WebKit-https.git
11 years ago2010-02-22 Huahui Wu <hwu@google.com>
eric@webkit.org [Tue, 23 Feb 2010 01:55:38 +0000 (01:55 +0000)]
2010-02-22  Huahui Wu  <hwu@google.com>

        Reviewed by Eric Seidel.

        Add code that enables SquirrelFish Extreme (a.k.a JSCX, JSC JIT)
        in Android. It's disabled by default, but is enabled when the
        enveronment variable ENABLE_JSC_JIT is set to true.
        https://bugs.webkit.org/show_bug.cgi?id=34855

        * Android.mk:
2010-02-22  Huahui Wu  <hwu@google.com>

        Reviewed by Eric Seidel.

        Add code that enables SquirrelFish Extreme (a.k.a JSCX, JSC JIT)
        in Android. It's disabled by default, but is enabled when the
        enveronment variable ENABLE_JSC_JIT is set to true.
        https://bugs.webkit.org/show_bug.cgi?id=34855

        * Android.mk:
        * wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-22 Stephan Aßmus <superstippi@gmx.de>
eric@webkit.org [Tue, 23 Feb 2010 01:29:08 +0000 (01:29 +0000)]
2010-02-22  Stephan Aßmus  <superstippi@gmx.de>

        Reviewed by Eric Seidel.

        Fix various issues in PlatformMouseEventHaiku.
        https://bugs.webkit.org/show_bug.cgi?id=34685

        Covered by existing tests.

        Mapping Haiku button constants (bit field) to WebCore buttons was broken.
        Extracting event time was broken (supposed to be in seconds).
        Wrong coordinate was being extracted, needs to be content local.
        Added extracting modifier key flags.

        * platform/haiku/PlatformMouseEventHaiku.cpp:
        (WebCore::PlatformMouseEvent::PlatformMouseEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-22 Stephan Aßmus <superstippi@gmx.de>
eric@webkit.org [Tue, 23 Feb 2010 01:12:51 +0000 (01:12 +0000)]
2010-02-22  Stephan Aßmus  <superstippi@gmx.de>

        Reviewed by Eric Seidel.

        [Haiku] Implement creating and filling platform gradients.
        https://bugs.webkit.org/show_bug.cgi?id=34683

        Covered by existing tests.

        * platform/graphics/Gradient.h:
            Typedef PlatformGradient to BGradient
        * platform/graphics/haiku/GradientHaiku.cpp:
        (WebCore::Gradient::platformDestroy):
            Delete the cached BGradient object.
        (WebCore::Gradient::platformGradient):
            Create a BGradient object according to the type of Gradient.
            Return the cached object.
        (WebCore::Gradient::fill):
            use BView API to fill with the platform gradient.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-22 Chris Evans <cevans@chromium.org>
tony@chromium.org [Tue, 23 Feb 2010 01:01:07 +0000 (01:01 +0000)]
2010-02-22  Chris Evans  <cevans@chromium.org>

        Reviewed by Darin Adler.

        Add test for https://bugs.webkit.org/show_bug.cgi?id=32842
        It has been fixed on trunk for a while, but we want to make sure we
        do not regress.

        * fast/text/find-layout-crash.html: Added.
        * fast/text/find-layout-crash-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-22 Stephan Aßmus <superstippi@gmx.de>
eric@webkit.org [Tue, 23 Feb 2010 00:55:34 +0000 (00:55 +0000)]
2010-02-22  Stephan Aßmus  <superstippi@gmx.de>

        Reviewed by Eric Seidel.

        Build fix for debug builds of GlyphPageTreeNode.cpp
        https://bugs.webkit.org/show_bug.cgi?id=34528

        Covered by existing tests.

        * platform/graphics/GlyphPageTreeNode.cpp:
            include <stdio.h> since printf() is used if NDEBUG is not defined.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebKit on Windows should pick up system setting changes without requiring explicit...
sfalken@apple.com [Tue, 23 Feb 2010 00:45:54 +0000 (00:45 +0000)]
WebKit on Windows should pick up system setting changes without requiring explicit API calls
https://bugs.webkit.org/show_bug.cgi?id=35269

Reviewed by Darin Adler.

* WebKit.vcproj/WebKit.def: Removed WebKitSystemParameterChanged.
* WebKit.vcproj/WebKit_debug.def: Removed WebKitSystemParameterChanged.
* WebKitGraphics.cpp: Removed WebKitSystemParameterChanged.
* WebKitGraphics.h: Removed WebKitSystemParameterChanged.
* WebView.cpp:
(systemParameterChanged): Call through to wkSystemFontSmoothingChanged for font changes.
(WebView::windowReceivedMessage): Pick up WM_SETTINGCHANGE from windowReceivedMessage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-22 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Tue, 23 Feb 2010 00:12:34 +0000 (00:12 +0000)]
2010-02-22  Nate Chapin  <japhet@chromium.org>

        Unreviewed, Chromium build fix.

        Add special case in CodeGeneratorV8.pm for named getters for html plugin-related elements.

        CodeGeneratorV8.pm was relying on HasOverridingNameGetter to hint
        that a custom named getter was needed. That hint was removed in
        http://trac.webkit.org/changeset/55104.

        * bindings/scripts/CodeGeneratorV8.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRubber-stamped by Alexey Proskuryakov.
ossy@webkit.org [Mon, 22 Feb 2010 23:28:18 +0000 (23:28 +0000)]
Rubber-stamped by Alexey Proskuryakov.

[Qt] fast/encoding/invalid-UTF-8-2.html fails
https://bugs.webkit.org/show_bug.cgi?id=35263

Qt Linux Release buildbot got the platform independent result for
fast/encoding/invalid-UTF-8-2.html instead of Qt specific one.

Qt specific expected file is removed to make buildbot green,
but it needs more investigation.

* platform/qt/fast/encoding/invalid-UTF-8-2-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Rubber-stamped by Geoff Garen.
ap@apple.com [Mon, 22 Feb 2010 23:27:02 +0000 (23:27 +0000)]
    Rubber-stamped by Geoff Garen.

        Rename RuntimeObjectImp to RuntimeObject.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAvoid recursion when trying to get the size of a PNG; it's unnecessary
pkasting@chromium.org [Mon, 22 Feb 2010 23:23:47 +0000 (23:23 +0000)]
Avoid recursion when trying to get the size of a PNG; it's unnecessary
and in the worst case can lead to heap corruption.
https://bugs.webkit.org/show_bug.cgi?id=35167

Reviewed by Eric Seidel.

WebCore:

Test: fast/images/bad-png.html

* platform/image-decoders/png/PNGImageDecoder.cpp:
(WebCore::PNGImageReader::decode):

LayoutTests:

* fast/images/bad-png-expected.txt: Added.
* fast/images/bad-png.html: Added.
* fast/images/resources/bad-png.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoDisable WebView docking to views that are too small.
beidson@apple.com [Mon, 22 Feb 2010 23:10:15 +0000 (23:10 +0000)]
Disable WebView docking to views that are too small.
<rdar://problem/7248409> and https://bugs.webkit.org/show_bug.cgi?id=35254

Reviewed by Tim Hatcher.

WebCore:

* WebCore.base.exp:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::canAttachWindow): Provide a utility for WebKits to make a showWindow()
  decision based on if attachment would be allowed or not.
(WebCore::InspectorController::attachWindow): Don't attach if the view is too small to attach to.
* inspector/InspectorController.h:

WebKit/mac:

* WebCoreSupport/WebInspectorClient.mm:
(-[WebInspectorWindowController showWindow:]): No matter the preference, don't open the inspector
  window attached if WebCore says it shouldn't be attached.

WebKit/win:

* WebCoreSupport/WebInspectorClient.cpp:
(WebInspectorClient::showWindowWithoutNotifications): No matter the preference, don't open the inspector
  window attached if WebCore says it shouldn't be attached.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55107 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Build fix.
ap@apple.com [Mon, 22 Feb 2010 22:32:51 +0000 (22:32 +0000)]
    Build fix.

        * WebCore.base.exp: Export Instance::newRuntimeObject, it's virtual!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Undo a small part of the previous commit.
ap@apple.com [Mon, 22 Feb 2010 22:25:41 +0000 (22:25 +0000)]
    Undo a small part of the previous commit.

        * bridge/runtime_method.cpp: (JSC::callRuntimeMethod): Let's keep the instance local
        variable as RefPtr for safety.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Darin Adler.
ap@apple.com [Mon, 22 Feb 2010 22:21:33 +0000 (22:21 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=35260
        Eliminate __apple_runtime_object

        No change in functionality, so no tests.

        * WebCore.base.exp: Don't export Instance::newRuntimeObject, WebKit doesn't need it.

        * bindings/js/JSHTMLAppletElementCustom.cpp:
        * bindings/js/JSHTMLEmbedElementCustom.cpp:
        * bindings/js/JSHTMLObjectElementCustom.cpp:
        * html/HTMLAppletElement.idl:
        * html/HTMLEmbedElement.idl:
        * html/HTMLObjectElement.idl:
        These objects no longer need overriding name getters, as they no longer intercept the
        __apple_runtime_object property.

        * bindings/js/JSPluginElementFunctions.cpp:
        (WebCore::pluginInstance): This is no longer static. It was used for callPlugin() in
        this file, and now it's also used elsewhere when calling plug-in methods.
        (WebCore::runtimeObjectGetter): Removed. This function was only used by the intercepting
        name getters.

        * bindings/js/JSPluginElementFunctions.h: Export pluginInstance().

        * bindings/objc/WebScriptObject.mm:
        (+[WebScriptObject _convertValueToObjcValue:originRootObject:rootObject:]):
        * bridge/runtime_method.cpp:
        (JSC::callRuntimeMethod):
        Take plug-in element's instance directly, without relying on fake attribute lookup.
        One change resulting from this is that RuntimeObjectImp may not be created in some cases -
        this code only needs an instance, but the old code had to pass the instance wrapped into
        RuntimeObjectImp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-22 Robert Hogan <robert@roberthogan.net>
ap@apple.com [Mon, 22 Feb 2010 22:17:29 +0000 (22:17 +0000)]
2010-02-22  Robert Hogan  <robert@roberthogan.net>

        Reviewed by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=32937
        LayoutTests/fast/encoding/invalid-UTF-8.html fails on Qt.

        The test was verifying two things: first, that U+FFFD is rendered by the browser, and second,
        that ill-formed UTF-8 sequences are turned into U+FFFD. Some aspects of the latter are not
        precisely defined by the Unicode specification, so different platforms may legitimately
        have different results.

        Split the test into two: one to test the rendering of invalid UTF-8 sequences, and the other
        to protect against regressions in each platform's decoding behaviour.

        * fast/encoding/invalid-UTF-8-2-expected.txt: Added.
        * fast/encoding/invalid-UTF-8-2.html: Added.
        * fast/encoding/invalid-UTF-8.html:
        * platform/mac/fast/encoding/invalid-UTF-8-expected.checksum:
        * platform/mac/fast/encoding/invalid-UTF-8-expected.png:
        * platform/mac/fast/encoding/invalid-UTF-8-expected.txt:
        * platform/qt/fast/encoding/invalid-UTF-8-2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBug 35186 - AX: AXFocused is not writable like it should be on nodes
cfleizach@apple.com [Mon, 22 Feb 2010 21:07:51 +0000 (21:07 +0000)]
Bug 35186 - AX: AXFocused is not writable like it should be on nodes
https://bugs.webkit.org/show_bug.cgi?id=35186

Fixing layout test failure.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agohttps://bugs.webkit.org/show_bug.cgi?id=35256
sullivan@apple.com [Mon, 22 Feb 2010 20:59:48 +0000 (20:59 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=35256
HTMLSelectElement::setSelectedIndexByUser() can trigger unnecessary JS when there is no change to the selected index

Reviewed by Tim Hatcher.

No new tests because this code path is not used for JS-initiated changes.

* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::setSelectedIndexByUser):
Bail out if the to-be-selected index matches the already-selected index.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-22 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Mon, 22 Feb 2010 20:51:25 +0000 (20:51 +0000)]
2010-02-22  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by John Sullivan.

        <rdar://problem/7285392>
        On Leopard, we have to disable hardware acceleration if we detect that the
        installed Core Video framework has bug <rdar://problem/7228836>.

        * WebView/WebView.mm:
        (coreVideoHas7228836Fix):
        (-[WebView _preferencesChangedNotification:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoReproducible crash in WebCore::nextLinePosition on Tweeteorites.com
enrica@apple.com [Mon, 22 Feb 2010 20:05:26 +0000 (20:05 +0000)]
Reproducible crash in WebCore::nextLinePosition on Tweeteorites.com
<rdar://problem/7615758>
https://bugs.webkit.org/show_bug.cgi?id=35060

Reviewed by Dan Bernstein.

WebCore:

Test: editing/selection/extend-byline-withfloat.html

* editing/visible_units.cpp:
(WebCore::previousLinePosition): Skip elements with zero height.
(WebCore::nextLinePosition): Skip elements with zero height.

LayoutTests:

* editing/selection/extend-byline-withfloat-expected.txt: Added.
* editing/selection/extend-byline-withfloat.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-22 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Mon, 22 Feb 2010 20:03:17 +0000 (20:03 +0000)]
2010-02-22  Nate Chapin  <japhet@chromium.org>

        Unreviewed, Chromium build fix.

        * bindings/scripts/CodeGeneratorV8.pm: Compile break due to bad patch merge.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-22 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Mon, 22 Feb 2010 19:53:59 +0000 (19:53 +0000)]
2010-02-22  Nate Chapin  <japhet@chromium.org>

        Reviewed by Dimitri Glazkov.

        [V8] Streamline V8 event listener code. Merge all the variants of
        V8DOMWrapper::getEventListner() into a single version and generate
        addEventListener() and removeEventListener() bindings for all objects
        except DOMWindow.

        https://bugs.webkit.org/show_bug.cgi?id=35245

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAX: AXFocused is not writable like it should be on nodes
cfleizach@apple.com [Mon, 22 Feb 2010 19:29:24 +0000 (19:29 +0000)]
AX: AXFocused is not writable like it should be on nodes
https://bugs.webkit.org/show_bug.cgi?id=35186

Reviewed by Beth Dakin.

WebCore:

Test: platform/mac/accessibility/element-focus.html

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::canSetFocusAttribute):

LayoutTests:

* platform/mac/accessibility/element-focus-expected.txt: Added.
* platform/mac/accessibility/element-focus.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-22 Laszlo Gombos <laszlo.1.gombos@nokia.com>
laszlo.1.gombos@nokia.com [Mon, 22 Feb 2010 19:24:12 +0000 (19:24 +0000)]
2010-02-22  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Unreviewed Symbian build fix.

        [Qt] Updated the def file with new exports to enable
        building DumpRenderTree.

        * symbian/eabi/QtWebKitu.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoJSStringBuilder should not CRASH if allocation fails, it should throw a JSException.
barraclough@apple.com [Mon, 22 Feb 2010 19:12:01 +0000 (19:12 +0000)]
JSStringBuilder should not CRASH if allocation fails, it should throw a JSException.

Reviewed by Oliver Hunt.

* runtime/JSGlobalObjectFunctions.cpp:
* runtime/JSStringBuilder.h:
(JSC::JSStringBuilder::JSStringBuilder):
(JSC::JSStringBuilder::append):
(JSC::JSStringBuilder::build):
* runtime/StringBuilder.h:
(JSC::StringBuilder::build):
* wtf/Vector.h:
(WTF::VectorBufferBase::tryAllocateBuffer):
(WTF::):
(WTF::VectorBuffer::tryAllocateBuffer):
(WTF::::tryExpandCapacity):
(WTF::::tryReserveCapacity):
(WTF::::tryAppend):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-22 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Mon, 22 Feb 2010 19:07:29 +0000 (19:07 +0000)]
2010-02-22  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        Bump library versioning for 1.1.22 release.

        * configure.ac:

WebKit/gtk:

2010-02-22  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        Update for release.

        * NEWS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-22 Kwang Yul Seo <skyul@company100.net>
eric@webkit.org [Mon, 22 Feb 2010 19:02:50 +0000 (19:02 +0000)]
2010-02-22  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Eric Seidel.

        [BREWMP] Map FastMalloc to BREW memory allocator
        https://bugs.webkit.org/show_bug.cgi?id=33570

        Use MALLOC macro instead of the standard malloc function.
        Although RVCT provides malloc, we can't use it in BREW
        because the loader does not initialize the base address properly.

        * wtf/FastMalloc.cpp:
        * wtf/brew/SystemMallocBrew.h: Added.
        (mallocBrew):
        (callocBrew):
        (freeBrew):
        (reallocBrew):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-22 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Mon, 22 Feb 2010 18:48:26 +0000 (18:48 +0000)]
2010-02-22  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein, Darin Adler.

        Remove addScrolledContentOffset/subtractScrolledContentOffset
        https://bugs.webkit.org/show_bug.cgi?id=35225

        Remove RenderLayer's addScrolledContentOffset() and subtractScrolledContentOffset()
        methods, and instead use the existing scrolledContentOffset(), and use
        IntSize and IntPoint instead of lots of x, y variables.

        Added new IntPoint toPoint(const IntSize&) method as a convenience to convert a size to a point,
        which is needed in a few places.

        * page/EventHandler.cpp:
        (WebCore::EventHandler::handleDrag): Use the new toPoint() convenience.
        * platform/graphics/IntPoint.h:
        (WebCore::toPoint): New convenience method to convert an IntSize to an IntPoint.
        * rendering/LayoutState.cpp:
        (WebCore::LayoutState::LayoutState):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::layoutBlock):
        (WebCore::RenderBlock::paintObject):
        (WebCore::RenderBlock::selectionGapRectsForRepaint):
        (WebCore::RenderBlock::nodeAtPoint):
        (WebCore::RenderBlock::offsetForContents):
        * rendering/RenderBoxModelObject.cpp:
        (WebCore::RenderBoxModelObject::paintFillLayerExtended):
        * rendering/RenderInline.cpp:
        (WebCore::RenderInline::clippedOverflowRectForRepaint):
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::updateLayerPosition):
        * rendering/RenderLayer.h:
        (WebCore::RenderLayer::size):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::computeRectForRepaint):
        * rendering/TextControlInnerElements.cpp:
        (WebCore::RenderTextControlInnerBlock::positionForPoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55090 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-02-22 Adam Langley <agl@google.com>
agl@chromium.org [Mon, 22 Feb 2010 18:36:50 +0000 (18:36 +0000)]
2009-02-22  Adam Langley  <agl@google.com>

        Reviewed by Darin Fisher.

        fontconfig on Linux can change the render preferences on a per strike
        basis (a strike a combination of face and size). Because of this, we
        need to query fontconfig each time a new FontPlatformData is created
        for a new size.

        This patch adds support for querying this via ChromiumBridge.

        https://bugs.webkit.org/show_bug.cgi?id=33065

        * platform/chromium/ChromiumBridge.h: add getRenderStyleForStrike
        * platform/graphics/chromium/FontCacheLinux.cpp:
        (WebCore::FontCache::createFontPlatformData):
        * platform/graphics/chromium/FontCustomPlatformData.cpp:
        (WebCore::FontCustomPlatformData::fontPlatformData):
        * platform/graphics/chromium/FontPlatformDataLinux.cpp:
        (WebCore::FontPlatformData::FontPlatformData):
        (WebCore::FontPlatformData::operator=):
        (WebCore::FontPlatformData::setupPaint):
        (WebCore::FontPlatformData::queryStyle):
          add code to query fontconfig via ChromiumBridge
        * platform/graphics/chromium/FontPlatformDataLinux.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBuild fix for make distcheck.
kov@webkit.org [Mon, 22 Feb 2010 18:11:55 +0000 (18:11 +0000)]
Build fix for make distcheck.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-22 Laszlo Gombos <laszlo.1.gombos@nokia.com>
eric@webkit.org [Mon, 22 Feb 2010 17:25:35 +0000 (17:25 +0000)]
2010-02-22  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        Fix compiler warning "suggest parentheses around"
        https://bugs.webkit.org/show_bug.cgi?id=35197

        No new tests as there is no new functionality.

        * wml/WMLVariables.cpp:
        (WebCore::substituteVariableReferences):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore
kov@webkit.org [Mon, 22 Feb 2010 17:01:06 +0000 (17:01 +0000)]
WebCore

2010-02-22  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Xan Lopez.

        [Soup] loses information related to message flags when converting from/to Resource{Request,Response}
        https://bugs.webkit.org/show_bug.cgi?id=35093

        Store message flags in WebCore objects, and set them on the
        SoupMessage, when creating one from them.

        No behaviour change.

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::fillResponseFromMessage):
        * platform/network/soup/ResourceRequest.h:
        (WebCore::ResourceRequest::soupMessageFlags):
        (WebCore::ResourceRequest::setSoupMessageFlags):
        * platform/network/soup/ResourceRequestSoup.cpp:
        (WebCore::ResourceRequest::toSoupMessage):
        (WebCore::ResourceRequest::updateFromSoupMessage):
        * platform/network/soup/ResourceResponse.h:
        (WebCore::ResourceResponse::soupMessageFlags):
        (WebCore::ResourceResponse::setSoupMessageFlags):
        * platform/network/soup/ResourceResponseSoup.cpp:
        (WebCore::ResourceResponse::toSoupMessage):
        (WebCore::ResourceResponse::updateFromSoupMessage):

WebKit/gtk

2010-02-22  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Xan Lopez.

        [Soup] loses information related to message flags when converting from/to Resource{Request,Response}
        https://bugs.webkit.org/show_bug.cgi?id=35093

        Update the flags that are stored in the request, when the response
        is received.

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::dispatchDidReceiveResponse):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Build the DRT in debug on Mac OS X
vestbo@webkit.org [Mon, 22 Feb 2010 16:40:53 +0000 (16:40 +0000)]
[Qt] Build the DRT in debug on Mac OS X

Reviewed by Kenneth Rohde Christiansen.

* DumpRenderTree/qt/DumpRenderTree.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-22 Steve Block <steveblock@google.com>
eric@webkit.org [Mon, 22 Feb 2010 16:17:49 +0000 (16:17 +0000)]
2010-02-22  Steve Block  <steveblock@google.com>

        Reviewed by Nate Chapin.

        Shared worker types used in globalObjectPrototypeIsDOMWindow are not properly guarded
        https://bugs.webkit.org/show_bug.cgi?id=35238

        No new tests, build fix only.

        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::globalObjectPrototypeIsDOMWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55084 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-22 Laszlo Gombos <laszlo.1.gombos@nokia.com>
laszlo.1.gombos@nokia.com [Mon, 22 Feb 2010 15:16:36 +0000 (15:16 +0000)]
2010-02-22  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Unreviewed build fix.

        [Qt] Build fix for RVCT.

        Fix after r55024. The "-i" option is for perl not for the
        script.

        * DerivedSources.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-22 Laszlo Gombos <laszlo.1.gombos@nokia.com>
eric@webkit.org [Mon, 22 Feb 2010 15:12:33 +0000 (15:12 +0000)]
2010-02-22  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Add support for layout tests on Symbian
        https://bugs.webkit.org/show_bug.cgi?id=31589

        * WebKit.pro:
2010-02-22  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Add support for layout tests on Symbian
        https://bugs.webkit.org/show_bug.cgi?id=31589

        * DumpRenderTree/qt/DumpRenderTree.pro:
        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
        * DumpRenderTree/qt/main.cpp:
        (main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-22 Steve Block <steveblock@google.com>
eric@webkit.org [Mon, 22 Feb 2010 14:26:13 +0000 (14:26 +0000)]
2010-02-22  Steve Block  <steveblock@google.com>

        Reviewed by Simon Fraser.

        Simplifies calculation of the transform in RenderLayer::paintLayer
        https://bugs.webkit.org/show_bug.cgi?id=35101

        No new tests, optimization only.

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::paintLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-22 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
vestbo@webkit.org [Mon, 22 Feb 2010 14:21:25 +0000 (14:21 +0000)]
2010-02-22  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>

        Reviewed by Maciej Stachowiak.

        Don't reset the assignee back to default on component change

        https://bugs.webkit.org/show_bug.cgi?id=35236

        There's a risk of reseting a valid assignee for example when
        triaging a bug. All components in WebKit have the default
        assignee set to webkit-unassigned@webkit.org so this should
        not cause problems for people relying on this functionality.

        * template/en/custom/bug/edit.html.tmpl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Switching from Phonon to QtMultimedia Backend for Qt 4.7
vestbo@webkit.org [Mon, 22 Feb 2010 13:42:13 +0000 (13:42 +0000)]
[Qt] Switching from Phonon to QtMultimedia Backend for Qt 4.7

Patch by Nicholas Young <nicholas.young@nokia.com> on 2010-02-22
Reviewed by Tor Arne Vestbø.

https://bugs.webkit.org/show_bug.cgi?id=34631

No new tests. This patch only affects multimedia backend.

* WebCore.pro: Build depends on Qt version.
* css/mediaControlsQt.css: Updated media controls.
* platform/graphics/MediaPlayer.cpp: Different backend included depending on Qt version.
* platform/graphics/qt/MediaPlayerPrivateQt.cpp: Added new QtMultimedia Backend.
(WebCore::MediaPlayerPrivate::create):
(WebCore::MediaPlayerPrivate::registerMediaEngine):
(WebCore::MediaPlayerPrivate::getSupportedTypes):
(WebCore::MediaPlayerPrivate::supportsType):
(WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::~MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::hasVideo):
(WebCore::MediaPlayerPrivate::hasAudio):
(WebCore::MediaPlayerPrivate::load):
(WebCore::MediaPlayerPrivate::cancelLoad):
(WebCore::MediaPlayerPrivate::play):
(WebCore::MediaPlayerPrivate::pause):
(WebCore::MediaPlayerPrivate::paused):
(WebCore::MediaPlayerPrivate::seek):
(WebCore::MediaPlayerPrivate::seeking):
(WebCore::MediaPlayerPrivate::duration):
(WebCore::MediaPlayerPrivate::currentTime):
(WebCore::MediaPlayerPrivate::buffered):
(WebCore::MediaPlayerPrivate::maxTimeSeekable):
(WebCore::MediaPlayerPrivate::bytesLoaded):
(WebCore::MediaPlayerPrivate::totalBytes):
(WebCore::MediaPlayerPrivate::setRate):
(WebCore::MediaPlayerPrivate::setVolume):
(WebCore::MediaPlayerPrivate::supportsMuting):
(WebCore::MediaPlayerPrivate::setMuted):
(WebCore::MediaPlayerPrivate::networkState):
(WebCore::MediaPlayerPrivate::readyState):
(WebCore::MediaPlayerPrivate::setVisible):
(WebCore::MediaPlayerPrivate::mediaStatusChanged):
(WebCore::MediaPlayerPrivate::handleError):
(WebCore::MediaPlayerPrivate::stateChanged):
(WebCore::MediaPlayerPrivate::nativeSizeChanged):
(WebCore::MediaPlayerPrivate::queuedSeekTimeout):
(WebCore::MediaPlayerPrivate::seekTimeout):
(WebCore::MediaPlayerPrivate::positionChanged):
(WebCore::MediaPlayerPrivate::durationChanged):
(WebCore::MediaPlayerPrivate::volumeChanged):
(WebCore::MediaPlayerPrivate::mutedChanged):
(WebCore::MediaPlayerPrivate::updateStates):
(WebCore::MediaPlayerPrivate::setSize):
(WebCore::MediaPlayerPrivate::naturalSize):
(WebCore::MediaPlayerPrivate::paint):
(WebCore::MediaPlayerPrivate::repaint):
* platform/graphics/qt/MediaPlayerPrivateQt.h: Added new QtMultimedia Backend.
(WebCore::MediaPlayerPrivate::isAvailable):
(WebCore::MediaPlayerPrivate::supportsFullscreen):
* platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::mediaControlsBaselineOpacity): New method.
(WebCore::RenderThemeQt::paintMediaBackground): Background depends on baseline opacity.
(WebCore::RenderThemeQt::paintMediaMuteButton): Changed styling.
(WebCore::RenderThemeQt::paintMediaCurrentTime): Added current time display.
(WebCore::RenderThemeQt::formatMediaControlsCurrentTime): Added time formatting.
(WebCore::RenderThemeQt::formatMediaControlsRemainingTime): Added time formatting.
(WebCore::RenderThemeQt::paintMediaVolumeSliderTrack): Volume slider added.
(WebCore::RenderThemeQt::paintMediaVolumeSliderThumb): Volume slider added.
(WebCore::RenderThemeQt::paintMediaSliderTrack): Updated for QtMultimedia.
(WebCore::RenderThemeQt::paintMediaSliderThumb): Dropped an unnecessary check.
(WebCore::RenderThemeQt::adjustSliderThumbSize): Handle a missing case.
* platform/qt/RenderThemeQt.h: Reimplemented a few more methods.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-22 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Mon, 22 Feb 2010 13:02:47 +0000 (13:02 +0000)]
2010-02-22  Alexander Pavlov  <apavlov@chromium.org>

        Not reviewed: mac build fix

        * bindings/js/ScriptDebugServer.cpp:
        (WebCore::ScriptDebugServer::ScriptDebugServer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-22 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Mon, 22 Feb 2010 12:14:41 +0000 (12:14 +0000)]
2010-02-22  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: there should be a way to "deactivate" or "skip" all breakpoints while debugging.
        https://bugs.webkit.org/show_bug.cgi?id=33217

        WebCore:
        * English.lproj/localizedStrings.js:
        * bindings/js/ScriptDebugServer.cpp:
        (WebCore::ScriptDebugServer::ScriptDebugServer):
        (WebCore::ScriptDebugServer::hasBreakpoint):
        (WebCore::ScriptDebugServer::setBreakpointsActivated):
        * bindings/js/ScriptDebugServer.h:
        * bindings/v8/ScriptDebugServer.h:
        (WebCore::ScriptDebugServer::setBreakpointsActivated):
        * inspector/InspectorBackend.cpp:
        (WebCore::InspectorBackend::activateBreakpoints):
        (WebCore::InspectorBackend::deactivateBreakpoints):
        * inspector/InspectorBackend.h:
        * inspector/InspectorBackend.idl:
        * inspector/front-end/Images/deactivateBreakpointsButtonGlyph.png: Added.
        * inspector/front-end/Images/deactivateBreakpointsDisabledButtonGlyph.png: Added.
        * inspector/front-end/InspectorBackendStub.js:
        (.WebInspector.InspectorBackendStub.prototype.activateBreakpoints):
        (.WebInspector.InspectorBackendStub.prototype.deactivateBreakpoints):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel):
        (WebInspector.ScriptsPanel.prototype.get breakpointsActivated):
        (WebInspector.ScriptsPanel.prototype.addBreakpoint):
        (WebInspector.ScriptsPanel.prototype._stepOutClicked):
        (WebInspector.ScriptsPanel.prototype._toggleBreakpointsClicked):
        * inspector/front-end/inspector.css:
        * inspector/front-end/textViewer.css:

        WebKit/chromium:
        * src/js/DebuggerAgent.js:
        (devtools.DebuggerAgent):
        (devtools.DebuggerAgent.prototype.setBreakpointsActivated):
        (devtools.DebuggerAgent.prototype.handleBreakEvent_):
        (devtools.DebuggerAgent.prototype.handleExceptionEvent_):
        * src/js/InspectorControllerImpl.js:
        (devtools.InspectorBackendImpl.prototype.activateBreakpoints):
        (devtools.InspectorBackendImpl.prototype.deactivateBreakpoints):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoREGRESSION (r55039): Animation starts from near end when loaded over slow network
mrowe@apple.com [Mon, 22 Feb 2010 11:18:05 +0000 (11:18 +0000)]
REGRESSION (r55039): Animation starts from near end when loaded over slow network
<http://webkit.org/b/35222> / <rdar://problem/7673523>

Rubber-stamped by Sam Weinig and Maciej Stachowiak.

Roll out r55039 (related to <http://webkit.org/b/35115>) as it causes animated GIFs
to skip intermediate frames when loading over a slower network.

* platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::startAnimation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoNot reviewed, build fix.
mjs@apple.com [Mon, 22 Feb 2010 10:31:47 +0000 (10:31 +0000)]
Not reviewed, build fix.

Revert the previous change.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-21 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Mon, 22 Feb 2010 09:28:30 +0000 (09:28 +0000)]
2010-02-21  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Darin Adler.

        Cache JavaScript wrappers inline in DOM nodes
        https://bugs.webkit.org/show_bug.cgi?id=35226
        <rdar://problem/7664202>

        8.8% speedup on Dromaeo DOM Core tests.
        3.3% speedup on Hixie DOM Core tests.

        * bindings/js/JSDOMBinding.cpp:
        (WebCore::forgetDOMNode): Clear wrapper pointer.
        (WebCore::cacheDOMNodeWrapper): Cache inline too if caching for normal world.
        * bindings/js/JSDOMBinding.h:
        (WebCore::DOMObjectWrapperMapFor):
        * bindings/js/JSDocumentCustom.cpp:
        (WebCore::toJS): Remove unneeded argument from getCachedDOMNodeWrapper.
        * bindings/js/JSNodeCustom.cpp:
        (WebCore::createWrapperInline): Renamed version of original createWrapper.
        (WebCore::createWrapper): Call createWrapperInline. Out-of-line version.
        (WebCore::toJSNewlyCreated): Call createWrapperInline instead of createWrapper.
        * bindings/js/JSNodeCustom.h: Added.
        (WebCore::getCachedDOMNodeWrapper): Moved here so it can be inlined.
        (WebCore::toJS): Moved here so it can be inlined.
        * bindings/js/ScriptWrappable.h:
        (WebCore::ScriptWrappable::ScriptWrappable): Implement this in the obvious
        way for JavaScriptCore.
        (WebCore::ScriptWrappable::wrapper):
        (WebCore::ScriptWrappable::setWrapper):
        (WebCore::ScriptWrappable::clearWrapper):
        * bindings/scripts/CodeGeneratorJS.pm: Include CustomHeader heaaders
        in the header, not just the impl file, so they can add inlining.
        * dom/Node.idl: Add CustomHeader directive.

        Add new files to build.

        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-22 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 22 Feb 2010 09:13:58 +0000 (09:13 +0000)]
2010-02-22  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: windows build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoPart 2 of Windows build fix.
bweinstein@apple.com [Mon, 22 Feb 2010 08:08:03 +0000 (08:08 +0000)]
Part 2 of Windows build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-21 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 22 Feb 2010 07:59:29 +0000 (07:59 +0000)]
2010-02-21  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: stop on inline breakpoints on reload.
        - ScriptBreakpoint struct has been introduced and reused in InspectorController
          and debug server.
        - JavaScriptDebugServer was moved to bindings/js and renamed to ScriptDebugServer
          There were no changes to semantics, only some mechanical changes:
            - addBreakpoint and updateBreakpoint were merged into setBreakpoint
            - ScriptDebugServer now operates ScriptBreakpoint instances instead of
              BreakpointInfo.
            - It no longer allocates maps and breakpoint info in heap - all done on stack.
            - JavaScriptDebugListener is now ScriptDebugServer::Listener
            - Listener methods no longer have ExecState (was unused).
            - addListener/removeListener pair wuth no page argument removed (was unused).
        - InspectorController now binds sourceID to url and maintains a map of 'sticky'
          breakpoints. Whenever script is loaded and there is a sticky breakpoint url matching,
          breakpoint is being 'restored' synchronously in debug server and pushed to frontend.
          Front-end no longer stores map of sticky breakpoints.
            - setBreakpoint/removeBreakpoint/didParseSource trio handle this logic.
        - A bunch of if(USE_JSC/V8/other) forks removed.
        - InspectorFrontend now operates primitive types only, got rid of USE_JSC as well.

        https://bugs.webkit.org/show_bug.cgi?id=28799

        * GNUmakefile.am:
        * WebCore.base.exp:
        * WebCore.gypi:
        * WebCore.order:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSInjectedScriptHostCustom.cpp:
        (WebCore::JSInjectedScriptHost::currentCallFrame):
        (WebCore::JSInjectedScriptHost::isActivation):
        * bindings/js/ScriptDebugServer.cpp:
        (WebCore::ScriptDebugServer::shared):
        (WebCore::ScriptDebugServer::ScriptDebugServer):
        (WebCore::ScriptDebugServer::~ScriptDebugServer):
        (WebCore::ScriptDebugServer::addListener):
        (WebCore::ScriptDebugServer::removeListener):
        (WebCore::ScriptDebugServer::pageCreated):
        (WebCore::ScriptDebugServer::hasListenersInterestedInPage):
        (WebCore::ScriptDebugServer::setBreakpoint):
        (WebCore::ScriptDebugServer::removeBreakpoint):
        (WebCore::ScriptDebugServer::hasBreakpoint):
        (WebCore::ScriptDebugServer::clearBreakpoints):
        (WebCore::ScriptDebugServer::setPauseOnExceptionsState):
        (WebCore::ScriptDebugServer::pauseProgram):
        (WebCore::ScriptDebugServer::continueProgram):
        (WebCore::ScriptDebugServer::stepIntoStatement):
        (WebCore::ScriptDebugServer::stepOverStatement):
        (WebCore::ScriptDebugServer::stepOutOfFunction):
        (WebCore::ScriptDebugServer::currentCallFrame):
        (WebCore::ScriptDebugServer::currentCallFrameState):
        (WebCore::ScriptDebugServer::dispatchDidParseSource):
        (WebCore::ScriptDebugServer::dispatchFailedToParseSource):
        (WebCore::toPage):
        (WebCore::ScriptDebugServer::detach):
        (WebCore::ScriptDebugServer::sourceParsed):
        (WebCore::ScriptDebugServer::dispatchFunctionToListeners):
        (WebCore::ScriptDebugServer::setJavaScriptPaused):
        (WebCore::ScriptDebugServer::pauseIfNeeded):
        (WebCore::ScriptDebugServer::callEvent):
        (WebCore::ScriptDebugServer::atStatement):
        (WebCore::ScriptDebugServer::returnEvent):
        (WebCore::ScriptDebugServer::exception):
        (WebCore::ScriptDebugServer::willExecuteProgram):
        (WebCore::ScriptDebugServer::didExecuteProgram):
        (WebCore::ScriptDebugServer::didReachBreakpoint):
        (WebCore::ScriptDebugServer::recompileAllJSFunctionsSoon):
        (WebCore::ScriptDebugServer::recompileAllJSFunctions):
        (WebCore::ScriptDebugServer::didAddListener):
        (WebCore::ScriptDebugServer::didRemoveListener):
        (WebCore::ScriptDebugServer::didRemoveLastListener):
        * bindings/js/ScriptDebugServer.h:
        (WebCore::ScriptDebugServer::Listener::~Listener):
        (WebCore::ScriptDebugServer::):
        (WebCore::ScriptDebugServer::pauseOnExceptionsState):
        (WebCore::ScriptDebugServer::hasListeners):
        (WebCore::ScriptDebugServer::hasGlobalListeners):
        * bindings/v8/ScriptDebugServer.cpp:
        (WebCore::ScriptDebugServer::shared):
        * bindings/v8/ScriptDebugServer.h:
        (WebCore::ScriptDebugServer::Listener::~Listener):
        (WebCore::ScriptDebugServer::addListener):
        (WebCore::ScriptDebugServer::removeListener):
        (WebCore::ScriptDebugServer::setBreakpoint):
        (WebCore::ScriptDebugServer::removeBreakpoint):
        (WebCore::ScriptDebugServer::clearBreakpoints):
        (WebCore::ScriptDebugServer::):
        (WebCore::ScriptDebugServer::pauseOnExceptionsState):
        (WebCore::ScriptDebugServer::setPauseOnExceptionsState):
        (WebCore::ScriptDebugServer::pauseProgram):
        (WebCore::ScriptDebugServer::continueProgram):
        (WebCore::ScriptDebugServer::stepIntoStatement):
        (WebCore::ScriptDebugServer::stepOverStatement):
        (WebCore::ScriptDebugServer::stepOutOfFunction):
        (WebCore::ScriptDebugServer::recompileAllJSFunctionsSoon):
        (WebCore::ScriptDebugServer::recompileAllJSFunctions):
        (WebCore::ScriptDebugServer::currentCallFrameState):
        (WebCore::ScriptDebugServer::pageCreated):
        (WebCore::ScriptDebugServer::ScriptDebugServer):
        (WebCore::ScriptDebugServer::~ScriptDebugServer):
        * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
        (WebCore::V8InjectedScriptHost::currentCallFrameCallback):
        (WebCore::V8InjectedScriptHost::isActivationCallback):
        * inspector/InjectedScriptHost.cpp:
        * inspector/InjectedScriptHost.h:
        * inspector/InjectedScriptHost.idl:
        * inspector/InspectorBackend.cpp:
        (WebCore::InspectorBackend::setBreakpoint):
        (WebCore::InspectorBackend::removeBreakpoint):
        (WebCore::InspectorBackend::pauseInDebugger):
        (WebCore::InspectorBackend::stepOverStatementInDebugger):
        (WebCore::InspectorBackend::stepIntoStatementInDebugger):
        (WebCore::InspectorBackend::stepOutOfFunctionInDebugger):
        (WebCore::InspectorBackend::pauseOnExceptionsState):
        (WebCore::InspectorBackend::setPauseOnExceptionsState):
        * inspector/InspectorBackend.h:
        * inspector/InspectorBackend.idl:
        * inspector/ScriptBreakpoint.h: Added.
        (WebCore::InspectorBreakpoint::InspectorBreakpoint):
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::InspectorController):
        (WebCore::InspectorController::setWindowVisible):
        (WebCore::InspectorController::scriptObjectReady):
        (WebCore::InspectorController::close):
        (WebCore::InspectorController::didCommitLoad):
        (WebCore::InspectorController::addProfile):
        (WebCore::InspectorController::startUserInitiatedProfiling):
        (WebCore::InspectorController::stopUserInitiatedProfiling):
        (WebCore::InspectorController::enableProfiler):
        (WebCore::InspectorController::disableProfiler):
        (WebCore::InspectorController::enableDebuggerFromFrontend):
        (WebCore::InspectorController::disableDebugger):
        (WebCore::InspectorController::resumeDebugger):
        (WebCore::InspectorController::setBreakpoint):
        (WebCore::InspectorController::removeBreakpoint):
        (WebCore::InspectorController::didParseSource):
        (WebCore::InspectorController::failedToParseSource):
        (WebCore::InspectorController::didPause):
        * inspector/InspectorController.h:
        * inspector/InspectorFrontend.cpp:
        (WebCore::InspectorFrontend::parsedScriptSource):
        (WebCore::InspectorFrontend::restoredBreakpoint):
        (WebCore::InspectorFrontend::failedToParseScriptSource):
        (WebCore::InspectorFrontend::resumedScript):
        * inspector/InspectorFrontend.h:
        * inspector/JavaScriptDebugListener.h: Removed.
        * inspector/JavaScriptDebugServer.cpp: Removed.
        * inspector/JavaScriptDebugServer.h: Removed.
        * inspector/front-end/Breakpoint.js:
        (WebInspector.Breakpoint.prototype.set condition):
        * inspector/front-end/BreakpointsSidebarPane.js:
        (WebInspector.BreakpointsSidebarPane.prototype.addBreakpoint):
        (WebInspector.BreakpointsSidebarPane.prototype._breakpointEnableChanged):
        * inspector/front-end/InspectorBackendStub.js:
        (.WebInspector.InspectorBackendStub.prototype.addBreakpoint):
        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.ResourcesPanel.prototype.sourceFrameForResource):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel):
        (WebInspector.ScriptsPanel.prototype.addScript):
        (WebInspector.ScriptsPanel.prototype.addBreakpoint):
        (WebInspector.ScriptsPanel.prototype.removeBreakpoint):
        (WebInspector.ScriptsPanel.prototype._showScriptOrResource):
        * inspector/front-end/inspector.js:
        (WebInspector.restoredBreakpoint):
        * page/Page.cpp:
        (WebCore::Page::Page):
        * platform/android/TemporaryLinkStubs.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoPart 1 of Windows build fix.
bweinstein@apple.com [Mon, 22 Feb 2010 07:56:15 +0000 (07:56 +0000)]
Part 1 of Windows build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoJavaScriptCore: Make UString::m_data be const, and make the UChar owned/ref-counted...
barraclough@apple.com [Mon, 22 Feb 2010 06:50:44 +0000 (06:50 +0000)]
JavaScriptCore: Make UString::m_data be const, and make the UChar owned/ref-counted by CrossThreadRefCounted be const too.

Reviewed by Oliver Hunt.

* runtime/UStringImpl.cpp:
(JSC::UStringImpl::baseSharedBuffer):
(JSC::UStringImpl::~UStringImpl):
* runtime/UStringImpl.h:
(JSC::UStringImpl::create):
(JSC::UStringImpl::data):
(JSC::UStringImpl::UStringImpl):
* wtf/OwnFastMallocPtr.h:
(WTF::OwnFastMallocPtr::~OwnFastMallocPtr):

WebCore: Make the UChar owned/ref-counted by StringImpl::CrossThreadRefCounted be const.

Reviewed by Oliver Hunt.

* platform/text/StringImpl.cpp:
(WebCore::StringImpl::sharedBuffer):
* platform/text/StringImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-21 Yuta Kitamura <yutak@chromium.org>
eric@webkit.org [Mon, 22 Feb 2010 06:12:52 +0000 (06:12 +0000)]
2010-02-21  Yuta Kitamura  <yutak@chromium.org>

        Reviewed by Darin Adler.

        HashMapTranslatorAdapter::translate() needs to set the mapped value.

        HTTPHeaderMap::add(const char*, const String&) does not work
        https://bugs.webkit.org/show_bug.cgi?id=35227

        * wtf/HashMap.h:
        (WTF::HashMapTranslatorAdapter::translate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-07 Yuzo Fujishima <yuzo@google.com>
yuzo@google.com [Mon, 22 Feb 2010 04:12:46 +0000 (04:12 +0000)]
2010-02-07  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by Eric Seidel.

        When page-break-{after,before} is set to always, force page breaks even for overflow-specified elements.
        RenderBlock::inRootBlockContext() was introduced by Changeset 5611. Although it is a reasonable criteria for choosing an optional page break location, it is not for a mandatory page break as specified by http://dev.w3.org/csswg/css3-page/#forced-pg-brk. The method is removed because it is not used anywhere else.
        Note: this patch makes page break work for overflow-specified elements. For tables and floated elements, more work is needed.
        https://bugs.webkit.org/show_bug.cgi?id=9526

        * printing/page-break-always-for-overflow-expected.txt: Added.
        * printing/page-break-always-for-overflow.html: Added.
        * printing/script-tests/page-break-always-for-overflow.js: Added.
2010-02-07  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by Eric Seidel.

        When page-break-{after,before} is set to always, force page breaks even for overflow-specified elements.
        RenderBlock::inRootBlockContext() was introduced by Changeset 5611. Although it is a reasonable criteria for choosing an optional page break location, it is not for a mandatory page break as specified by http://dev.w3.org/csswg/css3-page/#forced-pg-brk. The method is removed because it is not used anywhere else.
        Note: this patch makes page break work for overflow-specified elements. For tables and floated elements, more work is needed.
        https://bugs.webkit.org/show_bug.cgi?id=9526

        Test: printing/page-break-always-for-overflow.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::paintChildren):
        * rendering/RenderBlock.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRemove auto_ptr usage in WebCore.
jchaffraix@webkit.org [Sun, 21 Feb 2010 23:40:46 +0000 (23:40 +0000)]
Remove auto_ptr usage in WebCore.
https://bugs.webkit.org/show_bug.cgi?id=35157

Reviewed by Eric Seidel.

The changes consists of:

- Changing auto_ptr arguments or return types to PassOwnPtr.

- Replacing local auto_ptr by OwnPtr.

- Removing now unneeded <memory> inclusion.

* css/CSSParser.cpp:
(WebCore::CSSParser::addProperty):
* loader/WorkerThreadableLoader.cpp:
(WebCore::WorkerThreadableLoader::MainThreadBridge::mainThreadCreateLoader):
(WebCore::workerContextDidReceiveResponse):
(WebCore::workerContextDidReceiveData):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveData):
(WebCore::workerContextDidReceiveAuthenticationCancellation):
* loader/WorkerThreadableLoader.h:
* loader/icon/IconLoader.cpp:
(WebCore::IconLoader::create):
* loader/icon/IconLoader.h:
* platform/ContextMenu.cpp:
(WebCore::separatorItem):
* platform/CrossThreadCopier.h:
(WebCore::):
* platform/network/HTTPHeaderMap.cpp:
(WebCore::HTTPHeaderMap::copyData):
(WebCore::HTTPHeaderMap::adopt):
* platform/network/HTTPHeaderMap.h:
* platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::adopt):
(WebCore::ResourceRequestBase::copyData):
* platform/network/ResourceRequestBase.h:
* platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::adopt):
(WebCore::ResourceResponseBase::copyData):
* platform/network/ResourceResponseBase.h:
* svg/SVGDocumentExtensions.cpp:
(WebCore::SVGDocumentExtensions::removePendingResource):
* svg/SVGDocumentExtensions.h:
* svg/SVGElement.cpp:
(WebCore::SVGElement::insertedIntoDocument):
* workers/GenericWorkerTask.h:
* workers/WorkerThread.cpp:
(WebCore::WorkerThreadStartupData::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-21 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Sun, 21 Feb 2010 21:47:07 +0000 (21:47 +0000)]
2010-02-21  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        https://bugs.webkit.org/show_bug.cgi?id=22215
        Avoid calling absoluteClippedOverflowRect() so many times

        RenderLayer::updateLayerPositions() computes the clipped overflow rect
        and the outline bounds for repaint, and then calls repaintAfterLayoutIfNeeded()
        which can compute the same rects all over again. Avoid this by passing
        these two rects into repaintAfterLayoutIfNeeded() if known. This measurably
        reduces the time spent in updateLayerPositions() for some content.

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::updateLayerPositions):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::repaintAfterLayoutIfNeeded):
        * rendering/RenderObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFalse warnings about needing layout in
mitz@apple.com [Sun, 21 Feb 2010 21:19:02 +0000 (21:19 +0000)]
False warnings about needing layout in
-[WebHTMLView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]
https://bugs.webkit.org/show_bug.cgi?id=35218

Reviewed by Darin Adler.

* WebView/WebHTMLView.mm:
(-[WebHTMLView _recursiveDisplayRectIfNeededIgnoringOpacity:isVisibleRect:rectIsVisibleRectForView:topView:]):
Suppress the warning and the forced layout if the view is not being drawn
in this display operation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Sam Weinig.
kdecker@apple.com [Sun, 21 Feb 2010 20:20:41 +0000 (20:20 +0000)]
    Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=35215
        <rdar://problem/7673157>

        The plugInViewWithArguments: API passes a dictionary of plugin arguments. One of the parameters
        is WebPlugInBaseURLKey, which is a key that represents the base URL of the document containing
        the plug-in's view. Instead of sending the base URL, code in  WebFrameLoaderClient::createPlugin
        would incorrectly pass the source URL of the plug-in resource.

        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::createPlugin): When building the plug-in arguments dictionary, pass the
        real base URL for the WebPlugInBaseURLKey key.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-20 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Sun, 21 Feb 2010 11:32:53 +0000 (11:32 +0000)]
2010-02-20  Maciej Stachowiak  <mjs@apple.com>

        Rubber stamped by Adam Barth.

        Add sunspider-0.9.1 to the site in preparation for announcing it.
        https://bugs.webkit.org/show_bug.cgi?id=35206

        * perf/sunspider-0.9.1: Added.
        * perf/sunspider-0.9.1/json2.js: Added.
        * perf/sunspider-0.9.1/sunspider-0.9: Added.
        * perf/sunspider-0.9.1/sunspider-0.9.1: Added.
        * perf/sunspider-0.9.1/sunspider-0.9.1/driver.html: Added.
        * perf/sunspider-0.9.1/sunspider-0.9.1/results.html: Added.
        * perf/sunspider-0.9.1/sunspider-0.9.1/sunspider-test-contents.js: Added.
        * perf/sunspider-0.9.1/sunspider-0.9.1/sunspider-test-prefix.js: Added.
        * perf/sunspider-0.9.1/sunspider-0.9/driver.html: Added.
        * perf/sunspider-0.9.1/sunspider-0.9/results.html: Added.
        * perf/sunspider-0.9.1/sunspider-0.9/sunspider-test-contents.js: Added.
        * perf/sunspider-0.9.1/sunspider-0.9/sunspider-test-prefix.js: Added.
        * perf/sunspider-0.9.1/sunspider-analyze-results.js: Added.
        * perf/sunspider-0.9.1/sunspider-compare-results.js: Added.
        * perf/sunspider-0.9.1/sunspider.css: Added.
        * perf/sunspider-0.9.1/sunspider.html: Added.
        * perf/sunspider-0.9.1/versions.html: Added.
2010-02-20  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Adam Barth.

        Add sunspider-0.9.1 to the site in preparation for announcing it.
        https://bugs.webkit.org/show_bug.cgi?id=35206

        * hosted/sunspider.css: Remove tabs, which I noticed where present while
        copying to the WebKitSite directory.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Maciej Stachowiak.
ap@apple.com [Sun, 21 Feb 2010 06:01:26 +0000 (06:01 +0000)]
    Reviewed by Maciej Stachowiak.

        https://bugs.webkit.org/show_bug.cgi?id=35202
        <rdar://problem/4856597> Calling Java method which accepts Object always passes a null argument

        * bridge/jni/jsc/JNIUtilityPrivate.cpp: (JSC::Bindings::convertValueToJValue): Add cases for
        other JS types.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-20 Laszlo Gombos <laszlo.1.gombos@nokia.com>
eric@webkit.org [Sun, 21 Feb 2010 05:22:43 +0000 (05:22 +0000)]
2010-02-20  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Darin Adler.

        Fix compiler warning "suggest parentheses around"
        https://bugs.webkit.org/show_bug.cgi?id=35197

        No new tests as there is no new functionality.

        * html/DateComponents.cpp:
        (WebCore::beforeGregorianStartDate):
        * plugins/PluginDatabase.cpp:
        (WebCore::PluginDatabase::findPlugin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoMoved simplejson into webkitpy/thirdparty directory.
cjerdonek@webkit.org [Sat, 20 Feb 2010 20:44:13 +0000 (20:44 +0000)]
Moved simplejson into webkitpy/thirdparty directory.

Reviewed by Adam Barth.

https://bugs.webkit.org/show_bug.cgi?id=35196

* Scripts/run-chromium-webkit-tests:
  - Added webkitpy/thirdparty to the script's search path.

* Scripts/webkitpy/thirdparty/simplejson: Copied from WebKitTools/simplejson.
  - Copied simplejson directory.

* simplejson: Removed.
* simplejson/LICENSE.txt: Removed.
* simplejson/README.txt: Removed.
* simplejson/__init__.py: Removed.
* simplejson/_speedups.c: Removed.
* simplejson/decoder.py: Removed.
* simplejson/encoder.py: Removed.
* simplejson/jsonfilter.py: Removed.
* simplejson/scanner.py: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-20 Noam Rosenthal <noam.rosenthal@nokia.com>
laszlo.1.gombos@nokia.com [Sat, 20 Feb 2010 20:24:03 +0000 (20:24 +0000)]
2010-02-20  Noam Rosenthal  <noam.rosenthal@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] ENABLE_3D_RENDERING should be optional
        https://bugs.webkit.org/show_bug.cgi?id=35100

        * WebKit.pri: ENABLE_3D_RENDERING moved to a proper feature test

2010-02-20  Noam Rosenthal  <noam.rosenthal@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] ENABLE_3D_RENDERING should be optional
        https://bugs.webkit.org/show_bug.cgi?id=35100

        No new tests: this is a build fix.

        * WebCore.pri: ENABLE_3D_RENDERING is now a proper feature test

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55056 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-20 Chris Jerdonek <cjerdonek@webkit.org>
cjerdonek@webkit.org [Sat, 20 Feb 2010 19:36:04 +0000 (19:36 +0000)]
2010-02-20  Chris Jerdonek  <cjerdonek@webkit.org>

        Reviewed by Adam Barth.

        Moved BeautifulSoup to webkitpy/thirdparty directory.

        https://bugs.webkit.org/show_bug.cgi?id=35195

        * Scripts/webkitpy/BeautifulSoup.py: Removed.
          - Moved to webkitpy/thirdparty.

        * Scripts/webkitpy/bugzilla.py:
          - Updated import statement.

        * Scripts/webkitpy/bugzilla_unittest.py:
          - Updated import statement.

        * Scripts/webkitpy/buildbot.py:
          - Updated import statement.

        * Scripts/webkitpy/buildbot_unittest.py:
          - Updated import statement.

        * Scripts/webkitpy/statusserver.py:
          - Updated import statement.

        * Scripts/webkitpy/thirdparty/BeautifulSoup.py: Copied from WebKitTools/Scripts/webkitpy/BeautifulSoup.py.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Maciej Stachowiak.
ap@apple.com [Sat, 20 Feb 2010 18:22:48 +0000 (18:22 +0000)]
    Reviewed by Maciej Stachowiak.

        https://bugs.webkit.org/show_bug.cgi?id=23742
        Applet methods can not return arrays to JS

        * bridge/jni/jsc/JNIBridgeJSC.cpp: (JavaArray::JavaArray): Don't accidentally zero out
        m_rootObject (that's how PassRefPtr works). Without m_rootObject, we crash quickly.

        * bridge/jni/jsc/JavaInstanceJSC.cpp: (JavaInstance::invokeMethod): Do handle returned arrays.
        Also, added an ifdef around  code that's only needed on Tiger, and removed a comment saying
        it can be removed when "new" plugin ships. I doubt that anyone can remember what "new"
        could refer to back then.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55054 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-20 Chris Jerdonek <cjerdonek@webkit.org>
cjerdonek@webkit.org [Sat, 20 Feb 2010 17:42:46 +0000 (17:42 +0000)]
2010-02-20  Chris Jerdonek  <cjerdonek@webkit.org>

        Reviewed by Adam Barth.

        Created a directory for third-party Python code, and moved
        autoinstall.py into it.

        https://bugs.webkit.org/show_bug.cgi?id=34540

        * Scripts/webkitpy/__init__.py:
          - Updated "import autoinstall" statement.

        * Scripts/webkitpy/autoinstall.py: Removed.
          - Moved to thirdparty/autoinstall.py.

        * Scripts/webkitpy/thirdparty: Added.
        * Scripts/webkitpy/thirdparty/__init__.py: Added.
        * Scripts/webkitpy/thirdparty/autoinstall.py: Copied from WebKitTools/Scripts/webkitpy/autoinstall.py.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55053 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-20 Pavel Feldman <pfeldman@chromium.org>
eric@webkit.org [Sat, 20 Feb 2010 15:40:03 +0000 (15:40 +0000)]
2010-02-20  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: re-creating view in ResourcesPanel confuses ScriptsPanel's visibleView logic.

        https://bugs.webkit.org/show_bug.cgi?id=35192

        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.ResourcesPanel.prototype.recreateViewForResourceIfNeeded):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype.show):
        (WebInspector.ScriptsPanel.prototype.viewRecreated):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-20 Pavel Feldman <pfeldman@chromium.org>
eric@webkit.org [Sat, 20 Feb 2010 15:23:44 +0000 (15:23 +0000)]
2010-02-20  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: need to highlight the evaluated expression used for popovers.

        https://bugs.webkit.org/show_bug.cgi?id=35126

        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype._mouseMove):
        (WebInspector.SourceFrame.prototype._hidePopup):
        (WebInspector.SourceFrame.prototype._mouseHover):
        (WebInspector.SourceFrame.prototype._showPopup.showObjectPopup):
        (WebInspector.SourceFrame.prototype._showPopup):
        * inspector/front-end/inspector.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55051 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRoll out 55047, since it causes regressions in layout and API tests.
kov@webkit.org [Sat, 20 Feb 2010 14:29:17 +0000 (14:29 +0000)]
Roll out 55047, since it causes regressions in layout and API tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55050 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed, obvious fix for the python failure in our new buildbot step:
kov@webkit.org [Sat, 20 Feb 2010 14:29:01 +0000 (14:29 +0000)]
Unreviewed, obvious fix for the python failure in our new buildbot step:

  http://build.webkit.org/builders/GTK Linux 32-bit Release/builds/9075/steps/API tests/logs/err.text

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55049 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-20 Gustavo Noronha Silva <gns@gnome.org>
kov@webkit.org [Sat, 20 Feb 2010 14:13:45 +0000 (14:13 +0000)]
2010-02-20  Gustavo Noronha Silva  <gns@gnome.org>

        Unreviewed. Trivial fix - unnecessary variable got added by
        mistake.

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::dispatchDidReceiveResponse):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore
kov@webkit.org [Sat, 20 Feb 2010 12:35:35 +0000 (12:35 +0000)]
WebCore

2010-02-19  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Xan Lopez.

        [Soup] loses information related to message flags when converting from/to Resource{Request,Response}
        https://bugs.webkit.org/show_bug.cgi?id=35093

        Store message flags in WebCore objects, and set them on the
        SoupMessage, when creating one from them.

        No behaviour change.

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::fillResponseFromMessage):
        * platform/network/soup/ResourceRequest.h:
        (WebCore::ResourceRequest::soupMessageFlags):
        (WebCore::ResourceRequest::setSoupMessageFlags):
        * platform/network/soup/ResourceRequestSoup.cpp:
        (WebCore::ResourceRequest::toSoupMessage):
        (WebCore::ResourceRequest::updateFromSoupMessage):
        * platform/network/soup/ResourceResponse.h:
        (WebCore::ResourceResponse::soupMessageFlags):
        (WebCore::ResourceResponse::setSoupMessageFlags):
        * platform/network/soup/ResourceResponseSoup.cpp:
        (WebCore::ResourceResponse::toSoupMessage):
        (WebCore::ResourceResponse::updateFromSoupMessage):

WebKit/gtk

2010-02-18  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Xan Lopez.

        [Soup] loses information related to message flags when converting from/to Resource{Request,Response}
        https://bugs.webkit.org/show_bug.cgi?id=35093

        Update the flags that are stored in the request, when the response
        is received.

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::dispatchDidReceiveResponse):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-19 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Sat, 20 Feb 2010 12:25:17 +0000 (12:25 +0000)]
2010-02-19  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Xan Lopez.

        [Soup] loses information related to message flags when converting from/to Resource{Request,Response}
        https://bugs.webkit.org/show_bug.cgi?id=35093

        Refactor updating of ResourceResponse objects from soup message
        objects, to avoid code duplication.

        No behaviour change.

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::fillResponseFromMessage):
        * platform/network/soup/ResourceResponseSoup.cpp:
        (WebCore::ResourceResponse::updateFromSoupMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Maciej Stachowiak.
ap@apple.com [Sat, 20 Feb 2010 09:33:18 +0000 (09:33 +0000)]
    Reviewed by Maciej Stachowiak.

        https://bugs.webkit.org/show_bug.cgi?id=35190
        Don't use system malloc in Java bindings

        * bridge/jni/jsc/JavaInstanceJSC.cpp: (JavaInstance::invokeMethod): Switched to WTF::Vector.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Maciej Stachowiak.
ap@apple.com [Sat, 20 Feb 2010 08:24:45 +0000 (08:24 +0000)]
    Reviewed by Maciej Stachowiak.

        https://bugs.webkit.org/show_bug.cgi?id=9761
        LiveConnect string conversion fails for java.lang.Object

        Can't test Java in DRT (I wonder why).

        * bridge/jni/jsc/JNIUtilityPrivate.cpp: (JSC::Bindings::convertValueToJValue):
        Added the necessary conversion. Also, removed CONVERT_NULL_TO_EMPTY_STRING dead code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-19 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Sat, 20 Feb 2010 03:06:28 +0000 (03:06 +0000)]
2010-02-19  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by David Levin.

        Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
        https://bugs.webkit.org/show_bug.cgi?id=35147

        * Configurations/FeatureDefines.xcconfig:
2010-02-19  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by David Levin.

        Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
        https://bugs.webkit.org/show_bug.cgi?id=35147

        * win/tools/vsprops/FeatureDefines.vsprops:
2010-02-19  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by David Levin.

        Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
        https://bugs.webkit.org/show_bug.cgi?id=35147

        * features.gypi:
2010-02-19  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by David Levin.

        Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
        https://bugs.webkit.org/show_bug.cgi?id=35147

        * Configurations/FeatureDefines.xcconfig:
2010-02-19  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by David Levin.

        Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
        https://bugs.webkit.org/show_bug.cgi?id=35147

        I made ENABLE(SANDBOX) only control the sandbox attribute itself;
        I did not ifdef the infrastructure to make sandboxing
        switchable. This is because the likely concerns about sandboxing
        are not stability of the infrastructure code, but rather the fact
        that the security model exposed to authors is still evolving.

        * Configurations/FeatureDefines.xcconfig:
        * GNUmakefile.am:
        * WebCore.pri:
        * html/HTMLIFrameElement.cpp:
        (WebCore::HTMLIFrameElement::parseMappedAttribute):
2010-02-19  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by David Levin.

        Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
        https://bugs.webkit.org/show_bug.cgi?id=35147

        * configure.ac:
2010-02-19  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by David Levin.

        Add an ENABLE flag for sandboxed iframes to make it possible to disable it in releases
        https://bugs.webkit.org/show_bug.cgi?id=35147

        * Scripts/build-webkit: Handle new flag.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55043 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-19 Leandro Pereira <leandro@profusion.mobi>
eric@webkit.org [Sat, 20 Feb 2010 02:08:39 +0000 (02:08 +0000)]
2010-02-19  Leandro Pereira  <leandro@profusion.mobi>

        Reviewed by Shinichiro Hamaji.

        [style-queue] should not complain about identifier names with underscores under WebKit/efl/ewk/
        https://bugs.webkit.org/show_bug.cgi?id=35091

        White list unix_hacker_style names in WebKit/efl/ewk because these
        are used in the EFL API.

        * Scripts/webkitpy/style/checker.py:
         - Filter out readability/naming on WebKit/efl/ewk.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Maciej Stachowiak.
ap@apple.com [Sat, 20 Feb 2010 01:23:12 +0000 (01:23 +0000)]
    Reviewed by Maciej Stachowiak.

        https://bugs.webkit.org/show_bug.cgi?id=35132
        <rdar://problem/7664353> Mouse cursor sometimes flickers over Flash content (35132)

WebCore:
        * page/EventHandler.cpp: (WebCore::EventHandler::handleMouseMoveEvent): Don't set mouse
        pointer when above a plug-in or applet to prevent flicker.

WebKit:
        * Plugins/WebNetscapePluginEventHandlerCarbon.mm:
        (WebNetscapePluginEventHandlerCarbon::mouseMoved): Send adjustCursor events on every mouse
        move. This matches Firefox, and is actually required for plug-ins to manipulate cursor wihout
        resorting to techniques such as fast firing timers.

        * Plugins/WebNetscapePluginView.mm:
        (-[WebNetscapePluginView handleMouseEntered:]): Some plug-ins handle mouse cursor internally,
        but those that don't just need to get an arrow cursor (matching Firefox). This means that
        e.g. a plugin inside <A> won't get a finger mouse pointer.

        * Plugins/WebHostedNetscapePluginView.mm:
        (-[WebNetscapePluginView handleMouseEntered:]):
        (-[WebNetscapePluginView handleMouseExited:]):
        Implement this behavior here, too. Also, out of process code didn't reset mouse pointer on
        mouse exit, which it needed to do.

        * WebView/WebHTMLView.mm:
        (needsCursorRectsSupportAtPoint):
        (setCursor):
        (resetCursorRects):
        Make sure that the same workaround we have for Web content also applies to Netscape plug-ins,
        as AppKit would reset the mouse pointer to arrow if given a chance.
        (+[WebHTMLViewPrivate initialize]): Renamed setCursorIMP on Leopard and higher to prevent
        confusion - the method we override is completely different.
        (-[WebHTMLView hitTest:]): Added a FIXME about a likely bug.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-19 Eric Seidel <eric@webkit.org>
eric@webkit.org [Sat, 20 Feb 2010 00:51:04 +0000 (00:51 +0000)]
2010-02-19  Eric Seidel  <eric@webkit.org>

        Reviewed by Dimitri Glazkov.

        fast/forms/search-event-delay.html failed on Snow Leopard Debug Bot
        https://bugs.webkit.org/show_bug.cgi?id=33543

        * platform/mac-snowleopard/Skipped:
         - This test prints times and expects 0.1s precision even on Debug bots.
           That can't work.  Skipping the test to make the bots green until this can be made non-flakey
           or until we have a layout test system which allows "failure" expectations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix regression in calculating an animated image's start time.
pkasting@chromium.org [Sat, 20 Feb 2010 00:45:45 +0000 (00:45 +0000)]
Fix regression in calculating an animated image's start time.
https://bugs.webkit.org/show_bug.cgi?id=35115

Reviewed by Adam Barth.

* platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::startAnimation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-19 Eric Seidel <eric@webkit.org>
eric@webkit.org [Sat, 20 Feb 2010 00:44:24 +0000 (00:44 +0000)]
2010-02-19  Eric Seidel  <eric@webkit.org>

        Reviewed by Dimitri Glazkov.

        editing/pasteboard/4641033.html timed out on Tiger Bot
        https://bugs.webkit.org/show_bug.cgi?id=33310

        * platform/mac-tiger/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-19 James Hawkins <jhawkins@chromium.org>
eric@webkit.org [Sat, 20 Feb 2010 00:41:48 +0000 (00:41 +0000)]
2010-02-19  James Hawkins  <jhawkins@chromium.org>

        Reviewed by Darin Fisher.

        [Chromium] Call WebViewClient::didAcceptAutoFillSuggestion when the
        user selects a suggestion from the AutoFill suggestions popup.

        https://bugs.webkit.org/show_bug.cgi?id=35174

        * public/WebViewClient.h:
        (WebKit::WebViewClient::didAcceptAutoFillSuggestion):
        * src/AutoFillPopupMenuClient.cpp:
        (WebKit::AutoFillPopupMenuClient::valueChanged):
        * src/AutoFillPopupMenuClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Geoffrey Garen.
ap@apple.com [Fri, 19 Feb 2010 23:44:56 +0000 (23:44 +0000)]
    Reviewed by Geoffrey Garen.

        https://bugs.webkit.org/show_bug.cgi?id=35178
        LiveConnect code uses hand-rolled fprintf logging

        Changed to use LOG, LOG_ERROR and ASSERT.

        * platform/Logging.cpp:
        (WebCore::getChannelFromName):
        * platform/Logging.h:
        * platform/mac/LoggingMac.mm:
        (WebCore::InitializeLoggingChannelsIfNecessary):
        * platform/win/LoggingWin.cpp:
        (WebCore::InitializeLoggingChannelsIfNecessary):
        TextConversion channel was (almost) unused, renamed to LiveConnect.

        * platform/text/gtk/TextCodecGtk.cpp: (WebCore::TextCodecGtk::registerEncodingNames):
        The only use of this channel was in platform specific code, commandeered it for cross-platform
        needs.

        * bridge/jni/JNIBridge.cpp:
        * bridge/jni/JNIUtility.cpp:
        (JSC::Bindings::getJavaVM):
        (JSC::Bindings::getJNIEnv):
        (JSC::Bindings::getJNIField):
        * bridge/jni/JNIUtility.h:
        (JSC::Bindings::callJNIMethodV):
        (JSC::Bindings::callJNIStaticMethod):
        * bridge/jni/jni_jsobject.mm:
        (completedJavaScriptAccess):
        (dispatchToJavaScriptThread):
        (performJavaScriptAccess):
        (JavaJSObject::invoke):
        (JavaJSObject::call):
        (JavaJSObject::eval):
        (JavaJSObject::getMember):
        (JavaJSObject::setMember):
        (JavaJSObject::removeMember):
        (JavaJSObject::getSlot):
        (JavaJSObject::setSlot):
        (JavaJSObject::toString):
        (JavaJSObject::createNative):
        * bridge/jni/jsc/JNIBridgeJSC.cpp:
        (JavaField::valueFromInstance):
        (JavaField::setValueToInstance):
        * bridge/jni/jsc/JavaClassJSC.cpp:
        (JavaClass::JavaClass):
        * bridge/jni/jsc/JavaInstanceJSC.cpp:
        (JavaInstance::invokeMethod):
        (JObjectWrapper::JObjectWrapper):
        (JObjectWrapper::~JObjectWrapper):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55036 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoJSString::getIndex() calls value() to resolve the string value (is a rope)
barraclough@apple.com [Fri, 19 Feb 2010 23:36:09 +0000 (23:36 +0000)]
JSString::getIndex() calls value() to resolve the string value (is a rope)
to a UString, then passes the result to jsSingleCharacterSubstring without
checking for an exception.  In case of out-of-memory the returned UString
is null(), which may result in an out-of-buounds substring being created.
This is bad.

Reviewed by Oliver Hunt.

Simple fix is to be able to get an index from a rope without resolving to
UString.  This may be a useful optimization in some test cases.

The same bug exists in some other methods is JSString, these can be fixed
by changing them to call getIndex().

* runtime/JSString.cpp:
(JSC::JSString::resolveRope):
(JSC::JSString::getStringPropertyDescriptor):
* runtime/JSString.h:
(JSC::jsSingleCharacterSubstring):
(JSC::JSString::getIndex):
(JSC::jsSingleCharacterString):
(JSC::JSString::getStringPropertySlot):
* runtime/UStringImpl.cpp:
(JSC::singleCharacterSubstring):
* runtime/UStringImpl.h:
(JSC::UStringImpl::singleCharacterSubstring):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-19 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 19 Feb 2010 23:07:02 +0000 (23:07 +0000)]
2010-02-19  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Split out "prepare-rollout" from "rollout" and make --complete-rollout default
        https://bugs.webkit.org/show_bug.cgi?id=33745

        * Scripts/webkitpy/commands/download.py:
         - Add a new AbstractRolloutPrepCommand to share code between PrepareRollout and Rollout
         - Add PrepareRollout
        * Scripts/webkitpy/commands/download_unittest.py: Test PrepareRollout, remove CompleteRollout tests.
        * Scripts/webkitpy/steps/__init__.py: include ReopenBugAfterRollout step.
        * Scripts/webkitpy/steps/completerollout.py: Removed.
        * Scripts/webkitpy/steps/options.py: remove complete_rollout
        * Scripts/webkitpy/steps/reopenbugafterrollout.py: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-19 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Fri, 19 Feb 2010 23:06:34 +0000 (23:06 +0000)]
2010-02-19  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        RenderSVGResourceMasker causes an Assert on Wind builds during DRT
        https://bugs.webkit.org/show_bug.cgi?id=35182

        We remove the Assert for now and return earlier, if the HashMap of the Masker
        does not contain the RenderObject. The RenderObject is an identifiert to get
        a already calculated mask.
        A race condition during parsing can cause the invalidation call, before the mask
        got calculated (only during DRT on Win build bots).
        The real bug will be fixed with: https://bugs.webkit.org/show_bug.cgi?id=35181

        * rendering/RenderSVGResourceMasker.cpp:
        (WebCore::RenderSVGResourceMasker::invalidateClient):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-19 James Hawkins <jhawkins@chromium.org>
eric@webkit.org [Fri, 19 Feb 2010 22:50:55 +0000 (22:50 +0000)]
2010-02-19  James Hawkins  <jhawkins@chromium.org>

        Reviewed by Eric Seidel.

        [Chromium] Use the m_suggestionsPopupClient pointer to refer to the
        popup client, as the Autocomplete popup might not be the current
        popup.

        https://bugs.webkit.org/show_bug.cgi?id=35172

        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::autocompleteHandleKeyEvent):
        (WebKit::WebViewImpl::refreshSuggestionsPopup):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55032 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-19 James Hawkins <jhawkins@chromium.org>
eric@webkit.org [Fri, 19 Feb 2010 22:34:55 +0000 (22:34 +0000)]
2010-02-19  James Hawkins  <jhawkins@chromium.org>

        Reviewed by Eric Seidel.

        [Chromium] Rename EditorClientImpl::onAutofillSuggestionAccepted to
        onAutocompleteSuggestionAccepted to better match the purpose of the
        function.

        https://bugs.webkit.org/show_bug.cgi?id=35171

        * src/EditorClientImpl.cpp:
        (WebKit::EditorClientImpl::onAutocompleteSuggestionAccepted):
        * src/EditorClientImpl.h:
        * src/SuggestionsPopupMenuClient.cpp:
        (WebKit::SuggestionsPopupMenuClient::valueChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55031 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-19 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 19 Feb 2010 22:10:18 +0000 (22:10 +0000)]
2010-02-19  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        <rdar://problem/7535894> Page contents missing from snapshot on Newsweek.com article

        Followup to avoid capturing compositing layers twice in snapshots. Add private
        methods to WebView to specify whether drawing the WebView into an image will
        include flattened compositing layers (the default behavior) or not.

        * WebView/WebFrame.mm:
        (-[WebFrame _drawRect:contentsOnly:]): Consult the WebView flag to see if we
        want flattening.

        * WebView/WebViewPrivate.h: New methods.
        * WebView/WebView.mm: Ditto.
        (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
        (-[WebView _setIncludesFlattenedCompositingLayersWhenDrawingToBitmap:]):
        (-[WebView _includesFlattenedCompositingLayersWhenDrawingToBitmap]):

        * WebView/WebViewData.h: New member variable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore: Make Pasteboard::writeImage() safe against NULL cachedImages, and clean
pkasting@chromium.org [Fri, 19 Feb 2010 21:44:32 +0000 (21:44 +0000)]
WebCore: Make Pasteboard::writeImage() safe against NULL cachedImages, and clean
up some code.
https://bugs.webkit.org/show_bug.cgi?id=35136

Reviewed by Darin Fisher.

* loader/ImageLoader.cpp:
(WebCore::ImageLoader::updateRenderer): Shorten some code.
* page/DragController.cpp:
(WebCore::getImage): Shorten some code.
* platform/chromium/PasteboardChromium.cpp:
(WebCore::Pasteboard::writeImage): NULL-check cachedImage().
* platform/gtk/PasteboardGtk.cpp:
(WebCore::Pasteboard::writeImage): NULL-check cachedImage().
* platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::writeImage): NULL-check cachedImage().
* platform/qt/PasteboardQt.cpp:
(WebCore::Pasteboard::writeImage): NULL-check cachedImage().
* platform/win/PasteboardWin.cpp:
(WebCore::Pasteboard::writeImage): NULL-check cachedImage().

WebKit/chromium: Add an isImageBlocked bool to the WebContextMenuData struct.
https://bugs.webkit.org/show_bug.cgi?id=35136

Reviewed by Darin Fisher.

This lets us properly enable/disable the "Copy Image" context menu entry
(and, in the future, maybe add a "Load Image" function).

* public/WebContextMenuData.h:
* src/ContextMenuClientImpl.cpp:
(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55029 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRubberstamped by Noam Rosenthal, who wrote the original code.
kenneth@webkit.org [Fri, 19 Feb 2010 21:30:57 +0000 (21:30 +0000)]
Rubberstamped by Noam Rosenthal, who wrote the original code.

Make mouse wheel scrolling work when using the GraphicsLayer.

* platform/graphics/qt/GraphicsLayerQt.cpp:
(WebCore::GraphicsLayerQtImpl::GraphicsLayerQtImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55028 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-19 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Fri, 19 Feb 2010 21:08:58 +0000 (21:08 +0000)]
2010-02-19  Oliver Hunt  <oliver@apple.com>

        RS = Gavin Barraclough.

        Split the 32/64 version of JITPropertyAccess into a separate file.

        * GNUmakefile.am:
        * JavaScriptCore.gypi:
        * JavaScriptCore.pri:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * jit/JITPropertyAccess.cpp:
        * jit/JITPropertyAccess32_64.cpp: Added.
        (JSC::JIT::emit_op_put_by_index):
        (JSC::JIT::emit_op_put_getter):
        (JSC::JIT::emit_op_put_setter):
        (JSC::JIT::emit_op_del_by_id):
        (JSC::JIT::emit_op_method_check):
        (JSC::JIT::emitSlow_op_method_check):
        (JSC::JIT::emit_op_get_by_val):
        (JSC::JIT::emitSlow_op_get_by_val):
        (JSC::JIT::emit_op_put_by_val):
        (JSC::JIT::emitSlow_op_put_by_val):
        (JSC::JIT::emit_op_get_by_id):
        (JSC::JIT::emitSlow_op_get_by_id):
        (JSC::JIT::emit_op_put_by_id):
        (JSC::JIT::emitSlow_op_put_by_id):
        (JSC::JIT::compileGetByIdHotPath):
        (JSC::JIT::compileGetByIdSlowCase):
        (JSC::JIT::compilePutDirectOffset):
        (JSC::JIT::compileGetDirectOffset):
        (JSC::JIT::testPrototype):
        (JSC::JIT::privateCompilePutByIdTransition):
        (JSC::JIT::patchGetByIdSelf):
        (JSC::JIT::patchMethodCallProto):
        (JSC::JIT::patchPutByIdReplace):
        (JSC::JIT::privateCompilePatchGetArrayLength):
        (JSC::JIT::privateCompileGetByIdProto):
        (JSC::JIT::privateCompileGetByIdSelfList):
        (JSC::JIT::privateCompileGetByIdProtoList):
        (JSC::JIT::privateCompileGetByIdChainList):
        (JSC::JIT::privateCompileGetByIdChain):
        (JSC::JIT::emit_op_get_by_pname):
        (JSC::JIT::emitSlow_op_get_by_pname):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55027 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-19 William Siegrist <wsiegrist@apple.com>
wsiegrist@apple.com [Fri, 19 Feb 2010 20:30:21 +0000 (20:30 +0000)]
2010-02-19 William Siegrist <wsiegrist@apple.com>

Add GTK Linux 64-bit Release bot. Rename GTK Linux Release to GTK Linux 32-bit Release.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-19 Jesus Sanchez-Palencia <jesus.palencia@openbossa.org>
eric@webkit.org [Fri, 19 Feb 2010 19:47:00 +0000 (19:47 +0000)]
2010-02-19  Jesus Sanchez-Palencia  <jesus.palencia@openbossa.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Need a final integration between QtLauncher and QGVLauncher
        https://bugs.webkit.org/show_bug.cgi?id=35161

        Add animated flip support to QtLauncher when running on QGraphicsView mode.

        * QtLauncher/main.cpp:
        (LauncherWindow::initializeView):
        (LauncherWindow::setupUI):
        * QtLauncher/webview.cpp:
        (WebViewGraphicsBased::WebViewGraphicsBased):
        (WebViewGraphicsBased::animatedFlip):
        (WebViewGraphicsBased::animatedYFlip):
        * QtLauncher/webview.h:
        (WebViewGraphicsBased::setYRotation):
        (WebViewGraphicsBased::yRotation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55025 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-19 Patrick Gansterer <paroga@paroga.com>
eric@webkit.org [Fri, 19 Feb 2010 19:30:55 +0000 (19:30 +0000)]
2010-02-19  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Laszlo Gombos.

        Added additional parameter to create_rvct_stubs
        for setting the regularexpression prefix.
        Renamed it because it now works for other platforms too.
        https://bugs.webkit.org/show_bug.cgi?id=34951

        * DerivedSources.pro:
        * create_jit_stubs: Copied from JavaScriptCore/create_rvct_stubs.
        * create_rvct_stubs: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-19 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Fri, 19 Feb 2010 19:22:57 +0000 (19:22 +0000)]
2010-02-19  Nate Chapin  <japhet@chromium.org>

        Reviewed by Dimitri Glazkov.

        [V8] Fix Worker crash regression in r54972

        https://bugs.webkit.org/show_bug.cgi?id=35166

        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::instantiateV8Object): Properly unwrap global objects when inside a WorkerContext.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoNot reviewed. Reverts r55020 which causes crashes in Chromium LayoutTests
steveblock@google.com [Fri, 19 Feb 2010 19:09:37 +0000 (19:09 +0000)]
Not reviewed. Reverts r55020 which causes crashes in Chromium LayoutTests

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55022 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Dan Bernstein.
ap@apple.com [Fri, 19 Feb 2010 18:59:24 +0000 (18:59 +0000)]
    Reviewed by Dan Bernstein.

        https://bugs.webkit.org/show_bug.cgi?id=35165
        plugins/set-status.html fails on Windows bot

        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::status):
        * Plugins/WebNetscapePluginView.mm:
        (-[WebNetscapePluginView status:]):
        Match Windows port behavior (and also Firefox one, in a way) - pass null status messages as
        empty ones to chrome.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55021 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-19 Steve Block <steveblock@google.com>
eric@webkit.org [Fri, 19 Feb 2010 17:13:51 +0000 (17:13 +0000)]
2010-02-19  Steve Block  <steveblock@google.com>

        Reviewed by David Levin.

        Sets default values of V8 runtime enabler flags to match behavior with JSC
        https://bugs.webkit.org/show_bug.cgi?id=35095

        No new tests, modifies a Chromium feature only.

        * bindings/generic/RuntimeEnabledFeatures.cpp: Modified. Sets appcache and geolocation flag defaults to 'on'
        * storage/Database.cpp: Modified. Sets database flag default to 'on'.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55020 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Implement textZoomIn() and textZoomOut() in DRT's EventSender, add results
abecsi@webkit.org [Fri, 19 Feb 2010 17:13:38 +0000 (17:13 +0000)]
[Qt] Implement textZoomIn() and textZoomOut() in DRT's EventSender, add results
for passing new tests and unskip the passing ones from the Skipped list.
https://bugs.webkit.org/show_bug.cgi?id=35159

Reviewed by Kenneth Rohde Christiansen.

WebKitTools:

* DumpRenderTree/qt/EventSenderQt.cpp:
(EventSender::textZoomIn):
(EventSender::textZoomOut):
* DumpRenderTree/qt/EventSenderQt.h:

LayoutTests:

* platform/qt/Skipped: unskip passing tests
* platform/qt/svg/custom/text-zoom-expected.txt: Added.
* platform/qt/svg/zoom: Added.
* platform/qt/svg/zoom/page: Added.
* platform/qt/svg/zoom/page/absolute-sized-document-no-scrollbars-expected.txt: Added.
* platform/qt/svg/zoom/page/absolute-sized-document-scrollbars-expected.txt: Added.
* platform/qt/svg/zoom/page/relative-sized-document-scrollbars-expected.txt: Added.
* platform/qt/svg/zoom/page/zoom-foreignObject-expected.txt: Added.
* platform/qt/svg/zoom/page/zoom-hixie-mixed-008-expected.txt: Added.
* platform/qt/svg/zoom/page/zoom-hixie-mixed-009-expected.txt: Added.
* platform/qt/svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt: Added.
* platform/qt/svg/zoom/page/zoom-svg-float-border-padding-expected.txt: Added.
* platform/qt/svg/zoom/text: Added.
* platform/qt/svg/zoom/text/absolute-sized-document-no-scrollbars-expected.txt: Added.
* platform/qt/svg/zoom/text/absolute-sized-document-scrollbars-expected.txt: Added.
* platform/qt/svg/zoom/text/relative-sized-document-scrollbars-expected.txt: Added.
* platform/qt/svg/zoom/text/zoom-foreignObject-expected.txt: Added.
* platform/qt/svg/zoom/text/zoom-hixie-mixed-008-expected.txt: Added.
* platform/qt/svg/zoom/text/zoom-hixie-mixed-009-expected.txt: Added.
* platform/qt/svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt: Added.
* platform/qt/svg/zoom/text/zoom-svg-float-border-padding-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55019 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-19 Marcus Bulach <bulach@chromium.org>
eric@webkit.org [Fri, 19 Feb 2010 16:57:38 +0000 (16:57 +0000)]
2010-02-19  Marcus Bulach  <bulach@chromium.org>

        Reviewed by Jeremy Orlow.

        Fixes GeolocationServiceBridgeImpl::stopUpdating (it can be called multiple times).

        * src/GeolocationServiceBridgeChromium.cpp:
        (WebKit::GeolocationServiceBridgeImpl::stopUpdating):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55018 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-19 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Fri, 19 Feb 2010 16:50:16 +0000 (16:50 +0000)]
2010-02-19  Philippe Normand  <pnormand@igalia.com>

        Rubber-stamped by Gustavo Noronha Silva.

        [GTK] fast/forms/restore-selection-after-layout.html fails on 32bits Debug build
        https://bugs.webkit.org/show_bug.cgi?id=35158

        * platform/gtk/Skipped: Skip failing test

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55017 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-19 Alexander Pavlov <apavlov@chromium.org>
eric@webkit.org [Fri, 19 Feb 2010 15:16:10 +0000 (15:16 +0000)]
2010-02-19  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        WebInspector: Elements panel: Correctly show empty elements' ending tags
        for XML and HTML documents.
        https://bugs.webkit.org/show_bug.cgi?id=26315

        * inspector/console-dirxml-expected.txt:
        * inspector/console-format-collections-expected.txt:
        * inspector/console-format-expected.txt:
        * inspector/elements-panel-limited-children-expected.txt:
        * inspector/elements-panel-structure-expected.txt:
        Re-baselined due to closing tags and ellipses between opening and closing tags

        * inspector/elements-panel-xhtml-structure-expected.txt: Added.
        * inspector/elements-panel-xhtml-structure.xhtml: Added.
2010-02-19  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        WebInspector: Elements panel: Correctly show empty elements' ending tags
        for XML and HTML documents.
        https://bugs.webkit.org/show_bug.cgi?id=26315

        Test: inspector/elements-panel-xhtml-structure.xhtml

        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::populateScriptObjects):
        * inspector/front-end/ElementsTreeOutline.js:
        (WebInspector.ElementsTreeOutline.prototype.set rootDOMNode):
        (WebInspector.ElementsTreeOutline.prototype.get isXMLMimeType):
        (WebInspector.ElementsTreeOutline.prototype._contextMenuEventFired):
        (WebInspector.ElementsTreeElement.prototype.onexpand):
        (WebInspector.ElementsTreeElement.prototype.oncollapse):
        (WebInspector.ElementsTreeElement.prototype.updateTitle.callback):
        (WebInspector.ElementsTreeElement.prototype.updateTitle):
        (WebInspector.ElementsTreeElement.prototype._nodeTitleInfo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55016 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Unreviewed Changelog typo fix.
abecsi@webkit.org [Fri, 19 Feb 2010 14:52:01 +0000 (14:52 +0000)]
Unreviewed Changelog typo fix.

    r5993 should be r54993.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@55015 268f45cc-cd09-0410-ab3c-d52691b4dbfc