WebKit-https.git
12 years agoAdd the Chromium Blog to Planet WebKit.
timothy@apple.com [Sun, 7 Sep 2008 17:28:48 +0000 (17:28 +0000)]
Add the Chromium Blog to Planet WebKit.

        Reviewed by Tim Hatcher.

        * config.ini: Add The Chromium Blog

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd a manual-test I forgot to commit in r36029.
timothy@apple.com [Sun, 7 Sep 2008 16:48:51 +0000 (16:48 +0000)]
Add a manual-test I forgot to commit in r36029.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Adds console.dirxml support to the Web Inspector.
timothy@apple.com [Sun, 7 Sep 2008 16:48:41 +0000 (16:48 +0000)]
    Adds console.dirxml support to the Web Inspector.

        https://bugs.webkit.org/show_bug.cgi?id=19156

        Reviewed by Timothy Hatcher.

        * WebCore.vcproj/WebCore.vcproj: Added ElementsTreeOutline.js.
        * bindings/js/JSConsoleCustom.cpp:
        (WebCore::JSConsole::dirxml):
        * page/Console.cpp:
        (WebCore::Console::dirxml): Adds a ConsoleMessage with NodeMessageLevel.
        * page/Console.h:
        (WebCore::): Added NodeMessageLevel.
        * page/Console.idl: Added console.dirxml.
        * page/inspector/Console.js: A NodeMessage creates a ElementsTreeOutline.
        * page/inspector/ElementsPanel.js: Modified to use ElementsTreeOutline. The ElementsTreeOutline
        in the ElementsPanel has includeRootDOMNode and selectEnabled set to true.
        * page/inspector/ElementsTreeOutline.js: Added.
        (WebInspector.ElementsTreeOutline): A subclass of TreeOutline for displaying a DOM node tree.
        (WebInspector.ElementsTreeElement): A subclass of TreeElement for ElementsTreeOutline.
        * page/inspector/WebKit.qrc: Added ElementsTreeOutline.js.
        * page/inspector/inspector.css:
        * page/inspector/inspector.html: Added ElementsTreeOutline.js.
        * page/inspector/inspector.js: Moved hover related methods to WebInspector.
        (WebInspector.altKeyDown):
        (WebInspector.forceHoverHighlight):
        (WebInspector.hoveredDOMNode):
        (WebInspector._updateHoverHighlightSoon):
        (WebInspector._updateHoverHighlight):
        (WebInspector.documentKeyDown): Updates WebInspector.altKeyDown
        (WebInspector.documentKeyUp): Updates WebInspector.altKeyDown
        * page/inspector/utilities.js: Added getDocumentForNode, parentNodeOrFrameElement,
        isAncestorIncludingParentFrames.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-09-07 Cameron Zwarich <cwzwarich@webkit.org>
cwzwarich@webkit.org [Sun, 7 Sep 2008 09:20:30 +0000 (09:20 +0000)]
2008-09-07  Cameron Zwarich  <cwzwarich@webkit.org>

        Not reviewed.

        Visual C++ seems to have some odd casting rules, so just convert the
        offending cast back to a C-style cast for now.

        * kjs/collector.cpp:
        (KJS::otherThreadStackPointer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-09-07 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Sun, 7 Sep 2008 09:09:34 +0000 (09:09 +0000)]
2008-09-07  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Mark Rowe.

        Attempt to fix the Windows build by using a const_cast to cast regs.Esp
        to a uintptr_t instead of a reinterpret_cast.

        * kjs/collector.cpp:
        (KJS::otherThreadStackPointer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRoll out r36245 in hopes of fixing the Windows nightly builds with Safari 3.1.2.
mrowe@apple.com [Sun, 7 Sep 2008 08:41:35 +0000 (08:41 +0000)]
Roll out r36245 in hopes of fixing the Windows nightly builds with Safari 3.1.2.

Rubber-stamped by Tim Hatcher.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-09-07 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Sun, 7 Sep 2008 08:39:38 +0000 (08:39 +0000)]
2008-09-07  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Sam Weinig.

        Remove C-style casts from kjs/collector.cpp.

        * kjs/collector.cpp:
        (KJS::Heap::heapAllocate):
        (KJS::currentThreadStackBase):
        (KJS::Heap::markConservatively):
        (KJS::otherThreadStackPointer):
        (KJS::Heap::markOtherThreadConservatively):
        (KJS::Heap::sweep):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBuild fix for the debug variant.
mrowe@apple.com [Sun, 7 Sep 2008 07:54:25 +0000 (07:54 +0000)]
Build fix for the debug variant.

* DerivedSources.make: Also use the .Debug.exp exports file when building the debug variant.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-09-07 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Sun, 7 Sep 2008 07:21:32 +0000 (07:21 +0000)]
2008-09-07  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Timothy Hatcher.

        Remove C-style casts from the CTI code.

        * VM/CTI.cpp:
        (KJS::CTI::emitGetArg):
        (KJS::CTI::emitGetPutArg):
        (KJS::ctiRepatchCallByReturnAddress):
        (KJS::CTI::compileOpCall):
        (KJS::CTI::privateCompileMainPass):
        (KJS::CTI::privateCompileGetByIdSelf):
        (KJS::CTI::privateCompileGetByIdProto):
        (KJS::CTI::privateCompileGetByIdChain):
        (KJS::CTI::privateCompilePutByIdReplace):
        (KJS::CTI::privateArrayLengthTrampoline):
        (KJS::CTI::privateStringLengthTrampoline):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-09-07 Stephanie Lewis <slewis@apple.com>
slewis@apple.com [Sun, 7 Sep 2008 07:12:45 +0000 (07:12 +0000)]
2008-09-07  Stephanie Lewis  <slewis@apple.com>

        Reviewed by Mark Rowe.

        Fix DRT build

        * DumpRenderTree/DumpRenderTreePrefix.h:
        * DumpRenderTree/win/DumpRenderTree.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoQt build fix.
mrowe@apple.com [Sun, 7 Sep 2008 06:08:56 +0000 (06:08 +0000)]
Qt build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Fix Windows nightlies.
sfalken@apple.com [Sun, 7 Sep 2008 05:50:34 +0000 (05:50 +0000)]
    Fix Windows nightlies.

        Copy WebKit.dll alongside application so registry-free COM can find it.
        Update embedded manifest to force use registry-free COM.

        Reviewed by Dave Hyatt.

        * FindSafari/FindSafari.cpp:
        (copyManifest):
        (replaceManifest):
        (_tmain):
        * FindSafari/FindSafari.rc: Added.
        * FindSafari/FindSafari.vcproj:
        * FindSafari/Safari.exe.manifest: Added.
        * FindSafari/resource.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Fix Windows nightlies.
sfalken@apple.com [Sun, 7 Sep 2008 05:48:59 +0000 (05:48 +0000)]
    Fix Windows nightlies.

        Include both nightly and production CLSIDs in our interfaces, type library.
        Remove COM registration code.

        Reviewed by Dave Hyatt.

        * ForEachCoClass.cpp:
        (setUseOpenSourceWebKit):
        * Interfaces/WebKit.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoMerge squirrelfish-extreme to trunk.
mrowe@apple.com [Sun, 7 Sep 2008 05:44:58 +0000 (05:44 +0000)]
Merge squirrelfish-extreme to trunk.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-09-06 Antti Koivisto <antti@apple.com>
antti@apple.com [Sun, 7 Sep 2008 03:54:21 +0000 (03:54 +0000)]
2008-09-06  Antti Koivisto  <antti@apple.com>

        Reviewed by Dave Hyatt.

        <rdar://problem/6187043>
        Don't parse full HTML user agent style sheet unless it is actually needed
        <rdar://problem/6131889>
        WebView is significantly more expensive to create recently

        Parsing the html4.css takes significant amount of time and memory (~50kb) on application
        startup. Some clients may never use most of the rules.

        With this patch we use simplified UA stylesheet until we hit something it can't handle.
        This avoids full stylesheet parsing on application startup (due to empty document construction)
        and also makes it possible for clients with very simple demands (divs and spans only) never to load
        the full style.

        It also delays view source style parsing until it is used.

        * css/CSSStyleSelector.cpp:
        (WebCore::elementCanUseSimpleDefaultStyle):
        (WebCore::CSSStyleSelector::CSSStyleSelector):
        (WebCore::loadFullDefaultStyle):
        (WebCore::loadSimpleDefaultStyle):
        (WebCore::loadViewSourceStyle):
        (WebCore::CSSStyleSelector::matchUARules):
        (WebCore::CSSStyleSelector::styleForElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agowx build fix.
kevino@webkit.org [Sun, 7 Sep 2008 03:46:50 +0000 (03:46 +0000)]
wx build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-09-06 Antti Koivisto <antti@apple.com>
antti@apple.com [Sat, 6 Sep 2008 23:32:26 +0000 (23:32 +0000)]
2008-09-06  Antti Koivisto  <antti@apple.com>

        Reverting r35953 which was causing problems on Windows which relies on
        WebCore timers in nested event loops. r36132 did alternative fix.

        * page/Chrome.cpp:
        (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
        (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36133 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-09-06 Antti Koivisto <antti@apple.com>
antti@apple.com [Sat, 6 Sep 2008 23:27:09 +0000 (23:27 +0000)]
2008-09-06  Antti Koivisto  <antti@apple.com>

        Reviewed by Dan Bernstein.

        Fix <rdar://problem/6201644>
        https://bugs.webkit.org/show_bug.cgi?id=20493
        Crash after OK in dialog box and reloading page in secure mode

        Limited loader only fix since the general timer fix is causing problems on Windows.

        * loader/loader.cpp:
        (WebCore::Loader::servePendingRequests):
        (WebCore::Loader::Host::Host):
        (WebCore::Loader::Host::didFinishLoading):
        (WebCore::Loader::Host::didFail):
        (WebCore::Loader::Host::didReceiveData):
        * loader/loader.h:
        (WebCore::Loader::Host::processingResource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36132 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Dave Hyatt.
mitz@apple.com [Sat, 6 Sep 2008 22:39:34 +0000 (22:39 +0000)]
    Reviewed by Dave Hyatt.

        The initial Core Text adoption prototype was made by Daniel Fenwick.

        - <rdar://problem/5158514> Add a Core Text-based complex text code path

        Currently the Core Text code path is not used in any configuration.

        * WebCore.xcodeproj/project.pbxproj: Added files.
        * config.h: Defined WTF_USE_ATSUI and WTF_USE_CORE_TEXT.
        * platform/graphics/Font.cpp:
        (WebCore::WidthIterator::advance): Moved the spacingDisabled() test out
        of the loop.
        * platform/graphics/GlyphBuffer.h:
        (WebCore::GlyphBuffer::add): Added this version that takes an advance.
        * platform/graphics/SimpleFontData.h: Added ATSUI and CORE_TEXT #ifdefs.
        Added getCTFont() and getCFStringAttributes() and corresponding data
        members for Core Text.
        * platform/graphics/mac/CoreTextController.cpp: Added.
        (WebCore::roundCGFloat): Helper function.
        (WebCore::ceilCGFloat): Helper function.
        (WebCore::CoreTextController::CoreTextRun::CoreTextRun):
        (WebCore::CoreTextController::CoreTextController):
        (WebCore::CoreTextController::offsetForPosition):
        (WebCore::CoreTextController::collectCoreTextRuns): Added. Segments the
        run into subruns as necessary such that each subrun can be rendered with
        a single font. Also separates out soft hyphens and replaces them with
        real hyphens, because Core Text does not emit a glyph for soft hyphens.
        Then calls collectCoreTextRunsForCharacters() on each subrun.
        (WebCore::CoreTextController::advance):
        (WebCore::CoreTextController::collectCoreTextRunsForCharacters): Creates
        a CTLine from the given subrun and collects its CoreTextRuns.
        (WebCore::CoreTextController::adjustGlyphsAndAdvances): Applies the
        rounding hacks, letter- and word-spacing and glyph substitutions and
        stores the resulting adjusted glyphs and advances.
        * platform/graphics/mac/CoreTextController.h: Copied from WebCore/platform/graphics/win/UniscribeController.h.
        (WebCore::CoreTextController::totalWidth):
        (WebCore::CoreTextController::finalRoundingWidth):
        (WebCore::CoreTextController::CoreTextRun::ctRun):
        (WebCore::CoreTextController::CoreTextRun::glyphCount):
        (WebCore::CoreTextController::CoreTextRun::fontData):
        (WebCore::CoreTextController::CoreTextRun::characters):
        (WebCore::CoreTextController::CoreTextRun::stringLocation):
        (WebCore::CoreTextController::CoreTextRun::stringLength):
        (WebCore::CoreTextController::CoreTextRun::indexAt):
        * platform/graphics/mac/FontMac.mm: Moved the ATSUI-specific parts to
        FontMacATSUI.mm.
        * platform/graphics/mac/FontMacATSUI.mm: Copied from WebCore/platform/graphics/mac/FontMac.mm.
        (WebCore::disableLigatures): Changed to call
        FontPlatformData::allowsLigatures().
        (WebCore::overrideLayoutOperation): Changed to call
        FontPlatformData::roundsGlyphAdvances().
        * platform/graphics/mac/FontMacCoreText.cpp: Copied from WebCore/platform/graphics/win/FontWin.cpp.
        (WebCore::Font::selectionRectForComplexText): Changed to use
        totalWidth() instead of advancing to the end and using runWidthSoFar().
        (WebCore::Font::drawComplexText):
        (WebCore::Font::floatWidthForComplexText): Ditto.
        (WebCore::Font::offsetForPositionForComplexText):
        * platform/graphics/mac/FontPlatformData.h:
        * platform/graphics/mac/FontPlatformDataMac.mm:
        (WebCore::FontPlatformData::setFont):
        (WebCore::FontPlatformData::roundsGlyphAdvances): Added. Checks the
        AppKit rendering mode.
        (WebCore::FontPlatformData::allowsLigatures): Added. Implements the
        heuristic that allows ligatures in fonts that do not have a glyph for
        'a', based on the assumption that such fonts are only used in complex
        text.
        * platform/graphics/mac/SimpleFontDataMac.mm:
        (WebCore::SimpleFontData::platformInit):
        (WebCore::SimpleFontData::platformDestroy):
        (WebCore::SimpleFontData::getCTFont): Added.
        (WebCore::SimpleFontData::getCFStringAttributes): Added. Caches and
        returns an attributes dictionary.
        * platform/text/mac/ShapeArabic.c: Added ATSUI #ifdefs.
        * platform/text/mac/ShapeArabic.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36131 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-09-06 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Sat, 6 Sep 2008 11:48:40 +0000 (11:48 +0000)]
2008-09-06  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Maciej Stachowiak.

        Fix the Mac Debug build by adding symbols that are exported only in a
        Debug configuration.

        * Configurations/JavaScriptCore.xcconfig:
        * DerivedSources.make:
        * JavaScriptCore.Debug.exp: Added.
        * JavaScriptCore.base.exp: Copied from JavaScriptCore.exp.
        * JavaScriptCore.exp: Removed.
        * JavaScriptCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Dave Hyatt.
mitz@apple.com [Sat, 6 Sep 2008 08:31:02 +0000 (08:31 +0000)]
    Reviewed by Dave Hyatt.

        - make combining mark offsets work in CG text on Windows

        * platform/graphics/win/FontCGWin.cpp:
        (WebCore::Font::drawGlyphs): The old code tried to translate the text
        matrix, but failed for two reasons: it did not actually change the
        matrix, and even if it did, CGContextSetTextPosition overwrites the
        translation values in the text matrix. Instead, just added the
        translation to the anchor point.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36129 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBuild fix.
timothy@apple.com [Sat, 6 Sep 2008 05:37:41 +0000 (05:37 +0000)]
Build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBuild fix.
timothy@apple.com [Sat, 6 Sep 2008 05:19:47 +0000 (05:19 +0000)]
Build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36127 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Correct a typo in the setApplicationChromeModeEnabledEnabled:
timothy@apple.com [Sat, 6 Sep 2008 05:19:43 +0000 (05:19 +0000)]
    Correct a typo in the setApplicationChromeModeEnabledEnabled:
        method name, remove the extra "Enabled".

        * WebView/WebPreferences.mm:
        * WebView/WebPreferencesPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-09-05 Darin Adler <darin@apple.com>
darin@apple.com [Sat, 6 Sep 2008 04:59:53 +0000 (04:59 +0000)]
2008-09-05  Darin Adler  <darin@apple.com>

        Reviewed by Cameron Zwarich.

        - https://bugs.webkit.org/show_bug.cgi?id=20681
          JSPropertyNameIterator functions need to be inlined

        1.007x as fast on SunSpider overall
        1.081x as fast on SunSpider math-cordic

        * VM/JSPropertyNameIterator.cpp: Moved functions out of here.
        * VM/JSPropertyNameIterator.h:
        (KJS::JSPropertyNameIterator::JSPropertyNameIterator): Moved
        this into the header and marked it inline.
        (KJS::JSPropertyNameIterator::create): Ditto.
        (KJS::JSPropertyNameIterator::next): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36125 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-09-05 Darin Adler <darin@apple.com>
darin@apple.com [Sat, 6 Sep 2008 04:58:40 +0000 (04:58 +0000)]
2008-09-05  Darin Adler  <darin@apple.com>

        Reviewed by Geoff Garen.

        - fix https://bugs.webkit.org/show_bug.cgi?id=20673
          single-character strings are churning in the Identifier table

        1.007x as fast on SunSpider overall
        1.167x as fast on SunSpider string/fasta

        * JavaScriptCore.exp: Updated.
        * kjs/SmallStrings.cpp:
        (KJS::SmallStrings::singleCharacterStringRep): Added.
        * kjs/SmallStrings.h: Added singleCharacterStringRep for clients that
        need just a UString, not a JSString.
        * kjs/identifier.cpp:
        (KJS::Identifier::add): Added special cases for single character strings
        so that the UString::Rep that ends up in the identifier table is the one
        from the single-character string optimization; otherwise we end up having
        to look it up in the identifier table over and over again.
        (KJS::Identifier::addSlowCase): Ditto.
        (KJS::Identifier::checkSameIdentifierTable): Made this function an empty
        inline in release builds so that callers don't have to put #ifndef NDEBUG
        at each call site.
        * kjs/identifier.h:
        (KJS::Identifier::add): Removed #ifndef NDEBUG around the calls to
        checkSameIdentifierTable.
        (KJS::Identifier::checkSameIdentifierTable): Added. Empty inline version
        for NDEBUG builds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-09-05 Gustavo Noronha Silva <gns@gnome.org>
alp@webkit.org [Sat, 6 Sep 2008 04:08:30 +0000 (04:08 +0000)]
2008-09-05  Gustavo Noronha Silva  <gns@gnome.org>

        Reviewed by Alp Toker.

        https://bugs.webkit.org/show_bug.cgi?id=18346
        [GTK] Remove build warnings

        Applied some casts, and removed an unused typedef to make the
        compiler happy, printing less warnings when building.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBuild fix.
mrowe@apple.com [Sat, 6 Sep 2008 00:56:43 +0000 (00:56 +0000)]
Build fix.

* kjs/JSObject.h: Move the inline virtual destructor after a non-inline
virtual function so that the symbol for the vtable is not marked as a
weakly exported symbol.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Adam Roben.
eric@webkit.org [Sat, 6 Sep 2008 00:21:58 +0000 (00:21 +0000)]
    Reviewed by Adam Roben.

        Build fix for WebKitWin and Chromium

        * platform/FileSystem.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin Adler.
eric@webkit.org [Fri, 5 Sep 2008 22:17:56 +0000 (22:17 +0000)]
    Reviewed by Darin Adler.

        Try to make Chromium compile with ToT:
        - Wrap a few places which depend on KJS:: in #if USE(JSC)
        - Include some windows forward declarations

        * dom/Node.h:
        * page/Console.h:
        * page/animation/CompositeAnimation.h:
        * platform/FileSystem.h:
        * platform/graphics/Image.h:
        * platform/text/AtomicString.h:
        * platform/text/String.cpp:
        * rendering/style/RenderStyle.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-09-04 Dean Jackson <dino@apple.com>
dino@apple.com [Fri, 5 Sep 2008 22:08:18 +0000 (22:08 +0000)]
2008-09-04  Dean Jackson  <dino@apple.com>

        Updates to draft specifications.

        Animations

            * Keyframes must provide 0% and 100% to be valid
              <rdar://problem/6165732> [animations] Spec should say what happens if you omit the 0% or 100% keyframe

            * Mention that keyframes can be specified in any order
              <rdar://problem/6165728> [animations] Spec should say that keyframes can be in any order
              (It actually already said this, but I made it more clear)

            * Keyframe names must be IDENT not STRING
              <rdar://problem/6164640> [animations] should we allow quoted animation names

        Transforms

            * Change transform operation values in CSSTransformValue -
              splitting 2d and 3d.

            * Removed definition of <angle> - now reference CSS Values and Units
              consequence is that rotations now support "turn" units
              (feel free to turn it up to 11)
              <rdar://problem/6177272> [transforms] Should support "turns" as a rotation unit

            * Added exception to CSSMatrix setMatrixValue() and inverse() methods
              <rdar://problem/6160283> [transforms] Specify error reporting for WebKitCSSMatrix

            * Added getCSSMatrix() method to CSSTransformValue

            * Added Table of Contents to Transforms

            * skewZ() transform function removed. It makes no sense.

            * Definition for skew() transform function was missing
            * Also added a new CSSTransformValue CSS_SKEW
              <rdar://problem/6137414> [transforms] skew() function definition is missing

            * Removed mention of transitions when discussion keyframes rule
              <rdar://problem/6103072> [animations] CSS Animation spec mentions transition keyframes

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd support for runtime switchability of the RenderTheme.
hyatt@apple.com [Fri, 5 Sep 2008 21:52:08 +0000 (21:52 +0000)]
Add support for runtime switchability of the RenderTheme.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-09-05 Darin Adler <darin@apple.com>
darin@apple.com [Fri, 5 Sep 2008 21:51:22 +0000 (21:51 +0000)]
2008-09-05  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        - fix https://bugs.webkit.org/show_bug.cgi?id=20671
          JavaScriptCore string manipulation spends too much time in memcpy

        1.011x as fast on SunSpider overall
        1.028x as fast on SunSpider string tests

        For small strings, use a loop rather than calling memcpy. The loop can
        be faster because there's no function call overhead, and because it can
        assume the pointers are aligned instead of checking that. Currently the
        threshold is set at 20 characters, based on some testing on one particular
        computer. Later we can tune this for various platforms by setting
        USTRING_COPY_CHARS_INLINE_CUTOFF appropriately, but it does no great harm
        if not perfectly tuned.

        * kjs/ustring.cpp:
        (KJS::overflowIndicator): Removed bogus const.
        (KJS::maxUChars): Ditto.
        (KJS::copyChars): Added.
        (KJS::UString::Rep::createCopying): Call copyChars instead of memcpy.
        Also eliminated need for const_cast.
        (KJS::UString::expandPreCapacity): Ditto.
        (KJS::concatenate): Ditto.
        (KJS::UString::spliceSubstringsWithSeparators): Ditto.
        (KJS::UString::append): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-09-05 Antti Koivisto <antti@apple.com>
antti@apple.com [Fri, 5 Sep 2008 18:52:05 +0000 (18:52 +0000)]
2008-09-05  Antti Koivisto  <antti@apple.com>

        Qt build fix.

        * svg/SVGFEImageElement.cpp:
        (WebCore::SVGFEImageElement::build):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUpdated some of the ChangeLog files to use the full 64-bit universal version of my...
darin@apple.com [Fri, 5 Sep 2008 18:15:43 +0000 (18:15 +0000)]
Updated some of the ChangeLog files to use the full 64-bit universal version of my name.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-09-05 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Fri, 5 Sep 2008 17:52:39 +0000 (17:52 +0000)]
2008-09-05  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Sam and Alexey.

        Make the profiler work with a null exec state.  This will allow other
        applications start the profiler to get DTrace probes going without
        needing a WebView.

        * ChangeLog:
        * profiler/ProfileGenerator.cpp:
        (KJS::ProfileGenerator::ProfileGenerator):
        (KJS::ProfileGenerator::willExecute):
        (KJS::ProfileGenerator::didExecute):
        * profiler/Profiler.cpp:
        (KJS::Profiler::startProfiling):
        (KJS::Profiler::stopProfiling):
        (KJS::dispatchFunctionToProfiles):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-09-05 Dirk Schulze <vbs85@gmx.de>
aroben@apple.com [Fri, 5 Sep 2008 15:33:28 +0000 (15:33 +0000)]
2008-09-05  Dirk Schulze  <vbs85@gmx.de>

        Gtk build fix

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-09-05 Antti Koivisto <antti@apple.com>
antti@apple.com [Fri, 5 Sep 2008 10:36:59 +0000 (10:36 +0000)]
2008-09-05  Antti Koivisto  <antti@apple.com>

        Another build fix.

        * svg/SVGFEImageElement.cpp:
        (WebCore::SVGFEImageElement::notifyFinished):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-09-05 Antti Koivisto <antti@apple.com>
antti@apple.com [Fri, 5 Sep 2008 10:03:39 +0000 (10:03 +0000)]
2008-09-05  Antti Koivisto  <antti@apple.com>

        Build fixes.

        * WebCore.xcodeproj/project.pbxproj:
        * svg/graphics/filters/SVGFEImage.cpp:
        (WebCore::FEImage::cachedImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-09-05 Antti Koivisto <antti@apple.com>
antti@apple.com [Fri, 5 Sep 2008 09:28:11 +0000 (09:28 +0000)]
2008-09-05  Antti Koivisto  <antti@apple.com>

        Reviewed by Darin.

        Most of the implementation for https://bugs.webkit.org/show_bug.cgi?id=17998
        When a resource is cached locally, WebKit should follow RFC 2616 "Specific end-to-end revalidation" instead of "Unspecified end-to-end revalidation"

        Implement HTTP 1.1 "Specific end-to-end revalidation" for WebCore memory cache. This patch does
        not yet enable it for the biggest use case, reloading. However it is good for general browsing as
        well. Doing this in WebCore level as opposed to relying on disk cache has big benefit that
        we avoid re-decoding resources, especially images.

        To be exact the enabled case is not actually the "Specific end-to-end revalidation" since it does not include
        CacheControl: max-age=0 header. That would be added in reload case.

        The approach for revalidation is to kick the original resource out from the memory cache
        and create a new CachedResource that represents the revalidation request. In case
        we get 304 back for the request we put the original resource back to the cache, update
        its expiration date and switch the clients registered to revalidation resource to be
        clients of the original resource.

        All heap allocated CachedImage pointers now use CachedResourceHandle<CachedImage> (and so on) instead.
        This allows updating the handles to point to the original resource when the revalidation succeeds. It
        also acts as refcounting smart pointer.

        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * css/CSSFontFaceSource.h:
        * css/CSSImportRule.h:
        * dom/Clipboard.h:
        (WebCore::Clipboard::dragImage):
        * dom/ProcessingInstruction.h:
        * dom/ScriptElement.h:
        * dom/XMLTokenizer.cpp:
        (WebCore::XMLTokenizer::isWaitingForScripts):
        * dom/XMLTokenizer.h:
        * html/HTMLImageLoader.cpp:
        (WebCore::HTMLImageLoader::setImage):
        (WebCore::HTMLImageLoader::updateFromElement):
        (WebCore::HTMLImageLoader::notifyFinished):
        * html/HTMLImageLoader.h:
        (WebCore::HTMLImageLoader::image):
        * html/HTMLLinkElement.h:
        * html/HTMLTokenizer.cpp:
        (WebCore::HTMLTokenizer::reset):
        (WebCore::HTMLTokenizer::scriptHandler):
        (WebCore::HTMLTokenizer::notifyFinished):
        * html/HTMLTokenizer.h:
        * loader/Cache.cpp:
        (WebCore::Cache::revalidateResource):
        (WebCore::Cache::revalidationSucceeded):
        (WebCore::Cache::revalidationFailed):
        * loader/Cache.h:
        * loader/CachedResource.cpp:
        (WebCore::CachedResource::CachedResource):
        (WebCore::CachedResource::~CachedResource):
        (WebCore::CachedResource::isExpired):
        (WebCore::CachedResource::setResponse):
        (WebCore::CachedResource::deleteIfPossible):
        (WebCore::CachedResource::setResourceToRevalidate):
        (WebCore::CachedResource::clearResourceToRevalidate):
        (WebCore::CachedResource::switchClientsToRevalidatedResource):
        (WebCore::CachedResource::canUseCacheValidator):
        (WebCore::CachedResource::mustRevalidate):
        * loader/CachedResource.h:
        (WebCore::CachedResource::canDelete):
        (WebCore::CachedResource::registerHandle):
        (WebCore::CachedResource::unregisterHandle):
        (WebCore::CachedResource::isCacheValidator):
        (WebCore::CachedResource::resourceToRevalidate):
        (WebCore::CachedResource::setExpirationDate):
        * loader/CachedResourceHandle.cpp: Added.
        (WebCore::CachedResourceHandleBase::setResource):
        * loader/CachedResourceHandle.h: Added.
        (WebCore::CachedResourceHandleBase::~CachedResourceHandleBase):
        (WebCore::CachedResourceHandleBase::get):
        (WebCore::CachedResourceHandleBase::operator!):
        (WebCore::CachedResourceHandleBase::operator UnspecifiedBoolType):
        (WebCore::CachedResourceHandleBase::CachedResourceHandleBase):
        (WebCore::CachedResourceHandleBase::operator=):
        (WebCore::CachedResourceHandle::CachedResourceHandle):
        (WebCore::CachedResourceHandle::get):
        (WebCore::CachedResourceHandle::operator->):
        (WebCore::CachedResourceHandle::operator=):
        (WebCore::CachedResourceHandle::operator==):
        (WebCore::CachedResourceHandle::operator!=):
        (WebCore::operator==):
        (WebCore::operator!=):
        * loader/DocLoader.cpp:
        (WebCore::DocLoader::checkForReload):
        * loader/UserStyleSheetLoader.h:
        * loader/loader.cpp:
        (WebCore::Loader::Host::servePendingRequests):
        (WebCore::Loader::Host::didFinishLoading):
        (WebCore::Loader::Host::didFail):
        (WebCore::Loader::Host::didReceiveResponse):
        (WebCore::Loader::Host::didReceiveData):
        * page/EventHandler.cpp:
        (WebCore::EventHandler::selectCursor):
        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::setCachedImage):
        (WebCore::RenderImage::imageChanged):
        * rendering/RenderImage.h:
        (WebCore::RenderImage::cachedImage):
        (WebCore::RenderImage::imagePtr):
        * rendering/style/RenderStyle.h:
        * rendering/style/StyleCachedImage.h:
        (WebCore::StyleCachedImage::data):
        (WebCore::StyleCachedImage::cachedImage):
        * svg/SVGFEImageElement.h:
        * svg/graphics/filters/SVGFEImage.h:
        * xml/XSLImportRule.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-09-04 Brady Eidson <beidson@apple.com>
beidson@apple.com [Fri, 5 Sep 2008 04:58:12 +0000 (04:58 +0000)]
2008-09-04  Brady Eidson  <beidson@apple.com>

        Reviewed by Mitz

        <rdar://problem/6180236> - Safari times out connections after 1 or 2 minutes

        A 60-second default timeout was added in http://trac.webkit.org/changeset/17144 in an attempt
        to model default NSURLRequest behavior in a cross-platform manner.

        Sadly by always enforcing this 60 second timeout, WebCore was stomping over the wishes of any Webkit
        client that wished to enforce a much larger default timeout using NSURLRequest API.

        Additionally, upon reviewing what all other browsers do, it seems apparent that "no limit" is desirable
        behavior on the web and this restores previous Safari/WebKit behavior.

        It would be easy to write a layout test for this, but to be effective it would have
        to run for at least 61 seconds, which seems insane until will can parallelize run-webkit-tests

        * manual-tests/timeout-test.html: Added.
        * manual-tests/timeout-test.php: Added.

        * platform/network/ResourceRequestBase.h:
        (WebCore::ResourceRequestBase::ResourceRequestBase):  Rename the constant to "unspecifiedTimeoutInterval"
          and make it UINT_MAX so platforms that do set it have an effective "no timeout."  (Windows, for example)
        * platform/network/mac/ResourceRequestMac.mm:
        (WebCore::ResourceRequest::doUpdatePlatformRequest):  If the timeout for this request is
          "unspecifiedTimeoutInterval", then don't bother setting the timeout using NSURLRequest API, allowing
          WebKit applications to enforce their own default timeout.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
mitz@apple.com [Fri, 5 Sep 2008 04:26:32 +0000 (04:26 +0000)]
WebCore:

        Reviewed by Beth Dakin.

        - fix <rdar://problem/6198514> Changing a button's opacity triggers relayout

        Test: fast/repaint/button-spurious-layout-hint.html

        * rendering/RenderButton.cpp:
        (WebCore::RenderButton::setStyle): Reset the inner block's style box
        flex to 0 to avoid getting a spurious layout hint.

LayoutTests:

        Reviewed by Beth Dakin.

        - pixel test for <rdar://problem/6198514> Changing a button's opacity triggers relayout

        * fast/repaint/button-spurious-layout-hint.html: Added.
        * platform/mac/fast/repaint/button-spurious-layout-hint-expected.checksum: Added.
        * platform/mac/fast/repaint/button-spurious-layout-hint-expected.png: Added.
        * platform/mac/fast/repaint/button-spurious-layout-hint-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36107 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-09-04 Gavin Barraclough <barraclough@apple.com>
ggaren@apple.com [Fri, 5 Sep 2008 03:11:54 +0000 (03:11 +0000)]
2008-09-04  Gavin Barraclough  <barraclough@apple.com>

        Reviewed by Geoffrey Garen.

        Fixed an off-by-one error that would cause the StructureIDChain to
        be one object too short.

        Can't construct a test case because other factors make this not crash
        (yet!).

        * kjs/StructureID.cpp:
        (KJS::StructureIDChain::StructureIDChain):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-09-04 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Fri, 5 Sep 2008 01:26:47 +0000 (01:26 +0000)]
2008-09-04  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Maciej Stachowiak.

        Add a '--args' option to SunSpider, so that we can pass '-j' to TraceMonkey
        and '--expose-gc' to V8. Also, rename the '--v8' option to '--v8-suite' and
        correct the punctuation in its documentation.

        * sunspider:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agowx build fixes.
kevino@webkit.org [Thu, 4 Sep 2008 23:53:04 +0000 (23:53 +0000)]
wx build fixes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
mitz@apple.com [Thu, 4 Sep 2008 23:27:19 +0000 (23:27 +0000)]
WebCore:

        Reviewed by Mark Rowe.

        - roll out r36050 because it made svg/custom/invalid-fill-hex.svg fail,
          and fixing https://bugs.webkit.org/show_bug.cgi?id=15360 appears to
          require a different approach

        * css/CSSGrammar.y:

LayoutTests:

        - roll out r36050 because it made svg/custom/invalid-fill-hex.svg fail,
          and fixing https://bugs.webkit.org/show_bug.cgi?id=15360 appears to
          require a different approach

        * css1/color_and_background/invalid_color-expected.txt: Removed.
        * css1/color_and_background/invalid_color.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix https://bugs.webkit.org/show_bug.cgi?id=20639.
mrowe@apple.com [Thu, 4 Sep 2008 21:44:28 +0000 (21:44 +0000)]
Fix https://bugs.webkit.org/show_bug.cgi?id=20639.
Bug 20639: ENABLE_DASHBOARD_SUPPORT does not need to be a FEATURE_DEFINE

Reviewed by Eric Seidel.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-09-04 Adele Peterson <adele@apple.com>
adele@apple.com [Thu, 4 Sep 2008 21:25:15 +0000 (21:25 +0000)]
2008-09-04  Adele Peterson  <adele@apple.com>

        Build fix.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.vcproj/WTF/WTF.vcproj:
        * JavaScriptCore.vcproj/jsc/jsc.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoMac build fix.
mrowe@apple.com [Thu, 4 Sep 2008 21:00:02 +0000 (21:00 +0000)]
Mac build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Build fix only, no review.
eric@webkit.org [Thu, 4 Sep 2008 20:44:12 +0000 (20:44 +0000)]
    Build fix only, no review.

        * dom/XMLTokenizer.cpp: Fix the Chromium merge build by adding a missing header (the Mac files must include it somewhere).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-09-04 Marco Barisione <marco.barisione@collabora.co.uk>
jmalonzo@webkit.org [Thu, 4 Sep 2008 20:26:16 +0000 (20:26 +0000)]
2008-09-04  Marco Barisione  <marco.barisione@collabora.co.uk>

        Reviewed by Eric Seidel.

        http://bugs.webkit.org/show_bug.cgi?id=20380
        [GTK][AUTOTOOLS] Include autotoolsconfig.h from config.h

        * kjs/config.h: Include the configuration header generated by
        autotools if available.

2008-09-04  Marco Barisione  <marco.barisione@collabora.co.uk>

        Reviewed by Eric Seidel.

        http://bugs.webkit.org/show_bug.cgi?id=20380
        [GTK][AUTOTOOLS] Include autotoolsconfig.h from config.h

        * configure.ac: Rename the configuration header from aconfig.h to autotoolsconfig.h.

2008-09-04  Marco Barisione  <marco.barisione@collabora.co.uk>

        Reviewed by Eric Seidel.

        http://bugs.webkit.org/show_bug.cgi?id=20380
        [GTK][AUTOTOOLS] Include autotoolsconfig.h from config.h

        * config.h: Include the configuration header generated by autotools if
        available.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoPresto change-o!
mrowe@apple.com [Thu, 4 Sep 2008 20:16:05 +0000 (20:16 +0000)]
Presto change-o!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Rubber-stamped by Dave Hyatt.
mitz@apple.com [Thu, 4 Sep 2008 18:15:25 +0000 (18:15 +0000)]
    Rubber-stamped by Dave Hyatt.

        - rename CachedResource::allReferencesRemoved() to allClientsRemoved()

        * loader/CachedFont.cpp:
        (WebCore::CachedFont::allClientsRemoved):
        * loader/CachedFont.h:
        * loader/CachedImage.cpp:
        (WebCore::CachedImage::allClientsRemoved):
        * loader/CachedImage.h:
        * loader/CachedResource.cpp:
        (WebCore::CachedResource::removeClient):
        * loader/CachedResource.h:
        (WebCore::CachedResource::allClientsRemoved):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-09-04 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Thu, 4 Sep 2008 18:08:44 +0000 (18:08 +0000)]
2008-09-04  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Oliver Hunt.

        Bug 20616: Incorporate V8 benchmarks in testing
        <https://bugs.webkit.org/show_bug.cgi?id=20616>

        This is a first attempt at running the V8 benchmarks within SunSpider,
        with the --v8 option. The number of iterations is fixed for each
        benchmark, and was chosen to make each of the benchmarks run between
        500 ms and 600 ms in V8 on my machine, a 2.16 GHz MacBook Pro.

        SunSpider:

        * sunspider:
        * tests/LIST-V8: Added.
        * tests/v8-crypto.js: Added.
        * tests/v8-deltablue.js: Added.
        * tests/v8-earley-boyer.js: Added.
        * tests/v8-raytrace.js: Added.
        * tests/v8-richards.js: Added.

        WebKitTools:

        * Scripts/run-sunspider:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agowx buildbot fix. More robust handling of clean when makefiles are not built or are...
kevino@webkit.org [Thu, 4 Sep 2008 17:51:59 +0000 (17:51 +0000)]
wx buildbot fix. More robust handling of clean when makefiles are not built or are not completely made.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Make JavaScriptCoreGenerated build first instead of WTF
aroben@apple.com [Thu, 4 Sep 2008 16:10:30 +0000 (16:10 +0000)]
    Make JavaScriptCoreGenerated build first instead of WTF

        JavaScriptCoreGenerated does some setup work that we want to happen
        before WTF builds.

        * WebKit.vcproj/WebKit.sln: Reversed the dependencies of WTF and
        JavaScriptCoreGenerated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Ignore warning LNK4221 on Windows
aroben@apple.com [Thu, 4 Sep 2008 16:10:09 +0000 (16:10 +0000)]
    Ignore warning LNK4221 on Windows

        This warning is emitted when an object file with no public symbols is
        passed to the linker/librarian. This often occurs in WebCore for files
        that have been disabled via ENABLE()/USE() macros.

        Rubberstamped by Anders Carlsson.

        * win/tools/vsprops/common.vsprops: Ignore warning LNK4221.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Windows build fix after r36071
aroben@apple.com [Thu, 4 Sep 2008 16:09:53 +0000 (16:09 +0000)]
    Windows build fix after r36071

        We were getting these errors:

        error C2356: initialization segment must not change during translation
        unit

        This was happening because multiple files #included by
        DerivedSources.cpp were themselves #including StaticConstructors.h. I
        fixed the error by adding header guards to StaticConstructors.h so its
        contents will only be included once.

        But it's also not a good idea for StaticConstructors.h to end up in
        DerivedSources.cpp, since it ends up "polluting" all the source files
        we have in there. So I removed all the files that include
        StaticConstructors.h and added some preprocessor directives to
        DerivedSources.cpp to catch this error in the future.

        * DerivedSources.cpp: Removed the *Names.cpp files, which include
        StaticConstructors.h, and added some preprocessor directives to make
        sure we don't end up accidentally including StaticConstructors.h in
        the future.
        * WebCore.vcproj/WebCore.vcproj: Added the *Names.cpp files.
        * platform/StaticConstructors.h: Added header guards.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Windows build fix
aroben@apple.com [Thu, 4 Sep 2008 16:09:33 +0000 (16:09 +0000)]
    Windows build fix

        * platform/graphics/win/FontPlatformData.h: Added a missing #include
        of PassRefPtr.h, and corrected the capitalization of RefCounted.h.
        * platform/text/PlatformString.h: Added a missing #include of
        PassRefPtr.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36090 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-09-04 Tor Arne Vestbø <tavestbo@trolltech.com>
vestbo@webkit.org [Thu, 4 Sep 2008 14:24:58 +0000 (14:24 +0000)]
2008-09-04  Tor Arne Vestbø  <tavestbo@trolltech.com>

        Reviewed by Simon

        Fix the QtWebKit build to match changes in r36016

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-09-04 Tor Arne Vestbø <tavestbo@trolltech.com>
vestbo@webkit.org [Thu, 4 Sep 2008 11:44:17 +0000 (11:44 +0000)]
2008-09-04  Tor Arne Vestbø  <tavestbo@trolltech.com>

        Reviewed by Simon.

        Re-enable support for user stylesheets in QtWebKit

        QtWebKit now follows the FRAME_LOADS_USER_STYLESHEET
        code path, which allows us to keep API support for
        loading user style sheets from remote URLs.

        As part of the change UserStyleSheetLoader.cpp/h was
        moved from WebCore/loader/mac to WebCore/loader.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix the 64-bit build.
mrowe@apple.com [Thu, 4 Sep 2008 09:29:26 +0000 (09:29 +0000)]
Fix the 64-bit build.

* VM/CodeBlock.cpp:
(KJS::CodeBlock::printStructureID): Store the instruction offset into an unsigned local
to avoid a warning related to format specifiers.
(KJS::CodeBlock::printStructureIDs): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-09-04 Alp Toker <alp@nuanti.com>
alp@webkit.org [Thu, 4 Sep 2008 09:14:42 +0000 (09:14 +0000)]
2008-09-04  Alp Toker  <alp@nuanti.com>

        Reviewed by Eric.

        Remove left-over QT and CAIRO platform checks.

        * html/CanvasRenderingContext2D.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix typo
mitz@apple.com [Thu, 4 Sep 2008 08:58:58 +0000 (08:58 +0000)]
Fix typo

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Mark Rowe.
eric@webkit.org [Thu, 4 Sep 2008 08:39:51 +0000 (08:39 +0000)]
    Reviewed by Mark Rowe.

        Fix leak of TextMetrix due to over-ref as see on buildbot.

        * html/TextMetrics.h: use adoptRef since RefCounted starts @ refcount 1 instead of 0 now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36084 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-09-04 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Thu, 4 Sep 2008 08:00:04 +0000 (08:00 +0000)]
2008-09-04  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Rubber-stamped by Oliver Hunt.

        Correct the spelling of 'entryIndices'.

        * kjs/PropertyMap.cpp:
        (KJS::PropertyMap::get):
        (KJS::PropertyMap::getLocation):
        (KJS::PropertyMap::put):
        (KJS::PropertyMap::insert):
        (KJS::PropertyMap::remove):
        (KJS::PropertyMap::checkConsistency):
        * kjs/PropertyMap.h:
        (KJS::PropertyMapHashTable::entries):
        (KJS::PropertyMap::getOffset):
        (KJS::PropertyMap::putOffset):
        (KJS::PropertyMap::offsetForTableLocation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
mitz@apple.com [Thu, 4 Sep 2008 07:26:53 +0000 (07:26 +0000)]
WebCore:

        Reviewed by Dave Hyatt.

        - fix https://bugs.webkit.org/show_bug.cgi?id=19717
          <rdar://problem/6026832> REGRESSION (r31876): menu items render horizontally at the Economist

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::layoutOnlyPositionedObjects): In the
        positioned movement only case, call
        tryLayoutDoingPositionedMovementOnly() and fall back on doing a full
        layout if that fails.
        (WebCore::RenderBlock::layoutPositionedObjects): Ditto.
        * rendering/RenderBox.h:
        (WebCore::RenderBox::tryLayoutDoingPositionedMovementOnly): Renamed
        layoutDoingPositionedMovementOnly to this, and made this function
        check if the width changed. If it did, return, leaving the object
        dirty. The caller can then call layout(). The width can change even
        in the "positioned movement only" case if the object is shrink-to-fit
        and the available width constraint is met. (This was the case in the
        bug).
        * rendering/RenderObject.h:
        (WebCore::RenderObject::tryLayoutDoingPositionedMovementOnly):
        Renamed layoutDoingPositionedMovementOnly() to this.

LayoutTests:

        Reviewed by Dave Hyatt.

        - test for https://bugs.webkit.org/show_bug.cgi?id=19717
          <rdar://problem/6026832> REGRESSION (r31876): menu items render horizontally at the Economist

        * fast/block/positioning/move-with-auto-width.html: Added.
        * platform/mac/fast/block/positioning/move-with-auto-width-expected.checksum: Added.
        * platform/mac/fast/block/positioning/move-with-auto-width-expected.png: Added.
        * platform/mac/fast/block/positioning/move-with-auto-width-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoJavaScriptCore:
ggaren@apple.com [Thu, 4 Sep 2008 07:21:43 +0000 (07:21 +0000)]
JavaScriptCore:

2008-09-03  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Cameron Zwarich.

        Fixed <rdar://problem/6193925> REGRESSION: Crash occurs at
        KJS::Machine::privateExecute() when attempting to load my Mobile Gallery
        (http://www.me.com/gallery/#home)

        also

        https://bugs.webkit.org/show_bug.cgi?id=20633 Crash in privateExecute
        @ cs.byu.edu

        The underlying problem was that we would cache prototype properties
        even if the prototype was a dictionary.

        The fix is to transition a prototype back from dictionary to normal
        status when an opcode caches access to it. (This is better than just
        refusing to cache, since a heavily accessed prototype is almost
        certainly not a true dictionary.)

        * VM/Machine.cpp:
        (KJS::Machine::tryCacheGetByID):
        * kjs/JSObject.h:

LayoutTests:

2008-09-04  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Cameron Zwarich.

        Test for <rdar://problem/6193925> REGRESSION: Crash occurs at
        KJS::Machine::privateExecute() when attempting to load my Mobile Gallery
        (http://www.me.com/gallery/#home)

        also

        https://bugs.webkit.org/show_bug.cgi?id=20633 Crash in privateExecute
        @ cs.byu.edu

        * fast/js/pic/dictionary-prototype-expected.txt: Added.
        * fast/js/pic/dictionary-prototype.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago No review, build fix only.
eric@webkit.org [Thu, 4 Sep 2008 06:31:37 +0000 (06:31 +0000)]
    No review, build fix only.

        Attempt to fix the Qt build.

        * WebCore.pro: add page/animation to include path

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-09-03 Alp Toker <alp@nuanti.com>
alp@webkit.org [Thu, 4 Sep 2008 06:11:46 +0000 (06:11 +0000)]
2008-09-03  Alp Toker  <alp@nuanti.com>

        Build fix following r36073. Include config.h where necessary.

        * WebCoreSupport/PasteboardHelperGtk.cpp:
        * webkit/webkitversion.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoMore Mac build fixes.
mrowe@apple.com [Thu, 4 Sep 2008 03:46:14 +0000 (03:46 +0000)]
More Mac build fixes.

Set ENABLE_DASHBOARD_SUPPORT when building for Mac via build-webkit.
Also set ENABLE_CROSS_DOCUMENT_MESSAGING in order to match the
default configuration specified in the .xcconfig files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoTouch an input file to force a derived file to be rebuilt.
mrowe@apple.com [Thu, 4 Sep 2008 03:29:10 +0000 (03:29 +0000)]
Touch an input file to force a derived file to be rebuilt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix the Mac build.
mrowe@apple.com [Thu, 4 Sep 2008 03:20:30 +0000 (03:20 +0000)]
Fix the Mac build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUpdate layout test results after recent canvas changes.
mrowe@apple.com [Thu, 4 Sep 2008 01:59:31 +0000 (01:59 +0000)]
Update layout test results after recent canvas changes.

* fast/canvas/canvas-invalid-fillstyle-expected.txt:
* fast/canvas/canvas-invalid-strokestyle-expected.txt:
* fast/canvas/drawImage-with-negative-source-destination-expected.txt:
* fast/dom/Window/window-properties-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Sam.
eric@webkit.org [Thu, 4 Sep 2008 01:32:51 +0000 (01:32 +0000)]
    Reviewed by Sam.

        Clean up Platform.h and add PLATFORM(CHROMIUM), PLATFORM(SKIA) and USE(V8_BINDINGS)

        * Configurations/WebCore.xcconfig: add missing ENABLE_*
        * config.h: add rules for V8_BINDINGS

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Sam.
eric@webkit.org [Thu, 4 Sep 2008 01:32:26 +0000 (01:32 +0000)]
    Reviewed by Sam.

        https://bugs.webkit.org/show_bug.cgi?id=20620

        Add #if USE(JSC) around KJS dependencies
        Remove !USE(JAVASCRIPTCORE_BINDINGS) support for 3 reasons:
        1. Most platforms have it on anyway
        2. V8 is going to want to share some of that code
        3. Those platforms which want it off, should have a separate file instead of an #ifdef in our .cpp

        * bindings/js/JSPluginElementFunctions.cpp: remove !USE(JAVASCRIPTCORE_BINDINGS) support
        * config.h: change JAVASCRIPTCORE_BINDINGS to JSC and add USE(V8)
        * html/HTMLAppletElement.cpp: remove USE(JAVASCRIPTCORE_BINDINGS) wrappers
        * html/HTMLAppletElement.h: remove USE(JAVASCRIPTCORE_BINDINGS) wrappers
        * html/HTMLEmbedElement.cpp: remove USE(JAVASCRIPTCORE_BINDINGS) wrappers
        * html/HTMLEmbedElement.h: remove USE(JAVASCRIPTCORE_BINDINGS) wrappers
        * html/HTMLObjectElement.cpp: remove USE(JAVASCRIPTCORE_BINDINGS) wrappers
        * html/HTMLObjectElement.h: remove USE(JAVASCRIPTCORE_BINDINGS) wrappers
        * html/HTMLPlugInElement.cpp: replace USE(JAVASCRIPTCORE_BINDINGS) with USE(JSC) where needed
        * html/HTMLPlugInElement.h: replace USE(JAVASCRIPTCORE_BINDINGS) with USE(JSC) where needed
        * platform/text/AtomicString.cpp: add USE(JSC)
        * platform/text/AtomicString.h: add USE(JSC)
        * platform/text/PlatformString.h: add USE(JSC)
        * platform/text/String.cpp: add USE(JSC)
        * platform/text/StringImpl.cpp: add USE(JSC)
        * platform/text/StringImpl.h: add USE(JSC)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoTidy up some ChangeLog entries.
mrowe@apple.com [Thu, 4 Sep 2008 00:10:39 +0000 (00:10 +0000)]
Tidy up some ChangeLog entries.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-09-03 Dean McNamee <deanm@chromium.org>
mrowe@apple.com [Wed, 3 Sep 2008 23:46:54 +0000 (23:46 +0000)]
2008-09-03  Dean McNamee  <deanm@chromium.org>

        Reviewed by Darin Adler.

        Fix https://bugs.webkit.org/show_bug.cgi?id=20511
        Bug 20511: Remove static initializers on Windows

        Avoid static initializers on Windows by forcing Visual C++ to put
        all static initializers in a code segment that is never executed.

        * config.h:
        * css/MediaFeatureNames.cpp:
        * dom/EventNames.cpp:
        * dom/QualifiedName.cpp:
        * dom/make_names.pl:
        * platform/StaticConstructors.h:
        * platform/text/AtomicString.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-09-03 Dirk Schulze <vbs85@gmx.de>
mrowe@apple.com [Wed, 3 Sep 2008 23:40:49 +0000 (23:40 +0000)]
2008-09-03  Dirk Schulze  <vbs85@gmx.de>

        Reviewed by Dave Hyatt.

        Make FontCairo draw TextStroke and TextFill separately.

        [CAIRO] draw TextFill and TextStroke separately.
        [https://bugs.webkit.org/show_bug.cgi?id=20631]

        * platform/graphics/cairo/FontCairo.cpp:
        (WebCore::Font::drawGlyphs):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-09-03 Peter Kasting <zerodpx@gmail.com>
mrowe@apple.com [Wed, 3 Sep 2008 23:34:40 +0000 (23:34 +0000)]
2008-09-03  Peter Kasting  <zerodpx@gmail.com>

        Reviewed by Dave Hyatt.

        https://bugs.webkit.org/show_bug.cgi?id=19663
        Account for paint and timer lag when animating images.  Also pretend
        that images whose animations were paused (by becoming invisible)
        continued to animate, by "catching up" to the correct frame when they're
        shown again.

        * platform/graphics/BitmapImage.cpp:
        (WebCore::BitmapImage::BitmapImage):
        (WebCore::BitmapImage::startAnimation):
        (WebCore::BitmapImage::advanceAnimation):
        (WebCore::BitmapImage::internalAdvanceAnimation):
        (WebCore::BitmapImage::notifyObserverAndTrimDecodedData):
        * platform/graphics/BitmapImage.h:
        * platform/graphics/cairo/ImageCairo.cpp:
        (WebCore::BitmapImage::draw):
        * platform/graphics/cg/ImageCG.cpp:
        (WebCore::BitmapImage::draw):
        * platform/graphics/qt/ImageQt.cpp:
        (WebCore::BitmapImage::draw):
        * platform/graphics/wx/ImageWx.cpp:
        (WebCore::BitmapImage::draw):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoJavaScriptCore:
kmccullough@apple.com [Wed, 3 Sep 2008 21:53:17 +0000 (21:53 +0000)]
JavaScriptCore:

2008-09-03  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Tim.

        Remove the rest of the "zombie" code from the profiler.
        - There is no longer a need for the ProfilerClient callback mechanism.

        * API/JSProfilerPrivate.cpp:
        (JSStartProfiling):
        * JavaScriptCore.exp:
        * profiler/HeavyProfile.h:
        * profiler/ProfileGenerator.cpp:
        (KJS::ProfileGenerator::create):
        (KJS::ProfileGenerator::ProfileGenerator):
        * profiler/ProfileGenerator.h:
        (KJS::ProfileGenerator::profileGroup):
        * profiler/Profiler.cpp:
        (KJS::Profiler::startProfiling):
        (KJS::Profiler::stopProfiling): Immediately return the profile when
        stopped instead of using a callback.
        * profiler/Profiler.h:
        * profiler/TreeProfile.h:

WebCore:

2008-09-03  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Tim.

        Remove the rest of the "zombie" code from the profiler.
        - There is no longer a need for the ProfilerClient callback mechanism.

        * page/Console.cpp:
        (WebCore::Console::Console):
        (WebCore::Console::profile):
        (WebCore::Console::profileEnd): Move the variables from the header to
        here since we don't have to wait for a callback to use them.
        * page/Console.h:
        * page/InspectorController.cpp:
        (WebCore::InspectorController::startUserInitiatedProfiling):
        (WebCore::InspectorController::stopUserInitiatedProfiling):
        * page/InspectorController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Windows build fix.
adachan@apple.com [Wed, 3 Sep 2008 21:43:44 +0000 (21:43 +0000)]
    Windows build fix.

        * WebCore.vcproj/WebCore.vcproj: Added JSWebKitCSSKeyframeRule.cpp and JSWebKitCSSKeyframesRule.cpp to the project.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-09-01 Dean Jackson <dino@apple.com>
dino@apple.com [Wed, 3 Sep 2008 21:15:53 +0000 (21:15 +0000)]
2008-09-01  Dean Jackson  <dino@apple.com>

        Reviewed by Dave Hyatt.

        https://bugs.webkit.org/show_bug.cgi?id=20594
        Add DOM interfaces for WebKitCSSKeyframeRule
        and WebKitCSSKeyframesRule.

        TEST: LayoutTests/css3/keyframes-rule.html

        * css/WebKitCSSKeyframeRule.idl: Added
        * css/WebKitCSSKeyframesRule.idl: Added

        * bindings/js/JSCSSRuleCustom.cpp:
        (WebCore::toJS):
            Add return of new JS Keyframe rules
        * bindings/objc/DOMInternal.h:
            Include new internal header

        * DerivedSources.make:
        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
            Build configs for new files

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Windows build fix
aroben@apple.com [Wed, 3 Sep 2008 20:30:59 +0000 (20:30 +0000)]
    Windows build fix

        * DerivedSources.cpp: Add JSTextMetrics.cpp to fix the build.
        * WebCore.vcproj/WebCore.vcproj: Add JSTextMetrics.h for
        convenience/consistency.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-09-03 Adele Peterson <adele@apple.com>
adele@apple.com [Wed, 3 Sep 2008 20:13:41 +0000 (20:13 +0000)]
2008-09-03  Adele Peterson  <adele@apple.com>

        Build fix.

        * WebCore.vcproj/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agogit-svn-id: https://svn.webkit.org/repository/webkit/trunk@36063 268f45cc-cd09-0410...
hyatt@apple.com [Wed, 3 Sep 2008 19:06:59 +0000 (19:06 +0000)]
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-09-03 Adele Peterson <adele@apple.com>
adele@apple.com [Wed, 3 Sep 2008 19:02:45 +0000 (19:02 +0000)]
2008-09-03  Adele Peterson  <adele@apple.com>

        Build fix.

        * wtf/win/MainThreadWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
hyatt@apple.com [Wed, 3 Sep 2008 18:32:05 +0000 (18:32 +0000)]
WebCore:

2008-09-03  David Hyatt  <hyatt@apple.com>

        Fix for bug 18203, right floats should be allowed to overflow past the left border edge.

        Reviewed by Darin (ages ago)

        Added fast/block/float/clamped-right-float.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::positionNewFloats):

LayoutTests:

2008-09-03  David Hyatt  <hyatt@apple.com>

        Fix for bug 18203.

        Reviewed by Darin (ages ago).

        * fast/block/float/clamped-right-float.html: Added.
        * platform/mac/fast/block/float/clamped-right-float-expected.checksum: Added.
        * platform/mac/fast/block/float/clamped-right-float-expected.png: Added.
        * platform/mac/fast/block/float/clamped-right-float-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
hyatt@apple.com [Wed, 3 Sep 2008 18:13:39 +0000 (18:13 +0000)]
WebCore:

2008-09-02  David Hyatt  <hyatt@apple.com>

        Add support for canvas text drawing APIs.

        Reviewed by olliej

        Tests added as fast/canvas/canvas-text-*.html

        * DerivedSources.make:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSCanvasRenderingContext2DCustom.cpp:
        (WebCore::JSCanvasRenderingContext2D::fillText):
        (WebCore::JSCanvasRenderingContext2D::strokeText):
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::initForStyleResolve):
        (WebCore::CSSStyleSelector::applyPropertyToStyle):
        * css/CSSStyleSelector.h:
        * html/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::State::State):
        (WebCore::CanvasRenderingContext2D::font):
        (WebCore::CanvasRenderingContext2D::setFont):
        (WebCore::CanvasRenderingContext2D::textAlign):
        (WebCore::CanvasRenderingContext2D::setTextAlign):
        (WebCore::CanvasRenderingContext2D::textBaseline):
        (WebCore::CanvasRenderingContext2D::setTextBaseline):
        (WebCore::CanvasRenderingContext2D::fillText):
        (WebCore::CanvasRenderingContext2D::strokeText):
        (WebCore::CanvasRenderingContext2D::measureText):
        (WebCore::CanvasRenderingContext2D::drawTextInternal):
        (WebCore::CanvasRenderingContext2D::accessFont):
        * html/CanvasRenderingContext2D.h:
        * html/CanvasRenderingContext2D.idl:
        * html/TextMetrics.h: Added.
        (WebCore::TextMetrics::create):
        (WebCore::TextMetrics::width):
        (WebCore::TextMetrics::setWidth):
        (WebCore::TextMetrics::TextMetrics):
        * html/TextMetrics.idl: Added.
        * platform/graphics/Font.cpp:
        (WebCore::Font::lineGap):
        * platform/graphics/Font.h:
        * platform/graphics/GraphicsContext.cpp:
        (WebCore::GraphicsContext::drawBidiText):
        * platform/graphics/GraphicsContext.h:
        * platform/graphics/GraphicsTypes.cpp:
        (WebCore::textAlignName):
        (WebCore::parseTextAlign):
        (WebCore::textBaselineName):
        (WebCore::parseTextBaseline):
        * platform/graphics/GraphicsTypes.h:
        (WebCore::):

LayoutTests:

2008-09-02  David Hyatt  <hyatt@apple.com>

        Add support for the canvas text APIs.

        Reviewed by olliej

        * fast/canvas/canvas-text-alignment.html: Added.
        * fast/canvas/canvas-text-baseline.html: Added.
        * platform/mac/fast/canvas/canvas-text-alignment-expected.checksum: Added.
        * platform/mac/fast/canvas/canvas-text-alignment-expected.png: Added.
        * platform/mac/fast/canvas/canvas-text-alignment-expected.txt: Added.
        * platform/mac/fast/canvas/canvas-text-baseline-expected.checksum: Added.
        * platform/mac/fast/canvas/canvas-text-baseline-expected.png: Added.
        * platform/mac/fast/canvas/canvas-text-baseline-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-09-03 John Sullivan <sullivan@apple.com>
sullivan@apple.com [Wed, 3 Sep 2008 17:37:24 +0000 (17:37 +0000)]
2008-09-03  John Sullivan  <sullivan@apple.com>

        Fixed <rdar://problem/6193022> <rdar://problem/6193022> Crash occurs at WebCore::AnimationBase::propertiesEqual () after certain steps

        Fixed by Darin, reviewed by me

        * page/animation/AnimationBase.cpp:
        (WebCore::AnimationBase::propertiesEqual):
        added ensurePropertyMap() to this static function
        (WebCore::AnimationBase::getPropertyAtIndex):
        ditto
        (WebCore::AnimationBase::getNumProperties):
        ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoJavaScriptCore:
kmccullough@apple.com [Wed, 3 Sep 2008 17:35:42 +0000 (17:35 +0000)]
JavaScriptCore:

2008-09-02  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Darin and Tim.

        Remove most of the "zombie" mode from the profiler.  Next we will need
        to remove the client callback mechanism in profiles.

        - This simplifies the code, leverages the recent changes I've made in
        getting line numbers from SquirrelFish, and is a slight speed
        improvement on SunSpider.
        - Also the "zombie" mode was a constant source of odd edge cases and
        obscure bugs so it's good to remove since all of its issues may not have
        been found.

        * API/JSProfilerPrivate.cpp: No need to call didFinishAllExecution() any
        more.
        (JSEndProfiling):
        * JavaScriptCore.exp: Export the new signature of retrieveLastCaller()
        * VM/Machine.cpp:
        (KJS::Machine::execute): No need to call didFinishAllExecution() any
        more.
        (KJS::Machine::retrieveCaller): Now operates on InternalFunctions now
        since the RegisterFile is no longer guaranteeded to store only
        JSFunctions
        (KJS::Machine::retrieveLastCaller): Now also retrieve the function's
        name
        (KJS::Machine::callFrame): A result of changing retrieveCaller()
        * VM/Machine.h:
        * VM/Register.h:
        * kjs/JSGlobalObject.cpp:
        (KJS::JSGlobalObject::~JSGlobalObject):
        * kjs/nodes.h:
        * profiler/ProfileGenerator.cpp:
        (KJS::ProfileGenerator::create): Now pass the original exec and get the
        global exec and client when necessary.  We need the original exec so we
        can have the stack frame where profiling started.
        (KJS::ProfileGenerator::ProfileGenerator): ditto.
        (KJS::ProfileGenerator::addParentForConsoleStart): This is where the
        parent to star of the profile is added, if there is one.
        (KJS::ProfileGenerator::willExecute): Remove uglyness!
        (KJS::ProfileGenerator::didExecute): Ditto!
        (KJS::ProfileGenerator::stopProfiling):
        (KJS::ProfileGenerator::removeProfileStart): Use a better way to find
        and remove the function we are looking for.
        (KJS::ProfileGenerator::removeProfileEnd): Ditto.
        * profiler/ProfileGenerator.h:
        (KJS::ProfileGenerator::client):
        * profiler/ProfileNode.cpp:
        (KJS::ProfileNode::removeChild): Add a better way to remove a child from
        a ProfileNode.
        (KJS::ProfileNode::stopProfiling):
        (KJS::ProfileNode::debugPrintData): Modified a debug-only diagnostic
        function to be sane.
        * profiler/ProfileNode.h:
        * profiler/Profiler.cpp: Change to pass the original exec state.
        (KJS::Profiler::startProfiling):
        (KJS::Profiler::stopProfiling):
        (KJS::Profiler::willExecute):
        (KJS::Profiler::didExecute):
        (KJS::Profiler::createCallIdentifier):
        * profiler/Profiler.h:

WebCore:

2008-09-03  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Darin and Tim.

        Remove most of the "zombie" mode from the profiler.  Next we will need
        to remove the client callback mechanism in profiles.
        - These changes are a result of changes to JSCore.

        * manual-tests/inspector/profiler-test-nested-start-and-stop-profiler.html:
        * page/Console.cpp:
        (WebCore::retrieveLastCaller):
        (WebCore::Console::profileEnd):
        * page/InspectorController.cpp:
        (WebCore::InspectorController::stopUserInitiatedProfiling):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
adele@apple.com [Wed, 3 Sep 2008 16:57:58 +0000 (16:57 +0000)]
WebCore:

2008-09-03  Adele Peterson  <adele@apple.com>

        Reviewed by Darin Adler.

        Test: fast/forms/search-display-none-cancel-button.html

        Allow display:none to work on a search field's cancel button.  Prepare for adding more style-ability for the results button too.

        * css/html4.css: Set display:inline-block for these buttons.  Now they can be overridden by a web author.

        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::setStyle): Add nil checks for the button renderers.
        (WebCore::RenderTextControl::createResultsButtonStyle): Don't set the display explicitly.  This is now done in html4.css.
        (WebCore::RenderTextControl::createCancelButtonStyle): ditto.
        (WebCore::RenderTextControl::createSubtreeIfNeeded):
        Reorganize this code so our complicated way of adding shadow nodes is abstracted out into the TextControlInnerElement class.
        (WebCore::RenderTextControl::updateFromElement): Added nil checks for the button renderers.
        (WebCore::RenderTextControl::subtreeHasChanged): ditto.
        (WebCore::RenderTextControl::calcHeight): ditto.
        (WebCore::RenderTextControl::nodeAtPoint): ditto.
        (WebCore::RenderTextControl::layout): ditto.
        (WebCore::RenderTextControl::calcPrefWidths): ditto.
        (WebCore::RenderTextControl::clientPaddingLeft): ditto.
        (WebCore::RenderTextControl::clientPaddingRight): ditto.

        * rendering/TextControlInnerElements.cpp:
        (WebCore::RenderTextControlInnerBlock::RenderTextControlInnerBlock): Moved from RenderTextControl.cpp.
        (WebCore::RenderTextControlInnerBlock::nodeAtPoint): ditto.
        (WebCore::TextControlInnerElement::attachInnerElement): Added.
         This does all the separate steps of attaching a shadow node that used to be repeated in RenderTextControl::createSubtreeIfNeeded for each element.
        (WebCore::TextControlInnerTextElement::createRenderer): Added.  Creates a RenderTextControlInnerBlock.
        * rendering/TextControlInnerElements.h:

LayoutTests:

2008-09-03  Adele Peterson  <adele@apple.com>

        Reviewed by Darin Adler.

        Test that display:none works on a search field's cancel button.

        * fast/forms/search-display-none-cancel-button.html: Added.
        * platform/mac/fast/forms/search-display-none-cancel-button-expected.checksum: Added.
        * platform/mac/fast/forms/search-display-none-cancel-button-expected.png: Added.
        * platform/mac/fast/forms/search-display-none-cancel-button-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin Adler.
ap@webkit.org [Wed, 3 Sep 2008 16:37:00 +0000 (16:37 +0000)]
    Reviewed by Darin Adler.

        Implement callOnMainThreadAndWait().

        This will be useful when a background thread needs to perform UI calls synchronously
        (e.g. an openDatabase() call cannot return until the user answers to a confirmation dialog).

        * wtf/MainThread.cpp:
        (WTF::FunctionWithContext::FunctionWithContext): Added a ThreadCondition member. When
        non-zero, the condition is signalled after the function is called.
        (WTF::mainThreadFunctionQueueMutex): Renamed from functionQueueMutex, sinc this is no longer
        static. Changed to be initialized from initializeThreading() to avoid lock contention.
        (WTF::initializeMainThread): On non-Windows platforms, just call mainThreadFunctionQueueMutex.
        (WTF::dispatchFunctionsFromMainThread): Signal synchronous calls when done.
        (WTF::callOnMainThread): Updated for functionQueueMutex rename.
        (WTF::callOnMainThreadAndWait):  Added.

        * wtf/MainThread.h: Added callOnMainThreadAndWait(); initializeMainThread() now exists on
        all platforms.

        * wtf/win/MainThreadWin.cpp: (WTF::initializeMainThread): Added a callOnMainThreadAndWait()
        call to initialize function queue mutex.

        * wtf/ThreadingGtk.cpp: (WTF::initializeThreading):
        * wtf/ThreadingPthreads.cpp: (WTF::initializeThreading):
        * wtf/ThreadingQt.cpp: (WTF::initializeThreading):
        Only initialize mainThreadIdentifier on non-Darwin platforms. It was not guaranteed to be
        accurate on Darwin.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36056 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-09-03 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Wed, 3 Sep 2008 16:20:43 +0000 (16:20 +0000)]
2008-09-03  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Darin Adler.

        Use isUndefinedOrNull() instead of separate checks for each in op_eq_null
        and op_neq_null.

        * VM/Machine.cpp:
        (KJS::Machine::privateExecute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Maciej.
ap@webkit.org [Wed, 3 Sep 2008 08:08:19 +0000 (08:08 +0000)]
    Reviewed by Maciej.

        Elminate SQLiteAuthorizer class.

        * WebCore.xcodeproj/project.pbxproj:
        * WebCore.vcproj/WebCore.vcproj:
        * GNUmakefile.am
        Removed SQLiteAuthorizer.h.

        * platform/sql/SQLiteAuthorizer.cpp:
        * platform/sql/SQLiteAuthorizer.h: Removed.
        * platform/sql/SQLiteDatabase.cpp:
        (WebCore::SQLiteDatabase::authorizerFunction):
        (WebCore::SQLiteDatabase::setAuthorizer):
        * platform/sql/SQLiteDatabase.h:
        * storage/DatabaseAuthorizer.h:
        (WebCore::DatabaseAuthorizer::create):
        (WebCore::DatabaseAuthorizer::createView):
        (WebCore::DatabaseAuthorizer::createTempView):
        (WebCore::DatabaseAuthorizer::dropView):
        (WebCore::DatabaseAuthorizer::dropTempView):
        (WebCore::DatabaseAuthorizer::allowSelect):
        (WebCore::DatabaseAuthorizer::allowReindex):
        Merge SQLiteAuthorizer and DatabaseAuthorizer, as keeping them separate serves no purpose.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36054 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoMove the backslash to the right place.
mrowe@apple.com [Wed, 3 Sep 2008 07:09:45 +0000 (07:09 +0000)]
Move the backslash to the right place.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36053 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-09-03 Dirk Schulze <vbs85@gmx.de>
mrowe@apple.com [Wed, 3 Sep 2008 07:05:48 +0000 (07:05 +0000)]
2008-09-03  Dirk Schulze  <vbs85@gmx.de>

        Reviewed and tweaked by Mark Rowe.

        WebKitGtk build fix.

        * GNUmakefile.am:
        * page/animation/AnimationController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-09-02 Robert Blaut <webkit@blaut.biz>
mrowe@apple.com [Wed, 3 Sep 2008 06:59:03 +0000 (06:59 +0000)]
2008-09-02  Robert Blaut  <webkit@blaut.biz>

        Reviewed by Geoff Garen.

        Fix for <https://bugs.webkit.org/show_bug.cgi?id=16913>
        Misplaced elements should not close DL lists.

        Test: fast/invalid/test-case-tr-th-td-should-not-close-dl-list.html

        * html/HTMLParser.cpp:
        (WebCore::HTMLParser::handleError):

2008-09-02  Robert Blaut  <webkit@blaut.biz>

        Reviewed by Geoff Garen.

        Test for <https://bugs.webkit.org/show_bug.cgi?id=16913>
        Misplaced elements should not close DL lists.

        * fast/invalid/test-case-tr-th-td-should-not-close-dl-list-expected.txt: Added.
        * fast/invalid/test-case-tr-th-td-should-not-close-dl-list.html: Added.
        * platform/mac/fast/invalid/missing-dl-end-tag-expected.checksum:
        * platform/mac/fast/invalid/missing-dl-end-tag-expected.png:
        * platform/mac/fast/invalid/missing-dl-end-tag-expected.txt:
        * platform/mac/fast/invalid/missing-dt-end-tag-expected.checksum:
        * platform/mac/fast/invalid/missing-dt-end-tag-expected.png:
        * platform/mac/fast/invalid/missing-dt-end-tag-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36051 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-09-02 Glenn Wilson <wilsong@gmail.com>
mrowe@apple.com [Wed, 3 Sep 2008 06:51:31 +0000 (06:51 +0000)]
2008-09-02  Glenn Wilson  <wilsong@gmail.com>

        Reviewed by Darin Adler.

        Fix for <https://bugs.webkit.org/show_bug.cgi?id=15360>
        Bug 15360: color:#{predefined colorName} is treated as colorName in Safari

        We would inappropriately interpret and apply an invalid CSS "color" property
        when the value is a predefined color preceded by a '#' symbol.  For example,
        style="color:#gray;" would apply the color gray when it should not.

        In the bison template, "hexcolor" was defined as both "HEX maybe_space" OR "IDENT maybe_space".
        This caused identifiers not fitting the appropriate hex format but preceded by a '#' to be
        interpreted as a valid color (CSSPrimitiveValue::CSS_PARSER_HEXCOLOR), when it was really just
        an ignorable token.

        To correct this, "IDENT maybe_space" was removed from "hexcolor" and added under "term" as
        '#' IDENT maybe_space, which is then processed as a CSSPrimitiveValue::CSS_STRING instead of
        CSSPrimitiveValue::CSS_PARSER_HEXCOLOR.

        Test: css1/color_and_background/invalid_color.html

        * css/CSSGrammar.y:

2008-09-02  Glenn Wilson  <wilsong@gmail.com>

        Reviewed by Darin Adler.

        Test for <https://bugs.webkit.org/show_bug.cgi?id=15360>
        Bug 15360: color:#{predefined colorName} is treated as colorName in Safari

        Added new test to verify that CSS "color" attributes with '#'-preceeded predefined color names
        are not rendered in those colors.

        * css1/color_and_background/invalid_color.html: Added.
        * css1/color_and_background/invalid_color-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36050 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBuild fix. Remove the now unnecessary check for "4" in the user agent string.
mrowe@apple.com [Wed, 3 Sep 2008 06:38:04 +0000 (06:38 +0000)]
Build fix.  Remove the now unnecessary check for "4" in the user agent string.

Reviewed by Tim Hatcher.

* WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@36049 268f45cc-cd09-0410-ab3c-d52691b4dbfc