ap [Tue, 31 Oct 2006 18:43:09 +0000 (18:43 +0000)]
2006-10-31 MorganL <morganl.webkit@yahoo.com>
Reviewed by Maciej.
Fixes http://bugs.webkit.org/show_bug.cgi?id=11286
Includes some CRLF -> LF fixups.
* platform/win/CookieJarWin.cpp:
(WebCore::cookies):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17485
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Tue, 31 Oct 2006 18:19:14 +0000 (18:19 +0000)]
Reviewed by Steve.
Fix some incorrect forward declarations.
* loader/FrameLoader.h:
* page/Frame.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17484
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Tue, 31 Oct 2006 18:16:08 +0000 (18:16 +0000)]
2006-10-31 Vladimir Olexa <vladimir.olexa@gmail.com>
Reviewed by Geoff.
http://bugs.webkit.org/show_bug.cgi?id=4166
Function object does not support caller property
Test: fast/js/caller-property.html
* kjs/function.cpp:
(KJS::FunctionImp::callerGetter): added
(KJS::FunctionImp::getOwnPropertySlot): added if statement to handle callerGetter()
* kjs/function.h: added callerGetter() declaration
* kjs/identifier.h: added caller property macro
* tests/mozilla/expected.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17483
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Tue, 31 Oct 2006 17:45:42 +0000 (17:45 +0000)]
Reviewed by Maciej.
- fixed "Stop and reload don't work on the WebView"
http://bugs.webkit.org/show_bug.cgi?id=11285
* COM/WebFrame.cpp:
(WebFrame::stopLoading): Implement.
* COM/WebView.cpp:
(WebView::stopLoading): ditto
(WebView::reload): ditto
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17482
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Tue, 31 Oct 2006 17:20:32 +0000 (17:20 +0000)]
2006-10-31 Simon Hausmann <hausmann@kde.org>
Reviewed by Maciej.
* QtLauncher/main.cpp:
(main): Declare our frame as main frame to the Page object.
Fixes crashes on various web sites
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17481
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Tue, 31 Oct 2006 16:49:59 +0000 (16:49 +0000)]
* DumpRenderTree/DumpRenderTree.m: Instead of allocating a single local
pasteboard, allocate any number of local pasteboards.
(main): Allocate the dictionary of pasteboards.
(+[DumpRenderTreePasteboard _pasteboardWithName:]): Allocate a pasteboard,
given a name.
(+[LocalPasteboard alloc]): Added, so we don't have to call NSAllocateObject
explicitly elsewhere.
(-[LocalPasteboard addTypes:owner:]): Added a check that the owner responds
to the selector rather than calling unconditionally.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17480
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Tue, 31 Oct 2006 16:40:17 +0000 (16:40 +0000)]
* WebCore.xcodeproj/project.pbxproj: Change GraphicsTypes.h to a private header to
try to fix the build on the buildbot.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17479
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Tue, 31 Oct 2006 16:16:01 +0000 (16:16 +0000)]
* bridge/mac/FrameMac.mm:
(WebCore::FrameMac::advanceToNextMisspelling): Build fix for release Tiger builds.
(WebCore::FrameMac::markMisspellings): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17478
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan [Tue, 31 Oct 2006 14:26:46 +0000 (14:26 +0000)]
* bridge/mac/FrameMac.mm:
(WebCore::FrameMac::advanceToNextMisspelling):
build fix: needed #ifndef BUILDING_ON_TIGER in one more place
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17477
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan [Tue, 31 Oct 2006 14:18:37 +0000 (14:18 +0000)]
Reviewed by Adam Roben
- fixes <rdar://problem/
4804614> Bad grammar ranges are not visibly marked
This patch introduces much of the guts of grammar checking, though still not enough to actually
check grammar sensibly, due to:
<rdar://problem/
4811175> Many false reports of bad grammar appear, caused by insufficient
context passed to grammar checker
* platform/Logging.h:
* platform/Logging.cpp:
new log channel SpellingAndGrammar
* bridge/mac/WebCorePageBridge.mm:
(initializeLoggingChannelsIfNecessary):
initialize new log channel
* bridge/mac/FrameMac.mm:
(WebCore::FrameMac::advanceToNextMisspelling):
Compute bad grammar range when computing misspelling range. Find first detailed grammar range from the
set NSSpellChecker determines. Compare it with misspelling range to see which is earliest (or shortest
in the event of a tie), and do further processing with that one (select range; create marker that
causes range to be visibly marked with a funky underline; update spelling panel appropriately).
(WebCore::FrameMac::markMisspellings):
More or less the same types of changes as in advanceToNextMisspelling The loops are structured just
differently enough to make sharing code between these two functions a little tricky, so I decided to
save that for a later patch.
(WebCore::FrameMac::respondToChangedSelection):
remove grammar markers when we remove spelling markers
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17476
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Tue, 31 Oct 2006 12:36:32 +0000 (12:36 +0000)]
2006-10-31 Nikolas Zimmermann <zimmermann@kde.org>
Reviewed by Mitz.
Fix Qt/Linux build with older gcc3.3.4.
* bindings/js/kjs_window.cpp:
(KJS::WindowFunc::callAsFunction):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17475
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Tue, 31 Oct 2006 12:24:43 +0000 (12:24 +0000)]
Remove obsolete KCanvasClipperQt.h which should have been removed in r17467.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17474
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Tue, 31 Oct 2006 11:47:47 +0000 (11:47 +0000)]
2006-10-31 Zack Rusin <zack@kde.org>
Reviewed by Mitz.
Fix the Qt build after last nights changes.
* platform/qt/FrameQt.cpp:
* platform/qt/EditorClientQt.h:
* platform/qt/EditorClientQt.cpp:
* platform/graphics/svg/qt/SVGResourceImageQt.cpp:
* platform/graphics/svg/qt/SVGResourceClipperQt.cpp:
* CMakeLists.txt:
* kcanvas/device/qt/KRenderingDeviceQt.cpp:
2006-10-31 Zack Rusin <zack@kde.org>
Reviewed by Mitz.
Fix the Qt build after last nights changes.
* QtLauncher/CMakeLists.txt:
* WebKitPart/CMakeLists.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17473
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Tue, 31 Oct 2006 05:50:14 +0000 (05:50 +0000)]
- fixed build
* DumpRenderTree/DumpRenderTree.m: (-[LocalPasteboard setString:forType:]):
Don't use CFPasteboard.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17472
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Tue, 31 Oct 2006 05:46:02 +0000 (05:46 +0000)]
Reviewed by Anders.
- remove BrowserExtension
* WebCore.vcproj/WebCore/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/kjs_window.cpp:
(KJS::createNewWindow):
(KJS::WindowFunc::callAsFunction):
* bridge/BrowserExtension.h: Removed.
* bridge/mac/BrowserExtensionMac.h: Removed.
* bridge/mac/BrowserExtensionMac.mm: Removed.
* bridge/mac/FrameMac.mm:
(WebCore::FrameMac::FrameMac):
(WebCore::FrameMac::submitForm):
(WebCore::FrameMac::urlSelected):
* bridge/win/BrowserExtensionWin.cpp: Removed.
* bridge/win/BrowserExtensionWin.h: Removed.
* bridge/win/FrameWin.cpp:
(WebCore::FrameWin::FrameWin):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::createWindow):
* loader/FrameLoader.h:
* loader/icon/IconLoader.cpp:
* loader/mac/FrameLoaderMac.mm:
(WebCore::FrameLoader::safeLoad):
(WebCore::FrameLoader::load):
(WebCore::FrameLoader::createWindow):
* page/Frame.cpp:
(WebCore::Frame::urlSelected):
(WebCore::Frame::requestFrame):
(WebCore::Frame::submitForm):
(WebCore::Frame::scheduleHistoryNavigation):
(WebCore::Frame::redirectionTimerFired):
* page/Frame.h:
* page/FrameLoadRequest.h:
(WebCore::FrameLoadRequest::FrameLoadRequest):
(WebCore::FrameLoadRequest::isEmpty):
(WebCore::FrameLoadRequest::resourceRequest):
(WebCore::FrameLoadRequest::frameName):
(WebCore::FrameLoadRequest::setFrameName):
* page/FramePrivate.h:
(WebCore::FramePrivate::FramePrivate):
(WebCore::FramePrivate::~FramePrivate):
* platform/gdk/BrowserExtensionGdk.h: Removed.
* platform/gdk/FrameGdk.cpp:
(WebCore::FrameGdk::FrameGdk):
* platform/gdk/TemporaryLinkStubs.cpp:
* platform/network/ResourceRequest.h:
(WebCore::ResourceRequest::isEmpty):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17471
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Tue, 31 Oct 2006 05:45:25 +0000 (05:45 +0000)]
* Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]):
Fix comment.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17470
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Tue, 31 Oct 2006 05:29:07 +0000 (05:29 +0000)]
Reviewed by Tim H.
Fixes: http://bugs.webkit.org/show_bug.cgi?id=11353
* Drosera/debugger.js: ParsedURL() object now recognizes local files
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17469
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Tue, 31 Oct 2006 04:48:08 +0000 (04:48 +0000)]
Reviewed by Tim Hatcher.
* DumpRenderTree/DumpRenderTree.m: Changed to allocate a local pasteboard.
This should make our buildbot tests no longer need a pasteboard server.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17468
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver [Tue, 31 Oct 2006 04:17:43 +0000 (04:17 +0000)]
2006-10-31 Nikolas Zimmermann <zimmermann@kde.org>
Reviewed by Oliver.
Modified from original due to earlier reversion
Fixes: http://bugs.webkit.org/show_bug.cgi?id=11436
Better SVG integration in WebKit, Part I.
The patch is mostly about creating a new platform/graphics directory, and
moving the kcanvas resources (clipper/masker/marker) there (in svg budir),
with a new name (KCanvasClipper -> SVGResourceClipper). Also fix several ownership
issues, by using ref counting (the SVG classes now store RefPtrs to the resources).
KCanvasFilters is still left in kcanvas/ subdirectory, to be converted in a next patch.
All details of the patch, and upcoming patches can be found in the bug report.
* CMakeLists.txt:
* WebCore.xcodeproj/project.pbxproj:
* graphics/svg/SVGResource.cpp: Removed.
* graphics/svg/SVGResourceClipper.cpp: Removed.
* graphics/svg/SVGResourceClipper.h: Removed.
* graphics/svg/SVGResourceImage.h: Removed.
* graphics/svg/SVGResourceListener.h: Removed.
* graphics/svg/SVGResourceMarker.cpp: Removed.
* graphics/svg/SVGResourceMarker.h: Removed.
* graphics/svg/SVGResourceMasker.cpp: Removed.
* graphics/svg/SVGResourceMasker.h: Removed.
* kcanvas/KCanvasClipper.cpp: Removed.
* kcanvas/KCanvasClipper.h: Removed.
* kcanvas/KCanvasCreator.cpp: Removed.
* kcanvas/KCanvasCreator.h: Removed.
* kcanvas/KCanvasFilters.cpp:
(WebCore::getFilterById):
* kcanvas/KCanvasFilters.h:
* kcanvas/KCanvasImage.h: Removed.
* kcanvas/KCanvasMarker.cpp: Removed.
* kcanvas/KCanvasMarker.h: Removed.
* kcanvas/KCanvasMasker.cpp: Removed.
* kcanvas/KCanvasMasker.h: Removed.
* kcanvas/KCanvasResource.cpp: Removed.
* kcanvas/KCanvasResource.h: Removed.
* kcanvas/KCanvasResourceListener.h: Removed.
* kcanvas/KCanvasTreeDebug.cpp:
(WebCore::writeRenderResources):
* kcanvas/device/KRenderingDevice.h:
* kcanvas/device/KRenderingPaintServer.h:
(WebCore::KRenderingPaintServer::KRenderingPaintServer):
* kcanvas/device/KRenderingPaintServerGradient.cpp:
(WebCore::KRenderingPaintServerGradient::listener):
(WebCore::KRenderingPaintServerGradient::setListener):
* kcanvas/device/KRenderingPaintServerGradient.h:
* kcanvas/device/KRenderingPaintServerPattern.cpp:
(WebCore::KRenderingPaintServerPattern::KRenderingPaintServerPattern):
(WebCore::KRenderingPaintServerPattern::~KRenderingPaintServerPattern):
(WebCore::KRenderingPaintServerPattern::tile):
(WebCore::KRenderingPaintServerPattern::setTile):
(WebCore::KRenderingPaintServerPattern::listener):
(WebCore::KRenderingPaintServerPattern::setListener):
* kcanvas/device/KRenderingPaintServerPattern.h:
* kcanvas/device/KRenderingPaintServerSolid.h:
* kcanvas/device/qt/KCanvasClipperQt.cpp: Removed.
* kcanvas/device/qt/KCanvasClipperQt.h:
* kcanvas/device/qt/KRenderingDeviceQt.cpp:
(WebCore::KRenderingDeviceQt::contextForImage):
(WebCore::KRenderingDeviceQt::createResource):
(WebCore::KRenderingDeviceQt::createPaintServer):
* kcanvas/device/qt/KRenderingDeviceQt.h:
* kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp:
* kcanvas/device/qt/KRenderingPaintServerPatternQt.cpp:
* kcanvas/device/qt/KRenderingPaintServerQt.cpp:
* kcanvas/device/qt/KRenderingPaintServerSolidQt.cpp:
* kcanvas/device/qt/RenderPathQt.h: Removed.
* kcanvas/device/quartz/KCanvasFilterQuartz.mm:
(WebCore::KCanvasFilterQuartz::getCIFilterStack):
* kcanvas/device/quartz/KCanvasItemQuartz.mm:
* kcanvas/device/quartz/KCanvasMaskerQuartz.h: Removed.
* kcanvas/device/quartz/KCanvasMaskerQuartz.mm: Removed.
* kcanvas/device/quartz/KCanvasResourcesQuartz.h: Removed.
* kcanvas/device/quartz/KCanvasResourcesQuartz.mm: Removed.
* kcanvas/device/quartz/KRenderingDeviceQuartz.h:
* kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
(WebCore::KRenderingDeviceQuartz::contextForImage):
(WebCore::KRenderingDeviceQuartz::createPaintServer):
(WebCore::KRenderingDeviceQuartz::createResource):
* kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
(WebCore::KRenderingPaintServerGradientQuartz::KRenderingPaintServerGradientQuartz):
(WebCore::KRenderingPaintServerGradientQuartz::~KRenderingPaintServerGradientQuartz):
(WebCore::KRenderingPaintServerGradientQuartz::setup):
(WebCore::KRenderingPaintServerGradientQuartz::teardown):
* kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
* kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
(WebCore::patternCallback):
(WebCore::KRenderingPaintServerPatternQuartz::setup):
* kcanvas/device/quartz/QuartzSupport.mm:
* ksvg2/misc/KCanvasRenderingStyle.cpp:
(WebCore::sharedSolidPaintServer):
* ksvg2/svg/SVGClipPathElement.cpp:
(WebCore::SVGClipPathElement::SVGClipPathElement):
(WebCore::SVGClipPathElement::~SVGClipPathElement):
(WebCore::SVGClipPathElement::canvasResource):
* ksvg2/svg/SVGClipPathElement.h:
* ksvg2/svg/SVGFEImageElement.cpp:
* ksvg2/svg/SVGFilterElement.cpp:
(WebCore::SVGFilterElement::SVGFilterElement):
(WebCore::SVGFilterElement::~SVGFilterElement):
(WebCore::SVGFilterElement::canvasResource):
* ksvg2/svg/SVGFilterElement.h:
* ksvg2/svg/SVGGradientElement.cpp:
(WebCore::SVGGradientElement::SVGGradientElement):
(WebCore::SVGGradientElement::~SVGGradientElement):
(WebCore::SVGGradientElement::canvasResource):
(WebCore::SVGGradientElement::resourceNotification):
* ksvg2/svg/SVGGradientElement.h:
* ksvg2/svg/SVGImageElement.cpp:
* ksvg2/svg/SVGLinearGradientElement.cpp:
(WebCore::SVGLinearGradientElement::buildGradient):
* ksvg2/svg/SVGLinearGradientElement.h:
* ksvg2/svg/SVGMarkerElement.cpp:
(WebCore::SVGMarkerElement::SVGMarkerElement):
(WebCore::SVGMarkerElement::~SVGMarkerElement):
(WebCore::SVGMarkerElement::canvasResource):
* ksvg2/svg/SVGMarkerElement.h:
* ksvg2/svg/SVGMaskElement.cpp:
(WebCore::SVGMaskElement::SVGMaskElement):
(WebCore::SVGMaskElement::~SVGMaskElement):
(WebCore::SVGMaskElement::drawMaskerContent):
(WebCore::SVGMaskElement::canvasResource):
* ksvg2/svg/SVGMaskElement.h:
* ksvg2/svg/SVGPatternElement.cpp:
(WebCore::SVGPatternElement::SVGPatternElement):
(WebCore::SVGPatternElement::~SVGPatternElement):
(WebCore::SVGPatternElement::fillAttributesFromReferencePattern):
(WebCore::SVGPatternElement::drawPatternContentIntoTile):
(WebCore::SVGPatternElement::canvasResource):
* ksvg2/svg/SVGPatternElement.h:
* ksvg2/svg/SVGRadialGradientElement.cpp:
(WebCore::SVGRadialGradientElement::buildGradient):
* ksvg2/svg/SVGRadialGradientElement.h:
* ksvg2/svg/SVGStyledElement.h:
(WebCore::SVGStyledElement::canvasResource):
* platform/GraphicsContext.cpp: Removed.
* platform/GraphicsContext.h: Removed.
* platform/GraphicsTypes.cpp: Removed.
* platform/GraphicsTypes.h: Removed.
* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContextState::GraphicsContextState):
(WebCore::GraphicsContextPrivate::GraphicsContextPrivate):
(WebCore::GraphicsContext::createGraphicsContextPrivate):
(WebCore::GraphicsContext::destroyGraphicsContextPrivate):
(WebCore::GraphicsContext::save):
(WebCore::GraphicsContext::restore):
(WebCore::GraphicsContext::font):
(WebCore::GraphicsContext::setFont):
(WebCore::GraphicsContext::pen):
(WebCore::GraphicsContext::setPen):
(WebCore::GraphicsContext::setFillColor):
(WebCore::GraphicsContext::fillColor):
(WebCore::GraphicsContext::updatingControlTints):
(WebCore::GraphicsContext::setUpdatingControlTints):
(WebCore::GraphicsContext::setPaintingDisabled):
(WebCore::GraphicsContext::paintingDisabled):
(WebCore::GraphicsContext::drawImage):
(WebCore::GraphicsContext::drawText):
(WebCore::GraphicsContext::drawHighlightForText):
(WebCore::GraphicsContext::initFocusRing):
(WebCore::GraphicsContext::clearFocusRing):
(WebCore::GraphicsContext::focusRingBoundingRect):
(WebCore::GraphicsContext::addFocusRingRect):
(WebCore::GraphicsContext::focusRingWidth):
(WebCore::GraphicsContext::focusRingOffset):
(WebCore::GraphicsContext::focusRingRects):
(WebCore::GraphicsContext::drawTiledImage):
* platform/graphics/GraphicsContext.h:
* platform/graphics/GraphicsTypes.cpp:
(WebCore::):
(WebCore::parseCompositeOperator):
(WebCore::compositeOperatorName):
(WebCore::parseLineCap):
(WebCore::lineCapName):
(WebCore::parseLineJoin):
(WebCore::lineJoinName):
* platform/graphics/GraphicsTypes.h:
(WebCore::):
* platform/graphics/svg/SVGResource.cpp: Added.
(WebCore::SVGResource::SVGResource):
(WebCore::SVGResource::~SVGResource):
(WebCore::SVGResource::invalidate):
(WebCore::SVGResource::addClient):
(WebCore::SVGResource::clients):
(WebCore::SVGResource::idInRegistry):
(WebCore::SVGResource::setIdInRegistry):
(WebCore::SVGResource::externalRepresentation):
(WebCore::getResourceById):
(WebCore::getPaintServerById):
(WebCore::operator<<):
* platform/graphics/svg/SVGResource.h: Added.
(WebCore::):
(WebCore::SVGResource::isPaintServer):
(WebCore::SVGResource::isFilter):
(WebCore::SVGResource::isClipper):
(WebCore::SVGResource::isMarker):
(WebCore::SVGResource::isMasker):
(WebCore::SVGResourceListener::~SVGResourceListener):
* platform/graphics/svg/SVGResourceClipper.cpp: Added.
(WebCore::SVGResourceClipper::SVGResourceClipper):
(WebCore::SVGResourceClipper::~SVGResourceClipper):
(WebCore::SVGResourceClipper::resetClipData):
(WebCore::SVGResourceClipper::addClipData):
(WebCore::SVGResourceClipper::clipData):
(WebCore::SVGResourceClipper::externalRepresentation):
(WebCore::operator<<):
(WebCore::getClipperById):
* platform/graphics/svg/SVGResourceClipper.h: Added.
(WebCore::ClipDataList::addPath):
(WebCore::SVGResourceClipper::isClipper):
* platform/graphics/svg/SVGResourceImage.h: Added.
* platform/graphics/svg/SVGResourceMarker.cpp: Added.
(WebCore::SVGResourceMarker::SVGResourceMarker):
(WebCore::SVGResourceMarker::~SVGResourceMarker):
(WebCore::SVGResourceMarker::setMarker):
(WebCore::SVGResourceMarker::setRef):
(WebCore::SVGResourceMarker::draw):
(WebCore::SVGResourceMarker::externalRepresentation):
(WebCore::getMarkerById):
* platform/graphics/svg/SVGResourceMarker.h: Added.
(WebCore::SVGResourceMarker::refX):
(WebCore::SVGResourceMarker::refY):
(WebCore::SVGResourceMarker::setAngle):
(WebCore::SVGResourceMarker::setAutoAngle):
(WebCore::SVGResourceMarker::angle):
(WebCore::SVGResourceMarker::setUseStrokeWidth):
(WebCore::SVGResourceMarker::useStrokeWidth):
(WebCore::SVGResourceMarker::isMarker):
* platform/graphics/svg/SVGResourceMasker.cpp: Added.
(WebCore::SVGResourceMasker::SVGResourceMasker):
(WebCore::SVGResourceMasker::~SVGResourceMasker):
(WebCore::SVGResourceMasker::setMask):
(WebCore::SVGResourceMasker::mask):
(WebCore::SVGResourceMasker::externalRepresentation):
(WebCore::getMaskerById):
* platform/graphics/svg/SVGResourceMasker.h: Added.
(WebCore::SVGResourceMasker::isMasker):
* platform/graphics/svg/cg/SVGResourceClipperCg.mm: Added.
(WebCore::SVGResourceClipper::applyClip):
* platform/graphics/svg/cg/SVGResourceImageCg.mm: Added.
(WebCore::SVGResourceImage::SVGResourceImage):
(WebCore::SVGResourceImage::~SVGResourceImage):
(WebCore::SVGResourceImage::init):
(WebCore::SVGResourceImage::size):
(WebCore::SVGResourceImage::cgLayer):
(WebCore::SVGResourceImage::setCGLayer):
* platform/graphics/svg/cg/SVGResourceMaskerCg.mm: Added.
(WebCore::applyLuminanceToAlphaFilter):
(WebCore::applyExpandAlphatoGrayscaleFilter):
(WebCore::transformImageIntoGrayscaleMask):
(WebCore::SVGResourceMasker::applyMask):
* platform/graphics/svg/qt/SVGResourceClipperQt.cpp: Added.
(WebCore::SVGResourceClipper::applyClip):
* platform/graphics/svg/qt/SVGResourceImageQt.cpp: Added.
(WebCore::SVGResourceImage::init):
(WebCore::SVGResourceImage::size):
* platform/graphics/svg/qt/SVGResourceMaskerQt.cpp: Added.
(WebCore::SVGResourceMasker::applyMask):
* platform/qt/GraphicsContextQt.cpp:
* rendering/RenderPath.cpp:
(WebCore::RenderPath::paint):
(WebCore::DrawMarkersData::DrawMarkersData):
(WebCore::RenderPath::drawMarkersIfNeeded):
* rendering/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::paint):
* rendering/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::paint):
* rendering/SVGInlineFlowBox.cpp:
(WebCore::paintSVGInlineFlow):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17467
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan [Tue, 31 Oct 2006 03:53:05 +0000 (03:53 +0000)]
Reviewed by Brady
- minor cleanup to make future patches clearer
* bridge/mac/FrameMac.mm:
(WebCore::FrameMac::advanceToNextMisspelling):
renamed misspelling to misspellingNSRange for clarity; changed > 0 test to == 0 test
with "continue" to better match structure of similar code in markMisspellings; a few
other style tweaks.
(WebCore::FrameMac::markMisspellings):
renamed misspelling to misspellingNSRange for clarity; removed unnecessary braces around
a block just after a break and outdented accordingly.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17466
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Tue, 31 Oct 2006 03:23:35 +0000 (03:23 +0000)]
Reviewed by Beth.
Reorganized project file into Delegates and Controllers groups, and split
UIDelegate stuff into a UIDelegate class.
A little birdy told me that I might end up adding some UIDelegate methods
to DRT soon.
* DumpRenderTree/DumpRenderTree.m:
(main):
(runTest):
* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17465
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan [Tue, 31 Oct 2006 02:54:41 +0000 (02:54 +0000)]
WebCore:
Reviewed by Geoff Garen
WebCore part of change to push the code that updates the spelling panel
into WebCore, in preparation for some grammar-checking stuff.
* bridge/mac/FrameMac.h:
* bridge/mac/FrameMac.mm:
(WebCore::FrameMac::advanceToNextMisspelling):
no more return value for this method, and update the spelling panel with
the misspelled word here rather than in the WebKit callers.
WebKit:
Reviewed by Geoff Garen
* WebView/WebHTMLView.m:
(-[NSArray checkSpelling:]):
removed code to update spelling panel; WebCore handles that now
(-[NSArray showGuessPanel:]):
ditto
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17464
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan [Tue, 31 Oct 2006 02:36:35 +0000 (02:36 +0000)]
* English.lproj/WebViewEditingContextMenu.nib/info.nib:
* English.lproj/WebViewEditingContextMenu.nib/objects.nib:
Another wording change to match framework, post-Tiger:
"Check Spelling" -> "Check Document Now"
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17463
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver [Tue, 31 Oct 2006 02:33:47 +0000 (02:33 +0000)]
liver Hunt <oliver@apple.com>
Reviewed by Anders.
Roll out last patch
* CMakeLists.txt:
* ChangeLog:
* WebCore.xcodeproj/project.pbxproj:
* graphics/svg/SVGResource.cpp:
* graphics/svg/SVGResourceClipper.cpp:
* graphics/svg/SVGResourceClipper.h:
* graphics/svg/SVGResourceImage.h:
* graphics/svg/SVGResourceListener.h:
* graphics/svg/SVGResourceMarker.cpp:
* graphics/svg/SVGResourceMarker.h:
* graphics/svg/SVGResourceMasker.cpp:
* graphics/svg/SVGResourceMasker.h:
* kcanvas/KCanvasClipper.cpp: Added.
(WebCore::operator<<):
(WebCore::KCanvasClipper::KCanvasClipper):
(WebCore::KCanvasClipper::~KCanvasClipper):
(WebCore::KCanvasClipper::resetClipData):
(WebCore::KCanvasClipper::addClipData):
(WebCore::KCanvasClipper::clipData):
(WebCore::KCanvasClipper::externalRepresentation):
(WebCore::getClipperById):
* kcanvas/KCanvasClipper.h: Added.
(WebCore::KCClipData::windRule):
(WebCore::KCClipDataList::KCClipDataList):
(WebCore::KCClipDataList::addPath):
(WebCore::KCanvasClipper::isClipper):
* kcanvas/KCanvasFilters.cpp:
(WebCore::getFilterById):
* kcanvas/KCanvasFilters.h:
* kcanvas/KCanvasImage.h: Added.
(WebCore::KCanvasImage::KCanvasImage):
(WebCore::KCanvasImage::~KCanvasImage):
* kcanvas/KCanvasMarker.cpp: Added.
(WebCore::KCanvasMarker::KCanvasMarker):
(WebCore::KCanvasMarker::~KCanvasMarker):
(WebCore::KCanvasMarker::setMarker):
(WebCore::KCanvasMarker::setRef):
(WebCore::KCanvasMarker::refX):
(WebCore::KCanvasMarker::refY):
(WebCore::KCanvasMarker::setAngle):
(WebCore::KCanvasMarker::angle):
(WebCore::KCanvasMarker::setAutoAngle):
(WebCore::KCanvasMarker::setUseStrokeWidth):
(WebCore::KCanvasMarker::useStrokeWidth):
(WebCore::KCanvasMarker::draw):
(WebCore::KCanvasMarker::externalRepresentation):
(WebCore::getMarkerById):
* kcanvas/KCanvasMarker.h: Added.
(WebCore::KCanvasMarker::isMarker):
* kcanvas/KCanvasMasker.cpp: Added.
(WebCore::KCanvasMasker::KCanvasMasker):
(WebCore::KCanvasMasker::~KCanvasMasker):
(WebCore::KCanvasMasker::setMask):
(WebCore::KCanvasMasker::externalRepresentation):
(WebCore::getMaskerById):
* kcanvas/KCanvasMasker.h: Added.
(WebCore::KCanvasMasker::isMasker):
(WebCore::KCanvasMasker::mask):
* kcanvas/KCanvasResource.cpp: Added.
(WebCore::operator<<):
(WebCore::KCanvasResource::KCanvasResource):
(WebCore::KCanvasResource::~KCanvasResource):
(WebCore::KCanvasResource::addClient):
(WebCore::KCanvasResource::clients):
(WebCore::KCanvasResource::invalidate):
(WebCore::KCanvasResource::idInRegistry):
(WebCore::KCanvasResource::setIdInRegistry):
(WebCore::KCanvasResource::externalRepresentation):
(WebCore::getResourceById):
(WebCore::getPaintServerById):
* kcanvas/KCanvasResource.h:
(WebCore::):
(WebCore::KCanvasResource::isPaintServer):
(WebCore::KCanvasResource::isFilter):
(WebCore::KCanvasResource::isClipper):
(WebCore::KCanvasResource::isMarker):
(WebCore::KCanvasResource::isMasker):
* kcanvas/KCanvasResourceListener.h: Added.
(KCanvasResourceListener::KCanvasResourceListener):
(KCanvasResourceListener::~KCanvasResourceListener):
* kcanvas/KCanvasTreeDebug.cpp:
(WebCore::writeRenderResources):
* kcanvas/device/KRenderingDevice.h:
* kcanvas/device/KRenderingPaintServer.h:
(WebCore::KRenderingPaintServer::KRenderingPaintServer):
(WebCore::KRenderingPaintServer::idInRegistry):
(WebCore::KRenderingPaintServer::setIdInRegistry):
* kcanvas/device/KRenderingPaintServerGradient.cpp:
(WebCore::KRenderingPaintServerGradient::listener):
(WebCore::KRenderingPaintServerGradient::setListener):
* kcanvas/device/KRenderingPaintServerGradient.h:
* kcanvas/device/KRenderingPaintServerPattern.cpp:
(WebCore::KRenderingPaintServerPattern::KRenderingPaintServerPattern):
(WebCore::KRenderingPaintServerPattern::~KRenderingPaintServerPattern):
(WebCore::KRenderingPaintServerPattern::tile):
(WebCore::KRenderingPaintServerPattern::setTile):
(WebCore::KRenderingPaintServerPattern::listener):
(WebCore::KRenderingPaintServerPattern::setListener):
* kcanvas/device/KRenderingPaintServerPattern.h:
* kcanvas/device/KRenderingPaintServerSolid.h:
* kcanvas/device/qt/KCanvasClipperQt.cpp:
(WebCore::KCanvasClipperQt::applyClip):
* kcanvas/device/qt/KCanvasClipperQt.h:
(WebCore::KCanvasClipperQt::KCanvasClipperQt):
* kcanvas/device/qt/KRenderingDeviceQt.cpp:
(WebCore::KRenderingDeviceQt::contextForImage):
(WebCore::KRenderingDeviceQt::createResource):
(WebCore::KRenderingDeviceQt::createPaintServer):
* kcanvas/device/qt/KRenderingDeviceQt.h:
* kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp:
* kcanvas/device/qt/KRenderingPaintServerPatternQt.cpp:
* kcanvas/device/qt/KRenderingPaintServerQt.cpp:
* kcanvas/device/qt/KRenderingPaintServerSolidQt.cpp:
* kcanvas/device/quartz/KCanvasFilterQuartz.mm:
(WebCore::KCanvasFilterQuartz::getCIFilterStack):
* kcanvas/device/quartz/KCanvasItemQuartz.mm:
* kcanvas/device/quartz/KCanvasMaskerQuartz.h:
(WebCore::KCanvasMaskerQuartz::KCanvasMaskerQuartz):
* kcanvas/device/quartz/KCanvasMaskerQuartz.mm:
(WebCore::applyLuminanceToAlphaFilter):
(WebCore::applyExpandAlphatoGrayscaleFilter):
(WebCore::transformImageIntoGrayscaleMask):
(WebCore::KCanvasMaskerQuartz::applyMask):
* kcanvas/device/quartz/KCanvasResourcesQuartz.h:
(WebCore::KCanvasClipperQuartz::KCanvasClipperQuartz):
(WebCore::KCanvasImageQuartz::KCanvasImageQuartz):
(WebCore::KCanvasImageQuartz::init):
(WebCore::KCanvasImageQuartz::size):
* kcanvas/device/quartz/KCanvasResourcesQuartz.mm:
(WebCore::KCanvasClipperQuartz::applyClip):
(WebCore::KCanvasImageQuartz::~KCanvasImageQuartz):
(WebCore::KCanvasImageQuartz::cgLayer):
(WebCore::KCanvasImageQuartz::setCGLayer):
* kcanvas/device/quartz/KRenderingDeviceQuartz.h:
* kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
(WebCore::KRenderingDeviceQuartz::contextForImage):
(WebCore::KRenderingDeviceQuartz::createPaintServer):
(WebCore::KRenderingDeviceQuartz::createResource):
* kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
(WebCore::KRenderingPaintServerGradientQuartz::KRenderingPaintServerGradientQuartz):
(WebCore::KRenderingPaintServerGradientQuartz::~KRenderingPaintServerGradientQuartz):
(WebCore::KRenderingPaintServerGradientQuartz::setup):
(WebCore::KRenderingPaintServerGradientQuartz::teardown):
* kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
* kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
(WebCore::patternCallback):
(WebCore::KRenderingPaintServerPatternQuartz::setup):
* kcanvas/device/quartz/QuartzSupport.mm:
* ksvg2/misc/KCanvasRenderingStyle.cpp:
(WebCore::sharedSolidPaintServer):
* ksvg2/svg/SVGClipPathElement.cpp:
(WebCore::SVGClipPathElement::SVGClipPathElement):
(WebCore::SVGClipPathElement::~SVGClipPathElement):
(WebCore::SVGClipPathElement::canvasResource):
* ksvg2/svg/SVGClipPathElement.h:
* ksvg2/svg/SVGFEImageElement.cpp:
* ksvg2/svg/SVGFilterElement.cpp:
(WebCore::SVGFilterElement::SVGFilterElement):
(WebCore::SVGFilterElement::~SVGFilterElement):
(WebCore::SVGFilterElement::canvasResource):
* ksvg2/svg/SVGFilterElement.h:
* ksvg2/svg/SVGGradientElement.cpp:
(WebCore::SVGGradientElement::SVGGradientElement):
(WebCore::SVGGradientElement::~SVGGradientElement):
(WebCore::SVGGradientElement::canvasResource):
(WebCore::SVGGradientElement::resourceNotification):
* ksvg2/svg/SVGGradientElement.h:
* ksvg2/svg/SVGImageElement.cpp:
* ksvg2/svg/SVGLinearGradientElement.cpp:
(WebCore::SVGLinearGradientElement::buildGradient):
* ksvg2/svg/SVGLinearGradientElement.h:
* ksvg2/svg/SVGMarkerElement.cpp:
(WebCore::SVGMarkerElement::SVGMarkerElement):
(WebCore::SVGMarkerElement::~SVGMarkerElement):
(WebCore::SVGMarkerElement::canvasResource):
* ksvg2/svg/SVGMarkerElement.h:
* ksvg2/svg/SVGMaskElement.cpp:
(WebCore::SVGMaskElement::SVGMaskElement):
(WebCore::SVGMaskElement::~SVGMaskElement):
(WebCore::SVGMaskElement::drawMaskerContent):
(WebCore::SVGMaskElement::canvasResource):
* ksvg2/svg/SVGMaskElement.h:
* ksvg2/svg/SVGPatternElement.cpp:
(WebCore::SVGPatternElement::SVGPatternElement):
(WebCore::SVGPatternElement::~SVGPatternElement):
(WebCore::SVGPatternElement::fillAttributesFromReferencePattern):
(WebCore::SVGPatternElement::drawPatternContentIntoTile):
(WebCore::SVGPatternElement::canvasResource):
* ksvg2/svg/SVGPatternElement.h:
* ksvg2/svg/SVGRadialGradientElement.cpp:
(WebCore::SVGRadialGradientElement::buildGradient):
* ksvg2/svg/SVGRadialGradientElement.h:
* ksvg2/svg/SVGStyledElement.h:
(WebCore::SVGStyledElement::canvasResource):
* platform/GraphicsContext.cpp: Added.
(WebCore::GraphicsContextState::GraphicsContextState):
(WebCore::GraphicsContextPrivate::GraphicsContextPrivate):
(WebCore::GraphicsContext::createGraphicsContextPrivate):
(WebCore::GraphicsContext::destroyGraphicsContextPrivate):
(WebCore::GraphicsContext::save):
(WebCore::GraphicsContext::restore):
(WebCore::GraphicsContext::font):
(WebCore::GraphicsContext::setFont):
(WebCore::GraphicsContext::pen):
(WebCore::GraphicsContext::setPen):
(WebCore::GraphicsContext::setFillColor):
(WebCore::GraphicsContext::fillColor):
(WebCore::GraphicsContext::updatingControlTints):
(WebCore::GraphicsContext::setUpdatingControlTints):
(WebCore::GraphicsContext::setPaintingDisabled):
(WebCore::GraphicsContext::paintingDisabled):
(WebCore::GraphicsContext::drawImage):
(WebCore::GraphicsContext::drawText):
(WebCore::GraphicsContext::drawHighlightForText):
(WebCore::GraphicsContext::initFocusRing):
(WebCore::GraphicsContext::clearFocusRing):
(WebCore::GraphicsContext::focusRingBoundingRect):
(WebCore::GraphicsContext::addFocusRingRect):
(WebCore::GraphicsContext::focusRingWidth):
(WebCore::GraphicsContext::focusRingOffset):
(WebCore::GraphicsContext::focusRingRects):
(WebCore::GraphicsContext::drawTiledImage):
* platform/GraphicsContext.h: Added.
* platform/GraphicsTypes.cpp: Added.
(WebCore::):
(WebCore::parseCompositeOperator):
(WebCore::compositeOperatorName):
(WebCore::parseLineCap):
(WebCore::lineCapName):
(WebCore::parseLineJoin):
(WebCore::lineJoinName):
* platform/GraphicsTypes.h: Added.
(WebCore::):
* platform/graphics/GraphicsContext.cpp:
* platform/graphics/GraphicsContext.h:
* platform/graphics/GraphicsTypes.cpp:
* platform/graphics/GraphicsTypes.h:
* platform/qt/GraphicsContextQt.cpp:
* rendering/RenderPath.cpp:
(WebCore::RenderPath::paint):
(WebCore::DrawMarkersData::DrawMarkersData):
(WebCore::RenderPath::drawMarkersIfNeeded):
* rendering/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::paint):
* rendering/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::paint):
* rendering/SVGInlineFlowBox.cpp:
(WebCore::paintSVGInlineFlow):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17462
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver [Tue, 31 Oct 2006 01:46:33 +0000 (01:46 +0000)]
2006-10-31 Nikolas Zimmermann <zimmermann@kde.org>
Reviewed by Oliver.
Fixes: http://bugs.webkit.org/show_bug.cgi?id=11436
Better SVG integration in WebKit, Part I.
The patch is mostly about creating a new platform/graphics directory, and
moving the kcanvas resources (clipper/masker/marker) there (in svg budir),
with a new name (KCanvasClipper -> SVGResourceClipper). Also fix several ownership
issues, by using ref counting (the SVG classes now store RefPtrs to the resources).
KCanvasFilters is still left in kcanvas/ subdirectory, to be converted in a next patch.
All details of the patch, and upcoming patches can be found in the bug report.
* CMakeLists.txt:
* WebCore.xcodeproj/project.pbxproj:
* kcanvas/KCanvasClipper.cpp: Removed.
* kcanvas/KCanvasClipper.h: Removed.
* kcanvas/KCanvasCreator.cpp: Removed.
* kcanvas/KCanvasCreator.h: Removed.
* kcanvas/KCanvasFilters.cpp:
(WebCore::getFilterById):
* kcanvas/KCanvasFilters.h:
* kcanvas/KCanvasImage.h: Removed.
* kcanvas/KCanvasMarker.cpp: Removed.
* kcanvas/KCanvasMarker.h: Removed.
* kcanvas/KCanvasMasker.cpp: Removed.
* kcanvas/KCanvasMasker.h: Removed.
* kcanvas/KCanvasResource.cpp: Removed.
* kcanvas/KCanvasResource.h: Removed.
* kcanvas/KCanvasResourceListener.h: Removed.
* kcanvas/KCanvasTreeDebug.cpp:
(WebCore::writeRenderResources):
* kcanvas/device/KRenderingDevice.h:
* kcanvas/device/KRenderingPaintServer.h:
(WebCore::KRenderingPaintServer::KRenderingPaintServer):
* kcanvas/device/KRenderingPaintServerGradient.cpp:
(WebCore::KRenderingPaintServerGradient::listener):
(WebCore::KRenderingPaintServerGradient::setListener):
* kcanvas/device/KRenderingPaintServerGradient.h:
* kcanvas/device/KRenderingPaintServerPattern.cpp:
(WebCore::KRenderingPaintServerPattern::KRenderingPaintServerPattern):
(WebCore::KRenderingPaintServerPattern::~KRenderingPaintServerPattern):
(WebCore::KRenderingPaintServerPattern::tile):
(WebCore::KRenderingPaintServerPattern::setTile):
(WebCore::KRenderingPaintServerPattern::listener):
(WebCore::KRenderingPaintServerPattern::setListener):
* kcanvas/device/KRenderingPaintServerPattern.h:
* kcanvas/device/KRenderingPaintServerSolid.h:
* kcanvas/device/qt/KCanvasClipperQt.cpp: Removed.
* kcanvas/device/qt/KCanvasClipperQt.h: Removed.
* kcanvas/device/qt/KRenderingDeviceQt.cpp:
(WebCore::KRenderingDeviceQt::contextForImage):
(WebCore::KRenderingDeviceQt::createResource):
(WebCore::KRenderingDeviceQt::createPaintServer):
* kcanvas/device/qt/KRenderingDeviceQt.h:
* kcanvas/device/qt/KRenderingPaintServerGradientQt.cpp:
* kcanvas/device/qt/KRenderingPaintServerPatternQt.cpp:
* kcanvas/device/qt/KRenderingPaintServerQt.cpp:
* kcanvas/device/qt/KRenderingPaintServerSolidQt.cpp:
* kcanvas/device/qt/RenderPathQt.h: Removed.
* kcanvas/device/quartz/KCanvasFilterQuartz.mm:
(WebCore::KCanvasFilterQuartz::getCIFilterStack):
* kcanvas/device/quartz/KCanvasItemQuartz.mm:
* kcanvas/device/quartz/KCanvasMaskerQuartz.h: Removed.
* kcanvas/device/quartz/KCanvasMaskerQuartz.mm: Removed.
* kcanvas/device/quartz/KCanvasResourcesQuartz.h: Removed.
* kcanvas/device/quartz/KCanvasResourcesQuartz.mm: Removed.
* kcanvas/device/quartz/KRenderingDeviceQuartz.h:
* kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
(WebCore::KRenderingDeviceQuartz::contextForImage):
(WebCore::KRenderingDeviceQuartz::createPaintServer):
(WebCore::KRenderingDeviceQuartz::createResource):
* kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
(WebCore::KRenderingPaintServerGradientQuartz::KRenderingPaintServerGradientQuartz):
(WebCore::KRenderingPaintServerGradientQuartz::~KRenderingPaintServerGradientQuartz):
(WebCore::KRenderingPaintServerGradientQuartz::setup):
(WebCore::KRenderingPaintServerGradientQuartz::teardown):
* kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
* kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
(WebCore::patternCallback):
(WebCore::KRenderingPaintServerPatternQuartz::setup):
* kcanvas/device/quartz/QuartzSupport.mm:
* ksvg2/misc/KCanvasRenderingStyle.cpp:
(WebCore::sharedSolidPaintServer):
* ksvg2/svg/SVGClipPathElement.cpp:
(WebCore::SVGClipPathElement::SVGClipPathElement):
(WebCore::SVGClipPathElement::~SVGClipPathElement):
(WebCore::SVGClipPathElement::canvasResource):
* ksvg2/svg/SVGClipPathElement.h:
* ksvg2/svg/SVGFEImageElement.cpp:
* ksvg2/svg/SVGFilterElement.cpp:
(WebCore::SVGFilterElement::SVGFilterElement):
(WebCore::SVGFilterElement::~SVGFilterElement):
(WebCore::SVGFilterElement::canvasResource):
* ksvg2/svg/SVGFilterElement.h:
* ksvg2/svg/SVGGradientElement.cpp:
(WebCore::SVGGradientElement::SVGGradientElement):
(WebCore::SVGGradientElement::~SVGGradientElement):
(WebCore::SVGGradientElement::canvasResource):
(WebCore::SVGGradientElement::resourceNotification):
* ksvg2/svg/SVGGradientElement.h:
* ksvg2/svg/SVGImageElement.cpp:
* ksvg2/svg/SVGLinearGradientElement.cpp:
(WebCore::SVGLinearGradientElement::buildGradient):
* ksvg2/svg/SVGLinearGradientElement.h:
* ksvg2/svg/SVGMarkerElement.cpp:
(WebCore::SVGMarkerElement::SVGMarkerElement):
(WebCore::SVGMarkerElement::~SVGMarkerElement):
(WebCore::SVGMarkerElement::canvasResource):
* ksvg2/svg/SVGMarkerElement.h:
* ksvg2/svg/SVGMaskElement.cpp:
(WebCore::SVGMaskElement::SVGMaskElement):
(WebCore::SVGMaskElement::~SVGMaskElement):
(WebCore::SVGMaskElement::drawMaskerContent):
(WebCore::SVGMaskElement::canvasResource):
* ksvg2/svg/SVGMaskElement.h:
* ksvg2/svg/SVGPatternElement.cpp:
(WebCore::SVGPatternElement::SVGPatternElement):
(WebCore::SVGPatternElement::~SVGPatternElement):
(WebCore::SVGPatternElement::fillAttributesFromReferencePattern):
(WebCore::SVGPatternElement::drawPatternContentIntoTile):
(WebCore::SVGPatternElement::canvasResource):
* ksvg2/svg/SVGPatternElement.h:
* ksvg2/svg/SVGRadialGradientElement.cpp:
(WebCore::SVGRadialGradientElement::buildGradient):
* ksvg2/svg/SVGRadialGradientElement.h:
* ksvg2/svg/SVGStyledElement.h:
(WebCore::SVGStyledElement::canvasResource):
* platform/GraphicsContext.cpp: Removed.
* platform/GraphicsContext.h: Removed.
* platform/GraphicsTypes.cpp: Removed.
* platform/GraphicsTypes.h: Removed.
* platform/graphics/GraphicsContext.cpp: Added.
(WebCore::GraphicsContextState::GraphicsContextState):
(WebCore::GraphicsContextPrivate::GraphicsContextPrivate):
(WebCore::GraphicsContext::createGraphicsContextPrivate):
(WebCore::GraphicsContext::destroyGraphicsContextPrivate):
(WebCore::GraphicsContext::save):
(WebCore::GraphicsContext::restore):
(WebCore::GraphicsContext::font):
(WebCore::GraphicsContext::setFont):
(WebCore::GraphicsContext::pen):
(WebCore::GraphicsContext::setPen):
(WebCore::GraphicsContext::setFillColor):
(WebCore::GraphicsContext::fillColor):
(WebCore::GraphicsContext::updatingControlTints):
(WebCore::GraphicsContext::setUpdatingControlTints):
(WebCore::GraphicsContext::setPaintingDisabled):
(WebCore::GraphicsContext::paintingDisabled):
(WebCore::GraphicsContext::drawImage):
(WebCore::GraphicsContext::drawText):
(WebCore::GraphicsContext::drawHighlightForText):
(WebCore::GraphicsContext::initFocusRing):
(WebCore::GraphicsContext::clearFocusRing):
(WebCore::GraphicsContext::focusRingBoundingRect):
(WebCore::GraphicsContext::addFocusRingRect):
(WebCore::GraphicsContext::focusRingWidth):
(WebCore::GraphicsContext::focusRingOffset):
(WebCore::GraphicsContext::focusRingRects):
(WebCore::GraphicsContext::drawTiledImage):
* platform/graphics/GraphicsContext.h: Added.
* platform/graphics/GraphicsTypes.cpp: Added.
(WebCore::):
(WebCore::parseCompositeOperator):
(WebCore::compositeOperatorName):
(WebCore::parseLineCap):
(WebCore::lineCapName):
(WebCore::parseLineJoin):
(WebCore::lineJoinName):
* platform/graphics/GraphicsTypes.h: Added.
(WebCore::):
* platform/graphics/svg/SVGResource.cpp: Added.
(WebCore::SVGResource::SVGResource):
(WebCore::SVGResource::~SVGResource):
(WebCore::SVGResource::invalidate):
(WebCore::SVGResource::addClient):
(WebCore::SVGResource::clients):
(WebCore::SVGResource::idInRegistry):
(WebCore::SVGResource::setIdInRegistry):
(WebCore::SVGResource::externalRepresentation):
(WebCore::getResourceById):
(WebCore::getPaintServerById):
(WebCore::operator<<):
* platform/graphics/svg/SVGResource.h: Added.
(WebCore::):
(WebCore::SVGResource::isPaintServer):
(WebCore::SVGResource::isFilter):
(WebCore::SVGResource::isClipper):
(WebCore::SVGResource::isMarker):
(WebCore::SVGResource::isMasker):
(WebCore::SVGResourceListener::~SVGResourceListener):
* platform/graphics/svg/SVGResourceClipper.cpp: Added.
(WebCore::SVGResourceClipper::SVGResourceClipper):
(WebCore::SVGResourceClipper::~SVGResourceClipper):
(WebCore::SVGResourceClipper::resetClipData):
(WebCore::SVGResourceClipper::addClipData):
(WebCore::SVGResourceClipper::clipData):
(WebCore::SVGResourceClipper::externalRepresentation):
(WebCore::operator<<):
(WebCore::getClipperById):
* platform/graphics/svg/SVGResourceClipper.h: Added.
(WebCore::ClipDataList::addPath):
(WebCore::SVGResourceClipper::isClipper):
* platform/graphics/svg/SVGResourceImage.h: Added.
* platform/graphics/svg/SVGResourceMarker.cpp: Added.
(WebCore::SVGResourceMarker::SVGResourceMarker):
(WebCore::SVGResourceMarker::~SVGResourceMarker):
(WebCore::SVGResourceMarker::setMarker):
(WebCore::SVGResourceMarker::setRef):
(WebCore::SVGResourceMarker::draw):
(WebCore::SVGResourceMarker::externalRepresentation):
(WebCore::getMarkerById):
* platform/graphics/svg/SVGResourceMarker.h: Added.
(WebCore::SVGResourceMarker::refX):
(WebCore::SVGResourceMarker::refY):
(WebCore::SVGResourceMarker::setAngle):
(WebCore::SVGResourceMarker::setAutoAngle):
(WebCore::SVGResourceMarker::angle):
(WebCore::SVGResourceMarker::setUseStrokeWidth):
(WebCore::SVGResourceMarker::useStrokeWidth):
(WebCore::SVGResourceMarker::isMarker):
* platform/graphics/svg/SVGResourceMasker.cpp: Added.
(WebCore::SVGResourceMasker::SVGResourceMasker):
(WebCore::SVGResourceMasker::~SVGResourceMasker):
(WebCore::SVGResourceMasker::setMask):
(WebCore::SVGResourceMasker::mask):
(WebCore::SVGResourceMasker::externalRepresentation):
(WebCore::getMaskerById):
* platform/graphics/svg/SVGResourceMasker.h: Added.
(WebCore::SVGResourceMasker::isMasker):
* platform/graphics/svg/cg/SVGResourceClipperCg.mm: Added.
(WebCore::SVGResourceClipper::applyClip):
* platform/graphics/svg/cg/SVGResourceImageCg.mm: Added.
(WebCore::SVGResourceImage::SVGResourceImage):
(WebCore::SVGResourceImage::~SVGResourceImage):
(WebCore::SVGResourceImage::init):
(WebCore::SVGResourceImage::size):
(WebCore::SVGResourceImage::cgLayer):
(WebCore::SVGResourceImage::setCGLayer):
* platform/graphics/svg/cg/SVGResourceMaskerCg.mm: Added.
(WebCore::applyLuminanceToAlphaFilter):
(WebCore::applyExpandAlphatoGrayscaleFilter):
(WebCore::transformImageIntoGrayscaleMask):
(WebCore::SVGResourceMasker::applyMask):
* platform/graphics/svg/qt/SVGResourceClipperQt.cpp: Added.
(WebCore::SVGResourceClipper::applyClip):
* platform/graphics/svg/qt/SVGResourceImageQt.cpp: Added.
(WebCore::SVGResourceImage::init):
(WebCore::SVGResourceImage::size):
* platform/graphics/svg/qt/SVGResourceMaskerQt.cpp: Added.
(WebCore::SVGResourceMasker::applyMask):
* platform/qt/GraphicsContextQt.cpp:
* rendering/RenderPath.cpp:
(WebCore::RenderPath::paint):
(WebCore::DrawMarkersData::DrawMarkersData):
(WebCore::RenderPath::drawMarkersIfNeeded):
* rendering/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::paint):
* rendering/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::paint):
* rendering/SVGInlineFlowBox.cpp:
(WebCore::paintSVGInlineFlow):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17461
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver [Tue, 31 Oct 2006 01:44:20 +0000 (01:44 +0000)]
2006-10-31 Nikolas Zimmermann <zimmermann@kde.org>
Reviewed by Oliver.
Add new platform/graphics include directory.
* DumpRenderTree/DumpRenderTree.qtproj/CMakeLists.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17460
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Tue, 31 Oct 2006 01:35:47 +0000 (01:35 +0000)]
Reviewed by Brady.
Make the universal build return non-zero when module make fails.
* Makefile:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17459
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Tue, 31 Oct 2006 01:33:04 +0000 (01:33 +0000)]
Reviewed by Stephanie.
Add a special case for the Internal makefiles, so it can find the OepnSource.
* Scripts/webkitdirs.pm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17458
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan [Tue, 31 Oct 2006 01:25:52 +0000 (01:25 +0000)]
WebCore:
Reviewed by Geoff Garen.
Moved spelling-related methods from bridge to EditorClient. Added one not-yet-used
grammar-related method.
* bridge/EditorClient.h:
declare isContinuousSpellCheckingEnabled(), spellCheckerDocumentTag(), and new
isGrammarCheckingEnabled()
* bridge/mac/WebCoreFrameBridge.h:
removed bridge equivalents
* bridge/mac/FrameMac.mm:
(WebCore::FrameMac::advanceToNextMisspelling):
convert bridge-using code to editor()->client()-using code
(WebCore::FrameMac::markMisspellingsInAdjacentWords):
ditto
(WebCore::FrameMac::markMisspellings):
ditto
(WebCore::FrameMac::respondToChangedSelection):
ditto
* editing/Editor.h:
* editing/Editor.cpp:
(WebCore::Editor::client):
new method, returns EditorClient pointer. In an ideal world all the code that needed to
access the EditorClient would be in Editor.cpp, and we wouldn't need this accessor.
But for now it's too tricky to extricate the spelling-related code from FrameMac.mm.
WebKit:
Reviewed by Geoff Garen.
Moved spelling-related methods from bridge to EditorClient. Added one not-yet-used
grammar-related method.
* WebCoreSupport/WebEditorClient.h:
declare overrides of isContinuousSpellCheckingEnabled(), spellCheckerDocumentTag(), and new
isGrammarCheckingEnabled()
* WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::isContinuousSpellCheckingEnabled):
implement by calling through to WebView
(WebEditorClient::isGrammarCheckingEnabled):
ditto
(WebEditorClient::spellCheckerDocumentTag):
ditto
* WebCoreSupport/WebFrameBridge.mm:
removed bridge equivalents of these methods
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17457
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Tue, 31 Oct 2006 01:21:49 +0000 (01:21 +0000)]
Reviewed by Beth.
Fixed nil-deref crash that I saw while using TOT (not sure how to repro,
but the debugger confirmed the cause).
* WebView/WebFrame.mm:
(core): Added check for NULL bridge.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17456
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Tue, 31 Oct 2006 01:01:01 +0000 (01:01 +0000)]
WebCore:
Reviewed by Darin.
Removed a number of editing and selection methods from the bridge.
I moved cross-platform editing and selection code into Editor and
SelectionController, respecitvely.
I moved ObjC and AppKit stuff up into WebKit, so I ended up exporting
everything + the kitchen sink.
Specific comments below for interesting things.
* bindings/objc/DOMInternal.h: Moved exception handling helper methods into
a new file so that WebKit can use them, too. Added a helper method for
handling exceptions when selecting a Range.
* bridge/mac/FrameMac.h: Moved attributedString creation and helper functions into
WebKit, since they have to do with creating an NSAttributedString for API
consumption, and not much to do with general Frame functionality.
* editing/Editor.h: Moved lastEditCommand tracking (at least the data,
for now) into the Editor. Eventually, the Frame will not have to notify
the Editor of what the lastEditCommand was, since the Editor will perform
all EditCommands.
* editing/SelectionController.h: The code here is just stuff moved from the bridge.
* editing/SelectionController.cpp:
(WebCore::SelectionController::setSelectedRange): We now explicitly check from DOM exceptions
and return them. The bridge method to select a DOM range did this implicitly,
since all ObjC DOM operations handle DOM exceptions by throwing them as
ObjC exceptions.
* editing/TextAffinity.h: Added helper functions for conversion to NSSelectionAffinity.
The two enumerations are numerically identical, but that's an implementation
detail of TextAffinity that clients shouldn't be required to know about.
WebKit:
Reviewed by Darin.
Removed a number of editing and selection methods from the bridge.
I moved cross-platform editing and selection code into WebCore::Editor and
WebCore::SelectionController, respecitvely.
All of the seemingly new code here is just code grabbed from WebCore or
merged from WebCoreFrameBridge.
I changed one piece of internal API: we now pass around Ranges in places
where we used to pass around broken out components of Ranges.
I also added WebCore XPATH_SUPPORT AND SVG_SUPPORT #defines to the project.
Since we now include WebCore headers that depend on these #defines, we need
to keep in sync with them, to avoid binary incompatibility.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17455
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Tue, 31 Oct 2006 00:49:26 +0000 (00:49 +0000)]
Rolling out the following change because this crash:
<rdar://problem/
4806705> REGRESSION: Crash occurs at WebCore::Font::lineSpacing() when loading site (http://www.photoplusexpo.com/ppe/index.jsp)
And this regression:
<rdar://problem/
4728514> REGRESSION: Safari applies the wrong font to BODY element at http://www.apple.com/downloads/dashboard/
2006-09-06 David Harrison <harrison@apple.com>
Reviewed and tweaked by Tim H.
<rdar://problem/
4564955> WebKit doesn't trigger Auto Font Activation
If we don't find the font in the available fonts list, call [NSFont fontWithName:size:]
to trigger a search that will include auto activation. No PLT or iBench perf impact.
No layout tests affected. Not testable in an automated way that will work on all systems.
* platform/mac/WebFontCache.mm:
(+[WebFontCache fontWithFamily:traits:size:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17450
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Mon, 30 Oct 2006 23:25:05 +0000 (23:25 +0000)]
Reviewed by harrison
<rdar://problem/
4808375>
REGRESSION: TextIterator slowed down, affecting Find on Page & Copy (etc.) (11460)
* editing/TextIterator.cpp:
(WebCore::TextIterator::exitNode): Only create VisiblePositions
when we're going to use them to create a range for an emitted character.
We should further speed TextIterators up by avoiding creating VisiblePositions
for TIs that are only used for the characters they emit (like the one that
plainText uses).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17449
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Mon, 30 Oct 2006 22:41:29 +0000 (22:41 +0000)]
Reviewed by Mitz.
Fix for http://bugs.webkit.org/show_bug.cgi?id=11441
More rendering code cleaning
* WebCore.xcodeproj/project.pbxproj:
* rendering/RenderApplet.cpp:
(WebCore::RenderApplet::RenderApplet):
(WebCore::RenderApplet::createWidgetIfNecessary):
* rendering/RenderApplet.h:
* rendering/RenderArena.cpp:
(WebCore::):
(WebCore::RenderArena::RenderArena):
(WebCore::RenderArena::allocate):
(WebCore::RenderArena::free):
* rendering/RenderArena.h:
* rendering/RenderBR.cpp:
(WebCore::RenderBR::RenderBR):
(WebCore::RenderBR::baselinePosition):
(WebCore::RenderBR::lineHeight):
(WebCore::RenderBR::setStyle):
(WebCore::RenderBR::caretMinOffset):
(WebCore::RenderBR::positionForCoordinates):
(WebCore::RenderBR::inlineBox):
* rendering/RenderBR.h:
* rendering/RenderBlock.cpp:
* rendering/RenderBlock.h:
(WebCore::RenderBlock::maxTopMargin):
(WebCore::RenderBlock::maxBottomMargin):
(WebCore::RenderBlock::initMaxMarginValues):
(WebCore::RenderBlock::containsFloats):
(WebCore::RenderBlock::setHasMarkupTruncation):
(WebCore::RenderBlock::BlockSelectionInfo::BlockSelectionInfo):
(WebCore::RenderBlock::BlockSelectionInfo::block):
(WebCore::RenderBlock::BlockSelectionInfo::state):
(WebCore::RenderBlock::FloatingObject::FloatingObject):
(WebCore::RenderBlock::CompactInfo::clear):
* rendering/RenderButton.cpp:
(WebCore::RenderButton::removeChild):
(WebCore::RenderButton::paintObject):
* rendering/RenderButton.h:
(WebCore::RenderButton::renderName):
(WebCore::RenderButton::removeLeftoverAnonymousBoxes):
* rendering/RenderContainer.cpp:
(WebCore::RenderContainer::RenderContainer):
* rendering/RenderContainer.h:
(WebCore::RenderContainer::firstChild):
(WebCore::RenderContainer::lastChild):
(WebCore::RenderContainer::calcMinMaxWidth):
* rendering/RenderCounter.cpp:
(WebCore::RenderCounter::RenderCounter):
(WebCore::toRoman):
(WebCore::toHebrew):
(WebCore::RenderCounter::calcMinMaxWidth):
* rendering/RenderCounter.h:
* rendering/RenderFieldset.cpp:
(WebCore::RenderFieldset::paintBoxDecorations):
(WebCore::RenderFieldset::paintBorderMinusLegend):
(WebCore::RenderFieldset::setStyle):
* rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::~RenderFileUploadControl):
(WebCore::RenderFileUploadControl::setStyle):
(WebCore::RenderFileUploadControl::paintObject):
(WebCore::RenderFileUploadControl::calcMinMaxWidth):
* rendering/RenderFileUploadControl.h:
(WebCore::RenderFileUploadControl::renderName):
* rendering/RenderFlexibleBox.h:
* rendering/RenderFlow.cpp:
* rendering/RenderFlow.h:
* rendering/RenderForeignObject.cpp:
(WebCore::RenderForeignObject::RenderForeignObject):
(WebCore::RenderForeignObject::paint):
(WebCore::RenderForeignObject::computeAbsoluteRepaintRect):
(WebCore::RenderForeignObject::layout):
(WebCore::RenderForeignObject::nodeAtPoint):
* rendering/RenderForeignObject.h:
(WebCore::RenderForeignObject::renderName):
* rendering/RenderFormElement.cpp:
(WebCore::RenderFormElement::setStyle):
(WebCore::RenderFormElement::layout):
(WebCore::RenderFormElement::textAlignment):
* rendering/RenderFormElement.h:
* rendering/RenderFrame.cpp:
* rendering/RenderFrame.h:
(WebCore::RenderFrame::element):
* rendering/RenderFrameSet.cpp:
* rendering/RenderFrameSet.h:
(WebCore::RenderFrameSet::element):
* rendering/RenderHTMLCanvas.cpp:
(WebCore::RenderHTMLCanvas::RenderHTMLCanvas):
(WebCore::RenderHTMLCanvas::paint):
* rendering/RenderHTMLCanvas.h:
(WebCore::RenderHTMLCanvas::renderName):
* rendering/RenderImage.cpp:
(WebCore::RenderImage::RenderImage):
(WebCore::RenderImage::setStyle):
(WebCore::RenderImage::setContentObject):
(WebCore::RenderImage::setCachedImage):
(WebCore::RenderImage::imageChanged):
(WebCore::RenderImage::paint):
(WebCore::RenderImage::layout):
(WebCore::RenderImage::updateAltText):
* rendering/RenderImage.h:
(WebCore::RenderImage::element):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::RenderInline):
(WebCore::RenderInline::~RenderInline):
(WebCore::RenderInline::setStyle):
(WebCore::RenderInline::addChildToFlow):
(WebCore::RenderInline::cloneInline):
(WebCore::RenderInline::splitInlines):
(WebCore::RenderInline::splitFlow):
(WebCore::RenderInline::paint):
(WebCore::RenderInline::absoluteRects):
(WebCore::RenderInline::calcMinMaxWidth):
(WebCore::RenderInline::requiresLayer):
(WebCore::RenderInline::width):
(WebCore::RenderInline::height):
(WebCore::RenderInline::renderName):
(WebCore::RenderInline::nodeAtPoint):
(WebCore::RenderInline::positionForCoordinates):
* rendering/RenderInline.h:
(WebCore::RenderInline::layout):
* rendering/RenderLayer.cpp:
* rendering/RenderLayer.h:
(WebCore::ClipRects::ClipRects):
(WebCore::RenderLayer::nextSibling):
(WebCore::RenderLayer::root):
(WebCore::RenderLayer::setPos):
(WebCore::RenderLayer::height):
(WebCore::RenderLayer::relativePositionOffset):
* rendering/RenderLineEdit.cpp:
(WebCore::RenderLineEdit::setStyle):
(WebCore::RenderLineEdit::updateFromElement):
(WebCore::RenderLineEdit::selectionStart):
(WebCore::RenderLineEdit::selectionEnd):
(WebCore::RenderLineEdit::setSelectionStart):
(WebCore::RenderLineEdit::setSelectionEnd):
(WebCore::RenderLineEdit::setSelectionRange):
* rendering/RenderLineEdit.h:
* rendering/RenderListBox.cpp:
* rendering/RenderListBox.h:
(WebCore::RenderListBox::renderName):
* rendering/RenderListItem.cpp:
(WebCore::RenderListItem::setStyle):
(WebCore::getParentOfFirstLineBox):
(WebCore::RenderListItem::updateMarkerLocation):
(WebCore::RenderListItem::positionListMarker):
(WebCore::RenderListItem::paint):
* rendering/RenderListItem.h:
* rendering/RenderListMarker.cpp:
* rendering/RenderListMarker.h:
(WebCore::RenderListMarker::renderName):
(WebCore::RenderListMarker::isListMarker):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17448
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
slewis [Mon, 30 Oct 2006 22:35:43 +0000 (22:35 +0000)]
Reviewed by Darin.
Change Makefiles to return non-zero when module make fails.
* Makefile:
WebKitTools:
Change Makefiles to return non-zero when module make fails.
Fix bug where if xcode options are not set, modules can build in the
wrong directory.
* Makefile:
* Scripts/webkitdirs.pm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17447
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Mon, 30 Oct 2006 22:25:41 +0000 (22:25 +0000)]
Build fix.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17446
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Mon, 30 Oct 2006 22:19:19 +0000 (22:19 +0000)]
Reviewed by Hyatt.
<rdar://problem/
4478625> Basic table editing and culling
Refined the criteria for deletable elements, rely on the renderer more.
Corrected the interface positioning for elements that have borders.
* editing/DeleteButtonController.cpp:
(WebCore::isDeletableElement):
(WebCore::DeleteButtonController::show):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17445
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kmccullo [Mon, 30 Oct 2006 21:34:54 +0000 (21:34 +0000)]
Reviewed by Adam.
- Fix some timezone issues and JavaScriptCore date tests. Addresses bugzilla 4930.
* kjs/DateMath.h:
(KJS::GregorianDateTime::GregorianDateTime): Here's the fix, to add parenthesis for order of precedence.
* kjs/date_object.cpp:
(KJS::DateProtoFunc::callAsFunction):
(KJS::DateObjectImp::construct): memset not needed as GregorianDateTime initializes itself.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17444
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Mon, 30 Oct 2006 20:48:29 +0000 (20:48 +0000)]
- fix build
* loader/ResourceLoader.h: Added header guard.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17443
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Mon, 30 Oct 2006 20:05:39 +0000 (20:05 +0000)]
Reviewed by Adam.
- fix FrameLoader files so they can be built on non-Mac platforms
* page/FramePrivate.h:
(WebCore::FramePrivate::FramePrivate): Added code to create the frame loader.
(WebCore::FramePrivate::~FramePrivate): Added code to delete the frame loader.
* page/Page.h:
* page/Page.cpp: (WebCore::Page::setDefersLoading): Removed the
#if PLATFORM(MAC) that Adam added as a stop-gap when I did this wrong
the other day.
* bridge/mac/FrameMac.mm:
(WebCore::FrameMac::FrameMac): Removed code to create the frame loader.
(WebCore::FrameMac::~FrameMac): Removed code to delete the frame loader.
* loader/FrameLoader.h: Changed import to include, added #if PLATFORM(MAC)
around the PolicyCheck definition.
* loader/FormState.cpp: Changed import to include.
* loader/FrameLoader.cpp: Ditto.
* loader/MainResourceLoader.h: Ditto.
* loader/FrameLoaderTypes.h: Added a header guard.
* loader/NetscapePlugInStreamLoader.h: Changed import to include.
Added #if PLATFORM(MAC) around Mac-specific details.
* loader/SubresourceLoader.h: Ditto.
* page/Frame.cpp: (WebCore::Frame::loader): Updated name of loader to
m_loader from m_frameLoader.
* CMakeLists.txt: Updated.
* WebCoreSources.bkl: Updated.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17442
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Mon, 30 Oct 2006 19:53:53 +0000 (19:53 +0000)]
2006-10-30 Nikolas Zimmermann <zimmermann@kde.org>
Reviewed and landed by Anders.
Patch by Zack rusin to fix:
http://bugs.webkit.org/show_bug.cgi?id=11429
Fix startup crash.
* platform/qt/FrameQtClient.cpp:
(WebCore::FrameQtClientDefault::openURL):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17441
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Mon, 30 Oct 2006 19:38:28 +0000 (19:38 +0000)]
2006-10-30 Zach Rusin <zack@kde.org>
Reviewed and landed by Anders.
* platform/network/qt/ResourceHandleQt.cpp:
(WebCore::ResourceHandle::receivedResponse):
* platform/qt/FrameQtClient.cpp:
(WebCore::FrameQtClientDefault::FrameQtClientDefault):
* platform/qt/LoaderFunctionsQt.cpp:
(WebCore::ServeSynchronousRequest):
More build fixes.
2006-10-30 Simon Hausmann <hausmann@kde.org>
Reviewed and landed by Anders.
- fix Qt build
* platform/qt/FrameQtClient.cpp: ResourceLoaderClient ->
ResourceHandleClient
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17440
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Mon, 30 Oct 2006 19:32:18 +0000 (19:32 +0000)]
Requested by Maciej.
* fast/dom/xmlhttprequest-get-expected.txt: Generated a new result.
Maciej says that the new behavior of returning empty string instead of
undefined is correct and matches Firefox, so the new result is better
than the old.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17439
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Mon, 30 Oct 2006 17:20:05 +0000 (17:20 +0000)]
WebCore:
Reviewed by John Sullivan.
- work toward removing Objective-C data types from FrameLoader.h:
removed NSDate, NSString, WebCorePageState, WebCoreResourceLoader,
and WebCoreResourceHandle
- moved bodyBackgroundColor function from Frame to WebFrame in WebKit
* page/PageState.h:
* page/PageState.cpp: Added, C++ class with much of what WebCorePageState had.
* bridge/mac/FrameMac.h: Removed uneeeded declarations and bodyBackgroundColor().
* bridge/mac/FrameMac.mm: (WebCore::FrameMac::startRedirectionTimer): Use a
double for the date instead of an NSDate.
* bridge/mac/WebCoreFrameBridge.h:
* bridge/mac/WebCoreFrameBridge.mm: Removed invalidatePageCache and
saveDocumentToPageCache methods.
* bridge/mac/WebCorePageState.h:
* bridge/mac/WebCorePageState.mm: Removed most of the class and turned it into
an Objective-C wrapper for PageState.
* loader/FrameLoader.h: Removed unused Objective-C types, eliminated use of
NSDate and WebCorePageState.
* loader/FrameLoaderClient.h: Changed NSDate to double.
* loader/mac/FrameLoaderMac.mm:
(WebCore::FrameLoader::receivedMainResourceError): Moved call to setInPageCache
here that used to be in invalidateCurrentItemPageCache on the WebKit side.
(WebCore::FrameLoader::clientRedirected): Changed NSDate to double for date.
(WebCore::FrameLoader::open): Moved one of the open functions that was part of
commitProvisionalLoad inside the commitProvisionalLoad function, so that it can
extract the parameters from the response. Changed the open function that takes
a PageState to use the new C++ PageState.
(WebCore::FrameLoader::commitProvisionalLoad): Added the code from the open
function; tightened up logic, removing a few cases that could never happen, as
well as the unused reload boolean.
* ForwardingHeaders/kjs/property_map.h: Added.
* WebCore.exp: Updated.
* WebCore.xcodeproj/project.pbxproj: Updated.
WebKit:
Reviewed by John Sullivan.
- work toward removing Objective-C data types from FrameLoader.h:
removed NSDate, NSString, WebCorePageState, WebCoreResourceLoader,
and WebCoreResourceHandle
- moved bodyBackgroundColor function here from Frame
* History/WebHistoryItem.m: (+[WebHistoryItem _closeObjectsInPendingPageCaches]):
Updated for change in WebCorePageState.
* WebCoreSupport/WebFrameBridge.mm: Removed saveDocumentToPageCache method.
* WebCoreSupport/WebFrameLoaderClient.h: Changed NSDate to double.
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::invalidateCurrentItemPageCache): Moved the code that was
formerly in invalidatePageCache: on the bridge here.
(WebFrameLoaderClient::dispatchWillPerformClientRedirect): Added code to make the
NSDate here.
(WebFrameLoaderClient::createPageCache): Restructured code to create the
WebCorePageState object directly instead of calling saveDocumentToPageCache on
the bridge.
* WebView/WebFrame.mm: (-[WebFrame _bodyBackgroundColor]): Rewrote this to work
directly with the DOM and renderers rather than using a function on Frame.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17438
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Mon, 30 Oct 2006 17:18:45 +0000 (17:18 +0000)]
Reviewed by John Sullivan.
* kjs/SavedBuiltins.h: Added needed include.
* wtf/OwnPtr.h: (WTF::OwnPtr::set): Fixed mistake in assertion.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17437
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Mon, 30 Oct 2006 16:27:12 +0000 (16:27 +0000)]
Reviewed by Tim H.
Fix for http://bugs.webkit.org/show_bug.cgi?id=10468
[Drosera] The Console toolbar button should bring the console window to the front.
The console now gets focus when its activated but already open. Command + L also
now activates/focuses the console.
* Drosera/English.lproj/MainMenu.nib/classes.nib:
* Drosera/English.lproj/MainMenu.nib/info.nib:
* Drosera/English.lproj/MainMenu.nib/keyedobjects.nib:
* Drosera/debugger.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17436
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Mon, 30 Oct 2006 11:08:12 +0000 (11:08 +0000)]
WebCore:
Reviewed by Anders.
- added ResourceResponse class and didReceiveResponse delegate call
* WebCore.xcodeproj/project.pbxproj: Added new files.
* bridge/mac/WebCoreFrameBridge.h: Removed no longer needed
expiresTimeForResponse: method.
* dom/XMLTokenizer.cpp:
(WebCore::openFunc): Updated to use ResourceResponse.
* loader/FrameLoader.h: Update loadResourceSynchronously to
use ResourceResponse.
* loader/LoaderFunctions.h:
* loader/icon/IconLoader.cpp:
(IconLoader::didReceiveResponse): Updated from receivedResponse
and made cross-platform.
* loader/icon/IconLoader.h: updated for above change
* loader/loader.cpp:
(WebCore::Loader::receivedResponse): reduced to just saving
the PlatformResponse (ideally we'd phase out use of this).
(WebCore::Loader::didReceivedResponse): most of the ReceivedResponse
logic.
* loader/loader.h:
* loader/mac/FrameLoaderMac.mm:
(WebCore::FrameLoader::loadResourceSynchronously): Return results
as ResourceResponse.
* loader/mac/IconLoaderMac.mm: remove receivedResponse.
* loader/mac/LoaderFunctionsMac.mm:
(WebCore::ServeSynchronousRequest): take ResourceResponse as
argument.
* platform/network/ResourceHandle.cpp:
* platform/network/ResourceHandle.h: Remove calls for
broken out response pieces.
* platform/network/ResourceHandleClient.h:
(WebCore::ResourceHandleClient::didReceiveResponse): New
delegate method.
* platform/network/ResourceHandleInternal.h:
(WebCore::ResourceHandleInternal::ResourceHandleInternal): Remove
storage of response bits, we're not gonna return them
seprately any more.
* platform/network/ResourceResponse.h: Added.
(WebCore::ResourceResponse::ResourceResponse): Freshly
implemented. Same for below.
(WebCore::ResourceResponse::url):
(WebCore::ResourceResponse::mimeType):
(WebCore::ResourceResponse::expectedContentLength):
(WebCore::ResourceResponse::textEncodingName):
(WebCore::ResourceResponse::suggestedFilename):
(WebCore::ResourceResponse::httpStatusCode):
(WebCore::ResourceResponse::setHTTPStatusCode):
(WebCore::ResourceResponse::httpHeaderField):
(WebCore::ResourceResponse::httpHeaderFields):
(WebCore::ResourceResponse::isMultipart):
(WebCore::ResourceResponse::setExpirationDate):
(WebCore::ResourceResponse::expirationDate):
* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::didReceiveResponse): Send didReceiveResponse
client method.
* platform/network/cf/ResourceResponseCFNet.h: Added.
* platform/network/cf/ResourceResponseCFNet.mm: Added.
(getResourceResponse): Helper function to get a ResourceResponse
from CFURLResponseRef.
* platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandleInternal::~ResourceHandleInternal):
Don't bother cleaning up fields we no longer have.
(WebCore::ResourceHandle::receivedResponse): Send
didReceiveResponse client method.
* platform/network/mac/ResourceResponseMac.h: Added.
* platform/network/mac/ResourceResponseMac.mm: Added.
(getResourceResponse): Helper function to get a ResourceResponse
from an NSURLResponse*.
* rendering/HitTestResult.cpp:
* xml/XSLTProcessor.cpp:
(WebCore::docLoaderFunc): Prepare for use of ResourceResponse.
* xml/xmlhttprequest.cpp:
(WebCore::XMLHttpRequest::getResponseText): Store http response
info in the form of a ResourceResponse, change all methods to
account for this.
(WebCore::XMLHttpRequest::getResponseXML):
(WebCore::XMLHttpRequest::XMLHttpRequest):
(WebCore::XMLHttpRequest::open):
(WebCore::XMLHttpRequest::send):
(WebCore::XMLHttpRequest::getAllResponseHeaders):
(WebCore::XMLHttpRequest::getResponseHeader):
(WebCore::XMLHttpRequest::getStatus):
(WebCore::XMLHttpRequest::getStatusText):
(WebCore::XMLHttpRequest::processSyncLoadResults):
(WebCore::XMLHttpRequest::didFinishLoading):
(WebCore::XMLHttpRequest::didReceiveResponse):
(WebCore::XMLHttpRequest::didReceiveData):
* xml/xmlhttprequest.h:
WebKit:
Reviewed by Anders.
- added ResourceResponse class and didReceiveResponse delegate call
* WebCoreSupport/WebFrameBridge.mm: Removed no longer needed
expiresTimeForResponse: method.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17435
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Mon, 30 Oct 2006 01:31:09 +0000 (01:31 +0000)]
- fix build
* loader/DocumentLoader.h: Add declarations so this compiles without ObjC.
* loader/NetscapePlugInStreamLoader.h: Ditto.
* loader/ResourceLoader.h: Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17434
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Mon, 30 Oct 2006 01:16:42 +0000 (01:16 +0000)]
WebCore:
- one last name change -- WebFormState.h to FormState.h
- added more empty placeholder platform-independent files
for currently-Mac-specific loader classes
* loader/FormState.cpp: Updated include.
* loader/FrameLoader.cpp: Updated include.
* loader/mac/FrameLoaderMac.mm: Updated include.
* loader/WebFormState.h: Removed.
* loader/FormState.h: Added.
* loader/DocumentLoader.cpp: Added.
* loader/MainResourceLoader.cpp: Added.
* loader/NetscapePlugInStreamLoader.cpp: Added.
* loader/ResourceLoader.cpp: Added.
* loader/SubresourceLoader.cpp: Added.
* WebCore.xcodeproj/project.pbxproj: Updated for changes above.
WebKit:
- update for the WebCore rename
* WebCoreSupport/WebFrameLoaderClient.mm:
* WebView/WebFrame.mm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17433
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Mon, 30 Oct 2006 01:01:00 +0000 (01:01 +0000)]
* Scripts/do-file-rename: Renames done, ready for the next round.
* Scripts/do-webcore-rename: Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17432
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Mon, 30 Oct 2006 00:57:20 +0000 (00:57 +0000)]
WebCore:
- did the do-webcore-rename renames, including a number of changes
to the names of loader files (and WebResourceLoader -> ResourceLoader),
jScript() to scriptProxy(), jScriptEnabled() to javaScriptEnabled(),
and improvements to the names of decoder classes and their source
files (Decoder -> TextResourceDecoder, StreamingTextDecoder -> TextCodec)
WebKit:
- update for the WebCore renames
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17431
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Mon, 30 Oct 2006 00:43:49 +0000 (00:43 +0000)]
Rubber stamped by Adam (kinda).
- add Mac suffixes and correct filenames inside loader/mac
* WebCore.xcodeproj/project.pbxproj: Updated for changes below.
* loader/mac/FrameLoader.mm: Removed.
* loader/mac/WebDocumentLoader.mm: Removed.
* loader/mac/WebLoader.mm: Removed.
* loader/mac/WebMainResourceLoader.mm: Removed.
* loader/mac/WebNetscapePlugInStreamLoader.mm: Removed.
* loader/mac/WebSubresourceLoader.mm: Removed.
* loader/mac/FrameLoaderMac.mm: Added.
* loader/mac/DocumentLoaderMac.mm: Added.
* loader/mac/ResourceLoaderMac.mm: Added.
* loader/mac/MainResourceLoaderMac.mm: Added.
* loader/mac/WebNetscapePlugInStreamLoaderMac.mm: Added.
* loader/mac/SubresourceLoaderMac.mm: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17430
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Mon, 30 Oct 2006 00:37:02 +0000 (00:37 +0000)]
Reviewed by Adam.
- moving towards use of FrameLoader cross-platform; get FrameLoader.h
and FrameLoader.cpp mostly ready
* WebCore.xcodeproj/project.pbxproj: Added FrameLoader.cpp and
FormState.cpp. Removed WebFormState.mm.
* loader/FrameLoader.h: Put in lots of #if statements to see if we can
get this header compiling on non-Mac.
* loader/FrameLoader.cpp: Added. Has non-Mac-specific bits of FrameLoader.
* loader/mac/FrameLoader.mm: Moved some non-Mac-specific bits out.
* loader/FrameLoaderClient.h: Added some ifdefs.
* loader/WebDocumentLoader.h: Ditto.
* loader/WebLoader.h: Ditto.
* loader/WebMainResourceLoader.h: Ditto.
* loader/mac/WebDocumentLoader.mm:
(WebCore::DocumentLoader::isLoadingInAPISense):
Rewrote to work without bridge, partly to remove the need for ObjC
bridge type in the header, and also because we're tearing down the bridge.
* loader/mac/WebMainResourceLoader.mm:
(WebCore::MainResourceLoader::MainResourceLoader): Removed unused
m_contentLength and m_bytesReceived.
(WebCore::MainResourceLoader::didReceiveResponse): Ditto.
(WebCore::MainResourceLoader::didReceiveData): Ditto.
* bridge/mac/WebCoreFrameBridge.h: Removed doneProcessingData.
* bridge/mac/WebCoreFrameBridge.mm: Ditto.
* loader/mac/FormState.mm: Removed.
* loader/FormState.cpp: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17429
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Sun, 29 Oct 2006 23:38:35 +0000 (23:38 +0000)]
Rubber stamped by Adam.
- moving towards use of FrameLoader cross-platform; move the headers
for the Mac loader from loader/mac into loader, in preparation for
making them useful on non-Mac
* WebCore.xcodeproj/project.pbxproj:
* loader/mac/FrameLoader.h: Removed.
* loader/mac/WebDocumentLoader.h: Removed.
* loader/mac/WebFormState.h: Removed.
* loader/mac/WebLoader.h: Removed.
* loader/mac/WebMainResourceLoader.h: Removed.
* loader/mac/WebNetscapePlugInStreamLoader.h: Removed.
* loader/mac/WebSubresourceLoader.h: Removed.
* loader/FrameLoader.h: Added.
* loader/WebDocumentLoader.h: Added.
* loader/WebFormState.h: Added.
* loader/WebLoader.h: Added.
* loader/WebMainResourceLoader.h: Added.
* loader/WebNetscapePlugInStreamLoader.h: Added.
* loader/WebSubresourceLoader.h: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17428
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Sun, 29 Oct 2006 23:01:37 +0000 (23:01 +0000)]
Reviewed by Geoff.
Finish Darin's clean up of the use of __APPLE__ in WebCore, begun in
r17405.
* platform/DeprecatedString.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17427
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin [Sun, 29 Oct 2006 22:07:47 +0000 (22:07 +0000)]
Rubber stamped by Geoff.
This is a followup to my HitTestResult checkin. Most of the
HitTestResult local variables in the code were named i or info for
when the class was named NodeInfo. This patch renames all of these
local variables to result.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17426
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Sun, 29 Oct 2006 20:48:17 +0000 (20:48 +0000)]
More semi-fixes.
* page/Page.cpp: Forgot to wrap the actual definition of
setDefersLoading() in PLATFORM(MAC).
* platform/PlatformWheelEvent.h: Fix up preprocessor directives.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17425
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Sun, 29 Oct 2006 20:32:41 +0000 (20:32 +0000)]
Build semi-fix.
Move all FrameLoader-related code in Page.{cpp,h} within #if
PLATFORM(MAC), since this class currently only exists on Mac.
* page/Page.cpp:
* page/Page.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17424
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Sun, 29 Oct 2006 19:15:43 +0000 (19:15 +0000)]
* Scripts/do-file-rename: And again.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17423
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Sun, 29 Oct 2006 19:06:36 +0000 (19:06 +0000)]
build fix.
* platform/PlatformString.h:
(WebCore::String::operator NSString*):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17422
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Sun, 29 Oct 2006 19:03:18 +0000 (19:03 +0000)]
Rolled out accidental commit.
* platform/AtomicString.h:
(WebCore::AtomicString::AtomicString):
(WebCore::AtomicString::operator NSString*):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17421
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Sun, 29 Oct 2006 18:58:27 +0000 (18:58 +0000)]
Reviewed by Geoff.
Test for http://bugs.webkit.org/show_bug.cgi?id=11444
REGRESSION (r17378): Exception (-[NSCFDictionary setObject:forKey:]: attempt to insert nil value)
when submitting a form with an empty uninitialized field
* fast/forms/submit-nil-value-field-assert-expected.txt: Added.
* fast/forms/submit-nil-value-field-assert.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17420
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Sun, 29 Oct 2006 18:54:28 +0000 (18:54 +0000)]
RS by Darin.
Rolled out change to map NULL Strings to nil NSStrings because it caused
even more AppKit crashes. Maybe we should remove the NSString * operator
entirely, since its use is not straight-forward, and require callers to
specify explicitly whether they tolerate NULL.
* platform/AtomicString.h:
* platform/PlatformString.h:
(WebCore::String::operator NSString*):
* platform/mac/TextFieldMac.mm:
(-[NSSearchFieldCell _addStringToRecentSearches:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17419
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Sun, 29 Oct 2006 18:28:25 +0000 (18:28 +0000)]
* Scripts/do-webcore-rename: Tweaked plans for renaming again.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17418
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Sun, 29 Oct 2006 18:03:17 +0000 (18:03 +0000)]
Added a bug number to change log.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17417
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Sun, 29 Oct 2006 17:44:39 +0000 (17:44 +0000)]
Reviewed by Geoff.
- fixed storage leak showing up on the buildbot
* loader/mac/WebSubresourceLoader.mm: (WebCore::SubresourceLoader::create):
Release the NSURLRequest after passing it to load. Also clean up logic a bit.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17416
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Sun, 29 Oct 2006 17:12:56 +0000 (17:12 +0000)]
WebCore:
Rubber stamped by Adam Roben.
- renamed WebFrameLoaderClient to match the class name inside it
* loader/mac/WebFrameLoaderClient.h: Removed.
* loader/FrameLoaderClient.h: Moved it here.
* WebCore.xcodeproj/project.pbxproj: Updated project.
* bridge/mac/FrameMac.mm: Updated includes.
* bridge/mac/WebCoreFrameBridge.mm: Ditto.
* loader/mac/FrameLoader.mm: Ditto.
* loader/mac/WebLoader.h: Ditto.
WebKit:
Rubber stamped by Adam Roben.
- renamed WebCore's WebFrameLoaderClient to match the class name inside it
* WebCoreSupport/WebFrameBridge.mm: Update include.
* WebCoreSupport/WebFrameLoaderClient.h: Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17415
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Sun, 29 Oct 2006 16:50:10 +0000 (16:50 +0000)]
Reviewed by Mitz.
- fix crash visible on buildbot and also when running the test
anchor-image-scrolled-x-y.html under libgmalloc
* loader/mac/WebSubresourceLoader.h: Renamed m_loader to m_handle
now that the class is named ResourceHandle.
* loader/mac/WebSubresourceLoader.mm: Renaming, plus:
(WebCore::SubresourceLoader::didFinishLoading): Get the handle into
a local RefPtr before calling finishJobAndHandle, since we might get
cancelled inside that function, so we should not rely on m_handle to
keep the ResourceHandle alive.
(WebCore::SubresourceLoader::didFail): Ditto.
(WebCore::SubresourceLoader::didCancel): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17414
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Sun, 29 Oct 2006 12:21:37 +0000 (12:21 +0000)]
2006-10-30 Mark Rowe <bdash@webkit.org>
Reviewed by Maciej.
Fix fast/block/basic/014.html to pass when Microsoft Office fonts are present.
* fast/block/basic/014-expected.checksum:
* fast/block/basic/014-expected.png:
* fast/block/basic/014-expected.txt:
* fast/block/basic/014.html: Always use default sans-serif font rather than
preferring Microsoft Office fonts.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17413
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Sun, 29 Oct 2006 11:15:21 +0000 (11:15 +0000)]
2006-10-29 Mark Rowe <bdash@webkit.org>
Reviewed by Mitz.
Fix failure in editing/inserting/insert-
3851164-fix if Gill Sans font is present.
* editing/inserting/insert-
3851164-fix.html: Specify sans-serif to match expected results
generated without Gill Sans present.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17412
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Sun, 29 Oct 2006 10:00:32 +0000 (10:00 +0000)]
Not reviewed.
- build fix
* platform/network/mac/ResourceHandleMac.mm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17411
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Sun, 29 Oct 2006 09:44:37 +0000 (09:44 +0000)]
Rubber stamped by Darin.
- renamed ResourceLoader to ResourceHandle (and same for related classes)
* CMakeLists.txt:
* Projects/gdk/webcore-gdk.bkl:
* WebCore.vcproj/WebCore/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* WebCoreSources.bkl:
* bridge/mac/FrameMac.mm:
* bridge/win/FrameWin.cpp:
* dom/XMLTokenizer.cpp:
* loader/Cache.cpp:
* loader/CachedResource.h:
* loader/LoaderFunctions.h:
* loader/icon/IconLoader.cpp:
(IconLoader::startLoading):
(IconLoader::didReceiveData):
(IconLoader::didFinishLoading):
* loader/icon/IconLoader.h:
* loader/loader.cpp:
(WebCore::Loader::servePendingRequests):
(WebCore::Loader::receivedAllData):
(WebCore::Loader::receivedResponse):
(WebCore::Loader::didReceiveData):
(WebCore::Loader::cancelRequests):
(WebCore::Loader::jobForRequest):
* loader/loader.h:
* loader/mac/IconLoaderMac.mm:
(IconLoader::receivedResponse):
* loader/mac/LoaderFunctionsMac.mm:
* loader/mac/WebLoader.h:
* loader/mac/WebSubresourceLoader.h:
* loader/mac/WebSubresourceLoader.mm:
(WebCore::SubresourceLoader::SubresourceLoader):
(WebCore::SubresourceLoader::create):
* platform/gdk/FrameGdk.cpp:
(WebCore::FrameGdkClientDefault::FrameGdkClientDefault):
(WebCore::FrameGdkClientDefault::openURL):
(WebCore::FrameGdkClientDefault::submitForm):
(WebCore::FrameGdkClientDefault::receivedResponse):
(WebCore::FrameGdkClientDefault::didReceiveData):
(WebCore::FrameGdkClientDefault::receivedAllData):
* platform/gdk/FrameGdk.h:
* platform/gdk/TemporaryLinkStubs.cpp:
(WebCore::ServeSynchronousRequest):
(WebCore::ResourceHandle::assembleResponseHeaders):
(WebCore::ResourceHandle::retrieveCharset):
* platform/network/ResourceHandle.cpp: Added.
(WebCore::ResourceHandle::ResourceHandle):
(WebCore::ResourceHandle::create):
(WebCore::ResourceHandle::isErrorPage):
(WebCore::ResourceHandle::error):
(WebCore::ResourceHandle::setError):
(WebCore::ResourceHandle::responseEncoding):
(WebCore::ResourceHandle::responseHTTPHeadersAsString):
(WebCore::ResourceHandle::kill):
(WebCore::ResourceHandle::requestHeaders):
(WebCore::ResourceHandle::url):
(WebCore::ResourceHandle::postData):
(WebCore::ResourceHandle::method):
(WebCore::ResourceHandle::client):
* platform/network/ResourceHandle.h: Added.
(WebCore::ResourceHandle::getInternal):
* platform/network/ResourceHandleClient.h: Added.
(WebCore::ResourceHandleClient::~ResourceHandleClient):
(WebCore::ResourceHandleClient::didReceiveData):
(WebCore::ResourceHandleClient::didFinishLoading):
(WebCore::ResourceHandleClient::receivedRedirect):
(WebCore::ResourceHandleClient::receivedResponse):
(WebCore::ResourceHandleClient::receivedAllData):
* platform/network/ResourceHandleInternal.h: Added.
(WebCore::ResourceHandleInternal::ResourceHandleInternal):
* platform/network/ResourceLoader.cpp: Removed.
* platform/network/ResourceLoader.h: Removed.
* platform/network/ResourceLoaderClient.h: Removed.
* platform/network/ResourceLoaderInternal.h: Removed.
* platform/network/cf/ResourceHandleCFNet.cpp: Added.
(WebCore::willSendRequest):
(WebCore::didReceiveResponse):
(WebCore::didReceiveData):
(WebCore::didFinishLoading):
(WebCore::didFail):
(WebCore::willCacheResponse):
(WebCore::didReceiveChallenge):
(WebCore::ResourceHandleInternal::~ResourceHandleInternal):
(WebCore::ResourceHandle::~ResourceHandle):
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::cancel):
* platform/network/cf/ResourceLoaderCFNet.cpp: Removed.
* platform/network/gdk/ResourceHandleCurl.cpp: Added.
(WebCore::ResourceHandleInternal::~ResourceHandleInternal):
(WebCore::ResourceHandle::~ResourceHandle):
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::cancel):
* platform/network/gdk/ResourceHandleManager.cpp: Added.
(WebCore::ResourceHandleManager::ResourceHandleManager):
(WebCore::ResourceHandleManager::get):
(WebCore::ResourceHandleManager::useSimpleTransfer):
(WebCore::writeCallback):
(WebCore::ResourceHandleManager::downloadTimerCallback):
(WebCore::ResourceHandleManager::remove):
(WebCore::ResourceHandleManager::add):
(WebCore::ResourceHandleManager::cancel):
* platform/network/gdk/ResourceHandleManager.h: Added.
* platform/network/gdk/ResourceLoaderCurl.cpp: Removed.
* platform/network/gdk/ResourceLoaderManager.cpp: Removed.
* platform/network/gdk/ResourceLoaderManager.h: Removed.
* platform/network/mac/ResourceHandleMac.mm: Added.
(WebCore::ResourceHandleInternal::~ResourceHandleInternal):
(WebCore::ResourceHandle::~ResourceHandle):
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::assembleResponseHeaders):
(WebCore::ResourceHandle::retrieveResponseEncoding):
(WebCore::ResourceHandle::receivedResponse):
(WebCore::ResourceHandle::cancel):
(WebCore::ResourceHandle::redirectedToURL):
(WebCore::ResourceHandle::addData):
(WebCore::ResourceHandle::finishJobAndHandle):
(WebCore::ResourceHandle::reportError):
* platform/network/mac/ResourceLoaderMac.mm: Removed.
* platform/network/qt/ResourceHandleManager.cpp: Added.
(WebCore::ResourceHandleManager::ResourceHandleManager):
(WebCore::ResourceHandleManager::~ResourceHandleManager):
(WebCore::ResourceHandleManager::self):
(WebCore::ResourceHandleManager::slotData):
(WebCore::ResourceHandleManager::slotMimetype):
(WebCore::ResourceHandleManager::slotResult):
(WebCore::ResourceHandleManager::remove):
(WebCore::ResourceHandleManager::add):
(WebCore::ResourceHandleManager::cancel):
* platform/network/qt/ResourceHandleManager.h: Added.
* platform/network/qt/ResourceHandleQt.cpp: Added.
(WebCore::ResourceHandleInternal::~ResourceHandleInternal):
(WebCore::ResourceHandle::~ResourceHandle):
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::cancel):
(WebCore::ResourceHandle::assembleResponseHeaders):
(WebCore::ResourceHandle::retrieveResponseEncoding):
(WebCore::ResourceHandle::receivedResponse):
(WebCore::ResourceHandle::extractCharsetFromHeaders):
* platform/network/qt/ResourceLoaderManager.cpp: Removed.
* platform/network/qt/ResourceLoaderManager.h: Removed.
* platform/network/qt/ResourceLoaderQt.cpp: Removed.
* platform/network/win/ResourceHandleWin.cpp: Added.
(WebCore::):
(WebCore::addToOutstandingJobs):
(WebCore::lookupResourceHandle):
(WebCore::ResourceHandleWndProc):
(WebCore::initializeOffScreenResourceHandleWindow):
(WebCore::ResourceHandleInternal::~ResourceHandleInternal):
(WebCore::ResourceHandle::~ResourceHandle):
(WebCore::ResourceHandle::onHandleCreated):
(WebCore::ResourceHandle::onRequestRedirected):
(WebCore::ResourceHandle::onRequestComplete):
(WebCore::ResourceHandle::start):
(WebCore::ResourceHandle::fileLoadTimer):
(WebCore::ResourceHandle::cancel):
(WebCore::ResourceHandle::setHasReceivedResponse):
(WebCore::ResourceHandle::hasReceivedResponse):
* platform/network/win/ResourceHandleWin.h: Added.
* platform/network/win/ResourceLoaderWin.cpp: Removed.
* platform/network/win/ResourceLoaderWin.h: Removed.
* platform/qt/FrameQt.cpp:
* platform/qt/FrameQtClient.cpp:
(WebCore::FrameQtClientDefault::openURL):
(WebCore::FrameQtClientDefault::submitForm):
(WebCore::FrameQtClientDefault::receivedResponse):
(WebCore::FrameQtClientDefault::didReceiveData):
(WebCore::FrameQtClientDefault::receivedAllData):
* platform/qt/FrameQtClient.h:
* platform/win/TemporaryLinkStubs.cpp:
(WebCore::ResourceHandle::assembleResponseHeaders):
(WebCore::ResourceHandle::retrieveResponseEncoding):
(WebCore::ServeSynchronousRequest):
* xml/XSLTProcessor.cpp:
* xml/xmlhttprequest.cpp:
(WebCore::XMLHttpRequest::send):
(WebCore::XMLHttpRequest::didFinishLoading):
(WebCore::XMLHttpRequest::receivedRedirect):
(WebCore::XMLHttpRequest::didReceiveData):
* xml/xmlhttprequest.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17410
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Sun, 29 Oct 2006 09:36:21 +0000 (09:36 +0000)]
LayoutTests:
* fast/events/js-keyboard-event-creation-expected.txt: Update test that
is affected in a minor way by the change to DumpRenderTree.
WebKitTools:
Reviewed by Mitz.
* DumpRenderTree/DumpRenderTree.m: (-[DumpRenderTreeWindow keyDown:]):
Added. Does nothing, which prevents a beep.
* Scripts/do-webcore-rename: Tweaked plans for renaming a bit.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17409
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Sun, 29 Oct 2006 08:47:23 +0000 (08:47 +0000)]
WebCore:
Reviewed by Maciej.
- eliminate use of NSArray to carry form data around
* WebCore.exp:
* WebCore.xcodeproj/project.pbxproj:
* bridge/mac/FormDataMac.h: Removed.
* bridge/mac/FormDataMac.mm: Removed.
* bridge/mac/FrameMac.h:
* bridge/mac/WebCoreFrameBridge.h:
* bridge/mac/WebCoreFrameBridge.mm:
* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::submit):
* loader/FormData.h:
(WebCore::FormData::isEmpty):
* loader/mac/FrameLoader.h:
* loader/mac/FrameLoader.mm:
(WebCore::FrameLoader::load):
(WebCore::FrameLoader::post):
(WebCore::FrameLoader::loadEmptyDocumentSynchronously):
(WebCore::FrameLoader::loadResourceSynchronously):
* loader/mac/LoaderFunctionsMac.mm:
(WebCore::ServeSynchronousRequest):
* loader/mac/WebFormDataStream.h:
* loader/mac/WebFormDataStream.m:
(WebCore::pairRetain):
(WebCore::pairRelease):
(WebCore::pairEqual):
(WebCore::pairHash):
(WebCore::closeCurrentStream):
(WebCore::scheduleWithPair):
(WebCore::advanceCurrentStream):
(WebCore::openNextStream):
(WebCore::formCreate):
(WebCore::formFinalize):
(WebCore::formOpen):
(WebCore::formRead):
(WebCore::formCanRead):
(WebCore::formClose):
(WebCore::formSchedule):
(WebCore::formUnschedule):
(WebCore::formEventCallback):
(WebCore::setHTTPBody):
* loader/mac/WebSubresourceLoader.h:
* loader/mac/WebSubresourceLoader.mm:
(WebCore::SubresourceLoader::create):
* platform/network/mac/ResourceLoaderMac.mm:
WebKit:
Reviewed by Maciej.
- eliminate use of NSArray to carry form data around
(the code in this framework was actually using the NSArray to hold a single
NSData anyway, so I just went back to an NSData for now)
* History/WebHistoryItem.m:
(-[WebHistoryItem _setFormInfoFromRequest:]):
(-[WebHistoryItem formData]):
* History/WebHistoryItemPrivate.h:
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::dispatchWillSubmitForm):
* WebView/WebFrame.mm:
(-[WebFrame _loadItem:withLoadType:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17408
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Sun, 29 Oct 2006 08:36:14 +0000 (08:36 +0000)]
Reviewed by Darin.
- create SubresourceLoader with a ResourceRequest, not broken out request bits
* loader/mac/WebSubresourceLoader.h:
* loader/mac/WebSubresourceLoader.mm:
(WebCore::SubresourceLoader::create):
* platform/network/mac/ResourceLoaderMac.mm:
(WebCore::ResourceLoader::start):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17407
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Sun, 29 Oct 2006 07:30:17 +0000 (07:30 +0000)]
Reviewed by Darin.
- removed ObjC glue between ResourceLoader and SubresourceLoader, then now talk to each other directly
Removed WebCoreResourceLoader, WebCoreResourceHandle and WebCoreResourceLoaderImp
* WebCore.xcodeproj/project.pbxproj:
* bridge/mac/WebCoreFrameBridge.h:
* loader/mac/FrameLoader.h:
* loader/mac/FrameLoader.mm:
* loader/mac/LoaderFunctionsMac.mm:
* loader/mac/WebLoader.h:
* loader/mac/WebSubresourceLoader.h:
* loader/mac/WebSubresourceLoader.mm:
(WebCore::SubresourceLoader::SubresourceLoader):
(WebCore::SubresourceLoader::create):
(WebCore::SubresourceLoader::willSendRequest):
(WebCore::SubresourceLoader::didReceiveResponse):
(WebCore::SubresourceLoader::didReceiveData):
(WebCore::SubresourceLoader::didFinishLoading):
(WebCore::SubresourceLoader::didFail):
(WebCore::SubresourceLoader::didCancel):
* platform/network/ResourceLoader.h:
* platform/network/ResourceLoaderInternal.h:
* platform/network/mac/ResourceLoaderMac.mm:
(WebCore::ResourceLoader::~ResourceLoader):
(WebCore::ResourceLoader::start):
(WebCore::ResourceLoader::receivedResponse):
(WebCore::ResourceLoader::cancel):
(WebCore::ResourceLoader::redirectedToURL):
(WebCore::ResourceLoader::addData):
(WebCore::ResourceLoader::finishJobAndHandle):
(WebCore::ResourceLoader::reportError):
* platform/network/mac/WebCoreResourceLoader.h: Removed.
* platform/network/mac/WebCoreResourceLoaderImp.h: Removed.
* platform/network/mac/WebCoreResourceLoaderImp.mm: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17406
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Sun, 29 Oct 2006 06:48:02 +0000 (06:48 +0000)]
JavaScriptCore:
Reviewed by Maciej.
- renamed PassRefPtr::release to releaseRef to make it clearer that
it's the counterpart of adoptRef, and to make it harder to confuse
it with the safer-to-use RefPtr::release
* kjs/identifier.cpp:
(KJS::CStringTranslator::translate):
(KJS::UCharBufferTranslator::translate):
* kjs/ustring.cpp:
(KJS::UString::Rep::create):
* wtf/PassRefPtr.h:
(WTF::PassRefPtr::PassRefPtr):
(WTF::PassRefPtr::~PassRefPtr):
(WTF::PassRefPtr::get):
(WTF::PassRefPtr::releaseRef):
(WTF::PassRefPtr::operator->):
(WTF::PassRefPtr::operator=):
(WTF::adoptRef):
(WTF::static_pointer_cast):
(WTF::const_pointer_cast):
* wtf/RefPtr.h:
(WTF::RefPtr::RefPtr):
(WTF::RefPtr::operator=):
WebCore:
Reviewed by Maciej.
- eliminated the use of Objective-C for the policy decider
machinery, obviating the need for WebPolicyDecider,
WebCoreFrameLoaderAsDelegate, and
WebCoreMainResourceLoaderAsPolicyDelegate
- grouped the state related to policy decisions into a PolicyCheck
class to simplify the FrameLoader logic
- removed six methods from the bridge, reducing FrameLoader's use of
the bridge to a single method
- changed form state to always use HashMap instead of NSDictionary
- moved the defersLoading flag from WebView to WebCore::Page
and changed code to consistently call it defersLoading rather
than defersCallbacks
- updated for rename of PassRefPtr::release to releaseRef
- replaced all uses of __APPLE__ with appropriate PLATFORM defines
- cleaned up kjs_binding.h a bit
- cleaned up FrameMac.h a bit
* loader/mac/WebPolicyDecider.h: Removed.
* loader/mac/WebPolicyDecider.mm: Removed.
* WebCore.xcodeproj/project.pbxproj: Updated for removal.
* WebCore.exp:
* bindings/js/kjs_binding.cpp:
(KJS::ScriptInterpreter::ScriptInterpreter):
(KJS::ScriptInterpreter::wasRunByUserGesture):
* bindings/js/kjs_binding.h:
(KJS::ScriptInterpreter::setCurrentEvent):
(KJS::ScriptInterpreter::setInlineCode):
(KJS::ScriptInterpreter::setProcessingTimerCallback):
(KJS::ScriptInterpreter::getCurrentEvent):
(KJS::cacheDOMObject):
(KJS::DOMExceptionTranslator::DOMExceptionTranslator):
* bridge/AXObjectCache.h:
* bridge/mac/BrowserExtensionMac.mm:
(WebCore::BrowserExtensionMac::createNewWindow):
* bridge/mac/FrameMac.h:
* bridge/mac/FrameMac.mm:
(WebCore::FrameMac::loadRequest):
(WebCore::FrameMac::submitForm):
(WebCore::FrameMac::urlSelected):
(WebCore::FrameMac::userAgent):
(WebCore::FrameMac::passMouseDownEventToWidget):
(WebCore::FrameMac::handleMouseMoveEvent):
* bridge/mac/PageMac.mm:
(WebCore::Page::Page):
* bridge/mac/WebCoreEditCommand.mm:
* bridge/mac/WebCoreFrameBridge.h:
* bridge/mac/WebCoreFrameBridge.mm:
(-[WebCoreFrameBridge dragOperationForDraggingInfo:]):
(-[WebCoreFrameBridge syncLoadResourceWithMethod:URL:customHeaders:postData:finalURL:responseHeaders:statusCode:]):
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::cleanup):
(WebCore::CSSPrimitiveValue::cssText):
* css/CSSPrimitiveValue.h:
(WebCore::CSSPrimitiveValue::):
* css/CSSValueList.cpp:
(WebCore::CSSValueList::append):
* css/cssparser.cpp:
(WebCore::CSSParser::parseValue):
* css/cssparser.h:
* css/cssstyleselector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::updateSelection):
(WebCore::Document::implicitClose):
(WebCore::Document::setFocusNode):
* dom/Document.h:
* editing/ReplaceSelectionCommand.h:
* html/HTMLParser.cpp:
(WebCore::HTMLParser::handleResidualStyleCloseTagAcrossBlocks):
* loader/mac/FrameLoader.h:
(WebCore::PolicyCheck::request):
* loader/mac/FrameLoader.mm:
(WebCore::FrameLoader::~FrameLoader):
(WebCore::FrameLoader::safeLoad):
(WebCore::FrameLoader::load):
(WebCore::FrameLoader::open):
(WebCore::FrameLoader::stopLoading):
(WebCore::setAllDefersLoading):
(WebCore::FrameLoader::setDefersLoading):
(WebCore::FrameLoader::willSendRequest):
(WebCore::FrameLoader::receivedMainResourceError):
(WebCore::FrameLoader::callContinueFragmentScrollAfterNavigationPolicy):
(WebCore::FrameLoader::commitProvisionalLoad):
(WebCore::FrameLoader::checkNavigationPolicy):
(WebCore::FrameLoader::checkContentPolicy):
(WebCore::FrameLoader::cancelContentPolicyCheck):
(WebCore::FrameLoader::stopPolicyCheck):
(WebCore::FrameLoader::checkNewWindowPolicy):
(WebCore::FrameLoader::continueAfterNewWindowPolicy):
(WebCore::FrameLoader::continueAfterNavigationPolicy):
(WebCore::FrameLoader::continueAfterContentPolicy):
(WebCore::FrameLoader::continueAfterWillSubmitForm):
(WebCore::FrameLoader::callContinueLoadAfterNavigationPolicy):
(WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
(WebCore::FrameLoader::closeDocument):
(WebCore::FrameLoader::transitionToCommitted):
(WebCore::FrameLoader::callContinueLoadAfterNewWindowPolicy):
(WebCore::FrameLoader::continueLoadAfterNewWindowPolicy):
(WebCore::FrameLoader::post):
(WebCore::FrameLoader::detachFromParent):
(WebCore::FrameLoader::addExtraFieldsToRequest):
(WebCore::PolicyCheck::PolicyCheck):
(WebCore::PolicyCheck::clear):
(WebCore::PolicyCheck::set):
(WebCore::PolicyCheck::call):
(WebCore::PolicyCheck::dropRequest):
(WebCore::FrameLoaderClient::~FrameLoaderClient):
* loader/mac/WebFormState.h:
* loader/mac/WebFormState.mm:
* loader/mac/WebFrameLoaderClient.h:
* loader/mac/WebLoader.h:
(WebCore::WebResourceLoader::defersLoading):
* loader/mac/WebLoader.mm:
(WebCore::WebResourceLoader::WebResourceLoader):
(WebCore::WebResourceLoader::load):
(WebCore::WebResourceLoader::setDefersLoading):
* loader/mac/WebMainResourceLoader.h:
* loader/mac/WebMainResourceLoader.mm:
(WebCore::MainResourceLoader::MainResourceLoader):
(WebCore::MainResourceLoader::releaseDelegate):
(WebCore::MainResourceLoader::didCancel):
(WebCore::MainResourceLoader::callContinueAfterNavigationPolicy):
(WebCore::MainResourceLoader::continueAfterNavigationPolicy):
(WebCore::MainResourceLoader::willSendRequest):
(WebCore::MainResourceLoader::callContinueAfterContentPolicy):
(WebCore::MainResourceLoader::continueAfterContentPolicy):
(WebCore::MainResourceLoader::didReceiveResponse):
(WebCore::MainResourceLoader::didReceiveData):
(WebCore::MainResourceLoader::didFinishLoading):
(WebCore::MainResourceLoader::didFail):
(WebCore::MainResourceLoader::loadNow):
(WebCore::MainResourceLoader::load):
(WebCore::MainResourceLoader::setDefersLoading):
* page/Frame.cpp:
(WebCore::Frame::paint):
* page/FrameView.cpp:
(WebCore::FrameView::layout):
* page/FrameView.h:
* page/Page.cpp:
(WebCore::Page::setDefersLoading):
* page/Page.h:
(WebCore::Page::defersLoading):
* platform/DeprecatedString.h:
* platform/DeprecatedStringList.h:
* platform/FontFallbackList.h:
* platform/PlatformKeyboardEvent.h:
* platform/PlatformMouseEvent.h:
* platform/PlatformWheelEvent.h:
* platform/mac/ClipboardMac.h:
* platform/mac/ClipboardMac.mm:
(WebCore::ClipboardMac::setDragImage):
(WebCore::ClipboardMac::dragNSImage):
(WebCore::ClipboardMac::sourceOperation):
(WebCore::ClipboardMac::destinationOperation):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::setStyle):
* rendering/break_lines.cpp:
(WebCore::nextBreakablePosition):
WebKit:
Reviewed by Maciej.
- eliminated the use of Objective-C for the policy decider
machinery, obviating the need for WebPolicyDeciderMac
- moved the defersLoading flag from WebView to WebCore::Page
- removed unused copies of four methods that in the frame bridge;
the actually-used copies are in the page bridge
- updated for rename of PassRefPtr::release to releaseRef
* WebView/WebPolicyDeciderMac.h: Removed.
* WebView/WebPolicyDeciderMac.m: Removed.
* WebKit.xcodeproj/project.pbxproj: Updated for removal.
* Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView sendEvent:]):
* Plugins/WebNetscapePluginStream.mm:
* WebCoreSupport/WebFrameBridge.mm:
* WebCoreSupport/WebFrameLoaderClient.h:
* WebCoreSupport/WebFrameLoaderClient.mm:
(getWebView):
(WebFrameLoaderClient::WebFrameLoaderClient):
(WebFrameLoaderClient::willCloseDocument):
(WebFrameLoaderClient::dispatchDecidePolicyForMIMEType):
(WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
(WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
(WebFrameLoaderClient::cancelPolicyCheck):
(WebFrameLoaderClient::dispatchWillSubmitForm):
(WebFrameLoaderClient::setDefersLoading):
(WebFrameLoaderClient::setTitle):
(WebFrameLoaderClient::deliverArchivedResourcesAfterDelay):
(WebFrameLoaderClient::deliverArchivedResources):
(WebFrameLoaderClient::setUpPolicyListener):
(WebFrameLoaderClient::receivedPolicyDecison):
(WebFrameLoaderClient::userAgent):
(-[WebFramePolicyListener initWithWebCoreFrame:]):
(-[WebFramePolicyListener invalidate]):
(-[WebFramePolicyListener dealloc]):
(-[WebFramePolicyListener finalize]):
(-[WebFramePolicyListener receivedPolicyDecision:]):
(-[WebFramePolicyListener ignore]):
(-[WebFramePolicyListener download]):
(-[WebFramePolicyListener use]):
(-[WebFramePolicyListener continue]):
* WebCoreSupport/WebPageBridge.mm:
(-[WebPageBridge runModal]):
* WebView/WebArchiver.m:
(+[WebArchiver archiveSelectionInFrame:]):
* WebView/WebFormDelegate.h:
* WebView/WebFormDelegate.m:
(+[WebFormDelegate _sharedWebFormDelegate]):
(-[WebFormDelegate textFieldDidBeginEditing:inFrame:]):
(-[WebFormDelegate textFieldDidEndEditing:inFrame:]):
(-[WebFormDelegate textDidChangeInTextField:inFrame:]):
(-[WebFormDelegate textDidChangeInTextArea:inFrame:]):
(-[WebFormDelegate frame:sourceFrame:willSubmitForm:withValues:submissionListener:]):
* WebView/WebFrame.mm:
(-[WebFrame _loadURL:referrer:intoChild:]):
(-[WebFrame _isFrameSet]):
* WebView/WebFrameInternal.h:
* WebView/WebFrameView.mm:
(-[WebFrameView _shouldDrawBorder]):
* WebView/WebHTMLView.m:
(-[NSArray knowsPageRange:]):
* WebView/WebView.mm:
(-[WebView _formDelegate]):
* WebView/WebViewInternal.h:
* WebView/WebViewPrivate.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17405
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Sat, 28 Oct 2006 23:44:46 +0000 (23:44 +0000)]
Adding forgotten Bugzilla reference.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17404
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Sat, 28 Oct 2006 23:41:53 +0000 (23:41 +0000)]
Fixing ChangeLog entries: r17933 => r17399.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17403
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Sat, 28 Oct 2006 23:39:47 +0000 (23:39 +0000)]
WebCore:
Reviewed by Maciej.
Fix layout tests that broke after r17933. Mitz discovered that the
failures were caused by HitTestResult::m_point being uninitialized
much of the time. HitTestResults are now always constructed with a
point, and RenderLayer::hitTest and RenderLayer::hitTestLayer use that
point instead of being passed one explicitly.
* WebCore.exp: Change constructor symbol.
* bridge/mac/FrameMac.mm:
(WebCore::FrameMac::eventMayStartDrag): Update to new constructor and
hitTest().
(WebCore::FrameMac::handleMouseMoveEvent): Ditto.
* bridge/mac/WebCoreAXObject.mm:
(-[WebCoreAXObject doAXTextMarkerForPosition:]): Ditto.
(-[WebCoreAXObject accessibilityHitTest:]): Ditto.
* dom/Document.cpp:
(WebCore::Document::elementFromPoint): Ditto.
(WebCore::Document::prepareMouseEvent): Ditto.
* page/Frame.cpp:
(WebCore::Frame::isPointInsideSelection): Ditto.
(WebCore::Frame::hitTestResultAtPoint): Ditto.
* page/FrameView.cpp:
(WebCore::FrameView::handleWheelEvent): Ditto.
* rendering/HitTestResult.cpp:
(WebCore::HitTestResult::HitTestResult): Initalize m_point with the
passed point.
* rendering/HitTestResult.h: Update constructor declaration.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::autoscroll): Update to new constructor and
hitTest().
(WebCore::RenderLayer::hitTest): Use the IntPoint stored in the
HitTestResult instead of being passed one.
(WebCore::RenderLayer::hitTestLayer): Ditto.
* rendering/RenderLayer.h: Update declarations.
WebKit:
Reviewed by Maciej.
Fix layout tests that broke after r17933. Mitz discovered that the
failures were caused by HitTestResult::m_point being uninitialized
much of the time. HitTestResults are now always constructed with a
point.
* WebView/WebHTMLView.m:
(-[WebHTMLView elementAtPoint:allowShadowContent:]): Pass point to
HitTestResult constructor.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17402
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Sat, 28 Oct 2006 21:33:35 +0000 (21:33 +0000)]
Reviewed by Anders.
Fix Qt/Linux build.
* CMakeLists.txt:
* platform/qt/FrameQtClient.cpp:
(WebCore::numRequests):
(WebCore::FrameQtClientDefault::numPendingOrLoadingRequests):
* platform/qt/PopupMenuQt.cpp:
(WebCore::PopupMenu::updateFromElement):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17401
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Sat, 28 Oct 2006 18:56:06 +0000 (18:56 +0000)]
Tweaked by Sam. Reviewed by Brady.
Fix for: http://bugs.webkit.org/show_bug.cgi?id=11437
Initialize m_modifyBiasSet to false, as it sometimes gets
used before it has been initalized.
* editing/SelectionController.cpp:
(WebCore::SelectionController::SelectionController):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17400
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin [Sat, 28 Oct 2006 18:28:00 +0000 (18:28 +0000)]
WebCore:
Reviewed by Darin.
This is the WebCore half of pushing elementAtPoint and the backend
of WebElementDictionary into WebCore. Most of the changes below are
to accommodate one of the following:
-NodeInfo is now a stand-alone class called HitTestResult.
Previously it was defined in RenderObject.h, but not for
any particular reason. The WebElementDictionary
functionality that was pushed into WebCore has been pushed
specifically into the this class. In fact,
WebElementDictionary now keeps a HitTestResult as a member
varibale.
-The enumeration AccessPolicy is now called
ClipboardAccessPolicy and is defined in its own header. It
was previously defined in ClipboardMac.h, but is now
defined independently to avoid including ClipboardMac.h
from within FrameMac.h since FrameMac.h is now included in
WebElementDictionary.m in WebKit.
-Element now has a virtual target() for the sake of
NodeInfo::targetFrame()
* WebCore.exp: Several WebCore functions are newly called from
WebKit, so they have been added here.
* WebCore.xcodeproj/project.pbxproj:
* bindings/objc/DOM.mm: Must include Image.h because of adjustments
to ClipboardMac.
* bridge/mac/FrameMac.h: Adjust to HitTestResult changes.
* bridge/mac/FrameMac.mm:
(WebCore::FrameMac::freeClipboard): Adjust to ClipboardAccessPolicy
and HitTestResult changes.
(WebCore::FrameMac::eventMayStartDrag): Same.
(WebCore::FrameMac::handleMouseMoveEvent): Same.
(WebCore::FrameMac::dispatchCPPEvent): Same.
(WebCore::FrameMac::mayDHTMLCut): Same.
(WebCore::FrameMac::mayDHTMLCopy): Same.
(WebCore::FrameMac::mayDHTMLPaste): Same.
(WebCore::FrameMac::tryDHTMLCut): Same
(WebCore::FrameMac::tryDHTMLCopy): Same.
(WebCore::FrameMac::tryDHTMLPaste): Same.
* bridge/mac/WebCoreAXObject.mm:
(-[WebCoreAXObject doAXTextMarkerForPosition:]): Adjust to
HitTestResult changes.
(-[WebCoreAXObject accessibilityHitTest:]): Same.
* bridge/mac/WebCoreFrameBridge.h: Same.
* bridge/mac/WebCoreFrameBridge.mm:
(-[WebCoreFrameBridge dragOperationForDraggingInfo:]): Adjust for
ClipboardAccessPolicy changes.
(-[WebCoreFrameBridge dragExitedWithDraggingInfo:]): Same.
(-[WebCoreFrameBridge concludeDragForDraggingInfo:]): Same.
* dom/Document.cpp:
(WebCore::Document::elementFromPoint): Adjust for HitTestResult
changes.
(WebCore::Document::prepareMouseEvent): Same.
* dom/Element.h:
(WebCore::Element::target): Now has a virtual target()
* html/HTMLAnchorElement.h: Same.
* html/HTMLAreaElement.cpp:
(WebCore::HTMLAreaElement::mapMouseEvent): Adjust for HitTestResult
changes.
* html/HTMLAreaElement.h: Virtual target()
* html/HTMLBaseElement.h:
(WebCore::HTMLBaseElement::target): Same.
* html/HTMLFormElement.h: Same.
* html/HTMLLinkElement.h: Same.
* html/HTMLMapElement.cpp:
(WebCore::HTMLMapElement::mapMouseEvent): Adjust for HitTestResult
changes.
* html/HTMLMapElement.h: Same.
* page/Frame.cpp:
(WebCore::Frame::isPointInsideSelection): Same.
(WebCore::Frame::hitTestResultAtPoint): Same.
* page/Frame.h: Same.
* page/FrameView.cpp:
(WebCore::FrameView::handleWheelEvent): Same.
* platform/mac/ClipboardAccessPolicy.h: Added.
(WebCore::):
* platform/mac/ClipboardMac.h: Remove definition of AccessPolicy,
include ClipboardAccessPolicy.h, and rename AccessPolicy to
ClipboardAccessPolicy.
* platform/mac/ClipboardMac.mm: Rename ClipboardAccessPolicy.
(WebCore::ClipboardMac::ClipboardMac):
(WebCore::ClipboardMac::setAccessPolicy):
(WebCore::ClipboardMac::clearData):
(WebCore::ClipboardMac::clearAllData):
(WebCore::ClipboardMac::getData):
(WebCore::ClipboardMac::setData):
(WebCore::ClipboardMac::types):
(WebCore::ClipboardMac::setDragImage):
(WebCore::ClipboardMac::setDropEffect):
(WebCore::ClipboardMac::setEffectAllowed):
* rendering/EllipsisBox.cpp:
(WebCore::EllipsisBox::nodeAtPoint): Adjust for HitTestResult
changes.
* rendering/EllipsisBox.h:
* rendering/HitTestResult.cpp: Added.
(WebCore::HitTestResult::HitTestResult):
(WebCore::HitTestResult::~HitTestResult):
(WebCore::HitTestResult::operator=):
(WebCore::HitTestResult::setInnerNode):
(WebCore::HitTestResult::setInnerNonSharedNode):
(WebCore::HitTestResult::setURLElement):
(WebCore::HitTestResult::setScrollbar):
(WebCore::HitTestResult::targetFrame):
(WebCore::HitTestResult::boundingBox):
(WebCore::HitTestResult::isSelected):
(WebCore::HitTestResult::title):
* rendering/HitTestResult.h: Added.
(WebCore::HitTestResult::readonly):
(WebCore::HitTestResult::active):
(WebCore::HitTestResult::mouseMove):
(WebCore::HitTestResult::innerNode):
(WebCore::HitTestResult::innerNonSharedNode):
(WebCore::HitTestResult::point):
(WebCore::HitTestResult::URLElement):
(WebCore::HitTestResult::scrollbar):
(WebCore::HitTestResult::setPoint):
(WebCore::HitTestResult::setReadonly):
(WebCore::HitTestResult::setActive):
(WebCore::HitTestResult::setMouseMove):
* rendering/InlineBox.cpp:
(WebCore::InlineBox::nodeAtPoint): Adjust to HitTestResult changes.
* rendering/InlineBox.h: Same.
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::nodeAtPoint): Same.
* rendering/InlineFlowBox.h: Same.
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::nodeAtPoint): Same.
* rendering/InlineTextBox.h: Same.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::isPointInScrollbar): Same.
(WebCore::RenderBlock::nodeAtPoint): Same.
* rendering/RenderBlock.h: Same.
* rendering/RenderBox.cpp:
(WebCore::RenderBox::nodeAtPoint): Same.
* rendering/RenderBox.h: Same.
* rendering/RenderFlow.cpp:
(WebCore::RenderFlow::hitTestLines): Same.
* rendering/RenderFlow.h: Same.
* rendering/RenderForeignObject.cpp:
(WebCore::RenderForeignObject::nodeAtPoint): Same.
* rendering/RenderForeignObject.h: Same.
* rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::nodeAtPoint): Same.
* rendering/RenderFrameSet.h: Same.
* rendering/RenderImage.cpp:
(WebCore::RenderImage::nodeAtPoint): Same.
* rendering/RenderImage.h: Same.
* rendering/RenderInline.cpp:
(WebCore::RenderInline::nodeAtPoint): Same.
* rendering/RenderInline.h: Same.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::autoscroll): Same.
(WebCore::RenderLayer::hitTest): Same.
(WebCore::RenderLayer::hitTestLayer): Same.
(WebCore::RenderLayer::updateHoverActiveState): Same.
* rendering/RenderLayer.h: Same.
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::isPointInScrollbar): Same.
* rendering/RenderListBox.h: Same.
* rendering/RenderObject.cpp:
(WebCore::RenderObject::hitTest): Same.
(WebCore::RenderObject::setInnerNode): Same.
(WebCore::RenderObject::nodeAtPoint): Same.
* rendering/RenderObject.h: Remove NodeInfo class and forward
declare HitTestResult.
* rendering/RenderPath.cpp:
(WebCore::RenderPath::nodeAtPoint): Adjust to HitTestResult
changes.
* rendering/RenderPath.h: Same.
* rendering/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::nodeAtPoint): Same.
* rendering/RenderSVGImage.h: Same
* rendering/RenderSVGText.cpp:
(WebCore::RenderSVGText::nodeAtPoint): Same.
* rendering/RenderSVGText.h: Same.
* rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::nodeAtPoint): Same.
* rendering/RenderTableRow.h: Same.
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::nodeAtPoint): Same.
* rendering/RenderTableSection.h: Same.
* rendering/RenderText.h: Same.
(WebCore::RenderText::nodeAtPoint): Same.
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::nodeAtPoint): Same.
* rendering/RenderTextControl.h: Same.
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::nodeAtPoint): Same.
* rendering/RootInlineBox.h: Same.
WebKit:
Reviewed by Darin.
This is the WebKit half of pushing the guts of elementAtPoint and
WebElementDictionary into WebCore. Among other things, this patch
makes WebElementDictionary.m and WebHTMLView.m Objective-C++
* MigrateHeaders.make: Add DOMElementInternal.h to the list of
headers to migrate.
* Misc/WebElementDictionary.h: Replaced DOMNode, DOMElement, and
NSPoint member variables with a HitTestResult member variable.
* Misc/WebElementDictionary.m:
(addLookupKey): Formatting.
(-[WebElementDictionary initWithHitTestResult:]): Constructor just
takes a HitTestResult now and sets the member variable.
(-[WebElementDictionary dealloc]): delete HitTestResult.
(-[WebElementDictionary finalize]): Address HitTestResult.
(-[WebElementDictionary _domNode]): Use HitTestResult and call into
WebCore.
(-[WebElementDictionary objectForKey:]): Same.
(-[WebElementDictionary _webFrame]): Same.
(-[WebElementDictionary _targetWebFrame]): Same.
(-[WebElementDictionary _title]): Same.
(-[WebElementDictionary _imageRect]): Same.
(-[WebElementDictionary _isSelected]): Same.
* WebKit.xcodeproj/project.pbxproj:
* WebView/WebFrame.mm:
(core): Convert from DOMNode* to Node*
(kit): Convert from Node* to DOMNode*
* WebView/WebFrameInternal.h: Support for the above.
* WebView/WebHTMLView.m:
(-[WebHTMLView elementAtPoint:allowShadowContent:]): Call directly
into Frame.cpp to get HitTestResult.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17399
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Sat, 28 Oct 2006 08:19:24 +0000 (08:19 +0000)]
WebCore:
Removed accidentally committed duplicate ChangeLog entries.
WebKit:
Removed accidentally committed duplicate ChangeLog entries.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17398
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Sat, 28 Oct 2006 06:18:19 +0000 (06:18 +0000)]
Reviewed by Anders.
- reverted fix for http://bugs.webkit.org/show_bug.cgi?id=11212, later we will address the performance
impact of fixing it again.
* bridge/mac/FrameMac.mm:
(WebCore::FrameMac::clear):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17397
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Sat, 28 Oct 2006 05:08:17 +0000 (05:08 +0000)]
WebCore:
Reviewed by John & Adam.
- assorted speedups to fix perf regression from fixing correctness regression
* WebCore.exp: exported new methods.
* WebCore.xcodeproj/project.pbxproj: Added CachedResourceMac.mm
* bridge/mac/WebCoreFrameBridge.h:
* bridge/mac/WebCoreFrameBridge.mm:
* loader/CachedResource.cpp: Removed now obsolete getCFURL.
* loader/CachedResource.h:
* loader/mac/CachedResourceMac.mm: Added.
(WebCore::CachedResource::getNSURLRequest): New method; the NSURLRequest is
now cached in the CachedObject.
* loader/mac/FrameLoader.h:
* loader/mac/FrameLoader.mm:
(WebCore::FrameLoader::loadedResourceFromMemoryCache): New method - lets
the WebKit side do faster dispatch for clients that implement the fast path delegate.
* loader/mac/LoaderFunctionsMac.mm:
(WebCore::CheckCacheObjectStatus): Instead of calling several FrameLoader methods,
just call loadedResourceFromMemoryCache.
* loader/mac/WebFrameLoaderClient.h:
WebKit:
Reviewed by John & Adam.
- various performance improvements for resource delegate dispatch.
- avoid any ObjC messaging when fetching the WebView
- avoid ObjC calls to WebView to get resource load delegate and impl cache
- cache actual method pointers, not just the fact that the method is present
- added a new SPI resource load delegate method which allows clients to get
just one message in case of synchronously loading from memory cache; if this
is implemented you don't get the normal delegate calls in that case.
- various other minor tweaks
* WebCoreSupport/WebFrameBridge.h:
* WebCoreSupport/WebFrameLoaderClient.h:
* WebCoreSupport/WebFrameLoaderClient.mm:
(getWebView):
(WebFrameLoaderClient::hasBackForwardList):
(WebFrameLoaderClient::resetBackForwardList):
(WebFrameLoaderClient::privateBrowsingEnabled):
(WebFrameLoaderClient::updateHistoryForStandardLoad):
(WebFrameLoaderClient::resetAfterLoadError):
(WebFrameLoaderClient::download):
(WebFrameLoaderClient::dispatchDidLoadResourceFromMemoryCache):
(WebFrameLoaderClient::dispatchIdentifierForInitialRequest):
(WebFrameLoaderClient::dispatchWillSendRequest):
(WebFrameLoaderClient::dispatchDidReceiveAuthenticationChallenge):
(WebFrameLoaderClient::dispatchDidCancelAuthenticationChallenge):
(WebFrameLoaderClient::dispatchDidReceiveResponse):
(WebFrameLoaderClient::dispatchDidReceiveContentLength):
(WebFrameLoaderClient::dispatchDidFinishLoading):
(WebFrameLoaderClient::dispatchDidFailLoading):
(WebFrameLoaderClient::dispatchDidHandleOnloadEvents):
(WebFrameLoaderClient::dispatchDidReceiveServerRedirectForProvisionalLoad):
(WebFrameLoaderClient::dispatchDidCancelClientRedirect):
(WebFrameLoaderClient::dispatchWillPerformClientRedirect):
(WebFrameLoaderClient::dispatchDidChangeLocationWithinPage):
(WebFrameLoaderClient::dispatchWillClose):
(WebFrameLoaderClient::dispatchDidReceiveIcon):
(WebFrameLoaderClient::dispatchDidStartProvisionalLoad):
(WebFrameLoaderClient::dispatchDidReceiveTitle):
(WebFrameLoaderClient::dispatchDidCommitLoad):
(WebFrameLoaderClient::dispatchDidFailProvisionalLoad):
(WebFrameLoaderClient::dispatchDidFailLoad):
(WebFrameLoaderClient::dispatchDidFinishLoad):
(WebFrameLoaderClient::dispatchDidFirstLayout):
(WebFrameLoaderClient::dispatchCreatePage):
(WebFrameLoaderClient::dispatchShow):
(WebFrameLoaderClient::dispatchDecidePolicyForMIMEType):
(WebFrameLoaderClient::dispatchDecidePolicyForNewWindowAction):
(WebFrameLoaderClient::dispatchDecidePolicyForNavigationAction):
(WebFrameLoaderClient::dispatchUnableToImplementPolicy):
(WebFrameLoaderClient::dispatchWillSubmitForm):
(WebFrameLoaderClient::dispatchDidLoadMainResource):
(WebFrameLoaderClient::progressStarted):
(WebFrameLoaderClient::progressCompleted):
(WebFrameLoaderClient::incrementProgress):
(WebFrameLoaderClient::completeProgress):
(WebFrameLoaderClient::setMainFrameDocumentReady):
(WebFrameLoaderClient::startDownload):
(WebFrameLoaderClient::willChangeTitle):
(WebFrameLoaderClient::didChangeTitle):
(WebFrameLoaderClient::mainFrameURL):
(WebFrameLoaderClient::frameLoadCompleted):
* WebCoreSupport/WebPageBridge.h:
* WebKit.xcodeproj/project.pbxproj:
* WebView/WebFrame.mm:
(frame):
(core):
(kit):
(getWebView):
(-[WebFrame _addBackForwardItemClippedAtTarget:]):
(-[WebFrame _canCachePage]):
(-[WebFrame _purgePageCache]):
(-[WebFrame _loadItem:withLoadType:]):
(-[WebFrame _goToItem:withLoadType:]):
(-[WebFrame _updateBackground]):
(-[WebFrame _clearSelectionInOtherFrames]):
(-[WebFrame _isMainFrame]):
(-[WebFrame webView]):
* WebView/WebResourceLoadDelegatePrivate.h: Added.
* WebView/WebView.mm:
(-[WebView _cacheResourceLoadDelegateImplementations]):
(WebViewGetResourceLoadDelegate):
(WebViewGetResourceLoadDelegateImplementations):
* WebView/WebViewInternal.h:
* WebView/WebViewPrivate.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17396
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver [Sat, 28 Oct 2006 04:14:58 +0000 (04:14 +0000)]
2006-10-27 Oliver Hunt <oliver@apple.com>
Reviewed by Maciej.
build fix
* dom/Document.cpp:
(WebCore::Document::referrer):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17395
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson [Sat, 28 Oct 2006 02:08:38 +0000 (02:08 +0000)]
top level:
Rubber stamped by Tim Hatcher
Added "make universal" to build universal binaries
* Makefile:
* Makefile.shared:
WebKitTools:
Rubber stamped by Tim Hatcher
Added "make universal" to build universal binaries
* Makefile:
* Makefile.shared:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17394
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Sat, 28 Oct 2006 01:22:13 +0000 (01:22 +0000)]
WebCore:
Reviewed by Maciej.
Moved some WebCoreFrameBridge functions into FrameLoader.
I had to make FrameLoader.h capable of compiling in C++-only source files
by adding some forward declarations and __OBJC__ #ifdefs.
* WebCore.exp:
* bridge/mac/FrameMac.h:
* bridge/mac/FrameMac.mm:
(WebCore::FrameMac::createEmptyDocument):
(WebCore::FrameMac::tokenizerProcessedData):
* bridge/mac/WebCoreFrameBridge.h:
* bridge/mac/WebCoreFrameBridge.mm:
* dom/Document.cpp:
(WebCore::Document::processHttpEquiv):
(WebCore::Document::referrer):
* loader/LoaderFunctions.h:
* loader/mac/FrameLoader.h:
* loader/mac/FrameLoader.mm:
(WebCore::numRequests):
(WebCore::FrameLoader::numPendingOrLoadingRequests):
(WebCore::FrameLoader::isReloading):
(WebCore::FrameLoader::referrer):
(WebCore::FrameLoader::loadEmptyDocumentSynchronously):
(WebCore::FrameLoader::startLoadingResource):
* loader/mac/LoaderFunctionsMac.mm:
(WebCore::CheckIfReloading):
* page/Frame.h:
* page/FrameTree.cpp:
(WebCore::FrameTree::isDescendantOf):
(WebCore::FrameTree::traverseNext):
* page/FrameTree.h:
* platform/network/mac/ResourceLoaderMac.mm:
(WebCore::ResourceLoader::start):
WebKit:
Reviewed by Maciej.
Moved some WebCoreFrameBridge functions into FrameLoader.
* WebView/WebFrame.mm:
(-[WebFrame _numPendingOrLoadingRequests:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17393
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Sat, 28 Oct 2006 00:41:35 +0000 (00:41 +0000)]
Reviewed by Darin.
<rdar://problem/
4478625> HTML Editing: Basic table editing and culling
Expanded the Deletion UI to lists, positioned block element and block elementss with borders.
* editing/DeleteButtonController.cpp:
(WebCore::isDeletableElement):
(WebCore::enclosingDeletableElement):
(WebCore::DeleteButtonController::respondToChangedSelection):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17392
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan [Fri, 27 Oct 2006 23:43:26 +0000 (23:43 +0000)]
Reviewed by Kevin Decker
Some more grammar-checking plumbing. No additional grammar jokes will have been made by the time
you haven't not finished reading this.
* rendering/InlineTextBox.h:
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paint):
Updated for changed signature of paintDocumentMarkers, which causes grammar markers to be
considered also.
(WebCore::InlineTextBox::paintDocumentMarkers):
Renamed from paintAllMarkersOfType; now takes a bool for whether background or foreground
markers should be painted, instead of a marker type. This avoids walking the collection of
markers multiple times back to back. Now handles grammar markers.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17391
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Fri, 27 Oct 2006 22:31:05 +0000 (22:31 +0000)]
WebCore:
Reviewed by Beth.
Renamed Copy Files to Copy Generated Headers.
Copy 4 DOM*Internal.h headers.
* WebCore.xcodeproj/project.pbxproj:
* bindings/scripts/CodeGeneratorObjC.pm:
WebKit:
Reviewed by Beth.
Make a DerivedSource/Webkit directory to store migrated
internal headers from WebCore.
* MigrateHeaders.make:
* WebKit.xcodeproj/project.pbxproj:
* WebView/WebFrame.mm: import the new migrated DOM*Internal.h headers
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17390
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Fri, 27 Oct 2006 22:07:30 +0000 (22:07 +0000)]
Fixed the revision number in my ChangeLog entry.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17389
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan [Fri, 27 Oct 2006 21:28:28 +0000 (21:28 +0000)]
Reviewed by Anders
- fixed http://bugs.webkit.org/show_bug.cgi?id=11439
REGRESSION: Another page loading crash
* WebView/WebFrame.mm:
(-[WebFrame _createItem:]):
Handle nil documentLoader the way we did before ObjC->C++ changes
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17388
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan [Fri, 27 Oct 2006 20:50:02 +0000 (20:50 +0000)]
WebCore:
Reviewed by Anders
* WebCore.exp:
exported symbol for FrameMac->advanceToNextSpelling()
* bridge/mac/WebCoreFrameBridge.h:
* bridge/mac/WebCoreFrameBridge.mm:
removed advanceToNextMisspelling callers. Clients in WebKit must now call FrameMac directly.
WebKit:
Reviewed by Anders
* WebView/WebHTMLView.m:
(-[NSArray checkSpelling:]):
call advanceToNextMisspelling directly on FrameMac, bypassing bridge
(-[NSArray showGuessPanel:]):
ditto
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17387
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Fri, 27 Oct 2006 20:42:17 +0000 (20:42 +0000)]
LayoutTests:
Reviewed by harrison
<http://bugs.webkit.org/show_bug.cgi?id=11423>
REGRESSION: First newline missing from textarea's value
Changes reflect the removal of more brs that were about
to collapse:
* editing/deleting/delete-
4038408-fix-expected.txt:
* editing/inserting/insert-
3654864-fix-expected.txt:
* editing/inserting/insert-
3659587-fix-expected.txt:
* editing/inserting/insert-
3775316-fix-expected.txt:
* editing/inserting/insert-at-end-01-expected.txt:
* editing/inserting/insert-at-end-02-expected.txt:
* editing/inserting/insert-br-001-expected.txt:
* editing/inserting/insert-br-005-expected.txt:
Added to demonstrate fix:
* fast/forms/11423-expected.txt: Added.
* fast/forms/11423.html: Added.
WebCore:
Reviewed by harrison
<http://bugs.webkit.org/show_bug.cgi?id=11423>
REGRESSION: First newline missing from textarea's value
The regression is that foo, return, bar in a textarea serializes as 'foobar'.
Before my change in r11423, return (an InsertLineBreak) would insert a '\n'
(the line break) then a br to prevent the '\n' from collapsing, since the
insertion is being done at the end of a block (the textarea's shadow div). Then,
inserting "bar" would displace the br, and "foo\nbar" would serialize as "foo\nbar".
After my change in r11423, InsertLineBreak would insert a br then a '\n' (reversed
the order). Then inserting "bar" would displace the '\n' and "foo"<br>"bar" would
serialize as "foobar" because when serializing RenderTextControl intentionally asks
textContent to not convert brs to newlines. It seems to think that the only brs in
the shadow div will be placeholders or collapsed.
We could remove this assumption, but, for consistancy's sake, I changed InsertLineBreak
to insert two '\n's when at the end of a block in white-space:pre text. This alone
would have fixed the bug, but introduced a new one, because foo, return, bar would
produce "foo\nbar\n" which would serialize as "foo\nbar\n" (even though the second
'\n' is collapsed, because of 9661). So, then I changed placeholder displacement to
displace a '\n' if it's acting as a placeholder. A "placeholder" is now defined as
a br or '\n' that will collapse (become superfluous) when content is inserted just
before it.
* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::removePlaceholderAt): Renamed. Remove
a br or '\n' if content inserted just before it will cause it to collapse.
* editing/CompositeEditCommand.h:
* editing/InsertLineBreakCommand.cpp:
(WebCore::InsertLineBreakCommand::doApply): Insert the same type of node
to prevent a collapse as was used for the line break. Fixed comments.
* editing/InsertTextCommand.cpp:
(WebCore::InsertTextCommand::input): Call the renamed function.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17386
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Fri, 27 Oct 2006 18:47:52 +0000 (18:47 +0000)]
Build fix.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17379
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Fri, 27 Oct 2006 18:29:57 +0000 (18:29 +0000)]
Reviewed by Brady.
Fixed semantic inaccuracy in String::operator NSString *(), where a NULL
String became an empty NSString *, instead of nil. This will become important
as we start using this conversion more.
Added work-around for AppKit crash that semantic accuracy revealed.
No testcase because I don't think there's a way to reflect this change
in a webpage yet.
* platform/PlatformString.h:
(WebCore::String::operator NSString*):
* platform/mac/TextFieldMac.mm:
(-[NSSearchFieldCell _addStringToRecentSearches:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17378
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Fri, 27 Oct 2006 17:50:27 +0000 (17:50 +0000)]
Reviewed by Steve.
* kjs/grammar.y: Add definitions of YYMALLOC and YYFREE to fix
a warning some people see (not sure why others don't see it).
* JavaScriptCore.vcproj/JavaScriptCore/grammarWrapper.cpp: Touch
this file to force it to re-build grammar.cpp.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17377
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Fri, 27 Oct 2006 16:49:56 +0000 (16:49 +0000)]
Oops, forgot to save one file.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17374
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
git://git.webkit.org / WebKit-https.git / log