sfalken@apple.com [Thu, 18 Nov 2010 20:42:44 +0000 (20:42 +0000)]
WebCore: [chromium] REGRESSION(72141): Chromium fails acid3 on windows and linux
https://bugs.webkit.org/show_bug.cgi?id=49638
Patch by James Robinson <jamesr@chromium.org> on 2010-11-18
Reviewed by Darin Fisher.
Avoid clamping zero text size to 12pt in FontPlatformData::setupPaint() in FontPlatformDataLinux.cpp
Set all metrics to 0 if the font size is specified as zero in SimpleFontDataChromiumWin.cpp, just
like Safari Win did in r72270.
Test: fast/text/font-size-zero.html
* platform/graphics/chromium/FontPlatformDataLinux.cpp:
(WebCore::FontPlatformData::setupPaint):
* platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
(WebCore::SimpleFontData::platformInit):
WebKit/win: Debug_Internal Windows configuration is unnecessary, should be removed
https://bugs.webkit.org/show_bug.cgi?id=49753
Reviewed by Adam Roben.
* WebKitPrefix.h:
WebKit2: Keep the web process alive if there are active downloads
https://bugs.webkit.org/show_bug.cgi?id=49755
Patch by Anders Carlsson <andersca@apple.com> on 2010-11-18
Reviewed by Sam Weinig.
Make sure that Download objects are destroyed when the download finishes or fails.
Don't close the web process if there are live Download objects.
* UIProcess/Downloads/DownloadProxy.cpp:
(WebKit::DownloadProxy::didFail):
Add stub.
* UIProcess/Downloads/DownloadProxy.h:
* UIProcess/Downloads/DownloadProxy.messages.in:
Add DidFail message.
* WebProcess/Downloads/Download.cpp:
(WebKit::Download::didFinish):
Call DownloadManager::downloadFinished.
(WebKit::Download::didFail):
Send DidFail message and call DownloadManager::downloadFinished.
* WebProcess/Downloads/Download.h:
(WebKit::Download::destinationID):
Call downloadID().
(WebKit::Download::downloadID):
Return the download ID.
* WebProcess/Downloads/DownloadManager.cpp:
(WebKit::DownloadManager::downloadFinished):
Delete the Download object and call WebProcess::shutdownIfPossible.
* WebProcess/Downloads/DownloadManager.h:
(WebKit::DownloadManager::isDownloading):
Return whether the download manager has any active downloads.
* WebProcess/Downloads/mac/DownloadMac.mm:
(-[WKDownloadAsDelegate download:didFailWithError:]):
Call Download::didFail.
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::removeWebPage):
Call shutdownIfPossible.
(WebKit::WebProcess::shutdownIfPossible):
New function. Don't shutdown if there are live pages or active downloads.
* WebProcess/WebProcess.h:
WebKitLibraries: Debug_Internal Windows configuration is unnecessary, should be removed
https://bugs.webkit.org/show_bug.cgi?id=49753
Reviewed by Adam Roben.
* win/tools/vsprops/debug.vsprops:
* win/tools/vsprops/debug_internal.vsprops:
WebKitTools: update-webkit-support-libs should fall back to existing
WebKitSupportLibrary version if there is no internet connectivity
https://bugs.webkit.org/show_bug.cgi?id=49503
Patch by Daniel Bates <dbates@rim.com> on 2010-11-18
Reviewed by Adam Roben.
Fall back to existing support libraries (if present) when there is
no internet connection.
Currently, update-webkit-support-libs dies with an "out-of-date"
error when there is no internet connection because it cannot
retrieve versioning information from developer.apple.com. Because
update-webkit-support-libs fails, build-webkit fails. Instead,
if there is no internet connection and the support libraries are
present then we should warn the user and exit() with success so
that build-webkit can work without an internet connection.
* Scripts/update-webkit-support-libs:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72327
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dbates@webkit.org [Thu, 18 Nov 2010 20:29:19 +0000 (20:29 +0000)]
2010-11-18 Daniel Bates <dbates@rim.com>
Reviewed by Adam Roben.
update-webkit-support-libs should fall back to existing
WebKitSupportLibrary version if there is no internet connectivity
https://bugs.webkit.org/show_bug.cgi?id=49503
Fall back to existing support libraries (if present) when there is
no internet connection.
Currently, update-webkit-support-libs dies with an "out-of-date"
error when there is no internet connection because it cannot
retrieve versioning information from developer.apple.com. Because
update-webkit-support-libs fails, build-webkit fails. Instead,
if there is no internet connection and the support libraries are
present then we should warn the user and exit() with success so
that build-webkit can work without an internet connection.
* Scripts/update-webkit-support-libs:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72326
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 18 Nov 2010 20:26:11 +0000 (20:26 +0000)]
Add Windows results for test added in r71980
* platform/win/fast/repaint/repaint-across-writing-mode-boundary-expected.checksum: Added.
* platform/win/fast/repaint/repaint-across-writing-mode-boundary-expected.png: Added.
* platform/win/fast/repaint/repaint-across-writing-mode-boundary-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72325
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Thu, 18 Nov 2010 20:10:27 +0000 (20:10 +0000)]
2010-11-18 James Robinson <jamesr@chromium.org>
Reviewed by Darin Fisher.
[chromium] REGRESSION(72141): Chromium fails acid3 on windows and linux
https://bugs.webkit.org/show_bug.cgi?id=49638
Adds a test checking that the bounding client rect of a text run with font-size:0
has zero height. This is also covered by acid3, but an isolated test case is easier
to work with.
* fast/text/font-size-zero-expected.txt: Added.
* fast/text/font-size-zero.html: Added.
* fast/text/script-tests/font-size-zero.js: Added.
2010-11-18 James Robinson <jamesr@chromium.org>
Reviewed by Darin Fisher.
[chromium] REGRESSION(72141): Chromium fails acid3 on windows and linux
https://bugs.webkit.org/show_bug.cgi?id=49638
Avoid clamping zero text size to 12pt in FontPlatformData::setupPaint() in FontPlatformDataLinux.cpp
Set all metrics to 0 if the font size is specified as zero in SimpleFontDataChromiumWin.cpp, just
like Safari Win did in r72270.
Test: fast/text/font-size-zero.html
* platform/graphics/chromium/FontPlatformDataLinux.cpp:
(WebCore::FontPlatformData::setupPaint):
* platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
(WebCore::SimpleFontData::platformInit):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72324
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 18 Nov 2010 20:06:49 +0000 (20:06 +0000)]
Keep the web process alive if there are active downloads
https://bugs.webkit.org/show_bug.cgi?id=49755
Reviewed by Sam Weinig.
Make sure that Download objects are destroyed when the download finishes or fails.
Don't close the web process if there are live Download objects.
* UIProcess/Downloads/DownloadProxy.cpp:
(WebKit::DownloadProxy::didFail):
Add stub.
* UIProcess/Downloads/DownloadProxy.h:
* UIProcess/Downloads/DownloadProxy.messages.in:
Add DidFail message.
* WebProcess/Downloads/Download.cpp:
(WebKit::Download::didFinish):
Call DownloadManager::downloadFinished.
(WebKit::Download::didFail):
Send DidFail message and call DownloadManager::downloadFinished.
* WebProcess/Downloads/Download.h:
(WebKit::Download::destinationID):
Call downloadID().
(WebKit::Download::downloadID):
Return the download ID.
* WebProcess/Downloads/DownloadManager.cpp:
(WebKit::DownloadManager::downloadFinished):
Delete the Download object and call WebProcess::shutdownIfPossible.
* WebProcess/Downloads/DownloadManager.h:
(WebKit::DownloadManager::isDownloading):
Return whether the download manager has any active downloads.
* WebProcess/Downloads/mac/DownloadMac.mm:
(-[WKDownloadAsDelegate download:didFailWithError:]):
Call Download::didFail.
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::removeWebPage):
Call shutdownIfPossible.
(WebKit::WebProcess::shutdownIfPossible):
New function. Don't shutdown if there are live pages or active downloads.
* WebProcess/WebProcess.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72323
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 18 Nov 2010 20:02:47 +0000 (20:02 +0000)]
Update Windows results after r72050
* platform/win/fast/dom/Window/window-postmessage-clone-frames-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72322
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis@webkit.org [Thu, 18 Nov 2010 20:01:10 +0000 (20:01 +0000)]
2010-11-18 Rob Buis <rwlbuis@gmail.com>
Reviewed by Simon Fraser.
Only inject fullscreen.css when in fullscreen
https://bugs.webkit.org/show_bug.cgi?id=49510
Refactor to only add fullscreen sheet rules when document is in fullscreen mode.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::loadFullDefaultStyle):
(WebCore::loadFullScreenRulesIfNeeded):
(WebCore::CSSStyleSelector::styleForElement):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72321
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Thu, 18 Nov 2010 19:55:36 +0000 (19:55 +0000)]
2010-11-18 Mihai Parparita <mihaip@chromium.org>
Add missing mac pixel baselines (all baselines are for Snow Leopard).
* platform/mac/css1/text_properties/text_transform-expected.checksum: Added.
* platform/mac/css1/text_properties/text_transform-expected.png: Added.
* platform/mac/fast/canvas/toDataURL-alpha-expected.checksum: Added.
* platform/mac/fast/canvas/toDataURL-alpha-expected.png: Added.
* platform/mac/fast/repaint/canvas-putImageData-expected.checksum: Added.
* platform/mac/fast/repaint/canvas-putImageData-expected.png: Added.
* platform/mac/fast/table/early-table-layout-expected.checksum: Added.
* platform/mac/fast/table/early-table-layout-expected.png: Added.
* platform/mac/media/video-canvas-alpha-expected.checksum: Added.
* platform/mac/media/video-canvas-alpha-expected.png: Added.
* platform/mac/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.checksum: Added.
* platform/mac/platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.png: Added.
* platform/mac/svg/text/text-intro-05-t-expected.png: Added.
* platform/mac/transforms/3d/hit-testing/backface-hit-test-expected.checksum: Added.
* platform/mac/transforms/3d/hit-testing/backface-hit-test-expected.png: Added.
* platform/mac/transforms/3d/hit-testing/backface-no-transform-hit-test-expected.checksum: Added.
* platform/mac/transforms/3d/hit-testing/backface-no-transform-hit-test-expected.png: Added.
* platform/mac/transforms/3d/hit-testing/rotated-hit-test-expected.checksum: Added.
* platform/mac/transforms/3d/hit-testing/rotated-hit-test-expected.png: Added.
* platform/mac/transforms/3d/point-mapping/3d-point-mapping-2-expected.checksum: Added.
* platform/mac/transforms/3d/point-mapping/3d-point-mapping-2-expected.png: Added.
* platform/mac/transforms/3d/point-mapping/3d-point-mapping-3-expected.checksum: Added.
* platform/mac/transforms/3d/point-mapping/3d-point-mapping-3-expected.png: Added.
* platform/mac/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.checksum: Added.
* platform/mac/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.png: Added.
* platform/mac/transforms/3d/point-mapping/3d-point-mapping-deep-expected.checksum: Added.
* platform/mac/transforms/3d/point-mapping/3d-point-mapping-deep-expected.png: Added.
* platform/mac/transforms/3d/point-mapping/3d-point-mapping-expected.checksum: Added.
* platform/mac/transforms/3d/point-mapping/3d-point-mapping-expected.png: Added.
* platform/mac/transforms/3d/point-mapping/3d-point-mapping-origins-expected.checksum: Added.
* platform/mac/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png: Added.
* platform/mac/transforms/3d/point-mapping/3d-point-mapping-overlapping-expected.checksum: Added.
* platform/mac/transforms/3d/point-mapping/3d-point-mapping-overlapping-expected.png: Added.
* platform/mac/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.checksum: Added.
* platform/mac/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72320
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Thu, 18 Nov 2010 19:54:55 +0000 (19:54 +0000)]
2010-11-18 James Robinson <jamesr@chromium.org>
Reviewed by David Levin.
[chromium] Update chromium DEPS to r66658 to pick up skia roll
https://bugs.webkit.org/show_bug.cgi?id=49754
* DEPS:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72319
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 18 Nov 2010 19:47:12 +0000 (19:47 +0000)]
Land new Windows results for tests from r72235
* platform/win/fast/blockflow/vertical-align-table-baseline-expected.checksum: Added.
* platform/win/fast/blockflow/vertical-align-table-baseline-expected.png: Added.
* platform/win/fast/blockflow/vertical-align-table-baseline-expected.txt: Added.
* platform/win/fast/blockflow/vertical-baseline-alignment-expected.checksum: Added.
* platform/win/fast/blockflow/vertical-baseline-alignment-expected.png: Added.
* platform/win/fast/blockflow/vertical-baseline-alignment-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72318
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Thu, 18 Nov 2010 19:21:49 +0000 (19:21 +0000)]
[chromium] Removing various items from expectations to reflect the current state.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72317
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Thu, 18 Nov 2010 19:18:26 +0000 (19:18 +0000)]
Clean up vcproj errors
https://bugs.webkit.org/show_bug.cgi?id=49741
Reviewed by Adam Roben.
WebCore:
* WebCore.vcproj/WebCore.vcproj:
WebKit2:
* win/WebKit2WebProcess.vcproj:
WebKitTools:
* MiniBrowser/MiniBrowser.vcproj:
* WebKitAPITest/WebKitAPITest.vcproj:
* WebKitTestRunner/win/InjectedBundle.vcproj:
* WebKitTestRunner/win/WebKitTestRunner.vcproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72316
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Thu, 18 Nov 2010 19:12:45 +0000 (19:12 +0000)]
Reviewed by Anders Carlsson.
https://bugs.webkit.org/show_bug.cgi?id=49694
Add some comments about XSLStyleSheet owner node
No change in behavior, so no tests.
* dom/ProcessingInstruction.cpp:
(WebCore::ProcessingInstruction::checkStyleSheet):
* xml/XSLStyleSheet.h:
(WebCore::XSLStyleSheet::create):
(WebCore::XSLStyleSheet::createEmbedded):
(WebCore::XSLStyleSheet::createForXSLTProcessor):
* xml/XSLStyleSheetLibxslt.cpp:
(WebCore::XSLStyleSheet::XSLStyleSheet):
* xml/XSLTProcessorLibxslt.cpp:
(WebCore::xsltStylesheetPointer):
* xml/XSLTProcessorQt.cpp:
(WebCore::XSLTProcessor::transformToString):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72315
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hayato@chromium.org [Thu, 18 Nov 2010 19:06:33 +0000 (19:06 +0000)]
2010-11-18 Hayato Ito <hayato@chromium.org>
Reviewed by Shinichiro Hamaji.
[NRWT] Fix a break of '--new-baseline' feature in pixel_test
which is caused by r72249.
https://bugs.webkit.org/show_bug.cgi?id=49751
* Scripts/webkitpy/layout_tests/test_types/image_diff.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72314
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Thu, 18 Nov 2010 19:00:14 +0000 (19:00 +0000)]
2010-11-18 Tony Chang <tony@chromium.org>
Unreviewed, updating qt Skipped list.
* platform/qt/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72313
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Thu, 18 Nov 2010 18:51:00 +0000 (18:51 +0000)]
2010-11-18 Mihai Parparita <mihaip@chromium.org>
Unreviewed Mac expectations update.
r71700 and r72173 updated some Mac baselines recently, more tests now
pass when run with the DRT.
* platform/mac/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72312
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 18 Nov 2010 18:48:01 +0000 (18:48 +0000)]
Implement layoutTestController.waitForPolicyDelegate on Windows
Fixes <http://webkit.org/b/25038> <rdar://problem/
6790213>.
Reviewed by Simon Fraser.
LayoutTests:
Unskip tests that rely on layoutTestController.waitForPolicyDelegate on
Windows
* platform/win/Skipped:
WebKitTools:
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::waitForPolicyDelegate): Implemented by porting
code from LayoutTestControllerMac.mm.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72311
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antonm@chromium.org [Thu, 18 Nov 2010 18:43:40 +0000 (18:43 +0000)]
Not reviewed, rebaselining fast/parser/style-script-head-test.html
* platform/chromium-linux/fast/parser/style-script-head-test-expected.txt: Added.
* platform/chromium-win/fast/parser/style-script-head-test-expected.txt: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72310
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xan@webkit.org [Thu, 18 Nov 2010 18:33:13 +0000 (18:33 +0000)]
2010-11-18 Xan Lopez <xlopez@igalia.com>
Reviewed by Martin Robinson.
Fix introspection build, we were missing a -I flag.
* GNUmakefile.am:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72309
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Thu, 18 Nov 2010 18:31:17 +0000 (18:31 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=49743
[Qt] fast/xsl/import-non-document-node.xhtml fails
* platform/qt/Skipped: Disabling the new test for Qt.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72308
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hayato@chromium.org [Thu, 18 Nov 2010 18:29:02 +0000 (18:29 +0000)]
2010-11-18 Hayato Ito <hayato@chromium.org>
Reviewed by Shinichiro Hamaji.
[NRWT] Fix a break of '--new-baseline' feature which is caused by r72249.
https://bugs.webkit.org/show_bug.cgi?id=49740
* Scripts/webkitpy/layout_tests/test_types/text_diff.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72307
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jorlow@chromium.org [Thu, 18 Nov 2010 18:23:04 +0000 (18:23 +0000)]
2010-11-18 Jeremy Orlow <jorlow@chromium.org>
Reviewed by Darin Fisher.
[chromium] IndexedDB API cleanup
https://bugs.webkit.org/show_bug.cgi?id=49733
Make it so that you can't directly instantiate our "interface"
classes. Remove some code for 2 sided merges.
* public/WebIDBCursor.h:
(WebKit::WebIDBCursor::WebIDBCursor):
* public/WebIDBDatabase.h:
(WebKit::WebIDBDatabase::WebIDBDatabase):
* public/WebIDBIndex.h:
(WebKit::WebIDBIndex::WebIDBIndex):
* public/WebIDBObjectStore.h:
(WebKit::WebIDBObjectStore::WebIDBObjectStore):
* public/WebIDBTransaction.h:
(WebKit::WebIDBTransaction::WebIDBTransaction):
* src/IDBTransactionBackendProxy.cpp:
(WebCore::IDBTransactionBackendProxy::IDBTransactionBackendProxy):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72306
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
benjamin.poulain@nokia.com [Thu, 18 Nov 2010 18:09:02 +0000 (18:09 +0000)]
2010-11-18 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] [WK2] WebKit 2 would not compile for Qt without ENABLE_TOUCH_EVENT
https://bugs.webkit.org/show_bug.cgi?id=49664
Move the ENABLE(TOUCH_EVENTS) to the code where internal WebKit touch
types are used.
* UIProcess/API/qt/qgraphicswkview.cpp:
(QGraphicsWKView::touchEvent):
* UIProcess/API/qt/qwkpage.cpp:
(QWKPagePrivate::touchEvent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72305
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jer.noble@apple.com [Thu, 18 Nov 2010 18:09:00 +0000 (18:09 +0000)]
2010-11-16 Jer Noble <jer.noble@apple.com>
Reviewed by Eric Carlson.
REGRESSION (Safari 5.0.1): HTML5 videos on YouTube never start playing on Windows
https://bugs.webkit.org/show_bug.cgi?id=44439
<rdar://problem/
8342407>
setUpCookiesForQuickTime() previously depended on having setFrameView() called first
in order to get a Frame, and when it wasn't set, the cookie-copy failed. Now,
setUpCookiesForQuickTime uses the MediaPlayerClient function mediaPlayerOwningDocument()
to retrieve the document and subsequently, the Frame.
* platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::setUpCookiesForQuickTime):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72304
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
joepeck@webkit.org [Thu, 18 Nov 2010 17:59:53 +0000 (17:59 +0000)]
2010-11-18 Joseph Pecoraro <joepeck@webkit.org>
Reviewed by Darin Adler.
Allow no-store resources to be used for back navigation
https://bugs.webkit.org/show_bug.cgi?id=49672
Add tests for checking if the cache was used for a "Cache-control: no-store"
resource in back navigation, reload navigation, and normal navigation.
* http/tests/cache/history-only-cached-subresource-loads-expected.txt: Added.
* http/tests/cache/history-only-cached-subresource-loads.html: Added.
* http/tests/cache/resources/no-store-resource-forward.html: Added.
* http/tests/cache/resources/no-store-resource-next.html: Added.
* http/tests/cache/resources/no-store-resource.html: Added.
* http/tests/cache/resources/random.cgi: Added.
2010-11-18 Joseph Pecoraro <joepeck@webkit.org>
Reviewed by Darin Adler.
Allow no-store resources to be used for back navigation
https://bugs.webkit.org/show_bug.cgi?id=49672
Test: http/tests/cache/history-only-cached-subresource-loads.html
HTTP allows "Cache-Control: no-store" resources to "cached" for the
purposes of history, such as back/forward navigation. Previously
WebCore just immediately evicted these resources, now we leave them in
the cache as long as they are not "https". This allows us to use them
if they are used in a back navigation, or lazily evict and replace
them on other load types expecting non-stale resources.
(WebCore::CachedResource::CachedResource):
(WebCore::CachedResource::removeClient): instead of immediately removing the resource from the cache, leave it in the cache.
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::checkForReload):
(WebCore::CachedResourceLoader::requestResource): allow history only resources if the CachePolicy is CachePolicyHistoryBuffer (back/forward navigation).
* loader/cache/MemoryCache.cpp:
(WebCore::MemoryCache::requestResource): lazily remove history only resources if it is requested for a load type expecting non-stale resources.
* loader/cache/MemoryCache.h: default the forHistory parameter to false.
Rename cache policy CachePolicyAllowStale to CachePolicyHistoryBuffer.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::subresourceCachePolicy):
* loader/cache/CachePolicy.h:
* loader/cache/CachedResource.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72303
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Thu, 18 Nov 2010 17:54:25 +0000 (17:54 +0000)]
2010-11-18 Tony Chang <tony@chromium.org>
Reviewed by Adam Barth.
run platform/chromium/plugins/refcount-leaks.html on all platforms
https://bugs.webkit.org/show_bug.cgi?id=49485
Moving the test into the top level plugins dir.
* platform/chromium/drt_expectations.txt:
* platform/chromium/plugins/refcount-leaks-expected.txt: Removed.
* platform/chromium/plugins/refcount-leaks.html: Removed.
* plugins/refcount-leaks-expected.txt: Copied from LayoutTests/platform/chromium/plugins/refcount-leaks-expected.txt.
* plugins/refcount-leaks.html: Copied from LayoutTests/platform/chromium/plugins/refcount-leaks.html.
2010-11-18 Tony Chang <tony@chromium.org>
Reviewed by Adam Barth.
run platform/chromium/plugins/refcount-leaks.html on all platforms
https://bugs.webkit.org/show_bug.cgi?id=49485
Add PluginObject.testObjectCount which returns the number of allocated
TestObjects. Add PluginObject.testCreateTestObject which allocates
and returns a TestObject.
Add TestObject.refCount which returns the number of refs on the
TestObject.
* DumpRenderTree/TestNetscapePlugIn/PluginObject.cpp:
(pluginGetProperty):
(pluginInvoke):
* DumpRenderTree/TestNetscapePlugIn/TestObject.cpp:
(getTestObjectCount):
(testAllocate):
(testDeallocate):
(testGetProperty):
(testScriptObjectInvoke): Release a ref to a plugin object that was
previously leaked.
* DumpRenderTree/TestNetscapePlugIn/TestObject.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72302
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Thu, 18 Nov 2010 17:48:32 +0000 (17:48 +0000)]
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=49700
XSLTProcessor.importNode is only tested with document nodes, and hits an assertion
Test: fast/xsl/import-non-document-node.xhtml
* css/CSSStyleSheet.cpp:
(WebCore::isAcceptableCSSStyleSheetParent):
(WebCore::CSSStyleSheet::CSSStyleSheet):
* css/StyleSheet.cpp:
(WebCore::StyleSheet::StyleSheet):
Moved the assertion - hopefully, it's valid for CSS stylesheets.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72301
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antonm@chromium.org [Thu, 18 Nov 2010 17:39:46 +0000 (17:39 +0000)]
Not reviewed, proper regrouping of suppressions.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72300
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 18 Nov 2010 17:35:14 +0000 (17:35 +0000)]
2010-11-18 Charlie Reis <creis@chromium.org>
Reviewed by Darin Fisher.
Update correct content state during back/forward navigations
https://bugs.webkit.org/show_bug.cgi?id=48809
Ensures that history's previousItem is non-null when clients try to
update content state (e.g., Chromium's UpdateSessionHistory). We now
track load completions with a boolean field rather than by clearing
previousItem.
Behavior covered by existing tests in fast/history and fast/loader.
* loader/HistoryController.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72299
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antonm@chromium.org [Thu, 18 Nov 2010 17:34:22 +0000 (17:34 +0000)]
Not reviewed, 1st fixing failures of fast/dom/setPrimitiveValue-exceptions.html
https://bugs.webkit.org/show_bug.cgi?id=49653
There is apparently a crash in Win DBG build so I'm keeping the suppression.
* platform/chromium-mac/fast/dom/setPrimitiveValue-exceptions-expected.txt: Added.
* platform/chromium-win/fast/dom/setPrimitiveValue-exceptions-expected.txt: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72298
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Thu, 18 Nov 2010 17:26:43 +0000 (17:26 +0000)]
WebKitTools projects (WebKitTestRunner, record-memory-win) should use vsprops for common build settings
https://bugs.webkit.org/show_bug.cgi?id=49711
Reviewed by Adam Roben.
* WebKitTestRunner/Configurations/WebKitTestRunnerCFLite.vsprops: Added.
* WebKitTestRunner/Configurations/WebKitTestRunnerCommon.vsprops: Added.
* WebKitTestRunner/Configurations/WebKitTestRunnerCoreFoundation.vsprops: Added.
* WebKitTestRunner/win/WebKitTestRunner.vcproj:
* record-memory-win/record-memory-win-common.vsprops: Added.
* record-memory-win/record-memory-win.vcproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72297
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Thu, 18 Nov 2010 17:14:32 +0000 (17:14 +0000)]
WebKit Interfaces project should use vsprops file for common build settings
https://bugs.webkit.org/show_bug.cgi?id=49713
Reviewed by Adam Roben.
* WebKit.vcproj/Interfaces.vcproj:
* WebKit.vcproj/InterfacesCommon.vsprops: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72296
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abecsi@webkit.org [Thu, 18 Nov 2010 17:06:01 +0000 (17:06 +0000)]
2010-11-18 Andras Becsi <abecsi@inf.u-szeged.hu>
Reviewed by Csaba Osztrogonác.
[Qt][WK2] Only add user agent strings to the list which aren't listed yet.
* MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::updateUserAgentList):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72295
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 18 Nov 2010 16:36:09 +0000 (16:36 +0000)]
2010-11-18 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r72288.
http://trac.webkit.org/changeset/72288
https://bugs.webkit.org/show_bug.cgi?id=49730
'krit attempted to do that, but revert got stuck' (Requested
by antonm on #webkit).
* platform/mac/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.checksum: Removed.
* platform/mac/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png: Removed.
* platform/mac/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt: Removed.
* platform/mac/svg/custom/svg-curve-with-relative-cordinates-expected.txt:
* platform/mac/svg/dom/SVGPathSegList-appendItem-expected.checksum: Removed.
* platform/mac/svg/dom/SVGPathSegList-appendItem-expected.png: Removed.
* platform/mac/svg/dom/SVGPathSegList-clear-and-initialize-expected.checksum: Removed.
* platform/mac/svg/dom/SVGPathSegList-clear-and-initialize-expected.png: Removed.
* platform/mac/svg/dom/SVGPathSegList-cloning-expected.checksum: Removed.
* platform/mac/svg/dom/SVGPathSegList-cloning-expected.png: Removed.
* platform/mac/svg/dom/SVGPathSegList-cloning-expected.txt: Removed.
* platform/mac/svg/dom/SVGPathSegList-insertItemBefore-expected.checksum: Removed.
* platform/mac/svg/dom/SVGPathSegList-insertItemBefore-expected.png: Removed.
* platform/mac/svg/dom/SVGPathSegList-removeItem-expected.checksum: Removed.
* platform/mac/svg/dom/SVGPathSegList-removeItem-expected.png: Removed.
* platform/mac/svg/dom/SVGPathSegList-replaceItem-expected.checksum: Removed.
* platform/mac/svg/dom/SVGPathSegList-replaceItem-expected.png: Removed.
* platform/mac/svg/dom/SVGPathSegList-segment-modification-expected.checksum: Removed.
* platform/mac/svg/dom/SVGPathSegList-segment-modification-expected.png: Removed.
* platform/mac/svg/dom/SVGPathSegList-segment-modification-expected.txt: Removed.
* platform/mac/svg/dom/SVGPathSegList-xml-dom-synchronization-expected.checksum: Removed.
* platform/mac/svg/dom/SVGPathSegList-xml-dom-synchronization-expected.png: Removed.
* platform/mac/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.checksum: Removed.
* platform/mac/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.png: Removed.
* platform/mac/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.txt: Removed.
* svg/W3C-SVG-1.1-SE/paths-dom-02-f.svg: Removed.
* svg/dom/SVGPathSegList-appendItem-expected.txt: Removed.
* svg/dom/SVGPathSegList-appendItem.xhtml: Removed.
* svg/dom/SVGPathSegList-clear-and-initialize-expected.txt: Removed.
* svg/dom/SVGPathSegList-clear-and-initialize.xhtml: Removed.
* svg/dom/SVGPathSegList-cloning.html: Removed.
* svg/dom/SVGPathSegList-insertItemBefore-expected.txt: Removed.
* svg/dom/SVGPathSegList-insertItemBefore.xhtml: Removed.
* svg/dom/SVGPathSegList-removeItem-expected.txt: Removed.
* svg/dom/SVGPathSegList-removeItem.xhtml: Removed.
* svg/dom/SVGPathSegList-replaceItem-expected.txt: Removed.
* svg/dom/SVGPathSegList-replaceItem.xhtml: Removed.
* svg/dom/SVGPathSegList-segment-modification.svg: Removed.
* svg/dom/SVGPathSegList-xml-dom-synchronization-expected.txt: Removed.
* svg/dom/SVGPathSegList-xml-dom-synchronization.xhtml: Removed.
* svg/dom/SVGPathSegList-xml-dom-synchronization2.xhtml: Removed.
* svg/dom/fuzz-path-parser-expected.txt:
* svg/dom/path-parser-expected.txt:
* svg/dom/script-tests/path-parser.js:
():
* svg/dom/svglist-exception-on-out-bounds-error-expected.txt:
* svg/dom/svglist-exception-on-out-bounds-error.html:
* svg/dom/svgpath-out-of-bounds-getPathSeg-expected.txt:
2010-11-18 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r72288.
http://trac.webkit.org/changeset/72288
https://bugs.webkit.org/show_bug.cgi?id=49730
'krit attempted to do that, but revert got stuck' (Requested
by antonm on #webkit).
* Android.mk:
* CMakeLists.txt:
* DerivedSources.make:
* GNUmakefile.am:
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* WebCore.order:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSBindingsAllInOne.cpp:
* bindings/js/JSDOMBinding.cpp:
(WebCore::setDOMException):
* bindings/js/JSDOMBinding.h:
(WebCore::createDOMObjectWrapper):
(WebCore::getDOMObjectWrapper):
* bindings/js/JSSVGPathSegCustom.cpp:
(WebCore::toJS):
* bindings/js/JSSVGPathSegListCustom.cpp: Added.
(WebCore::JSSVGPathSegList::clear):
(WebCore::JSSVGPathSegList::initialize):
(WebCore::JSSVGPathSegList::getItem):
(WebCore::JSSVGPathSegList::insertItemBefore):
(WebCore::JSSVGPathSegList::replaceItem):
(WebCore::JSSVGPathSegList::removeItem):
(WebCore::JSSVGPathSegList::appendItem):
* bindings/scripts/CodeGenerator.pm:
* bindings/scripts/CodeGeneratorJS.pm:
* bindings/scripts/CodeGeneratorObjC.pm:
* bindings/scripts/CodeGeneratorV8.pm:
* rendering/SVGRenderTreeAsText.cpp:
(WebCore::operator<<):
* svg/SVGAllInOne.cpp:
* svg/SVGAnimatedPathData.cpp: Added.
* svg/SVGAnimatedPathData.h: Copied from WebCore/svg/SVGPathSegClosePath.h.
(WebCore::SVGAnimatedPathData::~SVGAnimatedPathData):
* svg/SVGAnimatedPathData.idl: Copied from WebCore/svg/SVGPathSegCurvetoQuadraticAbs.idl.
* svg/SVGPathElement.cpp:
(WebCore::SVGPathElement::SVGPathElement):
(WebCore::SVGPathElement::getPathSegAtLength):
(WebCore::SVGPathElement::createSVGPathSegClosePath):
(WebCore::SVGPathElement::createSVGPathSegMovetoAbs):
(WebCore::SVGPathElement::createSVGPathSegMovetoRel):
(WebCore::SVGPathElement::createSVGPathSegLinetoAbs):
(WebCore::SVGPathElement::createSVGPathSegLinetoRel):
(WebCore::SVGPathElement::createSVGPathSegCurvetoCubicAbs):
(WebCore::SVGPathElement::createSVGPathSegCurvetoCubicRel):
(WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticAbs):
(WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticRel):
(WebCore::SVGPathElement::createSVGPathSegArcAbs):
(WebCore::SVGPathElement::createSVGPathSegArcRel):
(WebCore::SVGPathElement::createSVGPathSegLinetoHorizontalAbs):
(WebCore::SVGPathElement::createSVGPathSegLinetoHorizontalRel):
(WebCore::SVGPathElement::createSVGPathSegLinetoVerticalAbs):
(WebCore::SVGPathElement::createSVGPathSegLinetoVerticalRel):
(WebCore::SVGPathElement::createSVGPathSegCurvetoCubicSmoothAbs):
(WebCore::SVGPathElement::createSVGPathSegCurvetoCubicSmoothRel):
(WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticSmoothAbs):
(WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticSmoothRel):
(WebCore::SVGPathElement::parseMappedAttribute):
(WebCore::SVGPathElement::svgAttributeChanged):
(WebCore::SVGPathElement::synchronizeProperty):
(WebCore::SVGPathElement::pathSegList):
(WebCore::SVGPathElement::normalizedPathSegList):
(WebCore::SVGPathElement::animatedPathSegList):
(WebCore::SVGPathElement::animatedNormalizedPathSegList):
(WebCore::SVGPathElement::toPathData):
* svg/SVGPathElement.h:
(WebCore::SVGPathElement::isValid):
(WebCore::SVGPathElement::supportsMarkers):
* svg/SVGPathElement.idl:
* svg/SVGPathParserFactory.cpp:
(WebCore::globalSVGPathSegListBuilder):
(WebCore::SVGPathParserFactory::buildPathFromByteStream):
(WebCore::SVGPathParserFactory::buildPathFromSVGPathSegList):
(WebCore::SVGPathParserFactory::buildSVGPathSegListFromString):
(WebCore::SVGPathParserFactory::buildSVGPathSegListFromByteStream):
(WebCore::SVGPathParserFactory::buildStringFromSVGPathSegList):
(WebCore::SVGPathParserFactory::buildSVGPathByteStreamFromString):
(WebCore::SVGPathParserFactory::buildAnimatedSVGPathByteStream):
(WebCore::SVGPathParserFactory::getSVGPathSegAtLengthFromSVGPathSegList):
* svg/SVGPathParserFactory.h:
* svg/SVGPathSeg.cpp: Copied from WebCore/svg/SVGPathSegLinetoHorizontalRel.idl.
(WebCore::SVGPathSeg::associatedAttributeName):
* svg/SVGPathSeg.h:
(WebCore::SVGPathSegSingleCoord::setX):
(WebCore::SVGPathSegSingleCoord::x):
(WebCore::SVGPathSegSingleCoord::setY):
(WebCore::SVGPathSegSingleCoord::y):
(WebCore::SVGPathSegSingleCoord::SVGPathSegSingleCoord):
* svg/SVGPathSeg.idl:
* svg/SVGPathSegArc.cpp: Copied from WebCore/svg/SVGPathSegClosePath.h.
(WebCore::SVGPathSegArcAbs::SVGPathSegArcAbs):
(WebCore::SVGPathSegArcRel::SVGPathSegArcRel):
* svg/SVGPathSegArc.h:
(WebCore::SVGPathSegArc::SVGPathSegArc):
(WebCore::SVGPathSegArc::setX):
(WebCore::SVGPathSegArc::x):
(WebCore::SVGPathSegArc::setY):
(WebCore::SVGPathSegArc::y):
(WebCore::SVGPathSegArc::setR1):
(WebCore::SVGPathSegArc::r1):
(WebCore::SVGPathSegArc::setR2):
(WebCore::SVGPathSegArc::r2):
(WebCore::SVGPathSegArc::setAngle):
(WebCore::SVGPathSegArc::angle):
(WebCore::SVGPathSegArc::setLargeArcFlag):
(WebCore::SVGPathSegArc::largeArcFlag):
(WebCore::SVGPathSegArc::setSweepFlag):
(WebCore::SVGPathSegArc::sweepFlag):
(WebCore::SVGPathSegArcAbs::create):
(WebCore::SVGPathSegArcAbs::pathSegType):
(WebCore::SVGPathSegArcAbs::pathSegTypeAsLetter):
(WebCore::SVGPathSegArcRel::create):
(WebCore::SVGPathSegArcRel::pathSegType):
(WebCore::SVGPathSegArcRel::pathSegTypeAsLetter):
* svg/SVGPathSegArcAbs.idl:
* svg/SVGPathSegArcRel.idl:
* svg/SVGPathSegClosePath.cpp: Added.
* svg/SVGPathSegClosePath.h:
(WebCore::SVGPathSegClosePath::create):
(WebCore::SVGPathSegClosePath::SVGPathSegClosePath):
* svg/SVGPathSegCurvetoCubic.cpp: Copied from WebCore/svg/SVGPathSegClosePath.h.
(WebCore::SVGPathSegCurvetoCubicAbs::SVGPathSegCurvetoCubicAbs):
(WebCore::SVGPathSegCurvetoCubicRel::SVGPathSegCurvetoCubicRel):
* svg/SVGPathSegCurvetoCubic.h:
(WebCore::SVGPathSegCurvetoCubic::SVGPathSegCurvetoCubic):
(WebCore::SVGPathSegCurvetoCubic::setX):
(WebCore::SVGPathSegCurvetoCubic::x):
(WebCore::SVGPathSegCurvetoCubic::setY):
(WebCore::SVGPathSegCurvetoCubic::y):
(WebCore::SVGPathSegCurvetoCubic::setX1):
(WebCore::SVGPathSegCurvetoCubic::x1):
(WebCore::SVGPathSegCurvetoCubic::setY1):
(WebCore::SVGPathSegCurvetoCubic::y1):
(WebCore::SVGPathSegCurvetoCubic::setX2):
(WebCore::SVGPathSegCurvetoCubic::x2):
(WebCore::SVGPathSegCurvetoCubic::setY2):
(WebCore::SVGPathSegCurvetoCubic::y2):
(WebCore::SVGPathSegCurvetoCubicAbs::create):
(WebCore::SVGPathSegCurvetoCubicAbs::pathSegType):
(WebCore::SVGPathSegCurvetoCubicAbs::pathSegTypeAsLetter):
(WebCore::SVGPathSegCurvetoCubicRel::create):
(WebCore::SVGPathSegCurvetoCubicRel::pathSegType):
(WebCore::SVGPathSegCurvetoCubicRel::pathSegTypeAsLetter):
* svg/SVGPathSegCurvetoCubicAbs.idl:
* svg/SVGPathSegCurvetoCubicRel.idl:
* svg/SVGPathSegCurvetoCubicSmooth.cpp: Copied from WebCore/svg/SVGPathSegClosePath.h.
(WebCore::SVGPathSegCurvetoCubicSmoothAbs::SVGPathSegCurvetoCubicSmoothAbs):
(WebCore::SVGPathSegCurvetoCubicSmoothRel::SVGPathSegCurvetoCubicSmoothRel):
* svg/SVGPathSegCurvetoCubicSmooth.h:
(WebCore::SVGPathSegCurvetoCubicSmooth::SVGPathSegCurvetoCubicSmooth):
(WebCore::SVGPathSegCurvetoCubicSmooth::setX):
(WebCore::SVGPathSegCurvetoCubicSmooth::x):
(WebCore::SVGPathSegCurvetoCubicSmooth::setY):
(WebCore::SVGPathSegCurvetoCubicSmooth::y):
(WebCore::SVGPathSegCurvetoCubicSmooth::setX2):
(WebCore::SVGPathSegCurvetoCubicSmooth::x2):
(WebCore::SVGPathSegCurvetoCubicSmooth::setY2):
(WebCore::SVGPathSegCurvetoCubicSmooth::y2):
(WebCore::SVGPathSegCurvetoCubicSmoothAbs::create):
(WebCore::SVGPathSegCurvetoCubicSmoothAbs::pathSegType):
(WebCore::SVGPathSegCurvetoCubicSmoothAbs::pathSegTypeAsLetter):
(WebCore::SVGPathSegCurvetoCubicSmoothRel::create):
(WebCore::SVGPathSegCurvetoCubicSmoothRel::pathSegType):
(WebCore::SVGPathSegCurvetoCubicSmoothRel::pathSegTypeAsLetter):
* svg/SVGPathSegCurvetoCubicSmoothAbs.idl:
* svg/SVGPathSegCurvetoCubicSmoothRel.idl:
* svg/SVGPathSegCurvetoQuadratic.cpp: Copied from WebCore/svg/SVGPathSegClosePath.h.
(WebCore::SVGPathSegCurvetoQuadraticAbs::SVGPathSegCurvetoQuadraticAbs):
(WebCore::SVGPathSegCurvetoQuadraticRel::SVGPathSegCurvetoQuadraticRel):
* svg/SVGPathSegCurvetoQuadratic.h:
(WebCore::SVGPathSegCurvetoQuadratic::SVGPathSegCurvetoQuadratic):
(WebCore::SVGPathSegCurvetoQuadratic::setX):
(WebCore::SVGPathSegCurvetoQuadratic::x):
(WebCore::SVGPathSegCurvetoQuadratic::setY):
(WebCore::SVGPathSegCurvetoQuadratic::y):
(WebCore::SVGPathSegCurvetoQuadratic::setX1):
(WebCore::SVGPathSegCurvetoQuadratic::x1):
(WebCore::SVGPathSegCurvetoQuadratic::setY1):
(WebCore::SVGPathSegCurvetoQuadratic::y1):
(WebCore::SVGPathSegCurvetoQuadraticAbs::create):
(WebCore::SVGPathSegCurvetoQuadraticAbs::pathSegType):
(WebCore::SVGPathSegCurvetoQuadraticAbs::pathSegTypeAsLetter):
(WebCore::SVGPathSegCurvetoQuadraticRel::create):
(WebCore::SVGPathSegCurvetoQuadraticRel::pathSegType):
(WebCore::SVGPathSegCurvetoQuadraticRel::pathSegTypeAsLetter):
* svg/SVGPathSegCurvetoQuadraticAbs.idl:
* svg/SVGPathSegCurvetoQuadraticRel.idl:
* svg/SVGPathSegCurvetoQuadraticSmooth.cpp: Copied from WebCore/svg/SVGPathSegClosePath.h.
(WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::SVGPathSegCurvetoQuadraticSmoothAbs):
(WebCore::SVGPathSegCurvetoQuadraticSmoothRel::SVGPathSegCurvetoQuadraticSmoothRel):
* svg/SVGPathSegCurvetoQuadraticSmooth.h:
(WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::create):
(WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::pathSegType):
(WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::pathSegTypeAsLetter):
(WebCore::SVGPathSegCurvetoQuadraticSmoothRel::create):
(WebCore::SVGPathSegCurvetoQuadraticSmoothRel::pathSegType):
(WebCore::SVGPathSegCurvetoQuadraticSmoothRel::pathSegTypeAsLetter):
* svg/SVGPathSegCurvetoQuadraticSmoothAbs.idl:
* svg/SVGPathSegCurvetoQuadraticSmoothRel.idl:
* svg/SVGPathSegLineto.cpp: Copied from WebCore/svg/SVGPathSegClosePath.h.
(WebCore::SVGPathSegLinetoAbs::SVGPathSegLinetoAbs):
(WebCore::SVGPathSegLinetoRel::SVGPathSegLinetoRel):
* svg/SVGPathSegLineto.h:
(WebCore::SVGPathSegLinetoAbs::create):
(WebCore::SVGPathSegLinetoAbs::pathSegType):
(WebCore::SVGPathSegLinetoAbs::pathSegTypeAsLetter):
(WebCore::SVGPathSegLinetoRel::create):
(WebCore::SVGPathSegLinetoRel::pathSegType):
(WebCore::SVGPathSegLinetoRel::pathSegTypeAsLetter):
* svg/SVGPathSegLinetoAbs.idl:
* svg/SVGPathSegLinetoHorizontal.cpp: Copied from WebCore/svg/SVGPathSegClosePath.h.
(WebCore::SVGPathSegLinetoHorizontalAbs::SVGPathSegLinetoHorizontalAbs):
(WebCore::SVGPathSegLinetoHorizontalRel::SVGPathSegLinetoHorizontalRel):
* svg/SVGPathSegLinetoHorizontal.h:
(WebCore::SVGPathSegLinetoHorizontal::SVGPathSegLinetoHorizontal):
(WebCore::SVGPathSegLinetoHorizontal::setX):
(WebCore::SVGPathSegLinetoHorizontal::x):
(WebCore::SVGPathSegLinetoHorizontalAbs::create):
(WebCore::SVGPathSegLinetoHorizontalAbs::pathSegType):
(WebCore::SVGPathSegLinetoHorizontalAbs::pathSegTypeAsLetter):
(WebCore::SVGPathSegLinetoHorizontalRel::create):
(WebCore::SVGPathSegLinetoHorizontalRel::pathSegType):
(WebCore::SVGPathSegLinetoHorizontalRel::pathSegTypeAsLetter):
* svg/SVGPathSegLinetoHorizontalAbs.idl:
* svg/SVGPathSegLinetoHorizontalRel.idl:
* svg/SVGPathSegLinetoRel.idl:
* svg/SVGPathSegLinetoVertical.cpp: Copied from WebCore/svg/SVGPathSegClosePath.h.
(WebCore::SVGPathSegLinetoVerticalAbs::SVGPathSegLinetoVerticalAbs):
(WebCore::SVGPathSegLinetoVerticalRel::SVGPathSegLinetoVerticalRel):
* svg/SVGPathSegLinetoVertical.h:
(WebCore::SVGPathSegLinetoVertical::SVGPathSegLinetoVertical):
(WebCore::SVGPathSegLinetoVertical::setY):
(WebCore::SVGPathSegLinetoVertical::y):
(WebCore::SVGPathSegLinetoVerticalAbs::create):
(WebCore::SVGPathSegLinetoVerticalAbs::pathSegType):
(WebCore::SVGPathSegLinetoVerticalAbs::pathSegTypeAsLetter):
(WebCore::SVGPathSegLinetoVerticalRel::create):
(WebCore::SVGPathSegLinetoVerticalRel::pathSegType):
(WebCore::SVGPathSegLinetoVerticalRel::pathSegTypeAsLetter):
* svg/SVGPathSegLinetoVerticalAbs.idl:
* svg/SVGPathSegLinetoVerticalRel.idl:
* svg/SVGPathSegList.cpp:
(WebCore::SVGPathSegList::SVGPathSegList):
* svg/SVGPathSegList.h:
(WebCore::SVGPathSegList::create):
* svg/SVGPathSegList.idl:
* svg/SVGPathSegListBuilder.cpp:
(WebCore::SVGPathSegListBuilder::SVGPathSegListBuilder):
(WebCore::SVGPathSegListBuilder::moveTo):
(WebCore::SVGPathSegListBuilder::lineTo):
(WebCore::SVGPathSegListBuilder::lineToHorizontal):
(WebCore::SVGPathSegListBuilder::lineToVertical):
(WebCore::SVGPathSegListBuilder::curveToCubic):
(WebCore::SVGPathSegListBuilder::curveToCubicSmooth):
(WebCore::SVGPathSegListBuilder::curveToQuadratic):
(WebCore::SVGPathSegListBuilder::curveToQuadraticSmooth):
(WebCore::SVGPathSegListBuilder::arcTo):
(WebCore::SVGPathSegListBuilder::closePath):
* svg/SVGPathSegListBuilder.h:
(WebCore::SVGPathSegListBuilder::setCurrentSVGPathSegList):
(WebCore::SVGPathSegListBuilder::cleanup):
* svg/SVGPathSegListSource.cpp:
(WebCore::SVGPathSegListSource::SVGPathSegListSource):
(WebCore::SVGPathSegListSource::parseSVGSegmentType):
(WebCore::SVGPathSegListSource::nextCommand):
(WebCore::SVGPathSegListSource::parseMoveToSegment):
(WebCore::SVGPathSegListSource::parseLineToSegment):
(WebCore::SVGPathSegListSource::parseCurveToQuadraticSmoothSegment):
* svg/SVGPathSegListSource.h:
(WebCore::SVGPathSegListSource::create):
* svg/SVGPathSegMoveto.cpp: Copied from WebCore/svg/SVGPathSegClosePath.h.
(WebCore::SVGPathSegMovetoAbs::SVGPathSegMovetoAbs):
(WebCore::SVGPathSegMovetoRel::SVGPathSegMovetoRel):
* svg/SVGPathSegMoveto.h:
(WebCore::SVGPathSegMovetoAbs::create):
(WebCore::SVGPathSegMovetoAbs::pathSegType):
(WebCore::SVGPathSegMovetoAbs::pathSegTypeAsLetter):
(WebCore::SVGPathSegMovetoRel::create):
(WebCore::SVGPathSegMovetoRel::pathSegType):
(WebCore::SVGPathSegMovetoRel::pathSegTypeAsLetter):
* svg/SVGPathSegMovetoAbs.idl:
* svg/SVGPathSegMovetoRel.idl:
* svg/SVGPathSegWithContext.h: Removed.
* svg/properties/SVGAnimatedPathSegListPropertyTearOff.h: Removed.
* svg/properties/SVGPathSegListPropertyTearOff.cpp: Removed.
* svg/properties/SVGPathSegListPropertyTearOff.h: Removed.
2010-11-18 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r72288.
http://trac.webkit.org/changeset/72288
https://bugs.webkit.org/show_bug.cgi?id=49730
'krit attempted to do that, but revert got stuck' (Requested
by antonm on #webkit).
* WebView/WebRenderLayer.mm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72294
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Thu, 18 Nov 2010 15:39:13 +0000 (15:39 +0000)]
2010-11-18 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r72292.
http://trac.webkit.org/changeset/72292
https://bugs.webkit.org/show_bug.cgi?id=49732
will break win build (Requested by loislo on #webkit).
* inspector/CodeGeneratorInspector.pm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72293
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Thu, 18 Nov 2010 15:33:56 +0000 (15:33 +0000)]
2010-11-18 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: reduce the footprint of InspectorBackendDispatcher.
InspectorBackendDispatcher is a generated file.
Its content is not optimal and loc may be reduced by a quarter.
In each generated function we have a code for getting 'in' values from
the arguments properties object. I've extracted this code into separate getters.
The side effect is better readability of the generated code.
https://bugs.webkit.org/show_bug.cgi?id=49729
* inspector/CodeGeneratorInspector.pm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72292
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antonm@chromium.org [Thu, 18 Nov 2010 14:47:22 +0000 (14:47 +0000)]
Not reviewed, removing rebaselined expectation for fast/backgrounds/size/contain-and-cover.html
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72291
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Thu, 18 Nov 2010 14:42:58 +0000 (14:42 +0000)]
2010-11-18 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
[v8] fast/css/getFloatValueForUnit.html fails since http://trac.webkit.org/changeset/72189
https://bugs.webkit.org/show_bug.cgi?id=49656
WebCore:
* bindings/scripts/CodeGeneratorV8.pm:
LayoutTests:
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72290
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 18 Nov 2010 13:51:26 +0000 (13:51 +0000)]
2010-11-18 Chao-ying Fu <fu@mips.com>
Reviewed by Csaba Osztrogonác.
Avoid increasing required alignment of target type warning
https://bugs.webkit.org/show_bug.cgi?id=43963
* runtime/UString.h:
(JSC::UStringHash::equal):
* wtf/StdLibExtras.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72289
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Thu, 18 Nov 2010 13:42:45 +0000 (13:42 +0000)]
2010-11-18 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Convert SVGPathSeg/SVGPathSegList to the new SVGPropertyTearOff concept
https://bugs.webkit.org/show_bug.cgi?id=49580
SVGPathElement.cloneNode loses generated pathSegList
https://bugs.webkit.org/show_bug.cgi?id=43388
SVG Path elements are not correctly updated through pathSegList manipulation on relative values
https://bugs.webkit.org/show_bug.cgi?id=30219
Changing an SVGPathSeg does not update a following Smooth Cubic Curveto
https://bugs.webkit.org/show_bug.cgi?id=19741
SVGPathElement should only build SVGPathSeg* list on demand
https://bugs.webkit.org/show_bug.cgi?id=10827
Tests: svg/W3C-SVG-1.1-SE/paths-dom-02-f.svg
svg/dom/SVGPathSegList-appendItem.xhtml
svg/dom/SVGPathSegList-clear-and-initialize.xhtml
svg/dom/SVGPathSegList-cloning.html
svg/dom/SVGPathSegList-insertItemBefore.xhtml
svg/dom/SVGPathSegList-removeItem.xhtml
svg/dom/SVGPathSegList-replaceItem.xhtml
svg/dom/SVGPathSegList-xml-dom-synchronization.xhtml
svg/dom/SVGPathSegList-xml-dom-synchronization2.xhtml
svg/dom/SVGPathSegList-segment-modification.svg
Convert SVGPathSeg*/SVGPathSegList to the new SVG(Animated)PropertyTearOff concept.
Unlike all other SVG* types that use the SVGPropertyTearOff concept, SVGPathSegs are already refcounted,
and don't need to be wrapped in SVGPropertyTearOff objects. The consequence is that SVGPathSegs need to track
themselves to which list and path element they belong. Introduce new SVGAnimatedPathSegListPropertyTearOff
and SVGPathSegListPropertyTearOff classes, that encapsulate the special needed for SVGPathSegList.
Each SVGPathSeg now needs to store a RefPtr<SVGPathElement> - this makes it impossible to use SVGPathSegList
to represent the 'd' attribute internally in SVGPathElement. SVGPathSegList is now only used in the SVG DOM bindings
if someone explicitely requests 'pathElement.pathSegList' (eg. via JS). Switch to use SVGPathByteStream to store
the 'd' attribute data in SVGPathElement, which is much more compact, and less memory intensive.
Dirk already prepared SVGPathParserFactory some months ago, which allows easy conversion between
String/Path/SVGPathSegList/SVGPathByteStream in all directions, including normalizing the lists, when requested.
As consequence SVGPathSegList is now only built on demand, when explicitely requested. Using the SVGAnimatedProperty
concept gives us 'd' attribute <-> SVGPathSegList synchronization for free, fixing several bugs, listed above.
* Android.mk: Remove obsolete SVGPathSeg*.cpp files and SVGAnimatedPathData.cpp from build.
* CMakeLists.txt: Ditto.
* DerivedSources.make: Remove SVGAnimatedPathData IDL generation.
* GNUmakefile.am: Remove obsolete SVGPathSeg*.cpp files and SVGAnimatedPathData.cpp from build.
* WebCore.gyp/WebCore.gyp: Remove SVGAnimatedPathData IDL generation.
* WebCore.gypi: Remove obsolete SVGPathSeg*.cpp files and SVGAnimatedPathData.cpp from build.
* WebCore.order: Remove no-longer existant SVGAnimatedPathData symbols.
* WebCore.pro: Remove obsolete SVGPathSeg*.cpp files and SVGAnimatedPathData.cpp / JSSVGPathSegCustom.* from build.
* WebCore.vcproj/WebCore.vcproj: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* bindings/js/JSBindingsAllInOne.cpp: Remove JSSVGPathSegCustom.cpp from build.
* bindings/js/JSDOMBinding.cpp: Adapt to toJS() changes, remove context parameter.
(WebCore::setDOMException):
* bindings/js/JSDOMBinding.h: Remove obsolete CREATE_SVG_OBJECT_WRAPPER macro, the context parameter is not existant anymore.
* bindings/js/JSSVGPathSegCustom.cpp: Replace CREATE_SVG_OBJECT_WRAPPER by CREATE_DOM_OBJECT_WRAPPER. Remove context parameter/handling.
(WebCore::toJS):
* bindings/js/JSSVGPathSegListCustom.cpp: Removed.
* bindings/scripts/CodeGenerator.pm: Map 'SVGPathSegList' IDL type to SVG 'SVGPathSegListPropertyTearOff' native type.
* bindings/scripts/CodeGeneratorJS.pm: Remove IsSVGTypeNeedingContextParameter() methods and usages. Handle SVGPathSegListPropertyTearOff.
* bindings/scripts/CodeGeneratorObjC.pm: Handle SVGPathSegListPropertyTearOff.
* bindings/scripts/CodeGeneratorV8.pm: Remove IsSVGTypeNeedingContextParameter() methods and usages.
* rendering/SVGRenderTreeAsText.cpp: Build path string from byte stream, not path segment list.
(WebCore::operator<<):
* svg/SVGAllInOne.cpp: Remove obsolete cpp files.
* svg/SVGAnimatedPathData.cpp: Removed.
* svg/SVGAnimatedPathData.h: Removed.
* svg/SVGAnimatedPathData.idl: Removed.
* svg/SVGPathElement.cpp: Build SVGPathList on demand. Use SVGPathByteStream to parse/store the 'd' attribute content.
(WebCore::SVGPathElement::SVGPathElement):
(WebCore::SVGPathElement::getPathSegAtLength): Use SVGPathByteStream, not SVGPathSegList to determine the getPathSegAtLength() information.
(WebCore::SVGPathElement::createSVGPathSegClosePath): Pass SVGPathElement to SVGPathSeg and a SVGPathSegRole parameter and store it to track the list origin.
(WebCore::SVGPathElement::createSVGPathSegMovetoAbs): Ditto.
(WebCore::SVGPathElement::createSVGPathSegMovetoRel): Ditto.
(WebCore::SVGPathElement::createSVGPathSegLinetoAbs): Ditto.
(WebCore::SVGPathElement::createSVGPathSegLinetoRel): Ditto.
(WebCore::SVGPathElement::createSVGPathSegCurvetoCubicAbs): Ditto.
(WebCore::SVGPathElement::createSVGPathSegCurvetoCubicRel): Ditto.
(WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticAbs): Ditto.
(WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticRel): Ditto.
(WebCore::SVGPathElement::createSVGPathSegArcAbs): Ditto.
(WebCore::SVGPathElement::createSVGPathSegArcRel): Ditto.
(WebCore::SVGPathElement::createSVGPathSegLinetoHorizontalAbs): Ditto.
(WebCore::SVGPathElement::createSVGPathSegLinetoHorizontalRel): Ditto.
(WebCore::SVGPathElement::createSVGPathSegLinetoVerticalAbs): Ditto.
(WebCore::SVGPathElement::createSVGPathSegLinetoVerticalRel): Ditto.
(WebCore::SVGPathElement::createSVGPathSegCurvetoCubicSmoothAbs): Ditto.
(WebCore::SVGPathElement::createSVGPathSegCurvetoCubicSmoothRel): Ditto.
(WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticSmoothAbs): Ditto.
(WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticSmoothRel): Ditto.
(WebCore::SVGPathElement::parseMappedAttribute): Build SVGPathByteStream from 'd' attribute, not a SVGPathSegList.
(WebCore::SVGPathElement::svgAttributeChanged): If a SVGPathSegList object has been built, synchronize it with the 'd' attribute.
(WebCore::SVGPathElement::synchronizeProperty): Synchronize 'd' attribute with the SVGPathSegList, if needed.
(WebCore::SVGPathElement::synchronizeD): Added.
(WebCore::SVGPathElement::pathSegList): Use same trick as in SVGPolyElement to expose the 'pathSegList' / 'animatedPathSegList' object to the SVG DOM bindings.
(WebCore::SVGPathElement::normalizedPathSegList): Ditto.
(WebCore::SVGPathElement::animatedPathSegList): Ditto.
(WebCore::SVGPathElement::animatedNormalizedPathSegList): Ditto.
(WebCore::SVGPathElement::toPathData): Build 'Path' object from SVGPathByteStream, not from SVGPathSegList.
(WebCore::SVGPathElement::pathSegListChanged): Used to synchronize the SVGPathSegLists and the d attribute, as well as any changes from any SVGPathSeg associated with this SVGPathElement.
* svg/SVGPathElement.h: Add new accessors...
(WebCore::SVGPathElement::pathByteStream): ... needed by SVGRenderTreeAsText.
(WebCore::SVGPathElement::animatablePathSegList): ... needed by SVGPathSegListPropertyTearOff.
* svg/SVGPathElement.idl: Merge SVGAnimatedPathData interface into SVGPathElement.
* svg/SVGPathParserFactory.cpp: Cleanup SVGPathParserFactory, remove obsolete methods, now that SVGPathElement switched to using SVGPathByteStream internally.
(WebCore::globalSVGPathSegListBuilder):
(WebCore::SVGPathParserFactory::buildSVGPathByteStreamFromSVGPathSegList):
(WebCore::SVGPathParserFactory::buildPathFromByteStream):
(WebCore::SVGPathParserFactory::buildSVGPathSegListFromByteStream):
(WebCore::SVGPathParserFactory::buildStringFromSVGPathSegList):
(WebCore::SVGPathParserFactory::buildSVGPathByteStreamFromString):
(WebCore::SVGPathParserFactory::buildAnimatedSVGPathByteStream):
(WebCore::SVGPathParserFactory::getSVGPathSegAtLengthFromSVGPathByteStream):
* svg/SVGPathParserFactory.h:
* svg/SVGPathSeg.cpp: Removed.
* svg/SVGPathSeg.h: Add new SVGPathSegRole enum, identifying to which list a path segment belongs.
(WebCore::SVGPathSeg::SVGPathSeg):
* svg/SVGPathSeg.idl: Reindented.
* svg/SVGPathSegArc.cpp: Removed.
* svg/SVGPathSegArc.h: All setters now call the commitChange() method.
* svg/SVGPathSegArcAbs.idl: Enable StrictTypeChecking.
* svg/SVGPathSegArcRel.idl: Ditto.
* svg/SVGPathSegClosePath.cpp: Removed.
* svg/SVGPathSegClosePath.h:
* svg/SVGPathSegCurvetoCubic.cpp: Removed.
* svg/SVGPathSegCurvetoCubic.h: All setters now call the commitChange() method.
* svg/SVGPathSegCurvetoCubicAbs.idl: Enable StrictTypeChecking.
* svg/SVGPathSegCurvetoCubicRel.idl: Ditto.
* svg/SVGPathSegCurvetoCubicSmooth.cpp: Removed.
* svg/SVGPathSegCurvetoCubicSmooth.h: All setters now call the commitChange() method.
* svg/SVGPathSegCurvetoCubicSmoothAbs.idl: Enable StrictTypeChecking.
* svg/SVGPathSegCurvetoCubicSmoothRel.idl: Ditto.
* svg/SVGPathSegCurvetoQuadratic.cpp: Removed.
* svg/SVGPathSegCurvetoQuadratic.h: All setters now call the commitChange() method.
* svg/SVGPathSegCurvetoQuadraticAbs.idl: Enable StrictTypeChecking.
* svg/SVGPathSegCurvetoQuadraticRel.idl: Ditto.
* svg/SVGPathSegCurvetoQuadraticSmooth.cpp: Removed.
* svg/SVGPathSegCurvetoQuadraticSmooth.h: All setters now call the commitChange() method.
* svg/SVGPathSegCurvetoQuadraticSmoothAbs.idl: Enable StrictTypeChecking.
* svg/SVGPathSegCurvetoQuadraticSmoothRel.idl: Ditto.
* svg/SVGPathSegLineto.cpp: Removed.
* svg/SVGPathSegLineto.h: All setters now call the commitChange() method.
* svg/SVGPathSegLinetoAbs.idl: Enable StrictTypeChecking.
* svg/SVGPathSegLinetoHorizontal.cpp: Removed.
* svg/SVGPathSegLinetoHorizontal.h: All setters now call the commitChange() method.
* svg/SVGPathSegLinetoHorizontalAbs.idl: Enable StrictTypeChecking.
* svg/SVGPathSegLinetoHorizontalRel.idl: Ditto.
* svg/SVGPathSegLinetoRel.idl: Enable StrictTypeChecking.
* svg/SVGPathSegLinetoVertical.cpp: Removed.
* svg/SVGPathSegLinetoVertical.h: All setters now call the commitChange() method.
* svg/SVGPathSegLinetoVerticalAbs.idl: Enable StrictTypeChecking.
* svg/SVGPathSegLinetoVerticalRel.idl: Ditto.
* svg/SVGPathSegList.cpp: Switch from SVGList<RefPtr<SVGPathSeg> > to a plain Vector<RefPtr<SVGPathSeg> >.
(WebCore::SVGPathSegList::valueAsString): Utilize SVGPathParserFactory to build a String from a SVGPathSegList.
(WebCore::SVGPathSegList::commitChange): Call SVGPathElement::pathSegListChanged().
* svg/SVGPathSegList.h:
(WebCore::SVGPathSegList::SVGPathSegList):
* svg/SVGPathSegList.idl: Remove [JSCCustom] flags, no longer needed.
* svg/SVGPathSegListBuilder.cpp: Adapt to SVGPathSegList API changes.
(WebCore::SVGPathSegListBuilder::SVGPathSegListBuilder):
(WebCore::SVGPathSegListBuilder::moveTo):
(WebCore::SVGPathSegListBuilder::lineTo):
(WebCore::SVGPathSegListBuilder::lineToHorizontal):
(WebCore::SVGPathSegListBuilder::lineToVertical):
(WebCore::SVGPathSegListBuilder::curveToCubic):
(WebCore::SVGPathSegListBuilder::curveToCubicSmooth):
(WebCore::SVGPathSegListBuilder::curveToQuadratic):
(WebCore::SVGPathSegListBuilder::curveToQuadraticSmooth):
(WebCore::SVGPathSegListBuilder::arcTo):
(WebCore::SVGPathSegListBuilder::closePath):
* svg/SVGPathSegListBuilder.h: Ditto.
(WebCore::SVGPathSegListBuilder::setCurrentSVGPathElement):
(WebCore::SVGPathSegListBuilder::setCurrentSVGPathSegList):
(WebCore::SVGPathSegListBuilder::setCurrentSVGPathSegRole):
(WebCore::SVGPathSegListBuilder::cleanup):
* svg/SVGPathSegListSource.cpp: Ditto.
(WebCore::SVGPathSegListSource::SVGPathSegListSource):
(WebCore::SVGPathSegListSource::parseSVGSegmentType):
(WebCore::SVGPathSegListSource::nextCommand):
(WebCore::SVGPathSegListSource::parseMoveToSegment):
(WebCore::SVGPathSegListSource::parseLineToSegment):
(WebCore::SVGPathSegListSource::parseCurveToQuadraticSmoothSegment):
* svg/SVGPathSegListSource.h: Ditto.
(WebCore::SVGPathSegListSource::create):
* svg/SVGPathSegMoveto.cpp: Removed.
* svg/SVGPathSegMoveto.h: All setters now call the commitChange() method.
* svg/SVGPathSegMovetoAbs.idl: Enable StrictTypeChecking.
* svg/SVGPathSegMovetoRel.idl: Ditto.
* svg/SVGPathSegWithContext.h: Added. This is the new base class for all SVGPathSeg derived types, that's associated with a SVGPathElement and a 'role' (normalized/unaltered segment list).
(WebCore::SVGPathSegWithContext::SVGPathSegWithContext):
(WebCore::SVGPathSegWithContext::animatedProperty):
(WebCore::SVGPathSegWithContext::setContextAndRole):
(WebCore::SVGPathSegWithContext::commitChange):
(WebCore::SVGPathSegSingleCoordinate::x):
(WebCore::SVGPathSegSingleCoordinate::setX):
(WebCore::SVGPathSegSingleCoordinate::y):
(WebCore::SVGPathSegSingleCoordinate::setY):
(WebCore::SVGPathSegSingleCoordinate::SVGPathSegSingleCoordinate):
* svg/properties/SVGAnimatedPathSegListPropertyTearOff.h: Added.
(WebCore::SVGAnimatedPathSegListPropertyTearOff::baseVal):
(WebCore::SVGAnimatedPathSegListPropertyTearOff::animVal):
(WebCore::SVGAnimatedPathSegListPropertyTearOff::removeItemFromList):
(WebCore::SVGAnimatedPathSegListPropertyTearOff::create):
(WebCore::SVGAnimatedPathSegListPropertyTearOff::SVGAnimatedPathSegListPropertyTearOff):
* svg/properties/SVGPathSegListPropertyTearOff.cpp: Added.
(WebCore::SVGPathSegListPropertyTearOff::clear): Added in the cpp file, not in the header, as it needs access to SVGPathSegWithContext, which we can't include from the header.
(WebCore::SVGPathSegListPropertyTearOff::getItem): Ditto.
(WebCore::SVGPathSegListPropertyTearOff::removeItem): Ditto.
(WebCore::SVGPathSegListPropertyTearOff::contextElement): Needs access to SVGPathElement, that's why it lives in the cpp file.
(WebCore::SVGPathSegListPropertyTearOff::processIncomingListItemValue): Needs access to SVGPathSegWithContext.
* svg/properties/SVGPathSegListPropertyTearOff.h: Added.
(WebCore::SVGPathSegListPropertyTearOff::create):
(WebCore::SVGPathSegListPropertyTearOff::removeItemFromList):
(WebCore::SVGPathSegListPropertyTearOff::numberOfItems):
(WebCore::SVGPathSegListPropertyTearOff::initialize):
(WebCore::SVGPathSegListPropertyTearOff::insertItemBefore):
(WebCore::SVGPathSegListPropertyTearOff::replaceItem):
(WebCore::SVGPathSegListPropertyTearOff::appendItem):
(WebCore::SVGPathSegListPropertyTearOff::SVGPathSegListPropertyTearOff):
(WebCore::SVGPathSegListPropertyTearOff::commitChange):
(WebCore::SVGPathSegListPropertyTearOff::processIncomingListItemWrapper):
2010-11-18 Nikolas Zimmermann <nzimmermann@rim.com>
Reviewed by Dirk Schulze.
Convert SVGPathSeg/SVGPathSegList to the new SVGPropertyTearOff concept
https://bugs.webkit.org/show_bug.cgi?id=49580
Add several new tests covering SVGPathSegList usage.
* platform/mac/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.checksum: Added.
* platform/mac/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png: Added.
* platform/mac/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt: Added.
* platform/mac/svg/custom/svg-curve-with-relative-cordinates-expected.txt:
* platform/mac/svg/dom/SVGPathSegList-appendItem-expected.checksum: Added.
* platform/mac/svg/dom/SVGPathSegList-appendItem-expected.png: Added.
* platform/mac/svg/dom/SVGPathSegList-clear-and-initialize-expected.checksum: Added.
* platform/mac/svg/dom/SVGPathSegList-clear-and-initialize-expected.png: Added.
* platform/mac/svg/dom/SVGPathSegList-cloning-expected.checksum: Added.
* platform/mac/svg/dom/SVGPathSegList-cloning-expected.png: Added.
* platform/mac/svg/dom/SVGPathSegList-cloning-expected.txt: Added.
* platform/mac/svg/dom/SVGPathSegList-insertItemBefore-expected.checksum: Added.
* platform/mac/svg/dom/SVGPathSegList-insertItemBefore-expected.png: Added.
* platform/mac/svg/dom/SVGPathSegList-removeItem-expected.checksum: Added.
* platform/mac/svg/dom/SVGPathSegList-removeItem-expected.png: Added.
* platform/mac/svg/dom/SVGPathSegList-replaceItem-expected.checksum: Added.
* platform/mac/svg/dom/SVGPathSegList-replaceItem-expected.png: Added.
* platform/mac/svg/dom/SVGPathSegList-segment-modification-expected.checksum: Added.
* platform/mac/svg/dom/SVGPathSegList-segment-modification-expected.png: Added.
* platform/mac/svg/dom/SVGPathSegList-segment-modification-expected.txt: Added.
* platform/mac/svg/dom/SVGPathSegList-xml-dom-synchronization-expected.checksum: Added.
* platform/mac/svg/dom/SVGPathSegList-xml-dom-synchronization-expected.png: Added.
* platform/mac/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.checksum: Added.
* platform/mac/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.png: Added.
* platform/mac/svg/dom/SVGPathSegList-xml-dom-synchronization2-expected.txt: Added.
* svg/W3C-SVG-1.1-SE/paths-dom-02-f.svg: Added.
* svg/dom/SVGPathSegList-appendItem-expected.txt: Added.
* svg/dom/SVGPathSegList-appendItem.xhtml: Added.
* svg/dom/SVGPathSegList-clear-and-initialize-expected.txt: Added.
* svg/dom/SVGPathSegList-clear-and-initialize.xhtml: Added.
* svg/dom/SVGPathSegList-cloning.html: Added.
* svg/dom/SVGPathSegList-insertItemBefore-expected.txt: Added.
* svg/dom/SVGPathSegList-insertItemBefore.xhtml: Added.
* svg/dom/SVGPathSegList-removeItem-expected.txt: Added.
* svg/dom/SVGPathSegList-removeItem.xhtml: Added.
* svg/dom/SVGPathSegList-replaceItem-expected.txt: Added.
* svg/dom/SVGPathSegList-replaceItem.xhtml: Added.
* svg/dom/SVGPathSegList-segment-modification.svg: Added.
* svg/dom/SVGPathSegList-xml-dom-synchronization-expected.txt: Added.
* svg/dom/SVGPathSegList-xml-dom-synchronization.xhtml: Added.
* svg/dom/SVGPathSegList-xml-dom-synchronization2.xhtml: Added.
* svg/dom/fuzz-path-parser-expected.txt:
* svg/dom/path-parser-expected.txt:
* svg/dom/script-tests/path-parser.js:
():
* svg/dom/svglist-exception-on-out-bounds-error-expected.txt:
* svg/dom/svglist-exception-on-out-bounds-error.html:
* svg/dom/svgpath-out-of-bounds-getPathSeg-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72288
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antonm@chromium.org [Thu, 18 Nov 2010 13:29:18 +0000 (13:29 +0000)]
Not reviewed, rebaselining fast/backgrounds/size/contain-and-cover.html
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72287
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
senorblanco@chromium.org [Thu, 18 Nov 2010 13:21:44 +0000 (13:21 +0000)]
2010-11-18 Stephen White <senorblanco@chromium.org>
Unreviewed; new test baselines.
New win & linux baselines for test affected by http://trac.webkit.org/changeset/72282.
* platform/chromium-linux/fast/backgrounds/size/contain-and-cover-expected.checksum:
* platform/chromium-linux/fast/backgrounds/size/contain-and-cover-expected.png:
* platform/chromium-win/fast/backgrounds/size/contain-and-cover-expected.checksum:
* platform/chromium-win/fast/backgrounds/size/contain-and-cover-expected.png:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72286
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Thu, 18 Nov 2010 12:57:04 +0000 (12:57 +0000)]
2010-11-18 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Chrome DevTools: minify front-end JavaScript.
https://bugs.webkit.org/show_bug.cgi?id=49657
* scripts/concatenate_js_files.py:
* scripts/jsmin.py: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72285
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mario@webkit.org [Thu, 18 Nov 2010 12:42:08 +0000 (12:42 +0000)]
2010-11-18 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Martin Robinson.
[Gtk] atk_text_get_selection returns the wrong offsets after a link
https://bugs.webkit.org/show_bug.cgi?id=49514
Consider possible embedded objects to calculate startOffset.
So far we were using offsetInContainerNode() to calculate the
value of startOffset when checking the offsets for the current
selection, which was wrong because that wouldn't work ok if any
embedded object was present in the paragraph before the
selection. Thus, we need to consider this fact when calculating
the startOffset from the point of view of the object this function
is called on, in order to return the right and actual values.
* accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
(getSelectionOffsetsForObject): Check range length from the first
position in the object the function is called on until the first
position of current selection, and use it as startOffset.
2010-11-18 Mario Sanchez Prada <msanchez@igalia.com>
Reviewed by Martin Robinson.
[Gtk] atk_text_get_selection returns the wrong offsets after a link
https://bugs.webkit.org/show_bug.cgi?id=49514
Updated test case to also chech this specific subcase.
We need to explicitly check the case of having a selection in a
paragraph after an embedded object (i.e. a link) to make sure the
right calculations are being done when the paragraph is composed
of more than just one text object, and the current selection is
made only in one of them.
* tests/testatk.c:
(testWebkitAtkTextSelections): Make sure that a selection after a
link in a paragraph is working ok when asking for the text
selection from the point of view of the paragraph.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72284
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Thu, 18 Nov 2010 12:34:53 +0000 (12:34 +0000)]
2010-11-17 Andreas Kling <kling@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
Reuse the size of the actualVisibleContentRect when loading a new page
or navigating session history.
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::transitionToCommittedForNewPage):
2010-11-17 Andreas Kling <kling@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
Reuse the size of the actualVisibleContentRect when loading a new page
or navigating session history.
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72283
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
senorblanco@chromium.org [Thu, 18 Nov 2010 12:20:55 +0000 (12:20 +0000)]
2010-11-12 Stephen White <senorblanco@chromium.org>
Reviewed by Simon Fraser.
Fix for multiple urls in a background-image causing repeated repaints.
https://bugs.webkit.org/show_bug.cgi?id=42390
Change the key of RenderBoxModelObject's LastPaintSizeMap to include
the layer of the element being drawn, so that the same URL used
repeated in the same background-image, or another element's
background-image, can be uniquely identified. The layer is a void
pointer, since it is only used as part of the key and using a
void pointer will discourage dereferencing it. This pointer is NULL
when called from RenderImage (<img> elements).
Covered by fast/backgrounds/size/contain-and-cover.html
* rendering/RenderBoxModelObject.cpp:
(WebCore::ImageQualityController::keyDestroyed):
The old objectDestroyed() is renamed to keyDestroyed().
(WebCore::ImageQualityController::objectDestroyed):
The new objectDestroyed() iterates over all outstanding resizes
to remove any resizes pertaining to this object.
(WebCore::ImageQualityController::highQualityRepaintTimerFired):
Retrieve the RenderBoxModelObject from the pair's "first" member.
(WebCore::ImageQualityController::shouldPaintAtLowQuality):
Create a key from the {object, layer} pair, and use it to access
the repaint size map.
(WebCore::RenderBoxModelObject::shouldPaintAtLowQuality):
Plumb the layer through to the image quality controller.
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
Pass the bgLayer when checking
* rendering/RenderBoxModelObject.h:
Add the void* layer parameter to shouldPaintAtLowQuality.
* rendering/RenderImage.cpp:
(WebCore::RenderImage::paintIntoRect):
Pass 0 (null) for the layer parameter in this case.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72282
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
crogers@google.com [Thu, 18 Nov 2010 11:47:16 +0000 (11:47 +0000)]
2010-11-18 Chris Rogers <crogers@google.com>
Reviewed by Dimitri Glazkov.
Add loadPlatformAudioResource() and decodeAudioFileData() to ChromiumBridge
https://bugs.webkit.org/show_bug.cgi?id=49557
No new tests since audio API is not yet implemented.
* platform/chromium/ChromiumBridge.h:
2010-11-18 Chris Rogers <crogers@google.com>
Reviewed by Dimitri Glazkov.
Add loadPlatformAudioResource() and decodeAudioFileData() to ChromiumBridge
https://bugs.webkit.org/show_bug.cgi?id=49557
* WebKit.gyp:
* public/WebAudioBus.h: Added.
(WebKit::WebAudioBus::WebAudioBus):
* public/WebKitClient.h:
(WebKit::WebKitClient::decodeAudioFileData):
* src/ChromiumBridge.cpp:
(WebCore::ChromiumBridge::loadPlatformAudioResource):
(WebCore::ChromiumBridge::decodeAudioFileData):
* src/WebAudioBus.cpp: Added.
(WebKit::WebAudioBus::~WebAudioBus):
(WebKit::WebAudioBus::initialize):
(WebKit::WebAudioBus::numberOfChannels):
(WebKit::WebAudioBus::length):
(WebKit::WebAudioBus::sampleRate):
(WebKit::WebAudioBus::channelData):
(WebKit::WebAudioBus::release):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72281
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antonm@chromium.org [Thu, 18 Nov 2010 11:26:12 +0000 (11:26 +0000)]
Not reviewed, rebaselining fast/dom/setPrimitiveValue.html
https://bugs.webkit.org/show_bug.cgi?id=49653
* platform/chromium-win/fast/dom/setPrimitiveValue-expected.txt: Removed.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72280
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Thu, 18 Nov 2010 11:13:38 +0000 (11:13 +0000)]
2010-11-18 MORITA Hajime <morrita@google.com>
Unreviewed expectation update.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72279
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Thu, 18 Nov 2010 08:28:43 +0000 (08:28 +0000)]
Update layout test results for bots.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72278
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Thu, 18 Nov 2010 08:17:03 +0000 (08:17 +0000)]
Updates for recent rebaselines and changes.
* platform/chromium-mac/fast/js/regexp-overflow-expected.txt:
* platform/chromium-mac/fast/text/atsui-negative-spacing-features-expected.checksum: Added.
* platform/chromium-mac/fast/text/atsui-negative-spacing-features-expected.png: Added.
* platform/chromium/test_expectations.txt:
* platform/mac/fast/repaint/repaint-across-writing-mode-boundary-expected.txt: The only
non-chromium only change. This started failing when r72235 was landed and only has
some very small pixel placement changes (which is typicaly of other layout test
changes that happened with that change).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72277
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Thu, 18 Nov 2010 06:36:33 +0000 (06:36 +0000)]
2010-11-17 Martin Robinson <mrobinson@igalia.com>
Fix two incorrect GTK+ baselines.
* platform/gtk/fast/css/line-height-determined-by-primary-font-expected.txt:
* platform/gtk/fast/css/negative-leading-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72276
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Thu, 18 Nov 2010 06:32:43 +0000 (06:32 +0000)]
2010-11-17 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] Changing any GNUmakefile.am in the source tree forces a rebuld of the DOM bindings and WebKit APi
https://bugs.webkit.org/show_bug.cgi?id=49400
Move WebKit API build rules out of GNUmakefile.am. These are now in
WebKit/gtk/GNUmakefile.am.
* GNUmakefile.am: Remove WebKit API build rules.
2010-11-17 Martin Robinson <mrobinson@igalia.com>
Reviewed by Gustavo Noronha Silva.
[GTK] Changing any GNUmakefile.am in the source tree forces a rebuld of the DOM bindings and WebKit APi
https://bugs.webkit.org/show_bug.cgi?id=49400
Add GNUmakefile.am and include all WebKit API build rules. Make webkitenum.*
depend on this new file, instead of the generated GNUmakefile.am.
* GNUmakefile.am: Copied from GNUmakefile.am.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72275
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Thu, 18 Nov 2010 05:22:54 +0000 (05:22 +0000)]
Add some test_expectations for failing tests
that need to be investigated and dealt with.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72274
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Thu, 18 Nov 2010 04:54:12 +0000 (04:54 +0000)]
Unreviewed, rolling out r72228.
http://trac.webkit.org/changeset/72228
https://bugs.webkit.org/show_bug.cgi?id=49712
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2010-11-17
Caused many >10 regressions on Win and Linux gpu layout test
runs. (Requested by dave_levin on #webkit).
WebCore:
* html/canvas/WebGLFramebuffer.cpp:
(WebCore::WebGLFramebuffer::onAccess):
(WebCore::WebGLFramebuffer::initializeRenderbuffers):
* html/canvas/WebGLFramebuffer.h:
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::clear):
(WebCore::WebGLRenderingContext::copyTexImage2D):
(WebCore::WebGLRenderingContext::copyTexSubImage2D):
(WebCore::WebGLRenderingContext::drawArrays):
(WebCore::WebGLRenderingContext::drawElements):
(WebCore::WebGLRenderingContext::readPixels):
(WebCore::WebGLRenderingContext::texImage2DBase):
WebKit/chromium:
* src/WebGraphicsContext3DDefaultImpl.cpp:
(WebKit::bytesPerComponent):
(WebKit::componentsPerPixel):
(WebKit::imageSizeInBytes):
(WebKit::WebGraphicsContext3DDefaultImpl::texImage2D):
LayoutTests:
* fast/canvas/webgl/uninitialized-test-expected.txt: Removed.
* fast/canvas/webgl/uninitialized-test.html: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72273
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Thu, 18 Nov 2010 04:33:24 +0000 (04:33 +0000)]
Add some test_expectations for failing tests
that need to be investigated and dealt with.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72272
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Thu, 18 Nov 2010 04:01:57 +0000 (04:01 +0000)]
Unreviewed, rolling out r72243.
http://trac.webkit.org/changeset/72243
https://bugs.webkit.org/show_bug.cgi?id=49710
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2010-11-17
Seemed to cause a large set of Chromium layout test to start
failing. (Requested by dave_levin on #webkit).
* bindings/v8/V8NPUtils.cpp:
(WebCore::convertV8ObjectToNPVariant):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72271
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 18 Nov 2010 02:33:37 +0000 (02:33 +0000)]
Fix Acid3 in Safari for Windows
Reviewed by Dave Hyatt.
* platform/graphics/win/SimpleFontDataWin.cpp:
(WebCore::SimpleFontData::initGDIFont): Initialize all our metrics to 0
if we have a font size of 0.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72270
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 18 Nov 2010 02:30:15 +0000 (02:30 +0000)]
Don't trigger Windows builds when chromium-win test results change
Reviewed by Mark Rowe.
* Scripts/webkitpy/common/config/build.py:
(_should_file_trigger_build): Changed the regular expression used to
search for directory names to only consider full directory names,
rather than matching directory names where the string we care about is
a suffix of the name.
* Scripts/webkitpy/common/config/build_unittest.py:
(ShouldBuildTest): Added a test.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72269
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Thu, 18 Nov 2010 02:19:32 +0000 (02:19 +0000)]
2010-11-17 Mihai Parparita <mihaip@chromium.org>
Update the pixel expectations for fast/tokenizer, fast/transforms, fast/wml, fast/xsl, fonts, scrollbars, svg, transforms, and transitions for the Mac port.
For the tests that currently fail on Snow Leopard with --pixel-tests
--tolerance 0, this moves the current pixel results to mac-leopard and
adds new Snow Leopard-specific results to platform/mac.
List of files omitted due to length but composed entirely of moves from
platform/mac to platform/mac-leopard and newly added files in
platform/mac.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72268
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hayato@chromium.org [Thu, 18 Nov 2010 02:02:37 +0000 (02:02 +0000)]
2010-11-17 Hayato Ito <hayato@chromium.org>
Reviewed by Shinichiro Hamaji.
Remove a uri member from TestInput class.
https://bugs.webkit.org/show_bug.cgi?id=49691
* Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72267
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Thu, 18 Nov 2010 01:41:59 +0000 (01:41 +0000)]
Update chromium results after r72125 and r72173.
* platform/chromium-linux/fast/css/negative-leading-expected.checksum: Added.
* platform/chromium-linux/fast/css/negative-leading-expected.png: Added.
* platform/chromium-linux/fast/forms/linebox-overflow-in-textarea-padding-expected.checksum:
* platform/chromium-linux/fast/forms/linebox-overflow-in-textarea-padding-expected.png:
* platform/chromium-mac/css2.1/t0805-c5518-brdr-t-01-e-expected.checksum: Added.
* platform/chromium-mac/css2.1/t0805-c5518-brdr-t-01-e-expected.png: Added.
* platform/chromium-mac/css2.1/t0805-c5519-brdr-r-00-a-expected.checksum: Added.
* platform/chromium-mac/css2.1/t0805-c5519-brdr-r-00-a-expected.png: Added.
* platform/chromium-mac/css2.1/t0805-c5520-brdr-b-01-e-expected.checksum: Added.
* platform/chromium-mac/css2.1/t0805-c5520-brdr-b-01-e-expected.png: Added.
* platform/chromium-mac/css2.1/t0805-c5521-brdr-l-00-a-expected.checksum: Added.
* platform/chromium-mac/css2.1/t0805-c5521-brdr-l-00-a-expected.png: Added.
* platform/chromium-mac/css2.1/t0805-c5521-brdr-l-01-e-expected.checksum: Added.
* platform/chromium-mac/css2.1/t0805-c5521-brdr-l-01-e-expected.png: Added.
* platform/chromium-mac/css2.1/t0805-c5521-ibrdr-l-00-a-expected.checksum: Added.
* platform/chromium-mac/css2.1/t0805-c5521-ibrdr-l-00-a-expected.png: Added.
* platform/chromium-mac/css2.1/t0905-c414-flt-02-c-expected.checksum: Added.
* platform/chromium-mac/css2.1/t0905-c414-flt-02-c-expected.png: Added.
* platform/chromium-mac/css2.1/t0905-c414-flt-03-c-expected.checksum: Added.
* platform/chromium-mac/css2.1/t0905-c414-flt-03-c-expected.png: Added.
* platform/chromium-mac/css2.1/t0905-c414-flt-04-c-expected.checksum: Added.
* platform/chromium-mac/css2.1/t0905-c414-flt-04-c-expected.png: Added.
* platform/chromium-mac/css2.1/t0905-c414-flt-fit-01-d-g-expected.checksum: Added.
* platform/chromium-mac/css2.1/t0905-c414-flt-fit-01-d-g-expected.png: Added.
* platform/chromium-mac/css2.1/t0905-c5525-fltblck-01-d-expected.checksum: Added.
* platform/chromium-mac/css2.1/t0905-c5525-fltblck-01-d-expected.png: Added.
* platform/chromium-mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.checksum:
* platform/chromium-mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.png: Added.
* platform/chromium-mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum:
* platform/chromium-mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
* platform/chromium-mac/css2.1/t0905-c5525-fltwidth-03-c-g-expected.checksum: Added.
* platform/chromium-mac/css2.1/t0905-c5525-fltwidth-03-c-g-expected.png: Added.
* platform/chromium-mac/css2.1/t090501-c414-flt-01-b-expected.checksum: Added.
* platform/chromium-mac/css2.1/t090501-c414-flt-01-b-expected.png: Added.
* platform/chromium-mac/css2.1/t090501-c414-flt-03-b-g-expected.checksum: Added.
* platform/chromium-mac/css2.1/t090501-c414-flt-03-b-g-expected.png: Added.
* platform/chromium-mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.checksum: Added.
* platform/chromium-mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.png: Added.
* platform/chromium-mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.checksum: Added.
* platform/chromium-mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.png: Added.
* platform/chromium-mac/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.checksum: Added.
* platform/chromium-mac/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.png: Added.
* platform/chromium-mac/css2.1/t1202-counter-03-b-expected.checksum: Added.
* platform/chromium-mac/css2.1/t1202-counter-03-b-expected.png: Added.
* platform/chromium-mac/css2.1/t1202-counter-04-b-expected.checksum: Added.
* platform/chromium-mac/css2.1/t1202-counter-04-b-expected.png: Added.
* platform/chromium-mac/css2.1/t1202-counter-09-b-expected.checksum: Added.
* platform/chromium-mac/css2.1/t1202-counter-09-b-expected.png: Added.
* platform/chromium-mac/css2.1/t1202-counters-03-b-expected.checksum: Added.
* platform/chromium-mac/css2.1/t1202-counters-03-b-expected.png: Added.
* platform/chromium-mac/css2.1/t1202-counters-09-b-expected.checksum:
* platform/chromium-mac/css2.1/t1202-counters-09-b-expected.png:
* platform/chromium-mac/editing/deleting/
5144139-2-expected.checksum: Added.
* platform/chromium-mac/editing/deleting/
5144139-2-expected.png: Added.
* platform/chromium-mac/editing/selection/caret-rtl-expected.checksum: Added.
* platform/chromium-mac/editing/selection/caret-rtl-expected.png: Added.
* platform/chromium-mac/editing/selection/extend-selection-bidi-expected.checksum: Added.
* platform/chromium-mac/editing/selection/extend-selection-bidi-expected.png: Added.
* platform/chromium-mac/fast/css/beforeSelectorOnCodeElement-expected.checksum: Added.
* platform/chromium-mac/fast/css/beforeSelectorOnCodeElement-expected.png: Added.
* platform/chromium-mac/fast/css/font-face-opentype-expected.checksum: Added.
* platform/chromium-mac/fast/css/font-face-opentype-expected.png: Added.
* platform/chromium-mac/fast/css/negative-leading-expected.checksum: Added.
* platform/chromium-mac/fast/css/negative-leading-expected.png: Added.
* platform/chromium-mac/fast/css/rtl-ordering-expected.checksum: Added.
* platform/chromium-mac/fast/css/rtl-ordering-expected.png: Added.
* platform/chromium-mac/fast/css/text-overflow-ellipsis-bidi-expected.checksum: Added.
* platform/chromium-mac/fast/css/text-overflow-ellipsis-bidi-expected.png: Added.
* platform/chromium-mac/fast/css/text-overflow-ellipsis-strict-expected.checksum:
* platform/chromium-mac/fast/css/text-overflow-ellipsis-strict-expected.png:
* platform/chromium-mac/fast/css/text-security-expected.checksum: Added.
* platform/chromium-mac/fast/css/text-security-expected.png: Added.
* platform/chromium-mac/fast/encoding/denormalised-voiced-japanese-chars-expected.checksum: Added.
* platform/chromium-mac/fast/encoding/denormalised-voiced-japanese-chars-expected.png: Added.
* platform/chromium-mac/fast/encoding/invalid-UTF-8-expected.checksum: Added.
* platform/chromium-mac/fast/encoding/invalid-UTF-8-expected.png:
* platform/chromium-mac/fast/forms/linebox-overflow-in-textarea-padding-expected.checksum: Added.
* platform/chromium-mac/fast/forms/linebox-overflow-in-textarea-padding-expected.png: Added.
* platform/chromium-mac/fast/repaint/repaint-across-writing-mode-boundary-expected.checksum:
* platform/chromium-mac/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
* platform/chromium-mac/fast/text/backslash-to-yen-sign-euc-expected.checksum:
* platform/chromium-mac/fast/text/backslash-to-yen-sign-euc-expected.png: Added.
* platform/chromium-mac/fast/text/backslash-to-yen-sign-expected.checksum: Added.
* platform/chromium-mac/fast/text/backslash-to-yen-sign-expected.png: Added.
* platform/chromium-mac/fast/text/bidi-embedding-pop-and-push-same-expected.checksum: Added.
* platform/chromium-mac/fast/text/bidi-embedding-pop-and-push-same-expected.png: Added.
* platform/chromium-mac/fast/text/cg-fallback-bolding-expected.checksum: Added.
* platform/chromium-mac/fast/text/cg-fallback-bolding-expected.png: Added.
* platform/chromium-mac/fast/text/complex-text-opacity-expected.checksum: Added.
* platform/chromium-mac/fast/text/complex-text-opacity-expected.png: Added.
* platform/chromium-mac/fast/text/complex-text-opacity-expected.txt: Added.
* platform/chromium-mac/fast/text/in-rendered-text-rtl-expected.checksum: Added.
* platform/chromium-mac/fast/text/in-rendered-text-rtl-expected.png: Added.
* platform/chromium-mac/fast/text/international/bidi-AN-after-L-expected.checksum: Added.
* platform/chromium-mac/fast/text/international/bidi-AN-after-L-expected.png: Added.
* platform/chromium-mac/fast/text/international/bidi-AN-after-empty-run-expected.checksum: Added.
* platform/chromium-mac/fast/text/international/bidi-AN-after-empty-run-expected.png: Added.
* platform/chromium-mac/fast/text/international/bidi-AN-after-empty-run-expected.txt: Added.
* platform/chromium-mac/fast/text/international/bidi-CS-after-AN-expected.checksum: Added.
* platform/chromium-mac/fast/text/international/bidi-CS-after-AN-expected.png: Added.
* platform/chromium-mac/fast/text/international/bidi-CS-after-AN-expected.txt: Added.
* platform/chromium-mac/fast/text/international/bidi-L2-run-reordering-expected.checksum: Added.
* platform/chromium-mac/fast/text/international/bidi-L2-run-reordering-expected.png: Added.
* platform/chromium-mac/fast/text/international/bidi-LDB-2-CSS-expected.checksum: Added.
* platform/chromium-mac/fast/text/international/bidi-LDB-2-CSS-expected.png: Added.
* platform/chromium-mac/fast/text/international/bidi-LDB-2-HTML-expected.checksum: Added.
* platform/chromium-mac/fast/text/international/bidi-LDB-2-HTML-expected.png: Added.
* platform/chromium-mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.checksum: Added.
* platform/chromium-mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.png: Added.
* platform/chromium-mac/fast/text/international/bidi-european-terminators-expected.checksum: Added.
* platform/chromium-mac/fast/text/international/bidi-european-terminators-expected.png: Added.
* platform/chromium-mac/fast/text/international/bidi-ignored-for-first-child-inline-expected.checksum: Added.
* platform/chromium-mac/fast/text/international/bidi-ignored-for-first-child-inline-expected.png: Added.
* platform/chromium-mac/fast/text/international/bidi-innertext-expected.checksum: Added.
* platform/chromium-mac/fast/text/international/bidi-innertext-expected.png: Added.
* platform/chromium-mac/fast/text/international/bidi-linebreak-001-expected.checksum:
* platform/chromium-mac/fast/text/international/bidi-linebreak-001-expected.png: Added.
* platform/chromium-mac/fast/text/international/bidi-linebreak-002-expected.checksum:
* platform/chromium-mac/fast/text/international/bidi-linebreak-002-expected.png: Added.
* platform/chromium-mac/fast/text/international/bidi-linebreak-003-expected.checksum:
* platform/chromium-mac/fast/text/international/bidi-linebreak-003-expected.png: Added.
* platform/chromium-mac/fast/text/international/bidi-listbox-atsui-expected.checksum: Added.
* platform/chromium-mac/fast/text/international/bidi-listbox-atsui-expected.png: Added.
* platform/chromium-mac/fast/text/international/bidi-listbox-expected.checksum: Added.
* platform/chromium-mac/fast/text/international/bidi-listbox-expected.png: Added.
* platform/chromium-mac/fast/text/international/bidi-mirror-he-ar-expected.checksum:
* platform/chromium-mac/fast/text/international/bidi-mirror-he-ar-expected.png:
* platform/chromium-mac/fast/text/international/bidi-mirror-he-ar-expected.txt:
* platform/chromium-mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.checksum: Added.
* platform/chromium-mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.png: Added.
* platform/chromium-mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt: Added.
* platform/chromium-mac/fast/text/international/bidi-neutral-run-expected.checksum:
* platform/chromium-mac/fast/text/international/bidi-neutral-run-expected.png:
* platform/chromium-mac/fast/text/international/bidi-neutral-run-expected.txt:
* platform/chromium-mac/fast/text/international/bidi-override-expected.checksum: Added.
* platform/chromium-mac/fast/text/international/bidi-override-expected.png: Added.
* platform/chromium-mac/fast/text/international/danda-space-expected.checksum: Added.
* platform/chromium-mac/fast/text/international/danda-space-expected.png: Added.
* platform/chromium-mac/fast/text/international/hindi-spacing-expected.checksum: Added.
* platform/chromium-mac/fast/text/international/hindi-spacing-expected.png: Added.
* platform/chromium-mac/fast/text/international/hindi-whitespace-expected.checksum:
* platform/chromium-mac/fast/text/international/hindi-whitespace-expected.png:
* platform/chromium-mac/fast/text/international/plane2-expected.checksum: Added.
* platform/chromium-mac/fast/text/international/plane2-expected.png: Added.
* platform/chromium-mac/fast/text/international/rtl-caret-expected.checksum: Added.
* platform/chromium-mac/fast/text/international/rtl-caret-expected.png: Added.
* platform/chromium-mac/fast/text/international/thai-baht-space-expected.checksum: Added.
* platform/chromium-mac/fast/text/international/thai-baht-space-expected.png: Added.
* platform/chromium-mac/fast/text/international/thai-baht-space-expected.txt: Added.
* platform/chromium-mac/fast/text/international/wrap-CJK-001-expected.checksum: Added.
* platform/chromium-mac/fast/text/international/wrap-CJK-001-expected.png: Added.
* platform/chromium-win/fast/compact/001-expected.txt:
* platform/chromium-win/fast/css/negative-leading-expected.checksum: Added.
* platform/chromium-win/fast/css/negative-leading-expected.png: Added.
* platform/chromium-win/fast/css/negative-leading-expected.txt: Added.
* platform/chromium-win/fast/forms/linebox-overflow-in-textarea-padding-expected.checksum:
* platform/chromium-win/fast/forms/linebox-overflow-in-textarea-padding-expected.png:
* platform/chromium-win/fast/forms/linebox-overflow-in-textarea-padding-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72266
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 18 Nov 2010 01:30:05 +0000 (01:30 +0000)]
Move FindSafari's settings into a vsprops file
Fixes <http://webkit.org/b/49699> FindSafari should use a vsprops file
Reviewed by Steve Falkenburg.
* FindSafari/FindSafari.vcproj:
* FindSafari/FindSafariCommon.vsprops: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72265
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 18 Nov 2010 01:16:30 +0000 (01:16 +0000)]
Use a minimum font size of 0 in DRT on Windows
This is the Windows equivalent of r72164.
Rubber-stamped by Dave Hyatt.
* DumpRenderTree/win/DumpRenderTree.cpp:
(resetDefaultsToConsistentValues):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72264
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Thu, 18 Nov 2010 01:10:23 +0000 (01:10 +0000)]
2010-11-17 Dirk Pranke <dpranke@chromium.org>
Reviewed by Andreas Kling.
webkit-patch pretty-diff shouldn't need to be run from a checkout root in git
https://bugs.webkit.org/show_bug.cgi?id=49639
* Scripts/webkitpy/common/checkout/scm.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72263
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Thu, 18 Nov 2010 00:42:24 +0000 (00:42 +0000)]
2010-11-17 Mihai Parparita <mihaip@chromium.org>
Reviewed by Tony Chang.
Rebaseline server: add loupe for image diffs
https://bugs.webkit.org/show_bug.cgi?id=49692
Add a loupe (magnifiying glass) for inspecting image diffs. Shows an
enlarged area of the expected, actual and diff images side by side.
* Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
* Scripts/webkitpy/tool/commands/data/rebaselineserver/loupe.js: Added.
* Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
* Scripts/webkitpy/tool/commands/rebaselineserver.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72262
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Thu, 18 Nov 2010 00:24:41 +0000 (00:24 +0000)]
2010-11-17 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam Roben.
WebKitLauncherWin should use vsprops for shared build settings
https://bugs.webkit.org/show_bug.cgi?id=49696
* WebKitLauncherWin/WebKitLauncherWin.vcproj:
* WebKitLauncherWin/WebKitLauncherWinCommon.vsprops: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72261
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Thu, 18 Nov 2010 00:21:26 +0000 (00:21 +0000)]
Unreviewed build fix. Touch precompiled header to force rebuild.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72260
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Thu, 18 Nov 2010 00:20:10 +0000 (00:20 +0000)]
Converge means of querying a parent node into one way, which is Node::parentNode.
https://bugs.webkit.org/show_bug.cgi?id=49686
Reviewed by Darin Adler.
WebCore:
No change in behavior, so no new tests.
* accessibility/AccessibilityObject.cpp:
(WebCore::renderListItemContainerForNode): Changed to use parentNode.
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::mouseButtonListener): Ditto.
(WebCore::siblingWithAriaRole): Ditto.
(WebCore::AccessibilityRenderObject::getDocumentLinks): Ditto.
(WebCore::AccessibilityRenderObject::accessibilityImageMapHitTest): Ditto.
* accessibility/mac/AccessibilityObjectWrapper.mm: Ditto.
(blockquoteLevel): Ditto.
* bindings/v8/V8GCController.cpp:
(WebCore::ObjectGrouperVisitor::visitDOMWrapper): Ditto.
* dom/ContainerNode.cpp: Ditto.
(WebCore::ContainerNode::insertBefore): Ditto.
(WebCore::ContainerNode::insertBeforeCommon): Ditto.
(WebCore::ContainerNode::replaceChild): Ditto.
(WebCore::ContainerNode::removeChild): Ditto.
(WebCore::ContainerNode::appendChild): Ditto.
(WebCore::ContainerNode::parserAddChild): Ditto.
* dom/DocumentType.cpp:
(WebCore::DocumentType::insertedIntoDocument): Ditto.
* dom/Element.cpp:
(WebCore::Element::computeInheritedLanguage): Ditto.
* dom/MouseRelatedEvent.cpp:
(WebCore::MouseRelatedEvent::receivedTarget): Ditto.
* dom/Position.cpp:
(WebCore::Position::isCandidate): Changed to use parentNode.
* dom/PositionIterator.cpp:
(WebCore::PositionIterator::isCandidate): Ditto.
* editing/AppendNodeCommand.cpp:
(WebCore::AppendNodeCommand::AppendNodeCommand): Ditto.
* editing/ApplyStyleCommand.cpp:
(WebCore::dummySpanAncestorForNode): Ditto.
(WebCore::ApplyStyleCommand::splitAncestorsWithUnicodeBidi): Ditto.
(WebCore::ApplyStyleCommand::removeEmbeddingUpToEnclosingBlock): Ditto.
(WebCore::highestEmbeddingAncestor): Ditto.
(WebCore::ApplyStyleCommand::splitTextElementAtEnd): Ditto.
(WebCore::ApplyStyleCommand::mergeStartWithPreviousIfIdentical): Ditto.
(WebCore::ApplyStyleCommand::mergeEndWithNextIfIdentical): Ditto.
* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::splitTreeToNode): Ditto.
* editing/DeleteSelectionCommand.cpp:
(WebCore::updatePositionForNodeRemoval): Ditto.
* editing/Editor.cpp:
(WebCore::Editor::textDirectionForSelection): Ditto.
* editing/MergeIdenticalElementsCommand.cpp:
(WebCore::MergeIdenticalElementsCommand::doUnapply): Ditto.
* editing/htmlediting.cpp:
(WebCore::isEmptyTableCell): Ditto.
* editing/markup.cpp:
(WebCore::StyledMarkupAccumulator::serializeNodes): Ditto.
* editing/visible_units.cpp:
(WebCore::previousLinePosition): Ditto.
(WebCore::nextLinePosition): Ditto.
* html/HTMLAreaElement.cpp:
(WebCore::HTMLAreaElement::imageElement): Ditto.
* html/HTMLElement.cpp:
(WebCore::HTMLElement::setOuterHTML): Ditto.
(WebCore::HTMLElement::insertAdjacent): Ditto.
(WebCore::HTMLElement::supportsFocus): Ditto.
* html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::insertedIntoDocument): Ditto.
(WebCore::HTMLEmbedElement::attributeChanged): Ditto.
* html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::insertRow): Ditto.
* html/HTMLTableRowsCollection.cpp: Ditto.
(WebCore::isInHead): Ditto.
(WebCore::isInBody): Ditto.
(WebCore::isInFoot): Ditto.
(WebCore::HTMLTableRowsCollection::rowAfter): Ditto.
* html/HTMLViewSourceDocument.cpp:
(WebCore::HTMLViewSourceDocument::addRange): Ditto.
* html/MediaDocument.cpp:
(WebCore::MediaDocument::replaceMediaElementTimerFired): Ditto.
* html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::attach): Ditto.
(WebCore::HTMLConstructionSite::findFosterSite): Ditto.
* html/parser/HTMLTreeBuilder.cpp:
* page/FocusController.cpp:
(WebCore::FocusController::findFocusableNodeInDirection): Ditto.
* rendering/MediaControlElements.cpp:
(WebCore::MediaControlElement::rendererIsNeeded): Ditto.
(WebCore::MediaControlElement::attach): Ditto.
(WebCore::MediaControlElement::updateStyle): Ditto.
(WebCore::MediaControlInputElement::rendererIsNeeded): Ditto.
(WebCore::MediaControlInputElement::attach): Ditto.
(WebCore::MediaControlInputElement::updateStyle): Ditto.
* rendering/RenderSVGGradientStop.cpp:
(WebCore::RenderSVGGradientStop::gradientElement): Ditto.
* svg/SVGAElement.cpp:
(WebCore::SVGAElement::createRenderer): Ditto.
(WebCore::SVGAElement::childShouldCreateRenderer): Ditto.
* svg/SVGFELightElement.cpp:
(WebCore::SVGFELightElement::svgAttributeChanged): Ditto.
(WebCore::SVGFELightElement::childrenChanged): Ditto.
* svg/SVGFEMergeNodeElement.cpp:
(WebCore::SVGFEMergeNodeElement::svgAttributeChanged): Ditto.
* svg/SVGLength.cpp:
(WebCore::SVGLength::determineViewport): Ditto.
* svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::updateRelativeLengthsInformation): Ditto.
* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::removeDisallowedElementsFromSubtree): Ditto.
* svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::insertedIntoDocument): Ditto.
* xml/XPathNodeSet.cpp:
(WebCore::XPath::NodeSet::sort): Ditto.
* xml/XPathStep.cpp:
(WebCore::XPath::Step::nodesInAxis): Ditto.
* xml/XSLTProcessorLibxslt.cpp:
(WebCore::xsltStylesheetPointer): Ditto.
WebKit/chromium:
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::insertStyleText): Changed to use parentNode.
(WebKit::WebFrameImpl::setFindEndstateFocusAndSelection): Ditto.
WebKit/qt:
* Api/qwebelement.cpp:
(QWebElement::prependOutside): Changed to use parentNode.
(QWebElement::appendOutside): Ditto.
(QWebElement::encloseContentsWith): Ditto.
(QWebElement::encloseWith): Ditto.
WebKit2:
* WebProcess/WebPage/WebPage.cpp: Changed to use parentNode.
(WebKit::WebPage::findZoomableAreaForPoint): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72259
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Thu, 18 Nov 2010 00:08:24 +0000 (00:08 +0000)]
2010-11-17 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam Roben.
WinLauncher should use vsprops for shared build settings
https://bugs.webkit.org/show_bug.cgi?id=49695
* WinLauncher/WinLauncher.cpp:
(_tWinMain):
(PrintView):
(WndProc):
(MyEditProc):
* WinLauncher/WinLauncher.vcproj:
* WinLauncher/WinLauncherCommon.vsprops: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72258
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aestes@apple.com [Thu, 18 Nov 2010 00:06:05 +0000 (00:06 +0000)]
Create Leopard-specific results for tests that differ between Leopard
and Snow Leopard due to r72173.
* platform/mac-leopard/platform/mac/editing: Added.
* platform/mac-leopard/platform/mac/editing/input: Added.
* platform/mac-leopard/platform/mac/editing/input/devanagari-ligature-expected.txt: Added.
* platform/mac-leopard/platform/mac/svg: Added.
* platform/mac-leopard/platform/mac/svg/batik: Added.
* platform/mac-leopard/platform/mac/svg/batik/text: Added.
* platform/mac-leopard/platform/mac/svg/batik/text/smallFonts-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72257
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aestes@apple.com [Wed, 17 Nov 2010 23:58:30 +0000 (23:58 +0000)]
Add Leopard-specific results for r72173.
* platform/mac-leopard/css2.1/t1202-counter-04-b-expected.txt:
* platform/mac-leopard/css2.1/t1202-counters-04-b-expected.txt:
* platform/mac-leopard/fast/text/complex-text-opacity-expected.txt:
* platform/mac-leopard/fast/text/international/bidi-AN-after-L-expected.txt:
* platform/mac-leopard/fast/text/international/bidi-AN-after-empty-run-expected.txt:
* platform/mac-leopard/fast/text/international/bidi-CS-after-AN-expected.txt:
* platform/mac-leopard/fast/text/international/bidi-mirror-he-ar-expected.txt:
* platform/mac-leopard/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt:
* platform/mac-leopard/fast/text/international/bidi-neutral-run-expected.txt:
* platform/mac-leopard/fast/text/international/thai-baht-space-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72256
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Wed, 17 Nov 2010 23:57:31 +0000 (23:57 +0000)]
2010-11-17 Tony Chang <tony@chromium.org>
Unreviewed, add chromium-win baselines for fast/text/atsui-negative-spacing-features.html.
* platform/chromium-win/fast/text/atsui-negative-spacing-features-expected.checksum: Added.
* platform/chromium-win/fast/text/atsui-negative-spacing-features-expected.png: Added.
* platform/chromium-win/fast/text/atsui-negative-spacing-features-expected.txt: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72255
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Wed, 17 Nov 2010 23:41:36 +0000 (23:41 +0000)]
2010-11-17 Tony Chang <tony@chromium.org>
Unreviewed, skip atsui-negative-spacing-features.html on qt and
gtk since the other atsui tests are skipped.
* platform/gtk/Skipped:
* platform/qt/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72254
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Wed, 17 Nov 2010 23:37:04 +0000 (23:37 +0000)]
2010-11-17 Kenneth Rohde Christiansen <kenneth@webkit.org>
Reviewed by Andreas Kling.
ScrollView: Don't translate by scrollX/scrollY or clip when paintsEntireContents()
This makes paint() with paintEntireContents() do exactly what it's supposed to:
paint from 0,0 to contentsSize().
The clipping was a no-op anyway since visibleContentRect() will return the whole
rect in paintsEntireContents() mode.
* platform/ScrollView.cpp:
(WebCore::ScrollView::paint):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72253
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Wed, 17 Nov 2010 23:19:00 +0000 (23:19 +0000)]
2010-11-17 Kenneth Rohde Christansen <kenneth@webkit.org>
Reviewed by Andreas Kling.
ScrollView: Update the actualVisibleContentRect after delegating a scroll.
This lets us avoid updating the actualVisibleContentRect from the client
after each scroll. We had to do this synchronously for WebKit2 to support
programmatic "animated scrolling" from JS.
* platform/ScrollView.cpp:
(WebCore::ScrollView::setScrollPosition):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72252
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Wed, 17 Nov 2010 23:18:53 +0000 (23:18 +0000)]
Delete unused file unintentionally added in last change.
* DumpRenderTree/win/DumpRenderTreeCURL.vsprops: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72251
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Wed, 17 Nov 2010 23:16:26 +0000 (23:16 +0000)]
DumpRenderTree on Windows should use a vsprops file for shared project settings
https://bugs.webkit.org/show_bug.cgi?id=49690
Reviewed by Adam Roben.
* DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
* DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePluginCommon.vsprops: Added.
* DumpRenderTree/win/DumpRenderTree.vcproj:
* DumpRenderTree/win/DumpRenderTreeApple.vsprops: Added.
* DumpRenderTree/win/DumpRenderTreeCFLite.vsprops: Added.
* DumpRenderTree/win/DumpRenderTreeCURL.vsprops: Added.
* DumpRenderTree/win/DumpRenderTreeCairo.vsprops: Added.
* DumpRenderTree/win/DumpRenderTreeCommon.vsprops: Added.
* DumpRenderTree/win/ImageDiff.vcproj:
* DumpRenderTree/win/ImageDiffCommon.vsprops: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72250
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hayato@chromium.org [Wed, 17 Nov 2010 23:02:39 +0000 (23:02 +0000)]
2010-11-17 Hayato Ito <hayato@chromium.org>
Refactor TestTypeBase.compare_output().
Introduce a TestOutput class and update compare_output() of each test
types so that they can take both actual and expected TestOutput objects.
https://bugs.webkit.org/show_bug.cgi?id=49431
* Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
* Scripts/webkitpy/layout_tests/layout_package/test_output.py: Added.
* Scripts/webkitpy/layout_tests/port/base.py:
* Scripts/webkitpy/layout_tests/port/chromium.py:
* Scripts/webkitpy/layout_tests/port/dryrun.py:
* Scripts/webkitpy/layout_tests/port/test.py:
* Scripts/webkitpy/layout_tests/port/webkit.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
* Scripts/webkitpy/layout_tests/test_types/image_diff.py:
* Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
* Scripts/webkitpy/layout_tests/test_types/text_diff.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72249
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Wed, 17 Nov 2010 22:57:43 +0000 (22:57 +0000)]
2010-11-17 Andreas Kling <kling@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
ScrollView: Decouple actualVisibleContentRect from visibleContentRect
Added actualVisibleContentRect() which will return the override provided
by setActualVisibleContentRect() or fall back to visibleContentRect()
if no override has been set.
This is similar to what the iPhone does.
* platform/ScrollView.cpp:
(WebCore::ScrollView::visibleContentRect):
* platform/ScrollView.h:
(WebCore::ScrollView::actualVisibleContentRect):
(WebCore::ScrollView::setActualVisibleContentRect): IntRect -> const IntRect&
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72248
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Wed, 17 Nov 2010 22:46:48 +0000 (22:46 +0000)]
Remove duplicate Web Inspector message handeling in WebPage::didReceiveMessage.
https://webkit.org/b/49689
Reviewed by Andreas Kling.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didReceiveMessage): Remove duplicate code.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72247
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Wed, 17 Nov 2010 22:46:34 +0000 (22:46 +0000)]
Fix a crash when closing the inspected page when the Web Inspector
page was never created.
https://bugs.webkit.org/show_bug.cgi?id=49687
Reviewed by John Sullivan.
* WebProcess/WebCoreSupport/WebInspectorClient.cpp:
(WebKit::WebInspectorClient::sendMessageToFrontend): Null check the Inspector WebPage.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72246
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Wed, 17 Nov 2010 22:37:15 +0000 (22:37 +0000)]
Make each Windows Test builder use the same OS for all its slaves
Currently each WebKit1 Windows Test builder has one Windows XP slave
and one Windows 7 slave. Having different OSes in a single builder
meant that the builders would alternate between red and green when
there were OS-specific failures.
Fixes <http://webkit.org/b/49688> Windows Test builders alternate
between red and green because of multiple OS versions
Reviewed by Mark Rowe.
* BuildSlaveSupport/build.webkit.org-config/config.json: Renamed
"Windows Release (Tests)" to "Windows 7 Release (Tests)", "Windows
Debug (Tests)" to "Windows XP Debug (Tests)", and "Windows Release
(WebKit2 Tests)" to "Windows 7 Release (WebKit2 Tests)". Updated the
builders for the two WebKit1 builders so that they would all use the
appropriate OS.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72245
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Wed, 17 Nov 2010 22:33:55 +0000 (22:33 +0000)]
2010-11-17 Tony Chang <tony@chromium.org>
Unreviewed, adding windows baseline for
fast/text/atsui-negative-spacing-features.html
* platform/win/fast/text/atsui-negative-spacing-features-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72244
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Wed, 17 Nov 2010 22:16:26 +0000 (22:16 +0000)]
2010-11-17 Tony Chang <tony@chromium.org>
Reviewed by Adam Barth.
[chromium] fix get-int-identifier-special-values.html using TestNetscapePlugIn
https://bugs.webkit.org/show_bug.cgi?id=49036
No new tests: Covered by plugins/npruntime/get-int-identifier-special-values.html
In http://codereview.chromium.org/11574, the forked chromium test
plugin changed how it testGetIntIdentifier to work around a change
caused by a silverlight specific plugin fix:
http://codereview.chromium.org/11569/diff/1/2
It's not clear to me that this change is needed anymore since
silverlight has had multiple releases, testing without this patch
works on a test windows build, and safari win seems to run silverlight
without this either. Since there's no test for this behavior, I'm
rolling it out so we can match the upstream test.
* bindings/v8/V8NPUtils.cpp:
(WebCore::convertV8ObjectToNPVariant):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72243
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Wed, 17 Nov 2010 22:02:28 +0000 (22:02 +0000)]
2010-11-17 Andreas Kling <kling@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
ScrollView: Let visibleContentRect() return the contentsSize() if paintsEntireContents()
* platform/ScrollView.cpp:
(WebCore::ScrollView::visibleContentRect):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72242
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 17 Nov 2010 21:57:32 +0000 (21:57 +0000)]
Don't crash when invalidating a page overlay that hasn't been installed yet
https://bugs.webkit.org/show_bug.cgi?id=49685
Reviewed by John Sullivan.
Null check the web page.
* WebProcess/WebPage/PageOverlay.cpp:
(WebKit::PageOverlay::setNeedsDisplay):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72241
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Wed, 17 Nov 2010 21:36:36 +0000 (21:36 +0000)]
2010-11-17 Tony Chang <tony@chromium.org>
Unreviewed, css variable support was removed in r72116.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72240
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Wed, 17 Nov 2010 21:29:33 +0000 (21:29 +0000)]
2010-11-17 James Simonsen <simonjam@chromium.org>
Reviewed by Tony Chang.
[chromium] Fix negative letter spacing in complex text on linux
https://bugs.webkit.org/show_bug.cgi?id=49563
* fast/text/atsui-negative-spacing-features.html: Added.
* platform/chromium-linux/fast/text/atsui-negative-spacing-features-expected.checksum: Added.
* platform/chromium-linux/fast/text/atsui-negative-spacing-features-expected.png: Added.
* platform/chromium-linux/fast/text/atsui-negative-spacing-features-expected.txt: Added.
* platform/mac/fast/text/atsui-negative-spacing-features-expected.checksum: Added.
* platform/mac/fast/text/atsui-negative-spacing-features-expected.png: Added.
* platform/mac/fast/text/atsui-negative-spacing-features-expected.txt: Added.
2010-11-17 James Simonsen <simonjam@chromium.org>
Reviewed by Tony Chang.
[chromium] Fix negative letter spacing in complex text on linux
https://bugs.webkit.org/show_bug.cgi?id=49563
Test: fast/text/atsui-negative-spacing-features.html
* platform/graphics/chromium/FontLinux.cpp: Make spacing signed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72239
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Wed, 17 Nov 2010 21:16:11 +0000 (21:16 +0000)]
2010-11-17 Andreas Kling <kling@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
ScrollView: Avoid unnecessary work in setScrollPosition() when scrolling is delegated.
* platform/ScrollView.cpp:
(WebCore::ScrollView::setScrollPosition): If delegatesScrolling(), we never use the
newScrollPosition, so move that calculation below the delegation path.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72238
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Wed, 17 Nov 2010 21:02:35 +0000 (21:02 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=49682 - Expose "removeItemAtIndex" in WKMutableArray
Reviewed by Darin Adler.
* Shared/API/c/WKMutableArray.cpp:
(WKArrayRemoveItemAtIndex):
* Shared/API/c/WKMutableArray.h:
* Shared/MutableArray.cpp:
(WebKit::MutableArray::removeItemAtIndex):
* Shared/MutableArray.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72237
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Wed, 17 Nov 2010 21:01:59 +0000 (21:01 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=49683 - Export WKContextMenuItem and WKContextMenuItemTypes as public headers
Reviewed by Anders Carlsson.
* WebKit2.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72236
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Wed, 17 Nov 2010 20:55:40 +0000 (20:55 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=48537
Reviewed by Sam Weinig.
WebCore:
Fonts with no vertical metrics should synthesize baselines when they appear
on lines that do use fonts with vertical metrics. Basically we want to make
sure that English text behaves like vertical-align:middle, i.e., its baseline
should be treated as though it cuts through the middle of the ascent+descent.
The way this works is that each line in the line box tree is labeled as having
a baseline type that is either ideographic or alphabetic for the purposes of
vertical alignment. A line becomes ideographic if any font with vertical tables
is either explicitly specified as the primary font or in any of the used fonts
in the text on that line.
This baselineType is passed down to computeLogicalBoxHeights and placeBoxesInBlockDirection,
and passed to the ascent and descent methods of the fonts that are examined.
The underlying Font code selects an appropriate baseline given the type passed in.
This patch also rewrites vertical alignment to lop 4 bytes off all RenderInlines and
to instead carry around the cached vertical positions for RenderInlines in a new
VerticalPositionCache object. This cache only lives for a single layout
operation, but it does cache information across all the lines built and placed during the
layout.
This matches the old behavior, since every call to layoutInlineChildren invalidated
all of the vertical positions in all of the RenderInlines anyway.
The VerticalPositionCache consists of two HashMaps, and it caches vertical alignment
positions for both alphabetic and ideographic baseline types.
The vertical-align computation has now been moved out of RenderBoxModelObject and
RenderInline and just placed right into verticalPositionForBox in InlineFlowBox.
This function has been changed to no longer be recursive when checking parents,
and it now relies on the fact that the parent vertical alignment computation result
has already been stored in the logicalTop() of that parent's line box. By checking
the line box logicalTop() value instead of recurring, the performance of first lines
now significantly improves to no longer have O(n^2) behavior in the depth of the line
box tree on the first line.
All of the baselinePosition functions on the various RenderObjects have been amended
to take a FontBaseline as the first argument. This patch does not attempt to fix up
MathML or form controls yet and just hardcodes AlphabeticBaselines for those renderers.
The RenderTableCell baselinePosition virtual method has been made non-virtual and had
all arguments removed, since it actually had no real connection with the rest of the
baseline positioning system. Cell baseline positioning works by calling firstLineBoxBaseline,
and that method has been patched to use the cached baselineType for the first line box
when computing the baseline of that line.
Added fast/blockflow/vertical-baseline-alignment.html and fast/blockflow/vertical-align-table-baseline.html.
* WebCore.xcodeproj/project.pbxproj:
* mathml/RenderMathMLFraction.cpp:
(WebCore::RenderMathMLFraction::baselinePosition):
* mathml/RenderMathMLFraction.h:
* mathml/RenderMathMLOperator.cpp:
(WebCore::RenderMathMLOperator::baselinePosition):
* mathml/RenderMathMLOperator.h:
* mathml/RenderMathMLRow.cpp:
(WebCore::RenderMathMLRow::baselinePosition):
* mathml/RenderMathMLRow.h:
* mathml/RenderMathMLSubSup.cpp:
(WebCore::RenderMathMLSubSup::baselinePosition):
* mathml/RenderMathMLSubSup.h:
* mathml/RenderMathMLUnderOver.cpp:
(WebCore::RenderMathMLUnderOver::layout):
(WebCore::RenderMathMLUnderOver::baselinePosition):
* mathml/RenderMathMLUnderOver.h:
* platform/graphics/SimpleFontData.h:
* rendering/InlineBox.h:
(WebCore::InlineBox::baselinePosition):
* rendering/InlineFlowBox.cpp:
(WebCore::verticalPositionForBox):
(WebCore::InlineFlowBox::computeLogicalBoxHeights):
(WebCore::InlineFlowBox::placeBoxesInBlockDirection):
* rendering/InlineFlowBox.h:
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::baselinePosition):
* rendering/InlineTextBox.h:
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::baselinePosition):
(WebCore::RenderBlock::firstLineBoxBaseline):
(WebCore::RenderBlock::lastLineBoxBaseline):
* rendering/RenderBlock.h:
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::computeBlockDirectionPositionsForLine):
(WebCore::RenderBlock::layoutInlineChildren):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::baselinePosition):
* rendering/RenderBox.h:
* rendering/RenderBoxModelObject.cpp:
* rendering/RenderBoxModelObject.h:
* rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::paintObject):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::RenderInline):
(WebCore::RenderInline::baselinePosition):
* rendering/RenderInline.h:
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::baselinePosition):
* rendering/RenderListBox.h:
* rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::baselinePosition):
* rendering/RenderListMarker.h:
* rendering/RenderSlider.cpp:
(WebCore::RenderSlider::baselinePosition):
* rendering/RenderSlider.h:
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::baselinePosition):
* rendering/RenderTableCell.h:
* rendering/RenderTextControlMultiLine.cpp:
(WebCore::RenderTextControlMultiLine::baselinePosition):
* rendering/RenderTextControlMultiLine.h:
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::alignBoxesInBlockDirection):
* rendering/RootInlineBox.h:
(WebCore::RootInlineBox::baselinePosition):
* rendering/VerticalPositionCache.h: Added.
(WebCore::VerticalPositionCache::VerticalPositionCache):
(WebCore::VerticalPositionCache::get):
(WebCore::VerticalPositionCache::set):
* rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::calculateBoundaries):
LayoutTests:
Fonts with no vertical metrics should synthesize baselines when they appear
on lines that do use fonts with vertical metrics. Basically we want to make
sure that English text behaves like vertical-align:middle, i.e., its baseline
should be treated as though it cuts through the middle of the ascent+descent.
The way this works is that each line in the line box tree is labeled as having
a baseline type that is either ideographic or alphabetic for the purposes of
vertical alignment. A line becomes ideographic if any font with vertical tables
is either explicitly specified as the primary font or in any of the used fonts
in the text on that line.
This baselineType is passed down to computeLogicalBoxHeights and placeBoxesInBlockDirection,
and passed to the ascent and descent methods of the fonts that are examined.
The underlying Font code selects an appropriate baseline given the type passed in.
This patch also rewrites vertical alignment to lop 4 bytes off all RenderInlines and
to instead carry around the cached vertical positions for RenderInlines in a new
VerticalPositionCache object. This cache only lives for a single layout
operation, but it does cache information across all the lines built and placed during the
layout.
This matches the old behavior, since every call to layoutInlineChildren invalidated
all of the vertical positions in all of the RenderInlines anyway.
The VerticalPositionCache consists of two HashMaps, and it caches vertical alignment
positions for both alphabetic and ideographic baseline types.
The vertical-align computation has now been moved out of RenderBoxModelObject and
RenderInline and just placed right into verticalPositionForBox in InlineFlowBox.
This function has been changed to no longer be recursive when checking parents,
and it now relies on the fact that the parent vertical alignment computation result
has already been stored in the logicalTop() of that parent's line box. By checking
the line box logicalTop() value instead of recurring, the performance of first lines
now significantly improves to no longer have O(n^2) behavior in the depth of the line
box tree on the first line.
All of the baselinePosition functions on the various RenderObjects have been amended
to take a FontBaseline as the first argument. This patch does not attempt to fix up
MathML or form controls yet and just hardcodes AlphabeticBaselines for those renderers.
The RenderTableCell baselinePosition virtual method has been made non-virtual and had
all arguments removed, since it actually had no real connection with the rest of the
baseline positioning system. Cell baseline positioning works by calling firstLineBoxBaseline,
and that method has been patched to use the cached baselineType for the first line box
when computing the baseline of that line.
Added fast/blockflow/vertical-baseline-alignment.html and fast/blockflow/vertical-align-table-baseline.html
* fast/blockflow/vertical-align-table-baseline.html: Added.
* fast/blockflow/vertical-baseline-alignment.html: Added.
* platform/mac/fast/blockflow/vertical-align-table-baseline-expected.checksum: Added.
* platform/mac/fast/blockflow/vertical-align-table-baseline-expected.png: Added.
* platform/mac/fast/blockflow/vertical-align-table-baseline-expected.txt: Added.
* platform/mac/fast/blockflow/vertical-baseline-alignment-expected.checksum: Added.
* platform/mac/fast/blockflow/vertical-baseline-alignment-expected.png: Added.
* platform/mac/fast/blockflow/vertical-baseline-alignment-expected.txt: Added.
* platform/mac/fast/blockflow/vertical-font-fallback-expected.checksum:
* platform/mac/fast/blockflow/vertical-font-fallback-expected.png:
* platform/mac/fast/blockflow/vertical-font-fallback-expected.txt:
* platform/mac/fast/repaint/repaint-across-writing-mode-boundary-expected.checksum:
* platform/mac/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
* platform/mac/fast/repaint/repaint-across-writing-mode-boundary-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72235
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 17 Nov 2010 20:52:33 +0000 (20:52 +0000)]
Need way to invalidate part of a WKOverlayRef so it will be redrawn
https://bugs.webkit.org/show_bug.cgi?id=49679
<rdar://problem/
8679152>
Reviewed by Darin Adler.
* WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.cpp:
(WKBundlePageOverlaySetNeedsDisplay):
* WebProcess/InjectedBundle/API/c/WKBundlePageOverlay.h:
* WebProcess/WebPage/PageOverlay.cpp:
(WebKit::PageOverlay::setNeedsDisplay):
* WebProcess/WebPage/PageOverlay.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72234
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Wed, 17 Nov 2010 20:48:34 +0000 (20:48 +0000)]
2010-11-17 James Robinson <jamesr@chromium.org>
Reviewed by Dan Bernstein.
[chromium] Set minimum font size to 0 for DRT
https://bugs.webkit.org/show_bug.cgi?id=49677
Followup for http://trac.webkit.org/changeset/72141.
Test: http/tests/misc/acid3.html
* DumpRenderTree/chromium/WebPreferences.cpp:
(WebPreferences::reset):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72233
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Wed, 17 Nov 2010 20:47:45 +0000 (20:47 +0000)]
Add stubbed out ScrollAnimator for the Mac
https://bugs.webkit.org/show_bug.cgi?id=49678
Reviewed by Anders Carlsson.
JavaScriptCore:
* wtf/Platform.h: Enable SMOOTH_SCROLLING on the Mac, this has no
change in behavior at the moment.
WebCore:
* WebCore.xcodeproj/project.pbxproj:
Add ScrollAnimator.h/cpp.
* platform/mac/ScrollAnimatorMac.cpp: Added.
(WebCore::ScrollAnimator::create):
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::~ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::scroll):
(WebCore::ScrollAnimatorMac::setScrollPositionAndStopAnimation):
* platform/mac/ScrollAnimatorMac.h: Added.
ScrollAnimatorMac just calls through to the base class for now.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72232
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Wed, 17 Nov 2010 20:31:22 +0000 (20:31 +0000)]
2010-11-17 Martin Robinson <mrobinson@igalia.com>
Update the skipped list to skip a newly failing geolocation test (requires
geolocation mock support). Organize geolocation test failures a bit better.
Add results for two new tests.
* platform/gtk/Skipped: Update skipped list.
* platform/gtk/fast/css/line-height-determined-by-primary-font-expected.txt: Added.
* platform/gtk/fast/css/negative-leading-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72231
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
inferno@chromium.org [Wed, 17 Nov 2010 20:11:56 +0000 (20:11 +0000)]
2010-11-17 Cris Neckar <cdn@chromium.org>
Reviewed by Adam Barth.
Modified codepath for object fallback content which has failed to load.
Refactored CachedResource error handling to use more granular statuses instead of a boolean value.
https://bugs.webkit.org/show_bug.cgi?id=46921
Test: fast/html/object-image-nested-fallback.html
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::renderFallbackContent):
* loader/cache/CachedCSSStyleSheet.cpp:
(WebCore::CachedCSSStyleSheet::error):
* loader/cache/CachedCSSStyleSheet.h:
* loader/cache/CachedFont.cpp:
(WebCore::CachedFont::ensureCustomFontData):
(WebCore::CachedFont::error):
* loader/cache/CachedFont.h:
* loader/cache/CachedImage.cpp:
(WebCore::CachedImage::data):
(WebCore::CachedImage::error):
* loader/cache/CachedImage.h:
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::CachedResource):
(WebCore::CachedResource::canUseCacheValidator):
(WebCore::CachedResource::mustRevalidate):
* loader/cache/CachedResource.h:
(WebCore::CachedResource::error):
(WebCore::CachedResource::httpStatusCodeError):
(WebCore::CachedResource::errorOccurred):
* loader/cache/CachedScript.cpp:
(WebCore::CachedScript::error):
* loader/cache/CachedScript.h:
* loader/cache/CachedXSLStyleSheet.cpp:
(WebCore::CachedXSLStyleSheet::error):
* loader/cache/CachedXSLStyleSheet.h:
* loader/loader.cpp:
(WebCore::Loader::load):
(WebCore::Loader::didFinishLoading):
(WebCore::Loader::didFail):
(WebCore::Loader::didReceiveData):
2010-11-17 Cris Neckar <cdn@chromium.org>
Reviewed by Adam Barth.
Added test for multiple image objects which use the same invalid data attribute.
https://bugs.webkit.org/show_bug.cgi?id=46921
* fast/html/object-image-nested-fallback-expected.txt: Added.
* fast/html/object-image-nested-fallback.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72230
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Wed, 17 Nov 2010 20:07:00 +0000 (20:07 +0000)]
Provide a way to create a WKView (WebPage) that is hidden from
the InjectedBundle. This is needed for the Web Inspector.
https://webkit.org/b/49670
Reviewed by Sam Weinig.
* Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::encode): Added visibleToInjectedBundle.
(WebKit::WebPageCreationParameters::decode): Ditto.
* Shared/WebPageCreationParameters.h: Ditto.
* UIProcess/API/C/win/WKView.cpp:
(WKViewCreate): Pass VisibleToInjectedBundle to the WebView create function.
* UIProcess/API/C/win/WKViewPrivate.cpp:
(WKViewCreateForWebInspector): Added. Not used yet. Passes HiddenFromInjectedBundle
to the WebView create function.
* UIProcess/API/C/win/WKViewPrivate.h: Added WKViewCreateForWebInspector.
* UIProcess/API/mac/WKView.mm:
(-[WKView initWithFrame:pageNamespaceRef:hiddenFromInjectedBundle:]): Added hiddenFromInjectedBundle
parameter and calls WebPageProxy::setVisibleToInjectedBundle.
(-[WKView initWithFrame:pageNamespaceRef:]): Calls initWithFrame:pageNamespaceRef:hiddenFromInjectedBundle:
and passes NO for hiddenFromInjectedBundle.
(-[WKView initWithFrame:]): Cleaned up by removing the local assignment to self and just returns the result.
* UIProcess/API/mac/WKViewInternal.h: Added initWithFrame:pageNamespaceRef:hiddenFromInjectedBundle:.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy): Initialize m_visibleToInjectedBundle from the creation parameters.
(WebKit::WebPageProxy::creationParameters): Set visibleToInjectedBundle using m_visibleToInjectedBundle.
* UIProcess/WebPageProxy.h: Added m_visibleToInjectedBundle.
(WebKit::WebPageProxy::visibleToInjectedBundle): Added. Return m_visibleToInjectedBundle.
(WebKit::WebPageProxy::setVisibleToInjectedBundle): Added. Set m_visibleToInjectedBundle.
* UIProcess/win/WebView.cpp:
(WebKit::WebView::WebView): Added InjectedBundleVisibility parameter and calls
WebPageProxy::setVisibleToInjectedBundle.
* UIProcess/win/WebView.h: Added InjectedBundleVisibility enum.
(WebKit::WebView::create): Added InjectedBundleVisibility parameter.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::create): Checks visibleToInjectedBundle before talking to the injected bundle.
(WebKit::WebPage::WebPage): Initialize m_isVisibleToInjectedBundle from the creation parameters.
(WebKit::WebPage::close): Checks m_isVisibleToInjectedBundle before talking to the injected bundle.
* WebProcess/WebPage/WebPage.h: Added m_isVisibleToInjectedBundle.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72229
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zmo@google.com [Wed, 17 Nov 2010 19:55:11 +0000 (19:55 +0000)]
2010-11-16 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
WebGLRenderingContext needs to zero textures and renderbuffers
https://bugs.webkit.org/show_bug.cgi?id=49355
* src/WebGraphicsContext3DDefaultImpl.cpp: Don't deal with texture initialization at this level.
2010-11-16 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
WebGLRenderingContext needs to zero textures and renderbuffers
https://bugs.webkit.org/show_bug.cgi?id=49355
Test: fast/canvas/webgl/uninitialized-test.html
* html/canvas/WebGLFramebuffer.cpp:
(WebCore::WebGLFramebuffer::onAccess): Use a parameter to decide if renderbuffer initialization is needed.
(WebCore::WebGLFramebuffer::initializeRenderbuffers): Don't return false if color buffer doesn't exist.
* html/canvas/WebGLFramebuffer.h: Modify onAccess function signature.
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::clear): Call onAccess with an added parameter.
(WebCore::WebGLRenderingContext::copyTexImage2D): Ditto.
(WebCore::WebGLRenderingContext::copyTexSubImage2D): Ditto.
(WebCore::WebGLRenderingContext::drawArrays): Ditto.
(WebCore::WebGLRenderingContext::drawElements): Ditto.
(WebCore::WebGLRenderingContext::readPixels): Ditto.
(WebCore::WebGLRenderingContext::texImage2DBase): Create buffer data of 0s if input is null to initialize textures.
2010-11-16 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
WebGLRenderingContext needs to zero textures and renderbuffers
https://bugs.webkit.org/show_bug.cgi?id=49355
* fast/canvas/webgl/uninitialized-test-expected.txt: Added.
* fast/canvas/webgl/uninitialized-test.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72228
268f45cc-cd09-0410-ab3c-
d52691b4dbfc