WebKit-https.git
15 years ago Reviewed by Darin, landed by Maciej.
mjs [Thu, 6 Apr 2006 04:14:24 +0000 (04:14 +0000)]
    Reviewed by Darin, landed by Maciej.

        * BuildSlaveSupport/build-launcher-app: Added.  Builds WebKit.app from WebKitLauncher
          and bundles the WebKit frameworks inside it.
        * BuildSlaveSupport/build-launcher-dmg: Added.  Builds, and optionally uploads, a disk image
          containing WebKit.app.
        * BuildSlaveSupport/run-performance-tests:  Use currentSVNRevision.
        * Scripts/webkitdirs.pm:  Add currentSVNRevision to retrieve the revision
          number of the SVN working copy.
        * WebKitLauncher: Added.
        * WebKitLauncher/Info.plist: Added.
        * WebKitLauncher/WebKitLauncher.xcodeproj: Added.
        * WebKitLauncher/WebKitLauncher.xcodeproj/project.pbxproj: Added.
        * WebKitLauncher/WebKitNightlyEnabler.m: Added.  This makes
          up the WebKitNightlyEnabler dylib which is loaded into Safari's address space
          to cause LaunchServices to treat Safari.app as WebKit.app when it is run from
          the nightly launcher.
        * WebKitLauncher/main.m: Added.  The WebKit.app launcher.
          It sets up the environment to have Safari use the bundled frameworks
          and load the WebKitNightlyEnabler dylib before exec'ing Safari
        * WebKitLauncher/start.html: Added.
        * WebKitLauncher/webkit.icns: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej.
darin [Thu, 6 Apr 2006 00:13:50 +0000 (00:13 +0000)]
    Reviewed by Maciej.

        - fix memory leak introduced by the previous change

        * kxmlcore/HashTable.h: Specialize NeedsRef so that it correctly returns true when
        the value in question is a pair where one of the pair needs a ref and the other
        of the pair does not.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by mjs
justing [Thu, 6 Apr 2006 00:00:24 +0000 (00:00 +0000)]
    Reviewed by mjs

        I forgot to convert one of the implicit remove/inserts to an explicit remove/insert,
        so we were hitting the assert I just added to InsertNodeBeforeCommand that checked for
        implicit removes.

        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::doApply):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoShould fix the build
justing [Wed, 5 Apr 2006 22:43:40 +0000 (22:43 +0000)]
Should fix the build

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
mjs [Wed, 5 Apr 2006 22:26:43 +0000 (22:26 +0000)]
LayoutTests:

        Reviewed by Anders.

        Update prototype chain for the following fix:

        - autogenerate bindings for all of the methods and properties of Document
        http://bugzilla.opendarwin.org/show_bug.cgi?id=8163

        * fast/dom/prototype-chain-expected.txt:

WebCore:

        Reviewed by Anders.

        - autogenerate bindings for all of the methods and properties of Document
        http://bugzilla.opendarwin.org/show_bug.cgi?id=8163

        - also removed document.actualEncoding since it is not in any spec
        or implemented by any other browser

        * DerivedSources.make: add JSDocument.h to results
        * WebCore.xcodeproj/project.pbxproj: Added new files to project
        * bindings/scripts/CodeGeneratorJS.pm: Support for new stuff needed by Document.
        * dom/Document.cpp:
        (WebCore::Document::readyState): moved impl here from JS bindings
        (WebCore::Document::inputEncoding): ditto
        (WebCore::Document::defaultCharset): ditto
        (WebCore::Document::setCharset): ditto
        * dom/Document.h:
        (WebCore::Document::charset): added, synonym for inputEncoding.
        (WebCore::Document::characterSet): ditto
        * dom/Document.idl: Added. Full interface for the Document object.
        * khtml/ecma/JSXMLHttpRequest.cpp:
        (KJS::JSXMLHttpRequestProtoFunc::callAsFunction): JSDocument, not DOMDocument
        * khtml/ecma/JSXSLTProcessor.cpp:
        (KJS::XSLTProcessorProtoFunc::callAsFunction): ditto
        * khtml/ecma/kjs_binding.cpp:
        (KJS::jsStringOrFalse): Added this convenience for the method on Document
        that bizzarely returns false on failure and a string otherwise.
        * khtml/ecma/kjs_binding.h:
        * khtml/ecma/kjs_css.cpp:
        (KJS::toJS): renamed for consistency
        * khtml/ecma/kjs_css.h:
        * khtml/ecma/kjs_dom.cpp:
        - removed all traces of DOMDocument
        (KJS::toJS): JSDocument, not DOMDocument
        * khtml/ecma/kjs_dom.h:
        * khtml/ecma/kjs_html.cpp:
        (KJS::):
        (KJS::JSHTMLDocument::JSHTMLDocument): inherit from JSDocument
        (KJS::JSHTMLDocument::getOwnPropertySlot): ditto
        (KJS::JSHTMLDocument::put): ditto
        * khtml/ecma/kjs_html.h:
        * khtml/ecma/kjs_traversal.cpp:
        (KJS::toJS): added overloads
        (KJS::toNodeFilter): handle JS functions as well as impl NodeFilter objects
        * khtml/ecma/kjs_traversal.h:
        * platform/AtomicString.h:
        (WebCore::AtomicString::AtomicString): Allow implicit conversion from String.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
justing [Wed, 5 Apr 2006 21:53:23 +0000 (21:53 +0000)]
LayoutTests:

        Reviewed by darin

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=8198>
        Hitting an assert on undo paste

        * editing/pasteboard/undoable-fragment-removes-expected.checksum: Added.
        * editing/pasteboard/undoable-fragment-removes-expected.png: Added.
        * editing/pasteboard/undoable-fragment-removes-expected.txt: Added.
        * editing/pasteboard/undoable-fragment-removes.html: Added.

WebCore:

        Reviewed by darin

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=8198>
        Hitting an assert on undo paste

        ReplaceSelectionCommand was doing a combination of undoable and non-undoable
        removes from the ReplacementFragment.  On Undo Paste, the undoable removes
        couldn't be undone because the tree was in a different state than it was
        at the time of the remove.  This patch makes all the removes from the fragment
        non-undoable.  We could make them all undoable, but I can't think of any reason
        why we'd want the fragment to be reconstructed on an Undo Paste.

        * editing/AppendNodeCommand.cpp:
        (WebCore::AppendNodeCommand::doApply):
        Assert that the node to append isn't already in a tree, since if it is, it will
        be removed in a non-undoable way.
        * editing/InsertNodeBeforeCommand.cpp:
        (WebCore::InsertNodeBeforeCommand::doApply): Ditto.
        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::doApply):
        Nodes were being moved from the fragment to the document with undoable inserts.
        Undoable inserts implicitly remove the node (in a non-undoable way) from its
        old location if it is already in a tree.  I now explicitly remove the nodes
        from the fragment before inserting them into the document to make it clear that
        they are being removed in a non-non-undoable way.  I also changed the one undoable
        remove from the fragment to a non-undoable remove.
        * editing/ReplaceSelectionCommand.h:
        Made ReplacementFragment's non-undoable removeNode public.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - fixed the build
darin [Wed, 5 Apr 2006 21:51:11 +0000 (21:51 +0000)]
    - fixed the build

        * WebCore.xcodeproj/project.pbxproj: Oops! Resolved merge conflict.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoJavaScriptCore:
darin [Wed, 5 Apr 2006 21:19:57 +0000 (21:19 +0000)]
JavaScriptCore:

        Reviewed by Maciej.

        - JavaScriptCore part of fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=8049
          StringImpl hash traits deleted value creates an init routine for WebCore
          <rdar://problem/4442248> REGRESSION: WebCore has init routines (8049)

        Change HashMap and HashSet implementation so they fold various types together.
        This allows us to implement maps and sets that use RefPtr<WebCore::StringImpl>
        and WebCore::String in terms of the underlying raw pointer type, and hence use
        -1 for the deleted value.

        * kxmlcore/HashTraits.h: Added a new type to HashTraits, StorageTraits, which is a
        type to be used when storing a value that has the same layout as the type itself.
        This is used only for non-key cases. In the case of keys, the hash function must also
        be considered. Moved emptyValue out of GenericHashTraitsBase into GenericHashTraits.
        Added a new bool to HashTraits, needsRef, which indicates whether the type needs
        explicit reference counting. If the type itself has needsRef true, but the storage
        type has needsRef false, then the HashSet or HashMap has to handle the reference
        counting explicitly. Added hash trait specializations for all signed integer values
        that give -1 as the deleted value. Gave all integers StorageTraits of the canonical
        integer type of the same size so int and long will share code. Gave all pointers and
        RefPtrs StorageTraits of the appropriately sized integer type. Removed redundant
        TraitType and emptyValue definitions in the pointer specialization for HashTraits.
        Added PairBaseHashTraits, which doesn't try to set up needsDestruction and deletedValue.
        Useful for types where we don't want to force the existence of deletedValue, such as
        the type of a pair in a HashMap which is not the actual storage type. Removed an
        unneeded parameter from the DeletedValueAssigner template. Added HashKeyStorageTraits
        template, which determines what type can be used to store a given hash key type with
        a given hash function, and specialized it for pointers and RefPtr so that pointer
        hash tables share an underlying HashTable that uses IntHash.

        * kxmlcore/HashTable.h: Added HashTableConstIteratorAdapter, HashTableIteratorAdapter,
        NeedsRef, RefCountManagerBase, RefCountManager, HashTableRefCountManagerBase, and
        HashTableRefCountManager. All are used by both HashSet and HashMap to handle hash
        tables where the type stored is not the same as the real value type.

        * kxmlcore/HashFunctions.h: Added a new struct named IntTypes that finds an
        integer type given a sizeof value. Renamed pointerHash to intHash and made it
        use overloading and take integer parameters. Added an IntHash struct which is
        a hash function that works for integers. Changed PtrHash to call IntHash with
        an appropriately sized integer. Made IntHash the default hash function for
        many integer types. Made PtrHash the default hash function for RefPtr as well
        as for raw pointers.

        * kxmlcore/HashSet.h: Changed implementation to use a separate "storage type"
        derived from the new traits. The HashTable will use the storage type and all
        necessary translation and ref/deref is done at the HashSet level. Also reorganized
        the file so that the HashSet is at the top and has no inline implementation inside
        it so it's easy to read the interface to HashSet.

        * kxmlcore/HashMap.h: Changed implementation to use a separate "storage type"
        derived from the new traits. The HashTable will use the storage type and all
        necessary translation and ref/deref is done at the HashMap level. Also reorganized
        the file so that the HashMap is at the top and has no inline implementation inside
        it so it's easy to read the interface to HashMap.

        * kxmlcore/HashMapPtrSpec.h: Removed. Superceded by optimizations in HashMap itself.

        * JavaScriptCore.xcodeproj/project.pbxproj: Remove HashMapPtrSpec.h, resort files,
        and also remove some unnecessary build settings from the aggregate target that
        generates derived sources.
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Ditto.

WebCore:

        Reviewed by Maciej.

        - fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=8049
          StringImpl hash traits deleted value creates an init routine for WebCore
          <rdar://problem/4442248> REGRESSION: WebCore has init routines (8049)

        * platform/StringHash.h: Added. Moved hash functions and such for
        WebCore::String and friends into this file so we don't have to include
        the hash traits header everywhere. Changed hashing for WebCore::StringImpl
        and WebCore::String so that they use a raw pointer for the underlying
        storage type, taking advantage of the new feature added in JavaScriptCore.

        * platform/AtomicString.h: Moved StrHash specialization to StringHash.h.
        * platform/PlatformString.h: Moved StrHash specialization to StringHash.h.
        * platform/StringImpl.h: Moved StrHash, CaseInsensitiveHash, and HashTraits
        to StringHash.h. Left DefaultHash behind so that you can't get the wrong
        hash function by accident if you forget to include "StringHash.h".

        * platform/StringImpl.cpp: Added include of StringHash.h and removed
        RefPtr<StringImpl> HashTraits<RefPtr<StringImpl> >::_deleted, which is
        the object with a global initializer causing all the trouble!

        * kwq/AccessibilityObjectCache.h: Changed hash function to be IntHash
        instead of PtrHash.

        * dom/StyledElement.cpp: Changed MappedAttributeKeyTraits to inherit from
        the generic traits in KXMLCore so we get a StorageType. Also cleaned up a
        tiny bit by adding default values to the MappedAttributeKey constructor.

        * platform/CharsetNames.cpp: Changed hash traits here to be a new
        TextEncodingIDHashTraits struct rather than defining new default traits
        for the integer type since more integer types have default traits in
        HashTraits.h now. Also added a specialization so this class will share
        the underlying implementation (since InvalidEncoding happens to be -1).

        * bridge/mac/FrameMac.h:
        * dom/Document.h:
        * dom/xml_tokenizer.h:
        * khtml/xsl/XSLTProcessor.h:
        * kwq/JavaAppletWidget.h:
        * page/FramePrivate.h:
        * page/Page.cpp:
        * platform/AtomicString.cpp:
        * platform/TransferJob.h:
        * rendering/render_applet.h:
        Added include of StringHash.h.

        * WebCore.xcodeproj/project.pbxproj: Added StringHash.h. Remove unneeded
        CREATE_HASH_TABLE variable in build settings. Re-sorted some file lists.
        Added quotes to the CREATE_HASH_TABLE initialization in the rule that
        builds generated files. Removed various unneeded build settings for that
        target as well.

        * ForwardingHeaders/kxmlcore/HashTraits.h: Added.

        - other minor cleanup

        * bridge/mac/FrameMac.mm: Sorted includes.
        * dom/Node.cpp: Removed bogus symbol after #endif.

        * khtml/xsl/XSLTProcessor.cpp: Sorted includes. Removed redundant using
        namespace WebCore.
        * loader/Cache.cpp: Ditto.

WebKitTools:

        Reviewed by Maciej.

        * Scripts/check-for-global-initializers: Remove StringImpl from the list of files that
        are allowed to have global initializers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
bdakin [Wed, 5 Apr 2006 18:05:12 +0000 (18:05 +0000)]
    Reviewed by Darin.

        Fix for <rdar://problem/4502311> text-transform:capitalize needs to
        treat nbsp as a regular space when ICU changes

        There will be future changes in ICU to match the Unicode 4.1
        standard which no longer recognizes &nbsp as a word separator. We
        need to work around this with text-transform:capitalize because
        words after non-breaking spaces still need to be capitalized.

        No layout tests added because existing layout tests cover this.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
ap [Wed, 5 Apr 2006 18:02:19 +0000 (18:02 +0000)]
    Reviewed by Darin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8110
          Define navigator.vendorSub (bcms.gov.uk doesn't allow access to login page)

        Test: fast/dom/navigator-vendorSub.html

        * khtml/ecma/kjs_navigator.cpp:
        (KJS::Navigator::getValueProperty): Return an empty string for vendorSub property.
        * khtml/ecma/kjs_navigator.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by OMG BETH
ggaren [Wed, 5 Apr 2006 18:02:07 +0000 (18:02 +0000)]
    Reviewed by OMG BETH

        * Scripts/run-testkjs:
        - pipe STDERR to /dev/null by default; new --verbose option overrides
        this behavior
        - set DYLD_FRAMEWORK_PATH to the webkit-configured path
        - output run command in a format that can be copied and pasted into the
        terminal to run manually

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
darin [Wed, 5 Apr 2006 03:55:40 +0000 (03:55 +0000)]
LayoutTests:

        Reviewed by Justin and Adele.

        * fast/forms/plaintext-mode-2-expected.txt: Updated because there's no longer
        and extra <div> element added.

WebCore:

        Reviewed by Justin (editing parts) and Adele (the rest).

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8182
          some text-field-related layout tests are failing

        The smart paste code was getting confused and adding extra spaces.

        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::doApply): Use isStartOfParagraph instead of
        isStartOfLine.
        (WebCore::ReplaceSelectionCommand::removeLinePlaceholderIfNeeded): Ditto.

        * editing/InsertParagraphSeparatorCommand.cpp: (WebCore::enclosingEmptyListItem):
        Change to call isStart/EndOfParagraph instead of Line.

        * editing/InsertTextCommand.cpp: (WebCore::InsertTextCommand::input):
        Add a comment about how isStartOfLine is almost certainly wrong here.

        - clean up some loose ends in the Frame class from the recent renaming

        * page/Frame.h: Removed declarations of deleteMe1, deleteMe2, and
        handleMouseMoveEventPart2.
        * page/Frame.cpp: (WebCore::Frame::handleMouseMoveEvent): Removed
        handleMouseMoveEventPart2 by renaming it to handleMouseMoveEvent and removing
        handleMouseMoveEvent itself.

        - invoke the makefile directly, removing the generate-derived-sources script

        * WebCore.vcproj/WebCore/build-generated-files.sh: Call make directly.
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * generate-derived-sources: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoUpdate table results after my change to create fewer RenderTexts.
hyatt [Wed, 5 Apr 2006 02:26:51 +0000 (02:26 +0000)]
Update table results after my change to create fewer RenderTexts.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoUpdate fast results after my change to create fewer RenderTexts.
hyatt [Wed, 5 Apr 2006 02:19:22 +0000 (02:19 +0000)]
Update fast results after my change to create fewer RenderTexts.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
adele [Wed, 5 Apr 2006 02:06:51 +0000 (02:06 +0000)]
LayoutTests:

        - Tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=8158
        REGRESSION: Clicking past RTL text in a new text field puts the caret on the wrong side of the text

        * editing/selection/caret-rtl-expected.checksum: Added.
        * editing/selection/caret-rtl-expected.png: Added.
        * editing/selection/caret-rtl-expected.txt: Added.
        * editing/selection/caret-rtl.html: Added.
        * editing/selection/caret-rtl-2-expected.checksum: Added.
        * editing/selection/caret-rtl-2-expected.png: Added.
        * editing/selection/caret-rtl-2-expected.txt: Added.
        * editing/selection/caret-rtl-2.html: Added.

WebCore:

        Reviewed by Justin.

        - Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=8158
        REGRESSION: Clicking past RTL text in a new text field puts the caret on the wrong side of the text

        Tests:
        editing/selection/caret-rtl.html
        editing/selection/caret-rtl-2.html

        * rendering/RenderText.cpp: (WebCore::RenderText::positionForCoordinates):
        When calculating the position for the beginning or end of an InlineTextBox,
        we now use offsetForPosition instead of just using m_start and m_len, because
        offsetForPosition will take rtl text into account.  I also made some formatting
        changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago New results for
adele [Wed, 5 Apr 2006 01:49:30 +0000 (01:49 +0000)]
    New results for
        * fast/forms/input-truncate-newline-expected.txt

        Filed bug:
        http://bugzilla.opendarwin.org/show_bug.cgi?id=8187
        input-truncate-newline layout test fails when run as part of larger set of tests

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix for bug 8065, inline blocks incorrectly loses spaces between them.
hyatt [Tue, 4 Apr 2006 23:34:04 +0000 (23:34 +0000)]
    Fix for bug 8065, inline blocks incorrectly loses spaces between them.

        Reviewed by beth

        * dom/Text.cpp:
        (WebCore::Text::rendererIsNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
adele [Tue, 4 Apr 2006 22:23:01 +0000 (22:23 +0000)]
LayoutTests:

         - Test for:
        http://bugzilla.opendarwin.org/show_bug.cgi?id=8092
        REGRESSION (NativeTextField): table contents misaligned in Netflix queue

        http://bugzilla.opendarwin.org/show_bug.cgi?id=8141
        REGRESSION: Native text field fails to wrap inside table

        http://bugzilla.opendarwin.org/show_bug.cgi?id=8072
        REGRESSION: text fields at connect.apple.com spill out of the containing box

        * fast/forms/input-table-expected.checksum: Added.
        * fast/forms/input-table-expected.png: Added.
        * fast/forms/input-table-expected.txt: Added.
        * fast/forms/input-table.html: Added.

WebCore:

        Reviewed by Hyatt.

        - Fix for:
        http://bugzilla.opendarwin.org/show_bug.cgi?id=8092
        REGRESSION (NativeTextField): table contents misaligned in Netflix queue

        http://bugzilla.opendarwin.org/show_bug.cgi?id=8141
        REGRESSION: Native text field fails to wrap inside table

        http://bugzilla.opendarwin.org/show_bug.cgi?id=8072
        REGRESSION: text fields at connect.apple.com spill out of the containing box

        Test: fast/forms/input-table.html

        Rewrote calcMinMaxWidth for text fields so it considers width,
        min-width, and max-width settings as well as the size attribute.

        * rendering/RenderTextField.cpp: (WebCore::RenderTextField::calcMinMaxWidth):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
bdakin [Tue, 4 Apr 2006 22:11:17 +0000 (22:11 +0000)]
    Reviewed by Darin.

        This is a followup to my fix for <rdar://problem/4493218>

        This patch re-names computeIntLength() and computerShortLength() to
        be computeLengthInt() and computeLengthShort(), respectively, to
        match the pre-existing computeLengthFloat(). This patch also adds
        the slightly confusing-ly named computeLengthIntForLength() which
        uses the max and min values of a 28-bit integer as bounds for
        overflow. This function is necessary because Length objects expect
        28-bit integers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoJavaScriptCore:
thatcher [Tue, 4 Apr 2006 21:21:35 +0000 (21:21 +0000)]
JavaScriptCore:

        Reviewed by Darin.

        The Debug and Release frameworks are now built with install paths relative to the build products directory.
        This removes the need for other projects to build with -framework WebCore and -framework JavaScriptCore.

        * JavaScriptCore.xcodeproj/project.pbxproj:

JavaScriptGlue:

        Reviewed by Darin.

        The Debug and Release frameworks are now built with install paths relative to the build products directory.
        This removes the need for other projects to build with -framework WebCore and -framework JavaScriptCore.

        * JavaScriptGlue.xcodeproj/project.pbxproj:

WebCore:

        Reviewed by Darin.

        The Debug and Release frameworks are now built with install paths relative to the build products directory.
        This removes the need for other projects to build with -framework WebCore and -framework JavaScriptCore.

        * WebCore.xcodeproj/project.pbxproj:

WebKit:

        Reviewed by Darin.

        The Debug and Release frameworks are now built with install paths relative to the build products directory.
        This removes the need for other projects to build with -framework WebCore and -framework JavaScriptCore.

        * WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
justing [Tue, 4 Apr 2006 20:52:10 +0000 (20:52 +0000)]
LayoutTests:

        Reviewed by darin

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=6608>
        REGRESSION: Line disappears when deleting

        Added:
        * editing/deleting/merge-different-styles-expected.checksum: Added.
        * editing/deleting/merge-different-styles-expected.png: Added.
        * editing/deleting/merge-different-styles-expected.txt: Added.
        * editing/deleting/merge-different-styles.html: Added.
        * editing/deleting/merge-no-br-expected.checksum: Added.
        * editing/deleting/merge-no-br-expected.png: Added.
        * editing/deleting/merge-no-br-expected.txt: Added.
        * editing/deleting/merge-no-br.html: Added.
        * editing/deleting/merge-whitespace-pre-expected.checksum: Added.
        * editing/deleting/merge-whitespace-pre-expected.png: Added.
        * editing/deleting/merge-whitespace-pre-expected.txt: Added.
        * editing/deleting/merge-whitespace-pre.html: Added.

        Fixes (not enough style on nodes for the fixes to be reflected in pixel results):
        * editing/deleting/delete-block-merge-contents-005-expected.txt:
        * editing/deleting/delete-block-merge-contents-006-expected.txt:
        * editing/deleting/delete-block-merge-contents-008-expected.txt:

        Equivalent render trees:
        * editing/deleting/delete-3857753-fix-expected.txt:
        * editing/inserting/insert-div-026-expected.txt:

        Forgot to checkin these new expected results after fixing the DRT bug:
        * fast/lists/drag-into-marker-expected.checksum:
        * fast/lists/drag-into-marker-expected.png:
        * fast/lists/drag-into-marker-expected.txt:

WebCore:

        Reviewed by darin

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=6608>
        REGRESSION: Line disappears when deleting

        Rewrote moveNodesAfterNode to address these problems:
        It moved nodes without preserving their style.
        It traversed over siblings looking for a br to know when
        to stop merging.  If the br was burried inside a span, it
        wouldn't find it.  If the text is whitespace:pre, it wouldn't
        stop.
        In theory it would crash if the "enclosingInlineElements" of the start of the
        selection to delete and the end of the selection to delete were the
        same.  We think that this will fix these:
        <rdar://problems/3950559&4498113>
        CrashTracer: 2116 crashes in Mail at com.apple.WebCore: khtml::CompositeEditCommand::insertNodeAfter + 32
        CrashTracer: 1569 crashes in Mail at com.apple.WebCore: khtml::DeleteSelectionCommand::moveNodesAfterNode + 340
        But we haven't been able to construct a reproducible case.

        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::removeNodeAndPruneAncestors): Moved from ReplaceSelectionCommand.
        (WebCore::CompositeEditCommand::prune): Ditto.
        * editing/CompositeEditCommand.h:
        * editing/DeleteSelectionCommand.cpp:
        (WebCore::DeleteSelectionCommand::mergeParagraphs):
        (WebCore::DeleteSelectionCommand::doApply):
        * editing/DeleteSelectionCommand.h:
        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::doApply):
        * editing/ReplaceSelectionCommand.h:
        (WebCore::):
        * editing/markup.cpp:
        (WebCore::createMarkup):
        Was crashing when passed a collapsed range.  I early return an empty string instead.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-04-04 Eric Seidel <eseidel@apple.com>
eseidel [Tue, 4 Apr 2006 18:10:12 +0000 (18:10 +0000)]
2006-04-04  Eric Seidel  <eseidel@apple.com>

        Reviewed by ggaren.

        Fix win32 build.
        Disable ASSERT redefinition warnings for now.

        * JavaScriptCore.vcproj/testkjs/testkjs.vcproj:
        * kxmlcore/Assertions.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adele Peterson.
sullivan [Tue, 4 Apr 2006 17:48:02 +0000 (17:48 +0000)]
    Reviewed by Adele Peterson.

        - WebKit part of <rdar://problem/4498418> "Autosaved" searchterms are saved during private browsing

        * WebView/WebView.m:
        (-[WebView _updateWebCoreSettingsFromPreferences:]):
        Pass private browsing setting down to WebCore.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adele Peterson.
sullivan [Tue, 4 Apr 2006 17:47:49 +0000 (17:47 +0000)]
    Reviewed by Adele Peterson.

        - WebCore part of <rdar://problem/4498418> "Autosaved" searchterms are saved during private browsing

        * bridge/mac/WebCoreSettings.h:
        * bridge/mac/WebCoreSettings.mm:
        (-[WebCoreSettings setPrivateBrowsingEnabled:]):
        (-[WebCoreSettings privateBrowsingEnabled]):
        Teach WebCoreSettings about private browsing (WebKit knew, but WebCore didn't)

        * kwq/KWQKHTMLSettings.h:
        (KHTMLSettings::privateBrowsingEnabled):
        (KHTMLSettings::setPrivateBrowsingEnabled):
        Teach KHTMLSettings about private browsing

        * kwq/KWQLineEdit.mm:
        Fix wrong class in a category method declaration; the compiler didn't seem to mind.

        * kwq/WebCoreTextField.mm:
        (-[KWQSearchFieldCell _addStringToRecentSearches:]):
        Override this method to bail out if private browsing is enabled.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Hyatt.
darin [Tue, 4 Apr 2006 16:15:07 +0000 (16:15 +0000)]
    Reviewed by Hyatt.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=7951
        REGRESSION: Safari crashes when printing a google map w/directions

        Tests: none, because I believe it only happens when printing, due to the relayouts

        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::recalcSectionsIfNeeded): Add new utility to let the cells
        ensure the sections' grid data is up to date.
        * rendering/RenderTable.h:
        * rendering/RenderTableCell.cpp:
        (WebCore::RenderTableCell::calcMinMaxWidth):  Call above method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-04-04 Bjrn Graf <bjoern.graf@gmail.com>
eseidel [Tue, 4 Apr 2006 12:11:08 +0000 (12:11 +0000)]
2006-04-04  Bjrn Graf  <bjoern.graf@gmail.com>

        Reviewed by ggaren & darin.  Landed by eseidel.

        Integrate CURL version of gettimeofday
        http://bugzilla.opendarwin.org/show_bug.cgi?id=7399
        Disable crash report dialogs for testkjs.exe in Release mode
        http://bugzilla.opendarwin.org/show_bug.cgi?id=8113

        * kjs/testkjs.cpp:
        (StopWatch::start):
        (StopWatch::stop):
        (StopWatch::getElapsedMS):
        (main):
        (kjsmain):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-04-03 Justin Haygood <jhaygood@spsu.edu>
eseidel [Tue, 4 Apr 2006 11:54:46 +0000 (11:54 +0000)]
2006-04-03  Justin Haygood <jhaygood@spsu.edu>

        Reviewed by eseidel.  Landed by eseidel.

        - WIN32: maximumScroll() is the maximum scroll delta, not the maximum scroll position. Update to use
          the real maximum scroll position.
        http://bugzilla.opendarwin.org/show_bug.cgi?id=8160

        * platform/win/ScrollViewWin.cpp:
        (WebCore::ScrollView::updateScrollBars):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-04-04 Eric Seidel <eseidel@apple.com>
eseidel [Tue, 4 Apr 2006 11:48:37 +0000 (11:48 +0000)]
2006-04-04  Eric Seidel  <eseidel@apple.com>

        Reviewed by andersca.

        Work-around spaces-in-pathnames issue in gnumake on win32.
        http://bugzilla.opendarwin.org/show_bug.cgi?id=8173

        * WebCore.vcproj/WebCore/build-generated-files.sh:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-04-04 Eric Seidel <eseidel@apple.com>
eseidel [Tue, 4 Apr 2006 10:08:50 +0000 (10:08 +0000)]
2006-04-04  Eric Seidel  <eseidel@apple.com>

        Reviewed by mjs.

        * kjs/number_object.cpp:
        (NumberProtoFunc::callAsFunction): remove trunc() to fix win32.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
mjs [Tue, 4 Apr 2006 09:03:26 +0000 (09:03 +0000)]
    Reviewed by Darin.

        - fixed "toPrecision sometimes messes up the last digit on intel Macs"
        http://bugzilla.opendarwin.org/show_bug.cgi?id=7748

        * kjs/number_object.cpp:
        (intPow10): Compute integer powers of 10 using exponentiation by squaring.
        (NumberProtoFunc::callAsFunction): Use intPow10(n) in place of all pow(10.0, n),
        plus a bit of refactoring.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - tried to fix build again
darin [Tue, 4 Apr 2006 06:54:07 +0000 (06:54 +0000)]
    - tried to fix build again

        * WebCore.xcodeproj/project.pbxproj: Removed JSStyleSheet files.
        * WebCore.vcproj/WebCore/WebCore.vcproj: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - fixed properties on a bunch of files
darin [Tue, 4 Apr 2006 06:30:13 +0000 (06:30 +0000)]
    - fixed properties on a bunch of files
          (removed allow-tabs and svn:executable from many)

        * css/css_base.cpp:
        * html/html_headimpl.cpp:
        * khtml/ecma/kjs_traversal.cpp:
        * kwq/DeprecatedPtrListImpl.cpp:
        * kwq/DeprecatedValueListImpl.cpp:
        * loader/CachedScript.h:
        * platform/ArrayImpl.cpp:
        * platform/StringImpl.cpp:
        * rendering/DataRef.h:
        * rendering/RenderContainer.cpp:
        * rendering/RenderTableCell.cpp:
        * rendering/bidi.h:
        * rendering/render_list.cpp:
        * rendering/render_style.cpp:
        * rendering/table_layout.h:
        Converted tabs to spaces.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
ap [Tue, 4 Apr 2006 05:21:08 +0000 (05:21 +0000)]
    Reviewed by Darin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7118
          Property values with extra items do not get treated as invalid (they should)

        Tests: fast/css/invalidation-errors.html
               fast/css/invalidation-errors-2.html
               fast/css/invalidation-errors-3.html

        * css/CSSGrammar.y: Rollback the properties added by parseValue() when it returns false.
        * css/cssparser.h: Moved shorthand counting to ShorthandScope, a new class in cssparser.cpp.
        * css/cssparser.cpp:
        (WebCore::CSSParser::rollbackLastProperties): Added.
        (WebCore::CSSParser::parseValue): Return false if there are too many properties in the list.
        (WebCore::CSSParser::parseBackgroundShorthand): Use ShorthandScope.
        (WebCore::CSSParser::parseShorthand): Ditto.
        (WebCore::CSSParser::parse4Values): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoBumping the PLT count back to 5.
thatcher [Tue, 4 Apr 2006 04:47:53 +0000 (04:47 +0000)]
Bumping the PLT count back to 5.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - changed StyleSheet back to hand-generated since the generated toJS
darin [Tue, 4 Apr 2006 04:07:26 +0000 (04:07 +0000)]
    - changed StyleSheet back to hand-generated since the generated toJS
          function was not making the right type of wrapper for CSS style sheets
          (fixes failing layout tests)

        * DerivedSources.make: Removed JSStyleSheet.h.
        * css/StyleSheet.idl: Removed.
        * khtml/ecma/kjs_css.cpp: Added DOMStyleSheet back in.
        * khtml/ecma/kjs_css.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13671 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - tweak config.h and Platform.h to try to get buildbot working
darin [Tue, 4 Apr 2006 03:55:09 +0000 (03:55 +0000)]
    - tweak config.h and Platform.h to try to get buildbot working
          (making some small changes at the same time)

        * kjs/config.h: Removed now-unneeded HAVE_ICU.
        * kxmlcore/Platform.h: Tweak how platform gets set up. Move all the
        USE stuff to the end.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13670 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - fixed Macintosh build
darin [Tue, 4 Apr 2006 03:34:33 +0000 (03:34 +0000)]
    - fixed Macintosh build

        * WebCore.xcodeproj/project.pbxproj: Fixed paths of some files that were absolute
        paths from my machine.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - try to fix Windows build
darin [Tue, 4 Apr 2006 03:14:15 +0000 (03:14 +0000)]
    - try to fix Windows build

        * WebCore.vcproj/WebCore/WebCore.vcproj: Add three new generated files as source files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoReviewed by Maciej.
staikos [Tue, 4 Apr 2006 02:45:19 +0000 (02:45 +0000)]
Reviewed by Maciej.

Fix Win32 build breakage and remove an unused forward.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
darin [Tue, 4 Apr 2006 01:54:40 +0000 (01:54 +0000)]
LayoutTests:

        - add a test of RTL to the test for bug 8106

        * fast/forms/input-text-scroll-left-on-blur-expected.png: Updated.
        * fast/forms/input-text-scroll-left-on-blur-expected.txt: Updated.
        * fast/forms/input-text-scroll-left-on-blur-expected.checksum: Updated.
        * fast/forms/input-text-scroll-left-on-blur.html: Updated.

WebCore:

        Reviewed by Maciej.

        - get RTL right for bug http://bugzilla.opendarwin.org/show_bug.cgi?id=8106
          REGRESSION (NativeTextField): New text fields don't scroll to the beginning when losing focus

        * rendering/RenderTextField.cpp: (WebCore::RenderTextField::forwardEvent):
        Scroll to the right if RTL.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13666 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej.
darin [Tue, 4 Apr 2006 01:50:51 +0000 (01:50 +0000)]
    Reviewed by Maciej.

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=8147
          convert derived sources script to a Makefile

        * DerivedSources.make: Added.
        * css/CSSPrimitiveValue.idl: Added.
        * css/Counter.idl: Added.
        * css/StyleSheet.idl: Added.

        * WebCore.xcodeproj/project.pbxproj: Added new generated files, IDLs, and the makefile.
        * bindings/scripts/CodeGeneratorJS.pm:

        * generate-derived-sources: Added license header. Removed most of the script, except for
        a single invocation of make.

        * khtml/ecma/kjs_css.h: Removed DOMStyleSheet, DOMCSSPrimitiveValue,
        CSSPrimitiveValueConstructor, and DOMCounter.
        * khtml/ecma/kjs_css.cpp:
        (KJS::DOMCSSStyleSheet::DOMCSSStyleSheet): Changed to use JSStyleSheet as the base class.
        (KJS::DOMCSSStyleSheet::getOwnPropertySlot): Ditto.
        (KJS::DOMCSSValueProtoFunc::callAsFunction): Added.
        (KJS::toJS): Changed to use JSCSSPrimitiveValue.
        (KJS::DOMRGBColor::getValueProperty): Changed to call toJS instead of making a
        DOMCSSPrimitiveValue directly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
justing [Mon, 3 Apr 2006 23:58:43 +0000 (23:58 +0000)]
LayoutTests:

        Reviewed by harrison

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=8117>
        REGRESSION (NativeTextField): Drag and drop text within a text input field modifies page
        <http://bugzilla.opendarwin.org/show_bug.cgi?id=7567>
        A drag and drop in DumpRenderTree copies the source, instead of cutting it

        * editing/pasteboard/drag-drop-modifies-page-expected.checksum: Added.
        * editing/pasteboard/drag-drop-modifies-page-expected.png: Added.
        * editing/pasteboard/drag-drop-modifies-page-expected.txt: Added.
        * editing/pasteboard/drag-drop-modifies-page.html: Added.

        Updated:
        * fast/lists/drag-onto-marker.html:
        * fast/lists/drag-onto-marker-expected.txt:
        * fast/lists/drag-onto-marker-expected.png:
        * fast/lists/drag-onto-marker-expected.checksum:

WebCore:

        Reviewed by harrison

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=8117>
        REGRESSION (NativeTextField): Drag and drop text within a text input field modifies page

        The frame's selection is only set after all sub-commands have been
        performed.  When we send the khtmlBeforeTextInsertedEvent to the root
        editable element we were using frame->selection(), which may no longer
        be in the document.

        Had to move the construction of the ReplacementFragment to when the
        replace operation is applied, because endingSelection isn't the
        endingSelection of the last operation when the replace operation
        is constructed.

        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplacementFragment::ReplacementFragment):
        (WebCore::ReplaceSelectionCommand::ReplaceSelectionCommand):
        (WebCore::ReplaceSelectionCommand::doApply):
        * editing/ReplaceSelectionCommand.h:

WebKitTools:

        Reviewed by harrison

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=7567>
        A drag and drop in DumpRenderTree copies the source, instead of cutting it

        Tell the source that the drag is over after the drag is performed, not before.

        * DumpRenderTree/EventSendingController.m:
        (-[EventSendingController mouseUp]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej.
staikos [Mon, 3 Apr 2006 23:49:39 +0000 (23:49 +0000)]
    Reviewed by Maciej.

        Implement a unicode abstraction layer to make JavaScriptCore much more
        easily ported to other platforms without having to take in libicu.  Also
        makes the unicode related code easier to understand.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13663 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Layout test for <rdar://problem/4495644> crash when mousing over
bdakin [Mon, 3 Apr 2006 23:46:21 +0000 (23:46 +0000)]
    Layout test for <rdar://problem/4495644> crash when mousing over
        links at nationalrealestateinvestors.com in
        WebCore::RenderBlock::findNextLineBreak

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Tim Hatcher.
sullivan [Mon, 3 Apr 2006 23:17:17 +0000 (23:17 +0000)]
    Reviewed by Tim Hatcher.

        - re-fixed <rdar://problem/4481198> REGRESSION (TOT): search results list in bookmarks view
        remains when search text is deleted

        * WebView/WebView.m:
        (-[WebView searchFor:direction:caseSensitive:wrap:]):
        I fixed this recently, but then broke it again by adding an early bail-out to this method. So
        now I'm removing the early bail-out.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Hyatt.
bdakin [Mon, 3 Apr 2006 22:30:07 +0000 (22:30 +0000)]
    Reviewed by Hyatt.

        Fix for <rdar://problem/4495644> crash when mousing over links at
        nationalrealestateinvestors.com in
        WebCore::RenderBlock::findNextLineBreak

        This is a fix for a repro crasher where a rootLineBox had a stale
        pointer to a render object.

        * rendering/RenderFlow.cpp:
        (WebCore::RenderFlow::dirtyLinesFromChangedChild): Only break from
        the function because of selfNeedsLayout() if we are not an inline
        flow, because if we are, we will not re-layout before bad things
        can happen.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej.
thatcher [Mon, 3 Apr 2006 22:26:18 +0000 (22:26 +0000)]
    Reviewed by Maciej.

        Removing idl files and some scripts from the WebCore target to prevent
        them from being copied into the Resources.

        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13659 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adele.
thatcher [Mon, 3 Apr 2006 22:06:06 +0000 (22:06 +0000)]
    Reviewed by Adele.

        Fixes <rdar://problem/4498338> JavaScriptCore fails to compile for ppc64
        Other 64 bit build fixes.

        * kjs/collector.cpp:
        (KJS::Collector::markOtherThreadConservatively): test for __DARWIN_UNIX03 and use __r1
        * kjs/dtoa.cpp:
        (Bigint::): cast PRIVATE_mem to unsigned to prevent warning
        * bindings/jni/jni_utility.cpp:
        (KJS::Bindings::getJavaVM): cast jniError to long to prevent format warning
        (KJS::Bindings::getJNIEnv): cast jniError to long to prevent format warning
        * bindings/runtime_root.cpp:
        (KJS::Bindings::addNativeReference): cast CFDictionaryGetValue to unsigned long to prevent warning
        (KJS::Bindings::removeNativeReference): cast CFDictionaryGetValue to unsigned long to prevent warning

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWin32 theme work. Bug 8162. r=anders
hyatt [Mon, 3 Apr 2006 21:58:47 +0000 (21:58 +0000)]
Win32 theme work. Bug 8162. r=anders

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
adele [Mon, 3 Apr 2006 21:55:08 +0000 (21:55 +0000)]
LayoutTests:

        Reviewed by Beth.

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=8085
          REGRESSION: Main menu positioned incorrectly on eia.org and fedex.com/us

        * fast/dom/Element/offsetTop-table-cell-expected.txt: Added.
        * fast/dom/Element/offsetTop-table-cell.html: Added.

WebCore:

        Reviewed by Beth.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8085
          REGRESSION: Main menu positioned incorrectly on eia.org and fedex.com/us

        Test: fast/dom/Element/offsetTop-table-cell.html

        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::offsetTop): Skip table rows when adding up
        the offsets, since a table cell's yPos() is relative to the table
        section, not the row.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
adele [Mon, 3 Apr 2006 21:42:17 +0000 (21:42 +0000)]
LayoutTests:

        Reviewed by Darin.

        - Test for http://bugzilla.opendarwin.org/show_bug.cgi?id=7943
          Layer outline does not repaint

        * fast/repaint/inline-block-overflow-expected.png: Added.
        * fast/repaint/layer-outline-expected.checksum: Added.
        * fast/repaint/layer-outline-expected.png: Added.
        * fast/repaint/layer-outline-expected.txt: Added.
        * fast/repaint/layer-outline-horizontal-expected.checksum: Added.
        * fast/repaint/layer-outline-horizontal-expected.png: Added.
        * fast/repaint/layer-outline-horizontal-expected.txt: Added.
        * fast/repaint/layer-outline-horizontal.html: Added.
        * fast/repaint/layer-outline.html: Added.

WebCore:

        Test: fast/repaint/layer-outline.html fast/repaint/layer-outline-horizontal.html

        Reviewed by Darin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7943
          Layer outline does not repaint

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::paintLayer): Use the outlineRect for the
        outline phase and do it only if the outlineRect isn't empty.
        (WebCore::RenderLayer::calculateRects): Actually add the outline width to the
        outline rect.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
adele [Mon, 3 Apr 2006 21:14:05 +0000 (21:14 +0000)]
LayoutTests:

        Reviewed by Justin.

        - Test for http://bugzilla.opendarwin.org/show_bug.cgi?id=8104
        REGRESSION (NativeTextField): New text fields should not allow pasting newlines

        * fast/forms/input-truncate-newline-expected.txt: Added.
        * fast/forms/input-truncate-newline.html: Added.

WebCore:

        Reviewed by Justin.

        - Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=8104
        REGRESSION (NativeTextField): New text fields should not allow pasting newlines

        Test: fast/forms/input-truncate-newline.html

        * html/HTMLInputElement.cpp:
        (WebCore::minPosition): Added helper function.
        (WebCore::HTMLInputElement::defaultEventHandler): Searches for /r or /n and
         truncates the text to be inserted to the earliest newline.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fixed a comment (forgot to save the file before the previous commit).
ap [Mon, 3 Apr 2006 17:46:05 +0000 (17:46 +0000)]
    Fixed a comment (forgot to save the file before the previous commit).

        * xml/xmlhttprequest.cpp:
        (WebCore::XMLHttpRequest::open):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
ap [Mon, 3 Apr 2006 16:36:35 +0000 (16:36 +0000)]
    Reviewed by Darin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8099
          REGRESSION: XMLHttpRequest lowercase post requests broken

        Test: http/tests/xmlhttprequest/methods-lower-case.html

        * xml/xmlhttprequest.cpp:
        (WebCore::XMLHttpRequest::open): Uppercase some HTTP method names, to match a Firefox quirk.
        (WebCore::XMLHttpRequest::send): Account for the above change.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
darin [Mon, 3 Apr 2006 16:28:38 +0000 (16:28 +0000)]
    Reviewed by Darin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8032
          REGRESSION: Focus ring not completely redrawn after a Delete changes its size

        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::repaintAfterLayoutIfNeeded): When an element changes size, the
        delta rectangles that need to be invalidated must be inflated by the outline size to ensure
        that the previous outline is erased, and the space where the new outline is to be drawn is
        also invalidated. This behaviour is identical to the behaviour of borders that was fixed in
        bug 6301.
        * manual-tests/outline-repaint-glitch.html: Added. Manual testcase.
        This is just an outline version of border-repaint-glitch.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
darin [Mon, 3 Apr 2006 16:25:37 +0000 (16:25 +0000)]
LayoutTests:

        Reviewed by Maciej.

        Adding tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=8121
        REGRESSION: 404s are not displayed
        and http://bugzilla.opendarwin.org/show_bug.cgi?id=7739
        REGRESSION: Assertion failure loading acid2 test in -[WebCoreFrameBridge installInFrame:]

        In addition I tweaked the httpd conf file to allow us to exec perl CGI scripts.

        * http/conf/httpd.conf:
        * http/tests/misc/error404-expected.checksum: Added.
        * http/tests/misc/error404-expected.png: Added.
        * http/tests/misc/error404-expected.txt: Added.
        * http/tests/misc/error404.pl: Added.
        * http/tests/misc/iframe404-expected.checksum: Added.
        * http/tests/misc/iframe404-expected.png: Added.
        * http/tests/misc/iframe404-expected.txt: Added.
        * http/tests/misc/iframe404.html: Added.

WebCore:

        Reviewed by Maciej.

        Support for fixing http://bugzilla.opendarwin.org/show_bug.cgi?id=8121
        REGRESSION: 404s are not displayed

        * bridge/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge currentForm]): Nuke redundant nil check.
        (-[WebCoreFrameBridge frameElement]): Tweak to not rely on our document, which
        gives a correct result even at the start of our loading process.
        * bindings/objc/DOM.mm:
        (-[DOMDocument _ownerElement]): Nuke redundant nil check.

WebKit:

        Reviewed by Maciej.

        fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8121
        REGRESSION: 404s are not displayed

        * WebView/WebMainResourceLoader.m:
        (-[WebMainResourceLoader continueAfterContentPolicy:response:]):
        Only cancel failed loads for object elements, not for frames or a whole page.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej.
darin [Mon, 3 Apr 2006 16:04:42 +0000 (16:04 +0000)]
    Reviewed by Maciej.

        - Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=8079
        REGRESSION: Redraw from page cache does not show visited links

        * page/Frame.cpp: (WebCore::Frame::reparseConfiguration): Added back
        updateStyleSelector call that was removed as part of the patch for bug 7907.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
mjs [Mon, 3 Apr 2006 07:06:47 +0000 (07:06 +0000)]
LayoutTests:

        Reviewed by Hyatt.

        Tests for:
        - fixed <rdar://problem/4198619> REGRESSION: tabbing through links fails after hitting text field w/ sys's "tab to all controls" off
        - fixed <rdar://problem/4463760> REGRESSION: Can't tab from old text field (like password fields) to new text field (6811)
        (http://bugzilla.opendarwin.org/show_bug.cgi?id=6811)
        - fixed tab and shift tab don't select the right things
        http://bugzilla.opendarwin.org/show_bug.cgi?id=5685

        * fast/forms/focus-control-to-page-expected.txt: Added.
        * fast/forms/focus-control-to-page.html: Added.

WebCore:

        Reviewed by Hyatt.

        - fixed <rdar://problem/4198619> REGRESSION: tabbing through links fails after hitting text field w/ sys's "tab to all controls" off
        - fixed <rdar://problem/4463760> REGRESSION: Can't tab from old text field (like password fields) to new text field (6811)
        (http://bugzilla.opendarwin.org/show_bug.cgi?id=6811)
        - fixed tab and shift tab don't select the right things
        http://bugzilla.opendarwin.org/show_bug.cgi?id=5685

        * bridge/mac/FrameMac.mm:
        (WebCore::FrameMac::nextKeyViewInFrame):
        * bridge/mac/WebCoreFrameBridge.h:

WebKit:

        Reviewed by Hyatt.

        - fixed <rdar://problem/4198619> REGRESSION: tabbing through links fails after hitting text field w/ sys's "tab to all controls" off
        - fixed <rdar://problem/4463760> REGRESSION: Can't tab from old text field (like password fields) to new text field (6811)
        (http://bugzilla.opendarwin.org/show_bug.cgi?id=6811)
        - fixed tab and shift tab don't select the right things
        http://bugzilla.opendarwin.org/show_bug.cgi?id=5685

        * WebCoreSupport/WebFrameBridge.m:
        (-[WebFrameBridge willMakeFirstResponderForNodeFocus]): New method
        - let WebHTMLView know that the next time it becomes first
        responder, it's to change focus within the page and the right node
        has already been set, so it should not move focus forward or
        backward inside it.
        * WebView/WebHTMLView.m:
        (-[NSArray needsPanelToBecomeKey]): Override to return YES, oddly enough this
        is the right way to tell AppKit that you should be in the tab cycle loop.
        (-[NSArray becomeFirstResponder]): Don't move forward or back in tab cycle
        when this becomeFirstResponder is for tabbing from a control in the page.
        (-[WebHTMLView _willMakeFirstResponderForNodeFocus]): Note that the next
        time this view becomes first responder, it will be for in-page focus
        navigation.
        * WebView/WebHTMLViewInternal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - updated one more result for change in focus ring appearance
darin [Mon, 3 Apr 2006 01:52:35 +0000 (01:52 +0000)]
    - updated one more result for change in focus ring appearance

        * fast/forms/plaintext-mode-2-expected.checksum: Updated.
        * fast/forms/plaintext-mode-2-expected.png: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - add a few stubs to get Windows closer to building
darin [Mon, 3 Apr 2006 01:39:33 +0000 (01:39 +0000)]
    - add a few stubs to get Windows closer to building

        * platform/win/TemporaryLinkStubs.cpp:
        (WebCore::focusRingColor):
        (WebCore::setFocusRingColorChangeFunction):
        (Frame::setNeedsReapplyStyles):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - fix the build
darin [Mon, 3 Apr 2006 01:26:44 +0000 (01:26 +0000)]
    - fix the build

        * WebCore.xcodeproj/project.pbxproj: Removed a bunch of files that should not have been
        mentioned at all, and a bunch of others that should be in the project but not in the target.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - updated layout test results, mostly for the change in focus ring appearance
darin [Mon, 3 Apr 2006 01:17:41 +0000 (01:17 +0000)]
    - updated layout test results, mostly for the change in focus ring appearance

        * editing/input/range-for-empty-document-expected.txt:

        * editing/selection/3690703-2-expected.checksum:
        * editing/selection/3690703-2-expected.png:
        * editing/selection/3690703-2-expected.txt:

        * fast/overflow/scrollRevealButton-expected.checksum:
        * fast/overflow/scrollRevealButton-expected.png:
        * fast/overflow/scrollRevealButton-expected.txt:

        * editing/deleting/collapse-whitespace-3587601-fix-expected.checksum:
        * editing/deleting/collapse-whitespace-3587601-fix-expected.png:
        * editing/deleting/delete-3608430-fix-expected.checksum:
        * editing/deleting/delete-3608430-fix-expected.png:
        * editing/deleting/delete-3608445-fix-expected.checksum:
        * editing/deleting/delete-3608445-fix-expected.png:
        * editing/deleting/delete-3608462-fix-expected.checksum:
        * editing/deleting/delete-3608462-fix-expected.png:
        * editing/deleting/delete-3959464-fix-expected.checksum:
        * editing/deleting/delete-3959464-fix-expected.png:
        * editing/deleting/delete-4038408-fix-expected.checksum:
        * editing/deleting/delete-4038408-fix-expected.png:
        * editing/deleting/delete-4083333-fix-expected.checksum:
        * editing/deleting/delete-4083333-fix-expected.png:
        * editing/deleting/delete-after-span-ws-001-expected.checksum:
        * editing/deleting/delete-after-span-ws-001-expected.png:
        * editing/deleting/delete-after-span-ws-002-expected.checksum:
        * editing/deleting/delete-after-span-ws-002-expected.png:
        * editing/deleting/delete-after-span-ws-003-expected.checksum:
        * editing/deleting/delete-after-span-ws-003-expected.png:
        * editing/deleting/delete-and-undo-expected.checksum:
        * editing/deleting/delete-and-undo-expected.png:
        * editing/deleting/delete-at-paragraph-boundaries-001-expected.checksum:
        * editing/deleting/delete-at-paragraph-boundaries-001-expected.png:
        * editing/deleting/delete-at-paragraph-boundaries-002-expected.checksum:
        * editing/deleting/delete-at-paragraph-boundaries-002-expected.png:
        * editing/deleting/delete-at-paragraph-boundaries-003-expected.checksum:
        * editing/deleting/delete-at-paragraph-boundaries-003-expected.png:
        * editing/deleting/delete-at-paragraph-boundaries-004-expected.checksum:
        * editing/deleting/delete-at-paragraph-boundaries-004-expected.png:
        * editing/deleting/delete-at-paragraph-boundaries-005-expected.checksum:
        * editing/deleting/delete-at-paragraph-boundaries-005-expected.png:
        * editing/deleting/delete-at-paragraph-boundaries-006-expected.checksum:
        * editing/deleting/delete-at-paragraph-boundaries-006-expected.png:
        * editing/deleting/delete-at-paragraph-boundaries-007-expected.checksum:
        * editing/deleting/delete-at-paragraph-boundaries-007-expected.png:
        * editing/deleting/delete-at-paragraph-boundaries-008-expected.checksum:
        * editing/deleting/delete-at-paragraph-boundaries-008-expected.png:
        * editing/deleting/delete-at-paragraph-boundaries-009-expected.checksum:
        * editing/deleting/delete-at-paragraph-boundaries-009-expected.png:
        * editing/deleting/delete-at-paragraph-boundaries-010-expected.checksum:
        * editing/deleting/delete-at-paragraph-boundaries-010-expected.png:
        * editing/deleting/delete-at-paragraph-boundaries-011-expected.checksum:
        * editing/deleting/delete-at-paragraph-boundaries-011-expected.png:
        * editing/deleting/delete-block-contents-001-expected.checksum:
        * editing/deleting/delete-block-contents-001-expected.png:
        * editing/deleting/delete-block-contents-002-expected.checksum:
        * editing/deleting/delete-block-contents-002-expected.png:
        * editing/deleting/delete-block-contents-003-expected.checksum:
        * editing/deleting/delete-block-contents-003-expected.png:
        * editing/deleting/delete-block-merge-contents-001-expected.checksum:
        * editing/deleting/delete-block-merge-contents-001-expected.png:
        * editing/deleting/delete-block-merge-contents-002-expected.checksum:
        * editing/deleting/delete-block-merge-contents-002-expected.png:
        * editing/deleting/delete-block-merge-contents-003-expected.checksum:
        * editing/deleting/delete-block-merge-contents-003-expected.png:
        * editing/deleting/delete-block-merge-contents-004-expected.checksum:
        * editing/deleting/delete-block-merge-contents-004-expected.png:
        * editing/deleting/delete-block-merge-contents-005-expected.checksum:
        * editing/deleting/delete-block-merge-contents-005-expected.png:
        * editing/deleting/delete-block-merge-contents-006-expected.checksum:
        * editing/deleting/delete-block-merge-contents-006-expected.png:
        * editing/deleting/delete-block-merge-contents-007-expected.checksum:
        * editing/deleting/delete-block-merge-contents-007-expected.png:
        * editing/deleting/delete-block-merge-contents-008-expected.checksum:
        * editing/deleting/delete-block-merge-contents-008-expected.png:
        * editing/deleting/delete-block-merge-contents-009-expected.checksum:
        * editing/deleting/delete-block-merge-contents-009-expected.png:
        * editing/deleting/delete-block-merge-contents-010-expected.checksum:
        * editing/deleting/delete-block-merge-contents-010-expected.png:
        * editing/deleting/delete-block-merge-contents-011-expected.checksum:
        * editing/deleting/delete-block-merge-contents-011-expected.png:
        * editing/deleting/delete-block-merge-contents-012-expected.checksum:
        * editing/deleting/delete-block-merge-contents-012-expected.png:
        * editing/deleting/delete-block-merge-contents-013-expected.checksum:
        * editing/deleting/delete-block-merge-contents-013-expected.png:
        * editing/deleting/delete-block-merge-contents-014-expected.checksum:
        * editing/deleting/delete-block-merge-contents-014-expected.png:
        * editing/deleting/delete-block-merge-contents-015-expected.checksum:
        * editing/deleting/delete-block-merge-contents-015-expected.png:
        * editing/deleting/delete-block-merge-contents-016-expected.checksum:
        * editing/deleting/delete-block-merge-contents-016-expected.png:
        * editing/deleting/delete-block-merge-contents-017-expected.checksum:
        * editing/deleting/delete-block-merge-contents-017-expected.png:
        * editing/deleting/delete-br-001-expected.checksum:
        * editing/deleting/delete-br-001-expected.png:
        * editing/deleting/delete-br-002-expected.checksum:
        * editing/deleting/delete-br-002-expected.png:
        * editing/deleting/delete-br-003-expected.checksum:
        * editing/deleting/delete-br-003-expected.png:
        * editing/deleting/delete-br-004-expected.checksum:
        * editing/deleting/delete-br-004-expected.png:
        * editing/deleting/delete-br-005-expected.checksum:
        * editing/deleting/delete-br-005-expected.png:
        * editing/deleting/delete-br-006-expected.checksum:
        * editing/deleting/delete-br-006-expected.png:
        * editing/deleting/delete-br-007-expected.checksum:
        * editing/deleting/delete-br-007-expected.png:
        * editing/deleting/delete-character-001-expected.checksum:
        * editing/deleting/delete-character-001-expected.png:
        * editing/deleting/delete-contiguous-ws-001-expected.checksum:
        * editing/deleting/delete-contiguous-ws-001-expected.png:
        * editing/deleting/delete-image-001-expected.checksum:
        * editing/deleting/delete-image-001-expected.png:
        * editing/deleting/delete-image-002-expected.checksum:
        * editing/deleting/delete-image-002-expected.png:
        * editing/deleting/delete-image-003-expected.checksum:
        * editing/deleting/delete-image-003-expected.png:
        * editing/deleting/delete-image-004-expected.checksum:
        * editing/deleting/delete-image-004-expected.png:
        * editing/deleting/delete-leading-ws-001-expected.checksum:
        * editing/deleting/delete-leading-ws-001-expected.png:
        * editing/deleting/delete-line-015-expected.checksum:
        * editing/deleting/delete-line-015-expected.png:
        * editing/deleting/delete-line-016-expected.checksum:
        * editing/deleting/delete-line-016-expected.png:
        * editing/deleting/delete-line-017-expected.checksum:
        * editing/deleting/delete-line-017-expected.png:
        * editing/deleting/delete-line-end-ws-001-expected.checksum:
        * editing/deleting/delete-line-end-ws-001-expected.png:
        * editing/deleting/delete-line-end-ws-002-expected.checksum:
        * editing/deleting/delete-line-end-ws-002-expected.png:
        * editing/deleting/delete-listitem-001-expected.checksum:
        * editing/deleting/delete-listitem-001-expected.png:
        * editing/deleting/delete-listitem-002-expected.checksum:
        * editing/deleting/delete-listitem-002-expected.png:
        * editing/deleting/delete-select-all-001-expected.checksum:
        * editing/deleting/delete-select-all-001-expected.png:
        * editing/deleting/delete-select-all-002-expected.checksum:
        * editing/deleting/delete-select-all-002-expected.png:
        * editing/deleting/delete-select-all-003-expected.checksum:
        * editing/deleting/delete-select-all-003-expected.png:
        * editing/deleting/delete-selection-001-expected.checksum:
        * editing/deleting/delete-selection-001-expected.png:
        * editing/deleting/delete-tab-001-expected.checksum:
        * editing/deleting/delete-tab-001-expected.png:
        * editing/deleting/delete-tab-002-expected.checksum:
        * editing/deleting/delete-tab-002-expected.png:
        * editing/deleting/delete-tab-003-expected.checksum:
        * editing/deleting/delete-tab-003-expected.png:
        * editing/deleting/delete-tab-004-expected.checksum:
        * editing/deleting/delete-tab-004-expected.png:
        * editing/deleting/delete-trailing-ws-001-expected.checksum:
        * editing/deleting/delete-trailing-ws-001-expected.png:
        * editing/deleting/delete-trailing-ws-002-expected.checksum:
        * editing/deleting/delete-trailing-ws-002-expected.png:
        * editing/deleting/delete-ws-fixup-001-expected.checksum:
        * editing/deleting/delete-ws-fixup-001-expected.png:
        * editing/deleting/delete-ws-fixup-002-expected.checksum:
        * editing/deleting/delete-ws-fixup-002-expected.png:
        * editing/deleting/delete-ws-fixup-003-expected.checksum:
        * editing/deleting/delete-ws-fixup-003-expected.png:
        * editing/deleting/delete-ws-fixup-004-expected.checksum:
        * editing/deleting/delete-ws-fixup-004-expected.png:
        * editing/deleting/smart-delete-001-expected.checksum:
        * editing/deleting/smart-delete-001-expected.png:
        * editing/deleting/smart-delete-002-expected.checksum:
        * editing/deleting/smart-delete-002-expected.png:
        * editing/execCommand/boldSelection-expected.checksum:
        * editing/execCommand/boldSelection-expected.png:
        * editing/execCommand/insertHTML-expected.checksum:
        * editing/execCommand/insertHTML-expected.png:
        * editing/execCommand/insertImage-expected.checksum:
        * editing/execCommand/insertImage-expected.png:
        * editing/execCommand/italicizeByCharacter-expected.checksum:
        * editing/execCommand/italicizeByCharacter-expected.png:
        * editing/execCommand/modifyForeColorByCharacter-expected.checksum:
        * editing/execCommand/modifyForeColorByCharacter-expected.png:
        * editing/execCommand/print-expected.checksum:
        * editing/execCommand/print-expected.png:
        * editing/execCommand/selectAll-expected.checksum:
        * editing/execCommand/selectAll-expected.png:
        * editing/execCommand/strikethroughSelection-expected.checksum:
        * editing/execCommand/strikethroughSelection-expected.png:
        * editing/inserting/4278698-expected.checksum:
        * editing/inserting/4278698-expected.png:
        * editing/inserting/editing-empty-divs-expected.checksum:
        * editing/inserting/editing-empty-divs-expected.png:
        * editing/inserting/insert-3659587-fix-expected.checksum:
        * editing/inserting/insert-3659587-fix-expected.png:
        * editing/inserting/insert-3775316-fix-expected.checksum:
        * editing/inserting/insert-3775316-fix-expected.png:
        * editing/inserting/insert-3778059-fix-expected.checksum:
        * editing/inserting/insert-3778059-fix-expected.png:
        * editing/inserting/insert-3800346-fix-expected.checksum:
        * editing/inserting/insert-3800346-fix-expected.png:
        * editing/inserting/insert-after-delete-001-expected.checksum:
        * editing/inserting/insert-after-delete-001-expected.png:
        * editing/inserting/insert-at-end-01-expected.checksum:
        * editing/inserting/insert-at-end-01-expected.png:
        * editing/inserting/insert-at-end-02-expected.checksum:
        * editing/inserting/insert-at-end-02-expected.png:
        * editing/inserting/insert-br-001-expected.checksum:
        * editing/inserting/insert-br-001-expected.png:
        * editing/inserting/insert-br-002-expected.checksum:
        * editing/inserting/insert-br-002-expected.png:
        * editing/inserting/insert-br-003-expected.checksum:
        * editing/inserting/insert-br-003-expected.png:
        * editing/inserting/insert-br-004-expected.checksum:
        * editing/inserting/insert-br-004-expected.png:
        * editing/inserting/insert-br-005-expected.checksum:
        * editing/inserting/insert-br-005-expected.png:
        * editing/inserting/insert-br-006-expected.checksum:
        * editing/inserting/insert-br-006-expected.png:
        * editing/inserting/insert-br-007-expected.checksum:
        * editing/inserting/insert-br-007-expected.png:
        * editing/inserting/insert-br-008-expected.checksum:
        * editing/inserting/insert-br-008-expected.png:
        * editing/inserting/insert-br-at-tabspan-001-expected.checksum:
        * editing/inserting/insert-br-at-tabspan-001-expected.png:
        * editing/inserting/insert-br-at-tabspan-002-expected.checksum:
        * editing/inserting/insert-br-at-tabspan-002-expected.png:
        * editing/inserting/insert-br-at-tabspan-003-expected.checksum:
        * editing/inserting/insert-br-at-tabspan-003-expected.png:
        * editing/inserting/insert-br-quoted-001-expected.checksum:
        * editing/inserting/insert-br-quoted-001-expected.png:
        * editing/inserting/insert-br-quoted-002-expected.checksum:
        * editing/inserting/insert-br-quoted-002-expected.png:
        * editing/inserting/insert-br-quoted-003-expected.checksum:
        * editing/inserting/insert-br-quoted-003-expected.png:
        * editing/inserting/insert-br-quoted-004-expected.checksum:
        * editing/inserting/insert-br-quoted-004-expected.png:
        * editing/inserting/insert-br-quoted-005-expected.checksum:
        * editing/inserting/insert-br-quoted-005-expected.png:
        * editing/inserting/insert-br-quoted-006-expected.checksum:
        * editing/inserting/insert-br-quoted-006-expected.png:
        * editing/inserting/insert-div-025-expected.checksum:
        * editing/inserting/insert-div-025-expected.png:
        * editing/inserting/insert-div-026-expected.checksum:
        * editing/inserting/insert-div-026-expected.png:
        * editing/inserting/insert-space-in-empty-doc-expected.checksum:
        * editing/inserting/insert-space-in-empty-doc-expected.png:
        * editing/inserting/insert-tab-001-expected.checksum:
        * editing/inserting/insert-tab-001-expected.png:
        * editing/inserting/insert-tab-002-expected.checksum:
        * editing/inserting/insert-tab-002-expected.png:
        * editing/inserting/insert-tab-003-expected.checksum:
        * editing/inserting/insert-tab-003-expected.png:
        * editing/inserting/insert-tab-004-expected.checksum:
        * editing/inserting/insert-tab-004-expected.png:
        * editing/inserting/insert-text-at-tabspan-001-expected.checksum:
        * editing/inserting/insert-text-at-tabspan-001-expected.png:
        * editing/inserting/insert-text-at-tabspan-002-expected.checksum:
        * editing/inserting/insert-text-at-tabspan-002-expected.png:
        * editing/inserting/insert-text-at-tabspan-003-expected.checksum:
        * editing/inserting/insert-text-at-tabspan-003-expected.png:
        * editing/inserting/insert-text-with-newlines-expected.checksum:
        * editing/inserting/insert-text-with-newlines-expected.png:
        * editing/inserting/return-key-with-selection-001-expected.checksum:
        * editing/inserting/return-key-with-selection-001-expected.png:
        * editing/inserting/return-key-with-selection-002-expected.checksum:
        * editing/inserting/return-key-with-selection-002-expected.png:
        * editing/inserting/return-key-with-selection-003-expected.checksum:
        * editing/inserting/return-key-with-selection-003-expected.png:
        * editing/inserting/typing-001-expected.checksum:
        * editing/inserting/typing-001-expected.png:
        * editing/inserting/typing-002-expected.checksum:
        * editing/inserting/typing-002-expected.png:
        * editing/inserting/typing-003-expected.checksum:
        * editing/inserting/typing-003-expected.png:
        * editing/inserting/typing-around-br-001-expected.checksum:
        * editing/inserting/typing-around-br-001-expected.png:
        * editing/inserting/typing-around-image-001-expected.checksum:
        * editing/inserting/typing-around-image-001-expected.png:
        * editing/pasteboard/3976872-expected.checksum:
        * editing/pasteboard/3976872-expected.png:
        * editing/pasteboard/4076267-2-expected.checksum:
        * editing/pasteboard/4076267-2-expected.png:
        * editing/pasteboard/4076267-3-expected.checksum:
        * editing/pasteboard/4076267-3-expected.png:
        * editing/pasteboard/4076267-expected.checksum:
        * editing/pasteboard/4076267-expected.png:
        * editing/pasteboard/block-wrappers-necessary-expected.checksum:
        * editing/pasteboard/block-wrappers-necessary-expected.png:
        * editing/pasteboard/cut-text-001-expected.checksum:
        * editing/pasteboard/cut-text-001-expected.png:
        * editing/pasteboard/display-block-on-spans-expected.checksum:
        * editing/pasteboard/display-block-on-spans-expected.png:
        * editing/pasteboard/paste-4035648-fix-expected.checksum:
        * editing/pasteboard/paste-4035648-fix-expected.png:
        * editing/pasteboard/paste-4038267-fix-expected.checksum:
        * editing/pasteboard/paste-4038267-fix-expected.png:
        * editing/pasteboard/paste-4039777-fix-expected.checksum:
        * editing/pasteboard/paste-4039777-fix-expected.png:
        * editing/pasteboard/paste-line-endings-001-expected.checksum:
        * editing/pasteboard/paste-line-endings-001-expected.png:
        * editing/pasteboard/paste-line-endings-002-expected.checksum:
        * editing/pasteboard/paste-line-endings-002-expected.png:
        * editing/pasteboard/paste-line-endings-003-expected.checksum:
        * editing/pasteboard/paste-line-endings-003-expected.png:
        * editing/pasteboard/paste-line-endings-004-expected.checksum:
        * editing/pasteboard/paste-line-endings-004-expected.png:
        * editing/pasteboard/paste-line-endings-005-expected.checksum:
        * editing/pasteboard/paste-line-endings-005-expected.png:
        * editing/pasteboard/paste-line-endings-006-expected.checksum:
        * editing/pasteboard/paste-line-endings-006-expected.png:
        * editing/pasteboard/paste-line-endings-007-expected.checksum:
        * editing/pasteboard/paste-line-endings-007-expected.png:
        * editing/pasteboard/paste-line-endings-008-expected.checksum:
        * editing/pasteboard/paste-line-endings-008-expected.png:
        * editing/pasteboard/paste-line-endings-009-expected.checksum:
        * editing/pasteboard/paste-line-endings-009-expected.png:
        * editing/pasteboard/paste-line-endings-010-expected.checksum:
        * editing/pasteboard/paste-line-endings-010-expected.png:
        * editing/pasteboard/paste-list-001-expected.checksum:
        * editing/pasteboard/paste-list-001-expected.png:
        * editing/pasteboard/paste-match-style-001-expected.checksum:
        * editing/pasteboard/paste-match-style-001-expected.png:
        * editing/pasteboard/paste-match-style-002-expected.checksum:
        * editing/pasteboard/paste-match-style-002-expected.png:
        * editing/pasteboard/paste-pre-001-expected.checksum:
        * editing/pasteboard/paste-pre-001-expected.png:
        * editing/pasteboard/paste-pre-002-expected.checksum:
        * editing/pasteboard/paste-pre-002-expected.png:
        * editing/pasteboard/paste-table-001-expected.checksum:
        * editing/pasteboard/paste-table-001-expected.png:
        * editing/pasteboard/paste-text-001-expected.checksum:
        * editing/pasteboard/paste-text-001-expected.png:
        * editing/pasteboard/paste-text-017-expected.checksum:
        * editing/pasteboard/paste-text-017-expected.png:
        * editing/pasteboard/paste-text-018-expected.checksum:
        * editing/pasteboard/paste-text-018-expected.png:
        * editing/pasteboard/paste-text-019-expected.checksum:
        * editing/pasteboard/paste-text-019-expected.png:
        * editing/pasteboard/paste-text-at-tabspan-001-expected.checksum:
        * editing/pasteboard/paste-text-at-tabspan-001-expected.png:
        * editing/pasteboard/paste-text-at-tabspan-002-expected.checksum:
        * editing/pasteboard/paste-text-at-tabspan-002-expected.png:
        * editing/pasteboard/paste-text-at-tabspan-003-expected.checksum:
        * editing/pasteboard/paste-text-at-tabspan-003-expected.png:
        * editing/pasteboard/smart-paste-001-expected.checksum:
        * editing/pasteboard/smart-paste-001-expected.png:
        * editing/pasteboard/smart-paste-002-expected.checksum:
        * editing/pasteboard/smart-paste-002-expected.png:
        * editing/pasteboard/smart-paste-003-expected.checksum:
        * editing/pasteboard/smart-paste-003-expected.png:
        * editing/pasteboard/smart-paste-004-expected.checksum:
        * editing/pasteboard/smart-paste-004-expected.png:
        * editing/pasteboard/smart-paste-005-expected.checksum:
        * editing/pasteboard/smart-paste-005-expected.png:
        * editing/pasteboard/smart-paste-006-expected.checksum:
        * editing/pasteboard/smart-paste-006-expected.png:
        * editing/pasteboard/smart-paste-007-expected.checksum:
        * editing/pasteboard/smart-paste-007-expected.png:
        * editing/selection/3690703-expected.checksum:
        * editing/selection/3690703-expected.png:
        * editing/selection/3690719-expected.checksum:
        * editing/selection/3690719-expected.png:
        * editing/selection/6476-expected.checksum:
        * editing/selection/6476-expected.png:
        * editing/selection/after-line-wrap-expected.checksum:
        * editing/selection/after-line-wrap-expected.png:
        * editing/selection/end-of-document-expected.checksum:
        * editing/selection/end-of-document-expected.png:
        * editing/selection/expanding-selections-expected.checksum:
        * editing/selection/expanding-selections-expected.png:
        * editing/selection/expanding-selections2-expected.checksum:
        * editing/selection/expanding-selections2-expected.png:
        * editing/selection/extend-by-character-001-expected.checksum:
        * editing/selection/extend-by-character-001-expected.png:
        * editing/selection/extend-by-character-002-expected.checksum:
        * editing/selection/extend-by-character-002-expected.png:
        * editing/selection/extend-by-character-003-expected.checksum:
        * editing/selection/extend-by-character-003-expected.png:
        * editing/selection/extend-by-character-004-expected.checksum:
        * editing/selection/extend-by-character-004-expected.png:
        * editing/selection/extend-by-character-005-expected.checksum:
        * editing/selection/extend-by-character-005-expected.png:
        * editing/selection/extend-by-character-006-expected.checksum:
        * editing/selection/extend-by-character-006-expected.png:
        * editing/selection/extend-by-word-001-expected.checksum:
        * editing/selection/extend-by-word-001-expected.png:
        * editing/selection/extend-by-word-002-expected.checksum:
        * editing/selection/extend-by-word-002-expected.png:
        * editing/selection/fake-doubleclick-expected.checksum:
        * editing/selection/fake-doubleclick-expected.png:
        * editing/selection/fake-drag-expected.checksum:
        * editing/selection/fake-drag-expected.png:
        * editing/selection/iframe-expected.checksum:
        * editing/selection/iframe-expected.png:
        * editing/selection/image-before-linebreak-expected.checksum:
        * editing/selection/image-before-linebreak-expected.png:
        * editing/selection/inline-table-expected.checksum:
        * editing/selection/inline-table-expected.png:
        * editing/selection/leave-requested-block-expected.checksum:
        * editing/selection/leave-requested-block-expected.png:
        * editing/selection/move-backwords-by-word-001-expected.checksum:
        * editing/selection/move-backwords-by-word-001-expected.png:
        * editing/selection/move-between-blocks-no-001-expected.checksum:
        * editing/selection/move-between-blocks-no-001-expected.png:
        * editing/selection/move-by-character-001-expected.checksum:
        * editing/selection/move-by-character-001-expected.png:
        * editing/selection/move-by-character-002-expected.checksum:
        * editing/selection/move-by-character-002-expected.png:
        * editing/selection/move-by-character-003-expected.checksum:
        * editing/selection/move-by-character-003-expected.png:
        * editing/selection/move-by-character-004-expected.checksum:
        * editing/selection/move-by-character-004-expected.png:
        * editing/selection/move-by-character-005-expected.checksum:
        * editing/selection/move-by-character-005-expected.png:
        * editing/selection/move-by-character-6-expected.checksum:
        * editing/selection/move-by-character-6-expected.png:
        * editing/selection/move-by-line-001-expected.checksum:
        * editing/selection/move-by-line-001-expected.png:
        * editing/selection/move-by-line-002-expected.checksum:
        * editing/selection/move-by-line-002-expected.png:
        * editing/selection/move-by-word-001-expected.checksum:
        * editing/selection/move-by-word-001-expected.png:
        * editing/selection/previous-line-position-expected.checksum:
        * editing/selection/previous-line-position-expected.png:
        * editing/selection/replaced-boundaries-1-expected.checksum:
        * editing/selection/replaced-boundaries-1-expected.png:
        * editing/selection/replaced-boundaries-2-expected.checksum:
        * editing/selection/replaced-boundaries-2-expected.png:
        * editing/selection/replaced-boundaries-3-expected.checksum:
        * editing/selection/replaced-boundaries-3-expected.png:
        * editing/selection/select-all-001-expected.checksum:
        * editing/selection/select-all-001-expected.png:
        * editing/selection/select-all-002-expected.checksum:
        * editing/selection/select-all-002-expected.png:
        * editing/selection/select-box-expected.checksum:
        * editing/selection/select-box-expected.png:
        * editing/selection/selection-3748164-fix-expected.checksum:
        * editing/selection/selection-3748164-fix-expected.png:
        * editing/selection/triple-click-in-pre-expected.checksum:
        * editing/selection/triple-click-in-pre-expected.png:
        * editing/selection/unrendered-001-expected.checksum:
        * editing/selection/unrendered-001-expected.png:
        * editing/selection/unrendered-002-expected.checksum:
        * editing/selection/unrendered-002-expected.png:
        * editing/selection/unrendered-003-expected.checksum:
        * editing/selection/unrendered-003-expected.png:
        * editing/selection/unrendered-004-expected.checksum:
        * editing/selection/unrendered-004-expected.png:
        * editing/selection/unrendered-005-expected.checksum:
        * editing/selection/unrendered-005-expected.png:
        * editing/style/block-style-004-expected.checksum:
        * editing/style/block-style-004-expected.png:
        * editing/style/block-style-005-expected.checksum:
        * editing/style/block-style-005-expected.png:
        * editing/style/block-style-006-expected.checksum:
        * editing/style/block-style-006-expected.png:
        * editing/style/block-styles-007-expected.checksum:
        * editing/style/block-styles-007-expected.png:
        * editing/style/remove-underline-across-paragraph-expected.checksum:
        * editing/style/remove-underline-across-paragraph-expected.png:
        * editing/style/remove-underline-across-paragraph-in-bold-expected.checksum:
        * editing/style/remove-underline-across-paragraph-in-bold-expected.png:
        * editing/style/remove-underline-after-paragraph-expected.checksum:
        * editing/style/remove-underline-after-paragraph-expected.png:
        * editing/style/remove-underline-after-paragraph-in-bold-expected.checksum:
        * editing/style/remove-underline-after-paragraph-in-bold-expected.png:
        * editing/style/remove-underline-expected.checksum:
        * editing/style/remove-underline-expected.png:
        * editing/style/remove-underline-from-stylesheet-expected.checksum:
        * editing/style/remove-underline-from-stylesheet-expected.png:
        * editing/style/remove-underline-in-bold-expected.checksum:
        * editing/style/remove-underline-in-bold-expected.png:
        * editing/style/smoosh-styles-001-expected.checksum:
        * editing/style/smoosh-styles-001-expected.png:
        * editing/style/smoosh-styles-002-expected.checksum:
        * editing/style/smoosh-styles-002-expected.png:
        * editing/style/smoosh-styles-003-expected.checksum:
        * editing/style/smoosh-styles-003-expected.png:
        * editing/style/style-3681552-fix-001-expected.checksum:
        * editing/style/style-3681552-fix-001-expected.png:
        * editing/style/style-3681552-fix-002-expected.checksum:
        * editing/style/style-3681552-fix-002-expected.png:
        * editing/style/style-3690704-fix-expected.checksum:
        * editing/style/style-3690704-fix-expected.png:
        * editing/style/style-3998892-fix-expected.checksum:
        * editing/style/style-3998892-fix-expected.png:
        * editing/style/style-boundary-001-expected.checksum:
        * editing/style/style-boundary-001-expected.png:
        * editing/style/style-boundary-002-expected.checksum:
        * editing/style/style-boundary-002-expected.png:
        * editing/style/style-boundary-003-expected.checksum:
        * editing/style/style-boundary-003-expected.png:
        * editing/style/style-boundary-004-expected.checksum:
        * editing/style/style-boundary-004-expected.png:
        * editing/style/typing-style-001-expected.checksum:
        * editing/style/typing-style-001-expected.png:
        * editing/style/typing-style-002-expected.checksum:
        * editing/style/typing-style-002-expected.png:
        * editing/style/typing-style-003-expected.checksum:
        * editing/style/typing-style-003-expected.png:
        * editing/style/unbold-in-bold-expected.checksum:
        * editing/style/unbold-in-bold-expected.png:
        * editing/style/underline-expected.checksum:
        * editing/style/underline-expected.png:
        * editing/undo/4063751-expected.checksum:
        * editing/undo/4063751-expected.png:
        * editing/undo/redo-typing-001-expected.checksum:
        * editing/undo/redo-typing-001-expected.png:
        * editing/undo/undo-typing-001-expected.checksum:
        * editing/undo/undo-typing-001-expected.png:
        * editing/unsupported-content/list-delete-001-expected.checksum:
        * editing/unsupported-content/list-delete-001-expected.png:
        * editing/unsupported-content/list-delete-002-expected.checksum:
        * editing/unsupported-content/list-delete-002-expected.png:
        * editing/unsupported-content/list-delete-003-expected.checksum:
        * editing/unsupported-content/list-delete-003-expected.png:
        * editing/unsupported-content/list-type-after-expected.checksum:
        * editing/unsupported-content/list-type-after-expected.png:
        * editing/unsupported-content/list-type-before-expected.checksum:
        * editing/unsupported-content/list-type-before-expected.png:
        * editing/unsupported-content/table-delete-001-expected.checksum:
        * editing/unsupported-content/table-delete-001-expected.png:
        * editing/unsupported-content/table-delete-002-expected.checksum:
        * editing/unsupported-content/table-delete-002-expected.png:
        * editing/unsupported-content/table-delete-003-expected.checksum:
        * editing/unsupported-content/table-delete-003-expected.png:
        * editing/unsupported-content/table-type-after-expected.checksum:
        * editing/unsupported-content/table-type-after-expected.png:
        * editing/unsupported-content/table-type-before-expected.checksum:
        * editing/unsupported-content/table-type-before-expected.png:
        * fast/css/outline-auto-empty-rects-expected.checksum:
        * fast/css/outline-auto-empty-rects-expected.png:
        * fast/css/outline-auto-location-expected.checksum:
        * fast/css/outline-auto-location-expected.png:
        * fast/dom/focus-contenteditable-expected.checksum:
        * fast/dom/focus-contenteditable-expected.png:
        * fast/encoding/utf-16-big-endian-expected.checksum:
        * fast/encoding/utf-16-big-endian-expected.png:
        * fast/encoding/utf-16-little-endian-expected.checksum:
        * fast/encoding/utf-16-little-endian-expected.png:
        * fast/events/focusingUnloadedFrame-expected.checksum:
        * fast/events/focusingUnloadedFrame-expected.png:
        * fast/forms/input-appearance-focus-expected.checksum:
        * fast/forms/input-appearance-focus-expected.png:
        * fast/forms/input-appearance-readonly-expected.checksum: Added.
        * fast/forms/input-appearance-readonly-expected.png: Added.
        * fast/forms/input-appearance-selection-expected.checksum:
        * fast/forms/input-appearance-selection-expected.png:
        * fast/forms/input-paste-undo-expected.checksum: Added.
        * fast/forms/input-paste-undo-expected.png: Added.
        * fast/forms/input-text-double-click-expected.checksum:
        * fast/forms/input-text-double-click-expected.png:
        * fast/forms/input-text-option-delete-expected.checksum:
        * fast/forms/input-text-option-delete-expected.png:
        * fast/forms/input-text-scroll-left-on-blur-expected.checksum:
        * fast/forms/input-text-scroll-left-on-blur-expected.png:
        * fast/lists/drag-into-marker-expected.checksum:
        * fast/lists/drag-into-marker-expected.png:
        * fast/overflow/childFocusRingClip-expected.checksum:
        * fast/overflow/childFocusRingClip-expected.png:
        * fast/overflow/overflow-focus-ring-expected.checksum:
        * fast/overflow/overflow-focus-ring-expected.png:
        * fast/text/justified-text-rect-expected.checksum:
        * fast/text/justified-text-rect-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - updated layout test results, mostly for the change in focus ring appearance
darin [Mon, 3 Apr 2006 01:16:44 +0000 (01:16 +0000)]
    - updated layout test results, mostly for the change in focus ring appearance

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - updated layout test results, mostly for the change in focus ring appearance
darin [Mon, 3 Apr 2006 01:15:48 +0000 (01:15 +0000)]
    - updated layout test results, mostly for the change in focus ring appearance

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - updated layout test results, mostly for the change in focus ring appearance
darin [Mon, 3 Apr 2006 01:14:58 +0000 (01:14 +0000)]
    - updated layout test results, mostly for the change in focus ring appearance

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - updated layout test results, mostly for the change in focus ring appearance
darin [Mon, 3 Apr 2006 01:12:38 +0000 (01:12 +0000)]
    - updated layout test results, mostly for the change in focus ring appearance

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adele.
darin [Mon, 3 Apr 2006 01:11:28 +0000 (01:11 +0000)]
    Reviewed by Adele.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8123
          focus ring on new text field doesn't look like the old one

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7685
          Focus ring color should change to match graphite when system theme is graphite

        - some cleanup to how we parse user agent style sheets

        * css/CSSValueKeywords.in: Added -webkit-focus-ring-color.

        * css/cssstyleselector.cpp:
        (WebCore::parseUASheet): Parse an array of chars instead of UTF-16.
        Cuts the size of the style sheet in half.
        (WebCore::CSSStyleSelector::applyProperty): Allow negative value for
        outline-offset. Changed shadow parsing to use getColorFromPrimitiveValue
        instead of repeating the same logic.
        (WebCore::CSSStyleSelector::getColorFromPrimitiveValue): Added a case
        for the focus ring color.
        * rendering/render_style.h: (WebCore::RenderStyle::setOutlineOffset):
        Changed to allow negative values.

        * css/html4.css: Removed a lot of excess spaces. Changed color of focus
        to -webkit-focus-ring-color. Changed width of focus to 5px.
        Added an outline-offset for <input type=text> of -2px.

        * css/cssparser.cpp:
        (WebCore::CSSParser::parseValue): Added focus ring color as an outline color all
        the time, and as any other color when not in strict mode. I'm confused about what's
        best for this whole strict mode policy, and I may need advice on Hyatt to perfect
        this one later.
        (WebCore::CSSParser::parseColorFromValue): Removed code to pin r, g, and b because
        the functions in platform already take care of that. Kept the pinning of a, though
        because that's done in floating point before converting to an integer.
        (WebCore::CSSParser::parseShadow): Allow focus ring color when not in strict mode.

        * bridge/mac/FrameMac.h: Eliminated the virtual detachFromView function.
        * bridge/mac/FrameMac.mm:
        (WebCore::FrameMac::FrameMac): Eliminated code to maintain the frame instances list.
        (WebCore::FrameMac::~FrameMac): Ditto.
        (WebCore::Frame::setNeedsReapplyStyles): Added.

        * bridge/mac/WebCoreSettings.mm: (-[WebCoreSettings _updateAllViews]):
        * platform/mac/WebCoreTextRendererFactory.mm:
        (-[WebCoreTextRendererFactory clearCaches]):
        Changed to call the new Page::setNeedsReapplyStylesForSettingsChange instead of using the
        obsolete Frame::instances.

        * page/Frame.h: Removed instances, mutableInstances, and detachFromView.
        * page/Frame.cpp: Ditto.

        * page/FrameTree.cpp:
        (WebCore::FrameTree::~FrameTree): Call setView(0) instead of detachFromView().
        (WebCore::FrameTree::removeChild): Ditto.

        * page/Page.h:
        * page/Page.cpp:
        (WebCore::Page::init): Added a set of pages instead of a page count. Also
        register a function for when the focus ring color changes the first time this
        is called.
        (WebCore::Page::~Page): Call setView(0) instead of detachFromView. Also update
        to manager the set of pages.
        (WebCore::Page::setNeedsReapplyStyles): Call setNeedsReapplyStyles on all frames.
        (WebCore::Page::setNeedsReapplyStylesForSettingsChange): Call setNeedsReapplyStyles
        on all frames with the passed-in settings.

        * css/make-css-file-arrays.pl: Changed to run the C preprocessor on the
        input files and to generate an array of char instead of unsigned short.

        * platform/PlatformString.h: Added a constructor that takes a char* and
        a length.
        * platform/String.cpp: (WebCore::String::String): Ditto.

        * WebCore.xcodeproj/project.pbxproj: Just some tweaks; adding in a few files like
        the user agent style sheets.

        * platform/Color.h: Removed all use of DeprecatedString. Cleaned up a bit.
        Added focusRingColor and setFocusRingColorChangeFunction.
        * platform/Color.cpp:
        (WebCore::makeRGB): Rewrote using max and min.
        (WebCore::makeRGBA): Ditto.
        (WebCore::parseHexColor): Cleaned up a bit; changed partway to String instead of
        DeprecatedString.
        (WebCore::Color::Color): Changed to use String and to call setNamedColor to save code.
        (WebCore::Color::setNamedColor): Changed to use String in the interface.

        * platform/mac/ColorMac.mm:
        (WebCore::observeTheme): Added. Function used to start up the observer.
        (WebCore::setFocusRingColorChangeFunction): Added. Used to get a call back so we can
        update all the views when the color changes (including recomputing style to get the
        color change in).
        (WebCore::setFocusRingColorChangeFunction): Added. Returns one of the two focus
        ring colors. Both of these match what AppKit uses -- neither matches what we used
        to have in the html4.css file.
        (+[WebCoreControlTintObserver controlTintDidChange]): Added. Used to update when
        the appearance is changed from blue to graphite and back. We keep a global so we
        don't have to call over to AppKit every time; that's probably overkill but we need
        the obsever for the color change function anyway.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
adele [Sun, 2 Apr 2006 19:54:25 +0000 (19:54 +0000)]
LayoutTests:

        Reviewed by Darin.

        - Test for http://bugzilla.opendarwin.org/show_bug.cgi?id=8118
          REGRESSION (r13595): Inline block's clipped overflow increases table row height

        * fast/inline-block/overflow-clip-expected.checksum: Added.
        * fast/inline-block/overflow-clip-expected.png: Added.
        * fast/inline-block/overflow-clip-expected.txt: Added.
        * fast/inline-block/overflow-clip.html: Added.

WebCore:

        Test: fast/inline-block/overflow-clip.html

        Reviewed by Darin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8118
          REGRESSION (r13595): Inline block's clipped overflow increases table row height

        * rendering/render_line.cpp:
        (WebCore::InlineFlowBox::placeBoxesVertically): Don't look at interior overflow
        when calculating the contribution to the inline's vertical overflows.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-04-02 Eric Seidel <eseidel@apple.com>
eseidel [Sun, 2 Apr 2006 12:13:27 +0000 (12:13 +0000)]
2006-04-02  Eric Seidel  <eseidel@apple.com>

        Reviewed by andersca.

        Make WebCore safe against KJS::Node in JavaScriptCore private headers.

        * editing/ReplaceSelectionCommand.h:
        * khtml/ecma/JSXMLSerializer.cpp:
        (KJS::XMLSerializerProtoFunc::callAsFunction):
        * khtml/ecma/JSXSLTProcessor.cpp:
        (KJS::XSLTProcessorProtoFunc::callAsFunction):
        * khtml/ecma/kjs_binding.cpp:
        (KJS::ScriptInterpreter::forgetDOMNodeForDocument):
        (KJS::ScriptInterpreter::putDOMNodeForDocument):
        * khtml/ecma/kjs_dom.cpp:
        (KJS::DOMNode::DOMNode):
        (KJS::DOMNode::mark):
        (KJS::DOMNode::getValueProperty):
        (KJS::DOMNode::putValueProperty):
        (KJS::DOMNodeProtoFunc::callAsFunction):
        (KJS::toNode):
        (KJS::DOMEventTargetNode::DOMEventTargetNode):
        (KJS::DOMDocumentProtoFunc::callAsFunction):
        (KJS::DOMElement::putValueProperty):
        (KJS::DOMElementProtoFunc::callAsFunction):
        (KJS::checkNodeSecurity):
        (KJS::toJS):
        (KJS::getRuntimeObject):
        (KJS::DOMNamedNodesCollection::DOMNamedNodesCollection):
        (KJS::DOMNamedNodesCollection::getOwnPropertySlot):
        * khtml/ecma/kjs_events.cpp:
        (KJS::JSLazyEventListener::JSLazyEventListener):
        (KJS::ClipboardProtoFunc::callAsFunction):
        * khtml/ecma/kjs_html.cpp:
        (KJS::JSHTMLDocument::namedItemGetter):
        (KJS::JSHTMLElement::framesetNameGetter):
        (KJS::JSHTMLElement::getOwnPropertySlot):
        (KJS::JSHTMLElement::pushEventHandlerScope):
        (KJS::JSHTMLCollection::callAsFunction):
        (KJS::JSHTMLCollection::getNamedItems):
        (KJS::JSHTMLSelectCollection::put):
        * khtml/ecma/kjs_traversal.cpp:
        (KJS::JSNodeFilterCondition::acceptNode):
        * khtml/ecma/kjs_window.cpp:
        (KJS::Window::put):
        * kwq/KWQPageState.mm:
        (-[KWQPageState WebCore::]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-04-02 Eric Seidel <eseidel@apple.com>
eseidel [Sun, 2 Apr 2006 11:41:38 +0000 (11:41 +0000)]
2006-04-02  Eric Seidel  <eseidel@apple.com>

        Reviewed by andersca.

        Add missing forwarding header.

        * kxmlcore/Vector.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
ggaren [Sun, 2 Apr 2006 08:55:58 +0000 (08:55 +0000)]
    Reviewed by Darin.

        - Fixed <rdar://problem/4430836> JavaScript patch crashing Quartz
        Composer

        JSValueWrappers used to hold on to the ExecState that pertained at
        the time of their creation. Since ExecStates are transient, that
        design was totally bogus, and it would crash once the ExecState had
        been deallocated.

        Unfortunately, there's no clean solution to this problem, since
        the JSGlue API has no notion of state. The solution here is to use
        a shared, global ExecState for the purpose of JSGlue calls. Given
        the pre-existing limitations in the JSGlue API, this design
        shouldn't actually introduce any new limitations (see comments in
        JSValueWrapper.cpp).

        I tested with Quartz Composer and PAC files, neither of which are
        layout-testable.

        * JSUtils.cpp:
        (KJSValueToJSObject):
        * JSValueWrapper.cpp:
        (JSValueWrapper::JSValueWrapper):
        (JSValueWrapper::GetValue):
        (getProcessGlobalExecState):
        (JSValueWrapper::JSObjectCopyPropertyNames):
        (JSValueWrapper::JSObjectCopyProperty):
        (JSValueWrapper::JSObjectSetProperty):
        (JSValueWrapper::JSObjectCallFunction):
        (JSValueWrapper::JSObjectCopyCFValue):
        * JSValueWrapper.h:

        Also added a test harness file. It was helpful while I was testing,
        and may come in handy in the future:

        * JavaScriptGlue.xcodeproj/project.pbxproj:
        testjsglue.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Eric.
darin [Sun, 2 Apr 2006 02:41:24 +0000 (02:41 +0000)]
    Reviewed by Eric.

        - removed a bunch of unneeded ForwardingHeaders and WebCore+SVG headers

        * ForwardingHeaders/kcanvas: Removed.
        * ForwardingHeaders/kcanvas/KCanvas.h: Removed.
        * ForwardingHeaders/kdom: Removed.
        * ForwardingHeaders/kdom/DOMString.h: Removed.
        * ForwardingHeaders/kdom/Helper.h: Removed.
        * ForwardingHeaders/kdom/KDOMSettings.h: Removed.
        * ForwardingHeaders/kdom/Namespace.h: Removed.
        * ForwardingHeaders/kdom/cache: Removed.
        * ForwardingHeaders/kdom/cache/KDOMCachedImage.h: Removed.
        * ForwardingHeaders/kdom/cache/KDOMCachedObject.h: Removed.
        * ForwardingHeaders/kdom/cache/KDOMCachedObjectClient.h: Removed.
        * ForwardingHeaders/kdom/cache/KDOMCachedScript.h: Removed.
        * ForwardingHeaders/kdom/cache/KDOMLoader.h: Removed.
        * ForwardingHeaders/kdom/core: Removed.
        * ForwardingHeaders/kdom/core/DOMConfiguration.h: Removed.
        * ForwardingHeaders/kdom/core/DOMException.h: Removed.
        * ForwardingHeaders/kdom/core/DOMList.h: Removed.
        * ForwardingHeaders/kdom/core/DOMString.h: Removed.
        * ForwardingHeaders/kdom/core/NamedAttrMap.h: Removed.
        * ForwardingHeaders/kdom/core/ProcessingInstruction.h: Removed.
        * ForwardingHeaders/kdom/core/domattrs.h: Removed.
        * ForwardingHeaders/kdom/ecma: Removed.
        * ForwardingHeaders/kdom/ecma/GlobalObject.h: Removed.
        * ForwardingHeaders/kdom/events: Removed.
        * ForwardingHeaders/kdom/events/Event.h: Removed.
        * ForwardingHeaders/kdom/events/EventListener.h: Removed.
        * ForwardingHeaders/kdom/events/EventTarget.h: Removed.
        * ForwardingHeaders/kdom/events/KeyboardEvent.h: Removed.
        * ForwardingHeaders/kdom/events/MouseEvent.h: Removed.
        * ForwardingHeaders/kdom/events/UIEvent.h: Removed.
        * ForwardingHeaders/kdom/events/kdomevents.h: Removed.
        * ForwardingHeaders/kdom/kdom.h: Removed.
        * ForwardingHeaders/kdom/parser: Removed.
        * ForwardingHeaders/kdom/parser/KDOMParser.h: Removed.
        * ForwardingHeaders/ksvg2: Removed.
        * ForwardingHeaders/ksvg2/KSVGPart.h: Removed.
        * ForwardingHeaders/ksvg2/KSVGView.h: Removed.
        * ForwardingHeaders/ksvg2/css: Removed.
        * ForwardingHeaders/ksvg2/css/CSSPropertyNames.h: Removed.
        * ForwardingHeaders/ksvg2/css/CSSValueKeywords.h: Removed.
        * WebCore+SVG/KDOMHeaders.h: Removed.
        * WebCore+SVG/Namespace.h: Removed.
        * WebCore+SVG/kdom.h: Removed.

        * WebCore.xcodeproj/project.pbxproj: Removed headers.

        * kcanvas/KCanvasCreator.cpp:
        * kcanvas/KCanvasResources.cpp:
        * kcanvas/KCanvasTreeDebug.cpp:
        * kcanvas/RenderPath.cpp:
        * kcanvas/RenderSVGImage.cpp:
        * kcanvas/device/quartz/KCanvasItemQuartz.mm:
        * kcanvas/device/quartz/KCanvasMaskerQuartz.mm:
        * kcanvas/device/quartz/KCanvasResourcesQuartz.mm:
        * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
        * ksvg2/css/SVGCSSStyleSelector.cpp:
        * ksvg2/events/SVGZoomEvent.h:
        * ksvg2/misc/KCanvasRenderingStyle.cpp:
        * ksvg2/misc/KSVGTimeScheduler.cpp:
        * ksvg2/misc/SVGImageLoader.cpp:
        * ksvg2/svg/SVGAElement.cpp:
        * ksvg2/svg/SVGAnimationElement.cpp:
        * ksvg2/svg/SVGCircleElement.cpp:
        * ksvg2/svg/SVGClipPathElement.cpp:
        * ksvg2/svg/SVGCursorElement.cpp:
        * ksvg2/svg/SVGCursorElement.h:
        * ksvg2/svg/SVGDOMImplementation.cpp:
        * ksvg2/svg/SVGDocument.cpp:
        * ksvg2/svg/SVGDocument.h:
        * ksvg2/svg/SVGElement.cpp:
        * ksvg2/svg/SVGEllipseElement.cpp:
        * ksvg2/svg/SVGExternalResourcesRequired.cpp:
        * ksvg2/svg/SVGExternalResourcesRequired.h:
        * ksvg2/svg/SVGFEBlendElement.cpp:
        * ksvg2/svg/SVGFEColorMatrixElement.cpp:
        * ksvg2/svg/SVGFEComponentTransferElement.cpp:
        * ksvg2/svg/SVGFECompositeElement.cpp:
        * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
        * ksvg2/svg/SVGFEDisplacementMapElement.cpp:
        * ksvg2/svg/SVGFEFloodElement.cpp:
        * ksvg2/svg/SVGFEGaussianBlurElement.cpp:
        * ksvg2/svg/SVGFEImageElement.cpp:
        * ksvg2/svg/SVGFEImageElement.h:
        * ksvg2/svg/SVGFELightElement.cpp:
        * ksvg2/svg/SVGFEMergeElement.cpp:
        * ksvg2/svg/SVGFEOffsetElement.cpp:
        * ksvg2/svg/SVGFESpecularLightingElement.cpp:
        * ksvg2/svg/SVGFETileElement.cpp:
        * ksvg2/svg/SVGFETurbulenceElement.cpp:
        * ksvg2/svg/SVGFilterElement.cpp:
        * ksvg2/svg/SVGGradientElement.cpp:
        * ksvg2/svg/SVGHelper.cpp:
        * ksvg2/svg/SVGImageElement.cpp:
        * ksvg2/svg/SVGLangSpace.cpp:
        * ksvg2/svg/SVGLength.cpp:
        * ksvg2/svg/SVGLineElement.cpp:
        * ksvg2/svg/SVGLinearGradientElement.cpp:
        * ksvg2/svg/SVGList.h:
        * ksvg2/svg/SVGLocatable.cpp:
        * ksvg2/svg/SVGMarkerElement.cpp:
        * ksvg2/svg/SVGMarkerElement.h:
        * ksvg2/svg/SVGMaskElement.cpp:
        * ksvg2/svg/SVGPathElement.cpp:
        * ksvg2/svg/SVGPatternElement.cpp:
        * ksvg2/svg/SVGPolyElement.cpp:
        * ksvg2/svg/SVGPolygonElement.cpp:
        * ksvg2/svg/SVGPolylineElement.cpp:
        * ksvg2/svg/SVGRadialGradientElement.cpp:
        * ksvg2/svg/SVGRectElement.cpp:
        * ksvg2/svg/SVGSVGElement.cpp:
        * ksvg2/svg/SVGStopElement.cpp:
        * ksvg2/svg/SVGStyleElement.cpp:
        * ksvg2/svg/SVGStyledElement.cpp:
        * ksvg2/svg/SVGStyledLocatableElement.cpp:
        * ksvg2/svg/SVGStyledTransformableElement.cpp:
        * ksvg2/svg/SVGTextElement.cpp:
        * ksvg2/svg/SVGTransformable.cpp:
        * ksvg2/svg/SVGUseElement.cpp:
        * ksvg2/svg/SVGViewElement.cpp:
        Updated includes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2006-04-01 Eric Seidel <eseidel@apple.com>
eseidel [Sun, 2 Apr 2006 01:57:51 +0000 (01:57 +0000)]
2006-04-01  Eric Seidel  <eseidel@apple.com>

        * libWebKitSystemInterface.a: commit a universal binary.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoOops. File was in change log, but not in commit.
darin [Sun, 2 Apr 2006 00:14:54 +0000 (00:14 +0000)]
Oops. File was in change log, but not in commit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej.
darin [Sun, 2 Apr 2006 00:04:31 +0000 (00:04 +0000)]
    Reviewed by Maciej.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8089
          REGRESSION: Caret position is off in native text field with text-align:right

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8082
          REGRESSION: Empty RTL text fields place the caret on the left side

        Need a way to make a test for this. No obvious way at the moment.

        * rendering/RenderFlow.cpp: (WebCore::RenderFlow::caretRect):
        Consider border, padding, and the width of the caret properly in the
        calculation of the caret's X position.

        * rendering/RenderBox.cpp: (WebCore::RenderBox::caretRect):
        Fixed some similar issues and rewrote this function for clarity.
        However, I suspect this function was and remains broken and is almost
        never called.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
darin [Sat, 1 Apr 2006 23:35:17 +0000 (23:35 +0000)]
LayoutTests:

        Reviewed by Justin.

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=8106
          REGRESSION (NativeTextField): New text fields don't scroll to the beginning when losing focus

        * fast/forms/input-text-scroll-left-on-blur-expected.png: Added.
        * fast/forms/input-text-scroll-left-on-blur-expected.txt: Added.
        * fast/forms/input-text-scroll-left-on-blur-expected.checksum: Added.
        * fast/forms/input-text-scroll-left-on-blur.html: Added.

WebCore:

        Reviewed by Justin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8106
          REGRESSION (NativeTextField): New text fields don't scroll to the beginning when losing focus

        Test: fast/forms/input-text-scroll-left-on-blur.html

        * html/HTMLInputElement.cpp: (WebCore::HTMLInputElement::defaultEventHandler): Pass blur events
        through to the RenderTextField, as well as mouse, drag, and wheel events.
        * rendering/RenderTextField.cpp: (WebCore::RenderTextField::forwardEvent): Scroll all the way to
        the left on a blur.

        - unrelated small changes

        * html/HTMLTextFieldInnerElement.cpp: Removed excess includes.
        (WebCore::HTMLTextFieldInnerElement::defaultEventHandler): Tweaked comments a bit.

        * dom/Element.cpp:
        (WebCore::Element::scrollIntoView): Removed unneeded this-> before function call.
        (WebCore::Element::scrollIntoViewIfNeeded): Ditto.

        * page/FrameView.cpp: (WebCore::FrameView::dispatchMouseEvent): Removed obsolete comment.

WebKitTools:

        Reviewed by Justin.

        * DumpRenderTree/EventSendingController.m: (-[EventSendingController keyDown:withModifiers:]):
        Fixed keyDown function so that it will work if you don't pass an array of modifiers or if
        elements in that array are not strings.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Beth.
darin [Sat, 1 Apr 2006 22:27:15 +0000 (22:27 +0000)]
    Reviewed by Beth.

        * libWebKitSystemInterface.a: Changed alpha in the focus-ring drawing
        code to use the system default alpha.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoOoops, actually land the fix with this ChangeLog entry:
mjs [Sat, 1 Apr 2006 20:59:45 +0000 (20:59 +0000)]
Ooops, actually land the fix with this ChangeLog entry:

2006-03-31  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Adele.

        <rdar://problem/4497684> REGRESSION(NativeTextField): After undoing pasted text in a field, the field changes to only a few pixels in height (8096)

        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::doApply): merge into start block when pasting into
        an empty editable subtree.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - re-updated many pixel results to try to create a new baseline
darin [Sat, 1 Apr 2006 19:39:38 +0000 (19:39 +0000)]
    - re-updated many pixel results to try to create a new baseline

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
mjs [Sat, 1 Apr 2006 10:14:17 +0000 (10:14 +0000)]
LayoutTests:

        Test cases for:

        <rdar://problem/4497684> REGRESSION(NativeTextField): After undoing pasted text in a field, the field changes to only a few pixels in height (8096)

        * fast/forms/input-paste-undo-expected.txt: Added.
        * fast/forms/input-paste-undo.html: Added.

WebCore:

        Reviewed by Adele.

        <rdar://problem/4497684> REGRESSION(NativeTextField): After undoing pasted text in a field, the field changes to only a few pixels in height (8096)

        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::doApply): merge into start block when pasting into
        an empty editable subtree.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
darin [Sat, 1 Apr 2006 09:40:43 +0000 (09:40 +0000)]
LayoutTests:

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=8063
          REGRESSION: double clicking in new text fields won't select whole words

        * fast/forms/input-text-double-click-expected.checksum: Added.
        * fast/forms/input-text-double-click-expected.png: Added.
        * fast/forms/input-text-double-click-expected.txt: Added.
        * fast/forms/input-text-double-click.html: Added.

WebCore:

        Reviewed by Maciej.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8063
          REGRESSION: double clicking in new text fields won't select whole words

        Test: fast/forms/input-text-double-click.html

        * editing/visible_units.cpp: (WebCore::nextBoundary): Set the end of the range by
        calling selectNodeContents rather than by calling setEndAfter. The problem with
        setEndAfter is that it doesn't do anything when the parent of the node is 0, and
        also it's not really what we want, since the boundary node is one with editable
        contents -- we want to stay inside the boundary node.

        * editing/Selection.cpp: (WebCore::Selection::validate): Fix a tiny formatting glitch
        I noticed at the same time.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
darin [Sat, 1 Apr 2006 09:32:44 +0000 (09:32 +0000)]
LayoutTests:

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=8105
          REGRESSION (NativeTextField): Option-delete deletes one space before the deleted word

        * fast/forms/input-text-option-delete-expected.checksum: Added.
        * fast/forms/input-text-option-delete-expected.png: Added.
        * fast/forms/input-text-option-delete-expected.txt: Added.
        * fast/forms/input-text-option-delete.html: Added.

WebKit:

        Reviewed by Maciej.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8105
          REGRESSION (NativeTextField): Option-delete deletes one space before the deleted word

        Test: fast/forms/input-text-option-delete.html

        * WebView/WebHTMLView.m:
        (-[WebHTMLView _deleteWithDirection:granularity:killRing:isTypingAction:]): Pass NO for
        smartDeleteOK. Smart deletion only applies to deleting a word at a time, and none of
        the callers of this function that delete a word at a time want smart deletion.
        (-[WebHTMLView deleteToEndOfLine:]): Fixed tiny formatting glitch.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoKnocking the number of PLTs we run down to 3 to see if we come in under the BuildBot...
thatcher [Sat, 1 Apr 2006 00:40:32 +0000 (00:40 +0000)]
Knocking the number of PLTs we run down to 3 to see if we come in under the BuildBot timeout.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoKnocking the number of PLTs we run down to 4 to see if we come in under the BuildBot...
thatcher [Sat, 1 Apr 2006 00:12:24 +0000 (00:12 +0000)]
Knocking the number of PLTs we run down to 4 to see if we come in under the BuildBot timeout.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Tim Hatcher.
sullivan [Fri, 31 Mar 2006 23:14:47 +0000 (23:14 +0000)]
    Reviewed by Tim Hatcher.

        - fixed <rdar://problem/4372842> 10.4.4 Regression: control-clicking on a misspelled word
        doesn't select it or offer corrections (first click only)

        * bridge/mac/FrameMac.mm:
        (WebCore::FrameMac::sendContextMenuEvent):
        Rolled in this one-line change that Hyatt wrote ages ago.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
thatcher [Fri, 31 Mar 2006 22:39:42 +0000 (22:39 +0000)]
    Reviewed by Darin.

        We need to set reachedTerminalState to YES before we release
        the resources to prevent a double dealloc of WebView

        Fixes <rdar://problem/4372628> crash deallocating a WebView in -[WebFrame stopLoading]

        * WebView/WebLoader.m:
        (-[NSURLProtocol releaseResources]): set reachedTerminalState earlier

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by John.
bdakin [Fri, 31 Mar 2006 21:50:38 +0000 (21:50 +0000)]
    Reviewed by John.

        Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=8108
        REGRESSION (r13590-r13593): Floating table's cells don't paint
        their background

        This is a regression from my painting patch yesterday. Just a silly
        error I didn't catch.

        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::paint): Change the phase of our new
        PaintInfo, not our old one.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Tim Omernick.
sullivan [Fri, 31 Mar 2006 21:36:38 +0000 (21:36 +0000)]
    Reviewed by Tim Omernick.

        Some cleanup in the WebIconDatabase code in a fruitless search for the cause
        of the mysterious -[WebFileDatabase performSetObject:forKey] crash

        * Misc/WebIconDatabase.m:
        (-[WebIconDatabase _createFileDatabase]):
        removed obsolete comment
        (-[WebIconDatabase _loadIconDictionaries]):
        Added ERRORs for unexpected early returns. Made dictionaries be autoreleased until
        the end of the method where they are retained, so that the early returns don't leak;
        added ASSERTs that the _private->dictionary values aren't being leaked.
        (-[WebIconDatabase _updateFileDatabase]):
        Added an ERROR for an unexpected early return, and made a trivial style fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
tomernic [Fri, 31 Mar 2006 20:58:33 +0000 (20:58 +0000)]
LayoutTests:

        Reviewed by Adele.

        Layout test for:
        <http://bugzilla.opendarwin.org/show_bug.cgi?id=7858>
        <rdar://problem/4483359> REGRESSION: New text field doesn't recognize the read only attribute

        * fast/forms/input-appearance-readonly-expected.txt: Added.
        * fast/forms/input-appearance-readonly.html: Added.

WebCore:

        Reviewed by Adele.

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=7858>
        <rdar://problem/4483359> REGRESSION: New text field doesn't recognize the read only attribute

        * rendering/RenderTextField.cpp:
        (WebCore::RenderTextField::createDivStyle):
        Set user modify based on the form element's readOnly().
        (WebCore::RenderTextField::updateFromElement):
        ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Tim Omernick.
adele [Fri, 31 Mar 2006 20:44:32 +0000 (20:44 +0000)]
    Reviewed by Tim Omernick.

        Updating shadowAncestorNode so it doesn't check for rootEditableElement.  Now we just walk
        up the tree to look for a shadowNode, and then we find the shadowParent.

        * dom/Node.cpp: (WebCore::Node::shadowAncestorNode):
        * rendering/RenderTextField.cpp: (WebCore::RenderTextField::setSelectionRange):
         Updated assertion to check for shadowAncestorNode instead of rootEditableElement.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix by Trey Matteson, reviewed by Maciej.
ap [Fri, 31 Mar 2006 20:30:07 +0000 (20:30 +0000)]
    Fix by Trey Matteson, reviewed by Maciej.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=7739
        REGRESSION: Assertion failure loading acid2 test in -[WebCoreFrameBridge installInFrame:]

        Tests: http/tests/misc/acid2.html, http/tests/misc/acid2-pixel.html

        The gist of this change is that we must cancel the load from the Webkit side when we
        realize we're switching to the fallback content.  This is somewhat a temp workaround
        since control of loading will be moving to WebCore.

        * WebView/WebMainResourceLoader.m:
        (-[WebMainResourceLoader continueAfterContentPolicy:response:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by John Sullivan.
adele [Fri, 31 Mar 2006 20:12:32 +0000 (20:12 +0000)]
    Reviewed by John Sullivan.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8101
          REGSRESSION: Fix for bug 7031 causes 30 layout tests to fail

        * rendering/render_line.cpp:
        (WebCore::InlineFlowBox::placeBoxesVertically): Change top and bottom positions
        only if childAffectsTopBottomPos is true.
        * rendering/RenderFlow.cpp:
        (WebCore::RenderFlow::paintLines): Redo a part of the patch for bug 7031 that
        wasn't committed with the rest of the patch.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin, landed by Beth.
bdakin [Fri, 31 Mar 2006 19:16:36 +0000 (19:16 +0000)]
    Reviewed by Darin, landed by Beth.

        Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=8081
        REGRESSION: Drop-down menu has gap at top

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::calcAbsoluteVerticalValues): When calculating
        the hypothetical vertical position in normal flow, skip table rows
        in the ancestor chain, since a table cell's Y position is relative
        to the table section, not the row.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFIx theme borders on win32.
hyatt [Fri, 31 Mar 2006 19:03:19 +0000 (19:03 +0000)]
FIx theme borders on win32.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
darin [Fri, 31 Mar 2006 18:51:40 +0000 (18:51 +0000)]
LayoutTests:

        - updated results for tests that involve scrolling

        * editing/selection/focus_editable_html-expected.txt: Added expected scroll position.
        * fast/dom/focus-contenteditable-expected.txt: Ditto.
        * fast/overflow/scrollRevealButton.html: Ditto.

        - updated results for tests that involve new exception names

        * fast/dom/Element/attr-param-typechecking-expected.txt: Updated.

        * fast/dynamic/insertAdjacentElement-expected.txt: Updated.
        * fast/dynamic/insertAdjacentElement-expected.png: Added.
        * fast/dynamic/insertAdjacentElement-expected.checksum: Added.

WebCore:

        Reviewed by John Sullivan.

        * khtml/ecma/kjs_binding.cpp: Added names for VALIDATION_ERR and
        TYPE_MISMATCH_ERR; new DOM Level 3 errors that need to be listed in
        the mapping from error code to error name.

        * dom/Element.idl: Removed comment from bad old days where we had to
        touch these files to make them rebuild.

WebKitTools:

        Reviewed by John Sullivan.

        - added a "--reset-results" option to run-webkit-tests so you can reset
          the results without first deleting expected results
        - <rdar://problem/4185878> add scroll position to dumpRenderTree

        * Scripts/run-webkit-tests: Rearranged the code a bit to make the sequence
        more logical. Moved all the subroutines to the end of the file. Added a
        "--force" option.

        * DumpRenderTree/DumpRenderTree.m:
        (main): Added a new --dump-all-pixels option, used when forcing run-webkit-tests
        to generate new output for all tests it runs.
        (dump): Dump the scroll position if it's non-zero. Always dump the image when
        the --dump-all-pixels option is passed. Also tightened up the image dumping
        code and replaced the incorrect use of +[NSGraphicsContext saveGraphicsState]
        with code to save and restore the context.

        * DumpRenderTree/DumpRenderTree.h: Tweaked includes a bit and added (void).
        * DumpRenderTree/EventSendingController.m: Added now-needed include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Geoff.
darin [Fri, 31 Mar 2006 18:02:13 +0000 (18:02 +0000)]
    Reviewed by Geoff.

        - <rdar://problem/4395622> API: WebScriptObject.h incorrectly reports that -isSelectorExcludedFromWebScript returns NO by default

        * bindings/objc/WebScriptObject.h: Fixed comment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Layout test for <rdar://problem/4472371> REGRESSION(417.9-TOT):
bdakin [Fri, 31 Mar 2006 17:40:54 +0000 (17:40 +0000)]
    Layout test for <rdar://problem/4472371> REGRESSION(417.9-TOT):
        Focus ring around link in overflow:auto div isn't clipped to div

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoRemoved all the tabs and cleared the "allow tabs" bit.
darin [Fri, 31 Mar 2006 16:39:12 +0000 (16:39 +0000)]
Removed all the tabs and cleared the "allow tabs" bit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix my build bustage with themes.
hyatt [Fri, 31 Mar 2006 11:45:15 +0000 (11:45 +0000)]
Fix my build bustage with themes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - fixed Windows build breakage from previous change
mjs [Fri, 31 Mar 2006 11:32:27 +0000 (11:32 +0000)]
    - fixed Windows build breakage from previous change

        * platform/ScrollView.h:
        * platform/win/FontWin.cpp:
        (WebCore::Font::drawLineForText):
        * platform/win/ScrollViewWin.cpp:
        (WebCore::ScrollView::scrollOffset):
        (WebCore::ScrollView::scrollBy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13606 268f45cc-cd09-0410-ab3c-d52691b4dbfc