WebKit-https.git
9 years ago[chromium] Rebaseline JPEG image results after r107389
noel.gordon@gmail.com [Fri, 17 Feb 2012 11:11:55 +0000 (11:11 +0000)]
[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #32 of N. Chrome MAC SnowLeopard differences under discussion
in bug 54322, retain IMAGE expectation on SnowLeopard, update pixel results.

* platform/chromium-linux/tables/mozilla/core/row_span-expected.png:
* platform/chromium-linux/tables/mozilla/other/cell_widths-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/core/row_span-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/other/cell_widths-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/core/row_span-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/other/cell_widths-expected.png: Added.
* platform/chromium-win/tables/mozilla/core/row_span-expected.png:
* platform/chromium-win/tables/mozilla/other/cell_widths-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Implement zoom in/out in MiniBrowser
carlosgc@webkit.org [Fri, 17 Feb 2012 11:09:59 +0000 (11:09 +0000)]
[GTK] Implement zoom in/out in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=75253

Reviewed by Gustavo Noronha Silva.

* MiniBrowser/gtk/BrowserWindow.c:
(browserWindowCanZoomIn):
(browserWindowCanZoomOut):
(browserWindowUpdateZoomActions):
(webViewZoomLevelChanged):
(zoomInCallback):
(zoomOutCallback):
(browser_window_init):
(browserWindowConstructed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108056 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] Allow partial updates
noam.rosenthal@nokia.com [Fri, 17 Feb 2012 11:09:07 +0000 (11:09 +0000)]
[Qt][WK2] Allow partial updates
https://bugs.webkit.org/show_bug.cgi?id=78824

Source/WebCore:

BitmapTextureGL should not zero-fill the textures when resetting.
This was needed in the previous buffer management system, where texture were not completely
filled by the backing store.

Reviewed by Simon Hausmann.

No new behavior.

* platform/graphics/opengl/TextureMapperGL.cpp:
(BitmapTextureGL):
(WebCore::texSubImage2DResourceSafe):
(WebCore):
(WebCore::BitmapTextureGL::reset):

Source/WebKit2:

Instead of using UpdateInfo to fill the entire tile's texture, we use it as a patch that
contains only the dirty rectangle of the current paint. This requires a lot less memory
for small updates, for example when typing a text in an input field.
This shows a significant reduction in overhead when testing on Mac with Instruments.

Reviewed by Simon Hausmann.

* UIProcess/qt/LayerBackingStore.cpp:
(WebKit::LayerBackingStoreTile::swapBuffers):
(WebKit::LayerBackingStoreTile::setBackBuffer):
(WebKit):
(WebKit::LayerBackingStore::updateTile):
* UIProcess/qt/LayerBackingStore.h:
(LayerBackingStoreTile):
* UIProcess/qt/LayerTreeHostProxyQt.cpp:
(WebKit::LayerTreeHostProxy::updateTileForLayer):
* WebProcess/WebPage/TiledBackingStoreRemoteTile.cpp:
(WebKit::TiledBackingStoreRemoteTile::updateBackBuffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agolayoutTestController.display() is flaky for SVG tests
zimmermann@webkit.org [Fri, 17 Feb 2012 11:07:05 +0000 (11:07 +0000)]
layoutTestController.display() is flaky for SVG tests
https://bugs.webkit.org/show_bug.cgi?id=78021

Reviewed by Adam Roben.

Apply the same fix to DRT/Win, as previously applied to DRT/Mac.
Size the web view before running the test, not when dumping.
All platforms handle this correctly now.

* DumpRenderTree/win/DumpRenderTree.cpp:
(dump):
(sizeWebViewForCurrentTest):
(runTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108054 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Fix GTK+ build after r108003.
carlosgc@webkit.org [Fri, 17 Feb 2012 10:37:17 +0000 (10:37 +0000)]
Unreviewed. Fix GTK+ build after r108003.

* Source/autotools/symbols.filter: Add missing symbol.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108053 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Rebaseline JPEG image results after r107389
noel.gordon@gmail.com [Fri, 17 Feb 2012 09:47:18 +0000 (09:47 +0000)]
[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #33 of N. See also bug 78219.

* platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
* platform/chromium-linux/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
* platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png: Added.
* platform/chromium-mac/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png: Removed.
* platform/chromium-mac/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png: Removed.
* platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-dom-preserveAspectRatio-attr-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGFEImageElement-svgdom-preserveAspectRatio-prop-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Forms] Integrate InputType::dispatchChangeEventInResponseToSetValue into InputType...
commit-queue@webkit.org [Fri, 17 Feb 2012 09:22:41 +0000 (09:22 +0000)]
[Forms] Integrate InputType::dispatchChangeEventInResponseToSetValue into InputType::setValue
https://bugs.webkit.org/show_bug.cgi?id=78873

Patch by Yosifumi Inoue <yosin@chromium.org> on 2012-02-17
Reviewed by Kent Tamura.

This patch moves event dispatch logic to InputType and TextFieldInputType from HTMLInputElement
and merge dispatchChangeEventInResponseToSetValue to setValue.

No new tests. No change in behavior.

* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setValue): Move dispatch logic to InputType and TextFieldInput.
* html/InputType.cpp: Remove dispatchChangeEventInResponseToSetValue implementation.
* html/InputType.h: Remove dispatchChangeEventInResponseToSetValue declaration.
(WebCore::InputType::setValue): Move code from dispatchChangeEventInResponseToSetValue.
* html/TextFieldInputType.cpp: Remove dispatchChangeEventInResponseToSetValue implementation.
* html/TextFieldInputType.h: Remove dispatchChangeEventInResponseToSetValue declaration.
(WebCore::TextFieldInputType::setValue): Move code from dispatchChangeEventInResponseToSetValue. Stop dispatching event in InputType::setValue.
* html/HTMLTextFormControlElement.h: Make setTextAsOfLastFormControlChangeEvent to public from protected for accessing from InputType class.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108051 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2012-02-17 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Fri, 17 Feb 2012 09:09:09 +0000 (09:09 +0000)]
2012-02-17  Yury Semikhatsky  <yurys@chromium.org>

        Unreviewed. Mac build fix after r108047.

        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108050 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemoving the last presentation attribute should result in a null attributeStyle().
kling@webkit.org [Fri, 17 Feb 2012 09:01:54 +0000 (09:01 +0000)]
Removing the last presentation attribute should result in a null attributeStyle().
<http://webkit.org/b/78812>

Reviewed by Antti Koivisto.

If the collectStyleForAttribute() pass in updateAttributeStyle() doesn't encounter any
respected presentation attributes, set a null attributeStyle() instead of an empty one.

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):
* dom/StyledElement.cpp:
(WebCore::StyledElement::updateAttributeStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108049 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Rebaseline JPEG image results after r107389
noel.gordon@gmail.com [Fri, 17 Feb 2012 08:44:45 +0000 (08:44 +0000)]
[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #31 of N. Any reasons for the MAC exception have been lost
in time, like tears in rain. Remove the MAC exception, update all pixel results.

* platform/chromium-linux/tables/mozilla/bugs/bug82946-2-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug82946-2-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug82946-2-expected.png: Added.
* platform/chromium-win/tables/mozilla/bugs/bug82946-2-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: use static counters for estimation of allocated Documents, Nodes and...
yurys@chromium.org [Fri, 17 Feb 2012 08:33:30 +0000 (08:33 +0000)]
Web Inspector: use static counters for estimation of allocated Documents, Nodes and JS EventListeners
https://bugs.webkit.org/show_bug.cgi?id=78825

Introduced static counters of allocated Documents, Nodes and JS EventListeners.
Their values are displayed on the Timeline panel.

Reviewed by Pavel Feldman.

* CMakeLists.txt:
* English.lproj/localizedStrings.js:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::JSEventListener):
(WebCore::JSEventListener::~JSEventListener):
* bindings/v8/V8AbstractEventListener.cpp:
(WebCore::V8AbstractEventListener::V8AbstractEventListener):
(WebCore::V8AbstractEventListener::~V8AbstractEventListener):
* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::~Document):
* dom/Document.h:
(WebCore::Node::Node):
* dom/Node.cpp:
(WebCore::Node::~Node):
* inspector/InspectorAllInOne.cpp:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
* inspector/InspectorCounters.cpp: Added.
(WebCore):
(WebCore::InspectorCounters::counterValue):
* inspector/InspectorCounters.h: Added.
(WebCore):
(InspectorCounters):
(WebCore::InspectorCounters::incrementCounter):
(WebCore::InspectorCounters::decrementCounter):
* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::didCallFunction):
(WebCore::InspectorTimelineAgent::didDispatchEvent):
(WebCore::InspectorTimelineAgent::didWriteHTML):
(WebCore::InspectorTimelineAgent::didFireTimer):
(WebCore::InspectorTimelineAgent::didEvaluateScript):
(WebCore::InspectorTimelineAgent::setHeapSizeStatistic):
(WebCore::InspectorTimelineAgent::InspectorTimelineAgent):
* inspector/InspectorTimelineAgent.h:
(WebCore):
(WebCore::InspectorTimelineAgent::create):
(InspectorTimelineAgent):
* inspector/front-end/MemoryStatistics.js:
(WebInspector.MemoryStatistics):
(WebInspector.MemoryStatistics.prototype.addTimlineEvent):
(WebInspector.MemoryStatistics.prototype._draw.getDocumentCount):
(WebInspector.MemoryStatistics.prototype._refreshCurrentValues):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._onTimelineEventRecorded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, GTK rebaseline after r108034.
philn@webkit.org [Fri, 17 Feb 2012 08:08:42 +0000 (08:08 +0000)]
Unreviewed, GTK rebaseline after r108034.

* platform/gtk/fast/dom/Window/window-properties-expected.txt:
* platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/gtk/fast/js/global-constructors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Rebaseline JPEG image results after r107389
noel.gordon@gmail.com [Fri, 17 Feb 2012 08:06:50 +0000 (08:06 +0000)]
[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #30 of N.  Chrome MAC SnowLeopard differences under discussion
in bug 54322, retain IMAGE expectation on SnowLeopard, update pixel results.

* platform/chromium-linux/tables/mozilla/core/bloomberg-expected.png:
* platform/chromium-linux/tables/mozilla/core/misc-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/core/bloomberg-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/core/misc-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/core/bloomberg-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/core/misc-expected.png: Added.
* platform/chromium-win/tables/mozilla/core/bloomberg-expected.png:
* platform/chromium-win/tables/mozilla/core/misc-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Rollout r107952 removed fast/events/related-target-focusevent.html so
noel.gordon@gmail.com [Fri, 17 Feb 2012 07:52:17 +0000 (07:52 +0000)]
Unreviewed. Rollout r107952 removed fast/events/related-target-focusevent.html so
lint complains about it in test_expectations.txt, remove it's expectation line.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCorrect a misleading comment regarding string delimiters in CSS parsing.
cdn@chromium.org [Fri, 17 Feb 2012 07:47:58 +0000 (07:47 +0000)]
Correct a misleading comment regarding string delimiters in CSS parsing.
https://bugs.webkit.org/show_bug.cgi?id=78521

Reviewed by Zoltan Herczeg.

* css/CSSParser.cpp:
(WebCore::CSSParser::lex):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108043 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. r107980 rolled-out, fast/js/stack-trace.html was removed so lint
noel.gordon@gmail.com [Fri, 17 Feb 2012 07:44:07 +0000 (07:44 +0000)]
Unreviewed. r107980 rolled-out, fast/js/stack-trace.html was removed so lint
complains about it in test_expectations.txt, remove it's expectation line.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix the TextureMapper build for GTK+.
mrobinson@webkit.org [Fri, 17 Feb 2012 07:30:07 +0000 (07:30 +0000)]
Fix the TextureMapper build for GTK+.

No new tests. This is just a build fix.

* GNUmakefile.list.am: Add missing files to the build and change spaces to tabs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Make sure print operation object is alive until printing finishes in WebKit2
carlosgc@webkit.org [Fri, 17 Feb 2012 07:26:13 +0000 (07:26 +0000)]
[GTK] Make sure print operation object is alive until printing finishes in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=78829

Reviewed by Martin Robinson.

* UIProcess/API/gtk/WebKitPrintOperation.cpp:
(drawPagesForPrintingCompleted): Adopt the WebKitPrintOperation
reference so that it's released when the callback finishes.
(webkitPrintOperationRunDialogForFrame): Pass a reference of
WebKitPrintOperation to the printing callback.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Make install is broken when building without --enable-gtk-doc
carlosgc@webkit.org [Fri, 17 Feb 2012 07:23:28 +0000 (07:23 +0000)]
[GTK] Make install is broken when building without --enable-gtk-doc
https://bugs.webkit.org/show_bug.cgi?id=78828

Reviewed by Martin Robinson.

* gtk/generate-gtkdoc:
(rebase_installed_docs): Check documentation has been generated
before trying to rebase it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd ENABLE(STYLE_SCOPED) around HTMLStyleElement::m_isRegisteredWithScopingNode
dbates@webkit.org [Fri, 17 Feb 2012 07:20:12 +0000 (07:20 +0000)]
Add ENABLE(STYLE_SCOPED) around HTMLStyleElement::m_isRegisteredWithScopingNode

The instance variable HTMLStyleElement::m_isRegisteredWithScopingNode is only
referenced from within ENABLE(STYLE_SCOPED)-guarded code. We should add this
guard around its declaration.

* html/HTMLStyleElement.h:
(HTMLStyleElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd JSC code profiling support on Linux x86
yuqiang.xian@intel.com [Fri, 17 Feb 2012 07:10:12 +0000 (07:10 +0000)]
Add JSC code profiling support on Linux x86
https://bugs.webkit.org/show_bug.cgi?id=78871

Reviewed by Gavin Barraclough.

We don't unwind the stack for now as we cannot guarantee all the
libraries are compiled without -fomit-frame-pointer.

* tools/CodeProfile.cpp:
(JSC::CodeProfile::sample):
* tools/CodeProfiling.cpp:
(JSC):
(JSC::profilingTimer):
(JSC::CodeProfiling::begin):
(JSC::CodeProfiling::end):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Rolling out r107980, because it broke 32 bit platforms.
ossy@webkit.org [Fri, 17 Feb 2012 06:43:23 +0000 (06:43 +0000)]
Unreviewed. Rolling out r107980, because it broke 32 bit platforms.

Source/JavaScriptCore:

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::throwException):
(JSC::Interpreter::privateExecute):
* interpreter/Interpreter.h:
(JSC):
(Interpreter):
* jsc.cpp:
(GlobalObject::finishCreation):
* parser/Nodes.h:
(JSC::FunctionBodyNode::setInferredName):
* parser/Parser.h:
(JSC::::parse):
* runtime/CommonIdentifiers.h:
* runtime/Error.cpp:
(JSC::addErrorInfo):
* runtime/Error.h:
(JSC):

LayoutTests:

* fast/js/exception-properties-expected.txt:
* fast/js/script-tests/exception-properties.js:
* fast/js/script-tests/stack-trace.js: Removed.
* fast/js/stack-trace-expected.txt: Removed.
* fast/js/stack-trace.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108036 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[v8] v8 doesn't assume to do 'new WebKitShadowRoot(host)'
shinyak@chromium.org [Fri, 17 Feb 2012 06:42:02 +0000 (06:42 +0000)]
[v8] v8 doesn't assume to do 'new WebKitShadowRoot(host)'
https://bugs.webkit.org/show_bug.cgi?id=78875

Reviewed by Kentaro Hara.

Source/WebCore:

Since v8 does not assume that we do 'new WebkitShadowRoot(host)', a wrapper object for new WebKitShadowRoot(host)
was saved in DOMObject storage instead of DOMNode storage.

CodeGenerator should handle with DOMNode correctly to solve the problem.

Test: fast/dom/shadow/shadow-root-new.html

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateConstructorCallback):

LayoutTests:

Skip non-chromium ports since SHADOW_DOM flag is not enabled in their ports.

* fast/dom/shadow/shadow-root-new.html: Added.
* fast/dom/shadow/shadow-root-new-expected.txt: Added.
* platform/efl/Skipped:
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
* platform/wincairo/Skipped:
* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: Unreviewed rollout r107952 because it broke shadow-boundary-events...
loislo@chromium.org [Fri, 17 Feb 2012 06:35:46 +0000 (06:35 +0000)]
Source/WebCore: Unreviewed rollout r107952 because it broke shadow-boundary-events.html and related-target-focusevent.html on mac.
see http://webkit.org/b/78832

* CMakeLists.txt:
* DerivedSources.cpp:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* dom/DOMAllInOne.cpp:
* dom/EventDispatchMediator.cpp:
(WebCore::FocusEventDispatchMediator::create):
(WebCore):
(WebCore::FocusEventDispatchMediator::FocusEventDispatchMediator):
(WebCore::FocusEventDispatchMediator::dispatchEvent):
(WebCore::BlurEventDispatchMediator::create):
(WebCore::BlurEventDispatchMediator::BlurEventDispatchMediator):
(WebCore::BlurEventDispatchMediator::dispatchEvent):
* dom/EventDispatchMediator.h:
(FocusEventDispatchMediator):
(WebCore):
(BlurEventDispatchMediator):
* dom/EventFactory.in:
* dom/FocusEvent.cpp: Removed.
* dom/FocusEvent.h: Removed.
* dom/FocusEvent.idl: Removed.
* dom/Node.cpp:
(WebCore::Node::dispatchFocusInEvent):
(WebCore::Node::dispatchFocusOutEvent):
* dom/UIEvent.cpp:
(WebCore::FocusInEventDispatchMediator::create):
(WebCore):
(WebCore::FocusInEventDispatchMediator::FocusInEventDispatchMediator):
(WebCore::FocusInEventDispatchMediator::dispatchEvent):
(WebCore::FocusOutEventDispatchMediator::create):
(WebCore::FocusOutEventDispatchMediator::FocusOutEventDispatchMediator):
(WebCore::FocusOutEventDispatchMediator::dispatchEvent):
* dom/UIEvent.h:
(FocusInEventDispatchMediator):
(WebCore):
(FocusOutEventDispatchMediator):
* page/DOMWindow.idl:

LayoutTests: Unreviewed rollout r107952 because it broke shadow-boundary-events.html and related-target-focusevent.html on mac.
see http://webkit.org/b/78832

* fast/dom/shadow/shadow-boundary-events-expected.txt:
* fast/dom/shadow/shadow-boundary-events.html:
* fast/events/event-creation-expected.txt:
* fast/events/event-creation.html:
* fast/events/related-target-focusevent-expected.txt: Removed.
* fast/events/related-target-focusevent.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Rebaseline JPEG image results after r107389
noel.gordon@gmail.com [Fri, 17 Feb 2012 06:21:29 +0000 (06:21 +0000)]
[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #29 of N.  Chrome MAC differences under discussion in bug
BUGCR23473, retain IMAGE expectation on MAC therefore, update the pixel results.

* platform/chromium-linux/fast/repaint/backgroundSizeRepaint-expected.png:
* platform/chromium-mac-leopard/fast/repaint/backgroundSizeRepaint-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/repaint/backgroundSizeRepaint-expected.png: Added.
* platform/chromium-win/fast/repaint/backgroundSizeRepaint-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAnother fix for viewport tests
mhahnenberg@apple.com [Fri, 17 Feb 2012 06:20:38 +0000 (06:20 +0000)]
Another fix for viewport tests

No new tests.

* dom/ViewportArguments.cpp:
(WebCore::numericPrefix): When we don't parse a number, we could either be
trying to parse junk, which returns NaN, or we could get an empty string,
which returns 0, so we need to account for that in the assert.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108032 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Bundle page scale factor and limits in CCLayerTreeHost
commit-queue@webkit.org [Fri, 17 Feb 2012 05:58:38 +0000 (05:58 +0000)]
[chromium] Bundle page scale factor and limits in CCLayerTreeHost
https://bugs.webkit.org/show_bug.cgi?id=78762

Setting page scale factor and its limits in separate methods
may cause clamping bugs if one of them makes it to the
impl thread before the other.  Change the API to bundle them together,
which matches the existing impl-side interface.

Patch by Alexandre Elias <aelias@google.com> on 2012-02-16
Reviewed by James Robinson.

Source/WebCore:

No new tests (API change will disallow this type of bug).

* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::finishCommitOnImplThread):
(WebCore::CCLayerTreeHost::setPageScaleFactorAndLimits):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(CCLayerTreeHost):

Source/WebKit/chromium:

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::computePageScaleFactorLimits):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit::WebViewImpl::updateLayerTreeViewport):
* tests/CCLayerTreeHostTest.cpp:
(WTF::CCLayerTreeHostTestStartPageScaleAnimation::applyScrollAndScale):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108031 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRebaseline JPEG image results after r107389
noel.gordon@gmail.com [Fri, 17 Feb 2012 05:51:11 +0000 (05:51 +0000)]
Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #26 of N. Color profiles are not supported in chrome win/linux.
Retain the FAIL MISSING expectation, update the failing win/linux pixel result.

* platform/chromium-win/fast/images/color-jpeg-with-color-profile-expected.png: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Rebaseline JPEG image results after r107389
noel.gordon@gmail.com [Fri, 17 Feb 2012 05:49:13 +0000 (05:49 +0000)]
[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #28 of N.  Chrome MAC differences under discussion in bug
BUGCR23473, retain IMAGE expectation on MAC therefore, update the pixel results.

* platform/chromium-linux/fast/repaint/clipped-relative-expected.png:
* platform/chromium-linux/fast/repaint/selected-replaced-expected.png:
* platform/chromium-mac-leopard/fast/repaint/clipped-relative-expected.png: Added.
* platform/chromium-mac-leopard/fast/repaint/selected-replaced-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/repaint/clipped-relative-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/repaint/selected-replaced-expected.png: Added.
* platform/chromium-win/fast/repaint/clipped-relative-expected.png:
* platform/chromium-win/fast/repaint/selected-replaced-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108029 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Rebaselined run-bindings-tests results.
haraken@chromium.org [Fri, 17 Feb 2012 05:34:09 +0000 (05:34 +0000)]
Unreviewed. Rebaselined run-bindings-tests results.

* bindings/scripts/test/JS/JSTestEventConstructor.cpp:
(WebCore::JSTestEventConstructorConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::JSTestInterfaceConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObjConstructor::finishCreation):
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::finishCreation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108028 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Add method to WebViewImpl to extract zoom/scroll params for gesture events...
commit-queue@webkit.org [Fri, 17 Feb 2012 05:33:57 +0000 (05:33 +0000)]
[Chromium] Add method to WebViewImpl to extract zoom/scroll params for gesture events on touch devices
https://bugs.webkit.org/show_bug.cgi?id=72909

Patch by Varun Jain <varunjain@google.com> on 2012-02-16
Reviewed by James Robinson.

* src/WebViewImpl.cpp:
(std):
(WebKit):
(WebKit::WebViewImpl::computeBlockBounds):
(WebKit::WebViewImpl::widenRectWithinPageBounds):
(WebKit::WebViewImpl::computeScaleAndScrollForHitRect):
* src/WebViewImpl.h:
(WebViewImpl):
* tests/WebFrameTest.cpp:
(WebKit):
(WebKit::TEST_F):
* tests/data/get_scale_for_auto_zoom_into_div_test.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108027 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Rebaseline JPEG image results after r107389
noel.gordon@gmail.com [Fri, 17 Feb 2012 05:26:47 +0000 (05:26 +0000)]
[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #25 of N.  Chrome MAC rendering was previously incorrect, and
still is incorrect/weird: update test_expectations.txt with IMAGE failure.

* platform/chromium-linux/compositing/overflow/overflow-scaled-descendant-overlapping-expected.png: Removed.
* platform/chromium-linux/compositing/overflow/overflow-scaled-descendant-overlapping-expected.txt: Removed.
* platform/chromium-mac-leopard/compositing/overflow/overflow-scaled-descendant-overlapping-expected.png: Added.
* platform/chromium-mac-snowleopard/compositing/overflow/overflow-scaled-descendant-overlapping-expected.png:
* platform/chromium-mac-snowleopard/compositing/overflow/overflow-scaled-descendant-overlapping-expected.txt: Removed.
* platform/chromium-win-vista/compositing/overflow/overflow-scaled-descendant-overlapping-expected.png: Removed.
* platform/chromium-win-vista/compositing/overflow/overflow-scaled-descendant-overlapping-expected.txt: Removed.
* platform/chromium-win-xp/compositing/overflow/overflow-scaled-descendant-overlapping-expected.png: Removed.
* platform/chromium-win-xp/compositing/overflow/overflow-scaled-descendant-overlapping-expected.txt: Removed.
* platform/chromium-win/compositing/overflow/overflow-scaled-descendant-overlapping-expected.txt: Removed.
* platform/chromium/compositing/overflow/overflow-scaled-descendant-overlapping-expected.txt: Renamed from LayoutTests/platform/chromium-linux-x86/compositing/overflow/overflow-scaled-descendant-overlapping-expected.txt.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] LayerChromium::setNeedsDisplay does not apply contents scale correctly
commit-queue@webkit.org [Fri, 17 Feb 2012 05:02:44 +0000 (05:02 +0000)]
[chromium] LayerChromium::setNeedsDisplay does not apply contents scale correctly
https://bugs.webkit.org/show_bug.cgi?id=77464

Source/WebCore:

Use bounds() instead of contentBounds() to calculate the region to mark
as needing painting in LayerChromium::setNeedsDisplay(). contentBounds()
includes contents scale, while bounds() does not.

Since this change also means that TiledLayerChromium::setNeedsDisplayRect() is
given an unscaled rectangle, modify that function to scale the rectangle before
using it to invalidate the underlying tiles.

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-02-16
Reviewed by James Robinson.

Tests: New tests added to LayerChromium and TiledLayerChromium unit tests.

* platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::setNeedsDisplay):
* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::setNeedsDisplayRect):

Source/WebKit/chromium:

Added a new unit test for TiledLayerChromium to verify its invalidation behavior when
the contents scale changes. Also enhance and existing unit test for LayerChromium to
verify the paint rectangle dimensions instead just checking that it is not empty.

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-02-16
Reviewed by James Robinson.

* tests/LayerChromiumTest.cpp:
* tests/TiledLayerChromiumTest.cpp:
(WTF::FakeTiledLayerChromium::setNeedsDisplayRect):
(FakeTiledLayerChromium):
(WTF::FakeTiledLayerChromium::lastNeedsDisplayRect):
(WTF::TEST):
(WTF):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108025 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Rebaseline JPEG image results after r107389
noel.gordon@gmail.com [Fri, 17 Feb 2012 04:50:52 +0000 (04:50 +0000)]
[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #27 of N.

* platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png:
* platform/chromium-mac-leopard/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png:
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-39-t-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=78065
morrita@google.com [Fri, 17 Feb 2012 04:46:20 +0000 (04:46 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=78065
[Chromium] Should eliminate WebTextCheckingResult legacy APIs

Reviewed by Kent Tamura.

Removed unused legacy members.

* public/WebTextCheckingResult.h:
(WebKit::WebTextCheckingResult::WebTextCheckingResult):
(WebTextCheckingResult):
* src/AssertMatchingEnums.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoLazy init for DefaultAudioDestinationNode and OfflineAudioDestinationNode
commit-queue@webkit.org [Fri, 17 Feb 2012 04:36:50 +0000 (04:36 +0000)]
Lazy init for DefaultAudioDestinationNode and OfflineAudioDestinationNode
https://bugs.webkit.org/show_bug.cgi?id=76509

Patch by Raymond Liu <raymond.liu@intel.com> on 2012-02-16
Reviewed by Eric Seidel.

No new tests required.

* webaudio/AudioDestinationNode.h:
* webaudio/AudioNode.h:
(WebCore::AudioNode::sampleRate):
* webaudio/DefaultAudioDestinationNode.cpp:
(WebCore::DefaultAudioDestinationNode::DefaultAudioDestinationNode):
* webaudio/DefaultAudioDestinationNode.h:
* webaudio/OfflineAudioDestinationNode.cpp:
(WebCore::OfflineAudioDestinationNode::OfflineAudioDestinationNode):
* webaudio/OfflineAudioDestinationNode.h:
(WebCore::OfflineAudioDestinationNode::sampleRate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108022 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Refactoring] Remove location from NodeRenderingContext.
shinyak@chromium.org [Fri, 17 Feb 2012 04:13:49 +0000 (04:13 +0000)]
[Refactoring] Remove location from NodeRenderingContext.
https://bugs.webkit.org/show_bug.cgi?id=78796

Reviewed by Hajime Morita.

This is a simple refactoring to remove m_location from NodeRenderingContext.
TreeLocation is merged into AttachPhase like the following.
    LocationUndertermined -> Calculating
    LocationNotInTree -> AttachingNotInTree
    LocationLightChild -> AttachingStraight / AttachingNotDistributed / AttachingDistributed
    LocationShadowChild -> AttachingStraight / AttachingShadowChild / AttachingFallback

We have renamed the enum items of AttachPhase, because not only <content> but also
<shadow> will use the phases. Basically these words are taken from Shadow DOM spec.
'Calculating' means NodeRenderingContext is used not for attaching but for calculating RenderObject.

No new tests, no change in behavior.

* dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::NodeRenderingContext):
(WebCore::NodeRenderingContext::nextRenderer):
(WebCore::NodeRenderingContext::previousRenderer):
(WebCore::NodeRenderingContext::parentRenderer):
(WebCore::NodeRenderingContext::shouldCreateRenderer):
* dom/NodeRenderingContext.h:
(NodeRenderingContext):
(WebCore::NodeRenderingContext::parentNodeForRenderingAndStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108021 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoENABLE_INTERPRETER should be ENABLE_CLASSIC_INTERPRETER
fpizlo@apple.com [Fri, 17 Feb 2012 04:10:00 +0000 (04:10 +0000)]
ENABLE_INTERPRETER should be ENABLE_CLASSIC_INTERPRETER
https://bugs.webkit.org/show_bug.cgi?id=78791

Rubber stamped by Oliver Hunt.

Just a renaming, nothing more. Also renamed COMPUTED_GOTO_INTERPRETER to
COMPUTED_GOTO_CLASSIC_INTERPRETER.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
(JSC::CodeBlock::stronglyVisitStrongReferences):
(JSC):
(JSC::CodeBlock::shrinkToFit):
* bytecode/CodeBlock.h:
(CodeBlock):
* bytecode/Instruction.h:
(JSC::Instruction::Instruction):
* bytecode/Opcode.h:
(JSC::padOpcodeName):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitResolve):
(JSC::BytecodeGenerator::emitResolveWithBase):
(JSC::BytecodeGenerator::emitGetById):
(JSC::BytecodeGenerator::emitPutById):
(JSC::BytecodeGenerator::emitDirectPutById):
* interpreter/AbstractPC.cpp:
(JSC::AbstractPC::AbstractPC):
* interpreter/AbstractPC.h:
(AbstractPC):
* interpreter/CallFrame.h:
(ExecState):
* interpreter/Interpreter.cpp:
(JSC):
(JSC::Interpreter::initialize):
(JSC::Interpreter::isOpcode):
(JSC::Interpreter::unwindCallFrame):
(JSC::Interpreter::execute):
(JSC::Interpreter::privateExecute):
(JSC::Interpreter::retrieveLastCaller):
* interpreter/Interpreter.h:
(JSC::Interpreter::getOpcode):
(JSC::Interpreter::getOpcodeID):
(Interpreter):
* jit/ExecutableAllocatorFixedVMPool.cpp:
(JSC::FixedVMPoolExecutableAllocator::FixedVMPoolExecutableAllocator):
* runtime/Executable.cpp:
(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):
* runtime/Executable.h:
(NativeExecutable):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::getHostFunction):
* runtime/JSGlobalData.h:
(JSGlobalData):
* wtf/OSAllocatorPosix.cpp:
(WTF::OSAllocator::reserveAndCommit):
* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108020 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRun sort-Xcode-project-file.
tkent@chromium.org [Fri, 17 Feb 2012 03:50:29 +0000 (03:50 +0000)]
Run sort-Xcode-project-file.

* WebCore.xcodeproj/project.pbxproj: Sorted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108019 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAnother build fix for viewport tests
mhahnenberg@apple.com [Fri, 17 Feb 2012 03:46:48 +0000 (03:46 +0000)]
Another build fix for viewport tests

No new tests.

* dom/ViewportArguments.cpp:
(WebCore::numericPrefix): We now return NaN instead of 0 when we fail to
parse a number using charactersToFloatIgnoringJunk, so we need to assert that
we have NaN rather than 0.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108018 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] pull third_party/gold to fix linux build
evan@chromium.org [Fri, 17 Feb 2012 03:32:05 +0000 (03:32 +0000)]
[chromium] pull third_party/gold to fix linux build
https://bugs.webkit.org/show_bug.cgi?id=78842

Reviewed by Tony Chang.

The Chrome build now depends on third_party/gold also being checked out.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108017 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Rebaseline JPEG image results after r107389
noel.gordon@gmail.com [Fri, 17 Feb 2012 03:28:23 +0000 (03:28 +0000)]
[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #24 of N.  Differences in rendered image extents on chrome
LINUX, WIN compared to chrome MAC.  Retain that fact in test_expectations.txt.

* platform/chromium-linux/tables/mozilla/bugs/bug101674-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug101674-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug101674-expected.txt:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108016 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: [chromium] Fix bugs in the implementation of WebDatabase::closeDataba...
michaeln@google.com [Fri, 17 Feb 2012 03:18:48 +0000 (03:18 +0000)]
Source/WebCore: [chromium] Fix bugs in the implementation of WebDatabase::closeDatabaseImmediately.
https://bugs.webkit.org/show_bug.cgi?id=78841

WebDatabase now delegates this function entirely to DatabaseTracker,
a new closeDatabasesImmediately() has been added for that purpose. That
method posts tasks to the appropiate context thread for each database
instance that should be closed immediately.

The DatabaseTracker getAllOpenDatabases() method has been removed from
the chromium impl because it's unsafe, refs cannot be safely taken on
AbstractDatabase instances in the tracker's collection of open databases.

Add a message to the console log when a database is forcibly closed.

Transactions initiated on a database instance that has been forcibly
closed complete with a transaction error callback.

This is part of resolving http://crbug.com/98939

Reviewed by David Levin.

No new layout tests, there is no common code way to closeImmediately.
We have coverage for this in py automation tests.

* platform/sql/SQLiteDatabase.cpp:
The closeImmediately code path can result in the underlying sqlite3 handle being
closed earlier than usual and trip some assertions. Updated the assertions to no
longer trigger in this early close case.
(WebCore::SQLiteDatabase::close):
(WebCore::SQLiteDatabase::setMaximumSize):
* platform/sql/SQLiteDatabase.h:
(WebCore::SQLiteDatabase::sqlite3Handle):

* storage/Database.cpp:
(WebCore::Database::closeImmediately): Modified to only be called on the context thread and to log a console message.
(WebCore::Database::changeVersion): Use the private runTransaction helper method.
(WebCore::Database::transaction): Pass a new param required by the runTransaction helper.
(WebCore::Database::readTransaction): Ditto.
(WebCore::callTransactionErrorCallback): Used to defer invocation of the error callback.
(WebCore::Database::runTransaction): Modified to detect when the database has been closed, and
to invoke the error callback in that case. This also avoids creating a reference cycle between
a newly created transaction and the database that previously existed due to a transction being
added and never removed from the Q while in this state.
* storage/Database.h:
* storage/DatabaseSync.cpp:
(WebCore::DatabaseSync::closeImmediately): Modified to only be called on the context thread and to log a console message.
* storage/DatabaseTracker.h:

* storage/chromium/DatabaseTrackerChromium.cpp:
Posts tasks to the appropiate context thread for execution without bumping AbstractDatabase refcounts.
(DatabaseTracker::CloseOneDatabaseImmediatelyTask):
(WebCore::DatabaseTracker::CloseOneDatabaseImmediatelyTask::create):
(WebCore::DatabaseTracker::CloseOneDatabaseImmediatelyTask::performTask):
(WebCore::DatabaseTracker::CloseOneDatabaseImmediatelyTask::CloseOneDatabaseImmediatelyTask):
(WebCore::DatabaseTracker::closeDatabasesImmediately):
(WebCore::DatabaseTracker::closeOneDatabaseImmediately):

Source/WebKit/chromium: Fix bugs in the implementation of WebDatabase::closeDatabaseImmediately.
https://bugs.webkit.org/show_bug.cgi?id=78841

WebDatabase now delegates this function entirely to DatabaseTracker.
This is part of resolving http://crbug.com/98939

Reviewed by David Levin.

* src/WebDatabase.cpp:
(WebKit::WebDatabase::closeDatabaseImmediately):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108015 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Rebaseline JPEG image results after r107389
noel.gordon@gmail.com [Fri, 17 Feb 2012 02:41:11 +0000 (02:41 +0000)]
[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #23 of N.

* platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png:
* platform/chromium-mac-leopard/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png:
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108014 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Occlusion tracking with CSS filters
commit-queue@webkit.org [Fri, 17 Feb 2012 02:27:57 +0000 (02:27 +0000)]
[Chromium] Occlusion tracking with CSS filters
https://bugs.webkit.org/show_bug.cgi?id=77498

Patch by Dana Jansens <danakj@chromium.org> on 2012-02-16
Reviewed by James Robinson.

Source/WebCore:

The new CSS filter support within the compositor changes how
occlusion tracking needs to function. A filter can change the
alpha value of pixels, making an otherwise opaque pixel no
longer so. Secondly, a filter may move color values around
on a surface, which can cause otherwise occluded areas to
become visible and require painting.

New unit tests: CCLayerTreeHostTest.cpp

Tests: compositing/culling/filter-occlusion-alpha-large.html
       compositing/culling/filter-occlusion-alpha.html
       compositing/culling/filter-occlusion-blur-large.html
       compositing/culling/filter-occlusion-blur.html

* platform/graphics/chromium/RenderSurfaceChromium.cpp:
(WebCore::RenderSurfaceChromium::RenderSurfaceChromium):
* platform/graphics/chromium/RenderSurfaceChromium.h:
(WebCore::RenderSurfaceChromium::setFilters):
(WebCore::RenderSurfaceChromium::filters):
(WebCore::RenderSurfaceChromium::setNearestAncestorThatMovesPixels):
(WebCore::RenderSurfaceChromium::nearestAncestorThatMovesPixels):
(RenderSurfaceChromium):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::enterTargetRenderSurface):
(WebCore::CCLayerTreeHost::paintLayerContents):
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::subtreeShouldRenderToSeparateSurface):
(WebCore::calculateDrawTransformsAndVisibilityInternal):
(WebCore::CCLayerTreeHostCommon::calculateDrawTransformsAndVisibility):
* platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore::CCRenderSurface::CCRenderSurface):
* platform/graphics/chromium/cc/CCRenderSurface.h:
(WebCore::CCRenderSurface::setNearestAncestorThatMovesPixels):
(WebCore::CCRenderSurface::nearestAncestorThatMovesPixels):
(CCRenderSurface):
* platform/graphics/filters/FilterOperation.h:
(FilterOperation):
(WebCore::FilterOperation::affectsOpacity):
(WebCore::FilterOperation::movesPixels):
(WebCore::ReferenceFilterOperation::affectsOpacity):
(WebCore::ReferenceFilterOperation::movesPixels):
(ReferenceFilterOperation):
(WebCore::BasicComponentTransferFilterOperation::affectsOpacity):
(BasicComponentTransferFilterOperation):
(WebCore::BlurFilterOperation::affectsOpacity):
(WebCore::BlurFilterOperation::movesPixels):
(BlurFilterOperation):
(WebCore::DropShadowFilterOperation::affectsOpacity):
(DropShadowFilterOperation):
* platform/graphics/filters/FilterOperations.cpp:
(WebCore::FilterOperations::hasFilterThatAffectsOpacity):
(WebCore):
(WebCore::FilterOperations::hasFilterThatMovesPixels):
* platform/graphics/filters/FilterOperations.h:
(WebCore::FilterOperations::isEmpty):
(FilterOperations):

Source/WebKit/chromium:

* tests/CCLayerTreeHostTest.cpp:
(CCLayerTreeHostTestLayerOcclusionWithFilters):
(WTF::CCLayerTreeHostTestLayerOcclusionWithFilters::CCLayerTreeHostTestLayerOcclusionWithFilters):
(WTF::CCLayerTreeHostTestLayerOcclusionWithFilters::beginTest):
(WTF::CCLayerTreeHostTestLayerOcclusionWithFilters::afterTest):
(WTF):

LayoutTests:

* compositing/culling/filter-occlusion-alpha-expected.png: Added.
* compositing/culling/filter-occlusion-alpha-expected.txt: Added.
* compositing/culling/filter-occlusion-alpha-large-expected.png: Added.
* compositing/culling/filter-occlusion-alpha-large-expected.txt: Added.
* compositing/culling/filter-occlusion-alpha-large.html: Added.
* compositing/culling/filter-occlusion-alpha.html: Added.
* compositing/culling/filter-occlusion-blur-expected.txt: Added.
* compositing/culling/filter-occlusion-blur-large-expected.txt: Added.
* compositing/culling/filter-occlusion-blur-large.html: Added.
* compositing/culling/filter-occlusion-blur.html: Added.
* platform/chromium/compositing/culling/filter-occlusion-blur-expected.png: Added.
* platform/chromium/compositing/culling/filter-occlusion-blur-large-expected.png: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108013 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Rebaseline JPEG image results after r107389
noel.gordon@gmail.com [Fri, 17 Feb 2012 02:15:29 +0000 (02:15 +0000)]
[chromium] Rebaseline JPEG image results after r107389
https://bugs.webkit.org/show_bug.cgi?id=78454

Unreviewed. Rebaseline #22 of N.

* platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
* platform/chromium-mac-leopard/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Adapt to the removal of WebStringIml.h
leo.yang@torchmobile.com.cn [Fri, 17 Feb 2012 02:08:15 +0000 (02:08 +0000)]
[BlackBerry] Adapt to the removal of WebStringIml.h
https://bugs.webkit.org/show_bug.cgi?id=78784

Reviewed by Antonio Gomes.

Source/WebCore:

WebKit/blackberry/WebCoreSupport/WebStringImpl.h which hasn't been upstreamed
has been removed internally. We should adapt to this removal for the
upstreamed part of the BlackBerry port. Actually WebStringImpl is not necessary
because it just inherits from WTF::StringImpl but adding nothing.

No functionalities changed, no new tests.

* platform/text/blackberry/StringBlackBerry.cpp:
(WTF::String::operator WebString):

Source/WebKit:

blackberry/WebCoreSupport/WebStringImpl.h which hasn't been upstreamed
has been removed internally. We should adapt to this removal for the
upstreamed part of the BlackBerry port. Actually WebStringImpl is not necessary
because it just inherits from WTF::StringImpl but adding nothing.

* blackberry/Api/WebString.cpp:
(BlackBerry::WebKit::WebString::WebString):
(BlackBerry::WebKit::WebString::equalIgnoringCase):
* blackberry/Api/WebString.h:
(WTF):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMade Weak<T> single-owner, adding PassWeak<T>
ggaren@apple.com [Fri, 17 Feb 2012 01:56:13 +0000 (01:56 +0000)]
Made Weak<T> single-owner, adding PassWeak<T>
https://bugs.webkit.org/show_bug.cgi?id=78740

Reviewed by Sam Weinig.

Source/JavaScriptCore:

This works basically the same way as OwnPtr<T> and PassOwnPtr<T>.

This clarifies the semantics of finalizers: It's ambiguous and probably
a bug to copy a finalizer (i.e., it's a bug to run a C++ destructor
twice), so I've made Weak<T> non-copyable. Anywhere we used to copy a
Weak<T>, we now use PassWeak<T>.

This also makes Weak<T> HashMaps more efficient.

* API/JSClassRef.cpp:
(OpaqueJSClass::prototype): Use PassWeak<T> instead of set(), since
set() is gone now.

* JavaScriptCore.xcodeproj/project.pbxproj: Export!

* heap/PassWeak.h: Added.
(JSC):
(PassWeak):
(JSC::PassWeak::PassWeak):
(JSC::PassWeak::~PassWeak):
(JSC::PassWeak::get):
(JSC::::leakHandle):
(JSC::adoptWeak):
(JSC::operator==):
(JSC::operator!=): This is the Weak<T> version of PassOwnPtr<T>.

* heap/Weak.h:
(Weak):
(JSC::Weak::Weak):
(JSC::Weak::release):
(JSC::Weak::hashTableDeletedValue):
(JSC::=):
(JSC): Changed to be non-copyable, removing a lot of copying-related
APIs. Added hash traits so hash maps still work.

* jit/JITStubs.cpp:
(JSC::JITThunks::hostFunctionStub):
* runtime/RegExpCache.cpp:
(JSC::RegExpCache::lookupOrCreate): Use PassWeak<T>, as required by
our new hash map API.

Source/WebCore:

* bindings/js/JSDOMBinding.cpp:
(WebCore::jsStringSlowCase): Use PassWeak<T>, as required by our new
hash map API.

* bindings/js/JSDOMBinding.h:
(WebCore::getCachedWrapper):
(WebCore::cacheWrapper): Use PassWeak<T> and raw pointer, as required by
our new hash map API.

* bindings/js/JSEventListener.h:
(WebCore::JSEventListener::setWrapper):
* bindings/js/ScriptWrappable.h:
(WebCore::ScriptWrappable::setWrapper):
* bridge/jsc/BridgeJSC.cpp:
(JSC::Bindings::Instance::createRuntimeObject):
* bridge/runtime_root.cpp:
(JSC::Bindings::RootObject::addRuntimeObject): Use PassWeak<T>, as
required by our new hash map and Weak<T> APIs.

Source/WebKit2:

* WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
(WebKit::NPRuntimeObjectMap::getOrCreateJSObject): Use raw pointer and
PassWeak<T>, as required by our new hash map API.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCrash in visiblePositionForIndex
rniwa@webkit.org [Fri, 17 Feb 2012 01:43:50 +0000 (01:43 +0000)]
Crash in visiblePositionForIndex
https://bugs.webkit.org/show_bug.cgi?id=77683

Reviewed by Eric Seidel.

Source/WebCore:

Fixed the crash.

Test: editing/execCommand/applyblockelement-visiblepositionforindex-crash.html

* editing/ApplyBlockElementCommand.cpp:
(WebCore::ApplyBlockElementCommand::doApply):
* editing/InsertListCommand.cpp:
(WebCore::InsertListCommand::doApply):
* editing/htmlediting.cpp:
(WebCore::indexForVisiblePosition):
* editing/htmlediting.h:
(WebCore):

LayoutTests:

Add a regression test. It crashes Webkit with very high frequency.

* editing/execCommand/applyblockelement-visiblepositionforindex-crash-expected.txt: Added.
* editing/execCommand/applyblockelement-visiblepositionforindex-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoShadowBlur.cpp's cached content matching needs to consider m_layerSize changes
mdelaney@apple.com [Fri, 17 Feb 2012 01:40:33 +0000 (01:40 +0000)]
ShadowBlur.cpp's cached content matching needs to consider m_layerSize changes
https://bugs.webkit.org/show_bug.cgi?id=78765

Reviewed by Simon Fraser.

No new tests due to the flaky nature of reproducing the issue.

* platform/graphics/ShadowBlur.cpp:
(WebCore::ScratchBuffer::getScratchBuffer): Make sure to call clearScratchBuffer()
when we create a new ImageBuffer in order to invalidate cached values.
(WebCore::ScratchBuffer::setCachedShadowValues): Roll together matching and setting
of cached values into one method to enforce them being the same.
(WebCore::ScratchBuffer::setCachedInsetShadowValues): Ditto.

Restructure to use new method described above.
(WebCore::ShadowBlur::drawRectShadowWithoutTiling):
(WebCore::ShadowBlur::drawInsetShadowWithoutTiling):
(WebCore::ShadowBlur::drawInsetShadowWithTiling):
(WebCore::ShadowBlur::drawRectShadowWithTiling):
(WebCore::ShadowBlur::beginShadowLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108008 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Empty divs not transforming overflow correctly
commit-queue@webkit.org [Fri, 17 Feb 2012 01:30:27 +0000 (01:30 +0000)]
[chromium] Empty divs not transforming overflow correctly
https://bugs.webkit.org/show_bug.cgi?id=78850

Patch by Dana Jansens <danakj@chromium.org> on 2012-02-16
Reviewed by James Robinson.

Source/WebCore:

Test: compositing/overflow/transform-in-empty-container.html

* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::setSize):

LayoutTests:

* compositing/overflow/transform-in-empty-container-expected.png: Added.
* compositing/overflow/transform-in-empty-container-expected.txt: Added.
* compositing/overflow/transform-in-empty-container.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix use of long long in FractionalLayoutUnit::setRawValue
eae@chromium.org [Fri, 17 Feb 2012 01:16:15 +0000 (01:16 +0000)]
Fix use of long long in FractionalLayoutUnit::setRawValue
https://bugs.webkit.org/show_bug.cgi?id=78835

Reviewed by Eric Seidel.

Change setRawValue(long long) to compare against int min and max instead
of using abs as not all platforms we support implement a long long
version of abs or llabs.

No new tests.

* platform/FractionalLayoutUnit.h:
(WebCore::FractionalLayoutUnit::setRawValue):
Compare against int min/max instead of just max with abs.

(WebCore::FractionalLayoutUnit::isInBounds):
Fix type mismatch warning.

(WebCore::operator==):
Fix typo.

(WebCore::operator*):
Use long long version of setRawValue.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agonrwt: simplify worker interface
dpranke@chromium.org [Fri, 17 Feb 2012 01:11:25 +0000 (01:11 +0000)]
nrwt: simplify worker interface
https://bugs.webkit.org/show_bug.cgi?id=78181

Reviewed by Tony Chang.

This change moves code in name(), is_done(), run(), and cancel()
from Worker to AbstractWorker, since the logic is pretty much
boilerplate code that any implementation would want to use.

* Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
(get.should):
(AbstractWorker.__init__):
(AbstractWorker):
(AbstractWorker.name):
(AbstractWorker.stop_handling_messages):
(AbstractWorker.run):
(AbstractWorker.is_done):
(AbstractWorker.cancel):
* Scripts/webkitpy/layout_tests/controllers/worker.py:
(Worker.__init__):
(Worker.run):
(Worker.handle_stop):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Unreviewed baseline update for compositing/scrollbar-painting.html
jamesr@google.com [Fri, 17 Feb 2012 01:06:41 +0000 (01:06 +0000)]
[chromium] Unreviewed baseline update for compositing/scrollbar-painting.html

* platform/chromium-mac-snowleopard/compositing/scrollbar-painting-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: Add an internal flag to accept multiple shadow roots for the purpose...
shinyak@chromium.org [Fri, 17 Feb 2012 00:57:19 +0000 (00:57 +0000)]
Source/WebCore: Add an internal flag to accept multiple shadow roots for the purpose of tests.
https://bugs.webkit.org/show_bug.cgi?id=78453

Reviewed by Hajime Morita.

This patch introduces a flag to enable multiple shadow subtrees.
This flag is intended to be used for testing purpose for a while.
We will remove it later.

No new tests, no change in behavior.

* WebCore.exp.in:
* bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore):
* bindings/generic/RuntimeEnabledFeatures.h:
(RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::multipleShadowSubtreesEnabled):
(WebCore::RuntimeEnabledFeatures::setMultipleShadowSubtreesEnabled):
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::create):
* dom/ShadowRootList.cpp:
(WebCore::ShadowRootList::pushShadowRoot):
* testing/Internals.cpp:
(WebCore::Internals::setMultipleShadowSubtreesEnabled):
(WebCore):
* testing/Internals.h:
(Internals):
* testing/Internals.idl:

LayoutTests: Needs an internal flag to accept multiple shadow roots for the purpose of tests
https://bugs.webkit.org/show_bug.cgi?id=78453

Reviewed by Hajime Morita.

* fast/dom/shadow/shadow-root-js-api.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImprove usability of coding-style.html
tkent@chromium.org [Fri, 17 Feb 2012 00:57:14 +0000 (00:57 +0000)]
Improve usability of coding-style.html
https://bugs.webkit.org/show_bug.cgi?id=78470

Reviewed by Eric Seidel.

* coding/coding-style.html:
- Do not add a title attribute to each of LI elements
- Do not add a click handler to each of them
- Add a SPAN element in order to show [id-name] and provide smaller clickable area.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix the broken viewport tests
mhahnenberg@apple.com [Fri, 17 Feb 2012 00:54:37 +0000 (00:54 +0000)]
Fix the broken viewport tests
https://bugs.webkit.org/show_bug.cgi?id=78774

Reviewed by Kenneth Rohde Christiansen.

Source/JavaScriptCore:

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* wtf/text/WTFString.cpp:
(WTF):
(WTF::toDoubleType): Template-ized to allow other functions to specify whether they
want to allow trailing junk or not when calling strtod.
(WTF::charactersToDouble):
(WTF::charactersToFloat):
(WTF::charactersToFloatIgnoringJunk): Created new version of charactersToFloat that allows
trailing junk.
* wtf/text/WTFString.h:
(WTF):

Source/WebCore:

No new tests.

* dom/ViewportArguments.cpp:
(WebCore::numericPrefix): Changed to use the new charactersToFloatWithJunk function(s).

LayoutTests:

* platform/gtk/Skipped: Undoing tests skipped due to earlier breakage.
* platform/qt/Skipped: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Disable mock scrollbars for rubber-banding tests
commit-queue@webkit.org [Fri, 17 Feb 2012 00:49:42 +0000 (00:49 +0000)]
[chromium] Disable mock scrollbars for rubber-banding tests
https://bugs.webkit.org/show_bug.cgi?id=78370

Turning on mock scrollbars caused rubber-banding tests to fail
because the overhang is painted by the ScrollbarTheme, which
was replaced by the mock theme. Disable mock scrollbars for
these tests.

Patch by Alexei Svitkine <asvitkine@chromium.org> on 2012-02-16
Reviewed by James Robinson.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@108000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoVery large strings could cause the new quoted string to wrap.
cdn@chromium.org [Fri, 17 Feb 2012 00:48:11 +0000 (00:48 +0000)]
Very large strings could cause the new quoted string to wrap.
https://bugs.webkit.org/show_bug.cgi?id=78387

Reviewed by Eric Seidel.

* css/CSSParser.cpp:
(WebCore::quoteCSSString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd a themeChromiumAndroid.css file for android-specific default styles
eric@webkit.org [Fri, 17 Feb 2012 00:46:50 +0000 (00:46 +0000)]
Add a themeChromiumAndroid.css file for android-specific default styles
https://bugs.webkit.org/show_bug.cgi?id=78547

Reviewed by Adam Barth.

This includes the themeChromiumAndroid.css file from the Chromium-Android port
as well as some addidtional changes they had to html.css.  I believe those
changes were made before themeChromiumAndroid was created, but it's now the better place for this CSS.

* WebCore.gyp/WebCore.gyp:
* css/themeChromiumAndroid.css: Added.
(select[size][multiple]):
(input[type="date"], input[type="datetime"], input[type="datetime-local"], input[type="time"], input[type="month"]):
* rendering/RenderThemeChromiumAndroid.cpp:
(WebCore::RenderThemeChromiumAndroid::extraDefaultStyleSheet):
(WebCore):
* rendering/RenderThemeChromiumAndroid.h:
(RenderThemeChromiumAndroid):
(WebCore::RenderThemeChromiumAndroid::delegatesMenuListRendering):
(WebCore::RenderThemeChromiumAndroid::platformTapHighlightColor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoENH: Add ability to run subset of JavaScript layout tests with JSC
msaboff@apple.com [Fri, 17 Feb 2012 00:46:38 +0000 (00:46 +0000)]
ENH: Add ability to run subset of JavaScript layout tests with JSC
https://bugs.webkit.org/show_bug.cgi?id=78764

Reviewed by Gavin Barraclough.

Tools:

New simple test drive shell script that runs a defined
list of javascript tests using jsc and the standalone-{pre,post}.js
wrappers.

* Scripts/run-fast-jsc: Added.

LayoutTests:

* fast/js/jsc-test-list: Added. List of tests that can be run
using jsc.  Used by new Tools/Scripts/run-fast-jsc script.
* fast/js/resources/standalone-post.js: ~pdated to match changes
in js-test-post.js
* fast/js/resources/standalone-pre.js: Updated to match changes
in js-test-pre.js

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Unreviewed. Mark fast/js/stack.html as an expected failure, we aren't...
jamesr@google.com [Fri, 17 Feb 2012 00:28:33 +0000 (00:28 +0000)]
[chromium] Unreviewed. Mark fast/js/stack.html as an expected failure, we aren't interesting in converging on
this in v8.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/10616280> and https://bugs.webkit.org/show_bug.cgi?id=78767
beidson@apple.com [Fri, 17 Feb 2012 00:26:03 +0000 (00:26 +0000)]
<rdar://problem/10616280> and https://bugs.webkit.org/show_bug.cgi?id=78767
REGRESSION (r90471) - iAd Producer 2.0.1 produces blank pages

Reviewed by Sam Weinig.

Source/WebCore:

No new tests. (Subtle API change attached to a specific application)

* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::isLoadingInAPISense): Return true if the app needs the quirk
and there are outstanding subresource loads.

* page/Settings.cpp:
(WebCore::Settings::Settings):
* page/Settings.h:
(WebCore::Settings::setNeedsIsLoadingInAPISenseQuirk):
(WebCore::Settings::needsIsLoadingInAPISenseQuirk):
(Settings):

Source/WebKit/mac:

* WebView/WebView.mm:
(-[WebView _needsIsLoadingInAPISenseQuirk]):
(-[WebView _preferencesChanged:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove [ConvertScriptString] from FileReaderSync.idl
haraken@chromium.org [Fri, 17 Feb 2012 00:10:19 +0000 (00:10 +0000)]
Remove [ConvertScriptString] from FileReaderSync.idl
https://bugs.webkit.org/show_bug.cgi?id=78335

Reviewed by Eric Seidel.

Source/WebCore:

The spec says that FileReadSync should throw NOT_FOUND_ERR
if a given blob is invalid: http://www.w3.org/TR/FileAPI/#FileReaderSync

By this fix, we can completely remove [ConvertScriptString] from WebKit.

Tests: fast/files/workers/worker-read-blob-sync.html
       fast/files/workers/worker-read-file-sync.html

* fileapi/FileReaderSync.cpp: Modified to throw NOT_FOUND_ERR if a blob is invalid.
(WebCore::FileReaderSync::readAsArrayBuffer):
(WebCore::FileReaderSync::readAsBinaryString):
(WebCore::FileReaderSync::readAsText):
(WebCore::FileReaderSync::readAsDataURL):
* fileapi/FileReaderSync.idl:

* bindings/scripts/CodeGeneratorJS.pm: Removed [ConvertScriptString]
since no one is using it.
(NativeToJSValue):
* bindings/scripts/CodeGeneratorV8.pm: Ditto.
(NativeToJSValue):

* bindings/scripts/test/TestObj.idl: Removed a test case for [ConvertScriptString].

* bindings/scripts/test/CPP/WebDOMTestObj.cpp: Updated run-bindings-tests results.
* bindings/scripts/test/CPP/WebDOMTestObj.h:
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(webkit_dom_test_obj_get_property):
(webkit_dom_test_obj_class_init):
* bindings/scripts/test/GObject/WebKitDOMTestObj.h:
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore):
* bindings/scripts/test/JS/JSTestObj.h:
(WebCore):
* bindings/scripts/test/ObjC/DOMTestObj.h:
* bindings/scripts/test/ObjC/DOMTestObj.mm:
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore):

LayoutTests:

The spec says that FileReadSync should throw NOT_FOUND_ERR
if a given blob is invalid: http://www.w3.org/TR/FileAPI/#FileReaderSync
This patch adds test cases for FileReaderSync with an invalid blob
to check that NOT_FOUND_ERR is thrown.

* fast/files/resources/read-common.js:
(_readBlobAsArrayBufferSync):
(_readBlobAsBinaryStringSync):
(_readBlobAsTextSync):
(_readBlobAsDataURLSync):
* fast/files/workers/worker-read-blob-sync-expected.txt:
* fast/files/workers/worker-read-file-sync-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoIndexedDB: Chromium WebKit API support for IDBObjectStore.delete(IDBKeyRange)
jsbell@chromium.org [Fri, 17 Feb 2012 00:10:09 +0000 (00:10 +0000)]
IndexedDB: Chromium WebKit API support for IDBObjectStore.delete(IDBKeyRange)
https://bugs.webkit.org/show_bug.cgi?id=78619

Add an overload to WebIDBObjectStore::deleteFunction(). First part of a two-sided patch.

Reviewed by Darin Fisher.

* public/WebIDBObjectStore.h:
(WebKit::WebIDBObjectStore::deleteFunction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2012-02-16 Antonio Gomes <agomes@rim.com>
tonikitoo@webkit.org [Fri, 17 Feb 2012 00:04:35 +0000 (00:04 +0000)]
2012-02-16  Antonio Gomes  <agomes@rim.com>

       [BlackBerry] Implemented a way to defer client navigation change client notifications
       https://bugs.webkit.org/show_bug.cgi?id=78848

       Reviewed by Rob Buis.

       Currently we postpone touch_down till touch_up if user touches
       the screen and an input field has the WebKit focus. This is done
       so we can scroll the page without hidding the vkb needlessly.

       However, it breaks the conversion of touch to mouse events
       if an input field has the focus in the following scenario:
       an <input type=text> is focused and an user grab and-drag
       a <input type=range> knob/slide. It does not work until the
       user unfocuses the currently focused edit field.

       Patch introduces a way to unfocus a currently focused input field,
       without requesting the client to show or hide the virtual keyboard
       right way. Instead it gets a delayed notification of the vkb mode requested
       at either touch_released/mouse_up or touch_cancel time.

       For now, due to content side issues with major web sites,
       only delay navigation mode notification changes if we are not dealing with
       input modes.

       * WebKitSupport/InputHandler.cpp:
       (BlackBerry::WebKit::InputHandler::InputHandler):
       (BlackBerry::WebKit::InputHandler::nodeFocused):
       (BlackBerry::WebKit::InputHandler::setElementFocused):
       (BlackBerry::WebKit::InputHandler::setNavigationMode):
       (WebKit):
       (BlackBerry::WebKit::InputHandler::setDelayClientNotificationOfNavigationModeChange):
       (BlackBerry::WebKit::InputHandler::processPendingClientNavigationModeChangeNotification):
       (BlackBerry::WebKit::InputHandler::notifyClientOfNavigationModeChange):
       (BlackBerry::WebKit::InputHandler::willOpenPopupForNode):
       (BlackBerry::WebKit::InputHandler::setPopupListIndexes):
       (BlackBerry::WebKit::InputHandler::spannableTextInRange):
       (BlackBerry::WebKit::InputHandler::removeComposedText):
       (BlackBerry::WebKit::InputHandler::firstSpanInString):
       (BlackBerry::WebKit::InputHandler::setText):
       (BlackBerry::WebKit::InputHandler::setRelativeCursorPosition):
       * WebKitSupport/InputHandler.h:
       (InputHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2012-02-16 Antonio Gomes <agomes@rim.com>
tonikitoo@webkit.org [Fri, 17 Feb 2012 00:04:23 +0000 (00:04 +0000)]
2012-02-16  Antonio Gomes  <agomes@rim.com>

        Crash @WebPagePrivate::enqueueRenderingOfClippedContentOfScrollableNodeAfterInRegionScrolling MKS_2986818
        https://bugs.webkit.org/show_bug.cgi?id=78845

        Reviewed by Rob Buis.

        We were trying to operate on a cached Node when its page/frame/document
        were gone to PageCache already. To avoid such problems, lets clean up
        any document data we have cached when the Frame goes into the cache.

        * WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
        (WebCore::FrameLoaderClientBlackBerry::didSaveToPageCache):
        (WebCore):
        * WebCoreSupport/FrameLoaderClientBlackBerry.h:
        (FrameLoaderClientBlackBerry):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2012-02-16 Antonio Gomes <agomes@rim.com>
tonikitoo@webkit.org [Fri, 17 Feb 2012 00:04:11 +0000 (00:04 +0000)]
2012-02-16 Antonio Gomes <agomes@rim.com>

        [BlackBerry] Upstream touch handling related classes (Part III: InRegionScrollableArea)
        https://bugs.webkit.org/show_bug.cgi?id=78509

        Reviewed by Adam Treat and Rob Buis.

        InRegionScrollableArea specializes the BlackBerry specific ScrollViewBase,
        working as a read-only wrapper object for a scrollable areas in the page.
        It is used in our client side to control in-region scrolling (scrollable boxes,
        inner frames, etc).

        Initial upstream.

        * WebKitSupport/InRegionScrollableArea.cpp: Added.
        (WebKit):
        (BlackBerry::WebKit::InRegionScrollableArea::InRegionScrollableArea):
        (BlackBerry::WebKit::InRegionScrollableArea::calculateMinimumScrollPosition):
        (BlackBerry::WebKit::InRegionScrollableArea::calculateMaximumScrollPosition):
        (BlackBerry::WebKit::InRegionScrollableArea::layer):
        (BlackBerry):
        * WebKitSupport/InRegionScrollableArea.h: Added.
        (WebCore):
        (WebKit):
        (InRegionScrollableArea):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAttempt to fix the GTK build.
abarth@webkit.org [Thu, 16 Feb 2012 23:59:27 +0000 (23:59 +0000)]
Attempt to fix the GTK build.

* WebCoreSupport/GeolocationClientGtk.cpp:
(WebKit::GeolocationClient::requestPermission):
(WebKit::GeolocationClient::cancelPermissionRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Clipping/Transforms applied in wrong order in opaque paint tracking
commit-queue@webkit.org [Thu, 16 Feb 2012 23:51:00 +0000 (23:51 +0000)]
[chromium] Clipping/Transforms applied in wrong order in opaque paint tracking
https://bugs.webkit.org/show_bug.cgi?id=78775

Patch by Dana Jansens <danakj@chromium.org> on 2012-02-16
Reviewed by Stephen White.

Source/WebCore:

The clip was being applied in device coordinates, before transforming the painted
rect into device coordinates. This made any translations get doubly represented,
and gave incorrect paint tracking results.

Test: compositing/culling/unscrolled-within-boxshadow.html

Unit test: PlatformContextSkiaTest.cpp

* platform/graphics/skia/OpaqueRegionSkia.cpp:
(WebCore::OpaqueRegionSkia::didDraw):

Source/WebKit/chromium:

* tests/PlatformContextSkiaTest.cpp:
(WebCore::TEST):

LayoutTests:

* compositing/culling/unscrolled-within-boxshadow-expected.png: Added.
* compositing/culling/unscrolled-within-boxshadow-expected.txt: Added.
* compositing/culling/unscrolled-within-boxshadow.html: Added.
* compositing/overflow/clip-content-under-overflow-controls-expected.png:
* compositing/scrollbar-painting-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCrash with tables in multi-column layout.
inferno@chromium.org [Thu, 16 Feb 2012 23:35:17 +0000 (23:35 +0000)]
Crash with tables in multi-column layout.
https://bugs.webkit.org/show_bug.cgi?id=78415

Reviewed by Julien Chaffraix.

Source/WebCore:

Multi-column code creates anonymous column blocks directly
under RenderTable, thereby violating table layout assumption.
E.g. Captions in this testcase gets reparented to these anonymous
column blocks and when they go away, they are not able to clear
themselves from table's m_captions list (since RenderTable::removeChild
is not called).

Test: fast/multicol/span/table-multi-column-crash.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::containingColumnsBlock):

LayoutTests:

* fast/multicol/span/table-multi-column-crash-expected.txt: Added.
* fast/multicol/span/table-multi-column-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] File system api build is broken
commit-queue@webkit.org [Thu, 16 Feb 2012 23:32:46 +0000 (23:32 +0000)]
[GTK] File system api build is broken
https://bugs.webkit.org/show_bug.cgi?id=78479

Patch by ChangSeok Oh <shivamidow@gmail.com> on 2012-02-16
Reviewed by Philippe Normand.

This patch is a small step to support FileSystem API for GTK port.
As I know, bug58443 also dealt with it, but it looks like the submitted patch
needs to be updated. To do that, I think I need to discuss with the original author.
So, I hope to just fix build break issue in this bug.

No new tests. Implementing the feature is not done yet.

* GNUmakefile.list.am: Added some missing files.
* bindings/js/JSDirectoryEntryCustom.cpp: Added Error.h to use its API.
* platform/AsyncFileSystem.cpp:
(WebCore):
(WebCore::AsyncFileSystem::create): The arguments don't match the declaration in AsyncFileSystem.h.
* platform/gtk/AsyncFileSystemGtk.cpp: Added.
(WebCore):
(WebCore::AsyncFileSystem::isAvailable):
(WebCore::AsyncFileSystem::isValidType):
(WebCore::AsyncFileSystem::create):
(WebCore::AsyncFileSystem::openFileSystem):
(WebCore::AsyncFileSystem::crackFileSystemURL):
(WebCore::AsyncFileSystemGtk::AsyncFileSystemGtk):
(WebCore::AsyncFileSystemGtk::~AsyncFileSystemGtk):
(WebCore::AsyncFileSystemGtk::toURL):
(WebCore::AsyncFileSystemGtk::move):
(WebCore::AsyncFileSystemGtk::copy):
(WebCore::AsyncFileSystemGtk::remove):
(WebCore::AsyncFileSystemGtk::removeRecursively):
(WebCore::AsyncFileSystemGtk::readMetadata):
(WebCore::AsyncFileSystemGtk::createFile):
(WebCore::AsyncFileSystemGtk::createDirectory):
(WebCore::AsyncFileSystemGtk::fileExists):
(WebCore::AsyncFileSystemGtk::directoryExists):
(WebCore::AsyncFileSystemGtk::readDirectory):
(WebCore::AsyncFileSystemGtk::createWriter):
* platform/gtk/AsyncFileSystemGtk.h: Added.
(WebCore):
(AsyncFileSystemGtk):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoHandle dirty descendant visibility status in RenderLayer::updateLayerPositionsAfterScroll
enne@google.com [Thu, 16 Feb 2012 23:30:55 +0000 (23:30 +0000)]
Handle dirty descendant visibility status in RenderLayer::updateLayerPositionsAfterScroll
https://bugs.webkit.org/show_bug.cgi?id=78286

Reviewed by Julien Chaffraix.

This is an unfortunate bandaid over a corner case where sometimes the
visible descendant status dirty flag is true when this function is
called from FrameView::repaintFixedElementsAfterScrolling. As it
should be cheap to refresh this flag when dirty in most cases (as it
early outs after finding any visible descendant), just lazily update
the dirty flag here to ensure correctness.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updateLayerPositionsAfterScroll):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Update table pixel expectations. Unreviewed.
jamesr@google.com [Thu, 16 Feb 2012 23:25:43 +0000 (23:25 +0000)]
[chromium] Update table pixel expectations. Unreviewed.

* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug27038-1-expected.png: Renamed from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug27038-1-expected.png.
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug27038-2-expected.png: Renamed from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug27038-2-expected.png.
* platform/chromium-win/tables/mozilla/bugs/bug27038-1-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug27038-2-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Add WEBKIT_EXPORT to new WebDragData methods.
dcheng@chromium.org [Thu, 16 Feb 2012 22:54:43 +0000 (22:54 +0000)]
[chromium] Add WEBKIT_EXPORT to new WebDragData methods.
https://bugs.webkit.org/show_bug.cgi?id=78843

Reviewed by Tony Chang.

* public/platform/WebDragData.h:
(WebDragData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoChrome::*Geolocation* are just useless pass-throughs to ChromeClient and should be...
abarth@webkit.org [Thu, 16 Feb 2012 22:50:12 +0000 (22:50 +0000)]
Chrome::*Geolocation* are just useless pass-throughs to ChromeClient and should be removed
https://bugs.webkit.org/show_bug.cgi?id=78844

Reviewed by Eric Seidel.

These function serve no useful purpose and should be removed.

* page/Chrome.cpp:
(WebCore):
* page/Chrome.h:
(Chrome):
* page/Geolocation.cpp:
(WebCore::Geolocation::reset):
(WebCore::Geolocation::requestPermission):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd a missing image for my commit r107965.
inferno@chromium.org [Thu, 16 Feb 2012 22:45:14 +0000 (22:45 +0000)]
Add a missing image for my commit r107965.

* fast/multicol/span/clone-flexbox-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImplement Error.stack
oliver@apple.com [Thu, 16 Feb 2012 22:38:39 +0000 (22:38 +0000)]
Implement Error.stack
https://bugs.webkit.org/show_bug.cgi?id=66994

Reviewed by Gavin Barraclough.

Source/JavaScriptCore:

Implement support for stack traces on exception objects.  This is a rewrite
of the core portion of the last stack walking logic, but the mechanical work
of adding the information to an exception comes from the original work by
Juan Carlos Montemayor Elosua.

* interpreter/Interpreter.cpp:
(JSC::getCallerInfo):
(JSC):
(JSC::getSourceURLFromCallFrame):
(JSC::getStackFrameCodeType):
(JSC::Interpreter::getStackTrace):
(JSC::Interpreter::throwException):
(JSC::Interpreter::privateExecute):
* interpreter/Interpreter.h:
(JSC):
(StackFrame):
(JSC::StackFrame::toString):
(Interpreter):
* jsc.cpp:
(GlobalObject::finishCreation):
(functionJSCStack):
* parser/Nodes.h:
(JSC::FunctionBodyNode::setInferredName):
* parser/Parser.h:
(JSC::::parse):
* runtime/CommonIdentifiers.h:
* runtime/Error.cpp:
(JSC::addErrorInfo):
* runtime/Error.h:
(JSC):

LayoutTests:

Add testcases for producing a stack trace on exception objects.

* fast/js/exception-properties-expected.txt:
* fast/js/script-tests/exception-properties.js:
* fast/js/script-tests/stack-trace.js: Added.
(printStack):
(hostThrower):
(callbacker):
(outer):
(inner):
(evaler):
(normalOuter):
(normalInner):
(scripterInner):
(scripterOuter):
(selfRecursive1):
(selfRecursive2):
(selfRecursive3):
(throwError):
(object.get getter1.o.valueOf):
(object.get getter1):
(object.get getter2):
(object.get getter3.o2.valueOf):
(object.get getter3):
(object.nonInlineable.callCount):
(object.nonInlineable):
(object.inlineable):
(yetAnotherInlinedCall):
(makeInlinableCall):
(.try.g):
(h):
(mapTest):
(mapTestDriver):
(dfgFunction):
(try.f):
* fast/js/stack-trace-expected.txt: Added.
* fast/js/stack-trace.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2012-02-16 Antonio Gomes <agomes@rim.com>
tonikitoo@webkit.org [Thu, 16 Feb 2012 22:03:33 +0000 (22:03 +0000)]
2012-02-16 Antonio Gomes <agomes@rim.com>

        [BlackBerry] Upstream touch handling related classes (part II: FatFingers)
        https://bugs.webkit.org/show_bug.cgi?id=78509

        Reviewed by Rob Buis.

        FatFingers is the class responsible to the whole touch
        accuracy of the BlackBerry port. Initial upstream.

        * WebKitSupport/FatFingers.cpp: Added.
        (WebKit):
        (BlackBerry::WebKit::FatFingers::fingerRectForPoint):
        (BlackBerry::WebKit::hasMousePressListener):
        (BlackBerry::WebKit::FatFingers::isElementClickable):
        (BlackBerry::WebKit::isFieldWithText):
        (BlackBerry::WebKit::distanceBetweenPoints):
        (BlackBerry::WebKit::compareDistanceBetweenPoints):
        (BlackBerry::WebKit::isValidFrameOwner):
        (BlackBerry::WebKit::FatFingers::FatFingers):
        (BlackBerry::WebKit::FatFingers::~FatFingers):
        (BlackBerry::WebKit::FatFingers::findBestPoint):
        (BlackBerry::WebKit::FatFingers::checkFingerIntersection):
        (BlackBerry::WebKit::FatFingers::findIntersectingRegions):
        (BlackBerry::WebKit::FatFingers::checkForClickableElement):
        (BlackBerry::WebKit::FatFingers::checkForText):
        (BlackBerry::WebKit::FatFingers::getPaddings):
        (BlackBerry::WebKit::FatFingers::nodesFromRect):
        (BlackBerry::WebKit::FatFingers::getRelevantInfoFromPoint):
        (BlackBerry::WebKit::FatFingers::setSuccessfulFatFingersResult):
        * WebKitSupport/FatFingers.h: Added.
        (WebCore):
        (WebKit):
        (FatFingersResult):
        (BlackBerry::WebKit::FatFingersResult::FatFingersResult):
        (BlackBerry::WebKit::FatFingersResult::reset):
        (BlackBerry::WebKit::FatFingersResult::originPosition):
        (BlackBerry::WebKit::FatFingersResult::adjustedPosition):
        (BlackBerry::WebKit::FatFingersResult::positionWasAdjusted):
        (BlackBerry::WebKit::FatFingersResult::isTextInput):
        (BlackBerry::WebKit::FatFingersResult::isValid):
        (BlackBerry::WebKit::FatFingersResult::validNode):
        (BlackBerry::WebKit::FatFingersResult::nodeAsElementIfApplicable):
        (FatFingers):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Unreviewed, update baselines for region repaint tests due to skia off...
jamesr@google.com [Thu, 16 Feb 2012 21:32:57 +0000 (21:32 +0000)]
[chromium] Unreviewed, update baselines for region repaint tests due to skia off-by-one.

* platform/chromium-mac-snowleopard/fast/repaint/region-painting-invalidation-expected.png: Added.
* platform/chromium-win/fast/repaint/region-painting-invalidation-expected.png: Added.
* platform/chromium-win/fast/repaint/region-painting-invalidation-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Unreviewed, these regions tests pass after r107961.
tony@chromium.org [Thu, 16 Feb 2012 21:24:51 +0000 (21:24 +0000)]
[chromium] Unreviewed, these regions tests pass after r107961.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Unreviewed rebaselines and expectation updates.
jamesr@google.com [Thu, 16 Feb 2012 21:20:31 +0000 (21:20 +0000)]
[chromium] Unreviewed rebaselines and expectation updates.

* platform/chromium-linux/fast/html/details-add-summary-1-and-click-expected.png:
* platform/chromium-linux/fast/html/details-add-summary-10-and-click-expected.png:
* platform/chromium-linux/fast/html/details-add-summary-2-and-click-expected.png:
* platform/chromium-linux/fast/html/details-add-summary-3-and-click-expected.png:
* platform/chromium-linux/fast/html/details-add-summary-4-and-click-expected.png:
* platform/chromium-linux/fast/html/details-add-summary-5-and-click-expected.png:
* platform/chromium-linux/fast/html/details-add-summary-6-and-click-expected.png:
* platform/chromium-linux/fast/html/details-add-summary-7-and-click-expected.png:
* platform/chromium-linux/fast/html/details-add-summary-8-and-click-expected.png:
* platform/chromium-linux/fast/html/details-add-summary-9-and-click-expected.png:
* platform/chromium-linux/fast/html/details-remove-summary-1-and-click-expected.png:
* platform/chromium-linux/fast/html/details-remove-summary-2-and-click-expected.png:
* platform/chromium-linux/fast/html/details-remove-summary-3-and-click-expected.png:
* platform/chromium-linux/fast/html/details-remove-summary-4-and-click-expected.png:
* platform/chromium-linux/fast/html/details-remove-summary-5-and-click-expected.png:
* platform/chromium-linux/fast/html/details-remove-summary-6-and-click-expected.png:
* platform/chromium-mac-leopard/fast/html/details-add-summary-1-and-click-expected.png:
* platform/chromium-mac-leopard/fast/html/details-add-summary-10-and-click-expected.png:
* platform/chromium-mac-leopard/fast/html/details-add-summary-2-and-click-expected.png:
* platform/chromium-mac-leopard/fast/html/details-add-summary-3-and-click-expected.png:
* platform/chromium-mac-leopard/fast/html/details-add-summary-4-and-click-expected.png:
* platform/chromium-mac-leopard/fast/html/details-add-summary-5-and-click-expected.png:
* platform/chromium-mac-leopard/fast/html/details-add-summary-6-and-click-expected.png:
* platform/chromium-mac-leopard/fast/html/details-add-summary-7-and-click-expected.png:
* platform/chromium-mac-leopard/fast/html/details-add-summary-8-and-click-expected.png:
* platform/chromium-mac-leopard/fast/html/details-add-summary-9-and-click-expected.png:
* platform/chromium-mac-leopard/fast/html/details-remove-summary-1-and-click-expected.png:
* platform/chromium-mac-leopard/fast/html/details-remove-summary-2-and-click-expected.png:
* platform/chromium-mac-leopard/fast/html/details-remove-summary-3-and-click-expected.png:
* platform/chromium-mac-leopard/fast/html/details-remove-summary-4-and-click-expected.png:
* platform/chromium-mac-leopard/fast/html/details-remove-summary-5-and-click-expected.png:
* platform/chromium-mac-leopard/fast/html/details-remove-summary-6-and-click-expected.png:
* platform/chromium-mac-snowleopard/fast/html/details-add-summary-1-and-click-expected.png: Copied from LayoutTests/platform/chromium-mac-leopard/fast/html/details-add-summary-1-and-click-expected.png.
* platform/chromium-mac-snowleopard/fast/html/details-add-summary-10-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-10-and-click-expected.png.
* platform/chromium-mac-snowleopard/fast/html/details-add-summary-2-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-2-and-click-expected.png.
* platform/chromium-mac-snowleopard/fast/html/details-add-summary-3-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-8-and-click-expected.png.
* platform/chromium-mac-snowleopard/fast/html/details-add-summary-4-and-click-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/html/details-add-summary-5-and-click-expected.png: Copied from LayoutTests/platform/chromium-mac-leopard/fast/html/details-add-summary-8-and-click-expected.png.
* platform/chromium-mac-snowleopard/fast/html/details-add-summary-6-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-6-and-click-expected.png.
* platform/chromium-mac-snowleopard/fast/html/details-add-summary-7-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-7-and-click-expected.png.
* platform/chromium-mac-snowleopard/fast/html/details-add-summary-8-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-add-summary-9-and-click-expected.png.
* platform/chromium-mac-snowleopard/fast/html/details-add-summary-9-and-click-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-1-and-click-expected.png.
* platform/chromium-mac-snowleopard/fast/html/details-remove-summary-1-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-1-and-click-expected.png.
* platform/chromium-mac-snowleopard/fast/html/details-remove-summary-2-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-2-and-click-expected.png.
* platform/chromium-mac-snowleopard/fast/html/details-remove-summary-3-and-click-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-3-and-click-expected.png.
* platform/chromium-mac-snowleopard/fast/html/details-remove-summary-4-and-click-expected.png: Copied from LayoutTests/platform/chromium-mac-leopard/fast/html/details-add-summary-9-and-click-expected.png.
* platform/chromium-mac-snowleopard/fast/html/details-remove-summary-5-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-4-and-click-expected.png.
* platform/chromium-mac-snowleopard/fast/html/details-remove-summary-6-and-click-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/html/details-remove-summary-3-and-click-expected.png.
* platform/chromium-mac/fast/html/details-add-summary-1-and-click-expected.png: Removed.
* platform/chromium-mac/fast/html/details-add-summary-3-and-click-expected.png: Removed.
* platform/chromium-mac/fast/html/details-add-summary-4-and-click-expected.png: Removed.
* platform/chromium-mac/fast/html/details-add-summary-5-and-click-expected.png: Removed.
* platform/chromium-mac/fast/html/details-remove-summary-5-and-click-expected.png: Removed.
* platform/chromium-mac/fast/html/details-remove-summary-6-and-click-expected.png: Removed.
* platform/chromium-win/fast/html/details-add-summary-1-and-click-expected.png:
* platform/chromium-win/fast/html/details-add-summary-10-and-click-expected.png:
* platform/chromium-win/fast/html/details-add-summary-2-and-click-expected.png:
* platform/chromium-win/fast/html/details-add-summary-3-and-click-expected.png:
* platform/chromium-win/fast/html/details-add-summary-4-and-click-expected.png:
* platform/chromium-win/fast/html/details-add-summary-5-and-click-expected.png:
* platform/chromium-win/fast/html/details-add-summary-6-and-click-expected.png:
* platform/chromium-win/fast/html/details-add-summary-7-and-click-expected.png:
* platform/chromium-win/fast/html/details-add-summary-8-and-click-expected.png:
* platform/chromium-win/fast/html/details-add-summary-9-and-click-expected.png:
* platform/chromium-win/fast/html/details-remove-summary-1-and-click-expected.png:
* platform/chromium-win/fast/html/details-remove-summary-2-and-click-expected.png:
* platform/chromium-win/fast/html/details-remove-summary-3-and-click-expected.png:
* platform/chromium-win/fast/html/details-remove-summary-4-and-click-expected.png:
* platform/chromium-win/fast/html/details-remove-summary-5-and-click-expected.png:
* platform/chromium-win/fast/html/details-remove-summary-6-and-click-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, GTK rebaseline after r107952.
philn@webkit.org [Thu, 16 Feb 2012 21:06:25 +0000 (21:06 +0000)]
Unreviewed, GTK rebaseline after r107952.

* platform/gtk/fast/dom/Window/window-properties-expected.txt:
* platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/gtk/fast/js/global-constructors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[soup] Move important SoupSession feature initialization to WebCore
sergio@webkit.org [Thu, 16 Feb 2012 20:56:02 +0000 (20:56 +0000)]
[soup] Move important SoupSession feature initialization to WebCore
https://bugs.webkit.org/show_bug.cgi?id=68602

Reviewed by Martin Robinson.

Source/WebCore:

Moved content sniffer and decoder initialization from WebKit to
WebCore because network stuff will not work as expected without
them. Added also out-of-the-box proxy support to WebCore.

No new tests required as we're just moving stuff from WebKit to
WebCore.

* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::ResourceHandle::defaultSession):

Source/WebKit/gtk:

Moved content sniffer and decoder initialization from WebKit to
WebCore because network stuff will not work as expected without
them.

No new tests required as we're just moving stuff from WebKit to
WebCore.

* webkit/webkitglobals.cpp:
(webkitInit):

Source/WebKit2:

Moved content sniffer and decoder initialization from the
WebProcess to WebCore because network stuff will not work as
expected without them.

No new tests required as we're just moving stuff from the
WebProcess to WebCore.

* WebProcess/gtk/WebProcessMainGtk.cpp:
(WebKit::WebProcessMainGtk):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107973 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2012-02-16 Antonio Gomes <agomes@rim.com>
tonikitoo@webkit.org [Thu, 16 Feb 2012 20:55:34 +0000 (20:55 +0000)]
2012-02-16 Antonio Gomes <agomes@rim.com>

        [BlackBerry] Upstream touch handling related classes
        https://bugs.webkit.org/show_bug.cgi?id=78509

        Reviewed by Rob Buis.

        Initial upstream of the Blackberry specific single touch event
        handler class.

        * blackberry/WebKitSupport/TouchEventHandler.cpp: Added.
        (WebKit):
        (BlackBerry::WebKit::hasMouseMoveListener):
        (BlackBerry::WebKit::hasTouchListener):
        (BlackBerry::WebKit::elementExpectsMouseEvents):
        (BlackBerry::WebKit::shouldConvertTouchToMouse):
        (BlackBerry::WebKit::TouchEventHandler::TouchEventHandler):
        (BlackBerry::WebKit::TouchEventHandler::~TouchEventHandler):
        (BlackBerry::WebKit::TouchEventHandler::shouldSuppressMouseDownOnTouchDown):
        (BlackBerry::WebKit::TouchEventHandler::touchEventCancel):
        (BlackBerry::WebKit::TouchEventHandler::touchHoldEvent):
        (BlackBerry::WebKit::TouchEventHandler::handleTouchPoint):
        (BlackBerry::WebKit::TouchEventHandler::spellCheck):
        (BlackBerry::WebKit::TouchEventHandler::handleFatFingerPressed):
        (BlackBerry::WebKit::elementForTapHighlight):
        (BlackBerry::WebKit::TouchEventHandler::drawTapHighlight):
        * blackberry/WebKitSupport/TouchEventHandler.h: Added.
        (WebCore):
        (WebKit):
        (TouchEventHandler):
        (BlackBerry::WebKit::TouchEventHandler::lastFatFingersResult):
        (BlackBerry::WebKit::TouchEventHandler::resetLastFatFingersResult):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agothead in table without tbody causes table height doubling
jchaffraix@webkit.org [Thu, 16 Feb 2012 20:50:08 +0000 (20:50 +0000)]
thead in table without tbody causes table height doubling
https://bugs.webkit.org/show_bug.cgi?id=37244

Reviewed by Ojan Vafai.

Source/WebCore:

Tests: fast/table/double-height-table-no-tbody-expected.html
       fast/table/double-height-table-no-tbody.html

The bug is caused by the layout code would wrongly assuming that a
table without a <tbody> is an empty table. We would set the logical
height to the style's logical height wrongly before inflating the
logical height to account for the section(s). This would cause us
to increase past our needed size thus the bug.

* rendering/RenderTable.cpp:
(WebCore::RenderTable::layout):
A table is empty if it does not have any top section, not just a <tbody>.
The test uncovered an issue with height distribution in layoutRows where we
would distribute the extra height to the first <tbody> not section.

LayoutTests:

* fast/table/double-height-table-no-tbody-expected.html: Added.
* fast/table/double-height-table-no-tbody.html: Added.
Test that we properly lay out tables with only a <thead> or <tfoot>
exactly like a table with only a <tbody>.

* platform/chromium-linux/tables/mozilla/bugs/bug27038-1-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug27038-2-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug27038-1-expected.txt:
* platform/chromium-win/tables/mozilla/bugs/bug27038-2-expected.txt:
This is neither a progression nor a regression. We are not doing the right
thing as we don't distribute the extra logical height evenly over our sections.
Now we give the extra height to the <thead> (first section) instead of the <tbody>.

* platform/chromium/test_expectations.txt:
* platform/efl/test_expectations.txt:
* platform/gtk/test_expectations.txt:
* platform/mac/test_expectations.txt:
* platform/qt/test_expectations.txt:
* platform/win/test_expectations.txt:
Marked the previous tests as needing a new baseline.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCSS 2.1 failure: fixed-table-layout-013 and fixed-table-layout-015 fail
robert@webkit.org [Thu, 16 Feb 2012 20:40:20 +0000 (20:40 +0000)]
CSS 2.1 failure: fixed-table-layout-013 and fixed-table-layout-015 fail
https://bugs.webkit.org/show_bug.cgi?id=78027

Reviewed by Julien Chaffraix.

Source/WebCore:

Both of these test the (slightly implicit) rule that width set on column-groups cannot
affect the width of columns in a fixed layout table: http://www.w3.org/TR/CSS21/tables.html#fixed-table-layout
FF, Opera and IE all pass these two tests.

Tests: css2.1/20110323/fixed-table-layout-013.htm
       css2.1/20110323/fixed-table-layout-015.htm

* rendering/FixedTableLayout.cpp:
(WebCore::nextCol): A helper function for finding the next column along.
(WebCore::FixedTableLayout::calcWidthArray): Ignore width specified by column groups.
* rendering/RenderTableCol.h:
(WebCore::RenderTableCol::isTableColGroup): Convenience function for identifying column groups.

LayoutTests:

* css2.1/20110323/fixed-table-layout-013-expected.html: Added.
* css2.1/20110323/fixed-table-layout-013.htm: Added.
* css2.1/20110323/fixed-table-layout-015-expected.html: Added.
* css2.1/20110323/fixed-table-layout-015.htm: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107970 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Unreviewed, tests passing after the fix in r107874.
tony@chromium.org [Thu, 16 Feb 2012 20:32:43 +0000 (20:32 +0000)]
[chromium] Unreviewed, tests passing after the fix in r107874.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r107941.
philn@webkit.org [Thu, 16 Feb 2012 20:32:06 +0000 (20:32 +0000)]
Unreviewed, rolling out r107941.
http://trac.webkit.org/changeset/107941
https://bugs.webkit.org/show_bug.cgi?id=68602

Broke 23 http tests on GTK

Source/WebCore:

* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::ResourceHandle::defaultSession):

Source/WebKit/gtk:

* webkit/webkitglobals.cpp:
(webkitInit):

Source/WebKit2:

* WebProcess/gtk/WebProcessMainGtk.cpp:
(WebKit::WebProcessMainGtk):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoXSS Auditor bypass with U+2028/2029
tsepez@chromium.org [Thu, 16 Feb 2012 20:30:09 +0000 (20:30 +0000)]
XSS Auditor bypass with U+2028/2029
https://bugs.webkit.org/show_bug.cgi?id=78732

Reviewed by Adam Barth.

Source/WebCore:

Test: http/tests/security/xssAuditor/script-tag-with-trailing-comment-U2028.html

* html/parser/XSSAuditor.cpp:
(WebCore::isJSNewline):
(WebCore::XSSAuditor::snippetForJavaScript):

LayoutTests:

* http/tests/security/xssAuditor/script-tag-with-trailing-comment-U2028-expected.txt: Added.
* http/tests/security/xssAuditor/script-tag-with-trailing-comment-U2028.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNPN_GetValueForURL / NPNURLVProxy returns DIRECT when proxy configured via PAC
mrowe@apple.com [Thu, 16 Feb 2012 20:19:57 +0000 (20:19 +0000)]
NPN_GetValueForURL / NPNURLVProxy returns DIRECT when proxy configured via PAC
<http://webkit.org/b/78766> / <rdar://problem/10729283>

Reviewed by Anders Carlsson.

* platform/network/cf/ProxyServerCFNet.cpp:
(WebCore::proxyAutoConfigurationResultCallback): Stop the runloop, and then process
the results that we received.
(WebCore::processProxyServers): Processing of array of proxy configuration information
moved from addProxyServersForURL. Handling of proxy auto-configuration URLs is now handled
by calling CFNetworkExecuteProxyAutoConfigurationURL and waiting synchronously on the result
callback. Doing this synchronously is not great, but it's the best we can do without a lot
of restructuring of the code that calls this. We arbitrarily time out the execution after five
seconds to avoid permanently hanging.
(WebCore::addProxyServersForURL): Call in to our helper function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix clone() function to handle descendant classes of RenderBlock.
inferno@chromium.org [Thu, 16 Feb 2012 20:16:46 +0000 (20:16 +0000)]
Fix clone() function to handle descendant classes of RenderBlock.
https://bugs.webkit.org/show_bug.cgi?id=78273

Reviewed by Eric Seidel.

Source/WebCore:

Test: fast/multicol/span/clone-flexbox-crash.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::clone):

LayoutTests:

You should see two RenderFlexibleBox in the rendertree, indicating that
cloning was correct.

* fast/multicol/span/clone-flexbox-expected.txt: Added.
* fast/multicol/span/clone-flexbox.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd a perf test for the CSS parser.
alexis.menard@openbossa.org [Thu, 16 Feb 2012 20:14:38 +0000 (20:14 +0000)]
Add a perf test for the CSS parser.
https://bugs.webkit.org/show_bug.cgi?id=78114

Reviewed by Ryosuke Niwa.

Add a perf test for the CSS parser. It load a big CSS chunk
which contains some snippets of the YUI library from Yahoo!.

* Parser/css-parser-yui.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd to committers.py
tsepez@chromium.org [Thu, 16 Feb 2012 20:00:22 +0000 (20:00 +0000)]
Add to committers.py

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Unreviewed gardening
jamesr@google.com [Thu, 16 Feb 2012 19:57:50 +0000 (19:57 +0000)]
[chromium] Unreviewed gardening

* platform/chromium/fast/js/property-getters-and-setters-expected.txt:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[CSSRegions]overflowRegion tests are flaky
commit-queue@webkit.org [Thu, 16 Feb 2012 19:39:53 +0000 (19:39 +0000)]
[CSSRegions]overflowRegion tests are flaky
https://bugs.webkit.org/show_bug.cgi?id=78761

Patch by Raul Hudea <rhudea@adobe.com> on 2012-02-16
Reviewed by Tony Chang.

Source/WebCore:

The overflowRegion tests were updated.

* dom/Element.cpp:
(WebCore::Element::webkitRegionOverflow):

LayoutTests:

* fast/regions/element-region-overflow-state-expected.txt:
* fast/regions/element-region-overflow-state-vertical-rl-expected.txt:
* fast/regions/element-region-overflow-state-vertical-rl.html:
* fast/regions/element-region-overflow-state.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Add method to WebPluginContainer to check if a rectangle is topmost
commit-queue@webkit.org [Thu, 16 Feb 2012 19:36:26 +0000 (19:36 +0000)]
[chromium] Add method to WebPluginContainer to check if a rectangle is topmost
https://bugs.webkit.org/show_bug.cgi?id=78166

Patch by Viet-Trung Luu <viettrungluu@chromium.org> on 2012-02-16
Reviewed by Darin Fisher.

* public/WebPluginContainer.h:
(WebPluginContainer):
* src/WebPluginContainerImpl.cpp:
* src/WebPluginContainerImpl.h:
(WebPluginContainerImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[CSS Regions] Repaint issues when changing innerHTML of content
commit-queue@webkit.org [Thu, 16 Feb 2012 19:15:40 +0000 (19:15 +0000)]
[CSS Regions] Repaint issues when changing innerHTML of content
https://bugs.webkit.org/show_bug.cgi?id=78787

Patch by Raul Hudea <rhudea@adobe.com> on 2012-02-16
Reviewed by David Hyatt.

Source/WebCore:

The calculation of the clipping rectangle is based on the repaint rectangle,
so it needs to be clipped to the current region, because it might spread over multiple ones.

Test: fast/repaint/region-painting-invalidation.html

* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::repaintRectangleInRegions):

LayoutTests:

* fast/repaint/region-painting-invalidation.html: Added.
* platform/chromium/test_expectations.txt: Needs baseline
* platform/mac/fast/repaint/region-painting-invalidation-expected.png: Added.
* platform/mac/fast/repaint/region-painting-invalidation-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Unreviewed chromium gardening
jamesr@google.com [Thu, 16 Feb 2012 19:12:32 +0000 (19:12 +0000)]
[chromium] Unreviewed chromium gardening

* platform/chromium-linux/svg/text/tspan-dynamic-positioning-expected.png: Added.
* platform/chromium-mac-leopard/compositing/plugins/composited-plugin-expected.png: Added.
* platform/chromium-mac-leopard/compositing/plugins/composited-plugin-expected.txt: Added.
* platform/chromium-mac-leopard/svg/text/tspan-dynamic-positioning-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/text/tspan-dynamic-positioning-expected.png: Added.
* platform/chromium-win/svg/text/tspan-dynamic-positioning-expected.png: Added.
* platform/chromium-win/svg/text/tspan-dynamic-positioning-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNumerous trivial bugs in Object.defineProperty
barraclough@apple.com [Thu, 16 Feb 2012 19:08:01 +0000 (19:08 +0000)]
Numerous trivial bugs in Object.defineProperty
https://bugs.webkit.org/show_bug.cgi?id=78777

Reviewed by Sam Weinig.

There are a handful of really trivial bugs, related to Object.defineProperty:
    * Redefining an accessor with different attributes changes the attributes, but not the get/set functions!
    * Calling an undefined setter should only throw in strict mode.
    * When redefining an accessor to a data decriptor, if writable is not specified we should default to false.
    * Any attempt to redefine a non-configurable property of an array as configurable should be rejected.
    * Object.defineProperties should call toObject on 'Properties' argument, rather than throwing if it is not an object.
    * If preventExtensions has been called on an array, subsequent assignment beyond array bounds should fail.
    * 'isFrozen' shouldn't be checking the ReadOnly bit for accessor descriptors (we presently always keep this bit as 'false').
    * Should be able to redefine an non-writable, non-configurable property, with the same value and attributes.
    * Should be able to define an non-configurable accessor.
These are mostly all one-line changes, e.g. inverted boolean checks, masking against wrong attribute.

Source/JavaScriptCore:

* runtime/JSArray.cpp:
(JSC::SparseArrayValueMap::put):
    - Added ASSERT.
    - Calling an undefined setter should only throw in strict mode.
(JSC::JSArray::putDescriptor):
    - Should be able to define an non-configurable accessor.
(JSC::JSArray::defineOwnNumericProperty):
    - Any attempt to redefine a non-configurable property of an array as configurable should be rejected.
(JSC::JSArray::putByIndexBeyondVectorLength):
    - If preventExtensions has been called on an array, subsequent assignment beyond array bounds should fail.
* runtime/JSArray.h:
(JSArray):
    - made enterDictionaryMode public, called from JSObject.
* runtime/JSObject.cpp:
(JSC::JSObject::put):
    - Calling an undefined setter should only throw in strict mode.
(JSC::JSObject::preventExtensions):
    - Put array objects into dictionary mode to handle this!
(JSC::JSObject::defineOwnProperty):
    - Should be able to redefine an non-writable, non-configurable property, with the same value and attributes.
    - Redefining an accessor with different attributes changes the attributes, but not the get/set functions!
* runtime/ObjectConstructor.cpp:
(JSC::objectConstructorDefineProperties):
    - Object.defineProperties should call toObject on 'Properties' argument, rather than throwing if it is not an object.
* runtime/PropertyDescriptor.cpp:
(JSC::PropertyDescriptor::attributesWithOverride):
    - When redefining an accessor to a data decriptor, if writable is not specified we should default to false.
(JSC::PropertyDescriptor::attributesOverridingCurrent):
    - When redefining an accessor to a data decriptor, if writable is not specified we should default to false.
* runtime/Structure.cpp:
(JSC::Structure::freezeTransition):
    - 'freezeTransition' shouldn't be setting the ReadOnly bit for accessor descriptors (we presently always keep this bit as 'false').
(JSC::Structure::isFrozen):
    - 'isFrozen' shouldn't be checking the ReadOnly bit for accessor descriptors (we presently always keep this bit as 'false').

LayoutTests:

* fast/js/Object-defineProperties-expected.txt:
* fast/js/Object-defineProperty-expected.txt:
* fast/js/preventExtensions-expected.txt:
* fast/js/property-getters-and-setters-expected.txt:
* fast/js/script-tests/Object-defineProperty.js:
* fast/js/script-tests/preventExtensions.js:
* fast/js/script-tests/property-getters-and-setters.js:
    - Update result & add new test cases for all bugs fixed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@107957 268f45cc-cd09-0410-ab3c-d52691b4dbfc