WebKit-https.git
10 years agoCaret is drawn in the wrong place in multi-column blocks
mitz@apple.com [Sat, 22 Oct 2011 05:52:52 +0000 (05:52 +0000)]
Caret is drawn in the wrong place in multi-column blocks
https://bugs.webkit.org/show_bug.cgi?id=70662

Reviewed by Gavin Barraclough.

* manual-tests/caret-in-columns.html: Added.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintCaret): Removed the call to offsetForContents(). That function takes
a point in local coordinates, whereas this function was applying it to a point in painting root
coordinates. The desired effect was only to undo the scroll adjustment done by the caller,
paintObject().
(WebCore::RenderBlock::paintObject): Pass the original, rather than scroll-adjusted, paint offset
to paintCaret().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[EFL] Change efl style local variables with WebKit coding Style.
gyuyoung.kim@samsung.com [Sat, 22 Oct 2011 05:32:12 +0000 (05:32 +0000)]
[EFL] Change efl style local variables with WebKit coding Style.
https://bugs.webkit.org/show_bug.cgi?id=69988

Reviewed by Antonio Gomes.

Change *sd* variable name with *smartData*. Some variables were changed by Bug 69988.

* ewk/ewk_frame.cpp:
(ewk_frame_view_get):
(ewk_frame_uri_set):
(ewk_frame_uri_get):
(ewk_frame_contents_size_get):
(ewk_frame_load_document_finished):
(ewk_frame_load_error):
(ewk_frame_title_set):
(ewk_frame_uri_changed):
(ewk_frame_editor_client_selection_changed):
(ewk_frame_editor_client_contents_changed):
(EWKPrivate::coreFrame):
* ewk/ewk_view.cpp:
(_ewk_view_smart_pre_render_region):
(_ewk_view_smart_pre_render_relative_radius):
(_ewk_view_smart_pre_render_cancel):
(_ewk_view_smart_disable_render):
(_ewk_view_smart_enable_render):
(EWKPrivate::corePage):
* ewk/ewk_view_single.cpp:
(_ewk_view_single_smart_add):
(_ewk_view_single_smart_resize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98190 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[WK2] Clicking a print button in a PDF doesn't do anything
ap@apple.com [Sat, 22 Oct 2011 04:57:09 +0000 (04:57 +0000)]
[WK2] Clicking a print button in a PDF doesn't do anything
https://bugs.webkit.org/show_bug.cgi?id=70663
<rdar://problem/9795014>

Reviewed by Dan Bernstein.

* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.cpp: (WebKit::WebPageProxy::printMainFrame): Added a public method
that PDFViewController could call.

* UIProcess/API/mac/PDFViewController.h:
* UIProcess/API/mac/PDFViewController.mm:
(-[WKPDFView PDFViewPerformPrint:]):
(WebKit::PDFViewController::print):
Connect PDFView delegate method for printing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98189 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDFG inlining sometimes fails to reset constant references
fpizlo@apple.com [Sat, 22 Oct 2011 03:58:55 +0000 (03:58 +0000)]
DFG inlining sometimes fails to reset constant references
https://bugs.webkit.org/show_bug.cgi?id=70668

Source/JavaScriptCore:

Reviewed by Anders Carlsson.

Reset constant references when we need to (new block created) and not
when we don't (change of inlining depth).

* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::prepareToParseBlock):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::parseCodeBlock):

LayoutTests:

Reviewed by Anders Carlsson.

Added a new test that covers this specific bug as well as the general
ability to perform inlining, and the ability to OSR out of an inline
stack.

* fast/js/dfg-inline-constant-expected.txt: Added.
* fast/js/dfg-inline-constant.html: Added.
* fast/js/script-tests/dfg-inline-constant.js: Added.
(foo):
(bar):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98188 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoLookup does not work on text using web fonts in WebKit2
weinig@apple.com [Sat, 22 Oct 2011 03:56:01 +0000 (03:56 +0000)]
Lookup does not work on text using web fonts in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=70669
<rdar://problem/10147441>

Reviewed by Anders Carlsson.

* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::performDictionaryLookupForRange):
If the font for the range is web font (and therefore no NSFont is
available), use the system font of the same size. While not great,
it approximates what WebKit1 does.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix crash below CoreIPC::MessageSender<WebKit::WebPage>::send<Messages::WebPageProxy...
weinig@apple.com [Sat, 22 Oct 2011 03:25:07 +0000 (03:25 +0000)]
Fix crash below CoreIPC::MessageSender<WebKit::WebPage>::send<Messages::WebPageProxy::DidPerformDictionaryLookup>
https://bugs.webkit.org/show_bug.cgi?id=70667
<rdar://problem/9622186>

Reviewed by Anders Carlsson.

* Shared/DictionaryPopupInfo.cpp:
(WebKit::DictionaryPopupInfo::encode):
(WebKit::DictionaryPopupInfo::decode):
Account for the fact that the options dictionary can be null. This is due to Lookup passing
back a null, rather than empty, dictionary when it could not find any interesting characteristics.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Make setVisibility extension- and thread-correct
nduca@chromium.org [Sat, 22 Oct 2011 03:15:41 +0000 (03:15 +0000)]
[chromium] Make setVisibility extension- and thread-correct
https://bugs.webkit.org/show_bug.cgi?id=70635

Reviewed by Kenneth Russell.

Source/WebCore:

* platform/graphics/chromium/Extensions3DChromium.h:
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::initialize):
(WebCore::LayerRendererChromium::setVisible):
* platform/graphics/chromium/LayerRendererChromium.h:
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::LayerRendererCapabilities::LayerRendererCapabilities):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::setVisible):

Source/WebKit/chromium:

* public/WebGraphicsContext3D.h:
(WebKit::WebGraphicsContext3D::setVisibilityCHROMIUM):
* src/Extensions3DChromium.cpp:
(WebCore::Extensions3DChromium::setVisibilityCHROMIUM):
* src/GraphicsContext3DChromium.cpp:
* src/GraphicsContext3DPrivate.h:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setVisibilityState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd WKBrowsingContextGroup which wraps WKPageGroupRef
weinig@apple.com [Sat, 22 Oct 2011 02:51:33 +0000 (02:51 +0000)]
Add WKBrowsingContextGroup which wraps WKPageGroupRef
https://bugs.webkit.org/show_bug.cgi?id=70665

Reviewed by Anders Carlsson.

* UIProcess/API/mac/WKBrowsingContextGroup.h: Added.
* UIProcess/API/mac/WKBrowsingContextGroup.mm: Added.
(-[WKBrowsingContextGroup initWithIdentifier:]):
(-[WKBrowsingContextGroup dealloc]):
(-[WKBrowsingContextGroup pageGroupRef]):
* UIProcess/API/mac/WKBrowsingContextGroupInternal.h: Added.
* UIProcess/API/mac/WKView.h:
* UIProcess/API/mac/WKView.mm:
(-[WKView initWithFrame:processGroup:browsingContextGroup:]):
* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98184 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFixup test expectations now that http://trac.webkit.org/changeset/98173 has landed.
ojan@chromium.org [Sat, 22 Oct 2011 02:24:23 +0000 (02:24 +0000)]
Fixup test expectations now that trac.webkit.org/changeset/98173 has landed.

* platform/chromium-cg-mac-leopard/fast/backgrounds/background-leakage-transforms-expected.png: Added.
* platform/chromium-cg-mac-leopard/fast/writing-mode/fallback-orientation-expected.png:
* platform/chromium-cg-mac-snowleopard/fast/backgrounds/background-leakage-transforms-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/writing-mode/fallback-orientation-expected.png: Added.
* platform/chromium-cg-mac/fast/backgrounds/background-leakage-transforms-expected.png: Removed.
* platform/chromium-mac-leopard/fast/backgrounds/background-leakage-transforms-expected.png: Added.
* platform/chromium-mac-leopard/fast/writing-mode/fallback-orientation-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/backgrounds/background-leakage-transforms-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/writing-mode/fallback-orientation-expected.png:
* platform/chromium-mac/fast/backgrounds/background-leakage-transforms-expected.png: Removed.
* platform/chromium-win/fast/backgrounds/background-leakage-transforms-expected.txt: Added.
* platform/chromium/fast/backgrounds/background-leakage-transforms-expected.txt: Added.
* platform/chromium/fast/writing-mode/fallback-orientation-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98183 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Layout Test fast/canvas/webgl/premultiplyalpha-test.html is failing
jchaffraix@webkit.org [Sat, 22 Oct 2011 01:42:06 +0000 (01:42 +0000)]
[Chromium] Layout Test fast/canvas/webgl/premultiplyalpha-test.html is failing
https://bugs.webkit.org/show_bug.cgi?id=68885

Unreviewed gardening.

* platform/chromium/test_expectations.txt: Removed the test since it has been passing on
the bots for at least a week.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98182 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed rebaseline.
jchaffraix@webkit.org [Sat, 22 Oct 2011 01:32:49 +0000 (01:32 +0000)]
Unreviewed rebaseline.

This test started failing on the bot. As this is a progression, updating the baseline.

* platform/chromium-cg-mac-snowleopard/fast/multicol/flipped-blocks-border-after-expected.png: Removed.
* platform/chromium-cg-mac-snowleopard/fast/multicol/flipped-blocks-border-after-expected.txt: Removed.
* platform/chromium-mac/fast/multicol/flipped-blocks-border-after-expected.png: Removed.
* platform/chromium-mac/fast/multicol/flipped-blocks-border-after-expected.txt: Removed.
* platform/chromium/fast/multicol/flipped-blocks-border-after-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98181 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Layout Test canvas/philip/tests/toDataURL.jpeg.*.html is failing on Mac...
jchaffraix@webkit.org [Sat, 22 Oct 2011 01:26:06 +0000 (01:26 +0000)]
[Chromium] Layout Test canvas/philip/tests/toDataURL.jpeg.*.html is failing on Mac 10.5 CG
https://bugs.webkit.org/show_bug.cgi?id=68879

Reviewed by Adam Barth.

* platform/chromium/test_expectations.txt: Those changes have been consistently passing on
the bots for at least 10 days.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98180 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDFG should have inlining
fpizlo@apple.com [Sat, 22 Oct 2011 01:22:46 +0000 (01:22 +0000)]
DFG should have inlining
https://bugs.webkit.org/show_bug.cgi?id=69996

Reviewed by Oliver Hunt.

Implements inlining that's hooked into the bytecode parser. Only
works for calls, for now, though nothing fundamentally prevents us
from inlining constructor calls. 2% overall speed-up on all
benchmarks. 7% speed-up on V8 (around 34% and 27% on deltablue and
richards respectively), neutral on Kraken and SunSpider.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::visitAggregate):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::baselineVersion):
(JSC::CodeBlock::setInstructionCount):
(JSC::CodeBlock::likelyToTakeSlowCase):
(JSC::CodeBlock::couldTakeSlowCase):
(JSC::CodeBlock::likelyToTakeSpecialFastCase):
(JSC::CodeBlock::likelyToTakeDeepestSlowCase):
(JSC::CodeBlock::likelyToTakeAnySlowCase):
* bytecode/CodeOrigin.h:
(JSC::CodeOrigin::inlineDepthForCallFrame):
(JSC::CodeOrigin::inlineDepth):
(JSC::CodeOrigin::operator==):
(JSC::CodeOrigin::inlineStack):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::generate):
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::beginBasicBlock):
(JSC::DFG::AbstractState::execute):
(JSC::DFG::AbstractState::mergeStateAtTail):
* dfg/DFGBasicBlock.h:
(JSC::DFG::BasicBlock::BasicBlock):
(JSC::DFG::BasicBlock::ensureLocals):
(JSC::DFG::UnlinkedBlock::UnlinkedBlock):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::getDirect):
(JSC::DFG::ByteCodeParser::get):
(JSC::DFG::ByteCodeParser::setDirect):
(JSC::DFG::ByteCodeParser::set):
(JSC::DFG::ByteCodeParser::getLocal):
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::flush):
(JSC::DFG::ByteCodeParser::InlineStackEntry::~InlineStackEntry):
(JSC::DFG::ByteCodeParser::InlineStackEntry::remapOperand):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::processPhiStack):
(JSC::DFG::ByteCodeParser::linkBlock):
(JSC::DFG::ByteCodeParser::linkBlocks):
(JSC::DFG::ByteCodeParser::handleSuccessor):
(JSC::DFG::ByteCodeParser::determineReachability):
(JSC::DFG::ByteCodeParser::buildOperandMapsIfNecessary):
(JSC::DFG::ByteCodeParser::InlineStackEntry::InlineStackEntry):
(JSC::DFG::ByteCodeParser::parseCodeBlock):
(JSC::DFG::ByteCodeParser::parse):
* dfg/DFGCapabilities.cpp:
(JSC::DFG::canHandleOpcodes):
(JSC::DFG::canCompileOpcodes):
(JSC::DFG::canInlineOpcodes):
* dfg/DFGCapabilities.h:
(JSC::DFG::mightCompileEval):
(JSC::DFG::mightCompileProgram):
(JSC::DFG::mightCompileFunctionForCall):
(JSC::DFG::mightCompileFunctionForConstruct):
(JSC::DFG::mightInlineFunctionForCall):
(JSC::DFG::mightInlineFunctionForConstruct):
(JSC::DFG::canInlineOpcode):
(JSC::DFG::canInlineOpcodes):
(JSC::DFG::canInlineFunctionForCall):
(JSC::DFG::canInlineFunctionForConstruct):
* dfg/DFGGraph.cpp:
(JSC::DFG::printWhiteSpace):
(JSC::DFG::Graph::dumpCodeOrigin):
(JSC::DFG::Graph::dump):
* dfg/DFGGraph.h:
(JSC::DFG::GetBytecodeBeginForBlock::operator()):
(JSC::DFG::Graph::blockIndexForBytecodeOffset):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::decodedCodeMapFor):
(JSC::DFG::JITCompiler::linkOSRExits):
(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::debugCall):
(JSC::DFG::JITCompiler::baselineCodeBlockFor):
* dfg/DFGJITCompiler32_64.cpp:
(JSC::DFG::JITCompiler::exitSpeculativeWithOSR):
* dfg/DFGNode.h:
(JSC::DFG::Node::hasVariableAccessData):
(JSC::DFG::Node::shouldGenerate):
* dfg/DFGOperands.h:
(JSC::DFG::Operands::ensureLocals):
(JSC::DFG::Operands::setLocal):
(JSC::DFG::Operands::getLocal):
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::OSRExit::OSRExit):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::SpeculativeJIT):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* interpreter/CallFrame.cpp:
(JSC::CallFrame::trueCallerFrameSlow):
* jit/JITCall.cpp:
(JSC::JIT::compileOpCallSlowCase):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/Executable.cpp:
(JSC::FunctionExecutable::baselineCodeBlockFor):
(JSC::FunctionExecutable::produceCodeBlockFor):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):
* runtime/Executable.h:
(JSC::FunctionExecutable::profiledCodeBlockFor):
(JSC::FunctionExecutable::parameterCount):
* runtime/Heuristics.cpp:
(JSC::Heuristics::initializeHeuristics):
* runtime/Heuristics.h:
* runtime/JSFunction.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98179 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=70647
bdakin@apple.com [Sat, 22 Oct 2011 01:15:20 +0000 (01:15 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=70647
Common but unreproducible crash under [ScrollbarPartAnimation setCurrentProgress:]
-and corresponding-
<rdar://problem/9542018>

Reviewed by Sam Weinig.

This patch implements two speculative fixes for this crash.

First, block exceptions around all of the code responsible for calling
stopAnimation. If that code throws any exceptions, we want to make sure the other
animations are still stopped.
* platform/mac/ScrollAnimatorMac.mm:
(-[WebScrollbarPartAnimation scrollAnimatorDestroyed]):
(-[WebScrollbarPainterDelegate scrollAnimatorDestroyed]):
(WebCore::ScrollAnimatorMac::~ScrollAnimatorMac):

Only send AppKit these notifications for active pages. I originally made these
assertions, and I found that they were hit a surprising number of times. If we
only send notifications for active pages, then we should greatly reduce and
possibly eliminate our chances of hitting this crash.
(WebCore::ScrollAnimatorMac::notifyPositionChanged):
(WebCore::ScrollAnimatorMac::contentAreaWillPaint):
(WebCore::ScrollAnimatorMac::mouseEnteredContentArea):
(WebCore::ScrollAnimatorMac::mouseExitedContentArea):
(WebCore::ScrollAnimatorMac::mouseMovedInContentArea):
(WebCore::ScrollAnimatorMac::willStartLiveResize):
(WebCore::ScrollAnimatorMac::contentsResized):
(WebCore::ScrollAnimatorMac::willEndLiveResize):
(WebCore::ScrollAnimatorMac::contentAreaDidShow):
(WebCore::ScrollAnimatorMac::contentAreaDidHide):
(WebCore::ScrollAnimatorMac::didBeginScrollGesture):
(WebCore::ScrollAnimatorMac::didEndScrollGesture):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd put to the MethodTable
mhahnenberg@apple.com [Sat, 22 Oct 2011 00:48:40 +0000 (00:48 +0000)]
Add put to the MethodTable
https://bugs.webkit.org/show_bug.cgi?id=70439

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* runtime/ClassInfo.h: Added put and putByIndex to the MethodTable.
* runtime/JSFunction.h: Changed access modifier for put to protected since some
subclasses of JSFunction need to reference it in their MethodTables.

Source/WebCore:

No new tests.

* WebCore.exp.in:
* bindings/js/JSDOMWindowCustom.cpp: Added static put since it was overlooked in
previous patches.
(WebCore::JSDOMWindow::putVirtual):
(WebCore::JSDOMWindow::put):
* bindings/js/JSDOMWindowShell.cpp: Ditto.
(WebCore::JSDOMWindowShell::putVirtual):
(WebCore::JSDOMWindowShell::put):
* bindings/js/JSDOMWindowShell.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98177 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSource/WebCore: https://bugs.webkit.org/show_bug.cgi?id=70580
dslomov@google.com [Sat, 22 Oct 2011 00:38:14 +0000 (00:38 +0000)]
Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=70580
[Chromium] Implement MessagePort transfer in chromium port of webkit.

Reviewed by David Levin.

* bindings/v8/SerializedScriptValue.cpp:
(WebCore::V8ObjectMap::Writer::writeTransferredMessagePort):
(WebCore::V8ObjectMap::Serializer::Serializer):
(WebCore::V8ObjectMap::Serializer::doSerialize):
(WebCore::V8ObjectMap::Reader::read):
(WebCore::V8ObjectMap::Deserializer::Deserializer):
(WebCore::V8ObjectMap::Deserializer::tryGetTransferredMessagePort):
(WebCore::SerializedScriptValue::SerializedScriptValue):
(WebCore::SerializedScriptValue::deserialize):

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=70580
[Chromium] Implement MessagePort transfer in chromium port of webkit.
Results for JSC include some FAILs - this will be addressed when JSC
implements message port transfers as well (https://bugs.webkit.org/show_bug.cgi?id=70658)

Reviewed by David Levin.

* fast/dom/Window/window-postmessage-args-expected.txt:
* fast/dom/Window/window-postmessage-args.html:
* fast/events/message-port-multi-expected.txt:
* fast/events/resources/message-port-multi.js:
(testTransfers.channel0.port2.onmessage):
(testTransfers):
(channel.port2.onmessage):
* platform/chromium-win/fast/events/message-port-multi-expected.txt:
* platform/chromium/fast/dom/Window/window-postmessage-args-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98175 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agor97693 caused 42 failures on the chromium mac bots
ojan@chromium.org [Sat, 22 Oct 2011 00:10:58 +0000 (00:10 +0000)]
r97693 caused 42 failures on the chromium mac bots
https://bugs.webkit.org/show_bug.cgi?id=70300

Can't test this until https://bugs.webkit.org/show_bug.cgi?id=70660
is fixed. The fix for that bug will test this codepath as well though.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeBlockPreferredLogicalWidths):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98173 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSetting form.enctype reflected attribute behaves strangely.
commit-queue@webkit.org [Sat, 22 Oct 2011 00:04:18 +0000 (00:04 +0000)]
Setting form.enctype reflected attribute behaves strangely.
https://bugs.webkit.org/show_bug.cgi?id=44879

Patch by Vineet Chaudhary <vineet.chaudhary@motorola.com> on 2011-10-21
Reviewed by Darin Adler.

Source/WebCore:

The spec says form.enctype should be application/x-www-form-urlencoded,
So as "text", "plain", "multipart" or "form-data" these are not a valid value so must be ignored.

* loader/FormSubmission.cpp:
(WebCore::FormSubmission::Attributes::parseEncodingType):

LayoutTests:

Leading/trailing white-spaces should not be allowed while specifying attribute value.
Added more test coverage for form.enctype attribute.

* fast/forms/encoding-test.html:
* fast/forms/enctype-attribute-expected.txt:
* fast/forms/enctype-attribute.html: Corrected test case as per new behavior.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98172 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoEnsure periodic flushing of canvas drawing context
mdelaney@apple.com [Sat, 22 Oct 2011 00:01:58 +0000 (00:01 +0000)]
Ensure periodic flushing of canvas drawing context
https://bugs.webkit.org/show_bug.cgi?id=70646

Reviewed by Simon Fraser.

No new tests. No current way to track tests that cause hangs or
non-deterministic drops in performance.

* platform/graphics/cg/ImageBufferDataCG.h: Adds a timestamp of last tracked flush.
* platform/graphics/cg/ImageBufferCG.cpp: Ensures periodic flushes on the drawing context.
(WebCore::ImageBuffer::ImageBuffer):
(WebCore::ImageBuffer::context): Flushes context if we're beyond flush interval.
(WebCore::ImageBuffer::copyNativeImage): Updates last flush timestamp.
(WebCore::ImageBuffer::getUnmultipliedImageData): Updates last flush timestamp.
(WebCore::ImageBuffer::getPremultipliedImageData): Updates last flush timestamp.
(WebCore::ImageBuffer::putUnmultipliedImageData): Updates last flush timestamp.
(WebCore::ImageBuffer::putPremultipliedImageData): Updates last flush timestamp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoGardening update.
jchaffraix@webkit.org [Fri, 21 Oct 2011 23:53:56 +0000 (23:53 +0000)]
Gardening update.

* platform/chromium/test_expectations.txt: We are randomly hitting
a known ASSERT on this test case.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98169 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBencher script doesn't measure GC times accurately
fpizlo@apple.com [Fri, 21 Oct 2011 23:20:38 +0000 (23:20 +0000)]
Bencher script doesn't measure GC times accurately
https://bugs.webkit.org/show_bug.cgi?id=70588

Reviewed by Geoff Garen.

Added two new options which allow different ways of measuring GC times:

--measure-gc, which omits calls to gc() between benchmark invocations.
This option takes an optional argument, which is the name of the
VM in which to enable this feature. This allows comparing a single VM
against itself, with and without GC.

--rerun <N>, which causes each sample measurement to include N invocations
which do not have gc() calls between them. The default is N = 1, which
results in the same behavior as before.

You can use either --measure-gc or --rerun <N> for N > 1 (preferably
N >= 3) to get more of a contribution from GC to the measured times.
--rerun results in tighter confidence intervals than --measure-gc, since
it amortizes GC effects in each sample, while with --measure-gc some
samples will see GC and some won't leading to a higher standard devation
and thus requiring more samples to reduce confidence intervals to
managable levels.

* Scripts/bencher:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98167 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoStyle guide should mention the preference of index over iterator
rniwa@webkit.org [Fri, 21 Oct 2011 23:18:57 +0000 (23:18 +0000)]
Style guide should mention the preference of index over iterator
https://bugs.webkit.org/show_bug.cgi?id=70285

Reviewed by Darin Adler.

Per discussion on https://lists.webkit.org/pipermail/webkit-dev/2011-October/018274.html,
we prefer index over iterators.

* coding/coding-style.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98166 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoIntroduce Event::hasInterface to make uses of interfaceName more readable
abarth@webkit.org [Fri, 21 Oct 2011 22:56:39 +0000 (22:56 +0000)]
Introduce Event::hasInterface to make uses of interfaceName more readable
https://bugs.webkit.org/show_bug.cgi?id=70652

Reviewed by Eric Seidel.

Source/WebCore:

Eric felt that this approach would be more readable because it requires
less syntax at each callsite.

* bindings/js/JSErrorHandler.cpp:
(WebCore::JSErrorHandler::handleEvent):
* bindings/objc/DOMEvents.mm:
(kitClass):
* bindings/v8/V8WindowErrorHandler.cpp:
(WebCore::V8WindowErrorHandler::callListenerFunction):
* bindings/v8/V8WorkerContextErrorHandler.cpp:
(WebCore::V8WorkerContextErrorHandler::callListenerFunction):
* dom/Event.cpp:
(WebCore::Event::hasInterface):
* dom/Event.h:
* dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::determineDispatchBehavior):
* dom/Node.cpp:
(WebCore::Node::defaultEventHandler):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::defaultEventHandler):
* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::defaultEventHandler):
* html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::forwardEvent):
(WebCore::TextFieldInputType::shouldSubmitImplicitly):
* inspector/InspectorDOMStorageResource.cpp:
(WebCore::InspectorDOMStorageResource::handleEvent):

Source/WebKit/chromium:

Update call sites to the new interface.

* src/WebDOMEvent.cpp:
(WebKit::WebDOMEvent::isMutationEvent):
(WebKit::WebDOMEvent::isTextEvent):
(WebKit::WebDOMEvent::isCompositionEvent):
(WebKit::WebDOMEvent::isMessageEvent):
(WebKit::WebDOMEvent::isWheelEvent):
(WebKit::WebDOMEvent::isOverflowEvent):
(WebKit::WebDOMEvent::isPageTransitionEvent):
(WebKit::WebDOMEvent::isPopStateEvent):
(WebKit::WebDOMEvent::isProgressEvent):
(WebKit::WebDOMEvent::isXMLHttpRequestProgressEvent):
(WebKit::WebDOMEvent::isWebKitAnimationEvent):
(WebKit::WebDOMEvent::isWebKitTransitionEvent):
(WebKit::WebDOMEvent::isBeforeLoadEvent):
* src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::handleEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98164 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[MutationObservers] Implement basic subtree observation
adamk@chromium.org [Fri, 21 Oct 2011 22:52:29 +0000 (22:52 +0000)]
[MutationObservers] Implement basic subtree observation
https://bugs.webkit.org/show_bug.cgi?id=70436

Reviewed by Ryosuke Niwa.

Source/WebCore:

Note that this patch only implements "basic" subtree semantics,
not the fully robust semantics described in
http://lists.w3.org/Archives/Public/public-webapps/2011JulSep/1622.html.
Most importantly, this change does not handle the case where mutations
occur in a temporarily detached subtree.

The plan is to implement those semantics in a followup to avoid
blocking other parts of the MutationObserver spec that rely on
the existence of subtree observation but not its specific
implementation.

Test: fast/mutation/observe-subtree.html

* dom/Node.cpp:
(WebCore::addMatchingObservers): Static helper method for registeredMutationObserversOfType().
(WebCore::Node::registeredMutationObserversOfType): Walk up the tree looking for observers.
* dom/NodeRareData.h:
(WebCore::MutationObserverEntry::hasAllOptions): A stricter, renamed from matches().

LayoutTests:

* fast/mutation/observe-subtree-expected.txt: Added.
* fast/mutation/observe-subtree.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98163 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Remote debugging needs QWebInspector to work
commit-queue@webkit.org [Fri, 21 Oct 2011 22:33:35 +0000 (22:33 +0000)]
[Qt] Remote debugging needs QWebInspector to work
https://bugs.webkit.org/show_bug.cgi?id=70651

Patch by Luiz Agostini <luiz.agostini@palm.com> on 2011-10-21
Reviewed by Kenneth Rohde Christiansen.

Removing QWebInspector dependency from remote inspector.

* Api/qwebinspector.cpp:
* Api/qwebinspector_p.h:
(QWebInspectorPrivate::QWebInspectorPrivate):
* WebCoreSupport/InspectorClientQt.cpp:
(WebCore::InspectorClientQt::InspectorClientQt):
(WebCore::InspectorClientQt::openInspectorFrontend):
(WebCore::InspectorClientQt::attachAndReplaceRemoteFrontend):
(WebCore::InspectorClientQt::detachRemoteFrontend):
(WebCore::InspectorClientQt::sendMessageToFrontend):
* WebCoreSupport/InspectorClientQt.h:
* WebCoreSupport/InspectorServerQt.cpp:
(WebCore::InspectorServerRequestHandlerQt::tcpReadyRead):
* WebCoreSupport/InspectorServerQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98162 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMark member variables of WebKit2 API @private
weinig@apple.com [Fri, 21 Oct 2011 22:30:29 +0000 (22:30 +0000)]
Mark member variables of WebKit2 API @private
https://bugs.webkit.org/show_bug.cgi?id=70655

Reviewed by Simon Fraser.

* UIProcess/API/mac/WKBrowsingContextController.h:
* UIProcess/API/mac/WKView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98161 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRename WKProcessCluster to WKProcessGroup
weinig@apple.com [Fri, 21 Oct 2011 22:26:24 +0000 (22:26 +0000)]
Rename WKProcessCluster to WKProcessGroup
https://bugs.webkit.org/show_bug.cgi?id=70654

Reviewed by Simon Fraser.

* UIProcess/API/mac/WKProcessCluster.h: Removed.
* UIProcess/API/mac/WKProcessCluster.mm: Removed.
* UIProcess/API/mac/WKProcessClusterInternal.h: Removed.
* UIProcess/API/mac/WKProcessGroup.h: Copied from Source/WebKit2/UIProcess/API/mac/WKProcessCluster.h.
* UIProcess/API/mac/WKProcessGroup.mm: Copied from Source/WebKit2/UIProcess/API/mac/WKProcessCluster.mm.
(-[WKProcessGroup initWithInjectedBundleURL:]):
* UIProcess/API/mac/WKProcessGroupInternal.h: Copied from Source/WebKit2/UIProcess/API/mac/WKProcessClusterInternal.h.
* UIProcess/API/mac/WKView.h:
* UIProcess/API/mac/WKView.mm:
(-[WKView initWithFrame:processCluster:]):
* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove ability to create a WKView without a WKContextRef and WKPageGroupRef
weinig@apple.com [Fri, 21 Oct 2011 22:09:22 +0000 (22:09 +0000)]
Remove ability to create a WKView without a WKContextRef and WKPageGroupRef
https://bugs.webkit.org/show_bug.cgi?id=70653

Reviewed by Simon Fraser.

Source/WebKit2:

Requiring a context and pagegroup removes the concept of global contexts,
which is something that is both confusing, and makes Objective-C wrapping
harder.

* UIProcess/API/mac/WKView.mm:
(-[WKView initWithFrame:processCluster:]):
* UIProcess/API/mac/WKViewPrivate.h:
Remove init methods that didn't take both a context and a pagegroup.

Tools:

* MiniBrowser/mac/AppDelegate.h:
* MiniBrowser/mac/AppDelegate.m:
(-[BrowserAppDelegate init]):
(-[BrowserAppDelegate newWindow:]):
(-[BrowserAppDelegate openPanelDidEnd:returnCode:contextInfo:]):
* MiniBrowser/mac/BrowserWindowController.h:
* MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController initWithContext:pageGroup:]):
(-[BrowserWindowController windowWillClose:]):
(createNewPage):
(-[BrowserWindowController awakeFromNib]):
* TestWebKitAPI/mac/WebKitAgnosticTest.mm:
(TestWebKitAPI::WebKitAgnosticTest::runWebKit2Test):
Update testing code to pass a PageGroup as necessary.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98159 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Wrong type conversion in InspectorServerQt.cpp
commit-queue@webkit.org [Fri, 21 Oct 2011 22:01:54 +0000 (22:01 +0000)]
[Qt] Wrong type conversion in InspectorServerQt.cpp
https://bugs.webkit.org/show_bug.cgi?id=70639

Patch by Luiz Agostini <luiz.agostini@palm.com> on 2011-10-21
Reviewed by Noam Rosenthal.

Wrong type conversion causes WebSocket handshake failures for the remote inspector.

* WebCoreSupport/InspectorServerQt.cpp:
(WebCore::parseWebSocketChallengeNumber):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agowebkitpy: Teach NRWT about the EFL port
commit-queue@webkit.org [Fri, 21 Oct 2011 21:59:58 +0000 (21:59 +0000)]
webkitpy: Teach NRWT about the EFL port
https://bugs.webkit.org/show_bug.cgi?id=70637

Allows using ``efl'' as a platform when executing NRWT.

Patch by Leandro Pereira <leandro@profusion.mobi> on 2011-10-21
Reviewed by Eric Seidel.

* Scripts/webkitpy/layout_tests/port/efl.py: Added.
* Scripts/webkitpy/layout_tests/port/efl_unittest.py: Added.
* Scripts/webkitpy/layout_tests/port/factory.py: Adjust factory to make EflPort objects
when using PortFactory.get(port_name='efl').

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoIndexedDB: objectStore.transaction property should be readonly
commit-queue@webkit.org [Fri, 21 Oct 2011 21:30:11 +0000 (21:30 +0000)]
IndexedDB: objectStore.transaction property should be readonly
https://bugs.webkit.org/show_bug.cgi?id=62395

Patch by Joshua Bell <jsbell@chromium.org> on 2011-10-21
Reviewed by Tony Chang.

Source/WebCore:

Implement the IDBObjectStore.transaction property defined by the spec.

Test: storage/indexeddb/readonly-properties.html

* storage/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::transaction):
* storage/IDBObjectStore.h:
* storage/IDBObjectStore.idl:

LayoutTests:

* storage/indexeddb/objectstore-basics-expected.txt:
* storage/indexeddb/objectstore-basics.html:
* storage/indexeddb/readonly-properties-expected.txt: Added.
* storage/indexeddb/readonly-properties.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98154 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago [WK2] Crash after printing a view with accelerated compositing content
ap@apple.com [Fri, 21 Oct 2011 21:26:15 +0000 (21:26 +0000)]
    [WK2] Crash after printing a view with accelerated compositing content
        https://bugs.webkit.org/show_bug.cgi?id=70643
        <rdar://problem/9479083>

        Reviewed by Darin Adler.

        * UIProcess/API/mac/WKPrintingView.mm: (-[WKPrintingView _delayedResumeAutodisplayTimerFired]):
        We cannot rely on -[WKView drawRect:] calling endPrinting() for us. That call to endPrinting()
        is still necessary to paint e.g. when resizing a window while a print dialog is present.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98153 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoEvent.h has too many virtual isMumbleEvent() functions
abarth@webkit.org [Fri, 21 Oct 2011 21:07:12 +0000 (21:07 +0000)]
Event.h has too many virtual isMumbleEvent() functions
https://bugs.webkit.org/show_bug.cgi?id=70636

Reviewed by Dimitri Glazkov.

Source/WebCore:

We should use the new interfaceName() way of doing run-time type inference.

* bindings/js/JSErrorHandler.cpp:
(WebCore::JSErrorHandler::handleEvent):
* bindings/js/JSEventCustom.cpp:
(WebCore::JSEvent::clipboardData):
* bindings/objc/DOMEvents.mm:
(kitClass):
* bindings/v8/V8WindowErrorHandler.cpp:
(WebCore::V8WindowErrorHandler::callListenerFunction):
* bindings/v8/V8WorkerContextErrorHandler.cpp:
(WebCore::V8WorkerContextErrorHandler::callListenerFunction):
* bindings/v8/custom/V8EventCustom.cpp:
(WebCore::V8Event::clipboardDataAccessorGetter):
* dom/BeforeLoadEvent.h:
(WebCore::BeforeLoadEvent::interfaceName):
* dom/BeforeTextInsertedEvent.h:
* dom/ClipboardEvent.cpp:
* dom/ClipboardEvent.h:
* dom/CompositionEvent.cpp:
* dom/CompositionEvent.h:
* dom/ErrorEvent.cpp:
* dom/ErrorEvent.h:
* dom/Event.cpp:
(WebCore::Event::storesResultAsString):
(WebCore::Event::storeResult):
(WebCore::Event::clipboardData):
* dom/Event.h:
* dom/Event.idl:
    - Remove this interface from the CPP bindings because this function
      no longer exists.  It's unclear to me how strong our API
      commitments are in the CPP bindings.
* dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::determineDispatchBehavior):
* dom/MessageEvent.cpp:
* dom/MessageEvent.h:
* dom/MutationEvent.cpp:
* dom/MutationEvent.h:
* dom/Node.cpp:
(WebCore::Node::defaultEventHandler):
* dom/OverflowEvent.cpp:
* dom/OverflowEvent.h:
* dom/PageTransitionEvent.h:
* dom/ProgressEvent.h:
* dom/TextEvent.cpp:
* dom/TextEvent.h:
* dom/WheelEvent.cpp:
* dom/WheelEvent.h:
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::defaultEventHandler):
* html/HTMLTextAreaElement.cpp:
(WebCore::HTMLTextAreaElement::defaultEventHandler):
* html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::forwardEvent):
(WebCore::TextFieldInputType::shouldSubmitImplicitly):
* html/shadow/TextControlInnerElements.cpp:
(WebCore::TextControlInnerTextElement::defaultEventHandler):
* svg/SVGZoomEvent.cpp:
* svg/SVGZoomEvent.h:

Source/WebKit/chromium:

Update these callsites to the new API.

* src/WebDOMEvent.cpp:
(WebKit::WebDOMEvent::isKeyboardEvent):
(WebKit::WebDOMEvent::isMutationEvent):
(WebKit::WebDOMEvent::isTextEvent):
(WebKit::WebDOMEvent::isCompositionEvent):
(WebKit::WebDOMEvent::isClipboardEvent):
(WebKit::WebDOMEvent::isMessageEvent):
(WebKit::WebDOMEvent::isWheelEvent):
(WebKit::WebDOMEvent::isBeforeTextInsertedEvent):
(WebKit::WebDOMEvent::isOverflowEvent):
(WebKit::WebDOMEvent::isPageTransitionEvent):
(WebKit::WebDOMEvent::isProgressEvent):
(WebKit::WebDOMEvent::isBeforeLoadEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98146 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFlush denormals in Biquad, ZeroPole, and DynamicsCompressor.
commit-queue@webkit.org [Fri, 21 Oct 2011 21:04:43 +0000 (21:04 +0000)]
Flush denormals in Biquad, ZeroPole, and DynamicsCompressor.

We only flush when saving the state variables instead of in the
loops so that we don't impact performance too much when there are
no denormals.  This will at least not propagate the denormals any
further within the class.

https://bugs.webkit.org/show_bug.cgi?id=70626

Patch by Raymond Toy <rtoy@google.com> on 2011-10-21
Reviewed by Kenneth Russell.

* platform/audio/Biquad.cpp:
(WebCore::Biquad::process):
Flush denormals when storing the filter state back in to class
filter state.
* platform/audio/DynamicsCompressorKernel.cpp:
(WebCore::DynamicsCompressorKernel::process):
Ditto.
* platform/audio/ZeroPole.cpp:
(WebCore::ZeroPole::process):
Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[WK2] WebFrameLoaderClient::shouldFallback() should use a port-specific implementation
commit-queue@webkit.org [Fri, 21 Oct 2011 20:52:11 +0000 (20:52 +0000)]
[WK2] WebFrameLoaderClient::shouldFallback() should use a port-specific implementation
https://bugs.webkit.org/show_bug.cgi?id=70055

Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2011-10-21
Reviewed by Luiz Agostini.

In QtWebKit 1, our FrameLoaderClient::shouldFallback was checking for InterruptedForPolicyChange
error. In WebKit2, we are relying on the common implementation for WebFrameLoaderClient::shouldFallback
which doesn't check for the same error. Here we add this check only for Qt.

* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::shouldFallBack):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed gardening, yet another flaky crashing test.
jchaffraix@webkit.org [Fri, 21 Oct 2011 20:51:47 +0000 (20:51 +0000)]
Unreviewed gardening, yet another flaky crashing test.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoGardening rebaselines.
jchaffraix@webkit.org [Fri, 21 Oct 2011 20:37:59 +0000 (20:37 +0000)]
Gardening rebaselines.

* platform/chromium-linux-x86/fast/multicol/vertical-lr: Removed.
* platform/chromium-linux-x86/fast/multicol/vertical-lr/rules-with-border-before-expected.png: Removed.
* platform/chromium-linux-x86/fast/multicol/vertical-rl: Removed.
* platform/chromium-linux-x86/fast/multicol/vertical-rl/rules-with-border-before-expected.png: Removed.
* platform/chromium-linux/fast/multicol/vertical-lr/rules-with-border-before-expected.png: Removed.
* platform/chromium-linux/fast/multicol/vertical-rl/rules-with-border-before-expected.png: Removed.
* platform/chromium-win/fast/multicol/vertical-lr/rules-with-border-before-expected.png: Added.
* platform/chromium-win/fast/multicol/vertical-rl/rules-with-border-before-expected.png: Added.
* platform/chromium/fast/multicol: Added.
* platform/chromium/fast/multicol/vertical-lr: Added.
* platform/chromium/fast/multicol/vertical-lr/rules-with-border-before-expected.png: Added.
* platform/chromium/fast/multicol/vertical-rl: Added.
* platform/chromium/fast/multicol/vertical-rl/rules-with-border-before-expected.png: Added.
* platform/chromium/test_expectations.txt:
The dumps are weird on SL so we don't land them but mark the test as PASS TEXT.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed gardening.
jchaffraix@webkit.org [Fri, 21 Oct 2011 20:02:49 +0000 (20:02 +0000)]
Unreviewed gardening.

* platform/chromium/test_expectations.txt: This test is flaky and crashing
sometimes on snow-leopard.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98133 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix r98125 by having duplicate entries for Win Debug.
jchaffraix@webkit.org [Fri, 21 Oct 2011 19:56:23 +0000 (19:56 +0000)]
Fix r98125 by having duplicate entries for Win Debug.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed gardening.
jchaffraix@webkit.org [Fri, 21 Oct 2011 19:43:18 +0000 (19:43 +0000)]
Unreviewed gardening.

* platform/chromium/test_expectations.txt: The test is now also failing on debug on XP.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98125 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: Advanced search results should be cleared on navigation.
vsevik@chromium.org [Fri, 21 Oct 2011 19:38:12 +0000 (19:38 +0000)]
Web Inspector: Advanced search results should be cleared on navigation.
https://bugs.webkit.org/show_bug.cgi?id=70627

Reviewed by Pavel Feldman.

* inspector/front-end/AdvancedSearchController.js:
(WebInspector.AdvancedSearchController):
(WebInspector.AdvancedSearchController.prototype._frameNavigated):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd finalizer to JSObject
mhahnenberg@apple.com [Fri, 21 Oct 2011 19:36:46 +0000 (19:36 +0000)]
Add finalizer to JSObject
https://bugs.webkit.org/show_bug.cgi?id=70336

Reviewed by Darin Adler.

* heap/MarkedBlock.cpp:
(JSC::MarkedBlock::callDestructor): Skip the call to the destructor
if we're a JSFinalObject, since the finalizer takes care of things.
* runtime/JSCell.h:
(JSC::JSCell::~JSCell): Remove the GC validation due to a conflict with
future changes and the fact that we no longer always call the destructor, making
the information provided less useful.
* runtime/JSObject.cpp:
(JSC::JSObject::finalize): Add finalizer for JSObject.
(JSC::JSObject::allocatePropertyStorage): The first time we need to allocate out-of-line
property storage, we add a finalizer to ourself.
* runtime/JSObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed gardening.
jchaffraix@webkit.org [Fri, 21 Oct 2011 19:33:56 +0000 (19:33 +0000)]
Unreviewed gardening.

* platform/chromium/test_expectations.txt: Mark call-base-resolution.html as crashing on snow-leopard.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[MutationObservers] Implement WebKitMutationObserver.observe for childList changes
adamk@chromium.org [Fri, 21 Oct 2011 19:19:56 +0000 (19:19 +0000)]
[MutationObservers] Implement WebKitMutationObserver.observe for childList changes
https://bugs.webkit.org/show_bug.cgi?id=68955

Patch by Rafael Weinstein <rafaelw@chromium.org> on 2011-10-21
Reviewed by Ryosuke Niwa.

Source/WebCore:

This patch adds a ChildListMutationScope object which manages the coalescing of
multiple child removals and additions within DOM operations into single childList
mutation records.

Note that this patch doesn't cover all the cases which can be coalesced (it only
covers ContainerNode.*, and Node.innerHTML/innerText). A separate bug,
https://bugs.webkit.org/show_bug.cgi?id=70385, has been opened to track the
remaining cases.

Test: fast/mutation/observe-childList.html

* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/ChildListMutationScope.cpp: Added.
(WebCore::ChildListAccumulation::ChildListAccumulation::ChildListAccumulation):
(WebCore::ChildListAccumulation::ChildListAccumulation::~ChildListAccumulation):
(WebCore::ChildListAccumulation::ChildListAccumulation::childAdded):
(WebCore::ChildListAccumulation::ChildListAccumulation::willRemoveChild):
(WebCore::ChildListAccumulation::ChildListAccumulation::dispatch):
(WebCore::ChildListAccumulation::ChildListAccumulation::clear):
(WebCore::ChildListAccumulation::ChildListAccumulation::isEmpty):
(WebCore::ChildListAccumulation::ChildListAccumulator::ChildListAccumulator):
(WebCore::ChildListAccumulation::ChildListAccumulator::~ChildListAccumulator):
(WebCore::ChildListAccumulation::ChildListAccumulator::initialize):
(WebCore::ChildListAccumulation::ChildListAccumulator::instance):
(WebCore::ChildListAccumulation::ChildListAccumulator::childAdded):
(WebCore::ChildListAccumulation::ChildListAccumulator::willRemoveChild):
(WebCore::ChildListAccumulation::ChildListAccumulator::incrementScopingLevel):
(WebCore::ChildListAccumulation::ChildListAccumulator::decrementScopingLevel):
(WebCore::ChildListMutationScope::ChildListMutationScope):
(WebCore::ChildListMutationScope::~ChildListMutationScope):
(WebCore::ChildListMutationScope::childAdded):
(WebCore::ChildListMutationScope::willRemoveChild):
* dom/ChildListMutationScope.h: Added.
* dom/ContainerNode.cpp:
(WebCore::ContainerNode::insertBefore):
(WebCore::ContainerNode::replaceChild):
(WebCore::willRemoveChildren):
(WebCore::dispatchChildInsertionEvents):
(WebCore::dispatchChildRemovalEvents):
* dom/Element.cpp:
(WebCore::enqueueAttributesMutationRecord):
* dom/Node.cpp:
(WebCore::Node::setTextContent):
(WebCore::Node::registeredMutationObserversOfType):
* dom/WebKitMutationObserver.cpp:
(WebCore::WebKitMutationObserver::disconnect):
* html/HTMLElement.cpp:
(WebCore::replaceChildrenWithFragment):
(WebCore::replaceChildrenWithText):

LayoutTests:

* fast/mutation/observe-attributes-expected.txt:
* fast/mutation/observe-attributes.html:
* fast/mutation/observe-childList-expected.txt: Added.
* fast/mutation/observe-childList.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed gardening: rebaseline 2 tests (small color difference).
jchaffraix@webkit.org [Fri, 21 Oct 2011 18:43:43 +0000 (18:43 +0000)]
Unreviewed gardening: rebaseline 2 tests (small color difference).

* platform/chromium-linux-x86/fast/multicol: Added.
* platform/chromium-linux-x86/fast/multicol/vertical-lr: Added.
* platform/chromium-linux-x86/fast/multicol/vertical-lr/rules-with-border-before-expected.png: Added.
* platform/chromium-linux-x86/fast/multicol/vertical-rl: Added.
* platform/chromium-linux-x86/fast/multicol/vertical-rl/rules-with-border-before-expected.png: Added.
* platform/chromium-linux/fast/multicol/vertical-lr/rules-with-border-before-expected.png: Added.
* platform/chromium-linux/fast/multicol/vertical-rl/rules-with-border-before-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed gardening: second chunk of baselines for Chromium-Skia
caryclark@google.com [Fri, 21 Oct 2011 18:31:56 +0000 (18:31 +0000)]
Unreviewed gardening: second chunk of baselines for Chromium-Skia
on Leopard.

[Omitting 706 of 712 files for brevity.]

* platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-57-d-expected.png: Added.
* platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-58-d-expected.png: Added.
* platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-59-d-expected.png: Added.
...
* platform/chromium-mac-leopard/fast/block/positioning/absolute-in-inline-rtl-expected.png: Added.
* platform/chromium-mac-leopard/fast/block/positioning/absolute-in-inline-short-ltr-expected.png: Added.
* platform/chromium-mac-leopard/fast/block/positioning/absolute-in-inline-short-rtl-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFocus rings are too thin in HiDPI in WebKit2
jeffm@apple.com [Fri, 21 Oct 2011 18:20:58 +0000 (18:20 +0000)]
Focus rings are too thin in HiDPI in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=70396

Rename wkSetPatternBaseCTM() to wkSetBaseCTM().

Reviewed by Beth Dakin.

* win/include/WebKitSystemInterface/WebKitSystemInterface.h:
* win/lib/WebKitSystemInterface.lib:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r98079.
commit-queue@webkit.org [Fri, 21 Oct 2011 18:13:04 +0000 (18:13 +0000)]
Unreviewed, rolling out r98079.
http://trac.webkit.org/changeset/98079
https://bugs.webkit.org/show_bug.cgi?id=70624

The extensions tests enabled are failing on the Chromium Win
Dbg bot (Requested by jchaffraix on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-21

Source/WebCore:

* inspector/front-end/ExtensionAPI.js:
(buildExtensionAPIInjectedScript):

LayoutTests:

* http/tests/inspector/extensions-headers.html:
* http/tests/inspector/resources/extension-main.js:
():
* inspector/extensions/extensions-audits.html:
* inspector/extensions/extensions-console.html:
* inspector/extensions/extensions-resources.html:
* platform/chromium/inspector/extensions/extensions-api-expected.txt: Removed.
* platform/chromium/inspector/extensions/extensions-eval-expected.txt: Removed.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoColumn rules positioned incorrectly in vertical-rl block with horizontal border or...
mitz@apple.com [Fri, 21 Oct 2011 18:03:16 +0000 (18:03 +0000)]
Column rules positioned incorrectly in vertical-rl block with horizontal border or padding
https://bugs.webkit.org/show_bug.cgi?id=70622

Reviewed by Beth Dakin.

Source/WebCore:

Tests: fast/multicol/vertical-lr/rules-with-border-before.html
       fast/multicol/vertical-rl/rules-with-border-before.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintColumnRules): Changed to use the physical left border and padding for the
left edge of the horizontal column rule.

LayoutTests:

* fast/multicol/vertical-lr/rules-with-border-before-expected.png: Added.
* fast/multicol/vertical-lr/rules-with-border-before-expected.txt: Added.
* fast/multicol/vertical-lr/rules-with-border-before.html: Added.
* fast/multicol/vertical-rl/rules-with-border-before-expected.png: Added.
* fast/multicol/vertical-rl/rules-with-border-before-expected.txt: Added.
* fast/multicol/vertical-rl/rules-with-border-before.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] WebKit build does not respect QMAKE_MAC_SDK variable.
commit-queue@webkit.org [Fri, 21 Oct 2011 17:55:50 +0000 (17:55 +0000)]
[Qt] WebKit build does not respect QMAKE_MAC_SDK variable.
https://bugs.webkit.org/show_bug.cgi?id=70596

Instead of only relying on DARWIN_MAJOR_VERSION we also
check QMAKE_MAC_SDK. In case QMAKE_MAC_SDK is not defined
we are still falling back to DARWIN_MAJOR_VERSION.

Patch by Andy Shaw <andy.shaw@digia.com>

Patch by Zeno Albisser <zeno.albisser@nokia.com> on 2011-10-21
Reviewed by Noam Rosenthal.

* QtWebKit.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFlash of white when loading a page after a web process crash
andersca@apple.com [Fri, 21 Oct 2011 17:46:34 +0000 (17:46 +0000)]
Flash of white when loading a page after a web process crash
https://bugs.webkit.org/show_bug.cgi?id=70615
<rdar://problem/10306906>

Reviewed by Darin Adler.

* UIProcess/API/mac/WKView.mm:
(-[WKView _processDidCrash]):
(-[WKView _didRelaunchProcess]):
Remove calls to setNeedsDisplay here.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::processDidCrash):
Call setNeedsDisplay, but only if calling out to the loader client didn't relaunch the web process.

* WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::setPaintingEnabled):
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::DrawingAreaImpl):
(WebKit::DrawingAreaImpl::setNeedsDisplay):
(WebKit::DrawingAreaImpl::scroll):
(WebKit::DrawingAreaImpl::setPaintingEnabled):
* WebProcess/WebPage/DrawingAreaImpl.h:
Add a way to disable painting completely for a drawing area.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
Disable painting while setting up the web page, otherwise we'll get paint requests when we set the
active state of the web page.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix Windows build.
simon.fraser@apple.com [Fri, 21 Oct 2011 17:41:38 +0000 (17:41 +0000)]
Fix Windows build.

* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::hasAnyAdditionalCompositedLayers):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agore-enable layout tests against chromium-mac-snowleopard (Skia) baselines
commit-queue@webkit.org [Fri, 21 Oct 2011 17:39:37 +0000 (17:39 +0000)]
re-enable layout tests against chromium-mac-snowleopard (Skia) baselines
https://bugs.webkit.org/show_bug.cgi?id=70612

Patch by Elliot Poger <epoger@google.com> on 2011-10-21
Reviewed by Adam Barth.

* platform/chromium-mac-snowleopard/fast/dom/call-a-constructor-as-a-function-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/dom/error-to-string-stack-overflow-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/parser/entity-end-script-tag-expected.txt: Removed.
* platform/chromium-mac/fast/multicol/flipped-blocks-border-after-expected.png: Added.
* platform/chromium-mac/fast/multicol/flipped-blocks-border-after-expected.txt: Added.
* platform/chromium-mac/fast/multicol/vertical-rl/rule-style-expected.png: Added.
* platform/chromium-mac/fast/repaint/continuation-after-outline-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[EFL] Change efl style local variables with WebKit coding Style.
gyuyoung.kim@samsung.com [Fri, 21 Oct 2011 17:32:39 +0000 (17:32 +0000)]
[EFL] Change efl style local variables with WebKit coding Style.
https://bugs.webkit.org/show_bug.cgi?id=69988

Reviewed by Antonio Gomes.

In common with Bug 69073, this is a third step in order to be more compliant with WebKit coding style.
We have used one-letter| two-letter local variable according to efl style. However, it's
more difficult for other reviewers to review EFL patches. So, this patch changes efl style
local variable with meaningful one.

- Use *menu* instead of *o* in comment of ewk_contextmenu.cpp.
- Use *list* instead of *l* local variable
- Use *ewkPolicy* instead of *ewk_policy* in ewk_cookies.cpp
- Use *smartData* instead of *sd* local variable for Ewk_XXXX_Smart_Data struct.
- Use *width*, *height* instead of *w*, *h* local variables.
- Use *scrollX*, *scrollY*, *scrollWidth*, *scrollHeight*, *centerX*, *centerY*, *deltaX*, *deltaY*,
*baseX*, *baseY* instead of *sx*, *sy*, *sw*, *sh*, *cx*, *cy*, *dx*, *dy*, *bx*, *by*.
- Use *red*, *green*, *blue*, *alpha*, *contentRed*, *contentGreen*, *contentBlue* and *contentAlpha*
instead of *r*,*g*,*b*,*a*,*cr*,*cg*,*cb*,*ca*.
- Use *tilePositionX*, *tilePositionY* instead of *ox*,*oy* in tiled backingstore files.
- Use *object* instead of *obj*
- Use *length* instead of *len*
- Use *coreFrame* instead of *cf*
- Use *buffer* instead of *buf*
- Use *item* instead of *i*
- Use *currentColumn*, *currentRow* instead of *m_col*, *m_row*
- Remove "_" in local variable.
- And so on.

* ewk/ewk_auth_soup.cpp:
* ewk/ewk_contextmenu.cpp:
* ewk/ewk_cookies.cpp:
* ewk/ewk_frame.cpp:
* ewk/ewk_history.cpp:
* ewk/ewk_js.cpp:
* ewk/ewk_main.cpp:
* ewk/ewk_settings.cpp:
* ewk/ewk_tiled_backing_store.cpp:
* ewk/ewk_tiled_matrix.cpp:
* ewk/ewk_tiled_model.cpp:
* ewk/ewk_view.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Gtk] mousemove event always has metaKey == true
commit-queue@webkit.org [Fri, 21 Oct 2011 17:28:07 +0000 (17:28 +0000)]
[Gtk] mousemove event always has metaKey == true
https://bugs.webkit.org/show_bug.cgi?id=35299

Patch by Devdatta Deshpande <pwjd73@motorola.com> on 2011-10-21
Reviewed by Martin Robinson.

Source/WebCore:

GDK_MOD2_MASK doesn't always mean meta so we can't use it to identify
the meta key state. Use GDK_META_MASK instead.

Test: platform/gtk/fast/events/event-sender-metakey.html

* platform/gtk/PlatformMouseEventGtk.cpp:
(WebCore::PlatformMouseEvent::PlatformMouseEvent):

Tools:

* DumpRenderTree/gtk/EventSender.cpp:
(gdkModifierFromJSValue): GDK_META_MASK is used to represent metaKey for platform GTK mouse and
keyboard events. So making it in sync with WebCore files.
(mouseMoveToCallback): Sending modifier keys state for mouse move event.

LayoutTests:

For testing state of metaKey for mouse and keyboard events generated
using evnetSender object.

* platform/gtk/fast/events/event-sender-metakey-expected.txt: Added.
* platform/gtk/fast/events/event-sender-metakey.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoStyle and Link elements' sheet() should return CSSStyleSheet.
commit-queue@webkit.org [Fri, 21 Oct 2011 17:04:39 +0000 (17:04 +0000)]
Style and Link elements' sheet() should return CSSStyleSheet.
https://bugs.webkit.org/show_bug.cgi?id=70608

Patch by Andreas Kling <kling@webkit.org> on 2011-10-21
Reviewed by Antti Koivisto.

Return a CSSStyleSheet* instead of a StyleSheet* in these functions
since we know they are always CSSStyleSheets.
Also remove some now-unnecessary isCSSStyleSheet() checks.

* dom/StyleElement.h:
(WebCore::StyleElement::sheet):
* html/HTMLLinkElement.cpp:
* html/HTMLLinkElement.h:
(WebCore::HTMLLinkElement::sheet):
* page/PageSerializer.cpp:
(WebCore::PageSerializer::serializeFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: Advanced search is working very slowly and does not show searching...
vsevik@chromium.org [Fri, 21 Oct 2011 16:58:58 +0000 (16:58 +0000)]
Web Inspector: Advanced search is working very slowly and does not show searching progress.
https://bugs.webkit.org/show_bug.cgi?id=70611

Search implementation changed so that we do not start searching in the next file unless
the previous one was already searched. This allows to interrupt search.
Not all search matches are added on UI by default now, only first 20 for each file.
Search progress information and search stop button were added to drawer status bar.

Reviewed by Pavel Feldman.

* English.lproj/localizedStrings.js:
* inspector/ContentSearchUtils.cpp:
(WebCore::ContentSearchUtils::getRegularExpressionMatchesByLines):
(WebCore::ContentSearchUtils::countRegularExpressionMatches):
* inspector/front-end/AdvancedSearchController.js:
(WebInspector.AdvancedSearchController.prototype._onSearchResult):
(WebInspector.AdvancedSearchController.prototype._onSearchFinished):
(WebInspector.AdvancedSearchController.prototype.startSearch):
(WebInspector.AdvancedSearchController.prototype.resetSearch):
(WebInspector.AdvancedSearchController.prototype.stopSearch):
(WebInspector.SearchView):
(WebInspector.SearchView.prototype.get statusBarItems):
(WebInspector.SearchView.prototype.get counterElement):
(WebInspector.SearchView.prototype.set resultsPane):
(WebInspector.SearchView.prototype.searchStarted):
(WebInspector.SearchView.prototype._updateSearchResultsMessage):
(WebInspector.SearchView.prototype._updateSearchProgress):
(WebInspector.SearchView.prototype.resetResults):
(WebInspector.SearchView.prototype._resetCounters):
(WebInspector.SearchView.prototype.nothingFound):
(WebInspector.SearchView.prototype.addSearchResult):
(WebInspector.SearchView.prototype.searchFinished):
(WebInspector.SearchView.prototype._searchStopButtonPressed):
(WebInspector.SearchResultsPane):
(WebInspector.FileBasedSearchResultsPane):
(WebInspector.FileBasedSearchResultsPane.prototype.addSearchResult):
(WebInspector.FileBasedSearchResultsPane.prototype._fileTreeElementExpanded):
(WebInspector.FileBasedSearchResultsPane.prototype._appendSearchMatches):
(WebInspector.FileBasedSearchResultsPane.prototype._appendShowMoreMatchesElement):
(WebInspector.FileBasedSearchResultsPane.prototype._showMoreMatchesElementSelected):
(WebInspector.FileBasedSearchResultsPane.prototype._addFileTreeElement):
(WebInspector.FileBasedSearchResultsPane.prototype._regexMatchRanges):
* inspector/front-end/Drawer.js:
(WebInspector.Drawer.prototype.hide):
* inspector/front-end/Images/statusbarButtonGlyphs.png:
* inspector/front-end/ScriptsSearchScope.js:
(WebInspector.ScriptsSearchScope):
(WebInspector.ScriptsSearchScope.prototype.performSearch.filterOutContentScripts):
(WebInspector.ScriptsSearchScope.prototype.performSearch.continueSearch):
(WebInspector.ScriptsSearchScope.prototype.performSearch.searchCallbackWrapper):
(WebInspector.ScriptsSearchScope.prototype.performSearch):
(WebInspector.ScriptsSearchScope.prototype.stopSearch):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._registerShortcuts):
* inspector/front-end/inspector.css:
(#drawer-status-bar .search-status-bar-item):
(#drawer-status-bar .search-status-bar-message):
(#drawer-status-bar .search-status-bar-progress):
(#drawer-status-bar .search-status-bar-stop-button-item):
(#drawer-status-bar .search-status-bar-stop-button .glyph):
(#drawer-status-bar .search-results-status-bar-message):
(.search-view .search-results):
(#search-results-pane-file-based .search-results-outline-disclosure):
(#search-results-pane-file-based .search-result):
(#search-results-pane-file-based .search-result:hover):
(#search-results-pane-file-based .show-more-matches):
(#search-results-pane-file-based .show-more-matches:hover):
(#search-results-pane-file-based .search-match:hover):
* inspector/front-end/utilities.js:
():

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoImplement mechanism to enable privileged webgl extensions
zmo@google.com [Fri, 21 Oct 2011 16:42:19 +0000 (16:42 +0000)]
Implement mechanism to enable privileged webgl extensions
https://bugs.webkit.org/show_bug.cgi?id=70538

Reviewed by Darin Fisher.

Source/WebCore:

* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::allowPrivilegedExtensions): check page/Settings flag.
* page/Settings.cpp: Add the flag.
(WebCore::Settings::Settings):
(WebCore::Settings::setPrivilegedWebGLExtensionsEnabled):
* page/Settings.h: Ditto.
(WebCore::Settings::privilegedWebGLExtensionsEnabled):

Source/WebKit/chromium:

* public/WebSettings.h: Add the flag.
* src/WebSettingsImpl.cpp: Ditto.
(WebKit::WebSettingsImpl::setPrivilegedWebGLExtensionsEnabled):
* src/WebSettingsImpl.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: first line in file is not highlighted.
podivilov@chromium.org [Fri, 21 Oct 2011 15:56:25 +0000 (15:56 +0000)]
Web Inspector: first line in file is not highlighted.
https://bugs.webkit.org/show_bug.cgi?id=70504

Reviewed by Pavel Feldman.

* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._initializeTextViewer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSimplify CSSStyleRule::setSelectorText().
andreas.kling@nokia.com [Fri, 21 Oct 2011 15:43:03 +0000 (15:43 +0000)]
Simplify CSSStyleRule::setSelectorText().
https://bugs.webkit.org/show_bug.cgi?id=70607

Reviewed by Antti Koivisto.

Remove unnecessary isCSSStyleSheet() check and redundant Document finding
logic (CSSStyleSheet::document() will return the owner node's Document just
like this code would.)

* css/CSSStyleRule.cpp:
(WebCore::CSSStyleRule::setSelectorText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed gardening: first chunk of rebaselines for Chromium-Skia
caryclark@google.com [Fri, 21 Oct 2011 15:15:03 +0000 (15:15 +0000)]
Unreviewed gardening: first chunk of rebaselines for Chromium-Skia
on Leopard.

[Omitting 707 of 713 files for brevity.]

* platform/chromium-mac-leopard/css1: Added.
* platform/chromium-mac-leopard/css1/basic: Added.
* platform/chromium-mac-leopard/css1/basic/class_as_selector-expected.png: Added.
...
* platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-54-d-expected.png: Added.
* platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-55-d-expected.png: Added.
* platform/chromium-mac-leopard/css2.1/t170602-bdr-conflct-w-56-d-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, skip failing a11y test in GTK.
philn@webkit.org [Fri, 21 Oct 2011 14:33:09 +0000 (14:33 +0000)]
Unreviewed, skip failing a11y test in GTK.

* platform/gtk/Skipped: Skip accessibility/menu-list-sends-change-notification.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, GTK baselines for 3 new tests.
philn@webkit.org [Fri, 21 Oct 2011 14:16:17 +0000 (14:16 +0000)]
Unreviewed, GTK baselines for 3 new tests.

* platform/gtk/fast/css/clip-text-in-scaled-div-expected.txt: Added.
* platform/gtk/fast/repaint/region-painting-via-layout-expected.txt: Added.
* platform/gtk/fast/selectors/visited-descendant-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agowatchlist: Add a new entry for WebKit2 GTK+ public API
carlosgc@webkit.org [Fri, 21 Oct 2011 13:47:58 +0000 (13:47 +0000)]
watchlist: Add a new entry for WebKit2 GTK+ public API
https://bugs.webkit.org/show_bug.cgi?id=70601

Reviewed by Philippe Normand.

Subscribe myself to WebKit2 GTK+ API patches. Also add a message
for patches that might include new API that points to the WebKit2
GTK+ API guidelines.

* Scripts/webkitpy/common/config/watchlist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed gardening: rebaselining to account for focus ring changes in
caryclark@google.com [Fri, 21 Oct 2011 13:36:22 +0000 (13:36 +0000)]
Unreviewed gardening: rebaselining to account for focus ring changes in
http://trac.webkit.org/changeset/97971

* platform/chromium-mac-snowleopard/editing/deleting/5099303-expected.png: Added.
* platform/chromium-mac-snowleopard/editing/deleting/delete-3959464-fix-expected.png:
* platform/chromium-mac-snowleopard/editing/deleting/delete-and-undo-expected.png:
* platform/chromium-mac-snowleopard/editing/deleting/delete-block-contents-003-expected.png:
* platform/chromium-mac-snowleopard/editing/deleting/delete-contiguous-ws-001-expected.png:
* platform/chromium-mac-snowleopard/editing/deleting/delete-tab-002-expected.png:
* platform/chromium-mac-snowleopard/editing/deleting/delete-tab-003-expected.png:
* platform/chromium-mac-snowleopard/editing/deleting/delete-to-select-table-expected.png:
* platform/chromium-mac-snowleopard/editing/deleting/delete-trailing-ws-002-expected.png:
* platform/chromium-mac-snowleopard/editing/deleting/delete-ws-fixup-001-expected.png:
* platform/chromium-mac-snowleopard/editing/deleting/delete-ws-fixup-002-expected.png:
* platform/chromium-mac-snowleopard/editing/execCommand/5569741-expected.png:
* platform/chromium-mac-snowleopard/editing/execCommand/insert-list-and-stitch-expected.png:
* platform/chromium-mac-snowleopard/editing/execCommand/insertHorizontalRule-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/5418891-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/editing-empty-divs-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/insert-br-004-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/insert-br-005-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/insert-br-007-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/insert-div-025-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/insert-paragraph-02-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/insert-paragraph-03-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/insert-tab-002-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/insert-tab-003-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/insert-text-with-newlines-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/paragraph-separator-01-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/paragraph-separator-02-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/paragraph-separator-03-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/return-key-with-selection-001-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/return-key-with-selection-002-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/return-key-with-selection-003-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/typing-002-expected.png:
* platform/chromium-mac-snowleopard/editing/inserting/typing-around-br-001-expected.png:
* platform/chromium-mac-snowleopard/editing/pasteboard/4242293-expected.png:
* platform/chromium-mac-snowleopard/editing/pasteboard/8145-2-expected.png:
* platform/chromium-mac-snowleopard/editing/pasteboard/cut-text-001-expected.png:
* platform/chromium-mac-snowleopard/editing/pasteboard/drag-selected-image-to-contenteditable-expected.png:
* platform/chromium-mac-snowleopard/editing/pasteboard/merge-after-delete-1-expected.png:
* platform/chromium-mac-snowleopard/editing/pasteboard/merge-after-delete-2-expected.png:
* platform/chromium-mac-snowleopard/editing/pasteboard/merge-after-delete-expected.png:
* platform/chromium-mac-snowleopard/editing/pasteboard/merge-end-blockquote-expected.png:
* platform/chromium-mac-snowleopard/editing/pasteboard/paste-text-019-expected.png:
* platform/chromium-mac-snowleopard/editing/pasteboard/smart-paste-008-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/13804-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/5234383-1-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/5234383-2-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/extend-by-word-001-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/move-backwords-by-word-001-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/move-by-character-001-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/move-by-line-001-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/move-by-word-001-expected.png:
* platform/chromium-mac-snowleopard/editing/selection/unrendered-002-expected.png:
* platform/chromium-mac-snowleopard/editing/spelling/spelling-expected.png:
* platform/chromium-mac-snowleopard/editing/style/5046875-2-expected.png:
* platform/chromium-mac-snowleopard/editing/style/block-styles-007-expected.png:
* platform/chromium-mac/editing/deleting/4922367-expected.png:
* platform/chromium-mac/editing/deleting/5126166-expected.png:
* platform/chromium-mac/editing/deleting/5144139-2-expected.png:
* platform/chromium-mac/editing/deleting/5206311-1-expected.png:
* platform/chromium-mac/editing/deleting/5272440-expected.png:
* platform/chromium-mac/editing/deleting/5369009-expected.png:
* platform/chromium-mac/editing/deleting/5433862-2-expected.png:
* platform/chromium-mac/editing/deleting/5483370-expected.png:
* platform/chromium-mac/editing/deleting/collapse-whitespace-3587601-fix-expected.png:
* platform/chromium-mac/editing/deleting/delete-3608445-fix-expected.png:
* platform/chromium-mac/editing/deleting/delete-3608462-fix-expected.png:
* platform/chromium-mac/editing/deleting/delete-3959464-fix-expected.png:
* platform/chromium-mac/editing/deleting/delete-4083333-fix-expected.png:
* platform/chromium-mac/editing/deleting/delete-after-span-ws-001-expected.png:
* platform/chromium-mac/editing/deleting/delete-after-span-ws-002-expected.png:
* platform/chromium-mac/editing/deleting/delete-after-span-ws-003-expected.png:
* platform/chromium-mac/editing/deleting/delete-and-undo-expected.png:
* platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-001-expected.png:
* platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-002-expected.png:
* platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-003-expected.png:
* platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-004-expected.png:
* platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-005-expected.png:
* platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-006-expected.png:
* platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-007-expected.png:
* platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-008-expected.png:
* platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-009-expected.png:
* platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-010-expected.png:
* platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-011-expected.png:
* platform/chromium-mac/editing/deleting/delete-at-start-or-end-expected.png:
* platform/chromium-mac/editing/deleting/delete-block-contents-001-expected.png:
* platform/chromium-mac/editing/deleting/delete-block-contents-002-expected.png:
* platform/chromium-mac/editing/deleting/delete-block-contents-003-expected.png:
* platform/chromium-mac/editing/deleting/delete-block-merge-contents-001-expected.png:
* platform/chromium-mac/editing/deleting/delete-block-merge-contents-002-expected.png:
* platform/chromium-mac/editing/deleting/delete-block-merge-contents-003-expected.png:
* platform/chromium-mac/editing/deleting/delete-block-merge-contents-004-expected.png:
* platform/chromium-mac/editing/deleting/delete-block-merge-contents-005-expected.png:
* platform/chromium-mac/editing/deleting/delete-block-merge-contents-006-expected.png:
* platform/chromium-mac/editing/deleting/delete-block-merge-contents-007-expected.png:
* platform/chromium-mac/editing/deleting/delete-block-merge-contents-008-expected.png:
* platform/chromium-mac/editing/deleting/delete-block-merge-contents-009-expected.png:
* platform/chromium-mac/editing/deleting/delete-block-merge-contents-010-expected.png:
* platform/chromium-mac/editing/deleting/delete-block-merge-contents-011-expected.png:
* platform/chromium-mac/editing/deleting/delete-block-merge-contents-012-expected.png:
* platform/chromium-mac/editing/deleting/delete-block-merge-contents-013-expected.png:
* platform/chromium-mac/editing/deleting/delete-block-merge-contents-014-expected.png:
* platform/chromium-mac/editing/deleting/delete-block-merge-contents-015-expected.png:
* platform/chromium-mac/editing/deleting/delete-block-merge-contents-016-expected.png:
* platform/chromium-mac/editing/deleting/delete-block-merge-contents-017-expected.png:
* platform/chromium-mac/editing/deleting/delete-br-001-expected.png:
* platform/chromium-mac/editing/deleting/delete-br-002-expected.png:
* platform/chromium-mac/editing/deleting/delete-br-003-expected.png:
* platform/chromium-mac/editing/deleting/delete-br-004-expected.png:
* platform/chromium-mac/editing/deleting/delete-br-005-expected.png:
* platform/chromium-mac/editing/deleting/delete-br-006-expected.png:
* platform/chromium-mac/editing/deleting/delete-br-007-expected.png:
* platform/chromium-mac/editing/deleting/delete-br-013-expected.png:
* platform/chromium-mac/editing/deleting/delete-character-001-expected.png:
* platform/chromium-mac/editing/deleting/delete-contiguous-ws-001-expected.png:
* platform/chromium-mac/editing/deleting/delete-first-list-item-expected.png:
* platform/chromium-mac/editing/deleting/delete-hr-expected.png:
* platform/chromium-mac/editing/deleting/delete-image-001-expected.png:
* platform/chromium-mac/editing/deleting/delete-image-002-expected.png:
* platform/chromium-mac/editing/deleting/delete-image-003-expected.png:
* platform/chromium-mac/editing/deleting/delete-image-004-expected.png:
* platform/chromium-mac/editing/deleting/delete-leading-ws-001-expected.png:
* platform/chromium-mac/editing/deleting/delete-line-015-expected.png:
* platform/chromium-mac/editing/deleting/delete-line-016-expected.png:
* platform/chromium-mac/editing/deleting/delete-line-017-expected.png:
* platform/chromium-mac/editing/deleting/delete-line-end-ws-001-expected.png:
* platform/chromium-mac/editing/deleting/delete-line-end-ws-002-expected.png:
* platform/chromium-mac/editing/deleting/delete-listitem-001-expected.png:
* platform/chromium-mac/editing/deleting/delete-listitem-002-expected.png:
* platform/chromium-mac/editing/deleting/delete-selection-001-expected.png:
* platform/chromium-mac/editing/deleting/delete-tab-001-expected.png:
* platform/chromium-mac/editing/deleting/delete-tab-002-expected.png:
* platform/chromium-mac/editing/deleting/delete-tab-003-expected.png:
* platform/chromium-mac/editing/deleting/delete-tab-004-expected.png:
* platform/chromium-mac/editing/deleting/delete-to-select-table-expected.png:
* platform/chromium-mac/editing/deleting/delete-trailing-ws-001-expected.png:
* platform/chromium-mac/editing/deleting/delete-trailing-ws-002-expected.png:
* platform/chromium-mac/editing/deleting/delete-ws-fixup-001-expected.png:
* platform/chromium-mac/editing/deleting/delete-ws-fixup-002-expected.png:
* platform/chromium-mac/editing/deleting/delete-ws-fixup-003-expected.png:
* platform/chromium-mac/editing/deleting/delete-ws-fixup-004-expected.png:
* platform/chromium-mac/editing/deleting/list-item-1-expected.png:
* platform/chromium-mac/editing/deleting/merge-different-styles-expected.png:
* platform/chromium-mac/editing/deleting/merge-endOfParagraph-expected.png:
* platform/chromium-mac/editing/deleting/merge-into-empty-block-1-expected.png:
* platform/chromium-mac/editing/deleting/merge-into-empty-block-2-expected.png:
* platform/chromium-mac/editing/deleting/merge-no-br-expected.png:
* platform/chromium-mac/editing/deleting/merge-unrendered-space-expected.png:
* platform/chromium-mac/editing/deleting/merge-whitespace-pre-expected.png:
* platform/chromium-mac/editing/deleting/non-smart-delete-expected.png:
* platform/chromium-mac/editing/deleting/pruning-after-merge-2-expected.png:
* platform/chromium-mac/editing/deleting/smart-delete-001-expected.png:
* platform/chromium-mac/editing/deleting/smart-delete-002-expected.png:
* platform/chromium-mac/editing/deleting/smart-delete-003-expected.png:
* platform/chromium-mac/editing/deleting/smart-delete-004-expected.png:
* platform/chromium-mac/editing/deleting/table-cells-expected.png:
* platform/chromium-mac/editing/deleting/type-delete-after-quote-expected.png:
* platform/chromium-mac/editing/execCommand/4580583-1-expected.png:
* platform/chromium-mac/editing/execCommand/4580583-2-expected.png:
* platform/chromium-mac/editing/execCommand/4641880-1-expected.png:
* platform/chromium-mac/editing/execCommand/4641880-2-expected.png:
* platform/chromium-mac/editing/execCommand/4747450-expected.png:
* platform/chromium-mac/editing/execCommand/4916402-expected.png:
* platform/chromium-mac/editing/execCommand/4916541-expected.png:
* platform/chromium-mac/editing/execCommand/4924441-expected.png:
* platform/chromium-mac/editing/execCommand/5080333-1-expected.png:
* platform/chromium-mac/editing/execCommand/5080333-2-expected.png:
* platform/chromium-mac/editing/execCommand/5136770-expected.png:
* platform/chromium-mac/editing/execCommand/5138441-expected.png:
* platform/chromium-mac/editing/execCommand/5142012-1-expected.png:
* platform/chromium-mac/editing/execCommand/5481523-expected.png:
* platform/chromium-mac/editing/execCommand/5569741-expected.png:
* platform/chromium-mac/editing/execCommand/create-list-with-hr-expected.png:
* platform/chromium-mac/editing/execCommand/format-block-with-trailing-br-expected.png:
* platform/chromium-mac/editing/execCommand/indent-empty-root-expected.png:
* platform/chromium-mac/editing/execCommand/indent-list-item-expected.png:
* platform/chromium-mac/editing/execCommand/indent-selection-expected.png:
* platform/chromium-mac/editing/execCommand/insert-list-and-stitch-expected.png:
* platform/chromium-mac/editing/execCommand/insertHorizontalRule-expected.png:
* platform/chromium-mac/editing/execCommand/insertImage-expected.png:
* platform/chromium-mac/editing/execCommand/nsresponder-indent-expected.png:
* platform/chromium-mac/editing/execCommand/nsresponder-outdent-expected.png:
* platform/chromium-mac/editing/execCommand/print-expected.png:
* platform/chromium-mac/editing/execCommand/remove-list-from-range-selection-expected.png:
* platform/chromium-mac/editing/execCommand/remove-list-item-1-expected.png:
* platform/chromium-mac/editing/execCommand/selectAll-expected.png:
* platform/chromium-mac/editing/inserting/4278698-expected.png:
* platform/chromium-mac/editing/inserting/4840662-expected.png:
* platform/chromium-mac/editing/inserting/4875189-1-expected.png:
* platform/chromium-mac/editing/inserting/4875189-2-expected.png:
* platform/chromium-mac/editing/inserting/4959067-expected.png:
* platform/chromium-mac/editing/inserting/4960120-2-expected.png:
* platform/chromium-mac/editing/inserting/5002441-expected.png:
* platform/chromium-mac/editing/inserting/5058163-1-expected.png:
* platform/chromium-mac/editing/inserting/5058163-2-expected.png:
* platform/chromium-mac/editing/inserting/5156401-2-expected.png:
* platform/chromium-mac/editing/inserting/5418891-expected.png:
* platform/chromium-mac/editing/inserting/5510537-expected.png:
* platform/chromium-mac/editing/inserting/5549929-2-expected.png:
* platform/chromium-mac/editing/inserting/5549929-3-expected.png:
* platform/chromium-mac/editing/inserting/6703873-expected.png:
* platform/chromium-mac/editing/inserting/before-after-input-element-expected.png:
* platform/chromium-mac/editing/inserting/break-blockquote-after-delete-expected.png:
* platform/chromium-mac/editing/inserting/editable-inline-element-expected.png:
* platform/chromium-mac/editing/inserting/edited-whitespace-1-expected.png:
* platform/chromium-mac/editing/inserting/editing-empty-divs-expected.png:
* platform/chromium-mac/editing/inserting/insert-3775316-fix-expected.png:
* platform/chromium-mac/editing/inserting/insert-3778059-fix-expected.png:
* platform/chromium-mac/editing/inserting/insert-3800346-fix-expected.png:
* platform/chromium-mac/editing/inserting/insert-after-delete-001-expected.png:
* platform/chromium-mac/editing/inserting/insert-at-end-01-expected.png:
* platform/chromium-mac/editing/inserting/insert-at-end-02-expected.png:
* platform/chromium-mac/editing/inserting/insert-br-001-expected.png:
* platform/chromium-mac/editing/inserting/insert-br-002-expected.png:
* platform/chromium-mac/editing/inserting/insert-br-003-expected.png:
* platform/chromium-mac/editing/inserting/insert-br-004-expected.png:
* platform/chromium-mac/editing/inserting/insert-br-005-expected.png:
* platform/chromium-mac/editing/inserting/insert-br-006-expected.png:
* platform/chromium-mac/editing/inserting/insert-br-007-expected.png:
* platform/chromium-mac/editing/inserting/insert-br-008-expected.png:
* platform/chromium-mac/editing/inserting/insert-br-009-expected.png:
* platform/chromium-mac/editing/inserting/insert-br-at-tabspan-001-expected.png:
* platform/chromium-mac/editing/inserting/insert-br-at-tabspan-002-expected.png:
* platform/chromium-mac/editing/inserting/insert-br-at-tabspan-003-expected.png:
* platform/chromium-mac/editing/inserting/insert-br-quoted-001-expected.png:
* platform/chromium-mac/editing/inserting/insert-br-quoted-002-expected.png:
* platform/chromium-mac/editing/inserting/insert-br-quoted-003-expected.png:
* platform/chromium-mac/editing/inserting/insert-br-quoted-004-expected.png:
* platform/chromium-mac/editing/inserting/insert-br-quoted-005-expected.png:
* platform/chromium-mac/editing/inserting/insert-br-quoted-006-expected.png:
* platform/chromium-mac/editing/inserting/insert-div-025-expected.png:
* platform/chromium-mac/editing/inserting/insert-div-026-expected.png:
* platform/chromium-mac/editing/inserting/insert-paragraph-01-expected.png:
* platform/chromium-mac/editing/inserting/insert-paragraph-02-expected.png:
* platform/chromium-mac/editing/inserting/insert-paragraph-03-expected.png:
* platform/chromium-mac/editing/inserting/insert-paragraph-04-expected.png:
* platform/chromium-mac/editing/inserting/insert-paragraph-05-expected.png:
* platform/chromium-mac/editing/inserting/insert-space-in-empty-doc-expected.png:
* platform/chromium-mac/editing/inserting/insert-tab-001-expected.png:
* platform/chromium-mac/editing/inserting/insert-tab-002-expected.png:
* platform/chromium-mac/editing/inserting/insert-tab-003-expected.png:
* platform/chromium-mac/editing/inserting/insert-tab-004-expected.png:
* platform/chromium-mac/editing/inserting/insert-text-at-tabspan-001-expected.png:
* platform/chromium-mac/editing/inserting/insert-text-at-tabspan-002-expected.png:
* platform/chromium-mac/editing/inserting/insert-text-at-tabspan-003-expected.png:
* platform/chromium-mac/editing/inserting/insert-text-with-newlines-expected.png:
* platform/chromium-mac/editing/inserting/line-break-expected.png:
* platform/chromium-mac/editing/inserting/multiple-lines-selected-expected.png:
* platform/chromium-mac/editing/inserting/paragraph-separator-01-expected.png:
* platform/chromium-mac/editing/inserting/paragraph-separator-02-expected.png:
* platform/chromium-mac/editing/inserting/paragraph-separator-03-expected.png:
* platform/chromium-mac/editing/inserting/paragraph-separator-in-table-1-expected.png:
* platform/chromium-mac/editing/inserting/paragraph-separator-in-table-2-expected.png:
* platform/chromium-mac/editing/inserting/redo-expected.png:
* platform/chromium-mac/editing/inserting/return-key-with-selection-001-expected.png:
* platform/chromium-mac/editing/inserting/return-key-with-selection-002-expected.png:
* platform/chromium-mac/editing/inserting/return-key-with-selection-003-expected.png:
* platform/chromium-mac/editing/inserting/typing-001-expected.png:
* platform/chromium-mac/editing/inserting/typing-002-expected.png:
* platform/chromium-mac/editing/inserting/typing-003-expected.png:
* platform/chromium-mac/editing/inserting/typing-around-br-001-expected.png:
* platform/chromium-mac/editing/inserting/typing-around-image-001-expected.png:
* platform/chromium-mac/editing/pasteboard/3976872-expected.png:
* platform/chromium-mac/editing/pasteboard/4076267-2-expected.png:
* platform/chromium-mac/editing/pasteboard/4076267-3-expected.png:
* platform/chromium-mac/editing/pasteboard/4076267-expected.png:
* platform/chromium-mac/editing/pasteboard/4242293-expected.png:
* platform/chromium-mac/editing/pasteboard/4631972-expected.png:
* platform/chromium-mac/editing/pasteboard/4641033-expected.png:
* platform/chromium-mac/editing/pasteboard/4806874-expected.png:
* platform/chromium-mac/editing/pasteboard/4944770-1-expected.png:
* platform/chromium-mac/editing/pasteboard/4944770-2-expected.png:
* platform/chromium-mac/editing/pasteboard/4947130-expected.png:
* platform/chromium-mac/editing/pasteboard/5006779-expected.png:
* platform/chromium-mac/editing/pasteboard/5032095-expected.png:
* platform/chromium-mac/editing/pasteboard/5071074-2-expected.png:
* platform/chromium-mac/editing/pasteboard/5071074-expected.png:
* platform/chromium-mac/editing/pasteboard/5075944-expected.png:
* platform/chromium-mac/editing/pasteboard/5134759-expected.png:
* platform/chromium-mac/editing/pasteboard/5156401-1-expected.png:
* platform/chromium-mac/editing/pasteboard/5247341-expected.png:
* platform/chromium-mac/editing/pasteboard/5387578-expected.png:
* platform/chromium-mac/editing/pasteboard/5478250-expected.png:
* platform/chromium-mac/editing/pasteboard/5601583-1-expected.png:
* platform/chromium-mac/editing/pasteboard/8145-1-expected.png:
* platform/chromium-mac/editing/pasteboard/8145-2-expected.png:
* platform/chromium-mac/editing/pasteboard/8145-3-expected.png:
* platform/chromium-mac/editing/pasteboard/bad-placeholder-expected.png:
* platform/chromium-mac/editing/pasteboard/cut-text-001-expected.png:
* platform/chromium-mac/editing/pasteboard/displaced-generic-placeholder-expected.png:
* platform/chromium-mac/editing/pasteboard/displaced-placeholder-expected.png:
* platform/chromium-mac/editing/pasteboard/drag-drop-modifies-page-expected.png:
* platform/chromium-mac/editing/pasteboard/drag-selected-image-to-contenteditable-expected.png: Added.
* platform/chromium-mac/editing/pasteboard/drag-selected-image-to-contenteditable-expected.txt: Added.
* platform/chromium-mac/editing/pasteboard/input-field-1-expected.png:
* platform/chromium-mac/editing/pasteboard/merge-after-delete-1-expected.png:
* platform/chromium-mac/editing/pasteboard/merge-after-delete-2-expected.png:
* platform/chromium-mac/editing/pasteboard/merge-after-delete-expected.png:
* platform/chromium-mac/editing/pasteboard/merge-end-blockquote-expected.png:
* platform/chromium-mac/editing/pasteboard/merge-end-borders-expected.png:
* platform/chromium-mac/editing/pasteboard/merge-start-blockquote-expected.png:
* platform/chromium-mac/editing/pasteboard/merge-start-list-expected.png:
* platform/chromium-mac/editing/pasteboard/paste-4035648-fix-expected.png:
* platform/chromium-mac/editing/pasteboard/paste-4038267-fix-expected.png:
* platform/chromium-mac/editing/pasteboard/paste-blockquote-after-blockquote-expected.png:
* platform/chromium-mac/editing/pasteboard/paste-blockquote-into-blockquote-4-expected.png:
* platform/chromium-mac/editing/pasteboard/paste-line-endings-001-expected.png:
* platform/chromium-mac/editing/pasteboard/paste-line-endings-002-expected.png:
* platform/chromium-mac/editing/pasteboard/paste-line-endings-003-expected.png:
* platform/chromium-mac/editing/pasteboard/paste-line-endings-004-expected.png:
* platform/chromium-mac/editing/pasteboard/paste-line-endings-005-expected.png:
* platform/chromium-mac/editing/pasteboard/paste-line-endings-006-expected.png:
* platform/chromium-mac/editing/pasteboard/paste-line-endings-007-expected.png:
* platform/chromium-mac/editing/pasteboard/paste-line-endings-008-expected.png:
* platform/chromium-mac/editing/pasteboard/paste-line-endings-009-expected.png:
* platform/chromium-mac/editing/pasteboard/paste-line-endings-010-expected.png:
* platform/chromium-mac/editing/pasteboard/paste-match-style-001-expected.png:
* platform/chromium-mac/editing/pasteboard/paste-match-style-002-expected.png:
* platform/chromium-mac/editing/pasteboard/paste-text-019-expected.png:
* platform/chromium-mac/editing/pasteboard/paste-text-at-tabspan-003-expected.png:
* platform/chromium-mac/editing/pasteboard/pasting-object-expected.png:
* platform/chromium-mac/editing/pasteboard/pasting-tabs-expected.png:
* platform/chromium-mac/editing/pasteboard/quirks-mode-br-1-expected.png:
* platform/chromium-mac/editing/pasteboard/smart-drag-drop-expected.png:
* platform/chromium-mac/editing/pasteboard/smart-paste-007-expected.png:
* platform/chromium-mac/editing/pasteboard/smart-paste-008-expected.png: Added.
* platform/chromium-mac/editing/pasteboard/styled-element-markup-expected.png:
* platform/chromium-mac/editing/pasteboard/undoable-fragment-removes-expected.png:
* platform/chromium-mac/editing/pasteboard/unrendered-br-expected.png:
* platform/chromium-mac/editing/selection/13804-expected.png:
* platform/chromium-mac/editing/selection/3690703-2-expected.png:
* platform/chromium-mac/editing/selection/3690703-expected.png:
* platform/chromium-mac/editing/selection/3690719-expected.png:
* platform/chromium-mac/editing/selection/4397952-expected.png:
* platform/chromium-mac/editing/selection/4818145-expected.png:
* platform/chromium-mac/editing/selection/4866671-expected.png:
* platform/chromium-mac/editing/selection/4889598-expected.png:
* platform/chromium-mac/editing/selection/4895428-2-expected.png:
* platform/chromium-mac/editing/selection/4932260-1-expected.png:
* platform/chromium-mac/editing/selection/4932260-2-expected.png:
* platform/chromium-mac/editing/selection/4932260-3-expected.png:
* platform/chromium-mac/editing/selection/4947387-expected.png:
* platform/chromium-mac/editing/selection/5007143-2-expected.png:
* platform/chromium-mac/editing/selection/5007143-expected.png:
* platform/chromium-mac/editing/selection/5057506-2-expected.png:
* platform/chromium-mac/editing/selection/5057506-expected.png:
* platform/chromium-mac/editing/selection/5076323-1-expected.png:
* platform/chromium-mac/editing/selection/5076323-2-expected.png:
* platform/chromium-mac/editing/selection/5076323-3-expected.png:
* platform/chromium-mac/editing/selection/5099303-expected.png:
* platform/chromium-mac/editing/selection/5131716-1-expected.png:
* platform/chromium-mac/editing/selection/5131716-2-expected.png:
* platform/chromium-mac/editing/selection/5131716-3-expected.png:
* platform/chromium-mac/editing/selection/5131716-4-expected.png:
* platform/chromium-mac/editing/selection/5195166-2-expected.png:
* platform/chromium-mac/editing/selection/5234383-1-expected.png:
* platform/chromium-mac/editing/selection/5234383-2-expected.png:
* platform/chromium-mac/editing/selection/6476-expected.png:
* platform/chromium-mac/editing/selection/after-line-wrap-expected.png:
* platform/chromium-mac/editing/selection/caret-before-select-expected.png:
* platform/chromium-mac/editing/selection/caret-ltr-2-expected.png:
* platform/chromium-mac/editing/selection/caret-ltr-2-left-expected.png:
* platform/chromium-mac/editing/selection/caret-ltr-expected.png:
* platform/chromium-mac/editing/selection/caret-ltr-right-expected.png:
* platform/chromium-mac/editing/selection/caret-rtl-2-expected.png:
* platform/chromium-mac/editing/selection/caret-rtl-2-left-expected.png:
* platform/chromium-mac/editing/selection/caret-rtl-expected.png:
* platform/chromium-mac/editing/selection/caret-rtl-right-expected.png:
* platform/chromium-mac/editing/selection/click-start-of-line-expected.png:
* platform/chromium-mac/editing/selection/contains-boundaries-expected.png:
* platform/chromium-mac/editing/selection/contenteditable-click-inside-expected.png:
* platform/chromium-mac/editing/selection/drag-select-1-expected.png:
* platform/chromium-mac/editing/selection/editable-non-editable-crash-expected.png:
* platform/chromium-mac/editing/selection/end-of-document-expected.png:
* platform/chromium-mac/editing/selection/expanding-selections-expected.png:
* platform/chromium-mac/editing/selection/expanding-selections2-expected.png:
* platform/chromium-mac/editing/selection/extend-by-character-001-expected.png:
* platform/chromium-mac/editing/selection/extend-by-character-002-expected.png:
* platform/chromium-mac/editing/selection/extend-by-character-003-expected.png:
* platform/chromium-mac/editing/selection/extend-by-character-004-expected.png:
* platform/chromium-mac/editing/selection/extend-by-character-005-expected.png:
* platform/chromium-mac/editing/selection/extend-by-character-006-expected.png:
* platform/chromium-mac/editing/selection/extend-by-sentence-001-expected.png:
* platform/chromium-mac/editing/selection/extend-by-word-001-expected.png:
* platform/chromium-mac/editing/selection/extend-by-word-002-expected.png:
* platform/chromium-mac/editing/selection/extend-selection-bidi-expected.png:
* platform/chromium-mac/editing/selection/fake-doubleclick-expected.png:
* platform/chromium-mac/editing/selection/iframe-expected.png:
* platform/chromium-mac/editing/selection/image-before-linebreak-expected.png:
* platform/chromium-mac/editing/selection/inline-table-expected.png:
* platform/chromium-mac/editing/selection/leave-requested-block-expected.png:
* platform/chromium-mac/editing/selection/mixed-editability-3-expected.png:
* platform/chromium-mac/editing/selection/mixed-editability-4-expected.png:
* platform/chromium-mac/editing/selection/mixed-editability-5-expected.png:
* platform/chromium-mac/editing/selection/mixed-editability-6-expected.png:
* platform/chromium-mac/editing/selection/mixed-editability-7-expected.png:
* platform/chromium-mac/editing/selection/mixed-editability-8-expected.png:
* platform/chromium-mac/editing/selection/mixed-editability-9-expected.png:
* platform/chromium-mac/editing/selection/move-backwords-by-word-001-expected.png:
* platform/chromium-mac/editing/selection/move-between-blocks-no-001-expected.png:
* platform/chromium-mac/editing/selection/move-by-character-001-expected.png:
* platform/chromium-mac/editing/selection/move-by-character-002-expected.png:
* platform/chromium-mac/editing/selection/move-by-character-003-expected.png:
* platform/chromium-mac/editing/selection/move-by-character-004-expected.png:
* platform/chromium-mac/editing/selection/move-by-character-005-expected.png:
* platform/chromium-mac/editing/selection/move-by-character-6-expected.png:
* platform/chromium-mac/editing/selection/move-by-line-001-expected.png:
* platform/chromium-mac/editing/selection/move-by-line-002-expected.png:
* platform/chromium-mac/editing/selection/move-by-sentence-001-expected.png:
* platform/chromium-mac/editing/selection/move-by-sentence-linebreak-expected.png:
* platform/chromium-mac/editing/selection/move-by-word-001-expected.png:
* platform/chromium-mac/editing/selection/move-past-trailing-space-expected.png:
* platform/chromium-mac/editing/selection/previous-line-position-expected.png:
* platform/chromium-mac/editing/selection/replace-selection-1-expected.png:
* platform/chromium-mac/editing/selection/replaced-boundaries-1-expected.png:
* platform/chromium-mac/editing/selection/replaced-boundaries-2-expected.png:
* platform/chromium-mac/editing/selection/replaced-boundaries-3-expected.png:
* platform/chromium-mac/editing/selection/select-all-001-expected.png:
* platform/chromium-mac/editing/selection/select-all-002-expected.png:
* platform/chromium-mac/editing/selection/select-box-expected.png:
* platform/chromium-mac/editing/selection/select-element-paragraph-boundary-expected.png:
* platform/chromium-mac/editing/selection/select-missing-image-expected.png:
* platform/chromium-mac/editing/selection/selection-3748164-fix-expected.png:
* platform/chromium-mac/editing/selection/table-caret-1-expected.png:
* platform/chromium-mac/editing/selection/table-caret-2-expected.png:
* platform/chromium-mac/editing/selection/table-caret-3-expected.png:
* platform/chromium-mac/editing/selection/triple-click-in-pre-expected.png:
* platform/chromium-mac/editing/selection/unrendered-001-expected.png:
* platform/chromium-mac/editing/selection/unrendered-002-expected.png: Added.
* platform/chromium-mac/editing/selection/unrendered-003-expected.png:
* platform/chromium-mac/editing/selection/unrendered-004-expected.png:
* platform/chromium-mac/editing/selection/unrendered-005-expected.png:
* platform/chromium-mac/editing/selection/unrendered-space-expected.png:
* platform/chromium-mac/editing/selection/wrapped-line-caret-1-expected.png:
* platform/chromium-mac/editing/selection/wrapped-line-caret-2-expected.png:
* platform/chromium-mac/editing/spelling/spelling-expected.png:
* platform/chromium-mac/editing/style/4916887-expected.png:
* platform/chromium-mac/editing/style/5017613-1-expected.png:
* platform/chromium-mac/editing/style/5017613-2-expected.png:
* platform/chromium-mac/editing/style/5046875-1-expected.png:
* platform/chromium-mac/editing/style/5046875-2-expected.png: Added.
* platform/chromium-mac/editing/style/5065910-expected.png:
* platform/chromium-mac/editing/style/5084241-expected.png:
* platform/chromium-mac/editing/style/5228141-expected.png:
* platform/chromium-mac/editing/style/5279521-expected.png:
* platform/chromium-mac/editing/style/block-styles-007-expected.png:
* platform/chromium-mac/editing/style/highlight-expected.png:
* platform/chromium-mac/editing/style/smoosh-styles-001-expected.png:
* platform/chromium-mac/editing/style/style-3681552-fix-001-expected.png:
* platform/chromium-mac/editing/style/style-3681552-fix-002-expected.png:
* platform/chromium-mac/editing/style/style-3998892-fix-expected.png:
* platform/chromium-mac/editing/style/style-boundary-001-expected.png:
* platform/chromium-mac/editing/style/style-boundary-002-expected.png:
* platform/chromium-mac/editing/style/style-boundary-003-expected.png:
* platform/chromium-mac/editing/style/style-boundary-004-expected.png:
* platform/chromium-mac/editing/style/style-boundary-005-expected.png:
* platform/chromium-mac/editing/style/typing-style-001-expected.png:
* platform/chromium-mac/editing/style/typing-style-002-expected.png:
* platform/chromium-mac/editing/style/unbold-in-bold-expected.png:
* platform/chromium-mac/editing/undo/4063751-expected.png:
* platform/chromium-mac/editing/undo/5378473-expected.png:
* platform/chromium-mac/editing/undo/redo-typing-001-expected.png:
* platform/chromium-mac/editing/undo/undo-combined-delete-boundary-expected.png:
* platform/chromium-mac/editing/undo/undo-combined-delete-expected.png:
* platform/chromium-mac/editing/undo/undo-delete-boundary-expected.png:
* platform/chromium-mac/editing/undo/undo-delete-expected.png:
* platform/chromium-mac/editing/undo/undo-forward-delete-boundary-expected.png:
* platform/chromium-mac/editing/undo/undo-forward-delete-expected.png:
* platform/chromium-mac/editing/undo/undo-misspellings-expected.png:
* platform/chromium-mac/editing/undo/undo-typing-001-expected.png:
* platform/chromium-mac/editing/unsupported-content/list-delete-001-expected.png:
* platform/chromium-mac/editing/unsupported-content/list-delete-003-expected.png:
* platform/chromium-mac/editing/unsupported-content/list-type-after-expected.png:
* platform/chromium-mac/editing/unsupported-content/list-type-before-expected.png:
* platform/chromium-mac/editing/unsupported-content/table-delete-001-expected.png:
* platform/chromium-mac/editing/unsupported-content/table-delete-002-expected.png:
* platform/chromium-mac/editing/unsupported-content/table-delete-003-expected.png:
* platform/chromium-mac/editing/unsupported-content/table-type-after-expected.png:
* platform/chromium-mac/editing/unsupported-content/table-type-before-expected.png:
* platform/chromium-mac/fast/css/focus-ring-outline-color-expected.png:
* platform/chromium-mac/fast/css/focus-ring-outline-offset-expected.png:
* platform/chromium-mac/fast/css/focus-ring-outline-width-expected.png:
* platform/chromium-mac/fast/css/outline-auto-location-expected.png:
* platform/chromium-mac/fast/dom/focus-contenteditable-expected.png:
* platform/chromium-mac/fast/inline/25277-2-expected.png:
* platform/chromium-mac/fast/inline/25277-expected.png:
* platform/chromium-mac/fast/inline/continuation-outlines-expected.png:
* platform/chromium-mac/fast/inline/continuation-outlines-with-layers-2-expected.png:
* platform/chromium-mac/fast/inline/continuation-outlines-with-layers-expected.png:
* platform/chromium-mac/fast/inline/inline-focus-ring-expected.png:
* platform/chromium-mac/fast/overflow/overflow-focus-ring-expected.png:
* platform/chromium-mac/fast/repaint/focus-layers-expected.png:
* platform/chromium-mac/fast/repaint/focus-ring-expected.png:
* platform/chromium-mac/fast/text/delete-hard-break-character-expected.png:
* platform/chromium-mac/fast/text/international/rtl-caret-expected.png:
* platform/chromium-mac/fast/transforms/transformed-caret-expected.png:
* platform/chromium-mac/svg/custom/focus-ring-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-10-21 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Fri, 21 Oct 2011 12:43:45 +0000 (12:43 +0000)]
2011-10-21  Alejandro G. Castro  <alex@igalia.com>

        [cairo] Forward declaration of GraphicsContextState uses class instead of struct
        https://bugs.webkit.org/show_bug.cgi?id=70522

        The type is a struct not a class, replace the definition in the
        forward declaration.

        Reviewed by Martin Robinson.

        * platform/graphics/cairo/PlatformContextCairo.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Web Inspector: remove debugger support for out-of-process dedicated workers
yurys@chromium.org [Fri, 21 Oct 2011 12:39:08 +0000 (12:39 +0000)]
[Chromium] Web Inspector: remove debugger support for out-of-process dedicated workers
https://bugs.webkit.org/show_bug.cgi?id=70602

Now that Chromium uses in-process dedicated workers, remove support for out-of-process
dedicated workers debugger.

Reviewed by Pavel Feldman.

* public/WebWorker.h:
* src/WebWorkerClientImpl.cpp:
(WebKit::WebWorkerClientImpl::connectToInspector):
(WebKit::WebWorkerClientImpl::disconnectFromInspector):
(WebKit::WebWorkerClientImpl::WebWorkerClientImpl):
* src/WebWorkerClientImpl.h:
* src/WebWorkerImpl.cpp:
* src/WebWorkerImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] fast/events/touch/page-scaled-touch-gesture-click.html is failing
zoltan@webkit.org [Fri, 21 Oct 2011 12:02:58 +0000 (12:02 +0000)]
[Qt] fast/events/touch/page-scaled-touch-gesture-click.html is failing
https://bugs.webkit.org/show_bug.cgi?id=70593

It was introduced in r97988. Skip it.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove QtScript source code from WebKit.
hausmann@webkit.org [Fri, 21 Oct 2011 10:26:05 +0000 (10:26 +0000)]
Remove QtScript source code from WebKit.
https://bugs.webkit.org/show_bug.cgi?id=64088

Reviewed by Tor Arne Vestbø.

Removed dead code that isn't developed anymore.

.:

* Source/WebKit.pro:

Source/JavaScriptCore:

* JavaScriptCore.gypi:
* JavaScriptCore.pri:
* qt/api/QtScript.pro: Removed.
* qt/api/qscriptconverter_p.h: Removed.
* qt/api/qscriptengine.cpp: Removed.
* qt/api/qscriptengine.h: Removed.
* qt/api/qscriptengine_p.cpp: Removed.
* qt/api/qscriptengine_p.h: Removed.
* qt/api/qscriptfunction.cpp: Removed.
* qt/api/qscriptfunction_p.h: Removed.
* qt/api/qscriptoriginalglobalobject_p.h: Removed.
* qt/api/qscriptprogram.cpp: Removed.
* qt/api/qscriptprogram.h: Removed.
* qt/api/qscriptprogram_p.h: Removed.
* qt/api/qscriptstring.cpp: Removed.
* qt/api/qscriptstring.h: Removed.
* qt/api/qscriptstring_p.h: Removed.
* qt/api/qscriptsyntaxcheckresult.cpp: Removed.
* qt/api/qscriptsyntaxcheckresult.h: Removed.
* qt/api/qscriptsyntaxcheckresult_p.h: Removed.
* qt/api/qscriptvalue.cpp: Removed.
* qt/api/qscriptvalue.h: Removed.
* qt/api/qscriptvalue_p.h: Removed.
* qt/api/qscriptvalueiterator.cpp: Removed.
* qt/api/qscriptvalueiterator.h: Removed.
* qt/api/qscriptvalueiterator_p.h: Removed.
* qt/api/qtscriptglobal.h: Removed.
* qt/benchmarks/benchmarks.pri: Removed.
* qt/benchmarks/benchmarks.pro: Removed.
* qt/benchmarks/qscriptengine/qscriptengine.pro: Removed.
* qt/benchmarks/qscriptengine/tst_qscriptengine.cpp: Removed.
* qt/benchmarks/qscriptvalue/qscriptvalue.pro: Removed.
* qt/benchmarks/qscriptvalue/tst_qscriptvalue.cpp: Removed.
* qt/tests/qscriptengine/qscriptengine.pro: Removed.
* qt/tests/qscriptengine/tst_qscriptengine.cpp: Removed.
* qt/tests/qscriptstring/qscriptstring.pro: Removed.
* qt/tests/qscriptstring/tst_qscriptstring.cpp: Removed.
* qt/tests/qscriptvalue/qscriptvalue.pro: Removed.
* qt/tests/qscriptvalue/tst_qscriptvalue.cpp: Removed.
* qt/tests/qscriptvalue/tst_qscriptvalue.h: Removed.
* qt/tests/qscriptvalue/tst_qscriptvalue_generated_comparison.cpp: Removed.
* qt/tests/qscriptvalue/tst_qscriptvalue_generated_init.cpp: Removed.
* qt/tests/qscriptvalue/tst_qscriptvalue_generated_istype.cpp: Removed.
* qt/tests/qscriptvalue/tst_qscriptvalue_generated_totype.cpp: Removed.
* qt/tests/qscriptvalueiterator/qscriptvalueiterator.pro: Removed.
* qt/tests/qscriptvalueiterator/tst_qscriptvalueiterator.cpp: Removed.
* qt/tests/tests.pri: Removed.
* qt/tests/tests.pro: Removed.

Tools:

* Scripts/webkitpy/style/checker_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt][WK2] Typo fix.
ossy@webkit.org [Fri, 21 Oct 2011 09:15:26 +0000 (09:15 +0000)]
[Qt][WK2] Typo fix.

* tests/util.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agobytecompiler sometimes generates incorrect bytecode for put_by_id
commit-queue@webkit.org [Fri, 21 Oct 2011 09:11:26 +0000 (09:11 +0000)]
bytecompiler sometimes generates incorrect bytecode for put_by_id
https://bugs.webkit.org/show_bug.cgi?id=70403

Patch by Zheng Liu <zheng.z.liu@intel.com> on 2011-10-21
Reviewed by Filip Pizlo.

* bytecompiler/NodesCodegen.cpp:
(JSC::AssignDotNode::emitBytecode):
(JSC::AssignBracketNode::emitBytecode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt][WK2] Buildfix for newer Qt5. Remove duplicated defines.
ossy@webkit.org [Fri, 21 Oct 2011 09:08:48 +0000 (09:08 +0000)]
[Qt][WK2] Buildfix for newer Qt5. Remove duplicated defines.

Reviewed by Simon Hausmann.

Source/WebKit/qt:

* tests/util.h:

Source/WebKit2:

* UIProcess/API/qt/tests/util.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98090 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-10-21 Carlos Garcia Campos <cgarcia@igalia.com>
carlosgc@webkit.org [Fri, 21 Oct 2011 09:00:56 +0000 (09:00 +0000)]
2011-10-21  Carlos Garcia Campos  <cgarcia@igalia.com>

        Unreviewed. Fix WebKit2 GTK+ build after r98081.

        * UIProcess/API/gtk/WebKitWebView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r98085.
commit-queue@webkit.org [Fri, 21 Oct 2011 08:55:00 +0000 (08:55 +0000)]
Unreviewed, rolling out r98085.
http://trac.webkit.org/changeset/98085
https://bugs.webkit.org/show_bug.cgi?id=70589

It broke the build (Requested by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-21

Source/WebKit/qt:

* tests/util.h:

Source/WebKit2:

* UIProcess/API/qt/tests/util.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] 2 inspector/extensions tests times out on Mac and linux after r97850
caseq@chromium.org [Fri, 21 Oct 2011 08:49:35 +0000 (08:49 +0000)]
[Qt] 2 inspector/extensions tests times out on Mac and linux after r97850
https://bugs.webkit.org/show_bug.cgi?id=70414

Unreviewed. Skipped inspector/extensions/extensions-{events,network}.html

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[GTK] Fix API documentation comment for webkit_web_view_get_estimated_load_progress()
carlosgc@webkit.org [Fri, 21 Oct 2011 08:44:49 +0000 (08:44 +0000)]
[GTK] Fix API documentation comment for webkit_web_view_get_estimated_load_progress()
https://bugs.webkit.org/show_bug.cgi?id=70587

Reviewed by Philippe Normand.

It's should start with /** to be recognized as API documentation.

* UIProcess/API/gtk/WebKitWebView.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt][WK2] Unreviewed buildfix for newer Qt5. Remove duplicated defines.
ossy@webkit.org [Fri, 21 Oct 2011 08:40:06 +0000 (08:40 +0000)]
[Qt][WK2] Unreviewed buildfix for newer Qt5. Remove duplicated defines.

Source/WebKit/qt:

* tests/util.h:
(waitForSignal):

Source/WebKit2:

* UIProcess/API/qt/tests/util.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[EFL] ewk_view_mode_get uses dedicated macros instead of standard NULL checking.
commit-queue@webkit.org [Fri, 21 Oct 2011 08:32:01 +0000 (08:32 +0000)]
[EFL] ewk_view_mode_get uses dedicated macros instead of standard NULL checking.
https://bugs.webkit.org/show_bug.cgi?id=65680

Patch by Grzegorz Czajkowski <g.czajkowski@samsung.com> on 2011-10-21
Reviewed by Ryosuke Niwa.

Generally API methods using macros NULL checking in WebKit-EFL.
The macros ensure that code is smaller, version of view object
is checked and error message is displayed if NULL is passed.

* ewk/ewk_view.cpp:
(ewk_view_mode_get):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98084 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd tests to check behavior of border attribute with a large number or an invalid...
tkent@chromium.org [Fri, 21 Oct 2011 08:24:08 +0000 (08:24 +0000)]
Add tests to check behavior of border attribute with a large number or an invalid value.
https://bugs.webkit.org/show_bug.cgi?id=69055

Reviewed by Daniel Bates.

r96290 changed the behavior of integer parsing so that large
number strings which can not be represented in 32 bit integers
makes an error. However, border attribute behavior wasn't changed
by r96290 because its default value is 0 and
parseHTMLNonNegativeInteger() had set 0 in a case of overflow.

* fast/dom/HTMLImageElement/image-with-invalid-border-expected.html: Added.
* fast/dom/HTMLImageElement/image-with-invalid-border.html: Added.
* fast/dom/HTMLInputElement/input-with-invalid-border-expected.html: Added.
* fast/dom/HTMLInputElement/input-with-invalid-border.html: Added.
* fast/dom/HTMLObjectElement/object-with-invalid-border-expected.html: Added.
* fast/dom/HTMLObjectElement/object-with-invalid-border.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDFG should not try to predict argument types by looking at the values of
fpizlo@apple.com [Fri, 21 Oct 2011 08:19:03 +0000 (08:19 +0000)]
DFG should not try to predict argument types by looking at the values of
argument registers at the time of compilation
https://bugs.webkit.org/show_bug.cgi?id=70578

Reviewed by Oliver Hunt.

* bytecode/CodeBlock.cpp:
* dfg/DFGDriver.cpp:
(JSC::DFG::compile):
(JSC::DFG::tryCompile):
(JSC::DFG::tryCompileFunction):
* dfg/DFGDriver.h:
(JSC::DFG::tryCompileFunction):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::predictArgumentTypes):
* dfg/DFGGraph.h:
* runtime/Executable.cpp:
(JSC::FunctionExecutable::compileOptimizedForCall):
(JSC::FunctionExecutable::compileOptimizedForConstruct):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):
* runtime/Executable.h:
(JSC::FunctionExecutable::compileForCall):
(JSC::FunctionExecutable::compileForConstruct):
(JSC::FunctionExecutable::compileFor):
(JSC::FunctionExecutable::compileOptimizedFor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[GTK] Add can_go_back/forward methods to WebKit2 GTK+ API
carlosgc@webkit.org [Fri, 21 Oct 2011 08:17:03 +0000 (08:17 +0000)]
[GTK] Add can_go_back/forward methods to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=69823

Reviewed by Martin Robinson.

* UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_go_back):
(webkit_web_view_can_go_back):
(webkit_web_view_go_forward):
(webkit_web_view_can_go_forward):
* UIProcess/API/gtk/WebKitWebView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[GTK] Add webkit_web_view_stop_loading() to WebKit2 GTK+ API
carlosgc@webkit.org [Fri, 21 Oct 2011 08:09:05 +0000 (08:09 +0000)]
[GTK] Add webkit_web_view_stop_loading() to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=69610

Reviewed by Martin Robinson.

* UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_stop_loading):
* UIProcess/API/gtk/WebKitWebView.h:
* UIProcess/API/gtk/tests/LoadTrackingTest.cpp:
(provisionalLoadFailedCallback):
(loadFailedCallback):
* UIProcess/API/gtk/tests/TestWebKitWebLoaderClient.cpp:
(LoadStopTrackingTest::loadCommitted):
(LoadStopTrackingTest::loadFailed):
(LoadStopTrackingTest::loadFinished):
(testLoadCancelled):
(serverCallback):
(beforeAll):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: make extension tests pass on chromium
caseq@chromium.org [Fri, 21 Oct 2011 07:51:42 +0000 (07:51 +0000)]
Web Inspector: make extension tests pass on chromium
https://bugs.webkit.org/show_bug.cgi?id=70334

Reviewed by Pavel Feldman.

LayoutTests:

* http/tests/inspector/extensions-headers.html:
* http/tests/inspector/resources/extension-main.js:
():
* inspector/extensions/extensions-audits.html:
* inspector/extensions/extensions-console.html:
* inspector/extensions/extensions-resources.html:
* platform/chromium/inspector/extensions/extensions-api-expected.txt: Added.
* platform/chromium/inspector/extensions/extensions-eval-expected.txt: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] FontCache::createFontPlatformData() is broken, a default font is returned
ossy@webkit.org [Fri, 21 Oct 2011 07:19:31 +0000 (07:19 +0000)]
[Qt] FontCache::createFontPlatformData() is broken, a default font is returned
even if the family does not match.
https://bugs.webkit.org/show_bug.cgi?id=55036

Unreviewed. Update tests after r97990, and unskip them. (part 6)

* platform/qt/tables/: [...]
* platform/qt/transforms/: [...]
* platform/qt/transitions/: [...]
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Test expectation change: fast/canvas/webgl/WebGLContextEvent.html now...
yuzo@google.com [Fri, 21 Oct 2011 07:07:50 +0000 (07:07 +0000)]
[chromium] Test expectation change: fast/canvas/webgl/WebGLContextEvent.html now passes.

Unreviewed. The test passes since http://trac.webkit.org/changeset/98044/

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoThese tests are skipped so there's no need to say they TIMEOUT.
abarth@webkit.org [Fri, 21 Oct 2011 06:56:38 +0000 (06:56 +0000)]
These tests are skipped so there's no need to say they TIMEOUT.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd a test to check behavior of tabindex attribute with a large number
tkent@chromium.org [Fri, 21 Oct 2011 06:52:25 +0000 (06:52 +0000)]
Add a test to check behavior of tabindex attribute with a large number
https://bugs.webkit.org/show_bug.cgi?id=69056

Reviewed by Daniel Bates.

r96290 changed the behavior of integer parsing so that large
number strings which can not be represented in 32 bit integers
makes an error. Before r96290, we had assumed such large numbers
are equivelent to 0. We assume them invalid values.

* fast/dom/tabindex-defaults-expected.txt: Added.
* fast/dom/tabindex-defaults.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSwitch webkit2 bot to NRWT
eric@webkit.org [Fri, 21 Oct 2011 06:49:08 +0000 (06:49 +0000)]
Switch webkit2 bot to NRWT
https://bugs.webkit.org/show_bug.cgi?id=56729

Reviewed by Adam Barth.

Move the WK2 bot to using NRWT instead of ORWT, as announced on webkit-dev:
https://lists.webkit.org/pipermail/webkit-dev/2011-October/018337.html

* Scripts/run-webkit-tests:
(runningOnBuildBot):
(useNewRunWebKitTests):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Update test expectation for inspector/debugger/{linkifier,script-formatter...
yuzo@google.com [Fri, 21 Oct 2011 06:47:05 +0000 (06:47 +0000)]
[chromium] Update test expectation for inspector/debugger/{linkifier,script-formatter}.html

Unreviewed.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] FontCache::createFontPlatformData() is broken, a default font is returned
ossy@webkit.org [Fri, 21 Oct 2011 06:42:21 +0000 (06:42 +0000)]
[Qt] FontCache::createFontPlatformData() is broken, a default font is returned
even if the family does not match.
https://bugs.webkit.org/show_bug.cgi?id=55036

Unreviewed. Update tests after r97990, and unskip them. (part 5)

* platform/qt/svg/: [...]
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNRWT is asserting on DRT due to lack of newline when processing line from DumpRenderTree
eric@webkit.org [Fri, 21 Oct 2011 06:30:01 +0000 (06:30 +0000)]
NRWT is asserting on DRT due to lack of newline when processing line from DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=70585

Reviewed by Adam Barth.

This really should be an assert, as this inidicates a programming error in either DRT or NRWT.
However since DRT was functioning fine before in Qt, we'll make this an error log for now
and once we find the root cause flip this back to an assert.

* Scripts/webkitpy/layout_tests/port/webkit.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Rolled DEPS.
commit-queue@webkit.org [Fri, 21 Oct 2011 06:28:53 +0000 (06:28 +0000)]
Unreviewed.  Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-20

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: reimplement protocol backend/frontend source generator
loislo@chromium.org [Fri, 21 Oct 2011 06:00:34 +0000 (06:00 +0000)]
Web Inspector: reimplement protocol backend/frontend source generator
https://bugs.webkit.org/show_bug.cgi?id=69295

Patch by Peter Rybin <peter.rybin@gmail.com> on 2011-10-20
Reviewed by Pavel Feldman.

Old 2-stage python+perf generator that uses intermediate IDL output is
being replaced with a solid python script. This is for simplicity and
as a base for the future JSON validator.

* CMakeLists.txt:
* CodeGenerators.pri:
* DerivedSources.make:
* GNUmakefile.am:
* WebCore.gyp/WebCore.gyp:
* inspector/CodeGeneratorInspector.pm: Removed.
* inspector/CodeGeneratorInspector.py: Added.
* inspector/Inspector.json:
* inspector/generate-inspector-idl: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r98064.
yutak@chromium.org [Fri, 21 Oct 2011 05:48:54 +0000 (05:48 +0000)]
Unreviewed, rolling out r98064.
http://trac.webkit.org/changeset/98064
https://bugs.webkit.org/show_bug.cgi?id=64788

Broke Mac bots.

* Scripts/webkitpy/layout_tests/servers/websocket_server.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAttemp to fix a bunch of tests PLATFORM(MAC). We can't use a static
abarth@webkit.org [Fri, 21 Oct 2011 05:43:00 +0000 (05:43 +0000)]
Attemp to fix a bunch of tests PLATFORM(MAC).  We can't use a static
map because that's shared between threads (and events exist in worker
threads).  It migh be better to add a thread-specific map, but we can
do that in another patch.

* bindings/js/JSEventCustom.cpp:
(WebCore::toJS):
* bindings/v8/custom/V8EventCustom.cpp:
(WebCore::toV8):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDFG call optimization handling will fail if the call had been unlinked due
fpizlo@apple.com [Fri, 21 Oct 2011 05:14:06 +0000 (05:14 +0000)]
DFG call optimization handling will fail if the call had been unlinked due
to the callee being optimized
https://bugs.webkit.org/show_bug.cgi?id=70468

Reviewed by Geoff Garen.

If a call had ever been linked, we remember this fact as well as the function
to which it was linked even if unlinkIncomingCalls() or unlinkCalls() are
called.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::visitAggregate):
* bytecode/CodeBlock.h:
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGRepatch.cpp:
(JSC::DFG::dfgLinkFor):
* jit/JIT.cpp:
(JSC::JIT::linkFor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebSocket: Connecting to localhost:8880 takes one second on Windows
yutak@chromium.org [Fri, 21 Oct 2011 04:14:10 +0000 (04:14 +0000)]
WebSocket: Connecting to localhost:8880 takes one second on Windows
https://bugs.webkit.org/show_bug.cgi?id=64788

Reviewed by Dirk Pranke.

* Scripts/webkitpy/layout_tests/servers/websocket_server.py:
Bind to "localhost" instead of "127.0.0.1" to let pywebsocket listen on both
IPv4 and IPv6 addresses. This should prevent the test reserved-opcodes.html
from timing out on Windows, because this test tries to open a lot of
connections to localhost and each attempt takes one second to fall back from
IPv6 to IPv4 on Windows (I have no idea why Windows works like this, though).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDFG JIT 32_64 - Fix ByteArray speculation
commit-queue@webkit.org [Fri, 21 Oct 2011 04:01:28 +0000 (04:01 +0000)]
DFG JIT 32_64 - Fix ByteArray speculation
https://bugs.webkit.org/show_bug.cgi?id=70571

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-10-20
Reviewed by Filip Pizlo.

* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::ValueSource::forPrediction):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agonrwt: newly generated results are put in cross-platform directory
rniwa@webkit.org [Fri, 21 Oct 2011 03:35:50 +0000 (03:35 +0000)]
nrwt: newly generated results are put in cross-platform directory
https://bugs.webkit.org/show_bug.cgi?id=68931

Reviewed by Dirk Pranke.

The bug was caused by SingleTestRunner._add_missing_baselines's always calling _save_baseline_data
with generate_new_baseline set to False. Fixed the bug by always passing True when .png file is missing
(because png images are typically different on each platform), and passing True when .txt file is missing
and the actual result's first line matches the regular expression "layer at \(\d+,\d+\) size \d+x\d+".

* Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
* Scripts/webkitpy/layout_tests/port/test.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py: Changed the expectation
and added a test case.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Adding myself to watchlist.
tkent@chromium.org [Fri, 21 Oct 2011 03:29:25 +0000 (03:29 +0000)]
Unreviewed. Adding myself to watchlist.

* Scripts/webkitpy/common/config/watchlist:
Add "ChromiumDumpRenderTree" and "Forms" definitions, and cc them to me.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@98061 268f45cc-cd09-0410-ab3c-d52691b4dbfc