antti [Fri, 29 Jun 2007 08:18:35 +0000 (08:18 +0000)]
Reviewed by Maciej.
Added WKQTMovieDataRate and WKQTMovieMaxTimeLoaded
* WebKitSystemInterface.h:
* libWebKitSystemInterface.a:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23869
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Fri, 29 Jun 2007 05:49:36 +0000 (05:49 +0000)]
Get WebCore compiling with /W2 on Windows
Reviewed by Steve.
No regression tests affected.
* WebCore.vcproj/WebCore.vcproj: Turn the warning level up to 2, and
disable two warnings: implicit int <=> float conversion, and class vs.
struct inconsistency.
* dom/CharacterData.cpp:
(WebCore::CharacterData::deleteData): Cast to int before negating.
* loader/Cache.cpp:
(WebCore::Cache::remove): Ditto.
* platform/graphics/Path.cpp:
(WebCore::pathLengthApplierFunction): Consistently use floats.
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::drawEllipse): Ditto.
* platform/win/GraphicsContextWin.cpp:
(WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23868
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Fri, 29 Jun 2007 04:16:57 +0000 (04:16 +0000)]
Reviewed by Maciej Stachowiak.
Fixed <rdar://problem/
5299005> DOM timers fire without a local autorelease
pool => pathologically high high water mark
I couldn't measure any performance problems with iBench HTML or PLT.
* WebCore.xcodeproj/project.pbxproj: Changed .cpp file to be ObjC++.
* platform/mac/SharedTimerMac.cpp:
(WebCore::timerFired): Added autorelease pool.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23867
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Fri, 29 Jun 2007 02:46:23 +0000 (02:46 +0000)]
LayoutTests:
Reviewed by Beth.
- test for http://bugs.webkit.org/show_bug.cgi?id=14118
ASSERTION FAILED: !needsLayout() seen again
* fast/dynamic/recursive-layout-expected.txt: Added.
* fast/dynamic/recursive-layout.html: Added.
WebCore:
Reviewed by Beth.
- fix http://bugs.webkit.org/show_bug.cgi?id=14118
ASSERTION FAILED: !needsLayout() seen again
Test: fast/dynamic/recursive-layout.html
* page/FrameView.cpp:
(WebCore::FrameView::layout): Removed the midLayout guards around
the calls to invalidateSelection() and updateWidgetPositions(). Those
calls may dirty the layout, but in that case they also update it, so
they should be allowed to do it. Added an ASSERT to make sure that when
they return, the root is not marked for layout.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23866
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
slewis [Fri, 29 Jun 2007 01:05:20 +0000 (01:05 +0000)]
Reviewed by Adam,
Allow tests to use pre-built roots instead of building the tests.
* Scripts/run-javascriptcore-tests: added --root option
* Scripts/run-webkit-tests: added --root option
* Scripts/webkitdirs.pm: added support for using a root
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23865
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Fri, 29 Jun 2007 00:06:27 +0000 (00:06 +0000)]
Reviewed by Darin.
<rdar://problem/
5287569> WEBVIEW: Creating a webview in IB 3.0 (v2.0) NIB later crashes Interface Builder 2.5.4 on Tiger
Prevent encoding any of the WebView subviews. The subviews are ignored by -[WebView initWithCoder:] and will be recreated.
The Tiger 2.0 code crashed when the WebView released the subviews in initWithCoder:, so now there are no subviews to release.
This never happened before because the Tiger 2.0 code and IB wouldn't encode a WebView that has a WebHTMLView.
* WebView/WebView.mm:
(-[WebView encodeWithCoder:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23864
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Thu, 28 Jun 2007 23:02:18 +0000 (23:02 +0000)]
LayoutTests:
Rubberstamped by Adam Roben.
Roll out r23861. It caused the buildbot to fail on intel.
* http/tests/navigation/goBack-blank-tab-page-expected.txt: Removed.
* http/tests/navigation/goBack-blank-tab-page.html: Removed.
* http/tests/navigation/resources/before-go-back.html: Removed.
* http/tests/navigation/resources/will-go-back.html: Removed.
WebCore:
Rubberstamped by Adam Roben.
Roll out r23861. It caused the buildbot to fail on intel.
* page/Page.cpp:
(WebCore::Page::goToItem):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23863
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Thu, 28 Jun 2007 21:08:16 +0000 (21:08 +0000)]
LayoutTests:
Reviewed by Geoff.
Tests for http://bugs.webkit.org/show_bug.cgi?id=13038
ASSERTION FAILED: item->target().isEmpty() || m_mainFrame->tree()->find(item->target()) == m_mainFrame
Although the test works with the script, it can't detect an eventually
error automatically since the first link must be opened in a new tab with
a _blank target to reproduce the crash. So it should be launched manually
following the steps decribed in there, then it's effective.
* http/tests/navigation/goBack-blank-tab-page-expected.txt: Added.
* http/tests/navigation/goBack-blank-tab-page.html: Added.
* http/tests/navigation/resources/before-go-back.html: Added.
* http/tests/navigation/resources/will-go-back.html: Added.
WebCore:
Reviewed by Geoff.
Patch for http://bugs.webkit.org/show_bug.cgi?id=13038
ASSERTION FAILED: item->target().isEmpty() || m_mainFrame->tree()->find(item->target()) == m_mainFrame
Modification of an ASSERT on goToItem related to go back/forward in
history.Don't need to check the frameset if the target is _blank.
* page/Page.cpp:
(WebCore::Page::goToItem):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23861
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Thu, 28 Jun 2007 20:16:54 +0000 (20:16 +0000)]
Tabs are bad
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23860
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Thu, 28 Jun 2007 20:13:50 +0000 (20:13 +0000)]
Remove tests that don't need to be skipped anymore.
* win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23859
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Thu, 28 Jun 2007 19:46:14 +0000 (19:46 +0000)]
Reviewed by Oliver.
<rdar://problem/
5234139>
<object> with PNG src rendered as image document.
Complete the URL before passing it to the frame loader client.
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::isImageType):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23857
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis [Thu, 28 Jun 2007 16:59:36 +0000 (16:59 +0000)]
Forgot committing this change in my previous commit.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23855
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis [Thu, 28 Jun 2007 16:00:29 +0000 (16:00 +0000)]
Reviewed by Maciej.
http://bugs.webkit.org/show_bug.cgi?id=14373
CSS1: selectors (classes and IDs) cannot start with a dash or with a digit
Make sure the id selector validates against the CSS2.1 identfier
definition, not the hexcolor/HASH definition.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23854
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann [Thu, 28 Jun 2007 14:44:27 +0000 (14:44 +0000)]
Propagate mouse double click events from Qt to WebCore.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23853
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann [Thu, 28 Jun 2007 14:16:42 +0000 (14:16 +0000)]
Implemented clipboard functions in QWebPage, in particular can(Cut|Copy|Paste), cut/copy/paste as slot as well as a selectionChanged() signal.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23852
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann [Thu, 28 Jun 2007 14:16:31 +0000 (14:16 +0000)]
Implemented PasteboardQt::writeSelection to copy the selected text into the Clipboard as well as PasteboardQt::plainText to retrieve plain text from the clipboard for pasting for example into form fields.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23851
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti [Thu, 28 Jun 2007 13:54:25 +0000 (13:54 +0000)]
LayoutTests:
Reviewed by Mitz.
Test changes for http://bugs.webkit.org/show_bug.cgi?id=14332
Bug 14332: REGRESSION (r21145): <td> width ignored
<rdar://problem/
5290123>
- expand empty-cells.html to cover non-zero cellpadding case too
- update other related tests (none of these affect pixel results)
* fast/css/acid2-expected.txt:
* fast/css/acid2-pixel-expected.txt:
* fast/table/032-expected.txt:
* fast/table/empty-cells-expected.checksum:
* fast/table/empty-cells-expected.png:
* fast/table/empty-cells-expected.txt:
* fast/table/empty-cells.html:
* fast/table/empty-section-crash-expected.txt:
* http/tests/misc/acid2-expected.txt:
* http/tests/misc/acid2-pixel-expected.txt:
* tables/mozilla/bugs/bug222467-expected.txt:
* tables/mozilla/bugs/bug78162-expected.txt:
WebCore:
Reviewed by Mitz.
Fix http://bugs.webkit.org/show_bug.cgi?id=14332
Bug 14332: REGRESSION (r21145): <td> width ignored
<rdar://problem/
5290123>
Cells in table with non-zero cellpadding are not considered empty.
* rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::recalcColumn):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23850
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Thu, 28 Jun 2007 07:48:16 +0000 (07:48 +0000)]
Fix <rdar://problem/
5300455> Prefast: typo in RenderBlock::paintObject
Reviewed by Hyatt.
No layout test possible, as this bug didn't have any effect since
"bool & bool" has the same value as "bool && bool"
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintObject): Changed & to &&.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23848
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Thu, 28 Jun 2007 07:30:39 +0000 (07:30 +0000)]
Fix <rdar://problem/
5300443> word-break and -webkit-user-modify allow any value
WebCore:
Fix <rdar://problem/
5300443> word-break and -webkit-user-modify allow any value
The bug was caused by two typos found by prefast.
Reviewed by Hyatt.
* css/cssparser.cpp:
(WebCore::CSSParser::parseValue): Fixed typos.
LayoutTests:
New test for <rdar://problem/
5300443> word-break and -webkit-user-modify allow any value
Reviewed by Hyatt.
* fast/css/word-break-user-modify-allowed-values-expected.txt: Added.
* fast/css/word-break-user-modify-allowed-values.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23847
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kmccullo [Thu, 28 Jun 2007 06:53:45 +0000 (06:53 +0000)]
JavaScriptCore:
Reviewed by Darin.
- <rdar://problem/
5271937> REGRESSION: Apparent WebKit JavaScript memory smasher when submitting comment to iWeb site (crashes in kjs_pcre_compile2)
- Correctly evaluate the return value of _pcre_ucp_findchar.
* pcre/pcre_compile.c:
(compile_branch):
* pcre/pcre_exec.c:
(match):
LayoutTests:
Reviewed by Darin.
- <rdar://problem/
5271937> REGRESSION: Apparent WebKit JavaScript memory smasher when submitting comment to iWeb site (crashes in kjs_pcre_compile2)
- Correctly evaluate the return value of _pcre_ucp_findchar.
* fast/js/regexp-unicode-overflow-expected.txt: Added.
* fast/js/regexp-unicode-overflow.html: Added.
* fast/js/resources/regexp-unicode-overflow.js: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23846
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Thu, 28 Jun 2007 06:18:24 +0000 (06:18 +0000)]
2007-06-20 Matt Perry <mpComplete@gmail.com>
Reviewed by Adam.
- Fix http://bugs.webkit.org/show_bug.cgi?id=14251:
onchange handler for select controls doesn't fire when changing via keyboard
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::menuListDefaultEventHandler): Got rid of
a call to saveLastSelection in the "Enter" key handler for select
controls that was preventing onchange from firing.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23845
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Thu, 28 Jun 2007 06:01:41 +0000 (06:01 +0000)]
Yet another build fix :(
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23844
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Thu, 28 Jun 2007 05:32:45 +0000 (05:32 +0000)]
Fix Gdk, Qt, and Win32 builds.
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23843
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Thu, 28 Jun 2007 05:25:59 +0000 (05:25 +0000)]
LayoutTests:
Reviewed by Geoff.
Update tests for http://bugs.webkit.org/show_bug.cgi?id=14319
Move the Selection object out of the JS bindings
* fast/dom/Window/window-properties-expected.txt:
* fast/js/toString-and-valueOf-override-expected.txt:
* http/tests/security/cross-frame-access-expected.txt:
WebCore:
Reviewed by Geoff.
Patch for http://bugs.webkit.org/show_bug.cgi?id=14319
Move the Selection object out of the JS bindings
- Renames JS Object Selection to DOMSelection to avoid a name
conflict.
* DerivedSources.make:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/kjs_window.cpp:
(KJS::WindowPrivate::WindowPrivate):
(KJS::Window::mark):
(KJS::Window::clearHelperObjectProperties):
(KJS::WindowFunc::callAsFunction):
(KJS::Window::disconnectFrame):
* bindings/js/kjs_window.h:
(KJS::Window::):
* page/DOMSelection.cpp: Added.
(WebCore::DOMSelection::DOMSelection):
(WebCore::DOMSelection::frame):
(WebCore::DOMSelection::disconnectFrame):
(WebCore::DOMSelection::anchorNode):
(WebCore::DOMSelection::baseNode):
(WebCore::DOMSelection::anchorOffset):
(WebCore::DOMSelection::baseOffset):
(WebCore::DOMSelection::focusNode):
(WebCore::DOMSelection::extentNode):
(WebCore::DOMSelection::focusOffset):
(WebCore::DOMSelection::extentOffset):
(WebCore::DOMSelection::isCollapsed):
(WebCore::DOMSelection::type):
(WebCore::DOMSelection::rangeCount):
(WebCore::DOMSelection::collapse):
(WebCore::DOMSelection::collapseToEnd):
(WebCore::DOMSelection::collapseToStart):
(WebCore::DOMSelection::empty):
(WebCore::DOMSelection::setBaseAndExtent):
(WebCore::DOMSelection::setPosition):
(WebCore::DOMSelection::modify):
(WebCore::DOMSelection::getRangeAt):
(WebCore::DOMSelection::removeAllRanges):
(WebCore::DOMSelection::addRange):
(WebCore::DOMSelection::toString):
* page/DOMSelection.h: Added.
* page/DOMSelection.idl: Added.
* page/DOMWindow.cpp:
(WebCore::DOMWindow::disconnectFrame):
(WebCore::DOMWindow::getSelection):
* page/DOMWindow.h:
* page/DOMWindow.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23842
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Thu, 28 Jun 2007 03:34:49 +0000 (03:34 +0000)]
Reviewed by Maciej.
2nd patch for http://bugs.webkit.org/show_bug.cgi?id=14111
Autogenerate Event JS binding
- Cleanup kjs_events
* bindings/js/kjs_events.cpp:
(WebCore::JSAbstractEventListener::JSAbstractEventListener):
(WebCore::JSAbstractEventListener::handleEvent):
(WebCore::JSAbstractEventListener::isHTMLEventListener):
(WebCore::JSUnprotectedEventListener::JSUnprotectedEventListener):
(WebCore::JSUnprotectedEventListener::~JSUnprotectedEventListener):
(WebCore::JSUnprotectedEventListener::listenerObj):
(WebCore::JSUnprotectedEventListener::windowObj):
(WebCore::JSUnprotectedEventListener::clearWindowObj):
(WebCore::JSUnprotectedEventListener::mark):
(WebCore::JSEventListener::JSEventListener):
(WebCore::JSEventListener::~JSEventListener):
(WebCore::JSEventListener::listenerObj):
(WebCore::JSEventListener::windowObj):
(WebCore::JSEventListener::clearWindowObj):
(WebCore::JSLazyEventListener::JSLazyEventListener):
(WebCore::JSLazyEventListener::listenerObj):
(WebCore::JSLazyEventListener::parseCode):
(WebCore::getNodeEventListener):
(WebCore::JSClipboard::JSClipboard):
(WebCore::JSClipboard::getValueProperty):
(WebCore::JSClipboard::putValueProperty):
(WebCore::JSClipboardPrototypeFunction::callAsFunction):
(WebCore::toJS):
(WebCore::toClipboard):
* bindings/js/kjs_events.h:
(WebCore::JSClipboard::classInfo):
(WebCore::JSClipboard::impl):
* bindings/js/kjs_window.h:
* ksvg2/events/JSSVGLazyEventListener.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23841
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Thu, 28 Jun 2007 03:19:46 +0000 (03:19 +0000)]
LayoutTests:
Reviewed by Adam Roben.
Tests for http://bugs.webkit.org/show_bug.cgi?id=12045
Crash under gmalloc at WTF::RefPtr<WebCore::HTMLSliderThumbElement>::operator->
<rdar://problem/
5286670>
* fast/forms/thumbslider-crash-expected.checksum: Added.
* fast/forms/thumbslider-crash-expected.png: Added.
* fast/forms/thumbslider-crash-expected.txt: Added.
* fast/forms/thumbslider-crash.html: Added.
* fast/forms/thumbslider-no-parent-slider-expected.checksum: Added.
* fast/forms/thumbslider-no-parent-slider-expected.png: Added.
* fast/forms/thumbslider-no-parent-slider-expected.txt: Added.
* fast/forms/thumbslider-no-parent-slider.html: Added.
WebCore:
Reviewed by Adam Roben.
Patch for http://bugs.webkit.org/show_bug.cgi?id=12045
Crash under gmalloc at WTF::RefPtr<WebCore::HTMLSliderThumbElement>::operator->
<rdar://problem/
5286670>
Test: fast/forms/thumbslider-no-parent-slider.html
Test: fast/forms/thumbslider-crash.html
* rendering/RenderObject.h:
(WebCore::RenderObject::isSlider):
* rendering/RenderSlider.h:
(WebCore::RenderSlider::isSlider):
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::paint): Only paint thumbslider
if the parent renderer is a RenderSlider.
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintSliderThumb):
* rendering/RenderThemeSafari.cpp:
(WebCore::RenderThemeSafari::paintSliderThumb):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23840
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos [Thu, 28 Jun 2007 01:50:40 +0000 (01:50 +0000)]
Missed this file as part of #23832
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23839
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos [Thu, 28 Jun 2007 01:36:24 +0000 (01:36 +0000)]
Make Qt builds link when XSLT is disabled
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23838
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken [Thu, 28 Jun 2007 00:23:10 +0000 (00:23 +0000)]
Turn on static code analysis (Windows only).
Affects only folks that have Visual Studio Team Suite installed,
or who have replaced their compiler with the version shipping in the
Vista SDK.
Reviewed by Oliver.
* WebCore.vcproj/WebCore.vcproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23837
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos [Thu, 28 Jun 2007 00:04:26 +0000 (00:04 +0000)]
Remove files that no longer exist (were commented out)
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23836
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos [Wed, 27 Jun 2007 23:14:04 +0000 (23:14 +0000)]
revert IDL change until the code generator is fixed
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23835
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Wed, 27 Jun 2007 23:08:03 +0000 (23:08 +0000)]
LayoutTests:
Reviewed by John.
<rdar://problem/
5247341> REGRESSION: Pasting sometimes loses trailing newline
Demonstrates the bug:
* editing/pasteboard/
5247341-expected.checksum: Added.
* editing/pasteboard/
5247341-expected.png: Added.
* editing/pasteboard/
5247341-expected.txt: Added.
* editing/pasteboard/
5247341.html: Added.
The changes in this patch exposed three bugs (
5296964,
5296977, and
5299425).
Added FIXMES for them. Also removed tabs in them:
* editing/pasteboard/paste-table-003-expected.checksum:
* editing/pasteboard/paste-table-003-expected.png:
* editing/pasteboard/paste-table-003-expected.txt:
* editing/pasteboard/paste-table-003.html:
* fast/forms/textarea-paste-newline.html:
Equivalent trees:
* editing/pasteboard/paste-text-016-expected.txt:
* editing/pasteboard/paste-text-017-expected.txt:
WebCore:
Reviewed by John.
<rdar://problem/
5247341> REGRESSION: Pasting sometimes leaves out trailing newline
Pasting with a trailing interchange newline doesn't work when pasting
into an empty line. Code that handles removing brs at the insertion
position tries to also handle trailing interchange newlines by re-using
those brs and fails. Removed that code and handle all interchange
newlines with code later in doApply().
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::doApply): Don't try to re-use the
endBR when there's a trailing interchange newline.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23834
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos [Wed, 27 Jun 2007 22:21:55 +0000 (22:21 +0000)]
Use the proper macros so that it builds with !SVG and !XPATH
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23833
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos [Wed, 27 Jun 2007 22:06:14 +0000 (22:06 +0000)]
Fix compilation with various Qt configurations
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23832
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken [Wed, 27 Jun 2007 22:05:14 +0000 (22:05 +0000)]
Fix ChangeLog.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23831
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken [Wed, 27 Jun 2007 22:01:04 +0000 (22:01 +0000)]
Turn on static code analysis.
Reviewed by Oliver.
Effects only folks that have Visual Studio Team Suite installed,
or who have replaced their compiler with the version shipping in the
Vista SDK.
* CodeAnalysisConfig.h: Added.
* WebKit.vcproj/WebKit.vcproj:
* WebLocalizableStrings.cpp:
(createWebKitBundle):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23830
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken [Wed, 27 Jun 2007 21:55:41 +0000 (21:55 +0000)]
Prefast: Remove variable redefinitions in inner scopes.
Reviewed by Ada.
* WebDownload.cpp:
(WebDownload::didFinish):
* WebNotificationCenter.cpp:
(WebNotificationCenter::postNotificationInternal):
(WebNotificationCenter::removeObserver):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23829
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken [Wed, 27 Jun 2007 21:28:40 +0000 (21:28 +0000)]
Remove SEH block from around history plist read, since the underlying bug has been fixed.
Reviewed by Darin.
* WebHistory.cpp:
(createHistoryListFromStream):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23828
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Wed, 27 Jun 2007 21:27:23 +0000 (21:27 +0000)]
Reviewed by Oliver.
<rdar://problem/
5253950>
When Shockwave plugin has been loaded, exiting crashes Safari
Add a "load count" for plugin packages. When the load count is zero, unload the plugin.
* plugins/win/PluginPackageWin.cpp:
(WebCore::PluginPackageWin::PluginPackageWin):
(WebCore::PluginPackageWin::load):
(WebCore::PluginPackageWin::unload):
(WebCore::PluginPackageWin::unloadWithoutShutdown):
* plugins/win/PluginPackageWin.h:
* plugins/win/PluginViewWin.cpp:
(WebCore::PluginViewWin::~PluginViewWin):
Make sure to unload the plugin package and clear any references to plugin script objects.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23827
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos [Wed, 27 Jun 2007 20:45:36 +0000 (20:45 +0000)]
We were compiling purely out of luck, but if qmake sets up the build order
slightly differently it fails. This forces a dependency to generate HTMLNames.h
in time.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23826
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos [Wed, 27 Jun 2007 20:13:27 +0000 (20:13 +0000)]
Patch from Eli Fidler to compile when QT_NO_IMAGE_TEXT is defined.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23825
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos [Wed, 27 Jun 2007 20:06:38 +0000 (20:06 +0000)]
Patch from Eli Fidler to remove QT3_SUPPORT dependency in ICO handler.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23824
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Wed, 27 Jun 2007 20:04:48 +0000 (20:04 +0000)]
LayoutTests:
Reviewed by John.
<rdar://problem/
4580583> Breaking blockquoted list should not automatically renumber the second list
Splits a quoted list w/o splitting a list item:
* editing/execCommand/
4580583-1-expected.checksum: Added.
* editing/execCommand/
4580583-1-expected.png: Added.
* editing/execCommand/
4580583-1-expected.txt: Added.
* editing/execCommand/
4580583-1.html: Added.
Split a quoted list item:
* editing/execCommand/
4580583-2-expected.checksum: Added.
* editing/execCommand/
4580583-2-expected.png: Added.
* editing/execCommand/
4580583-2-expected.txt: Added.
* editing/execCommand/
4580583-2.html: Added.
WebCore:
Reviewed by John.
<rdar://problem/
4580583> Breaking blockquoted list should not automatically renumber the second list
When a quoted numbered list is broken in half, it's cloned
to make the second list. That second list needs its start attribute
set so that the numbers of the list items in it will be preserved.
* editing/BreakBlockquoteCommand.cpp:
(WebCore::BreakBlockquoteCommand::doApply): Set the start attribute
of a cloned list to be the original number of the first list item in it.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23823
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken [Wed, 27 Jun 2007 17:28:39 +0000 (17:28 +0000)]
Prefast: Fix misplaced parenthesis.
Reviewed by Darin.
* WebView.cpp:
(core):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23822
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Wed, 27 Jun 2007 17:21:46 +0000 (17:21 +0000)]
Reviewed by Geoff.
http://bugs.webkit.org/show_bug.cgi?id=14413
GIF animation throttling is different from MSIE
* platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::ImageSource::frameDurationAtIndex):
Change the cut-off value to 50ms to match MSIE.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23821
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan [Wed, 27 Jun 2007 17:15:37 +0000 (17:15 +0000)]
Reviewed by Darin
- WebKit support for displaying multiple text matches in PDF views (<rdar://problem/
4601967>)
* WebView/WebPDFView.h:
new ivars textMatches and lastScrollPosition; now conforms to WebMultipleTextMatches protocol
* WebView/WebPDFView.mm:
(-[WebPDFView dealloc]):
release textMatches
(-[WebPDFView viewDidMoveToWindow]):
start observing bounds changes in the PDF document's enclosing clip view, so we can notice when
scrolling takes place
(-[WebPDFView viewWillMoveToWindow:]):
stop observing bounds changes in the PDF document's enclosing clip view
(-[WebPDFView searchFor:direction:caseSensitive:wrap:startInSelection:]):
most of the code here has been moved into the new method _nextMatchFor::::, which this now calls
(-[WebPDFView setMarkedTextMatchesAreHighlighted:]):
implementation of WebMultipleTextMatches protocol method, does nothing useful here because we don't
support inline highlighting of matches in PDF documents
(-[WebPDFView markedTextMatchesAreHighlighted]):
implementation of WebMultipleTextMatches protocol method
(-[WebPDFView markAllMatchesForText:caseSensitive:limit:]):
implementation of WebMultipleTextMatches protocol method; calls _nextMatchFor:::: in a loop until
entire document is searched or limit is hit; records results by saving PDFSelections in textMatches ivar
(-[WebPDFView unmarkAllTextMatches]):
implementation of WebMultipleTextMatches protocol method; clears saved textMatches
(-[WebPDFView rectsForTextMatches]):
implementation of WebMultipleTextMatches protocol method; converts saved PDFSelections into NSValue
objects that represent NSRects
(-[WebPDFView _clipViewForPDFDocumentView]):
new helper method to find the clip view whose bounds determine the current scroll position
(-[WebPDFView _nextMatchFor:direction:caseSensitive:wrap:fromSelection:startInSelection:]):
new helper method, extracted from searchFor:::::
(-[WebPDFView _PDFDocumentViewMightHaveScrolled:]):
new notification callback; tells webView's delegate when document has scrolled
(-[WebPDFView _setTextMatches:]):
new helper method, stores value in ivar
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23820
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken [Wed, 27 Jun 2007 17:13:17 +0000 (17:13 +0000)]
Prefast: Add null check prior to writing into allocated BSTR.
Reviewed by Darin.
* MarshallingHelpers.cpp:
(MarshallingHelpers::CFStringRefToBSTR):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23819
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken [Wed, 27 Jun 2007 16:53:09 +0000 (16:53 +0000)]
Prefast: Add error handling for SysAllocStringLen where the string length is determined by website content.
Reviewed by Sam, Darin.
Allocation failure will result in a null dereference in this case,
so it isn't exploitable.
* DefaultDownloadDelegate.cpp:
(DefaultDownloadDelegate::decideDestinationWithSuggestedFilename):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23818
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Wed, 27 Jun 2007 16:47:41 +0000 (16:47 +0000)]
Forgot to commit this file with r23815.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23817
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Wed, 27 Jun 2007 16:43:01 +0000 (16:43 +0000)]
JavaScriptCore:
Reviewed by Darin.
First pass at fixing implicit 64-32 bit conversion errors.
<rdar://problem/
5292262>
- Add 'f' suffix where necessary.
* kjs/testkjs.cpp:
(StopWatch::getElapsedMS):
WebCore:
Reviewed by Darin.
First pass at fixing implicit 64-32 bit conversion errors.
<rdar://problem/
5292262>
- Add 'f' suffix where necessary.
* bridge/mac/WebCoreAXObject.mm:
(-[WebCoreAXObject accessibilityAttributeValue:forParameter:]):
* css/csshelper.h:
* css/cssstyleselector.cpp:
(WebCore::):
(WebCore::CSSStyleSelector::largerFontSize):
(WebCore::CSSStyleSelector::smallerFontSize):
* html/CanvasGradient.cpp:
(WebCore::CanvasGradient::addColorStop):
* html/CanvasPattern.cpp:
(WebCore::CanvasPattern::createPattern):
* ksvg2/css/SVGCSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applySVGProperty):
* ksvg2/css/SVGRenderStyle.h:
* ksvg2/events/SVGZoomEvent.cpp:
(WebCore::SVGZoomEvent::SVGZoomEvent):
* ksvg2/svg/SVGLength.cpp:
(WebCore::SVGLength::SVGLength):
(WebCore::SVGLength::value):
(WebCore::SVGLength::setValue):
(WebCore::SVGLength::valueAsPercentage):
(WebCore::SVGLength::PercentageOfViewport):
* ksvg2/svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::pixelUnitToMillimeterX):
(WebCore::SVGSVGElement::pixelUnitToMillimeterY):
(WebCore::SVGSVGElement::getScreenCTM):
* ksvg2/svg/SVGTextContentElement.cpp:
(WebCore::SVGTextContentElement::getComputedTextLength):
(WebCore::SVGTextContentElement::getSubStringLength):
(WebCore::SVGTextContentElement::getRotationOfChar):
* ksvg2/svg/SVGTransformDistance.cpp:
(WebCore::SVGTransformDistance::SVGTransformDistance):
(WebCore::SVGTransformDistance::distance):
* page/InspectorController.cpp:
(WebCore::InspectorResource::InspectorResource):
* platform/graphics/FloatPoint3D.cpp:
(WebCore::FloatPoint3D::normalize):
* platform/graphics/Path.cpp:
(WebCore::pathLengthApplierFunction):
(WebCore::Path::createRoundedRectangle):
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::drawLine):
(WebCore::GraphicsContext::strokeArc):
* platform/graphics/cg/ImageCG.cpp:
(WebCore::FrameData::clear):
* platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::ImageSource::frameDurationAtIndex):
* platform/graphics/cg/PDFDocumentImage.cpp:
(WebCore::PDFDocumentImage::setCurrentPage):
* platform/graphics/svg/SVGPaintServerPattern.cpp:
(WebCore::SVGPaintServerPattern::externalRepresentation):
* platform/graphics/svg/SVGPaintServerRadialGradient.cpp:
(WebCore::SVGPaintServerRadialGradient::SVGPaintServerRadialGradient):
* platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp:
(WebCore::cgGradientCallback):
(WebCore::CGShadingRefForRadialGradient):
(WebCore::SVGPaintServerGradient::updateQuartzGradientStopsCache):
* platform/mac/FontDataMac.mm:
(WebCore::webFallbackFontFamily):
* platform/mac/PopupMenuMac.mm:
(WebCore::PopupMenu::show):
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::placeBoxesHorizontally):
* rendering/RenderSlider.cpp:
(WebCore::RenderSlider::setValueForPosition):
(WebCore::RenderSlider::setPositionFromValue):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23816
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Wed, 27 Jun 2007 16:36:43 +0000 (16:36 +0000)]
Reviewed by Geoff.
http://bugs.webkit.org/show_bug.cgi?id=14288
XMLHttpRequest doesn't use a correct content type for file:// URLs
Test: fast/dom/xmlhttprequest-html-response-encoding.html
* xml/xmlhttprequest.cpp:
(WebCore::XMLHttpRequest::responseMIMEType): Use MIME type provided by
the network layer, since it provides it even for non-HTTP responses.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23815
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver [Wed, 27 Jun 2007 08:19:53 +0000 (08:19 +0000)]
Reviewed by Maciej.
Hopefully fix remainder of the IME issues on Mac.
We now assume that the IME silently consumes any event given
to it during text composition, and only override this assumption
if the NSTextInput or NSResponder callbacks are made.
This prevents us from treating those events that the IME has
consumed internally (eg. candidate window navigation) as unhandled
events that should be bubbled.
This fixes:
<rdar://problem/
5107538> Major problems handling key press event with non-english Input Methods
<rdar://problem/
4196249> REGRESSION: Mail: Inputting space (U+0020) with IM deletes subsequent line breaks on Mail.app
<rdar://problem/
5015544> REGRESSION: Reverse conversion keyboard command does not work in Safari.
<rdar://problem/
5045121> REGRESSION: Inline is confirmed after press left/right arrow keys, happens in Mail but not in TextEdit.
<rdar://problem/
5076807> REGRESSION: Can't undo conversion of inline text (by hitting ESC)
<rdar://problem/
5085781> REGRESSION: Active input area lost "selected" highlight
<rdar://problem/
5094200> space key pressed to close the associated words candidate window gets inserted as text
<rdar://problem/
5228294> Candidate item for character matrix is sometimes skipped
* WebKit.xcodeproj/project.pbxproj:
* WebView/WebHTMLView.mm:
(-[WebHTMLView launchKeyEvent:]):
(-[WebHTMLView keyDown:]):
(-[WebHTMLView keyUp:]):
(-[WebHTMLView _interceptEditingKeyEvent:shouldSaveCommand:]):
(-[WebHTMLView unmarkText]):
(-[WebHTMLView setMarkedText:selectedRange:]):
(-[WebHTMLView doCommandBySelector:]):
(-[WebHTMLView insertText:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23813
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Wed, 27 Jun 2007 05:45:40 +0000 (05:45 +0000)]
2007-06-26 Alp Toker <alp.toker@collabora.co.uk>
Reviewed by Sam Weinig.
http://bugs.webkit.org/show_bug.cgi?id=14061
Implement more of FrameLoaderClientGdk
Make FrameLoaderClientGdk work properly when the MIME type is set.
* loader/gdk/FrameLoaderClientGdk.cpp:
(WebCore::FrameLoaderClientGdk::objectContentType):
(WebCore::FrameLoaderClientGdk::canShowMIMEType):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23812
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Wed, 27 Jun 2007 05:44:33 +0000 (05:44 +0000)]
2007-06-26 Alp Toker <alp.toker@collabora.co.uk>
Reviewed by Maciej.
http://bugs.webkit.org/show_bug.cgi?id=14058
Gdk font backend cleanup
* platform/FontData.h: Remove obsolete function.
* platform/gdk/FontDataGdk.cpp:
(WebCore::FontData::containsCharacters): Lock/unlock only once.
(WebCore::FontData::platformWidthForGlyph): Remove needless cast.
* platform/gdk/FontPlatformData.h: Remove obsolete function.
* platform/gdk/FontPlatformDataGdk.cpp:
(WebCore::FontPlatformData::FontPlatformData): Pass the actual size,
not the pixel size.
(WebCore::FontPlatformData::~FontPlatformData): Free m_fontMatrix.
* platform/gdk/GlyphPageTreeNodeGdk.cpp:
(WebCore::GlyphPage::fill): Lock/unlock only once.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23811
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Wed, 27 Jun 2007 05:33:32 +0000 (05:33 +0000)]
2007-06-26 Mitz Pettel <mitz@webkit.org>
Reviewed by Hyatt.
- fix http://bugs.webkit.org/show_bug.cgi?id=14406
<colgroup>'s borders are ignored when it has <col> children
Covered by existing tests.
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::collapsedLeftBorder):
(WebCore::RenderTableCell::collapsedRightBorder):
(WebCore::RenderTableCell::collapsedTopBorder):
(WebCore::RenderTableCell::collapsedBottomBorder):
2007-06-26 Mitz Pettel <mitz@webkit.org>
Reviewed by Hyatt.
- updated results for http://bugs.webkit.org/show_bug.cgi?id=14406
<colgroup>'s borders are ignored when it has <col> children
* tables/mozilla/core/table_rules-expected.checksum: Added.
* tables/mozilla/core/table_rules-expected.png: Added.
* tables/mozilla/core/table_rules-expected.txt: Added.
* tables/mozilla/core/table_rules.html: Copied from LayoutTests/tables/mozilla_expected_failures/core/table_rules.html.
* tables/mozilla/marvin/x_table_rules_groups-expected.checksum: Added.
* tables/mozilla/marvin/x_table_rules_groups-expected.png: Added.
* tables/mozilla/marvin/x_table_rules_groups-expected.txt: Added.
* tables/mozilla/marvin/x_table_rules_groups.xml: Copied from LayoutTests/tables/mozilla_expected_failures/marvin/x_table_rules_groups.xml.
* tables/mozilla_expected_failures/core/table_rules-expected.checksum: Removed.
* tables/mozilla_expected_failures/core/table_rules-expected.png: Removed.
* tables/mozilla_expected_failures/core/table_rules-expected.txt: Removed.
* tables/mozilla_expected_failures/core/table_rules.html: Removed.
* tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.checksum:
* tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.txt:
* tables/mozilla_expected_failures/marvin/x_table_rules_groups-expected.checksum: Removed.
* tables/mozilla_expected_failures/marvin/x_table_rules_groups-expected.png: Removed.
* tables/mozilla_expected_failures/marvin/x_table_rules_groups-expected.txt: Removed.
* tables/mozilla_expected_failures/marvin/x_table_rules_groups.xml: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23810
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Wed, 27 Jun 2007 04:46:07 +0000 (04:46 +0000)]
2007-06-26 Mitz Pettel <mitz@webkit.org>
Reviewed by Oliver.
- fix http://bugs.webkit.org/show_bug.cgi?id=14329
REGRESSION: TEXTAREA - cannot drag-and-drop text at en.wikipedia.org/
Test: fast/repaint/text-selection-rect-in-overflow-2.html
* rendering/RenderObject.cpp:
(WebCore::RenderObject::computeAbsoluteRepaintRect): Added code to account
for overflow scroll and columns.
* rendering/RenderText.cpp:
(WebCore::RenderText::selectionRect): Adjust for columns only in the
non-clipped case, since RenderObject::absolutePosition() does not.
2007-06-26 Mitz Pettel <mitz@webkit.org>
Reviewed by Oliver.
- repaint test for http://bugs.webkit.org/show_bug.cgi?id=14329
REGRESSION: TEXTAREA - cannot drag-and-drop text at en.wikipedia.org/
* fast/repaint/resources/text-selection-rect-in-overflow-frame.html: Added.
* fast/repaint/text-selection-rect-in-overflow-2-expected.checksum: Added.
* fast/repaint/text-selection-rect-in-overflow-2-expected.png: Added.
* fast/repaint/text-selection-rect-in-overflow-2-expected.txt: Added.
* fast/repaint/text-selection-rect-in-overflow-2.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23809
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Wed, 27 Jun 2007 04:43:27 +0000 (04:43 +0000)]
2007-06-26 Mitz Pettel <mitz@webkit.org>
Reviewed by Sam.
- http://bugs.webkit.org/show_bug.cgi?id=14415
Remove the unused method RenderObject::setTable()
* rendering/RenderObject.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23808
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Wed, 27 Jun 2007 04:07:35 +0000 (04:07 +0000)]
Touching config.h to force WebCore to rebuild after r23806
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23807
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Wed, 27 Jun 2007 03:16:23 +0000 (03:16 +0000)]
2007-06-26 MorganL <morganl.webkit@yahoo.com>
Reviewed by Maciej.
Implement http://bugs.webkit.org/show_bug.cgi?id=14225
Bug 14225: Make it possible to define platform-specific ResourceRequest without #ifdefs
This change moves the bulk of ResourceRequest into a base class named
ResourceRequestBase with all platform-specific bits pushed into
ResourceRequest. This allows ports to easily add new members to a
ResourceRequest without having to #ifdef the code that is shared
between ports.
* WebCore.exp:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* platform/network/ResourceRequest.cpp: Removed.
* platform/network/ResourceRequest.h: Removed.
* platform/network/ResourceRequestBase.cpp: Added.
(WebCore::ResourceRequestBase::asResourceRequest):
(WebCore::ResourceRequestBase::isEmpty):
(WebCore::ResourceRequestBase::isNull):
(WebCore::ResourceRequestBase::url):
(WebCore::ResourceRequestBase::setURL):
(WebCore::ResourceRequestBase::cachePolicy):
(WebCore::ResourceRequestBase::setCachePolicy):
(WebCore::ResourceRequestBase::timeoutInterval):
(WebCore::ResourceRequestBase::setTimeoutInterval):
(WebCore::ResourceRequestBase::mainDocumentURL):
(WebCore::ResourceRequestBase::setMainDocumentURL):
(WebCore::ResourceRequestBase::httpMethod):
(WebCore::ResourceRequestBase::setHTTPMethod):
(WebCore::ResourceRequestBase::httpHeaderFields):
(WebCore::ResourceRequestBase::httpHeaderField):
(WebCore::ResourceRequestBase::setHTTPHeaderField):
(WebCore::ResourceRequestBase::httpBody):
(WebCore::ResourceRequestBase::setHTTPBody):
(WebCore::ResourceRequestBase::allowHTTPCookies):
(WebCore::ResourceRequestBase::setAllowHTTPCookies):
(WebCore::ResourceRequestBase::addHTTPHeaderField):
(WebCore::ResourceRequestBase::addHTTPHeaderFields):
(WebCore::operator==):
(WebCore::ResourceRequestBase::isConditional):
(WebCore::ResourceRequestBase::updatePlatformRequest):
(WebCore::ResourceRequestBase::updateResourceRequest):
* platform/network/ResourceRequestBase.h: Added.
(WebCore::):
(WebCore::ResourceRequestBase::httpContentType):
(WebCore::ResourceRequestBase::setHTTPContentType):
(WebCore::ResourceRequestBase::httpReferrer):
(WebCore::ResourceRequestBase::setHTTPReferrer):
(WebCore::ResourceRequestBase::clearHTTPReferrer):
(WebCore::ResourceRequestBase::httpUserAgent):
(WebCore::ResourceRequestBase::setHTTPUserAgent):
(WebCore::ResourceRequestBase::httpAccept):
(WebCore::ResourceRequestBase::setHTTPAccept):
(WebCore::ResourceRequestBase::ResourceRequestBase):
(WebCore::operator!=):
* platform/network/cf/ResourceRequest.h: Added.
(WebCore::ResourceRequest::ResourceRequest):
* platform/network/curl/ResourceRequest.h: Added.
(WebCore::ResourceRequest::ResourceRequest):
(WebCore::ResourceRequest::doUpdatePlatformRequest):
(WebCore::ResourceRequest::doUpdateResourceRequest):
* platform/network/mac/ResourceRequest.h: Added.
(WebCore::ResourceRequest::ResourceRequest):
* platform/network/qt/ResourceRequest.h: Added.
(WebCore::ResourceRequest::ResourceRequest):
(WebCore::ResourceRequest::doUpdatePlatformRequest):
(WebCore::ResourceRequest::doUpdateResourceRequest):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23806
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Wed, 27 Jun 2007 03:13:26 +0000 (03:13 +0000)]
2007-06-26 Jim Correia <jim.correia@pobox.com>
Reviewed by Darin.
Fix http://bugs.webkit.org/show_bug.cgi?id=14411
Bug 14411: WebNetscapePluginPackage overagressively sets CurApRefNum, which affects shipping versions of BBEdit.
<rdar://problem/
5297268>
* Plugins/WebNetscapePluginPackage.m:
(+[WebNetscapePluginPackage initialize]): Force the Resource Manager to
lazy initialize, and only set CurApRefNum to the system file if
CurApRefNum is still -1 after that forced lazy initialization.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23805
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Wed, 27 Jun 2007 02:13:36 +0000 (02:13 +0000)]
Add ChangeLog entries from the Windows merge.
Reviewed by Maciej.
* ChangeLog:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23804
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Wed, 27 Jun 2007 01:44:54 +0000 (01:44 +0000)]
LayoutTests:
Reviewed by Maciej.
Make sure not to enumerate the toString() function.
<rdar://problem/
5297118>
* fast/dom/Window/window-appendages-cleared-expected.txt:
* fast/dom/Window/window-properties-expected.txt:
* fast/js/toString-dontEnum-expected.txt: Added.
* fast/js/toString-dontEnum.html: Added.
WebCore:
Reviewed by Maciej.
Make sure not to enumerate the toString() function.
<rdar://problem/
5297118>
* bindings/js/kjs_window.cpp:
* bindings/scripts/CodeGeneratorJS.pm: Add support for [DontEnum].
* html/HTMLAnchorElement.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23803
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Tue, 26 Jun 2007 23:26:17 +0000 (23:26 +0000)]
Reviewed by Maciej Stachowiak.
Fixed <rdar://problem/
5296627> JSGarbageCollect headerdoc suggests that
using JavaScriptCore requires leaking memory
* API/JSBase.h: Changed documentation to explain that you can pass NULL
to JSGarbageCollect.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23802
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Tue, 26 Jun 2007 23:07:33 +0000 (23:07 +0000)]
Reviewed by Mitz, landed by Anders.
http://bugs.webkit.org/show_bug.cgi?id=14421
Implement GraphicsContext::clearRect()
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::clearRect):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23801
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Tue, 26 Jun 2007 23:05:06 +0000 (23:05 +0000)]
Reviewed and landed by Anders.
http://bugs.webkit.org/show_bug.cgi?id=14416
Content does not render fully in some cases
Fix mismatched calls to cairo_save/restore due to an early method return.
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::drawLine):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23800
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tristan [Tue, 26 Jun 2007 21:31:10 +0000 (21:31 +0000)]
Reviewed by John Sullivan.
Added two accessor functions for <rdar://problem/
4119138>
* bindings/objc/DOMHTML.mm:
(-[DOMHTMLInputElement _isEdited]):
(-[DOMHTMLTextAreaElement _isEdited]):
Added an accessor to the isEdited value of a DOM node's render object
* bindings/objc/DOMPrivate.h:
Added header definitions for _isEdited
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23799
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Tue, 26 Jun 2007 20:07:58 +0000 (20:07 +0000)]
Fix Win32 build.
* WebCore.vcproj/WebCore.vcproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23797
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Tue, 26 Jun 2007 20:05:47 +0000 (20:05 +0000)]
Fix Qt and Gdk builds.
* WebCore.pro:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23796
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Tue, 26 Jun 2007 19:55:22 +0000 (19:55 +0000)]
LayoutTests:
Reviewed by Geoff.
Update tests for http://bugs.webkit.org/show_bug.cgi?id=14111
Autogenerate Event JS binding
* fast/dom/prototype-chain-expected.txt: DOMEventPrototype is no longer
in the prototype chain.
* fast/dom/xmlhttprequest-get-expected.txt:
WebCore:
Reviewed by Geoff.
Patch for http://bugs.webkit.org/show_bug.cgi?id=14111
Autogenerate Event JS binding
- Moves the dataTransfer method into MouseEvent where it should be.
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSEventCustom.cpp: Added.
(WebCore::JSEvent::clipboardData):
(WebCore::toJS):
* bindings/js/JSEventTargetNode.cpp:
* bindings/js/JSXMLHttpRequest.cpp:
* bindings/js/kjs_events.cpp:
* bindings/js/kjs_events.h:
* bindings/objc/DOMUtility.mm:
(KJS::createDOMWrapper):
* bindings/scripts/CodeGeneratorJS.pm:
* dom/Event.h:
(WebCore::Event::returnValue):
(WebCore::Event::setReturnValue):
(WebCore::Event::clipboardData):
* dom/Event.idl:
* dom/MouseEvent.h:
(WebCore::MouseEvent::dataTransfer):
* dom/MouseEvent.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23795
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos [Tue, 26 Jun 2007 14:40:27 +0000 (14:40 +0000)]
Missed checking in this file when checking in icon database patch from Adam Treat. Unused on all platforms presently.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23791
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Tue, 26 Jun 2007 12:28:26 +0000 (12:28 +0000)]
Reviewed by Mark Rowe.
Follow up fix for: Bug 14385: Web Inspector's computed style doesn't show implicitly set properties
http://bugs.webkit.org/show_bug.cgi?id=14385
Correctly remember the "Show implicit properties" setting as you switch nodes.
* page/inspector/ResourcePanel.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23790
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Tue, 26 Jun 2007 06:52:15 +0000 (06:52 +0000)]
LayoutTests:
Reviewed by John.
<rdar://problem/
5290534> Crash RenderTextControl::calcHeight() after deleting text in a search field
Demonstrates the bug:
* editing/deleting/
5290534-expected.txt: Added.
* editing/deleting/
5290534.html: Added.
Fixed a bug (an extra br was inserted) and removed a FIXME:
* editing/deleting/
4845371-expected.checksum:
* editing/deleting/
4845371-expected.png:
* editing/deleting/
4845371-expected.txt:
* editing/deleting/
4845371.html:
Removed an unrendered br that was being incorrectly inserted:
* editing/deleting/
5126166-expected.txt:
WebCore:
Reviewed by John.
<rdar://problem/
5290534> Crash at RenderTextControl::calcHeight() after deleting text in a search field
Editing removed a node that was part of a search field's internal
structure that should not be removed.
* editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::handleGeneralDelete): If the
selection to delete ends at [container, x], where x is the number
of children in container, don't remove container. Special case
code elsewhere in this function will remove it if necessary.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23787
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Tue, 26 Jun 2007 06:34:38 +0000 (06:34 +0000)]
LayoutTests:
Reviewed by Maciej.
Test for http://bugs.webkit.org/show_bug.cgi?id=11315
Mutating document.constructor.prototype mutates Object.prototype
* fast/js/constructor-expected.txt: Added.
* fast/js/constructor.html: Added.
* fast/js/resources/constructor.js: Added.
WebCore:
Reviewed by Maciej.
Patch for http://bugs.webkit.org/show_bug.cgi?id=11315
Mutating document.constructor.prototype mutates Object.prototype
Test: fast/js/constructor.html
* bindings/scripts/CodeGeneratorJS.pm: add constructor attribute to
classes with constructors. It is an non-enumeratable, non-deletable,
readonly attribute.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23786
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos [Tue, 26 Jun 2007 05:23:00 +0000 (05:23 +0000)]
Repair the OS X build.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23785
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Tue, 26 Jun 2007 05:12:03 +0000 (05:12 +0000)]
Really remove LayoutTestResults.
* LayoutTestResults: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23784
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Tue, 26 Jun 2007 05:00:17 +0000 (05:00 +0000)]
Fix Bug 14405: LayoutTestResults/qt should be in LayoutTests/qt
Top Level:
Fix Bug 14405: LayoutTestResults/qt should be in LayoutTests/qt
http://bugs.webkit.org/show_bug.cgi?id=14405
Reviewed by Anders.
* LayoutTestResults: Removed.
WebKitTools:
Fix Bug 14405: LayoutTestResults/qt should be in LayoutTests/qt
http://bugs.webkit.org/show_bug.cgi?id=14405
Reviewed by Anders.
* Scripts/run-webkit-tests:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23783
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos [Tue, 26 Jun 2007 04:56:54 +0000 (04:56 +0000)]
Patch from Adam Treat to make the SQLite icon database optional.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23782
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Tue, 26 Jun 2007 04:38:00 +0000 (04:38 +0000)]
Enable running the regression tests on Windows.
These changes were developed alongside the Windows WebKit port and
have been well tested.
Rubberstamped by Sam.
* Scripts/run-webkit-tests:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23781
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Tue, 26 Jun 2007 04:18:26 +0000 (04:18 +0000)]
Reviewed by Adam Roben.
Patch for http://bugs.webkit.org/show_bug.cgi?id=14369
HTML syntax highlighting colors and DOM tree colors should be the same
* css/view-source.css:
* page/inspector/ResourcePanel.js:
* page/inspector/inspector.css:
* page/inspector/inspector.js:
* page/inspector/utilities.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23780
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Tue, 26 Jun 2007 03:18:32 +0000 (03:18 +0000)]
Fix Bug 14402: Main resource of apple.com/safari/ is called "www.apple.com" instead of "safari"
The solution was to make KURL::lastPathComponent ignore trailing
slashes, which is what -[NSURL lastPathComponent] does, too.
Reviewed by Oliver.
* platform/KURL.cpp:
(WebCore::KURL::lastPathComponent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23779
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Tue, 26 Jun 2007 03:09:51 +0000 (03:09 +0000)]
Fix Bug 14403: prepare-ChangeLog --git-commit doesn't support --diff
http://bugs.webkit.org/show_bug.cgi?id=14403
Reviewed by Mark Rowe.
* Scripts/prepare-ChangeLog: Don't spew to stdout, use stderr instead.
(sub createPatchCommand): Generate a correct diff in the $gitCommit
case.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23778
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kdecker [Tue, 26 Jun 2007 00:56:18 +0000 (00:56 +0000)]
Reviewed by Darin.
<rdar://problem/
5294036> -[WebView customTextEncodingName] API may return empty string instead of nil
* WebView/WebView.mm:
(-[WebView _mainFrameOverrideEncoding]): Addded the nsStringNilIfEmpty() inline to the data being returned because
our API says "The custom text encoding name or nil if no custom text encoding name has been set." I also verified
the standing Tiger WebKit behavior for this method and it does indeed return nil if a custom encoding wasn't set.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23777
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Tue, 26 Jun 2007 00:51:43 +0000 (00:51 +0000)]
Reviewed by Adam Roben.
Patch for http://bugs.webkit.org/show_bug.cgi?id=14257
Web Inspector lists favicon.ico as "other" instead of "image"
* page/InspectorController.cpp:
(WebCore::InspectorResource::type):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23776
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Tue, 26 Jun 2007 00:43:56 +0000 (00:43 +0000)]
Land pdevenv and supporting scripts/programs
pdevenv is a script that will open an instance of Visual Studio that
can compile multiple files in parallel, similar to make -jN. It uses
the following scripts/programs to accomplish this:
CLWrapper: Compiles to vcbin/cl.exe. Calls Scripts/parallelcl.
parallelcl: Actually performs the parallel compilation by forking
multiple instances of the Microsoft-supplied cl.exe.
MIDLWrapper: Compiles to vcbin/midl.exe. Calls through to the
Microsoft-supplied midl.exe. This avoids having to invoke perl for
every invocation of midl.exe, which would be quite slow.
Rubberstamped by Sam.
* CLWrapper/CLWrapper.cpp: Added.
(wmain):
* CLWrapper/CLWrapper.sln: Added.
* CLWrapper/CLWrapper.vcproj: Added.
* MIDLWrapper/MIDLWrapper.cpp: Added.
(wmain):
* MIDLWrapper/MIDLWrapper.sln: Added.
* MIDLWrapper/MIDLWrapper.vcproj: Added.
* Scripts/parallelcl: Added.
* Scripts/pdevenv: Added.
* vcbin/cl.exe: Added.
* vcbin/midl.exe: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23775
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan [Tue, 26 Jun 2007 00:30:29 +0000 (00:30 +0000)]
Reviewed by Darin
- WebKit part of <rdar://problem/
5293820>, needed to support multiple matches in PDFs
* WebView/WebDocumentInternal.h:
Added WebMultipleTextMatches protocol, containing five methods that were formerly implemented in WebHTMLView
* WebView/WebHTMLViewPrivate.h:
Removed declarations for the methods that are now in WebMultipleTextMatches protocol
* WebView/WebHTMLView.mm:
(-[WebHTMLView markAllMatchesForText:caseSensitive:limit:]):
moved this method into the WebDocumentInternalProtocols portion of the file
(-[WebHTMLView setMarkedTextMatchesAreHighlighted:]):
ditto
(-[WebHTMLView markedTextMatchesAreHighlighted]):
ditto
(-[WebHTMLView unmarkAllTextMatches]):
ditto
(-[WebHTMLView rectsForTextMatches]):
ditto
* WebView/WebView.mm:
(-[WebView canMarkAllTextMatches]):
new method, returns YES only if the documentView of every frame implements WebMultipleTextMatches
(-[WebView markAllMatchesForText:caseSensitive:highlight:limit:]):
check for WebMultipleTextMatches protocol instead of checking for WebHTMLView class
(-[WebView unmarkAllTextMatches]):
ditto
(-[WebView rectsForTextMatches]):
ditto
* WebView/WebViewPrivate.h:
declared new method canMarkAllTextMatches
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23774
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Tue, 26 Jun 2007 00:07:25 +0000 (00:07 +0000)]
LayoutTests:
Reviewed by Hyatt.
Test for: <rdar://problem/
5286410> Scrollbar and resize corner for overflow area is not hidden with style "visibility: hidden;"
http://bugs.webkit.org/show_bug.cgi?id=14297
* fast/overflow/hidden-scrollbar-resize-expected.checksum: Added.
* fast/overflow/hidden-scrollbar-resize-expected.png: Added.
* fast/overflow/hidden-scrollbar-resize-expected.txt: Added.
* fast/overflow/hidden-scrollbar-resize.html: Added.
WebCore:
Reviewed by Hyatt.
Fix for <rdar://problem/
5286410> Scrollbar and resize corner for overflow area is not hidden with style "visibility: hidden;"
http://bugs.webkit.org/show_bug.cgi?id=14297
Test: fast/overflow/hidden-scrollbar-resize.html
* rendering/RenderLayer.cpp: (WebCore::RenderLayer::paintLayer):
Updated our shouldPaint check to consider visibility.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23773
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver [Mon, 25 Jun 2007 22:59:19 +0000 (22:59 +0000)]
Reviewed by Darin.
<rdar://problem/
5293444> REGRESSION: Dragging plain text into a styled text region does not acquire the correct style info
Fixing logic error in DragController
* manual-tests/drop-text-acquires-style.html: Added.
* page/DragController.cpp:
(WebCore::documentFragmentFromDragData):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23772
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Mon, 25 Jun 2007 21:36:46 +0000 (21:36 +0000)]
Reviewed by Adam Roben.
Annotate prototypes by adding "Prototype" subtitle.
* page/inspector/ResourcePanel.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23771
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Mon, 25 Jun 2007 21:29:13 +0000 (21:29 +0000)]
Build fix.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23770
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos [Mon, 25 Jun 2007 18:20:57 +0000 (18:20 +0000)]
Some work on adding HTTP proxy and SSL errors to WebKitQt, as well as preparing
for upcoming patches to do authentication.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23769
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan [Mon, 25 Jun 2007 17:48:13 +0000 (17:48 +0000)]
Reviewed by Darin
Fixed <rdar://problem/
5292259> Find on Page doesn't work (throws exception) on page that includes PDF in a subframe
* WebView/WebView.mm:
(-[WebView markAllMatchesForText:caseSensitive:highlight:limit:]):
We were testing whether the view was an HTMLView, but then running code that assumed it was an HTMLView outside of
that test. That's a bad idea.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23768
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Mon, 25 Jun 2007 16:04:06 +0000 (16:04 +0000)]
Reviewed by Adam Roben.
http://bugs.webkit.org/show_bug.cgi?id=14386
Gdk build fix
* WebCore.pro: Fix gtk/gdk typo.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23767
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Mon, 25 Jun 2007 14:51:02 +0000 (14:51 +0000)]
Reviewed by Anders.
Bug 14385: Web Inspector's computed style doesn't show implicitly set properties
http://bugs.webkit.org/show_bug.cgi?id=14385
Add a toggle to show implict computed properties.
* page/inspector/ResourcePanel.js:
* page/inspector/inspector.css:
* page/inspector/inspector.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23764
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Mon, 25 Jun 2007 12:57:31 +0000 (12:57 +0000)]
2007-06-25 Alp Toker <alp.toker@collabora.co.uk>
Reviewed by Mark.
http://bugs.webkit.org/show_bug.cgi?id=13975
Use system-provided libjpeg and libpng
* WebKit.pri: Link against external libjpeg and libpng.
2007-06-25 Alp Toker <alp.toker@collabora.co.uk>
Reviewed by Mark.
http://bugs.webkit.org/show_bug.cgi?id=13975
Use system-provided libjpeg and libpng
* WebCore.pro: Remove bundled libjpeg and libpng sources.
* platform/image-decoders/jpeg: Remove sources.
* platform/image-decoders/png: Remove sources.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23763
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Mon, 25 Jun 2007 10:31:54 +0000 (10:31 +0000)]
2007-06-25 Mitz Pettel <mitz@webkit.org>
Reviewed by Darin.
- fix http://bugs.webkit.org/show_bug.cgi?id=14202
Table caption renders too narrow sometimes
Test: fast/table/caption-relayout.html
* rendering/RenderTable.cpp:
(WebCore::RenderTable::layout): Mark the caption for layout if the table
width changed.
2007-06-25 Mitz Pettel <mitz@webkit.org>
Reviewed by Darin.
- test and updated results for http://bugs.webkit.org/show_bug.cgi?id=14202
Table caption renders too narrow sometimes
* fast/table/caption-relayout-expected.checksum: Added.
* fast/table/caption-relayout-expected.png: Added.
* fast/table/caption-relayout-expected.txt: Added.
* fast/table/caption-relayout.html: Added.
* tables/mozilla/marvin/x_caption_class-expected.checksum:
* tables/mozilla/marvin/x_caption_class-expected.png:
* tables/mozilla/marvin/x_caption_class-expected.txt:
* tables/mozilla/marvin/x_caption_id-expected.checksum:
* tables/mozilla/marvin/x_caption_id-expected.png:
* tables/mozilla/marvin/x_caption_id-expected.txt:
* tables/mozilla/marvin/x_caption_style-expected.checksum:
* tables/mozilla/marvin/x_caption_style-expected.png:
* tables/mozilla/marvin/x_caption_style-expected.txt:
* tables/mozilla_expected_failures/bugs/bug29058-2-expected.checksum:
* tables/mozilla_expected_failures/bugs/bug29058-2-expected.png:
* tables/mozilla_expected_failures/bugs/bug29058-2-expected.txt:
* tables/mozilla_expected_failures/bugs/bug3166-5-expected.checksum:
* tables/mozilla_expected_failures/bugs/bug3166-5-expected.png:
* tables/mozilla_expected_failures/bugs/bug3166-5-expected.txt:
* tables/mozilla_expected_failures/bugs/bug3166-6-expected.checksum:
* tables/mozilla_expected_failures/bugs/bug3166-6-expected.png:
* tables/mozilla_expected_failures/bugs/bug3166-6-expected.txt:
* tables/mozilla_expected_failures/bugs/bug3166-9-expected.checksum:
* tables/mozilla_expected_failures/bugs/bug3166-9-expected.png:
* tables/mozilla_expected_failures/bugs/bug3166-9-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23762
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Mon, 25 Jun 2007 10:29:03 +0000 (10:29 +0000)]
2007-06-25 Mitz Pettel <mitz@webkit.org>
Reviewed by Darin.
- fix http://bugs.webkit.org/show_bug.cgi?id=14245
Underline painted under <br>, not repainted properly
Test: fast/inline/br-text-decoration.html
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::drawLineForText): Added an early return if the line width
is zero. Also changed the line stroke to a rect fill, so that lines with length shorter
than their thickness paint correctly.
2007-06-25 Mitz Pettel <mitz@webkit.org>
Reviewed by Darin.
- pixel test for http://bugs.webkit.org/show_bug.cgi?id=14245
Underline painted under <br>, not repainted properly
* fast/inline/br-text-decoration-expected.checksum: Added.
* fast/inline/br-text-decoration-expected.png: Added.
* fast/inline/br-text-decoration-expected.txt: Added.
* fast/inline/br-text-decoration.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23761
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Mon, 25 Jun 2007 10:27:00 +0000 (10:27 +0000)]
2007-06-25 Matt Perry <mpComplete@gmail.com>
Reviewed by Sam Weinig.
Modify test to wait until the second frame loads, and update its expected output to match.
* fast/dom/HTMLDocument/frameless-location-bugzilla10837-expected.checksum:
* fast/dom/HTMLDocument/frameless-location-bugzilla10837-expected.png:
* fast/dom/HTMLDocument/frameless-location-bugzilla10837-expected.txt:
* fast/dom/HTMLDocument/frameless-location-bugzilla10837.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23760
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Mon, 25 Jun 2007 10:23:33 +0000 (10:23 +0000)]
2007-06-25 Mitz Pettel <mitz@webkit.org>
Reviewed by Maciej.
- fix http://bugs.webkit.org/show_bug.cgi?id=14341
rules="none" ignored in certain cases
Covered by existing tests.
* html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::getSharedCellDecl):
2007-06-25 Mitz Pettel <mitz@webkit.org>
Reviewed by Maciej.
- updated results for http://bugs.webkit.org/show_bug.cgi?id=14341
rules="none" ignored in certain cases
* tables/mozilla/marvin/table_rules_none-expected.checksum: Added.
* tables/mozilla/marvin/table_rules_none-expected.png: Added.
* tables/mozilla/marvin/table_rules_none-expected.txt: Added.
* tables/mozilla/marvin/table_rules_none.html: Copied from LayoutTests/tables/mozilla_expected_failures/marvin/table_rules_none.html.
* tables/mozilla/marvin/x_table_rules_none-expected.checksum: Added.
* tables/mozilla/marvin/x_table_rules_none-expected.png: Added.
* tables/mozilla/marvin/x_table_rules_none-expected.txt: Added.
* tables/mozilla/marvin/x_table_rules_none.xml: Copied from LayoutTests/tables/mozilla_expected_failures/marvin/x_table_rules_none.xml.
* tables/mozilla_expected_failures/core/table_rules-expected.checksum:
* tables/mozilla_expected_failures/core/table_rules-expected.png:
* tables/mozilla_expected_failures/core/table_rules-expected.txt:
* tables/mozilla_expected_failures/marvin/table_rules_none-expected.checksum: Removed.
* tables/mozilla_expected_failures/marvin/table_rules_none-expected.png: Removed.
* tables/mozilla_expected_failures/marvin/table_rules_none-expected.txt: Removed.
* tables/mozilla_expected_failures/marvin/table_rules_none.html: Removed.
* tables/mozilla_expected_failures/marvin/x_table_rules_none-expected.checksum: Removed.
* tables/mozilla_expected_failures/marvin/x_table_rules_none-expected.png: Removed.
* tables/mozilla_expected_failures/marvin/x_table_rules_none-expected.txt: Removed.
* tables/mozilla_expected_failures/marvin/x_table_rules_none.xml: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23759
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Mon, 25 Jun 2007 07:10:13 +0000 (07:10 +0000)]
Reviewed by Mitz.
Patch for http://bugs.webkit.org/show_bug.cgi?id=14379
Anchor elements show up as their href in the properties pane, not HTMLAnchorElement
* page/inspector/ResourcePanel.js: make sure not to call an overriden
toString() by using Object.prototype.toString.call().
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23758
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Mon, 25 Jun 2007 05:09:06 +0000 (05:09 +0000)]
Fix http://bugs.webkit.org/show_bug.cgi?id=14374
Bug 14374: Computed Style section should be expanded by default
Reviewed by Sam.
No regression test possible.
* page/inspector/ResourcePanel.js: Expand all style sections.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23757
268f45cc-cd09-0410-ab3c-
d52691b4dbfc