eseidel [Sun, 3 Jul 2005 07:03:14 +0000 (07:03 +0000)]
Bug #: 3824
Submitted by: eseidel
Reviewed by: mjs
* ForwardingHeaders/qpair.h: Added.
* kwq/KWQPair.h: Added.
Qt compatible QPair, built on std::pair
http://bugzilla.opendarwin.org/show_bug.cgi?id=3824
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9574
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin [Fri, 1 Jul 2005 22:12:26 +0000 (22:12 +0000)]
Adding createCaption test for HTMLTableElement.
Reviewed by Adele (sort of).
Test cases added:
* layout-tests/fast/dom/HTMLTableElement/createCaption-expected.txt: Added.
* layout-tests/fast/dom/HTMLTableElement/createCaption.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9567
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan [Fri, 1 Jul 2005 21:30:52 +0000 (21:30 +0000)]
Reviewed by Darin Adler.
- fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=3711: Displayed PDF have limited options in contextual menu
This was a problem with using Tiger's version of Safari with tip of tree WebKit.
* WebView.subproj/WebPDFView.m:
(-[WebPDFView _anyPDFTagsFoundInMenu:]):
new method, returns YES if the menu contains any items with any of the new PDF-related tags.
(-[WebPDFView menuForEvent:]):
If the executable was linked on Tiger or older (but it will never be older, since this code is
new to Tiger), force all of the PDF-related items into the menu if none of them were there
after processing by the delegate.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9566
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Fri, 1 Jul 2005 21:07:03 +0000 (21:07 +0000)]
Moving dom tests around to conform to new directory structure
specified in today's meeting.
Reviewed by justing.
Test cases added:
* layout-tests/fast/dom/HTMLDocument/title-get-expected.txt: Added.
* layout-tests/fast/dom/HTMLDocument/title-get.html: Added.
* layout-tests/fast/dom/HTMLDocument/title-set-expected.txt: Added.
* layout-tests/fast/dom/HTMLDocument/title-set.html: Added.
* layout-tests/fast/dom/HTMLDocument/title/get-expected.txt: Removed.
* layout-tests/fast/dom/HTMLDocument/title/get.html: Removed.
* layout-tests/fast/dom/HTMLDocument/title/set-expected.txt: Removed.
* layout-tests/fast/dom/HTMLDocument/title/set.html: Removed.
* layout-tests/fast/dom/HTMLDocument/url-getset-expected.txt: Added.
* layout-tests/fast/dom/HTMLDocument/url-getset.html: Added.
* layout-tests/fast/dom/HTMLDocument/url/getset-expected.txt: Removed.
* layout-tests/fast/dom/HTMLDocument/url/getset.html: Removed.
* layout-tests/fast/dom/HTMLDocument/write-call-expected.txt: Added.
* layout-tests/fast/dom/HTMLDocument/write-call.html: Added.
* layout-tests/fast/dom/HTMLDocument/write-multiple-calls-expected.txt: Added.
* layout-tests/fast/dom/HTMLDocument/write-multiple-calls.html: Added.
* layout-tests/fast/dom/HTMLDocument/write/call-expected.txt: Removed.
* layout-tests/fast/dom/HTMLDocument/write/call.html: Removed.
* layout-tests/fast/dom/HTMLDocument/write/multiple-calls-expected.txt: Removed.
* layout-tests/fast/dom/HTMLDocument/write/multiple-calls.html: Removed.
* layout-tests/fast/dom/HTMLDocument/writeln-call-expected.txt: Added.
* layout-tests/fast/dom/HTMLDocument/writeln-call.html: Added.
* layout-tests/fast/dom/HTMLDocument/writeln-multiple-calls-expected.txt: Added.
* layout-tests/fast/dom/HTMLDocument/writeln-multiple-calls.html: Added.
* layout-tests/fast/dom/HTMLDocument/writeln/call-expected.txt: Removed.
* layout-tests/fast/dom/HTMLDocument/writeln/call.html: Removed.
* layout-tests/fast/dom/HTMLDocument/writeln/multiple-calls-expected.txt: Removed.
* layout-tests/fast/dom/HTMLDocument/writeln/multiple-calls.html: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9562
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan [Fri, 1 Jul 2005 20:07:51 +0000 (20:07 +0000)]
- added WKExecutableLinkedInTigerOrEarlier
* WebKitSystemInterface.h:
* libWebKitSystemInterface.a:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9561
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Fri, 1 Jul 2005 18:56:38 +0000 (18:56 +0000)]
JavaScriptCore:
-landed patch by Eric Seidel <macdome@opendarwin.org>
-for http://bugzilla.opendarwin.org/show_bug.cgi?id=3657
GroundWork: Moving some functions from khtml->jsc following kjs TOT
- no layout test necessary yet - only groundwork
Reviewed by darin.
* kjs/lookup.h:
(KJS::cacheGlobalObject):
WebCore:
-landed patch by Eric Seidel <macdome@opendarwin.org>
-for http://bugzilla.opendarwin.org/show_bug.cgi?id=3657
GroundWork: Moving some functions from khtml->jsc following kjs TOT
- no layout test necessary yet - only groundwork
Reviewed by darin.
* ForwardingHeaders/qintdict.h:
* khtml/ecma/kjs_binding.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9560
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Fri, 1 Jul 2005 18:45:13 +0000 (18:45 +0000)]
JavaScriptCore:
-landed patch by Carsten Guenther <cguenther@gmail.com>
-fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=3477
some US-centric date formats not parsed by JavaScript (clock at news8austin.com)
-relevant tests:
mozilla/ecma_3/Date/15.9.5.5.js
layout-tests/fast/js/date-parse-test.html
Reviewed by darin.
* kjs/date_object.cpp:
(formatLocaleDate):
(day):
(dayFromYear):
(daysInYear):
(timeFromYear):
(yearFromTime):
(weekDay):
(timeZoneOffset):
(DateProtoFuncImp::call):
(DateObjectImp::construct):
(KJS::parseDate):
(ymdhms_to_seconds):
(KJS::makeTime):
(findMonth):
(KJS::KRFCDate_parseDate):
* kjs/date_object.h:
* tests/mozilla/expected.html: updated expected results to reflect fix
WebCore:
-landed patch by Carsten Guenther <cguenther@gmail.com>
http://bugzilla.opendarwin.org/show_bug.cgi?id=3477
-corrects errors in date layout test
Reviewed by darin.
Test cases modified:
* layout-tests/fast/js/date-parse-test.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9559
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Fri, 1 Jul 2005 17:47:12 +0000 (17:47 +0000)]
-fixed <rdar://problem/
4168186> JavaScript fails to throw exceptions
for invalid return statements
relevant tests:
ecma/Statements/12.9-1-n.js
ecma_2/Exceptions/lexical-052.js
ecma_2/Exceptions/statement-009.js
Reviewed by sullivan.
* kjs/nodes.cpp:
(ReturnNode::execute): now throws exception if return is not inside
a function.
* tests/mozilla/expected.html: updated to reflect fix
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9558
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Fri, 1 Jul 2005 17:37:15 +0000 (17:37 +0000)]
Reviewed by sullivan.
* tests/mozilla/expected.html: Updated test results for last fix.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9557
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Fri, 1 Jul 2005 17:19:19 +0000 (17:19 +0000)]
-fixed <rdar://problem/
4168161> JavaScript fails to throw an exception
for invalid function calls
Reviewed by sullivan.
Relevant mozilla test: ecma_3/Exceptions/regress-95101.js
* kjs/nodes.cpp:
(FunctionCallNode::evaluate): evaluate now checks for an exception
after resolving a function name (in case the function is undefined)
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9556
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Fri, 1 Jul 2005 10:03:04 +0000 (10:03 +0000)]
Bug #: 3669
Submitted by: eseidel
Reviewed by: darin
* kwq/KWQSize.h:
* kwq/KWQSize.mm:
(QSize::operator CGSize): adding CGSize conversion support
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9555
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Fri, 1 Jul 2005 09:55:02 +0000 (09:55 +0000)]
Bug #: 3687
Submitted by: eseidel
Reviewed by: darin
* kjs/interpreter.h:
(KJS::Context::curStmtFirstLine): stub for compatibility with KDE
* kjs/value.h:
(KJS::Value::isValid): compatibility with KDE
http://bugzilla.opendarwin.org/show_bug.cgi?id=3687
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9554
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Fri, 1 Jul 2005 09:48:20 +0000 (09:48 +0000)]
Bug #: 3771
Submitted by: eseidel
Reviewed by: darin
* kjs/create_hash_table: rolled in changes from KDE, including
-n <namespace> support from KDOM and support for newer comments
http://bugzilla.opendarwin.org/show_bug.cgi?id=3771
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9553
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Fri, 1 Jul 2005 05:20:49 +0000 (05:20 +0000)]
Reviewed by John Sullivan.
- fixed <http://bugzilla.opendarwin.org/show_bug.cgi?id=3774>
do renaming so that loaders are called "loader", not "client" or "delegate"
* Misc.subproj/WebIconLoader.h:
* Plugins.subproj/WebNetscapePluginStream.h:
* Plugins.subproj/WebNetscapePluginStream.m:
(-[WebNetscapePluginStream initWithRequest:pluginPointer:notifyData:sendNotification:]):
(-[WebNetscapePluginStream start]):
(-[WebNetscapePlugInStreamLoader didFinishLoading]):
(-[WebNetscapePlugInStreamLoader didFailWithError:]):
(-[WebNetscapePlugInStreamLoader cancelWithError:]):
* WebCoreSupport.subproj/WebBridge.m:
(-[WebBridge startLoadingResource:withURL:customHeaders:]):
(-[WebBridge startLoadingResource:withURL:customHeaders:postData:]):
(-[WebBridge canRunModalNow]):
* WebCoreSupport.subproj/WebSubresourceClient.h: Removed.
* WebCoreSupport.subproj/WebSubresourceClient.m: Removed.
* WebCoreSupport.subproj/WebSubresourceLoader.h:
* WebCoreSupport.subproj/WebSubresourceLoader.m:
(-[WebSubresourceLoader initWithLoader:dataSource:]):
(-[WebSubresourceLoader dealloc]):
(+[WebSubresourceLoader startLoadingResource:withRequest:customHeaders:referrer:forDataSource:]):
(+[WebSubresourceLoader startLoadingResource:withURL:customHeaders:referrer:forDataSource:]):
(+[WebSubresourceLoader startLoadingResource:withURL:customHeaders:postData:referrer:forDataSource:]):
(-[WebSubresourceLoader didReceiveResponse:]):
(-[WebSubresourceLoader didReceiveData:lengthReceived:]):
(-[WebSubresourceLoader didFinishLoading]):
(-[WebSubresourceLoader didFailWithError:]):
(-[WebSubresourceLoader cancel]):
* WebKit.pbproj/project.pbxproj:
* WebView.subproj/WebBaseResourceHandleDelegate.h: Removed.
* WebView.subproj/WebBaseResourceHandleDelegate.m: Removed.
* WebView.subproj/WebDataSource.m:
(-[WebDataSourcePrivate dealloc]):
(-[WebDataSource _setLoading:]):
(-[WebDataSource _updateLoading]):
(-[WebDataSource _setPrimaryLoadComplete:]):
(-[WebDataSource _startLoading:]):
(-[WebDataSource _addSubresourceLoader:]):
(-[WebDataSource _removeSubresourceLoader:]):
(-[WebDataSource _addPlugInStreamLoader:]):
(-[WebDataSource _removePlugInStreamLoader:]):
(-[WebDataSource _stopLoadingInternal]):
(-[WebDataSource _defersCallbacksChanged]):
(-[WebDataSource _stopLoadingWithError:]):
(-[WebDataSource data]):
(-[WebDataSource isLoading]):
* WebView.subproj/WebDataSourcePrivate.h:
* WebView.subproj/WebLoader.h:
* WebView.subproj/WebLoader.m:
* WebView.subproj/WebMainResourceClient.h: Removed.
* WebView.subproj/WebMainResourceClient.m: Removed.
* WebView.subproj/WebMainResourceLoader.h:
* WebView.subproj/WebMainResourceLoader.m:
(-[WebMainResourceLoader didReceiveResponse:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9552
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Fri, 1 Jul 2005 00:45:50 +0000 (00:45 +0000)]
-rolled in KDE fix to <rdar://problem/
4167660> JavaScript fails to
throw exceptions for invalid break/continue statements
No layout tests because it's already covered by the Mozilla suite
Reviewed by mjs.
* kjs/internal.h: LabelStack now tracks where you are relative to
switch and iteration (loop) statements
(KJS::LabelStack::LabelStack):
(KJS::LabelStack::pushIteration):
(KJS::LabelStack::popIteration):
(KJS::LabelStack::inIteration):
(KJS::LabelStack::pushSwitch):
(KJS::LabelStack::popSwitch):
(KJS::LabelStack::inSwitch):
* kjs/nodes.cpp:
These files were updated to use the new LabelStack:
(DoWhileNode::execute):
(WhileNode::execute):
(ForNode::execute):
(ForInNode::execute):
(SwitchNode::execute):
These files were updated to throw exceptions for invalid
break/continue statements:
(BreakNode::execute):
(ContinueNode::execute):
* tests/mozilla/expected.html: Updated expected results to reflect fix
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9551
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Thu, 30 Jun 2005 23:18:33 +0000 (23:18 +0000)]
Changes based on input from Michael Kahl.
* Scripts/cvs-create-patch: Use "-f" so we are compatible with .cvsrc files that
specify different style of "diff".
* Scripts/webkitdirs.pm: Add missing call to determineBaseProductDir, so that
determineConfigurationProductDir works in all cases.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9550
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kdecker [Thu, 30 Jun 2005 18:19:42 +0000 (18:19 +0000)]
Reviewed by rjw.
fixed: <rdar://problem/
4166838> failed assertion in`Interpreter::lockCount() > 0
no layout test added; this is in the bindings code.
* bindings/objc/WebScriptObject.mm:
(+[WebScriptObject _convertValueToObjcValue:KJS::originExecutionContext:Bindings::executionContext:Bindings::]): make sure to lock and unlock the interpreter around allocations.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9549
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdibello [Thu, 30 Jun 2005 17:50:24 +0000 (17:50 +0000)]
Reviewed by Geoff Garen.
Test cases added: getting and setting div.align
* layout-tests/fast/dom/HTMLDivElement/align/getset-expected.txt: Added.
* layout-tests/fast/dom/HTMLDivElement/align/getset.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9548
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Thu, 30 Jun 2005 05:57:56 +0000 (05:57 +0000)]
Forgot one file.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9547
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Thu, 30 Jun 2005 05:57:18 +0000 (05:57 +0000)]
Reviewed and landed by Darin Adler.
- Fix <http://bugzilla.opendarwin.org/show_bug.cgi?id=3274>
document() not supported
Test cases added:
* layout-tests/fast/xsl/document-function-expected.txt: Added.
* layout-tests/fast/xsl/document-function.xml: Added.
* layout-tests/fast/xsl/document-function.xsl: Added.
* layout-tests/fast/xsl/resources/document-function-source.xml: Added.
* khtml/xsl/xslt_processorimpl.cpp:
(DOM::parseErrorFunc):
Stub to prevent errors from getting written to the console.
(DOM::stylesheetLoadFunc):
Fetch and parse documents.
(DOM::XSLTProcessorImpl::transformDocument):
Use the processor as the global variable instead of the
style sheet.
* khtml/xsl/xslt_processorimpl.h:
(DOM::XSLTProcessorImpl::stylesheet):
(DOM::XSLTProcessorImpl::sourceDocument):
Add accessors for source document and stylesheet.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9546
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Thu, 30 Jun 2005 05:41:38 +0000 (05:41 +0000)]
- fixed bug which would result in multiple unwanted dumps in a single layout test
* DumpRenderTree/DumpRenderTree.m:
(-[WaitUntilDoneDelegate webView:locationChangeDone:forDataSource:]): Set new
"readyToDump" flag.
(-[LayoutTestController waitUntilDone]): Update for name change.
(-[LayoutTestController notifyDone]): Dump only if ready.
(dumpRenderTree): Set up new boolean and update for name change.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9545
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Thu, 30 Jun 2005 04:33:00 +0000 (04:33 +0000)]
Changes by Timothy Hatcher.
Reviewed by me.
* Scripts/run-webkit-app: Added script to open an arbritrary application with
a CVS built WebKit. Example: ./run-webkit-app Colloquy
* Scripts/gdb-safari: Added support for WEBKIT_SAFARI environment variable to specify
a custom location to the Safari.app bundle. This is optional, script defaults to the stock location.
* Scripts/run-safari: Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9544
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Thu, 30 Jun 2005 03:19:13 +0000 (03:19 +0000)]
Unreviewed - fixing build breakage with gcc 4.
* khtml/misc/hashtable.h: Don't use a typedef when declaring a class friend.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9543
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
harrison [Thu, 30 Jun 2005 01:56:12 +0000 (01:56 +0000)]
Temporarily enable tab coalescing ahead of white-space:pre-wrap
change because of problems with keeping the tabs separate. Will
revert when problems are fixed or remove if I do pre-wrap
first.
* khtml/editing/insert_text_command.cpp:
(khtml::InsertTextCommand::prepareForTextInsertion):
(khtml::InsertTextCommand::insertTab):
* khtml/editing/markup.cpp:
(khtml::createParagraphContentsFromString):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9542
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
harrison [Thu, 30 Jun 2005 01:28:36 +0000 (01:28 +0000)]
Reviewed by Dave Hyatt (rendering) and Maciej (editing).
Test cases added: Coming soon. Will include with next round of changes for this bug.
This is the first checkin for...
<rdar://problem/
3792529> REGRESSION (Mail): Tabs do not work the way they did in Panther (especially useful in plain text mail)
Basic strategy is to put tabs into spans with white-space:pre style, and
render them with tabs stops every 8th space, where the space width and
the left margin are those of the enclosing block.
What's left is to switch to implement white-space:pre-wrap so
that we can coalesce consecutive tabs while maintaining proper
line breaking. That will keep the markup smaller.
* WebCoreSupport.subproj/WebTextRenderer.m:
(isSpace):
(-[WebTextRenderer _CG_drawHighlightForRun:style:geometry:]):
(-[WebTextRenderer _CG_floatWidthForRun:style:widths:fonts:glyphs:startPosition:numGlyphs:]):
(-[WebTextRenderer _extendCharacterToGlyphMapToInclude:]):
(-[WebTextRenderer _CG_pointToOffset:style:position:reversed:includePartialGlyphs:]):
(initializeCharacterWidthIterator):
(widthForNextCharacter):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9541
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
harrison [Thu, 30 Jun 2005 01:27:47 +0000 (01:27 +0000)]
Reviewed by Dave Hyatt (rendering) and Maciej (editing).
Test cases added: Coming soon. Will include with next round of changes for this bug.
This is the first checkin for...
<rdar://problem/
3792529> REGRESSION (Mail): Tabs do not work the way they did in Panther (especially useful in plain text mail)
Basic strategy is to put tabs into spans with white-space:pre style, and
render them with tabs stops every 8th space, where the space width and
the left margin are those of the enclosing block.
What's left is to switch to implement white-space:pre-wrap so
that we can coalesce consecutive tabs while maintaining proper
line breaking. That will keep the markup smaller.
* khtml/editing/apply_style_command.cpp:
(khtml::createStyleSpanElement):
(khtml::ApplyStyleCommand::removeCSSStyle):
(khtml::ApplyStyleCommand::addInlineStyleIfNeeded):
* khtml/editing/delete_selection_command.cpp:
(khtml::DeleteSelectionCommand::saveTypingStyleState):
* khtml/editing/edit_command.cpp:
(khtml::EditCommand::styleAtPosition):
* khtml/editing/html_interchange.h:
* khtml/editing/htmlediting.cpp:
(khtml::isSpecialElement):
(khtml::isTabSpanNode):
(khtml::isTabSpanTextNode):
(khtml::positionBeforeTabSpan):
(khtml::createTabSpanElement):
* khtml/editing/htmlediting.h:
* khtml/editing/insert_text_command.cpp:
(khtml::InsertTextCommand::prepareForTextInsertion):
(khtml::InsertTextCommand::input):
(khtml::InsertTextCommand::insertTab):
* khtml/editing/insert_text_command.h:
* khtml/editing/markup.cpp:
(khtml::createParagraphContentsFromString):
(khtml::createFragmentFromText):
* khtml/editing/replace_selection_command.cpp:
(khtml::ReplacementFragment::removeStyleNodes):
* khtml/html/htmltokenizer.cpp:
(khtml::HTMLTokenizer::begin):
(khtml::HTMLTokenizer::processListing):
(khtml::HTMLTokenizer::parseEntity):
(khtml::HTMLTokenizer::parseTag):
(khtml::HTMLTokenizer::addPending):
(khtml::HTMLTokenizer::write):
* khtml/html/htmltokenizer.h:
(khtml::HTMLTokenizer::):
* khtml/rendering/bidi.cpp:
(khtml::addRun):
(khtml::RenderBlock::tabWidth):
(khtml::RenderBlock::computeHorizontalPositionsForLine):
(khtml::RenderBlock::skipWhitespace):
(khtml::RenderBlock::findNextLineBreak):
(khtml::RenderBlock::checkLinesForTextOverflow):
* khtml/rendering/break_lines.cpp:
(khtml::isBreakable):
* khtml/rendering/font.cpp:
(Font::drawHighlightForText):
(Font::drawText):
(Font::floatWidth):
(Font::floatCharacterWidths):
(Font::checkSelectionPoint):
(Font::width):
* khtml/rendering/font.h:
* khtml/rendering/render_block.cpp:
(khtml::stripTrailingSpace):
(khtml::RenderBlock::calcInlineMinMaxWidth):
* khtml/rendering/render_block.h:
* khtml/rendering/render_br.h:
(khtml::RenderBR::width):
* khtml/rendering/render_flexbox.cpp:
(khtml::RenderFlexibleBox::layoutVerticalBox):
* khtml/rendering/render_image.cpp:
(RenderImage::setPixmap):
(RenderImage::paint):
* khtml/rendering/render_line.cpp:
(khtml::EllipsisBox::paint):
* khtml/rendering/render_line.h:
(khtml::InlineBox::width):
(khtml::InlineBox::xPos):
(khtml::InlineBox::yPos):
(khtml::InlineBox::height):
(khtml::InlineBox::baseline):
* khtml/rendering/render_list.cpp:
(RenderListMarker::paint):
(RenderListMarker::calcMinMaxWidth):
* khtml/rendering/render_object.cpp:
(RenderObject::tabWidth):
(RenderObject::recalcMinMaxWidths):
* khtml/rendering/render_object.h:
* khtml/rendering/render_replaced.cpp:
* khtml/rendering/render_text.cpp:
(InlineTextBox::selectionRect):
(InlineTextBox::paint):
(InlineTextBox::paintSelection):
(InlineTextBox::paintMarkedTextBackground):
(InlineTextBox::textPos):
(InlineTextBox::offsetForPosition):
(InlineTextBox::positionForOffset):
(RenderText::cacheWidths):
(RenderText::widthFromCache):
(RenderText::trimmedMinMaxWidth):
(RenderText::calcMinMaxWidth):
(RenderText::containsOnlyWhitespace):
(RenderText::width):
* khtml/rendering/render_text.h:
* kwq/KWQFontMetrics.h:
* kwq/KWQFontMetrics.mm:
(QFontMetrics::width):
(QFontMetrics::charWidth):
(QFontMetrics::floatWidth):
(QFontMetrics::floatCharacterWidths):
(QFontMetrics::checkSelectionPoint):
(QFontMetrics::boundingRect):
(QFontMetrics::size):
* kwq/KWQPainter.h:
* kwq/KWQPainter.mm:
(QPainter::drawText):
(QPainter::drawHighlightForText):
* kwq/WebCoreTextRenderer.h:
* kwq/WebCoreTextRendererFactory.mm:
(WebCoreInitializeEmptyTextStyle):
* layout-tests/editing/deleting/delete-tab-001-expected.txt:
* layout-tests/editing/deleting/delete-tab-001.html:
* layout-tests/editing/deleting/delete-tab-002-expected.txt:
* layout-tests/editing/deleting/delete-tab-002.html:
* layout-tests/editing/deleting/delete-tab-003-expected.txt:
* layout-tests/editing/deleting/delete-tab-003.html:
* layout-tests/editing/deleting/delete-tab-004-expected.txt:
* layout-tests/editing/deleting/delete-tab-004.html:
* layout-tests/editing/inserting/insert-tab-001-expected.txt:
* layout-tests/editing/inserting/insert-tab-002-expected.txt:
* layout-tests/editing/inserting/insert-tab-003-expected.txt:
* layout-tests/editing/inserting/insert-tab-004-expected.txt:
* layout-tests/fast/dom/quadraticCurveTo-expected.txt:
* layout-tests/fast/js/string-replace-2-expected.txt:
* layout-tests/fast/table/039-expected.txt:
* layout-tests/fast/table/border-collapsing/004-expected.txt:
* layout-tests/fast/tokenizer/script_extra_close-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9540
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Thu, 30 Jun 2005 01:19:47 +0000 (01:19 +0000)]
JavaScriptCore:
Patch by Francisco Tolmasky <tolmasky@gmail.com>
- fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=3667
Core JavaScript 1.5 Reference:Objects:Array:forEach
See WebCore Changelog for layout tests added.
Reviewed by darin.
* kjs/array_object.cpp:
(ArrayProtoFuncImp::call):
* kjs/array_object.h:
(KJS::ArrayProtoFuncImp::):
WebCore:
Contributed by Francisco Tolmasky <tolmasky@gmail.com>
-test cases for fix to http://bugzilla.opendarwin.org/show_bug.cgi?id=3667
Core JavaScript 1.5 Reference:Objects:Array:forEach
See JavaScriptCore Changelog for details on the patch.
Reviewed by darin.
Test cases added:
* layout-tests/fast/js/array-every-expected.txt: Added.
* layout-tests/fast/js/array-every.html: Added.
* layout-tests/fast/js/array-foreach-expected.txt: Added.
* layout-tests/fast/js/array-foreach.html: Added.
* layout-tests/fast/js/array-some-expected.txt: Added.
* layout-tests/fast/js/array-some.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9539
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdibello [Thu, 30 Jun 2005 00:41:49 +0000 (00:41 +0000)]
Reviewed by Geoff Garen
Test cases added: added expected results for previous check in
* layout-tests/fast/dom/HTMLDocument/url/getset-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9538
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Thu, 30 Jun 2005 00:22:23 +0000 (00:22 +0000)]
DOM compatibility tests for HTMLDocument::writeln
Reviewed by justing.
Test cases added:
* layout-tests/fast/dom/HTMLDocument/writeln/call-expected.txt: Added.
* layout-tests/fast/dom/HTMLDocument/writeln/call.html: Added.
* layout-tests/fast/dom/HTMLDocument/writeln/multiple-calls-expected.txt: Added.
* layout-tests/fast/dom/HTMLDocument/writeln/multiple-calls.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9537
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Thu, 30 Jun 2005 00:19:51 +0000 (00:19 +0000)]
Reviewed by Geoff Garen.
Test cases added: added DOM test for document.URL
* layout-tests/fast/dom/HTMLDocument/url/getset.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9536
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdibello [Thu, 30 Jun 2005 00:13:39 +0000 (00:13 +0000)]
Reviewed by Geoff Garen.
Test cases added: added DOM test for document.URL
* layout-tests/fast/dom/HTMLDocument/url/getset.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9535
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Wed, 29 Jun 2005 23:24:32 +0000 (23:24 +0000)]
DOM compatibility test for HTMLDocument::write
Reviewed by justing.
Test cases added:
* layout-tests/fast/dom/HTMLDocument/write/call-expected.txt: Added.
* layout-tests/fast/dom/HTMLDocument/write/call.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9534
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Wed, 29 Jun 2005 23:12:02 +0000 (23:12 +0000)]
DOM compatibility tests for HTMLDocument::title
Reviewed by justing.
Test cases added:
* layout-tests/fast/dom/HTMLDocument/title/get-expected.txt: Added.
* layout-tests/fast/dom/HTMLDocument/title/get.html: Added.
* layout-tests/fast/dom/HTMLDocument/title/set-expected.txt: Added.
* layout-tests/fast/dom/HTMLDocument/title/set.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9533
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Wed, 29 Jun 2005 23:01:16 +0000 (23:01 +0000)]
DOM compatibility tests for HTMLDocument::title
Reviewed by justing.
Test cases added:
* layout-tests/fast/dom/HTMLDocument/title/get.html: Added.
* layout-tests/fast/dom/HTMLDocument/title/set.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9532
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan [Wed, 29 Jun 2005 22:53:51 +0000 (22:53 +0000)]
Reviewed by Kevin.
- deleted some never-used stub code
* WebView.subproj/WebView.m:
* WebView.subproj/WebViewInternal.h:
* WebView.subproj/WebViewPrivate.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9531
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Wed, 29 Jun 2005 21:37:02 +0000 (21:37 +0000)]
*** empty log message ***
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9530
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Wed, 29 Jun 2005 21:29:27 +0000 (21:29 +0000)]
*** empty log message ***
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9529
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Wed, 29 Jun 2005 21:22:30 +0000 (21:22 +0000)]
*** empty log message ***
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9528
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Wed, 29 Jun 2005 21:04:32 +0000 (21:04 +0000)]
Reviewed by Darin.
Added iterator support to new hashtable class, the HashSet API is
now essentially complete.
Added support for consistency check mode.
* khtml/misc/hashset.h:
(khtml::HashSet::capacity): Added
(khtml::HashSet::begin): Added (both const and non-const)
(khtml::HashSet::end): Added (both const and non-const)
(khtml::HashSet::insert): Made both versions return an iterator
(khtml::HashSet::find): Added (both const and on-const, returning appropriate iterator)
(khtml::HashSet::contains): Added
(khtml::HashSet::remove): Added version that takes an iterator argument
(khtml::HashSet::clear): Added
* khtml/misc/hashtable.h:
(khtml::HashTableIterator): New class with all the obvious iterator stuff.
(khtml::HashTableConstIterator::HashTableConstIterator): New class with all the obvious
const iterator stuff.
(khtml::HashTable::begin): Added (both const and non-consts)
(khtml::HashTable::end): Added (both const and non-consts)
(khtml::HashTable::capacity): Added
(khtml::HashTable::insert): Implement non-template method in terms
of template method.
(khtml::HashTable::contains): Added (implemented in terms of find)
(khtml::HashTable::remove): Implemented key remove in terms of find and
iterator remove.
(khtml::HashTable::hash): Made static
(khtml::HashTable::equal): Made static
(khtml::HashTable::identityConvert): Added - no-op convert method so template insert
method can be implemented in terms of non-template
(khtml::HashTable::insert): Changed to return iterator
(khtml::HashTable::reinsert): Recoded to be more like the other functions
(khtml::HashTable::find): Added
(khtml::HashTable::remove): Added iterator version
(khtml::HashTable::clear): Added
* khtml/xml/dom_atomicstring.cpp:
(DOM::AtomicString::add): Updated to deal with the fact that insert returns an iterator
(khtml::HashTable::shouldExpand): New helper.
(khtml::HashTable::shouldShrink): ditto
(khtml::HashTable::makeIterator): ditto
(khtml::HashTable::makeConstIterator): ditto
(khtml::HashTable::checkConsistency): consistency check method
(khtml::HashTable::checkConsistencyExceptSize): consistency check method
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9527
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Wed, 29 Jun 2005 20:59:21 +0000 (20:59 +0000)]
JavaScriptCore:
Patch contributed by Oliver Hunt <ojh16@student.canterbury.ac.nz>
-fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=3743
Incorrect error message given for certain calls
See WebCore Changelog for layout test added.
Reviewed by mjs.
* kjs/object.cpp:
(KJS::ObjectImp::defaultValue):
WebCore:
-added test case for fix to http://bugzilla.opendarwin.org/show_bug.cgi?id=3743
Incorrect error message given for certain calls
See JavaScriptCore Changelog for details about the patch.
Reviewed by me.
Test cases added:
* layout-tests/fast/js/toString-stack-overflow-expected.txt: Added.
* layout-tests/fast/js/toString-stack-overflow.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9526
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Wed, 29 Jun 2005 20:15:00 +0000 (20:15 +0000)]
Rolling out date patch from 6-28-05 because it breaks
fast/js/date-parse-test
Reviewed by NOBODY.
* kjs/date_object.cpp:
(formatLocaleDate):
(DateProtoFuncImp::call):
(DateObjectImp::construct):
(KJS::parseDate):
(ymdhms_to_seconds):
(isSpaceOrTab):
(KJS::KRFCDate_parseDate):
* kjs/date_object.h:
* tests/mozilla/expected.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9525
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Wed, 29 Jun 2005 20:14:58 +0000 (20:14 +0000)]
- Fixes <bugzilla.opendarwin.org/show_bug.cgi?id=3714>
HTMLLabelElement's form property isn't implemented
Patch by Anders Carlsson <andersca@mac.com>
Reviewed by Darin
Test cases added:
* layout-tests/fast/dom/HTMLLabelElement/properties/form-expected.txt: Added.
* layout-tests/fast/dom/HTMLLabelElement/properties/form.html: Added.
* khtml/html/html_formimpl.cpp:
(DOM::HTMLLabelElementImpl::form):
Traverse upwards looking for a form element.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9524
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Wed, 29 Jun 2005 18:49:20 +0000 (18:49 +0000)]
Bug #:
Submitted by:
Reviewed by:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9523
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Wed, 29 Jun 2005 17:52:16 +0000 (17:52 +0000)]
Patch by Joost de Valk <webkit@joostdevalk.nl>
- http://bugzilla.opendarwin.org/show_bug.cgi?id=3732
Testcase for accesskeys that will run with run-webkit-tests.
Reviewed by Darin.
Test cases added:
* layout-tests/fast/forms/access-key-expected.txt: Added.
* layout-tests/fast/forms/access-key.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9522
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Wed, 29 Jun 2005 17:50:24 +0000 (17:50 +0000)]
Patch by Anders Carlsson <andersca@mac.com>
- Fixes <http://bugzilla.opendarwin.org/show_bug.cgi?id=3715>
An HTMLObjectElement's form property was always null.
Reviewed by Darin
Test cases added:
* layout-tests/fast/dom/htmlobject-form-expected.txt: Added.
* layout-tests/fast/dom/htmlobject-form.html: Added.
* khtml/html/html_objectimpl.cpp:
(DOM::HTMLObjectElementImpl::form):
Implement this function by traversing the parent nodes looking
for a form element.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9521
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Wed, 29 Jun 2005 17:41:39 +0000 (17:41 +0000)]
Patch by Antoine Quint <ml@graougraou.com>
-fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=3648
quadraticCurveTo() method in <canvas> APIs JS bindings does not exist
Reviewed by Darin.
Test cases added:
* layout-tests/fast/dom/quadraticCurveTo-expected.txt: Added.
* layout-tests/fast/dom/quadraticCurveTo.xml: Added.
* khtml/ecma/kjs_html.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9520
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Wed, 29 Jun 2005 17:18:16 +0000 (17:18 +0000)]
Patch by Hanspeter Schaub <Hanspeterschaub@mac.com>
-fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=3317
REGRESSION: CSS2: outline is applied to both <li> element
and its enclosing text with context dependent selector
Reviewed by Hyatt.
Test cases added:
* layout-tests/fast/css/list-outline-expected.txt: Added.
* layout-tests/fast/css/list-outline.html: Added.
* khtml/rendering/render_line.cpp:
(khtml::InlineFlowBox::paint):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9519
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Wed, 29 Jun 2005 16:32:27 +0000 (16:32 +0000)]
Reviewed by Darin.
-fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=3750
build fails with KJS_VERBOSE set
* kjs/nodes.cpp: changed debug print statement to use UString
(VarDeclNode::evaluate):
* kjs/reference.cpp: ditto
(KJS::Reference::putValue):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9518
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vicki [Tue, 28 Jun 2005 23:22:16 +0000 (23:22 +0000)]
Reviewed by Maciej.
- fix our part of <rdar://problem/
4122332> extra HTTP GET when iframe requests file
already fetched by parent that should have been cached. Setting location via javascript
should not signal a full reload of the destination page and all its subresources.
* khtml/khtml_part.cpp:
(KHTMLPart::changeLocation): remove code that sets the reload flag
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9517
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Tue, 28 Jun 2005 22:25:43 +0000 (22:25 +0000)]
Patch contributed by Carsten Guenther <cguenther@gmail.com>.
-fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=3477
some US-centric date formats not parsed by JavaScript (clock at news8austin.com)
Reviewed by darin.
* kjs/date_object.cpp:
(formatLocaleDate):
(day):
(dayFromYear):
(daysInYear):
(timeFromYear):
(yearFromTime):
(weekDay):
(timeZoneOffset):
(DateProtoFuncImp::call):
(DateObjectImp::construct):
(KJS::parseDate):
(ymdhms_to_seconds):
(KJS::makeTime):
(findMonth):
(KJS::KRFCDate_parseDate):
* kjs/date_object.h:
* tests/mozilla/expected.html: updated expected test results to reflect fix
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9516
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Tue, 28 Jun 2005 22:18:27 +0000 (22:18 +0000)]
Patch by Kevin Ballard <kevin@sb.org>
Reviewed by Darin
- Fixes <http://bugzilla.opendarwin.org/show_bug.cgi?id=3654>
Updating the value of a textarea wasn't saving the cursor position
in a line ending-agnostic fashion.
Test cases added:
* layout-tests/fast/forms/cursor-position-expected.txt: Added.
* layout-tests/fast/forms/cursor-position.html: Added.
* kwq/KWQTextArea.mm:
(-[KWQTextArea getCursorPositionAsIndex:inParagraph:]):
(RangeOfParagraph):
(-[KWQTextArea setCursorPositionToIndex:inParagraph:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9515
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Tue, 28 Jun 2005 21:18:17 +0000 (21:18 +0000)]
*** empty log message ***
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9514
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Tue, 28 Jun 2005 18:47:12 +0000 (18:47 +0000)]
Patch by Alexey Proskuryakov <ap@nypop.com>
- <http://bugzilla.opendarwin.org/show_bug.cgi?id=3727>
When a DECODE_DEBUG preprocessor symbol is defined in khtml/misc/decoder.cpp,
compilation fails because a non-existent variable "force" is used.
Reviewed by Darin
Test cases added: None required
* khtml/misc/decoder.cpp:
(Decoder::setEncoding):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9513
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
harrison [Tue, 28 Jun 2005 16:22:04 +0000 (16:22 +0000)]
Reviewed by Chris Blumenberg.
Test cases added: (NONE)
(continued) <rdar://problem/
4140688> assertion failure double-clicking text to select
Fixed my checkin from yesterday.
* khtml/rendering/render_text.cpp:
(InlineTextBox::paintMarkedTextBackground):
(InlineTextBox::positionForOffset):
Changed tabs to spaces.
(RenderText::positionForCoordinates):
Make sure affinity is downstream when in mid-line.
Changed tabs to spaces.
(RenderText::caretRect):
(RenderText::cacheWidths):
(RenderText::trimmedMinMaxWidth):
(RenderText::minXPos):
(RenderText::width):
(RenderText::caretMaxOffset):
Changed tabs to spaces.
* layout-tests/editing/style/create-block-for-style-004-expected.txt:
Expected ending selection affinity is downstream.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9512
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Tue, 28 Jun 2005 05:47:26 +0000 (05:47 +0000)]
Remove accidentally committed code that breaks the build. Oops!
* khtml/xml/dom_atomicstring.cpp:
(DOM::AtomicString::expand):
(DOM::AtomicString::shrink):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9511
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Tue, 28 Jun 2005 01:57:42 +0000 (01:57 +0000)]
Removed accidental change from last checkin.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9510
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Tue, 28 Jun 2005 01:54:35 +0000 (01:54 +0000)]
Reviewed by Darin.
- replaced all our hash functions with the state of the art in hashing
- ~1% speedup on cvs-base
No test cases added, perf effects only.
* khtml/xml/dom_atomicstring.cpp:
(DOM::AtomicStringStatisticsExitLogger::~AtomicStringStatisticsExitLogger):
Improved stats gathering to track collisions in more detail and count reinserts
on remove.
(DOM::addToCollisionCount): ditto
(DOM::AtomicString::add): ditto
(DOM::AtomicString::insert): ditto
(DOM::AtomicString::remove): ditto
* khtml/xml/dom_stringimpl.cpp:
(DOM::DOMStringImpl::computeHash): Replace with SuperFastHash algorithm.
* kwq/KWQCharsets.mm:
(encodingNameHash): Clean up mistaken shift in the wrong direction.
* kwq/KWQString.h: Removed unused hashing code.
* kwq/KWQString.mm: ditto
* kwq/KWQTextCodec.mm:
(QTextCodec::hash): Use a variant of the SuperFastHash algorithm.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9509
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Tue, 28 Jun 2005 00:02:08 +0000 (00:02 +0000)]
Reviewed by Darin.
- replace hash functions with better ones
* JavaScriptCore.pbproj/project.pbxproj: Add new file to build.
* kjs/interpreter_map.cpp:
(KJS::InterpreterMap::computeHash): Use shared pointer hash.
* kjs/pointer_hash.h: Added.
(KJS::pointerHash): Pointer hash based on 32-bit mix and 64-bit mix hashes.
* kjs/protected_values.cpp:
(KJS::ProtectedValues::computeHash): Use shared pointer hash.
* kjs/ustring.cpp:
(KJS::UString::Rep::computeHash): Use SuperFastHash algorithm.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9501
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Mon, 27 Jun 2005 20:23:34 +0000 (20:23 +0000)]
Patch by Anders Carlsson <andersca@mac.com>
Reviewed by Darin.
- Fixes <http://bugzilla.opendarwin.org/show_bug.cgi?id=3489>
WebView's setSelectedDOMRange doesn't not implement clearing the selection as described in the WebView documentation:
<http://developer.apple.com/documentation/Cocoa/Reference/WebKit/ObjC_classic/Classes/WebView.html>
* WebView.subproj/WebView.m:
(-[WebView setSelectedDOMRange:affinity:]):
If range is nil, call deselectText.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9496
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
harrison [Mon, 27 Jun 2005 19:12:34 +0000 (19:12 +0000)]
Reviewed by Ken.
Test cases added: None because this relies on mouse clicking.
<rdar://problem/
4140688> assertion failure double-clicking text to select
* khtml/rendering/render_text.cpp:
(RenderText::positionForCoordinates):
Use setAffinityUsingLinePosition.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9490
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Mon, 27 Jun 2005 05:33:53 +0000 (05:33 +0000)]
* Scripts/build-dumprendertree: Pass -project option so that having a second
copy of the project (like the one Xcode 2.1 offers to make for you) that's
out of date won't screw you up.
* Scripts/build-webkit: Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9488
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Sat, 25 Jun 2005 17:21:59 +0000 (17:21 +0000)]
- updated a layout test so that it doesn't depend on a remote resource via http
* layout-tests/fast/backgrounds/001.html: Change image URL to be relative.
* layout-tests/fast/backgrounds/resources/bg_position_larger.gif: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9487
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Sat, 25 Jun 2005 05:17:33 +0000 (05:17 +0000)]
Changes by Mitz Pettel.
Reviewed by me.
Test cases added:
* layout-tests/fast/text/international/bidi-explicit-embedding-expected.txt: Added.
* layout-tests/fast/text/international/bidi-explicit-embedding.html: Added.
- fixed <http://bugzilla.opendarwin.org/show_bug.cgi?id=3599>
Incorrect layout of explicit embedding levels
* khtml/rendering/bidi.cpp:
(khtml::embed): Set up the new run correctly following an embed/pop.
(khtml::RenderBlock::bidiReorderLine): Close the "dangling" run when we see an explicit
embedding character (or PDF).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9486
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Sat, 25 Jun 2005 04:47:05 +0000 (04:47 +0000)]
Changes by Mitz Pettel.
Reviewed by me.
Test cases added:
* layout-tests/fast/text/international/bidi-CS-after-AN-expected.txt: Added.
* layout-tests/fast/text/international/bidi-CS-after-AN.html: Added.
- fixed <http://bugzilla.opendarwin.org/show_bug.cgi?id=3693>
Bug_72578 in KHTML: bidi algorithm misbehaves with CS after AN
* khtml/rendering/bidi.cpp: (khtml::RenderBlock::bidiReorderLine): Rolled in the
patch from the KDE tree.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9485
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Fri, 24 Jun 2005 21:05:11 +0000 (21:05 +0000)]
- <bugzilla.opendarwin.org/show_bug.cgi?id=3673>
Adds QBuffer::setBuffer(QByteArray) support to KWQBuffer, and adds a QBuffer(QByteArray) constructor.
Reviewed by Darin
Test cases added: Non required
* kwq/KWQBuffer.h:
(QBuffer::QBuffer):
* kwq/KWQBuffer.mm:
(QBuffer::setBuffer):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9484
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Fri, 24 Jun 2005 20:48:59 +0000 (20:48 +0000)]
Patch contributed by Duncan Wilcox <duncan@mclink.it>
Reviewed by Darin
- Fixed <http://bugzilla.opendarwin.org/show_bug.cgi?id=3535>
Spelling suggestions in the context menu don't call the should* delegate methods
* WebView.subproj/WebHTMLView.m:
(-[WebHTMLView _changeSpellingFromMenu:]):
give delegate's webView:shouldInsertText:replacingDOMRange:givenAction: a chance
to prevent replacing of selected text
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9483
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Fri, 24 Jun 2005 18:57:22 +0000 (18:57 +0000)]
- <bugzilla.opendarwin.org/show_bug.cgi?id=3672> KWQRect -- CGRect and other small additions
- <http://bugzilla.opendarwin.org/show_bug.cgi?id=3670> Add remove and byteOrderMark support to KWQString for kdom
Reviewed by Darin
Test cases added: None required
* kwq/KWQRect.h:
(QRect::contains):
* kwq/KWQRect.mm:
(QRect::QRect):
(QRect::topRight):
(QRect::bottomLeft):
(QRect::normalize):
(QRect::operator CGRect):
* kwq/KWQString.h:
(QChar::):
(QString::remove):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9482
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Fri, 24 Jun 2005 16:48:39 +0000 (16:48 +0000)]
Reviewed by Justin Garcia.
- fixed <rdar://problem/
4151619> Safari changes "\" characters to "/" in the query part of links that start with "?"
Test cases added:
* layout-tests/fast/dom/anchor-backslash-expected.txt: Added.
* layout-tests/fast/dom/anchor-backslash.html: Added.
* kwq/KWQKURL.mm: (substituteBackslashes): Fix error where we'd ignore
"?" and "#" characters if they were the first character in the string.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9481
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Fri, 24 Jun 2005 05:59:09 +0000 (05:59 +0000)]
* khtml/html/html_formimpl.cpp: (DOM::HTMLTextAreaElementImpl::setValue):
Took out an unneeded type cast (meant to do that before committing).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9480
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Fri, 24 Jun 2005 05:53:31 +0000 (05:53 +0000)]
Reviewed and landed by Darin Adler.
Test cases added:
* layout-tests/fast/forms/selection-functions-expected.txt: Added.
* layout-tests/fast/forms/selection-functions.html: Added.
* layout-tests/fast/forms/textarea-crlf-expected.txt: Added.
* layout-tests/fast/forms/textarea-crlf.html: Added.
- Fixes bug <http://bugzilla.opendarwin.org/show_bug.cgi?id=3401>.
Also fixes issue where setting text of a textarea in code and then
retrieving it would leave the \r\n sequences in the text, despite
the textarea translating to \n in all other cases.
* khtml/ecma/kjs_html.h:
* khtml/ecma/kjs_html.cpp:
(KJS::getInputSelectionStart):
(KJS::getInputSelectionEnd):
(KJS::KJS::HTMLElement::getValueProperty):
(KJS::KJS::HTMLElement::hasProperty):
(KJS::KJS::HTMLElementFunction::tryCall):
(KJS::HTMLElement::putValue):
* khtml/html/html_formimpl.cpp:
(DOM::HTMLInputElementImpl::canHaveSelection):
(DOM::HTMLInputElementImpl::selectionStart):
(DOM::HTMLInputElementImpl::selectionEnd):
(DOM::HTMLInputElementImpl::setSelectionStart):
(DOM::HTMLInputElementImpl::setSelectionEnd):
(DOM::HTMLInputElementImpl::setSelectionRange):
(DOM::HTMLInputElementImpl::setValue):
(DOM::HTMLTextAreaElementImpl::selectionStart):
(DOM::HTMLTextAreaElementImpl::selectionEnd):
(DOM::HTMLTextAreaElementImpl::setSelectionStart):
(DOM::HTMLTextAreaElementImpl::setSelectionEnd):
(DOM::HTMLTextAreaElementImpl::setSelectionRange):
(DOM::HTMLTextAreaElementImpl::setValue):
* khtml/html/html_formimpl.h:
* khtml/rendering/render_form.cpp:
(RenderLineEdit::selectionStart):
(RenderLineEdit::selectionEnd):
(RenderLineEdit::setSelectionStart):
(RenderLineEdit::setSelectionEnd):
(RenderLineEdit::setSelectionRange):
(RenderTextArea::selectionStart):
(RenderTextArea::selectionEnd):
(RenderTextArea::setSelectionStart):
(RenderTextArea::setSelectionEnd):
(RenderTextArea::select):
(RenderTextArea::setSelectionRange):
* khtml/rendering/render_form.h:
* kwq/KWQLineEdit.h:
* kwq/KWQLineEdit.mm:
(QLineEdit::setCursorPosition):
(QLineEdit::cursorPosition):
(QLineEdit::selectAll):
(QLineEdit::selectionStart):
(QLineEdit::selectedText):
(QLineEdit::setSelection):
* kwq/KWQTextArea.h:
* kwq/KWQTextArea.mm:
(-[KWQTextArea setSelectedRange:]):
(-[KWQTextArea selectedRange]):
(-[KWQTextArea getCursorPositionAsIndex:inParagraph:]):
(RangeOfParagraph):
* kwq/KWQTextEdit.h:
* kwq/KWQTextEdit.mm:
(QTextEdit::getCursorPosition):
(QTextEdit::selectionStart):
(QTextEdit::selectionEnd):
(QTextEdit::setSelectionStart):
(QTextEdit::setSelectionEnd):
(QTextEdit::selectAll):
(QTextEdit::setSelectionRange):
* kwq/KWQTextField.h:
* kwq/KWQTextField.mm:
(-[KWQTextFieldController selectedRange]):
(-[KWQTextFieldController setSelectedRange:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9479
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Thu, 23 Jun 2005 21:52:17 +0000 (21:52 +0000)]
Patch by Eric Seidel <macdome@opendarwin.org>
Adds QTextIStream, QTextOStream to KWQ
Reviewed by Darin
Test cases added: None required
* kwq/KWQTextStream.h:
(QTextIStream::QTextIStream):
(QTextOStream::QTextOStream):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9478
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Thu, 23 Jun 2005 21:25:49 +0000 (21:25 +0000)]
Patch by Eric Seidel <macdome@opendarwin.org>
This patch contains several small additions to KWQ
Reviewed by Darin
Test cases added: None required
* kwq/KWQApplication.h:
(QApplication::palette):
* kwq/KWQDateTime.h:
(QDateTime::time):
* kwq/KWQDict.h:
(QDict::operator[]):
(QDictIterator::operator*):
* kwq/KWQKDebug.h:
(kdbgstream::operator<<):
* kwq/KWQMemArray.h:
(QMemArray::duplicate):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9477
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
harrison [Thu, 23 Jun 2005 19:47:50 +0000 (19:47 +0000)]
Test cases added: None needed for this debug-only utility code.
- Make showTree() const.
- Add showTree() for InlineBox.
- Add showTree() for RenderObject.
* khtml/editing/selection.cpp:
(khtml::Selection::showTree):
* khtml/editing/selection.h:
* khtml/editing/visible_position.cpp:
(khtml::VisiblePosition::showTree):
* khtml/editing/visible_position.h:
Make showTree() const.
* khtml/rendering/render_line.cpp:
(khtml::InlineBox::showTree):
* khtml/rendering/render_line.h:
Add showTree() for InlineBox.
* khtml/rendering/render_object.cpp:
(RenderObject::showTree):
* khtml/rendering/render_object.h:
Add showTree() for RenderObject.
* khtml/xml/dom_nodeimpl.cpp:
(appendAttributeDesc):
(NodeImpl::showNode):
(NodeImpl::showTree):
(NodeImpl::showTreeAndMark):
* khtml/xml/dom_nodeimpl.h:
Make showTree() const.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9476
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vicki [Thu, 23 Jun 2005 19:13:57 +0000 (19:13 +0000)]
- added template to be used when writing manual tests
* manual-tests/template.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9475
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Thu, 23 Jun 2005 15:00:36 +0000 (15:00 +0000)]
* Scripts/webkitdirs.pm: Fixed a regular expression in the code I just landed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9474
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Thu, 23 Jun 2005 14:53:16 +0000 (14:53 +0000)]
Changes based on input from Michael Kahl.
* Scripts/cvs-create-patch: Added code to handle getting changes in the top-level
directory passed in.
* Scripts/webkitdirs.pm: Eliminate use of changing the current directory and using
getcwd() in the code to find the base product dir. Added code to handle unusual
base product directory values that use SRCROOT.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9473
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Thu, 23 Jun 2005 03:15:27 +0000 (03:15 +0000)]
- added forwarding headers as needed for Eric Seidel's KDOM work
see <http://bugzilla.opendarwin.org/show_bug.cgi?id=3655>
* ForwardingHeaders/kjs/value.h: Added.
* ForwardingHeaders/qintdict.h: Added an include.
* ForwardingHeaders/qptrcollection.h: Added.
* ForwardingHeaders/qsize.h: Added.
* kwq/KWQIntDict.h: Added. Empty file.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9472
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan [Wed, 22 Jun 2005 21:32:09 +0000 (21:32 +0000)]
Reviewed by Chris Blumenberg.
- fixed <rdar://problem/
3764645> please add a way to allow WebKit clients to override the WebPDFView context menu
* PublicHeaderChangesFromTiger.txt: Added.
New file to keep track of changes made to public headers that haven't been through API review yet.
Initially lists the WebMenuItem enum tags added to WebUIDelegate.h as part of this change.
* WebView.subproj/WebDefaultContextMenuDelegate.m:
(-[WebDefaultUIDelegate appendDefaultItems:toArray:]):
new method, handles initial separator
(-[WebDefaultUIDelegate contextMenuItemsForElement:defaultMenuItems:]):
now has defaultMenuItems: parameter. Any menu items in this array are appended at the end of
the standard set.
(-[WebDefaultUIDelegate editingContextMenuItemsForElement:defaultMenuItems:]):
ditto
(-[WebDefaultUIDelegate webView:contextMenuItemsForElement:defaultMenuItems:]):
This had a defaultMenuItems parameter before but it was always nil. Now it passes the defaultMenuItems
parameter on to the two methods that construct lists (one for editing, the other for viewing). Also
tweaked variable name and type for clarity.
* WebView.subproj/WebHTMLView.m:
(-[WebHTMLView menuForEvent:]):
passes nil for new defaultItems parameter of _menuForElement:
* WebView.subproj/WebImageView.m:
(-[WebImageView menuForEvent:]):
ditto
* WebView.subproj/WebTextView.m:
(-[WebTextView menuForEvent:]):
ditto
* WebView.subproj/WebPDFView.m:
(-[WebPDFView elementAtPoint:]):
new method to create the element dictionary needed for _menuForElement:defaultItems:. Only supplies the
webFrame at this point.
(-[WebPDFView _menuItemsFromPDFKitForEvent:]):
new method to return copies of the menu items that PDFKit would include in the context menu, with
WebKit tags applied
(-[WebPDFView menuForEvent:]):
now calls standard WebKit context menu mechanism, so clients' delegates can modify the context menu as
desired. The initial set of items are the ones WebKit was already displaying for PDF context menus.
* WebView.subproj/WebUIDelegate.h:
added enum values for the menu items in the PDF context menu
* WebView.subproj/WebViewPrivate.h:
* WebView.subproj/WebView.m:
(-[WebView _menuForElement:defaultItems:]):
Added the defaultItems: parameter to this method, which is then passed along to WebDefaultUIDelegate.
All callers pass nil except for WebPDFView, at least for now.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9471
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Wed, 22 Jun 2005 21:05:59 +0000 (21:05 +0000)]
Reviewed by Vicki.
Test cases added:
* layout-tests/fast/css/apple-prefix-expected.txt: Added.
* layout-tests/fast/css/apple-prefix.html: Added.
- fixed <rdar://problem/
4141650> REGRESSION: Safari RSS slider broken with TOT WebCore
* khtml/css/parser.y:
(getPropertyID): Fix lifetime problem on the QString. Also construct the QString
using length, since the passed-in char * is not necessarily null-terminated. Also do
the mapping only if it's a "-apple-" prefix -- the old code would do it for, e.g.,
"-applex-" too. The old code would not successfully map the "apple" in "appleLineClamp"
to "khtml", and Dave changed things so that the internal name of all CSS attributes
is "khtml" back in his 2005-05-03 check-in, breaking the use of appleLineClamp in RSS.
(getValueID): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9470
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Wed, 22 Jun 2005 18:23:46 +0000 (18:23 +0000)]
Added more bug numbers to the change log.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9467
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Wed, 22 Jun 2005 18:22:03 +0000 (18:22 +0000)]
Reviewed and landed by Darin Adler.
Test cases added:
* layout-tests/fast/dom/title-text-property-expected.txt: Added
* layout-tests/fast/dom/title-text-property.html: Added
* layout-tests/fast/dom/title-text-property-expected-2.txt: Added
* layout-tests/fast/dom/title-text-property-2.html: Added
Fixed <http://bugzilla.opendarwin.org/show_bug.cgi?id=3586>
Setting and getting title's text attribute does not work
* khtml/dom/html_head.cpp:
(HTMLTitleElement::text):
(HTMLTitleElement::setText):
Call HTMLTitleElementImpl::text() and ::setText().
* khtml/html/html_headimpl.cpp:
(HTMLTitleElementImpl::HTMLTitleElementImpl):
(HTMLTitleElementImpl::insertedIntoDocument):
(HTMLTitleElementImpl::removedFromDocument):
(HTMLTitleElementImpl::childrenChanged):
Pass the current title node to DocumentImpl::setTitle
and ::removeTitle.
(HTMLTitleElementImpl::text):
Return the title.
(HTMLTitleElementImpl::setText):
Set the new title.
* khtml/xml/dom_docimpl.cpp:
(DocumentImpl::DocumentImpl):
(DocumentImpl::~DocumentImpl):
(DocumentImpl::updateTitle):
(DocumentImpl::setTitle):
(DocumentImpl::removeTitle):
* khtml/xml/dom_docimpl.h:
Only update the title if it's done by setting document.title
or by changing the child nodes of the title element.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9466
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Wed, 22 Jun 2005 18:01:02 +0000 (18:01 +0000)]
Change by Anders Carlsson.
- added support for dumping title changes
* DumpRenderTree/DumpRenderTree.m:
(-[WaitUntilDoneDelegate webView:didReceiveTitle:forFrame:]): Added. Dump title change
if requested by JavaScript.
(+[LayoutTestController isSelectorExcludedFromWebScript:]): Added dumpTitleChanges.
(-[LayoutTestController dumpTitleChanges]): Added, sets flag.
(dumpRenderTree): Start flag as NO.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9465
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Wed, 22 Jun 2005 17:39:53 +0000 (17:39 +0000)]
Changes by Mitz Pettel.
Reviewed by me.
- fixed <http://bugzilla.opendarwin.org/show_bug.cgi?id=3633>
Layout order of bidi level runs is incorrect
Test cases added:
* layout-tests/fast/text/international/bidi-L2-run-reordering-expected.txt: Added.
* layout-tests/fast/text/international/bidi-L2-run-reordering.html: Added.
* khtml/rendering/bidi.cpp: (khtml::RenderBlock::bidiReorderLine): Fixed mistake
where we'd advance too far after reversing a run.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9464
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Wed, 22 Jun 2005 17:29:28 +0000 (17:29 +0000)]
- added test case for JavaScriptCore fix
* layout-tests/fast/js/string-replace-2-expected.txt: Added.
* layout-tests/fast/js/string-replace-2.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9463
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Wed, 22 Jun 2005 17:26:17 +0000 (17:26 +0000)]
Change by Anders Carlsson.
Reviewed by me.
- fixed <http://bugzilla.opendarwin.org/show_bug.cgi?id=3294>
String.prototype.replace() fails with function as second param
* kjs/string_object.cpp: (replace): Added code to handle functions.
* tests/mozilla/expected.html: Updated since ecma_3/RegExp/regress-209067.js is fixed now.
* tests/mozilla/run-mozilla-tests: Fix a minor coding style issue that leads to a warning each
time we run the tests.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9462
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Wed, 22 Jun 2005 16:44:08 +0000 (16:44 +0000)]
Change by Mitz Pettel.
Reviewed by me.
- fixed <http://bugzilla.opendarwin.org/show_bug.cgi?id=3618>
RTL runs drawn by CG not reversed properly
* WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer _CG_drawRun:style:geometry:]):
Fix off-by-one mistake in order-swapping loops.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9461
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Wed, 22 Jun 2005 16:38:03 +0000 (16:38 +0000)]
Reviewed by John Sullivan.
Test cases added:
* layout-tests/fast/dom/css-set-property-exception-expected.txt: Added.
* layout-tests/fast/dom/css-set-property-exception.html: Added.
- fixed <http://bugzilla.opendarwin.org/show_bug.cgi?id=3616>
RSS search field, Dashboard widgets failing due to CSS exception
* khtml/ecma/kjs_css.cpp: (KJS::DOMCSSStyleDeclaration::tryPut):
Ignore exceptions when setting properties.
* layout-tests/fast/js/exception-linenums.html: Changed test case that
involved setting style to one that involved setting another property that
raises an exception when you try to set it (setting prefix on a text node).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9460
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Wed, 22 Jun 2005 16:20:01 +0000 (16:20 +0000)]
Change by Michael Gaiman.
Reviewed by me.
- fixed <http://bugzilla.opendarwin.org/show_bug.cgi?id=3436>
Missing implementation of -[NSData(WebNSDateExtras) _webkit_parseRFC822HeaderFields]
* Misc.subproj/WebNSDataExtras.h: Fixed name of category say NSData, not NSDate.
* Misc.subproj/WebNSDataExtras.m: (-[NSData _webkit_parseRFC822HeaderFields]): Fixed method name.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9459
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Wed, 22 Jun 2005 15:31:57 +0000 (15:31 +0000)]
Change proposed by Eric Seidel.
* WebCore.pbproj/project.pbxproj: Fix build rule to match the one in JavaScriptCore.
The one here accidentally had hard-coded paths in it and also had the $() vs. ${}
issue that broke building on Xcode 2.1 for no good reason (it didn't need $() or ${}).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9458
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Wed, 22 Jun 2005 04:38:53 +0000 (04:38 +0000)]
Patch from KevinBallard <kevin@sb.org>, reviewed by me.
- fix build for Xcode 2.1, use ${} for INPUT_FILE_BASE to fix build with Xcode 2.1
* WebCore.pbproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9457
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Wed, 22 Jun 2005 01:15:43 +0000 (01:15 +0000)]
- Fixes <rdar://problem/
4114192>.
- Fixes a crash in TOT Mail/Blot if you Edit -> Add Hyperlink on a Selection
that ends at the end of the document
- Fixes a problem in TOT Mail/Blot where Edit -> Add Hyperlink creates
a link one character beyond what is expected.
In replacement, during insertion, some special case code was being called inappropriately.
Reviewed by Harrison
Test cases added: None, requires manual interaction
* khtml/editing/replace_selection_command.cpp:
(khtml::ReplaceSelectionCommand::doApply): In "step 2" of a replacement, we should
only next() the insertion point if the special pre-insertion-merge actually occured.
mergeStart used to be the correct check for the occurence of a pre-insertion-merge, but
a bug fix made this not the case. A non-null m_lastNodeInserted correctly signals
that some pre-insertion merging occured.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9456
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Wed, 22 Jun 2005 00:48:49 +0000 (00:48 +0000)]
JavaScriptCore:
rolling out fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=3293, since it caused layout test failures.
fast/forms/element-by-name
fast/loader/loadInProgress
* ChangeLog:
* bindings/objc/objc_runtime.h:
* bindings/objc/objc_runtime.mm:
(ObjcFallbackObjectImp::hasProperty):
* bindings/runtime_array.cpp:
(RuntimeArrayImp::hasProperty):
* bindings/runtime_array.h:
* bindings/runtime_object.cpp:
(RuntimeObjectImp::hasProperty):
* bindings/runtime_object.h:
* kjs/array_instance.h:
* kjs/array_object.cpp:
(ArrayInstanceImp::hasProperty):
* kjs/function.cpp:
(KJS::FunctionImp::hasProperty):
(KJS::ActivationImp::hasProperty):
* kjs/function.h:
* kjs/object.cpp:
(KJS::ObjectImp::hasProperty):
* kjs/object.h:
* kjs/object_object.cpp:
(ObjectPrototypeImp::ObjectPrototypeImp):
(ObjectProtoFuncImp::call):
* kjs/object_object.h:
(KJS::ObjectProtoFuncImp::):
* kjs/string_object.cpp:
(StringInstanceImp::hasProperty):
* kjs/string_object.h:
* tests/mozilla/expected.html:
WebCore:
rolling out fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=3293, since it caused layout test failures.
fast/forms/element-by-name
fast/loader/loadInProgress
* ChangeLog:
* khtml/ecma/kjs_binding.h:
* khtml/ecma/kjs_css.cpp:
(KJS::DOMCSSStyleDeclaration::hasProperty):
* khtml/ecma/kjs_css.h:
* khtml/ecma/kjs_dom.cpp:
(KJS::DOMNodeList::hasProperty):
(KJS::DOMNamedNodeMap::hasProperty):
* khtml/ecma/kjs_dom.h:
* khtml/ecma/kjs_html.cpp:
(KJS::HTMLDocument::hasProperty):
(KJS::KJS::HTMLElement::hasProperty):
(KJS::KJS::HTMLCollection::hasProperty):
* khtml/ecma/kjs_html.h:
* khtml/ecma/kjs_window.cpp:
(KJS::Window::hasProperty):
(KJS::Konqueror::hasProperty):
* khtml/ecma/kjs_window.h:
* layout-tests/fast/js/eval-var-decl-expected.txt: Removed. This test used hasOwnProperty
* layout-tests/fast/js/eval-var-decl.html: Removed. This test used hasOwnProperty
* layout-tests/fast/js/hasOwnProperty-expected.txt: Removed.
* layout-tests/fast/js/hasOwnProperty.html: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9455
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Wed, 22 Jun 2005 00:23:09 +0000 (00:23 +0000)]
* WebCore.pbproj/project.pbxproj: Switched to a build rule rather than a build phase for the
.y files -- this gets rid of the problem where modifying the .y file would not cause sufficient
compilation.
* khtml/css/parser_wrapper.cpp: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9454
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Wed, 22 Jun 2005 00:22:55 +0000 (00:22 +0000)]
* JavaScriptCore.pbproj/project.pbxproj: Switched to a build rule rather than a build phase for
.y files -- this gets rid of the problem where modifying the .y file would not cause sufficient
compilation.
* kjs/grammar_wrapper.cpp: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9453
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Tue, 21 Jun 2005 23:02:19 +0000 (23:02 +0000)]
Patch from Anders Carlsson <andersca@mac.com>, reviewed by Darin.
Fixed: <http://bugzilla.opendarwin.org/show_bug.cgi?id=3450>
<rdar://problem/
3881901> String.replace() method not working when regex pattern contains {n, m}
* pcre/pcre.c: (pcre_compile): Remember the last char length so it can be subtracted correctly if needed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9452
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Tue, 21 Jun 2005 23:02:07 +0000 (23:02 +0000)]
Test cases for:
<http://bugzilla.opendarwin.org/show_bug.cgi?id=3450>
<rdar://problem/
3881901> String.replace() method not working when regex pattern contains {n, m}
* layout-tests/fast/js/string_replace-expected.txt: Added.
* layout-tests/fast/js/string_replace.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9451
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Tue, 21 Jun 2005 22:27:55 +0000 (22:27 +0000)]
Patch contributed by Niels Leenheer <niels.leenheer@gmail.com>
- fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=3370
(Safari can't handle strange frame dimensions)
Reviewed by Darin.
* khtml/dom/dom_string.cpp:
(DOM::DOMString::toCoordsArray):
* khtml/dom/dom_string.h:
* khtml/html/html_imageimpl.cpp:
(HTMLAreaElementImpl::parseMappedAttribute):
* khtml/xml/dom_atomicstring.h:
(DOM::AtomicString::toCoordsArray):
* khtml/xml/dom_stringimpl.cpp:
(DOM::parseLength):
(DOM::DOMStringImpl::toCoordsArray):
(DOM::DOMStringImpl::toLengthArray):
* khtml/xml/dom_stringimpl.h:
Test cases added:
* layout-tests/fast/frames/invalid-expected.txt: Added.
* layout-tests/fast/frames/invalid.html: Added.
* layout-tests/fast/frames/valid-expected.txt: Added.
* layout-tests/fast/frames/valid.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9450
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Tue, 21 Jun 2005 18:44:58 +0000 (18:44 +0000)]
- fixed <rdar://problem/
4155049> javascript function named as "opener" doesn't get called because of window.opener property
Test cases only, fix is in JavaScriptCore
Reviewed by cblu.
Test cases added:
* layout-tests/fast/js/global-opener-function-expected.txt: Added.
* layout-tests/fast/js/global-opener-function.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9449
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Tue, 21 Jun 2005 18:42:30 +0000 (18:42 +0000)]
- fixed <rdar://problem/
4155532> 'delete' succeeds on functions
- fixed <rdar://problem/
4155049> javascript function named as "opener" doesn't get called because of window.opener property
Reviewed by cblu.
* kjs/nodes.cpp:
(FuncDeclNode::processFuncDecl): Functions now have DontDelete and Internal attributes set when appropriate.
Test cases:
* tests/mozilla/expected.html: Updated for one new success.
- see also test case added in WebCore.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9448
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
harrison [Tue, 21 Jun 2005 18:11:10 +0000 (18:11 +0000)]
Reviewed by Justin.
- show class and style attributes for element nodes
- nil check the node being showTree'd
- add Position::showTree()
Test cases added: None needed for this debug-only utility code.
* khtml/editing/selection.cpp:
(khtml::Selection::showTree):
- nil check the node
* khtml/editing/visible_position.cpp:
(khtml::VisiblePosition::previousVisiblePosition):
- comments
(khtml::VisiblePosition::showTree):
- nil check the node
* khtml/xml/dom_nodeimpl.cpp:
(appendAttributeDesc):
(NodeImpl::showNode):
- show class and style attributes for element nodes
* khtml/xml/dom_position.cpp:
(DOM::Position::showTree):
* khtml/xml/dom_position.h:
- add Position::showTree()
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9447
268f45cc-cd09-0410-ab3c-
d52691b4dbfc