WebKit-https.git
10 years ago2011-09-18 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Mon, 19 Sep 2011 07:36:12 +0000 (07:36 +0000)]
2011-09-18  Ilya Tikhonovsky  <loislo@chromium.org>

        Web Inspector: requestAnimationFrame callbacks don't show up in the timeline panel.
        https://bugs.webkit.org/show_bug.cgi?id=67986

        Reviewed by Pavel Feldman.

        Test: inspector/timeline/timeline-animation-frame.html

WebCore:

        * English.lproj/localizedStrings.js:
        * bindings/v8/V8Proxy.cpp:
        (WebCore::V8Proxy::callFunction):
        (WebCore::V8Proxy::callFunctionWithoutFrame):
        (WebCore::V8Proxy::instrumentedCallFunction):
        * bindings/v8/V8Proxy.h:
        * bindings/v8/custom/V8CustomVoidCallback.cpp:
        (WebCore::invokeCallback):
        * dom/ScriptedAnimationController.cpp:
        (WebCore::ScriptedAnimationController::registerCallback):
        (WebCore::ScriptedAnimationController::cancelCallback):
        (WebCore::ScriptedAnimationController::serviceScriptedAnimations):
        * inspector/InspectorInstrumentation.cpp:
        (WebCore::InspectorInstrumentation::didRegisterAnimationFrameCallbackImpl):
        (WebCore::InspectorInstrumentation::didCancelAnimationFrameCallbackImpl):
        (WebCore::InspectorInstrumentation::willFireAnimationFrameEventImpl):
        (WebCore::InspectorInstrumentation::didFireAnimationFrameEventImpl):
        * inspector/InspectorInstrumentation.h:
        (WebCore::InspectorInstrumentation::willCallFunction):
        (WebCore::InspectorInstrumentation::didRegisterAnimationFrameCallback):
        (WebCore::InspectorInstrumentation::didCancelAnimationFrameCallback):
        (WebCore::InspectorInstrumentation::willFireAnimationFrameEvent):
        (WebCore::InspectorInstrumentation::didFireAnimationFrameEvent):
        * inspector/InspectorTimelineAgent.cpp:
        (WebCore::InspectorTimelineAgent::didRegisterAnimationFrameCallback):
        (WebCore::InspectorTimelineAgent::didCancelAnimationFrameCallback):
        (WebCore::InspectorTimelineAgent::willFireAnimationFrameEvent):
        (WebCore::InspectorTimelineAgent::didFireAnimationFrameEvent):
        * inspector/InspectorTimelineAgent.h:
        * inspector/TimelineRecordFactory.cpp:
        (WebCore::TimelineRecordFactory::createAnimationFrameCallbackData):
        * inspector/TimelineRecordFactory.h:
        * inspector/front-end/TimelineAgent.js:
        * inspector/front-end/TimelinePanel.js:
        (WebInspector.TimelinePanel):
        (WebInspector.TimelinePanel.prototype.get _recordStyles):
        (WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
        (WebInspector.TimelinePanel.prototype._clearPanel):
        (WebInspector.TimelinePanel.FormattedRecord):
        (WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
        (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):

        LayoutTests:

        * inspector/timeline/timeline-animation-frame-expected.txt: Added.
        * inspector/timeline/timeline-animation-frame.html: Added.
        * inspector/timeline/timeline-enum-stability-expected.txt:
        * platform/chromium/inspector/timeline/timeline-enum-stability-expected.txt:
        * platform/qt/Skipped: inspector/timeline/timeline-animation-frame.html was added to the skip list.
        * inspector/timeline/timeline-test.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[GTK] Fix distcheck build
carlosgc@webkit.org [Mon, 19 Sep 2011 07:31:19 +0000 (07:31 +0000)]
[GTK] Fix distcheck build
https://bugs.webkit.org/show_bug.cgi?id=68241

Reviewed by Martin Robinson.

Source/JavaScriptCore:

* GNUmakefile.list.am:

Source/WebCore:

* GNUmakefile.list.am:

Source/WebKit2:

* GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRebaseline navigator test for chromium-win-vista.
koz@chromium.org [Mon, 19 Sep 2011 06:50:06 +0000 (06:50 +0000)]
Rebaseline navigator test for chromium-win-vista.
https://bugs.webkit.org/show_bug.cgi?id=68334

Unreviewed. Rebaseline for navigator-detached-no-crash.

* platform/chromium-win-vista/fast/dom/navigator-detached-no-crash-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: chromium-win: "Save timeline data" does nothing.
loislo@chromium.org [Mon, 19 Sep 2011 05:34:39 +0000 (05:34 +0000)]
Web Inspector: chromium-win: "Save timeline data" does nothing.
https://bugs.webkit.org/show_bug.cgi?id=68313

windows shell API function GetSaveFileName doesn't accept file names with ':' symbol.

Reviewed by Pavel Feldman.

* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelineModel.prototype._saveToFile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemoved ProfilerServer.
mitz@apple.com [Mon, 19 Sep 2011 01:29:10 +0000 (01:29 +0000)]
Removed ProfilerServer.

Reviewed by Mark Rowe.

* JavaScriptCore.gypi:
* JavaScriptCore.xcodeproj/project.pbxproj:
* profiler/ProfilerServer.h: Removed.
* profiler/ProfilerServer.mm: Removed.
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
* wscript:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDFG JIT should inline Math.min, Math.max, and Math.sqrt
fpizlo@apple.com [Sun, 18 Sep 2011 22:29:41 +0000 (22:29 +0000)]
DFG JIT should inline Math.min, Math.max, and Math.sqrt
https://bugs.webkit.org/show_bug.cgi?id=68318

Reviewed by Gavin Barraclough.

Adds Math.min, Math.max, and Math.sqrt intrinsics. Adds support for
a function to have an intrinsic but not a thunk generator. This is
a 7% speed-up on access-nbody, and neutral elsewhere, mainly because
we're still not DFG compiling the bulk of the hot code in Kraken audio
benchmarks.

* create_hash_table:
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleMinMax):
(JSC::DFG::ByteCodeParser::handleIntrinsic):
* dfg/DFGIntrinsic.h:
* dfg/DFGNode.h:
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNode):
(JSC::DFG::Propagator::fixupNode):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* jit/JITStubs.cpp:
(JSC::JITThunks::hostFunctionStub):
* runtime/Lookup.cpp:
(JSC::setUpStaticFunctionSlot):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove two files from JavaScriptCore.gypi that were removed in r95240
thakis@chromium.org [Sun, 18 Sep 2011 21:35:46 +0000 (21:35 +0000)]
Remove two files from JavaScriptCore.gypi that were removed in r95240
https://bugs.webkit.org/show_bug.cgi?id=68327

Unreviewed, build warning fix.

* JavaScriptCore.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove special case handling of inline storage from the JIT
oliver@apple.com [Sun, 18 Sep 2011 18:38:43 +0000 (18:38 +0000)]
Remove special case handling of inline storage from the JIT
https://bugs.webkit.org/show_bug.cgi?id=68319

Reviewed by Gavin Barraclough.

Simplify logic used for reading and writing to property storage
by removing the special cases for inline storage.  This has no
perf impact.

* dfg/DFGRepatch.cpp:
(JSC::DFG::generateProtoChainAccessStub):
(JSC::DFG::tryBuildGetByIDList):
* jit/JIT.h:
* jit/JITPropertyAccess.cpp:
(JSC::JIT::compilePutDirectOffset):
(JSC::JIT::compileGetDirectOffset):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompileGetByIdSelfList):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::compilePutDirectOffset):
(JSC::JIT::compileGetDirectOffset):
(JSC::JIT::privateCompilePutByIdTransition):
(JSC::JIT::privateCompileGetByIdSelfList):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTry to fix the Chromium Mac build after r95391.
mitz@apple.com [Sun, 18 Sep 2011 18:18:26 +0000 (18:18 +0000)]
Try to fix the Chromium Mac build after r95391.

* WebCore.gyp/WebCore.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTry to fix the Chromium Mac build after r95391.
mitz@apple.com [Sun, 18 Sep 2011 18:05:02 +0000 (18:05 +0000)]
Try to fix the Chromium Mac build after r95391.

* WebCore.gyp/WebCore.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTry to fix the Chromium Mac build after r95391.
mitz@apple.com [Sun, 18 Sep 2011 17:27:31 +0000 (17:27 +0000)]
Try to fix the Chromium Mac build after r95391.

* WebCore.gypi: Updated for the renaming of ComplexTextController.cpp.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* platform/graphics/Font.h: Changed #if directives to include the Chromium Mac port.
* platform/graphics/SimpleFontData.h: Ditto.
* platform/graphics/mac/ComplexTextControllerCoreText.cpp: Changed the filename extension of this
Objective-C++ file to .mm.
* platform/graphics/mac/ComplexTextControllerCoreText.mm: Copied from Source/WebCore/platform/graphics/mac/ComplexTextControllerCoreText.cpp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSnow Leopard build fix after r95391.
mitz@apple.com [Sun, 18 Sep 2011 17:16:05 +0000 (17:16 +0000)]
Snow Leopard build fix after r95391.

* platform/graphics/mac/ComplexTextControllerCoreText.cpp:
(WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoLeopard build fix after r95391.
mitz@apple.com [Sun, 18 Sep 2011 17:02:31 +0000 (17:02 +0000)]
Leopard build fix after r95391.

* platform/graphics/mac/ComplexTextControllerATSUI.cpp:
(WebCore::ComplexTextController::collectComplexTextRunsForCharactersATSUI):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSource/WebCore: Allow Core Text to choose the fallback font for rendering a combining...
mitz@apple.com [Sun, 18 Sep 2011 16:52:31 +0000 (16:52 +0000)]
Source/WebCore: Allow Core Text to choose the fallback font for rendering a combining character sequence

Fixes <rdar://problem/7860281> Decomposed text is displayed incorrectly when Verdana is specified
https://bugs.webkit.org/show_bug.cgi?id=68287

Reviewed by Dave Hyatt.

Test: platform/mac/fast/text/combining-character-sequence-fallback.html

* WebCore.xcodeproj/project.pbxproj: Compile ComplexTextControllerCoreText.cpp as Objective-C++.
I am going to rename this file in a followup patch.

* platform/graphics/Font.h: Declared fontDataForCombiningCharacterSequence().

* platform/graphics/SimpleFontData.h: Declared canRenderCombiningCharacterSequence() and added
a member variable to cache the results of calling this function.

* platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ComplexTextController::offsetForPosition): Fixed a typo in a comment.
(WebCore::advanceByCombiningCharacterSequence): Added this helper function, which iterates over
characters until the end of a sequence of combining characters, zero-width joiners and zero-width
non-joiners. A single base characater followed by such a (possibly-empty) sequence is known as
a combining character sequence. This stretches the definition a little because the base character
may be a combining character as well. Returns false if an invalid UTF-16 sequence is encountered,
true otherwise.
(WebCore::ComplexTextController::collectComplexTextRuns): - Replaced the glyphData and nextGlyphData
variables each with a pair of variables, a SimpleFontData* and a boolean indicating whether a
character mapped to the missing glyph. This clarifies that this function does not use glyph IDs.
- Renamed the local variable newC to uppercaseCharacter.
- Changed to use advanceByCombiningCharacterSequence().
- Changed to use Font::fontDataForCombiningCharacterSequence() instead of Font::glyphDataForCharacter().
  If there are combining marks and none of the fonts in the fallback list can render the sequence alone,
  use the systemFallbackFontData() constant to indicate to collectComplexTextRunsForCharactersCoreText()
  to allow Core Text to perform its own fallback.
- Stopped checking isSmallCaps against nextIsSmallCaps. It was redundant, since the small caps FontData
  differs from the normal variant.
(WebCore::ComplexTextController::collectComplexTextRunsForCharacters): Moved the common logic to
handle the 0 fontData case from the ATSUI and Core Text continuations of this function into this function.

* platform/graphics/mac/ComplexTextController.h:
(WebCore::ComplexTextController::systemFallbackFontData): Added. This constant is used to indicate to
collectComplexTextRunsForCharactersCoreText() that it should allow Core Text to perform its own font
fallback.

* platform/graphics/mac/ComplexTextControllerATSUI.cpp:
(WebCore::ComplexTextController::collectComplexTextRunsForCharactersATSUI): Handle systemFallbackFontData()
by using the primary font data.

* platform/graphics/mac/ComplexTextControllerCoreText.cpp:
(-[CascadeList initWithFont:WebCore::character:]): Added.
(-[CascadeList count]): Added.
(-[CascadeList objectAtIndex:]): Added. Returns an entry from a cascade list of CTFontDescriptorRef
objects based on the font’s fallback list for the character. The list is initialized lazily.
(WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText): Handle systemFallbackFontData()
by allowing Core Text to perform font fallback, starting with a cascade list based on the font’s fallback
list and possibly continuing with system fallback.

* platform/graphics/mac/FontMac.mm:
(WebCore::Font::fontDataForCombiningCharacterSequence): Added. If the sequence is only a base character,
calls through to glyphDataForCharacter(). Otherwise, iterates over the font’s fallback list for the
base character (and the system fallback font for that character), returning the first font that can
render the sequence, or 0 if there is none.

* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::provideStringAndAttributes): Added this Core Text callback.
(WebCore::SimpleFontData::canRenderCombiningCharacterSequence): Added. Checks if Core Text can render
the sequence using only this font. Caches the result.

LayoutTests: <rdar://problem/7860281> Decomposed text is displayed incorrectly when Verdana is specified
https://bugs.webkit.org/show_bug.cgi?id=68287

Reviewed by Dave Hyatt.

* platform/mac/fast/text/combining-character-sequence-fallback.html: Added.
* platform/mac/platform/mac/fast/text/combining-character-sequence-fallback-expected.png: Added.
* platform/mac/platform/mac/fast/text/combining-character-sequence-fallback-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdated expected results for two tests after r95362.
mitz@apple.com [Sun, 18 Sep 2011 16:21:15 +0000 (16:21 +0000)]
Updated expected results for two tests after r95362.

* platform/mac/fast/dom/Window/window-properties-expected.txt:
* platform/mac/fast/dom/Window/window-property-descriptors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDFG JIT does not have full block-local CSE
fpizlo@apple.com [Sun, 18 Sep 2011 03:47:04 +0000 (03:47 +0000)]
DFG JIT does not have full block-local CSE
https://bugs.webkit.org/show_bug.cgi?id=68316

Reviewed by Oliver Hunt.

This adds block-local CSE to the DFG. CSE runs in the propagator just after
type propagation. It is part of the propagator itself because it needs to
use the propagator's internal data structures to determine which operations
may have side effects. Because it changes the live-ranges of nodes, the
virtual register allocator had to be moved into the propagator so that it
runs after CSE. To ensure that the back-end knows to keep the inputs to
any eliminated node alive for OSR, a new node type, Phantom, was introduced.
It is a no-op but prolonges the live-range of its inputs.

This is an 80% speed-up on imaging-gaussian-blur, and a 10% speed-up on
Kraken.

* JavaScriptCore.xcodeproj/project.pbxproj:
* dfg/DFGAliasTracker.h: Removed.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::parse):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
* dfg/DFGGraph.h:
(JSC::DFG::MethodCheckData::operator==):
(JSC::DFG::MethodCheckData::operator!=):
* dfg/DFGNode.h:
(JSC::DFG::Node::hasVirtualRegister):
(JSC::DFG::Node::setRefCount):
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::Propagator):
(JSC::DFG::Propagator::fixpoint):
(JSC::DFG::Propagator::propagateNode):
(JSC::DFG::Propagator::canonicalize):
(JSC::DFG::Propagator::computeStartIndex):
(JSC::DFG::Propagator::startIndex):
(JSC::DFG::Propagator::pureCSE):
(JSC::DFG::Propagator::globalVarLoadElimination):
(JSC::DFG::Propagator::getByValLoadElimination):
(JSC::DFG::Propagator::getMethodLoadElimination):
(JSC::DFG::Propagator::performSubstitution):
(JSC::DFG::Propagator::setReplacement):
(JSC::DFG::Propagator::performNodeCSE):
(JSC::DFG::Propagator::performBlockCSE):
(JSC::DFG::Propagator::localCSE):
(JSC::DFG::Propagator::allocateVirtualRegisters):
(JSC::DFG::propagate):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agomethod_check should repatch itself if it finds that the new structure(s)
fpizlo@apple.com [Sat, 17 Sep 2011 23:33:01 +0000 (23:33 +0000)]
method_check should repatch itself if it finds that the new structure(s)
are the result of transitions from the old structure(s)
https://bugs.webkit.org/show_bug.cgi?id=68294

Reviewed by Gavin Barraclough.

Previously a patched method_check would slow-path to get_by_id. Now it
slow-paths to method_check_update, which attempts to correct the
method_check due to structure transitions before bailing to get_by_id.

This is a 1-2% speed-up on some benchmarks and is not a slow-down
anywhere, leading to a 0.6% speed-up on the Kraken geomean.

* jit/JITPropertyAccess.cpp:
(JSC::JIT::patchMethodCallProto):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* jit/JITStubs.h:
* runtime/Structure.h:
(JSC::Structure::transitivelyTransitionedFrom):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFrameLoaderClient BackForwardList-related methods are unsued
mihaip@chromium.org [Sat, 17 Sep 2011 23:31:52 +0000 (23:31 +0000)]
FrameLoaderClient BackForwardList-related methods are unsued
https://bugs.webkit.org/show_bug.cgi?id=68293

Reviewed by Darin Adler.

Source/WebCore:

Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.

* history/BackForwardListImpl.cpp:
(WebCore::BackForwardListImpl::addItem):
(WebCore::BackForwardListImpl::goBack):
(WebCore::BackForwardListImpl::goForward):
(WebCore::BackForwardListImpl::goToItem):
(WebCore::BackForwardListImpl::setCapacity):
* loader/EmptyClients.h:
* loader/FrameLoaderClient.h:

Source/WebKit/chromium:

Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.

* src/FrameLoaderClientImpl.cpp:
* src/FrameLoaderClientImpl.h:

Source/WebKit/efl:

Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.

* WebCoreSupport/FrameLoaderClientEfl.cpp:
* WebCoreSupport/FrameLoaderClientEfl.h:

Source/WebKit/gtk:

Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.

* WebCoreSupport/FrameLoaderClientGtk.cpp:
* WebCoreSupport/FrameLoaderClientGtk.h:

Source/WebKit/haiku:

Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.

* WebCoreSupport/FrameLoaderClientHaiku.cpp:
* WebCoreSupport/FrameLoaderClientHaiku.h:

Source/WebKit/mac:

Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.

* WebCoreSupport/WebFrameLoaderClient.h:
* WebCoreSupport/WebFrameLoaderClient.mm:
* WebKit.order:

Source/WebKit/qt:

Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.

* WebCoreSupport/FrameLoaderClientQt.cpp:
* WebCoreSupport/FrameLoaderClientQt.h:

Source/WebKit/win:

Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.

* WebCoreSupport/WebFrameLoaderClient.cpp:
* WebCoreSupport/WebFrameLoaderClient.h:

Source/WebKit/wince:

Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.

* WebCoreSupport/FrameLoaderClientWinCE.cpp:
* WebCoreSupport/FrameLoaderClientWinCE.h:

Source/WebKit/wx:

Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.

* WebKitSupport/FrameLoaderClientWx.cpp:
* WebKitSupport/FrameLoaderClientWx.h:

Source/WebKit2:

Remove FrameLoaderClient methods that were added by r51629, since only
the old (since-deleted) Android port needed them.

* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=68307
hyatt@apple.com [Sat, 17 Sep 2011 23:12:16 +0000 (23:12 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=68307

Crash in border image cssText. Make sure to null check all the components, since they're all
optional now.

Reviewed by Sam Weinig.

Source/WebCore:

Added fast/borders/border-image-slice-omission.html

* css/CSSBorderImageValue.cpp:
(WebCore::CSSBorderImageValue::cssText):

LayoutTests:

* fast/borders/border-image-slice-omission.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRework script context creation/release notifications
aa@chromium.org [Sat, 17 Sep 2011 22:47:09 +0000 (22:47 +0000)]
Rework script context creation/release notifications
https://bugs.webkit.org/show_bug.cgi?id=67828

Reviewed by Adam Barth.

Source/WebCore:

* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::disposeContextHandles):
(WebCore::V8DOMWindowShell::initContextIfNeeded):
* bindings/v8/V8IsolatedContext.cpp:
(WebCore::V8IsolatedContext::V8IsolatedContext):
(WebCore::V8IsolatedContext::destroy):
* bindings/v8/V8IsolatedContext.h:
* loader/EmptyClients.h:
(WebCore::EmptyFrameLoaderClient::didCreateScriptContext):
(WebCore::EmptyFrameLoaderClient::willReleaseScriptContext):
* loader/FrameLoaderClient.h:

Source/WebKit/chromium:

* public/WebFrameClient.h:
(WebKit::WebFrameClient::didCreateScriptContext):
(WebKit::WebFrameClient::didDestroyScriptContext):
(WebKit::WebFrameClient::willReleaseScriptContext):
* src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::didCreateScriptContext):
(WebKit::FrameLoaderClientImpl::willReleaseScriptContext):
* src/FrameLoaderClientImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt][WK2] fast/events/media-element-focus-tab.html fails
ossy@webkit.org [Sat, 17 Sep 2011 20:10:01 +0000 (20:10 +0000)]
[Qt][WK2] fast/events/media-element-focus-tab.html fails
https://bugs.webkit.org/show_bug.cgi?id=68315

* platform/qt-wk2/Skipped: Skip fast/events/media-element-focus-tab.html until fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: file open dialog appears when user clicks on the timeline bar in timel...
loislo@chromium.org [Sat, 17 Sep 2011 17:43:36 +0000 (17:43 +0000)]
Web Inspector: file open dialog appears when user clicks on the timeline bar in timeline panel.
https://bugs.webkit.org/show_bug.cgi?id=68312

Reviewed by Pavel Feldman.

       * inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._createFileSelector):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix after r95372.
jeffm@apple.com [Sat, 17 Sep 2011 15:58:50 +0000 (15:58 +0000)]
Build fix after r95372.

* dom/DOMAllInOne.cpp: #include "EventListenerMap.cpp"

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoOverride supportsFocus() for HTMLMediaElement.
commit-queue@webkit.org [Sat, 17 Sep 2011 10:57:17 +0000 (10:57 +0000)]
Override supportsFocus() for HTMLMediaElement.
https://bugs.webkit.org/show_bug.cgi?id=67190

Patch by Deepak Sherveghar <bpwv64@motorola.com> on 2011-09-17
Reviewed by Antonio Gomes.

Source/WebCore:

Tests: fast/events/media-element-focus-tab.html
       fast/spatial-navigation/snav-media-elements.html

Return true from supportsFocus() if control's attribute is present or a tabindex is specified.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::supportsFocus):
* html/HTMLMediaElement.h:

LayoutTests:

For media elements be able to receive focus without tabindex if
control attribute is present, hence changed
tabindex-focus-blur-all.js and tabindex-focus-blur-all-expected.txt.

* fast/events/media-element-focus-tab-expected.txt: Added.
* fast/events/media-element-focus-tab.html: Added.
* fast/events/resources/tabindex-focus-blur-all.js:
(test):
* fast/events/tabindex-focus-blur-all-expected.txt:
* fast/spatial-navigation/snav-media-elements-expected.txt: Added.
* fast/spatial-navigation/snav-media-elements.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium]The focus of an input field inside an Iframe doesn't get cleared even thoug...
commit-queue@webkit.org [Sat, 17 Sep 2011 09:49:26 +0000 (09:49 +0000)]
[chromium]The focus of an input field inside an Iframe doesn't get cleared even though clearFocusedNode is called.
https://bugs.webkit.org/show_bug.cgi?id=68162

Add a unit-test to check whether the focus of node is get cleared when clearFocusNode called.
This test check for focus of input node inside a frame after clear focus get called.
Patch by chandra shekar vallala <chandra.vallala@motorola.com> on 2011-09-17
Reviewed by Adam Barth.

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::clearFocusedNode):
* tests/WebFrameTest.cpp:
(WebKit::TEST_F): Added a unit test to make sure that focus of the node is get cleared.
* tests/data/autofocus_input_field_iframe.html: Added.
* tests/data/iframe_clear_focused_node_test.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[EFL] Bump minimum requirement for cairo to 1.10.
ryuan.choi@samsung.com [Sat, 17 Sep 2011 09:28:13 +0000 (09:28 +0000)]
[EFL] Bump minimum requirement for cairo to 1.10.
https://bugs.webkit.org/show_bug.cgi?id=68226

Reviewed by Adam Barth.

* Source/cmake/FindCairo.cmake: Check required version.
* Source/cmake/OptionsEfl.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Unreviewed gardening.
ossy@webkit.org [Sat, 17 Sep 2011 09:08:24 +0000 (09:08 +0000)]
[Qt] Unreviewed gardening.

* platform/qt-4.8/editing/deleting/merge-whitespace-pre-expected.txt: Update after r95335.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt][WK2] Unreviewed gardening after r95337.
ossy@webkit.org [Sat, 17 Sep 2011 08:59:26 +0000 (08:59 +0000)]
[Qt][WK2] Unreviewed gardening after r95337.

* platform/qt-wk2/Skipped: Skip one more test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt][WK2] fast/forms/submit-to-blank-multiple-times.html fails
ossy@webkit.org [Sat, 17 Sep 2011 08:06:58 +0000 (08:06 +0000)]
[Qt][WK2] fast/forms/submit-to-blank-multiple-times.html fails
https://bugs.webkit.org/show_bug.cgi?id=68309

* platform/qt-wk2/Skipped: Skip fast/forms/submit-to-blank-multiple-times.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt][WK2] Unreviewed gardening after r95335.
ossy@webkit.org [Sat, 17 Sep 2011 07:57:56 +0000 (07:57 +0000)]
[Qt][WK2] Unreviewed gardening after r95335.

* platform/qt-wk2/Skipped: Skip new failing tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Unreviewed gardening.
ossy@webkit.org [Sat, 17 Sep 2011 07:49:33 +0000 (07:49 +0000)]
[Qt] Unreviewed gardening.

* platform/qt/Skipped: Skip plugins/fullscreen-plugins-dont-reload.html, because ENABLE(FULLSCREEN_API) is disabled on Qt.
* platform/qt/fast/dom/Window/window-properties-expected.png: Updated after r95362.
* platform/qt/fast/dom/Window/window-properties-expected.txt: Updated after r95362.
* platform/qt/fast/dom/Window/window-property-descriptors-expected.png: Updated after r95362.
* platform/qt/fast/dom/Window/window-property-descriptors-expected.txt: Updated after r95362.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRename ENABLE(LEVELDB) to USE(LEVELDB)
abarth@webkit.org [Sat, 17 Sep 2011 06:52:28 +0000 (06:52 +0000)]
Rename ENABLE(LEVELDB) to USE(LEVELDB)
https://bugs.webkit.org/show_bug.cgi?id=68290

Reviewed by Darin Adler.

Source/WebCore:

LEVELDB is a library that can be used to implemented INDEXED_DATABASE,
which means it should be a USE not an ENABLE.

* CMakeLists.txt:
* WebCore.gyp/WebCore.gyp:
* platform/leveldb/LevelDBComparator.h:
* platform/leveldb/LevelDBDatabase.cpp:
* platform/leveldb/LevelDBDatabase.h:
* platform/leveldb/LevelDBIterator.h:
* platform/leveldb/LevelDBSlice.h:
* platform/leveldb/LevelDBTransaction.cpp:
* platform/leveldb/LevelDBTransaction.h:
* platform/leveldb/LevelDBWriteBatch.cpp:
* platform/leveldb/LevelDBWriteBatch.h:
* storage/IDBFactoryBackendImpl.cpp:
(WebCore::IDBFactoryBackendImpl::open):
(WebCore::IDBFactoryBackendImpl::migrateFromSQLiteToLevelDB):
* storage/IDBLevelDBBackingStore.cpp:
* storage/IDBLevelDBBackingStore.h:
* storage/IDBLevelDBCoding.cpp:
* storage/IDBLevelDBCoding.h:

Source/WebKit/chromium:

* features.gypi:
* tests/IDBLevelDBCodingTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoReduce EventTarget memory usage by deferring hash map allocation
commit-queue@webkit.org [Sat, 17 Sep 2011 06:34:05 +0000 (06:34 +0000)]
Reduce EventTarget memory usage by deferring hash map allocation
until there are listeners for more than 1 event type.

http://webkit.org/b/68105

Patch by Andreas Kling <kling@webkit.org> on 2011-09-16
Reviewed by Darin Adler.

Introduce an EventListenerMap class which manages a map of event types that have
one or more listeners connected.

When there is only one event type, it's stored directly on the EventListenerMap
internally, and when more are added it moves to a hash map. It only goes back
from the hash map if all the listeners are removed at once (i.e clear() is called.)

* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:

    Adding files.

* WebCore.exp.in:

    Export EventListenerMap::contains() for WebKit/mac.

* dom/EventListenerMap.cpp: Added.
(WebCore::EventListenerMap::EventListenerMap):
(WebCore::EventListenerMap::~EventListenerMap):
(WebCore::EventListenerMap::isEmpty):
(WebCore::EventListenerMap::contains):
(WebCore::EventListenerMap::clear):
(WebCore::EventListenerMap::eventTypes):
(WebCore::addListenerToVector):
(WebCore::EventListenerMap::add):
(WebCore::removeListenerFromVector):
(WebCore::EventListenerMap::remove):
(WebCore::EventListenerMap::find):
(WebCore::removeFirstListenerCreatedFromMarkup):
(WebCore::EventListenerMap::removeFirstEventListenerCreatedFromMarkup):
(WebCore::copyListenersNotCreatedFromMarkupToTarget):
(WebCore::EventListenerMap::copyEventListenersNotCreatedFromMarkupToTarget):
(WebCore::EventListenerIterator::EventListenerIterator):
(WebCore::EventListenerIterator::nextListener):
* dom/EventListenerMap.h: Added.

* dom/EventTarget.cpp:
(WebCore::EventTargetData::~EventTargetData):
(WebCore::EventTarget::addEventListener):
(WebCore::EventTarget::removeEventListener):
(WebCore::EventTarget::fireEventListeners):
(WebCore::EventTarget::getEventListeners):
(WebCore::EventTarget::removeAllEventListeners):

* dom/EventTarget.h:
(WebCore::EventTarget::visitJSEventListeners):

    Use EventListenerIterator to visit listeners. (JSC specific.)

* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::getEventListenersForNode):

    Call EventListenerMap::eventTypes() go get the list of event types
    currently listened for.

* dom/Node.cpp:
(WebCore::Node::removeEventListener):
* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::transferEventListenersToShadowTree):

    Move implementations of SVG-specific hacks into EventListenerMap and
    call them from here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDon't detach elements from the render tree when entering fullscreen mode
koz@chromium.org [Sat, 17 Sep 2011 06:07:42 +0000 (06:07 +0000)]
Don't detach elements from the render tree when entering fullscreen mode
https://bugs.webkit.org/show_bug.cgi?id=66531

Source/WebCore:

This prevents plugin instances from being destroyed and reinstantiated
when entering fullscreen mode.

Reviewed by James Robinson.

Test: plugins/fullscreen-plugins-dont-reload.html

* dom/Document.cpp:
(WebCore::Document::webkitWillEnterFullScreenForElement):
(WebCore::Document::webkitDidExitFullScreenForElement):
* dom/NodeRenderingContext.cpp:
(WebCore::NodeRendererFactory::createRendererIfNeeded):
* rendering/RenderFullScreen.cpp:
(createFullScreenStyle):
(RenderFullScreen::wrapRenderer):
(RenderFullScreen::unwrapRenderer):
* rendering/RenderFullScreen.h:

LayoutTests:

Test that the plugin is not reloaded when entering fullscreen.

Reviewed by James Robinson.

* plugins/fullscreen-plugins-dont-reload-expected.txt: Added.
* plugins/fullscreen-plugins-dont-reload.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoadd non-CG Webkit-Mac builds to flakiness dashboard
commit-queue@webkit.org [Sat, 17 Sep 2011 05:53:51 +0000 (05:53 +0000)]
add non-CG Webkit-Mac builds to flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=68265

Patch by Elliot Poger <epoger@google.com> on 2011-09-16
Reviewed by Adam Barth.

As Chromium-on-Mac approaches the switchover from Core Graphics to
Skia, we need to add the Skia version to the flakiness dashboard.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:
* TestResultServer/static-dashboards/builders.js:
* TestResultServer/static-dashboards/flakiness_dashboard_tests.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSource/WebCore: Rename FrameLoaderClient::allowImages to FrameLoaderClient::allowImag...
jochen@chromium.org [Sat, 17 Sep 2011 05:52:07 +0000 (05:52 +0000)]
Source/WebCore: Rename FrameLoaderClient::allowImages to FrameLoaderClient::allowImage and include the image URL as parameter
https://bugs.webkit.org/show_bug.cgi?id=68071

This will allow embedders to block images based on where the image is loaded from, instead of just blocking all images in a given frame.

Reviewed by Adam Barth.

* html/ImageDocument.cpp:
(WebCore::ImageDocumentParser::appendBytes):
* loader/FrameLoaderClient.h:
(WebCore::FrameLoaderClient::allowImage):
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::requestImage):

Source/WebKit/chromium: Rename FrameLoaderClient::allowImages to FrameLoaderClient::allowImage and include the image URL as parameter
https://bugs.webkit.org/show_bug.cgi?id=68071

Reviewed by Adam Barth.

* public/WebPermissionClient.h:
(WebKit::WebPermissionClient::allowImage):
* src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::allowImage):
* src/FrameLoaderClientImpl.h:

Tools: Rename FrameLoaderClient::allowImages to FrameLoaderClient::allowImage and include the image URL as parameter
https://bugs.webkit.org/show_bug.cgi?id=68071

Reviewed by Adam Barth.

* DumpRenderTree/chromium/WebPermissions.cpp:
(WebPermissions::allowImage):
* DumpRenderTree/chromium/WebPermissions.h:

LayoutTests: Add tests for FrameLoaderClient::allowImage.
https://bugs.webkit.org/show_bug.cgi?id=68071

Reviewed by Adam Barth.

* http/tests/permissionclient/resources/bostin.gif:
* http/tests/permissionclient/resources/redir.php:
* platform/chromium/permissionclient/image-permissions-expected.txt:
* platform/chromium/permissionclient/image-permissions.html:
* platform/http/tests/permissionclient/image-permissions-expected.txt:
* platform/http/tests/permissionclient/image-permissions.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=67733
dslomov@google.com [Sat, 17 Sep 2011 05:30:14 +0000 (05:30 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=67733
[Chromium] Separate WebKit initialization and V8 initialization in chromium port.

Reviewed by Darin Fisher.

* public/WebKit.h:
* src/WebKit.cpp:
(WebKit::initialize):
(WebKit::initializeWithoutV8):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] QTouchWebView missing loadProgress tests
commit-queue@webkit.org [Sat, 17 Sep 2011 05:24:58 +0000 (05:24 +0000)]
[Qt] QTouchWebView missing loadProgress tests
https://bugs.webkit.org/show_bug.cgi?id=68183

Patch by Gopal Raghavan <gopal.1.raghavan@nokia.com> on 2011-09-16
Reviewed by Chang Shu.

Added test case to check load progress for QTouchWebView

* UIProcess/API/qt/tests/qmltests/TouchWebView/tst_loadProgress.qml: Added.
* UIProcess/API/qt/tests/qmltests/qmltests.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake XSSAuditor truncate inline snippets at a reasonable length before comparison
commit-queue@webkit.org [Sat, 17 Sep 2011 05:16:07 +0000 (05:16 +0000)]
Make XSSAuditor truncate inline snippets at a reasonable length before comparison
respecting boundaries of multiply urlencoded sequences.
https://bugs.webkit.org/show_bug.cgi?id=68092

Patch by Tom Sepez <tsepez@chromium.org> on 2011-09-16
Reviewed by Adam Barth.

Source/WebCore:

Test: http/tests/security/xssAuditor/property-escape-long.html

* html/parser/XSSAuditor.cpp:
(WebCore::XSSAuditor::filterTokenAfterScriptStartTag):
(WebCore::XSSAuditor::eraseDangerousAttributesIfInjected):
(WebCore::XSSAuditor::eraseAttributeIfInjected):
(WebCore::XSSAuditor::decodedSnippetForAttribute):
(WebCore::XSSAuditor::isContainedInRequest):
* html/parser/XSSAuditor.h:

LayoutTests:

* http/tests/security/xssAuditor/property-escape-long-expected.txt: Added.
* http/tests/security/xssAuditor/property-escape-long.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove m_contentsDirty from LayerChromium because it
commit-queue@webkit.org [Sat, 17 Sep 2011 04:39:45 +0000 (04:39 +0000)]
Remove m_contentsDirty from LayerChromium because it
is redundant with m_dirtyRect.
https://bugs.webkit.org/show_bug.cgi?id=68213

Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-09-16
Reviewed by James Robinson.

Code cleanup towards unit testing.

* platform/graphics/chromium/Canvas2DLayerChromium.cpp:
(WebCore::Canvas2DLayerChromium::updateCompositorResources):
* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::paintContentsIfDirty):
* platform/graphics/chromium/ImageLayerChromium.cpp:
(WebCore::ImageLayerChromium::paintContentsIfDirty):
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::setNeedsDisplay):
(WebCore::LayerChromium::resetNeedsDisplay):
* platform/graphics/chromium/LayerChromium.h:
* platform/graphics/chromium/VideoLayerChromium.cpp:
(WebCore::VideoLayerChromium::updateCompositorResources):
* platform/graphics/chromium/WebGLLayerChromium.cpp:
(WebCore::WebGLLayerChromium::updateCompositorResources):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTouch Platform.h in the hope to fix SnowLeopard Intel Release (WebKit2 Tests).
rniwa@webkit.org [Sat, 17 Sep 2011 04:28:36 +0000 (04:28 +0000)]
Touch Platform.h in the hope to fix SnowLeopard Intel Release (WebKit2 Tests).

* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoupdate-webkit-chromium should retry the gclient call if it fails once
commit-queue@webkit.org [Sat, 17 Sep 2011 04:15:13 +0000 (04:15 +0000)]
update-webkit-chromium should retry the gclient call if it fails once
https://bugs.webkit.org/show_bug.cgi?id=68252

Patch by Tom Zakrajsek <tomz@codeaurora.org> on 2011-09-16
Reviewed by Adam Barth.

* Scripts/update-webkit-chromium:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSource/WebCore: https://bugs.webkit.org/show_bug.cgi?id=66714
dslomov@google.com [Sat, 17 Sep 2011 04:01:31 +0000 (04:01 +0000)]
Source/WebCore: https://bugs.webkit.org/show_bug.cgi?id=66714
Add webkitPostMessage to allow for adding transferable support.
This adds webkitPostMessage, currently identical to postMessage, which
would later be a vehicle for adding transferable support for messaging.

Based on patch by Luke Zarko.

Reviewed by David Levin.

* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::webkitPostMessage):
* bindings/js/JSDedicatedWorkerContextCustom.cpp:
(WebCore::JSDedicatedWorkerContext::webkitPostMessage):
* bindings/js/JSMessageEventCustom.cpp:
(WebCore::JSMessageEvent::webkitInitMessageEvent):
* bindings/js/JSMessagePortCustom.cpp:
(WebCore::JSMessagePort::webkitPostMessage):
* bindings/js/JSWorkerCustom.cpp:
(WebCore::JSWorker::postMessage):
(WebCore::JSWorker::webkitPostMessage):
* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::handlePostMessageCallback):
(WebCore::V8DOMWindow::postMessageCallback):
(WebCore::V8DOMWindow::webkitPostMessageCallback):
* bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:
(WebCore::handlePostMessageCallback):
(WebCore::V8DedicatedWorkerContext::postMessageCallback):
(WebCore::V8DedicatedWorkerContext::webkitPostMessageCallback):
* bindings/v8/custom/V8MessageEventCustom.cpp:
(WebCore::V8MessageEvent::initMessageEventCallback):
(WebCore::V8MessageEvent::webkitInitMessageEventCallback):
* bindings/v8/custom/V8MessagePortCustom.cpp:
(WebCore::handlePostMessageCallback):
(WebCore::V8MessagePort::postMessageCallback):
(WebCore::V8MessagePort::webkitPostMessageCallback):
* bindings/v8/custom/V8WorkerCustom.cpp:
(WebCore::handlePostMessageCallback):
(WebCore::V8Worker::postMessageCallback):
(WebCore::V8Worker::webkitPostMessageCallback):
* dom/MessageEvent.idl:
* dom/MessagePort.idl:
* page/DOMWindow.idl:
* workers/DedicatedWorkerContext.idl:
* workers/Worker.idl:

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=66714
Add webkitPostMessage to allow for adding transferable support.
This adds webkitPostMessage, currently identical to postMessage, which
would later be a vehicle for adding transferable support for messaging.
The tests ensure that webkitPostMessage and postMessage behave identically.

Based on patch by Luke Zarko.

Reviewed by David Levin.

* fast/dom/Window/window-postmessage-args-expected.txt:
* fast/dom/Window/window-postmessage-args.html:
* fast/dom/Window/window-property-descriptors-expected.txt:
* fast/events/message-port-expected.txt:
* fast/events/message-port.html:
* fast/workers/resources/worker-call.js:
* fast/workers/worker-call-expected.txt:
* platform/chromium/fast/dom/Window/window-postmessage-args-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChromium: Fix repaint of rubber-band overhang area under composited path
commit-queue@webkit.org [Sat, 17 Sep 2011 03:47:37 +0000 (03:47 +0000)]
Chromium: Fix repaint of rubber-band overhang area under composited path
https://bugs.webkit.org/show_bug.cgi?id=68246

I accidently removed these two lines from the last patch on: https://bugs.webkit.org/show_bug.cgi?id=66969

Patch by Alexei Svitkine <asvitkine@chromium.org> on 2011-09-16
Reviewed by James Robinson.

Test: platform/chromium-gpu/compositing/rubberbanding/transform-overhang-size-change.html

Source/WebCore:

* platform/ScrollView.cpp:
(WebCore::ScrollView::scrollContents):

LayoutTests:

* platform/chromium-gpu/compositing/rubberbanding/transform-overhang-size-change-expected.png: Added.
* platform/chromium-gpu/compositing/rubberbanding/transform-overhang-size-change-expected.txt: Added.
* platform/chromium-gpu/compositing/rubberbanding/transform-overhang-size-change.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemoved unwanted NotImplemented.h inclusion in WebKit2 GTK port & platform independen...
commit-queue@webkit.org [Sat, 17 Sep 2011 03:36:17 +0000 (03:36 +0000)]
Removed unwanted NotImplemented.h inclusion in WebKit2 GTK port & platform independent files
https://bugs.webkit.org/show_bug.cgi?id=68249

Patch by Ravi Phaneendra Kasibhatla <ravi.kasibhatla@motorola.com> on 2011-09-16
Reviewed by Martin Robinson.

* Shared/Plugins/NPIdentifierData.cpp: Removed NotImplemented.h inclusion.
* Shared/Plugins/NPRemoteObjectMap.cpp: Removed NotImplemented.h inclusion.
* Shared/Plugins/NPVariantData.cpp: Removed NotImplemented.h inclusion.
* UIProcess/gtk/WebContextGtk.cpp: Removed NotImplemented.h inclusion.
* WebProcess/Cookies/WebCookieManager.cpp: Removed NotImplemented.h inclusion.
* WebProcess/KeyValueStorage/WebKeyValueStorageManager.cpp: Removed NotImplemented.h inclusion.
* WebProcess/Plugins/Netscape/JSNPMethod.cpp: Removed NotImplemented.h inclusion.
* WebProcess/Plugins/Netscape/NPJSObject.cpp: Removed NotImplemented.h inclusion.
* WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp: Removed NotImplemented.h inclusion.
* WebProcess/WebCoreSupport/WebInspectorClient.cpp: Removed NotImplemented.h inclusion.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Add movementX/Y members to WebMouseEvent
scheib@chromium.org [Sat, 17 Sep 2011 03:23:07 +0000 (03:23 +0000)]
[Chromium] Add movementX/Y members to WebMouseEvent
https://bugs.webkit.org/show_bug.cgi?id=68174

Reviewed by Dimitri Glazkov.

* public/WebInputEvent.h:
(WebKit::WebMouseEvent::WebMouseEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRename APIValueWrapper type to APIValueWrapperType for consistency
weinig@apple.com [Sat, 17 Sep 2011 02:57:36 +0000 (02:57 +0000)]
Rename APIValueWrapper type to APIValueWrapperType for consistency
https://bugs.webkit.org/show_bug.cgi?id=68306

Reviewed by Anders Carlsson.

* runtime/JSAPIValueWrapper.h:
(JSC::JSAPIValueWrapper::createStructure):
Update name.

* runtime/JSType.h:
Update name and un-indent.

* runtime/Structure.h:
(JSC::JSCell::isAPIValueWrapper):
Update name.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove unused isStrictModeFunction function
weinig@apple.com [Sat, 17 Sep 2011 02:47:09 +0000 (02:47 +0000)]
Remove unused isStrictModeFunction function
https://bugs.webkit.org/show_bug.cgi?id=68305

Reviewed by Anders Carlsson.

* runtime/JSObject.h:
(JSC::JSObject::isStrictModeFunction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDepend on harfbuzz for OS=Android as well
commit-queue@webkit.org [Sat, 17 Sep 2011 02:42:16 +0000 (02:42 +0000)]
Depend on harfbuzz for OS=Android as well
https://bugs.webkit.org/show_bug.cgi?id=68239

Like GTK, Android depends on harfbuzz as well, so reflect that in
the project file. Furthermore, fix a compile error in PopupListBox.cpp
by explicitly including ctype.h, as isspace otherwise won't be declared.

Patch by Peter Beverloo <peter@chromium.org> on 2011-09-16
Reviewed by Steve Block.

* WebCore.gyp/WebCore.gyp:
* platform/chromium/PopupListBox.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRename flex-align values to match the spec
tony@chromium.org [Sat, 17 Sep 2011 02:40:27 +0000 (02:40 +0000)]
Rename flex-align values to match the spec
https://bugs.webkit.org/show_bug.cgi?id=67741

Reviewed by Ojan Vafai.

Source/WebCore:

* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EFlexAlign):
* css/CSSValueKeywords.in:
* rendering/style/RenderStyleConstants.h:

LayoutTests:

* css3/flexbox/css-properties-expected.txt:
* css3/flexbox/script-tests/css-properties.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[V8] REGRESSION(94783): calling the binding script during V8 context creation slows...
commit-queue@webkit.org [Sat, 17 Sep 2011 02:31:00 +0000 (02:31 +0000)]
[V8] REGRESSION(94783): calling the binding script during V8 context creation slows down page loads
https://bugs.webkit.org/show_bug.cgi?id=68237

Patch by Ulan Degenbaev <ulan@chromium.org> on 2011-09-16
Reviewed by Kenneth Russell.

Call the binding script lazily on the first run of the set() method of
a typed array.

* ../../Source/WebCore/WebCore.gypi:
* ../../Source/WebCore/bindings/v8/V8BindingScripts.cpp: Removed.
* ../../Source/WebCore/bindings/v8/V8BindingScripts.h: Removed.
* ../../Source/WebCore/bindings/v8/V8DOMWindowShell.cpp:
* ../../Source/WebCore/bindings/v8/WorkerContextExecutionProxy.cpp:
* ../../Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.cpp:
* ../../Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.h:
* ../../Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustomScript.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChromium pixel test rebaseline for r95335.
rniwa@webkit.org [Sat, 17 Sep 2011 02:24:26 +0000 (02:24 +0000)]
Chromium pixel test rebaseline for r95335.

* platform/chromium-cg-mac-leopard/editing/deleting/merge-whitespace-pre-expected.png: Added.
* platform/chromium-linux/editing/deleting/merge-whitespace-pre-expected.png:
* platform/chromium-mac/editing/deleting/merge-whitespace-pre-expected.png:
* platform/chromium-win-vista/editing: Removed.
* platform/chromium-win/editing/deleting/merge-whitespace-pre-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoImplement an ErrorEvent constructor for JSC
commit-queue@webkit.org [Sat, 17 Sep 2011 02:01:29 +0000 (02:01 +0000)]
Implement an ErrorEvent constructor for JSC
https://bugs.webkit.org/show_bug.cgi?id=68148

Patch by Kentaro Hara <haraken@chromium.org> on 2011-09-16
Reviewed by Sam Weinig.

Source/WebCore:

The spec for the ErrorEvent constructor is here:
http://dev.w3.org/html5/workers/#errorevent

Test: fast/events/constructors/error-event-constructor.html

* bindings/generic/EventConstructors.h: Added a definition for the ErrorEvent constructor.
* bindings/js/JSEventConstructors.cpp: Added #includes for ErrorEvent.
* dom/ErrorEvent.cpp:
(WebCore::ErrorEventInit::ErrorEventInit):
(WebCore::ErrorEvent::ErrorEvent):
(WebCore::ErrorEvent::initErrorEvent):
(WebCore::ErrorEvent::isErrorEvent):
* dom/ErrorEvent.h: Added a definition for ErrorEventInit.
(WebCore::ErrorEvent::create):
(WebCore::ErrorEvent::message):
(WebCore::ErrorEvent::filename):
(WebCore::ErrorEvent::lineno):
* dom/ErrorEvent.idl: Makes ErrorEvent constructible.

LayoutTests:

error-event-constructor.html checks the behavior of the ErrorEvent constructor.

* fast/dom/constructed-objects-prototypes-expected.txt: Now window has ErrorEvent.
* fast/events/constructors/error-event-constructor-expected.txt: Added.
* fast/events/constructors/error-event-constructor.html: Added.
* platform/chromium/test_expectations.txt: Skipped error-event-constructor.html, since V8 does not yet have the ErrorEvent constructor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCORS images viewed from different domains fail security checks
abarth@webkit.org [Sat, 17 Sep 2011 01:47:36 +0000 (01:47 +0000)]
CORS images viewed from different domains fail security checks
https://bugs.webkit.org/show_bug.cgi?id=68011

Reviewed by Darin Adler.

I am unable to reproduce the bug, but the test I wrote in the process
might be worth having anyway.

* http/tests/security/canvas-cors-with-two-hosts-expected.txt: Added.
* http/tests/security/canvas-cors-with-two-hosts.html: Added.
* http/tests/security/resources/canvas-cors-subtest.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoOverhangs a ruby by no more than half the width of the neighboring text.
haraken@google.com [Sat, 17 Sep 2011 01:36:07 +0000 (01:36 +0000)]
Overhangs a ruby by no more than half the width of the neighboring text.
https://bugs.webkit.org/show_bug.cgi?id=62684

Reviewed by Dan Bernstein.

Assume two rubies between which a narrow text exists, like
"<ruby>x<rt>xxxxxx</rt></ruby>l<ruby>y<rt>yyyyyy</rt></ruby>".
In order to avoid the two rubies overlapping with each other,
this patch overhangs the ruby by no more than half the ruby font
size and no more than half the width of the neighboring text.

Source/WebCore:

Tests: fast/ruby/overhang-horizontal-no-overlap1.html
       fast/ruby/overhang-horizontal-no-overlap2.html
       fast/ruby/overhang-vertical-no-overlap1.html
       fast/ruby/overhang-vertical-no-overlap2.html

* rendering/RenderRubyRun.cpp:
(WebCore::RenderRubyRun::getOverhang): Calculates the width of ruby overhanging.

LayoutTests:

* fast/ruby/overhang-horizontal-no-overlap1-expected.png: Added.
* fast/ruby/overhang-horizontal-no-overlap1-expected.txt: Added.
* fast/ruby/overhang-horizontal-no-overlap1.html: Added. Tests if two rubies do not overlap with each other when a narrow text exists between the two rubies. Split into two test files in order to fit each test result within one page.
* fast/ruby/overhang-horizontal-no-overlap2-expected.png: Added.
* fast/ruby/overhang-horizontal-no-overlap2-expected.txt: Added.
* fast/ruby/overhang-horizontal-no-overlap2.html: Added. Tests if two rubies do not overlap with each other when a narrow text exists between the two rubies. Split into two test files in order to fit each test result within one page.
* fast/ruby/overhang-vertical-no-overlap1-expected.png: Added.
* fast/ruby/overhang-vertical-no-overlap1-expected.txt: Added.
* fast/ruby/overhang-vertical-no-overlap1.html: Added. Tests if two rubies do not overlap with each other when a narrow text exists between the two rubies. Split into two test files in order to fit each test result within one page.
* fast/ruby/overhang-vertical-no-overlap2-expected.png: Added.
* fast/ruby/overhang-vertical-no-overlap2-expected.txt: Added.
* fast/ruby/overhang-vertical-no-overlap2.html: Added. Tests if two rubies do not overlap with each other when a narrow text exists between the two rubies. Split into two test files in order to fit each test result within one page.
* platform/chromium-linux/fast/ruby/overhang-vertical-expected.png: Removed.
* platform/chromium-win/fast/ruby/overhang-horizontal-expected.png: Removed.
* platform/chromium/test_expectations.txt: Skips overhang-horizontal.html.  We will update the result image as a rebase line.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r95304.
rniwa@webkit.org [Sat, 17 Sep 2011 01:32:10 +0000 (01:32 +0000)]
Unreviewed, rolling out r95304.
http://trac.webkit.org/changeset/95304
https://bugs.webkit.org/show_bug.cgi?id=68299

Broke GTK+ builds. It pulls derived headers into main.c
(Requested by rniwa on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-16

* bindings/scripts/CodeGeneratorGObject.pm:
():
* bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestCallback.h:
* bindings/scripts/test/GObject/WebKitDOMTestCallbackPrivate.h:
* bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestInterface.h:
* bindings/scripts/test/GObject/WebKitDOMTestInterfacePrivate.h:
* bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.h:
* bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListenerPrivate.h:
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(webkit_dom_test_obj_conditional_method1):
(webkit_dom_test_obj_conditional_method2):
(webkit_dom_test_obj_conditional_method3):
(webkit_dom_test_obj_get_conditional_attr1):
(webkit_dom_test_obj_set_conditional_attr1):
(webkit_dom_test_obj_get_conditional_attr2):
(webkit_dom_test_obj_set_conditional_attr2):
(webkit_dom_test_obj_get_conditional_attr3):
(webkit_dom_test_obj_set_conditional_attr3):
(webkit_dom_test_obj_set_property):
(webkit_dom_test_obj_get_property):
(webkit_dom_test_obj_class_init):
* bindings/scripts/test/GObject/WebKitDOMTestObj.h:
* bindings/scripts/test/GObject/WebKitDOMTestObjPrivate.h:
* bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.h:
* bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterfacePrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRe-named isRootLayer to isNonCompositedContent because
commit-queue@webkit.org [Sat, 17 Sep 2011 01:14:47 +0000 (01:14 +0000)]
Re-named isRootLayer to isNonCompositedContent because
that is what the flag actually means.
https://bugs.webkit.org/show_bug.cgi?id=68214

Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-09-16
Reviewed by James Robinson.

Code cleanup towards unit testing.

* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::pushPropertiesTo):
* platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::setIsNonCompositedContent):
(WebCore::LayerChromium::isNonCompositedContent):
* platform/graphics/chromium/NonCompositedContentHost.cpp:
(WebCore::NonCompositedContentHost::NonCompositedContentHost):
* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::setLayerTreeHost):
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::CCLayerImpl):
* platform/graphics/chromium/cc/CCLayerImpl.h:
(WebCore::CCLayerImpl::setIsNonCompositedContent):
(WebCore::CCLayerImpl::isNonCompositedContent):
* platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::CCTiledLayerImpl::draw):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake custom scrollbar theme for use in DRT, to reduce pixel diffs between platforms
simon.fraser@apple.com [Sat, 17 Sep 2011 01:12:48 +0000 (01:12 +0000)]
Make custom scrollbar theme for use in DRT, to reduce pixel diffs between platforms
https://bugs.webkit.org/show_bug.cgi?id=68134

Source/WebCore:

Reviewed by Sam Weinig.

Add a new setting to control whether the mock scrollbar theme is used.
This is a global setting, so that it can be set without having to
access a specific Settings object.

* page/Settings.h:
(WebCore::Settings::setMockScrollbarsEnabled):
(WebCore::Settings::mockScrollbarsEnabled):

Source/WebKit/mac:

Reviewed by Sam Weinig.

Hook up a private preference that enables the mock scrollbar theme.

* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.mm:
(-[WebPreferences mockScrollbarsEnabled]):
(-[WebPreferences setMockScrollbarsEnabled:]):
* WebView/WebPreferencesPrivate.h:

Source/WebKit2:

Reviewed by Sam Weinig.

Hook up a private preference that enables the mock scrollbar theme.

* Shared/WebPreferencesStore.h:
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetMockScrollbarsEnabled):
(WKPreferencesGetMockScrollbarsEnabled):
* UIProcess/API/C/WKPreferencesPrivate.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoLarge canvas fills should not crash or create unnecessarily large image buffers
commit-queue@webkit.org [Sat, 17 Sep 2011 01:02:45 +0000 (01:02 +0000)]
Large canvas fills should not crash or create unnecessarily large image buffers
https://bugs.webkit.org/show_bug.cgi?id=67988

Source/WebCore:

When using source-in, destination-in, source-out, or destination-atop a temporary
buffer is created. This buffer only needs to be big enough to cover the intersection
of the path and the canvas. If the area of intersection between the fill and the
canvas is empty the canvas is completely cleared and a temporary buffer is not used.

This change also adds some null checks for failures to create contexts or buffers.

Patch by Ben Wells <benwells@chromium.org> on 2011-09-16
Reviewed by Darin Adler.

Test: fast/canvas/canvas-large-fills.html

* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::clearCanvas):
(WebCore::CanvasRenderingContext2D::fillAndDisplayTransparencyElsewhere):

LayoutTests:

Patch by Ben Wells <benwells@chromium.org> on 2011-09-16
Reviewed by Darin Adler.

* fast/canvas/canvas-large-fills-expected.txt: Added.
* fast/canvas/canvas-large-fills.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove default NULL argument in LayerChromium::create().
commit-queue@webkit.org [Sat, 17 Sep 2011 00:50:28 +0000 (00:50 +0000)]
Remove default NULL argument in LayerChromium::create().
https://bugs.webkit.org/show_bug.cgi?id=68211

Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-09-16
Reviewed by James Robinson.

Code cleanup related to creating unit testing.

* platform/graphics/chromium/LayerChromium.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Rebaseline fix up due to r95239.
levin@chromium.org [Sat, 17 Sep 2011 00:45:50 +0000 (00:45 +0000)]
[chromium] Rebaseline fix up due to r95239.

Add back in a baseline that was removed in my last change.

* platform/chromium-cg-mac-leopard/fast/clip/overflow-border-radius-combinations-expected.png: Added.
* platform/chromium-cg-mac-leopard/fast/clip/overflow-border-radius-transformed-expected.png: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix the rebaseline in r95325 and also rebaseline for r95335.
rniwa@webkit.org [Sat, 17 Sep 2011 00:44:34 +0000 (00:44 +0000)]
Fix the rebaseline in r95325 and also rebaseline for r95335.

* inspector/styles/styles-update-from-js-expected.txt:
* platform/chromium/test_expectations.txt
* platform/chromium-win/editing/deleting/merge-whitespace-pre-expected.txt:
* platform/qt/editing/deleting/merge-whitespace-pre-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Move quad drawing code from LayerChromium to LayerRendererChromium
enne@google.com [Sat, 17 Sep 2011 00:33:09 +0000 (00:33 +0000)]
[chromium] Move quad drawing code from LayerChromium to LayerRendererChromium
https://bugs.webkit.org/show_bug.cgi?id=68272

Reviewed by James Robinson.

All the OpenGL code is in LayerRendererChromium and the CCLayerImpl
tree, so move the static drawTexturedQuad/toGLMatrix functions to
LayerRendererChromium, where they really belong.

Just moving code around. Tested by existing compositor tests.

* platform/graphics/chromium/LayerChromium.cpp:
* platform/graphics/chromium/LayerChromium.h:
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::toGLMatrix):
(WebCore::LayerRendererChromium::drawTexturedQuad):
* platform/graphics/chromium/LayerRendererChromium.h:
* platform/graphics/chromium/cc/CCCanvasLayerImpl.cpp:
(WebCore::CCCanvasLayerImpl::draw):
* platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
(WebCore::CCHeadsUpDisplay::draw):
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::drawDebugBorder):
* platform/graphics/chromium/cc/CCPluginLayerImpl.cpp:
(WebCore::CCPluginLayerImpl::draw):
* platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore::CCRenderSurface::drawSurface):
* platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::CCTiledLayerImpl::drawTiles):
* platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore::CCVideoLayerImpl::drawYUV):
(WebCore::CCVideoLayerImpl::drawRGBA):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCleanup JSTypeInfo a bit
weinig@apple.com [Sat, 17 Sep 2011 00:22:50 +0000 (00:22 +0000)]
Cleanup JSTypeInfo a bit
https://bugs.webkit.org/show_bug.cgi?id=68289

Reviewed by Anders Carlsson.

* dfg/DFGOperations.cpp:
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
Replace direct access to flags() with predicate.

* runtime/JSObject.h:
(JSC::JSFinalObject::createStructure):
Pass FinalObjectType instead of using special IsJSFinalObject.

* runtime/JSTypeInfo.h:
(JSC::TypeInfo::TypeInfo):
Add additional assert that you should no object should OverridesHasInstance but not have ImplementsHasInstance set.

(JSC::TypeInfo::isFinalObject):
Added.

(JSC::TypeInfo::masqueradesAsUndefined):
(JSC::TypeInfo::implementsHasInstance):
(JSC::TypeInfo::isEnvironmentRecord):
(JSC::TypeInfo::overridesHasInstance):
(JSC::TypeInfo::implementsDefaultHasInstance):
(JSC::TypeInfo::overridesGetOwnPropertySlot):
(JSC::TypeInfo::overridesVisitChildren):
(JSC::TypeInfo::overridesGetPropertyNames):
(JSC::TypeInfo::prohibitsPropertyCaching):
(JSC::TypeInfo::isSetOnFlags1):
(JSC::TypeInfo::isSetOnFlags2):
Replace direct bit twiddling with helper functions.

* runtime/Structure.cpp:
(JSC::Structure::Structure):
Use new isFinalObject() predicate.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoStop installing source and header files in to WebKit2.framework after r95303.
mrowe@apple.com [Sat, 17 Sep 2011 00:22:37 +0000 (00:22 +0000)]
Stop installing source and header files in to WebKit2.framework after r95303.

* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnsigned bit shift fails under certain conditions in 32 bit builds
barraclough@apple.com [Sat, 17 Sep 2011 00:20:24 +0000 (00:20 +0000)]
Unsigned bit shift fails under certain conditions in 32 bit builds
https://bugs.webkit.org/show_bug.cgi?id=68166

Reviewed by Geoff Garen.

Source/JavaScriptCore:

The major bug here is that the slow case (which handles shifts of
doubles) doesn't check for negative results from an unsigned shift
(which should be unsigned, and as such can't be represented by a
signed integer immediate).  The implementation is also flawed for
shifts by negative shift amounts (treats as shift by zero).

* jit/JITArithmetic32_64.cpp:
(JSC::JIT::emitRightShift):
(JSC::JIT::emitRightShiftSlowCase):

LayoutTests:

Added layout test.

* fast/js/floating-point-truncate-rshift-expected.txt:
* fast/js/floating-point-truncate-rshift.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd the forgotten test, also suppress a test in Chromium as it needs a rebaseline.
rniwa@webkit.org [Sat, 17 Sep 2011 00:08:06 +0000 (00:08 +0000)]
Add the forgotten test, also suppress a test in Chromium as it needs a rebaseline.

* platform/chromium/test_expectations.txt:
* editing/deleting/merge-paragraph-into-blockquote-expected.txt: Added.
* editing/deleting/merge-paragraph-into-blockquote.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFixed const correctness on accessors in LayerChromium
commit-queue@webkit.org [Sat, 17 Sep 2011 00:07:18 +0000 (00:07 +0000)]
Fixed const correctness on accessors in LayerChromium
https://bugs.webkit.org/show_bug.cgi?id=68210

Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-09-16
Reviewed by James Robinson.

Code cleanup related to creating unit testing.

* platform/graphics/chromium/LayerChromium.h:
(WebCore::LayerChromium::preserves3D):
(WebCore::LayerChromium::replicaLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDeleting line break before h1 converts h1 to span
rniwa@webkit.org [Sat, 17 Sep 2011 00:00:07 +0000 (00:00 +0000)]
Deleting line break before h1 converts h1 to span
https://bugs.webkit.org/show_bug.cgi?id=45784

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Fixed the bug by treating h1 and other elements that retain structure like Mail blockquote.

We already had a logic to overriding styles of merged paragraphs by Mail blockquote so
just extend this logic for h1-h6, pre, etc...

Tests: editing/deleting/merge-paragraph-from-address.html
       editing/deleting/merge-paragraph-from-h6-with-style.html
       editing/deleting/merge-paragraph-from-h6.html
       editing/deleting/merge-paragraph-from-listing.html
       editing/deleting/merge-paragraph-into-h1-with-style.html
       editing/deleting/merge-paragraph-into-h1.html
       editing/deleting/merge-paragraph-into-pre.html

* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::removeRedundantStylesAndKeepStyleSpanInline):
* editing/markup.cpp:
(WebCore::isBlockNodeToRetainAppearance): Extracted from ancestorToRetainStructureAndAppearance.
(WebCore::StyledMarkupAccumulator::serializeNodes):
(WebCore::ancestorToRetainStructureAndAppearance):
* editing/markup.h:

LayoutTests:

Added a bunch of tests to ensure WebKit does not keep block elements' style when merging paragraphs.
When removing line breaks between <h1>hello</h1>world and hello<pre>world</pre> for example,
we should not be overriding and preserving styles from h1 in the merge paragraph respectively.

* editing/deleting/merge-paragraph-from-address-expected.txt: Added.
* editing/deleting/merge-paragraph-from-address.html: Added.
* editing/deleting/merge-paragraph-from-h6-expected.txt: Added.
* editing/deleting/merge-paragraph-from-h6-with-style-expected.txt: Added.
* editing/deleting/merge-paragraph-from-h6-with-style.html: Added.
* editing/deleting/merge-paragraph-from-h6.html: Added.
* editing/deleting/merge-paragraph-from-listing-expected.txt: Added.
* editing/deleting/merge-paragraph-from-listing.html: Added.
* editing/deleting/merge-paragraph-into-h1-expected.txt: Added.
* editing/deleting/merge-paragraph-into-h1-style-expected.txt: Added.
* editing/deleting/merge-paragraph-into-h1-with-style-expected.txt: Added.
* editing/deleting/merge-paragraph-into-h1-with-style.html: Added.
* editing/deleting/merge-paragraph-into-h1.html: Added.
* editing/deleting/merge-paragraph-into-pre-expected.txt: Added.
* editing/deleting/merge-paragraph-into-pre.html: Added.
* platform/mac/editing/deleting/merge-whitespace-pre-expected.png:
* platform/mac/editing/deleting/merge-whitespace-pre-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Create WebGL layer for graphics contexts on demand
nduca@chromium.org [Fri, 16 Sep 2011 23:33:23 +0000 (23:33 +0000)]
[chromium] Create WebGL layer for graphics contexts on demand
https://bugs.webkit.org/show_bug.cgi?id=68288

Reviewed by James Robinson.

* src/GraphicsContext3DChromium.cpp:
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::platformLayer):
* src/GraphicsContext3DPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSet but not used variables cleanup (gcc 4.6)
commit-queue@webkit.org [Fri, 16 Sep 2011 23:24:34 +0000 (23:24 +0000)]
Set but not used variables cleanup (gcc 4.6)
https://bugs.webkit.org/show_bug.cgi?id=68157

Patch by Max Perepelitsyn <pph34r@gmail.com> on 2011-09-16
Reviewed by Darin Adler.

* platform/audio/ReverbConvolverStage.cpp:
(WebCore::ReverbConvolverStage::process):
* rendering/RenderMediaControlsChromium.cpp:
(WebCore::paintMediaButton):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Rebaseline fix up due to r95239.
levin@chromium.org [Fri, 16 Sep 2011 23:07:43 +0000 (23:07 +0000)]
[chromium] Rebaseline fix up due to r95239.

Expectation removal due to r95322 and r95325.

 * platform/chromium-cg-mac-leopard/fast/clip/overflow-border-radius-composited-expected.png: Added.
 * platform/chromium-cg-mac/fast/clip/overflow-border-radius-combinations-expected.png: Added.
 * platform/chromium-cg-mac/fast/clip/overflow-border-radius-composited-expected.png: Added.
 * platform/chromium-cg-mac/fast/clip/overflow-border-radius-transformed-expected.png: Added.
 * platform/chromium-cg-mac/fast/css/nested-rounded-corners-expected.png:
 * platform/chromium-linux/fast/clip/overflow-border-radius-combinations-expected.png: Added.
 * platform/chromium-linux/fast/clip/overflow-border-radius-composited-expected.png: Added.
 * platform/chromium-linux/fast/clip/overflow-border-radius-transformed-expected.png: Added.
 * platform/chromium-linux/fast/css/nested-rounded-corners-expected.png:
 * platform/chromium-mac/fast/clip/overflow-border-radius-combinations-expected.png: Added.
 * platform/chromium-mac/fast/clip/overflow-border-radius-composited-expected.png: Added.
 * platform/chromium-mac/fast/clip/overflow-border-radius-transformed-expected.png: Added.
 * platform/chromium-mac/fast/css/nested-rounded-corners-expected.png:
 * platform/chromium-win/fast/clip/overflow-border-radius-combinations-expected.png: Added.
 * platform/chromium-win/fast/clip/overflow-border-radius-combinations-expected.txt: Added.
 * platform/chromium-win/fast/clip/overflow-border-radius-composited-expected.png: Added.
 * platform/chromium-win/fast/clip/overflow-border-radius-composited-expected.txt: Added.
 * platform/chromium-win/fast/clip/overflow-border-radius-transformed-expected.png: Added.
 * platform/chromium-win/fast/clip/overflow-border-radius-transformed-expected.txt: Added.
 * platform/chromium-win/fast/css/nested-rounded-corners-expected.png:
 * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemoved undetectable style.filter.
ggaren@apple.com [Fri, 16 Sep 2011 23:02:43 +0000 (23:02 +0000)]
Removed undetectable style.filter.

Reviewed by Sam Weinig.

This feature was added in http://trac.webkit.org/changeset/15557 to
support housingmaps.com. But housingmaps.com no longer needs this hack,
we don't know of other websites that need it, and we don't know of
any other browsers that have implemented this feature.

Source/JavaScriptCore:

* GNUmakefile.list.am:
* JavaScriptCore.gypi:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* runtime/JSTypeInfo.h:
* runtime/StringObjectThatMasqueradesAsUndefined.h: Removed.

Source/WebCore:

* ForwardingHeaders/runtime/StringObjectThatMasqueradesAsUndefined.h: Removed.
* WebCore.order:
* bindings/js/JSCSSStyleDeclarationCustom.cpp:
(WebCore::JSCSSStyleDeclaration::nameGetter):

LayoutTests:

* fast/dom/undetectable-style-filter-expected.txt: Removed.
* fast/dom/undetectable-style-filter.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-09-16 Rob Buis <rbuis@rim.com>
rwlbuis@webkit.org [Fri, 16 Sep 2011 22:50:44 +0000 (22:50 +0000)]
2011-09-16  Rob Buis  <rbuis@rim.com>

        Add Eli's rim address and change the nick.

        * Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r95317.
commit-queue@webkit.org [Fri, 16 Sep 2011 22:29:56 +0000 (22:29 +0000)]
Unreviewed, rolling out r95317.
http://trac.webkit.org/changeset/95317
https://bugs.webkit.org/show_bug.cgi?id=68282

Remove newly added overlapping test expectations. (Requested
by dave_levin on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-16

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] compilation failed in target 'webkit_unit_tests'.
commit-queue@webkit.org [Fri, 16 Sep 2011 22:27:29 +0000 (22:27 +0000)]
[chromium] compilation failed in target 'webkit_unit_tests'.
https://bugs.webkit.org/show_bug.cgi?id=68078

Patch by chandra shekar v <chandra.vallala@motorola.com> on 2011-09-16
Reviewed by Adam Barth.

* tests/WebFrameTest.cpp:
(WebKit::TestReloadDoesntRedirectWebFrameClient::decidePolicyForNavigation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdate JSC results to account for intrinsics change.
abarth@webkit.org [Fri, 16 Sep 2011 22:02:37 +0000 (22:02 +0000)]
Update JSC results to account for intrinsics change.

* bindings/scripts/test/JS/JSTestInterface.cpp:
* bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
* bindings/scripts/test/JS/JSTestObj.cpp:
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoPrepare JSTypes for more Object subtypes
weinig@apple.com [Fri, 16 Sep 2011 21:34:20 +0000 (21:34 +0000)]
Prepare JSTypes for more Object subtypes
https://bugs.webkit.org/show_bug.cgi?id=68200

Reviewed by Gavin Barraclough.

* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::branchIfNotObject):
* jit/JITInlineMethods.h:
(JSC::JIT::emitJumpIfNotObject):
* runtime/JSGlobalObject.h:
(JSC::Structure::prototypeForLookup):
* runtime/JSObject.h:
(JSC::JSObject::finishCreation):
* runtime/JSType.h:
* runtime/JSTypeInfo.h:
(JSC::TypeInfo::type):
(JSC::TypeInfo::isObject):
(JSC::TypeInfo::isFinal):
(JSC::TypeInfo::prohibitsPropertyCaching):
* runtime/NativeErrorConstructor.h:
(JSC::NativeErrorConstructor::finishCreation):
* runtime/Operations.cpp:
(JSC::jsIsObjectType):
* runtime/Structure.cpp:
(JSC::Structure::addPropertyTransitionToExistingStructure):
(JSC::Structure::addPropertyTransition):
* runtime/Structure.h:
(JSC::Structure::isObject):
(JSC::JSCell::isObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRebaseline from r95242.
rniwa@webkit.org [Fri, 16 Sep 2011 21:12:03 +0000 (21:12 +0000)]
Rebaseline from r95242.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRolled back in r95201 with test failure fixed.
ggaren@apple.com [Fri, 16 Sep 2011 21:05:09 +0000 (21:05 +0000)]
Rolled back in r95201 with test failure fixed.

I missed two cases of jumpSlowToHot in rshift -- these cases need to be
sure to initialize regT1 to the int tag, since it will otherwise hold
the top 32 bits of a double.

* jit/JIT.h:
* jit/JITArithmetic32_64.cpp:
(JSC::JIT::emit_op_lshift):
(JSC::JIT::emitRightShift):
(JSC::JIT::emitRightShiftSlowCase):
(JSC::JIT::emit_op_bitand):
(JSC::JIT::emit_op_bitor):
(JSC::JIT::emit_op_bitxor):
(JSC::JIT::emit_op_bitnot):
(JSC::JIT::emit_op_post_inc):
(JSC::JIT::emit_op_post_dec):
(JSC::JIT::emit_op_pre_inc):
(JSC::JIT::emit_op_pre_dec):
* jit/JITInlineMethods.h:
(JSC::JIT::emitStoreAndMapInt32):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoReplace use of access to nodeList using call, with array style notation.
weinig@apple.com [Fri, 16 Sep 2011 20:59:25 +0000 (20:59 +0000)]
Replace use of access to nodeList using call, with array style notation.

* editing/pasteboard/paste-noscript.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttp/tests/history/back-with-fragment-change.php fails on non-Chromium bots
mihaip@chromium.org [Fri, 16 Sep 2011 20:43:41 +0000 (20:43 +0000)]
http/tests/history/back-with-fragment-change.php fails on non-Chromium bots
https://bugs.webkit.org/show_bug.cgi?id=68242

Skip test on ports on which it fails. Move comment to be inside
<?php> block so that HTTP headers can be set on all platforms (there
must not be any whitespace before the <?php> block).

* http/tests/history/back-with-fragment-change.php:
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed Windows build fix after 95318.
fpizlo@apple.com [Fri, 16 Sep 2011 20:42:19 +0000 (20:42 +0000)]
Unreviewed Windows build fix after 95318.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r95312.
commit-queue@webkit.org [Fri, 16 Sep 2011 20:33:55 +0000 (20:33 +0000)]
Unreviewed, rolling out r95312.
http://trac.webkit.org/changeset/95312
https://bugs.webkit.org/show_bug.cgi?id=68277

It's innocent, innocent I tell you! (Requested by jamesr_ on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-16

Source/WebCore:

* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::createTextureUpdater):
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::LayerRendererChromium):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::context):
(WebCore::CCThreadProxy::beginFrameAndCommitOnCCThread):
(WebCore::CCThreadProxy::setNeedsCommitAndRedrawOnCCThread):
(WebCore::CCThreadProxy::setNeedsRedrawOnCCThread):

Source/WebKit/chromium:

* tests/CCLayerTreeHostTest.cpp:
(WTF::TestHooks::beginCommitOnCCThread):
(WTF::TestHooks::commitCompleteOnCCThread):
(WTF::TestHooks::drawLayersOnCCThread):
(WTF::MockLayerTreeHostImpl::create):
(WTF::MockLayerTreeHostImpl::beginCommit):
(WTF::MockLayerTreeHostImpl::commitComplete):
(WTF::MockLayerTreeHostImpl::drawLayers):
(WTF::MockLayerTreeHostImpl::MockLayerTreeHostImpl):
(WTF::MockLayerTreeHost::create):
(WTF::MockLayerTreeHost::createLayerTreeHostImpl):
(WTF::MockLayerTreeHost::MockLayerTreeHost):
(WTF::CompositorMockWebGraphicsContext3D::create):
(WTF::CompositorMockWebGraphicsContext3D::makeContextCurrent):
(WTF::CompositorMockWebGraphicsContext3D::createProgram):
(WTF::CompositorMockWebGraphicsContext3D::createShader):
(WTF::CompositorMockWebGraphicsContext3D::getShaderiv):
(WTF::CompositorMockWebGraphicsContext3D::getProgramiv):
(WTF::CompositorMockWebGraphicsContext3D::CompositorMockWebGraphicsContext3D):
(WTF::MockLayerTreeHostClient::create):
(WTF::MockLayerTreeHostClient::animateAndLayout):
(WTF::MockLayerTreeHostClient::createCompositorThread):
(WTF::MockLayerTreeHostClient::createLayerTreeHostContext3D):
(WTF::MockLayerTreeHostClient::createRootLayerPainter):
(WTF::MockLayerTreeHostClient::didRecreateGraphicsContext):
(WTF::MockLayerTreeHostClient::MockLayerTreeHostClient):
(WTF::CCLayerTreeHostTest::postSetNeedsCommitToMainThread):
(WTF::CCLayerTreeHostTest::postSetNeedsRedrawToMainThread):
(WTF::CCLayerTreeHostTest::CCLayerTreeHostTest):
(WTF::CCLayerTreeHostTest::onBeginTest):
(WTF::CCLayerTreeHostTest::onEndTest):
(WTF::CCLayerTreeHostTest::dispatchSetNeedsCommit):
(WTF::CCLayerTreeHostTest::dispatchSetNeedsRedraw):
(WTF::CCLayerTreeHostTest::runTest):
(WTF::CCLayerTreeHostTest::testTimeout):
(WTF::CCLayerTreeHostTest::doBeginTest):
(WTF::CCLayerTreeHostTestShortlived2::beginTest):
(WTF::CCLayerTreeHostTestShortlived3::beginTest):
(WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::beginTest):
(WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestSetNeedsCommit1::beginTest):
(WTF::CCLayerTreeHostTestSetNeedsCommit1::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestSetNeedsCommit1::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestSetNeedsCommit2::beginTest):
(WTF::CCLayerTreeHostTestSetNeedsCommit2::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestSetNeedsCommit2::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestSetNeedsRedraw::beginTest):
(WTF::CCLayerTreeHostTestSetNeedsRedraw::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestSetNeedsRedraw::commitCompleteOnCCThread):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWindows build fix after r95310
aroben@apple.com [Fri, 16 Sep 2011 20:33:38 +0000 (20:33 +0000)]
Windows build fix after r95310

* JavaScriptCore.vcproj/jsc/jscCommon.vsprops: Added include\private\JavaScriptCore to the
include path so DFGIntrinsic.h can be found.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRationalize JSObject::putDirect* methods
barraclough@apple.com [Fri, 16 Sep 2011 20:32:15 +0000 (20:32 +0000)]
Rationalize JSObject::putDirect* methods
https://bugs.webkit.org/show_bug.cgi?id=68274

Reviewed by Sam Weinig.

Delete the *Function variants. These are overall inefficient,
in the way they get the name back from the function rather
than just passing it in.

* JavaScriptCore.exp:
* jsc.cpp:
(GlobalObject::finishCreation):
(GlobalObject::addFunction):
* runtime/FunctionPrototype.cpp:
(JSC::FunctionPrototype::addFunctionProperties):
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
* runtime/JSObject.cpp:
(JSC::JSObject::put):
(JSC::JSObject::putWithAttributes):
(JSC::JSObject::defineGetter):
(JSC::JSObject::defineSetter):
* runtime/JSObject.h:
(JSC::JSObject::putDirect):
(JSC::JSObject::putDirectWithoutTransition):
* runtime/Lookup.cpp:
(JSC::setUpStaticFunctionSlot):
* runtime/Lookup.h:
(JSC::lookupPut):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed; new expectations (Skia on Mac)
caryclark@google.com [Fri, 16 Sep 2011 20:22:20 +0000 (20:22 +0000)]
Unreviewed; new expectations (Skia on Mac)

This separates test failures that are specific to CG Mac from failures
for Skia on Mac (Leopard only).

* LayoutTests/platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed build fix for Windows.
fpizlo@apple.com [Fri, 16 Sep 2011 20:18:46 +0000 (20:18 +0000)]
Unreviewed build fix for Windows.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd back the WKHitTestResultRef parameter to mouseDidMoveOverElement in an ABI preser...
andersca@apple.com [Fri, 16 Sep 2011 20:12:07 +0000 (20:12 +0000)]
Add back the WKHitTestResultRef parameter to mouseDidMoveOverElement in an ABI preserving way
https://bugs.webkit.org/show_bug.cgi?id=68269

Reviewed by Geoffrey Garen.

Source/WebKit2:

Add back WKPageMouseDidMoveOverElementCallback last and deprecate the current callback.

* UIProcess/API/C/WKPage.h:
* UIProcess/WebUIClient.cpp:
(WebKit::WebUIClient::mouseDidMoveOverElement):

Tools:

Update client function signatures.

* MiniBrowser/gtk/BrowserWindow.c:
(browserWindowUIClientInit):
* MiniBrowser/mac/BrowserWindowController.m:
(mouseDidMoveOverElement):
(-[BrowserWindowController awakeFromNib]):
* MiniBrowser/win/BrowserView.cpp:
(BrowserView::create):
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::createOtherPage):
(WTR::TestController::initialize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Give local builds of WebProcess different icon to distinguish them from built...
ap@apple.com [Fri, 16 Sep 2011 20:06:00 +0000 (20:06 +0000)]
    Give local builds of WebProcess different icon to distinguish them from built-in Safariâ\80\99s WebProcess
        https://bugs.webkit.org/show_bug.cgi?id=68268

        Reviewed by Darin Adler.

        * Configurations/WebProcess.xcconfig: Add an icon in Debug and Release builds.  The empty
        value for production resulted in WebKit not adding the key to plist at all, which is what
        we want (but I don't know if it's a supported feature).
        Also, don't copy the icon file to built framework in production builds.

        * WebKit2.xcodeproj/project.pbxproj: Added WebKit.icns.

        * WebProcess/Info.plist: Added a key for the icon.

        * WebProcess/mac/WebKit.icns: Copied from Websites/webkit.org/images/surfin-safari.icns.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed build fix for non-DFG builds.
fpizlo@apple.com [Fri, 16 Sep 2011 20:05:29 +0000 (20:05 +0000)]
Unreviewed build fix for non-DFG builds.

* runtime/Executable.h:
(JSC::NativeExecutable::finishCreation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r95309.
commit-queue@webkit.org [Fri, 16 Sep 2011 20:05:01 +0000 (20:05 +0000)]
Unreviewed, rolling out r95309.
http://trac.webkit.org/changeset/95309
https://bugs.webkit.org/show_bug.cgi?id=68271

Broke many chromium gpu tests. (Requested by dave_levin on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-16

Source/WebCore:

* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::createTextureUpdater):
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::LayerRendererChromium):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::context):
(WebCore::CCThreadProxy::beginFrameAndCommitOnCCThread):
(WebCore::CCThreadProxy::setNeedsCommitAndRedrawOnCCThread):
(WebCore::CCThreadProxy::setNeedsRedrawOnCCThread):

Source/WebKit/chromium:

* tests/CCLayerTreeHostTest.cpp:
(WTF::CCLayerTreeHostTest::CCLayerTreeHostTest):
(WTF::CCLayerTreeHostTest::animateAndLayout):
(WTF::CCLayerTreeHostTest::beginCommitOnCCThread):
(WTF::CCLayerTreeHostTest::beginCommitOnMainThread):
(WTF::CCLayerTreeHostTest::commitOnCCThread):
(WTF::CCLayerTreeHostTest::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTest::commitCompleteOnMainThread):
(WTF::CCLayerTreeHostTest::drawLayersAndPresentOnCCThread):
(WTF::CCLayerTreeHostTest::updateLayers):
(WTF::CCLayerTreeHostTest::onBeginTest):
(WTF::CCLayerTreeHostTest::doEndTest):
(WTF::CCLayerTreeHostTest::onEndTest):
(WTF::CCLayerTreeHostTest::runTest):
(WTF::CCLayerTreeHostTest::testTimeout):
(WTF::MockLayerTreeHostClient::MockLayerTreeHostClient):
(WTF::MockLayerTreeHostClient::createLayerTreeHostContext3D):
(WTF::MockLayerTreeHostClient::animateAndLayout):
(WTF::MockLayerTreeHostClient::updateLayers):
(WTF::MockLayerTreeHostCommitter::create):
(WTF::MockLayerTreeHostCommitter::commit):
(WTF::MockLayerTreeHostCommitter::MockLayerTreeHostCommitter):
(WTF::MockLayerTreeHostImpl::create):
(WTF::MockLayerTreeHostImpl::beginCommit):
(WTF::MockLayerTreeHostImpl::commitComplete):
(WTF::MockLayerTreeHostImpl::drawLayersAndPresent):
(WTF::MockLayerTreeHostImpl::MockLayerTreeHostImpl):
(WTF::MockLayerTreeHostImplProxy::create):
(WTF::MockLayerTreeHostImplProxy::createLayerTreeHostImpl):
(WTF::MockLayerTreeHostImplProxy::MockLayerTreeHostImplProxy):
(WTF::MockLayerTreeHost::MockLayerTreeHost):
(WTF::MockLayerTreeHost::createLayerTreeHostImplProxy):
(WTF::MockLayerTreeHost::updateLayers):
(WTF::MockLayerTreeHost::createLayerTreeHostCommitter):
(WTF::MockLayerTreeHost::beginCommit):
(WTF::MockLayerTreeHost::commitComplete):
(WTF::CCLayerTreeHostTest::doBeginTest):
(WTF::CCLayerTreeHostTestShortlived2::beginTest):
(WTF::CCLayerTreeHostTestShortlived3::beginTest):
(WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::beginTest):
(WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestCommitingWithContinuousRedraw::drawLayersAndPresentOnCCThread):
(WTF::CCLayerTreeHostTestSetNeedsCommit1::beginTest):
(WTF::CCLayerTreeHostTestSetNeedsCommit1::drawLayersAndPresentOnCCThread):
(WTF::CCLayerTreeHostTestSetNeedsCommit1::commitOnCCThread):
(WTF::CCLayerTreeHostTestSetNeedsCommit2::beginTest):
(WTF::CCLayerTreeHostTestSetNeedsCommit2::drawLayersAndPresentOnCCThread):
(WTF::CCLayerTreeHostTestSetNeedsCommit2::commitOnCCThread):
(WTF::CCLayerTreeHostTestSetNeedsRedraw::beginTest):
(WTF::CCLayerTreeHostTestSetNeedsRedraw::drawLayersAndPresentOnCCThread):
(WTF::CCLayerTreeHostTestSetNeedsRedraw::commitOnCCThread):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTemporarily remove the WKHitTestResultRef parameter to avoid breaking the WK2 ABI/API
andersca@apple.com [Fri, 16 Sep 2011 19:29:07 +0000 (19:29 +0000)]
Temporarily remove the WKHitTestResultRef parameter to avoid breaking the WK2 ABI/API
https://bugs.webkit.org/show_bug.cgi?id=68266

Reviewed by John Sullivan.

Source/WebKit2:

* UIProcess/API/C/WKPage.h:
* UIProcess/WebUIClient.cpp:
(WebKit::WebUIClient::mouseDidMoveOverElement):

Tools:

* MiniBrowser/mac/BrowserWindowController.m:
(mouseDidMoveOverElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDFG JIT should inline Math.abs
fpizlo@apple.com [Fri, 16 Sep 2011 18:50:04 +0000 (18:50 +0000)]
DFG JIT should inline Math.abs
https://bugs.webkit.org/show_bug.cgi?id=68227

Source/JavaScriptCore:

Reviewed by Oliver Hunt.

This adds the ability to track intrinsic functions throughout the
host function infrastructure, so that the DFG can easily query
whether or not a call's target is intrinsic, and if so, which
intrinsic it is.

On top of this, it adds Math.abs intrinsics to DFG. Call(Math.abs)
is transformed into ValueToNumber<-ArithAbs nodes. These nodes
then get optimized using the usual tricks.

Also had to make a completely unrelated change to
DateInstanceCache.h in order to fix a preexisting alphabetical
sorting problem in JSGlobalData.h

This results in a big win in imaging-gaussian-blur: 61% faster
than before. The net win on Kraken is around 13%.

* JavaScriptCore.xcodeproj/project.pbxproj:
* create_hash_table:
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGGraph.h:
(JSC::DFG::Graph::isFunctionConstant):
(JSC::DFG::Graph::valueOfFunctionConstant):
* dfg/DFGIntrinsic.h: Added.
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::isFunctionConstant):
(JSC::DFG::JITCodeGenerator::valueOfFunctionConstant):
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::isFunctionConstant):
(JSC::DFG::JITCompiler::valueOfFunctionConstant):
* dfg/DFGNode.h:
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNode):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* jit/JITStubs.cpp:
(JSC::JITThunks::hostFunctionStub):
* jit/JITStubs.h:
* runtime/DateInstanceCache.h:
* runtime/Executable.cpp:
(JSC::ExecutableBase::intrinsic):
(JSC::NativeExecutable::intrinsic):
* runtime/Executable.h:
(JSC::NativeExecutable::create):
(JSC::NativeExecutable::finishCreation):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::getHostFunction):
* runtime/JSGlobalData.h:
* runtime/Lookup.cpp:
(JSC::HashTable::createTable):
(JSC::setUpStaticFunctionSlot):
* runtime/Lookup.h:
(JSC::HashEntry::initialize):
(JSC::HashEntry::intrinsic):

Source/WebCore:

Reviewed by Oliver Hunt.

Added JavaScriptCore/dfg to include path path. Changed the bindings
scripts to handle the presence of intrinsics.

* CMakeLists.txt:
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHashTable):

Source/WebKit:

Reviewed by Oliver Hunt.

Added JavaScriptCore/dfg to include path path.

* CMakeLists.txt:

Source/WebKit2:

Reviewed by Oliver Hunt.

Added JavaScriptCore/dfg to include path path.

* CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Fix CCLayerTreeHostTest
jamesr@google.com [Fri, 16 Sep 2011 18:43:37 +0000 (18:43 +0000)]
[chromium] Fix CCLayerTreeHostTest
https://bugs.webkit.org/show_bug.cgi?id=67418

Source/WebCore:

This is a minimal set of changes to get CCLayerTreeHostTest
compiling, running and passing with USE_THREADED_COMPOSITING
enabled.

Patch by Iain Merrick <husky@google.com> on 2011-09-16
Reviewed by James Robinson.

* platform/graphics/chromium/ContentLayerChromium.cpp:
(WebCore::ContentLayerChromium::createTextureUpdater):
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::LayerRendererChromium):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::createLayerTreeHostImpl):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::context):
(WebCore::CCThreadProxy::beginFrameAndCommitOnCCThread):
(WebCore::CCThreadProxy::setNeedsCommitAndRedrawOnCCThread):
(WebCore::CCThreadProxy::setNeedsRedrawOnCCThread):

Source/WebKit/chromium:

Fixes needed to compile and link with USE_THREADED_COMPOSITING
enabled, and to pass the basic unit test.

Patch by Iain Merrick <husky@google.com> on 2011-09-16
Reviewed by James Robinson.

* src/GraphicsContext3DChromium.cpp:
(WebCore::GraphicsContext3DPrivate::GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::platformLayer):
* src/GraphicsContext3DPrivate.h:
* tests/CCLayerTreeHostTest.cpp:
(TestHooks::beginCommitOnCCThread):
(TestHooks::commitCompleteOnCCThread):
(TestHooks::drawLayersOnCCThread):
(MockLayerTreeHostImpl::MockLayerTreeHostImpl):
(MockLayerTreeHostImpl::beginCommit):
(MockLayerTreeHostImpl::commitComplete):
(MockLayerTreeHostImpl::drawLayers):
(MockLayerTreeHost::MockLayerTreeHost):
(MockLayerTreeHost::createLayerTreeHostImpl):
(CompositorMockWebGraphicsContext3D::makeContextCurrent):
(CompositorMockWebGraphicsContext3D::createProgram):
(CompositorMockWebGraphicsContext3D::createShader):
(CompositorMockWebGraphicsContext3D::getShaderiv):
(CompositorMockWebGraphicsContext3D::getProgramiv):
(MockLayerTreeHostClient::MockLayerTreeHostClient):
(MockLayerTreeHostClient::animateAndLayout):
(MockLayerTreeHostClient::createCompositorThread):
(MockLayerTreeHostClient::createLayerTreeHostContext3D):
(MockLayerTreeHostClient::createRootLayerPainter):
(MockLayerTreeHostClient::didRecreateGraphicsContext):
(CCLayerTreeHostTest::postSetNeedsCommitToMainThread):
(CCLayerTreeHostTest::postSetNeedsRedrawToMainThread):
(CCLayerTreeHostTest::onEndTest):
(CCLayerTreeHostTest::dispatchSetNeedsCommit):
(CCLayerTreeHostTest::dispatchSetNeedsRedraw):
(CCLayerTreeHostTest::runTest):
(CCLayerTreeHostTest::doBeginTest):
(CCLayerTreeHostTestShortlived2::beginTest):
(CCLayerTreeHostTestShortlived3::beginTest):
(CCLayerTreeHostTestCommitingWithContinuousRedraw::beginTest):
(CCLayerTreeHostTestCommitingWithContinuousRedraw::commitCompleteOnCCThread):
(CCLayerTreeHostTestCommitingWithContinuousRedraw::drawLayersOnCCThread):
(CCLayerTreeHostTestSetNeedsCommit1::beginTest):
(CCLayerTreeHostTestSetNeedsCommit1::drawLayersOnCCThread):
(CCLayerTreeHostTestSetNeedsCommit1::commitCompleteOnCCThread):
(CCLayerTreeHostTestSetNeedsCommit2::beginTest):
(CCLayerTreeHostTestSetNeedsCommit2::drawLayersOnCCThread):
(CCLayerTreeHostTestSetNeedsCommit2::commitCompleteOnCCThread):
(CCLayerTreeHostTestSetNeedsRedraw::beginTest):
(CCLayerTreeHostTestSetNeedsRedraw::drawLayersOnCCThread):
(CCLayerTreeHostTestSetNeedsRedraw::commitCompleteOnCCThread):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoREGRESSION: Reproducible crash below SlotVisitor::harvestWeakReferences
fpizlo@apple.com [Fri, 16 Sep 2011 18:43:25 +0000 (18:43 +0000)]
REGRESSION: Reproducible crash below SlotVisitor::harvestWeakReferences
using Domino's online ordering
https://bugs.webkit.org/show_bug.cgi?id=68220

Reviewed by Oliver Hunt.

Weak handle processing can result in new objects being marked, which
results in new WeakReferencesHarvesters being added. But weak
reference harvesters are only processed before weak handle processing,
so there's the risk that a weak reference harvester will persist
until the next collection, by which time it may have been deleted.

* heap/Heap.cpp:
(JSC::Heap::markRoots):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r95227.
commit-queue@webkit.org [Fri, 16 Sep 2011 18:32:01 +0000 (18:32 +0000)]
Unreviewed, rolling out r95227.
http://trac.webkit.org/changeset/95227
https://bugs.webkit.org/show_bug.cgi?id=68262

Broke a bunch of SVG tests (Requested by andersca on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-16

* platform/ScrollView.cpp:
(WebCore::ScrollView::contentsSize):
(WebCore::ScrollView::wheelEvent):
* platform/ScrollView.h:
* platform/mac/ScrollViewMac.mm:
(WebCore::ScrollView::platformContentsSize):
* platform/wx/ScrollViewWx.cpp:
(WebCore::ScrollView::platformContentsSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-09-16 James Simonsen <simonjam@chromium.org>
simonjam@chromium.org [Fri, 16 Sep 2011 18:26:24 +0000 (18:26 +0000)]
2011-09-16  James Simonsen  <simonjam@chromium.org>

        Fix HTML5 parser's adoption agency algorithm to reparent correctly
        https://bugs.webkit.org/show_bug.cgi?id=68147

        Reviewed by Eric Seidel.

        * html5lib/resources/webkit02.dat:
2011-09-16  James Simonsen  <simonjam@chromium.org>

        Fix HTML5 parser's adoption agency algorithm to reparent correctly
        https://bugs.webkit.org/show_bug.cgi?id=68147

        Reviewed by Eric Seidel.

        * html/parser/HTMLTreeBuilder.cpp:
        (WebCore::HTMLTreeBuilder::callTheAdoptionAgency):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed commit. Fix Windows and MacOSX compilation after r95303.
igor.oliveira@openbossa.org [Fri, 16 Sep 2011 18:22:21 +0000 (18:22 +0000)]
Unreviewed commit. Fix Windows and MacOSX compilation after r95303.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCodeGeneratorGObject should use C++ style comments for ENABLE guards
abarth@webkit.org [Fri, 16 Sep 2011 18:06:30 +0000 (18:06 +0000)]
CodeGeneratorGObject should use C++ style comments for ENABLE guards
https://bugs.webkit.org/show_bug.cgi?id=68256

Reviewed by Darin Adler.

This patch should have not behavioral effect.  It just cleans up the
GObject code generator to use C++-style comments for ENABLE guards and
to use the usual comment style for license blocks.

* bindings/scripts/CodeGeneratorGObject.pm:
* bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestCallback.h:
* bindings/scripts/test/GObject/WebKitDOMTestCallbackPrivate.h:
* bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestInterface.h:
* bindings/scripts/test/GObject/WebKitDOMTestInterfacePrivate.h:
* bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.h:
* bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListenerPrivate.h:
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(webkit_dom_test_obj_conditional_method1):
(webkit_dom_test_obj_conditional_method2):
(webkit_dom_test_obj_conditional_method3):
(webkit_dom_test_obj_get_conditional_attr1):
(webkit_dom_test_obj_set_conditional_attr1):
(webkit_dom_test_obj_get_conditional_attr2):
(webkit_dom_test_obj_set_conditional_attr2):
(webkit_dom_test_obj_get_conditional_attr3):
(webkit_dom_test_obj_set_conditional_attr3):
(webkit_dom_test_obj_set_property):
(webkit_dom_test_obj_get_property):
(webkit_dom_test_obj_class_init):
* bindings/scripts/test/GObject/WebKitDOMTestObj.h:
* bindings/scripts/test/GObject/WebKitDOMTestObjPrivate.h:
* bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.cpp:
* bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterface.h:
* bindings/scripts/test/GObject/WebKitDOMTestSerializedScriptValueInterfacePrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@95304 268f45cc-cd09-0410-ab3c-d52691b4dbfc