WebKit GIT trees - WebKit-https.git/log

git://git.webkit.org / WebKit-https.git / log

summary | shortlog | log | commit | commitdiff | tree
first ⋅ prev ⋅ next

commit | commitdiff | tree

alexis.menard@openbossa.org [Wed, 6 Apr 2011 22:17:11 +0000 (22:17 +0000)]

2011-04-06  Alexis Menard  <alexis.menard@openbossa.org>

        Reviewed by Andreas Kling.

        [Qt] We should use USE(QT_MULTIMEDIA) rather than ENABLE(QT_MULTIMEDIA).
        https://bugs.webkit.org/show_bug.cgi?id=57974

        We should use USE(QT_MULTIMEDIA) rather than ENABLE(QT_MULTIMEDIA).

        No new tests needed, just a config flag rename.

        * features.pri:
2011-04-06  Alexis Menard  <alexis.menard@openbossa.org>

        Reviewed by Andreas Kling.

        [Qt] We should use USE(QT_MULTIMEDIA) rather than ENABLE(QT_MULTIMEDIA).
        https://bugs.webkit.org/show_bug.cgi?id=57974

        We should use USE(QT_MULTIMEDIA) rather than ENABLE(QT_MULTIMEDIA).

        No new tests needed, just a config flag rename.

        * Api/qwebkitplatformplugin.h:
        * WebCoreSupport/ChromeClientQt.cpp:
        * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
        (DumpRenderTreeSupportQt::mediaContentUrlByElementId):
        * WebCoreSupport/FullScreenVideoQt.cpp:
        (WebCore::FullScreenVideoQt::FullScreenVideoQt):
        (WebCore::FullScreenVideoQt::~FullScreenVideoQt):
        (WebCore::FullScreenVideoQt::enterFullScreenForNode):
        (WebCore::FullScreenVideoQt::exitFullScreenForNode):
        (WebCore::FullScreenVideoQt::requiresFullScreenForVideoPlayback):
        (WebCore::FullScreenVideoQt::isValid):
        * WebCoreSupport/FullScreenVideoQt.h:
        * WebCoreSupport/QtPlatformPlugin.cpp:
        * WebCoreSupport/QtPlatformPlugin.h:
        * examples/platformplugin/WebPlugin.cpp:
        (WebPlugin::supportsExtension):
        (WebPlugin::createExtension):
        * examples/platformplugin/WebPlugin.h:
        * examples/platformplugin/platformplugin.pro:
        * examples/platformplugin/qwebkitplatformplugin.h:
        * tests/qwebpage/tst_qwebpage.cpp:
        (tst_QWebPage::loadHtml5Video):
        * tests/tests.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

oliver@apple.com [Wed, 6 Apr 2011 22:15:11 +0000 (22:15 +0000)]

2011-04-06  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        Stop JSObject::isUsingInlineStorage() from using the structure
        https://bugs.webkit.org/show_bug.cgi?id=57986

        Make the isUsingInlineStorage() implementation just look at
        whether the property storage is inside the object.

        * runtime/JSObject.h:
        (JSC::JSObject::isUsingInlineStorage):
        (JSC::JSObject::JSObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83107 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

barraclough@apple.com [Wed, 6 Apr 2011 22:10:16 +0000 (22:10 +0000)]

Update comments documenting JSVALUE64/JSVALUE32_64 JSValue representations.

Rubber stamped by Geoff Garen.

* runtime/JSImmediate.h:
* runtime/JSValue.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

commit-queue@webkit.org [Wed, 6 Apr 2011 22:02:10 +0000 (22:02 +0000)]

2011-04-06  Tyler Close  <tjclose@chromium.org>

        Reviewed by Nate Chapin.

        run-bindings-tests reference files out of sync with CodeGenerator*.pm
        https://bugs.webkit.org/show_bug.cgi?id=57967

        * bindings/scripts/test/V8/V8TestCallback.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

mrowe@apple.com [Wed, 6 Apr 2011 21:57:58 +0000 (21:57 +0000)]

Expose the original URL of a WKBackForwardListItem.

Reviewed by Darin Adler.

Needed for <rdar://problem/9074651>.

* UIProcess/API/C/WKBackForwardListItem.cpp:
(WKBackForwardListItemCopyOriginalURL):
* UIProcess/API/C/WKBackForwardListItem.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

scheib@chromium.org [Wed, 6 Apr 2011 21:53:00 +0000 (21:53 +0000)]

2011-04-06  Vincent Scheib  <scheib@chromium.org>

        Fixed GPU expectations for r80867

        * platform/chromium-gpu-mac/platform/chromium/compositing/huge-layer-rotated-expected.png: Added.
        * platform/chromium-gpu-win/platform/chromium/compositing/huge-layer-rotated-expected.png: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

commit-queue@webkit.org [Wed, 6 Apr 2011 21:49:09 +0000 (21:49 +0000)]

2011-04-06  Asanka Herath  <asanka@chromium.org>

        Reviewed by Darin Fisher.

        Add new TargetType: TargetIsFavicon

        https://bugs.webkit.org/show_bug.cgi?id=57659

        No new functionality added, so no additional tests.

        * platform/network/ResourceRequestBase.h:
2011-04-06  Asanka Herath  <asanka@chromium.org>

        Reviewed by Darin Fisher.

        Add new TargetType: TargetIsFavicon

        https://bugs.webkit.org/show_bug.cgi?id=57659

        * public/WebURLRequest.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

aroben@apple.com [Wed, 6 Apr 2011 21:47:10 +0000 (21:47 +0000)]

Add a "view leaks" link to builds on SnowLeopard Intel Leaks

Fixes <http://webkit.org/b/56032> Leaks viewer should be linked from leaks bot results page

Reviewed by David Kilzer.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(ExtractTestResults.resultDirectoryURL): Added. Moved code to calculate the URL for the
build's results directory here...
(ExtractTestResults.finished): ...from here.
(ExtractTestResultsAndLeaks): New class that's used by the leaks builder
(ExtractTestResultsAndLeaks.finished): Calls up to the base class, but also adds a "view
leaks" link to point to Leaks Viewer for this build.
(TestFactory): Added ExtractTestResultsClass abstraction. This isn't overridden anywhere,
but it seemed good to add for consistency with BuildAndTestFactory.
(BuildAndTestFactory): Added ExtractTestResultsClass abstraction.
(BuildAndTestLeaksFactory): Use ExtractTestResultsAndLeaks as our ExtractTestResultsClass so
that we'll get a "view leaks" link.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

ossy@webkit.org [Wed, 6 Apr 2011 21:31:55 +0000 (21:31 +0000)]

[Qt] media tests are flakey
https://bugs.webkit.org/show_bug.cgi?id=57983

* platform/qt/Skipped: Disable all media tests until fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

hyatt@apple.com [Wed, 6 Apr 2011 21:22:56 +0000 (21:22 +0000)]

https://bugs.webkit.org/show_bug.cgi?id=57981

Reviewed by Simon Fraser.

Update the column count and width computation algorithm for CSS3 multi-column layout
to match the revised pseudo-algorithm in the latest draft of the spec.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::calcColumnWidth):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

rniwa@webkit.org [Wed, 6 Apr 2011 21:08:20 +0000 (21:08 +0000)]

2011-04-06  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Eric Seidel.

        borderPaddingMarginStart and borderPaddingMarginEnd should take RenderInline
        https://bugs.webkit.org/show_bug.cgi?id=57965

        Changed the argument types of borderPaddingMarginStart and borderPaddingMarginEnd
        from RenderBoxModelObject to RenderInline since they call marginStart and marginEnd
        instead of marginStartForChild and marginEndForChild respectively.

        Calling these two functions on RenderInline is okay because writing-mode cannot differ
        from that of the containing block.

        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::borderPaddingMarginStart):
        (WebCore::borderPaddingMarginEnd):
        (WebCore::inlineLogicalWidth):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

commit-queue@webkit.org [Wed, 6 Apr 2011 20:55:17 +0000 (20:55 +0000)]

2011-04-06  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r83039.
        http://trac.webkit.org/changeset/83039
        https://bugs.webkit.org/show_bug.cgi?id=57978

        introduced a new regression in conjunction to
        ReplaceSelectionCommand (Requested by rniwa on #webkit).

        * editing/inserting/insert-paragraph-separator-tab-span-expected.txt: Removed.
        * editing/inserting/insert-paragraph-separator-tab-span.html: Removed.
2011-04-06  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r83039.
        http://trac.webkit.org/changeset/83039
        https://bugs.webkit.org/show_bug.cgi?id=57978

        introduced a new regression in conjunction to
        ReplaceSelectionCommand (Requested by rniwa on #webkit).

        * editing/EditingStyle.cpp:
        (WebCore::EditingStyle::init):
        * editing/InsertParagraphSeparatorCommand.cpp:
        (WebCore::InsertParagraphSeparatorCommand::doApply):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

commit-queue@webkit.org [Wed, 6 Apr 2011 20:52:17 +0000 (20:52 +0000)]

2011-04-06  Naoki Takano  <takano.naoki@gmail.com>

        Reviewed by David Levin.

        Webkit ignores PgUp/PgDown/Home/End in SELECT tag objects
        https://bugs.webkit.org/show_bug.cgi?id=27658

        * fast/events/select-element-expected.txt: Added to check PgUp/PgDown/Home/End keys are working correctly in SELECT tag.
        * fast/events/select-element.html: Added for expectation.
2011-04-06  Naoki Takano  <takano.naoki@gmail.com>

        Reviewed by David Levin.

        Webkit ignores PgUp/PgDown/Home/End in SELECT tag objects
        https://bugs.webkit.org/show_bug.cgi?id=27658

        Test: fast/events/select-element.html

        * dom/SelectElement.cpp:
        (WebCore::nextValidIndex): Moved from elsewhere in the file to be used by other routines.
        (WebCore::nextSelectableListIndexPageAway): Returns a selectable index one page away from the given index.
        (WebCore::nextSelectableListIndex): Implemented with nextValidIndex.
        And converted to a normal static function from a private function of SelectElement.
        (WebCore::previousSelectableListIndex): Implemented with nextValidIndex.
        And converted to a normal static function from a private function of SelectElement.
        (WebCore::firstSelectableListIndex): Returns the first selectable index.
        (WebCore::lastSelectableListIndex): Returns the last selectable index.
        (WebCore::SelectElement::menuListDefaultEventHandler): Converted from C cast to C++ cast.
        (WebCore::SelectElement::listBoxDefaultEventHandler): Adds support for PageUp/PageDown/Home/End with both single and multiple selection.

        * dom/SelectElement.h:
        (WebCore::SelectElement::): Remove nextSelectableListIndex() and previousSelectableListIndex().

        * rendering/RenderListBox.h: Makes RenderListBox::size public so that PageUp/PageDown behavior can use the actual list size rather than that specified in HTML.
        They can differ due to the minimum size imposed by RenderListBox.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

hyatt@apple.com [Wed, 6 Apr 2011 20:47:51 +0000 (20:47 +0000)]

https://bugs.webkit.org/show_bug.cgi?id=57975

Reviewed by Dan Bernstein.

The "More..." link for line clamping no longer shows up in Safari RSS. Fix the isLink() check
to just look at the style, so that it can find the InlineTextBox and not care that it's a child
of the link element and not the line box for the link element itself (since that line box got
culled).

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::applyLineClamp):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

enne@google.com [Wed, 6 Apr 2011 20:44:35 +0000 (20:44 +0000)]

2011-04-06  Adrienne Walker  <enne@google.com>

        Unreviewed, rebaseline Chromium Win tests after r83075.

        * platform/chromium-win/fast/multicol/nested-columns-expected.checksum: Removed.
        * platform/chromium-win/fast/multicol/nested-columns-expected.png:
        * platform/chromium-win/fast/multicol/vertical-lr/nested-columns-expected.checksum: Removed.
        * platform/chromium-win/fast/multicol/vertical-lr/nested-columns-expected.png:
        * platform/chromium-win/fast/multicol/vertical-rl/nested-columns-expected.checksum: Removed.
        * platform/chromium-win/fast/multicol/vertical-rl/nested-columns-expected.png:
        * platform/chromium-win/fast/text/capitalize-empty-generated-string-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

hyatt@apple.com [Wed, 6 Apr 2011 20:37:57 +0000 (20:37 +0000)]

Rebaseline text orientation layout test on Windows.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

ossy@webkit.org [Wed, 6 Apr 2011 20:35:49 +0000 (20:35 +0000)]

[Qt] Update platform specific expected results after r83075.

* platform/qt/editing/pasteboard/paste-text-011-expected.checksum:
* platform/qt/editing/pasteboard/paste-text-011-expected.png:
* platform/qt/editing/pasteboard/paste-text-011-expected.txt:
* platform/qt/fast/css-generated-content/014-expected.checksum:
* platform/qt/fast/css-generated-content/014-expected.png:
* platform/qt/fast/css-generated-content/014-expected.txt:
* platform/qt/fast/css/word-space-extra-expected.checksum:
* platform/qt/fast/css/word-space-extra-expected.png:
* platform/qt/fast/css/word-space-extra-expected.txt:
* platform/qt/tables/mozilla/bugs/bug16252-expected.txt:
* platform/qt/tables/mozilla/bugs/bug2123-expected.checksum:
* platform/qt/tables/mozilla/bugs/bug2123-expected.png:
* platform/qt/tables/mozilla/bugs/bug2123-expected.txt:
* platform/qt/tables/mozilla/bugs/bug43854-1-expected.checksum:
* platform/qt/tables/mozilla/bugs/bug43854-1-expected.png:
* platform/qt/tables/mozilla/bugs/bug43854-1-expected.txt:
* platform/qt/tables/mozilla/bugs/bug4523-expected.checksum:
* platform/qt/tables/mozilla/bugs/bug4523-expected.png:
* platform/qt/tables/mozilla/bugs/bug4523-expected.txt:
* platform/qt/tables/mozilla/bugs/bug57828-2-expected.checksum:
* platform/qt/tables/mozilla/bugs/bug57828-2-expected.png:
* platform/qt/tables/mozilla/bugs/bug57828-2-expected.txt:
* platform/qt/tables/mozilla/core/bloomberg-expected.checksum:
* platform/qt/tables/mozilla/core/bloomberg-expected.png:
* platform/qt/tables/mozilla/core/bloomberg-expected.txt:
* platform/qt/tables/mozilla/marvin/backgr_index-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

beidson@apple.com [Wed, 6 Apr 2011 20:31:39 +0000 (20:31 +0000)]

https://bugs.webkit.org/show_bug.cgi?id=57973 and https://bugs.webkit.org/show_bug.cgi?id=57973
WK2 icon database should be able to get a CGImage of a specific size

Reviewed by Anders Carlsson.

../WebCore:

* platform/graphics/BitmapImage.h:
* platform/graphics/Image.h:
(WebCore::Image::getFirstCGImageRefOfSize):

* platform/graphics/cg/ImageCG.cpp:
(WebCore::BitmapImage::getFirstCGImageRefOfSize): Walk the frames of the image until reaching the
first frame of the requested size.

../WebKit2:

* UIProcess/API/C/cg/WKIconDatabaseCG.cpp:
(WKIconDatabaseTryGetCGImageForURL): Change this API to take a requested size, and find the first matching
CGImage in the icon.
* UIProcess/API/C/cg/WKIconDatabaseCG.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

kevino@webkit.org [Wed, 6 Apr 2011 20:29:22 +0000 (20:29 +0000)]

Reviewed by Kevin Ollivier.

[wx] Fix cursor handling so that we always call the chrome to set it.

https://bugs.webkit.org/show_bug.cgi?id=57972

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83090 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

enne@google.com [Wed, 6 Apr 2011 20:17:50 +0000 (20:17 +0000)]

2011-04-06  Adrienne Walker  <enne@google.com>

        Unreviewed, mark Chromium expectations for line-clamp.html to be a known regression.
        https://bugs.webkit.org/show_bug.cgi?id=57975

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

commit-queue@webkit.org [Wed, 6 Apr 2011 20:14:20 +0000 (20:14 +0000)]

2011-04-06  Alok Priyadarshi  <alokp@chromium.org>

        Reviewed by Eric Seidel.

        [chromium] Add settings API to enable accelerated drawing
        https://bugs.webkit.org/show_bug.cgi?id=57863

        If accelerated drawing is enabled we try to render content and
        root layers using GPU. Please note that this setting is ignored if
        accelerated compositing is disabled.

        * public/WebSettings.h:
        * src/WebSettingsImpl.cpp:
        (WebKit::WebSettingsImpl::setAcceleratedDrawingEnabled):
        * src/WebSettingsImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

hyatt@apple.com [Wed, 6 Apr 2011 20:06:45 +0000 (20:06 +0000)]

https://bugs.webkit.org/show_bug.cgi?id=41445

Reviewed by Dan Bernstein.

Visited links painting with black background. Make sure that if the visited style has
the initial background color (transparent) set that we just use the unvisited color.

Source/WebCore:

Added fast/history/visited-link-background-color.html

* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::visitedDependentColor):

LayoutTests:

Added fast/history/visited-link-background-color.html
* fast/history/visited-link-background-color.html: Added.
* platform/mac/fast/history/visited-link-background-color-expected.checksum: Added.
* platform/mac/fast/history/visited-link-background-color-expected.png: Added.
* platform/mac/fast/history/visited-link-background-color-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

ossy@webkit.org [Wed, 6 Apr 2011 19:56:47 +0000 (19:56 +0000)]

Unreviewed Qt buildfix after r83079.

* WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

jberlin@webkit.org [Wed, 6 Apr 2011 19:56:28 +0000 (19:56 +0000)]

WebKit2: Implement TextChecker on Windows
https://bugs.webkit.org/show_bug.cgi?id=57862

Reviewed by Anders Carlsson.

Part 2: Implement uniqueSpellDocumentTag and closeSpellDocumentWithTag.

* UIProcess/API/C/win/WKTextChecker.h:
* UIProcess/win/TextCheckerWin.cpp:
(WebKit::TextChecker::uniqueSpellDocumentTag):
(WebKit::TextChecker::closeSpellDocumentWithTag):
* UIProcess/win/WebTextCheckerClient.cpp:
(WebKit::WebTextCheckerClient::uniqueSpellDocumentTag):
(WebKit::WebTextCheckerClient::closeSpellDocumentWithTag):
* UIProcess/win/WebTextCheckerClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

enne@google.com [Wed, 6 Apr 2011 19:46:35 +0000 (19:46 +0000)]

2011-04-06  Adrienne Walker  <enne@google.com>

       Unreviewed, update Chromium expectations for set-unloaded-frame-location.html as a flaky crasher.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83084 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

enne@google.com [Wed, 6 Apr 2011 19:31:03 +0000 (19:31 +0000)]

2011-04-06  Adrienne Walker  <enne@google.com>

       Unreviewed, rebaseline Chromium linux tests after r83075.

        * platform/chromium-linux/fast/multicol/nested-columns-expected.checksum: Removed.
        * platform/chromium-linux/fast/multicol/nested-columns-expected.png:
        * platform/chromium-linux/fast/multicol/vertical-lr/nested-columns-expected.checksum: Removed.
        * platform/chromium-linux/fast/multicol/vertical-lr/nested-columns-expected.png:
        * platform/chromium-linux/fast/multicol/vertical-rl/nested-columns-expected.checksum: Removed.
        * platform/chromium-linux/fast/multicol/vertical-rl/nested-columns-expected.png:
        * platform/chromium-linux/fast/text/capitalize-empty-generated-string-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

dino@apple.com [Wed, 6 Apr 2011 19:26:23 +0000 (19:26 +0000)]

2011-04-06  Dean Jackson  <dino@apple.com>

        Reviewed by Chris Marrin.

        https://bugs.webkit.org/show_bug.cgi?id=56936
        Crash in ImplicitAnimation::~ImplicitAnimation

        Make sure the style and start time waiting lists
        are cleared in the CompositeAnimation destructor. This
        way, no running transitions can be left in a state
        where they are destroyed as the AnimationControllerPrivate
        cleans up.

        * page/animation/CompositeAnimation.cpp:
        (WebCore::CompositeAnimation::~CompositeAnimation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

commit-queue@webkit.org [Wed, 6 Apr 2011 19:24:20 +0000 (19:24 +0000)]

2011-04-06  Robert Sesek  <rsesek@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Move code duplicated between the WebKit/mac and WebKit2 down to WebCore because Chromium will need it too
        https://bugs.webkit.org/show_bug.cgi?id=54969

        No change in behavior; no new tests.

        * editing/TextIterator.cpp:
        (WebCore::TextIterator::locationAndLengthFromRange): New method from duplicated code in WebKits
        * editing/TextIterator.h:
        * page/Frame.cpp:
        (WebCore::Frame::rangeForPoint): New method from duplicated code in WebKits
2011-04-06  Robert Sesek  <rsesek@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Move code duplicated between the WebKit/mac and WebKit2 down to WebCore because Chromium will need it too
        https://bugs.webkit.org/show_bug.cgi?id=54969

        * WebView/WebFrame.mm:
        (-[WebFrame _convertToNSRange:]): Moved duplicated code to WebCore
        (-[WebFrame _characterRangeAtPoint:]): Moved duplicated code to WebCore
2011-04-06  Robert Sesek  <rsesek@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Move code duplicated between the WebKit/mac and WebKit2 down to WebCore because Chromium will need it too
        https://bugs.webkit.org/show_bug.cgi?id=54969

        * WebProcess/WebCoreSupport/WebEditorClient.cpp:
        (WebKit::WebEditorClient::respondToChangedSelection): Moved duplicated code to WebCore
        * WebProcess/WebPage/mac/WebPageMac.mm: Moved duplicated code to WebCore
        (WebKit::WebPage::getMarkedRange):
        (WebKit::WebPage::getSelectedRange):
        (WebKit::WebPage::characterIndexForPoint):
        (WebKit::WebPage::performDictionaryLookupAtLocation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

alexis.menard@openbossa.org [Wed, 6 Apr 2011 18:50:06 +0000 (18:50 +0000)]

2011-04-06  Alexis Menard  <alexis.menard@openbossa.org>

        Reviewed by Andreas Kling.

        Skip tests not passing in the Qt bot.

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

steveblock@google.com [Wed, 6 Apr 2011 18:46:49 +0000 (18:46 +0000)]

2011-04-06  Leandro Gracia Gil  <leandrogracia@chromium.org>

        Reviewed by Steve Block.

        Factoring the creation of 'FunctionOnly' callbacks in JavaScriptCore.
        https://bugs.webkit.org/show_bug.cgi?id=57770

        Create a template from an existing functionality in JSGeolocationCustom.cpp
        to be used by the custom bindings of both Geolocation and the Media Stream API.
        V8 version of this bug: https://bugs.webkit.org/show_bug.cgi?id=57760

        No new tests. LayoutTests/fast/dom/Geolocation/argument-types.html

        * Android.jscbindings.mk:
        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/CallbackFunction.cpp: Added.
        (WebCore::checkFunctionOnlyCallback):
        * bindings/js/CallbackFunction.h: Added.
        (WebCore::createFunctionOnlyCallback):
        * bindings/js/JSBindingsAllInOne.cpp:
        * bindings/js/JSGeolocationCustom.cpp:
        (WebCore::JSGeolocation::getCurrentPosition):
        (WebCore::JSGeolocation::watchPosition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

alexis.menard@openbossa.org [Wed, 6 Apr 2011 18:43:29 +0000 (18:43 +0000)]

2011-04-06  Alexis Menard  <alexis.menard@openbossa.org>

        Reviewed by Andreas Kling.

        [Qt] Implement fullscreen playback for the GStreamer backend.
        https://bugs.webkit.org/show_bug.cgi?id=56826

        Implement support for fullscreen playback when building the
        Qt port with the GStreamer backend (DEFINES+=USE_GSTREAMER=1).
        The implementation is done in FullScreenVideoQt alongside with
        the Qt Multimedia support.

        No new tests because layout tests cover it. They are not yet activated
        but will be any time soon.

        * platform/graphics/gstreamer/PlatformVideoWindowPrivate.h:
        * platform/graphics/gstreamer/PlatformVideoWindowQt.cpp:
        (FullScreenVideoWindow::FullScreenVideoWindow):
        (FullScreenVideoWindow::setVideoElement):
        (FullScreenVideoWindow::closeEvent):
        (FullScreenVideoWindow::keyPressEvent):
        (FullScreenVideoWindow::event):
        (FullScreenVideoWindow::showFullScreen):
        (FullScreenVideoWindow::hideCursor):
        (FullScreenVideoWindow::showCursor):
2011-04-06  Alexis Menard  <alexis.menard@openbossa.org>

        Reviewed by Andreas Kling.

        [Qt] Implement fullscreen playback for the GStreamer backend.
        https://bugs.webkit.org/show_bug.cgi?id=56826

        Implement support for fullscreen playback when building the
        Qt port with the GStreamer backend (DEFINES+=USE_GSTREAMER=1).
        The implementation is done in FullScreenVideoQt alongside with
        the Qt Multimedia support.

        No new tests because layout tests cover it. They are not yet activated
        but will be any time soon.

        * QtWebKit.pro:
        * WebCoreSupport/ChromeClientQt.cpp:
        (WebCore::ChromeClientQt::ChromeClientQt):
        (WebCore::ChromeClientQt::~ChromeClientQt):
        (WebCore::ChromeClientQt::enterFullscreenForNode):
        (WebCore::ChromeClientQt::exitFullscreenForNode):
        * WebCoreSupport/ChromeClientQt.h:
        * WebCoreSupport/FullScreenVideoQt.cpp:
        (WebCore::GStreamerFullScreenVideoHandler::GStreamerFullScreenVideoHandler):
        (WebCore::GStreamerFullScreenVideoHandler::setVideoElement):
        (WebCore::GStreamerFullScreenVideoHandler::enterFullScreen):
        (WebCore::GStreamerFullScreenVideoHandler::windowClosed):
        (WebCore::GStreamerFullScreenVideoHandler::exitFullScreen):
        (WebCore::DefaultFullScreenVideoHandler::DefaultFullScreenVideoHandler):
        (WebCore::FullScreenVideoQt::FullScreenVideoQt):
        (WebCore::FullScreenVideoQt::~FullScreenVideoQt):
        (WebCore::FullScreenVideoQt::enterFullScreenForNode):
        (WebCore::FullScreenVideoQt::exitFullScreenForNode):
        (WebCore::FullScreenVideoQt::requiresFullScreenForVideoPlayback):
        (WebCore::FullScreenVideoQt::isValid):
        * WebCoreSupport/FullScreenVideoQt.h:
        (WebCore::GStreamerFullScreenVideoHandler::~GStreamerFullScreenVideoHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

commit-queue@webkit.org [Wed, 6 Apr 2011 18:40:50 +0000 (18:40 +0000)]

2011-04-06  Zan Dobersek  <zandobersek@gmail.com>

        Reviewed by Eric Seidel.

        [Gtk] plugins/set-status.html fails
        https://bugs.webkit.org/show_bug.cgi?id=57844

        Unskip a newly-passing test.

        * platform/gtk/Skipped:
2011-04-06  Zan Dobersek  <zandobersek@gmail.com>

        Reviewed by Eric Seidel.

        [Gtk] plugins/set-status.html fails
        https://bugs.webkit.org/show_bug.cgi?id=57844

        Allow an empty status text to be dumped.

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (webViewStatusBarTextChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

rniwa@webkit.org [Wed, 6 Apr 2011 18:34:11 +0000 (18:34 +0000)]

2011-04-06  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Dimitri Glazkov.

        Bundle lineLeftOffset and lineRightOffset as a class
        https://bugs.webkit.org/show_bug.cgi?id=57851

        Added a new class LineOffsets that encapsulates lineLeftOffset and lineRightOffset.
        The patch makes clear that lineLeftOffset and lineRightOffset are never read individually
        and only the difference is used to compute the width.

        * rendering/RenderBlock.h:
        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::RenderBlock::skipLeadingWhitespace): Takes LineOffsets instead of two integers.
        (WebCore::LineOffsets::LineOffsets): Added.
        (WebCore::LineOffsets::width): Added.
        (WebCore::LineOffsets::setLeft): Added.
        (WebCore::LineOffsets::setRight): Added.
        (WebCore::RenderBlock::findNextLineBreak): Calls skipLeadingWhitespace and positionNewFloatOnLine.
        (WebCore::RenderBlock::positionNewFloatOnLine): Takes LineOffsets instead of two integers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

hyatt@apple.com [Wed, 6 Apr 2011 18:20:52 +0000 (18:20 +0000)]

https://bugs.webkit.org/show_bug.cgi?id=57916

Reviewed by Dan Bernstein.

Implement an optimization to the line box tree to cull out most of the intermediate
line boxes that can occur between the root line box and the leaves of the tree (images
and text).

Source/WebCore:

RenderInlines now have a boolean member, m_alwaysCreateLineBoxes,
that starts off as false. Only if it gets flipped to true will there be any line boxes
created for that RenderInline.

* page/FocusController.cpp:
(WebCore::FocusController::advanceFocusDirectionally):
Adjust the ordering of updateLayout calls to make sure rects aren't queried unless layout
is up to date.

* page/SpatialNavigation.cpp:
(WebCore::hasOffscreenRect):
(WebCore::nodeRectInAbsoluteCoordinates):
Add asserts in spatial navigation code to catch any future bad queries that might be made
for rectangles without layout being up to date.

* platform/graphics/FloatRect.cpp:
(WebCore::FloatRect::uniteIfNonZero):
* platform/graphics/FloatRect.h:
* platform/graphics/IntRect.cpp:
(WebCore::IntRect::uniteIfNonZero):
* platform/graphics/IntRect.h:
Add a new unite function that is useful for the render tree to FloatRect and IntRect.  This
version allows rect unites to happen if either width or height is nonzero.

* rendering/HitTestResult.cpp:
(WebCore::HitTestResult::addNodeToRectBasedTestResult):
Make sure rect-based hit testing properly adds in culled inline ancestors to the set of nodes
if content inside those inlines is hit.

* rendering/InlineBox.h:
(WebCore::InlineBox::logicalFrameRect):
Fix a bug in this function for obtaining the logical frame rect of an inline box.

* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::addToLine):
addToLine now also checks line gap in the line box tree optimization checks.

(WebCore::InlineFlowBox::addTextBoxVisualOverflow):
(WebCore::InlineFlowBox::computeOverflow):
* rendering/InlineFlowBox.h:
Rewritten to add the text box overflow to the text box itself.

* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::destroy):
Destroy has been changed to call a helper function to remove and destroy the line boxes that
is now called from one additional spot.

(WebCore::InlineTextBox::logicalOverflowRect):
(WebCore::InlineTextBox::setLogicalOverflowRect):
Text boxes now cache their own overflow in a global hash table.

(WebCore::InlineTextBox::baselinePosition):
(WebCore::InlineTextBox::lineHeight):
Changed to not assume that the parent line box's renderer is the RenderText's immediate
parent, since intermediate line boxes may have been culled.

(WebCore::InlineTextBox::paint):
Paint now properly checks only the text box overflow instead of the parent line box's overflow.

* rendering/InlineTextBox.h:
(WebCore::InlineTextBox::logicalTopVisualOverflow):
(WebCore::InlineTextBox::logicalBottomVisualOverflow):
(WebCore::InlineTextBox::logicalLeftVisualOverflow):
(WebCore::InlineTextBox::logicalRightVisualOverflow):
New accessors to obtain overflow for inline text boxes.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::updateFirstLetter):
updateFirstLetter now removes text boxes from the line box tree before it destroys them, since those
text boxes may not have anything in between them and the block that contains the inline first letter
container.

* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::createLineBoxes):
The culling optimization is done here.  Only if the RenderInline says that boxes are allowed will they
be created.

(WebCore::RenderBlock::layoutInlineChildren):
The state of the RenderInline is updated here, in case it is discovered that line boxes are now needed.
This is done before any lines are built.

* rendering/RenderInline.cpp:
(WebCore::RenderInline::RenderInline):
The new m_alwaysCreateLineBoxes flag has been added to the constructor.

(WebCore::RenderInline::styleDidChange):
An initial update of the m_alwaysCreateLineBoxes happens here for things that can be checked immediately
(like having a layer, borders, padding, margins or backgrounds).  Some checks that depend on examining
the RenderInline's parent (including first line styles) happen later in layoutInlineChildren.

(WebCore::RenderInline::updateAlwaysCreateLineBoxes):
The function called by layoutInlineChildren to check parent and child style differences (e.g., font,
vertical alignment, line height, etc.).

(WebCore::RenderInline::absoluteRects):
(WebCore::RenderInline::culledInlineAbsoluteRects):
absoluteRects calls culledInlineAbsoluteRects when m_alwaysCreateLineBoxes is false.

(WebCore::RenderInline::absoluteQuads):
(WebCore::RenderInline::culledInlineAbsoluteQuads):
absoluteQuads calls culledInlineAbsoluteQuads when m_alwaysCreateLineBoxes is false.

(WebCore::RenderInline::offsetLeft):
(WebCore::RenderInline::offsetTop):
offsetLeft and offsetTop now check descendant renderers when m_alwaysCreateLineBoxes is false.

(WebCore::RenderInline::linesBoundingBox):
(WebCore::RenderInline::culledInlineBoundingBox):
lineBoundingBox calls culledInlineBoundingBox when m_alwaysCreateLineBoxes is false.

(WebCore::RenderInline::culledInlineFirstLineBox):
(WebCore::RenderInline::culledInlineLastLineBox):
Helpers that return the first and last line box descendants. Used by firstLineBoxIncludingCulling and
lastLineBoxIncludingCulling (which are in turn called by offsetLeft and offsetTop).

(WebCore::RenderInline::culledInlineVisualOverflowBoundingBox):
(WebCore::RenderInline::linesVisualOverflowBoundingBox):
linesVisualOverflowBoundingBox calls culledInlineVisualOverflowBoundingBox when m_alwaysCreateLineBoxes is false.

(WebCore::RenderInline::clippedOverflowRectForRepaint):
The initial bailout check is now done using firstLineBoxIncludingCulling instead of just firstLineBox.

(WebCore::RenderInline::dirtyLineBoxes):
dirtyLineBoxes now crawls into descendants to figure out which root lines to dirty when
m_alwaysCreateLineBoxes is false.

(WebCore::RenderInline::createAndAppendInlineFlowBox):
Clear the m_alwaysCreateLineBoxes if a box gets added anyway. This happens for leaf inline flows and also
when line-box-contain is set to an unusual value.

(WebCore::RenderInline::addFocusRingRects):
Used culledInlineAbsoluteRects in place of the line box walk when m_alwaysCreateLineBoxes is false.

* rendering/RenderInline.h:
(WebCore::RenderInline::firstLineBoxIncludingCulling):
(WebCore::RenderInline::lastLineBoxIncludingCulling):
Helpers used in a few places (like offsetLeft and offsetTop), mostly in places where the existence of a box
is all that needs checking.

(WebCore::RenderInline::alwaysCreateLineBoxes):
(WebCore::RenderInline::setAlwaysCreateLineBoxes):
Functions for getting and setting the m_alwaysCreateLineBoxes flag.

* rendering/RenderLineBoxList.cpp:
(WebCore::RenderLineBoxList::dirtyLinesFromChangedChild):
Modified to use firstLineBoxIncludingCulling and lastLineBoxIncludingCulling to ensure the right set of
lines get dirtied.

* rendering/RenderText.cpp:
(WebCore::RenderText::removeAndDestroyTextBoxes):
New helper invoked by destroy and also from updateFirstLetter.

(WebCore::RenderText::destroy):
Changed to call removeAndDestroyTextBoxes.

(WebCore::RenderText::absoluteRects):
Fixed to be properly physical instead of logical.

(WebCore::RenderText::linesVisualOverflowBoundingBox):
New implementation for RenderText that gives the bounding box of the text boxes including overflow from
shadows, glyphs, text-stroke, etc.  Used by RenderInline::culledInlineVisualOverflowBoundingBox.

* rendering/RenderText.h:
* rendering/svg/RenderSVGInline.cpp:
(WebCore::RenderSVGInline::RenderSVGInline):
RenderSVGInline always sets m_alwaysCreateLineBoxes to true so that SVG is unaffected by this optimization.

* rendering/svg/SVGRootInlineBox.cpp:
(WebCore::SVGRootInlineBox::layoutCharactersInTextBoxes):
(WebCore::SVGRootInlineBox::layoutChildBoxes):
Move the isInlineFlowBox asserts to after the generated content skips, since the generated content boxes are
now InlineTextBoxes (the enclosing InlineFlowBoxes got culled).

LayoutTests:

RenderInlines now have a boolean member, m_alwaysCreateLineBoxes,
that starts off as false. Only if it gets flipped to true will there be any line boxes
created for that RenderInline.

* platform/mac/fast/blockflow/text-orientation-basic-expected.txt:
* platform/mac/fast/text/capitalize-empty-generated-string-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

morrita@google.com [Wed, 6 Apr 2011 18:17:17 +0000 (18:17 +0000)]

2011-04-06  MORITA Hajime  <morrita@google.com>

        Unreviewed expectations udpate for gtk port that follows r83065.

        * platform/gtk/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt:
        * platform/gtk/fast/dom/HTMLProgressElement/progress-element-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

enne@google.com [Wed, 6 Apr 2011 18:15:07 +0000 (18:15 +0000)]

2011-04-06  Adrienne Walker  <enne@google.com>

       Unreviewed, modify Chromium test expectations from r83065.  They need
       rebaselines, but in the meantime they should fail more generally so as
       not to trip the bots.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

alexis.menard@openbossa.org [Wed, 6 Apr 2011 18:13:58 +0000 (18:13 +0000)]

2011-04-06  Alexis Menard  <alexis.menard@openbossa.org>

        Reviewed by Benjamin Poulain.

        [Qt] Unskip some media LayoutTests.
        https://bugs.webkit.org/show_bug.cgi?id=57855

        Unskip some media tests for Qt.

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

commit-queue@webkit.org [Wed, 6 Apr 2011 18:12:30 +0000 (18:12 +0000)]

2011-04-06  Chang Shu  <cshu@webkit.org>

        Reviewed by Darin Adler.

        WebKitTestRunner needs layoutTestController.pageNumberForElementById
        https://bugs.webkit.org/show_bug.cgi?id=42329

        Unskip passed tests.

        * platform/mac-wk2/Skipped:
        * platform/qt-wk2/Skipped:
2011-04-06  Chang Shu  <cshu@webkit.org>

        Reviewed by Darin Adler.

        WebKitTestRunner needs layoutTestController.pageNumberForElementById
        https://bugs.webkit.org/show_bug.cgi?id=42329

        * WebProcess/InjectedBundle/API/c/WKBundle.cpp:
        (WKBundlePageNumberForElementById):
        * WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
        * WebProcess/InjectedBundle/InjectedBundle.cpp:
        (WebKit::InjectedBundle::pageNumberForElementById):
        * WebProcess/InjectedBundle/InjectedBundle.h:
2011-04-06  Chang Shu  <cshu@webkit.org>

        Reviewed by Darin Adler.

        WebKitTestRunner needs layoutTestController.pageNumberForElementById
        https://bugs.webkit.org/show_bug.cgi?id=42329

        * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
        * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
        (WTR::LayoutTestController::pageNumberForElementById):
        * WebKitTestRunner/InjectedBundle/LayoutTestController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

enrica@apple.com [Wed, 6 Apr 2011 18:03:32 +0000 (18:03 +0000)]

REGRESSION: Drag & Drop Gmail Attachments doesn't work.
https://bugs.webkit.org/show_bug.cgi?id=57909
<rdar://problem/9103220>

Reviewed by Darin Adler.

Source/WebCore:

In WebKit2 we cannot rely on the value returned by platformData() that
on Mac returns an NSDraggingInfo object. This is available only in the UI
process. Therefore we should use m_pasteboard instead.
We cannot change what platformData() returns on Mac, since there are
delegate methods that receive a NSDraggingInfo object (only in WebKit).

* platform/DragData.h:
(WebCore::DragData::pasteboard): Added.
* platform/mac/ClipboardMac.mm:
(WebCore::Clipboard::create): Changed to use pasteboard() instead of platformData().
* platform/mac/DragDataMac.mm:
(WebCore::DragData::asColor): Replaced references to m_platformData with m_pasteboard.
(WebCore::DragData::asURL): Same as above.

Source/WebKit2:

Added _hitTest method to support drag and drop when the drag types cannot be matched.
This is the case for elements that do not place content
in the drag pasteboard automatically when the drag start (i.e. dragging a DIV element).

* UIProcess/API/mac/WKView.mm:
(-[WKView _hitTest:dragTypes:]): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

commit-queue@webkit.org [Wed, 6 Apr 2011 17:56:27 +0000 (17:56 +0000)]

2011-04-06  Steve Lacey  <sjl@chromium.org>

        Reviewed by Eric Carlson.

        fast/layer/video_layer.html has the same text output for all chromium mac platforms.

        [chromium] Fix fast/layers/video_layer.html expectations
        https://bugs.webkit.org/show_bug.cgi?id=57386

        * platform/chromium-mac-leopard/fast/layers/video-layer-expected.txt: Removed.
        * platform/chromium-mac/fast/layers/video-layer-expected.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

sergio@webkit.org [Wed, 6 Apr 2011 17:32:27 +0000 (17:32 +0000)]

2011-04-06  Sergio Villar Senin  <svillar@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] DumpRenderTree: do not try to free NULL SoupURIs
        https://bugs.webkit.org/show_bug.cgi?id=57932

        Some Layout tests have invalid URIs that do not generate valid
        SoupURI instances. Do not try to free those NULL SoupURIs.

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (willSendRequestCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

benjamin.poulain@nokia.com [Wed, 6 Apr 2011 17:19:29 +0000 (17:19 +0000)]

2011-04-06  Benjamin Poulain  <benjamin.poulain@nokia.com>

        Reviewed by Darin Adler.

        ClipboardWin has unused variables "ExceptionCode ec"
        https://bugs.webkit.org/show_bug.cgi?id=57952

        Remove the unused variable.

        * platform/win/ClipboardWin.cpp:
        (WebCore::ClipboardWin::declareAndWriteDragImage):
        (WebCore::ClipboardWin::writePlainText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

rniwa@webkit.org [Wed, 6 Apr 2011 17:06:14 +0000 (17:06 +0000)]

2011-04-06  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Dimitri Glazkov.

        Split getBorderPaddingMargin into two functions
        https://bugs.webkit.org/show_bug.cgi?id=57947

        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::borderPaddingMarginStart): Extracted from getBorderPaddingMargin.
        (WebCore::borderPaddingMarginEnd): Ditto.
        (WebCore::inlineLogicalWidth): Calls borderPaddingMarginStart and borderPaddingMarginEnd.
        (WebCore::RenderBlock::findNextLineBreak): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

morrita@google.com [Wed, 6 Apr 2011 17:03:26 +0000 (17:03 +0000)]

2011-04-06  MORITA Hajime  <morrita@google.com>

        Reviewed by Dimitri Glazkov.

        [Refactoring] <progress> should not have manual layout code.
        https://bugs.webkit.org/show_bug.cgi?id=57801

        Updated progress-bar-value-pseudo-element.html to have wider coverage and
        follow pseudo class change.

        * fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element.html:
        * platform/chromium/test_expectations.txt:
        * platform/mac/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.checksum:
        * platform/mac/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.png:
        * platform/mac/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt:
2011-04-06  MORITA Hajime  <morrita@google.com>

        Reviewed by Dimitri Glazkov.

        [Refactoring] <progress> should not have manual layout code.
        https://bugs.webkit.org/show_bug.cgi?id=57801

        - Simplified RenderProgress, removing its custom layout code
        - Introducing ProgressValueElement and ProgressBarElement, replacing
          ProgressBarValueElement.

        Now the structure is almost identical to <meter>,
        other than:
        - RenderProgress has animated painting, thus manages its own timer.
        - Both ProgressValueElement and ProgressBarElement has pseudo classes
          which don't changes during its lifetime.

        * Android.mk:
        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * css/html.css:
        (progress):
        (progress::-webkit-progress-bar):
        (progress::-webkit-progress-value):
        * html/HTMLProgressElement.cpp:
        (WebCore::HTMLProgressElement::~HTMLProgressElement):
        (WebCore::HTMLProgressElement::create):
        (WebCore::HTMLProgressElement::attach):
        (WebCore::HTMLProgressElement::didElementStateChange):
        (WebCore::HTMLProgressElement::createShadowSubtree):
        * html/HTMLProgressElement.h:
        * html/shadow/ProgressShadowElement.cpp: Copied from Source/WebCore/html/shadow/ProgressBarValueElement.h.
        (WebCore::ProgressShadowElement::ProgressShadowElement):
        (WebCore::ProgressShadowElement::progressElement):
        (WebCore::ProgressShadowElement::rendererIsNeeded):
        (WebCore::ProgressBarElement::shadowPseudoId):
        (WebCore::ProgressValueElement::shadowPseudoId):
        (WebCore::ProgressValueElement::setWidthPercentage):
        * html/shadow/ProgressShadowElement.h: Renamed from Source/WebCore/html/shadow/ProgressBarValueElement.h.
        (WebCore::ProgressBarElement::ProgressBarElement):
        (WebCore::ProgressBarElement::create):
        (WebCore::ProgressValueElement::ProgressValueElement):
        (WebCore::ProgressValueElement::create):
        * rendering/RenderProgress.cpp:
        (WebCore::RenderProgress::RenderProgress):
        (WebCore::RenderProgress::updateFromElement):
        (WebCore::RenderProgress::animationTimerFired):
        * rendering/RenderProgress.h:
        (WebCore::RenderProgress::requiresForcedStyleRecalcPropagation):
        (WebCore::RenderProgress::canHaveChildren):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

mario@webkit.org [Wed, 6 Apr 2011 16:50:25 +0000 (16:50 +0000)]

2011-04-06  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Chris Fleizach.

        [GTK] Do not reference AccessibilityRenderObject from platform dependent code
        https://bugs.webkit.org/show_bug.cgi?id=57955

        Do not reference AccessibilityRenderObject from platform specific code

        Added new virtual functions to AccessibilityObject.h and removed
        explicit references to AccessibilityRenderObject from GTK code.

        * accessibility/AccessibilityObject.h:
        (WebCore::AccessibilityObject::renderer): New virtual method,
        returning 0 by default. Overriden by AccessibilityRenderObject.
        (WebCore::AccessibilityObject::correspondingLabelForControlElement):
        New virtual method, returning 0 by default. It complements the
        already present method correspondingControlForLabelElement().

        * accessibility/AccessibilityRenderObject.h:
        (WebCore::AccessibilityRenderObject::renderer): Made virtual.

        * accessibility/gtk/AXObjectCacheAtk.cpp:
        (WebCore::emitTextChanged): Reference  AccessibilityObject,
        instead of AccessibilityRenderObject.
        (WebCore::AXObjectCache::nodeTextChangePlatformNotification):
        Ditto.

        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
        (webkit_accessible_get_name): Do not reference
        AccessibilityRenderObject.
        (webkit_accessible_get_description): Ditto.
        (setAtkRelationSetFromCoreObject): Ditto.
        (optionFromList): Ditto.
        (optionFromSelection): Ditto.
        (webkit_accessible_selection_clear_selection): Ditto.
        (webkit_accessible_selection_get_selection_count): Ditto.
        (webkit_accessible_selection_select_all_selection): Ditto.
        (textForObject): Ditto.
        (webkit_accessible_text_get_text): Ditto.
        (getPangoLayoutForAtk): Ditto.
        (webkit_accessible_text_get_caret_offset): Ditto.
        (baselinePositionForRenderObject): Ditto.
        (getAttributeSetForAccessibilityObject): Ditto.
        (accessibilityObjectLength): Ditto.
        (getSelectionOffsetsForObject): Ditto.
        (webkit_accessible_text_set_selection): Ditto.
        (webkit_accessible_text_set_caret_offset): Ditto.
        (webkit_accessible_table_get_caption): Ditto.
        (getInterfaceMaskFromObject): Ditto.

        * accessibility/gtk/WebKitAccessibleHyperlink.cpp:
        (getRangeLengthForObject): Ditto.

        Removed unused renderer() method from AccessibilityMenuList.

        * accessibility/AccessibilityMenuList.h: Removed unused method.
        * accessibility/AccessibilityMenuList.cpp: Removed unused method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

demarchi@webkit.org [Wed, 6 Apr 2011 16:39:52 +0000 (16:39 +0000)]

2011-04-06  Lucas De Marchi  <lucas.demarchi@profusion.mobi>

        cmake: Fix build for ARMv7

        * CMakeLists.txt: add missing file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

apavlov@chromium.org [Wed, 6 Apr 2011 16:19:34 +0000 (16:19 +0000)]

2011-04-06  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Javascipt warning link expand and overlap with icons in js console
        https://bugs.webkit.org/show_bug.cgi?id=57939

        * inspector/front-end/inspector.js:
        (WebInspector.linkifyURLAsNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

apavlov@chromium.org [Wed, 6 Apr 2011 16:12:58 +0000 (16:12 +0000)]

2011-04-06  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Beautify parameter names in Inspector.json (CSS domain)
        https://bugs.webkit.org/show_bug.cgi?id=57931

        * inspector/Inspector.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

commit-queue@webkit.org [Wed, 6 Apr 2011 16:09:28 +0000 (16:09 +0000)]

2011-04-06  Jia Pu  <jpu@apple.com>

        Reviewed by Darin Adler.

        [Mac] WebCore need to notify AppKit spell checker after user has modified autocorrected text.
        https://bugs.webkit.org/show_bug.cgi?id=57665
        <rdar://problem/7350477>

        We need to track how user modified an autocorrected word. If he changed it back to original
        text, we want to record AutocorrectionReverted response. And if he changed it to something
        else, we want to record AutocorrectionEdited response.

        To achieve this, we need to distringuish between text replacement caused by autocorrection
        from that due to other causes, such as reversion, text substitution, etc. So we added a new
        marker type "Autocorrected". We also need to be able to check for correction, even when we
        don't intend to actually carry out replacement. For this, we introduced a new TextCheckingOption
        value, "CheckForCorrection".

        We also added DocumentMarkerController::markersInRange() to retrieve a vector of markers in
        specified range, and of specified type.

        * dom/DocumentMarker.h:
        * dom/DocumentMarkerController.cpp:
        (WebCore::DocumentMarkerController::markersInRange):
        (WebCore::DocumentMarkerController::hasMarkers):
        * dom/DocumentMarkerController.h:
        * editing/Editor.cpp:
        (WebCore::markerTypesForAutocorrection):
        (WebCore::markersHaveIdenticalDescription):
        (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
        (WebCore::Editor::recordSpellcheckerResponseForModifiedCorrection):
        (WebCore::Editor::changeBackToReplacedString):
        (WebCore::Editor::markMisspellingsAndBadGrammar):
        (WebCore::Editor::applyCorrectionPanelInfo):
        (WebCore::Editor::unappliedSpellCorrection):
        (WebCore::Editor::textCheckingTypeMaskFor):
        * editing/Editor.h:
        * editing/SpellingCorrectionCommand.cpp:
        (WebCore::SpellingCorrectionCommand::doApply):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

commit-queue@webkit.org [Wed, 6 Apr 2011 16:09:19 +0000 (16:09 +0000)]

2011-04-06  Liang Qi  <liang.qi@nokia.com>

        Reviewed by Benjamin Poulain.

        Correct a include file name.
        https://bugs.webkit.org/show_bug.cgi?id=57839

        * wtf/PageAllocatorSymbian.h: It should be case sensitive. This fix
        builds on Unix hosts.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

aroben@apple.com [Wed, 6 Apr 2011 15:58:57 +0000 (15:58 +0000)]

Build fix after r83056

* JavaScriptCore.vcproj/JavaScriptCore/copy-files.cmd: Added property svn:executable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

enne@google.com [Wed, 6 Apr 2011 15:54:44 +0000 (15:54 +0000)]

2011-04-06  Adrienne Walker  <enne@google.com>

       Unreviewed, add Chromium snow leopard baseline for meter-boundary-values

        * platform/chromium-mac/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

aroben@apple.com [Wed, 6 Apr 2011 15:47:57 +0000 (15:47 +0000)]

Move JavaScriptCoreGenerated's file-copying logic out to a new script

Hopefully this will make it easier to modify this logic in the future. I also made the
script much quieter than the old logic, since it didn't seem helpful to see long lists of
filenames during the copying phase.

If we like this new style, we could copy it for our other projects.

Fixes <http://webkit.org/b/57950> JavaScriptCoreGenerated's file-copying logic is hard to
modify and noisy

Reviewed by Steve Falkenburg.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.make: Moved logic to copy
files from here...
* JavaScriptCore.vcproj/JavaScriptCore/copy-files.cmd: ...to here. (Added.)

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreGenerated.vcproj: Added copy-files.cmd
for convenience.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83056 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

ossy@webkit.org [Wed, 6 Apr 2011 15:45:57 +0000 (15:45 +0000)]

ORWT shouldn't generate diff files for tests without expected files
https://bugs.webkit.org/show_bug.cgi?id=57846

Reviewed by Andreas Kling.

* Scripts/old-run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

ossy@webkit.org [Wed, 6 Apr 2011 15:44:11 +0000 (15:44 +0000)]

Fix using UNUSED_PARAM introduced in r82907
https://bugs.webkit.org/show_bug.cgi?id=57940

Reviewed by Darin Adler.

* WebProcess/ResourceCache/WebResourceCacheManager.cpp:
(WebKit::WebResourceCacheManager::clearCacheForOrigin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83054 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

podivilov@chromium.org [Wed, 6 Apr 2011 15:41:18 +0000 (15:41 +0000)]

2011-04-06  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r83045.
        http://trac.webkit.org/changeset/83045
        https://bugs.webkit.org/show_bug.cgi?id=57953

        Broke win layout tests (Requested by podivilov on #webkit).

        * inspector/debugger/script-formatter-expected.txt: Removed.
        * inspector/debugger/script-formatter.html: Removed.
        * platform/chromium/test_expectations.txt:
2011-04-06  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r83045.
        http://trac.webkit.org/changeset/83045
        https://bugs.webkit.org/show_bug.cgi?id=57953

        Broke win layout tests (Requested by podivilov on #webkit).

        * GNUmakefile.am:
        * inspector/front-end/DebuggerPresentationModel.js:
        (WebInspector.DebuggerPresentationModel.prototype._addScript):
        (WebInspector.DebuggerPresentationModel.prototype.toggleFormatSourceFiles):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83053 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

rniwa@webkit.org [Wed, 6 Apr 2011 15:19:56 +0000 (15:19 +0000)]

2011-04-06  Ryosuke Niwa  <rniwa@webkit.org>

        Moved the declaration of positionNewFloatOnLine in RenderBlock.h after r83042.

        * rendering/RenderBlock.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

diegohcg@webkit.org [Wed, 6 Apr 2011 15:16:26 +0000 (15:16 +0000)]

2011-03-27  Diego Gonzalez  <diegohcg@webkit.org>

    [Qt] Re-draw the <input> fields for Qt Mobile Theme to do not override elements already styled.
    https://bugs.webkit.org/show_bug.cgi?id=57007

    Reviewed by Kenneth Rohde Christiansen.

    * CodeGenerators.pri:
    * css/themeQtMobile.css: Removed.
    * platform/qt/QtMobileWebStyle.cpp:
    (drawRectangularControlBackground):
    (QtMobileWebStyle::drawPrimitive):
    (QtMobileWebStyle::drawComplexControl):
    * platform/qt/QtMobileWebStyle.h:
    * platform/qt/RenderThemeQt.cpp:
    (WebCore::RenderThemeQt::isControlStyled):
    (WebCore::RenderThemeQt::paintTextField):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83051 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

jberlin@webkit.org [Wed, 6 Apr 2011 15:15:36 +0000 (15:15 +0000)]

WebKit2: Implement TextChecker on Windows
https://bugs.webkit.org/show_bug.cgi?id=57862

Reviewed by Anders Carlsson.

Part 1: Get and set the state.

* Shared/API/c/win/WKBaseWin.h:
* Shared/APIObject.h:
* UIProcess/API/C/win/WKAPICastWin.h:

* UIProcess/API/C/win/WKTextChecker.cpp: Added.
(WKTextCheckerSetClient):
(WKTextCheckerContinuousSpellCheckingEnabledStateChanged):
(WKTextCheckerGrammarCheckingEnabledStateChanged):
* UIProcess/API/C/win/WKTextChecker.h: Added.

* UIProcess/TextChecker.h:
* UIProcess/win/TextCheckerWin.cpp:
(WebKit::TextChecker::state):
Do the initalization for the state only once so that it is not necessary to call the client
every time the state is requested.
(WebKit::TextChecker::isContinuousSpellCheckingAllowed):
Call the client.
(WebKit::TextChecker::setContinuousSpellCheckingEnabled):
Update the state and tell the client.
(WebKit::TextChecker::setGrammarCheckingEnabled):
Ditto.
(WebKit::TextChecker::continuousSpellCheckingEnabledStateChanged):
Update the state.
(WebKit::TextChecker::grammarCheckingEnabledStateChanged):
Update the state.

* UIProcess/win/WebTextChecker.cpp: Added.
(WebKit::WebTextChecker::shared):
Make the WebTextChecker available globally.
(WebKit::WebTextChecker::WebTextChecker):
(WebKit::WebTextChecker::setClient):
(WebKit::updateStateForAllWebProcesses):
(WebKit::WebTextChecker::continuousSpellCheckingEnabledStateChanged):
Tell the TextChecker that the state has changed, and then tell the
WebProcessProxies to send the new state to the WebProcesses.
(WebKit::WebTextChecker::grammarCheckingEnabledStateChanged):
Ditto.
* UIProcess/win/WebTextChecker.h: Added.
(WebKit::WebTextChecker::client):
(WebKit::WebTextChecker::type):

* UIProcess/win/WebTextCheckerClient.cpp: Added.
(WebKit::WebTextCheckerClient::continuousSpellCheckingAllowed):
(WebKit::WebTextCheckerClient::continuousSpellCheckingEnabled):
(WebKit::WebTextCheckerClient::setContinuousSpellCheckingEnabled):
(WebKit::WebTextCheckerClient::grammarCheckingEnabled):
(WebKit::WebTextCheckerClient::setGrammarCheckingEnabled):
* UIProcess/win/WebTextCheckerClient.h: Added.

* win/WebKit2.vcproj:
Add WKTextChecker.h/.cpp, WebTextChecker.h/.cpp, and WebTextCheckerClient.h/.cpp.
* win/WebKit2Generated.make:
Copy over WKTextChecker.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83050 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

commit-queue@webkit.org [Wed, 6 Apr 2011 14:57:21 +0000 (14:57 +0000)]

2011-04-06  Jia Pu  <jpu@apple.com>

        Reviewed by Darin Adler.

        [Mac] When autocorrection occurs without showing correction panel, WebCore need to post accessibility notification.
        https://bugs.webkit.org/show_bug.cgi?id=57800
        <rdar://problem/9218223>

        Defined a new accessibility notification type, AXAutocorrectionOccured. Editor::markAllMisspellingsAndBadGrammarInRanges()
        now posts said notification when any autocorrection or text replacement (e.g. replacing "(c)" with copyright mark) takes place.

        * accessibility/AXObjectCache.h:
        * accessibility/chromium/AXObjectCacheChromium.cpp:
        (WebCore::AXObjectCache::postPlatformNotification):
        * accessibility/mac/AXObjectCacheMac.mm:
        (WebCore::AXObjectCache::postPlatformNotification):
        * editing/Editor.cpp:
        (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83049 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

mrobinson@webkit.org [Wed, 6 Apr 2011 14:42:43 +0000 (14:42 +0000)]

2011-04-06  Martin Robinson  <mrobinson@igalia.com>

        Build fix for debug Cairo builds.

        * platform/graphics/cairo/PlatformContextCairo.cpp:
        (WebCore::PlatformContextCairo::pushImageMask): Update the reference to m_maskInformation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

diegohcg@webkit.org [Wed, 6 Apr 2011 14:38:58 +0000 (14:38 +0000)]

2011-04-06  Diego Gonzalez  <diegohcg@webkit.org>

    [Qt] Style fix for QtMobileWebStyle.h
    https://bugs.webkit.org/show_bug.cgi?id=57708

    Reviewed by Antonio Gomes.

    * platform/qt/QtMobileWebStyle.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

abecsi@webkit.org [Wed, 6 Apr 2011 14:35:56 +0000 (14:35 +0000)]

2011-04-06  Andras Becsi  <abecsi@webkit.org>

        Reviewed by Darin Adler.

        Invalid color #{predefined colorName} is accepted by the CSS parser.
        https://bugs.webkit.org/show_bug.cgi?id=15360

        * editing/execCommand/16049.html: Correct testcase which relies on parsing an invalid color value as valid.
        * fast/css/invalid-predefined-color-expected.txt: Added.
        * fast/css/invalid-predefined-color.html: Added.
        * fast/css/script-tests/invalid-predefined-color.js: Added.
2011-04-06  Andras Becsi  <abecsi@webkit.org>

        Reviewed by Darin Adler.

        Invalid color #{predefined colorName} is accepted by the CSS parser.
        https://bugs.webkit.org/show_bug.cgi?id=15360

        Test: fast/css/invalid-predefined-color.html

        * css/CSSGrammar.y: Remove superfluous hexcolor production.
        * css/tokenizer.flex: A hexadecimal number should consist of [a-fA-F0-9] values ({h}).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

podivilov@chromium.org [Wed, 6 Apr 2011 14:29:02 +0000 (14:29 +0000)]

2011-03-30  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: add test for script formatter worker.
        https://bugs.webkit.org/show_bug.cgi?id=57447

        * inspector/debugger/script-formatter-expected.txt: Added.
        * inspector/debugger/script-formatter.html: Added.
        * platform/chromium/test_expectations.txt:
2011-03-30  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: add test for script formatter worker.
        https://bugs.webkit.org/show_bug.cgi?id=57447

        Test: inspector/debugger/script-formatter.html

        * GNUmakefile.am:
        * inspector/front-end/DebuggerPresentationModel.js:
        (WebInspector.DebuggerPresentationModel):
        (WebInspector.DebuggerPresentationModel.prototype.toggleFormatSourceFiles):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

mrobinson@webkit.org [Wed, 6 Apr 2011 14:16:03 +0000 (14:16 +0000)]

2011-04-06  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [Cairo] Hide the details of image masking in PlatformContextCairo
        https://bugs.webkit.org/show_bug.cgi?id=57878

        No new tests. This is just a refactor.

        * platform/graphics/GraphicsContext.h:
        * platform/graphics/cairo/GraphicsContextCairo.cpp:
        (WebCore::GraphicsContext::savePlatformState): Call into PlatformContextCairo now to
        do the actual cairo_save. Remove information about image masking.
        (WebCore::GraphicsContext::restorePlatformState): Call into PlatformContextCairo now to
        do the actual cairo_restore. Remove information about image masking.
        * platform/graphics/cairo/GraphicsContextPlatformPrivateCairo.h:
        * platform/graphics/cairo/ImageBufferCairo.cpp:
        (WebCore::ImageBuffer::clip): Use PlatformContextCairo here now.
        * platform/graphics/cairo/PlatformContextCairo.cpp:
        (WebCore::PlatformContextCairo::restore): Added.
        (WebCore::PlatformContextCairo::save): Added.
        (WebCore::PlatformContextCairo::pushImageMask): Added.
        * platform/graphics/cairo/PlatformContextCairo.h:
        (WebCore::ImageMaskInformation::update): Moved from GraphicsContextPlatformPrivateCairo.h.
        (WebCore::ImageMaskInformation::isValid): Ditto.
        (WebCore::ImageMaskInformation::maskSurface): Ditto.
        (WebCore::ImageMaskInformation::maskRect): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

diegohcg@webkit.org [Wed, 6 Apr 2011 14:12:55 +0000 (14:12 +0000)]

2011-04-02  Diego Gonzalez  <diegohcg@webkit.org>

    [Qt] Radio buttons are showing wrong with mobile theme
    https://bugs.webkit.org/show_bug.cgi?id=57706

    Reviewed by Csaba Osztrogonác.

    * platform/qt/QtMobileWebStyle.cpp:
    (QtMobileWebStyle::drawRadio):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83043 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

rniwa@webkit.org [Wed, 6 Apr 2011 14:10:02 +0000 (14:10 +0000)]

2011-04-06  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Eric Seidel.

        Move RenderBlock::positionNewFloatOnLine to RenderBlockLineLayout.cpp
        https://bugs.webkit.org/show_bug.cgi?id=57943

        * rendering/RenderBlock.cpp: Removed positionNewFloatOnLine.
        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::RenderBlock::positionNewFloatOnLine): Moved from RenderBlock.cpp

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

diegohcg@webkit.org [Wed, 6 Apr 2011 13:50:24 +0000 (13:50 +0000)]

2011-04-05 Diego Gonzalez <diegohcg@webkit.org>

    Buildfix after r82125.

    [Qt] QtWebKit will not compile with QT_ASCII_CAST_WARNINGS enabled
    https://bugs.webkit.org/show_bug.cgi?id=57087

    * platform/qt/QtMobileWebStyle.cpp:
    (QtMobileWebStyle::findChecker):
    (QtMobileWebStyle::findRadio):
    (QtMobileWebStyle::findComboButton):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

podivilov@chromium.org [Wed, 6 Apr 2011 13:18:29 +0000 (13:18 +0000)]

2011-04-06  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: inline script imports in ScriptFormatterWorker.js so it works in Safari release.
        https://bugs.webkit.org/show_bug.cgi?id=57641

        * WebCore.xcodeproj/project.pbxproj:
        * gyp/streamline-inspector-source.sh:
        * inspector/combine-javascript-resources.pl: Renamed from Source/WebCore/combine-javascript-resources.
        * inspector/inline-javascript-imports.py: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

rniwa@webkit.org [Wed, 6 Apr 2011 12:59:24 +0000 (12:59 +0000)]

2011-04-06  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Eric Seidel.

        REGRESSION (r46914, r48764): When typing in Mail, line wrapping frequently occurs in the middle of words
        https://bugs.webkit.org/show_bug.cgi?id=57872

        r46914 initially introduced a regression by replacing calls to styleAtPosition by editingStyleAtPosition
        because editingStyleAtPosition did not avoid tab span to obtain the computed style unlike styleAtPosition.

        r46914 also introduced a regression by cloning hierarchy under new block at the insertion position without
        avoiding the tab span.

        Fixed the both regressions by avoiding tab spans when computing the editing style and when cloning hierarchy.

        Test: editing/inserting/insert-paragraph-separator-tab-span.html

        * editing/EditingStyle.cpp:
        (WebCore::EditingStyle::init): Always avoid a tab span when computing the editing style.
        * editing/InsertParagraphSeparatorCommand.cpp:
        (WebCore::InsertParagraphSeparatorCommand::doApply): Avoid cloning tab spans and inserting a paragraph
        separator into a paragraph separator.
2011-04-06  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Eric Seidel.

        REGRESSION (r46914, r48764): When typing in Mail, line wrapping frequently occurs in the middle of words
        https://bugs.webkit.org/show_bug.cgi?id=57872

        Added a test insert a paragraph separator and text around tab spans. WebKit should not apply the tab span's
        style to the paragraph separator or the text.

        * editing/inserting/insert-paragraph-separator-tab-span-expected.txt: Added.
        * editing/inserting/insert-paragraph-separator-tab-span.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

leviw@chromium.org [Wed, 6 Apr 2011 12:12:58 +0000 (12:12 +0000)]

2011-04-06  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Ryosuke Niwa.

        Add member functions for determining line/paragraph separation to InlineIterator
        https://bugs.webkit.org/show_bug.cgi?id=57938

        Adding atTextParagraphSeparator and atParagraphSeparator inline convenience functions to
        InlineIterator, where it makes far more sense for them to be. Also moving
        shouldPreserveNewline to RenderObject and renaming it preservesNewline.

        No new tests as this provides no new functionality.

        * rendering/InlineIterator.h:
        (WebCore::InlineIterator::atTextParagraphSeparator):
        (WebCore::InlineIterator::atParagraphSeparator):
        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::RenderBlock::requiresLineBox):
        (WebCore::RenderBlock::findNextLineBreak):
        * rendering/RenderObject.h:
        (WebCore::RenderObject::preservesNewline):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

apavlov@chromium.org [Wed, 6 Apr 2011 09:57:54 +0000 (09:57 +0000)]

2011-04-05  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Range insertNode function does not update content in the inspector
        https://bugs.webkit.org/show_bug.cgi?id=57829

        * inspector/elements/modify-chardata-expected.txt:
        * inspector/elements/modify-chardata.html:
2011-04-05  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Range insertNode function does not update content in the inspector
        https://bugs.webkit.org/show_bug.cgi?id=57829

        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::pushChildNodesToFrontend):
        (WebCore::InspectorDOMAgent::buildArrayForContainerChildren):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

commit-queue@webkit.org [Wed, 6 Apr 2011 09:37:32 +0000 (09:37 +0000)]

2011-04-06  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Improve tests for QWebFrame::url() and related methods
        https://bugs.webkit.org/show_bug.cgi?id=57865

        * tests/qwebframe/tst_qwebframe.cpp:
        (FakeReply::FakeReply): make more URLs reply HostNotFound. We needed two different URLs in the test.
        (tst_QWebFrame::requestedUrlAfterSetAndLoadFailures): check the properties after an setUrl()
        that fails and a load() that fails (for a different URL).

        (tst_QWebFrame::setUrlWithFragment_data):
        (tst_QWebFrame::setUrlWithFragment): add other test cases similar to the original, but changing
        the URL in the frame before the test starts.

        (tst_QWebFrame::setUrlSameUrl): document existing behavior of calling setUrl() twice with
        the same URL as argument.

        (extractBaseUrl):
        (tst_QWebFrame::setUrlThenLoads_data):
        (tst_QWebFrame::setUrlThenLoads): check the URL related properties of the frame after a
        sequence of set and loads. Those tests are interesting because the properties
        react different to setUrl() and load(): 'requestedUrl' always change, 'url' only when setUrl()
        is used or after the load() is committed and baseUrl() is similar to url() but also depends
        on the contents of the page when it loads.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83036 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

commit-queue@webkit.org [Wed, 6 Apr 2011 09:24:20 +0000 (09:24 +0000)]

2011-04-06  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        getComputedTextLength always returns 0 with tspan elements
        https://bugs.webkit.org/show_bug.cgi?id=19814

        Add a testcase showing that getComputedTextLength for <tspan> works fine.

        * svg/text/tspan-getComputedTextLength-expected.txt: Added.
        * svg/text/tspan-getComputedTextLength.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

alex@webkit.org [Wed, 6 Apr 2011 09:03:39 +0000 (09:03 +0000)]

2011-04-06  Alejandro G. Castro  <alex@igalia.com>

        Fix GTK3 compilation after r82962.

        * platform/gtk/RenderThemeGtk3.cpp:
        (WebCore::paintToggle):
        (WebCore::renderButton):
        (WebCore::RenderThemeGtk::paintMenuList):
        (WebCore::RenderThemeGtk::paintTextField):
        (WebCore::RenderThemeGtk::paintSliderTrack):
        (WebCore::RenderThemeGtk::paintSliderThumb):
        (WebCore::RenderThemeGtk::paintProgressBar):
        (WebCore::paintSpinArrowButton):
        * platform/gtk/ScrollbarThemeGtk3.cpp:
        (WebCore::ScrollbarThemeGtk::paintTrackBackground):
        (WebCore::ScrollbarThemeGtk::paintScrollbarBackground):
        (WebCore::ScrollbarThemeGtk::paintThumb):
        (WebCore::ScrollbarThemeGtk::paintButton):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

caseq@chromium.org [Wed, 6 Apr 2011 08:24:28 +0000 (08:24 +0000)]

2011-04-06  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: [Extensions API] remove inspectedPage.* events
        https://bugs.webkit.org/show_bug.cgi?id=57763

        - Removed webInspector.inspectedPage.* events
        - moved onNavigated to webInspector.resources

        * inspector/front-end/ExtensionAPI.js:
        (WebInspector.injectedExtensionAPI):
        (WebInspector.injectedExtensionAPI.InspectedWindow):
        * inspector/front-end/ExtensionAPISchema.json:
        * inspector/front-end/ExtensionServer.js:
        (WebInspector.ExtensionServer.prototype.notifyInspectedURLChanged):
        * inspector/front-end/inspector.js:
        (WebInspector.domContentEventFired):
        (WebInspector.loadEventFired):
        (WebInspector.inspectedURLChanged):

2011-04-06  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: [Extensions API] remove inspectedPage.* events
        https://bugs.webkit.org/show_bug.cgi?id=57763

        - Removed webInspector.inspectedPage.* events
        - moved onNavigated to webInspector.resources

        * http/tests/inspector/extensions-test.js:
        (initialize_ExtensionsTest.runWhenPageLoads):
        * http/tests/inspector/inspector-test.js:
        (initialize_InspectorTest.InspectorTest.runWhenPageLoads.chainedCallback):
        (initialize_InspectorTest.InspectorTest.runWhenPageLoads):
        * inspector/extensions/extensions-api-expected.txt:
        * inspector/extensions/extensions-events-expected.txt:
        * inspector/extensions/extensions-events.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

joepeck@webkit.org [Wed, 6 Apr 2011 08:10:05 +0000 (08:10 +0000)]

2011-04-06  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Antti Koivisto.

        Add <head> to the simpleUserAgentStyleSheet
        https://bugs.webkit.org/show_bug.cgi?id=57915

        * css/CSSStyleSelector.cpp:
        (WebCore::elementCanUseSimpleDefaultStyle): add head to the
        simple stylesheet, display:none.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83032 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

mnaganov@chromium.org [Wed, 6 Apr 2011 08:03:27 +0000 (08:03 +0000)]

2011-04-05  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [Chromium] Add layout test for Summary view of detailed heap snapshots.
        https://bugs.webkit.org/show_bug.cgi?id=57856

        Test: inspector/profiler/detailed-heapshots-summary.html

        * inspector/front-end/DataGrid.js:
        (WebInspector.DataGrid):
        * inspector/front-end/DetailedHeapshotGridNodes.js:
        (WebInspector.HeapSnapshotGridNode.prototype._populate.doPopulate):
        (WebInspector.HeapSnapshotGridNode.prototype._populate):
        (WebInspector.HeapSnapshotGridNode.prototype.populateChildren):
        (WebInspector.HeapSnapshotGridNode.prototype.sort.doSort):
        (WebInspector.HeapSnapshotGridNode.prototype.sort):
        (WebInspector.HeapSnapshotDiffNode.prototype.populateChildren):
        * inspector/front-end/DetailedHeapshotView.js:
        (WebInspector.HeapSnapshotSortableDataGrid.prototype.sortingChanged):
        * inspector/front-end/ProfilesPanel.js:
        (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot.doParse):
        (WebInspector.ProfilesPanel.prototype._finishHeapSnapshot):

2011-04-05  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [Chromium] Add layout test for Summary view of detailed heap snapshots.
        https://bugs.webkit.org/show_bug.cgi?id=57856

        * http/tests/inspector/inspector-test.js:
        (initialize_InspectorTest.):
        (initialize_InspectorTest):
        * inspector/profiler/detailed-heapshots-summary-expected.txt: Added.
        * inspector/profiler/detailed-heapshots-summary.html: Added.
        * inspector/profiler/detailed-heapshots-test.js: Added.
        * platform/chromium/inspector/profiler/detailed-heapshots-summary-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83031 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

ojan@chromium.org [Wed, 6 Apr 2011 07:50:47 +0000 (07:50 +0000)]

2011-04-06  Ojan Vafai  <ojan@chromium.org>

        http://trac.webkit.org/changeset/83024 incorrectly removed the mac-leopard results.
        Instead, it should have moved the results from chromium-mac to chromium-mac-leopard.

        * platform/chromium-mac-leopard/fast/box-shadow/spread-multiple-inset-expected.png: Added.
        * platform/chromium-mac-leopard/fast/html/details-add-summary-1-and-click-expected.png: Added.
        * platform/chromium-mac-leopard/fast/html/details-add-summary-1-expected.png: Added.
        * platform/chromium-mac-leopard/fast/html/details-add-summary-10-and-click-expected.png: Added.
        * platform/chromium-mac-leopard/fast/html/details-add-summary-10-expected.png: Added.
        * platform/chromium-mac-leopard/fast/html/details-add-summary-2-and-click-expected.png: Added.
        * platform/chromium-mac-leopard/fast/html/details-add-summary-2-expected.png: Added.
        * platform/chromium-mac-leopard/fast/html/details-add-summary-3-and-click-expected.png: Added.
        * platform/chromium-mac-leopard/fast/html/details-add-summary-3-expected.png: Added.
        * platform/chromium-mac-leopard/fast/html/details-add-summary-4-and-click-expected.png: Added.
        * platform/chromium-mac-leopard/fast/html/details-add-summary-4-expected.png: Added.
        * platform/chromium-mac-leopard/fast/html/details-add-summary-5-and-click-expected.png: Added.
        * platform/chromium-mac-leopard/fast/html/details-add-summary-5-expected.png: Added.
        * platform/chromium-mac-leopard/fast/html/details-add-summary-6-and-click-expected.png: Added.
        * platform/chromium-mac-leopard/fast/html/details-add-summary-6-expected.png: Added.
        * platform/chromium-mac-leopard/fast/html/details-add-summary-7-and-click-expected.png: Added.
        * platform/chromium-mac-leopard/fast/html/details-add-summary-7-expected.png: Added.
        * platform/chromium-mac-leopard/fast/html/details-add-summary-8-and-click-expected.png: Added.
        * platform/chromium-mac-leopard/fast/html/details-add-summary-8-expected.png: Added.
        * platform/chromium-mac-leopard/fast/html/details-add-summary-9-and-click-expected.png: Added.
        * platform/chromium-mac-leopard/fast/html/details-add-summary-9-expected.png: Added.
        * platform/chromium-mac-leopard/fast/html/details-no-summary1-expected.png: Added.
        * platform/chromium-mac-leopard/fast/html/details-no-summary2-expected.png: Added.
        * platform/chromium-mac-leopard/fast/html/details-no-summary3-expected.png: Added.
        * platform/chromium-mac-leopard/fast/html/details-no-summary4-expected.png: Added.
        * platform/chromium-mac-leopard/fast/html/details-open-javascript-expected.png: Added.
        * platform/chromium-mac-leopard/fast/html/details-open1-expected.png: Added.
        * platform/chromium-mac-leopard/fast/html/details-open2-expected.png: Added.
        * platform/chromium-mac-leopard/fast/html/details-open3-expected.png: Added.
        * platform/chromium-mac-leopard/fast/html/details-open4-expected.png: Added.
        * platform/chromium-mac-leopard/fast/html/details-open5-expected.png: Added.
        * platform/chromium-mac-leopard/fast/html/details-open6-expected.png: Added.
        * platform/chromium-mac-leopard/fast/html/details-position-expected.png: Added.
        * platform/chromium-mac-leopard/fast/html/details-remove-summary-1-and-click-expected.png: Added.
        * platform/chromium-mac-leopard/fast/html/details-remove-summary-1-expected.png: Added.
        * platform/chromium-mac-leopard/fast/html/details-remove-summary-2-and-click-expected.png: Added.
        * platform/chromium-mac-leopard/fast/html/details-remove-summary-2-expected.png: Added.
        * platform/chromium-mac-leopard/fast/html/details-remove-summary-3-and-click-expected.png: Added.
        * platform/chromium-mac-leopard/fast/html/details-remove-summary-3-expected.png: Added.
        * platform/chromium-mac-leopard/fast/html/details-remove-summary-4-and-click-expected.png: Added.
        * platform/chromium-mac-leopard/fast/html/details-remove-summary-4-expected.png: Added.
        * platform/chromium-mac-leopard/fast/html/details-remove-summary-5-and-click-expected.png: Added.
        * platform/chromium-mac-leopard/fast/html/details-remove-summary-5-expected.png: Added.
        * platform/chromium-mac-leopard/fast/html/details-remove-summary-6-and-click-expected.png: Added.
        * platform/chromium-mac-leopard/fast/html/details-remove-summary-6-expected.png: Added.
        * platform/chromium-mac-leopard/fast/html/details-writing-mode-expected.png: Added.
        * platform/chromium-mac-leopard/fast/inline-block/inline-block-vertical-align-expected.png: Added.
        * platform/chromium-mac-leopard/fast/multicol/layers-in-multicol-expected.png: Added.
        * platform/chromium-mac-leopard/fast/ruby/ruby-beforeafter-expected.png: Added.
        * platform/chromium-mac-leopard/fast/ruby/ruby-length-expected.png: Added.
        * platform/chromium-mac-leopard/fast/ruby/ruby-run-break-expected.png: Added.
        * platform/chromium-mac-leopard/fast/ruby/ruby-runs-expected.png: Added.
        * platform/chromium-mac-leopard/fast/ruby/ruby-runs-spans-expected.png: Added.
        * platform/chromium-mac-leopard/fast/ruby/ruby-trailing-expected.png: Added.
        * platform/chromium-mac-leopard/fast/ruby/rubyDOM-insert-rt-expected.png: Added.
        * platform/chromium-mac-leopard/fast/ruby/rubyDOM-insert-text1-expected.png: Added.
        * platform/chromium-mac-leopard/fast/ruby/rubyDOM-insert-text2-expected.png: Added.
        * platform/chromium-mac-leopard/fast/ruby/rubyDOM-insert-text3-expected.png: Added.
        * platform/chromium-mac-leopard/fast/ruby/rubyDOM-remove-rt1-expected.png: Added.
        * platform/chromium-mac-leopard/fast/ruby/rubyDOM-remove-rt2-expected.png: Added.
        * platform/chromium-mac-leopard/fast/ruby/rubyDOM-remove-text1-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

commit-queue@webkit.org [Wed, 6 Apr 2011 07:46:22 +0000 (07:46 +0000)]

2011-04-06  Anders Bakken  <agbakken@gmail.com>

        Reviewed by David Levin.

        [Qt] SmartReplaceQt.cpp has coding-style errors
        https://bugs.webkit.org/show_bug.cgi?id=40261

        This patch does not require new test cases.

        * editing/qt/SmartReplaceQt.cpp:
        (WebCore::isCharacterSmartReplaceExempt):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83029 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

zimmermann@webkit.org [Wed, 6 Apr 2011 07:40:50 +0000 (07:40 +0000)]

2011-04-06  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed.

        Add missing pixel test result.

        * platform/mac/svg/custom/use-in-symbol-with-offset-expected.checksum: Added.
        * platform/mac/svg/custom/use-in-symbol-with-offset-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83028 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

koz@chromium.org [Wed, 6 Apr 2011 07:38:43 +0000 (07:38 +0000)]

2011-04-06  James Kozianski  <koz@chromium.org>

        [chromium] Add expectations for failing GPU tests.
        https://bugs.webkit.org/show_bug.cgi?id=57926

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83027 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

commit-queue@webkit.org [Wed, 6 Apr 2011 07:22:26 +0000 (07:22 +0000)]

2011-04-06  Naoki Takano  <takano.naoki@gmail.com>

        Reviewed by Ryosuke Niwa.

        REGRESSION(r81328): Null pointer crash in canAppendNewLineFeed when selection isn't inside an editable element
        https://bugs.webkit.org/show_bug.cgi?id=57755

        * editing/execCommand/insert-line-break-onload-expected.txt: Added.
        * editing/execCommand/insert-line-break-onload.html: Added to check calling InsertLineBreak without any crash.
2011-04-06  Naoki Takano  <takano.naoki@gmail.com>

        Reviewed by Ryosuke Niwa.

        REGRESSION(r81328): Null pointer crash in canAppendNewLineFeed when selection isn't inside an editable element
        https://bugs.webkit.org/show_bug.cgi?id=57755

        Test: editing/execCommand/insert-line-break-onload.html

        * editing/TypingCommand.cpp:
        (WebCore::canAppendNewLineFeed): Added null pointer check for rootEditableElement().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

koz@chromium.org [Wed, 6 Apr 2011 06:50:42 +0000 (06:50 +0000)]

2011-04-05  James Kozianski  <koz@chromium.org>

        [chromium] Rebaseline images after r82969

        Rebaseline for missed linux test in r83019.

        * platform/chromium-linux/fast/css/text-input-with-webkit-border-radius-expected.checksum: Removed.
        * platform/chromium-linux/fast/css/text-input-with-webkit-border-radius-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83025 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

ojan@chromium.org [Wed, 6 Apr 2011 06:39:13 +0000 (06:39 +0000)]

2011-04-05  Shane Stephens  <shanestephens@google.com>

        Reviewed by Ojan Vafai.

        [Chromium] Greening the Mac 10.5 and 10.6 trees.
        https://bugs.webkit.org/show_bug.cgi?id=57924

        Rebaselines a bunch of tests with differences due to text anti-aliasing.
        (Prepared using rebaseline script)

        * platform/chromium-mac/fast/box-shadow/spread-multiple-inset-expected.checksum: Removed.
        * platform/chromium-mac/fast/box-shadow/spread-multiple-inset-expected.png: Removed.
        * platform/chromium-mac/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png: Added.
        * platform/chromium-mac/fast/html/details-add-summary-1-and-click-expected.png: Removed.
        * platform/chromium-mac/fast/html/details-add-summary-1-expected.png: Removed.
        * platform/chromium-mac/fast/html/details-add-summary-10-and-click-expected.png: Removed.
        * platform/chromium-mac/fast/html/details-add-summary-10-expected.png: Removed.
        * platform/chromium-mac/fast/html/details-add-summary-2-and-click-expected.png: Removed.
        * platform/chromium-mac/fast/html/details-add-summary-2-expected.png: Removed.
        * platform/chromium-mac/fast/html/details-add-summary-3-and-click-expected.png: Removed.
        * platform/chromium-mac/fast/html/details-add-summary-3-expected.png: Removed.
        * platform/chromium-mac/fast/html/details-add-summary-4-and-click-expected.png: Removed.
        * platform/chromium-mac/fast/html/details-add-summary-4-expected.png: Removed.
        * platform/chromium-mac/fast/html/details-add-summary-5-and-click-expected.png: Removed.
        * platform/chromium-mac/fast/html/details-add-summary-5-expected.png: Removed.
        * platform/chromium-mac/fast/html/details-add-summary-6-and-click-expected.png: Removed.
        * platform/chromium-mac/fast/html/details-add-summary-6-expected.png: Removed.
        * platform/chromium-mac/fast/html/details-add-summary-7-and-click-expected.png: Removed.
        * platform/chromium-mac/fast/html/details-add-summary-7-expected.png: Removed.
        * platform/chromium-mac/fast/html/details-add-summary-8-and-click-expected.png: Removed.
        * platform/chromium-mac/fast/html/details-add-summary-8-expected.png: Removed.
        * platform/chromium-mac/fast/html/details-add-summary-9-and-click-expected.png: Removed.
        * platform/chromium-mac/fast/html/details-add-summary-9-expected.png: Removed.
        * platform/chromium-mac/fast/html/details-no-summary1-expected.png: Removed.
        * platform/chromium-mac/fast/html/details-no-summary2-expected.png: Removed.
        * platform/chromium-mac/fast/html/details-no-summary3-expected.png: Removed.
        * platform/chromium-mac/fast/html/details-no-summary4-expected.png: Removed.
        * platform/chromium-mac/fast/html/details-open-javascript-expected.png: Removed.
        * platform/chromium-mac/fast/html/details-open1-expected.png: Removed.
        * platform/chromium-mac/fast/html/details-open2-expected.png: Removed.
        * platform/chromium-mac/fast/html/details-open3-expected.png: Removed.
        * platform/chromium-mac/fast/html/details-open4-expected.png: Removed.
        * platform/chromium-mac/fast/html/details-open5-expected.png: Removed.
        * platform/chromium-mac/fast/html/details-open6-expected.png: Removed.
        * platform/chromium-mac/fast/html/details-position-expected.png: Removed.
        * platform/chromium-mac/fast/html/details-remove-summary-1-and-click-expected.png: Removed.
        * platform/chromium-mac/fast/html/details-remove-summary-1-expected.png: Removed.
        * platform/chromium-mac/fast/html/details-remove-summary-2-and-click-expected.png: Removed.
        * platform/chromium-mac/fast/html/details-remove-summary-2-expected.png: Removed.
        * platform/chromium-mac/fast/html/details-remove-summary-3-and-click-expected.png: Removed.
        * platform/chromium-mac/fast/html/details-remove-summary-3-expected.png: Removed.
        * platform/chromium-mac/fast/html/details-remove-summary-4-and-click-expected.png: Removed.
        * platform/chromium-mac/fast/html/details-remove-summary-4-expected.png: Removed.
        * platform/chromium-mac/fast/html/details-remove-summary-5-and-click-expected.png: Removed.
        * platform/chromium-mac/fast/html/details-remove-summary-5-expected.png: Removed.
        * platform/chromium-mac/fast/html/details-remove-summary-6-and-click-expected.png: Removed.
        * platform/chromium-mac/fast/html/details-remove-summary-6-expected.png: Removed.
        * platform/chromium-mac/fast/html/details-writing-mode-expected.png: Removed.
        * platform/chromium-mac/fast/inline-block/inline-block-vertical-align-expected.checksum: Removed.
        * platform/chromium-mac/fast/inline-block/inline-block-vertical-align-expected.png: Removed.
        * platform/chromium-mac/fast/multicol/layers-in-multicol-expected.checksum: Removed.
        * platform/chromium-mac/fast/multicol/layers-in-multicol-expected.png: Removed.
        * platform/chromium-mac/fast/multicol/nested-columns-expected.checksum: Removed.
        * platform/chromium-mac/fast/multicol/nested-columns-expected.png:
        * platform/chromium-mac/fast/repaint/list-marker-expected.checksum: Removed.
        * platform/chromium-mac/fast/repaint/list-marker-expected.png:
        * platform/chromium-mac/fast/ruby/ruby-beforeafter-expected.png: Removed.
        * platform/chromium-mac/fast/ruby/ruby-length-expected.png: Removed.
        * platform/chromium-mac/fast/ruby/ruby-run-break-expected.png: Removed.
        * platform/chromium-mac/fast/ruby/ruby-runs-expected.png: Removed.
        * platform/chromium-mac/fast/ruby/ruby-runs-spans-expected.png: Removed.
        * platform/chromium-mac/fast/ruby/ruby-trailing-expected.png: Removed.
        * platform/chromium-mac/fast/ruby/rubyDOM-insert-rt-expected.png: Removed.
        * platform/chromium-mac/fast/ruby/rubyDOM-insert-text1-expected.png: Removed.
        * platform/chromium-mac/fast/ruby/rubyDOM-insert-text2-expected.png: Removed.
        * platform/chromium-mac/fast/ruby/rubyDOM-insert-text3-expected.png: Removed.
        * platform/chromium-mac/fast/ruby/rubyDOM-remove-rt1-expected.png: Removed.
        * platform/chromium-mac/fast/ruby/rubyDOM-remove-rt2-expected.png: Removed.
        * platform/chromium-mac/fast/ruby/rubyDOM-remove-text1-expected.png: Removed.
        * platform/chromium/test_expectations.txt:
        * platform/mac/fast/css/background-clip-values-expected.checksum: Added.
        * platform/mac/fast/css/background-clip-values-expected.png: Added.
        * platform/mac/fast/css/bidi-override-in-anonymous-block-expected.checksum: Added.
        * platform/mac/fast/css/bidi-override-in-anonymous-block-expected.png: Added.
        * platform/mac/fast/gradients/gradient-after-transparent-border-expected.checksum: Added.
        * platform/mac/fast/gradients/gradient-after-transparent-border-expected.png: Added.
        * platform/mac/fast/images/gray-scale-jpeg-with-color-profile-expected.checksum: Added.
        * platform/mac/fast/images/gray-scale-jpeg-with-color-profile-expected.png: Added.
        * platform/mac/media/controls-without-preload-expected.checksum: Added.
        * platform/mac/media/controls-without-preload-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

commit-queue@webkit.org [Wed, 6 Apr 2011 06:29:53 +0000 (06:29 +0000)]

2011-04-05  Zelidrag Hornung  <zelidrag@chromium.org>

        Reviewed by David Levin.

        Added MediaTypeFile enum value to WebContextMenuData::MediaType.
        https://bugs.webkit.org/show_bug.cgi?id=57566

        * public/WebContextMenuData.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

antti@apple.com [Wed, 6 Apr 2011 06:27:23 +0000 (06:27 +0000)]

Avoid calling currentTime() from FrameView::adjustedDeferredRepaintDelay() when repaints are deferred
https://bugs.webkit.org/show_bug.cgi?id=57914

Reviewed by Cameron Zwarich.

Don't call adjustedDeferredRepaintDelay unnecessarily.

* page/FrameView.cpp:
(WebCore::FrameView::repaintContentRectangle):
(WebCore::FrameView::adjustedDeferredRepaintDelay):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83022 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

commit-queue@webkit.org [Wed, 6 Apr 2011 06:01:02 +0000 (06:01 +0000)]

2011-04-05  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r83007.
        http://trac.webkit.org/changeset/83007
        https://bugs.webkit.org/show_bug.cgi?id=57920

        Broke WebFrameTest.FrameForEnteredContext on Chromium-win and
        Chromium-mac (Requested by tkent on #webkit).

        * WebKit.gyp:
        * WebKit.gypi:
        * public/WebFrame.h:
        * src/WebFrameImpl.cpp:
        * tests/WebFrameTest.cpp:
        (WebKit::WebFrameTest::WebFrameTest):
        (WebKit::WebFrameTest::registerMockedURLLoad):
        (WebKit::WebFrameTest::serveRequests):
        (WebKit::TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83021 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

commit-queue@webkit.org [Wed, 6 Apr 2011 05:57:43 +0000 (05:57 +0000)]

2011-04-05  Steve VanDeBogart  <vandebo@chromium.org>

        Reviewed by David Levin.

        Update call to SkAdvancedTypefaceMetrics to new API.
        https://bugs.webkit.org/show_bug.cgi?id=57887

        * platform/graphics/chromium/FontPlatformDataLinux.cpp:
        (WebCore::FontPlatformData::emSizeInFontUnits):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83020 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

koz@chromium.org [Wed, 6 Apr 2011 05:57:21 +0000 (05:57 +0000)]

2011-04-05  James Kozianski  <koz@chromium.org>

        Rebaseline images after r82969
        https://bugs.webkit.org/show_bug.cgi?id=57917

        Rebaseline for r82969, which causes slight changes in rounded corner rendering.

        * platform/chromium-linux/fast/blockflow/border-radius-clipping-vertical-lr-expected.checksum: Removed.
        * platform/chromium-linux/fast/blockflow/border-radius-clipping-vertical-lr-expected.png:
        * platform/chromium-linux/fast/blockflow/box-shadow-horizontal-bt-expected.checksum: Removed.
        * platform/chromium-linux/fast/blockflow/box-shadow-horizontal-bt-expected.png:
        * platform/chromium-linux/fast/blockflow/box-shadow-vertical-lr-expected.checksum: Removed.
        * platform/chromium-linux/fast/blockflow/box-shadow-vertical-lr-expected.png:
        * platform/chromium-linux/fast/blockflow/box-shadow-vertical-rl-expected.checksum: Removed.
        * platform/chromium-linux/fast/blockflow/box-shadow-vertical-rl-expected.png:
        * platform/chromium-linux/fast/borders/border-radius-huge-assert-expected.checksum: Removed.
        * platform/chromium-linux/fast/borders/border-radius-huge-assert-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusAllStylesAllCorners-expected.checksum: Removed.
        * platform/chromium-linux/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusArcs01-expected.checksum: Removed.
        * platform/chromium-linux/fast/borders/borderRadiusArcs01-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusDashed01-expected.checksum: Removed.
        * platform/chromium-linux/fast/borders/borderRadiusDashed01-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusDashed02-expected.checksum: Removed.
        * platform/chromium-linux/fast/borders/borderRadiusDashed02-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusDashed03-expected.checksum: Removed.
        * platform/chromium-linux/fast/borders/borderRadiusDashed03-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusDotted01-expected.checksum: Removed.
        * platform/chromium-linux/fast/borders/borderRadiusDotted01-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusDotted02-expected.checksum: Removed.
        * platform/chromium-linux/fast/borders/borderRadiusDotted02-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusDotted03-expected.checksum: Removed.
        * platform/chromium-linux/fast/borders/borderRadiusDotted03-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusDouble01-expected.checksum: Removed.
        * platform/chromium-linux/fast/borders/borderRadiusDouble01-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusDouble02-expected.checksum: Removed.
        * platform/chromium-linux/fast/borders/borderRadiusDouble02-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusDouble03-expected.checksum: Removed.
        * platform/chromium-linux/fast/borders/borderRadiusDouble03-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusGroove01-expected.checksum: Removed.
        * platform/chromium-linux/fast/borders/borderRadiusGroove01-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusGroove02-expected.checksum: Removed.
        * platform/chromium-linux/fast/borders/borderRadiusGroove02-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusInset01-expected.checksum: Removed.
        * platform/chromium-linux/fast/borders/borderRadiusInset01-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusInvalidColor-expected.checksum: Removed.
        * platform/chromium-linux/fast/borders/borderRadiusInvalidColor-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusOutset01-expected.checksum: Removed.
        * platform/chromium-linux/fast/borders/borderRadiusOutset01-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusRidge01-expected.checksum: Removed.
        * platform/chromium-linux/fast/borders/borderRadiusRidge01-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusSolid01-expected.checksum: Removed.
        * platform/chromium-linux/fast/borders/borderRadiusSolid01-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusSolid02-expected.checksum: Removed.
        * platform/chromium-linux/fast/borders/borderRadiusSolid02-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusSolid03-expected.checksum: Removed.
        * platform/chromium-linux/fast/borders/borderRadiusSolid03-expected.png:
        * platform/chromium-linux/fast/box-shadow/border-radius-big-expected.checksum: Removed.
        * platform/chromium-linux/fast/box-shadow/border-radius-big-expected.png:
        * platform/chromium-linux/fast/box-shadow/inset-expected.checksum: Removed.
        * platform/chromium-linux/fast/box-shadow/inset-expected.png:
        * platform/chromium-linux/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.checksum: Removed.
        * platform/chromium-linux/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png:
        * platform/chromium-linux/fast/box-shadow/spread-expected.checksum: Removed.
        * platform/chromium-linux/fast/box-shadow/spread-expected.png:
        * platform/chromium-linux/fast/box-shadow/spread-multiple-inset-expected.checksum: Removed.
        * platform/chromium-linux/fast/box-shadow/spread-multiple-inset-expected.png:
        * platform/chromium-linux/fast/box-shadow/spread-multiple-normal-expected.checksum: Removed.
        * platform/chromium-linux/fast/box-shadow/spread-multiple-normal-expected.png:
        * platform/chromium-linux/fast/forms/basic-selects-expected.checksum: Removed.
        * platform/chromium-linux/fast/forms/basic-selects-expected.png:
        * platform/chromium-linux/fast/layers/video-layer-expected.checksum: Removed.
        * platform/chromium-linux/fast/layers/video-layer-expected.png:
        * platform/chromium-linux/fast/overflow/border-radius-clipping-expected.checksum: Removed.
        * platform/chromium-linux/fast/overflow/border-radius-clipping-expected.png:
        * platform/chromium-linux/fast/repaint/border-radius-repaint-expected.checksum: Removed.
        * platform/chromium-linux/fast/repaint/border-radius-repaint-expected.png:
        * platform/chromium-linux/fast/replaced/border-radius-clip-expected.checksum: Removed.
        * platform/chromium-linux/fast/replaced/border-radius-clip-expected.png:
        * platform/chromium-linux/fast/transforms/shadows-expected.checksum: Removed.
        * platform/chromium-linux/fast/transforms/shadows-expected.png:
        * platform/chromium-linux/media/audio-controls-rendering-expected.checksum: Removed.
        * platform/chromium-linux/media/audio-controls-rendering-expected.png:
        * platform/chromium-linux/media/controls-after-reload-expected.checksum: Removed.
        * platform/chromium-linux/media/controls-after-reload-expected.png:
        * platform/chromium-linux/media/controls-strict-expected.checksum: Removed.
        * platform/chromium-linux/media/controls-strict-expected.png:
        * platform/chromium-linux/media/controls-styling-expected.checksum: Removed.
        * platform/chromium-linux/media/controls-styling-expected.png:
        * platform/chromium-linux/media/controls-without-preload-expected.checksum: Removed.
        * platform/chromium-linux/media/controls-without-preload-expected.png:
        * platform/chromium-linux/media/media-document-audio-repaint-expected.checksum: Removed.
        * platform/chromium-linux/media/media-document-audio-repaint-expected.png:
        * platform/chromium-linux/media/video-controls-rendering-expected.checksum: Removed.
        * platform/chromium-linux/media/video-controls-rendering-expected.png:
        * platform/chromium-linux/media/video-display-toggle-expected.checksum: Removed.
        * platform/chromium-linux/media/video-display-toggle-expected.png:
        * platform/chromium-linux/media/video-empty-source-expected.checksum: Removed.
        * platform/chromium-linux/media/video-empty-source-expected.png:
        * platform/chromium-linux/media/video-no-audio-expected.checksum: Removed.
        * platform/chromium-linux/media/video-no-audio-expected.png:
        * platform/chromium-linux/media/video-volume-slider-expected.checksum: Removed.
        * platform/chromium-linux/media/video-volume-slider-expected.png:
        * platform/chromium-linux/media/video-zoom-controls-expected.checksum: Removed.
        * platform/chromium-linux/media/video-zoom-controls-expected.png:
        * platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.checksum: Removed.
        * platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.png:
        * platform/chromium-win-xp/media/controls-after-reload-expected.checksum: Removed.
        * platform/chromium-win-xp/media/controls-after-reload-expected.png: Removed.
        * platform/chromium-win-xp/media/controls-strict-expected.checksum: Removed.
        * platform/chromium-win-xp/media/controls-strict-expected.png: Removed.
        * platform/chromium-win-xp/media/controls-styling-expected.checksum: Removed.
        * platform/chromium-win-xp/media/controls-styling-expected.png: Removed.
        * platform/chromium-win-xp/media/controls-without-preload-expected.checksum: Removed.
        * platform/chromium-win-xp/media/controls-without-preload-expected.png: Removed.
        * platform/chromium-win-xp/media/video-controls-rendering-expected.checksum: Removed.
        * platform/chromium-win-xp/media/video-controls-rendering-expected.png: Removed.
        * platform/chromium-win-xp/media/video-zoom-controls-expected.checksum: Removed.
        * platform/chromium-win-xp/media/video-zoom-controls-expected.png: Removed.
        * platform/chromium-win/fast/blockflow/border-radius-clipping-vertical-lr-expected.checksum: Removed.
        * platform/chromium-win/fast/blockflow/border-radius-clipping-vertical-lr-expected.png:
        * platform/chromium-win/fast/blockflow/box-shadow-horizontal-bt-expected.checksum: Removed.
        * platform/chromium-win/fast/blockflow/box-shadow-horizontal-bt-expected.png:
        * platform/chromium-win/fast/blockflow/box-shadow-vertical-lr-expected.checksum: Removed.
        * platform/chromium-win/fast/blockflow/box-shadow-vertical-lr-expected.png:
        * platform/chromium-win/fast/blockflow/box-shadow-vertical-rl-expected.checksum: Removed.
        * platform/chromium-win/fast/blockflow/box-shadow-vertical-rl-expected.png:
        * platform/chromium-win/fast/borders/border-radius-huge-assert-expected.checksum: Removed.
        * platform/chromium-win/fast/borders/border-radius-huge-assert-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusAllStylesAllCorners-expected.checksum: Removed.
        * platform/chromium-win/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusArcs01-expected.checksum: Removed.
        * platform/chromium-win/fast/borders/borderRadiusArcs01-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusDashed01-expected.checksum: Removed.
        * platform/chromium-win/fast/borders/borderRadiusDashed01-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusDashed02-expected.checksum: Removed.
        * platform/chromium-win/fast/borders/borderRadiusDashed02-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusDashed03-expected.checksum: Removed.
        * platform/chromium-win/fast/borders/borderRadiusDashed03-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusDotted01-expected.checksum: Removed.
        * platform/chromium-win/fast/borders/borderRadiusDotted01-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusDotted02-expected.checksum: Removed.
        * platform/chromium-win/fast/borders/borderRadiusDotted02-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusDotted03-expected.checksum: Removed.
        * platform/chromium-win/fast/borders/borderRadiusDotted03-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusDouble01-expected.checksum: Removed.
        * platform/chromium-win/fast/borders/borderRadiusDouble01-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusDouble02-expected.checksum: Removed.
        * platform/chromium-win/fast/borders/borderRadiusDouble02-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusDouble03-expected.checksum: Removed.
        * platform/chromium-win/fast/borders/borderRadiusDouble03-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusGroove01-expected.checksum: Removed.
        * platform/chromium-win/fast/borders/borderRadiusGroove01-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusGroove02-expected.checksum: Removed.
        * platform/chromium-win/fast/borders/borderRadiusGroove02-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusInset01-expected.checksum: Removed.
        * platform/chromium-win/fast/borders/borderRadiusInset01-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusInvalidColor-expected.checksum: Removed.
        * platform/chromium-win/fast/borders/borderRadiusInvalidColor-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusOutset01-expected.checksum: Removed.
        * platform/chromium-win/fast/borders/borderRadiusOutset01-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusRidge01-expected.checksum: Removed.
        * platform/chromium-win/fast/borders/borderRadiusRidge01-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusSolid01-expected.checksum: Removed.
        * platform/chromium-win/fast/borders/borderRadiusSolid01-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusSolid02-expected.checksum: Removed.
        * platform/chromium-win/fast/borders/borderRadiusSolid02-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusSolid03-expected.checksum: Removed.
        * platform/chromium-win/fast/borders/borderRadiusSolid03-expected.png:
        * platform/chromium-win/fast/box-shadow/border-radius-big-expected.checksum: Removed.
        * platform/chromium-win/fast/box-shadow/border-radius-big-expected.png:
        * platform/chromium-win/fast/box-shadow/inset-expected.checksum: Removed.
        * platform/chromium-win/fast/box-shadow/inset-expected.png:
        * platform/chromium-win/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.checksum: Removed.
        * platform/chromium-win/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png:
        * platform/chromium-win/fast/box-shadow/spread-expected.checksum: Removed.
        * platform/chromium-win/fast/box-shadow/spread-expected.png:
        * platform/chromium-win/fast/box-shadow/spread-multiple-inset-expected.checksum: Removed.
        * platform/chromium-win/fast/box-shadow/spread-multiple-inset-expected.png:
        * platform/chromium-win/fast/box-shadow/spread-multiple-normal-expected.checksum: Removed.
        * platform/chromium-win/fast/box-shadow/spread-multiple-normal-expected.png:
        * platform/chromium-win/fast/forms/basic-selects-expected.checksum: Removed.
        * platform/chromium-win/fast/forms/basic-selects-expected.png:
        * platform/chromium-win/fast/layers/video-layer-expected.checksum: Removed.
        * platform/chromium-win/fast/layers/video-layer-expected.png:
        * platform/chromium-win/fast/overflow/border-radius-clipping-expected.checksum: Removed.
        * platform/chromium-win/fast/overflow/border-radius-clipping-expected.png:
        * platform/chromium-win/fast/repaint/border-radius-repaint-expected.checksum: Removed.
        * platform/chromium-win/fast/repaint/border-radius-repaint-expected.png:
        * platform/chromium-win/fast/replaced/border-radius-clip-expected.checksum: Removed.
        * platform/chromium-win/fast/replaced/border-radius-clip-expected.png:
        * platform/chromium-win/fast/transforms/shadows-expected.checksum: Removed.
        * platform/chromium-win/fast/transforms/shadows-expected.png:
        * platform/chromium-win/media/audio-controls-rendering-expected.checksum: Removed.
        * platform/chromium-win/media/audio-controls-rendering-expected.png:
        * platform/chromium-win/media/controls-after-reload-expected.checksum: Removed.
        * platform/chromium-win/media/controls-after-reload-expected.png:
        * platform/chromium-win/media/controls-strict-expected.checksum: Removed.
        * platform/chromium-win/media/controls-strict-expected.png:
        * platform/chromium-win/media/controls-styling-expected.checksum: Removed.
        * platform/chromium-win/media/controls-styling-expected.png:
        * platform/chromium-win/media/controls-without-preload-expected.checksum: Removed.
        * platform/chromium-win/media/controls-without-preload-expected.png:
        * platform/chromium-win/media/media-document-audio-repaint-expected.checksum: Removed.
        * platform/chromium-win/media/media-document-audio-repaint-expected.png:
        * platform/chromium-win/media/video-controls-rendering-expected.checksum: Removed.
        * platform/chromium-win/media/video-controls-rendering-expected.png:
        * platform/chromium-win/media/video-display-toggle-expected.checksum: Removed.
        * platform/chromium-win/media/video-display-toggle-expected.png:
        * platform/chromium-win/media/video-empty-source-expected.checksum: Removed.
        * platform/chromium-win/media/video-empty-source-expected.png:
        * platform/chromium-win/media/video-no-audio-expected.checksum: Removed.
        * platform/chromium-win/media/video-no-audio-expected.png:
        * platform/chromium-win/media/video-volume-slider-expected.checksum: Removed.
        * platform/chromium-win/media/video-volume-slider-expected.png:
        * platform/chromium-win/media/video-zoom-controls-expected.checksum: Removed.
        * platform/chromium-win/media/video-zoom-controls-expected.png:
        * platform/chromium-win/svg/custom/svg-fonts-in-html-expected.checksum: Removed.
        * platform/chromium-win/svg/custom/svg-fonts-in-html-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83019 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

kevino@webkit.org [Wed, 6 Apr 2011 05:21:20 +0000 (05:21 +0000)]

[wx] Mac build fix. Handle cases where 10.4 SDK is not installed, and also add x86_64 arch to deps.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83018 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

tkent@chromium.org [Wed, 6 Apr 2011 05:11:56 +0000 (05:11 +0000)]

2011-04-05  Kent Tamura  <tkent@chromium.org>

        [Chromium] Update expectation images for a Skia rounded rectangle change (r83002).
        https://bugs.webkit.org/show_bug.cgi?id=57907

        * platform/chromium-linux/fast/blockflow/border-radius-clipping-vertical-lr-expected.checksum: Removed.
        * platform/chromium-linux/fast/blockflow/border-radius-clipping-vertical-lr-expected.png:
        * platform/chromium-linux/fast/blockflow/box-shadow-horizontal-bt-expected.checksum: Removed.
        * platform/chromium-linux/fast/blockflow/box-shadow-horizontal-bt-expected.png:
        * platform/chromium-linux/fast/blockflow/box-shadow-vertical-lr-expected.checksum: Removed.
        * platform/chromium-linux/fast/blockflow/box-shadow-vertical-lr-expected.png:
        * platform/chromium-linux/fast/blockflow/box-shadow-vertical-rl-expected.checksum: Removed.
        * platform/chromium-linux/fast/blockflow/box-shadow-vertical-rl-expected.png:
        * platform/chromium-linux/fast/borders/border-radius-huge-assert-expected.checksum: Removed.
        * platform/chromium-linux/fast/borders/border-radius-huge-assert-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusAllStylesAllCorners-expected.checksum: Removed.
        * platform/chromium-linux/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusArcs01-expected.checksum: Removed.
        * platform/chromium-linux/fast/borders/borderRadiusArcs01-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusDashed01-expected.checksum: Removed.
        * platform/chromium-linux/fast/borders/borderRadiusDashed01-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusDashed02-expected.checksum: Removed.
        * platform/chromium-linux/fast/borders/borderRadiusDashed02-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusDashed03-expected.checksum: Removed.
        * platform/chromium-linux/fast/borders/borderRadiusDashed03-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusDotted01-expected.checksum: Removed.
        * platform/chromium-linux/fast/borders/borderRadiusDotted01-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusDotted02-expected.checksum: Removed.
        * platform/chromium-linux/fast/borders/borderRadiusDotted02-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusDotted03-expected.checksum: Removed.
        * platform/chromium-linux/fast/borders/borderRadiusDotted03-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusDouble01-expected.checksum: Removed.
        * platform/chromium-linux/fast/borders/borderRadiusDouble01-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusDouble02-expected.checksum: Removed.
        * platform/chromium-linux/fast/borders/borderRadiusDouble02-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusDouble03-expected.checksum: Removed.
        * platform/chromium-linux/fast/borders/borderRadiusDouble03-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusGroove01-expected.checksum: Removed.
        * platform/chromium-linux/fast/borders/borderRadiusGroove01-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusGroove02-expected.checksum: Removed.
        * platform/chromium-linux/fast/borders/borderRadiusGroove02-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusInset01-expected.checksum: Removed.
        * platform/chromium-linux/fast/borders/borderRadiusInset01-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusInvalidColor-expected.checksum: Removed.
        * platform/chromium-linux/fast/borders/borderRadiusInvalidColor-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusOutset01-expected.checksum: Removed.
        * platform/chromium-linux/fast/borders/borderRadiusOutset01-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusRidge01-expected.checksum: Removed.
        * platform/chromium-linux/fast/borders/borderRadiusRidge01-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusSolid01-expected.checksum: Removed.
        * platform/chromium-linux/fast/borders/borderRadiusSolid01-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusSolid02-expected.checksum: Removed.
        * platform/chromium-linux/fast/borders/borderRadiusSolid02-expected.png:
        * platform/chromium-linux/fast/borders/borderRadiusSolid03-expected.checksum: Removed.
        * platform/chromium-linux/fast/borders/borderRadiusSolid03-expected.png:
        * platform/chromium-linux/fast/box-shadow/border-radius-big-expected.checksum: Removed.
        * platform/chromium-linux/fast/box-shadow/border-radius-big-expected.png:
        * platform/chromium-linux/fast/box-shadow/inset-expected.checksum: Removed.
        * platform/chromium-linux/fast/box-shadow/inset-expected.png:
        * platform/chromium-linux/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.checksum: Removed.
        * platform/chromium-linux/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png:
        * platform/chromium-linux/fast/box-shadow/spread-expected.checksum: Removed.
        * platform/chromium-linux/fast/box-shadow/spread-expected.png:
        * platform/chromium-linux/fast/box-shadow/spread-multiple-inset-expected.checksum: Removed.
        * platform/chromium-linux/fast/box-shadow/spread-multiple-inset-expected.png:
        * platform/chromium-linux/fast/box-shadow/spread-multiple-normal-expected.checksum: Removed.
        * platform/chromium-linux/fast/box-shadow/spread-multiple-normal-expected.png:
        * platform/chromium-linux/fast/forms/basic-selects-expected.checksum: Removed.
        * platform/chromium-linux/fast/forms/basic-selects-expected.png:
        * platform/chromium-linux/fast/overflow/border-radius-clipping-expected.checksum: Removed.
        * platform/chromium-linux/fast/overflow/border-radius-clipping-expected.png:
        * platform/chromium-linux/fast/repaint/border-radius-repaint-expected.checksum: Removed.
        * platform/chromium-linux/fast/repaint/border-radius-repaint-expected.png:
        * platform/chromium-linux/fast/replaced/border-radius-clip-expected.checksum: Removed.
        * platform/chromium-linux/fast/replaced/border-radius-clip-expected.png:
        * platform/chromium-linux/fast/transforms/shadows-expected.checksum: Removed.
        * platform/chromium-linux/fast/transforms/shadows-expected.png:
        * platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.checksum: Removed.
        * platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.png:
        * platform/chromium-win/fast/blockflow/border-radius-clipping-vertical-lr-expected.checksum: Removed.
        * platform/chromium-win/fast/blockflow/border-radius-clipping-vertical-lr-expected.png:
        * platform/chromium-win/fast/blockflow/box-shadow-horizontal-bt-expected.checksum: Removed.
        * platform/chromium-win/fast/blockflow/box-shadow-horizontal-bt-expected.png:
        * platform/chromium-win/fast/blockflow/box-shadow-vertical-lr-expected.checksum: Removed.
        * platform/chromium-win/fast/blockflow/box-shadow-vertical-lr-expected.png:
        * platform/chromium-win/fast/blockflow/box-shadow-vertical-rl-expected.checksum: Removed.
        * platform/chromium-win/fast/blockflow/box-shadow-vertical-rl-expected.png:
        * platform/chromium-win/fast/borders/border-radius-huge-assert-expected.checksum: Removed.
        * platform/chromium-win/fast/borders/border-radius-huge-assert-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusAllStylesAllCorners-expected.checksum: Removed.
        * platform/chromium-win/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusArcs01-expected.checksum: Removed.
        * platform/chromium-win/fast/borders/borderRadiusArcs01-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusDashed01-expected.checksum: Removed.
        * platform/chromium-win/fast/borders/borderRadiusDashed01-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusDashed02-expected.checksum: Removed.
        * platform/chromium-win/fast/borders/borderRadiusDashed02-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusDashed03-expected.checksum: Removed.
        * platform/chromium-win/fast/borders/borderRadiusDashed03-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusDotted01-expected.checksum: Removed.
        * platform/chromium-win/fast/borders/borderRadiusDotted01-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusDotted02-expected.checksum: Removed.
        * platform/chromium-win/fast/borders/borderRadiusDotted02-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusDotted03-expected.checksum: Removed.
        * platform/chromium-win/fast/borders/borderRadiusDotted03-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusDouble01-expected.checksum: Removed.
        * platform/chromium-win/fast/borders/borderRadiusDouble01-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusDouble02-expected.checksum: Removed.
        * platform/chromium-win/fast/borders/borderRadiusDouble02-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusDouble03-expected.checksum: Removed.
        * platform/chromium-win/fast/borders/borderRadiusDouble03-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusGroove01-expected.checksum: Removed.
        * platform/chromium-win/fast/borders/borderRadiusGroove01-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusGroove02-expected.checksum: Removed.
        * platform/chromium-win/fast/borders/borderRadiusGroove02-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusInset01-expected.checksum: Removed.
        * platform/chromium-win/fast/borders/borderRadiusInset01-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusInvalidColor-expected.checksum: Removed.
        * platform/chromium-win/fast/borders/borderRadiusInvalidColor-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusOutset01-expected.checksum: Removed.
        * platform/chromium-win/fast/borders/borderRadiusOutset01-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusRidge01-expected.checksum: Removed.
        * platform/chromium-win/fast/borders/borderRadiusRidge01-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusSolid01-expected.checksum: Removed.
        * platform/chromium-win/fast/borders/borderRadiusSolid01-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusSolid02-expected.checksum: Removed.
        * platform/chromium-win/fast/borders/borderRadiusSolid02-expected.png:
        * platform/chromium-win/fast/borders/borderRadiusSolid03-expected.checksum: Removed.
        * platform/chromium-win/fast/borders/borderRadiusSolid03-expected.png:
        * platform/chromium-win/fast/box-shadow/border-radius-big-expected.checksum: Removed.
        * platform/chromium-win/fast/box-shadow/border-radius-big-expected.png:
        * platform/chromium-win/fast/box-shadow/inset-expected.checksum: Removed.
        * platform/chromium-win/fast/box-shadow/inset-expected.png:
        * platform/chromium-win/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.checksum: Removed.
        * platform/chromium-win/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png:
        * platform/chromium-win/fast/box-shadow/spread-expected.checksum: Removed.
        * platform/chromium-win/fast/box-shadow/spread-expected.png:
        * platform/chromium-win/fast/box-shadow/spread-multiple-inset-expected.checksum: Removed.
        * platform/chromium-win/fast/box-shadow/spread-multiple-inset-expected.png:
        * platform/chromium-win/fast/box-shadow/spread-multiple-normal-expected.checksum: Removed.
        * platform/chromium-win/fast/box-shadow/spread-multiple-normal-expected.png:
        * platform/chromium-win/fast/forms/basic-selects-expected.checksum: Removed.
        * platform/chromium-win/fast/forms/basic-selects-expected.png:
        * platform/chromium-win/fast/overflow/border-radius-clipping-expected.checksum: Removed.
        * platform/chromium-win/fast/overflow/border-radius-clipping-expected.png:
        * platform/chromium-win/fast/repaint/border-radius-repaint-expected.checksum: Removed.
        * platform/chromium-win/fast/repaint/border-radius-repaint-expected.png:
        * platform/chromium-win/fast/replaced/border-radius-clip-expected.checksum: Removed.
        * platform/chromium-win/fast/replaced/border-radius-clip-expected.png:
        * platform/chromium-win/fast/transforms/shadows-expected.checksum: Removed.
        * platform/chromium-win/fast/transforms/shadows-expected.png:
        * platform/chromium-win/svg/custom/svg-fonts-in-html-expected.checksum: Removed.
        * platform/chromium-win/svg/custom/svg-fonts-in-html-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83017 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

ap@apple.com [Wed, 6 Apr 2011 04:35:01 +0000 (04:35 +0000)]

2011-04-05  Alexey Proskuryakov  <ap@apple.com>

        Reviewed by Darin Adler.

        Rename event dispatching functions after form event removal
        https://bugs.webkit.org/show_bug.cgi?id=57908

        * dom/InputElement.cpp:
        (WebCore::InputElement::setValueFromRenderer):
        * dom/Node.cpp:
        (WebCore::Node::dispatchChangeEvent):
        (WebCore::Node::dispatchInputEvent):
        (WebCore::Node::defaultEventHandler):
        * dom/Node.h:
        * html/HTMLFormControlElement.cpp:
        (WebCore::HTMLFormControlElement::dispatchFormControlChangeEvent):
        (WebCore::HTMLFormControlElement::dispatchFormControlInputEvent):
        (WebCore::HTMLTextFormControlElement::dispatchFormControlChangeEvent):
        Renamed "events" to "event", since there is only one event to dispatch now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83016 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

commit-queue@webkit.org [Wed, 6 Apr 2011 03:58:08 +0000 (03:58 +0000)]

2011-04-05  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r82978, r82999, and r83001.
        http://trac.webkit.org/changeset/82978
        http://trac.webkit.org/changeset/82999
        http://trac.webkit.org/changeset/83001
        https://bugs.webkit.org/show_bug.cgi?id=57913

        Does not work in Python 2.5 (Requested by abarth on #webkit).

        * Scripts/webkitpy/common/system/executive.py:
        * Scripts/webkitpy/common/system/executive_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83015 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

commit-queue@webkit.org [Wed, 6 Apr 2011 03:56:29 +0000 (03:56 +0000)]

2011-04-05  Anders Bakken  <agbakken@gmail.com>

        Reviewed by David Levin.

        [Qt] DragControllerQt.cpp has coding-style errors
        https://bugs.webkit.org/show_bug.cgi?id=40258

        This patch does not require new test cases.

        * page/qt/DragControllerQt.cpp:
        (WebCore::DragController::dragOperation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83014 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

commit-queue@webkit.org [Wed, 6 Apr 2011 03:53:10 +0000 (03:53 +0000)]

2011-04-05  Steve VanDeBogart  <vandebo@chromium.org>

        Reviewed by David Levin.

        Update deprecated include: platform_canvas_win.h to platform_canvas.h.
        https://bugs.webkit.org/show_bug.cgi?id=57896

        * platform/graphics/chromium/FontChromiumWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83013 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

ggaren@apple.com [Wed, 6 Apr 2011 03:49:23 +0000 (03:49 +0000)]

Try to fix the Windows build.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Who likes export files? I do!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

ggaren@apple.com [Wed, 6 Apr 2011 03:44:48 +0000 (03:44 +0000)]

2011-04-05  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        Introduced the concept of opaque roots, in preparation for marking the DOM with them
        https://bugs.webkit.org/show_bug.cgi?id=57903

        * JavaScriptCore.exp: Who likes export files? I do!

        * collector/handles/HandleHeap.cpp:
        (JSC::isValidWeakHandle): Factored out a helper function for ASSERTs.

        (JSC::WeakHandleOwner::~WeakHandleOwner): Moved from header to avoid
        weak linkage problems.

        (JSC::WeakHandleOwner::isReachableFromOpaqueRoots): New callback.
        Currently unused.

        (JSC::WeakHandleOwner::finalize): Switched from pure virtual to a
        default empty implementation, since not all clients necessarily want
        or need non-trivial finalizers.

        (JSC::HandleHeap::markWeakHandles): Split updateWeakHandles into two
        passes. The first pass marks all reachable weak handles. The second pass
        finalizes all unreachable weak handles. This must be two passes because
        we don't know the set of finalizable weak handles until we're done
        marking all weak handles.

        (JSC::HandleHeap::finalizeWeakHandles): Use new helper function.

        * collector/handles/HandleHeap.h: Ditto.

        * runtime/Heap.cpp:
        (JSC::Heap::destroy):
        (JSC::Heap::markRoots):
        (JSC::Heap::reset): Split out handle marking from handle finalization.

        * runtime/MarkStack.cpp:
        (JSC::MarkStack::reset):
        * runtime/MarkStack.h:
        (JSC::MarkStack::addOpaqueRoot):
        (JSC::MarkStack::containsOpaqueRoot):
        (JSC::MarkStack::opaqueRootCount):
        (JSC::HeapRootMarker::markStack): New helper functions for managing the
        set of opaque roots.

        * runtime/WeakGCMap.h:
        (JSC::WeakGCMap::finalize): Renamed to match parent class declaration.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

commit-queue@webkit.org [Wed, 6 Apr 2011 03:05:04 +0000 (03:05 +0000)]

2011-04-05  Chang Shu  <cshu@webkit.org>

        Reviewed by Darin Adler.

        WebKitTestRunner needs layoutTestController.numberOfPages
        https://bugs.webkit.org/show_bug.cgi?id=42694

        Unskip passed tests.

        * platform/mac-wk2/Skipped:
        * platform/qt-wk2/Skipped:
2011-04-05  Chang Shu  <cshu@webkit.org>

        Reviewed by Darin Adler.

        WebKitTestRunner needs layoutTestController.numberOfPages
        https://bugs.webkit.org/show_bug.cgi?id=42694

        * WebProcess/InjectedBundle/API/c/WKBundle.cpp:
        (WKBundleNumberOfPages):
        * WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
        * WebProcess/InjectedBundle/InjectedBundle.cpp:
        (WebKit::InjectedBundle::numberOfPages):
        * WebProcess/InjectedBundle/InjectedBundle.h:
2011-04-05  Chang Shu  <cshu@webkit.org>

        Reviewed by Darin Adler.

        WebKitTestRunner needs layoutTestController.numberOfPages
        https://bugs.webkit.org/show_bug.cgi?id=42694

        * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
        * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
        (WTR::LayoutTestController::numberOfPages):
        * WebKitTestRunner/InjectedBundle/LayoutTestController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

commit | commitdiff | tree

tony@chromium.org [Wed, 6 Apr 2011 02:20:00 +0000 (02:20 +0000)]

2011-04-05  Tony Chang  <tony@chromium.org>

        Reviewed by Mihai Parparita.

        [chromium] stop putting results downloaded from WebKit Linux in chromium-linux-x86_64
        https://bugs.webkit.org/show_bug.cgi?id=57889

        * Scripts/webkitpy/layout_tests/port/chromium.py:
        * Scripts/webkitpy/layout_tests/port/test.py:
        * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@83009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Mirror of the WebKit open source project from svn.webkit.org.