WebKit-https.git
14 years agoforgot to move one file in the last commit.
lars [Thu, 4 Oct 2007 07:36:09 +0000 (07:36 +0000)]
forgot to move one file in the last commit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Move png files that are not test results and where mistakenly moved in r26026
lars [Thu, 4 Oct 2007 07:32:23 +0000 (07:32 +0000)]
    Move png files that are not test results and where mistakenly moved in r26026
        back to where they belong.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adam.
darin [Thu, 4 Oct 2007 00:43:30 +0000 (00:43 +0000)]
    Reviewed by Adam.

        * Scripts/webkitdirs.pm: Automatically use "Debug_Internal" if
        we find the internal libraries in the libraries directory. This
        is helpful for Safari team engineers at Apple.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago <rdar://problem/5521230> Implement IWebIconDatabase::iconURLForURL in WebKit...
adachan [Wed, 3 Oct 2007 22:48:58 +0000 (22:48 +0000)]
    <rdar://problem/5521230> Implement IWebIconDatabase::iconURLForURL in WebKit for windows

        Reviewed by Steve and Brady.

        * Interfaces/IWebIconDatabase.idl:
        * WebIconDatabase.cpp:
        (WebIconDatabase::iconURLForURL):
        * WebIconDatabase.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26029 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Move pixel test results that were mistakenly left in place after r25970
aroben [Wed, 3 Oct 2007 21:00:48 +0000 (21:00 +0000)]
    Move pixel test results that were mistakenly left in place after r25970

        Rubberstamped by Sam.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Add some sometimes-timing-out tests to the Skipped file
aroben [Wed, 3 Oct 2007 17:40:56 +0000 (17:40 +0000)]
    Add some sometimes-timing-out tests to the Skipped file

        Rubberstamped by Sam.

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Update the location of AHEM___.TTF after r25968
aroben [Wed, 3 Oct 2007 17:33:13 +0000 (17:33 +0000)]
    Update the location of AHEM___.TTF after r25968

        Reviewed by Sam.

        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-10-03 Alp Toker <alp@atoker.com>
alp [Wed, 3 Oct 2007 17:25:43 +0000 (17:25 +0000)]
2007-10-03  Alp Toker  <alp@atoker.com>

        Reviewed by Adam.

        http://bugs.webkit.org/show_bug.cgi?id=14726
        [gtk] API design. Mapping the WebView delegates to signals.

        Change the API namespace of the Gtk+ port from 'WebKitGtk' to 'WebKit'.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26022 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-10-03 Alp Toker <alp@atoker.com>
alp [Wed, 3 Oct 2007 17:16:23 +0000 (17:16 +0000)]
2007-10-03  Alp Toker  <alp@atoker.com>

        Reviewed by Eric.

        http://bugs.webkit.org/show_bug.cgi?id=14129
        [CAIRO] Support the canvas element

        Add a new canvas implementation using Cairo for rendering.

        * html/CanvasGradient.cpp:
        (WebCore::CanvasGradient::CanvasGradient):
        (WebCore::CanvasGradient::~CanvasGradient):
        (WebCore::CanvasGradient::addColorStop):
        (WebCore::CanvasGradient::platformShading):
        * html/CanvasGradient.h:
        * html/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::setFillStyle):
        (WebCore::CanvasRenderingContext2D::fill):
        (WebCore::CanvasRenderingContext2D::stroke):
        (WebCore::CanvasRenderingContext2D::fillRect):
        (WebCore::CanvasRenderingContext2D::drawImage):
        (WebCore::CanvasRenderingContext2D::applyStrokePattern):
        * html/CanvasStyle.cpp:
        (WebCore::CanvasStyle::applyStrokeColor):
        * html/HTMLCanvasElement.cpp:
        (WebCore::HTMLCanvasElement::~HTMLCanvasElement):
        (WebCore::HTMLCanvasElement::reset):
        (WebCore::HTMLCanvasElement::paint):
        (WebCore::HTMLCanvasElement::createDrawingContext):
        (WebCore::HTMLCanvasElement::createPlatformImage):
        * html/HTMLCanvasElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26021 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-10-02 Cosimo Cecchi <cosimoc@svn.gnome.org>
zecke [Wed, 3 Oct 2007 16:31:13 +0000 (16:31 +0000)]
2007-10-02  Cosimo Cecchi  <cosimoc@svn.gnome.org>

        Reviewed by Mark.

        http://bugs.webkit.org/show_bug.cgi?id=15299
        Fix "hovering_over_link" signal being fired every time mouse moves.

        * WebCoreSupport/ChromeClientGtk.cpp:
        (WebKit::ChromeClient::ChromeClient):
        (WebKit::ChromeClient::mouseDidMoveOverElement):
        * WebCoreSupport/ChromeClientGtk.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26020 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-09-21 Sean Egan <seanegan@gmail.com>
zecke [Wed, 3 Oct 2007 16:30:50 +0000 (16:30 +0000)]
2007-09-21  Sean Egan  <seanegan@gmail.com>

        Reviewed by Alp.

        Add an "execute_script" method to programmatically call Javascript
        http://bugs.webkit.org/show_bug.cgi?id=15255

        * Api/webkitgtkpage.cpp:
        * Api/webkitgtkpage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26019 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago This fixes --strict mode in run-webkit-tests again after
lars [Wed, 3 Oct 2007 14:20:38 +0000 (14:20 +0000)]
    This fixes --strict mode in run-webkit-tests again after
        the platform dependent test results have been moved.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26018 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Fix a stupid bug in Unicode::toUpper/toLower.
lars [Wed, 3 Oct 2007 14:14:13 +0000 (14:14 +0000)]
    Fix a stupid bug in Unicode::toUpper/toLower.
        Fixes all three test failures in the JavaScriptCore test
        suite.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26017 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoadd some more passing tests, and update one result.
lars [Wed, 3 Oct 2007 13:28:35 +0000 (13:28 +0000)]
add some more passing tests, and update one result.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26016 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoremove the hack in run-webkit-tests that forced text only test
lars [Wed, 3 Oct 2007 11:52:24 +0000 (11:52 +0000)]
remove the hack in run-webkit-tests that forced text only test
to be taken from the platform independent dir. It was only left
there from early days.

Remove platform dependent results for tests that are text only nowadays,
and add one platform dependent result for a text only test that requires it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoadd some more results.
lars [Wed, 3 Oct 2007 11:33:12 +0000 (11:33 +0000)]
add some more results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@26010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Move all test results that are platform dependent but
lars [Wed, 3 Oct 2007 10:53:05 +0000 (10:53 +0000)]
    Move all test results that are platform dependent but
        stored in the platform independent part to their
        correct locations (inside platform/mac).

        This will make it a lot easier to maintain test
        results for other platforms than mac.

        Signed off by aroben.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25970 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agomove WebKitQt to WebKit/qt for consistency with the other ports.
lars [Wed, 3 Oct 2007 10:29:35 +0000 (10:29 +0000)]
move WebKitQt to WebKit/qt for consistency with the other ports.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoMove the Qt version of DRT into the correct place and put the binary into BUILDDIR...
lars [Wed, 3 Oct 2007 10:29:15 +0000 (10:29 +0000)]
Move the Qt version of DRT into the correct place and put the binary into BUILDDIR/bin.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-10-03 Mark Rowe <mrowe@apple.com>
bdash [Wed, 3 Oct 2007 09:25:21 +0000 (09:25 +0000)]
2007-10-03  Mark Rowe  <mrowe@apple.com>

        Reviewed by Alp Toker.

        Fix build-webkit when both QTDIR and --gtk are set.  The presence of --gtk
        should take precedence over QTDIR when determining which port we are working with.

        * Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoRemove pixel test results for text only tests
lars [Wed, 3 Oct 2007 09:03:13 +0000 (09:03 +0000)]
Remove pixel test results for text only tests

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoBump to correct version
aroben [Wed, 3 Oct 2007 06:31:38 +0000 (06:31 +0000)]
Bump to correct version

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoBump versions for submit
sfalken [Wed, 3 Oct 2007 06:08:26 +0000 (06:08 +0000)]
Bump versions for submit

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Rubber-stamped by Adam Roben.
weinig [Wed, 3 Oct 2007 02:15:21 +0000 (02:15 +0000)]
    Rubber-stamped by Adam Roben.

        * Interfaces/IWebPreferences.idl: Remove unnecessary comments.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Add keychain to the list of default packages to install
aroben [Wed, 3 Oct 2007 00:18:47 +0000 (00:18 +0000)]
    Add keychain to the list of default packages to install

        Rubberstamped by Sam.

        * CygwinDownloader/cygwin-downloader.py:
        * CygwinDownloader/cygwin-downloader.zip: Regenerated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Oliver and Adam.
weinig [Wed, 3 Oct 2007 00:17:53 +0000 (00:17 +0000)]
    Reviewed by Oliver and Adam.

        Patch for <rdar://problem/5506968> Fail to DnD local file with non-ascii character in path from desktop to Safari (can open it with file menu)

        Use CoreFoundation to do the conversion from path to URL, as the Windows API was not
        correctly converting to UTF-8 and we know CFURL will.

        * platform/win/ClipboardUtilitiesWin.cpp:
        (WebCore::urlFromPath):
        (WebCore::getURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin Adler.
tristan [Tue, 2 Oct 2007 23:36:06 +0000 (23:36 +0000)]
    Reviewed by Darin Adler.

        <rdar://problem/5511842> REGRESSION: Webkit stops responding while loading Apple Store Canada page (15304)

        Included the NSSynchronousURLConnection_PrivateMode mode, in addition to the default run loop modes
        as an acceptable mode when using performSelectorOnMainThread with our syncronous url callbacks.

        * platform/network/mac/ResourceHandleMac.mm:
        (-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]):
        Added NSSynchronousURLConnection_PrivateMode to the list of accepted modes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Added a mention of a bug that this test demonstrates:
justing [Tue, 2 Oct 2007 21:20:55 +0000 (21:20 +0000)]
    Added a mention of a bug that this test demonstrates:

        * editing/execCommand/5144139-1-expected.checksum: Removed.
        * editing/execCommand/5144139-1-expected.png: Removed.
        * editing/execCommand/5144139-1-expected.txt: Removed.
        * editing/execCommand/5144139-1.html:
        * platform/mac/editing/execCommand/5144139-1-expected.checksum: Added.
        * platform/mac/editing/execCommand/5144139-1-expected.png: Added.
        * platform/mac/editing/execCommand/5144139-1-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25938 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Mark Rowe.
kdecker [Tue, 2 Oct 2007 21:20:18 +0000 (21:20 +0000)]
    Reviewed by Mark Rowe.

        Re-added _minimumRequiredSafariBuildNumber. It turns out older version of Safari still rely
        on this method, so we need to keep it around at least until the next major Safari release.

        * StringsNotToBeLocalized.txt:
        * WebView/WebView.mm:
        (+[WebView _minimumRequiredSafariBuildNumber]):
        * WebView/WebViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoSet svn:eol-style for all .sln files to CRLF.
darin [Tue, 2 Oct 2007 20:57:06 +0000 (20:57 +0000)]
Set svn:eol-style for all .sln files to CRLF.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25935 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore:
darin [Tue, 2 Oct 2007 20:49:13 +0000 (20:49 +0000)]
JavaScriptCore:

        Reviewed by Adam.

        - add support for GDI objects to OwnPtr; I plan to use this
          to fix some GDI handle leaks

        * kjs/grammar.y: Change parser to avoid macros that conflict
        with macros defined in Windows system headers: THIS, DELETE,
        VOID, IN, and CONST. This is needed because OwnPtr.h will now
        include <windows.h>.
        * kjs/keywords.table: Ditto.

        * wtf/OwnPtr.h: For PLATFORM(WIN), add support so that OwnPtr can be
        a GDI handle, and it will call DeleteObject. Also change to use the
        RemovePointer technique used by RetainPtr, so you can say OwnPtr<HBITMAP>
        rather than having to pass in the type pointed to by HBITMAP.

        * wtf/OwnPtrWin.cpp: Added.
        (WebCore::deleteOwnedPtr): Put this in a separate file so that we
        don't have to include <windows.h> in OwnPtr.h.

        * JavaScriptCore.vcproj/WTF/WTF.vcproj: Added OwnPtrWin.cpp.

WebCore:

        Reviewed by Adam.

        - add support for GDI objects to OwnPtr; I plan to use this
          to fix some GDI handle leaks

        * css/CSSGrammar.y: Change parser to avoid macro that conflicts
        with macro defined in Windows system headers: FLOAT. This is needed
        because OwnPtr.h will now include <windows.h>.
        * css/CSSParser.cpp: (WebCore::CSSParser::lex): Ditto.
        * css/tokenizer.flex: Ditto.

        * platform/win/CursorWin.cpp: (WebCore::Cursor::Cursor):
        Use OwnPtr for a few HBITMAP objects as a test case.

        * platform/win/COMPtr.h: (COMPtr::COMPtr): Fix so that we can use
        Query with other COMPtr. Before this would not compile if it was
        ever instantiated.

win:

        Reviewed by Adam.

        - started using the new OwnPtr everywhere we do DeleteObject

        * WebNodeHighlight.cpp:
        (WebNodeHighlight::updateWindow):
        * WebView.cpp:
        (WebView::WebView):
        (WebView::deleteBackingStore):
        (WebView::ensureBackingStore):
        (WebView::addToDirtyRegion):
        (WebView::scrollBackingStore):
        (WebView::updateBackingStore):
        (WebView::paint):
        (WebView::paintIntoBackingStore):
        (WebView::paintIntoWindow):
        * WebView.h:

Also set svn:eol-style on all .vcproj to CRLF.

Also added svn:ignore of *.user for WebKitInitializer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25934 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebKitTools:
ddkilzer [Tue, 2 Oct 2007 20:38:36 +0000 (20:38 +0000)]
WebKitTools:

        Reviewed by Adam.

        Make "--git-commit trunk..HEAD" work with prepare-ChangeLog.
        Also makes WebCore regression test case logic work when using git.

        * Scripts/prepare-ChangeLog:
        (reviewerAndDescriptionForGitCommit): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adam, Ada.
sfalken [Tue, 2 Oct 2007 19:58:14 +0000 (19:58 +0000)]
    Reviewed by Adam, Ada.

        Fix leak of GDI handle when we call MLANG.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Fix <rdar://5505062> WebKit's version-independent ProgIDs contain version...
aroben [Tue, 2 Oct 2007 17:55:01 +0000 (17:55 +0000)]
    Fix <rdar://5505062> WebKit's version-independent ProgIDs contain version numbers

        I also added a few registry keys for our version-independent ProgIDs
        that we were missing.

        Reviewed by Steve.

        * ProgIDMacros.h: Added new macros to get version-independent ProgIDs.
        * WebKitDLL.cpp: Use the version-independent ProgIDs in the right
        places, and added some new keys for version-independent ProgIDs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by John Sullivan.
kdecker [Tue, 2 Oct 2007 17:35:26 +0000 (17:35 +0000)]
    Reviewed by John Sullivan.

        <rdar://problem/5517710>

        * WebView/WebView.mm: Removed -[WebView _minimumRequiredSafariBuildNumber] because newer
         versions of Safari no longer use this method. This won't break existing Safaris because
         they always use a respondsToSelector check before calling this.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adam.
andersca [Tue, 2 Oct 2007 17:31:11 +0000 (17:31 +0000)]
    Reviewed by Adam.

        Fix a bug discovered by app verifier where we would treat an LPCTSTR as a BSTR causing a crash.

        Also rename some protection space constants and change their values to match the mac version.

        * Interfaces/IWebURLAuthenticationChallenge.idl:
        * WebURLProtectionSpace.cpp:
        (WebURLProtectionSpace::initWithHost):
        (WebURLProtectionSpace::initWithProxyHost):
        (WebURLProtectionSpace::protocol):
        (WebURLProtectionSpace::proxyType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoReviewed by Eric Seidel.
treat [Tue, 2 Oct 2007 16:21:57 +0000 (16:21 +0000)]
Reviewed by Eric Seidel.

Open the requested url on the newly created window.
Implement createModalDialog and provide new API for this.
Patch by M. Mehdi Salem Naraghi (momesana) with additions by me.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agodirty way of getting the Qt port to 0 test failures.
lars [Tue, 2 Oct 2007 14:04:42 +0000 (14:04 +0000)]
dirty way of getting the Qt port to 0 test failures.
It's still a good thing to do, as we now have a complete
list of all tests that are currently failing in the Skipped
file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoupdate two more test results and skip two crashing test cases for now.
lars [Tue, 2 Oct 2007 13:19:16 +0000 (13:19 +0000)]
update two more test results and skip two crashing test cases for now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAdd API to retrieve the frame name from QWebFrame.
lars [Tue, 2 Oct 2007 13:02:43 +0000 (13:02 +0000)]
Add API to retrieve the frame name from QWebFrame.
Implement support for DRT::dumpChildrenAsText.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoupdate two more test results.
lars [Tue, 2 Oct 2007 12:56:11 +0000 (12:56 +0000)]
update two more test results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoSkip some tests that fail due to a bug in Qt 4.3, and update one more result.
lars [Tue, 2 Oct 2007 12:02:22 +0000 (12:02 +0000)]
Skip some tests that fail due to a bug in Qt 4.3, and update one more result.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix the handling of the response header for data urls. Make sure we always pass absol...
lars [Tue, 2 Oct 2007 11:29:43 +0000 (11:29 +0000)]
Fix the handling of the response header for data urls. Make sure we always pass absolute URLs to WebKit from both DRT and QtLauncher.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-10-02 Mark Rowe <mrowe@apple.com>
bdash [Tue, 2 Oct 2007 10:34:32 +0000 (10:34 +0000)]
2007-10-02  Mark Rowe  <mrowe@apple.com>

        Reviewed by Oliver.

        Update WebKitLauncher to notify you of new builds from the correct branch, rather than always checking trunk.

        * BuildSlaveSupport/build-launcher-app: Generate a file named BRANCH into WebKit.app so that it knows which branch it was built from.
        * WebKitLauncher/start.html: Use the new URL format that includes the branch we were built from.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-10-02 Mark Rowe <mrowe@apple.com>
bdash [Tue, 2 Oct 2007 09:13:00 +0000 (09:13 +0000)]
2007-10-02  Mark Rowe  <mrowe@apple.com>

        Rubber-stamped by Maciej.

        Configuration changes from build.webkit.org.  The major change is refactoring to work
        with Buildbot 0.7.6, but it does include other smaller changes that have been made in the
        last few weeks.

        * BuildSlaveSupport/build.webkit.org-config/master.cfg:
        * BuildSlaveSupport/build.webkit.org-config/webkit/auth.py:
        * BuildSlaveSupport/build.webkit.org-config/webkit/basesteps.py:
        * BuildSlaveSupport/build.webkit.org-config/webkit/builders.py:
        * BuildSlaveSupport/build.webkit.org-config/webkit/factories.py:
        * BuildSlaveSupport/build.webkit.org-config/webkit/schedulers.py:
        * BuildSlaveSupport/build.webkit.org-config/webkit/status.py:
        * BuildSlaveSupport/build.webkit.org-config/webkit/steps.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Add support for eventSender.mouseMove to DRT.
lars [Tue, 2 Oct 2007 09:10:53 +0000 (09:10 +0000)]
    Add support for eventSender.mouseMove to DRT.
        Fixes fast/css/hover-affects-child.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago The cookies() method should only return the value of the
lars [Tue, 2 Oct 2007 08:46:50 +0000 (08:46 +0000)]
    The cookies() method should only return the value of the
        cookie, not additional info such as the expiration date.
        Fixes LayoutTests/fast/cookies/local-file-can-set-cookies.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAdded some more test results.
lars [Tue, 2 Oct 2007 08:46:41 +0000 (08:46 +0000)]
Added some more test results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoUpdate test result.
lars [Tue, 2 Oct 2007 08:09:06 +0000 (08:09 +0000)]
Update test result.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix a wrong extension mapping in the MIMETypeRegistry and identify about: url's as...
lars [Tue, 2 Oct 2007 06:46:43 +0000 (06:46 +0000)]
Fix a wrong extension mapping in the MIMETypeRegistry and identify about: url's as frames in the FrameLoaderClient.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-10-01 Mark Rowe <mrowe@apple.com>
bdash [Tue, 2 Oct 2007 05:06:24 +0000 (05:06 +0000)]
2007-10-01  Mark Rowe  <mrowe@apple.com>

        * BuildSlaveSupport/build-launcher-dmg: Tweak once more to handle nightly builds for branches.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
justing [Tue, 2 Oct 2007 01:49:26 +0000 (01:49 +0000)]
WebCore:

        Reviewed by Harrison.

        <rdar://problem/5516183> REGRESSION: Creating a ToDo on an incoming message fails

        Rolling out r25721.

        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::doApply):
        * editing/ReplaceSelectionCommand.h:

LayoutTests:

        Reviewed by Harrison.

        <rdar://problem/5516183> REGRESSION: Creating a ToDo on an incoming message fails

        * editing/pasteboard/5483567.html: Removed.
        * editing/pasteboard/5483567.html-disabled: Added.
        * editing/pasteboard/nested-blocks-with-text-area-expected.txt:
        * editing/pasteboard/nested-blocks-with-text-field-expected.txt:
        * editing/pasteboard/paste-RTFD-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoRollout accidentally committed r25819
oliver [Mon, 1 Oct 2007 23:15:54 +0000 (23:15 +0000)]
Rollout accidentally committed r25819

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoYet another typo. I really like the whimsy in this one, but it's probably best to...
bdakin [Mon, 1 Oct 2007 23:00:51 +0000 (23:00 +0000)]
Yet another typo. I really like the whimsy in this one, but it's probably best to fix it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWrong its/it's!
bdakin [Mon, 1 Oct 2007 22:45:13 +0000 (22:45 +0000)]
Wrong its/it's!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adam.
bdakin [Mon, 1 Oct 2007 22:38:26 +0000 (22:38 +0000)]
    Reviewed by Adam.

        Fix for <rdar://problem/5515426> NetNewsWire 3 crashes at launch in
        WebCore::FrameView::layout (other repro scenarios too)

        The new call to updateWidget() that we added to FrameView::layout()
        can destroy the RenderPartObject. And so we were crashing on the
        subsequent call to updateWidgetPosition(). This patch fixes that by
        checking to make sure the RenderPartObject is still in the HashSet
        after updateWidget(). Because m_widgetUpdateSet can be modified
        during the call to updateWidget(), we need it to be intact while we
        are iterating through the copy, so we cannot use the HashSet::swap
        call we were using before. This patch instead uses a Vector to
        iterate through the HashSet data and calls clear() on the HashSet
        at the end.

        * page/FrameView.cpp:
        (WebCore::FrameView::layout):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-05-10 Eric Seidel <eric@webkit.org>
oliver [Mon, 1 Oct 2007 22:08:42 +0000 (22:08 +0000)]
2007-05-10  Eric Seidel  <eric@webkit.org>

        Reviewed by olliej.

        http://bugs.webkit.org/show_bug.cgi?id=11931
        PathCG fails to hit on unclosed sub-paths

        Test: svg/custom/hit-test-unclosed-subpaths.svg

        * platform/graphics/cg/PathCG.cpp:
        (WebCore::copyClosingSubpathsApplierFunction):
        (WebCore::copyCGPathClosingSubpaths):
        (WebCore::Path::contains): use new copy & close function

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-09-29 Lars Lindner <lars.lindner@gmail.com>
zecke [Mon, 1 Oct 2007 21:44:30 +0000 (21:44 +0000)]
2007-09-29  Lars Lindner  <lars.lindner@gmail.com>

        Reviewed by Adam.

        ChromeClientGtk.cpp does not implement mouseDidMoveOverElement()
        http://bugs.webkit.org/show_bug.cgi?id=15299

        Implementing "hovering_over_link" signal.

        * WebCoreSupport/ChromeClientGtk.cpp:
        (WebKit::ChromeClient::mouseDidMoveOverElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebKitTools:
ddkilzer [Mon, 1 Oct 2007 19:33:09 +0000 (19:33 +0000)]
WebKitTools:

        Reviewed by Hyatt.

        Make svn-apply and svn-unapply work with added files in git-diff formatted patches.

        * Scripts/svn-apply:
        (gitdiff2svndiff): Ignore lines beginning with "new file".
        * Scripts/svn-unapply:
        (gitdiff2svndiff): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-10-01 Eli Fidler <eli@staikos.net>
staikos [Mon, 1 Oct 2007 18:15:28 +0000 (18:15 +0000)]
2007-10-01  Eli Fidler  <eli@staikos.net>

        Reviewed by George Staikos.

        Switch bogus assert to a conditional and return.  This case happens
        when a widget is hidden.

        * platform/qt/WidgetQt.cpp:
        (WebCore::Widget::invalidateRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Remove the separate ChangeLog in Layouttests/platform/qt.
lars [Mon, 1 Oct 2007 13:51:06 +0000 (13:51 +0000)]
    Remove the separate ChangeLog in Layouttests/platform/qt.
        Update layout test results. We still have a few failures,
        but these ones are real issues.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej.
darin [Mon, 1 Oct 2007 01:54:09 +0000 (01:54 +0000)]
    Reviewed by Maciej.

        - tone down the assertion I asked Harrison to include in his fix for
          <rdar://problem/5511128>; it's OK to re-ref and deref the document
          as long as you do so after the children are done being destroyed

        No effect on release builds. Assertion change only.

        Besides the changes listed below, renamed m_hasDeleted flag to
        m_deletionHasBegun.

        * dom/ContainerNode.cpp: (WebCore::ContainerNode::removeAllChildren):
        Added code to set the m_deletionHasBegun flag and some assertions
        that test its state.

        * dom/Document.h: Removed m_hasDeleted -- we now use m_deletionHasBegun
        in the base class TreeShared.
        * dom/Document.cpp:
        (WebCore::Document::Document): Removed initialization of m_hasDeleted.
        (WebCore::Document::removedLastRef): Added code to clear
        m_inRemovedLastRefFunction if we end up deciding not to delete this.

        * platform/Shared.h:
        (WebCore::TreeShared::TreeShared): Added m_deletionHasBegun in addition to
        m_inRemovedLastRefFunction (formerly named m_hasRemovedLastRef).
        (WebCore::TreeShared::~TreeShared): Assert that m_deletionHasBegun is true.
        (WebCore::TreeShared::ref): Assert neither flag is true.
        (WebCore::TreeShared::deref): Ditto.
        (WebCore::TreeShared::hasOneRef): Ditto.
        (WebCore::TreeShared::removedLastRef): Made private. Added code to
        set m_hasDeleted to true. Also removed cast; since this class template
        has a virtual destructor, we don't need to cast before calling delete.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoQt build fix - Mac OS X specific
staikos [Sun, 30 Sep 2007 20:13:21 +0000 (20:13 +0000)]
Qt build fix - Mac OS X specific

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Clean-up in preparation for <rdar://5505062> WebKit's version-independent...
aroben [Sun, 30 Sep 2007 01:58:28 +0000 (01:58 +0000)]
     Clean-up in preparation for <rdar://5505062> WebKit's version-independent ProgIDs contain version numbers

         Reviewed by Steve.

         * ProgIDMacros.h: Stringify the passed in class name.
         * WebKitDLL.cpp: Added a FOR_EACH_CLASS macro to ensure that our class
         lists stay in the right order, and updated uses of the *_PROGID macros
         for to take the stringification into account.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoBakefiles:
zecke [Sat, 29 Sep 2007 15:34:39 +0000 (15:34 +0000)]
Bakefiles:
2007-09-29  Holger Hans Peter Freyther  <zecke@selfish.org>

        Reviewed by Mark.

        -Fix http://bugs.webkit.org/show_bug.cgi?id=13226.
        Remove Bakefiles from svn.

        * Bakefiles/Bakefiles.bkgen: Removed.
        * Bakefiles/ChangeLog: Removed.
        * Bakefiles/Readme.txt: Removed.
        * Bakefiles/presets.bkl: Removed.
        * Bakefiles/update-file-lists.py: Removed.

JavaScriptCore:
2007-09-29  Holger Hans Peter Freyther  <zecke@selfish.org>

        Reviewed by Mark.

        -Fix http://bugs.webkit.org/show_bug.cgi?id=13226.
        Remove Bakefiles from svn.

        * JavaScriptCoreSources.bkl: Removed.
        * jscore.bkl: Removed.

WebCore:
2007-09-29  Holger Hans Peter Freyther  <zecke@selfish.org>

        Reviewed by Mark.

        -Fix http://bugs.webkit.org/show_bug.cgi?id=13226.
        Remove Bakefiles from svn.

        * Projects/gdk/webcore-gdk.bkl: Removed.
        * Projects/wx/webcore-wx.bkl: Removed.
        * WebCoreSources.bkl: Removed.
        * webcore-base.bkl: Removed.

WebKitTools
2007-09-29  Holger Hans Peter Freyther  <zecke@selfish.org>

        Reviewed by Mark.

        -Fix http://bugs.webkit.org/show_bug.cgi?id=13226.
        Remove Bakefiles from svn.

        * GtkLauncher/Bakefiles.bkgen: Removed.
        * GtkLauncher/ENV: Removed.
        * GtkLauncher/gdklauncher.bkl: Removed.
        * GtkLauncher/mk: Removed.
        * Scripts/regenerate-makefiles: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-09-28 Jan Michael Alonzo <jmalonzo@unpluggable.com>
zecke [Sat, 29 Sep 2007 15:30:20 +0000 (15:30 +0000)]
2007-09-28  Jan Michael Alonzo  <jmalonzo@unpluggable.com>

        Reviewed by Mark.

        -Fix http://bugs.webkit.org/show_bug.cgi?id=15254.

        * platform/gtk/RenderThemeGtk.cpp:
        (WebCore::RenderThemeGtk::determineState):
            - Apply state if control is readonly
            - Added state GTK_STATE_SELECTED of object is checked
            - Apply GTK_STATE_ACTIVE if RenderObject isFocused()
        (WebCore::RenderThemeGtk::paintTextField):
        (WebCore::RenderThemeGtk::gtkEntry):
            - Implemented theme-aware text field based on gtk/gtkentry.c implementation

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-09-29 Holger Hans Peter Freyther <zecke@selfish.org>
zecke [Sat, 29 Sep 2007 15:16:15 +0000 (15:16 +0000)]
2007-09-29  Holger Hans Peter Freyther  <zecke@selfish.org>

        Reviewed by Eric.

        Build fix for Mac Gtk+ and Qt builds. In revision 25798 changing
        XSLTProcessor.cpp was forgotten.

        * xml/XSLTProcessor.cpp: Use PLATFORM(MAC) instead of PLATFORM(DARWIN)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Fix <rdar://4965715> Horizontal scrollwheel scrolling moves in opposite...
aroben [Sat, 29 Sep 2007 03:58:51 +0000 (03:58 +0000)]
     Fix <rdar://4965715> Horizontal scrollwheel scrolling moves in opposite direction on Vista

         Reviewed by Sam.

         No regression test possible.

         * platform/win/WheelEventWin.cpp:
         (WebCore::PlatformWheelEvent::PlatformWheelEvent): Use a negative
         delta when scrolling right to match EventHandler's expectations (which
         are based on AppKit).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoVersioning.
bdash [Sat, 29 Sep 2007 00:38:30 +0000 (00:38 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Mark Rowe
kdecker [Fri, 28 Sep 2007 21:56:01 +0000 (21:56 +0000)]
    Reviewed by Mark Rowe

        Build fix for Mac Gtk+ and Qt builds.

        * xml/XSLStyleSheet.cpp: Use PLATFORM(MAC) instead of PLATFORM(DARWIN)
        * xml/XSLTExtensions.cpp: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin Adler.
harrison [Fri, 28 Sep 2007 21:49:55 +0000 (21:49 +0000)]
    Reviewed by Darin Adler.

        <rdar://problem/5511128> Crash closing or reloading this SVG

        * dom/ContainerNode.cpp:
        (WebCore::dispatchChildInsertionEvents):
        (WebCore::dispatchChildRemovalEvents):
        Use DocPtr instead of RefPtr, since these events are dispatched
        when the Document is being being torn down by removedLastRef().

        * dom/DocPtr.h:
        (WebCore::DocPtr::DocPtr):
        Fix longstanding typo in template so that the DocPtr(DocPtr) constructor can be used.

        * dom/Document.cpp:
        (WebCore::Document::Document):
        (WebCore::Document::removedLastRef):
        * dom/Document.h:
        (WebCore::Document::selfOnlyRef):
        (WebCore::Document::selfOnlyDeref):
        * platform/Shared.h:
        (WebCore::Shared::Shared):
        (WebCore::Shared::ref):
        (WebCore::Shared::deref):
        (WebCore::Shared::hasOneRef):
        (WebCore::TreeShared::TreeShared):
        (WebCore::TreeShared::ref):
        (WebCore::TreeShared::deref):
        (WebCore::TreeShared::hasOneRef):
        (WebCore::TreeShared::refCount):
        Add debug-only checks for a document being ref-counted while being deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
kmccullo [Fri, 28 Sep 2007 18:31:55 +0000 (18:31 +0000)]
WebCore:

        Reviewed by Darin.

        - <rdar://5261371> Nothing downloaded when exporting bookmarks from iGoogle web history
        - Implemented IWebHTTPURLResponse::allHeaderFields so that if the content disposition is "attachment" we will download the file instead of display it. Also implemented some missing functionality.

        * platform/network/ResourceResponse.cpp:
        (WebCore::ResourceResponse::isAttachment):
        * platform/network/ResourceResponse.h:

win:

        Reviewed by Darin.

        - <rdar://5261371> Nothing downloaded when exporting bookmarks from iGoogle web history
        - Implemented IWebHTTPURLResponse::allHeaderFields so that if the content disposition is "attachment" we will download the file instead of display it.  Also implemented some missing functionality.

        * HTTPHeaderPropertyBag.cpp: Added.
        (HTTPHeaderPropertyBag::HTTPHeaderPropertyBag):
        (HTTPHeaderPropertyBag::createInstance):
        (HTTPHeaderPropertyBag::setResponse):
        (HTTPHeaderPropertyBag::response):
        (HTTPHeaderPropertyBag::QueryInterface):
        (HTTPHeaderPropertyBag::AddRef):
        (HTTPHeaderPropertyBag::Release):
        (ConvertFromLPCOLESTR):
        (ConvertToVariant):
        (ConvertFromVariant):
        (HTTPHeaderPropertyBag::Read):
        (HTTPHeaderPropertyBag::Write):
        * HTTPHeaderPropertyBag.h: Added.
        * Interfaces/IWebHTTPURLResponse.idl:
        * WebKit.vcproj/WebKit.vcproj:
        * WebURLResponse.cpp:
        (WebURLResponse::allHeaderFields):
        (WebURLResponse::isAttachment):
        * WebURLResponse.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-09-26 Holger Hans Peter Freyther <zecke@selfish.org>
zecke [Fri, 28 Sep 2007 15:37:04 +0000 (15:37 +0000)]
2007-09-26  Holger Hans Peter Freyther  <zecke@selfish.org>

        Reviewed by Anders.

        Implement PopupMenu using GtkMenu.

        * platform/PopupMenu.h:
        * platform/gtk/PopupMenuGtk.cpp:
        (WebCore::PopupMenu::PopupMenu):
        (WebCore::PopupMenu::~PopupMenu):
        (WebCore::PopupMenu::show):
        (WebCore::PopupMenu::hide):
        (WebCore::PopupMenu::updateFromElement):
        (WebCore::PopupMenu::itemWritingDirectionIsNatural):
        (WebCore::PopupMenu::menuItemActivated):
        (WebCore::PopupMenu::menuUnmapped):
        (WebCore::PopupMenu::menuPositionFunction):
        (WebCore::PopupMenu::menuRemoveItem):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-09-23 Holger Hans Peter Freyther <zecke@selfish.org>
zecke [Fri, 28 Sep 2007 15:36:15 +0000 (15:36 +0000)]
2007-09-23  Holger Hans Peter Freyther  <zecke@selfish.org>

        Rubber stamped by Mark.

        Obey the Coding-Style and move the asterisk to the
        left to be part of the type.

        * platform/gtk/RenderThemeGtk.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by bdash.
antti [Fri, 28 Sep 2007 13:45:57 +0000 (13:45 +0000)]
    Reviewed by bdash.

        Use frames instead windows for these tests. Closing windows reliably is difficult in DRT.

        * http/tests/security/resources/has-custom-property.html:
        * http/tests/security/resources/no-custom-property.html:
        * http/tests/security/window-properties-clear-domain-expected.txt:
        * http/tests/security/window-properties-clear-domain.html:
        * http/tests/security/window-properties-clear-port-expected.txt:
        * http/tests/security/window-properties-clear-port.html:
        * http/tests/security/window-properties-pass-expected.txt:
        * http/tests/security/window-properties-pass.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Ollie
sullivan [Fri, 28 Sep 2007 05:56:51 +0000 (05:56 +0000)]
    Reviewed by Ollie

        - fixed <rdar://problem/5408186> REGRESSION (5522-5523.9): Safari leaks every browser window

        The leak started occurring when we removed the code to clear the delegates and the host window
        from Safari as part of the fix for 5479443. But it turns out that Safari code was masking a
        bug here in WebView: setHostWindow:nil needs to be called before setting _private->closed to
        YES, or it will do nothing at all, causing a world leak due to a circular reference between
        the window and the WebView.

        I toyed with a more complex fix, but this is the simplest one that retains the fix for 5479443
        while otherwise restoring the code order to be as close as possible to what it was before
        5479443 was fixed.

        * WebView/WebView.mm:
        (-[WebView _close]):
        Moved the call that sets _private->closed to YES to be after the code that clears the delegates
        and the host window. Added a comment about this order.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoInternal build fix
sfalken [Fri, 28 Sep 2007 05:50:58 +0000 (05:50 +0000)]
Internal build fix

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoInternal build fix
sfalken [Fri, 28 Sep 2007 05:20:28 +0000 (05:20 +0000)]
Internal build fix

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by NOBODY.
antti [Fri, 28 Sep 2007 01:28:57 +0000 (01:28 +0000)]
    Reviewed by NOBODY.

        Update tests to hopefully fix occasional failures

        * fast/dom/Window/window-early-properties.html:
        * http/tests/security/resources/has-custom-property.html:
        * http/tests/security/resources/no-custom-property.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-09-27 Mitz Pettel <mitz@webkit.org>
bdash [Fri, 28 Sep 2007 01:01:42 +0000 (01:01 +0000)]
2007-09-27  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Dave Hyatt.

        - fix http://bugs.webkit.org/show_bug.cgi?id=15262
          REGRESSION: Margin-top:18px is pushing down the multiple select list box outside the div.

        Reflected in existing tests.

        * css/html4.css: Changed listboxes to use border-box sizing, to match Firefox,
        WinIE and apparently also Safari 2.

2007-09-27  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Dave Hyatt.

        - updated tests and results for http://bugs.webkit.org/show_bug.cgi?id=15262
          REGRESSION: Margin-top:18px is pushing down the multiple select list box outside the div.

        * fast/forms/listbox-clip-expected.checksum:
        * fast/forms/listbox-clip-expected.png:
        * fast/forms/listbox-clip-expected.txt:
        * fast/forms/listbox-selection-2.html:
        * fast/forms/select-item-background-clip.html:
        * fast/forms/select-list-box-with-height-expected.checksum:
        * fast/forms/select-list-box-with-height-expected.png:
        * fast/forms/select-list-box-with-height-expected.txt:
        * fast/text/drawBidiText.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoTweaked ChangeLog comment..
kdecker [Fri, 28 Sep 2007 00:06:55 +0000 (00:06 +0000)]
Tweaked ChangeLog comment..

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Rubber stamped by John Sullivan.
kdecker [Fri, 28 Sep 2007 00:04:56 +0000 (00:04 +0000)]
    Rubber stamped by John Sullivan.

        <rdar://problem/5493093>

        * JavaScriptCore.order: Added.
        * JavaScriptCore.xcodeproj/project.pbxproj: We're changing from using an order file built by
         another team to using one we actually check into our project repository. Linker settings for
         Symbol Ordering Flags have been updated accordingly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago <rdar://problem/5493093>
kdecker [Fri, 28 Sep 2007 00:03:39 +0000 (00:03 +0000)]
    <rdar://problem/5493093>

        Rubber stamped by John Sullivan.

        * WebCore.order: Added.
        * WebCore.xcodeproj/project.pbxproj:  We're changing from using an order file built by another team to using one
         we actually check into our project repository. Linker settings for Symbol Ordering Flags have been updated
         accordingly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago <rdar://problem/5507481> Added a delegate method to inform the client
adachan [Fri, 28 Sep 2007 00:01:04 +0000 (00:01 +0000)]
    <rdar://problem/5507481> Added a delegate method to inform the client
        app that WebView has painted.

        Reviewed by Steve.

        * Interfaces/IWebUIDelegatePrivate.idl:
        * WebView.cpp:
        (WebView::updateBackingStore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
antti [Thu, 27 Sep 2007 23:56:17 +0000 (23:56 +0000)]
WebCore:

        Reviewed by Geoff.

        Fix for <rdar://problem/5499125>
        REGRESSION (r21367): After launching Kidzui beta, a webview frame fails to appear in its main window

        If window object properties were modified when it had initial empty document (synchronously after
        window.open() for example) those modifications were lost when the real document was switched in.

        Match Firefox behavior where window properties are not cleared if the inital document and the loaded one
        have matching security domains.

        Tests: fast/dom/Window/window-early-properties.html
               http/tests/security/window-properties-clear-domain.html
               http/tests/security/window-properties-clear-port.html
               http/tests/security/window-properties-pass.html

        * WebCore.exp:
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::FrameLoader):
        (WebCore::FrameLoader::init):
        (WebCore::FrameLoader::clear):
        (WebCore::FrameLoader::isSecureTransition):
        (WebCore::FrameLoader::begin):
        * loader/FrameLoader.h:
        If we are transitioning from initial empty document to the final one, do a domain security check
        between old security policy URL and new URL. If that passes don't clear script proxy and script objects.

        * bindings/js/kjs_proxy.cpp:
        (WebCore::KJSProxy::updateDocumentWrapper):
        * bindings/js/kjs_proxy.h:
        * page/Frame.cpp:
        (WebCore::Frame::setDocument):
        Since we don't always clear window properties anymore, we need to update the document property to point to
        the newly created one.

LayoutTests:

        Reviewed by Geoff.

        Tests for <rdar://problem/5499125>
        REGRESSION (r21359-21368): After launching Kidzui beta, a webview frame fails to appear in its main window

        * fast/dom/Window/window-early-properties-expected.txt: Added.
        * fast/dom/Window/window-early-properties.html: Added.
        * http/tests/security/resources/has-custom-property.html: Added.
        * http/tests/security/resources/no-custom-property.html: Added.
        * http/tests/security/window-properties-clear-domain-expected.txt: Added.
        * http/tests/security/window-properties-clear-domain.html: Added.
        * http/tests/security/window-properties-clear-port-expected.txt: Added.
        * http/tests/security/window-properties-clear-port.html: Added.
        * http/tests/security/window-properties-pass-expected.txt: Added.
        * http/tests/security/window-properties-pass.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Rubber stamped by Darin.
kdecker [Thu, 27 Sep 2007 23:53:32 +0000 (23:53 +0000)]
    Rubber stamped by Darin.

        <rdar://problem/5493093>

        * WebKit.order: Added.
        * WebKit.xcodeproj/project.pbxproj: Altered build settings to use the new order file project instead of AppleInternal.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
kdecker [Thu, 27 Sep 2007 23:18:24 +0000 (23:18 +0000)]
    Reviewed by Darin.

        <rdar://problem/5493093>

        * WebCore.xcodeproj/project.pbxproj: Removed libxslt from statically linked frameworks.
        * platform/mac/SoftLinking.h: Formatting tweakes, added SOFT_LINK_LIBRARY, and if'def for
        PLATFORM(DARWIN)
        * xml/XSLStyleSheet.cpp: Soft-linked libxslt.
        * xml/XSLTExtensions.cpp: Removed the call to xsltGenericError, and added a FIXME comment stating
        that it might be helpful to push any errors from xmlXPathNewValueTree up to the Javascript Console.
        * xml/XSLTProcessor.cpp: Soft-linked libxslt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by John.
kmccullo [Thu, 27 Sep 2007 22:55:38 +0000 (22:55 +0000)]
    Reviewed by John.

        - Updating leopard leak list to refelct bugs that have been fixed and no longer leak.

        * Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Brady.
adele [Thu, 27 Sep 2007 22:06:23 +0000 (22:06 +0000)]
    Reviewed by Brady.

        Fix for <rdar://problem/5453350> REGRESSION (r18541, Tiger only): Refreshing a cached https page does not reload CSS and JavaScript resources
        http://bugs.webkit.org/show_bug.cgi?id=15121

        * loader/FrameLoader.cpp: (WebCore::FrameLoader::addExtraFieldsToRequest): Now sets the cache policy to ReloadIgnoringCacheData.  Without setting the cache policy,
        the default policy in this case was ReturnCacheDataElseLoad.  If we're in a situation where the resource is in the cache, we want to make sure to avoid loading from the cache in this case.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoCorrection, NSURLConnection not CFURLConnection.
thatcher [Thu, 27 Sep 2007 21:26:31 +0000 (21:26 +0000)]
Correction, NSURLConnection not CFURLConnection.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
thatcher [Thu, 27 Sep 2007 21:24:26 +0000 (21:24 +0000)]
    Reviewed by Darin.

        <rdar://problem/5199546> CrashTracer: [REGRESSION] 8216 crashes in Safari at com.apple.WebCore: WebCore::ResourceHandle::client const + 6

        On Tiger CFURLConnection can sometimes call the connection:willCacheResponse: delegate method on
        a secondary thread instead of the main thread. This was never an issue before, since the implementation
        of this method was very simple and thread safe.

        The fix is to block during connection:willCacheResponse: and perform the work on the main thread.
        We need to block since this delegate method needs to return a result. If we are already on the
        main thread (which sometimes we are), the method does nothing different. If we are on a secondary
        thread, we make a mutable dictionary to hold all the arguments and later the result object.
        Then performSelectorOnMainThread:withObject: using the _callConnectionWillCacheResponseWithInfo:
        selector. This new method just pulls the arguments out for the dictionary and calls the real
        connection:willCacheResponse: delegate method (this time on the main thread). The result is stored
        in the dictionary, and when performSelectorOnMainThread:withObject: finishes the result is pulled
        out and returned.

        * platform/network/mac/ResourceHandleMac.mm:
        (-[WebCoreResourceHandleAsDelegate _callConnectionWillCacheResponseWithInfo:]):
        (-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Build fix. Ran update-webkitsysteminterface script on Tiger, because
weinig [Thu, 27 Sep 2007 16:57:14 +0000 (16:57 +0000)]
    Build fix. Ran update-webkitsysteminterface script on Tiger, because
        the resulting binary differs when built on Tiger.

        * libWebKitSystemInterface.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Update WebKitSYstemInterface for @font-face changes.
hyatt [Thu, 27 Sep 2007 16:18:39 +0000 (16:18 +0000)]
    Update WebKitSYstemInterface for @font-face changes.

        * WebKitSystemInterface.h:
        * libWebKitSystemInterface.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Update to reflect the minimal WebKitSystemInterface changes required
hyatt [Thu, 27 Sep 2007 16:10:52 +0000 (16:10 +0000)]
    Update to reflect the minimal WebKitSystemInterface changes required
        to support @font-face.

        Reviewed by john

        * platform/mac/FontDataMac.mm:
        (WebCore::FontData::platformInit):
        (WebCore::FontData::platformWidthForGlyph):
        * platform/mac/WebCoreSystemInterface.h:
        * platform/mac/WebCoreSystemInterface.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Remove a test that was probably only intermittently failing
aroben [Thu, 27 Sep 2007 04:01:06 +0000 (04:01 +0000)]
    Remove a test that was probably only intermittently failing

        Reviewed by NOBODY.

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-09-26 Mark Rowe <mrowe@apple.com>
bdash [Thu, 27 Sep 2007 01:30:37 +0000 (01:30 +0000)]
2007-09-26  Mark Rowe  <mrowe@apple.com>

        Qt build fix.

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::objectContentType): Check for empty URL instead of invalid URL.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-09-26 Mark Rowe <mrowe@apple.com>
bdash [Thu, 27 Sep 2007 01:29:14 +0000 (01:29 +0000)]
2007-09-26  Mark Rowe  <mrowe@apple.com>

        Gtk build fix.

        * WebCoreSupport/FrameLoaderClientGtk.cpp:  Check for empty URL instead of invalid URL.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - fix Windows build
darin [Thu, 27 Sep 2007 01:24:47 +0000 (01:24 +0000)]
    - fix Windows build

        * platform/win/ClipboardWin.cpp:
        (WebCore::writeURL): Add a check for empty URL. Remove the check for invalid URL.
        (WebCore::ClipboardWin::setData): Remove the check for invalid URL.
        * plugins/win/PluginViewWin.cpp:
        (WebCore::PluginViewWin::start): Check for empty URL instead of invalid URL.
        (WebCore::PluginViewWin::load): Same here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by John Sullivan.
darin [Thu, 27 Sep 2007 00:56:36 +0000 (00:56 +0000)]
    Reviewed by John Sullivan.

        - fix <rdar://problem/5491054> REGRESSION (Mail, plain-text only): Nothing happens
          when you click on rdar://<num>&<num> links (or AOL links in Safari)

        Remove the non-useful concept of a "malformed"/"invalid" URL.

        There are URLs we can parse, and others we can't, but that's not sufficient to
        determine if we should try to work with the URL. It's entirely possible that
        a so-called "malformed" URL will work just fine if it's passed to the right
        software.

        * platform/KURL.h: Removed isMalformed() and isValid().

        * loader/Cache.cpp: (WebCore::Cache::requestResource): Removed unneeded check
        if the URL is valid. But do check for an empty URL just to guarantee we don't
        trip up with a null string. It's possible we can remove this empty URL check
        later, but it's less risky to leave the empty string behavior alone for now.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::urlSelected): Removed unneeded check if the URL is valid.
        Back on 2007-07-08, we realized that we needed to allow empty URLs. But we also
        need to allow other URLs here. This is the code path from the Mail case.
        (WebCore::FrameLoader::submitForm): Replaced URL validity check with a check
        for an empty URL (same reasoning as for requestResource above).

        * page/InspectorController.cpp: (WebCore::InspectorResource::type):
        * rendering/RenderObject.cpp: (WebCore::RenderObject::addPDFURLRect):
        Removed unneeded check for an invalid URL. In both of these cases it's definitely
        safe to allow event an empty URL.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adele Peterson.
ggaren [Wed, 26 Sep 2007 23:26:27 +0000 (23:26 +0000)]
    Reviewed by Adele Peterson.

        Fixed <rdar://problem/5507476> Promote cache model SPI to API

        Promoted cache model SPI to API. This was just a move, with some small
        edits to the documentation (changing 'application' to 'WebView' in
        some cases, since the interface is now per-WebView).

        * WebView/WebPreferences.h:
        * WebView/WebPreferences.m:
        (-[WebPreferences setCacheModel:]):
        (-[WebPreferences cacheModel]):
        * WebView/WebPreferencesPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@25768 268f45cc-cd09-0410-ab3c-d52691b4dbfc