WebKit-https.git
10 years ago2011-05-30 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Tue, 31 May 2011 04:03:56 +0000 (04:03 +0000)]
2011-05-30  Daniel Bates  <dbates@webkit.org>

        Reviewed by Adam Barth.

        Rename XSSFilter to XSSAuditor
        https://bugs.webkit.org/show_bug.cgi?id=61718

        Currently we use the names XSSFilter and XSSAuditor throughout the project.
        Instead, we should choose one name for consistency.

        No functionality was changed. So, no new tests.

        * XSSAuditor: Copied from PerformanceTests/XSSFilter.
        * XSSFilter: Removed.
        * XSSFilter/large-post-many-events.html: Removed.
        * XSSFilter/large-post-many-inline-scripts-and-events.html: Removed.
        * XSSFilter/resources: Removed.
        * XSSFilter/resources/target-for-large-post-many-inline-scripts-and-events.html: Removed.
2011-05-30  Daniel Bates  <dbates@webkit.org>

        Reviewed by Adam Barth.

        Rename XSSFilter to XSSAuditor
        https://bugs.webkit.org/show_bug.cgi?id=61718

        Currently we use the names XSSFilter and XSSAuditor throughout the project.
        Instead, we should choose one name for consistency.

        No functionality was changed. So, no new tests.

        * CMakeLists.txt:
        * GNUmakefile.list.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * html/parser/HTMLDocumentParser.cpp:
        (WebCore::HTMLDocumentParser::HTMLDocumentParser):
        (WebCore::HTMLDocumentParser::pumpTokenizer):
        * html/parser/HTMLDocumentParser.h:
        * html/parser/XSSAuditor.cpp: Copied from Source/WebCore/html/parser/XSSFilter.cpp.
        (WebCore::XSSAuditor::XSSAuditor):
        (WebCore::XSSAuditor::init):
        (WebCore::XSSAuditor::filterToken):
        (WebCore::XSSAuditor::filterTokenInitial):
        (WebCore::XSSAuditor::filterTokenAfterScriptStartTag):
        (WebCore::XSSAuditor::filterScriptToken):
        (WebCore::XSSAuditor::filterObjectToken):
        (WebCore::XSSAuditor::filterParamToken):
        (WebCore::XSSAuditor::filterEmbedToken):
        (WebCore::XSSAuditor::filterAppletToken):
        (WebCore::XSSAuditor::filterIframeToken):
        (WebCore::XSSAuditor::filterMetaToken):
        (WebCore::XSSAuditor::filterBaseToken):
        (WebCore::XSSAuditor::filterFormToken):
        (WebCore::XSSAuditor::eraseDangerousAttributesIfInjected):
        (WebCore::XSSAuditor::eraseAttributeIfInjected):
        (WebCore::XSSAuditor::snippetForRange):
        (WebCore::XSSAuditor::snippetForAttribute):
        (WebCore::XSSAuditor::isContainedInRequest):
        (WebCore::XSSAuditor::isSameOriginResource):
        * html/parser/XSSAuditor.h: Copied from Source/WebCore/html/parser/XSSFilter.h.
        * html/parser/XSSFilter.cpp: Removed.
        * html/parser/XSSFilter.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-30 No'am Rosenthal <noam.rosenthal@nokia.com>
noam.rosenthal@nokia.com [Tue, 31 May 2011 02:21:49 +0000 (02:21 +0000)]
2011-05-30  No'am Rosenthal  <noam.rosenthal@nokia.com>

        Reviewed by Simon Hausmann.

        WebKit2: Enable serializing of data types needed for cross-process accelerated compositing
        https://bugs.webkit.org/show_bug.cgi?id=61694

        Expose a public clearAll() function to reset WebCore::Animation.

        No new functionality, so no new tests.

        * platform/animation/Animation.h:
        (WebCore::Animation::clearAll):
2011-05-30  No'am Rosenthal  <noam.rosenthal@nokia.com>

        Reviewed by Simon Hausmann.

        WebKit2: Enable serializing of data types needed for cross-process accelerated compositing
        https://bugs.webkit.org/show_bug.cgi?id=61694

        Create an ArgumentCoder for WebCore::Animation.

        * Scripts/webkit2/messages.py:
        * Shared/WebCoreArgumentCoders.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-30 Raphael Kubo da Costa <kubo@profusion.mobi>
commit-queue@webkit.org [Tue, 31 May 2011 02:18:05 +0000 (02:18 +0000)]
2011-05-30  Raphael Kubo da Costa  <kubo@profusion.mobi>

        Reviewed by Kent Tamura.

        [efl] Fix _ewk_frame_children_iterator_next().
        https://bugs.webkit.org/show_bug.cgi?id=61749

        The iterator was returning always the first child, making tests like
        fast/history/history-back-initial-vs-final-url.html to timeout and
        eventually run out of memory.

        * ewk/ewk_frame.cpp:
        (_ewk_frame_children_iterator_next):
        (ewk_frame_children_iterator_new):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-30 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Tue, 31 May 2011 02:04:53 +0000 (02:04 +0000)]
2011-05-30  Kent Tamura  <tkent@chromium.org>

        [Mac] Skip a flaky test: svg/zoom/page/zoom-svg-through-object-with-text.xhtml

        * platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-30 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Tue, 31 May 2011 01:44:55 +0000 (01:44 +0000)]
2011-05-30  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Alexey Proskuryakov.

        Audio and video files saved to the Application Cache should preserve the original file extension
        https://bugs.webkit.org/show_bug.cgi?id=61750
        <rdar://9524922>

        No new tests, it isn't possible to check the name of the file in the cache from within
        DRT. Changes verified manually.

        * loader/appcache/ApplicationCacheStorage.cpp:
        (WebCore::ApplicationCacheStorage::store): Append the original file extension to the cache
            file name.
        (WebCore::ApplicationCacheStorage::writeDataToUniqueFileInDirectory): Add extension parameter.
        * loader/appcache/ApplicationCacheStorage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-30 Jer Noble <jer.noble@apple.com>
jer.noble@apple.com [Tue, 31 May 2011 00:05:02 +0000 (00:05 +0000)]
2011-05-30  Jer Noble  <jer.noble@apple.com>

        Reviewed by Dan Bernstein.

        Play/Pause button in wrong state when entering full screen on Vimeo
        https://bugs.webkit.org/show_bug.cgi?id=61754

        Update the play/pause button inside reset().  This ensures the button is in
        the correct state when the controls are created after playback has already
        started.

        * html/shadow/MediaControlRootElement.cpp:
        (WebCore::MediaControlRootElement::reset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-30 Hojong Han <hojong.han@samsung.com>
commit-queue@webkit.org [Mon, 30 May 2011 23:49:51 +0000 (23:49 +0000)]
2011-05-30  Hojong Han  <hojong.han@samsung.com>

        Reviewed by Geoffrey Garen.

        [JSC] malfunction during arithmetic condition check with negative number (-2147483648)
        https://bugs.webkit.org/show_bug.cgi?id=61416

        * assembler/MacroAssemblerARM.h:
        (JSC::MacroAssemblerARM::branch32):
        * tests/mozilla/ecma/Expressions/11.12-1.js:
        (getTestCases):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-30 No'am Rosenthal <noam.rosenthal@nokia.com>
noam.rosenthal@nokia.com [Mon, 30 May 2011 23:43:58 +0000 (23:43 +0000)]
2011-05-30  No'am Rosenthal  <noam.rosenthal@nokia.com>

        Reviewed by Simon Hausmann.

        WebKit2: Enable serializing of data types needed for cross-process accelerated compositing
        https://bugs.webkit.org/show_bug.cgi?id=61694

        Added a public TimingFunction::type() method.

        No new functionality, so no new tests.

        * platform/animation/TimingFunction.h:
        (WebCore::TimingFunction::type):
2011-05-30  No'am Rosenthal  <noam.rosenthal@nokia.com>

        Reviewed by Simon Hausmann.

        WebKit2: Enable serializing of data types needed for cross-process accelerated compositing
        https://bugs.webkit.org/show_bug.cgi?id=61694

        Add an ArgumentCoder for WebCore::TimingFunction. This serializer can create the appropriate
        TimingFunction subclass based on the type of timing function.

        * Scripts/webkit2/messages.py:
        * Shared/WebCoreArgumentCoders.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-30 Noam Rosenthal <noam.rosenthal@nokia.com>
noam.rosenthal@nokia.com [Mon, 30 May 2011 22:29:50 +0000 (22:29 +0000)]
2011-05-30  Noam Rosenthal  <noam.rosenthal@nokia.com>

        BUILD FIX for r87697 on Windows/Symbian

        For now enabling TextureMapper for Mac/Linux only.

        * WebCore.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-30 No'am Rosenthal <noam.rosenthal@nokia.com>
noam.rosenthal@nokia.com [Mon, 30 May 2011 22:02:57 +0000 (22:02 +0000)]
2011-05-30  No'am Rosenthal  <noam.rosenthal@nokia.com>

        Reviewed by Simon Hausmann.

        WebKit2: Enable serializing of data types needed for cross-process accelerated compositing
        https://bugs.webkit.org/show_bug.cgi?id=61694

        Add WebCore::Length and WebCore::TransformationMatrix to the types that use SimpleArgumentCoder.

        * Scripts/webkit2/messages.py:
        * Shared/WebCoreArgumentCoders.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBUILD FIX for r87692 with !ENABLE(FULLSCREEN_API)
ddkilzer@apple.com [Mon, 30 May 2011 22:00:57 +0000 (22:00 +0000)]
BUILD FIX for r87692 with !ENABLE(FULLSCREEN_API)

* dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::determineDispatchBehavior): Mark
shadowRoot as an unused parameter with !ENABLE(FULLSCREEN_API).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-30 No'am Rosenthal <noam.rosenthal@nokia.com>
noam.rosenthal@nokia.com [Mon, 30 May 2011 20:57:18 +0000 (20:57 +0000)]
2011-05-30  No'am Rosenthal  <noam.rosenthal@nokia.com>

        Reviewed by Andreas Kling.

        [Texmap][Qt] Enable TextureMapper by default
        https://bugs.webkit.org/show_bug.cgi?id=61740

        Make CONFIG+=texmap an opt-out instead of an opt-in.

        No new functionality so no new tests.

        * WebCore.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-30 Martin Robinson <mrobinson@igalia.com>
commit-queue@webkit.org [Mon, 30 May 2011 20:08:51 +0000 (20:08 +0000)]
2011-05-30  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] fast/css/font-face-zero-hash-key.html is crashing on the bots
        https://bugs.webkit.org/show_bug.cgi?id=61693

        * platform/gtk/Skipped: Unskip the test which is no longer crashing.
2011-05-30  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] fast/css/font-face-zero-hash-key.html is crashing on the bots
        https://bugs.webkit.org/show_bug.cgi?id=61693

        Do not try to read the FT_Face from m_scaledFont if it m_scaledFont is
        null. A recent change fixing 0-pixel-size fonts means that m_scaledFont
        may now be null.

        No new tests. This change should cause fast/css/font-face-zero-hash-key.html
        to stop crashing.

        * platform/graphics/freetype/FontPlatformDataFreeType.cpp:
        (WebCore::FontPlatformData::FontPlatformData): Do a null check before accessing
        m_scaledFont.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-30 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
caio.oliveira@openbossa.org [Mon, 30 May 2011 19:02:21 +0000 (19:02 +0000)]
2011-05-30  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>

        Reviewed by Andreas Kling.

        [Qt] Fix unnecessary wait in API autotest tst_QWebFrame::scrollbarsOff
        https://bugs.webkit.org/show_bug.cgi?id=61711

        The loadFinished() signal was emitted directly inside the call for setHtml, so
        the test was waiting the loadFinished() signal with a big timeout. Change this by
        a very small timeout and a verification with signal spy.

        In practice, setHtml() will either directly call loadFinished() or queue it to
        the next event loop run, and test will work for both situations.

        * tests/qwebframe/tst_qwebframe.cpp:
        (tst_QWebFrame::scrollbarsOff):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-30 Noam Rosenthal <noam.rosenthal@nokia.com>
noam.rosenthal@nokia.com [Mon, 30 May 2011 18:28:08 +0000 (18:28 +0000)]
2011-05-30  Noam Rosenthal  <noam.rosenthal@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Texmap][Qt] Disable accelerated plugins/media until they're working.
        https://bugs.webkit.org/show_bug.cgi?id=61687

        Until this works properly, we should indicate that our media implementation
        in texture mapper doesn't support accelerated compositing.

        This makes LayoutTests/compositing/video/* work again.

        * platform/graphics/qt/MediaPlayerPrivateQt.h:
        (WebCore::MediaPlayerPrivateQt::supportsAcceleratedRendering):
        (WebCore::MediaPlayerPrivateQt::platformLayer):
2011-05-30  Noam Rosenthal  <noam.rosenthal@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Texmap][Qt] Disable accelerated plugins/media in until they're working.
        https://bugs.webkit.org/show_bug.cgi?id=61687

        Turn off accelerated compositing for media and plugins when in texture-mapper.

        * Api/qwebsettings.cpp:
        (QWebSettingsPrivate::apply):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-30 Mikhail Naganov <mnaganov@chromium.org>
abarth@webkit.org [Mon, 30 May 2011 17:21:14 +0000 (17:21 +0000)]
2011-05-30  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Adam Barth.

        [Chromium] Fix regression after r87628.
        https://bugs.webkit.org/show_bug.cgi?id=61733

        Having r87628 in place, Chrome reliability bot crashes in
        WebCore::HTMLLinkElement::onloadTimerFired.

        This is because the change makes WebCore::CachedResource::setRequest to
        call checkNotify on request reset.  HTMLLinkElement registers itself as
        CachedResource client via m_cachedSheet, which can happen even if
        m_cachedLinkResource wasn't set.  As a result,
        WebCore::HTMLLinkElement::notifyFinished is got called with unset
        m_cachedLinkResource, which causes a crash in
        HTMLLinkElement::onloadTimerFired

        * html/HTMLLinkElement.cpp:
        (WebCore::HTMLLinkElement::notifyFinished):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-30 Jer Noble <jer.noble@apple.com>
darin@apple.com [Mon, 30 May 2011 17:09:48 +0000 (17:09 +0000)]
2011-05-30  Jer Noble  <jer.noble@apple.com>

        Reviewed by Darin Adler and Simon Fraser.

        REGRESSION (r87622): Scrubbing a Vimeo movie when in fullscreen stops playback; no way to make it start again
        https://bugs.webkit.org/show_bug.cgi?id=61717
        rdar://problem/9522272

        May be some good way to test this later. No immediate idea about the best way.

        When a media element is taken into full-screen mode, stop events from propagating
        outside the media element's shadow DOM, EventDispatcher::determineDispatchBehavior()
        has been changed to take a shadow root node. In our full screen media element check,
        we check to see if the passed shadow root is the shadow root of the full screen media
        element, and if so, specify events should StayInsideShadowDOM. The end result is that
        inside EventDispatcher::ensureEventAncestors, an ancestor chain is built up all the
        way from the SliderThumb to the video element's shadow root, but no further.

        * dom/EventDispatcher.cpp:
        (WebCore::EventDispatcher::determineDispatchBehavior): Restrict events to the
        shadow DOM when showing a full screen video.

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::HTMLMediaElement): Removed code to manage full screen controls.
        The events telling us about activity in the shadow DOM no longer bubble out so we need to
        handle this inside the shadow DOM on the root element.
        (WebCore::HTMLMediaElement::play): Ditto.
        (WebCore::HTMLMediaElement::playbackProgressTimerFired): Ditto.
        (WebCore::HTMLMediaElement::defaultEventHandler): Ditto.
        (WebCore::HTMLMediaElement::enterFullscreen): Ditto.
        (WebCore::HTMLMediaElement::exitFullscreen): Ditto.
        * html/HTMLMediaElement.h: Added isPlaying function, removed things moved to the root element.

        * html/shadow/MediaControlElements.cpp:
        (WebCore::MediaControlVolumeSliderContainerElement::defaultEventHandler): Rolled out
        changes that tried to make special rules for events using preDispatchEventHandler and such.
        This rolls out both r87622 and r87655.
        (WebCore::MediaControlMuteButtonElement::defaultEventHandler): Ditto.
        (WebCore::MediaControlPanelMuteButtonElement::defaultEventHandler): Ditto.
        (WebCore::MediaControlPlayButtonElement::defaultEventHandler): Ditto.
        (WebCore::MediaControlSeekButtonElement::defaultEventHandler): Ditto.
        (WebCore::MediaControlRewindButtonElement::defaultEventHandler): Ditto.
        (WebCore::MediaControlReturnToRealtimeButtonElement::defaultEventHandler): Ditto.
        (WebCore::MediaControlToggleClosedCaptionsButtonElement::defaultEventHandler): Ditto.
        (WebCore::MediaControlTimelineElement::defaultEventHandler): Ditto.
        (WebCore::MediaControlVolumeSliderElement::defaultEventHandler): Ditto.
        (WebCore::MediaControlFullscreenButtonElement::defaultEventHandler): Ditto.
        (WebCore::MediaControlFullscreenVolumeMinButtonElement::defaultEventHandler): Ditto.
        (WebCore::MediaControlFullscreenVolumeMaxButtonElement::defaultEventHandler): Ditto.
        * html/shadow/MediaControlElements.h: Ditto.

        * html/shadow/MediaControlRootElement.cpp:
        (WebCore::MediaControlRootElement::MediaControlRootElement): Initialize new data members.
        (WebCore::MediaControlRootElement::playbackStarted): Start the timer so we will consider
        hiding the controls later.
        (WebCore::MediaControlRootElement::playbackProgressed): Hide the controls if the mouse
        is no longer over the controls.
        (WebCore::MediaControlRootElement::playbackStopped): Stop the timer since we only hide
        automatically if we're playing.
        (WebCore::MediaControlRootElement::enteredFullscreen): Start the timer.
        (WebCore::MediaControlRootElement::exitedFullscreen): Stop the timer since we only care
        if we are full screen.
        (WebCore::MediaControlRootElement::containsRelatedTarget): Added. Helper for next function.
        (WebCore::MediaControlRootElement::defaultEventHandler): Do the hide/show and timer functions
        as the mouse is moved in and out.
        (WebCore::MediaControlRootElement::startHideFullscreenControlsTimer): Start the timer if
        needed.
        (WebCore::MediaControlRootElement::hideFullscreenControlsTimerFired): Hide if the conditions
        are met.
        (WebCore::MediaControlRootElement::stopHideFullscreenControlsTimer): Stop the timer.

        * html/shadow/MediaControlRootElement.h: Added new functions and data members.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-30 Gavin Peters <gavinp@chromium.org>
abarth@webkit.org [Mon, 30 May 2011 17:05:37 +0000 (17:05 +0000)]
2011-05-30  Gavin Peters  <gavinp@chromium.org>

        Reviewed by Adam Barth.

        prevent HTMLLinkElement from watching multiple CachedResources
        https://bugs.webkit.org/show_bug.cgi?id=61686

        If we modify an existing link element, stop listening to the previous
        cached resource, to prevent double notifications (which crash).

        Test: fast/dom/HTMLLinkElement/prefetch-too-many-clients.html

        * html/HTMLLinkElement.cpp:
        (WebCore::HTMLLinkElement::process):
2011-05-30  Gavin Peters  <gavinp@chromium.org>

        Reviewed by Adam Barth.

        prevent HTMLLinkElement from watching multiple CachedResources
        https://bugs.webkit.org/show_bug.cgi?id=61686

        If we modify an existing link element, stop listening to the previous
        cached resource, to prevent double notifications (which crash).

        * fast/dom/HTMLLinkElement/prefetch-too-many-clients-expected.txt: Added.
        * fast/dom/HTMLLinkElement/prefetch-too-many-clients.html: Added.
        * platform/gtk/Skipped:
        * platform/mac/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-30 Carlos Garcia Campos <cgarcia@igalia.com>
carlosgc@webkit.org [Mon, 30 May 2011 16:25:06 +0000 (16:25 +0000)]
2011-05-30  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Implement JavaScript dialogs in MiniBrowser
        https://bugs.webkit.org/show_bug.cgi?id=61725

        * MiniBrowser/gtk/BrowserWindow.c:
        (WKStringGetCString): Helper function to get a UTF-8 c string from
        a WKStringRef.
        (WKURLGetCString): Helper function to get a UTF-8 c string from a
        WKURLRef.
        (browserWindowUpdateURL): Update to use WKURLGetCString.
        (didReceiveTitleForFrame): Update to use WKStringGetCString.
        (createMessageDialog): Create a GtkMessageDialog.
        (runJavaScriptAlert):
        (runJavaScriptConfirm):
        (runJavaScriptPrompt):
        (browserWindowUIClientInit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-30 Anders Carlsson <andersca@apple.com>
carlosgc@webkit.org [Mon, 30 May 2011 16:17:56 +0000 (16:17 +0000)]
2011-05-30  Anders Carlsson  <andersca@apple.com>

        Reviewed by Simon Fraser.

        Remove incorrect asserts from PluginProcessConnection
        https://bugs.webkit.org/show_bug.cgi?id=61731

        There might be pending incoming messages from a PluginProxy even though we've
        destroyed the plug-in and removed it from the m_plugins map, so remove the incorrect assertions.

        * WebProcess/Plugins/PluginProcessConnection.cpp:
        (WebKit::PluginProcessConnection::didReceiveMessage):
        (WebKit::PluginProcessConnection::didReceiveSyncMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-30 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 30 May 2011 16:14:29 +0000 (16:14 +0000)]
2011-05-30  Anders Carlsson  <andersca@apple.com>

        Reviewed by Simon Fraser.

        Remove incorrect asserts from PluginProcessConnection
        https://bugs.webkit.org/show_bug.cgi?id=61731

        There might be pending incoming messages from a PluginProxy even though we've
        destroyed the plug-in and removed it from the m_plugins map, so remove the incorrect assertions.

        * WebProcess/Plugins/PluginProcessConnection.cpp:
        (WebKit::PluginProcessConnection::didReceiveMessage):
        (WebKit::PluginProcessConnection::didReceiveSyncMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-30 Peter Varga <pvarga@webkit.org>
pvarga@webkit.org [Mon, 30 May 2011 15:44:02 +0000 (15:44 +0000)]
2011-05-30  Peter Varga  <pvarga@webkit.org>

        Unreviewed build fix.

        [Qt][V8] Fix debug build.

        No new tests needed.

        * css/CSSStyleDeclaration.cpp: Add missing header.
        * dom/Text.cpp: Ditto.
        * rendering/InlineTextBox.cpp: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-30 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Mon, 30 May 2011 14:50:13 +0000 (14:50 +0000)]
2011-05-30  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r87683.
        http://trac.webkit.org/changeset/87683
        https://bugs.webkit.org/show_bug.cgi?id=61729

        Breaks inspector tests on Chromium (Requested by apavlov on
        #webkit).

        * http/tests/inspector/inspect-iframe-from-different-domain.html:
        * inspector/elements/elements-delete-inline-style.html:
        * inspector/elements/elements-panel-styles.html:
        * inspector/styles/styles-iframe.html:
        * inspector/styles/styles-update-from-js-expected.txt:
        * inspector/styles/styles-update-from-js.html:
        * inspector/styles/styles-url-linkify.html:
2011-05-30  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r87683.
        http://trac.webkit.org/changeset/87683
        https://bugs.webkit.org/show_bug.cgi?id=61729

        Breaks inspector tests on Chromium (Requested by apavlov on
        #webkit).

        * inspector/front-end/StylesSidebarPane.js:
        (WebInspector.StylesSidebarPane.prototype.update):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-30 Carlos Garcia Campos <cgarcia@igalia.com>
carlosgc@webkit.org [Mon, 30 May 2011 14:13:32 +0000 (14:13 +0000)]
2011-05-30  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Remove some unneeded header includes
        https://bugs.webkit.org/show_bug.cgi?id=60536

        * Platform/CoreIPC/Connection.cpp: Remove WebProcess.h.
        * Platform/CoreIPC/unix/ConnectionUnix.cpp: Remove
        ProcessLauncher.h and WebProcessProxy.h. Add <wtf/OwnArrayPtr.h>.
        * WebProcess/Plugins/Netscape/NPJSObject.cpp: Remove PluginView.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Remove passing tests from ARM Skipped list
rgabor@webkit.org [Mon, 30 May 2011 14:06:58 +0000 (14:06 +0000)]
[Qt] Remove passing tests from ARM Skipped list

Rubber-stamped by Csaba Osztrogonác.

* platform/qt-arm/Skipped:
* platform/qt-arm/fast: Removed.
* platform/qt-arm/fast/block: Removed.
* platform/qt-arm/fast/block/float: Removed.
* platform/qt-arm/fast/block/float/float-not-removed-from-next-sibling-expected.txt: Removed.
* platform/qt-arm/fast/block/float/float-not-removed-from-next-sibling2-expected.txt: Removed.
* platform/qt-arm/fast/block/float/float-not-removed-from-next-sibling3-expected.txt: Removed.
* platform/qt-arm/fast/block/float/float-not-removed-from-next-sibling4-expected.txt: Removed.
* platform/qt-arm/fast/transforms: Removed.
* platform/qt-arm/fast/transforms/transform-positioned-ancestor-expected.txt: Removed.
* platform/qt-arm/transforms: Removed.
* platform/qt-arm/transforms/2d: Removed.
* platform/qt-arm/transforms/2d/compound-transforms-vs-containers-expected.txt: Removed.
* platform/qt-arm/transforms/2d/transform-borderbox-expected.txt: Removed.
* platform/qt-arm/transforms/2d/transform-origin-borderbox-expected.txt: Removed.
* platform/qt-arm/transforms/2d/zoom-menulist-expected.txt: Removed.
* platform/qt-arm/transforms/no_transform_hit_testing-expected.txt: Removed.
* platform/qt-arm/transforms/svg-vs-css-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-27 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Mon, 30 May 2011 13:48:09 +0000 (13:48 +0000)]
2011-05-27  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: node selection is slow in the Elements panel.
        https://bugs.webkit.org/show_bug.cgi?id=60813

        * http/tests/inspector/inspect-iframe-from-different-domain.html:
        * inspector/elements/elements-delete-inline-style.html:
        * inspector/elements/elements-panel-styles.html:
        * inspector/styles/styles-iframe.html:
        * inspector/styles/styles-update-from-js.html:
        * inspector/styles/styles-update-from-js-expected.txt:
        * inspector/styles/styles-url-linkify.html:
2011-05-25  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: node selection is slow in the Elements panel.
        https://bugs.webkit.org/show_bug.cgi?id=60813

        Schedule full style updates rather than request all node styles from the backend up front.

        * inspector/front-end/StylesSidebarPane.js:
        (WebInspector.StylesSidebarPane.prototype.update.reloadAllStyles):
        (WebInspector.StylesSidebarPane.prototype.update):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-30 Mikhail Naganov <mnaganov@chromium.org>
mnaganov@chromium.org [Mon, 30 May 2011 10:36:55 +0000 (10:36 +0000)]
2011-05-30  Mikhail Naganov  <mnaganov@chromium.org>

        Unreviewed.
        [Chromium] Rebaseline tests after r87680.

        * platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png: Added.
        * platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png: Added.
        * platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png: Added.
        * platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png: Added.
        * platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png: Added.
        * platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png: Added.
        * platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png: Added.
        * platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png: Added.
        * platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png: Added.
        * platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.png: Added.
        * platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.png: Added.
        * platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.png: Added.
        * platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.png: Added.
        * platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.png: Added.
        * platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.png: Added.
        * platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.png: Added.
        * platform/chromium-linux-x86/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png: Added.
        * platform/chromium-linux-x86/svg/filters/feConvolveFilter-y-bounds-expected.png: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png:
        * platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png:
        * platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png:
        * platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png:
        * platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png:
        * platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png:
        * platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png:
        * platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png:
        * platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png:
        * platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.png:
        * platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.png:
        * platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.png:
        * platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.png:
        * platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.png:
        * platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.png:
        * platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.png:
        * platform/chromium-linux/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png:
        * platform/chromium-linux/svg/filters/feConvolveFilter-y-bounds-expected.png: Added.
        * platform/chromium-mac-leopard/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png:
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png:
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png:
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png:
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png:
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png:
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png:
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png:
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png:
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.png:
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.png:
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.png:
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.png:
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.png:
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.png:
        * platform/chromium-mac-leopard/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png:
        * platform/chromium-mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png: Added.
        * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.png:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.png:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.png:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.png:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.png:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.png:
        * platform/chromium-mac/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png:
        * platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-bias-attr-expected.png: Added.
        * platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-divisor-attr-expected.png: Added.
        * platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-edgeMode-attr-expected.png: Added.
        * platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-in-attr-expected.png: Added.
        * platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelMatrix-attr-expected.png: Added.
        * platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-kernelUnitLength-attr-expected.png: Added.
        * platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-order-attr-expected.png: Added.
        * platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-preserveAlpha-attr-expected.png: Added.
        * platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-dom-targetX-attr-expected.png: Added.
        * platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-bias-prop-expected.png: Added.
        * platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-divisor-prop-expected.png: Added.
        * platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-edgeMode-prop-expected.png: Added.
        * platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-in-prop-expected.png: Added.
        * platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelMatrix-prop-expected.png: Added.
        * platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-kernelUnitLength-prop-expected.png: Added.
        * platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-order-prop-expected.png: Added.
        * platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-preserveAlpha-prop-expected.png: Added.
        * platform/chromium-win-vista/svg/dynamic-updates/SVGFEConvolveMatrixElement-svgdom-targetX-prop-expected.png: Added.
        * platform/chromium-win-vista/svg/filters/feConvolveFilter-y-bounds-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago011-05-30 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Mon, 30 May 2011 09:18:16 +0000 (09:18 +0000)]
011-05-30  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: do not issue frontendReused for reload or navigation.
        https://bugs.webkit.org/show_bug.cgi?id=61192

       - only issue frontendReused when inspector is attached after main resource committed load
       - upon committing loading main resource, reset agents before sending FrameNavigated to page agent
       - Ensure main resource is set early so that abbreviations of URLs in resource tree are consistent after reload
       - do not enable agents explicitly in frontendReused (this is done by backend when resotring state from cookie)

        * inspector/InspectorAgent.cpp:
        (WebCore::InspectorAgent::InspectorAgent):
        (WebCore::InspectorAgent::restore):
        (WebCore::InspectorAgent::clearFrontend):
        (WebCore::InspectorAgent::didCommitLoad):
        * inspector/InspectorAgent.h:
        * inspector/InspectorInstrumentation.cpp:
        (WebCore::InspectorInstrumentation::didCommitLoadImpl):
        * inspector/front-end/NetworkManager.js:
        * inspector/front-end/ResourceTreeModel.js:
        (WebInspector.ResourceTreeModel.prototype._processCachedResources):
        (WebInspector.ResourceTreeModel.prototype._frameNavigated):
        (WebInspector.ResourceTreeModel.prototype._cleanupFramesAfterNavigation):
        (WebInspector.ResourceTreeModel.prototype._addFramesRecursively):
        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.ResourcesPanel.prototype.reset):
        (WebInspector.ResourcesPanel.prototype._resetResourcesTree):
        (WebInspector.DatabaseTreeElement.prototype.onpopulate):
        (WebInspector.SearchResultsTreeElementsTraverser.prototype._lastTreeElement):
        * inspector/front-end/inspector.js:
        (WebInspector.reset):
        (WebInspector.frontendReused):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-30 Ryan Sleevi <rsleevi@chromium.org>
commit-queue@webkit.org [Mon, 30 May 2011 08:30:17 +0000 (08:30 +0000)]
2011-05-30  Ryan Sleevi  <rsleevi@chromium.org>

        Reviewed by Darin Adler.

        FEConvolveMatrix::getPixelValue() fails to properly check if y is within bounds, causing it to fail to correctly apply the kernel and edge mode to the first targetY pixels
        https://bugs.webkit.org/show_bug.cgi?id=61603

        * platform/mac/svg/filters/feConvolveFilter-y-bounds-expected.png: Added.
        * platform/mac/svg/filters/feConvolveFilter-y-bounds-expected.txt: Added.
        * svg/filters/feConvolveFilter-y-bounds.svg: Added.
2011-05-30  Ryan Sleevi  <rsleevi@chromium.org>

        Reviewed by Darin Adler.

        FEConvolveMatrix::getPixelValue() fails to properly check if y is within bounds, causing it to fail to correctly apply the kernel and edge mode to the first targetY pixels
        https://bugs.webkit.org/show_bug.cgi?id=61603

        Test: svg/filters/feConvolveFilter-y-bounds.svg

        * platform/graphics/filters/FEConvolveMatrix.cpp:
        (WebCore::FEConvolveMatrix::getPixelValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-30 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Mon, 30 May 2011 07:45:41 +0000 (07:45 +0000)]
2011-05-30  Nate Chapin  <japhet@chromium.org>

        Reviewed by Antti Koivisto.

        Refactor the CachedResourceLoader -> CachedResource -> CachedResourceRequest
        flow so it's a little less circular.
        https://bugs.webkit.org/show_bug.cgi?id=61666

        * loader/cache/CachedFont.cpp:
        (WebCore::CachedFont::beginLoadIfNeeded):
        * loader/cache/CachedResource.cpp:
        (WebCore::CachedResource::load):
        * loader/cache/CachedResourceLoader.cpp:
        (WebCore::CachedResourceLoader::requestImage):
        (WebCore::CachedResourceLoader::setAutoLoadImages):
        (WebCore::CachedResourceLoader::loadStarted):
        * loader/cache/CachedResourceLoader.h:
        * loader/cache/CachedResourceRequest.cpp:
        (WebCore::CachedResourceRequest::load):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-30 Sheriff Bot <webkit.review.bot@gmail.com>
abarth@webkit.org [Mon, 30 May 2011 07:22:21 +0000 (07:22 +0000)]
2011-05-30  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r87618.
        http://trac.webkit.org/changeset/87618
        https://bugs.webkit.org/show_bug.cgi?id=61720

        Causes BrowserFocusTest.FocusOnReload to fail (Requested by
        abarth|gardener on #webkit).

        * fast/dom/HTMLLinkElement/prefetch-too-many-clients-expected.txt: Removed.
        * fast/dom/HTMLLinkElement/prefetch-too-many-clients.html: Removed.
        * platform/gtk/Skipped:
        * platform/mac/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:
2011-05-30  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r87618.
        http://trac.webkit.org/changeset/87618
        https://bugs.webkit.org/show_bug.cgi?id=61720

        Causes BrowserFocusTest.FocusOnReload to fail (Requested by
        abarth|gardener on #webkit).

        * html/HTMLLinkElement.cpp:
        (WebCore::HTMLLinkElement::process):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-29 Yuta Kitamura <yutak@chromium.org>
yutak@chromium.org [Mon, 30 May 2011 06:22:06 +0000 (06:22 +0000)]
2011-05-29  Yuta Kitamura  <yutak@chromium.org>

        Reviewed by Kent Tamura.

        WebSocket closing handshake
        https://bugs.webkit.org/show_bug.cgi?id=35721

        * http/tests/websocket/tests/client-close-expected.txt: Added.
        * http/tests/websocket/tests/client-close.html: Added. Test client-initiated close.
        * http/tests/websocket/tests/client-close_wsh.py: Added.
        * http/tests/websocket/tests/close-before-open-expected.txt: Add a new console message.
        * http/tests/websocket/tests/close-event-expected.txt:
        * http/tests/websocket/tests/close-event.html: Test if closeEvent.wasClean is true.
        * http/tests/websocket/tests/close-unref-websocket-expected.txt: Add a new console message.
        * http/tests/websocket/tests/frame-length-longer-than-buffer_wsh.py:
        We need to stop pywebsocket from starting the closing handshake. Otherwise, pywebsocket
        waits for a close frame to arrive and this test will time out.
        * http/tests/websocket/tests/server-close-expected.txt: Added.
        * http/tests/websocket/tests/server-close.html: Added. Test server-initiated close.
        * http/tests/websocket/tests/server-close_wsh.py: Added.
        * http/tests/websocket/tests/websocket-event-target-expected.txt: Add a new console message.
2011-05-29  Yuta Kitamura  <yutak@chromium.org>

        Reviewed by Kent Tamura.

        WebSocket closing handshake
        https://bugs.webkit.org/show_bug.cgi?id=35721

        Implement WebSocket closing handshake based on Ian Hickson's
        WebSocket protocol draft 76.

        Tests: http/tests/websocket/tests/client-close.html
               http/tests/websocket/tests/server-close.html

        * platform/network/SocketStreamHandleBase.cpp:
        (WebCore::SocketStreamHandleBase::send):
        Do not send a message if we are in Closing state.
        (WebCore::SocketStreamHandleBase::close):
        Do not disconnect if we have pending data which have not been sent yet.
        In this case, the actual disconnection will happen in sendPendingData().
        (WebCore::SocketStreamHandleBase::disconnect):
        Renamed from close(). Disconnect the connection immediately.
        (WebCore::SocketStreamHandleBase::sendPendingData):
        * platform/network/SocketStreamHandleBase.h:
        * websockets/ThreadableWebSocketChannelClientWrapper.cpp:
        Add didStartClosingHandshake(). Add a function argument (ClosingHandshakeCompletionStatus)
        to didClose().
        (WebCore::ThreadableWebSocketChannelClientWrapper::didStartClosingHandshake):
        (WebCore::ThreadableWebSocketChannelClientWrapper::didClose):
        (WebCore::ThreadableWebSocketChannelClientWrapper::didStartClosingHandshakeCallback):
        (WebCore::ThreadableWebSocketChannelClientWrapper::didCloseCallback):
        * websockets/ThreadableWebSocketChannelClientWrapper.h:
        * websockets/WebSocket.cpp:
        (WebCore::WebSocket::send):
        (WebCore::WebSocket::close):
        Fail if close() is attempted before the connection is established.
        Otherwise, set the state to CLOSING and start the closing handshake.
        (WebCore::WebSocket::bufferedAmount):
        If the state is CLOSING, we need to consider buffered data in m_channel and sent after close().
        (WebCore::WebSocket::didConnect):
        (WebCore::WebSocket::didReceiveMessage):
        We need to invoke message event in CLOSING state as well as OPEN state.
        (WebCore::WebSocket::didReceiveMessageError):
        (WebCore::WebSocket::didStartClosingHandshake):
        (WebCore::WebSocket::didClose):
        * websockets/WebSocket.h:
        * websockets/WebSocketChannel.cpp:
        (WebCore::WebSocketChannel::WebSocketChannel):
        (WebCore::WebSocketChannel::close):
        Start the closing handshake.
        (WebCore::WebSocketChannel::disconnect):
        Disconnect the socket stream, instead of close.
        (WebCore::WebSocketChannel::didClose):
        (WebCore::WebSocketChannel::didReceiveData): Ditto.
        (WebCore::WebSocketChannel::didFail): Ditto.
        (WebCore::WebSocketChannel::processBuffer):
        Ditto.
        Handle 0xFF 0x00 byte sequence, and discard received data once the closing handshake has started.
        (WebCore::WebSocketChannel::startClosingHandshake):
        Send 0xFF 0x00 byte sequence.
        (WebCore::WebSocketChannel::closingTimerFired):
        Disconnect the socket stream if the closing handshake has timed out.
        * websockets/WebSocketChannel.h:
        m_closing is true if "the WebSocket closing handshake has started" (as stated in the protocol
        specification).
        * websockets/WebSocketChannelClient.h:
        (WebCore::WebSocketChannelClient::didStartClosingHandshake): Added.
        (WebCore::WebSocketChannelClient::didClose): Add closingHandshakeCompletion parameter.
        * websockets/WorkerThreadableWebSocketChannel.cpp:
        Add closingHandshakeCompletion parameter to didClose(), and add didStartClosingHandshake().
        (WebCore::WorkerThreadableWebSocketChannel::Peer::close):
        (WebCore::workerContextDidStartClosingHandshake):
        (WebCore::WorkerThreadableWebSocketChannel::Peer::didStartClosingHandshake):
        (WebCore::workerContextDidClose):
        (WebCore::WorkerThreadableWebSocketChannel::Peer::didClose):
        * websockets/WorkerThreadableWebSocketChannel.h:
2011-05-29  Yuta Kitamura  <yutak@chromium.org>

        Reviewed by Kent Tamura.

        WebSocket closing handshake
        https://bugs.webkit.org/show_bug.cgi?id=35721

        * Scripts/webkitpy/thirdparty/__init__.py:
        Pull in pywebsocket 0.6b1. We need to update pywebsocket
        to get the right behavior of closing handshake.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-29 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 30 May 2011 06:17:28 +0000 (06:17 +0000)]
2011-05-29  Adam Barth  <abarth@webkit.org>

        More IMAGE results.

        * platform/chromium-mac-leopard/svg/wicd/test-scalable-background-image1-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-29 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 30 May 2011 06:07:34 +0000 (06:07 +0000)]
2011-05-29  Adam Barth  <abarth@webkit.org>

        Add image baselines for all these beautiful platforms.

        * platform/chromium-linux-x86/fullscreen: Added.
        * platform/chromium-linux-x86/fullscreen/full-screen-iframe-zIndex-expected.png: Added.
        * platform/chromium-linux/fullscreen/full-screen-iframe-zIndex-expected.png: Added.
        * platform/chromium-mac-leopard/fullscreen: Added.
        * platform/chromium-mac-leopard/fullscreen/full-screen-iframe-zIndex-expected.png: Added.
        * platform/chromium-mac/fullscreen: Added.
        * platform/chromium-mac/fullscreen/full-screen-iframe-zIndex-expected.png: Added.
        * platform/chromium-win-vista/fullscreen: Added.
        * platform/chromium-win-vista/fullscreen/full-screen-iframe-zIndex-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-29 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 30 May 2011 05:54:59 +0000 (05:54 +0000)]
2011-05-29  Adam Barth  <abarth@webkit.org>

        Attempt to fix build by implementing pure virtual function.

        * html/shadow/MediaControlRootElementChromium.cpp:
        (WebCore::MediaControlRootElementChromium::shouldHideControls):
        * html/shadow/MediaControlRootElementChromium.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87671 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-29 Brian Weinstein <bweinstein@apple.com>
jer.noble@apple.com [Mon, 30 May 2011 03:37:14 +0000 (03:37 +0000)]
2011-05-29  Brian Weinstein  <bweinstein@apple.com>

        Reviewed by Darin Adler.

        Controls never hide in full screen after user stops moving mouse
        https://bugs.webkit.org/show_bug.cgi?id=61715
        <rdar://problem/9522182>

        When we get a mouse move event in HTMLMediaElement::defaultEventHandler, and we are in full screen,
        show the media controls, and then start a timer.

        The timer fires 3 seconds after the user's last mouse movement (timer is restarted on every mouse
        move), and hides the controls.

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::HTMLMediaElement): Initialize our new timer.
        (WebCore::HTMLMediaElement::play): If we are in full screen mode, start our timer to hide the full screen
            controls. We don't want the user to have to move the mouse to hide them when they use the spacebar
            to play.
        (WebCore::HTMLMediaElement::startHideFullscreenControlsTimer): Starts a oneshot timer 3 seconds in the future
            if we are in full screen.
        (WebCore::HTMLMediaElement::hideFullscreenControlsTimerFired): Make sure that we are currently playing, and
            we are in full screen, and hide the controls. We don't want to hide the controls if we are paused.
        (WebCore::HTMLMediaElement::stopHideFullscreenControlsTimer): Stops the timer.
        (WebCore::HTMLMediaElement::defaultEventHandler): If we get a mouse move event and are in full screen, show the
            controls and start a timer to hide them.
        (WebCore::HTMLMediaElement::enterFullscreen): Start a timer to hide the full screen controls. The user shouldn't
            have the move the mouse once they enter full screen to hide the controls.
        (WebCore::HTMLMediaElement::exitFullscreen): Stop the timer to hide the full screen controls.
        * html/HTMLMediaElement.h:
        * html/shadow/MediaControls.h: Added pure virtual shouldHideControls() method.
        * html/shadow/MediaControlRootElement.cpp:
        (WebCore::MediaControlRootElement::playbackStopped): Stop the timer to hide the full screen controls.
        (WebCore::MediaControlRootElement::shouldHideControls): Added, only report that
            the caller should hide the controls if the panel is not hovered.
        * html/shadow/MediaControlRootElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-29 Jer Noble <jer.noble@apple.com>
jer.noble@apple.com [Mon, 30 May 2011 02:05:30 +0000 (02:05 +0000)]
2011-05-29  Jer Noble  <jer.noble@apple.com>

        Reviewed by Simon Fraser.

        Embedded Vimeo video, when taken fullscreen, is overlapped by content from the enclosing page
        https://bugs.webkit.org/show_bug.cgi?id=61712

        * fullscreen/full-screen-iframe-zIndex-expected.txt: Added.
        * fullscreen/full-screen-iframe-zIndex.html: Added.
        * platform/mac/fullscreen/full-screen-iframe-zIndex-expected.png: Added.
2011-05-29  Jer Noble  <jer.noble@apple.com>

        Reviewed by Simon Fraser.

        Embedded Vimeo video, when taken fullscreen, is overlapped by content from the enclosing page
        https://bugs.webkit.org/show_bug.cgi?id=61712

        Tests: fullscreen/full-screen-iframe-zIndex.html

        Walk up the ancestor chain for the full-screen element, marking them as full-screen
        ancestors. Then, we apply a pseudo-class to those elements, which disable all their
        stacking-context-creating styles.  Set the z-index of all full-screen elements (and
        the iframes which contain them) to a large value, ensuring they appear above other
        sibling elements.

        This new behavior replaces the previous "-webkit-full-screen-media-document" behavior
        and pesudo-class, so remove it and replace it with the new pseudo-class.

        * css/CSSSelector.cpp:
        (WebCore::nameToPseudoTypeMap): Add -webkit-full-screen-ancestor and remove
            -webkit-full-screen-media-document.
        (WebCore::CSSSelector::pseudoId): Add PseudoFullScreenAncestor and remove
            PseudoFullScreenMediaDocument
        (WebCore::CSSSelector::extractPseudoType): Ditto.
        * css/CSSSelector.h: Ditto.
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Remove the
            PseudoFullScreenMediaDocument implementation and replace it with
            PseudoFullScreenAncestor.
        * css/fullscreen.css:
        (:-webkit-full-screen): Add a z-index property.
        (:-webkit-full-screen-ancestor:not(iframe)): Added.  Reset the z-index to
            auto, and reset other stacking-context creating properties.
        * dom/Document.cpp:
        (WebCore::Document::setContainsFullScreenElementRecursively): Recurse up every element
            instead of just the iframe elements.
        (WebCore::Document::webkitWillEnterFullScreenForElement): Ditto.
        * dom/Element.cpp:
        (WebCore::Element::willRemove): Reset our parent's containsFullScreenElement property.
        (WebCore::Element::insertedIntoTree): Ditto.
        (WebCore::Element::containsFullScreenElement): Moved here from HTMLElementBase.
        (WebCore::Element::setContainsFullScreenElement): Ditto.
        * dom/Element.h:
        * dom/ElementRareData.h:
        (WebCore::ElementRareData::ElementRareData): Added ivar and initializer for
            m_containsFullScreenElement.
        * html/HTMLFrameElementBase.cpp:
        (WebCore::HTMLFrameElementBase::HTMLFrameElementBase): Removed ivar and initializer.
        (WebCore::HTMLFrameElementBase::setContainsFullScreenElement): Moved into Element.
        * html/HTMLFrameElementBase.h:
        * rendering/style/RenderStyleConstants.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-29 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 30 May 2011 00:49:32 +0000 (00:49 +0000)]
2011-05-29  Adam Barth  <abarth@webkit.org>

        Add expected result.

        * platform/chromium-mac-leopard/svg/wicd/test-scalable-background-image2-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87659 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-29 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 30 May 2011 00:42:47 +0000 (00:42 +0000)]
2011-05-29  Adam Barth  <abarth@webkit.org>

        Slightly adjust the type of the expected failure.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/9515650> 30 second rewind button obscured in fullscreen controller...
mitz@apple.com [Mon, 30 May 2011 00:19:51 +0000 (00:19 +0000)]
<rdar://problem/9515650> 30 second rewind button obscured in fullscreen controller when video uses custom inline controls
https://bugs.webkit.org/show_bug.cgi?id=61714

Reviewed by Darin Adler.

* dom/Document.cpp:
(WebCore::Document::webkitDidEnterFullScreenForElement): Call didBecomeFullscreenElement() on the
new full screen element.
(WebCore::Document::webkitWillExitFullScreenForElement): Call willStopBeingFullscreenElement() on
the full screen element.
* dom/Element.h:
(WebCore::Element::didBecomeFullscreenElement): Added with a default implementation that does nothing.
(WebCore::Element::willStopBeingFullscreenElement): Ditto.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::didBecomeFullscreenElement): Added this override, which calls
MediaControls::enteredFullscreen().
(WebCore::HTMLMediaElement::willStopBeingFullscreenElement): Added this override, which calls
MediaControls::exitedFullscreen().
* html/HTMLMediaElement.h:
* html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlFullscreenButtonElement::preDispatchEventHandler): Removed calls to
enteredFullscreen() and exitedFullscreen() from here, since they are now called in response to
changes to the fullscreen-ness of the element.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-29 Darin Adler <darin@apple.com>
darin@apple.com [Mon, 30 May 2011 00:19:45 +0000 (00:19 +0000)]
2011-05-29  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        Race condition in full screen controller, which leads to problem when web process crashes
        https://bugs.webkit.org/show_bug.cgi?id=61707

        Second try at this. First try could lead to a WKView leak.

        * UIProcess/mac/WKFullScreenWindowController.h: Added _isExitingAcceleratedCompositingMode.
        Needed to track whether we have retained so we don't leak if the page goes away before
        we get the callback.

        * UIProcess/mac/WKFullScreenWindowController.mm:
        (-[WKFullScreenWindowController exitAcceleratedCompositingMode]): Added code to set
        the new variable to YES.
        (-[WKFullScreenWindowController exitCompositedModeRepaintCompleted]): Added code to
        deal with the new boolean and to release.
        (exitCompositedModeRepaintCompleted): Removed the release that was here.
        (-[WKFullScreenWindowController close]): Added a call to exitCompositedModeRepaintCompleted
        here. We're as complete as we'll ever be when we're closed; we can't get the callback
        after that point.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-29 Darin Adler <darin@apple.com>
darin@apple.com [Mon, 30 May 2011 00:00:34 +0000 (00:00 +0000)]
2011-05-29  Darin Adler  <darin@apple.com>

        Reviewed by Kevin Decker.

        REGRESSION (r87622): In media documents, clicking the full screen button and the play button pauses the video
        https://bugs.webkit.org/show_bug.cgi?id=61713

        We need to come up with a way to regression-test these changes. Nothing at the moment.

        The bug is that we removed calls to preventDefault, but we still do need to prevent
        default handling of this event.

        * html/shadow/MediaControlElements.cpp:
        (WebCore::MediaControlElement::preDispatchEventHandler): Add back the preventDefault
        that was in here before r87622 as well as the stopPropagation that was added in r87622.
        (WebCore::MediaControlMuteButtonElement::preDispatchEventHandler): Ditto.
        (WebCore::MediaControlPlayButtonElement::preDispatchEventHandler): Ditto.
        (WebCore::MediaControlSeekButtonElement::preDispatchEventHandler): Ditto.
        (WebCore::MediaControlRewindButtonElement::preDispatchEventHandler): Ditto.
        (WebCore::MediaControlReturnToRealtimeButtonElement::preDispatchEventHandler): Ditto.
        (WebCore::MediaControlToggleClosedCaptionsButtonElement::preDispatchEventHandler): Ditto.
        (WebCore::MediaControlFullscreenButtonElement::preDispatchEventHandler): Ditto.
        (WebCore::MediaControlFullscreenVolumeMinButtonElement::preDispatchEventHandler): Ditto.
        (WebCore::MediaControlFullscreenVolumeMaxButtonElement::preDispatchEventHandler): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoREGRESSION (r87637): nytimes.com freezes after going back to it
weinig@apple.com [Sun, 29 May 2011 22:14:49 +0000 (22:14 +0000)]
REGRESSION (r87637): nytimes.com freezes after going back to it
<rdar://problem/9521928>

Reviewed by Anders Carlsson.

* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::forceRepaint):
Add call to setShouldNotifyAfterNextScheduledLayerFlush(false) to prevent a
redundant call to layerHostDidFlushLayers which would cause the layer state
to get out of sync with the UIProcess.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-29 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Sun, 29 May 2011 21:56:53 +0000 (21:56 +0000)]
2011-05-29  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Sam Weinig.

        Some heap refactoring
        https://bugs.webkit.org/show_bug.cgi?id=61704

        SunSpider says no change.

        * JavaScriptCore.exp: Export!

        * heap/Heap.cpp: COLLECT_ON_EVERY_ALLOCATION can actually do so now.

        (JSC::Heap::Heap): Changed Heap sub-objects to point to the heap.

        (JSC::Heap::allocate): Changed inline allocation code to only select the
        size class, since this can be optimized out at compile time -- everything
        else is now inlined into this out-of-line function.

        No need to duplicate ASSERTs made in our caller.

        * heap/Heap.h:
        (JSC::Heap::heap):
        (JSC::Heap::isMarked):
        (JSC::Heap::testAndSetMarked):
        (JSC::Heap::testAndClearMarked):
        (JSC::Heap::setMarked): Call directly into MarkedBlock instead of adding
        a layer of indirection through MarkedSpace.

        (JSC::Heap::allocate): See above.

        * heap/MarkedBlock.cpp:
        (JSC::MarkedBlock::create):
        (JSC::MarkedBlock::MarkedBlock):
        * heap/MarkedBlock.h: Changed Heap sub-objects to point to the heap.

        * heap/MarkedSpace.cpp:
        (JSC::MarkedSpace::MarkedSpace):
        (JSC::MarkedSpace::allocateBlock):
        * heap/MarkedSpace.h:
        (JSC::MarkedSpace::allocate): Updated to match changes above.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-29 Jer Noble <jer.noble@apple.com>
jer.noble@apple.com [Sun, 29 May 2011 21:28:24 +0000 (21:28 +0000)]
2011-05-29  Jer Noble  <jer.noble@apple.com>

        Reviewed by Simon Fraser.

        REGRESSION (r86924): webkitRequestFullScreen does not work properly (black screen, can’t interact)
        https://bugs.webkit.org/show_bug.cgi?id=61710

        When taking the documentElement full screen, we don't create a RenderFullScreen
        object and thus never enter accelerated compositing mode for the animation. Tell
        the WKFullScreenWindowController to enter accelerated compositing mode anyway
        (with an empty layer context) so as to fulfill its expectations and cause the
        full screen animation to complete.

        * UIProcess/mac/WKFullScreenWindowController.mm:
        (-[WKFullScreenWindowController finishedEnterFullScreenAnimation:]): Added a
            comment explaining when we expect the animation to complete.
        (-[WKFullScreenWindowController enterAcceleratedCompositingMode:WebKit::]):
            Remove an ASSERT which is no longer valid.
        * WebProcess/FullScreen/mac/WebFullScreenManagerMac.mm:
        (WebKit::WebFullScreenManagerMac::beginEnterFullScreenAnimation): Tell the UIProcess
            to enter then exit full-screen mode.
        (WebKit::WebFullScreenManagerMac::beginExitFullScreenAnimation): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-29 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Sun, 29 May 2011 20:45:10 +0000 (20:45 +0000)]
2011-05-29  Andreas Kling  <kling@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        Element: Micro-cleanup of scroll methods.
        https://bugs.webkit.org/show_bug.cgi?id=61705

        Do an early return without calculating element boundaries when asked
        to scroll an element without a renderer().

        * dom/Element.cpp:
        (WebCore::Element::scrollIntoView):
        (WebCore::Element::scrollIntoViewIfNeeded):
        (WebCore::Element::scrollByUnits):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-29 Darin Adler <darin@apple.com>
darin@apple.com [Sun, 29 May 2011 20:12:27 +0000 (20:12 +0000)]
2011-05-29  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        Race condition in full screen controller, which leads to problem when web process crashes
        https://bugs.webkit.org/show_bug.cgi?id=61707

        Saw this while debugging a crash. We don't have a way to make regression tests for this
        kind of issue at this time.

        * UIProcess/mac/WKFullScreenWindowController.mm:
        (-[WKFullScreenWindowController exitAcceleratedCompositingMode]): Retain the controller
        here since we are keeping a pointer to it.
        (exitCompositedModeRepaintCompleted): Release the controller here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-29 Darin Adler <darin@apple.com>
darin@apple.com [Sun, 29 May 2011 20:12:01 +0000 (20:12 +0000)]
2011-05-29  Darin Adler  <darin@apple.com>

        Reviewed by Dan Bernstein.

        Fix assertion seen when entering full screen mode for standalone video
        https://bugs.webkit.org/show_bug.cgi?id=61708

        We don't currently have a way to make a regression test for this.

        * dom/Document.cpp:
        (WebCore::Document::setAnimatingFullScreen): Call scheduleForcedStyleRecalc,
        because scheduleStyleRecalc is intended to only be called when the style
        system itself detects recalc is needed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-29 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Sun, 29 May 2011 20:06:10 +0000 (20:06 +0000)]
2011-05-29  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin Adler.

        REGRESSION (87637): Entering WebKit Full Screen mode causes an assertion in DrawingAreaImpl::layerHostDidFlushLayers
        https://bugs.webkit.org/show_bug.cgi?id=61706
        <rdar://problem/9521970>

        If we've already let the UI process know that we're in compositing mode, we just need to force a repaint.

        * WebProcess/WebPage/DrawingAreaImpl.cpp:
        (WebKit::DrawingAreaImpl::forceRepaint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-29 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Sun, 29 May 2011 19:38:46 +0000 (19:38 +0000)]
2011-05-29  Daniel Bates  <dbates@rim.com>

        Reviewed by David Kilzer.

        REGRESSION (r86515): svn-apply ignores diffs that omit line count in chunk range
        https://bugs.webkit.org/show_bug.cgi?id=61162

        Fixes an issue where svn-apply may ignore a diff that contains a chunk range line
        that omits a line count. In particular, the chunk range regular expression does
        not match a chunk range line that omits a line count. GNU diff(1) will omit the
        line count in the chunk range if the line count is exactly 1. For example, appending
        a new line to the end of an existing file F that contains exactly one line of text will
        be represented in a diff with a chunk range line that omits the line count for F.

        * Scripts/VCSUtils.pm:
          (parseChunkRange): Added.
        * Scripts/webkitperl/VCSUtils_unittest/parseChunkRange.pl: Added.
        * Scripts/webkitperl/VCSUtils_unittest/parseDiff.pl:
          - Added unit test "Git: Append new line to the end of an existing file".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-27 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Sun, 29 May 2011 19:13:46 +0000 (19:13 +0000)]
2011-05-27  Andreas Kling  <kling@webkit.org>

        Reviewed by James Robinson.

        [Qt] Add area check to ImageBufferData::getImageData()
        https://bugs.webkit.org/show_bug.cgi?id=61375

        No change in behavior, just a sanity check.

        * platform/graphics/qt/ImageBufferQt.cpp:
        (WebCore::getImageData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=61700
darin@apple.com [Sun, 29 May 2011 19:00:11 +0000 (19:00 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=61700
Need WebKit2 API to get the size of the render tree
-and corresponding-
<rdar://problem/9512733>

Patch by Beth Dakin <bdakin@apple.com> on 2011-05-29
Reviewed by Darin Adler.

New member variable on RenderArena keeps track of the current amount of memory
allocated in the arena. The new client function sends this piece of data to
WebKit.
* page/ChromeClient.h:
(WebCore::ChromeClient::setRenderTreeSize):
* page/FrameView.cpp:
(WebCore::FrameView::performPostLayoutTasks):
* rendering/RenderArena.cpp:
(WebCore::RenderArena::RenderArena):
(WebCore::RenderArena::allocate):
(WebCore::RenderArena::free):
* rendering/RenderArena.h:
(WebCore::RenderArena::totalRenderArenaSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-29 Beth Dakin <bdakin@apple.com>
darin@apple.com [Sun, 29 May 2011 18:13:14 +0000 (18:13 +0000)]
2011-05-29  Beth Dakin  <bdakin@apple.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=61700
        Need WebKit2 API to get the size of the render tree
        -and corresponding-
        <rdar://problem/9512733>

        * UIProcess/API/C/WKPage.cpp:
        (WKPageGetRenderTreeSize):
        * UIProcess/API/C/WKPage.h:
        * UIProcess/WebPageProxy.h:
        (WebKit::WebPageProxy::renderTreeSize):
        (WebKit::WebPageProxy::setRenderTreeSize):
        * UIProcess/WebPageProxy.messages.in:
        * WebProcess/WebCoreSupport/WebChromeClient.cpp:
        (WebKit::WebChromeClient::setRenderTreeSize):
        * WebProcess/WebCoreSupport/WebChromeClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/9519453>
darin@apple.com [Sun, 29 May 2011 18:03:30 +0000 (18:03 +0000)]
<rdar://problem/9519453>
When calling ForceRepaint on a page with accelerated compositing, we can get
a race condition where the UI process paints the old content, resulting in showing
the previous page. That happens because forceRepaint's callback waits for the next
repaint to happen, but nothing notifies UI process that the page is in accelerated
compositing mode.

Reviewed by Anders Carlsson and Simon Fraser.

* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::forceRepaint): Call layerHostDidFlushLayers instead of
just calling forceRepaint on the layer tree host.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-27 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Sun, 29 May 2011 09:49:03 +0000 (09:49 +0000)]
2011-05-27  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Data directory is webkitgtk-x.y not webkit-x.y
        https://bugs.webkit.org/show_bug.cgi?id=61642

        * GNUmakefile.am: updated data directory.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-29 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Sun, 29 May 2011 08:30:35 +0000 (08:30 +0000)]
2011-05-29  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r87566.
        http://trac.webkit.org/changeset/87566
        https://bugs.webkit.org/show_bug.cgi?id=61702

        It made all tests assert on Qt in debug mode (Requested by
        Ossy_weekend on #webkit).

        * WebCore.exp.in:
        * bindings/ScriptControllerBase.cpp:
        (WebCore::ScriptController::executeIfJavaScriptURL):
        * dom/Document.cpp:
        (WebCore::Document::Document):
        (WebCore::Document::suggestedMIMEType):
        (WebCore::Document::lastModified):
        (WebCore::Document::initSecurityContext):
        (WebCore::Document::updateURLForPushOrReplaceState):
        * dom/Document.h:
        (WebCore::Document::setDocumentLoader):
        (WebCore::Document::loader):
        * html/MediaDocument.cpp:
        (WebCore::MediaDocument::replaceMediaElementTimerFired):
        * html/PluginDocument.cpp:
        (WebCore::PluginDocumentParser::createDocumentStructure):
        * platform/mac/HTMLConverter.mm:
        (fileWrapperForElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-28 Steve Falkenburg <sfalken@apple.com>
sfalken@apple.com [Sun, 29 May 2011 07:04:13 +0000 (07:04 +0000)]
2011-05-28  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Dan Bernstein.

        Don't add sub-frames to global history when navigating via back/forward
        https://bugs.webkit.org/show_bug.cgi?id=61701
        <rdar://problem/9521222>

        Instead of just checking whether the load is the first in the frame, we also need to
        check to make sure we're loading in the main frame.

        Not testable due to lack of global history infrastructure in DRT.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::transitionToCommitted):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Suggested by Simon Fraser.
ap@apple.com [Sun, 29 May 2011 04:42:18 +0000 (04:42 +0000)]
    Suggested by Simon Fraser.

        REGRESSION (r85375): Load event is sometimes lost when multiple image elements use the same URL
        https://bugs.webkit.org/show_bug.cgi?id=61692
        <rdar://problem/9488628>

        * loader/ImageLoader.cpp: (WebCore::ImageLoader::notifyFinished): There was no need to use
        ASSERT_UNUSED here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Geoff Garen.
ap@apple.com [Sun, 29 May 2011 01:37:59 +0000 (01:37 +0000)]
    Reviewed by Geoff Garen.

        REGRESSION (r85375): Load event is sometimes lost when multiple image elements use the same URL
        https://bugs.webkit.org/show_bug.cgi?id=61692
        <rdar://problem/9488628>

        Test: fast/dom/gc-image-element-2.html

        Manually verified that tests from bug 59604 and from bug 40926 still pass.

        The problem here was that HTMLImageElement::hasPendingActivity() could return false when
        a load (or error) event was still expected to fire.

        * loader/cache/CachedResource.cpp:
        (WebCore::CachedResource::setRequest):
        * loader/cache/CachedResource.h:
        (WebCore::CachedResource::wasCanceled):
        (WebCore::CachedResource::errorOccurred):
        Track whether the load was canceled. We want to always notify clients of load outcome,
        as that's the only way they could make intelligent decisions.

        * dom/ScriptElement.cpp: (WebCore::ScriptElement::execute): Cached resource clients now
        get a notifyFinished call on cancellation. Handle this case, where we don't need the
        execute the script, but also don't need to fire an error event.

        * html/HTMLImageElement.cpp: Moved hasPendingActivity() to header, since it's just a single
        function call now.

        * html/HTMLImageElement.h: (WebCore::HTMLImageElement::hasPendingActivity): There is a large
        window between when CachedResource::isLoading() becomes false and events are queued.
        ImageLoader::haveFiredLoadEvent() is a much better indication of whether we are expecting
        an event to fire.

        * html/HTMLLinkElement.cpp: (WebCore::HTMLLinkElement::onloadTimerFired): Again, don't do
        anything on cancellation.

        * loader/ImageLoader.cpp:
        (WebCore::ImageEventSender::hasPendingEvents): Made it debug-only again, and fixed to
        give an accurate result while looping over the list of events to dispatch.
        (WebCore::ImageLoader::notifyFinished): Don't do anything when cancelled. We don't want to
        switch to a broken image icon, or to dispatch events.
        (WebCore::ImageEventSender::dispatchPendingEvents): Clear the current loader from dispatching
        list, as the event is no longer pending when it's being dispatched.

        * loader/ImageLoader.h: Removed unnecessary hasPendingLoadEvent(). We don't care whether one
        is already pending, we only care if one is expected at some time in the future, and
        !haveFiredLoadEvent() is our best idea of that.

        * dom/XMLDocumentParser.cpp: (WebCore::XMLDocumentParser::notifyFinished): Another place to
        handle cancellation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-28 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Sat, 28 May 2011 23:45:17 +0000 (23:45 +0000)]
2011-05-28  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein, Maciej Stachowiak.

        Denying access to your keychain on login crashes WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=61695
        <rdar://problem/9520570>

        Fix two sources of crashes if you hit the Deny button when WebKit2 is
        doing HTTP authentication.

        First, SecKeychainItemRequestData::attributeList() failed to initialize the
        length and data members of SecKeychainAttributes in the list if there was no data.
        This caused invalid memory reads later.

        Second, returning a non-zero error from the SecKeychainItemCopyContent shim method
        would cause a later crash in a system framework, which is not set up to handle
        errors. Instead, we always return noErr, and allow the authentication to fail.

        Finally, paranoically initialize the SecKeychainItemContext in two places
        to avoid uninitialized data members, and initialize length and outData
        to 0 in secKeychainItemCopyContent() in case SecKeychainItemCopyContent()
        fails to set them on error.

        * Shared/mac/SecKeychainItemRequestData.cpp:
        (WebKit::SecKeychainItemRequestData::attributeList):
        * UIProcess/mac/WebProcessProxyMac.mm:
        (WebKit::WebProcessProxy::secKeychainItemCopyContent):
        * WebProcess/mac/KeychainItemShimMethods.mm:
        (WebKit::webSecKeychainItemCopyContent):
        (WebKit::webSecKeychainItemCreateFromContent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-28 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 28 May 2011 22:26:15 +0000 (22:26 +0000)]
2011-05-28  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        EWS builds patches that fail to build twice, which seems useless and slows down the bots
        https://bugs.webkit.org/show_bug.cgi?id=55585

        This patch switches all the early warning system bots over to the new
        PatchAnalysisTask-based infrastructure.  This patch makes these bots
        more efficient (in the case where patches fail to build) and paves the
        way for running tests on these bots!

        * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
        * Scripts/webkitpy/tool/bot/earlywarningsystemtask.py:
        * Scripts/webkitpy/tool/bot/patchanalysistask.py:
        * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
        * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
        * Scripts/webkitpy/tool/commands/queues.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-28 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Sat, 28 May 2011 21:45:43 +0000 (21:45 +0000)]
2011-05-28  Martin Robinson  <mrobinson@igalia.com>

        Skip a failing test and better classify some existing skipped tests.

        * platform/gtk/Skipped: Update the skipped list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-28 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Sat, 28 May 2011 20:39:23 +0000 (20:39 +0000)]
2011-05-28  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        REGRESSION (r86578): Flash content missing from mercurynews.com
        https://bugs.webkit.org/show_bug.cgi?id=61691
        <rdar://problem/9519893>

        If the plug-in doesn't have access to the toplevel URL, make sure to
        return *something* to the plug-in.

        * PluginProcess/PluginControllerProxy.cpp:
        (WebKit::PluginControllerProxy::tryToShortCircuitInvoke):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-28 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 28 May 2011 19:59:16 +0000 (19:59 +0000)]
2011-05-28  Adam Barth  <abarth@webkit.org>

        Reviewed by Alexey Proskuryakov.

        Audit all uses of KURL::prettyURL
        https://bugs.webkit.org/show_bug.cgi?id=61201

        Update callers of prettyURL to just call string.

        * WebCoreSupport/ChromeClientQt.cpp:
        (WebCore::ChromeClientQt::mouseDidMoveOverElement):
        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::updateGlobalHistory):
        (WebCore::FrameLoaderClientQt::cancelledError):
        (WebCore::FrameLoaderClientQt::blockedError):
        (WebCore::FrameLoaderClientQt::objectContentType):
        (WebCore::FrameLoaderClientQt::createPlugin):
2011-05-28  Adam Barth  <abarth@webkit.org>

        Reviewed by Alexey Proskuryakov.

        Audit all uses of KURL::prettyURL
        https://bugs.webkit.org/show_bug.cgi?id=61201

        Update callers of prettyURL to just call string.

        * WebCoreSupport/ChromeClientGtk.cpp:
        (WebKit::ChromeClient::mouseDidMoveOverElement):
        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::dispatchDidChangeLocationWithinPage):
        (WebKit::FrameLoaderClient::dispatchDidCommitLoad):
        * webkit/webkitwebview.cpp:
        (webkit_web_view_get_icon_uri):
2011-05-28  Adam Barth  <abarth@webkit.org>

        Reviewed by Alexey Proskuryakov.

        Audit all uses of KURL::prettyURL
        https://bugs.webkit.org/show_bug.cgi?id=61201

        Update callers of prettyURL to just call string.

        * WebCoreSupport/ChromeClientEfl.cpp:
        (WebCore::ChromeClientEfl::mouseDidMoveOverElement):
        * WebCoreSupport/FrameLoaderClientEfl.cpp:
        (WebCore::FrameLoaderClientEfl::dispatchWillSendRequest):
        (WebCore::FrameLoaderClientEfl::assignIdentifierToInitialRequest):
        (WebCore::FrameLoaderClientEfl::dispatchDecidePolicyForNavigationAction):
        (WebCore::FrameLoaderClientEfl::download):
        (WebCore::FrameLoaderClientEfl::cancelledError):
        (WebCore::FrameLoaderClientEfl::blockedError):
        * ewk/ewk_frame.cpp:
        (ewk_frame_hit_test_new):
        (ewk_frame_uri_changed):
        * ewk/ewk_view.cpp:
        (_ewk_view_priv_new):
        (ewk_view_frame_create):
        (ewk_view_plugin_create):
2011-05-28  Adam Barth  <abarth@webkit.org>

        Reviewed by Alexey Proskuryakov.

        Audit all uses of KURL::prettyURL
        https://bugs.webkit.org/show_bug.cgi?id=61201

        As far as I can tell, all the callers of this API are confused.  There
        seems to be a cargo cult of using the "pretty" version of a URL, but in
        reality folks just want the URL itself.  The only case I'm unsure about
        is location.href, which could have some compatibility constraints.
        I've renamed prettyURL to deprecatedString to discourage folks from
        further cargo-culting.

        * WebCore.exp.in:
        * page/Location.cpp:
        (WebCore::Location::href):
        (WebCore::Location::toString):
        * platform/KURL.cpp:
        (WebCore::KURL::deprecatedString):
        * platform/KURL.h:
        * platform/KURLGoogle.cpp:
        (WebCore::KURL::deprecatedString):
        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::ResourceHandle::prepareForURL):
        * workers/WorkerLocation.cpp:
        (WebCore::WorkerLocation::href):
        (WebCore::WorkerLocation::toString):
2011-05-28  Adam Barth  <abarth@webkit.org>

        Reviewed by Alexey Proskuryakov.

        Audit all uses of KURL::prettyURL
        https://bugs.webkit.org/show_bug.cgi?id=61201

        Update callers of prettyURL to just call string.

        * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
        (WebKit::WebFrameLoaderClient::createPlugin):
        * WebProcess/WebCoreSupport/qt/WebErrorsQt.cpp:
        (WebKit::cancelledError):
        (WebKit::blockedError):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-28 Jer Noble <jer.noble@apple.com>
jer.noble@apple.com [Sat, 28 May 2011 19:41:14 +0000 (19:41 +0000)]
2011-05-28  Jer Noble  <jer.noble@apple.com>

        Reviewed by Maciej Stachowiak.

        Mouse clicks propagate outside full-screen media controls.
        https://bugs.webkit.org/show_bug.cgi?id=61689

        Mouse click events are propagating out of the media controls, so mouse click
        listeners registered on the video element are getting fired when the user
        clicks on media controller buttons.  By default, block propagation of click
        events from MediaControlElements by overriding preDispatchEventHandler, and
        convert all instances of defaultEventHandler -> preDispatchEventHandler.  Change
        all calls of event->setDefaultHandled() to event->stopPropagation().

        * html/shadow/MediaControlElements.cpp:
        (WebCore::MediaControlElement::preDispatchEventHandler): Added.  Block
            propagation of all mouse click events.
        (WebCore::MediaControlVolumeSliderContainerElement::preDispatchEventHandler):
            Renamed from setDefaultHandled.
        (WebCore::MediaControlMuteButtonElement::preDispatchEventHandler): Ditto.
        (WebCore::MediaControlPanelMuteButtonElement::preDispatchEventHandler): Ditto.
        (WebCore::MediaControlPlayButtonElement::preDispatchEventHandler): Ditto.
        (WebCore::MediaControlSeekButtonElement::preDispatchEventHandler): Ditto.
        (WebCore::MediaControlRewindButtonElement::preDispatchEventHandler): Ditto.
        (WebCore::MediaControlReturnToRealtimeButtonElement::preDispatchEventHandler): Ditto.
        (WebCore::MediaControlToggleClosedCaptionsButtonElement::preDispatchEventHandler): Ditto.
        (WebCore::MediaControlTimelineElement::preDispatchEventHandler): Ditto.
        (WebCore::MediaControlVolumeSliderElement::preDispatchEventHandler): Ditto.
        (WebCore::MediaControlFullscreenButtonElement::preDispatchEventHandler): Ditto.
        (WebCore::MediaControlFullscreenVolumeMinButtonElement::preDispatchEventHandler): Ditto.
        (WebCore::MediaControlFullscreenVolumeMaxButtonElement::preDispatchEventHandler): Ditto.
        * html/shadow/MediaControlElements.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-28 Gavin Peters <gavinp@chromium.org>
commit-queue@webkit.org [Sat, 28 May 2011 18:18:49 +0000 (18:18 +0000)]
2011-05-28  Gavin Peters  <gavinp@chromium.org>

        Reviewed by Adam Barth.

        prevent HTMLLinkElement from watching multiple CachedResources
        https://bugs.webkit.org/show_bug.cgi?id=61686

        If we modify an existing link element, stop listening to the previous
        cached resource, to prevent double notifications (which crash).

        * fast/dom/HTMLLinkElement/prefetch-too-many-clients-expected.txt: Added.
        * fast/dom/HTMLLinkElement/prefetch-too-many-clients.html: Added.
        * platform/gtk/Skipped:
        * platform/mac/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:
2011-05-28  Gavin Peters  <gavinp@chromium.org>

        Reviewed by Adam Barth.

        prevent HTMLLinkElement from watching multiple CachedResources
        https://bugs.webkit.org/show_bug.cgi?id=61686

        If we modify an existing link element, stop listening to the previous
        cached resource, to prevent double notifications (which crash).

        Test: fast/dom/HTMLLinkElement/prefetch-too-many-clients.html

        * html/HTMLLinkElement.cpp:
        (WebCore::HTMLLinkElement::process):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-28 Tonis Tiigi <tonistiigi@gmail.com>
commit-queue@webkit.org [Sat, 28 May 2011 17:55:16 +0000 (17:55 +0000)]
2011-05-28  Tonis Tiigi  <tonistiigi@gmail.com>

        Reviewed by Pavel Feldman.

        Web Inspector: there is a problem with computed style properties with wrong values
        https://bugs.webkit.org/show_bug.cgi?id=60535

        Adding cases that test invalid properties.

        * inspector/styles/styles-computed-trace-expected.txt:
        * inspector/styles/styles-computed-trace.html:
2011-05-28  Tonis Tiigi  <tonistiigi@gmail.com>

        Reviewed by Pavel Feldman.

        Web Inspector: there is a problem with computed style properties with wrong values
        https://bugs.webkit.org/show_bug.cgi?id=60535

        * inspector/front-end/StylesSidebarPane.js:
        (WebInspector.StylesSidebarPane.prototype._markUsedProperties):
        (WebInspector.ComputedStylePropertiesSection.prototype.rebuildComputedTrace):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-26 Antonio Gomes <agomes@rim.com>
tonikitoo@webkit.org [Sat, 28 May 2011 17:02:18 +0000 (17:02 +0000)]
2011-05-26  Antonio Gomes  <agomes@rim.com>

        Reviewed by Andreas Kling.

        Logic error in WebCore/Page/SpatialNavigation.cpp::areRectsPartial      lyAligned
        https://bugs.webkit.org/show_bug.cgi?id=61606

        Removed duplicated statement within if condition.

        No new tests. Obvious clean up patch.

        * page/SpatialNavigation.cpp:
        (WebCore::areRectsPartiallyAligned):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Unreviewed, clean up GPU tests expectations
mnaganov@chromium.org [Sat, 28 May 2011 16:16:12 +0000 (16:16 +0000)]
[Chromium] Unreviewed, clean up GPU tests expectations

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBUILD FIX when building only the interpreter
ddkilzer@apple.com [Sat, 28 May 2011 15:43:38 +0000 (15:43 +0000)]
BUILD FIX when building only the interpreter

Fixes the following compiler warning:

    JavaScriptCore/runtime/JSGlobalData.cpp:462:6: error: no previous prototype for function 'releaseExecutableMemory' [-Werror,-Wmissing-prototypes,3]
     void releaseExecutableMemory(JSGlobalData& globalData)
          ^

* jit/ExecutableAllocator.h: Moved declaration of
JSC::releaseExecutableMemory().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Unreviewed. Update test_expectations to remove suppressions for passing...
mnaganov@chromium.org [Sat, 28 May 2011 15:27:31 +0000 (15:27 +0000)]
[Chromium] Unreviewed. Update test_expectations to remove suppressions for passing tests

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBUILD FIX after r87527 with ENABLE(BRANCH_COMPACTION)
ddkilzer@apple.com [Sat, 28 May 2011 15:24:46 +0000 (15:24 +0000)]
BUILD FIX after r87527 with ENABLE(BRANCH_COMPACTION)

* assembler/LinkBuffer.h:
(JSC::LinkBuffer::linkCode): Added missing argument.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-28 Robert Hogan <robert@webkit.org>
robert@webkit.org [Sat, 28 May 2011 12:15:26 +0000 (12:15 +0000)]
2011-05-28  Robert Hogan  <robert@webkit.org>

        Reviewed by Antonio Gomes.

        [Qt] fast/events/backspace-nagivates-back fails on Qt bots (Mac and Linux)
        https://bugs.webkit.org/show_bug.cgi?id=60311

        If there is no editable text Qt interprets backspace as a navigation
        command, regardless of platform.

        * platform/qt/fast/events/backspace-navigates-back-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Unreviewed. Mark svg/wicd/test-scalable-background-image1.xhtml as crashin...
mnaganov@chromium.org [Sat, 28 May 2011 12:06:36 +0000 (12:06 +0000)]
[Chromium] Unreviewed. Mark svg/wicd/test-scalable-background-image1.xhtml as crashing on all platforms in debug

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Unreviewed. Mark svg/wicd/test-scalable-background-image1.xhtml as crashin...
mnaganov@chromium.org [Sat, 28 May 2011 10:32:45 +0000 (10:32 +0000)]
[Chromium] Unreviewed. Mark svg/wicd/test-scalable-background-image1.xhtml as crashing on Linux and Mac debug

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-28 Mikhail Naganov <mnaganov@chromium.org>
mnaganov@chromium.org [Sat, 28 May 2011 08:50:44 +0000 (08:50 +0000)]
2011-05-28  Mikhail Naganov  <mnaganov@chromium.org>

        [Chromium] Unreviewed. Test expectations update after r87605

        * platform/chromium-linux-x86/svg/wicd/test-scalable-background-image1-expected.png: Added.
        * platform/chromium-linux-x86/svg/wicd/test-scalable-background-image1-expected.txt: Added.
        * platform/chromium-linux-x86/svg/wicd/test-scalable-background-image2-expected.png: Added.
        * platform/chromium-linux-x86/svg/wicd/test-scalable-background-image2-expected.txt: Added.
        * platform/chromium-linux/svg/wicd/test-scalable-background-image1-expected.png: Added.
        * platform/chromium-linux/svg/wicd/test-scalable-background-image1-expected.txt: Added.
        * platform/chromium-linux/svg/wicd/test-scalable-background-image2-expected.png: Added.
        * platform/chromium-linux/svg/wicd/test-scalable-background-image2-expected.txt: Added.
        * platform/chromium-win-vista/svg/wicd/test-scalable-background-image1-expected.png: Added.
        * platform/chromium-win-vista/svg/wicd/test-scalable-background-image1-expected.txt: Added.
        * platform/chromium-win-vista/svg/wicd/test-scalable-background-image2-expected.png: Added.
        * platform/chromium-win-vista/svg/wicd/test-scalable-background-image2-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-28 Kenichi Ishibashi <bashi@chromium.org>
bashi@chromium.org [Sat, 28 May 2011 08:27:43 +0000 (08:27 +0000)]
2011-05-28  Kenichi Ishibashi  <bashi@chromium.org>

        Reviewed by Kent Tamura.

        Add bashi as a committer.

        https://bugs.webkit.org/show_bug.cgi?id=61685

        * Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-28 Annie Sullivan <sullivan@chromium.org>
commit-queue@webkit.org [Sat, 28 May 2011 07:17:58 +0000 (07:17 +0000)]
2011-05-28  Annie Sullivan  <sullivan@chromium.org>

        Reviewed by Ryosuke Niwa.

        editing/style/non-inheritable-styles should be dump-as-markup test
        https://bugs.webkit.org/show_bug.cgi?id=61681

        Converts the test to dump-as-markup and cleans up the HTML a bit.

        * editing/style/non-inheritable-styles-expected.txt: Added.
        * editing/style/non-inheritable-styles.html:
        * platform/chromium-linux/editing/style/non-inheritable-styles-expected.png: Removed.
        * platform/chromium-win/editing/style/non-inheritable-styles-expected.png: Removed.
        * platform/chromium-win/editing/style/non-inheritable-styles-expected.txt: Removed.
        * platform/gtk/editing/style/non-inheritable-styles-expected.png: Removed.
        * platform/gtk/editing/style/non-inheritable-styles-expected.txt: Removed.
        * platform/mac-leopard/editing/style/non-inheritable-styles-expected.png: Removed.
        * platform/mac/editing/style/non-inheritable-styles-expected.png: Removed.
        * platform/mac/editing/style/non-inheritable-styles-expected.txt: Removed.
        * platform/qt/editing/style/non-inheritable-styles-expected.png: Removed.
        * platform/qt/editing/style/non-inheritable-styles-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-27 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Sat, 28 May 2011 06:52:04 +0000 (06:52 +0000)]
2011-05-27  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed, this just adds a new test.

        WebKit fails WICD SVG background image tests
        https://bugs.webkit.org/show_bug.cgi?id=16481

        Add two WICD SVG background image tests, which pass just fine.

        * svg/wicd/resources/test-scalable-background-image1.css: Added.
        (html):
        (body):
        (p):
        * svg/wicd/resources/test-scalable-background-image1.svg: Added.
        * svg/wicd/resources/test-scalable-background-image2.css: Added.
        (html):
        * svg/wicd/resources/test-scalable-background-image2.svg: Added.
        * svg/wicd/test-scalable-background-image1.xhtml: Added.
        * svg/wicd/test-scalable-background-image2.xhtml: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-27 Annie Sullivan <sullivan@chromium.org>
commit-queue@webkit.org [Sat, 28 May 2011 06:19:39 +0000 (06:19 +0000)]
2011-05-27  Annie Sullivan  <sullivan@chromium.org>

        Reviewed by Ryosuke Niwa.

        editing/inserting/insert-3907422 should be dumpAsText test
        https://bugs.webkit.org/show_bug.cgi?id=61680

        Converted to dumpAsMarkup and cleaned up markup.

        * editing/inserting/insert-3907422-fix-expected.txt: Added.
        * editing/inserting/insert-3907422-fix.html:
        * platform/chromium-linux/editing/inserting/insert-3907422-fix-expected.png: Removed.
        * platform/chromium-mac-leopard/editing/inserting/insert-3907422-fix-expected.png: Removed.
        * platform/chromium-mac/editing/inserting/insert-3907422-fix-expected.png: Removed.
        * platform/chromium-win/editing/inserting/insert-3907422-fix-expected.png: Removed.
        * platform/chromium-win/editing/inserting/insert-3907422-fix-expected.txt: Removed.
        * platform/gtk/editing/inserting/insert-3907422-fix-expected.txt: Removed.
        * platform/mac/editing/inserting/insert-3907422-fix-expected.png: Removed.
        * platform/mac/editing/inserting/insert-3907422-fix-expected.txt: Removed.
        * platform/qt/editing/inserting/insert-3907422-fix-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-27 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 28 May 2011 04:48:28 +0000 (04:48 +0000)]
2011-05-27  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        When checking whether the tree is red, the EWS posts a link to the wrong log
        https://bugs.webkit.org/show_bug.cgi?id=61072

        We need to cache the original script error because that contains the
        failure log we want to upload.  If we don't cache that script error,
        self._script_error will get overwritten when we sanity check the clean
        tree (and it also has test failures).

        * Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
            - This testing approach is slightly goofy.  We'd like to use
              assertRaisesRegexp, but that's not available until Python 2.7.
        * Scripts/webkitpy/tool/bot/patchanalysistask.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRoll out r87544 since it is bogus.
mrowe@apple.com [Sat, 28 May 2011 04:39:34 +0000 (04:39 +0000)]
Roll out r87544 since it is bogus.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-27 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Sat, 28 May 2011 04:18:44 +0000 (04:18 +0000)]
2011-05-27  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        CG BitmapImage needs to check for valid CGImage in a couple of places
        https://bugs.webkit.org/show_bug.cgi?id=61684
        <rdar://problem/9519348>

        BitmapImage::getCGImageArray() can throw an exception if frameAtIndex()
        returns null, which it may do if the image is corrupted or still
        loading. Protect against that here and in getFirstCGImageRefOfSize().

        * platform/graphics/cg/ImageCG.cpp:
        (WebCore::BitmapImage::getFirstCGImageRefOfSize):
        (WebCore::BitmapImage::getCGImageArray):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-27 Jochen Eisinger <jochen@chromium.org>
jochen@chromium.org [Sat, 28 May 2011 03:27:16 +0000 (03:27 +0000)]
2011-05-27  Jochen Eisinger  <jochen@chromium.org>

        Reviewed by Adam Barth.

        Check access policy on all storage operations
        https://bugs.webkit.org/show_bug.cgi?id=61581

        * platform/chromium/permissionclient/storage-permission-expected.txt: Added.
        * platform/chromium/permissionclient/storage-permission.html: Added.
2011-05-27  Jochen Eisinger  <jochen@chromium.org>

        Reviewed by Adam Barth.

        Add Frame parameter to all StorageArea methods. The chromium
        embedder uses the Frame as context to decide whether or not
        to allow usage of the storage API.
        https://bugs.webkit.org/show_bug.cgi?id=61581

        Test: platform/chromium/permissionclient/storage-permission.html

        * storage/Storage.cpp:
        (WebCore::Storage::length):
        (WebCore::Storage::key):
        (WebCore::Storage::getItem):
        (WebCore::Storage::contains):
        * storage/StorageArea.h:
        * storage/StorageAreaImpl.cpp:
        (WebCore::StorageAreaImpl::length):
        (WebCore::StorageAreaImpl::key):
        (WebCore::StorageAreaImpl::getItem):
        (WebCore::StorageAreaImpl::contains):
        * storage/StorageAreaImpl.h:
2011-05-27  Jochen Eisinger  <jochen@chromium.org>

        Reviewed by Adam Barth.

        Check access policy on all storage operations
        https://bugs.webkit.org/show_bug.cgi?id=61581

        * src/StorageAreaProxy.cpp:
        (WebCore::StorageAreaProxy::length):
        (WebCore::StorageAreaProxy::key):
        (WebCore::StorageAreaProxy::getItem):
        (WebCore::StorageAreaProxy::setItem):
        (WebCore::StorageAreaProxy::removeItem):
        (WebCore::StorageAreaProxy::clear):
        (WebCore::StorageAreaProxy::contains):
        (WebCore::StorageAreaProxy::canAccessStorage):
        * src/StorageAreaProxy.h:
        * src/WebStorageAreaImpl.cpp:
        (WebKit::WebStorageAreaImpl::length):
        (WebKit::WebStorageAreaImpl::key):
        (WebKit::WebStorageAreaImpl::getItem):
2011-05-27  Jochen Eisinger  <jochen@chromium.org>

        Reviewed by Adam Barth.

        Add layoutTestController.setStorageAllowed() to control whether access
        to the localStorage API is enabled via the WebPermissionClient
        https://bugs.webkit.org/show_bug.cgi?id=61581

        * DumpRenderTree/chromium/LayoutTestController.cpp:
        (LayoutTestController::LayoutTestController):
        (LayoutTestController::setStorageAllowed):
        * DumpRenderTree/chromium/LayoutTestController.h:
        * DumpRenderTree/chromium/TestShell.cpp:
        (TestShell::TestShell):
        (TestShell::createNewWindow):
        * DumpRenderTree/chromium/TestShell.h:
        * DumpRenderTree/chromium/WebPermissions.h: Added.
        (WebPermissions::WebPermissions):
        (WebPermissions::allowStorage):
        (WebPermissions::setStorageAllowed):
        (WebPermissions::reset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-27 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Sat, 28 May 2011 02:28:00 +0000 (02:28 +0000)]
2011-05-27  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Eric Seidel.

        NRWT: clean up metered_stream code in preparation for 'nooverwriting' patch
        https://bugs.webkit.org/show_bug.cgi?id=60326

        This patch removes a lot of the complexity from the
        metered_stream implementation that was unnecessary since there
        was only one caller and the logic could be coordinated better.

        There should be no functional changes in this patch, just code
        getting deleted and cleaned up.

        * Scripts/webkitpy/layout_tests/layout_package/metered_stream.py:
        * Scripts/webkitpy/layout_tests/layout_package/metered_stream_unittest.py:
        * Scripts/webkitpy/layout_tests/layout_package/printing.py:
        * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-27 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Sat, 28 May 2011 02:24:20 +0000 (02:24 +0000)]
2011-05-27  Nate Chapin  <japhet@chromium.org>

        Reviewed by Jian Li.

        Keep a reference to BlobResourceHandle before calling doNotifyFinish()
        asynchronously to ensure it's still safe in the main thread.

        https://bugs.webkit.org/show_bug.cgi?id=61669

        I triggered this crash in fast/files/file-reader-abort.html during a
        refactor that changed timings slightly.

        * platform/network/BlobResourceHandle.cpp:
        (WebCore::doNotifyFinish):
        (WebCore::BlobResourceHandle::notifyFinish):
        * platform/network/BlobResourceHandle.h:
        (WebCore::BlobResourceHandle::aborted):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-27 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Sat, 28 May 2011 02:16:16 +0000 (02:16 +0000)]
2011-05-27  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Eric Seidel.

        NRWT: minor cleanup in printing module
        https://bugs.webkit.org/show_bug.cgi?id=60329

        * Scripts/webkitpy/layout_tests/layout_package/printing.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-27 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Sat, 28 May 2011 02:11:00 +0000 (02:11 +0000)]
2011-05-27  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Adam Barth.

        NRWT: remove --print detailed-progress
        https://bugs.webkit.org/show_bug.cgi?id=60324

        * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
        * Scripts/webkitpy/layout_tests/layout_package/printing.py:
        * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-27 Steve Lacey <sjl@chromium.org>
sjl@chromium.org [Sat, 28 May 2011 02:00:13 +0000 (02:00 +0000)]
2011-05-27  Steve Lacey  <sjl@chromium.org>

        Reviewed by David Levin.

        Add sjl@chromium.org as a committer.

        https://bugs.webkit.org/show_bug.cgi?id=61672

        * Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-27 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Sat, 28 May 2011 01:56:23 +0000 (01:56 +0000)]
2011-05-27  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Ojan Vafai.

        NRWT: debug messages from the workers are being logged twice
        https://bugs.webkit.org/show_bug.cgi?id=60428

        It looks like when the workers are run in separate processes
        we end up getting two copies of every log message they print.
        This has to do with the multiprocessing module on UNIX cloning
        the log configuration in a way I wasn't expecting, and so two
        log handlers end up getting registered.

        * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
        * Scripts/webkitpy/layout_tests/layout_package/printing.py:
        * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-27 Adam Klein <adamk@chromium.org>
adamk@chromium.org [Sat, 28 May 2011 01:24:21 +0000 (01:24 +0000)]
2011-05-27  Adam Klein  <adamk@chromium.org>

        Unreviewed. Hopefully last rebaseline from r87526.

        * platform/chromium-mac-leopard/svg/hixie/text/003-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed test expectations update: Vista flakiness.
adamk@chromium.org [Sat, 28 May 2011 00:30:18 +0000 (00:30 +0000)]
Unreviewed test expectations update: Vista flakiness.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-27 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Sat, 28 May 2011 00:28:56 +0000 (00:28 +0000)]
2011-05-27  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        JS API is too aggressive about throwing exceptions for NULL get or set operations
        https://bugs.webkit.org/show_bug.cgi?id=61678

        * API/JSCallbackObject.h: Changed our staticValueGetter to a regular
        function that returns a JSValue, so it can fail and still forward to
        normal property lookup.

        * API/JSCallbackObjectFunctions.h:
        (JSC::::getOwnPropertySlot): Don't throw an exception when failing to
        access a static property -- just forward the access. This allows objects
        to observe get/set operations but still let the JS object manage lifetime.

        (JSC::::put): Ditto.

        (JSC::::getStaticValue): Same as JSCallbackObject.h.

        * API/tests/testapi.c:
        (MyObject_set_nullGetForwardSet):
        * API/tests/testapi.js: Updated tests to reflect slightly less strict
        behavior, which matches headerdoc claims.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-27 Adam Klein <adamk@chromium.org>
adamk@chromium.org [Sat, 28 May 2011 00:26:19 +0000 (00:26 +0000)]
2011-05-27  Adam Klein  <adamk@chromium.org>

        Unreviewed. Even more rebaselines after r87526.

        * platform/chromium-linux-x86/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
        * platform/chromium-linux-x86/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Added.
        * platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
        * platform/chromium-linux/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Added.
        * platform/chromium-mac-leopard/svg/custom/object-sizing-expected.png: Added.
        * platform/chromium-mac-leopard/svg/wicd/rightsizing-grid-expected.png: Added.
        * platform/chromium-mac-leopard/svg/wicd/test-rightsizing-b-expected.png: Added.
        * platform/chromium-mac-leopard/svg/zoom/page/zoom-coords-viewattr-01-b-expected.png: Removed.
        * platform/chromium-mac-leopard/svg/zoom/page/zoom-coords-viewattr-01-b-expected.txt: Removed.
        * platform/chromium-mac-leopard/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
        * platform/chromium-win-vista/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.png: Added.
        * platform/chromium-win-vista/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-27 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Fri, 27 May 2011 23:53:36 +0000 (23:53 +0000)]
2011-05-27  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        Property caching is too aggressive for API objects
        https://bugs.webkit.org/show_bug.cgi?id=61677

        * API/JSCallbackObject.h: Opt in to ProhibitsPropertyCaching, since our
        callback APIs allow the client to change its mind about our propertis at
        any time.

        * API/tests/testapi.c:
        (PropertyCatchalls_getProperty):
        (PropertyCatchalls_setProperty):
        (PropertyCatchalls_getPropertyNames):
        (PropertyCatchalls_class):
        (main):
        * API/tests/testapi.js: Some tests for dynamic API objects.

        * interpreter/Interpreter.cpp:
        (JSC::Interpreter::tryCachePutByID):
        (JSC::Interpreter::tryCacheGetByID):
        * jit/JITStubs.cpp:
        (JSC::JITThunks::tryCachePutByID):
        (JSC::JITThunks::tryCacheGetByID):
        (JSC::DEFINE_STUB_FUNCTION): Opt out of property caching if the client
        requires it.

        * runtime/JSTypeInfo.h:
        (JSC::TypeInfo::TypeInfo):
        (JSC::TypeInfo::isFinal):
        (JSC::TypeInfo::prohibitsPropertyCaching):
        (JSC::TypeInfo::flags): Added a flag to track opting out of property
        caching. Fixed an "&&" vs "&" typo that was previously harmless, but
        is now harmful since m_flags2 can have more than one bit set.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed test expectations update: widen flakiness to include Linux.
adamk@chromium.org [Fri, 27 May 2011 23:21:33 +0000 (23:21 +0000)]
Unreviewed test expectations update: widen flakiness to include Linux.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-27 Steve Lacey <sjl@chromium.org>
sjl@chromium.org [Fri, 27 May 2011 23:18:07 +0000 (23:18 +0000)]
2011-05-27  Steve Lacey  <sjl@chromium.org>

        Reviewed by Eric Carlson.

        The behaviour of controls-after-reload was causing
        layoutTestController in DumpRenderTree to misbehave causing a reported
        failure in the test run after it (controls-css-overload).

        Effectively, notifyDone() ended up getting called again after the test
        was being torn down.

        This change removes the unneeded seek at the end of the test (as we
        should have already seeked to 0.

        https://bugs.webkit.org/show_bug.cgi?id=60132

        * media/controls-after-reload.html:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed.
slewis@apple.com [Fri, 27 May 2011 22:57:53 +0000 (22:57 +0000)]
Unreviewed.

Fix a typo in the order_file flag.

Source/JavaScriptCore:

* Configurations/Base.xcconfig:

Source/WebCore:

* Configurations/Base.xcconfig:

Source/WebKit/mac:

* Configurations/Base.xcconfig:

Source/WebKit2:

* Configurations/Base.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-27 Adam Klein <adamk@chromium.org>
adamk@chromium.org [Fri, 27 May 2011 22:32:01 +0000 (22:32 +0000)]
2011-05-27  Adam Klein  <adamk@chromium.org>

        Unreviewed. More rebaselines after r87526.

        * platform/chromium-linux-x86/svg/in-html/by-reference-expected.txt: Copied from LayoutTests/platform/chromium-linux/svg/in-html/by-reference-expected.txt.
        * platform/chromium-linux/svg/in-html/by-reference-expected.txt:
        * platform/chromium-win-vista/svg/in-html/by-reference-expected.txt: Copied from LayoutTests/platform/chromium-linux/svg/in-html/by-reference-expected.txt.
        * platform/chromium-win-vista/svg/zoom/page/zoom-foreignObject-expected.png: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-05-27 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 27 May 2011 22:14:13 +0000 (22:14 +0000)]
2011-05-27  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Always use the default localization strategy
        https://bugs.webkit.org/show_bug.cgi?id=61670
        <rdar://problem/9516130>

        Always use the default localization strategy when there's no platform strategy.

        * platform/DefaultLocalizationStrategy.cpp:
        (WebCore::DefaultLocalizationStrategy::shared):
        * platform/DefaultLocalizationStrategy.h:
        * platform/LocalizedStrings.cpp:
        (WebCore::inputElementAltText):
        (WebCore::resetButtonDefaultLabel):
        (WebCore::searchableIndexIntroduction):
        (WebCore::submitButtonDefaultLabel):
        (WebCore::fileButtonChooseFileLabel):
        (WebCore::fileButtonNoFileSelectedLabel):
        (WebCore::defaultDetailsSummaryText):
        (WebCore::copyImageUnknownFileLabel):
        (WebCore::contextMenuItemTagOpenLinkInNewWindow):
        (WebCore::contextMenuItemTagDownloadLinkToDisk):
        (WebCore::contextMenuItemTagCopyLinkToClipboard):
        (WebCore::contextMenuItemTagOpenImageInNewWindow):
        (WebCore::contextMenuItemTagDownloadImageToDisk):
        (WebCore::contextMenuItemTagCopyImageToClipboard):
        (WebCore::contextMenuItemTagCopyImageUrlToClipboard):
        (WebCore::contextMenuItemTagOpenFrameInNewWindow):
        (WebCore::contextMenuItemTagCopy):
        (WebCore::contextMenuItemTagGoBack):
        (WebCore::contextMenuItemTagGoForward):
        (WebCore::contextMenuItemTagStop):
        (WebCore::contextMenuItemTagReload):
        (WebCore::contextMenuItemTagCut):
        (WebCore::contextMenuItemTagPaste):
        (WebCore::contextMenuItemTagSelectAll):
        (WebCore::contextMenuItemTagNoGuessesFound):
        (WebCore::contextMenuItemTagIgnoreSpelling):
        (WebCore::contextMenuItemTagLearnSpelling):
        (WebCore::contextMenuItemTagSearchInSpotlight):
        (WebCore::contextMenuItemTagSearchWeb):
        (WebCore::contextMenuItemTagLookUpInDictionary):
        (WebCore::contextMenuItemTagOpenLink):
        (WebCore::contextMenuItemTagIgnoreGrammar):
        (WebCore::contextMenuItemTagSpellingMenu):
        (WebCore::contextMenuItemTagShowSpellingPanel):
        (WebCore::contextMenuItemTagCheckSpelling):
        (WebCore::contextMenuItemTagCheckSpellingWhileTyping):
        (WebCore::contextMenuItemTagCheckGrammarWithSpelling):
        (WebCore::contextMenuItemTagFontMenu):
        (WebCore::contextMenuItemTagShowFonts):
        (WebCore::contextMenuItemTagBold):
        (WebCore::contextMenuItemTagItalic):
        (WebCore::contextMenuItemTagUnderline):
        (WebCore::contextMenuItemTagOutline):
        (WebCore::contextMenuItemTagStyles):
        (WebCore::contextMenuItemTagShowColors):
        (WebCore::contextMenuItemTagSpeechMenu):
        (WebCore::contextMenuItemTagStartSpeaking):
        (WebCore::contextMenuItemTagStopSpeaking):
        (WebCore::contextMenuItemTagWritingDirectionMenu):
        (WebCore::contextMenuItemTagTextDirectionMenu):
        (WebCore::contextMenuItemTagDefaultDirection):
        (WebCore::contextMenuItemTagLeftToRight):
        (WebCore::contextMenuItemTagRightToLeft):
        (WebCore::contextMenuItemTagCorrectSpellingAutomatically):
        (WebCore::contextMenuItemTagSubstitutionsMenu):
        (WebCore::contextMenuItemTagShowSubstitutions):
        (WebCore::contextMenuItemTagSmartCopyPaste):
        (WebCore::contextMenuItemTagSmartQuotes):
        (WebCore::contextMenuItemTagSmartDashes):
        (WebCore::contextMenuItemTagSmartLinks):
        (WebCore::contextMenuItemTagTextReplacement):
        (WebCore::contextMenuItemTagTransformationsMenu):
        (WebCore::contextMenuItemTagMakeUpperCase):
        (WebCore::contextMenuItemTagMakeLowerCase):
        (WebCore::contextMenuItemTagCapitalize):
        (WebCore::contextMenuItemTagChangeBack):
        (WebCore::contextMenuItemTagOpenVideoInNewWindow):
        (WebCore::contextMenuItemTagOpenAudioInNewWindow):
        (WebCore::contextMenuItemTagCopyVideoLinkToClipboard):
        (WebCore::contextMenuItemTagCopyAudioLinkToClipboard):
        (WebCore::contextMenuItemTagToggleMediaControls):
        (WebCore::contextMenuItemTagToggleMediaLoop):
        (WebCore::contextMenuItemTagEnterVideoFullscreen):
        (WebCore::contextMenuItemTagMediaPlay):
        (WebCore::contextMenuItemTagMediaPause):
        (WebCore::contextMenuItemTagMediaMute):
        (WebCore::contextMenuItemTagInspectElement):
        (WebCore::searchMenuNoRecentSearchesText):
        (WebCore::searchMenuRecentSearchesText):
        (WebCore::searchMenuClearRecentSearchesText):
        (WebCore::AXWebAreaText):
        (WebCore::AXLinkText):
        (WebCore::AXListMarkerText):
        (WebCore::AXImageMapText):
        (WebCore::AXHeadingText):
        (WebCore::AXDefinitionListTermText):
        (WebCore::AXDefinitionListDefinitionText):
        (WebCore::AXARIAContentGroupText):
        (WebCore::AXButtonActionVerb):
        (WebCore::AXRadioButtonActionVerb):
        (WebCore::AXTextFieldActionVerb):
        (WebCore::AXCheckedCheckBoxActionVerb):
        (WebCore::AXUncheckedCheckBoxActionVerb):
        (WebCore::AXLinkActionVerb):
        (WebCore::AXMenuListPopupActionVerb):
        (WebCore::AXMenuListActionVerb):
        (WebCore::missingPluginText):
        (WebCore::crashedPluginText):
        (WebCore::multipleFileUploadText):
        (WebCore::unknownFileSizeText):
        (WebCore::uploadFileText):
        (WebCore::allFilesText):
        (WebCore::keygenMenuItem512):
        (WebCore::keygenMenuItem1024):
        (WebCore::keygenMenuItem2048):
        (WebCore::keygenKeychainItemName):
        (WebCore::imageTitle):
        (WebCore::mediaElementLoadingStateText):
        (WebCore::mediaElementLiveBroadcastStateText):
        (WebCore::localizedMediaControlElementString):
        (WebCore::localizedMediaControlElementHelpText):
        (WebCore::localizedMediaTimeDescription):
        (WebCore::validationMessageValueMissingText):
        (WebCore::validationMessageValueMissingForCheckboxText):
        (WebCore::validationMessageValueMissingForFileText):
        (WebCore::validationMessageValueMissingForMultipleFileText):
        (WebCore::validationMessageValueMissingForRadioText):
        (WebCore::validationMessageValueMissingForSelectText):
        (WebCore::validationMessageTypeMismatchText):
        (WebCore::validationMessageTypeMismatchForEmailText):
        (WebCore::validationMessageTypeMismatchForMultipleEmailText):
        (WebCore::validationMessageTypeMismatchForURLText):
        (WebCore::validationMessagePatternMismatchText):
        (WebCore::validationMessageTooLongText):
        (WebCore::validationMessageRangeUnderflowText):
        (WebCore::validationMessageRangeOverflowText):
        (WebCore::validationMessageStepMismatchText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@87578 268f45cc-cd09-0410-ab3c-d52691b4dbfc