WebKit-https.git
8 years agoDon't leak Documents when using MutationObserver from extensions
commit-queue@webkit.org [Sat, 2 Mar 2013 02:35:53 +0000 (02:35 +0000)]
Don't leak Documents when using MutationObserver from extensions
https://bugs.webkit.org/show_bug.cgi?id=111234

Patch by Elliott Sprehn <esprehn@gmail.com> on 2013-03-01
Reviewed by Adam Barth.

.:

* ManualTests/leak-observer-nonmain-world.html: Added.

Source/WebCore:

MutationObserverCallback holds a WorldContextHandle which secretly isn't
a handle to anything when it's for the main world. When it's for a non-main
world though, like those used in extensions, it becomes a strong reference
to the v8::Context which results in leaks by creating cycles:

MutationObserver -> Callback -> World -> Document -> Node -> MutationObserver.

Instead we should keep a RefPtr to a DOMWrapperWorld in the callback and then
get the v8::Context from that inside handleEvent.

Tests: ManualTests/leak-observer-nonmain-world.html

* bindings/v8/V8Binding.cpp:
(WebCore::toV8Context): Added overload that takes a DOMWrapperWorld.
* bindings/v8/V8Binding.h:
* bindings/v8/V8MutationCallback.cpp:
(WebCore::V8MutationCallback::V8MutationCallback):
(WebCore::V8MutationCallback::handleEvent):
* bindings/v8/V8MutationCallback.h:
(V8MutationCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBUILD FIX: testapi should link to Foundation, not CoreFoundation
ddkilzer@apple.com [Sat, 2 Mar 2013 01:31:54 +0000 (01:31 +0000)]
BUILD FIX: testapi should link to Foundation, not CoreFoundation

* JavaScriptCore.xcodeproj/project.pbxproj: Change testapi to
link to Foundation.framework instead of CoreFoundation.framework
since it uses NS types.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[css exclusions] Move ExclusionShapeInsideInfo into RenderBlockRareData
betravis@adobe.com [Sat, 2 Mar 2013 01:16:29 +0000 (01:16 +0000)]
[css exclusions] Move ExclusionShapeInsideInfo into RenderBlockRareData
https://bugs.webkit.org/show_bug.cgi?id=110995

Reviewed by Julien Chaffraix.

This patch moves ExclusionShapeInsideInfo into the RenderBlockRareData struct,
which enables us to move away from the global ExclusionShapeInsideInfo map.
Some additional refactoring was done to remove ExclusionShapeInsideInfo's
dependency on InlineIterator, which depended on RenderBlock. This work required
adding a new LineSegmentIterator struct.

Refactoring, no new tests.

* rendering/ExclusionShapeInsideInfo.cpp:
(WebCore):
(WebCore::LineSegmentRange::LineSegmentRange): Moving the InlineIterator
constructor to the .cpp file, as InlineIterator is now forward declared in
the .h file.
(WebCore::ExclusionShapeInsideInfo::isEnabledFor): Moving isEnabledFor to
the .cpp file, as RenderBlock is now forward declared in the .h file.
* rendering/ExclusionShapeInsideInfo.h:
(WebCore):
(LineSegmentIterator): A simple struct for containing segment positions for
layout.
(WebCore::LineSegmentIterator::LineSegmentIterator): Constructor.
(LineSegmentRange): Transitioning to store LineSegmentIterator.
(WebCore::LineSegmentRange::LineSegmentRange): Ditto.
(ExclusionShapeInsideInfo):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::willBeDestroyed): Destroying a block will now destroy
its ExclusionShapeInsideInfo, so there is no need to remove it from the map.
(WebCore):
(WebCore::RenderBlock::updateExclusionShapeInsideInfoAfterStyleChange): Use
the RenderBlockRareData struct rather than the global map.
* rendering/RenderBlock.h:
(WebCore):
(WebCore::RenderBlock::ensureExclusionShapeInsideInfo): Ensure an info struct
is present if the shape-inside style is set.
(WebCore::RenderBlock::exclusionShapeInsideInfo): Look up the info struct for
the current block.
(WebCore::RenderBlock::setExclusionShapeInsideInfo): Update the info struct
for the current block.
(RenderBlockRareData): Add the ExclusionShapeInsideInfo member.
* rendering/RenderBlockLineLayout.cpp:
(WebCore::constructBidiRunsForLine): Construct the appropriate offsets during
layout based on the stored LineSegmentIterators.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoEventHandler::handleGestureScrollUpdate() should invoke the user-generated scroll...
tdanderson@chromium.org [Sat, 2 Mar 2013 01:08:22 +0000 (01:08 +0000)]
EventHandler::handleGestureScrollUpdate() should invoke the user-generated scroll routines
so its behavior matches other user-initiated scrolls
https://bugs.webkit.org/show_bug.cgi?id=109769

Reviewed by James Robinson.

Source/WebCore:

To ensure that the scrolling behavior of GestureScrollUpdate events are consistent with
the scrolling behavior of mousewheel events, use the existing user-generated scroll logic
instead of calling into RenderLayer::scrollByRecursively(). This patch fixes the bug
reported in https://bugs.webkit.org/show_bug.cgi?id=109316, where the example page can
be scrolled using touch but cannot be scrolled using mousewheels.

Note that this patch does not use any of the mousewheel event-handling code.

Tests: fast/events/touch/gesture/touch-gesture-noscroll-body-propagated.html
       fast/events/touch/gesture/touch-gesture-noscroll-body-xhidden.html
       fast/events/touch/gesture/touch-gesture-noscroll-body-yhidden.html
       fast/events/touch/gesture/touch-gesture-noscroll-body.html

* page/EventHandler.cpp:
(WebCore::EventHandler::clear):
(WebCore::EventHandler::handleGestureEvent):
(WebCore::EventHandler::handleGestureScrollBegin):
(WebCore::EventHandler::handleGestureScrollUpdate):
(WebCore::EventHandler::sendScrollEventToView):
    By calling this function at the start of handleGestureScrollUpdate() in the case
    where |m_scrollGestureHandlingNode| is null, we ensure that the scroll updates
    can still scroll the page itself, if possible.
(WebCore):
(WebCore::EventHandler::clearGestureScrollNodes):
* page/EventHandler.h:
(EventHandler):
* platform/PlatformWheelEvent.h:
(WebCore::PlatformWheelEvent::setHasPreciseScrollingDeltas):

Source/WebKit/chromium:

Clear the nodes corresponding to a fling scroll event when the event ends.

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::updateAnimations):

LayoutTests:

Four new layout tests have been added and touch-gesture-scroll-page.html has been
modified to demonstrate that this patch fixes two existing bugs. See the inline
comments below for details.

Because I am now using the existing user-generated scroll logic, the delta for a single
GestureScrollUpdate event will not be propagated to the parent of the targeted node
unless the targeted node has no remaining scrollable area. So the changes to the
existing layout tests have been made to ensure that the targeted node has been fully
scrolled before subsequent GestureScrollUpdate events will scroll the parent(s) of
the targeted node.

I have also removed the function recordScroll() from the existing layout tests
because this function already exists in the included file resources/gesture-helpers.js.

* fast/events/touch/gesture/touch-gesture-noscroll-body-expected.txt: Added.
* fast/events/touch/gesture/touch-gesture-noscroll-body-propagated-expected.txt: Added.
* fast/events/touch/gesture/touch-gesture-noscroll-body-propagated.html: Copied from LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-page.html.
* fast/events/touch/gesture/touch-gesture-noscroll-body-xhidden-expected.txt: Added.
* fast/events/touch/gesture/touch-gesture-noscroll-body-xhidden.html: Copied from LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-page.html.
* fast/events/touch/gesture/touch-gesture-noscroll-body-yhidden-expected.txt: Added.
* fast/events/touch/gesture/touch-gesture-noscroll-body-yhidden.html: Copied from LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-page.html.
* fast/events/touch/gesture/touch-gesture-noscroll-body.html: Copied from LayoutTests/fast/events/touch/gesture/touch-gesture-scroll-page.html.
* fast/events/touch/gesture/touch-gesture-scroll-div-not-propagated.html:
* fast/events/touch/gesture/touch-gesture-scroll-div-propagated.html:
* fast/events/touch/gesture/touch-gesture-scroll-div-twice-propagated.html:
* fast/events/touch/gesture/touch-gesture-scroll-iframe-not-propagated.html:
* fast/events/touch/gesture/touch-gesture-scroll-iframe-propagated.html:
* fast/events/touch/gesture/touch-gesture-scroll-page-not-propagated.html:
* fast/events/touch/gesture/touch-gesture-scroll-page-propagated.html:
* fast/events/touch/gesture/touch-gesture-scroll-page.html:
      I modified this layout test in order to add test coverage for another bug
      which is fixed by this patch: if the hit test performed on a GestureScrollBegin
      does not target a specific node, the subsequent GestureScrollUpdate events should
      still attempt to scroll the page itself. This is consistent with how mousewheel
      events behave.
* platform/chromium/fast/events/touch/gesture/touch-gesture-noscroll-body-expected.txt: Added.
* platform/chromium/fast/events/touch/gesture/touch-gesture-noscroll-body-propagated-expected.txt: Added.
* platform/chromium/fast/events/touch/gesture/touch-gesture-noscroll-body-xhidden-expected.txt: Added.
* platform/chromium/fast/events/touch/gesture/touch-gesture-noscroll-body-yhidden-expected.txt: Added.
      These four new layout tests verify that a non-scrollable body will not scroll,
      as reported in https://bugs.webkit.org/show_bug.cgi?id=109316.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Revert r143827 to restore WebHelperPluginImpl's call to frameDetached()
commit-queue@webkit.org [Sat, 2 Mar 2013 01:05:07 +0000 (01:05 +0000)]
[chromium] Revert r143827 to restore WebHelperPluginImpl's call to frameDetached()
https://bugs.webkit.org/show_bug.cgi?id=111232

Patch by David Dorwin <ddorwin@chromium.org> on 2013-03-01
Reviewed by Adam Barth.

This patch reverts r143827, which causes a crash in failure conditions:
http://crbug.com/178848

* src/WebHelperPluginImpl.cpp:
(WebKit::WebHelperPluginImpl::destoryPage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIndexedDB: Avoid ScriptValue copies in IDBAny
alecflett@chromium.org [Sat, 2 Mar 2013 01:04:29 +0000 (01:04 +0000)]
IndexedDB: Avoid ScriptValue copies in IDBAny
https://bugs.webkit.org/show_bug.cgi?id=111002

Reviewed by Adam Barth.

This avoids some v8 handle thrashing in the long term,
and protects us against some crashes in the short term.

The crashes will be fixed in
https://bugs.webkit.org/show_bug.cgi?id=110206.

* Modules/indexeddb/IDBAny.cpp:
(WebCore::IDBAny::createNull):
(WebCore::IDBAny::createString):
(WebCore::IDBAny::IDBAny):
(WebCore::IDBAny::scriptValue):
* Modules/indexeddb/IDBAny.h:
(WebCore::IDBAny::create):
(IDBAny):
(WebCore::IDBAny::keyPath):
* bindings/v8/custom/V8IDBAnyCustom.cpp:
(WebCore::toV8):
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening of AppleWin port.
roger_fong@apple.com [Sat, 2 Mar 2013 01:01:47 +0000 (01:01 +0000)]
Unreviewed gardening of AppleWin port.

* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Upstream smart selection
commit-queue@webkit.org [Sat, 2 Mar 2013 01:00:59 +0000 (01:00 +0000)]
[BlackBerry] Upstream smart selection
https://bugs.webkit.org/show_bug.cgi?id=111226

Patch by Iris Wu <shuwu@rim.com> on 2013-03-01
Reviewed by Rob Buis.

1.  Extend the touch hold text selection to next paragraph.
2.  Draw and expand overlay over text as touch hold selection expands.
    Select paragraph when it's entirely covered by overlay.
3.  Start scrolling at a constant rate when the end of
    next pargraph is not in the viewport.

Reviewed Internally By Genevieve Mak and Mike Fenton.
PR 217897 238485 258279 279042 299779

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::selectAtDocumentPoint):
(BlackBerry::WebKit::WebPage::expandSelection):
(WebKit):
(BlackBerry::WebKit::WebPage::setOverlayExpansionPixelHeight):
(BlackBerry::WebKit::WebPagePrivate::setOverlayExpansionPixelHeight):
(BlackBerry::WebKit::WebPage::setParagraphExpansionPixelScrollMargin):
* Api/WebPage.h:
* Api/WebPageClient.h:
* Api/WebPage_p.h:
(WebPagePrivate):
* WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::cancelSelection):
(BlackBerry::WebKit::SelectionHandler::selectAtPoint):
(BlackBerry::WebKit::isInvalidLine):
(WebKit):
(BlackBerry::WebKit::isInvalidParagraph):
(BlackBerry::WebKit::SelectionHandler::selectNextParagraph):
(BlackBerry::WebKit::SelectionHandler::drawOverlay):
(BlackBerry::WebKit::SelectionHandler::findNextOverlayRegion):
(BlackBerry::WebKit::SelectionHandler::expandSelection):
(BlackBerry::WebKit::SelectionHandler::ensureSelectedTextVisible):
(BlackBerry::WebKit::SelectionHandler::setParagraphExpansionScrollMargin):
(BlackBerry::WebKit::SelectionHandler::expandSelectionToGranularity):
* WebKitSupport/SelectionHandler.h:
(SelectionHandler):
(BlackBerry::WebKit::SelectionHandler::setOverlayExpansionHeight):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening of AppleWin port.
roger_fong@apple.com [Sat, 2 Mar 2013 00:55:29 +0000 (00:55 +0000)]
Unreviewed gardening of AppleWin port.

* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening of AppleWin port.
roger_fong@apple.com [Fri, 1 Mar 2013 23:46:55 +0000 (23:46 +0000)]
Unreviewed gardening of AppleWin port.

* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Mark some software compositing tests as failing before landing anti-aliasi...
jamesr@google.com [Fri, 1 Mar 2013 23:22:00 +0000 (23:22 +0000)]
[chromium] Mark some software compositing tests as failing before landing anti-aliasing changes
https://bugs.webkit.org/show_bug.cgi?id=111224

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDon't use legacy test names when returning results from PerfTest.run
rniwa@webkit.org [Fri, 1 Mar 2013 22:55:03 +0000 (22:55 +0000)]
Don't use legacy test names when returning results from PerfTest.run
https://bugs.webkit.org/show_bug.cgi?id=111148

Reviewed by Dirk Pranke.

* Scripts/webkitpy/performance_tests/perftest.py:
(PerfTestMetric.name): Renamed from metric.
(PerfTest.test_name_without_file_extension): Extracted from legacy_chromium_bot_compatible_test_name.
(PerfTest.run): Use metric name instead of the legacy name to store iteration values.
(ChromiumStylePerfTest.parse_and_log_output): Use the metric name to store results as done in PerfTest.run.

* Scripts/webkitpy/performance_tests/perftest_unittest.py:
(TestPerfTestMetric.test_init_set_time_metric):
(TestPerfTestMetric.legacy_chromium_bot_compatible_test_name): Removed. The integration tests test this.
(TestReplayPerfTest.test_run_with_driver_accumulates_results):
(TestReplayPerfTest.test_run_with_driver_accumulates_memory_results):

* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner.__init__):
(PerfTestsRunner._generate_results_dict): Updated to iterate over (test, metrics) pair. Use view_source_url
to obtain the trac URL instead of hard coding it.
(PerfTestsRunner._run_tests_set):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Mark more flaky tests related to scrollbar ordering
enne@google.com [Fri, 1 Mar 2013 22:53:30 +0000 (22:53 +0000)]
[chromium] Mark more flaky tests related to scrollbar ordering
https://bugs.webkit.org/show_bug.cgi?id=111199

Unreviewed gardening.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSupport padding, margin and border for internal UA cue styling
vcarbune@chromium.org [Fri, 1 Mar 2013 22:42:02 +0000 (22:42 +0000)]
Support padding, margin and border for internal UA cue styling
https://bugs.webkit.org/show_bug.cgi?id=110703

Reviewed by Eric Carlson.

Source/WebCore:

For some particular user agent styling this allows the possibility
of making the window around the cue text bigger to match some user
styles (see CaptionUserPreferencesMac::captionsStyleSheetOverride).

These properties *cannot* be set through by using the ::cue
pseudo-element and, as specified, are used only internally.

Note: This patch is identical to the previously commited one,
as it was rolled back without related tests failing.

Test: media/track/track-cue-rendering-with-padding.html

* css/mediaControls.css:
(video::-webkit-media-text-track-display): Set the CSS box model
to include in the specified width or height the values of
padding / margin / border by using -webkit-box-sizing and avoid
overflow over 100% width because of having these properties set.
* rendering/RenderTextTrackCue.cpp:
(WebCore::RenderTextTrackCue::isOutside): To not interfere with
the regular WebVTT positioning algorithm, the check is done for
the absolute content box.
(WebCore::RenderTextTrackCue::repositionCueSnapToLinesSet): Added
an extra adjustment step to accomodate vertical padding (and not
overflow the cue container)

LayoutTests:

* media/track/track-cue-rendering-with-padding-expected.txt: Added.
* media/track/track-cue-rendering-with-padding.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION (r125809): CFStrings created via StringImpl::createCFString() might refer...
aestes@apple.com [Fri, 1 Mar 2013 22:39:10 +0000 (22:39 +0000)]
REGRESSION (r125809): CFStrings created via StringImpl::createCFString()  might reference freed memory when Objective-C garbage collection is enabled
https://bugs.webkit.org/show_bug.cgi?id=111219

Reviewed by Benjamin Poulain.

StringImpl::createCFString() uses CFStringCreateWithBytesNoCopy() in
order to create CFString without making an unnecessary copy. In order
to ensure that the the StringImpl's backing buffer isn't deallocated
while the CFString is still alive, we use a custom CFAllocator to
ref/deref the StringImpl at the appropriate times.

However, custom allocators aren't supported when Objective-C garbage
collection is enabled, so in this case we use the default CF allocator.
Since we can't guarantee the lifetime of the StringImpl in this case,
we should just fall back to copying the string, as we did prior to r125809.

* platform/text/cf/StringImplCF.cpp:
(garbageCollectionEnabled): Moved the check for whether garbage
collection is enabled from StringWrapperCFAllocator::create() to here.
(WTF::StringWrapperCFAllocator::create): Call garbageCollectionEnabled().
(WTF::StringImpl::createCFString): If garbage collection is enabled,
call the variants of CFStringCreate that copy the string.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Expose more of the configuration step to the gyp build
commit-queue@webkit.org [Fri, 1 Mar 2013 22:38:28 +0000 (22:38 +0000)]
[GTK] Expose more of the configuration step to the gyp build
https://bugs.webkit.org/show_bug.cgi?id=111213

Patch by Martin Robinson <mrobinson@igalia.com> on 2013-03-01
Reviewed by Dirk Pranke.

Expose more of the configuration phase to the gyp build, including WebKit features
and binary paths.

* gyp/Configuration.gypi.in: Add templatized gyp variables for the new configuration bits.
* gyp/autogen.sh: Properly link up the WebKit features script. So we can access it
relatively as if we were at the top-level of the source directory.
* gyp/configure.ac: Export the WebKit features.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAX: Upstream iOS Accessibility layout tests
cfleizach@apple.com [Fri, 1 Mar 2013 22:22:03 +0000 (22:22 +0000)]
AX: Upstream iOS Accessibility layout tests
https://bugs.webkit.org/show_bug.cgi?id=111187

Reviewed by David Kilzer.

Upstream the latest iOS Accessibility layout tests.

* platform/iphone-simulator: Added.
* platform/iphone-simulator/accessibility: Added.
* platform/iphone-simulator/accessibility/accessibility-aria-table-children-expected.txt: Added.
* platform/iphone-simulator/accessibility/accessibility-aria-table-children.html: Added.
* platform/iphone-simulator/accessibility/accessibility-crash-in-axcontainer-expected.txt: Added.
* platform/iphone-simulator/accessibility/accessibility-crash-in-axcontainer.html: Added.
* platform/iphone-simulator/accessibility/accessibility-hint-expected.txt: Added.
* platform/iphone-simulator/accessibility/accessibility-hint.html: Added.
* platform/iphone-simulator/accessibility/aria-pressed-state-expected.txt: Added.
* platform/iphone-simulator/accessibility/aria-pressed-state.html: Added.
* platform/iphone-simulator/accessibility/centerpoint-expected.txt: Added.
* platform/iphone-simulator/accessibility/centerpoint.html: Added.
* platform/iphone-simulator/accessibility/dom-focus-fires-on-correct-element-expected.txt: Added.
* platform/iphone-simulator/accessibility/dom-focus-fires-on-correct-element.html: Added.
* platform/iphone-simulator/accessibility/focus-change-notifications-expected.txt: Added.
* platform/iphone-simulator/accessibility/focus-change-notifications.html: Added.
* platform/iphone-simulator/accessibility/header-elements-expected.txt: Added.
* platform/iphone-simulator/accessibility/header-elements.html: Added.
* platform/iphone-simulator/accessibility/identifier-expected.txt: Added.
* platform/iphone-simulator/accessibility/identifier.html: Added.
* platform/iphone-simulator/accessibility/internal-link-expected.txt: Added.
* platform/iphone-simulator/accessibility/internal-link.html: Added.
* platform/iphone-simulator/accessibility/link-with-images-text-expected.txt: Added.
* platform/iphone-simulator/accessibility/link-with-images-text.html: Added.
* platform/iphone-simulator/accessibility/link-with-only-image-expected.txt: Added.
* platform/iphone-simulator/accessibility/link-with-only-image.html: Added.
* platform/iphone-simulator/accessibility/math-expected.txt: Added.
* platform/iphone-simulator/accessibility/math.html: Added.
* platform/iphone-simulator/accessibility/mixed-checkboxes-expected.txt: Added.
* platform/iphone-simulator/accessibility/mixed-checkboxes.html: Added.
* platform/iphone-simulator/accessibility/no-child-link-header-expected.txt: Added.
* platform/iphone-simulator/accessibility/no-child-link-header.html: Added.
* platform/iphone-simulator/accessibility/non-contiguous-link-expected.txt: Added.
* platform/iphone-simulator/accessibility/non-contiguous-link.html: Added.
* platform/iphone-simulator/accessibility/password-value-expected.txt: Added.
* platform/iphone-simulator/accessibility/password-value.html: Added.
* platform/iphone-simulator/accessibility/placeholder-value-expected.txt: Added.
* platform/iphone-simulator/accessibility/placeholder-value.html: Added.
* platform/iphone-simulator/accessibility/popup-button-value-label-expected.txt: Added.
* platform/iphone-simulator/accessibility/popup-button-value-label.html: Added.
* platform/iphone-simulator/accessibility/radio-button-expected.txt: Added.
* platform/iphone-simulator/accessibility/radio-button.html: Added.
* platform/iphone-simulator/accessibility/secure-text-field-expected.txt: Added.
* platform/iphone-simulator/accessibility/secure-text-field.html: Added.
* platform/iphone-simulator/accessibility/selected-buttons-expected.txt: Added.
* platform/iphone-simulator/accessibility/selected-buttons.html: Added.
* platform/iphone-simulator/accessibility/selected-text-expected.txt: Added.
* platform/iphone-simulator/accessibility/selected-text.html: Added.
* platform/iphone-simulator/accessibility/tab-role-expected.txt: Added.
* platform/iphone-simulator/accessibility/tab-role.html: Added.
* platform/iphone-simulator/accessibility/table-cell-for-row-col-expected.txt: Added.
* platform/iphone-simulator/accessibility/table-cell-for-row-col.html: Added.
* platform/iphone-simulator/accessibility/table-cell-ranges-expected.txt: Added.
* platform/iphone-simulator/accessibility/table-cell-ranges.html: Added.
* platform/iphone-simulator/accessibility/tables-lists-expected.txt: Added.
* platform/iphone-simulator/accessibility/tables-lists.html: Added.
* platform/iphone-simulator/accessibility/text-line-no-ignored-elements-expected.txt: Added.
* platform/iphone-simulator/accessibility/text-line-no-ignored-elements.html: Added.
* platform/iphone-simulator/accessibility/text-marker-list-item-expected.txt: Added.
* platform/iphone-simulator/accessibility/text-marker-list-item.html: Added.
* platform/iphone-simulator/accessibility/text-marker-validation-expected.txt: Added.
* platform/iphone-simulator/accessibility/text-marker-validation.html: Added.
* platform/iphone-simulator/accessibility/text-role-expected.txt: Added.
* platform/iphone-simulator/accessibility/text-role.html: Added.
* platform/iphone-simulator/accessibility/textfield-in-axvalue-expected.txt: Added.
* platform/iphone-simulator/accessibility/textfield-in-axvalue.html: Added.
* platform/iphone-simulator/accessibility/url-test-expected.txt: Added.
* platform/iphone-simulator/accessibility/url-test.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed AppleWin build fix.
roger_fong@apple.com [Fri, 1 Mar 2013 22:14:33 +0000 (22:14 +0000)]
Unreviewed AppleWin build fix.

* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::ResourceHandle::createCFURLConnection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Allow sharing the WebCore include list with the Chromium build
commit-queue@webkit.org [Fri, 1 Mar 2013 22:03:48 +0000 (22:03 +0000)]
[GTK] Allow sharing the WebCore include list with the Chromium build
https://bugs.webkit.org/show_bug.cgi?id=110241

Patch by Martin Robinson <mrobinson@igalia.com> on 2013-03-01
Reviewed by Dirk Pranke.

* WebCore.gyp/WebCoreGTK.gyp: Added. A skeleton gyp file for WebCoreGTK+.
* WebCore.gypi: Added shared include directories.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Add an extra project that assembles all project build logs on Windows...
roger_fong@apple.com [Fri, 1 Mar 2013 22:02:03 +0000 (22:02 +0000)]
Unreviewed. Add an extra project that assembles all project build logs on Windows into a single file.
https://bugs.webkit.org/show_bug.cgi?id=111202

This is useful for running VCExpress builds from command line because there is
no unified solution output, only per project build logs.
The project will be run as the last project in the solution.

* win/AssembleBuildLogs: Added.
* win/AssembleBuildLogs/AssembleBuildLogs.vcxproj: Added.
* win/AssembleBuildLogs/AssembleBuildLogs.vcxproj.filters: Added.
* win/AssembleBuildLogs/AssembleLogs.cmd: Added.
* win/AssembleBuildLogs/README: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago Make in-memory blobs work in NetworkProcess
ap@apple.com [Fri, 1 Mar 2013 22:00:57 +0000 (22:00 +0000)]
    Make in-memory blobs work in NetworkProcess
        https://bugs.webkit.org/show_bug.cgi?id=111132

        Reviewed by Sam Weinig.

        * NetworkProcess/NetworkConnectionToWebProcess.cpp:
        (WebKit::NetworkConnectionToWebProcess::registerBlobURL):
        (WebKit::NetworkConnectionToWebProcess::registerBlobURLFromURL):
        (WebKit::NetworkConnectionToWebProcess::unregisterBlobURL):
        * NetworkProcess/NetworkConnectionToWebProcess.h:
        Implement BlobRegistry interface by using BlobRegistryImpl (same one as used in
        WebProcess in non-PPT mode).

        * NetworkProcess/NetworkConnectionToWebProcess.messages.in: Added three messages
        needed for BlobRegistry.

        * NetworkProcess/NetworkProcess.cpp:
        * NetworkProcess/NetworkProcessPlatformStrategies.cpp: Added.
        * NetworkProcess/NetworkProcessPlatformStrategies.h: Added.
        Added a mostly empty platform strategy, just for FormData to talk to BlobRegistry.
        Perhaps we'll find a way to avoid this WebCore code path in NetworkProcess, because
        we obviously know which registry implementation is in use in this process.

        * Shared/FileAPI: Added.
        * Shared/FileAPI/BlobRegistrationData.cpp: Added.
        * Shared/FileAPI/BlobRegistrationData.h: Added.
        Added a class for passing BlobData and extension handles over IPC.
        This uses a trick with mutable a member to avoid copying decoded BlobStorageData.

        * WebKit2.xcodeproj/project.pbxproj:
        * WebProcess/FileAPI: Added.
        * WebProcess/FileAPI/BlobRegistryProxy.cpp: Added.
        * WebProcess/FileAPI/BlobRegistryProxy.h: Added.
        A proxy implementation of BlobRegistry that just sends requests over IPC. We only
        need async ones.

        * WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
        (WebKit::WebPlatformStrategies::createBlobRegistry):
        * WebProcess/WebCoreSupport/WebPlatformStrategies.h:
        Create an appropriate BlobRegistry.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoThreaded HTML Parser has an extra copy of every byte from the network
eric@webkit.org [Fri, 1 Mar 2013 21:53:26 +0000 (21:53 +0000)]
Threaded HTML Parser has an extra copy of every byte from the network
https://bugs.webkit.org/show_bug.cgi?id=111135

Reviewed by Adam Barth.

Source/WebCore:

Every LayoutTest executes this code in threaded parsing mode.

* dom/DecodedDataDocumentParser.cpp:
(WebCore::DecodedDataDocumentParser::appendBytes):
 - Pass ownership of the decoded string to the parser.
(WebCore::DecodedDataDocumentParser::flush):
 - Same.
* dom/DecodedDataDocumentParser.h:
(DecodedDataDocumentParser):
* dom/Document.cpp:
(WebCore::Document::setContent):
* dom/DocumentParser.h:
(DocumentParser):
* dom/RawDataDocumentParser.h:
(WebCore::RawDataDocumentParser::append):
* html/FTPDirectoryDocument.cpp:
(FTPDirectoryDocumentParser):
(WebCore::FTPDirectoryDocumentParser::append):
* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::append):
* html/parser/HTMLDocumentParser.h:
(HTMLDocumentParser):
* html/parser/HTMLViewSourceParser.cpp:
(WebCore::HTMLViewSourceParser::append):
* html/parser/HTMLViewSourceParser.h:
(HTMLViewSourceParser):
* html/parser/TextDocumentParser.cpp:
(WebCore::TextDocumentParser::append):
* html/parser/TextDocumentParser.h:
(TextDocumentParser):
* loader/DocumentWriter.cpp:
(WebCore::DocumentWriter::replaceDocument):
* xml/parser/XMLDocumentParser.cpp:
(WebCore::XMLDocumentParser::append):
* xml/parser/XMLDocumentParser.h:
(XMLDocumentParser):
* xml/parser/XMLDocumentParserLibxml2.cpp:
(WebCore::XMLDocumentParser::resumeParsing):

Source/WTF:

The threaded html parser needs to accept ownership
of a string buffer.  The easiest way to do this seemed
to be to use a PassRefPtr<StringImpl>, but there was no way
to generated one from a String (easily), so I added one.

* wtf/text/WTFString.h:
(WTF::String::releaseImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[New Multicolumn] Change inRenderFlowThread to follow containing block chain
hyatt@apple.com [Fri, 1 Mar 2013 21:44:06 +0000 (21:44 +0000)]
[New Multicolumn] Change inRenderFlowThread to follow containing block chain
https://bugs.webkit.org/show_bug.cgi?id=111206

Reviewed by Simon Fraser.

Source/WebCore:

This patch removes inRenderFlowThread and changes enclosingRenderFlowThread()
to flowThreadContainingBlock(). flowThreadContainingBlock() now follows
the containing block chain instead of the parent chain when outside of layout.
(It already did the right thing when called during layout.)

By removing inRenderFlowThread (which was following the parent chain), all
code that is checking for flow thread containment now correctly uses the
containing block chain. This allows for content to escape in-flow flow threads
and do the right thing without asserting.

Test: fast/multicol/positioned-outside-of-columns.html

* dom/WebKitNamedFlow.cpp:
(WebCore::inFlowThread):
(WebCore::WebKitNamedFlow::getRegionsByContent):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::removeLeftoverAnonymousBlock):
(WebCore::RenderBlock::collapseAnonymousBoxChild):
(WebCore::RenderBlock::updateRegionsAndExclusionsLogicalSize):
(WebCore::RenderBlock::computeRegionRangeForBlock):
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::computeOverflow):
(WebCore::RenderBlock::determineLogicalLeftPositionForChild):
(WebCore::RenderBlock::computeLogicalLocationForFloat):
(WebCore::RenderBlock::logicalLeftOffsetForContent):
(WebCore::RenderBlock::logicalRightOffsetForContent):
(WebCore::RenderBlock::hasNextPage):
(WebCore::RenderBlock::applyBeforeBreak):
(WebCore::RenderBlock::applyAfterBreak):
(WebCore::RenderBlock::pageLogicalTopForOffset):
(WebCore::RenderBlock::pageLogicalHeightForOffset):
(WebCore::RenderBlock::pageRemainingLogicalHeightForOffset):
(WebCore::RenderBlock::adjustForUnsplittableChild):
(WebCore::RenderBlock::adjustLinePositionForPagination):
(WebCore::RenderBlock::lineWidthForPaginatedLineChanged):
(WebCore::RenderBlock::offsetFromLogicalTopOfFirstPage):
(WebCore::RenderBlock::regionAtBlockOffset):
(WebCore::RenderBlock::setStaticInlinePositionForChild):
(WebCore::RenderBlock::logicalWidthChangedInRegions):
(WebCore::RenderBlock::clampToStartAndEndRegions):
* rendering/RenderBlock.h:
(RenderBlock):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::layoutExclusionShapeInsideInfo):
(WebCore::LineLayoutState::LineLayoutState):
(WebCore::LineLayoutState::flowThread):
(WebCore::LineLayoutState::setFlowThread):
(LineLayoutState):
(WebCore::RenderBlock::layoutRunsAndFloatsInRange):
(WebCore::RenderBlock::linkToEndLineIfNeeded):
(WebCore::RenderBlock::layoutInlineChildren):
(WebCore::RenderBlock::determineStartPosition):
(WebCore::RenderBlock::checkPaginationAndFloatsAtEndLine):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::clearRenderBoxRegionInfo):
(WebCore::RenderBox::renderBoxRegionInfo):
(WebCore::RenderBox::containingBlockLogicalWidthForPositioned):
(WebCore::RenderBox::containingBlockLogicalHeightForPositioned):
(WebCore::RenderBox::computePositionedLogicalWidth):
(WebCore::RenderBox::computePositionedLogicalHeight):
* rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutBlock):
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::objectInFlowRegion):
* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::layoutBlock):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::updateAlwaysCreateLineBoxes):
* rendering/RenderLayer.cpp:
(WebCore::accumulateOffsetTowardsAncestor):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::canBeComposited):
* rendering/RenderMedia.cpp:
(WebCore::RenderMedia::layout):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::locateFlowThreadContainingBlock):
(WebCore::RenderObject::containerForRepaint):
(WebCore::RenderObject::willBeRemovedFromTree):
(WebCore::RenderObject::removeFromRenderFlowThread):
(WebCore::RenderObject::removeFromRenderFlowThreadRecursive):
* rendering/RenderObject.h:
(RenderObject):
(WebCore::RenderObject::flowThreadContainingBlock):
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::setObjectStyleInRegion):
* rendering/RenderView.cpp:
(WebCore::RenderView::addChild):
(WebCore::RenderView::initializeLayoutState):
(WebCore::RenderView::setSelection):
* rendering/RenderView.h:
(WebCore::RenderView::pushLayoutState):
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::containingRegion):
(WebCore::RootInlineBox::setContainingRegion):

LayoutTests:

* fast/multicol/positioned-outside-of-columns-expected.html: Added.
* fast/multicol/positioned-outside-of-columns.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUncomment ENABLE_SVG guards to avoid having WebKitPluginProcess link
zandobersek@gmail.com [Fri, 1 Mar 2013 21:36:51 +0000 (21:36 +0000)]
Uncomment ENABLE_SVG guards to avoid having WebKitPluginProcess link
against libWebCoreSVG.la when SVG is disabled.

Rubber-stamped by Gustavo Noronha.

* GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd SPI for marking a WebView as doing things on behalf of another process
weinig@apple.com [Fri, 1 Mar 2013 21:32:43 +0000 (21:32 +0000)]
Add SPI for marking a WebView as doing things on behalf of another process
https://bugs.webkit.org/show_bug.cgi?id=111125

Reviewed by Alexey Proskuryakov.

Source/WebCore:

* platform/network/NetworkingContext.h:
(NetworkingContext):
* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::ResourceHandle::createCFURLConnection):
* platform/network/mac/ResourceHandleMac.mm:
(WebCore::ResourceHandle::createNSURLConnection):
Set the sourceApplicationAuditData on the URL connection if available.

Source/WebKit/mac:

* WebCoreSupport/WebFrameNetworkingContext.h:
(WebFrameNetworkingContext):
* WebCoreSupport/WebFrameNetworkingContext.mm:
(WebFrameNetworkingContext::sourceApplicationAuditData):
* WebView/WebView.mm:
(-[WebView _setSourceApplicationAuditData:]):
(-[WebView _sourceApplicationAuditData]):
* WebView/WebViewData.h:
* WebView/WebViewData.mm:
(-[WebViewPrivate dealloc]):
* WebView/WebViewPrivate.h:
Add SPI for setting a source application for a WebView.

Source/WebKit2:

* NetworkProcess/mac/RemoteNetworkingContext.h:
* NetworkProcess/mac/RemoteNetworkingContext.mm:
(WebKit::RemoteNetworkingContext::sourceApplicationAuditData):
* WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.h:
* WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
(WebKit::WebFrameNetworkingContext::sourceApplicationAuditData):
Stub out sourceApplicationAuditData() client function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Screen went black while navigating back/forward on the reddit.com page
zhajiang@rim.com [Fri, 1 Mar 2013 21:31:34 +0000 (21:31 +0000)]
[BlackBerry] Screen went black while navigating back/forward on the reddit.com page
https://bugs.webkit.org/show_bug.cgi?id=111192

Patch by Jacky Jiang <zhajiang@rim.com>.
Reviewed by Rob Buis.
Internally reviewed by Jakob Petsovits.

PR: 299783
When going back to the previous reddit.com page, the actual contents
size was much less than the history contents size. However, we expanded
the actual contents size to history contents size which caused a huge
black area below the actual contents.
To fix that, don't restore the contents size from history contents size
and scroll back to the valid contents area if we are about to overscroll.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::restoreHistoryViewState):
* Api/WebPage_p.h:
(WebPagePrivate):
* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::restoreViewState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Increase number of patches processed before clean building on WinEWS...
roger_fong@apple.com [Fri, 1 Mar 2013 21:26:51 +0000 (21:26 +0000)]
Unreviewed. Increase number of patches processed before clean building on WinEWS bots.

* EWSTools/start-queue-win.sh:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Windows] Unreviewed VS2010 build fix.
bfulgham@webkit.org [Fri, 1 Mar 2013 21:18:46 +0000 (21:18 +0000)]
[Windows] Unreviewed VS2010 build fix.

* WebCore.vcxproj/WebCore.vcxproj: Add missing TimelineTraceEventProcessor
  files to the project.
* WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Add ANGLE to the GTK+ gyp build
commit-queue@webkit.org [Fri, 1 Mar 2013 21:18:12 +0000 (21:18 +0000)]
[GTK] Add ANGLE to the GTK+ gyp build
https://bugs.webkit.org/show_bug.cgi?id=111128

Patch by Martin Robinson <mrobinson@igalia.com> on 2013-03-01
Reviewed by Dirk Pranke.

Add files that build an ANGLE static library for GTK+ using gyp.

* ANGLE.gyp/ANGLE.gyp: Added.
* ANGLE.gypi: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoObjective-C API: Passing JS functions to Objective-C callbacks causes JSValue to...
mhahnenberg@apple.com [Fri, 1 Mar 2013 21:14:24 +0000 (21:14 +0000)]
Objective-C API: Passing JS functions to Objective-C callbacks causes JSValue to leak
https://bugs.webkit.org/show_bug.cgi?id=107836

Reviewed by Oliver Hunt.

We've decided to remove support for this feature from the API because there's no way to automatically manage
the memory for clients in a satisfactory manner. Clients can still pass JS functions to Objective-C methods,
but the methods must accept plain JSValues instead of Objective-C blocks.

We now ignore functions that are part of a protocol that inherits from JSExport that accept blocks as arguments.

* API/JSBlockAdaptor.h: Removed.
* API/JSBlockAdaptor.mm: Removed.
* API/ObjCCallbackFunction.mm:
(ArgumentTypeDelegate::typeBlock): Return nil to signal that we want to ignore this function when copying it
to the object from the protocol.
* API/tests/testapi.mm: Added a test to make sure that we ignore methods declared as part of a JSExport-ed protocol
that have block arguments.
(-[TestObject bogusCallback:]):
* JavaScriptCore.gypi: Updated build files.
* JavaScriptCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Improve input bounds clipping for search fields.
mifenton@rim.com [Fri, 1 Mar 2013 21:07:34 +0000 (21:07 +0000)]
[BlackBerry] Improve input bounds clipping for search fields.
https://bugs.webkit.org/show_bug.cgi?id=111204

Reviewed by Rob Buis.

PR 292673.

Use the standardized InputHandler function to get the
bounds of an input field so that search fields are
truncated smaller to account for the X.

Reviewed Internally by Gen Mak.

* WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::setCaretPosition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[css exclusions] setting shape-inside on a parent does not relayout child blocks...
betravis@adobe.com [Fri, 1 Mar 2013 21:02:16 +0000 (21:02 +0000)]
[css exclusions] setting shape-inside on a parent does not relayout child blocks' inline content
https://bugs.webkit.org/show_bug.cgi?id=108128

Reviewed by David Hyatt.

Source/WebCore:

Ensure that blocks lay out when their parent's shape-inside changes.
ExclusionShapeInsideInfo now stores an additional flag indicating whether
the shape has changed and its block's children require layout. Each block
can look up the flag via LayoutState to determine whether it needs to lay
out its children.

Test: fast/exclusions/shape-inside/shape-inside-dynamic-nested.html

* rendering/ExclusionShapeInfo.h:
(WebCore::ExclusionShapeInfo::shapeSizeDirty): Add a method to determine
if the shape has changed.
(ExclusionShapeInfo):
* rendering/ExclusionShapeInsideInfo.h:
(WebCore::ExclusionShapeInsideInfo::setNeedsLayout): Set the flag indicating
layout is necessary.
(WebCore::ExclusionShapeInsideInfo::needsLayout): Retrieve the layout flag.
(ExclusionShapeInsideInfo):
(WebCore::ExclusionShapeInsideInfo::ExclusionShapeInsideInfo): Initialize
the layout flag.
* rendering/RenderBlock.cpp:
(WebCore::exclusionInfoRequiresRelayout): Return true if the shape info should
cause a relayout. Also update the needsLayout flag on the ExclusionShapeInsideInfo.
(WebCore):
(WebCore::RenderBlock::updateRegionsAndExclusionsLogicalSize): Return a boolean
indicating whether regions or exclusions updates should cause a relayout.
(WebCore::RenderBlock::layoutBlock): Relayout children if the shape inside has
changed.
* rendering/RenderBlock.h:
(RenderBlock):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutExclusionShapeInsideInfo): Changing to be a
class method.
(WebCore::LineWidth::LineWidth): Changing to use class method.
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Ditto.
(WebCore::constructBidiRunsForLine): Ditto.
(WebCore::RenderBlock::layoutRunsAndFloatsInRange): Ditto.
(WebCore::RenderBlock::LineBreaker::nextLineBreak): Ditto.

LayoutTests:

Test that setting and resetting shape-inside and shape-outside correctly lay out
content inside of child blocks.

* fast/exclusions/shape-inside/shape-inside-dynamic-nested-expected.html: Added.
* fast/exclusions/shape-inside/shape-inside-dynamic-nested.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDFG Branch(LogicalNot) peephole should not try to optimize and work-around the case...
fpizlo@apple.com [Fri, 1 Mar 2013 20:57:37 +0000 (20:57 +0000)]
DFG Branch(LogicalNot) peephole should not try to optimize and work-around the case where LogicalNot may be otherwise live
https://bugs.webkit.org/show_bug.cgi?id=111209

Reviewed by Oliver Hunt.

Even if it is then everything will work just fine. It's not necessary to check the ref count here.

* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agogetComputedStyle not implemented for -webkit-column-rule shorthand
commit-queue@webkit.org [Fri, 1 Mar 2013 20:49:51 +0000 (20:49 +0000)]
getComputedStyle not implemented for -webkit-column-rule shorthand
https://bugs.webkit.org/show_bug.cgi?id=111203

Patch by Uday Kiran <udaykiran@motorola.com> on 2013-03-01
Reviewed by Alexis Menard.

Source/WebCore:

Implement getComputedStyle for -webkit-column-rule property.

Test: fast/css/getComputedStyle/getComputedStyle-column-rule.html

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

LayoutTests:

Add test to check getComputedStyle for -webkit-column-rule.

* fast/css/getComputedStyle/getComputedStyle-column-rule-expected.txt: Added.
* fast/css/getComputedStyle/getComputedStyle-column-rule.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION(r144318) 1-7% perf. regression on SVG/SvgHitTesting
hyatt@apple.com [Fri, 1 Mar 2013 20:46:20 +0000 (20:46 +0000)]
REGRESSION(r144318) 1-7% perf. regression on SVG/SvgHitTesting
https://bugs.webkit.org/show_bug.cgi?id=111117

Make sure the allocated vector has a capacity of 1, since that is
far and away the most common case.

Reviewed by Andreas Kling.

* rendering/RenderFlowThread.h:
(WebCore):
* rendering/RenderLayer.h:
(WebCore):
* rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::collectLayerFragments):
* rendering/RenderMultiColumnSet.h:
* rendering/RenderRegion.h:
(WebCore):
(WebCore::RenderRegion::collectLayerFragments):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCrash at WebCore::SharedBuffer::hasPlatformData writing an image to the pasteboard.
enrica@apple.com [Fri, 1 Mar 2013 20:43:00 +0000 (20:43 +0000)]
Crash at WebCore::SharedBuffer::hasPlatformData writing an image to the pasteboard.
https://bugs.webkit.org/show_bug.cgi?id=111211.
<rdar://problem/8772758>

Reviewed by Ryosuke Niwa.

This is a speculative fix since we don't have a solid repro case.
Adding null check every time we build a SharedBuffer from an NSData
we have obtained manipulating data from the pasteboard.

* platform/mac/PasteboardMac.mm:
(WebCore::writeFileWrapperAsRTFDAttachment):
(WebCore::Pasteboard::writeImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDFG CSE phase shouldn't rely on ref count of nodes, since it doesn't have to
fpizlo@apple.com [Fri, 1 Mar 2013 20:40:05 +0000 (20:40 +0000)]
DFG CSE phase shouldn't rely on ref count of nodes, since it doesn't have to
https://bugs.webkit.org/show_bug.cgi?id=111205

Reviewed by Oliver Hunt.

I don't understand the intuition behind setLocalStoreElimination() validating that the SetLocal's ref count
is 1. I believe this is a hold-over from when setLocalStoreElimination() would match one SetLocal to another,
and then try to eliminate the first SetLocal. But that's not how it works now. Now, setLocalStoreElimination()
is actually Flush elimination: it eliminates any Flush that anchors a SetLocal if it proves that every path
from the SetLocal to the Flush is devoid of operations that may observe the local. It doesn't actually kill
the SetLocal itself: if the SetLocal is live because of other things (other Flushes or GetLocals in other
basic blocks), then the SetLocal will naturally still be alive because th Flush was only keeping the SetLocal
alive by one count rather than being solely responsible for its liveness.

* dfg/DFGCSEPhase.cpp:
(JSC::DFG::CSEPhase::setLocalStoreElimination):
(JSC::DFG::CSEPhase::eliminate):
(JSC::DFG::CSEPhase::performNodeCSE):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCrash at WebCore::SharedBuffer::hasPlatformData during paste.
enrica@apple.com [Fri, 1 Mar 2013 20:26:43 +0000 (20:26 +0000)]
Crash at WebCore::SharedBuffer::hasPlatformData during paste.
https://bugs.webkit.org/show_bug.cgi?id=111207.
<rdar://problem/13024528>

Reviewed by Ryosuke Niwa.

This is a speculative fix since we don't have a solid repro case.
Adding null check every time we get a SharedBuffer from the pasteboard.

* platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::plainText):
(WebCore::documentFragmentWithRTF):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDon't return statistics in PerfTest.run
rniwa@webkit.org [Fri, 1 Mar 2013 20:04:13 +0000 (20:04 +0000)]
Don't return statistics in PerfTest.run
https://bugs.webkit.org/show_bug.cgi?id=111145

Reviewed by Dirk Pranke.

Simply return a list of values obtained in each iteration from PerfTest.run.
Also simplify various methods as needed.

* Scripts/webkitpy/performance_tests/perftest.py:
(PerfTestMetric.__init__): Moved the code to convert 'Time' metric to 'FrameRate' and 'Runs'
as needed from PerfTestsRunner._generate_results_dict.

(PerfTestMetric.legacy_chromium_bot_compatible_test_name): Always append the metric name now
that we don't have to worry about the backward compatibility here.

(PerfTestMetric.iteration_values): Added.
(PerfTestMetric.unit): Added.
(PerfTestMetric.metric_to_unit):
(PerfTestMetric.time_unit_to_metric): Extracted from PerfTestsRunner._generate_results_dict.

(PerfTest.run):
(PerfTest.log_statistics): Merged compute_statistics and self.output_statistics.

* Scripts/webkitpy/performance_tests/perftest_unittest.py:
(TestPerfTestMetric.test_init_set_missing_unit):
(TestPerfTestMetric.test_init_set_time_metric): Added.
(TestPerfTestMetric.test_legacy_chromium_bot_compatible_test_name):
(TestPerfTestMetric.test_append):
(TestPerfTestMetric.test_compute_statistics): Removed. Integration tests check some of these
test cases and it's not critical to keep math right as they're not used in output JSON anymore.
(TestPerfTest._assert_results_are_correct):
(TestReplayPerfTest.test_run_with_driver_accumulates_results):
(TestReplayPerfTest.test_run_with_driver_accumulates_memory_results):

* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner._generate_results_dict):

* Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
(EventTargetWrapperTestData): The metric name shows up at the end of the test name as expected.
(SomeParserTestData): Ditto.
(MemoryTestData): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRename MovHint to MovHintEvent so I can create a NodeType called MovHint
fpizlo@apple.com [Fri, 1 Mar 2013 19:51:31 +0000 (19:51 +0000)]
Rename MovHint to MovHintEvent so I can create a NodeType called MovHint

Rubber stamped by Mark Hahnenberg.

This is similar to the SetLocal/SetLocalEvent naming scheme, where SetLocal is the
NodeType and SetLocalEvent is the VariableEventKind.

* dfg/DFGVariableEvent.cpp:
(JSC::DFG::VariableEvent::dump):
* dfg/DFGVariableEvent.h:
(JSC::DFG::VariableEvent::movHint):
(JSC::DFG::VariableEvent::id):
(JSC::DFG::VariableEvent::operand):
(VariableEvent):
* dfg/DFGVariableEventStream.cpp:
(JSC::DFG::VariableEventStream::reconstruct):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Mark rtl-iframe-absolute-overflow-scrolled as flaky.
enne@google.com [Fri, 1 Mar 2013 19:23:36 +0000 (19:23 +0000)]
[chromium] Mark rtl-iframe-absolute-overflow-scrolled as flaky.
https://bugs.webkit.org/show_bug.cgi?id=111199

Unreviewed gardening.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago Build fix for builds with BLOB disabled. This fixes it for me on Mac at least.
ap@apple.com [Fri, 1 Mar 2013 19:17:41 +0000 (19:17 +0000)]
    Build fix for builds with BLOB disabled. This fixes it for me on Mac at least.

        * platform/network/BlobRegistryImpl.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Curl] Session cookies should not be persistent.
commit-queue@webkit.org [Fri, 1 Mar 2013 19:13:17 +0000 (19:13 +0000)]
[Curl] Session cookies should not be persistent.
https://bugs.webkit.org/show_bug.cgi?id=111060

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-03-01
Reviewed by Brent Fulgham.

Curl saves both persistent cookies, and session cookies to the cookie file.
The session cookies should be deleted before starting a new session.

* platform/network/curl/ResourceHandleManager.cpp:
(WebCore::ResourceHandleManager::ResourceHandleManager): Call method to initialize cookie session.
(WebCore::ResourceHandleManager::initCookieSession): Added method to initialize cookie session.
* platform/network/curl/ResourceHandleManager.h: Added method to initialize cookie session.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Navigator should show tree element for each folder in the source path.
vsevik@chromium.org [Fri, 1 Mar 2013 17:57:56 +0000 (17:57 +0000)]
Web Inspector: Navigator should show tree element for each folder in the source path.
https://bugs.webkit.org/show_bug.cgi?id=108943

Reviewed by Pavel Feldman.

Source/WebCore:

NavigatorView now renders tree element for each folder in uiSourceCode uri.
Merging several folders into one tree elememnt when folder has only one folder as a child is supported.
ScriptsNavigator has horizontal scroll now.
Projects are shown in ScriptsNavigator by their displayName. This allows us to show several root file system folders
with the same name in the navigator (e.g. 'Source/WebCore/inspector' and 'LayoutTests/inspector').

Test: inspector/debugger/navigator-view.html: Renamed from scripts-file-selector.html

* English.lproj/localizedStrings.js:
* inspector/front-end/NavigatorView.js:
(WebInspector.NavigatorView):
(WebInspector.NavigatorView.iconClassForType):
(WebInspector.NavigatorView.prototype.addUISourceCode):
(WebInspector.NavigatorView.prototype._getProjectNode):
(WebInspector.NavigatorView.prototype._createProjectNode):
(WebInspector.NavigatorView.prototype._getOrCreateProjectNode):
(WebInspector.NavigatorView.prototype._getFolderNode):
(WebInspector.NavigatorView.prototype._createFolderNode):
(WebInspector.NavigatorView.prototype._getOrCreateFolderNode):
(WebInspector.NavigatorView.prototype._getUISourceCodeParentNode):
(WebInspector.NavigatorView.prototype._getOrCreateUISourceCodeParentNode):
(WebInspector.NavigatorView.prototype.revealUISourceCode):
(WebInspector.NavigatorView.prototype.removeUISourceCode):
(WebInspector.NavigatorView.prototype.rename):
(WebInspector.NavigatorView.prototype.reset):
(.typeWeight):
(WebInspector.NavigatorTreeOutline._treeElementsCompare):
(WebInspector.BaseNavigatorTreeElement):
(WebInspector.BaseNavigatorTreeElement.prototype.type):
(WebInspector.NavigatorFolderTreeElement):
(WebInspector.NavigatorFolderTreeElement.prototype.onpopulate):
(WebInspector.NavigatorFolderTreeElement.prototype.onattach):
(WebInspector.NavigatorSourceTreeElement):
(WebInspector.NavigatorTreeNode):
(WebInspector.NavigatorTreeNode.prototype.treeElement):
(WebInspector.NavigatorTreeNode.prototype.dispose):
(WebInspector.NavigatorTreeNode.prototype.isRoot):
(WebInspector.NavigatorTreeNode.prototype.hasChildren):
(WebInspector.NavigatorTreeNode.prototype.populate):
(WebInspector.NavigatorTreeNode.prototype.wasPopulated):
(WebInspector.NavigatorTreeNode.prototype.didAddChild):
(WebInspector.NavigatorTreeNode.prototype.willRemoveChild):
(WebInspector.NavigatorTreeNode.prototype.isPopulated):
(WebInspector.NavigatorTreeNode.prototype.isEmpty):
(WebInspector.NavigatorTreeNode.prototype.child):
(WebInspector.NavigatorTreeNode.prototype.children):
(WebInspector.NavigatorTreeNode.prototype.appendChild):
(WebInspector.NavigatorTreeNode.prototype.removeChild):
(WebInspector.NavigatorTreeNode.prototype.reset):
(WebInspector.NavigatorRootTreeNode):
(WebInspector.NavigatorRootTreeNode.prototype.isRoot):
(WebInspector.NavigatorRootTreeNode.prototype.treeElement):
(WebInspector.NavigatorRootTreeNode.prototype.wasPopulated):
(WebInspector.NavigatorRootTreeNode.prototype.didAddChild):
(WebInspector.NavigatorRootTreeNode.prototype.willRemoveChild):
(WebInspector.NavigatorUISourceCodeTreeNode):
(WebInspector.NavigatorUISourceCodeTreeNode.prototype.treeElement):
(WebInspector.NavigatorUISourceCodeTreeNode.prototype.updateTitle):
(WebInspector.NavigatorUISourceCodeTreeNode.prototype.hasChildren):
(WebInspector.NavigatorUISourceCodeTreeNode.prototype.dispose):
(WebInspector.NavigatorUISourceCodeTreeNode.prototype._titleChanged):
(WebInspector.NavigatorUISourceCodeTreeNode.prototype._workingCopyChanged):
(WebInspector.NavigatorUISourceCodeTreeNode.prototype._workingCopyCommitted):
(WebInspector.NavigatorUISourceCodeTreeNode.prototype._formattedChanged):
(WebInspector.NavigatorUISourceCodeTreeNode.prototype.reveal):
(WebInspector.NavigatorUISourceCodeTreeNode.prototype.rename.commitHandler):
(WebInspector.NavigatorUISourceCodeTreeNode.prototype.rename.cancelHandler):
(WebInspector.NavigatorUISourceCodeTreeNode.prototype.rename.afterEditing):
(WebInspector.NavigatorUISourceCodeTreeNode.prototype.rename):
(WebInspector.NavigatorFolderTreeNode):
(WebInspector.NavigatorFolderTreeNode.prototype.treeElement):
(WebInspector.NavigatorFolderTreeNode.prototype._createTreeElement):
(WebInspector.NavigatorFolderTreeNode.prototype.wasPopulated):
(WebInspector.NavigatorFolderTreeNode.prototype._addChildrenRecursive):
(WebInspector.NavigatorFolderTreeNode.prototype._shouldMerge):
(WebInspector.NavigatorFolderTreeNode.prototype.didAddChild):
(WebInspector.NavigatorFolderTreeNode.prototype.willRemoveChild):
* inspector/front-end/ScriptsNavigator.js:
* inspector/front-end/SimpleWorkspaceProvider.js:
(WebInspector.SimpleProjectDelegate.prototype.displayName):
* inspector/front-end/navigatorView.css:
(.navigator > ol):
(.navigator .base-navigator-tree-element-title):
(.navigator-tabbed-pane .navigator-container):

LayoutTests:

* http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest.):
(initialize_DebuggerTest):
* http/tests/inspector/workspace-test.js:
(initialize_WorkspaceTest.InspectorTest.createWorkspace):
* inspector/debugger/navigator-view-expected.txt: Added.
* inspector/debugger/navigator-view.html: Added.
* inspector/debugger/scripts-file-selector-expected.txt: Removed.
* inspector/debugger/scripts-file-selector.html: Removed.
* inspector/debugger/scripts-panel-expected.txt:
* inspector/debugger/scripts-panel.html:
* inspector/debugger/scripts-sorting-expected.txt:
* inspector/debugger/scripts-sorting.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Upstream BlackBerry::Platform::Graphics::GraphicsContext integration...
anilsson@rim.com [Fri, 1 Mar 2013 17:43:31 +0000 (17:43 +0000)]
[BlackBerry] Upstream BlackBerry::Platform::Graphics::GraphicsContext integration related changes in platform/graphics/blackberry
https://bugs.webkit.org/show_bug.cgi?id=111072

Reviewed by Rob Buis.

BlackBerry PR 293208

This patch contains contributions from many members of the BlackBerry
WebKit team:

Rob Buis
Robin Cao
Michael Carmody
Max Feil
Eli Fidler
Antonio Gomes
Jacky Jiang
Mike Lattanzio
Yong Li
Andrew Lo
Maxim Mogilnitsky
Joshua Netterfield
Arvid Nilsson
Jakob Petsovits
Konrad Piascik
Jeff Rogers
Artem Simonov
Filip Spacek
George Staikos
Cosmin Truta

Covered by existing tests.

* platform/graphics/blackberry/CanvasLayerWebKitThread.cpp:
(WebCore::CanvasLayerWebKitThread::deleteTextures):
(CanvasLayerCompositingThreadClient):
(WebCore::CanvasLayerCompositingThreadClient::layerCompositingThreadDestroyed):
(WebCore::CanvasLayerCompositingThreadClient::layerVisibilityChanged):
(WebCore::CanvasLayerCompositingThreadClient::uploadTexturesIfNeeded):
(WebCore::CanvasLayerCompositingThreadClient::clearBuffer):
(WebCore):
(WebCore::CanvasLayerCompositingThreadClient::CanvasLayerCompositingThreadClient):
(WebCore::CanvasLayerCompositingThreadClient::drawTextures):
(WebCore::CanvasLayerCompositingThreadClient::deleteTextures):
(WebCore::CanvasLayerCompositingThreadClient::commitPendingTextureUploads):
(WebCore::CanvasLayerWebKitThread::CanvasLayerWebKitThread):
(WebCore::CanvasLayerWebKitThread::~CanvasLayerWebKitThread):
(WebCore::CanvasLayerWebKitThread::clearBuffer):
* platform/graphics/blackberry/CanvasLayerWebKitThread.h:
(WebCore):
(WebCore::CanvasLayerWebKitThread::create):
(CanvasLayerWebKitThread):
* platform/graphics/blackberry/DisplayRefreshMonitorBlackBerry.cpp:
(WebCore::DisplayRefreshMonitor::displayLinkFired):
* platform/graphics/blackberry/DrawingBufferBlackBerry.cpp:
(WebCore::DrawingBuffer::DrawingBuffer):
(WebCore):
(WebCore::DrawingBuffer::publishToPlatformLayer):
(WebCore::DrawingBuffer::platformLayer):
* platform/graphics/blackberry/EGLImageLayerCompositingThreadClient.cpp:
(WebCore::EGLImageLayerCompositingThreadClient::~EGLImageLayerCompositingThreadClient):
(WebCore::EGLImageLayerCompositingThreadClient::uploadTexturesIfNeeded):
(WebCore::EGLImageLayerCompositingThreadClient::drawTextures):
(WebCore::EGLImageLayerCompositingThreadClient::deleteTextures):
(WebCore::EGLImageLayerCompositingThreadClient::bindContentsTexture):
(WebCore::EGLImageLayerCompositingThreadClient::setTextureAccessor):
* platform/graphics/blackberry/EGLImageLayerCompositingThreadClient.h:
(Graphics):
(EGLImageLayerCompositingThreadClient):
(WebCore::EGLImageLayerCompositingThreadClient::EGLImageLayerCompositingThreadClient):
* platform/graphics/blackberry/EGLImageLayerWebKitThread.cpp:
(WebCore::EGLImageLayerWebKitThread::EGLImageLayerWebKitThread):
(WebCore::EGLImageLayerWebKitThread::~EGLImageLayerWebKitThread):
(WebCore::EGLImageLayerWebKitThread::updateFrontBuffer):
(WebCore::EGLImageLayerWebKitThread::deleteFrontBuffer):
(WebCore::EGLImageLayerWebKitThread::commitPendingTextureUploads):
(WebCore::EGLImageLayerWebKitThread::createTextureIfNeeded):
(WebCore::EGLImageLayerWebKitThread::blitToFrontBuffer):
* platform/graphics/blackberry/EGLImageLayerWebKitThread.h:
(Graphics):
(EGLImageLayerWebKitThread):
* platform/graphics/blackberry/FloatRectBlackBerry.cpp:
(WebCore::FloatRect::normalized):
(WebCore):
* platform/graphics/blackberry/FontCacheBlackberry.cpp: Removed.
* platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp:
(WebCore::GraphicsContext3D::GraphicsContext3D):
(WebCore::GraphicsContext3D::paintToCanvas):
(WebCore::GraphicsContext3D::getImageData):
(WebCore):
* platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp:
(WebCore::GraphicsLayerBlackBerry::GraphicsLayerBlackBerry):
(WebCore::GraphicsLayerBlackBerry::setBackgroundColor):
(WebCore::GraphicsLayerBlackBerry::clearBackgroundColor):
(WebCore):
(WebCore::GraphicsLayerBlackBerry::setContentsNeedsDisplay):
(WebCore::GraphicsLayerBlackBerry::setNeedsDisplay):
(WebCore::GraphicsLayerBlackBerry::setNeedsDisplayInRect):
(WebCore::GraphicsLayerBlackBerry::updateLayerBackgroundColor):
(WebCore::GraphicsLayerBlackBerry::setupContentsLayer):
* platform/graphics/blackberry/GraphicsLayerBlackBerry.h:
(GraphicsLayerBlackBerry):
(WebCore::GraphicsLayerBlackBerry::notifySyncRequired):
* platform/graphics/blackberry/ImageBlackBerry.cpp:
(WebCore::ImageFrame::asNewNativeImage):
(WebCore):
(WebCore::FrameData::clear):
(WebCore::BitmapImage::BitmapImage):
(WebCore::BitmapImage::checkForSolidColor):
(WebCore::BitmapImage::invalidatePlatformData):
(WebCore::BitmapImage::draw):
(WebCore::Image::drawPattern):
* platform/graphics/blackberry/InstrumentedPlatformCanvas.h: Removed.
* platform/graphics/blackberry/LayerCompositingThread.cpp:
(WebCore::LayerCompositingThread::drawTextures):
(WebCore::LayerCompositingThread::drawSurface):
(WebCore::LayerCompositingThread::contentsTexture):
(WebCore::LayerCompositingThread::commitPendingTextureUploads):
(WebCore):
* platform/graphics/blackberry/LayerCompositingThread.h:
(Graphics):
(LayerCompositingThread):
* platform/graphics/blackberry/LayerCompositingThreadClient.h:
(Graphics):
(WebCore):
(LayerCompositingThreadClient):
(WebCore::LayerCompositingThreadClient::contentsTexture):
(WebCore::LayerCompositingThreadClient::commitPendingTextureUploads):
* platform/graphics/blackberry/LayerData.h:
(WebCore::LayerData::LayerData):
(WebCore::LayerData::contentsResolutionIndependent):
(LayerData):
(WebCore::LayerData::layerProgram):
(WebCore::LayerData::isContainerForFixedPositionLayers):
(WebCore::LayerData::isFixedToTop):
(WebCore::LayerData::isFixedToLeft):
(WebCore::LayerData::frameVisibleRect):
(WebCore::LayerData::frameContentsSize):
(WebCore::LayerData::contentsScale):
* platform/graphics/blackberry/LayerFilterRenderer.cpp:
(WebCore::LayerFilterRendererAction::LayerFilterRendererAction):
(WebCore::LayerFilterRenderer::initializeSharedGLObjects):
(WebCore::LayerFilterRenderer::ping):
(WebCore::LayerFilterRenderer::pong):
(WebCore::LayerFilterRenderer::pushSnapshot):
(WebCore::LayerFilterRenderer::popSnapshot):
(WebCore::LayerFilterRenderer::applyActions):
* platform/graphics/blackberry/LayerRenderer.cpp:
(WebCore):
(WebCore::LayerRenderer::LayerRenderer):
(WebCore::LayerRenderer::~LayerRenderer):
(WebCore::LayerRenderer::setViewport):
(WebCore::LayerRenderer::compositeLayers):
(WebCore::LayerRenderer::compositeBuffer):
(WebCore::LayerRenderer::drawColor):
(WebCore::LayerRenderer::useSurface):
(WebCore::LayerRenderer::drawLayersOnSurfaces):
(WebCore::glRound):
(WebCore::LayerRenderer::toOpenGLWindowCoordinates):
(WebCore::LayerRenderer::drawDebugBorder):
(WebCore::LayerRenderer::drawHolePunchRect):
(WebCore::LayerRenderer::updateLayersRecursive):
(WebCore::LayerRenderer::compositeLayersRecursive):
(WebCore::LayerRenderer::createProgram):
(WebCore::LayerRenderer::useProgram):
(WebCore::LayerRenderer::useLayerProgram):
* platform/graphics/blackberry/LayerRenderer.h:
(LayerRenderer):
* platform/graphics/blackberry/LayerRendererSurface.cpp:
(WebCore::LayerRendererSurface::ensureTexture):
* platform/graphics/blackberry/LayerTile.cpp:
(WebCore::LayerTile::LayerTile):
(WebCore::LayerTile::setContents):
(WebCore::LayerTile::updateContents):
* platform/graphics/blackberry/LayerTile.h:
(LayerTile):
(WebCore::LayerTile::renderState):
(WebCore::LayerTile::needsRender):
(WebCore::LayerTile::setNeedsRender):
(WebCore::LayerTile::setRenderPending):
(WebCore::LayerTile::setRenderDone):
* platform/graphics/blackberry/LayerTileIndex.h:
* platform/graphics/blackberry/LayerTiler.cpp:
(WebCore):
(WebCore::defaultTileSize):
(WebCore::LayerTiler::LayerTiler):
(WebCore::LayerTiler::updateTextureContentsIfNeeded):
(WebCore::LayerTiler::createBuffer):
(WebCore::LayerTiler::willCommit):
(WebCore::LayerTiler::commitPendingTextureUploads):
(WebCore::LayerTiler::layerVisibilityChanged):
(WebCore::LayerTiler::uploadTexturesIfNeeded):
(WebCore::LayerTiler::processTextureJob):
(WebCore::LayerTiler::addTileJob):
(WebCore::LayerTiler::performTileJob):
(WebCore::LayerTiler::drawTile):
(WebCore::LayerTiler::drawTextures):
(WebCore::LayerTiler::pruneTextures):
(WebCore::LayerTiler::updateTileSize):
(WebCore::LayerTiler::setNeedsBacking):
(WebCore::LayerTiler::contentsTexture):
* platform/graphics/blackberry/LayerTiler.h:
(WebCore::LayerTiler::tileSize):
(LayerTiler):
(WebCore::LayerTiler::TextureJob::TextureJob):
(WebCore::LayerTiler::TextureJob::setContents):
(WebCore::LayerTiler::TextureJob::updateContents):
(TextureJob):
(WebCore::LayerTiler::needsRender):
(WebCore::LayerTiler::removeUpdateContentsJobs):
* platform/graphics/blackberry/LayerWebKitThread.cpp:
(WebCore::LayerWebKitThread::LayerWebKitThread):
(WebCore::LayerWebKitThread::~LayerWebKitThread):
(WebCore::LayerWebKitThread::paintContents):
(WebCore::LayerWebKitThread::commitPendingTextureUploads):
(WebCore::LayerWebKitThread::setContents):
(WebCore::LayerWebKitThread::setNeedsCommit):
(WebCore::LayerWebKitThread::notifyAnimationsStarted):
(WebCore::LayerWebKitThread::commitOnWebKitThread):
(WebCore::LayerWebKitThread::startAnimations):
(WebCore::LayerWebKitThread::updateTextureContents):
(WebCore::LayerWebKitThread::commitOnCompositingThread):
(WebCore::LayerWebKitThread::addSublayer):
(WebCore):
(WebCore::LayerWebKitThread::addOverlay):
(WebCore::LayerWebKitThread::insert):
(WebCore::LayerWebKitThread::removeFromSuperlayer):
(WebCore::LayerWebKitThread::removeSublayerOrOverlay):
(WebCore::LayerWebKitThread::remove):
(WebCore::LayerWebKitThread::replaceSublayer):
(WebCore::LayerWebKitThread::filtersCanBeComposited):
(WebCore::LayerWebKitThread::removeAll):
(WebCore::LayerWebKitThread::setSublayers):
(WebCore::LayerWebKitThread::updateLayerHierarchy):
(WebCore::LayerWebKitThread::setIsMask):
(WebCore::LayerWebKitThread::releaseLayerResources):
* platform/graphics/blackberry/LayerWebKitThread.h:
(WebCore::LayerWebKitThread::insertSublayer):
(LayerWebKitThread):
(WebCore::LayerWebKitThread::isMask):
(WebCore::LayerWebKitThread::removeAllSublayers):
(WebCore::LayerWebKitThread::setFixedPosition):
(WebCore::LayerWebKitThread::setIsContainerForFixedPositionLayers):
(WebCore::LayerWebKitThread::setFixedToTop):
(WebCore::LayerWebKitThread::setFixedToLeft):
(WebCore::LayerWebKitThread::setFrameVisibleRect):
(WebCore::LayerWebKitThread::setFrameContentsSize):
(WebCore::LayerWebKitThread::setLayerProgram):
* platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
(WebCore::MediaPlayerPrivate::play):
(WebCore::MediaPlayerPrivate::supportsFullscreen):
(WebCore::MediaPlayerPrivate::paintCurrentFrameInContext):
(WebCore::MediaPlayerPrivate::prepareForRendering):
(WebCore):
(WebCore::MediaPlayerPrivate::resizeSourceDimensions):
(WebCore::MediaPlayerPrivate::percentLoaded):
(WebCore::MediaPlayerPrivate::updateStates):
(WebCore::MediaPlayerPrivate::waitMetadataTimerFired):
(WebCore::MediaPlayerPrivate::onAuthenticationNeeded):
(WebCore::MediaPlayerPrivate::notifyChallengeResult):
(WebCore::MediaPlayerPrivate::isProcessingUserGesture):
(WebCore::loadBufferingImageData):
(WebCore::MediaPlayerPrivate::setBuffering):
(WebCore::MediaPlayerPrivate::drawBufferingAnimation):
(WebCore::MediaPlayerPrivate::onConditionallyEnterFullscreen):
(WebCore::MediaPlayerPrivate::onExitFullscreen):
(WebCore::MediaPlayerPrivate::onCreateHolePunchRect):
(WebCore::MediaPlayerPrivate::onDestroyHolePunchRect):
* platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:
(BlackBerry):
(Platform):
(Graphics):
(MediaPlayerPrivate):
* platform/graphics/blackberry/PluginLayerWebKitThread.cpp:
(WebCore::PluginLayerWebKitThread::setPluginView):
* platform/graphics/blackberry/Texture.cpp:
(WebCore::Texture::Texture):
(WebCore::Texture::updateContents):
(WebCore::Texture::setContentsToColor):
(WebCore::Texture::protect):
* platform/graphics/blackberry/Texture.h:
(Texture):
(WebCore::Texture::textureId):
(WebCore::Texture::isDirty):
(WebCore::Texture::hasTexture):
(WebCore::Texture::sizeInBytes):
(WebCore::Texture::setTextureId):
(WebCore::Texture::setSize):
* platform/graphics/blackberry/TextureCacheCompositingThread.cpp:
(WebCore::TextureCacheCompositingThread::allocateTextureId):
(WebCore::freeTextureId):
(WebCore::TextureCacheCompositingThread::collectGarbage):
(WebCore::TextureCacheCompositingThread::textureSizeInBytesChanged):
(WebCore):
(WebCore::TextureCacheCompositingThread::textureDestroyed):
(WebCore::TextureCacheCompositingThread::install):
(WebCore::TextureCacheCompositingThread::resizeTexture):
(WebCore::TextureCacheCompositingThread::evict):
(WebCore::TextureCacheCompositingThread::prune):
(WebCore::TextureCacheCompositingThread::clear):
(WebCore::TextureCacheCompositingThread::textureForTiledContents):
(WebCore::TextureCacheCompositingThread::updateContents):
* platform/graphics/blackberry/TextureCacheCompositingThread.h:
(TextureCacheCompositingThread):
(WebCore::TextureCacheCompositingThread::ZombieTexture::ZombieTexture):
(ZombieTexture):
* platform/graphics/blackberry/skia/ImageBufferDataSkia.h: Removed.
* platform/graphics/blackberry/skia/PlatformSupport.cpp: Removed.
* platform/graphics/blackberry/skia/PlatformSupport.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Fix the Mac build with the current qtbase/dev branch
jocelyn.turcotte@digia.com [Fri, 1 Mar 2013 17:30:48 +0000 (17:30 +0000)]
[Qt] Fix the Mac build with the current qtbase/dev branch
https://bugs.webkit.org/show_bug.cgi?id=111190

Reviewed by Allan Sandfeld Jensen.

QMAKE_MACOSX_DEPLOYMENT_TARGET now influences
__MAC_OS_X_VERSION_MIN_REQUIRED through -mmacosx-version-min after
changes in qtbase to support iOS.

Having only WebCore defining it to 10.5 would create a mismatch of
ENABLE_THREADING_LIBDISPATCH with WTF to cause undefined symbols
while linking both together at the end.

Fix it by removing the statement which isn't needed anymore.
qtbase/mkspecs/common/mac-minimum-version.conf already defines
10.6 as the minimum Mac version.

* Target.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: [Regression] Snippets renaming is broken.
vsevik@chromium.org [Fri, 1 Mar 2013 17:06:34 +0000 (17:06 +0000)]
Web Inspector: [Regression] Snippets renaming is broken.
https://bugs.webkit.org/show_bug.cgi?id=111181

Reviewed by Alexander Pavlov.

Source/WebCore:

* inspector/front-end/NavigatorView.js:
* inspector/front-end/ScriptSnippetModel.js:
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.set _fileRenamed):
* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode.prototype.rename):

LayoutTests:

* inspector/debugger/script-snippet-model.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix a misspelled word in RenderObject.h. staticly -> statically.
hyatt@apple.com [Fri, 1 Mar 2013 17:04:13 +0000 (17:04 +0000)]
Fix a misspelled word in RenderObject.h. staticly -> statically.

Reviewed by Dean Jackson.

* rendering/RenderObject.h:
(WebCore::RenderObject::RenderObjectBitfields::RenderObjectBitfields):
(WebCore::RenderObject::RenderObjectBitfields::isPositioned):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[New Multicolumn] Change flow thread containment to be a state.
hyatt@apple.com [Fri, 1 Mar 2013 16:58:25 +0000 (16:58 +0000)]
[New Multicolumn] Change flow thread containment to be a state.
https://bugs.webkit.org/show_bug.cgi?id=111110

Change m_inRenderFlowThread from a single bit to an actual state. This
will let us track whether we're inside a multicolumn (in-flow) flow thread
or a named (out-of-flow) flow thread. In the former case, we're going to have
to do more work to maintain this state, but for now I've kept all the logic
the same just for the initial landing.

Reviewed by Andreas Kling.

* dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::createRendererForElementIfNeeded):
(WebCore::NodeRenderingContext::createRendererForTextIfNeeded):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::clone):
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::RenderFlowThread):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::clone):
* rendering/RenderMultiColumnFlowThread.cpp:
(WebCore::RenderMultiColumnFlowThread::RenderMultiColumnFlowThread):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::setFlowThreadStateIncludingDescendants):
(WebCore::RenderObject::removeFromRenderFlowThreadRecursive):
* rendering/RenderObject.h:
(WebCore::RenderObject::setParent):
(RenderObject):
(WebCore::RenderObject::inRenderFlowThread):
(WebCore::RenderObject::flowThreadState):
(WebCore::RenderObject::setFlowThreadState):
(WebCore::RenderObject::RenderObjectBitfields::RenderObjectBitfields):
(RenderObjectBitfields):
(WebCore::RenderObject::RenderObjectBitfields::flowThreadState):
(WebCore::RenderObject::RenderObjectBitfields::setFlowThreadState):
* rendering/RenderView.cpp:
(WebCore::RenderView::addChild):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBuild fix.
jberlin@webkit.org [Fri, 1 Mar 2013 16:46:11 +0000 (16:46 +0000)]
Build fix.

Roll out r144431 because it was a build fix for r144422, which was rolled out in r144446.

* platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBUILD FIX (r144358): Add UNUSED_PARAM() macros to WebCore::Extensions3DOpenGL::drawBu...
ddkilzer@apple.com [Fri, 1 Mar 2013 16:28:29 +0000 (16:28 +0000)]
BUILD FIX (r144358): Add UNUSED_PARAM() macros to WebCore::Extensions3DOpenGL::drawBuffersEXT()
<http://webkit.org/b/109331>

Fixes the following build failures:

    Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp:218:51: error: unused parameter 'n' [-Werror,-Wunused-parameter]
    void Extensions3DOpenGL::drawBuffersEXT(GC3Dsizei n, const GC3Denum* bufs)
                                                      ^
    Source/WebCore/platform/graphics/opengl/Extensions3DOpenGL.cpp:218:70: error: unused parameter 'bufs' [-Werror,-Wunused-parameter]
    void Extensions3DOpenGL::drawBuffersEXT(GC3Dsizei n, const GC3Denum* bufs)
                                                                         ^
    2 errors generated.

* platform/graphics/opengl/Extensions3DOpenGL.cpp:
(WebCore::Extensions3DOpenGL::drawBuffersEXT): Add UNUSED_PARAM()
macros.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[v8] ScriptValue has dangerous copy semantics
commit-queue@webkit.org [Fri, 1 Mar 2013 16:24:42 +0000 (16:24 +0000)]
[v8] ScriptValue has dangerous copy semantics
https://bugs.webkit.org/show_bug.cgi?id=110206

Patch by Dan Carney <dcarney@google.com> on 2013-03-01
Reviewed by Kentaro Hara.

Update ScriptValue to used a SharedPersistent,
making it impossible to return dead references.

No new tests. No change in functionality.

* bindings/v8/ScriptValue.cpp:
(WebCore::ScriptValue::serialize):
(WebCore::ScriptValue::getString):
(WebCore::ScriptValue::toString):
(WebCore::ScriptValue::toInspectorValue):
* bindings/v8/ScriptValue.h:
(WebCore::ScriptValue::ScriptValue):
(WebCore::ScriptValue::operator=):
(WebCore::ScriptValue::operator==):
(WebCore::ScriptValue::isEqual):
(WebCore::ScriptValue::isFunction):
(WebCore::ScriptValue::isNull):
(WebCore::ScriptValue::isUndefined):
(WebCore::ScriptValue::isObject):
(WebCore::ScriptValue::hasNoValue):
(WebCore::ScriptValue::clear):
(ScriptValue):
(WebCore::ScriptValue::v8Value):
(WebCore::ScriptValue::v8ValueRaw):
* bindings/v8/SharedPersistent.h:
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::InjectedScriptHost::scriptValueAsNode):
* bindings/v8/custom/V8MessageEventCustom.cpp:
(WebCore::V8MessageEvent::dataAttrGetterCustom):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening.
kadam@inf.u-szeged.hu [Fri, 1 Mar 2013 15:49:40 +0000 (15:49 +0000)]
[Qt] Unreviewed gardening.

* platform/qt/TestExpectations: Skipped failing test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd FeatureObserver for marquee and reflection
jchaffraix@webkit.org [Fri, 1 Mar 2013 15:47:26 +0000 (15:47 +0000)]
Add FeatureObserver for marquee and reflection
https://bugs.webkit.org/show_bug.cgi?id=111118

Reviewed by Simon Fraser.

Refactoring covered by existing tests.

* page/FeatureObserver.h:
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::styleChanged):
Added some instrumentation for reflection and marquee as they are both prefixed and this would help
to know their popularity on the web. Marquee was split between <marquee> (HTMLMarqueeElement) and
overflow: -webkit-marquee (CSSOverflowMarquee).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Introduce opaque SecurityOrigin string identifiers in the frontend
apavlov@chromium.org [Fri, 1 Mar 2013 15:37:12 +0000 (15:37 +0000)]
Web Inspector: Introduce opaque SecurityOrigin string identifiers in the frontend
https://bugs.webkit.org/show_bug.cgi?id=111165

Reviewed by Vsevolod Vlasov.

Source/WebCore:

A plain string security origin value has been replaced by WebInspector.SecurityOrigin all over the code,
containing a URL (which holds a stringified security origin) and an identifier (which is now used
as a key in place of the stringified security origin in various maps). To avoid the ResourceTreeModel
code clutter, the security origin tracking code has been extracted into a separate type,
WebInspector.SecurityOriginTracker, which works as a helper on the ResourceTreeModel.

No new tests, as it is a refactoring.

* inspector/front-end/DOMStorage.js:
(WebInspector.DOMStorage.storageId):
(WebInspector.DOMStorage.prototype.id):
(WebInspector.DOMStorage.prototype.getItems):
(WebInspector.DOMStorage.prototype.setItem):
(WebInspector.DOMStorage.prototype.removeItem):
(WebInspector.DOMStorageModel.prototype._securityOriginAdded):
(WebInspector.DOMStorageModel.prototype._securityOriginRemoved):
(WebInspector.DOMStorageModel.prototype._storageKey):
* inspector/front-end/ExtensionAuditCategory.js:
* inspector/front-end/FileSystemModel.js:
(WebInspector.FileSystemModel.prototype._reset):
(WebInspector.FileSystemModel.prototype._securityOriginAdded):
(WebInspector.FileSystemModel.prototype._securityOriginRemoved):
(WebInspector.FileSystemModel.prototype._addOrigin):
(WebInspector.FileSystemModel.prototype._removeOrigin):
(WebInspector.FileSystemModel.prototype._requestFileSystemRoot):
(WebInspector.FileSystemModel.prototype._fileSystemRootReceived):
(WebInspector.FileSystemModel.prototype._removeFileSystem):
(WebInspector.FileSystemModel.FileSystem.prototype.get name):
* inspector/front-end/IndexedDBModel.js:
(WebInspector.IndexedDBModel.prototype._reset):
(WebInspector.IndexedDBModel.prototype.refreshDatabaseNames):
(WebInspector.IndexedDBModel.prototype._securityOriginAdded):
(WebInspector.IndexedDBModel.prototype._securityOriginRemoved):
(WebInspector.IndexedDBModel.prototype._addOrigin):
(WebInspector.IndexedDBModel.prototype._removeOrigin):
(WebInspector.IndexedDBModel.prototype._updateOriginDatabaseNames):
(WebInspector.IndexedDBModel.prototype._loadDatabaseNames):
(WebInspector.IndexedDBModel.prototype._loadDatabase):
(WebInspector.IndexedDBModel.prototype.):
(WebInspector.IndexedDBModel.prototype._requestData):
(WebInspector.IndexedDBModel.DatabaseId.prototype.equals):
* inspector/front-end/IndexedDBViews.js:
(WebInspector.IDBDatabaseView.prototype._refreshDatabase):
* inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel.prototype._addFrame):
(WebInspector.ResourceTreeModel.prototype.securityOriginForId):
(WebInspector.ResourceTreeModel.prototype.securityOrigins):
(WebInspector.ResourceTreeModel.prototype._handleMainFrameDetached):
(WebInspector.ResourceTreeModel.prototype._frameNavigated):
(WebInspector.ResourceTreeModel.prototype._frameDetached):
(WebInspector.ResourceTreeModel.SecurityOriginTracker):
(WebInspector.ResourceTreeModel.SecurityOriginTracker.prototype._addSecurityOrigin):
(WebInspector.ResourceTreeModel.SecurityOriginTracker.prototype._removeSecurityOrigin):
(WebInspector.ResourceTreeModel.SecurityOriginTracker.prototype._bindSecurityOrigin):
(WebInspector.ResourceTreeModel.SecurityOriginTracker.prototype._unbindSecurityOrigin):
(WebInspector.ResourceTreeModel.SecurityOriginTracker.prototype._detachMainFrame):
(WebInspector.ResourceTreeModel.SecurityOriginTracker.prototype._securityOriginForId):
(WebInspector.ResourceTreeModel.SecurityOriginTracker.prototype._securityOrigins):
(WebInspector.ResourceTreeFrame.prototype._navigate):
(WebInspector.SecurityOrigin.prototype.id):
(WebInspector.SecurityOrigin.prototype.url):
(WebInspector.SecurityOrigin.prototype.uiTitle):
(WebInspector.SecurityOrigin.prototype.toProtocol):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.IDBDatabaseTreeElement):
(WebInspector.IDBDatabaseTreeElement.prototype.get itemURL):
(WebInspector.IDBObjectStoreTreeElement.prototype.get itemURL):
(WebInspector.IDBIndexTreeElement.prototype.get itemURL):
(WebInspector.DOMStorageTreeElement):
(WebInspector.DOMStorageTreeElement.prototype.get itemURL):
(WebInspector.FileSystemTreeElement):

LayoutTests:

Follow the string -> object conversion of the security origin.

* http/tests/inspector-enabled/dom-storage-open.html:
* http/tests/inspector/filesystem/delete-entry.html:
* http/tests/inspector/filesystem/request-filesystem-root.html:
* http/tests/inspector/indexeddb/database-data.html:
* http/tests/inspector/indexeddb/database-names.html:
* http/tests/inspector/indexeddb/database-structure.html:
* http/tests/inspector/resource-tree/resource-tree-events.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Reverse the base and extent of a selection when reversing its handles
nghanavatian@rim.com [Fri, 1 Mar 2013 15:25:40 +0000 (15:25 +0000)]
[BlackBerry] Reverse the base and extent of a selection when reversing its handles
https://bugs.webkit.org/show_bug.cgi?id=111098

Reviewed by Yong Li.

PR283969
Swap the base and extent if base does not come first, and set the new selection.

Internally reviewed by Mike Fenton

* WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::setSelection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: [Timeline] Show "curtains" when mouse is over CPU bar.
eustas@chromium.org [Fri, 1 Mar 2013 15:15:32 +0000 (15:15 +0000)]
Web Inspector: [Timeline] Show "curtains" when mouse is over CPU bar.
https://bugs.webkit.org/show_bug.cgi?id=108930

Reviewed by Pavel Feldman.

This feature will help developers to focus on events
that caused CPU bar.

* inspector/front-end/Popover.js: Added "arrowDirection" parameter.
* inspector/front-end/TimelineGrid.js:
(WebInspector.TimelineGrid): Added "curtains".
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._mouseMove): Show/hide "curtains"
when mouse is over CPU bar.
* inspector/front-end/timelinePanel.css: Added "curtains" style rules.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[JSC] Fix sign comparison warning/error after r144340.
rakuco@webkit.org [Fri, 1 Mar 2013 15:10:15 +0000 (15:10 +0000)]
[JSC] Fix sign comparison warning/error after r144340.
https://bugs.webkit.org/show_bug.cgi?id=111164

Reviewed by Mark Hahnenberg.

gcc (both 4.2.1 and 4.7.2) complain about comparing signed and
unsigned terms (clang accepts it just fine).

Work around that by casting the 1 to an uintptr_t as well.

* dfg/DFGEdge.h:
(JSC::DFG::Edge::makeWord):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: [Styles] Implement navigation to UI locations of property names/values...
apavlov@chromium.org [Fri, 1 Mar 2013 14:47:02 +0000 (14:47 +0000)]
Web Inspector: [Styles] Implement navigation to UI locations of property names/values in the source code
Relanding fixed r144449.
https://bugs.webkit.org/show_bug.cgi?id=105285

Reviewed by Vsevolod Vlasov.

Users can now Ctrl/Cmd-click CSS property names/values whose UI locations are found in
an external stylesheet/sass/other file. Inline stylesheets are not navigable,
since their start position is not detectable inside the surrounding HTML as of yet.

No new tests, a UI change.

* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSRule.prototype.isSourceNavigable): Whether the rule contains reliable source code information.
(WebInspector.CSSProperty.prototype.uiLocation): Returns a UILocation for the property name of value.
* inspector/front-end/StylesSidebarPane.js: Add navigation code.
(WebInspector.StylesSidebarPane.prototype._innerRebuildUpdate):
(WebInspector.StylePropertiesSection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r144449.
commit-queue@webkit.org [Fri, 1 Mar 2013 14:34:09 +0000 (14:34 +0000)]
Unreviewed, rolling out r144449.
http://trac.webkit.org/changeset/144449
https://bugs.webkit.org/show_bug.cgi?id=111175

Breaks style-related inspector tests (Requested by apavlov on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-01

* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSRule.prototype.get isRegular):
(WebInspector.CSSProperty.prototype.setDisabled):
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype._innerRebuildUpdate):
(WebInspector.StylePropertiesSection):
(.event):
(.isRevert):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: [Styles] Implement navigation to UI locations of property names/values...
apavlov@chromium.org [Fri, 1 Mar 2013 14:12:38 +0000 (14:12 +0000)]
Web Inspector: [Styles] Implement navigation to UI locations of property names/values in the source code
https://bugs.webkit.org/show_bug.cgi?id=105285

Reviewed by Vsevolod Vlasov.

Users can now Ctrl/Cmd-click CSS property names/values whose UI locations are found in
an external stylesheet/sass/other file. Inline stylesheets are not navigable,
since their start position is not detectable inside the surrounding HTML as of yet.

No new tests, a UI change.

* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSRule.prototype.isSourceNavigable): Whether the rule contains reliable source code information.
(WebInspector.CSSProperty.prototype.uiLocation): Returns a UILocation for the property name of value.
* inspector/front-end/StylesSidebarPane.js: Add navigation code.
(WebInspector.StylesSidebarPane.prototype._innerRebuildUpdate):
(WebInspector.StylePropertiesSection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed chromium gardening, update image expectation again
toyoshim@chromium.org [Fri, 1 Mar 2013 14:02:36 +0000 (14:02 +0000)]
Unreviewed chromium gardening, update image expectation again

* platform/chromium-mac-snowleopard/svg/custom/foreign-object-skew-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r144443.
commit-queue@webkit.org [Fri, 1 Mar 2013 13:38:55 +0000 (13:38 +0000)]
Unreviewed, rolling out r144443.
http://trac.webkit.org/changeset/144443
https://bugs.webkit.org/show_bug.cgi?id=111169

Caused 2 tests to crash by segv on Chromium Mac10.6 (Requested
by toyoshim on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-01

Source/WebCore:

* css/mediaControls.css:
(video::-webkit-media-text-track-display):
* rendering/RenderTextTrackCue.cpp:
(WebCore::RenderTextTrackCue::isOutside):
(WebCore::RenderTextTrackCue::repositionCueSnapToLinesSet):

LayoutTests:

* media/track/track-cue-rendering-with-padding-expected.txt: Removed.
* media/track/track-cue-rendering-with-padding.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r144422 and r144424.
commit-queue@webkit.org [Fri, 1 Mar 2013 13:30:17 +0000 (13:30 +0000)]
Unreviewed, rolling out r144422 and r144424.
http://trac.webkit.org/changeset/144422
http://trac.webkit.org/changeset/144424
https://bugs.webkit.org/show_bug.cgi?id=111167

Caused over 20 tests to fail assertion on Chromium Win port as
ASSERTION FAILED: m_platformRequestUpdated (Requested by
toyoshim on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-01

Source/WebCore:

* CMakeLists.txt:
* GNUmakefile.list.am:
* Modules/mediastream/RTCPeerConnection.cpp:
* Modules/notifications/Notification.cpp:
* Target.pri:
* WebCore.exp.in:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* bindings/ScriptControllerBase.cpp:
* bindings/js/JSNodeCustom.cpp:
* bindings/js/ScriptController.cpp:
* bindings/js/ScriptSourceCode.h:
* bindings/objc/DOM.mm:
* bindings/v8/ScriptController.cpp:
* bindings/v8/V8DOMWindowShell.cpp:
* bindings/v8/custom/V8DOMWindowCustom.cpp:
* css/CSSCrossfadeValue.h:
(WebCore::CSSCrossfadeValue::CSSCrossfadeValue):
(WebCore::CSSCrossfadeValue::CrossfadeSubimageObserverProxy::CrossfadeSubimageObserverProxy):
* css/CSSFontFaceSource.h:
* css/CSSFontSelector.cpp:
* css/WebKitCSSSVGDocumentValue.cpp:
* css/WebKitCSSSVGDocumentValue.h:
(WebCore):
* dom/Clipboard.cpp:
(WebCore::Clipboard::Clipboard):
* dom/ContainerNode.cpp:
* dom/DOMImplementation.cpp:
* dom/PendingScript.h:
* dom/ScriptElement.cpp:
* dom/ScriptElement.h:
* history/CachedFrame.cpp:
* html/DOMURL.cpp:
* html/HTMLAnchorElement.cpp:
* html/HTMLAppletElement.cpp:
* html/HTMLElement.cpp:
* html/HTMLEmbedElement.cpp:
* html/HTMLFrameSetElement.cpp:
* html/HTMLHtmlElement.cpp:
* html/HTMLImageElement.cpp:
* html/HTMLObjectElement.cpp:
* html/HTMLPlugInElement.cpp:
* html/ImageDocument.cpp:
* html/ImageInputType.cpp:
* html/MediaDocument.cpp:
* html/PluginDocument.cpp:
* html/canvas/WebGLRenderingContext.cpp:
(WebCore):
* html/parser/HTMLConstructionSite.cpp:
* html/parser/HTMLParserOptions.cpp:
* html/parser/HTMLScriptRunner.h:
* html/parser/XSSAuditor.cpp:
* html/parser/XSSAuditorDelegate.cpp:
* inspector/InspectorDebuggerAgent.cpp:
* inspector/InspectorFileSystemAgent.cpp:
* inspector/InspectorFrontendHost.cpp:
* inspector/InspectorInstrumentation.h:
(WebCore):
* inspector/InspectorPageAgent.cpp:
* inspector/NetworkResourcesData.cpp:
* inspector/NetworkResourcesData.h:
(WebCore):
* loader/CookieJar.cpp:
* loader/CrossOriginAccessControl.cpp:
* loader/CrossOriginAccessControl.h:
(WebCore):
* loader/CrossOriginPreflightResultCache.h:
* loader/DocumentThreadableLoader.h:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::FrameLoader):
* loader/FrameLoader.h:
(WebCore):
(WebCore::FrameLoader::policyChecker):
* loader/ImageLoader.cpp:
* loader/ImageLoader.h:
* loader/LinkLoader.h:
* loader/MainResourceLoader.cpp:
* loader/MainResourceLoader.h:
* loader/MixedContentChecker.cpp:
* loader/PingLoader.cpp:
* loader/PolicyChecker.h:
(WebCore):
* loader/ProgressTracker.cpp:
* loader/SubframeLoader.cpp:
* loader/SubresourceLoader.cpp:
* loader/TextTrackLoader.cpp:
* loader/TextTrackLoader.h:
* loader/ThreadableLoader.h:
* loader/appcache/ApplicationCacheGroup.cpp:
* loader/appcache/ApplicationCacheGroup.h:
(WebCore):
* loader/appcache/ApplicationCacheHost.cpp:
* loader/archive/cf/LegacyWebArchive.cpp:
* loader/cache/CachedFont.cpp:
* loader/cache/CachedFont.h:
(CachedFontClient):
(WebCore::CachedFontClient::~CachedFontClient):
(WebCore::CachedFontClient::expectedType):
(WebCore::CachedFontClient::resourceClientType):
(WebCore::CachedFontClient::fontLoaded):
(WebCore):
* loader/cache/CachedFontClient.h: Removed.
* loader/cache/CachedImage.cpp:
* loader/cache/CachedRawResource.cpp:
* loader/cache/CachedRawResource.h:
(WebCore):
(CachedRawResourceClient):
(WebCore::CachedRawResourceClient::~CachedRawResourceClient):
(WebCore::CachedRawResourceClient::expectedType):
(WebCore::CachedRawResourceClient::resourceClientType):
(WebCore::CachedRawResourceClient::dataSent):
(WebCore::CachedRawResourceClient::responseReceived):
(WebCore::CachedRawResourceClient::dataReceived):
(WebCore::CachedRawResourceClient::redirectReceived):
(WebCore::CachedRawResourceClient::dataDownloaded):
* loader/cache/CachedRawResourceClient.h: Removed.
* loader/cache/CachedResource.cpp:
* loader/cache/CachedResourceHandle.cpp:
* loader/cache/CachedResourceHandle.h:
(WebCore::CachedResourceHandleBase::~CachedResourceHandleBase):
(WebCore::CachedResourceHandleBase::CachedResourceHandleBase):
* loader/cache/CachedSVGDocument.h:
(CachedSVGDocumentClient):
(WebCore::CachedSVGDocumentClient::~CachedSVGDocumentClient):
(WebCore::CachedSVGDocumentClient::expectedType):
(WebCore::CachedSVGDocumentClient::resourceClientType):
(WebCore):
* loader/cache/CachedSVGDocumentClient.h: Removed.
* loader/cache/CachedSVGDocumentReference.cpp: Removed.
* loader/cache/CachedSVGDocumentReference.h:
(WebCore::CachedSVGDocumentReference::CachedSVGDocumentReference):
(WebCore::CachedSVGDocumentReference::~CachedSVGDocumentReference):
* loader/cache/CachedStyleSheetClient.h:
* loader/cache/MemoryCache.cpp:
* loader/cache/MemoryCache.h:
(WebCore):
(MemoryCache):
* loader/chromium/CachedRawResourceChromium.cpp:
* loader/icon/IconController.cpp:
* loader/icon/IconLoader.h:
* loader/mac/ResourceLoaderMac.mm:
* page/DOMWindowExtension.cpp:
* page/DragController.cpp:
* page/Frame.cpp:
(WebCore::Frame::Frame):
(WebCore::Frame::reportMemoryUsage):
* page/Frame.h:
(WebCore):
(Frame):
(WebCore::Frame::init):
(WebCore::Frame::loader):
* page/PerformanceNavigation.cpp:
* page/PerformanceTiming.cpp:
* page/PointerLockController.cpp:
* page/Settings.cpp:
* page/animation/CSSPropertyAnimation.cpp:
* platform/chromium/PasteboardChromium.cpp:
* platform/efl/ErrorsEfl.cpp:
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
* platform/graphics/filters/FilterOperation.cpp:
* platform/graphics/filters/FilterOperation.h:
(WebCore::FilterOperation::ReferenceFilterOperation::setCachedSVGDocumentReference):
(WebCore::FilterOperation::ReferenceFilterOperation::ReferenceFilterOperation):
* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
* platform/gtk/ErrorsGtk.cpp:
* platform/gtk/PasteboardGtk.cpp:
* platform/gtk/PasteboardHelper.h:
* platform/mac/ClipboardMac.h:
* platform/mac/ClipboardMac.mm:
* platform/mac/HTMLConverter.mm:
* platform/mac/PasteboardMac.mm:
* platform/network/AuthenticationChallengeBase.cpp:
* platform/network/cf/CookieJarCFNet.cpp:
* platform/network/cf/ResourceRequestCFNet.cpp:
* platform/network/mac/CookieStorageMac.mm:
* platform/qt/PasteboardQt.cpp:
* plugins/DOMMimeType.cpp:
* plugins/PluginRequest.h: Removed.
* plugins/PluginStream.h:
(PluginStreamClient):
(WebCore::PluginStreamClient::~PluginStreamClient):
(WebCore::PluginStreamClient::streamDidFinishLoading):
(WebCore):
* plugins/PluginStreamClient.h: Removed.
* plugins/PluginView.cpp:
* plugins/PluginView.h:
(WebCore):
(PluginRequest):
(WebCore::PluginRequest::PluginRequest):
(WebCore::PluginRequest::frameLoadRequest):
(WebCore::PluginRequest::notifyData):
(WebCore::PluginRequest::sendNotification):
(WebCore::PluginRequest::shouldAllowPopups):
* rendering/HitTestResult.cpp:
* rendering/InlineFlowBox.cpp:
* rendering/RenderBox.cpp:
* rendering/RenderEmbeddedObject.cpp:
* rendering/RenderImage.cpp:
* rendering/RenderImageResource.cpp:
(WebCore::RenderImageResource::RenderImageResource):
* rendering/RenderImageResource.h:
(WebCore::RenderImageResource::image):
(WebCore::RenderImageResource::errorOccurred):
(WebCore::RenderImageResource::usesImageContainerSize):
(WebCore::RenderImageResource::imageHasRelativeWidth):
(WebCore::RenderImageResource::imageHasRelativeHeight):
(WebCore::RenderImageResource::imageSize):
* rendering/RenderImageResourceStyleImage.cpp:
* rendering/RenderLayer.cpp:
* rendering/RenderLayerBacking.cpp:
* rendering/RenderLayerFilterInfo.h:
* rendering/RenderListItem.cpp:
* rendering/RenderListMarker.cpp:
* rendering/RenderSnapshottedPlugIn.cpp:
* rendering/RenderTableCol.cpp:
* rendering/RenderTableRow.cpp:
* rendering/RenderTableSection.cpp:
* rendering/style/StyleCachedShader.h:
* rendering/style/StyleCustomFilterProgram.cpp: Removed.
* rendering/style/StyleCustomFilterProgram.h:
(WebCore):
(WebCore::StyleCustomFilterProgram::vertexShaderString):
(StyleCustomFilterProgram):
(WebCore::StyleCustomFilterProgram::fragmentShaderString):
(WebCore::StyleCustomFilterProgram::isLoaded):
(WebCore::StyleCustomFilterProgram::willHaveClients):
(WebCore::StyleCustomFilterProgram::didRemoveLastClient):
(WebCore::StyleCustomFilterProgram::notifyFinished):
* svg/SVGFEImageElement.h:
* svg/SVGFontFaceUriElement.h:
(SVGFontFaceUriElement):
* svg/SVGImageLoader.cpp:
* svg/SVGUseElement.cpp:
* svg/SVGUseElement.h:
* svg/graphics/SVGImageCache.cpp:
* testing/MockPagePopupDriver.cpp:
* xml/XSLStyleSheet.h:
* xml/XSLTProcessorLibxslt.cpp:
* xml/parser/XMLDocumentParser.cpp:
* xml/parser/XMLDocumentParser.h:
* xml/parser/XMLDocumentParserLibxml2.cpp:

Source/WebKit/chromium:

* src/ApplicationCacheHost.cpp:
* src/AssociatedURLLoader.cpp:
* src/EditorClientImpl.cpp:
* src/SharedWorkerRepository.cpp:
* src/WebDataSourceImpl.cpp:
* src/WebFrameImpl.h:
(WebCore):
* src/WebNode.cpp:
* src/WebSharedWorkerImpl.cpp:
* tests/FrameLoaderClientImplTest.cpp:

Source/WebKit/efl:

* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
* ewk/ewk_frame.cpp:

Source/WebKit/gtk:

* webkit/webkitwebpolicydecision.cpp:

Source/WebKit/mac:

* DOM/WebDOMOperations.mm:
* Misc/WebNSPasteboardExtras.mm:
* WebCoreSupport/WebFrameNetworkingContext.mm:
* WebView/WebRenderLayer.mm:
* WebView/WebRenderNode.mm:

Source/WebKit/qt:

* WebCoreSupport/NotificationPresenterClientQt.cpp:
* WebCoreSupport/QWebPageAdapter.cpp:

Source/WebKit2:

* NetworkProcess/HostRecord.h:
* NetworkProcess/NetworkResourceLoadScheduler.h:
* NetworkProcess/NetworkResourceLoader.h:
(WebCore):
* Shared/WebRenderLayer.cpp:
* Shared/WebRenderObject.cpp:
* WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp:
* WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
* WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
* WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.cpp:
* WebProcess/Plugins/PDF/PDFPlugin.mm:
* WebProcess/Plugins/PluginView.cpp:
* WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
* WebProcess/WebCoreSupport/WebEditorClient.cpp:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
* WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
* WebProcess/WebPage/mac/WebPageMac.mm:
* WebProcess/WebProcess.cpp:
* WebProcess/soup/WebProcessSoup.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed chromium gardening, cleanup lint errors #2
toyoshim@chromium.org [Fri, 1 Mar 2013 12:59:15 +0000 (12:59 +0000)]
Unreviewed chromium gardening, cleanup lint errors #2
Remove duplicated entries.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: fix closure compiler warnings in ProfilesPanel
commit-queue@webkit.org [Fri, 1 Mar 2013 12:57:45 +0000 (12:57 +0000)]
Web Inspector: fix closure compiler warnings in ProfilesPanel
https://bugs.webkit.org/show_bug.cgi?id=111163

Patch by Alexei Filippov <alph@chromium.org> on 2013-03-01
Reviewed by Vsevolod Vlasov.

* inspector/front-end/ProfileLauncherView.js:
(WebInspector.ProfileLauncherView.prototype.addProfileType):
* inspector/front-end/ProfilesPanel.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSupport padding, margin and border for internal UA cue styling
vcarbune@chromium.org [Fri, 1 Mar 2013 12:32:43 +0000 (12:32 +0000)]
Support padding, margin and border for internal UA cue styling
https://bugs.webkit.org/show_bug.cgi?id=110703

Reviewed by Eric Carlson.

Source/WebCore:

For some particular user agent styling this allows the possibility
of making the window around the cue text bigger to match some user
styles (see CaptionUserPreferencesMac::captionsStyleSheetOverride).

These properties *cannot* be set through by using the ::cue
pseudo-element and, as specified, are used only internally.

Test: media/track/track-cue-rendering-with-padding.html

* css/mediaControls.css:
(video::-webkit-media-text-track-display): Set the CSS box model
to include in the specified width or height the values of
padding / margin / border by using -webkit-box-sizing and avoid
overflow over 100% width because of having these properties set.
* rendering/RenderTextTrackCue.cpp:
(WebCore::RenderTextTrackCue::isOutside): To not interfere with
the regular WebVTT positioning algorithm, the check is done for
the absolute content box.
(WebCore::RenderTextTrackCue::repositionCueSnapToLinesSet): Added
an extra adjustment step to accomodate vertical padding (and not
overflow the cue container)

LayoutTests:

* media/track/track-cue-rendering-with-padding-expected.txt: Added.
* media/track/track-cue-rendering-with-padding.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed chromium gardening
toyoshim@chromium.org [Fri, 1 Mar 2013 12:26:08 +0000 (12:26 +0000)]
Unreviewed chromium gardening

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Enable LINK_PREFETCH
allan.jensen@digia.com [Fri, 1 Mar 2013 12:17:20 +0000 (12:17 +0000)]
[Qt] Enable LINK_PREFETCH
https://bugs.webkit.org/show_bug.cgi?id=111158

Reviewed by Simon Hausmann.

Tools:

* qmake/mkspecs/features/features.pri:

LayoutTests:

Unskip tests depending on LINK_PREFETCH.

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WK2] Fix failing API tests after r143935
abecsi@webkit.org [Fri, 1 Mar 2013 12:05:16 +0000 (12:05 +0000)]
[Qt][WK2] Fix failing API tests after r143935
https://bugs.webkit.org/show_bug.cgi?id=111086

Reviewed by Jocelyn Turcotte.

Convert a leftorver resume call to the new resumeAndUpdateContent() call
in PageViewportControllerClientQt so that the notifications about zoom
animation state changes reach the API tests.

* UIProcess/qt/PageViewportControllerClientQt.cpp:
(WebKit::PageViewportControllerClientQt::scaleAnimationStateChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Save/load timeline should preserve DOMContentLoaded and Load event...
eustas@chromium.org [Fri, 1 Mar 2013 12:04:24 +0000 (12:04 +0000)]
Web Inspector: Save/load timeline should preserve DOMContentLoaded and Load event markers
https://bugs.webkit.org/show_bug.cgi?id=110819

Reviewed by Pavel Feldman.

To create event divider TimelinePresentation model checks if record
frame is main frame. With this patch check is moved to backend and
result is saved in record to avoid incoherence.

* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::didMarkDOMContentEvent):
Record "isMainFrame" flag.
(WebCore::InspectorTimelineAgent::didMarkLoadEvent): Ditto.
* inspector/TimelineRecordFactory.cpp:
(WebCore::TimelineRecordFactory::createMarkData):
Added data object constructor.
* inspector/TimelineRecordFactory.h: Ditto.
* inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel.isEventDivider):
Use saved flag value instead of comparing with "current" main frame.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Update features.pri with new features
allan.jensen@digia.com [Fri, 1 Mar 2013 12:01:57 +0000 (12:01 +0000)]
[Qt] Update features.pri with new features
https://bugs.webkit.org/show_bug.cgi?id=111157

Reviewed by Jocelyn Turcotte.

* qmake/mkspecs/features/features.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: [DataGrid] Columns are misaligned after rows being refreshed.
eustas@chromium.org [Fri, 1 Mar 2013 11:46:22 +0000 (11:46 +0000)]
Web Inspector: [DataGrid] Columns are misaligned after rows being refreshed.
https://bugs.webkit.org/show_bug.cgi?id=111077

Reviewed by Pavel Feldman.

Analysis: DataGridNode.refresh removes all cells and then recreates them.
The issue is that mandatory "corner" cell is not recreated.

* inspector/front-end/DataGrid.js:
(WebInspector.DataGridNode.prototype.refresh):
Added "corner" cell restoration code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WK2] Asynchronous spell checking implementation
g.czajkowski@samsung.com [Fri, 1 Mar 2013 11:39:02 +0000 (11:39 +0000)]
[WK2] Asynchronous spell checking implementation
https://bugs.webkit.org/show_bug.cgi?id=109577

Patch by Grzegorz Czajkowski  <g.czajkowski@samsung.com>, Mariusz Grzegorczyk <mariusz.g@samsung.com> on 2013-03-01
Reviewed by Enrica Casucci.

Associate the abstract 'WebCore::TextCheckingRequest' object with the unique identifier
on WebProcess side. The request data from the 'TextCheckingRequest' are retrieved and
passed to the UIProcess. The WK2 client (TextChecker{Gtk/Mac/Efl/Qt}.cpp) gets
the 'TextCheckerCompletion' object with the request data and possibility to notify
the WebProcess about the spelling results.
Finally, the WebPage object calls on the proper 'TextCheckingRequest' object
didSuccess/didCancel method to notify the WebCore about the spelling result.

* CMakeLists.txt:
* GNUmakefile.list.am:
Add 'TextCheckerCompletion.{h/cpp}' to the WebKit2 cmake based and
WK2-Gtk+ builds.

* Scripts/webkit2/messages.py:
(headers_for_type):
Add exception for 'TextCheckingRequestData' class to properly find header
file for it.

* Shared/WebCoreArgumentCoders.cpp:
* Shared/WebCoreArgumentCoders.h:
Teach 'ArgumentCoder' how to encode/decode 'TextCheckingRequestData' class.

* Target.pri:
Add 'TextCheckerCompletion.{h/cpp}' to the WK2-Qt build.

* UIProcess/TextChecker.h:
Add 'requestCheckingOfString' method to the TextChecker's interface.

* UIProcess/TextCheckerCompletion.cpp: Added.
(WebKit::TextCheckerCompletion::create):
(WebKit::TextCheckerCompletion::TextCheckerCompletion):

(WebKit::TextCheckerCompletion::spellDocumentTag):
Return the WebPageProxy's spellDocumentTag as the client might be
interested in from which page the request came.

(WebKit::TextCheckerCompletion::textCheckingRequestData):
Allow to retrieve 'TextCheckingRequestData' object.

(WebKit::TextCheckerCompletion::didFinishCheckingText):
(WebKit::TextCheckerCompletion::didCancelCheckingText):
Notify the 'WebPageProxy' object that the given request has been
handled or canceled.

* UIProcess/TextCheckerCompletion.h: Added.
Introduce a new class for WK2 to retrieve the request data and
call didFinishCheckingText/didCancelCheckingText.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::requestCheckingOfString):
Create 'TextCheckerCompletion' object and pass it
to the 'TextChecker::requestCheckingOfString' method.

(WebKit::WebPageProxy::didFinishCheckingText):
(WebKit::WebPageProxy::didCancelCheckingText):
Send the messages to WebProcess that the given request has been
handled or canceled.

* UIProcess/WebPageProxy.h:
(WebPageProxy):
Add public declarations for 'didFinishCheckingText', 'didCancelCheckingText'.
Add private declarations for 'requestCheckingOfString'.
Move the 'spellDocumentTag()' method to to the public section to be
accessible from 'TextCheckerCompletion' class.

* UIProcess/WebPageProxy.messages.in:
A new entry for 'RequestCheckingOfString'.

* UIProcess/efl/TextCheckerEfl.cpp:
(WebKit::TextChecker::requestCheckingOfString):
(WebKit):
* UIProcess/gtk/TextCheckerGtk.cpp:
(WebKit::TextChecker::requestCheckingOfString):
(WebKit):
* UIProcess/mac/TextCheckerMac.mm:
(WebKit::TextChecker::requestCheckingOfString):
(WebKit):
* UIProcess/qt/TextCheckerQt.cpp:
(WebKit::TextChecker::requestCheckingOfString):
(WebKit):
Add dummy implementations for 'requestCheckingOfString'.

* WebKit2.xcodeproj/project.pbxproj:
Add 'TextCheckerCompletion.{h/cpp} to Mac build.

* WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::generateTextCheckingRequestID):
Helper function to generate the unique identifier for the abstract
'TextCheckingRequest' object.

(WebKit::WebEditorClient::requestCheckingOfString):
Associate 'TextCheckingRequest' with the unique identifier and add them
to the map object.
Get the request data and send it to the UIProcess.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::addTextCheckingRequest):
Add the identifier and the request to the map object.

(WebKit::WebPage::didFinishCheckingText):
(WebKit::WebPage::didCancelCheckingText):
Call didSucceed/didCancel on the 'TextCheckingRequest' to notify the WebCore
about spellcheking results.
Remove the request from the map object.

* WebProcess/WebPage/WebPage.h:
Add declarations for 'addTextCheckingRequest', 'didFinishCheckingText' and
'didCancelCheckingText.'

* WebProcess/WebPage/WebPage.messages.in:
Add a new entry for DidFinishCheckingText, DidCancelCheckingText.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFlaky test: http/tests/inspector/resource-tree/resource-request-content-while-loading...
vsevik@chromium.org [Fri, 1 Mar 2013 11:36:57 +0000 (11:36 +0000)]
Flaky test: http/tests/inspector/resource-tree/resource-request-content-while-loading.html
https://bugs.webkit.org/show_bug.cgi?id=111123

Reviewed by Alexander Pavlov.

* TestExpectations:
* http/tests/inspector/resource-tree/resource-request-content-while-loading.html:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: Selector's raw start position in its line is considered to be 0 when...
apavlov@chromium.org [Fri, 1 Mar 2013 10:33:48 +0000 (10:33 +0000)]
Web Inspector: Selector's raw start position in its line is considered to be 0 when computing UILocation
https://bugs.webkit.org/show_bug.cgi?id=110732

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Test: inspector/styles/selector-line.html

* inspector/ContentSearchUtils.cpp:
(WebCore::ContentSearchUtils::sizetExtractor): Utility for binary search.
(WebCore::ContentSearchUtils::textPositionFromOffset): Converts absolute raw text offset into line:column.
(WebCore::ContentSearchUtils::getRegularExpressionMatchesByLines): Refactor.
(WebCore::ContentSearchUtils::lineEndings): Factored out of getRegularExpressionMatchesByLines.
(WebCore::ContentSearchUtils::buildObjectForSearchMatch): Drive-by: pass String by reference.
* inspector/ContentSearchUtils.h:
* inspector/Inspector.json: Use line:column for SourceRange boundaries rather than raw offsets.
* inspector/InspectorStyleSheet.cpp:
(ParsedStyleSheet::text): ASSERT(m_hasText).
(WebCore::InspectorStyle::buildObjectForStyle): Supply the lineEndings argument.
(WebCore::buildSourceRangeObject): Follow the protocol change.
(WebCore::InspectorStyle::setPropertyText): Refactor.
(WebCore::InspectorStyle::toggleProperty): Ditto.
(WebCore::InspectorStyle::styleText): Ditto.
(WebCore::InspectorStyle::populateAllProperties): Ditto.
(WebCore::InspectorStyle::styleWithProperties): Convert relative property range offsets into absolute ones.
(WebCore::InspectorStyle::extractSourceData): Factored out.
(WebCore::InspectorStyle::newLineAndWhitespaceDelimiters): Supply the lineEndings argument.
(WebCore::InspectorStyleSheet::buildObjectForSelectorList): Ditto.
(WebCore::InspectorStyleSheet::lineEndings): Compute line endings for ordinary stylesheets.
(WebCore::InspectorStyleSheetForInlineStyle::lineEndings): Ditto for bogus inline style stylesheets.
* inspector/InspectorStyleSheet.h:
* inspector/front-end/AuditRules.js: Removed the byte counting for unused CSS.
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSRule): Set selector rawLocation based on the selectorList range or sourceLine.
(WebInspector.CSSRule.prototype._setRawLocation): Added.
* inspector/front-end/SASSSourceMapping.js:
(WebInspector.SASSSourceMapping.prototype._bindUISourceCode): Fix call order when binding scss sourcecodes.

LayoutTests:

Changed tests have been rebaselined to follow the new source range structure.

* http/tests/inspector/elements-test.js:
(initialize_ElementTest.InspectorTest.rangeText): Fix source range dumping format.
* inspector/audits/audits-panel-functional-expected.txt:
* inspector/audits/audits-panel-noimages-functional-expected.txt:
* inspector/styles/get-set-stylesheet-text-expected.txt:
* inspector/styles/parse-stylesheet-errors-expected.txt:
* inspector/styles/resources/selector-line.css: Added.
* inspector/styles/resources/selector-line.css.map: Added.
* inspector/styles/resources/selector-line.scss: Added.
* inspector/styles/selector-line-expected.txt: Added.
* inspector/styles/selector-line.html: Added.
* inspector/styles/styles-new-API-expected.txt:
* inspector/styles/styles-source-offsets-expected.txt:
* inspector/styles/styles-source-offsets.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] put WebTestProxy::scheduleComposite back in place
jochen@chromium.org [Fri, 1 Mar 2013 10:19:35 +0000 (10:19 +0000)]
[chromium] put WebTestProxy::scheduleComposite back in place
https://bugs.webkit.org/show_bug.cgi?id=111146

Reviewed by Nico Weber.

The call was removed in http://trac.webkit.org/changeset/144398 because
DRT doesn't need it. However, content shell depends on this call.

* DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
(WebTestRunner::WebTestProxy::scheduleComposite):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoGet rid of two silly static null Strings
benjamin@webkit.org [Fri, 1 Mar 2013 10:13:22 +0000 (10:13 +0000)]
Get rid of two silly static null Strings
https://bugs.webkit.org/show_bug.cgi?id=111151

Reviewed by Eric Seidel.

We have a global null String through nullAtom, there is no need
for local static null strings.

* page/Page.cpp:
(WebCore::Page::groupName):
* rendering/RenderListItem.cpp:
(WebCore::RenderListItem::markerText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBuild fix.
mrowe@apple.com [Fri, 1 Mar 2013 10:03:57 +0000 (10:03 +0000)]
Build fix.

* platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.h: Add a missing #include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Mac] [WK1] http/tests/xmlhttprequest/navigation-should-abort.html fails
mkwst@chromium.org [Fri, 1 Mar 2013 09:45:46 +0000 (09:45 +0000)]
[Mac] [WK1] http/tests/xmlhttprequest/navigation-should-abort.html fails
https://bugs.webkit.org/show_bug.cgi?id=111052

Reviewed by Alexey Proskuryakov.

Currently, this test is failing to output the textual content of the
'data:' URL to which the test navigates. Replacing this 'data:' URL
with a "real" HTML file ensures that Mac WK1 behaves the same way as
the other ports for this test.

This doesn't really address the issue raised: navigation to a 'data:'
URL should behave in the same way as a "real" URL; filed
http://wkbug.com/111152 to track that issue.

* http/tests/xmlhttprequest/resources/navigation-target.html: Added.
    Add an actual file to which we can navigate.
* http/tests/xmlhttprequest/navigation-should-abort-expected.txt:
* http/tests/xmlhttprequest/navigation-should-abort.html:
    Navigate to the new HTML file during the test rather than an inlined
    data: URL.
* platform/mac-wk2/TestExpectations:
* platform/mac/TestExpectations:
    Remove the expectations set in r144277.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Fri, 1 Mar 2013 09:44:11 +0000 (09:44 +0000)]
Unreviewed GTK gardening.

* platform/gtk-wk1/TestExpectations: Removing expectation for the fast/canvas/canvas-currentPath-crash.html test.
* platform/gtk/media/video-playing-and-pause-expected.txt: Rebaselining.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: fix code-mirror experiment to work in debug mode
commit-queue@webkit.org [Fri, 1 Mar 2013 09:37:46 +0000 (09:37 +0000)]
Web Inspector: fix code-mirror experiment to work in debug mode
https://bugs.webkit.org/show_bug.cgi?id=111064

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-01
Reviewed by Pavel Feldman.

No new tests: no change in behaviour.

Improve importScript function to try load a script from the root
directory iff its loading from the given path failed.

* inspector/front-end/utilities.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: [Canvas] capture a WebGL extension by it's name in lower case
aandrey@chromium.org [Fri, 1 Mar 2013 09:18:52 +0000 (09:18 +0000)]
Web Inspector: [Canvas] capture a WebGL extension by it's name in lower case
https://bugs.webkit.org/show_bug.cgi?id=110745

Reviewed by Pavel Feldman.

WebGL's getExtension accepts a name that is tested against an ASCII case-insensitive match.
Just force lower case for extension names.

* inspector/InjectedScriptCanvasModuleSource.js:
(.):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix definition of DatePickerClient::setValue()
commit-queue@webkit.org [Fri, 1 Mar 2013 09:07:31 +0000 (09:07 +0000)]
Fix definition of DatePickerClient::setValue()
https://bugs.webkit.org/show_bug.cgi?id=110336

Patch by Alberto Garcia <albgarcia@rim.com> on 2013-03-01
Reviewed by Carlos Garcia Campos.

The definition of DatePickerClient::setValue() introduced in
r142987 does not match the prototype.

* WebCoreSupport/DatePickerClient.cpp:
(WebCore::DatePickerClient::setValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoXSSAuditor should use threadSafeMatch when relevant.
mkwst@chromium.org [Fri, 1 Mar 2013 08:47:21 +0000 (08:47 +0000)]
XSSAuditor should use threadSafeMatch when relevant.
https://bugs.webkit.org/show_bug.cgi?id=111099

Reviewed by Adam Barth.

Given the work on breaking parsing out into a background thread, we
should compare QualifiedNames in a thread-safe manner. Rather than
casting the result of QualifiedName::localName to a String, we can
call out to threadSafeMatch to do the comparison.

This patch leaves one use of equalIgnoringNullity in
XSSAuditor::findAttributeWithName. That usage seems safe, since we're
creating a new string against which to compare.

* html/parser/XSSAuditor.cpp:
(WebCore::hasName):
    Replace call to equalIgnoringNullity(Vector<UChar...>, String)
    with threadSafeMatch(String, QualifiedName).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION(r144422): Broke compilation on chromium-mac
jochen@chromium.org [Fri, 1 Mar 2013 08:23:09 +0000 (08:23 +0000)]
REGRESSION(r144422): Broke compilation on chromium-mac
https://bugs.webkit.org/show_bug.cgi?id=111150

Unreviewed build fix.

* src/WebFrameImpl.h:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd calendar table view for the new calendar picker
keishi@webkit.org [Fri, 1 Mar 2013 07:48:35 +0000 (07:48 +0000)]
Add calendar table view for the new calendar picker
https://bugs.webkit.org/show_bug.cgi?id=110970

Reviewed by Kent Tamura.

The calendar table that will be used in the new calendar picker (Bug 109439).

No new tests. Code is not used yet.

* Resources/pagepopups/calendarPicker.js:
(DayCell): Cell which represents one day in the calendar.
(DayCell.recycleOrCreate):
(DayCell.prototype._recycleBin):
(DayCell.prototype.throwAway):
(DayCell.prototype.setHighlighted): Sets the highlighted class on the element.
(DayCell.prototype.setDisabled): Sets the disabled class on the element.
(DayCell.prototype.setIsInCurrentMonth): Sets the current-month class on the element.
(DayCell.prototype.setIsToday): Sets the today class on the element.
(DayCell.prototype.reset): Resets the day cell to be reused.
(WeekNumberCell): Cell used for the week number column.
(WeekNumberCell.prototype._recycleBin):
(WeekNumberCell.recycleOrCreate):
(WeekNumberCell.prototype.reset):
(WeekNumberCell.prototype.throwAway):
(WeekNumberCell.prototype.setHighlighted): Sets the highlighted class on the element.
(WeekNumberCell.prototype.setDisabled): Sets the disabled class on the element.
(CalendarTableHeaderView): Header for the calendar table. Contains the column labels.
(CalendarRowCell): Row containing day cells and maybe a week number cell.
(CalendarRowCell.prototype._recycleBin):
(CalendarRowCell.prototype.reset):
(CalendarRowCell.prototype.throwAway):
(CalendarTableView): A list view showing a grid of days.
(CalendarTableView.prototype.rowAtScrollOffset): Returns the row number currently at the scroll offset.
(CalendarTableView.prototype.scrollOffsetForRow): Returns the current scroll offset for the given row.
(CalendarTableView.prototype.onClick): If the click is on a DayCell or WeekNumberCell, select the appropriate date range.
(CalendarTableView.prototype.onMouseOver): If the click is on a DayCell or WeekNumberCell, highlight the appropriate date range.
(CalendarTableView.prototype.onMouseOut):
(CalendarTableView.prototype.prepareNewCell): Prepares a new row cell by recycling or creating a new one.
(CalendarTableView.prototype.height): Returns the height of the view in pixels.
(CalendarTableView.prototype.setHeight): Sets the height of the view in pixels.
(CalendarTableView.prototype.scrollToMonth): Scrolls to reveal the given month.
(CalendarTableView.prototype.dayAtColumnAndRow): Day at a given column and row. Column number doesn't count week number column.
(CalendarTableView.prototype.columnAndRowForDay): Column and row for the given day.
(CalendarTableView.prototype.updateCells): Update the position and appearance of the cell.s
(CalendarTableView.prototype.prepareNewDayCell): Prepares a new day cell. The cell is registered to this._dayCells.
(CalendarTableView.prototype.prepareNewWeekNumberCell): Prepares a new week number cell. The cell is registered to this._weekNumberCells.
(CalendarTableView.prototype.throwAwayDayCell): The cell is unregistered from this._dayCells.
(CalendarTableView.prototype.throwAwayWeekNumberCell): The cell is unregistered from this._weekNumberCells.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoReduce amount of rebuilding when touching networking headers
ap@apple.com [Fri, 1 Mar 2013 07:26:10 +0000 (07:26 +0000)]
Reduce amount of rebuilding when touching networking headers
https://bugs.webkit.org/show_bug.cgi?id=111035

Reviewed by Eric Seidel.

Source/WebCore:

This uses a number of common unsurprising techniques. One interesting observation
is that including CachedResource related headers is very expensive. We can usually
get away with their Client counterparts, and with CachedResourceHandle.

* page/Frame.cpp:
* page/Frame.h:
Don't include FrameLoader, greatly reducing include graph for most non-loader files.
This required making Frame::init() non-inline - I'm not sure why it ever was.

* loader/FrameLoader.cpp:
* loader/FrameLoader.h:
Even though FrameLoader is logically on loading side of WebCore, it's included in
too many places. Not including PolicyChecker.h and ResourceHandle.h was among the
largest wins. As a future improvement, we should probably convert other members
to OwnPtrs.

* css/CSSCrossfadeValue.h: Initializing CachedResourceHandle with 0 requires a
definition of a class it holds, but default construction does not.

* loader/CrossOriginAccessControl.h: This file among others only needs ResourceHandleTypes.h,
not ResourceHandle.h. This header is semi-recent, so not all include sites were updated.

* loader/cache/CachedFont.h:
* loader/cache/CachedFontClient.h: Added.
* loader/cache/CachedRawResource.h:
* loader/cache/CachedRawResourceClient.h: Added.
* loader/cache/CachedSVGDocument.h:
* loader/cache/CachedSVGDocumentClient.h: Added.
These types were defining client types in the same headers, making it impossible
to avoid including networking headers through CachedResource. Moved clients into
separate files.

* plugins/PluginStream.h:
* plugins/PluginStreamClient.h: Added.
Similar situation here.

* loader/cache/CachedResourceHandle.cpp:
* loader/cache/CachedResourceHandle.h:
Moved functions that need to know about CachedResource to .cpp file. This is another
huge win. Added a destructor, so that CachedResource woudn't be needed in all files
that include CachedResourceHandle.

* loader/cache/CachedSVGDocumentReference.cpp: Added.
* loader/cache/CachedSVGDocumentReference.h:
Moved constructor and virtual function implementations to a .cpp file - they need
not inlining, and this lets us avoid including CachedSVGDocument.h in the header.

* platform/graphics/filters/FilterOperation.cpp:
* platform/graphics/filters/FilterOperation.h:
Avoid including CachedSVGDocumentReference.h. This is not such a big win now that
CachedSVGDocumentReference.h itself is smaller, but FilterOperation is so clearly
rendering code that it seems best to cut any ties with resources and loading.
Added a virtual destrutor in .cpp file, because inline destructors in polymorphic
classes are generally harmful (due to code bloat).

* plugins/PluginRequest.h: Added.
* plugins/PluginView.h:
Moved PluginRequest into a separate file, it was out of place in a view hierarchy
class file.

* rendering/RenderImageResource.cpp:
* rendering/RenderImageResource.h:
Moved definitions of virtual functions to a .cpp file. Thre is no win from having
them inline, and now we don't need CachedImage.h in the header.

* rendering/style/StyleCustomFilterProgram.cpp: Added.
* rendering/style/StyleCustomFilterProgram.h:
Ditto.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Modules/mediastream/RTCPeerConnection.cpp:
* Modules/notifications/Notification.cpp:
* Target.pri:
* WebCore.exp.in:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* bindings/ScriptControllerBase.cpp:
* bindings/js/JSNodeCustom.cpp:
* bindings/js/ScriptController.cpp:
* bindings/js/ScriptSourceCode.h:
* bindings/objc/DOM.mm:
* bindings/v8/ScriptController.cpp:
* bindings/v8/V8DOMWindowShell.cpp:
* bindings/v8/custom/V8DOMWindowCustom.cpp:
* css/CSSFontFaceSource.h:
* css/CSSFontSelector.cpp:
* css/WebKitCSSSVGDocumentValue.cpp:
* css/WebKitCSSSVGDocumentValue.h:
* dom/Clipboard.cpp:
* dom/ContainerNode.cpp:
* dom/DOMImplementation.cpp:
* dom/PendingScript.h:
* dom/ScriptElement.cpp:
* dom/ScriptElement.h:
* history/CachedFrame.cpp:
* html/DOMURL.cpp:
* html/HTMLAnchorElement.cpp:
* html/HTMLAppletElement.cpp:
* html/HTMLElement.cpp:
* html/HTMLEmbedElement.cpp:
* html/HTMLFrameSetElement.cpp:
* html/HTMLHtmlElement.cpp:
* html/HTMLImageElement.cpp:
* html/HTMLObjectElement.cpp:
* html/HTMLPlugInElement.cpp:
* html/ImageDocument.cpp:
* html/ImageInputType.cpp:
* html/MediaDocument.cpp:
* html/PluginDocument.cpp:
* html/canvas/WebGLRenderingContext.cpp:
* html/parser/HTMLConstructionSite.cpp:
* html/parser/HTMLParserOptions.cpp:
* html/parser/HTMLScriptRunner.h:
* html/parser/XSSAuditor.cpp:
* html/parser/XSSAuditorDelegate.cpp:
* inspector/InspectorDebuggerAgent.cpp:
* inspector/InspectorFileSystemAgent.cpp:
* inspector/InspectorFrontendHost.cpp:
* inspector/InspectorInstrumentation.h:
* inspector/InspectorPageAgent.cpp:
* inspector/NetworkResourcesData.cpp:
* inspector/NetworkResourcesData.h:
* loader/CookieJar.cpp:
* loader/CrossOriginAccessControl.cpp:
* loader/CrossOriginPreflightResultCache.h:
* loader/DocumentThreadableLoader.h:
* loader/ImageLoader.cpp:
* loader/ImageLoader.h:
* loader/LinkLoader.h:
* loader/MainResourceLoader.cpp:
* loader/MainResourceLoader.h:
* loader/MixedContentChecker.cpp:
* loader/PingLoader.cpp:
* loader/PolicyChecker.h:
* loader/ProgressTracker.cpp:
* loader/SubframeLoader.cpp:
* loader/SubresourceLoader.cpp:
* loader/TextTrackLoader.cpp:
* loader/TextTrackLoader.h:
* loader/ThreadableLoader.h:
* loader/appcache/ApplicationCacheGroup.cpp:
* loader/appcache/ApplicationCacheGroup.h:
* loader/appcache/ApplicationCacheHost.cpp:
* loader/archive/cf/LegacyWebArchive.cpp:
* loader/cache/CachedFont.cpp:
* loader/cache/CachedImage.cpp:
* loader/cache/CachedRawResource.cpp:
* loader/cache/CachedResource.cpp:
* loader/cache/CachedStyleSheetClient.h:
* loader/cache/MemoryCache.cpp:
* loader/cache/MemoryCache.h:
* loader/chromium/CachedRawResourceChromium.cpp:
* loader/icon/IconController.cpp:
* loader/icon/IconLoader.h:
* loader/mac/ResourceLoaderMac.mm:
* page/DOMWindowExtension.cpp:
* page/DragController.cpp:
* page/PerformanceNavigation.cpp:
* page/PerformanceTiming.cpp:
* page/PointerLockController.cpp:
* page/Settings.cpp:
* page/animation/CSSPropertyAnimation.cpp:
* platform/chromium/PasteboardChromium.cpp:
* platform/efl/ErrorsEfl.cpp:
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
* platform/gtk/ErrorsGtk.cpp:
* platform/gtk/PasteboardGtk.cpp:
* platform/gtk/PasteboardHelper.h:
* platform/mac/ClipboardMac.h:
* platform/mac/ClipboardMac.mm:
* platform/mac/HTMLConverter.mm:
* platform/mac/PasteboardMac.mm:
* platform/network/AuthenticationChallengeBase.cpp:
* platform/network/cf/CookieJarCFNet.cpp:
* platform/network/cf/ResourceRequestCFNet.cpp:
* platform/network/mac/CookieStorageMac.mm:
* platform/qt/PasteboardQt.cpp:
* plugins/DOMMimeType.cpp:
* plugins/PluginView.cpp:
* rendering/HitTestResult.cpp:
* rendering/InlineFlowBox.cpp:
* rendering/RenderBox.cpp:
* rendering/RenderEmbeddedObject.cpp:
* rendering/RenderImage.cpp:
* rendering/RenderImageResourceStyleImage.cpp:
* rendering/RenderLayer.cpp:
* rendering/RenderLayerBacking.cpp:
* rendering/RenderLayerFilterInfo.h:
* rendering/RenderListItem.cpp:
* rendering/RenderListMarker.cpp:
* rendering/RenderSnapshottedPlugIn.cpp:
* rendering/RenderTableCol.cpp:
* rendering/RenderTableRow.cpp:
* rendering/RenderTableSection.cpp:
* rendering/style/StyleCachedShader.h:
* svg/SVGFEImageElement.h:
* svg/SVGFontFaceUriElement.h:
* svg/SVGImageLoader.cpp:
* svg/SVGUseElement.cpp:
* svg/SVGUseElement.h:
* svg/graphics/SVGImageCache.cpp:
* testing/MockPagePopupDriver.cpp:
* xml/XSLStyleSheet.h:
* xml/XSLTProcessorLibxslt.cpp:
* xml/parser/XMLDocumentParser.cpp:
* xml/parser/XMLDocumentParser.h:
* xml/parser/XMLDocumentParserLibxml2.cpp:
Many self-evident changes - removing unnecessary header includes, adding smaller
more local ones that are now necessary.

Source/WebKit/chromium:

Adding includes that are now necessary because WebCore headers don't have them
any more.

* src/ApplicationCacheHost.cpp:
* src/AssociatedURLLoader.cpp:
* src/EditorClientImpl.cpp:
* src/SharedWorkerRepository.cpp:
* src/WebDataSourceImpl.cpp:
* src/WebFrameImpl.h:
* src/WebNode.cpp:
* src/WebSharedWorkerImpl.cpp:
* tests/FrameLoaderClientImplTest.cpp:

Source/WebKit/efl:

Adding includes that are now necessary because WebCore headers don't have them
any more.

* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
* ewk/ewk_frame.cpp:

Source/WebKit/gtk:

Adding includes that are now necessary because WebCore headers don't have them
any more.

* webkit/webkitwebpolicydecision.cpp:

Source/WebKit/mac:

Adding includes that are now necessary because WebCore headers don't have them
any more.

* DOM/WebDOMOperations.mm:
* Misc/WebNSPasteboardExtras.mm:
* WebCoreSupport/WebFrameNetworkingContext.mm:
* WebView/WebRenderLayer.mm:
* WebView/WebRenderNode.mm:

Source/WebKit/qt:

Adding includes that are now necessary because WebCore headers don't have them
any more.

* WebCoreSupport/NotificationPresenterClientQt.cpp:
* WebCoreSupport/QWebPageAdapter.cpp:

Source/WebKit2:

Adding includes that are now necessary because WebCore headers don't have them
any more.

* NetworkProcess/HostRecord.h:
* NetworkProcess/NetworkResourceLoadScheduler.h:
* NetworkProcess/NetworkResourceLoader.h:
* Shared/WebRenderLayer.cpp:
* Shared/WebRenderObject.cpp:
* WebProcess/Geolocation/GeolocationPermissionRequestManager.cpp:
* WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
* WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
* WebProcess/InjectedBundle/InjectedBundleDOMWindowExtension.cpp:
* WebProcess/Plugins/PDF/PDFPlugin.mm:
* WebProcess/Plugins/PluginView.cpp:
* WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
* WebProcess/WebCoreSupport/WebEditorClient.cpp:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
* WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
* WebProcess/WebPage/mac/WebPageMac.mm:
* WebProcess/WebProcess.cpp:
* WebProcess/soup/WebProcessSoup.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMerge PerfTestRunner._run_single_test into PerfTestRunner._run_tests_set
rniwa@webkit.org [Fri, 1 Mar 2013 06:34:29 +0000 (06:34 +0000)]
Merge PerfTestRunner._run_single_test into PerfTestRunner._run_tests_set
https://bugs.webkit.org/show_bug.cgi?id=111142

Reviewed by Adam Barth.

Merged _run_single_test into _run_tests_set. The code looks much cleaner now.

Also removed _print_status since it's never used anywhere.

* Scripts/webkitpy/performance_tests/perftestsrunner.py:
(PerfTestsRunner.run):
(PerfTestsRunner._run_tests_set):
* Scripts/webkitpy/performance_tests/perftestsrunner_integrationtest.py:
(MainTest.run_test):
(MainTest.test_run_test_set):
(MainTest.test_run_test_set_kills_drt_per_run):
(MainTest.test_run_test_set_for_parser_tests):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed chromium gardening
toyoshim@chromium.org [Fri, 1 Mar 2013 06:28:41 +0000 (06:28 +0000)]
Unreviewed chromium gardening
https://bugs.webkit.org/show_bug.cgi?id=111141

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[V8] Added V8CustomIndexedGetter to IDLs that correspond to existing custom indexedPr...
commit-queue@webkit.org [Fri, 1 Mar 2013 06:24:16 +0000 (06:24 +0000)]
[V8] Added V8CustomIndexedGetter to IDLs that correspond to existing custom indexedPropertyGetter.
https://bugs.webkit.org/show_bug.cgi?id=110852

Patch by Koji Hara <kojih@chromium.org> on 2013-02-28
Reviewed by Kentaro Hara.

Add V8CustomIndexedGetter attribute that indicates the interface have custom implementation of a getter of indexed properties.
(Also added to the wiki)
https://trac.webkit.org/wiki/WebKitIDL#V8CustomIndexedGetter
Add V8CustomIndexedGetter to IDLs that correspond to existing custom indexedPropertyGetter.
We want to clean up CodeGeneratorV8.pm.
The problem is that all implementations of indexed properties and named properties are currently delegated to custom bindings.
We want to auto-generate as much code as possible.
As a starting point, this commit assures a interface has [V8CustomIndexedGetter] ==> there's custom implementation of indexed getter.

No test. Simple refactoring.

* bindings/scripts/IDLAttributes.txt: Add V8CustomIndexedGetter attribute.
* dom/NamedNodeMap.idl: Add V8CustomIndexedGetter attribute.
* html/HTMLAppletElement.idl: Add V8CustomIndexedGetter attribute.
* html/HTMLEmbedElement.idl: Add V8CustomIndexedGetter attribute.
* html/HTMLFormElement.idl: Add V8CustomIndexedGetter attribute.
* html/HTMLObjectElement.idl: Add V8CustomIndexedGetter attribute.
* html/HTMLOptionsCollection.idl: Add V8CustomIndexedGetter attribute.
* html/HTMLSelectElement.idl: Add V8CustomIndexedGetter attribute.
* page/DOMWindow.idl: Add V8CustomIndexedGetter attribute.
* storage/Storage.idl: Add V8CustomIndexedGetter attribute.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoHeap-use-after-free in WebCore::AudioNodeInput::updateInternalBus
xingnan.wang@intel.com [Fri, 1 Mar 2013 06:07:55 +0000 (06:07 +0000)]
Heap-use-after-free in WebCore::AudioNodeInput::updateInternalBus
https://bugs.webkit.org/show_bug.cgi?id=108542

Replace the wrong AudioNodeOutput::bus() usage out of safe peroid,
which causes this issue.

Reviewed by Chris Rogers.

* Modules/webaudio/AudioNodeInput.cpp:
(WebCore::AudioNodeInput::numberOfChannels):
* Modules/webaudio/AudioNodeOutput.cpp:
(WebCore::AudioNodeOutput::bus):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDisable window occlusion detection for WebKitTestRunner Web View on Mac
commit-queue@webkit.org [Fri, 1 Mar 2013 05:46:21 +0000 (05:46 +0000)]
Disable window occlusion detection for WebKitTestRunner Web View on Mac
https://bugs.webkit.org/show_bug.cgi?id=111116

Patch by Kiran Muppala <cmuppala@apple.com> on 2013-02-28
Reviewed by Simon Fraser.

Window occlusion notifications were causing WebKitTestRunner's Web View
to be detected as occluded and causing a few JavaScript timer layout
tests to fail.  https://bugs.webkit.org/show_bug.cgi?id=111025, fixed this
by initializing the page visibility to "visible" after creating the view.
But a better solution is to disable window occlusion detection, so that
not only the page but also the view is treated as visible.

* WebKitTestRunner/TestController.cpp:
(WTR::TestController::createWebViewWithOptions): Remove call to
setVisibilityState, since it is no longer necessary.
* WebKitTestRunner/mac/PlatformWebViewMac.mm:
(WTR::PlatformWebView::PlatformWebView): Disable window occlusion
detection for the created WKView.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Gardening for some inspector tests
commit-queue@webkit.org [Fri, 1 Mar 2013 05:41:23 +0000 (05:41 +0000)]
[EFL] Gardening for some inspector tests
https://bugs.webkit.org/show_bug.cgi?id=111131

Unreviewed gardening.

Patch by Seokju Kwon <seokju.kwon@gmail.com> on 2013-02-28

* platform/efl-wk1/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r144370.
commit-queue@webkit.org [Fri, 1 Mar 2013 05:03:34 +0000 (05:03 +0000)]
Unreviewed, rolling out r144370.
http://trac.webkit.org/changeset/144370
https://bugs.webkit.org/show_bug.cgi?id=111136

Caused 21 assertion failure at DocumentLoader.cpp(436)
(Requested by toyoshim on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-28

Source/WebCore:

* dom/Document.cpp:
(WebCore::Document::decrementActiveParserCount):
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::isLoading):
(WebCore::DocumentLoader::checkLoadComplete):

LayoutTests:

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, chromium gardening; update expected image for Snow Leopard
toyoshim@chromium.org [Fri, 1 Mar 2013 04:40:10 +0000 (04:40 +0000)]
Unreviewed, chromium gardening; update expected image for Snow Leopard

* platform/chromium-mac-snowleopard/svg/custom/foreign-object-skew-expected.png:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WK2] Refactoring : Fix indentation and braces in WebInspectorClient.h|cpp
commit-queue@webkit.org [Fri, 1 Mar 2013 04:39:52 +0000 (04:39 +0000)]
[WK2] Refactoring : Fix indentation and braces in WebInspectorClient.h|cpp
https://bugs.webkit.org/show_bug.cgi?id=109925

Patch by Seokju Kwon <seokju.kwon@gmail.com> on 2013-02-28
Reviewed by Benjamin Poulain.

The contents of an outermost namespace block should not be indented.
And One-line control clauses should not use braces.

* WebProcess/WebCoreSupport/WebInspectorClient.cpp:
(WebKit::WebInspectorClient::closeInspectorFrontend):
* WebProcess/WebCoreSupport/WebInspectorClient.h:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Events can't be triggered on MediaStreamTrack
li.yin@intel.com [Fri, 1 Mar 2013 04:37:55 +0000 (04:37 +0000)]
[chromium] Events can't be triggered on MediaStreamTrack
https://bugs.webkit.org/show_bug.cgi?id=110930

Reviewed by Kentaro Hara.

Source/WebCore:

Spec: http://dev.w3.org/2011/webrtc/editor/getusermedia.html#mediastreamtrack
ended event handler should be triggered, when stop() is called.

No new tests because the test fast/mediastream/MediaStreamTrack.html
had covered it already.

* platform/mediastream/chromium/MediaStreamCenterChromium.cpp:
(WebCore::MediaStreamCenterChromium::didStopLocalMediaStream):

Tools:

Related code was moved to MediaStreamCenterChromium::didStopLocalMediaStream

* DumpRenderTree/chromium/TestRunner/src/MockWebMediaStreamCenter.cpp:
(WebTestRunner::MockWebMediaStreamCenter::didStopLocalMediaStream):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd a pre-bootstrap message for NetworkProcess XPC service
commit-queue@webkit.org [Fri, 1 Mar 2013 04:18:44 +0000 (04:18 +0000)]
Add a pre-bootstrap message for NetworkProcess XPC service
https://bugs.webkit.org/show_bug.cgi?id=111127

Patch by Kiran Muppala <cmuppala@apple.com> on 2013-02-28
Reviewed by Sam Weinig.

* Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.Development.mm:
(WebKit::XPCServiceEventHandler): Hold on to the pre-bootstrap message.
* Shared/EntryPointUtilities/mac/XPCService/XPCServiceMain.mm:
(WebKit::XPCServiceEventHandler): Ditto.
* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::connectToService): Send a pre-bootstrap message for NetworkProcess
XPC service.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWebKit API for enabling DOM logging for certain worlds
commit-queue@webkit.org [Fri, 1 Mar 2013 03:35:07 +0000 (03:35 +0000)]
WebKit API for enabling DOM logging for certain worlds
https://bugs.webkit.org/show_bug.cgi?id=110779

Source/WebCore:

Patch by Ankur Taly <ataly@google.com> on 2013-02-28
Reviewed by Adam Barth.

Adds additional static methods to DOMWrapperWorld for managing the
mapping between worldIDs and logger objects (where DOM logging messages
are sent), and also defines a class (V8DOMActivityLogger) for logger
objects.

* WebCore.gypi:
* bindings/v8/DOMWrapperWorld.cpp:
(WebCore):
(WebCore::domActivityLoggers):
(WebCore::DOMWrapperWorld::setDOMActivityLogger):
(WebCore::DOMWrapperWorld::getDOMActivityLogger):
* bindings/v8/DOMWrapperWorld.h:
(DOMWrapperWorld):
* bindings/v8/V8DOMActivityLogger.h: Added.
(WebCore):
(V8DOMActivityLogger):
(WebCore::V8DOMActivityLogger::~V8DOMActivityLogger):
(WebCore::V8DOMActivityLogger::log):

Source/WebKit/chromium:

Patch by Ankur Taly <ataly@google.com> on 2013-02-28
Reviewed by Adam Barth.

This patch adds initial plumbing for enabling logging of DOM
activity by JavaScript code running withing v8, on a
per-world basis. In particular it adds methods to the chromium
WebKit API for associating a logger object with world ids for which
DOM activity logging is enabled.

* WebKit.gyp:
* public/WebDOMActivityLogger.h: Added.
(v8):
(WebKit):
(WebDOMActivityLogger):
(WebKit::WebDOMActivityLogger::~WebDOMActivityLogger):
(WebKit::WebDOMActivityLogger::log):
* src/WebDOMActivityLogger.cpp: Added.
(WebKit):
(DOMActivityLoggerContainer):
(WebKit::DOMActivityLoggerContainer::DOMActivityLoggerContainer):
(WebKit::DOMActivityLoggerContainer::~DOMActivityLoggerContainer):
(WebKit::DOMActivityLoggerContainer::log):
(WebKit::hasDOMActivityLogger):
(WebKit::setDOMActivityLogger):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@144408 268f45cc-cd09-0410-ab3c-d52691b4dbfc