sfalken@apple.com [Mon, 4 Apr 2011 18:54:59 +0000 (18:54 +0000)]
Fix Windows build warning.
https://bugs.webkit.org/show_bug.cgi?id=57767
Reviewed by Brian Weinstein.
* win/tools/vsprops/common.vsprops:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82850
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Mon, 4 Apr 2011 18:41:15 +0000 (18:41 +0000)]
2011-04-01 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Make StructureChain GC allocated
https://bugs.webkit.org/show_bug.cgi?id=56695
Make StructureChain GC allocated, and make the various owners
mark it correctly.
* JavaScriptCore.exp:
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
(JSC::CodeBlock::derefStructures):
(JSC::CodeBlock::refStructures):
(JSC::CodeBlock::markAggregate):
* bytecode/Instruction.h:
(JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::set):
(JSC::PolymorphicAccessStructureList::PolymorphicAccessStructureList):
(JSC::PolymorphicAccessStructureList::derefStructures):
(JSC::PolymorphicAccessStructureList::markAggregate):
(JSC::Instruction::Instruction):
* bytecode/StructureStubInfo.cpp:
(JSC::StructureStubInfo::deref):
(JSC::StructureStubInfo::markAggregate):
* bytecode/StructureStubInfo.h:
(JSC::StructureStubInfo::initGetByIdChain):
(JSC::StructureStubInfo::initPutByIdTransition):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitJumpIfNotFunctionCall):
(JSC::BytecodeGenerator::emitJumpIfNotFunctionApply):
* collector/handles/Handle.h:
(JSC::HandleConverter::operator->):
(JSC::HandleConverter::operator*):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_jneq_ptr):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_jneq_ptr):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::privateCompileGetByIdChainList):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::privateCompileGetByIdChainList):
* jit/JITStubs.cpp:
(JSC::JITThunks::tryCachePutByID):
(JSC::JITThunks::tryCacheGetByID):
(JSC::getPolymorphicAccessStructureListSlot):
(JSC::DEFINE_STUB_FUNCTION):
* runtime/JSCell.h:
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
* runtime/JSGlobalData.h:
* runtime/JSGlobalObject.cpp:
(JSC::markIfNeeded):
* runtime/JSGlobalObject.h:
(JSC::Structure::prototypeChain):
* runtime/JSObject.h:
(JSC::JSObject::putDirectInternal):
(JSC::JSObject::markChildrenDirect):
* runtime/JSPropertyNameIterator.cpp:
(JSC::JSPropertyNameIterator::create):
(JSC::JSPropertyNameIterator::get):
(JSC::JSPropertyNameIterator::markChildren):
* runtime/JSPropertyNameIterator.h:
(JSC::JSPropertyNameIterator::setCachedPrototypeChain):
* runtime/JSZombie.cpp:
(JSC::JSZombie::leakedZombieStructure):
* runtime/JSZombie.h:
* runtime/MarkStack.h:
(JSC::MarkStack::append):
* runtime/MarkedBlock.cpp:
(JSC::MarkedBlock::sweep):
* runtime/Structure.cpp:
(JSC::Structure::addPropertyTransition):
* runtime/Structure.h:
(JSC::Structure::markAggregate):
* runtime/StructureChain.cpp:
(JSC::StructureChain::StructureChain):
(JSC::StructureChain::~StructureChain):
(JSC::StructureChain::markChildren):
* runtime/StructureChain.h:
(JSC::StructureChain::create):
(JSC::StructureChain::createStructure):
* runtime/WriteBarrier.h:
(JSC::WriteBarrierBase::get):
(JSC::WriteBarrierBase::operator*):
(JSC::WriteBarrierBase::operator->):
2011-04-01 Oliver Hunt <oliver@apple.com>
Reviewed by Geoffrey Garen.
Make StructureChain GC allocated
https://bugs.webkit.org/show_bug.cgi?id=56695
Update for new Structure marking function
* bindings/js/JSDOMGlobalObject.cpp:
(WebCore::JSDOMGlobalObject::markChildren):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82849
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 4 Apr 2011 18:29:22 +0000 (18:29 +0000)]
2011-04-04 Chang Shu <cshu@webkit.org>
Reviewed by Darin Adler.
WebKitTestRunner needs layoutTestController.setAllowFileAccessFromFileURLs
https://bugs.webkit.org/show_bug.cgi?id=57572
Unskip passed tests.
* platform/mac-wk2/Skipped:
2011-04-04 Chang Shu <cshu@webkit.org>
Reviewed by Darin Adler.
WebKitTestRunner needs layoutTestController.setAllowFileAccessFromFileURLs
https://bugs.webkit.org/show_bug.cgi?id=57572
* Shared/WebPreferencesStore.cpp:
(WebKit::WebPreferencesStore::decode):
(WebKit::WebPreferencesStore::overrideAllowFileAccessFromFileURLsForTestRunner):
* Shared/WebPreferencesStore.h:
* WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundleSetAllowFileAccessFromFileURLs):
* WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::setAllowFileAccessFromFileURLs):
* WebProcess/InjectedBundle/InjectedBundle.h:
2011-04-04 Chang Shu <cshu@webkit.org>
Reviewed by Darin Adler.
WebKitTestRunner needs layoutTestController.setAllowFileAccessFromFileURLs
https://bugs.webkit.org/show_bug.cgi?id=57572
* WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::setAllowFileAccessFromFileURLs):
* WebKitTestRunner/InjectedBundle/LayoutTestController.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82848
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Mon, 4 Apr 2011 18:00:32 +0000 (18:00 +0000)]
2011-04-04 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: add support for the enumerated types in the protocol.
https://bugs.webkit.org/show_bug.cgi?id=57761
* inspector/debugger/debugger-autocontinue-on-syntax-error.html:
* inspector/debugger/debugger-pause-on-exception.html:
2011-04-04 Pavel Feldman <pfeldman@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: add support for the enumerated types in the protocol.
https://bugs.webkit.org/show_bug.cgi?id=57761
* inspector/Inspector.json:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::setPauseOnExceptions):
* inspector/InspectorDebuggerAgent.h:
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::resourceRetrievedByXMLHttpRequestImpl):
(WebCore::InspectorInstrumentation::scriptImportedImpl):
* inspector/InspectorResourceAgent.cpp:
(WebCore::cachedResourceTypeString):
(WebCore::InspectorResourceAgent::didReceiveResponse):
(WebCore::InspectorResourceAgent::setInitialScriptContent):
(WebCore::InspectorResourceAgent::setInitialXHRContent):
* inspector/InspectorResourceAgent.h:
* inspector/front-end/ScriptsPanel.js:
* inspector/generate-inspector-idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82847
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 4 Apr 2011 17:47:03 +0000 (17:47 +0000)]
2011-04-04 Jon Lee <jonlee@apple.com>
Reviewed by Eric Seidel.
add some directories to .gitignore (and svn:ignore) when opening projects in xcode4
https://bugs.webkit.org/show_bug.cgi?id=57646
* .gitignore: added xcode 4 related project and workspace directories that are not needed for checkin
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82846
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Mon, 4 Apr 2011 17:32:51 +0000 (17:32 +0000)]
2011-04-04 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: InspectorRuntimeAgent should not depend on Page
https://bugs.webkit.org/show_bug.cgi?id=57759
Descendants of InspectorRuntimeAgent should implement a method providing access to the default
inspected state used for console evaluations.
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::InspectorAgent): runtime agent is created and deleted along with other agents.
(WebCore::InspectorAgent::setFrontend):
* inspector/InspectorAgent.h:
* inspector/InspectorRuntimeAgent.cpp:
(WebCore::InspectorRuntimeAgent::create):
(WebCore::InspectorRuntimeAgent::InspectorRuntimeAgent):
(WebCore::InspectorRuntimeAgent::evaluate):
* inspector/InspectorRuntimeAgent.h:
(WebCore::InspectorRuntimeAgent::InspectedStateProvider::~InspectedStateProvider):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82845
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 4 Apr 2011 17:29:53 +0000 (17:29 +0000)]
2011-04-04 Keith Kyzivat <keith.kyzivat@nokia.com>
Reviewed by Csaba Osztrogonác.
[Qt] DumpRenderTree breaks compilation in some uClibc environments
https://bugs.webkit.org/show_bug.cgi?id=57602
* DumpRenderTree/qt/main.cpp:
(get_backtrace):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82844
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 4 Apr 2011 17:05:55 +0000 (17:05 +0000)]
2011-04-04 Yong Li <yoli@rim.com>
Reviewed by Antonio Gomes.
https://bugs.webkit.org/show_bug.cgi?id=55969
Add a test that verifies history scroll position is restored
when WebKit goes forward from an unreachable URL error page.
(Error page handling is only supported by Qt DRT.)
* platform/qt/fast/history/back-to-unreachable-url-then-forward-expected.txt: Added.
* platform/qt/fast/history/back-to-unreachable-url-then-forward.html: Added.
* platform/qt/fast/history/resources/check-scroll-position.html: Added.
2011-04-04 Yong Li <yoli@rim.com>
Reviewed by Antonio Gomes.
https://bugs.webkit.org/show_bug.cgi?id=55969
Fix the issue that document state is not saved when
going backward and ending up with error page.
Test: platform/qt/fast/history/back-to-unreachable-url-then-forward.html
(For manual test, load a non-existent html first, then load
fast/history/resources/check-scroll-position.html, then go
back and go forward. If it doesn't show "SUCCESS" at the bottom
of the page, your browser has failed the test)
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::load):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82843
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kevino@webkit.org [Mon, 4 Apr 2011 16:51:34 +0000 (16:51 +0000)]
[wx] Unreviewed build fix, add new LayoutTestController method stub to wx.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82842
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Mon, 4 Apr 2011 16:36:49 +0000 (16:36 +0000)]
Remove a test from the win-wk2 skipped list that does not exist.
fast/js/navigator-mimeTypes-length.html was changed and moved to plugins in r71651.
* platform/win-wk2/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82841
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Mon, 4 Apr 2011 16:20:50 +0000 (16:20 +0000)]
[Windows 7 WebKit2 Release Tests] 6 tests failing since being removed from the mac-wk2
skipped list in r82625.
https://bugs.webkit.org/show_bug.cgi?id=57705
Unreviewed, addd win-wk2 expected results for the tests in order to get the bots green.
* platform/win-wk2/editing: Added.
* platform/win-wk2/editing/selection: Added.
* platform/win-wk2/editing/selection/after-line-break-expected.txt: Added.
* platform/win-wk2/editing/selection/caret-ltr-right-expected.checksum: Added.
* platform/win-wk2/editing/selection/caret-ltr-right-expected.png: Added.
* platform/win-wk2/editing/selection/caret-ltr-right-expected.txt: Added.
* platform/win-wk2/editing/selection/caret-rtl-2-left-expected.checksum: Added.
* platform/win-wk2/editing/selection/caret-rtl-2-left-expected.png: Added.
* platform/win-wk2/editing/selection/caret-rtl-2-left-expected.txt: Added.
* platform/win-wk2/editing/selection/drag-text-delay-expected.txt: Added.
* platform/win-wk2/fast/repaint: Added.
* platform/win-wk2/fast/repaint/japanese-rl-selection-clear-expected.txt: Added.
Apparently the pixel results are similar enough to the win expected pixel results that no
special pixel results need to be added for win-wk2.
* platform/win-wk2/plugins/resize-from-plugin-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82840
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Mon, 4 Apr 2011 15:56:13 +0000 (15:56 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=57683
Flesh out WK2 Icon Database API
Reviewed by Darin Adler.
For now the new API will add a client interface where the WK1 version used NSNotifications.
If we decide we'd like the granularity of specific callback functions later,
they can easily be added on.
Project file nonsense:
* GNUmakefile.am:
* WebKit2.pro:
* WebKit2.xcodeproj/project.pbxproj:
* win/WebKit2.vcproj:
Add a WKIconDatabaseClient and some new API:
* UIProcess/API/C/WKIconDatabase.cpp:
(WKIconDatabaseSetIconDatabaseClient):
(WKIconDatabaseRemoveAllIcons):
(WKIconDatabaseCheckIntegrityBeforeOpening):
* UIProcess/API/C/WKIconDatabase.h:
* UIProcess/API/C/cg/WKIconDatabaseCG.cpp:
(WKIconDatabaseTryGetCGImageForURL): Renamed to "try" for subtle clarification.
* UIProcess/API/C/cg/WKIconDatabaseCG.h:
Implementations for the new APIs:
* UIProcess/WebIconDatabase.cpp:
(WebKit::WebIconDatabase::retainIconForPageURL): Remove excessive logging.
(WebKit::WebIconDatabase::releaseIconForPageURL): Ditto.
(WebKit::WebIconDatabase::imageForPageURL):
(WebKit::WebIconDatabase::removeAllIcons):
(WebKit::WebIconDatabase::checkIntegrityBeforeOpening):
(WebKit::WebIconDatabase::initializeIconDatabaseClient):
(WebKit::WebIconDatabase::didImportIconURLForPageURL): Dispatch a client callback,
much like the WK1 API uses notifications.
(WebKit::WebIconDatabase::didImportIconDataForPageURL): Ditto.
(WebKit::WebIconDatabase::didChangeIconForPageURL): Ditto.
(WebKit::WebIconDatabase::didRemoveAllIcons): Ditto.
* UIProcess/WebIconDatabase.h:
* UIProcess/WebIconDatabaseClient.cpp: Added.
(WebKit::WebIconDatabaseClient::didChangeIconForPageURL):
(WebKit::WebIconDatabaseClient::didRemoveAllIcons):
* UIProcess/WebIconDatabaseClient.h: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82839
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Mon, 4 Apr 2011 15:47:40 +0000 (15:47 +0000)]
2011-04-04 Pavel Podivilov <podivilov@chromium.org>
Unreviewed, mark filesystem-reference.html as CRASH PASS on chromium.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82838
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sergio@webkit.org [Mon, 4 Apr 2011 15:36:19 +0000 (15:36 +0000)]
2011-04-04 Sergio Villar Senin <svillar@igalia.com>
Reviewed by Martin Robinson.
[GTK] Fix make distcheck for 1.4.0
https://bugs.webkit.org/show_bug.cgi?id=57750
Added a missing header file to the Makefile
* GNUmakefile.am:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82837
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Mon, 4 Apr 2011 15:09:00 +0000 (15:09 +0000)]
2011-04-04 Pavel Podivilov <podivilov@chromium.org>
Unreviewed, remove gradientLimit.svg and 2d.text.draw.align.end.ltr.html from test expectations.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82836
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Mon, 4 Apr 2011 14:34:04 +0000 (14:34 +0000)]
2011-04-04 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] http/tests/plugins/post-url-file.html fails on GTK+
https://bugs.webkit.org/show_bug.cgi?id=55826
* http/tests/plugins/resources/dump-post.pl: Instead of just printing out the "keywords" parameter,
print out the POSTDATA parameter as well. Printing "keywords" did not seem to work on the version of
Apache/Perl/CGI that existed on my machine. According to the Perl CGI module documentation
using 'POSTDATA' is the correct way to print the entire POSTDATA for more recent versions of the
module.
* platform/gtk/Skipped: Unskip the test which is now passing.
2011-04-04 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[GTK] http/tests/plugins/post-url-file.html fails on GTK+
https://bugs.webkit.org/show_bug.cgi?id=55826
Correct the implementation of handlePostReadFile which uses GIO APIs and
actually resizes the buffer to fit the entire size of the file data. This
was likely leading to memory corruption until now.
* plugins/gtk/PluginViewGtk.cpp:
(WebCore::PluginView::handlePostReadFile): Fix this method.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82833
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Mon, 4 Apr 2011 14:27:29 +0000 (14:27 +0000)]
2011-04-04 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: [Extensions API] add notifications on panels shown/hidden
https://bugs.webkit.org/show_bug.cgi?id=57752
* http/tests/inspector/extensions-test.js:
(initialize_ExtensionsTest.showPanel):
* http/tests/inspector/resources/extension-main.js:
(showPanel):
* inspector/extensions/extensions-api-expected.txt:
* inspector/extensions/extensions-events-expected.txt:
* inspector/extensions/extensions-events.html:
* inspector/extensions/extensions-expected.txt:
2011-04-04 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: [Extensions API] add notifications on panels shown/hidden
https://bugs.webkit.org/show_bug.cgi?id=57752
* inspector/front-end/ExtensionAPI.js:
(WebInspector.injectedExtensionAPI.PanelImpl):
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype.notifyPanelShown):
(WebInspector.ExtensionServer.prototype.notifyPanelHidden):
* inspector/front-end/Panel.js:
(WebInspector.Panel.prototype.show):
(WebInspector.Panel.prototype.hide):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82832
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Mon, 4 Apr 2011 14:23:25 +0000 (14:23 +0000)]
2011-04-04 Martin Robinson <mrobinson@igalia.com>
Reviewed by Xan Lopez.
[Gtk] webkit_web_view_popup_menu_handler should call SelectionController::localCaretRect
https://bugs.webkit.org/show_bug.cgi?id=54633
Remove use of legacy editing positions when positioning keyboard-driven context
menus. Simplify the code greatly.
* webkit/webkitwebview.cpp:
(getLocationForKeyboardGeneratedContextMenu): Added this helper which calculates
the context menu position.
(webkit_web_view_popup_menu_handler): Simplify code preventing the menu from bumping
into the edges of the view. Remove (0,-1) hack as it no longer seems to be important.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82831
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Mon, 4 Apr 2011 14:17:40 +0000 (14:17 +0000)]
2011-04-04 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: search in resources panel is broken.
https://bugs.webkit.org/show_bug.cgi?id=57631
Search in resources panel should trigger source frame content load.
* inspector/front-end/Panel.js:
(WebInspector.Panel.prototype.jumpToNextSearchResult):
(WebInspector.Panel.prototype.jumpToPreviousSearchResult):
* inspector/front-end/ResourcesPanel.js:
* inspector/front-end/SearchController.js:
(WebInspector.SearchController.prototype.handleShortcut):
(WebInspector.SearchController.prototype.focusSearchField):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.show):
(WebInspector.SourceFrame.prototype._ensureContentLoaded):
(WebInspector.SourceFrame.prototype.performSearch):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82830
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Mon, 4 Apr 2011 14:15:39 +0000 (14:15 +0000)]
2011-04-04 Pavel Podivilov <podivilov@chromium.org>
Unreviewed, mark xhr-breakpoints as CRASH PASS on chromium win debug.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82829
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Mon, 4 Apr 2011 13:53:13 +0000 (13:53 +0000)]
2011-04-03 Eric Seidel <eric@webkit.org>
Reviewed by Ryosuke Niwa.
Split out UnicodeBidi enum into its own header (to allow use in platform)
https://bugs.webkit.org/show_bug.cgi?id=57722
unicode-bidi is a CSS concept. However the same concept is really needed throughout
the bidi code in platform as well. So I'm moving the enum to platform.
The only part of the enum which doesn't make much sense to platform/ is "normal".
* WebCore.xcodeproj/project.pbxproj:
* css/CSSPrimitiveValueMappings.h:
* platform/text/UnicodeBidi.h: Added.
* rendering/style/RenderStyle.h:
* rendering/style/RenderStyleConstants.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82828
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Mon, 4 Apr 2011 13:40:55 +0000 (13:40 +0000)]
2011-04-04 Pavel Podivilov <podivilov@chromium.org>
Unreviewed, udpate chromium-linux test expectations after r82786.
* platform/chromium-linux/fast/table/colspanMinWidth-vertical-expected.checksum: Removed.
* platform/chromium-linux/fast/table/colspanMinWidth-vertical-expected.png:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82827
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Mon, 4 Apr 2011 13:28:42 +0000 (13:28 +0000)]
2011-04-04 Pavel Podivilov <podivilov@chromium.org>
Unreviewed, add chromium-linux expectation for the new test added in r82781.
* platform/chromium-linux/fast/images/imagemap-focus-ring-zero-outline-width-expected.png: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82826
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Mon, 4 Apr 2011 13:00:50 +0000 (13:00 +0000)]
2011-04-04 Pavel Podivilov <podivilov@chromium.org>
Unreviewed, rebaseline chromium-linux test expectations after r82783.
* platform/chromium-linux/fast/html/details-add-summary-1-and-click-expected.png: Added.
* platform/chromium-linux/fast/html/details-add-summary-1-expected.png: Added.
* platform/chromium-linux/fast/html/details-add-summary-10-and-click-expected.png: Added.
* platform/chromium-linux/fast/html/details-add-summary-10-expected.png: Added.
* platform/chromium-linux/fast/html/details-add-summary-2-and-click-expected.png: Added.
* platform/chromium-linux/fast/html/details-add-summary-2-expected.png: Added.
* platform/chromium-linux/fast/html/details-add-summary-3-and-click-expected.png: Added.
* platform/chromium-linux/fast/html/details-add-summary-3-expected.png: Added.
* platform/chromium-linux/fast/html/details-add-summary-4-and-click-expected.png: Added.
* platform/chromium-linux/fast/html/details-add-summary-4-expected.png: Added.
* platform/chromium-linux/fast/html/details-add-summary-5-and-click-expected.png: Added.
* platform/chromium-linux/fast/html/details-add-summary-5-expected.png: Added.
* platform/chromium-linux/fast/html/details-add-summary-6-and-click-expected.png: Added.
* platform/chromium-linux/fast/html/details-add-summary-6-expected.png: Added.
* platform/chromium-linux/fast/html/details-add-summary-7-and-click-expected.png: Added.
* platform/chromium-linux/fast/html/details-add-summary-7-expected.png: Added.
* platform/chromium-linux/fast/html/details-add-summary-8-and-click-expected.png: Added.
* platform/chromium-linux/fast/html/details-add-summary-8-expected.png: Added.
* platform/chromium-linux/fast/html/details-add-summary-9-and-click-expected.png: Added.
* platform/chromium-linux/fast/html/details-add-summary-9-expected.png: Added.
* platform/chromium-linux/fast/html/details-no-summary1-expected.png: Added.
* platform/chromium-linux/fast/html/details-no-summary2-expected.png: Added.
* platform/chromium-linux/fast/html/details-no-summary3-expected.png: Added.
* platform/chromium-linux/fast/html/details-no-summary4-expected.png: Added.
* platform/chromium-linux/fast/html/details-open-javascript-expected.png: Added.
* platform/chromium-linux/fast/html/details-open1-expected.png: Added.
* platform/chromium-linux/fast/html/details-open2-expected.png: Added.
* platform/chromium-linux/fast/html/details-open3-expected.png: Added.
* platform/chromium-linux/fast/html/details-open4-expected.png: Added.
* platform/chromium-linux/fast/html/details-open5-expected.png: Added.
* platform/chromium-linux/fast/html/details-open6-expected.png: Added.
* platform/chromium-linux/fast/html/details-position-expected.png: Added.
* platform/chromium-linux/fast/html/details-remove-summary-1-and-click-expected.png: Added.
* platform/chromium-linux/fast/html/details-remove-summary-1-expected.png: Added.
* platform/chromium-linux/fast/html/details-remove-summary-2-and-click-expected.png: Added.
* platform/chromium-linux/fast/html/details-remove-summary-2-expected.png: Added.
* platform/chromium-linux/fast/html/details-remove-summary-3-and-click-expected.png: Added.
* platform/chromium-linux/fast/html/details-remove-summary-3-expected.png: Added.
* platform/chromium-linux/fast/html/details-remove-summary-4-and-click-expected.png: Added.
* platform/chromium-linux/fast/html/details-remove-summary-4-expected.png: Added.
* platform/chromium-linux/fast/html/details-remove-summary-5-and-click-expected.png: Added.
* platform/chromium-linux/fast/html/details-remove-summary-5-expected.png: Added.
* platform/chromium-linux/fast/html/details-remove-summary-6-and-click-expected.png: Added.
* platform/chromium-linux/fast/html/details-remove-summary-6-expected.png: Added.
* platform/chromium-linux/fast/html/details-writing-mode-expected.png: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82825
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Mon, 4 Apr 2011 12:40:12 +0000 (12:40 +0000)]
2011-04-04 Andrey Adaikin <aandrey@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: Highlighted search tokens would not be shown on long lines in the text viewer
https://bugs.webkit.org/show_bug.cgi?id=57749
* inspector/front-end/TextViewer.js:
(WebInspector.TextEditorMainPanel.prototype.markAndRevealRange):
(WebInspector.TextEditorMainPanel.prototype._paintLine):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82824
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Mon, 4 Apr 2011 11:52:49 +0000 (11:52 +0000)]
2011-04-04 Pavel Podivilov <podivilov@chromium.org>
Unreviewed, add chromium expectations for the new test added in r82781.
* platform/chromium-mac-leopard/fast/images/imagemap-focus-ring-zero-outline-width-expected.png: Added.
* platform/chromium-win/fast/images/imagemap-focus-ring-zero-outline-width-expected.png: Added.
* platform/chromium-win/fast/images/imagemap-focus-ring-zero-outline-width-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82823
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Mon, 4 Apr 2011 11:33:44 +0000 (11:33 +0000)]
2011-04-04 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Incorrectly reports warning on missing/incorrect content-type for 304s
https://bugs.webkit.org/show_bug.cgi?id=48525
* inspector/front-end/Resource.js:
(WebInspector.Resource.prototype._mimeTypeIsConsistentWithType):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82822
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mario@webkit.org [Mon, 4 Apr 2011 11:25:30 +0000 (11:25 +0000)]
2011-04-04 Mario Sanchez Prada <msanchez@igalia.com>
Unreviewed. Unskipped test and added GTK-specific new baseline.
* platform/gtk/Skipped: Skipped passing test.
* platform/gtk/accessibility/aria-roles-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82821
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Mon, 4 Apr 2011 11:08:44 +0000 (11:08 +0000)]
2011-04-04 Pavel Podivilov <podivilov@chromium.org>
Unreviewed, remove chromium expectations added by mistake in r82815.
* platform/chromium-linux-x86_64/fast/table/colspanMinWidth-vertical-expected.png: Removed.
* platform/chromium-win-vista/fast/table/colspanMinWidth-vertical-expected.checksum: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82820
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Mon, 4 Apr 2011 11:01:46 +0000 (11:01 +0000)]
2011-04-04 Pavel Podivilov <podivilov@chromium.org>
Unreviewed, delete duplicate baselines added in r82812.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82819
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Mon, 4 Apr 2011 10:59:51 +0000 (10:59 +0000)]
2011-04-01 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: appropriateSelectorForNode() invokes the "localName" getter on DOMNode rather than function
https://bugs.webkit.org/show_bug.cgi?id=57632
Moved the affected method onto the DOMNode.prototype as "appropriateSelectorFor".
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMNode.prototype.appropriateSelectorFor):
* inspector/front-end/EventListenersSidebarPane.js:
():
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype.addBlankSection):
* inspector/front-end/utilities.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82818
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Mon, 4 Apr 2011 10:56:19 +0000 (10:56 +0000)]
2011-04-04 Pavel Podivilov <podivilov@chromium.org>
Unreviewed, fix bad rebaseline in r82812.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82817
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Mon, 4 Apr 2011 10:27:52 +0000 (10:27 +0000)]
2011-04-04 Pavel Podivilov <podivilov@chromium.org>
Unreviewed, fix exception in rebaseline tool.
* Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82816
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Mon, 4 Apr 2011 10:18:55 +0000 (10:18 +0000)]
2011-04-04 Pavel Podivilov <podivilov@chromium.org>
Unreviewed, udpate chromium test expectations after r82786.
* platform/chromium-linux-x86_64/fast/table/colspanMinWidth-vertical-expected.png: Added.
* platform/chromium-win-vista/fast/table/colspanMinWidth-vertical-expected.checksum: Added.
* platform/chromium-win/fast/table/colspanMinWidth-vertical-expected.checksum: Removed.
* platform/chromium-win/fast/table/colspanMinWidth-vertical-expected.png:
* platform/chromium-win/fast/table/colspanMinWidth-vertical-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82815
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Mon, 4 Apr 2011 10:10:29 +0000 (10:10 +0000)]
2011-04-04 Andrey Kosyakov <caseq@chromium.org>
Unreviewed. Followup to an incomplete commit in r82806.
* inspector/front-end/ExtensionAPI.js:
(WebInspector.injectedExtensionAPI.PanelWithSidebarImpl.prototype.createSidebarPane):
(WebInspector.injectedExtensionAPI.ExtensionSidebarPaneImpl):
(WebInspector.injectedExtensionAPI.ExtensionSidebarPaneImpl.prototype.setHeight):
(WebInspector.injectedExtensionAPI.ExtensionSidebarPaneImpl.prototype.setExpression):
(WebInspector.injectedExtensionAPI):
* inspector/front-end/ExtensionPanel.js:
(WebInspector.ExtensionSidebarPane):
(WebInspector.ExtensionSidebarPane.prototype.setPage):
(WebInspector.ExtensionSidebarPane.prototype._setObject):
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer):
(WebInspector.ExtensionServer.prototype.notifyExtensionSidebarUpdated):
(WebInspector.ExtensionServer.prototype._onCreatePanel):
(WebInspector.ExtensionServer.prototype._onCreateSidebarPane):
(WebInspector.ExtensionServer.prototype.createClientIframe):
(WebInspector.ExtensionServer.prototype._onSetSidebarContent):
2011-04-04 Andrey Kosyakov <caseq@chromium.org>
Unreviewed. Followup to an incomplete commit in r82806.
* inspector/extensions/extensions.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82814
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Mon, 4 Apr 2011 10:04:38 +0000 (10:04 +0000)]
2011-04-04 Pavel Podivilov <podivilov@chromium.org>
Unreviewed, add chromium test expectations for tests added in r82780.
* platform/chromium-mac/fast/dom/Element/scale-page-bounding-client-rect-expected.txt: Added.
* platform/chromium-mac/fast/dom/Element/scale-page-client-rects-expected.txt: Added.
* platform/chromium-mac/fast/dom/Range/scale-page-bounding-client-rect-expected.txt: Added.
* platform/chromium-mac/fast/dom/Range/scale-page-client-rects-expected.txt: Added.
* platform/chromium-win/fast/dom/Element/scale-page-bounding-client-rect-expected.txt: Added.
* platform/chromium-win/fast/dom/Element/scale-page-client-rects-expected.txt: Added.
* platform/chromium-win/fast/dom/Range/scale-page-bounding-client-rect-expected.txt: Added.
* platform/chromium-win/fast/dom/Range/scale-page-client-rects-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82813
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Mon, 4 Apr 2011 09:54:39 +0000 (09:54 +0000)]
2011-04-04 Pavel Podivilov <podivilov@chromium.org>
Unreviewed, rebaseline chromium tests after r82783.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82812
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Mon, 4 Apr 2011 09:44:06 +0000 (09:44 +0000)]
2011-04-04 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Fix Qt minimal build.
* inspector/InspectorFrontendChannel.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82811
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Mon, 4 Apr 2011 09:38:02 +0000 (09:38 +0000)]
2011-04-01 Sergey Vorobyev <sergeyvorobyev@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: Separate sendMessageToFrontend function
from InspectorClient to individual interface.
https://bugs.webkit.org/show_bug.cgi?id=57548
Refactoring - covered with existing inspector tests.
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* inspector/CodeGeneratorInspector.pm:
* inspector/InspectorClient.h:
* inspector/InspectorFrontendChannel.h: Added.
(WebCore::InspectorFrontendChannel::~InspectorFrontendChannel):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82810
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thakis@chromium.org [Mon, 4 Apr 2011 09:20:45 +0000 (09:20 +0000)]
2011-04-04 Nico Weber <thakis@chromium.org>
Reviewed by Eric Seidel.
Prefer a using directive over qualified names in LocalizedNumberICU.cpp
https://bugs.webkit.org/show_bug.cgi?id=57742
Requested by ap in https://bugs.webkit.org/show_bug.cgi?id=57715
* platform/text/LocalizedNumberICU.cpp:
(WebCore::createFormatterForCurrentLocale):
(WebCore::numberFormatter):
(WebCore::parseLocalizedNumber):
(WebCore::formatLocalizedNumber):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82809
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Mon, 4 Apr 2011 09:14:52 +0000 (09:14 +0000)]
2011-04-04 Andrey Adaikin <aandrey@google.com>
Reviewed by Yury Semikhatsky.
Web Inspector: Breakpoints in the gutter stay static while editing the text
https://bugs.webkit.org/show_bug.cgi?id=57616
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame):
(WebInspector.SourceFrame.prototype._saveViewerState):
(WebInspector.SourceFrame.prototype._restoreViewerState):
(WebInspector.SourceFrame.prototype._endEditing):
(WebInspector.SourceFrame.prototype._lineNumberAfterEditing):
(WebInspector.SourceFrame.prototype.addBreakpoint):
(WebInspector.SourceFrame.prototype.removeBreakpoint):
* inspector/front-end/TextViewer.js:
(WebInspector.TextViewer.prototype._syncDecorationsForLine):
(WebInspector):
(WebInspector.TextEditorChunkedPanel.prototype.removeDecoration):
(WebInspector.TextEditorChunkedPanel.prototype.makeLineAChunk):
(WebInspector.TextEditorChunkedPanel.prototype._splitChunkOnALine):
(WebInspector.TextEditorMainPanel.prototype._splitChunkOnALine):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82808
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Mon, 4 Apr 2011 09:03:03 +0000 (09:03 +0000)]
2011-04-04 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: remove obsolete doc generating code from CodeGenerator.
https://bugs.webkit.org/show_bug.cgi?id=57748
* inspector/CodeGeneratorInspector.pm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82807
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Mon, 4 Apr 2011 08:56:33 +0000 (08:56 +0000)]
2011-04-04 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: [Extensions API] Merge WatchExpressionSidebarPane into ExtensionSidebarPane
https://bugs.webkit.org/show_bug.cgi?id=57622
Merged WatchExpressionSidebarPane into ExtensionSidebarPane, added setPage(url).
Fixed wrong getter in schema (scripts -> elements)
* inspector/front-end/ExtensionAPI.js:
(WebInspector.injectedExtensionAPI.WatchExpressionSidebarPaneImpl.prototype.setObject):
(WebInspector.injectedExtensionAPI.WatchExpressionSidebarPaneImpl.prototype.setPage):
* inspector/front-end/ExtensionAPISchema.json:
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._onSetSidebarPage):
2011-04-04 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: [Extensions API] Merge WatchExpressionSidebarPane into ExtensionSidebarPane
https://bugs.webkit.org/show_bug.cgi?id=57622
Merged WatchExpressionSidebarPane into ExtensionSidebarPane, added setPage(url).
Fixed wrong getter in schema (scripts -> elements)
* inspector/extensions/extensions-api-expected.txt:
* inspector/extensions/extensions-expected.txt:
* inspector/extensions/extensions.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82806
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Mon, 4 Apr 2011 08:50:50 +0000 (08:50 +0000)]
2011-04-04 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Main loop sources are leaked in RunLoopGtk
https://bugs.webkit.org/show_bug.cgi?id=57618
* Platform/RunLoop.h:
(RunLoop::TimerBase::isRepeating):
* Platform/gtk/RunLoopGtk.cpp:
(RunLoop::~RunLoop): Make sure main loop is currently running
before calling g_main_loop_quit(), RunLoop::stop() might have been
called.
(RunLoop::wakeUp): Use an idle source with default priority
instead of a timeout one with a 0 interval.
(RunLoop::TimerBase::clearTimerSource): New method to clear the
timer.
(RunLoop::TimerBase::destroyNotifyCallback): Destroy notify
callback called when the source is destroyed to clear the timer.
(RunLoop::TimerBase::timerFiredCallback): Use the same callback for
repeating and no repeating timers.
(RunLoop::TimerBase::start): g_source_attach() increments the
source reference counter, so use GRefPtr to make sure the source
is freed.
(RunLoop::TimerBase::stop): Use clearTimerSource().
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82805
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Mon, 4 Apr 2011 08:33:47 +0000 (08:33 +0000)]
2011-04-04 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: introduce support of 'optional' flag for command arguments.
https://bugs.webkit.org/show_bug.cgi?id=57698
* inspector/protocol/runtime-agent-expected.txt:
* inspector/protocol/runtime-agent.html:
* inspector/report-API-errors-expected.txt:
* inspector/report-API-errors.html:
* inspector/report-protocol-errors-expected.txt:
2011-04-04 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: introduce support of 'optional' flag for command arguments.
https://bugs.webkit.org/show_bug.cgi?id=57698
* inspector/CodeGeneratorInspector.pm:
* inspector/Inspector.json:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::setBreakpointByUrl):
(WebCore::InspectorDebuggerAgent::setBreakpoint):
(WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
* inspector/InspectorDebuggerAgent.h:
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::reloadPage):
* inspector/InspectorPageAgent.h:
* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::getResourceContent):
* inspector/InspectorResourceAgent.h:
* inspector/InspectorRuntimeAgent.cpp:
(WebCore::InspectorRuntimeAgent::evaluate):
* inspector/InspectorRuntimeAgent.h:
* inspector/generate-inspector-idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82804
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Mon, 4 Apr 2011 08:08:28 +0000 (08:08 +0000)]
2011-04-04 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: InjectedScriptManager should not try to access inspected window in case of workers
https://bugs.webkit.org/show_bug.cgi?id=57637
* bindings/js/JSInjectedScriptManager.cpp:
(WebCore::InjectedScriptManager::injectedScriptFor):
* bindings/v8/custom/V8InjectedScriptManager.cpp:
(WebCore::InjectedScriptManager::injectedScriptFor):
* inspector/InjectedScript.cpp:
(WebCore::InjectedScript::InjectedScript):
(WebCore::InjectedScript::canAccessInspectedWindow):
* inspector/InjectedScript.h:
* inspector/InjectedScriptManager.cpp:
(WebCore::InjectedScriptManager::createForPage):
(WebCore::InjectedScriptManager::createForWorker):
(WebCore::InjectedScriptManager::InjectedScriptManager): access check function is passed as a parameter to the constructor
and it depends on which type of context we're inspecting(worker or page).
(WebCore::InjectedScriptManager::canAccessInspectedWorkerContext):
* inspector/InjectedScriptManager.h:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82803
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 4 Apr 2011 07:16:16 +0000 (07:16 +0000)]
2011-04-04 Ryuan Choi <ryuan.choi@samsung.com>
Reviewed by Eric Seidel.
V8StringCallback.cpp requires V8Binding.h
https://bugs.webkit.org/show_bug.cgi?id=57699
No new tests required because of just adding header file.
* bindings/scripts/CodeGeneratorV8.pm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82802
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Mon, 4 Apr 2011 06:41:05 +0000 (06:41 +0000)]
2011-04-03 Kent Tamura <tkent@chromium.org>
Reviewed by Eric Seidel.
Adding a test of value sanitization for <input type=text>
https://bugs.webkit.org/show_bug.cgi?id=57737
* fast/forms/input-value-sanitization-expected.txt:
* fast/forms/script-tests/input-value-sanitization.js: Add tests for type=text.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82801
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 4 Apr 2011 05:40:42 +0000 (05:40 +0000)]
2011-04-03 Ryuan Choi <ryuan.choi@samsung.com>
Reviewed by Eric Seidel.
[CMAKE] Clean duplicated files in WebCore_Sources
https://bugs.webkit.org/show_bug.cgi?id=57741
No new tests, Only duplicated files were removed.
* CMakeLists.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82800
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 4 Apr 2011 04:13:46 +0000 (04:13 +0000)]
2011-04-03 Luke Macpherson <macpherson@chromium.org>
Reviewed by Darin Adler.
Fix 2-space indentation introduced in bug 54706.
https://bugs.webkit.org/show_bug.cgi?id=57740
No new tests - whitespace changes only.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
Convert 2-space indentation to 4-space indentation.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82799
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 4 Apr 2011 03:09:35 +0000 (03:09 +0000)]
2011-04-03 Luke Macpherson <macpherson@chromium.org>
Reviewed by Dimitri Glazkov.
Make CSSStyleApplyProperty non-copyable
https://bugs.webkit.org/show_bug.cgi?id=57738
No new functionality added so no new tests required.
* css/CSSStyleApplyProperty.h:
Added WTF_MAKE_NONCOPYABLE(CSSStyleApplyProperty) to ensure singleton stays single.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82798
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Mon, 4 Apr 2011 02:21:38 +0000 (02:21 +0000)]
Build fix.
* Shared/DictionaryPopupInfo.cpp:
(WebKit::DictionaryPopupInfo::encode):
(WebKit::DictionaryPopupInfo::decode):
* Shared/DictionaryPopupInfo.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82797
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Mon, 4 Apr 2011 02:13:27 +0000 (02:13 +0000)]
<rdar://problem/
9227839> REGRESSION: Reproducible crash in Snow Leopard when trying to show the Dictionary panel or application
https://bugs.webkit.org/show_bug.cgi?id=57739
Reviewed by Maciej Stachowiak.
* Shared/DictionaryPopupInfo.cpp:
(WebKit::DictionaryPopupInfo::encode): Do not encode the options dictionary on Snow Leopard.
(WebKit::DictionaryPopupInfo::decode): Do not decode the options dictionary on Snow Leopard.
* Shared/DictionaryPopupInfo.h: Removed the options member variable on Snow Leopard.
* Shared/Plugins/PluginQuirks.h:
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::performDictionaryLookupForRange): Do not set the options member variable on
Snow Leopard.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82796
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Sun, 3 Apr 2011 23:22:58 +0000 (23:22 +0000)]
fast/images/extra-image-in-image-document.html crashes when run after embed-image.html
https://bugs.webkit.org/show_bug.cgi?id=57733
Reviewed by Maciej Stachowiak.
The crash happens because resetting the page scale as part of preparing the WebView for the
next test triggered layout, which in turn caused a plug-in to make a resource request, and
DumpRenderTree's delegate to be dispatched. The delegate doesn't expect to be called between
tests, and it references the layout test controller, which is null.
* page/Frame.cpp:
(WebCore::Frame::scalePage): Avoid an unnecessary layout if the page scale isn't changing. This
is more efficient, and has the side effect of avoiding the crash in DumpRenderTree, although
DumpRenderTree could still crash when after a test with disabled plug-ins and a non-1 page scale.
I think there are currently no such tests, so I am not fixing DumpRenderTree.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82795
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Sun, 3 Apr 2011 19:17:18 +0000 (19:17 +0000)]
Try to make this test more robust.
* fast/blockflow/broken-ideographic-font.html: Ensure that the font has been loaded before
letting the test finish.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82794
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Sun, 3 Apr 2011 12:37:40 +0000 (12:37 +0000)]
2011-04-03 Eric Seidel <eric@webkit.org>
Reviewed by Ryosuke Niwa.
Teach InlineIterator how to work from any root, not just a RenderBlock
https://bugs.webkit.org/show_bug.cgi?id=57726
For implementing bidi-unicode: isolate, we need to be able to run the
bidi algorithm over a subtree of inlines, not just from a block root.
This is the first step in making this possible.
* rendering/InlineIterator.h:
(WebCore::InlineIterator::InlineIterator):
(WebCore::InlineIterator::root):
(WebCore::bidiNext):
(WebCore::bidiFirst):
(WebCore::InlineIterator::increment):
(WebCore::InlineBidiResolver::appendRun):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::findNextLineBreak):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82793
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Sun, 3 Apr 2011 08:29:40 +0000 (08:29 +0000)]
2011-04-03 Eric Seidel <eric@webkit.org>
Reviewed by Dan Bernstein.
Split out handling of trailing spaces from layoutInlineChildren
https://bugs.webkit.org/show_bug.cgi?id=57432
There is much more we could split out from this function, but this is a start.
I suspect this is very hot code. Hopefully the compiler will do the right thing.
If it doesn't the Chromium PLT bots will tell us.
* rendering/RenderBlock.h:
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::handleTrailingSpaces):
(WebCore::RenderBlock::layoutInlineChildren):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82792
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Sun, 3 Apr 2011 07:54:33 +0000 (07:54 +0000)]
2011-03-21 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
editing commands shouldn't run when there's no body
https://bugs.webkit.org/show_bug.cgi?id=56771
The bug was caused by WebKit's not checking the existence of root editable element
in enabled* functions. Although isContentEditable returns true whenever we're in design mode,
we should not run editing commands in a document without a body element editable because
doing so results in appending a non-body element to the document node.
Fixed the bug by modifying various enabled* functions to ensure we have a root editable element.
New behavior tries to match that of Firefox except StyleWithCSS, which Firefox seems to ignore
when there are no body element. Since StyleWithCSS is a document's state or property, we allow
execCommand('StyleWithCSS') even in a document without a body element.
WebKit's and Firefox's behaviors also deviate in insert-image-with-selecting-document.html.
Whereas WebKit respects selection set by script and ignores execCommand, Firefox modifies
the selection when document.write("x") is ran and successfully inserts image.
Thus, empty-document-delete.html and empty-document-justify-right.html both pass on Firefox
while empty-document-stylewithcss.html and insert-image-with-selecting-document.html both fail.
Since Internet Explorer does not allow execCommand to run under design mode properly, we could
not test its behavior.
Tests: editing/editability/empty-document-delete.html
editing/editability/empty-document-justify-right.html
editing/editability/empty-document-stylewithcss.html
editing/execCommand/insert-image-with-selecting-document.html
* editing/Editor.cpp:
(WebCore::Editor::canEdit): Verify that the root editable element exists
instead of just checking that selection endpoints are editable because
selection endpoints could be document node without a body element in design mode
and we don't want to consider such a document editable.
(WebCore::Editor::canDelete): Ditto.
* editing/EditorCommand.cpp:
(WebCore::enabledInEditableText): Ditto.
(WebCore::enabledInRichlyEditableText): Ditto.
(WebCore::enabledDelete): Call enabledCut and enabledInEditableText instead
of duplicating the code in order to fix the same bug.
2011-03-21 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
editing commands shouldn't run when there's no body
https://bugs.webkit.org/show_bug.cgi?id=56771
Added tests to ensure WebKit does not crash when attempted to execute editing commands
in an empty document. Also added a test to ensure WebKit does not crash when InsertImage
is executed with selection endpoints being document. WebKit should ignore such attempts
and should not crash.
* editing/editability/empty-document-delete-expected.txt: Added.
* editing/editability/empty-document-delete.html: Added.
* editing/editability/empty-document-justify-right-expected.txt: Added.
* editing/editability/empty-document-justify-right.html: Added.
* editing/editability/empty-document-stylewithcss-expected.txt: Added.
* editing/editability/empty-document-stylewithcss.html: Added.
* editing/execCommand/insert-image-with-selecting-document-expected.txt: Added.
* editing/execCommand/insert-image-with-selecting-document.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82791
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Sun, 3 Apr 2011 06:30:06 +0000 (06:30 +0000)]
Updated results showing a progression after r82787. The current time display
is now correctly collapsed because the timeline container is not wide enough.
* platform/gtk/media/video-zoom-controls-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82790
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Sun, 3 Apr 2011 06:22:02 +0000 (06:22 +0000)]
Updated platform-specific results after r82787.
* platform/gtk/fast/table/colspanMinWidth-vertical-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82789
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Sun, 3 Apr 2011 05:40:51 +0000 (05:40 +0000)]
REGRESSION (r82786): Media controls render incorrectly on GTK and Qt
https://bugs.webkit.org/show_bug.cgi?id=57719
Reviewed by Maciej Stachowiak.
r82786 exposed an incorrect assumption inRenderMediaControlTimeDisplay::layout()
that the timeline container is the parent of the time display. This is not true
with the GTK media style, where the current time display is an inline box, and
thus wrapped in an anonymous flexible box. The code was incorrectly considering
the width of the anonymous box and deciding to hide the time display. Prior to
r82786, this mistake was corrected by the call to computeLogicalWidth() in line layout.
* rendering/MediaControlElements.cpp:
(WebCore::RenderMediaControlTimeDisplay::layout): Changed to skip past anonymous ancestors.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82788
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thakis@chromium.org [Sun, 3 Apr 2011 04:55:07 +0000 (04:55 +0000)]
2011-04-02 Nico Weber <thakis@chromium.org>
Reviewed by Adam Barth.
Explicitly use icu namespace for ports building with U_USING_ICU_NAMESPACE=0
By default, ICU includes |using namespace icu;| in its header files
for backwards compatibility. Clients can define
U_USING_ICU_NAMESPACE=0 to tell ICU to not do this. Prefixing all ICU
classes with |icu::| makes this file compile no matter what
U_USING_ICU_NAMESPACE is set to.
https://bugs.webkit.org/show_bug.cgi?id=57715
* platform/text/LocalizedNumberICU.cpp:
(WebCore::createFormatterForCurrentLocale):
(WebCore::numberFormatter):
(WebCore::parseLocalizedNumber):
(WebCore::formatLocalizedNumber):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82787
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Sun, 3 Apr 2011 01:47:22 +0000 (01:47 +0000)]
Remove an unnecessary extra computeLogicalWidth() from line layout
https://bugs.webkit.org/show_bug.cgi?id=57711
Reviewed by Dave Hyatt.
Source/WebCore:
Changes in behavior (MathML progression) covered by existing layout tests.
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Removed a
call to computeLogicalWidth(). Because of <http://webkit.org/b/57700>, this
actually prevents MathML rows from reverting to an incorrect width.
LayoutTests:
These updated expected results show progressions in MathML tests.
fast/table/colspanMinWidth-vertical results changed to show that text controls
still do not handle vertical writing modes correctly.
* platform/mac/fast/table/colspanMinWidth-vertical-expected.checksum:
* platform/mac/fast/table/colspanMinWidth-vertical-expected.png:
* platform/mac/fast/table/colspanMinWidth-vertical-expected.txt:
* platform/mac/mathml/presentation/fractions-expected.checksum:
* platform/mac/mathml/presentation/fractions-expected.png:
* platform/mac/mathml/presentation/fractions-expected.txt:
* platform/mac/mathml/presentation/fractions-vertical-alignment-expected.checksum:
* platform/mac/mathml/presentation/fractions-vertical-alignment-expected.png:
* platform/mac/mathml/presentation/fractions-vertical-alignment-expected.txt:
* platform/mac/mathml/presentation/roots-expected.checksum:
* platform/mac/mathml/presentation/roots-expected.png:
* platform/mac/mathml/presentation/roots-expected.txt:
* platform/mac/mathml/presentation/row-alignment-expected.checksum:
* platform/mac/mathml/presentation/row-alignment-expected.png:
* platform/mac/mathml/presentation/row-alignment-expected.txt:
* platform/mac/mathml/presentation/subsup-expected.checksum:
* platform/mac/mathml/presentation/subsup-expected.png:
* platform/mac/mathml/presentation/subsup-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82786
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Sun, 3 Apr 2011 01:43:47 +0000 (01:43 +0000)]
Updated platform-specific results after r82873.
* platform/gtk/fast/html/details-add-summary-1-and-click-expected.txt:
* platform/gtk/fast/html/details-add-summary-1-expected.txt:
* platform/gtk/fast/html/details-add-summary-10-and-click-expected.txt:
* platform/gtk/fast/html/details-add-summary-10-expected.txt:
* platform/gtk/fast/html/details-add-summary-2-and-click-expected.txt:
* platform/gtk/fast/html/details-add-summary-2-expected.txt:
* platform/gtk/fast/html/details-add-summary-3-and-click-expected.txt:
* platform/gtk/fast/html/details-add-summary-3-expected.txt:
* platform/gtk/fast/html/details-add-summary-4-and-click-expected.txt:
* platform/gtk/fast/html/details-add-summary-4-expected.txt:
* platform/gtk/fast/html/details-add-summary-5-and-click-expected.txt:
* platform/gtk/fast/html/details-add-summary-5-expected.txt:
* platform/gtk/fast/html/details-add-summary-6-and-click-expected.txt:
* platform/gtk/fast/html/details-add-summary-6-expected.txt:
* platform/gtk/fast/html/details-add-summary-7-and-click-expected.txt:
* platform/gtk/fast/html/details-add-summary-7-expected.txt:
* platform/gtk/fast/html/details-add-summary-8-and-click-expected.txt:
* platform/gtk/fast/html/details-add-summary-8-expected.txt:
* platform/gtk/fast/html/details-add-summary-9-and-click-expected.txt:
* platform/gtk/fast/html/details-add-summary-9-expected.txt:
* platform/gtk/fast/html/details-no-summary1-expected.txt:
* platform/gtk/fast/html/details-no-summary2-expected.txt:
* platform/gtk/fast/html/details-no-summary3-expected.txt:
* platform/gtk/fast/html/details-no-summary4-expected.txt:
* platform/gtk/fast/html/details-open-javascript-expected.txt:
* platform/gtk/fast/html/details-open1-expected.txt:
* platform/gtk/fast/html/details-open2-expected.txt:
* platform/gtk/fast/html/details-open3-expected.txt:
* platform/gtk/fast/html/details-open4-expected.txt:
* platform/gtk/fast/html/details-open5-expected.txt:
* platform/gtk/fast/html/details-open6-expected.txt:
* platform/gtk/fast/html/details-position-expected.txt:
* platform/gtk/fast/html/details-remove-summary-1-and-click-expected.txt:
* platform/gtk/fast/html/details-remove-summary-1-expected.txt:
* platform/gtk/fast/html/details-remove-summary-2-and-click-expected.txt:
* platform/gtk/fast/html/details-remove-summary-2-expected.txt:
* platform/gtk/fast/html/details-remove-summary-3-and-click-expected.txt:
* platform/gtk/fast/html/details-remove-summary-3-expected.txt:
* platform/gtk/fast/html/details-remove-summary-4-and-click-expected.txt:
* platform/gtk/fast/html/details-remove-summary-4-expected.txt:
* platform/gtk/fast/html/details-remove-summary-5-and-click-expected.txt:
* platform/gtk/fast/html/details-remove-summary-5-expected.txt:
* platform/gtk/fast/html/details-remove-summary-6-and-click-expected.txt:
* platform/gtk/fast/html/details-remove-summary-6-expected.txt:
* platform/gtk/fast/html/details-writing-mode-expected.txt:
* platform/qt/fast/html/details-add-summary-1-and-click-expected.txt:
* platform/qt/fast/html/details-add-summary-1-expected.txt:
* platform/qt/fast/html/details-add-summary-10-and-click-expected.txt:
* platform/qt/fast/html/details-add-summary-10-expected.txt:
* platform/qt/fast/html/details-add-summary-2-and-click-expected.txt:
* platform/qt/fast/html/details-add-summary-2-expected.txt:
* platform/qt/fast/html/details-add-summary-3-and-click-expected.txt:
* platform/qt/fast/html/details-add-summary-3-expected.txt:
* platform/qt/fast/html/details-add-summary-4-and-click-expected.txt:
* platform/qt/fast/html/details-add-summary-4-expected.txt:
* platform/qt/fast/html/details-add-summary-5-and-click-expected.txt:
* platform/qt/fast/html/details-add-summary-5-expected.txt:
* platform/qt/fast/html/details-add-summary-6-and-click-expected.txt:
* platform/qt/fast/html/details-add-summary-6-expected.txt:
* platform/qt/fast/html/details-add-summary-7-and-click-expected.txt:
* platform/qt/fast/html/details-add-summary-7-expected.txt:
* platform/qt/fast/html/details-add-summary-8-and-click-expected.txt:
* platform/qt/fast/html/details-add-summary-8-expected.txt:
* platform/qt/fast/html/details-add-summary-9-and-click-expected.txt:
* platform/qt/fast/html/details-add-summary-9-expected.txt:
* platform/qt/fast/html/details-no-summary1-expected.txt:
* platform/qt/fast/html/details-no-summary2-expected.txt:
* platform/qt/fast/html/details-no-summary3-expected.txt:
* platform/qt/fast/html/details-no-summary4-expected.txt:
* platform/qt/fast/html/details-open-javascript-expected.txt:
* platform/qt/fast/html/details-open1-expected.txt:
* platform/qt/fast/html/details-open2-expected.txt:
* platform/qt/fast/html/details-open3-expected.txt:
* platform/qt/fast/html/details-open4-expected.txt:
* platform/qt/fast/html/details-open5-expected.txt:
* platform/qt/fast/html/details-open6-expected.txt:
* platform/qt/fast/html/details-position-expected.txt:
* platform/qt/fast/html/details-remove-summary-1-and-click-expected.txt:
* platform/qt/fast/html/details-remove-summary-1-expected.txt:
* platform/qt/fast/html/details-remove-summary-2-and-click-expected.txt:
* platform/qt/fast/html/details-remove-summary-2-expected.txt:
* platform/qt/fast/html/details-remove-summary-3-and-click-expected.txt:
* platform/qt/fast/html/details-remove-summary-3-expected.txt:
* platform/qt/fast/html/details-remove-summary-4-and-click-expected.txt:
* platform/qt/fast/html/details-remove-summary-4-expected.txt:
* platform/qt/fast/html/details-remove-summary-5-and-click-expected.txt:
* platform/qt/fast/html/details-remove-summary-5-expected.txt:
* platform/qt/fast/html/details-remove-summary-6-and-click-expected.txt:
* platform/qt/fast/html/details-remove-summary-6-expected.txt:
* platform/qt/fast/html/details-writing-mode-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82785
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin@apple.com [Sun, 3 Apr 2011 00:47:44 +0000 (00:47 +0000)]
For Dan!
* DumpRenderTree/mac/DumpRenderTree.mm:
(resetWebViewToConsistentStateBeforeTesting):
Rubber-stamped by Geoff Garen.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82784
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Sun, 3 Apr 2011 00:34:42 +0000 (00:34 +0000)]
<details> marker loses its margin
https://bugs.webkit.org/show_bug.cgi?id=57713
Reviewed by Beth Dakin.
Source/WebCore:
* rendering/RenderDetails.cpp:
(WebCore::RenderDetails::computePreferredLogicalWidths): Override to update
the marker location.
* rendering/RenderDetails.h:
(WebCore::RenderDetails::renderName): Made private.
(WebCore::RenderDetails::isDetails): Ditto.
* rendering/RenderDetailsMarker.cpp:
(WebCore::RenderDetailsMarker::computePreferredLogicalWidths): Set the margins
in the style, like RenderListMarker does.
(WebCore::RenderDetailsMarker::layout): Set the margins from the style.
LayoutTests:
* platform/mac/fast/html/details-add-summary-1-and-click-expected.checksum:
* platform/mac/fast/html/details-add-summary-1-and-click-expected.png:
* platform/mac/fast/html/details-add-summary-1-and-click-expected.txt:
* platform/mac/fast/html/details-add-summary-1-expected.checksum:
* platform/mac/fast/html/details-add-summary-1-expected.png:
* platform/mac/fast/html/details-add-summary-1-expected.txt:
* platform/mac/fast/html/details-add-summary-10-and-click-expected.checksum:
* platform/mac/fast/html/details-add-summary-10-and-click-expected.png:
* platform/mac/fast/html/details-add-summary-10-and-click-expected.txt:
* platform/mac/fast/html/details-add-summary-10-expected.checksum:
* platform/mac/fast/html/details-add-summary-10-expected.png:
* platform/mac/fast/html/details-add-summary-10-expected.txt:
* platform/mac/fast/html/details-add-summary-2-and-click-expected.checksum:
* platform/mac/fast/html/details-add-summary-2-and-click-expected.png:
* platform/mac/fast/html/details-add-summary-2-and-click-expected.txt:
* platform/mac/fast/html/details-add-summary-2-expected.checksum:
* platform/mac/fast/html/details-add-summary-2-expected.png:
* platform/mac/fast/html/details-add-summary-2-expected.txt:
* platform/mac/fast/html/details-add-summary-3-and-click-expected.checksum:
* platform/mac/fast/html/details-add-summary-3-and-click-expected.png:
* platform/mac/fast/html/details-add-summary-3-and-click-expected.txt:
* platform/mac/fast/html/details-add-summary-3-expected.checksum:
* platform/mac/fast/html/details-add-summary-3-expected.png:
* platform/mac/fast/html/details-add-summary-3-expected.txt:
* platform/mac/fast/html/details-add-summary-4-and-click-expected.checksum:
* platform/mac/fast/html/details-add-summary-4-and-click-expected.png:
* platform/mac/fast/html/details-add-summary-4-and-click-expected.txt:
* platform/mac/fast/html/details-add-summary-4-expected.checksum:
* platform/mac/fast/html/details-add-summary-4-expected.png:
* platform/mac/fast/html/details-add-summary-4-expected.txt:
* platform/mac/fast/html/details-add-summary-5-and-click-expected.checksum:
* platform/mac/fast/html/details-add-summary-5-and-click-expected.png:
* platform/mac/fast/html/details-add-summary-5-and-click-expected.txt:
* platform/mac/fast/html/details-add-summary-5-expected.checksum:
* platform/mac/fast/html/details-add-summary-5-expected.png:
* platform/mac/fast/html/details-add-summary-5-expected.txt:
* platform/mac/fast/html/details-add-summary-6-and-click-expected.checksum:
* platform/mac/fast/html/details-add-summary-6-and-click-expected.png:
* platform/mac/fast/html/details-add-summary-6-and-click-expected.txt:
* platform/mac/fast/html/details-add-summary-6-expected.checksum:
* platform/mac/fast/html/details-add-summary-6-expected.png:
* platform/mac/fast/html/details-add-summary-6-expected.txt:
* platform/mac/fast/html/details-add-summary-7-and-click-expected.checksum:
* platform/mac/fast/html/details-add-summary-7-and-click-expected.png:
* platform/mac/fast/html/details-add-summary-7-and-click-expected.txt:
* platform/mac/fast/html/details-add-summary-7-expected.checksum:
* platform/mac/fast/html/details-add-summary-7-expected.png:
* platform/mac/fast/html/details-add-summary-7-expected.txt:
* platform/mac/fast/html/details-add-summary-8-and-click-expected.checksum:
* platform/mac/fast/html/details-add-summary-8-and-click-expected.png:
* platform/mac/fast/html/details-add-summary-8-and-click-expected.txt:
* platform/mac/fast/html/details-add-summary-8-expected.checksum:
* platform/mac/fast/html/details-add-summary-8-expected.png:
* platform/mac/fast/html/details-add-summary-8-expected.txt:
* platform/mac/fast/html/details-add-summary-9-and-click-expected.checksum:
* platform/mac/fast/html/details-add-summary-9-and-click-expected.png:
* platform/mac/fast/html/details-add-summary-9-and-click-expected.txt:
* platform/mac/fast/html/details-add-summary-9-expected.checksum:
* platform/mac/fast/html/details-add-summary-9-expected.png:
* platform/mac/fast/html/details-add-summary-9-expected.txt:
* platform/mac/fast/html/details-no-summary1-expected.checksum:
* platform/mac/fast/html/details-no-summary1-expected.png:
* platform/mac/fast/html/details-no-summary1-expected.txt:
* platform/mac/fast/html/details-no-summary2-expected.checksum:
* platform/mac/fast/html/details-no-summary2-expected.png:
* platform/mac/fast/html/details-no-summary2-expected.txt:
* platform/mac/fast/html/details-no-summary3-expected.checksum:
* platform/mac/fast/html/details-no-summary3-expected.png:
* platform/mac/fast/html/details-no-summary3-expected.txt:
* platform/mac/fast/html/details-no-summary4-expected.checksum:
* platform/mac/fast/html/details-no-summary4-expected.png:
* platform/mac/fast/html/details-no-summary4-expected.txt:
* platform/mac/fast/html/details-open-javascript-expected.checksum:
* platform/mac/fast/html/details-open-javascript-expected.png:
* platform/mac/fast/html/details-open-javascript-expected.txt:
* platform/mac/fast/html/details-open1-expected.checksum:
* platform/mac/fast/html/details-open1-expected.png:
* platform/mac/fast/html/details-open1-expected.txt:
* platform/mac/fast/html/details-open2-expected.checksum:
* platform/mac/fast/html/details-open2-expected.png:
* platform/mac/fast/html/details-open2-expected.txt:
* platform/mac/fast/html/details-open3-expected.checksum:
* platform/mac/fast/html/details-open3-expected.png:
* platform/mac/fast/html/details-open3-expected.txt:
* platform/mac/fast/html/details-open4-expected.checksum:
* platform/mac/fast/html/details-open4-expected.png:
* platform/mac/fast/html/details-open4-expected.txt:
* platform/mac/fast/html/details-open5-expected.checksum:
* platform/mac/fast/html/details-open5-expected.png:
* platform/mac/fast/html/details-open5-expected.txt:
* platform/mac/fast/html/details-open6-expected.checksum:
* platform/mac/fast/html/details-open6-expected.png:
* platform/mac/fast/html/details-open6-expected.txt:
* platform/mac/fast/html/details-position-expected.checksum:
* platform/mac/fast/html/details-position-expected.png:
* platform/mac/fast/html/details-position-expected.txt:
* platform/mac/fast/html/details-remove-summary-1-and-click-expected.checksum:
* platform/mac/fast/html/details-remove-summary-1-and-click-expected.png:
* platform/mac/fast/html/details-remove-summary-1-and-click-expected.txt:
* platform/mac/fast/html/details-remove-summary-1-expected.checksum:
* platform/mac/fast/html/details-remove-summary-1-expected.png:
* platform/mac/fast/html/details-remove-summary-1-expected.txt:
* platform/mac/fast/html/details-remove-summary-2-and-click-expected.checksum:
* platform/mac/fast/html/details-remove-summary-2-and-click-expected.png:
* platform/mac/fast/html/details-remove-summary-2-and-click-expected.txt:
* platform/mac/fast/html/details-remove-summary-2-expected.checksum:
* platform/mac/fast/html/details-remove-summary-2-expected.png:
* platform/mac/fast/html/details-remove-summary-2-expected.txt:
* platform/mac/fast/html/details-remove-summary-3-and-click-expected.checksum:
* platform/mac/fast/html/details-remove-summary-3-and-click-expected.png:
* platform/mac/fast/html/details-remove-summary-3-and-click-expected.txt:
* platform/mac/fast/html/details-remove-summary-3-expected.checksum:
* platform/mac/fast/html/details-remove-summary-3-expected.png:
* platform/mac/fast/html/details-remove-summary-3-expected.txt:
* platform/mac/fast/html/details-remove-summary-4-and-click-expected.checksum:
* platform/mac/fast/html/details-remove-summary-4-and-click-expected.png:
* platform/mac/fast/html/details-remove-summary-4-and-click-expected.txt:
* platform/mac/fast/html/details-remove-summary-4-expected.checksum:
* platform/mac/fast/html/details-remove-summary-4-expected.png:
* platform/mac/fast/html/details-remove-summary-4-expected.txt:
* platform/mac/fast/html/details-remove-summary-5-and-click-expected.checksum:
* platform/mac/fast/html/details-remove-summary-5-and-click-expected.png:
* platform/mac/fast/html/details-remove-summary-5-and-click-expected.txt:
* platform/mac/fast/html/details-remove-summary-5-expected.checksum:
* platform/mac/fast/html/details-remove-summary-5-expected.png:
* platform/mac/fast/html/details-remove-summary-5-expected.txt:
* platform/mac/fast/html/details-remove-summary-6-and-click-expected.checksum:
* platform/mac/fast/html/details-remove-summary-6-and-click-expected.png:
* platform/mac/fast/html/details-remove-summary-6-and-click-expected.txt:
* platform/mac/fast/html/details-remove-summary-6-expected.checksum:
* platform/mac/fast/html/details-remove-summary-6-expected.png:
* platform/mac/fast/html/details-remove-summary-6-expected.txt:
* platform/mac/fast/html/details-writing-mode-expected.checksum:
* platform/mac/fast/html/details-writing-mode-expected.png:
* platform/mac/fast/html/details-writing-mode-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82783
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin@apple.com [Sun, 3 Apr 2011 00:19:41 +0000 (00:19 +0000)]
Need to reset the scale, much like zoom.
* DumpRenderTree/mac/DumpRenderTree.mm:
(resetWebViewToConsistentStateBeforeTesting):
Rubber-stamped by Geoff Garen.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82782
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aestes@apple.com [Sun, 3 Apr 2011 00:01:42 +0000 (00:01 +0000)]
2011-04-02 Andy Estes <aestes@apple.com>
Reviewed by Oliver Hunt.
REGRESSION (r69237): Black border around map elements while using an image map on Mac platform
https://bugs.webkit.org/show_bug.cgi?id=52518
Test: fast/images/imagemap-focus-ring-zero-outline-width.html
* rendering/RenderImage.cpp:
(WebCore::RenderImage::paintAreaElementFocusRing): Return early if outlineWidth is 0.
2011-04-02 Andy Estes <aestes@apple.com>
Reviewed by Oliver Hunt.
REGRESSION (r69237): Black border around map elements while using an image map on Mac platform
https://bugs.webkit.org/show_bug.cgi?id=52518
* fast/images/imagemap-focus-ring-zero-outline-width.html: Added.
* platform/mac/fast/images/imagemap-focus-ring-zero-outline-width-expected.checksum: Added.
* platform/mac/fast/images/imagemap-focus-ring-zero-outline-width-expected.png: Added.
* platform/mac/fast/images/imagemap-focus-ring-zero-outline-width-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82781
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin@apple.com [Sat, 2 Apr 2011 23:46:28 +0000 (23:46 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=57605
Frame::pageScaleFactor() should not affect getBoundingClientRect() or
getClientRects()
-and corresponding-
<rdar://problem/
9194541>
Source/WebKit2:
Patch by Sam Weinig <sam@webkit.org> on 2011-04-02
Reviewed by Beth Dakin.
Add DRT support for the scaleWebView SPI.
* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageSetScaleAtOrigin):
* WebProcess/InjectedBundle/API/c/WKBundlePagePrivate.h:
Tools:
Patch by Sam Weinig <sam@webkit.org> on 2011-04-02
Reviewed by Beth Dakin.
Add DRT support for the scaleWebView SPI.
* DumpRenderTree/mac/EventSendingController.mm:
(+[EventSendingController isSelectorExcludedFromWebScript:]):
(+[EventSendingController webScriptNameForSelector:]):
(-[EventSendingController scalePageBy:atX:andY:]):
* WebKitTestRunner/InjectedBundle/Bindings/EventSendingController.idl:
* WebKitTestRunner/InjectedBundle/EventSendingController.cpp:
(WTR::EventSendingController::scalePageBy):
* WebKitTestRunner/InjectedBundle/EventSendingController.h:
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::reset):
LayoutTests:
Reviewed by Sam Weinig.
* fast/dom/Element/scale-page-bounding-client-rect-expected.txt: Added.
* fast/dom/Element/scale-page-bounding-client-rect.html: Added.
* fast/dom/Element/scale-page-client-rects-expected.txt: Added.
* fast/dom/Element/scale-page-client-rects.html: Added.
* fast/dom/Range/scale-page-bounding-client-rect-expected.txt: Added.
* fast/dom/Range/scale-page-bounding-client-rect.html: Added.
* fast/dom/Range/scale-page-client-rects-expected.txt: Added.
* fast/dom/Range/scale-page-client-rects.html: Added.
* platform/gtk/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82780
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Sat, 2 Apr 2011 23:19:51 +0000 (23:19 +0000)]
2011-04-02 Sam Weinig <sam@webkit.org>
Reviewed by Oliver Hunt.
"Search in Spotlight" broken in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=57712
Proxy spotlight searching to the UIProcess.
* UIProcess/WebPageProxy.messages.in:
Add new message. Re-organize messages to put all mac specific ones together.
* UIProcess/WebPageProxy.h:
* UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::speak):
(WebKit::WebPageProxy::searchWithSpotlight):
Moved code to trigger spotlight here. Use WTF::String -> NSString conversion function
instead of relying on the built in conversion since it doesn't always work in the UIProcess.
* WebProcess/WebCoreSupport/mac/WebContextMenuClientMac.mm:
(WebKit::WebContextMenuClient::searchWithSpotlight):
Post message to the UIProcess to do the searching.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82779
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin@apple.com [Sat, 2 Apr 2011 22:36:50 +0000 (22:36 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=57605
Frame::pageScaleFactor() should not affect getBoundingClientRect() or
getClientRects()
-and corresponding-
<rdar://problem/
9194541>
Reviewed by Sam Weinig.
New functions adjust*ForPageScale() are analogous to adjust*ForAbsoluteZoom().
* dom/Element.cpp:
(WebCore::Element::getClientRects):
(WebCore::Element::getBoundingClientRect):
* dom/Range.cpp:
(WebCore::adjustFloatQuadsForScrollAndAbsoluteZoomAndPageScale):
(WebCore::Range::getBorderAndTextQuads):
* rendering/RenderObject.h:
(WebCore::adjustFloatPointForPageScale):
(WebCore::adjustFloatQuadForPageScale):
(WebCore::adjustFloatRectForPageScale):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82778
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Sat, 2 Apr 2011 22:21:19 +0000 (22:21 +0000)]
Reverted r82775 due to changes in <details> test results, which are
likely progressions.
Source/WebCore:
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Removed a
LayoutTests:
* platform/mac/fast/table/colspanMinWidth-vertical-expected.checksum:
* platform/mac/fast/table/colspanMinWidth-vertical-expected.png:
* platform/mac/fast/table/colspanMinWidth-vertical-expected.txt:
* platform/mac/mathml/presentation/fractions-expected.checksum:
* platform/mac/mathml/presentation/fractions-expected.png:
* platform/mac/mathml/presentation/fractions-expected.txt:
* platform/mac/mathml/presentation/fractions-vertical-alignment-expected.checksum:
* platform/mac/mathml/presentation/fractions-vertical-alignment-expected.png:
* platform/mac/mathml/presentation/fractions-vertical-alignment-expected.txt:
* platform/mac/mathml/presentation/roots-expected.checksum:
* platform/mac/mathml/presentation/roots-expected.png:
* platform/mac/mathml/presentation/roots-expected.txt:
* platform/mac/mathml/presentation/row-alignment-expected.checksum:
* platform/mac/mathml/presentation/row-alignment-expected.png:
* platform/mac/mathml/presentation/row-alignment-expected.txt:
* platform/mac/mathml/presentation/subsup-expected.checksum:
* platform/mac/mathml/presentation/subsup-expected.png:
* platform/mac/mathml/presentation/subsup-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82777
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jeffm@apple.com [Sat, 2 Apr 2011 22:00:19 +0000 (22:00 +0000)]
2011-04-02 Jeff Miller <jeffm@apple.com>
Reviewed by Dan Bernstein.
WebKit2: Specify the certificate store in WKBundleSetClientCertificate()
https://bugs.webkit.org/show_bug.cgi?id=57707
Include the name of the system certificate store that the client certificate came from in WKBundleSetClientCertificate().
The PCCERT_CONTEXT for the client certificate we create from the message from the UI process doesn't contain enough information to actually use it in a request, we need to get the real certificate from the certificate store (which is typically the "MY" store).
* WebProcess/InjectedBundle/API/c/win/WKBundlePrivateWin.cpp:
(WKBundleSetClientCertificate): Add certificateSystemStoreName to parameters.
* WebProcess/InjectedBundle/API/c/win/WKBundlePrivateWin.h: Add certificateSystemStoreName to WKBundleSetClientCertificate() parameters.
* WebProcess/InjectedBundle/InjectedBundle.h: Add certificateSystemStoreName to setClientCertificate() parameters.
* WebProcess/InjectedBundle/win/InjectedBundleWin.cpp:
(WebKit::InjectedBundle::setClientCertificate): Read the real certificate from the certificate store.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82776
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Sat, 2 Apr 2011 21:37:11 +0000 (21:37 +0000)]
Remove an unnecessary extra computeLogicalWidth() from line layout
https://bugs.webkit.org/show_bug.cgi?id=57711
Reviewed by Dave Hyatt.
Source/WebCore:
Changes in behavior (MathML progression) covered by existing layout tests.
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Removed a
call to computeLogicalWidth(). Because of <http://webkit.org/b/57700>, this
actually prevents MathML rows from reverting to an incorrect width.
LayoutTests:
These updated expected results show progressions in MathML tests.
fast/table/colspanMinWidth-vertical results changed to show that text controls
still do not handle vertical writing modes correctly.
* platform/mac/fast/table/colspanMinWidth-vertical-expected.checksum:
* platform/mac/fast/table/colspanMinWidth-vertical-expected.png:
* platform/mac/fast/table/colspanMinWidth-vertical-expected.txt:
* platform/mac/mathml/presentation/fractions-expected.checksum:
* platform/mac/mathml/presentation/fractions-expected.png:
* platform/mac/mathml/presentation/fractions-expected.txt:
* platform/mac/mathml/presentation/fractions-vertical-alignment-expected.checksum:
* platform/mac/mathml/presentation/fractions-vertical-alignment-expected.png:
* platform/mac/mathml/presentation/fractions-vertical-alignment-expected.txt:
* platform/mac/mathml/presentation/roots-expected.checksum:
* platform/mac/mathml/presentation/roots-expected.png:
* platform/mac/mathml/presentation/roots-expected.txt:
* platform/mac/mathml/presentation/row-alignment-expected.checksum:
* platform/mac/mathml/presentation/row-alignment-expected.png:
* platform/mac/mathml/presentation/row-alignment-expected.txt:
* platform/mac/mathml/presentation/subsup-expected.checksum:
* platform/mac/mathml/presentation/subsup-expected.png:
* platform/mac/mathml/presentation/subsup-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82775
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 2 Apr 2011 20:56:11 +0000 (20:56 +0000)]
2011-04-02 Dominic Cooney <dominicc@google.com>
Reviewed by Martin Robinson.
Add layoutTestController.shadowRoot to GTK DumpRenderTree.
https://bugs.webkit.org/show_bug.cgi?id=57551
* platform/gtk/Skipped: unskip test that accesses shadowRoot
2011-04-02 Dominic Cooney <dominicc@google.com>
Reviewed by Martin Robinson.
Add layoutTestController.shadowRoot to GTK DumpRenderTree.
https://bugs.webkit.org/show_bug.cgi?id=57551
* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::shadowRoot):
* WebCoreSupport/DumpRenderTreeSupportGtk.h:
2011-04-02 Dominic Cooney <dominicc@google.com>
Reviewed by Martin Robinson.
Add layoutTestController.shadowRoot to GTK DumpRenderTree.
https://bugs.webkit.org/show_bug.cgi?id=57551
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::shadowRoot):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82774
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Sat, 2 Apr 2011 20:30:01 +0000 (20:30 +0000)]
2011-04-02 Sam Weinig <sam@webkit.org>
Reviewed by Dan Bernstein.
Implement WKBundleFrameHasHorizontalScrollbar/WKBundleFrameHasVerticalScrollbar
<rdar://problem/
9225772>
https://bugs.webkit.org/show_bug.cgi?id=57709
* WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
(WKBundleFrameHasHorizontalScrollbar):
(WKBundleFrameHasVerticalScrollbar):
* WebProcess/InjectedBundle/API/c/WKBundleFrame.h:
* WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::hasHorizontalScrollbar):
(WebKit::WebFrame::hasVerticalScrollbar):
* WebProcess/WebPage/WebFrame.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82773
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 2 Apr 2011 19:22:07 +0000 (19:22 +0000)]
2011-04-02 Ryuan Choi <ryuan.choi@samsung.com>
Reviewed by Martin Robinson.
[GTK] Fix leaked pointer in FontGtk.cpp
https://bugs.webkit.org/show_bug.cgi?id=57307
Fix a memory leak.
No new functionality, so no new tests.
* platform/graphics/gtk/FontGtk.cpp:
(WebCore::utf16ToUtf8): Rename utf16_to_utf8 and fix indentation.
(WebCore::convertUniCharToUTF8):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82772
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Sat, 2 Apr 2011 12:15:35 +0000 (12:15 +0000)]
2011-04-02 Patrick Gansterer <paroga@webkit.org>
Reviewed by Eric Seidel.
Remove AbstractStep._run_script and move script names to ports.py
https://bugs.webkit.org/show_bug.cgi?id=57704
Replace deprecated _run_script with _tool.executive.run_and_throw_if_fail.
* Scripts/webkitpy/common/config/ports.py:
* Scripts/webkitpy/tool/commands/download_unittest.py:
* Scripts/webkitpy/tool/commands/roll_unittest.py:
* Scripts/webkitpy/tool/commands/upload_unittest.py:
* Scripts/webkitpy/tool/steps/abstractstep.py:
* Scripts/webkitpy/tool/steps/checkstyle.py:
* Scripts/webkitpy/tool/steps/preparechangelog.py:
* Scripts/webkitpy/tool/steps/preparechangelogfordepsroll.py:
* Scripts/webkitpy/tool/steps/preparechangelogforrevert.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82771
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
paroga@webkit.org [Sat, 2 Apr 2011 11:18:57 +0000 (11:18 +0000)]
2011-04-02 Patrick Gansterer <paroga@webkit.org>
Reviewed by Eric Seidel.
Emulate shebang on Win32
https://bugs.webkit.org/show_bug.cgi?id=55927
Scripts on Windows work only if they are called with the explicit interpreter.
Read the first line of scripts to detect the correct executable.
* Scripts/webkitpy/common/config/ports.py:
* Scripts/webkitpy/common/system/executive.py: Added interpreter_for_script().
* Scripts/webkitpy/common/system/executive_unittest.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82770
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Sat, 2 Apr 2011 07:48:27 +0000 (07:48 +0000)]
2011-04-02 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: we should be able to have in and out arguments of a command with same name.
https://bugs.webkit.org/show_bug.cgi?id=57701
* inspector/CodeGeneratorInspector.pm:
* inspector/Inspector.json:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82769
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 2 Apr 2011 06:52:44 +0000 (06:52 +0000)]
2011-04-01 Anantanarayanan G Iyengar <ananta@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=57693
Skipped the windowless_plugin_paint_test.html layout test on Webkit Windows.
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82768
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Sat, 2 Apr 2011 06:02:09 +0000 (06:02 +0000)]
2011-04-01 Ilya Tikhonovsky <loislo@chromium.org>
Not reviewed trivial change.
Web Inspector: The page agent should be enabled even if JAVASCRIPT_DEBUGGER is off.
Followup change for r82281.
https://bugs.webkit.org/show_bug.cgi?id=57327
* inspector/InspectorPageAgent.cpp:
* inspector/InspectorPageAgent.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82767
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Sat, 2 Apr 2011 05:20:53 +0000 (05:20 +0000)]
2011-04-01 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
apos entities shouldn't show up in ChangeLogs when using webkit-patch
https://bugs.webkit.org/show_bug.cgi?id=57692
Previously, we were using BeautifulSoup to process XML from
bugs.webkit.org, but that's incorrect. We should be using
BeautifulStoneSoup to process the XML. We were getting the '
entity wrong because ' is an XML entity but not an HTML entity.
* Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
* Scripts/webkitpy/common/net/bugzilla/bugzilla_unittest.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82766
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Sat, 2 Apr 2011 03:44:20 +0000 (03:44 +0000)]
2011-04-01 Dimitri Glazkov <dglazkov@chromium.org>
Skip the test landed in r82758, since WebKitTestRunner doesn't implement
displayInvalidatedRegion.
* platform/mac-wk2/Skipped: Skipped the test.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82765
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
msaboff@apple.com [Sat, 2 Apr 2011 03:32:19 +0000 (03:32 +0000)]
2011-04-01 Michael Saboff <msaboff@apple.com>
Reviewed by Darin Adler.
Cached Resource Overhead Space Usage and Accounting Inaccurate
https://bugs.webkit.org/show_bug.cgi?id=57488
Fixed windows test failures.
Changed the fixed overhead value for ResourceResponse to 3800 bytes.
Modified ResourceResponse::platformLazyInit() to handle "base" level
attributes or all attributes. The base attributes, like URL, status
code, mime type and a few header fields (mostly cache related) are
suitable for most resources. This reduces the per resource memory
needs by over 1K bytes per resource thus saving memory in the cache.
Collectively, these two changes bring the overhead memory calculation
in line with reality.
No new tests added due to existing tests cover areas of change and
there is no functional change. The change is limited to reducing
memory usage along existing paths.
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::canUseCacheValidator):
* platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::adopt):
(WebCore::ResourceResponseBase::isHTTP):
(WebCore::ResourceResponseBase::url):
(WebCore::ResourceResponseBase::setURL):
(WebCore::ResourceResponseBase::mimeType):
(WebCore::ResourceResponseBase::setMimeType):
(WebCore::ResourceResponseBase::expectedContentLength):
(WebCore::ResourceResponseBase::setExpectedContentLength):
(WebCore::ResourceResponseBase::textEncodingName):
(WebCore::ResourceResponseBase::setTextEncodingName):
(WebCore::ResourceResponseBase::suggestedFilename):
(WebCore::ResourceResponseBase::setSuggestedFilename):
(WebCore::ResourceResponseBase::httpStatusCode):
(WebCore::ResourceResponseBase::setHTTPStatusCode):
(WebCore::ResourceResponseBase::httpStatusText):
(WebCore::ResourceResponseBase::setHTTPStatusText):
(WebCore::ResourceResponseBase::httpHeaderField):
(WebCore::ResourceResponseBase::setHTTPHeaderField):
(WebCore::ResourceResponseBase::httpHeaderFields):
(WebCore::ResourceResponseBase::parseCacheControlDirectives):
(WebCore::ResourceResponseBase::hasCacheValidatorFields):
(WebCore::ResourceResponseBase::date):
(WebCore::ResourceResponseBase::age):
(WebCore::ResourceResponseBase::expires):
(WebCore::ResourceResponseBase::lastModified):
(WebCore::ResourceResponseBase::isAttachment):
(WebCore::ResourceResponseBase::setLastModifiedDate):
(WebCore::ResourceResponseBase::lastModifiedDate):
(WebCore::ResourceResponseBase::wasCached):
(WebCore::ResourceResponseBase::connectionReused):
(WebCore::ResourceResponseBase::setConnectionReused):
(WebCore::ResourceResponseBase::connectionID):
(WebCore::ResourceResponseBase::setConnectionID):
(WebCore::ResourceResponseBase::resourceLoadTiming):
(WebCore::ResourceResponseBase::setResourceLoadTiming):
(WebCore::ResourceResponseBase::resourceLoadInfo):
(WebCore::ResourceResponseBase::setResourceLoadInfo):
(WebCore::ResourceResponseBase::lazyInit):
* platform/network/ResourceResponseBase.h:
(WebCore::ResourceResponseBase::platformLazyInit):
* platform/network/cf/ResourceResponse.h:
(WebCore::ResourceResponse::ResourceResponse):
(WebCore::ResourceResponse::memoryUsage):
* platform/network/cf/ResourceResponseCFNet.cpp:
(WebCore::ResourceResponse::platformLazyInit):
* platform/network/mac/ResourceResponseMac.mm:
(WebCore::ResourceResponse::platformLazyInit):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82764
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 2 Apr 2011 02:43:24 +0000 (02:43 +0000)]
2011-04-01 Jon Lee <jonlee@apple.com>
Reviewed by Darin Adler.
WebKit2: Type-to-select doesn't work in open <select> menu (53023)
https://bugs.webkit.org/show_bug.cgi?id=53023
<rdar://problem/
8907678>
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in: adding new setPopupMenuSelectedIndex message for windows platform
* UIProcess/win/WebPageProxyWin.cpp:
(WebKit::WebPageProxy::setPopupMenuSelectedIndex):
* UIProcess/win/WebPopupMenuProxyWin.h: moving setFocusedIndex() into public method
* WebProcess/WebCoreSupport/WebPopupMenu.cpp:
(WebKit::WebPopupMenu::updateFromElement): send message back to UIProcess to update the selected element
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82763
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Sat, 2 Apr 2011 02:43:07 +0000 (02:43 +0000)]
2011-04-01 Dirk Pranke <dpranke@chromium.org>
Unreviewed, expectations change.
Skipping fast/workers/dedicated-worker-lifecycle instead of
treating it as SLOW. It appears to be downright flaky.
https://bugs.webkit.org/show_bug.cgi?id=57678
* platform/mac/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82762
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Sat, 2 Apr 2011 02:42:31 +0000 (02:42 +0000)]
2011-04-01 Adam Barth <abarth@webkit.org>
This test fails by timing out.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82761
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Sat, 2 Apr 2011 02:23:17 +0000 (02:23 +0000)]
fix bug number
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82760
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Sat, 2 Apr 2011 02:18:28 +0000 (02:18 +0000)]
2011-04-01 Dirk Pranke <dpranke@chromium.org>
Unreviewed, expectations change.
Suppress some flaky bidi- and editing-related test failures on
SL Mac NRWT runs. See:
https://bugs.webkit.org/show_bug.cgi?id=57662
* platform/mac/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82759
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 2 Apr 2011 02:03:23 +0000 (02:03 +0000)]
2011-04-01 Anantanarayanan G Iyengar <ananta@chromium.org>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=45855
Windowless plugins added dynamically to the DOM should receive paint events.
This is done by ensuring that the plugin widget is marked for painting when
it is added. Added a layout test which verifies that a dynamically added plugin
receives a paint event. This test has to be skipped on chromium mac/linux and
on gtk and qt as it relies on support for the displayInvalidatedRegion function
in the LayoutTestController
* platform/chromium/test_expectations.txt:
* platform/gtk/Skipped:
* platform/qt/Skipped:
* plugins/windowless_plugin_paint_test-expected.txt: Added.
* plugins/windowless_plugin_paint_test.html: Added.
2011-04-01 Anantanarayanan G Iyengar <ananta@chromium.org>
Reviewed by Adam Barth.
https://bugs.webkit.org/show_bug.cgi?id=45855
Windowless plugins added dynamically to the DOM should receive paint events.
This is done by ensuring that the plugin widget is marked for painting when
it is added.
Test: plugins/windowless_plugin_paint_test.html
* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::setWidget):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82758
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 2 Apr 2011 01:45:45 +0000 (01:45 +0000)]
2011-04-01 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r82721.
http://trac.webkit.org/changeset/82721
https://bugs.webkit.org/show_bug.cgi?id=57687
This patch introduced assertion failures on the GTK+ bots.
(Requested by mrobinson on #webkit).
* platform/gtk/Skipped:
2011-04-01 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r82721.
http://trac.webkit.org/changeset/82721
https://bugs.webkit.org/show_bug.cgi?id=57687
This patch introduced assertion failures on the GTK+ bots.
(Requested by mrobinson on #webkit).
* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
* WebCoreSupport/DumpRenderTreeSupportGtk.h:
2011-04-01 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r82721.
http://trac.webkit.org/changeset/82721
https://bugs.webkit.org/show_bug.cgi?id=57687
This patch introduced assertion failures on the GTK+ bots.
(Requested by mrobinson on #webkit).
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::shadowRoot):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82757
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Sat, 2 Apr 2011 01:43:31 +0000 (01:43 +0000)]
Unreviewed buildfix.
[Qt][WK2] Build Webkit2 using "-2" option on Qt
https://bugs.webkit.org/show_bug.cgi?id=55074
* Scripts/build-webkit: Ensure that "-2" isn't passed to qmake.
(The isWK2() function removes it from @ARGV, but not from @options.)
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82756
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 2 Apr 2011 01:40:56 +0000 (01:40 +0000)]
2011-04-01 Keith Kyzivat <keith.kyzivat@nokia.com>
Reviewed by Csaba Osztrogonác.
[Qt] [WK2] MiniBrowser.qrc not found - regression from rev 82671
https://bugs.webkit.org/show_bug.cgi?id=57666
* MiniBrowser/qt/MiniBrowser.qrc: Renamed from Tools/MiniBrowser/MiniBrowser.qrc.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82755
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Sat, 2 Apr 2011 01:23:15 +0000 (01:23 +0000)]
2011-04-01 Adam Barth <abarth@webkit.org>
Attempt to fix the Chromium build using the great and powerful git.
This patch should be the remaining part of reverting Jeremy's ill-fated
refactoring.
* src/IDBDatabaseProxy.cpp:
(WebCore::IDBDatabaseProxy::create):
(WebCore::IDBDatabaseProxy::IDBDatabaseProxy):
(WebCore::IDBDatabaseProxy::~IDBDatabaseProxy):
(WebCore::IDBDatabaseProxy::name):
(WebCore::IDBDatabaseProxy::version):
(WebCore::IDBDatabaseProxy::objectStoreNames):
(WebCore::IDBDatabaseProxy::createObjectStore):
(WebCore::IDBDatabaseProxy::deleteObjectStore):
(WebCore::IDBDatabaseProxy::setVersion):
(WebCore::IDBDatabaseProxy::transaction):
(WebCore::IDBDatabaseProxy::close):
(WebCore::IDBDatabaseProxy::open):
* src/IDBDatabaseProxy.h:
* src/IDBObjectStoreProxy.cpp:
(WebCore::IDBObjectStoreProxy::create):
(WebCore::IDBObjectStoreProxy::IDBObjectStoreProxy):
(WebCore::IDBObjectStoreProxy::~IDBObjectStoreProxy):
(WebCore::IDBObjectStoreProxy::name):
(WebCore::IDBObjectStoreProxy::keyPath):
(WebCore::IDBObjectStoreProxy::indexNames):
(WebCore::IDBObjectStoreProxy::get):
(WebCore::IDBObjectStoreProxy::put):
(WebCore::IDBObjectStoreProxy::deleteFunction):
(WebCore::IDBObjectStoreProxy::clear):
(WebCore::IDBObjectStoreProxy::createIndex):
(WebCore::IDBObjectStoreProxy::index):
(WebCore::IDBObjectStoreProxy::deleteIndex):
(WebCore::IDBObjectStoreProxy::openCursor):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82754
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Sat, 2 Apr 2011 00:55:22 +0000 (00:55 +0000)]
2011-04-01 Dirk Pranke <dpranke@chromium.org>
Reviewed by Adam Barth.
new-run-webkit-tests: fix feature detection, skipped platform lists on mac
We apparently never implemented the code to skip tests based on
what was compiled into DRT. Also, change the logic used to skip
platform directories to match what old-run-webkit-tests does:
skip every test not in a directory in the baseline search path.
https://bugs.webkit.org/show_bug.cgi?id=57662
* Scripts/webkitpy/layout_tests/port/mac.py:
* Scripts/webkitpy/layout_tests/port/mac_unittest.py:
* Scripts/webkitpy/layout_tests/port/webkit.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82753
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Sat, 2 Apr 2011 00:40:02 +0000 (00:40 +0000)]
<webkit.org/b/56730> new-run-webkit-tests fails on Lion seed
Reviewed by Jon Honeycutt.
Teach new-run-webkit-tests about the concept of an unreleased version of Mac OS X.
* Scripts/webkitpy/layout_tests/port/chromium_mac.py:
* Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
* Scripts/webkitpy/layout_tests/port/mac.py:
* Scripts/webkitpy/layout_tests/port/mac_unittest.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82752
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Sat, 2 Apr 2011 00:36:18 +0000 (00:36 +0000)]
2011-04-01 Mike Reed <reed@google.com>
Reviewed by James Robinson.
always use native font rendering on skia_gpu
fixes a crash when SKIA_GPU is enabled, as we can't call getTopPlatformDevice()
https://bugs.webkit.org/show_bug.cgi?id=57663
No new tests. existing rendering tests will exercise this
* platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::isNativeFontRenderingAllowed):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82751
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Sat, 2 Apr 2011 00:35:59 +0000 (00:35 +0000)]
2011-04-01 Adam Barth <abarth@webkit.org>
Move these files back to their old locations. I'm not sure why the
rollout didn't move them properly.
* src/IDBDatabaseBackendProxy.cpp: Removed.
* src/IDBDatabaseBackendProxy.h: Removed.
* src/IDBDatabaseProxy.cpp: Copied from Source/WebKit/chromium/src/IDBDatabaseBackendProxy.cpp.
* src/IDBDatabaseProxy.h: Copied from Source/WebKit/chromium/src/IDBDatabaseBackendProxy.h.
* src/IDBObjectStoreBackendProxy.cpp: Removed.
* src/IDBObjectStoreProxy.cpp: Copied from Source/WebKit/chromium/src/IDBObjectStoreBackendProxy.cpp.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82750
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Sat, 2 Apr 2011 00:27:29 +0000 (00:27 +0000)]
Reviewed by Darin Adler.
REGRESSION: Assertion failure when executing a complex custom key binding
https://bugs.webkit.org/show_bug.cgi?id=57681
Also completes the fix for
<rdar://problem/
9063782> WebKit2: Text fields in Safari don't honor custom key bindings
* UIProcess/API/mac/WKView.mm: (-[WKView hasMarkedText]): There is no need to execute saved
commands when they can't possibly change the result.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@82749
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
git://git.webkit.org / WebKit-https.git / log