andersca [Fri, 10 Feb 2006 10:14:25 +0000 (10:14 +0000)]
2006-02-10 Joost de Valk <jdevalk@opendarwin.org>
Reviewed and landed by Anders.
http://bugzilla.opendarwin.org/show_bug.cgi?id=7164
Code cleanup
Changed <div id="banner" to <h1 id="banner"
global cleanup of CSS and code
* building/build.html:
* building/checkout.html:
* coding/coding-style.html:
* coding/contributing.html:
* contact.html:
* index.html:
* projects/accessibility/index.html:
* projects/cleanup/index.html:
* projects/compat/index.html:
* projects/css/index.html:
* projects/documentation/index.html:
* projects/dom/index.html:
* projects/editing/index.html:
* projects/forms/index.html:
* projects/html/index.html:
* projects/index.html:
* projects/javascript/index.html:
* projects/layout/index.html:
* projects/mathml/index.html:
* projects/performance/index.html:
* projects/plugins/index.html:
* projects/portability/index.html:
* projects/printing/index.html:
* projects/svg/index.html:
* projects/webkit/index.html:
* projects/xml/index.html:
* projects/xslt/index.html:
* quality/bugpriorities.html:
* quality/bugwriting.html:
* quality/lifecycle.html:
* quality/reduction.html:
* quality/reporting.html:
* quality/testing.html:
* quality/testwriting.html:
* webkitdev.css:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12733
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Fri, 10 Feb 2006 09:49:02 +0000 (09:49 +0000)]
Improve the double buffering of the image viewer test app on win32 to do a source composit op and not a source-over op.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12732
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Fri, 10 Feb 2006 09:47:56 +0000 (09:47 +0000)]
Merge cairo fixes from Mozilla and one additional fix after discussion with vlad. Code is now smarter about knowing when to blt vs. alpha blend.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12731
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Fri, 10 Feb 2006 09:03:44 +0000 (09:03 +0000)]
No review needed, just a build fix. This time for sure.
* kjs/JSType.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12730
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Fri, 10 Feb 2006 08:42:21 +0000 (08:42 +0000)]
JavaScriptCore:
Reviewed by eric.
- Fixed build. As it goes without saying, I will not mention that I
blame Kevin.
* JavaScriptCore.xcodeproj/project.pbxproj:
* kjs/JSImmediate.cpp:
(KJS::JSImmediate::toObject):
JavaScriptGlue:
Reviewed by eric.
- Fixed build.
* UserObjectImp.cpp:
(UserObjectImp::toPrimitive):
* UserObjectImp.h:
WebCore:
Reviewed by eric.
- Fixed build.
* bridge/mac/WebCoreFrameBridge.mm:
* khtml/ecma/kjs_binding.h:
(KJS::DOMFunction::toPrimitive):
* khtml/ecma/kjs_dom.cpp:
(KJS::DOMNode::toPrimitive):
(KJS::DOMNodeList::toPrimitive):
* khtml/ecma/kjs_dom.h:
* khtml/ecma/kjs_window.cpp:
(KJS::Location::toPrimitive):
(KJS::Selection::toPrimitive):
* khtml/ecma/kjs_window.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12729
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Fri, 10 Feb 2006 06:42:01 +0000 (06:42 +0000)]
Reviewed by mjs.
- Fixed <rdar://problem/
4343730> Should switch ConstantValues (null,
undefined, true, false) from JS objects to immediate values similar to
SimpleNumber
2.0% performance gain on my new super-accurate version of JS iBench.
(I promise to land a version of it soon.)
The gist of the change:
(1) The SimpleNumber class (simple_number.h) is now the JSImmediate
class (JSImmediate.h/.cpp), and it handles not only numbers but also
null, undefined, true, and false.
(2) JSImmediate provides convenience methods for the bit masking
necessary to encode and decode immediate values.
(3) ConstantValues, BooleanImp, NullImp, and UndefinedImp are gone.
(4) JSCell no longer implements functions like getBoolean, because
only a JSImmediate can be a boolean.
(5) JSImmediate no longer uses ALWAYS_INLINE because there's no need,
and ALWAYS_INLINE is a non-portable option of last resort.
(6) Type is now JSType, and it resides in its own file, JSType.h.
Since I was there, I did some header include sorting as part of this
change.
The rest pretty much explains itself.
* JavaScriptCore.xcodeproj/project.pbxproj: Removed simple_number.h,
added JSImmediate.h/.cpp.
* bindings/c/c_instance.cpp:
(KJS::Bindings::CInstance::defaultValue):
* bindings/c/c_instance.h:
* bindings/c/c_utility.cpp:
(KJS::Bindings::convertValueToNPVariant):
* bindings/jni/jni_instance.cpp:
(JavaInstance::defaultValue):
* bindings/jni/jni_instance.h:
* bindings/jni/jni_jsobject.cpp:
(JavaJSObject::convertValueToJObject):
* bindings/objc/WebScriptObject.mm:
(+[WebScriptObject _convertValueToObjcValue:originExecutionContext:executionContext:]):
Standardized calls to use getXXX instead of hand-rolling JSValue
functionality.
* bindings/objc/objc_instance.h:
* bindings/objc/objc_instance.mm:
(ObjcInstance::getValueOfUndefinedField):
(ObjcInstance::defaultValue):
* bindings/objc/objc_runtime.h:
* bindings/objc/objc_runtime.mm:
(ObjcFallbackObjectImp::type):
(ObjcFallbackObjectImp::defaultValue):
* bindings/runtime.h:
(KJS::Bindings::Instance::getValueOfUndefinedField):
* bindings/runtime_object.cpp:
(RuntimeObjectImp::defaultValue):
* bindings/runtime_object.h:
* kjs/JSImmediate.h: Added.
(KJS::JSImmediate::isImmediate):
(KJS::JSImmediate::isNumber):
(KJS::JSImmediate::isBoolean):
(KJS::JSImmediate::isUndefinedOrNull):
(KJS::JSImmediate::fromDouble):
(KJS::JSImmediate::toDouble):
(KJS::JSImmediate::toBoolean):
(KJS::JSImmediate::trueImmediate):
(KJS::JSImmediate::falseImmediate):
(KJS::JSImmediate::NaNImmediate):
(KJS::JSImmediate::undefinedImmediate):
(KJS::JSImmediate::nullImmediate):
(KJS::JSImmediate::tag):
(KJS::JSImmediate::unTag):
(KJS::JSImmediate::getTag):
(KJS::JSImmediate::):
(KJS::JSImmediate::isIEEE):
(KJS::JSImmediate::is32bit):
(KJS::JSImmediate::is64bit):
(KJS::JSImmediate::NanAsBits):
(KJS::JSImmediate::zeroAsBits):
(KJS::JSImmediate::oneAsBits):
* kjs/JSLock.cpp:
(KJS::JSLock::lock): Removed hack-o-rama to initialize ConstantValues.
* kjs/JSType.h: Added.
* kjs/collector.cpp:
(KJS::Collector::protect):
(KJS::Collector::unprotect):
(KJS::Collector::collect):
* kjs/internal.cpp:
(KJS::StringImp::toPrimitive):
(KJS::NumberImp::toPrimitive):
(KJS::NumberImp::toBoolean):
(KJS::GetterSetterImp::toPrimitive):
* kjs/internal.h:
(KJS::StringImp::type):
(KJS::NumberImp::type):
* kjs/object.cpp:
(KJS::JSObject::type):
(KJS::tryGetAndCallProperty): Replaced "Are you one of the six things
I'm looking for?" test with "Are you not the one thing I'm not looking
for" test.
(KJS::JSObject::defaultValue):
(KJS::JSObject::toPrimitive):
* kjs/object.h:
(KJS::GetterSetterImp::type):
(KJS::JSValue::isObject):
* kjs/operations.cpp:
(KJS::equal):
(KJS::strictEqual):
(KJS::add):
* kjs/reference.cpp:
(KJS::Reference::deleteValue):
* kjs/simple_number.h: Removed.
* kjs/string_object.cpp:
(StringInstance::getOwnPropertySlot): fixed indentation
* kjs/value.cpp:
(KJS::JSValue::toObject):
(KJS::jsNumberCell): New function to quarantine a PIC branch -- allows
us to inline jsNumber without adding PIC branches to callers.
* kjs/value.h:
(KJS::jsUndefined):
(KJS::jsNull):
(KJS::jsNaN):
(KJS::jsBoolean):
(KJS::jsNumber):
(KJS::JSValue::downcast):
(KJS::JSValue::isUndefinedOrNull):
(KJS::JSValue::isBoolean):
(KJS::JSValue::isNumber):
(KJS::JSValue::isString):
(KJS::JSValue::isObject):
(KJS::JSValue::getBoolean):
(KJS::JSValue::getNumber):
(KJS::JSValue::getString):
(KJS::JSValue::getObject):
(KJS::JSValue::getUInt32):
(KJS::JSValue::mark): Replaced !JSImmediate::is() test with assertion,
resulting in a slight performance gain. Callers should always check
!marked() before calling mark(), so it's impossible to call mark on
a JSImmediate.
(KJS::JSValue::marked):
(KJS::JSValue::type):
(KJS::JSValue::toPrimitive):
(KJS::JSValue::toBoolean):
(KJS::JSValue::toNumber):
(KJS::JSValue::toString):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12728
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tomernic [Fri, 10 Feb 2006 01:30:02 +0000 (01:30 +0000)]
Reviewed by Tim Hatcher.
<rdar://problem/
4153419> CrashTracer: 576 crashes in Safari at com.apple.WebKit: NPN_DestroyStream + 56
I never could reproduce this crasher, which seems to be caused by the Speed Download plugin. However,
I did find a way to make the affected code more bulletproof for those who are experiencing the crash.
* Plugins/WebBaseNetscapePluginStream.h:
Keep a WebBaseNetscapePluginView instead of the WebNetscapePluginPackage, since the plugin view could
potentially be deallocated before the stream finishes loading.
* Plugins/WebBaseNetscapePluginStream.m:
(-[WebBaseNetscapePluginStream _pluginCancelledConnectionError]):
Use pluginView instead of plugin.
(-[WebBaseNetscapePluginStream dealloc]):
Assert that the plugin instance has been nulled out, since that's now part of the stream's teardown
phase.
Release pluginView instead of plugin.
(-[WebBaseNetscapePluginStream setPluginPointer:]):
Retain the plugin view instead of the plugin package, since the plugin view could be deallocated while
the stream is running.
This method now accepts a NULL argument so that we can easily clear out the pluginView backpointer
(and other ivars derived from it).
(-[WebBaseNetscapePluginStream startStreamResponseURL:expectedContentLength:lastModifiedDate:MIMEType:]):
Use pluginView instead of plugin.
(-[WebBaseNetscapePluginStream _destroyStream]):
ditto
(-[WebBaseNetscapePluginStream finishedLoadingWithData:]):
ditto
(-[WebBaseNetscapePluginStream cancelLoadAndDestroyStreamWithError]):
Set the plugin instance to NULL, so that the pluginView backpointer is released. This method is called
for every plugin view's stream when the plugin view is stopped/destroyed.
(-[WebBaseNetscapePluginStream _deliverData]):
Use pluginView instead of plugin.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12727
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Fri, 10 Feb 2006 01:20:59 +0000 (01:20 +0000)]
Reviewed by Hyatt.
- <rdar://problem/
4430614> RenderThemeMac crashes under GC
* rendering/render_theme_mac.mm:
(WebCore::RenderThemeMac::RenderThemeMac): Initialize all the pointers.
(WebCore::RenderThemeMac::setCheckboxCellState): Use KWQRetainNSRelease so
we can retain a pointer to an ObjC object in a C++ class.
(WebCore::RenderThemeMac::setRadioCellState): Ditto.
(WebCore::RenderThemeMac::setButtonCellState): Ditto.
(WebCore::RenderThemeMac::setTextFieldCellState): Ditto.
* kwq/KWQResourceLoader.h: Remove unneeded forward declaration.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12726
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Fri, 10 Feb 2006 00:09:17 +0000 (00:09 +0000)]
Reviewed by Eric and Geoff.
- changed basic DOM mutation calls to assert that "this"
is not floating, then added more uses of RefPtr to prevent the
assertion from firing (at least during my testing and layout tests)
- removed use of PassRefPtr as the type of a local variable; after talking
with Maciej and Eric, this type of use is now "deprecated"
* bindings/js/JSDOMCore.cpp: Touched this file to get things to build.
* bindings/objc/DOM.mm:
(-[DOMRange extractContents]):
(-[DOMRange cloneContents]):
(-[DOMRange cloneRange]):
* khtml/ecma/kjs_range.cpp:
(KJS::DOMRange::getValueProperty):
(KJS::DOMRangeProtoFunc::callAsFunction):
* khtml/editing/Selection.cpp:
(WebCore::Selection::toRange):
* bridge/mac/WebCoreFrameBridge.mm:
(-[WebCoreFrameBridge documentFragmentWithMarkupString:baseURLString:]):
* dom/ContainerNodeImpl.cpp:
(WebCore::ContainerNodeImpl::insertBefore):
(WebCore::ContainerNodeImpl::replaceChild):
(WebCore::ContainerNodeImpl::removeChild):
(WebCore::ContainerNodeImpl::appendChild):
* dom/DocPtr.h: Removed uses of NULL and unused deprecated functions.
* dom/dom2_rangeimpl.h:
* dom/dom2_rangeimpl.cpp:
(WebCore::RangeImpl::RangeImpl):
(WebCore::RangeImpl::startContainer):
(WebCore::RangeImpl::endContainer):
(WebCore::RangeImpl::commonAncestorContainer):
(WebCore::RangeImpl::setStart):
(WebCore::RangeImpl::setEnd):
(WebCore::RangeImpl::collapse):
(WebCore::RangeImpl::compareBoundaryPoints):
(WebCore::RangeImpl::boundaryPointsValid):
(WebCore::RangeImpl::processContents):
(WebCore::RangeImpl::extractContents):
(WebCore::RangeImpl::cloneContents):
(WebCore::RangeImpl::insertNode):
(WebCore::RangeImpl::createContextualFragment):
(WebCore::RangeImpl::detach):
(WebCore::RangeImpl::cloneRange):
(WebCore::RangeImpl::selectNodeContents):
(WebCore::RangeImpl::surroundContents):
(WebCore::RangeImpl::containedByReadOnly):
(WebCore::RangeImpl::startPosition):
(WebCore::RangeImpl::endPosition):
(WebCore::RangeImpl::startNode):
(WebCore::RangeImpl::editingStartPosition):
(WebCore::rangeOfContents):
* dom/dom_elementimpl.h:
* dom/dom_elementimpl.cpp:
(WebCore::AttrImpl::AttrImpl):
(WebCore::AttrImpl::~AttrImpl):
(WebCore::AttrImpl::setValue):
(WebCore::AttrImpl::childTypeAllowed):
(WebCore::AttrImpl::childrenChanged):
(WebCore::ElementImpl::removeAttributeNode):
(WebCore::NamedAttrMapImpl::clearAttributes):
(WebCore::CSSMappedAttributeDeclarationImpl::~CSSMappedAttributeDeclarationImpl):
(WebCore::MappedAttributeImpl::clone):
* dom/DocumentFragmentImpl.cpp:
(DOM::DocumentFragmentImpl::cloneNode):
* dom/dom_xmlimpl.cpp:
(WebCore::EntityReferenceImpl::cloneNode):
(WebCore::ProcessingInstructionImpl::ProcessingInstructionImpl):
(WebCore::ProcessingInstructionImpl::checkStyleSheet):
(WebCore::ProcessingInstructionImpl::setStyleSheet):
* dom/dom_position.cpp:
* khtml/editing/break_blockquote_command.cpp:
(WebCore::BreakBlockquoteCommand::doApply):
* khtml/editing/composite_edit_command.cpp:
(WebCore::CompositeEditCommand::appendBlockPlaceholder):
(WebCore::CompositeEditCommand::insertBlockPlaceholder):
(WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary):
(WebCore::createBlockPlaceholderElement):
* khtml/editing/delete_selection_command.cpp:
(WebCore::DeleteSelectionCommand::insertPlaceholderForAncestorBlockContent):
(WebCore::DeleteSelectionCommand::moveNodesAfterNode):
* khtml/editing/html_interchange.cpp:
* khtml/editing/htmlediting.cpp:
(WebCore::rebalanceWhitespaceInTextNode):
(WebCore::nonBreakingSpaceString):
(WebCore::createDefaultParagraphElement):
(WebCore::createBreakElement):
(WebCore::createTabSpanElement):
* khtml/editing/insert_line_break_command.cpp:
(khtml::InsertLineBreakCommand::doApply):
* khtml/editing/insert_paragraph_separator_command.cpp:
(WebCore::InsertParagraphSeparatorCommand::doApply):
* khtml/editing/insert_paragraph_separator_command.h:
* khtml/editing/insert_text_command.cpp:
(khtml::InsertTextCommand::insertTab):
* khtml/editing/markup.cpp:
(khtml::createFragmentFromMarkup):
(khtml::createParagraphContentsFromString):
(khtml::createFragmentFromText):
(khtml::createFragmentFromNodeList):
* khtml/editing/rebalance_whitespace_command.cpp:
* khtml/editing/replace_selection_command.cpp:
(WebCore::ReplacementFragment::ReplacementFragment):
(WebCore::ReplacementFragment::insertFragmentForTestRendering):
(WebCore::ReplaceSelectionCommand::doApply):
* khtml/editing/visible_text.cpp:
(khtml::CharacterIterator::range):
(khtml::findPlainText):
* khtml/html/HTMLElementImpl.cpp:
(WebCore::HTMLElementImpl::cloneNode):
* khtml/html/htmlparser.cpp:
(HTMLParser::handleResidualStyleCloseTagAcrossBlocks):
* ksvg2/svg/SVGTransformableImpl.cpp:
(SVGTransformableImpl::parseTransformAttribute):
* ksvg2/svg/SVGUseElementImpl.cpp:
(SVGUseElementImpl::closeRenderer):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12725
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Thu, 9 Feb 2006 21:33:19 +0000 (21:33 +0000)]
Adding eol-style.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12724
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Thu, 9 Feb 2006 21:31:48 +0000 (21:31 +0000)]
Rolling over the ChangeLog.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12723
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Thu, 9 Feb 2006 19:22:16 +0000 (19:22 +0000)]
Fixes by Mark Rowe and Joost de Valk. Reviewed by Darin. Landed by ap.
- fixes from http://bugzilla.opendarwin.org/show_bug.cgi?id=4871
"Reporting Bugs" Page Should Prompt User To Test In Newest Version of WebKit
* quality/reporting.html:
* webkitdev.css: Added margin-bottom for li.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12722
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tomernic [Thu, 9 Feb 2006 19:21:47 +0000 (19:21 +0000)]
Reviewed by Darin Adler.
<rdar://problem/
4198378> Crash on a CFRelease when visiting http://www.akella.com/
* Plugins/WebBaseNetscapePluginView.m:
(-[WebBaseNetscapePluginView requestWithURLCString:]):
The true source of this crash is that the URL string is sometimes not NULL-terminated, which is the
Real Player plugin's fault. That has been filed as
4439591.
However, we can be more bulletproof here by switching the URL string encoding from Windows Latin 1
to ISO Latin 1, so that any NULL-terminated string can be represented. (As Darin and I found out
last night, Windows Latin 1 has "holes" in certain character ranges and thus cannot encode arbitrary
C strings).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12721
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Thu, 9 Feb 2006 10:16:55 +0000 (10:16 +0000)]
Reviewed and landed by Maciej.
Factor out common parts of Linear/Radial GradientQuartz
up into KRenderingPaintServerGradientQuartz.
Cleanup only, no layout tests needed or affected.
* kcanvas/device/KRenderingPaintServer.h:
* kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
(KRenderingPaintServerGradientQuartz::updateQuartzGradientCache):
(KRenderingPaintServerGradientQuartz::draw):
(KRenderingPaintServerGradientQuartz::setup):
(KRenderingPaintServerGradientQuartz::renderPath):
(KRenderingPaintServerGradientQuartz::teardown):
* kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
(KRenderingPaintServerLinearGradientQuartz::draw):
(KRenderingPaintServerLinearGradientQuartz::setup):
(KRenderingPaintServerLinearGradientQuartz::teardown):
(KRenderingPaintServerLinearGradientQuartz::renderPath):
(KRenderingPaintServerRadialGradientQuartz::draw):
(KRenderingPaintServerRadialGradientQuartz::setup):
(KRenderingPaintServerRadialGradientQuartz::teardown):
(KRenderingPaintServerRadialGradientQuartz::renderPath):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12720
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Thu, 9 Feb 2006 09:54:25 +0000 (09:54 +0000)]
Reviewed by Hyatt.
- various Frame cleanup:
Make Frame-related classes Noncopyable.
Remove nearly all of Frame's friends.
Remove some unused stuff.
Remove unneeded class forward declarations from Frame.h
* page/Frame.cpp:
* page/Frame.h:
* page/FrameTreeNode.h:
(WebCore::FrameTreeNode::FrameTreeNode):
(WebCore::FrameTreeNode::name):
(WebCore::FrameTreeNode::parent):
(WebCore::FrameTreeNode::setParent):
(WebCore::FrameTreeNode::nextSibling):
(WebCore::FrameTreeNode::previousSibling):
(WebCore::FrameTreeNode::firstChild):
(WebCore::FrameTreeNode::lastChild):
(WebCore::FrameTreeNode::childCount):
* page/FrameView.cpp:
(WebCore::FrameView::viewportMouseMoveEvent):
* page/Page.h:
(WebCore::Page::mainFrame):
* page/Plugin.h:
(WebCore::Plugin::Plugin):
(WebCore::Plugin::view):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12719
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Thu, 9 Feb 2006 09:36:08 +0000 (09:36 +0000)]
Rubber stamped by Anders.
- Moved all the default delegate classes to their own directory.
* DefaultDelegates: Added.
* DefaultDelegates/WebDefaultContextMenuDelegate.h: Added.
* DefaultDelegates/WebDefaultContextMenuDelegate.m: Added.
* DefaultDelegates/WebDefaultEditingDelegate.h: Added.
* DefaultDelegates/WebDefaultEditingDelegate.m: Added.
* DefaultDelegates/WebDefaultFrameLoadDelegate.h: Added.
* DefaultDelegates/WebDefaultFrameLoadDelegate.m: Added.
* DefaultDelegates/WebDefaultPolicyDelegate.h: Added.
* DefaultDelegates/WebDefaultPolicyDelegate.m: Added.
* DefaultDelegates/WebDefaultResourceLoadDelegate.h: Added.
* DefaultDelegates/WebDefaultResourceLoadDelegate.m: Added.
* DefaultDelegates/WebDefaultScriptDebugDelegate.h: Added.
* DefaultDelegates/WebDefaultScriptDebugDelegate.m: Added.
* DefaultDelegates/WebDefaultUIDelegate.h: Added.
* DefaultDelegates/WebDefaultUIDelegate.m: Added.
* WebKit.xcodeproj/project.pbxproj:
* WebView/WebDefaultContextMenuDelegate.h: Removed.
* WebView/WebDefaultContextMenuDelegate.m: Removed.
* WebView/WebDefaultEditingDelegate.h: Removed.
* WebView/WebDefaultEditingDelegate.m: Removed.
* WebView/WebDefaultFrameLoadDelegate.h: Removed.
* WebView/WebDefaultFrameLoadDelegate.m: Removed.
* WebView/WebDefaultPolicyDelegate.h: Removed.
* WebView/WebDefaultPolicyDelegate.m: Removed.
* WebView/WebDefaultResourceLoadDelegate.h: Removed.
* WebView/WebDefaultResourceLoadDelegate.m: Removed.
* WebView/WebDefaultScriptDebugDelegate.h: Removed.
* WebView/WebDefaultScriptDebugDelegate.m: Removed.
* WebView/WebDefaultUIDelegate.h: Removed.
* WebView/WebDefaultUIDelegate.m: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12718
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Thu, 9 Feb 2006 09:09:12 +0000 (09:09 +0000)]
Minor image cleanup to the decoders. Doesn't affect Mac.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12717
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Thu, 9 Feb 2006 08:46:51 +0000 (08:46 +0000)]
Update Win32 project to account for the khtml/xml to dom move.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12716
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Thu, 9 Feb 2006 08:26:28 +0000 (08:26 +0000)]
Rubber-stamped by Hyatt.
- moved khtml/xml to dom
* dom: moved from khtml/xml
* WebCore.xcodeproj/project.pbxproj: Updated for new file locations.
* WebCore+SVG/KDOMHeaders.h: Updated for new header locations.
* dom/dom2_rangeimpl.cpp: ditto
* dom/dom2_traversalimpl.cpp: ditto
* dom/dom_textimpl.cpp: ditto
* dom/dom_xmlimpl.cpp: ditto
* khtml/dom/dom2_events.cpp: ditto
* khtml/ecma/kjs_binding.cpp: ditto
* khtml/ecma/kjs_dom.cpp: ditto
* khtml/ecma/kjs_events.cpp: ditto
* khtml/ecma/kjs_html.cpp: ditto
* khtml/ecma/kjs_range.cpp: ditto
* khtml/ecma/kjs_views.cpp: ditto
* khtml/editing/Selection.cpp: ditto
* khtml/editing/SelectionController.cpp: ditto
* khtml/editing/delete_from_text_node_command.cpp: ditto
* khtml/editing/edit_command.cpp: ditto
* khtml/editing/insert_into_text_node_command.cpp: ditto
* khtml/editing/insert_line_break_command.cpp: ditto
* khtml/editing/insert_paragraph_separator_command.cpp: ditto
* khtml/editing/insert_text_command.cpp: ditto
* khtml/editing/join_text_nodes_command.cpp: ditto
* khtml/editing/markup.cpp: ditto
* khtml/editing/merge_identical_elements_command.cpp: ditto
* khtml/editing/rebalance_whitespace_command.cpp: ditto
* khtml/editing/remove_node_attribute_command.cpp: ditto
* khtml/editing/set_node_attribute_command.cpp: ditto
* khtml/editing/split_element_command.cpp: ditto
* khtml/editing/split_text_node_command.cpp: ditto
* khtml/editing/split_text_node_containing_element.cpp: ditto
* khtml/editing/visible_position.cpp: ditto
* khtml/editing/visible_position.h: ditto
* khtml/editing/visible_text.cpp: ditto
* khtml/editing/visible_text.h: ditto
* khtml/editing/visible_units.cpp: ditto
* khtml/editing/wrap_contents_in_dummy_span_command.cpp: ditto
* khtml/html/HTMLElementImpl.h: ditto
* khtml/html/html_documentimpl.cpp: ditto
* khtml/html/html_headimpl.cpp: ditto
* khtml/xbl/xbl_binding_manager.cpp: ditto
* khtml/xbl/xbl_tokenizer.cpp: ditto
* khtml/xbl/xbl_tokenizer.h: ditto
* ksvg2/svg/SVGAElementImpl.cpp: ditto
* rendering/InlineTextBox.cpp: ditto
* rendering/RenderContainer.cpp: ditto
* rendering/RenderText.h: ditto
* rendering/RenderTextField.cpp: ditto
* rendering/render_frames.cpp: ditto
* rendering/render_layer.cpp: ditto
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12715
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Thu, 9 Feb 2006 08:03:37 +0000 (08:03 +0000)]
2006-02-09 Eric Seidel <eseidel@apple.com>
Rubber-stamped by mjs.
Renamed split-class to split-file-by-class.
* Scripts/build-webkit: Updated copyright.
* Scripts/split-class: Removed.
* Scripts/split-file-by-class: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12714
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Thu, 9 Feb 2006 07:59:41 +0000 (07:59 +0000)]
2006-02-08 Eric Seidel <eseidel@apple.com>
Rubber-stamped by mjs.
Adding new script for splitting multi-class files.
Also adding supporting perl module with space removing heuristics.
* Scripts/SpacingHeuristics.pm: Added.
* Scripts/build-drawtest: updated copyright header
* Scripts/split-class: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12713
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Thu, 9 Feb 2006 07:50:14 +0000 (07:50 +0000)]
Test: fast/block/positioning/window-height-change.html
Reviewed by Hyatt.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5813
positioned blocks don't update when resizing the window vertically
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlock): Always relayout positioned children of
the root, since their positions may depend on the viewport's height which
may have changed.
* rendering/render_flexbox.cpp:
(khtml::RenderFlexibleBox::layoutBlock): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12712
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Thu, 9 Feb 2006 07:08:22 +0000 (07:08 +0000)]
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12711
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Thu, 9 Feb 2006 07:06:44 +0000 (07:06 +0000)]
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12710
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Thu, 9 Feb 2006 07:05:46 +0000 (07:05 +0000)]
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12709
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Thu, 9 Feb 2006 07:04:50 +0000 (07:04 +0000)]
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12708
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Thu, 9 Feb 2006 07:02:03 +0000 (07:02 +0000)]
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12707
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Thu, 9 Feb 2006 07:01:36 +0000 (07:01 +0000)]
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12706
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Thu, 9 Feb 2006 07:00:32 +0000 (07:00 +0000)]
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12705
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Thu, 9 Feb 2006 06:56:29 +0000 (06:56 +0000)]
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12704
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Thu, 9 Feb 2006 06:56:14 +0000 (06:56 +0000)]
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12703
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Thu, 9 Feb 2006 06:55:49 +0000 (06:55 +0000)]
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12702
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Thu, 9 Feb 2006 06:54:17 +0000 (06:54 +0000)]
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12701
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Thu, 9 Feb 2006 06:53:57 +0000 (06:53 +0000)]
Add missing file from earlier added svg test.
* svg/custom/resources/link-target.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12700
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Thu, 9 Feb 2006 06:45:41 +0000 (06:45 +0000)]
Add reviewer to an old check-in (remove forbidden OOPS).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12699
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Thu, 9 Feb 2006 06:43:36 +0000 (06:43 +0000)]
OK, OOPS-prevention is working now.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12698
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Thu, 9 Feb 2006 06:39:10 +0000 (06:39 +0000)]
Add libjpeg to the Win32 project.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12697
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Thu, 9 Feb 2006 06:38:53 +0000 (06:38 +0000)]
Reviewed by thatcher
Changes to test fix for:
<http://bugzilla.opendarwin.org/show_bug.cgi?id=3982>
webViewDidBeginEditing, webViewDidEndEditing notification methods not called on delegate
* DumpRenderTree/DumpRenderTree.m:
(-[WaitUntilDoneDelegate webView:didCommitLoadForFrame:]):
(+[LayoutTestController isSelectorExcludedFromWebScript:]):
(+[LayoutTestController webScriptNameForSelector:]):
(-[LayoutTestController setWindowHasFocus:]):
(-[LayoutTestController setDisplaysWithFocusAttributes:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12696
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Thu, 9 Feb 2006 06:37:41 +0000 (06:37 +0000)]
Add libjpeg to the tree.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12695
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Thu, 9 Feb 2006 06:34:46 +0000 (06:34 +0000)]
Can't the damn pre-commit work!
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12694
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Thu, 9 Feb 2006 06:33:35 +0000 (06:33 +0000)]
I should not be able to check this change in because it has OOPS in a ChangeLog file.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12693
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Thu, 9 Feb 2006 06:33:05 +0000 (06:33 +0000)]
Tiling of images on Win32 is supported now.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12692
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Thu, 9 Feb 2006 06:31:16 +0000 (06:31 +0000)]
Since there's OOPS in ChangeLog this should fail.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12691
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Thu, 9 Feb 2006 06:27:48 +0000 (06:27 +0000)]
Testing new OOPS pre-commit action.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12690
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Thu, 9 Feb 2006 06:20:16 +0000 (06:20 +0000)]
Added mention of test for the last check-in.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12689
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Thu, 9 Feb 2006 06:16:58 +0000 (06:16 +0000)]
Reviewed and tweaked by Darin.
- test for http://bugzilla.opendarwin.org/show_bug.cgi?id=6648
Safari strips namespace prefix when using setAttribute(), but should treat it as part of name
* fast/dom/Element: Added.
* fast/dom/Element/setAttribute-with-colon.html: Added.
* fast/dom/Element/setAttribute-with-colon-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12688
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Thu, 9 Feb 2006 06:16:02 +0000 (06:16 +0000)]
Reviewed and tweaked by Darin.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6648
Safari strips namespace prefix when using setAttribute(), but should treat it as part of name
* khtml/xml/dom_elementimpl.h: (ElementImpl::setAttribute): Removed body
* khtml/xml/dom_elementimpl.cpp: (ElementImpl::setAttribute): Changed code so that
attribute is not parsed into prefix and local name.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12687
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Thu, 9 Feb 2006 05:51:46 +0000 (05:51 +0000)]
Fix win32 build bustage. Added libjpeg prematurely to the project.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12686
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Thu, 9 Feb 2006 05:25:45 +0000 (05:25 +0000)]
Reviewed by thatcher
Changes to test fix for:
<http://bugzilla.opendarwin.org/show_bug.cgi?id=3982>
webViewDidBeginEditing, webViewDidEndEditing notification methods not called on delegate
* DumpRenderTree/DumpRenderTree.m:
(-[WaitUntilDoneDelegate webView:didCommitLoadForFrame:]):
(+[LayoutTestController isSelectorExcludedFromWebScript:]):
(+[LayoutTestController webScriptNameForSelector:]):
(-[LayoutTestController setWindowHasFocus:]):
(-[LayoutTestController setDisplaysWithFocusAttributes:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12685
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Thu, 9 Feb 2006 05:23:38 +0000 (05:23 +0000)]
Original patch by Graham Dennis, reviewed by me:
<http://bugzilla.opendarwin.org/show_bug.cgi?id=3982>
webViewDidBeginEditing, webViewDidEndEditing notification methods not called on delegate
Changes made by me, reviewed by thatcher:
Made _setWindowHasFocus: and _setDisplaysWithFocusAttributes: into private SPI to allow
for the testing of window.onFocus, window.onBlur, caret and focus halo painting, and
the focusing of content editable regions that happens as side effect of setting a selection,
but only if the window has focus (7128).
* WebCoreSupport/WebFrameBridge.m:
(-[WebFrameBridge didBeginEditing]):
(-[WebFrameBridge didEndEditing]):
* WebView/WebHTMLView.m:
(-[WebHTMLView updateFocusState]):
(-[WebHTMLView _setWindowHasFocus:]):
(-[WebHTMLView _setDisplaysWithFocusAttributes:]):
* WebView/WebHTMLViewPrivate.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12684
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Thu, 9 Feb 2006 05:18:20 +0000 (05:18 +0000)]
Original patch by Graham Dennis, reviewed by me
Changes made by me, reviewed by thatcher
<http://bugzilla.opendarwin.org/show_bug.cgi?id=3982>
webViewDidBeginEditing, webViewDidEndEditing notification methods not called on delegate
* bridge/mac/MacFrame.h:
* bridge/mac/MacFrame.mm:
(WebCore::MacFrame::didBeginEditing):
(WebCore::MacFrame::didEndEditing):
* bridge/mac/WebCoreFrameBridge.h:
* khtml/xml/DocumentImpl.cpp:
(WebCore::DocumentImpl::didBeginEditing):
(WebCore::DocumentImpl::didEndEditing):
(WebCore::DocumentImpl::setFocusNode):
* khtml/xml/DocumentImpl.h:
* khtml/xml/dom_elementimpl.cpp:
(WebCore::ElementImpl::focus):
* page/Frame.h:
(WebCore::Frame::didBeginEditing):
(WebCore::Frame::didEndEditing):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12683
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Thu, 9 Feb 2006 04:44:31 +0000 (04:44 +0000)]
Reviewed by Hyatt.
- test for http://bugzilla.opendarwin.org/show_bug.cgi?id=7095
Removing positioning from an element does not relayout properly
* fast/block/positioning/relayout-on-position-change-expected.checksum: Added.
* fast/block/positioning/relayout-on-position-change-expected.png: Added.
* fast/block/positioning/relayout-on-position-change-expected.txt: Added.
* fast/block/positioning/relayout-on-position-change.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12682
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Thu, 9 Feb 2006 04:42:09 +0000 (04:42 +0000)]
Test: fast/block/positioning/relayout-on-position-change.html
Reviewed by Hyatt.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7095
Removing positioning from an element does not relayout properly
* rendering/render_object.cpp:
(WebCore::RenderObject::setStyle): The second call to setNeedsLayoutAndMinMaxRecalc
did not mark containing blocks for relayout based on the new position value since
the object itself was already marked as needing layout. Changed the first call to
only mark the containing blocks (based on the old position value) and not the
object itself.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12681
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Thu, 9 Feb 2006 04:09:04 +0000 (04:09 +0000)]
bugzilla.opendarwin.org/show_bug.cgi?id=4914
http://bugzilla.opendarwin.org/show_bug.cgi?id=4282
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12680
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Thu, 9 Feb 2006 04:05:15 +0000 (04:05 +0000)]
Reviewed by Darin.
- Fix http://bugzilla.opendarwin.org/show_bug.cgi?id=3527
Allow Safari to open postscript files in browser windows as well
* WebView/WebPDFRepresentation.m:
(+[WebPDFRepresentation postScriptMIMETypes]): Added.
(+[WebPDFRepresentation supportedMIMETypes]): Include PostScript MIME types.
(-[WebPDFRepresentation convertPostScriptDataSourceToPDF:]): Added.
(-[WebPDFRepresentation finishedLoadingWithDataSource:]):
Handle PostScript conversion using new convertPostScriptDataSourceToPDF method.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12679
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Thu, 9 Feb 2006 03:50:06 +0000 (03:50 +0000)]
- added SVG path hit testing test
* svg/custom/hit-test-path-expected.checksum: Added.
* svg/custom/hit-test-path-expected.png: Added.
* svg/custom/hit-test-path-expected.txt: Added.
* svg/custom/hit-test-path.svg: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12678
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Thu, 9 Feb 2006 03:02:38 +0000 (03:02 +0000)]
Reviewed by Eric.
RenderPath refactoring:
- Rename the files to RenderPath
- Push the portable code from KCanvasItemQuartz down to RenderPath
- Move most of the unportable code from KCanvasItemQuartz to KCanvasPathQuartz
The only thing left in KCanvasItemQuartz is marker support. That should be factored to separate
iterating the path elements (KCanvasPathQuartz needs to provide that) and drawing the markers
(which should be done in portable code).
* ForwardingHeaders/kcanvas/RenderPath.h: Removed.
* WebCore.xcodeproj/project.pbxproj:
* kcanvas/KCanvasItem.cpp: Removed.
* kcanvas/KCanvasItem.h: Removed.
* kcanvas/KCanvasPath.h:
* kcanvas/RenderPath.cpp: Added.
(RenderPath::mapAbsolutePointToLocal):
(RenderPath::fillContains):
(RenderPath::strokeContains):
(RenderPath::strokeBBox):
(RenderPath::relativeBBox):
(RenderPath::setPath):
(RenderPath::layout):
(RenderPath::getAbsoluteRepaintRect):
(RenderPath::requiresLayer):
(RenderPath::lineHeight):
(RenderPath::baselinePosition):
(RenderPath::paint):
(RenderPath::nodeAtPoint):
* kcanvas/RenderPath.h: Added.
* kcanvas/device/quartz/KCanvasItemQuartz.h:
* kcanvas/device/quartz/KCanvasItemQuartz.mm:
* kcanvas/device/quartz/KCanvasPathQuartz.h:
* kcanvas/device/quartz/KCanvasPathQuartz.mm:
(KCanvasPathQuartz::boundingBox):
(scratchContext):
(KCanvasPathQuartz::strokeBoundingBox):
(pathContainsPoint):
(KCanvasPathQuartz::containsPoint):
(KCanvasPathQuartz::strokeContainsPoint):
* kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
(KRenderingDeviceQuartz::createItem):
* kcanvas/device/quartz/QuartzSupport.h:
* kcanvas/device/quartz/QuartzSupport.mm:
(applyStrokeStyleToContext):
* ksvg2/svg/SVGStyledElementImpl.cpp:
(SVGStyledElementImpl::updateCanvasItem):
(SVGStyledElementImpl::pushAttributeContext):
* ksvg2/svg/SVGStyledLocatableElementImpl.cpp:
* ksvg2/svg/SVGStyledTransformableElementImpl.cpp:
* kwq/KWQRenderTreeDebug.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12677
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Thu, 9 Feb 2006 02:32:04 +0000 (02:32 +0000)]
Fix broken layout tests.
* khtml/xml/NodeImpl.cpp:
(WebCore::NodeImpl::dispatchGenericEvent): iterator is null, so we have to reset it to the first node in the chain.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12676
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Thu, 9 Feb 2006 01:41:21 +0000 (01:41 +0000)]
LayoutTests:
Reviewed by Maciej.
- test for
<rdar://problem/
4325160> REGRESSION(416.12-420+): window events not stopped by stopPropagation (affects macnn forums)
* fast/events/window-events-bubble-expected.txt: Added.
* fast/events/window-events-bubble.html: Added.
* fast/events/window-events-bubble2-expected.txt: Added.
* fast/events/window-events-bubble2.html: Added.
* fast/events/window-events-capture-expected.txt: Added.
* fast/events/window-events-capture.html: Added.
WebCore:
Reviewed by Maciej.
- Fixed <rdar://problem/
4325160>
REGRESSION(416.12-420+): window events not stopped by stopPropagation (affects macnn forums)
Tests:
* fast/events/window-events-bubble.html
* fast/events/window-events-bubble2.html
* fast/events/window-events-capture.html
* khtml/xml/DocumentImpl.cpp:
(WebCore::DocumentImpl::handleWindowEvent): Added to send events directly to the window. This code used to be in defaultEventHandler, but that wasn't sending them at the right time.
(WebCore::DocumentImpl::defaultEventHandler): Moved code to send window events to handleWindowEvent.
* khtml/xml/DocumentImpl.h: Added handleWindowEvent.
* khtml/xml/NodeImpl.cpp:
(WebCore::NodeImpl::dispatchGenericEvent): fire window events in capture and bubble phases.
(WebCore::NodeImpl::dispatchWindowEvent): call handleWindowEvent.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12675
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Thu, 9 Feb 2006 01:27:52 +0000 (01:27 +0000)]
Build fix to not use echo -e. This failed to build with sh 3.1.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12670
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Wed, 8 Feb 2006 23:49:08 +0000 (23:49 +0000)]
Undo my checking of red painting that I landed by accident.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12669
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Wed, 8 Feb 2006 22:46:43 +0000 (22:46 +0000)]
Improved Cairo image rendering by only building the surface from the portion of the buffer that has been decoded so far.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12668
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Wed, 8 Feb 2006 11:53:23 +0000 (11:53 +0000)]
2006-02-08 Anders Carlsson <andersca@mac.com>
Rubber stamped by Maciej.
Move JSCore.cpp to bindings/js/JSDOMCore.cpp and
rename JSEvents.cpp to JSDOMEvents.cpp
* JSCore.cpp: Removed.
* WebCore.vcproj/WebCore/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSDOMCore.cpp: Added.
* bindings/js/JSDOMEvents.cpp: Added.
* bindings/js/JSEvents.cpp: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12661
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Wed, 8 Feb 2006 11:48:10 +0000 (11:48 +0000)]
2006-02-06 Anders Carlsson <andersca@mac.com>
Reviewed by Maciej.
- http://bugzilla.opendarwin.org/show_bug.cgi?id=7108
Autogenerate most of Element
* JSCore.cpp:
Add JSElement.cpp.
* bindings/scripts/CodeGeneratorJS.pm:
Handle a bunch of new types.
* khtml/ecma/kjs_dom.cpp:
(KJS::DOMElement::getValueProperty):
(KJS::DOMElementProtoFunc::callAsFunction):
Remove code that is autogenerated now.
(KJS::getDOMNode):
Create a JSElement instead of a DOMElement.
(KJS::getDOMNodeList):
Take a PassRefPtr like some of the other get methods.
* khtml/ecma/kjs_dom.h:
(KJS::DOMElement::):
Remove the now unused enums.
* khtml/ecma/kjs_html.cpp:
(KJS::):
(KJS::HTMLElement::HTMLElement):
(KJS::HTMLElement::getOwnPropertySlot):
(KJS::KJS::HTMLElement::toString):
(KJS::KJS::HTMLElement::put):
* khtml/ecma/kjs_html.h:
Have HTMLElement inherit from JSElement.
* khtml/xml/Element.idl: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12660
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Wed, 8 Feb 2006 11:46:27 +0000 (11:46 +0000)]
I jumped the gun adding QString.cpp to the Win32 build. Still has some compile issues to work out. Removing it for now.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12659
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Wed, 8 Feb 2006 11:36:15 +0000 (11:36 +0000)]
Remove qstring.h forwarding header.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12658
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Wed, 8 Feb 2006 11:33:38 +0000 (11:33 +0000)]
Get the new string files added, but Win32 is still busted from the infinite include of qstring.h
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12657
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Wed, 8 Feb 2006 10:50:52 +0000 (10:50 +0000)]
Land complete PNG support for Win32 (yay).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12656
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Wed, 8 Feb 2006 05:31:04 +0000 (05:31 +0000)]
Rubber stamped by Hyatt.
- move kwq/KWQString.mm to platform/QString.cpp, split out nonportable parts, speculative
port of one remaining nonportable bit to windows.
* ForwardingHeaders/qstring.h:
* WebCore+SVG/KDOMSettings.h:
* WebCore+SVG/kdom.h:
* WebCore.xcodeproj/project.pbxproj:
* css/cssparser.h:
* css/cssstyleselector.cpp:
* kcanvas/KCanvasResources.h:
* kcanvas/KCanvasTreeDebug.h:
* khtml/ecma/kjs_window.h:
* khtml/editing/html_interchange.cpp:
* khtml/editing/visible_position.h:
* khtml/editing/visible_text.h:
* khtml/editing/visible_units.cpp:
* khtml/html/FormDataList.h:
* khtml/html/html_objectimpl.cpp:
* khtml/html/htmltokenizer.h:
* khtml/misc/decoder.h:
* khtml/misc/formdata.h:
* khtml/xbl/xbl_protohandler.cpp:
* khtml/xml/dom_position.cpp:
* khtml/xsl/xslt_processorimpl.h:
* ksvg2/svg/SVGHelper.h:
* ksvg2/svg/SVGPreserveAspectRatioImpl.cpp:
* ksvg2/svg/SVGStyleElementImpl.cpp:
* ksvg2/svg/SVGURIReferenceImpl.h:
* ksvg2/svg/svgpathparser.cpp:
* kwq/KWQAccObjectCache.mm:
* kwq/KWQBuffer.h:
* kwq/KWQEvent.h:
* kwq/KWQFont.mm:
* kwq/KWQFontFamily.h:
* kwq/KWQFontMetrics.h:
* kwq/KWQKConfigBase.h:
* kwq/KWQKDebug.h:
* kwq/KWQKHTMLSettings.h:
* kwq/KWQKJobClasses.h:
* kwq/KWQKJobClasses.mm:
* kwq/KWQKLocale.mm:
* kwq/KWQKSSLKeyGen.mm:
* kwq/KWQKURL.h:
* kwq/KWQLineEdit.h:
* kwq/KWQRegExp.h:
* kwq/KWQRenderTreeDebug.h:
* kwq/KWQString.h: Removed.
* kwq/KWQString.mm: Removed.
* kwq/KWQStringList.h:
* kwq/KWQTextCodec.h:
* kwq/KWQTextStream.h:
* kwq/KWQTextUtilities.mm:
* kwq/WebCoreScriptDebugger.mm:
* loader/Cache.h:
* platform/Color.cpp:
* platform/Color.h:
* platform/QString.cpp: Added.
(allocateHandle):
(KWQStringData::KWQStringData):
(QString::QString):
(QString::insert):
(QString::detach):
(QString::remove):
(QString::setLength):
(QString::fill):
(initializeHandleNodeBlock):
(allocateNode):
(freeHandle):
* platform/QString.h: Added.
* platform/SegmentedString.h:
* platform/StringImpl.h:
* platform/mac/Image.mm:
* platform/mac/QString.mm: Added.
(QString::setBufferFromCFString):
(QString::fromCFString):
(QString::fromNSString):
(QString::getNSString):
(QString::utf8):
(QString::fromUtf8):
* rendering/bidi.h:
* rendering/break_lines.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12655
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Wed, 8 Feb 2006 03:05:31 +0000 (03:05 +0000)]
Update page directory in Win32 project to match what's there now.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12654
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Wed, 8 Feb 2006 03:01:16 +0000 (03:01 +0000)]
Reviewed by Adele.
- remove all remains of old-style frame tree, ChildFrame, ObjectContents and FrameList are all gone
* WebCore.xcodeproj/project.pbxproj:
* bridge/BrowserExtension.h:
* bridge/mac/BrowserExtensionMac.h:
* bridge/mac/BrowserExtensionMac.mm:
(WebCore::BrowserExtensionMac::createNewWindow):
* khtml/ecma/kjs_window.cpp:
(KJS::createNewWindow):
(KJS::Window::indexGetter):
(KJS::Window::getOwnPropertySlot):
(KJS::WindowFunc::callAsFunction):
(KJS::FrameArray::getValueProperty):
(KJS::FrameArray::indexGetter):
(KJS::FrameArray::nameGetter):
(KJS::FrameArray::getOwnPropertySlot):
* kwq/KWQFrame.mm:
(QFrame::setFrameStyle):
* page/Frame.cpp:
(WebCore::Frame::Frame):
(WebCore::Frame::stopLoading):
(WebCore::Frame::clear):
(WebCore::Frame::stopAnimations):
(WebCore::Frame::checkCompleted):
(WebCore::Frame::checkEmitLoadEvent):
(WebCore::Frame::requestFrame):
(WebCore::Frame::requestObject):
(WebCore::Frame::loadSubframe):
(WebCore::Frame::findFrame):
(WebCore::Frame::frameExists):
(WebCore::Frame::setZoomFactor):
(WebCore::Frame::frameNames):
(WebCore::Frame::frames):
(WebCore::Frame::childFrameNamed):
(WebCore::Frame::slotPartRemoved):
(WebCore::Frame::connectChild):
(WebCore::Frame::disconnectChild):
(WebCore::Frame::canCachePage):
(WebCore::Frame::setPolicyBaseURL):
(WebCore::Frame::treeNode):
(WebCore::Frame::frameDetached):
* page/Frame.h:
* page/FramePrivate.h:
* page/FrameTreeNode.h:
(WebCore::FrameTreeNode::name):
(WebCore::FrameTreeNode::parent):
(WebCore::FrameTreeNode::nextSibling):
(WebCore::FrameTreeNode::previousSibling):
(WebCore::FrameTreeNode::firstChild):
(WebCore::FrameTreeNode::lastChild):
(WebCore::FrameTreeNode::childCount):
* page/ObjectContents.h: Removed.
* page/Plugin.h:
(WebCore::Plugin::view):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12653
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Wed, 8 Feb 2006 02:39:22 +0000 (02:39 +0000)]
LayoutTests:
- test for
<rdar://problem/
3727939> Safari strips \0 characters from HTML tags making them valid
* fast/encoding/decoder-allow-null-chars.html
* fast/encoding/decoder-allow-null-chars-expected.txt
WebCore:
Reviewed by Maciej.
- Fixed <rdar://problem/
3727939> Safari strips \0 characters from HTML tags making them valid
Test: fast/encoding/decoder-allow-null-chars.html
* kwq/KWQTextCodec.cpp:
(KWQTextDecoder::convertLatin1): Removed stripping of null characters
(unwanted): ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12652
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Wed, 8 Feb 2006 00:46:43 +0000 (00:46 +0000)]
Land the skeleton of a PNG decoder for Win32.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12651
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Wed, 8 Feb 2006 00:14:28 +0000 (00:14 +0000)]
Add bindings/js/JSEvents.cpp to the win32 build.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12650
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Tue, 7 Feb 2006 23:08:50 +0000 (23:08 +0000)]
2006-02-07 Eric Seidel <eseidel@apple.com>
Reviewed by hyatt.
Removed ImageSubset, making ImageViewer link directly to WebCore.
* Viewer.vcproj:
* WebCore.vcproj/ImageSubset: Removed.
* WebCore.vcproj/ImageSubset/ImageSubset.vcproj: Removed.
* WebCore.vcproj/WebCore.sln:
* WebCore.vcproj/WebCore/WebCore.vcproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12649
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Tue, 7 Feb 2006 21:36:25 +0000 (21:36 +0000)]
Add Image Subset of WebCore as a project to the win32 build for the Image Viewer app to link against.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12648
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Tue, 7 Feb 2006 21:32:55 +0000 (21:32 +0000)]
Reviewed by darin.
- Fixed <rdar://problem/
4425269> REGRESSION: wrong size pop-up when
downloading attachment at webmail.mac.com (6882)
The bug was that the feature string parser didn't always initialize the
*Set variables, so WebCore assumed a height was set when it wasn't,
and used a garbage height variable.
While there, I fixed two other bugs: (1) The parser wasn't chewing up
as many characters as I thought it was. (Chewing up extra characters
is necessary to match Win IE.) (2) We considered \t and \f to be
whitespace, but Win IE doesn't.
* manual-tests/window-open-features-parsing.html: Added these cases,
fixed up comments.
* bridge/BrowserExtension.h: Cleaned up declaration order a bit.
* khtml/ecma/kjs_window.cpp:
(KJS::isSeparator): New function, tells you if a character is a
separator
(KJS::parseWindowFeatures): Always initialize *Set to false. Drive
parsing based on invalid characters ('separators') rather than valid
ones, to match Win IE.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12647
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Tue, 7 Feb 2006 21:27:04 +0000 (21:27 +0000)]
Set more MIME types.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12646
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Tue, 7 Feb 2006 21:17:48 +0000 (21:17 +0000)]
Set a bunch of MIME types.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12645
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Tue, 7 Feb 2006 17:01:42 +0000 (17:01 +0000)]
2006-02-07 Alexey Proskuryakov <ap@nypop.com>
Reviewed by Timothy.
Convert JavaScript objects to appropriate AppleScript types, instead of only strings
http://bugzilla.opendarwin.org/show_bug.cgi?id=7012
WebKit:
* WebView/WebView.m:
(-[WebView aeDescByEvaluatingJavaScriptFromString:]): Added.
* WebView/WebViewPrivate.h:
WebCore:
* bridge/mac/WebCoreFrameBridge.h:
* bridge/mac/WebCoreFrameBridge.mm:
(aeDescFromJSValue): Added.
(-[WebCoreFrameBridge aeDescByEvaluatingJavaScriptFromString:]): Added.
WebKitTools:
* DumpRenderTree/AppleScriptController.h: Added.
* DumpRenderTree/AppleScriptController.m: Added.
* DumpRenderTree/DumpRenderTree.m:
(-[WaitUntilDoneDelegate webView:windowScriptObjectAvailable:]):
* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
LayoutTests:
* fast/AppleScript: Added.
* fast/AppleScript/001-expected.txt: Added.
* fast/AppleScript/001.html: Added.
* fast/AppleScript/array-expected.txt: Added.
* fast/AppleScript/array.html: Added.
* fast/AppleScript/date-expected.txt: Added.
* fast/AppleScript/date.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12644
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Tue, 7 Feb 2006 11:31:51 +0000 (11:31 +0000)]
Add libpng and the zlib supporting library in preparation for iplementing PNG decoding.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12643
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Tue, 7 Feb 2006 11:07:43 +0000 (11:07 +0000)]
FInal image renaming for Win32 gif stuff.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12642
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Tue, 7 Feb 2006 10:47:39 +0000 (10:47 +0000)]
Rename ImageDecoder to ImageSource.
Reviewed by mjs
* WebCore.xcodeproj/project.pbxproj:
* platform/Image.cpp:
(WebCore::Image::cacheFrame):
(WebCore::Image::size):
(WebCore::Image::setNativeData):
(WebCore::Image::frameCount):
(WebCore::Image::isSizeAvailable):
* platform/Image.h:
* platform/ImageDecoder.h: Removed.
* platform/ImageSource.h: Added.
* platform/cairo/ImageCairo.cpp:
(WebCore::Image::drawInRect):
* platform/cairo/ImageDecoderCairo.cpp: Removed.
* platform/cairo/ImageSourceCairo.cpp: Added.
(WebCore::createDecoderPlugin):
(WebCore::ImageSource::ImageSource):
(WebCore::ImageSource::~ImageSource):
(WebCore::ImageSource::initialized):
(WebCore::ImageSource::setData):
(WebCore::ImageSource::isSizeAvailable):
(WebCore::ImageSource::size):
(WebCore::ImageSource::repetitionCount):
(WebCore::ImageSource::frameCount):
(WebCore::ImageSource::createFrameAtIndex):
(WebCore::ImageSource::frameDurationAtIndex):
* platform/mac/Image.mm:
(WebCore::Image::drawInRect):
* platform/mac/ImageData.mm: Removed.
* platform/mac/ImageDecoder.cpp: Removed.
* platform/mac/ImageSource.cpp: Added.
(WebCore::ImageSource::ImageSource):
(WebCore::ImageSource::~ImageSource):
(WebCore::ImageSource::initialized):
(WebCore::ImageSource::setData):
(WebCore::ImageSource::isSizeAvailable):
(WebCore::ImageSource::size):
(WebCore::ImageSource::repetitionCount):
(WebCore::ImageSource::frameCount):
(WebCore::ImageSource::createFrameAtIndex):
(WebCore::ImageSource::frameDurationAtIndex):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12641
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Tue, 7 Feb 2006 10:17:52 +0000 (10:17 +0000)]
Combine ImageData and Image (the result ends up in Image).
Reviewed by mjs
* WebCore.xcodeproj/project.pbxproj:
* bindings/objc/DOM.mm:
(-[DOMElement _image]):
(-[DOMElement _imageTIFFRepresentation]):
* bridge/mac/MacFrame.mm:
(WebCore::MacFrame::fileWrapperForElement):
* kcanvas/device/quartz/KCanvasFilterQuartz.mm:
(KCanvasFEImageQuartz::getCIFilter):
* khtml/ecma/kjs_html.cpp:
(KJS::KJS::Context2DFunction::callAsFunction):
(KJS::drawPattern):
(KJS::_rh):
(KJS::ImagePattern::createPattern):
* kwq/KWQClipboard.mm:
(WebCore::KWQClipboard::dragNSImage):
* kwq/KWQCursor.h:
* kwq/KWQCursor.mm:
(WebCore::createCustomCursor):
(WebCore::QCursor::QCursor):
* kwq/KWQPainter.h:
* kwq/KWQPainter.mm:
(WebCore::QPainter::drawImageAtPoint):
(WebCore::QPainter::drawImageInRect):
(WebCore::QPainter::drawImage):
(WebCore::QPainter::drawFloatImage):
(WebCore::QPainter::drawTiledImage):
(WebCore::QPainter::drawScaledAndTiledImage):
* loader/CachedImage.cpp:
(WebCore::CachedImage::image):
* loader/CachedImage.h:
* page/FrameView.cpp:
(WebCore::selectCursor):
* platform/Image.cpp:
(WebCore::Image::Image):
(WebCore::Image::~Image):
(WebCore::Image::invalidateData):
(WebCore::Image::cacheFrame):
(WebCore::Image::isNull):
(WebCore::Image::size):
(WebCore::Image::setData):
(WebCore::Image::setNativeData):
(WebCore::Image::frameCount):
(WebCore::Image::isSizeAvailable):
(WebCore::Image::frameAtIndex):
(WebCore::Image::frameDurationAtIndex):
(WebCore::Image::shouldAnimate):
(WebCore::Image::startAnimation):
(WebCore::Image::stopAnimation):
(WebCore::Image::resetAnimation):
(WebCore::Image::advanceAnimation):
(WebCore::Image::rect):
* platform/Image.h:
(KXMLCore::):
(WebCore::FrameData::m_duration):
(WebCore::FrameData::~FrameData):
(WebCore::Image::currentFrame):
(WebCore::Image::animationObserver):
(WebCore::Image::setIsPDF):
* platform/ImageData.cpp: Removed.
* platform/ImageData.h: Removed.
* platform/cairo/ImageCairo.cpp:
(WebCore::FrameData::clear):
(WebCore::Image::initNativeData):
(WebCore::Image::destroyNativeData):
(WebCore::Image::invalidateNativeData):
(WebCore::Image::drawInRect):
(WebCore::Image::tileInRect):
(WebCore::Image::scaleAndTileInRect):
* platform/mac/Image.mm:
(WebCore::FrameData::clear):
(WebCore::Image::initNativeData):
(WebCore::Image::destroyNativeData):
(WebCore::Image::invalidateNativeData):
(WebCore::Image::loadResource):
(WebCore::Image::supportsType):
(WebCore::Image::checkForSolidColor):
(WebCore::Image::getTIFFRepresentation):
(WebCore::Image::getNSImage):
(WebCore::Image::getCGImageRef):
(WebCore::Image::drawInRect):
(WebCore::drawPattern):
(WebCore::Image::tileInRect):
(WebCore::Image::scaleAndTileInRect):
* rendering/render_image.cpp:
(WebCore::RenderImage::imageChanged):
(WebCore::RenderImage::resetAnimation):
(WebCore::RenderImage::paint):
(WebCore::RenderImage::nullImage):
* rendering/render_image.h:
(WebCore::RenderImage::image):
* rendering/render_list.cpp:
(RenderListItem::getAbsoluteRepaintRect):
(RenderListMarker::paint):
(RenderListMarker::calcMinMaxWidth):
* rendering/render_object.cpp:
(WebCore::RenderObject::paintBorderImage):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12640
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Tue, 7 Feb 2006 09:29:20 +0000 (09:29 +0000)]
Reviewed by Darin. Landed by Maciej.
- Several fixes to the site
http://bugzilla.opendarwin.org/show_bug.cgi?id=7105
* blog/wp-content/themes/webkit/style.css:
* index.html:
* quality/bugwriting.html:
* quality/reduction.html:
* webkitdev.css:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12639
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Tue, 7 Feb 2006 09:21:00 +0000 (09:21 +0000)]
LayoutTests:
Reviewed by Eric.
- test case that verifies that <object> containing html is treated
like <iframe> in various respects
http://bugzilla.opendarwin.org/show_bug.cgi?id=7125
* fast/dom/HTMLObjectElement/object-as-frame-expected.txt: Added.
* fast/dom/HTMLObjectElement/object-as-frame.html: Added.
- updated this test to reflect that the onload event now fires for iframes,
including ones with empty src
http://bugzilla.opendarwin.org/show_bug.cgi?id=3609
* fast/events/event-targets-expected.checksum: Removed.
* fast/events/event-targets-expected.png: Removed.
* fast/events/event-targets-expected.txt:
* fast/events/event-targets.html:
WebCore:
Reviewed by Eric.
- fixed "remove frame, renderer and completed flag from ChildFrame, make Frame track these"
http://bugzilla.opendarwin.org/show_bug.cgi?id=7125
- fixed "onload event never called for iframe element with emtpy or about:blank src"
http://bugzilla.opendarwin.org/show_bug.cgi?id=3609
* bridge/mac/MacFrame.h:
* bridge/mac/MacFrame.mm:
(WebCore::MacFrame::MacFrame): pass along renderer
(WebCore::MacFrame::nextKeyViewInFrameHierarchy): get owner element in newfangled way
* bridge/mac/WebCoreFrameBridge.h:
* bridge/mac/WebCoreFrameBridge.mm:
(-[WebCoreFrameBridge removeChild:]): don't mess with renderer
(-[WebCoreFrameBridge init]): call new designated initializer
(-[WebCoreFrameBridge initWithRenderer:]): new designated initializer
(-[WebCoreFrameBridge dealloc]): don't mess with renderer
(-[WebCoreFrameBridge finalize]): ditto
(-[WebCoreFrameBridge installInFrame:]): ditto
* page/Frame.cpp:
(WebCore::FrameList::find): get name from frame not ChildFrame
(WebCore::Frame::init): take renderer parameter
(WebCore::Frame::clear): clear m_plugins, not m_objects
(WebCore::Frame::childBegin): updated comment
(WebCore::Frame::stop): add check-completed for documentless case here
(WebCore::Frame::checkCompleted): don't track separate completed flag
in ChildFrame, use the sub Frame object's own
(WebCore::Frame::checkEmitLoadEvent): ditto
(WebCore::Frame::requestFrame): don't store renderer and name in ChildFrame,
instead pass them along
(WebCore::Frame::requestObject): ditto above
(WebCore::Frame::loadPlugin): expect renderer parameter
(WebCore::Frame::loadSubframe): expect renderer and name parameters
(WebCore::Frame::slotChildStarted): don't mess with ChildFrame
(WebCore::Frame::slotChildCompleted): ditto
(WebCore::Frame::childFrame): don't check m_objects
(WebCore::Frame::frameExists): fix spacing, remove obsolete check and comment
(WebCore::Frame::frameNames): get name from frame
(WebCore::Frame::ownerElement): simplify a lot since the Frame knows its owner
renderer now
(WebCore::Frame::ownerRenderer): added
(WebCore::Frame::canCachePage): check m_plugins not m_objects
* page/Frame.h:
* page/FramePrivate.h:
(WebCore::ChildFrame): Remove constructor, most fields.
(WebCore::FramePrivate::FramePrivate): Pass ownerRenderer
* rendering/render_frames.cpp:
(WebCore::RenderPartObject::updateWidget): Make sure to pass name attr
to requestObject.
WebKit:
Reviewed by Eric.
- fixed "remove frame, renderer and completed flag from ChildFrame, make Frame track these"
http://bugzilla.opendarwin.org/show_bug.cgi?id=7125
- fixed "onload event never called for iframe element with emtpy or about:blank src"
http://bugzilla.opendarwin.org/show_bug.cgi?id=3609
* WebCoreSupport/WebFrameBridge.h:
* WebCoreSupport/WebFrameBridge.m:
(-[WebFrameBridge initWithPage:webView:renderer:frameName:view:]): Pass along renderer.
(-[WebFrameBridge createChildFrameNamed:withURL:referrer:renderPart:allowsScrolling:marginWidth:marginHeight:]): Pass along renderer.
* WebCoreSupport/WebPageBridge.m:
(-[WebPageBridge initWithMainFrameName:webView:frameView:]): Pass null for renderer.
* WebView/WebView.m:
* WebView/WebViewPrivate.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12638
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Tue, 7 Feb 2006 07:48:41 +0000 (07:48 +0000)]
LayoutTests:
Reviewed by Maciej.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6944
REGRESSION: crash when loading page w/ <link> that has a DOMSubtreeModified event listener
* fast/events/event-listener-on-link.html: Added.
* fast/events/event-listener-on-link-expected.txt: Added.
* fast/events/event-listener-on-link-expected.png: Added.
* fast/events/event-listener-on-link-expected.checksum: Added.
WebCore:
Reviewed by Maciej.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6944
REGRESSION: crash when loading page w/ <link> that has a DOMSubtreeModified event listener
Test: fast/events/event-listener-on-link.html
* khtml/xml/dom_elementimpl.h: Added createAttrImplIfNeeded, removed allocateImpl,
changed AttrImpl contructor to remove createTextChild bool, added createTextChild method,
changed getAttributeNode, getAttributeNodeNS, getNamedItem, getNamedItemNS, and item to return PassRefPtrs.
(DOM::ElementImpl::getAttributeNode):
* khtml/xml/dom_elementimpl.cpp:
(WebCore::AttributeImpl::createAttrImplIfNeeded): New method to replace allocateImpl.
This will use a RefPtr for the AttrImpl, check for an existing AttrImpl, create one if there isn't one,
and will call the new createTextChild.
(WebCore::AttrImpl::AttrImpl): Moved creation of text child to new createTextChild method.
If done in the constructor, the ref count is still 0, and the act of appending the text node
could cause the AttrImpl to be destroyed.
(WebCore::AttrImpl::createTextChild): Moved code from AttrImpl contructor.
Also, I've added an assert to make sure that any callers of this have ref'd the AttrImpl.
(WebCore::AttrImpl::cloneNode): Used RefPtr instead of PassRefPtr, and then called release() on it before returning.
(WebCore::ElementImpl::cloneNode): ditto.
(WebCore::ElementImpl::getAttributeNodeNS): Changed return type to PassRefPtr.
(WebCore::NamedAttrMapImpl::getNamedItemNS): ditto.
(WebCore::NamedAttrMapImpl::getNamedItem): ditto. Changed use of allocateImpl to createAttrImplIfNeeded
(WebCore::NamedAttrMapImpl::setNamedItem): ditto.
(WebCore::NamedAttrMapImpl::removeNamedItem): ditto.
(WebCore::NamedAttrMapImpl::item): ditto.
* khtml/xml/DocumentImpl.cpp:
(WebCore::DocumentImpl::createAttributeNS): Changed return type to PassRefPtr and removed bool from AttrImpl contructor call.
* khtml/xml/DocumentImpl.h: Now returns a PassRefPtr for createAttribute and createAttributeNS.
(WebCore::DocumentImpl::createAttribute):
* khtml/xml/NamedNodeMapImpl.h: Now returns a PassRefPtr for getNamedItem, getNamedItemNS, and item.
(WebCore::NamedNodeMapImpl::getNamedItem):
* bindings/objc/DOM.mm:
(-[DOMNamedNodeMap getNamedItem:]): Call get() since the methods discussed above now return PassRefPtrs.
(-[DOMNamedNodeMap item:]): ditto.
(-[DOMNamedNodeMap getNamedItemNS::]): ditto.
(-[DOMDocument createAttribute:]): ditto.
(-[DOMDocument createAttributeNS::]): ditto.
(-[DOMElement getAttributeNode:]): ditto.
(-[DOMElement getAttributeNodeNS::]): ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12637
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Tue, 7 Feb 2006 07:37:04 +0000 (07:37 +0000)]
Reviewed by Darin.
- fixed 7094: onfocus/onblur on non-form-controls bubble
http://bugzilla.opendarwin.org/show_bug.cgi?id=7094
* khtml/html/HTMLElementImpl.cpp:
(WebCore::HTMLElementImpl::parseMappedAttribute): connect onfocus/onblur to
focus/blur, not DOMFocusIn/DOMFocusOut
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12636
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Tue, 7 Feb 2006 07:14:16 +0000 (07:14 +0000)]
Reviewed by Darin.
- test for 7094: onfocus/onblur on non-form-controls bubble
http://bugzilla.opendarwin.org/show_bug.cgi?id=7094
* fast/events/div-focus-expected.txt: Added.
* fast/events/div-focus.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12635
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Tue, 7 Feb 2006 07:07:37 +0000 (07:07 +0000)]
Fix build bustage on Mac.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12634
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Tue, 7 Feb 2006 07:06:00 +0000 (07:06 +0000)]
Fix build bustage on Mac.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12633
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Tue, 7 Feb 2006 06:57:35 +0000 (06:57 +0000)]
2006-02-06 Eric Seidel <eseidel@apple.com>
Add svn:ignore properties for visual studio internals.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12632
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Tue, 7 Feb 2006 06:56:03 +0000 (06:56 +0000)]
2006-02-06 Eric Seidel <eseidel@apple.com>
Add svn:ignore properties for visual studio internals.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12631
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Tue, 7 Feb 2006 06:52:55 +0000 (06:52 +0000)]
2006-02-06 Eric Seidel <eseidel@apple.com>
Reviewed by hyatt.
Fix build-webkit for use on win32 (unblocks buildbot usage).
http://bugzilla.opendarwin.org/show_bug.cgi?id=7122
* Scripts/build-webkit: use ifCygwin() to conditionalize builds
* Scripts/webkitdirs.pm: add ifOSX() and ifCygwin()
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12630
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Tue, 7 Feb 2006 06:30:34 +0000 (06:30 +0000)]
Rename SystemTime.cpp to SystemTimeWin.cpp
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12629
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Tue, 7 Feb 2006 06:29:41 +0000 (06:29 +0000)]
Rename SystemTime.cpp to SystemTimeWin.cpp
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12628
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Tue, 7 Feb 2006 06:28:01 +0000 (06:28 +0000)]
Remove accidentally committed file.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12627
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Tue, 7 Feb 2006 06:15:06 +0000 (06:15 +0000)]
Fix more build bustage.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12626
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Tue, 7 Feb 2006 06:13:12 +0000 (06:13 +0000)]
Land image viewer test app.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12625
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Tue, 7 Feb 2006 06:11:17 +0000 (06:11 +0000)]
Reviewed by Darin.
- Refactor DateInstance to provide direct access to data. Several WIN32 modifications.
http://bugzilla.opendarwin.org/show_bug.cgi?id=7107
- No tests added - only changed functionality on WIN32, which should be covered by
existing tests.
* kjs/date_object.cpp:
(gmtoffset): On WIN32, use the recommended global (_timezone rather than timezone).
Updated comments.
(KJS::timeZoneOffset): Removed, was basically the same as the above.
(KJS::formatTime): Pass an UTC flag - UTC/local cannot be correctly selected on
Windows based on struct tm itself.
(KJS::DateInstance::getTime): Added.
(KJS::DateInstance::getUTCTime): Added.
(KJS::millisecondsToTM): Factored out from DateProtoFunc::callAsFunction().
(KJS::DateObjectImp::callAsFunction): Use the new parameter to formatTime().
(KJS::DateProtoFunc::callAsFunction): Updated for the other changes. The code for
GetTimezoneOffset was incorrect on WIN32 - _daylight global has nothing to do
with daylight savings time being in effect.
* kjs/date_object.h: Added prototypes for new functions.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12624
268f45cc-cd09-0410-ab3c-
d52691b4dbfc