13 years agoLayoutTests:
andersca [Fri, 6 Jul 2007 20:52:42 +0000 (20:52 +0000)]

        Reviewed by Mitz.

        REGRESSION: Can't access nested embed by document.name if object is not immediate parent

        * plugins/embed-inside-object-expected.txt: Added.
        * plugins/embed-inside-object.html: Added.


        Reviewed by Mitz.

        REGRESSION: Can't access nested embed by document.name if object is not immediate parent

        Traverse up the tree looking for an object element.

        * html/HTMLEmbedElement.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd another Leopard failure
aroben [Fri, 6 Jul 2007 20:29:41 +0000 (20:29 +0000)]
Add another Leopard failure

* mac/leopard/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd another crasher to the Skipped file
aroben [Fri, 6 Jul 2007 18:11:16 +0000 (18:11 +0000)]
Add another crasher to the Skipped file

Also moved a test that had a bug filed about it out of the section of
unfiled failures.

* win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Alexey.
andersca [Fri, 6 Jul 2007 18:00:42 +0000 (18:00 +0000)]
    Reviewed by Alexey.

        <rdar://problem/5313518> fast/events/iframe-object-onload.html shows events out of order on Leopard

        Fix test so that it doesn't matter in what order the frames/objects are loaded. This is done by keeping
        the load logs in an array and sort it before dumping it.

        * fast/events/iframe-object-onload-expected.txt:
        * fast/events/iframe-object-onload.html:
        * mac/leopard/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoDon't clobber variables that are already set, resulting in a broken build.
staikos [Fri, 6 Jul 2007 17:28:27 +0000 (17:28 +0000)]
Don't clobber variables that are already set, resulting in a broken build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Alexey.
andersca [Fri, 6 Jul 2007 17:08:50 +0000 (17:08 +0000)]
    Reviewed by Alexey.

        <rdar://problem/5313512> fast/frames/frame-set-same-{location,src}.html sometimes hang on Leopard

        Make these tests more robust against frames loading in a different order. Also, turn the tests
        into text tests and remove them from the Leopard skipped list.

        * fast/frames/frame-set-same-location-expected.checksum: Removed.
        * fast/frames/frame-set-same-location-expected.png: Removed.
        * fast/frames/frame-set-same-location-expected.txt:
        * fast/frames/frame-set-same-location.html:
        * fast/frames/frame-set-same-src-expected.checksum: Removed.
        * fast/frames/frame-set-same-src-expected.png: Removed.
        * fast/frames/frame-set-same-src-expected.txt:
        * fast/frames/frame-set-same-src.html:
        * mac/leopard/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd --qmakearg=foo to make it possible to configure the build without editing
staikos [Fri, 6 Jul 2007 16:54:37 +0000 (16:54 +0000)]
Add --qmakearg=foo to make it possible to configure the build without editing
the .pro files each time.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-07-07 Mark Rowe <mrowe@apple.com>
bdash [Fri, 6 Jul 2007 14:56:38 +0000 (14:56 +0000)]
2007-07-07  Mark Rowe  <mrowe@apple.com>

        Build fix.  Update WebDynamicScrollBarsView.h to include methods added and used in r24060.

        * WebView/WebDynamicScrollBarsView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by John.
thatcher [Fri, 6 Jul 2007 14:40:08 +0000 (14:40 +0000)]
    Reviewed by John.

        <rdar://problem/5236277> REGRESSION-9A458: SPI for setting scroll bar behavior doesn't work

        Calling setHorizontalScrollingMode: calls updateScrollers before returning, this will cause
        WebCore to reset the scrolling mode based on the CSS overflow rules. So the setAlwaysShowHorizontalScroller:
        and setAlwaysShowVerticalScroller: methods needed a way to lock the scrolling mode before
        calling updateScrollers.

        * WebView/WebDynamicScrollBarsView.m:
        (-[WebDynamicScrollBarsView updateScrollers]):
        (-[WebDynamicScrollBarsView setHorizontalScrollingMode:]):
        (-[WebDynamicScrollBarsView setHorizontalScrollingMode:andLock:]):
        (-[WebDynamicScrollBarsView setVerticalScrollingMode:]):
        (-[WebDynamicScrollBarsView setVerticalScrollingMode:andLock:]):
        (-[WebDynamicScrollBarsView setScrollingMode:]):
        (-[WebDynamicScrollBarsView setScrollingMode:andLock:]):
        * WebView/WebView.mm:
        (-[WebView setAlwaysShowVerticalScroller:]):
        (-[WebView setAlwaysShowHorizontalScroller:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
mjs [Fri, 6 Jul 2007 12:09:08 +0000 (12:09 +0000)]

        Reviewed by Antti.

        - <rdar://problem/5311093> JavaScriptCore fails to build with strict-aliasing warnings

        * Configurations/Base.xcconfig: Re-enable -Wstrict-aliasing
        * bindings/jni/jni_utility.cpp:
        (KJS::Bindings::getJNIEnv): Type-pun via a union instead of a pointer cast.
        * wtf/HashMap.h:
        (WTF::): Instead of doing type-punned assignments via pointer cast, do one of three things:
        (1) assign directly w/o cast if storage type matches real type; (2) assign using cast
        via union if type does not need reffing; (3) copy with memcpy and ref/deref manually if type
        needs reffing. This is ok peref-wise because memcpy of a constant length gets optomized.
        HashTraits are now expected to make ref()/deref() take the storage type, not the true type.
        * wtf/HashSet.h:
        (WTF::): Same basic idea.
        * wtf/HashTable.h:
        (WTF::): Added Assigner template for use by HashMap/HashSet. Change RefCounter to call ref()
        and deref() via storage type, avoiding the need to
        (WTF::RefCounter::ref): ditto
        (WTF::RefCounter::deref): ditto
        * wtf/HashTraits.h:
        (WTF::): Change ref() and deref() for RefPtr HashTraits to take the storage type; cast
        via union to pointer type.
        * wtf/FastMalloc.cpp:
        (WTF::TCMalloc_PageHeap::init): Changed from constructor to init function so this can go in a union.
        (WTF::): redefine pageheap macro in terms of getPageHeap().
        (WTF::getPageHeap): new inline function, helper for pageheap macro. This hides the cast in a union.
        (WTF::TCMalloc_ThreadCache::InitModule): Call init() instead of using placement new to initialize page
        * wtf/TCPageMap.h:
        (TCMalloc_PageMap1::init): Changed from constructor to init function.
        (TCMalloc_PageMap2::init): ditto
        (TCMalloc_PageMap3::init): ditto


        Reviewed by Antti.

        - <rdar://problem/5311093> JavaScriptCore fails to build with strict-aliasing warnings

        * platform/StringHash.h:
        (WTF::): Adapt to newer way to do storage types.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-07-06 Bernhard Rosenkraenzer <bero@arklinux.org>
bdash [Fri, 6 Jul 2007 11:42:53 +0000 (11:42 +0000)]
2007-07-06  Bernhard Rosenkraenzer  <bero@arklinux.org>

        Reviewed by Sam.

        Fix for http://bugs.webkit.org/show_bug.cgi?id=13985
        Bug 13985: WebCore/rendering/RenderTable.cpp fails to compile with gcc 4.2.x

        * rendering/RenderTable.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-07-06 Maxime Britto <mbritto@pleyo.com>
bdash [Fri, 6 Jul 2007 10:31:35 +0000 (10:31 +0000)]
2007-07-06  Maxime Britto  <mbritto@pleyo.com>

        Reviewed by Maciej.

        Fix http://bugs.webkit.org/show_bug.cgi?id=13038
        Bug 13038: ASSERTION FAILED: item->target().isEmpty() || m_mainFrame->tree()->find(item->target()) == m_mainFrame

        Modify an ASSERT in goToItem related to going back/forward in history.  We don't need to check the frameset if the target is _blank.
        The attached test case is a manual one since it relies on having pages opened in tabs in Safari.

        * manual-tests/goBack-blank-tab-page.html: Added.
        * manual-tests/resources/before-go-back.html: Added.
        * manual-tests/resources/will-go-back.html: Added.
        * page/Page.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-07-06 Mark Rowe <mrowe@apple.com>
bdash [Fri, 6 Jul 2007 10:21:32 +0000 (10:21 +0000)]
2007-07-06  Mark Rowe  <mrowe@apple.com>

        Unreviewed.  Update test results.

        * fast/encoding/utf-32-big-endian-bom-expected.txt:
        * fast/encoding/utf-32-big-endian-nobom-expected.txt:
        * fast/encoding/utf-32-little-endian-bom-expected.txt:
        * fast/encoding/utf-32-little-endian-nobom-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24056 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-07-06 Mitz Pettel <mitz@webkit.org>
bdash [Fri, 6 Jul 2007 10:06:46 +0000 (10:06 +0000)]
2007-07-06  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Maciej.

        - fix http://bugs.webkit.org/show_bug.cgi?id=14400
          Assertion failure (SHOULD NEVER BE REACHED) going back on YouTube

        Test: fast/forms/button-state-restore.html

        * dom/Document.h:
        (WebCore::Document::isFormElementRegistered): Added.
        * html/HTMLGenericFormElement.cpp:
        (WebCore::HTMLGenericFormElement::closeRenderer): Restore saved form
        element state only if the element is registered with the document to
        have its state saved.

2007-07-06  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Maciej.

        - test for http://bugs.webkit.org/show_bug.cgi?id=14400
          Assertion failure (SHOULD NEVER BE REACHED) going back on YouTube

        * fast/forms/button-state-restore-expected.txt: Added.
        * fast/forms/button-state-restore.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-07-06 Mitz Pettel <mitz@webkit.org>
bdash [Fri, 6 Jul 2007 10:05:16 +0000 (10:05 +0000)]
2007-07-06  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Maciej.

        - fix http://bugs.webkit.org/show_bug.cgi?id=14487
          Incomplete repaint of background and border of boxes with -webkit-border-fit:lines

        Test: fast/repaint/border-fit-lines.html

        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::repaintAfterLayoutIfNeeded): Do a full repaint if
        -webkit-border-fit:lines was specified.

2007-07-06  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Maciej.

        - repaint test for http://bugs.webkit.org/show_bug.cgi?id=14487
          Incomplete repaint of background and border of boxes with -webkit-border-fit:lines

        * fast/repaint/border-fit-lines-expected.checksum: Added.
        * fast/repaint/border-fit-lines-expected.png: Added.
        * fast/repaint/border-fit-lines-expected.txt: Added.
        * fast/repaint/border-fit-lines.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24054 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-07-06 Tony Chang <idealisms@gmail.com>
bdash [Fri, 6 Jul 2007 10:03:38 +0000 (10:03 +0000)]
2007-07-06  Tony Chang  <idealisms@gmail.com>

        Reviewed by Maciej.

        Bug 14516: crash loading multipart/x-mixed-replace data on windows safari

        NULL check m_resourceData to prevent a crash in Safari on Windows.

        * loader/ResourceLoader.cpp:

2007-07-06  Tony Chang  <idealisms@gmail.com>

        Reviewed by Maciej.

        Bug 14516: crash loading multipart/x-mixed-replace data on windows safari

        * http/tests/multipart/resources/multipart-nodashes.php: Added.
        * http/tests/multipart/win-boundary-crash-expected.txt: Added.
        * http/tests/multipart/win-boundary-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24053 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-07-06 Jungshik Shin <jungshik.shin@gmail.com>
bdash [Fri, 6 Jul 2007 10:00:45 +0000 (10:00 +0000)]
2007-07-06  Jungshik Shin  <jungshik.shin@gmail.com>

        Reviewed by Alexey.

        - Add UTF-32 encoding support

         - fast/encoding/utf-32-big-endian-bom.html
         - fast/encoding/utf-32-big-endian-nobom.xml
         - fast/encoding/utf-32-little-endian-bom.html
         - fast/encoding/utf-32-little-endian-nobom.xml

        * loader/TextResourceDecoder.cpp:
        * platform/TextDecoder.cpp:
        * platform/TextDecoder.h:
        * platform/TextEncoding.cpp:
        * platform/TextEncoding.h:

2007-07-06  Jungshik Shin <jungshik.shin@gmail.com>

        Reviewed by Alexey.

       - test for http://bugs.webkit.org/show_bug.cgi?id=13415

        * fast/encoding/utf-32-big-endian-bom-expected.txt: Added.
        * fast/encoding/utf-32-big-endian-bom.html: Added.
        * fast/encoding/utf-32-big-endian-nobom-expected.txt: Added.
        * fast/encoding/utf-32-big-endian-nobom.xml: Added.
        * fast/encoding/utf-32-little-endian-bom-expected.txt: Added.
        * fast/encoding/utf-32-little-endian-bom.html: Added.
        * fast/encoding/utf-32-little-endian-nobom-expected.txt: Added.
        * fast/encoding/utf-32-little-endian-nobom.xml: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-07-06 Holger Hans Peter Freyther <zecke@selfish.org>
bdash [Fri, 6 Jul 2007 09:56:26 +0000 (09:56 +0000)]
2007-07-06  Holger Hans Peter Freyther  <zecke@selfish.org>

        Reviewed by Maciej.

        Start implementening RenderThemeGdk/Gtk using GtkStyle. The approach is
        to allocate one native control for each widget type. And use margins, spacing,
        style properties from the Widget. And for drawing use GtkStyle on the rect supplied.

        This should allow nice integration and be relative resource friendly. Mozilla is using
        a similiar approach. They seem to share the GdkPixmap among several operations and this
        will be an obvious candidate for improvements. Create a normally big enough GdkPixmap and
        use that for drawing and then set clip regions for cairo to make sure to not go beyond the
        width and height.

        The next steps will be to introduce states for the widgets, add more widgets, handle focus,
        and various other style attributes, honor the size and margin and use that to propagate this
        back to RenderStyle*.

        * platform/gdk/RenderThemeGdk.cpp:
        * platform/gdk/RenderThemeGdk.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24051 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-07-06 Mitz Pettel <mitz@webkit.org>
bdash [Fri, 6 Jul 2007 09:52:54 +0000 (09:52 +0000)]
2007-07-06  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Maciej.

        - fix http://bugs.webkit.org/show_bug.cgi?id=10267
          Can't scroll page downwards with scroll wheel, when pointer is on top of non-scrolling iframe

        * WebView/WebDynamicScrollBarsView.m:
        (-[WebDynamicScrollBarsView scrollWheel:]): Override the superclass
        implementation to forward the wheel event to the next responder if this view
        does not allow scrolling in the event's direction.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24050 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix build.
rwlbuis [Fri, 6 Jul 2007 09:11:45 +0000 (09:11 +0000)]
Fix build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24049 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adam.
rwlbuis [Fri, 6 Jul 2007 09:00:13 +0000 (09:00 +0000)]
    Reviewed by Adam.

        Adding a stop with value 1.0 to a gradient that has already been used has no effect

        Implement start and end stop handling differently so they are not
        in the color stop array.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix <rdar://problem/5301994> Garbled text still showing on some sites
aroben [Fri, 6 Jul 2007 08:44:11 +0000 (08:44 +0000)]
Fix <rdar://problem/5301994> Garbled text still showing on some sites


        Fix <rdar://problem/5301994> Garbled text still showing on some sites

        Replace calls to GetGlyphIndices with wkGetGlyphs.

        Reviewed by Alice.

        * platform/win/GlyphPageTreeNodeWin.cpp:
        (WebCore::GlyphPage::fill): Use wkGetGlyphs.
        * platform/win/FontDataWin.cpp:


        Update WebKitSystemInterface.{h,lib} for <rdar://problem/5301994>

        Reviewed by Alice.

        * win/include/WebKitSystemInterface/WebKitSystemInterface.h:
        * win/lib/WebKitSystemInterface.lib:
        * win/lib/WebKitSystemInterface_debug.lib:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoForgot ChangeLog description
pewtermoose [Fri, 6 Jul 2007 07:41:23 +0000 (07:41 +0000)]
Forgot ChangeLog description

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adam Roben.
pewtermoose [Fri, 6 Jul 2007 07:37:56 +0000 (07:37 +0000)]
    Reviewed by Adam Roben.

        * building/build.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Not reviewed - Windows build fix.
pewtermoose [Fri, 6 Jul 2007 07:01:56 +0000 (07:01 +0000)]
    Not reviewed - Windows build fix.

        * bridge/win/FrameWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd optional --qmake= and --qt arguments to force Qt builds and force with a
staikos [Fri, 6 Jul 2007 06:14:55 +0000 (06:14 +0000)]
Add optional --qmake= and --qt arguments to force Qt builds and force with a
specific qmake binary

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24043 268f45cc-cd09-0410-ab3c-d52691b4dbfc

staikos [Fri, 6 Jul 2007 05:12:47 +0000 (05:12 +0000)]

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
sullivan [Fri, 6 Jul 2007 03:49:50 +0000 (03:49 +0000)]

        Reviewed by Adam

        - WebCore part of fix for <rdar://problem/5315033>

        * rendering/RenderObject.h:
        replaced PaintRestrictionSelectionOnlyWhiteText with PaintRestrictionSelectionOnlyBlackText
        replaced forceWhiteText with forceBlackText

        * rendering/RenderObject.cpp:
        added a useSelectionHeight parameter, which defaults to false; this method is unimplemented
        at this level so this has no effect.

        * rendering/RenderText.h:
        * rendering/RenderText.cpp:
        added a useSelectionHeight parameter, which defaults to false. If true, use the vertical position
        and height returned by selectionRect rather than replacing it with the more tight-fitting position
        and height of the line box.

        * dom/Range.h:
        * dom/Range.cpp:
        added a useSelectionHeight parameter, which defaults to false. Passes this along to RenderObject.

        * page/Frame.h:
        renamed parameter to selectionImage
        * page/Frame.cpp:
        pass true for addLineBoxRects new useSelectionHeight parameter, so the rects returned by this new
        method will match the height that the selection would be painted here
        updated for white->black name changes

        * page/mac/FrameMac.mm:
        updated for white->black name changes

        * rendering/InlineFlowBox.cpp:
        updated for white->black name changes

        * rendering/RenderLayer.cpp:
        updated for white->black name changes

        * rendering/InlineTextBox.cpp:
        updated for white->black name changes, and actually use black instead of white. This was the goal
        of all the name changes.


        Reviewed by Adam

        - WebKit part of fix for <rdar://problem/5315033>

        * WebView/WebDocumentPrivate.h:
        new selectionImageForcingBlackText: method. selectionImageForcingWhiteText: is no longer used and was never
        in an official release of WebKit, so it could be removed, except that doing so would cause trouble for people
        using nightly WebKit with Safari 3.0 beta. So I left it in, but made it just force black text instead of
        white text, which will look different for those nightly WebKit/Safari 3.0 beta people but not break anything.

        * Misc/WebSearchableTextView.m:
        (-[WebSearchableTextView selectionImageForcingBlackText:]):
        new unimplemented protocol method for this obsolete class

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView selectionImageForcingBlackText:]):
        calls through to WebCore the way selectionImageForcingWhiteText: used to
        (-[WebHTMLView selectionImageForcingWhiteText:]):
        now just calls selectionImageForcingBlackText:, thus not working as you would expect from the name

        * WebView/WebPDFView.mm:
        (-[WebPDFView selectionImageForcingBlackText:]):
        guts of old selectionImageForcingWhiteText:, but with black substituted for white
        (-[WebPDFView selectionImageForcingWhiteText:]):
        now just calls selectionImageForcingBlackText:, thus not working as you would expect from the name

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoForgot the file extension
aroben [Fri, 6 Jul 2007 03:33:54 +0000 (03:33 +0000)]
Forgot the file extension

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoUpdated the Windows Skipped file
aroben [Fri, 6 Jul 2007 03:31:56 +0000 (03:31 +0000)]
Updated the Windows Skipped file

* win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Oliver.
andersca [Fri, 6 Jul 2007 02:28:42 +0000 (02:28 +0000)]
    Reviewed by Oliver.

        Fix layout test failures.

        * loader/FrameLoader.cpp:
        Don't make a representation if we're creating the initial document.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix Bug 14388: Input in text fields limited to 1024 characters
aroben [Fri, 6 Jul 2007 01:58:37 +0000 (01:58 +0000)]
Fix Bug 14388: Input in text fields limited to 1024 characters


2007-07-05  Alp Toker  <alp.toker@collabora.co.uk>

        Fix Bug 14388: Input in text fields limited to 1024 characters

        Slightly modified by Adam Roben.

        Reviewed by Adele.

        Test: fast/forms/input-length.html

        * html/HTMLInputElement.cpp: Bump limit to 524288.
        * html/HTMLInputElement.h:


        Added two tests for Bug 14388: Input in text fields limited to 1024 characters

        fast/forms/input-maxlength-2.html is obsoleted by

        Reviewed by Adele.

        * fast/forms/input-implicit-length-limit-expected.txt: Added.
        * fast/forms/input-implicit-length-limit.html: Added.
        * fast/forms/input-maxlength-2-expected.checksum: Removed.
        * fast/forms/input-maxlength-2-expected.png: Removed.
        * fast/forms/input-maxlength-2-expected.txt: Removed.
        * fast/forms/input-maxlength-2.html: Removed.
        * fast/forms/input-maxlength-expected.txt: Added.
        * fast/forms/input-maxlength.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd another hanging test to the Leopard Skipped file
aroben [Fri, 6 Jul 2007 01:58:27 +0000 (01:58 +0000)]
Add another hanging test to the Leopard Skipped file

Rubberstamped by Adele.

* mac/leopard/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24036 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoUpdating expected results for r24027.
justing [Fri, 6 Jul 2007 01:02:45 +0000 (01:02 +0000)]
Updating expected results for r24027.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Build fix.
andersca [Thu, 5 Jul 2007 23:12:28 +0000 (23:12 +0000)]
    Build fix.

        * loader/FrameLoader.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Forgot to add this file for the test for <rdar://problem/5303566> REGRESSION:
ggaren [Thu, 5 Jul 2007 23:04:11 +0000 (23:04 +0000)]
    Forgot to add this file for the test for <rdar://problem/5303566> REGRESSION:
        XMLHttpRequest.responseXML. Darin added a dummy file before -- here's the
        real one.

        * fast/loader/resources/plist.app:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24029 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Geoff.
weinig [Thu, 5 Jul 2007 22:56:24 +0000 (22:56 +0000)]
    Reviewed by Geoff.

        Add focus, blur and close functions to DOMWindow implementation class
        and move bindings from Window to JSDOMWindow.

        * bindings/js/JSDOMWindowCustom.cpp:
        * bindings/js/kjs_window.cpp:
        * bindings/js/kjs_window.h:
        * bindings/scripts/CodeGeneratorJS.pm: Move prototype function declaration from
        the implementation to the header.
        * page/DOMWindow.cpp:
        * page/DOMWindow.h:
        * page/DOMWindow.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24028 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
justing [Thu, 5 Jul 2007 22:52:38 +0000 (22:52 +0000)]

        Reviewed by Harrison.

        <rdar://problem/5279521> REGRESSION: In Mail, a crash occurs at WebCore::Range::startPosition() when attempting to apply alignment to selected image/text in message body

        Demonstrates bug:
        * editing/style/5279521-expected.checksum: Added.
        * editing/style/5279521-expected.png: Added.
        * editing/style/5279521-expected.txt: Added.
        * editing/style/5279521.html: Added.

        * fast/forms/radio-check-click-and-drag-expected.txt:
        * fast/forms/textarea-type-spaces-expected.txt:


        Reviewed by Harrison.

        <rdar://problem/5279521> REGRESSION: In Mail, a crash occurs at WebCore::Range::startPosition() when attempting to apply alignment to selected image/text in message body

        * editing/TextIterator.cpp:
        (WebCore::TextIterator::exitNode): Previously emitted content shouldn't have
        to come from a text node in order to emit a '\n' as we exit block containers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24027 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Geoff.
andersca [Thu, 5 Jul 2007 22:50:52 +0000 (22:50 +0000)]
    Reviewed by Geoff.

        <rdar://problem/5315284> REGRESSION: Leopard Launch Time - plugins are being accessed at startup.

        Set a response that has a MIME type of "text/html" on the document loader so WebKit won't refresh the
        plugin database looking for a plug-in that can handle the document's MIME type (which will be null anyway).

        * loader/FrameLoader.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Oliver.
andersca [Thu, 5 Jul 2007 22:34:43 +0000 (22:34 +0000)]
    Reviewed by Oliver.

        WebKit loads user style sheets too late as seen in Mail (breaks DataDetectors; Mail flashes wrong font)

        Let the document know when the user style sheet is loading so that it try not to display anything
        until the user style sheet has finished loading.

        * page/Frame.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24025 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix a leak in WebView::setToolTip
aroben [Thu, 5 Jul 2007 21:02:41 +0000 (21:02 +0000)]
Fix a leak in WebView::setToolTip

Reviewed by Beth.

* WebView.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by John.
thatcher [Thu, 5 Jul 2007 20:43:30 +0000 (20:43 +0000)]
    Reviewed by John.

        <rdar://problem/5314993> Shiira 2.1 throws an exception open a new window: -[WebInspector window]: unrecognized selector

        Add an empty implementation of this method to prevent Shiira from throwing an exception.
        Also log that this method is obsolete and the class will be removed.

        * WebInspector/WebInspector.mm:
        (-[WebInspector window]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix Bug 14143: Tooltips not displayed on Windows
aroben [Thu, 5 Jul 2007 20:16:06 +0000 (20:16 +0000)]
Fix Bug 14143: Tooltips not displayed on Windows

Reviewed by Oliver.

* WebChromeClient.cpp:
(WebChromeClient::setToolTip): Call up to WebView.
* WebView.cpp:
(WebView::WebView): Initialize m_toolTipHwnd member.
(WebView::initWithFrame): Set up the tool tip window.
(initCommonControls): Added.
(WebView::initializeToolTipWindow): Added.
(WebView::setToolTip): Set the tool tip text and enable/disable the
tool tip.
* WebView.h: Added/updated declarations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24022 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
weinig [Thu, 5 Jul 2007 18:09:57 +0000 (18:09 +0000)]
    Reviewed by Darin.

        Move JSDOMWindow overriding getOwnPropertySlot logic from KJS::Window
        up into JSDOMWindow.  No change in functionality so no testcase required.

        * bindings/js/JSDOMWindowCustom.cpp:
        * bindings/js/kjs_window.cpp:
        * bindings/js/kjs_window.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24021 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago - tweaked IDN test and checked in both Tiger results and Leopard
darin [Thu, 5 Jul 2007 17:51:29 +0000 (17:51 +0000)]
    - tweaked IDN test and checked in both Tiger results and Leopard

        * fast/encoding/idn-security.html: Changed test to only test lowercase "a" since the behavior for
        uppercase letters has changed in the new ICU. Also added code to detect the older ICU and expect
        different results.

        * fast/encoding/idn-security-expected.txt: Regenerated results.

        * mac/leopard/fast/encoding/idn-security-expected.txt: Copied from fast/encoding/idn-security-expected.txt.
        The modified.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24020 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed and Landed by Sam.
weinig [Thu, 5 Jul 2007 17:02:49 +0000 (17:02 +0000)]
    Reviewed and Landed by Sam.

        - fix bug 14465 for window.showModalDialog

        * bindings/js/kjs_window.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24019 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Mitz.
weinig [Thu, 5 Jul 2007 16:14:19 +0000 (16:14 +0000)]
    Reviewed by Mitz.

        Patch for http://bugs.webkit.org/show_bug.cgi?id=14465
        window.open() uses the literal "undefined" as the URL

        * bindings/js/kjs_window.cpp:
        (KJS::WindowFunc::callAsFunction): add checks for undefined and null values when setting the url.
        * manual-tests/open-url-undefined.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24018 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-07-05 Holger Hans Peter Freyther <zecke@selfish.org>
bdash [Thu, 5 Jul 2007 13:51:33 +0000 (13:51 +0000)]
2007-07-05  Holger Hans Peter Freyther  <zecke@selfish.org>

        Reviewed by Rob Buis.

        Rework FontData and FontPlatformData for the Gdk work to make valgrind

        Move destroying of FontConfig and Cairo objects held in FontPlatformData
        to FontData::platformDestroy. The ownership of these objects is held by
        FontData. This is following the Mac and Qt port at least.

        Currently it is possible that FontPlatformData will not create cairo resources
        in this case at least make sure the variables are initialized to 0.
        Initialize x,y of the cairo_glyph_t with zero to avoid extents.x_advance depending
        on subtracing with not defined values.

        FontPlatformData::hash. Using FontDescription is a bad idea as we don't have a clue
        about how it is packed, if holes are present, etc. The FcPattern and the m_fontMatrix
        should be good enough to describe the Font. All other objects are created using these

        Replace C-style casts with C++ casts, in this case reinterpret_cast.

        * platform/gdk/FontDataGdk.cpp:
        (WebCore::FontData::platformInit): Don't assert
        (WebCore::FontData::platformDestroy): Take over ownership
        (WebCore::FontData::platformWidthForGlyph): initialize
        (WebCore::FontData::setFont): be paranoid and assert
        * platform/gdk/FontPlatformData.h:
        (WebCore::FontPlatformData::FontPlatformData): Initialize everything
        (WebCore::FontPlatformData::hash): make valgrind happy and don't use m_fontDescription
        * platform/gdk/FontPlatformDataGdk.cpp:
        (WebCore::FontPlatformData::~FontPlatformData): FontData::platformDestroy will do this
        (WebCore::FontPlatformData::list): Don't use C-style casts.
        (WebCore::FontPlatformData::setFont): m_fontFace, m_fontMatrix, m_options might not be initialized
        (WebCore::FontPlatformData::operator==): Don't use C-style casts.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24017 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-07-05 Alp Toker <alp.toker@collabora.co.uk>
bdash [Thu, 5 Jul 2007 13:47:47 +0000 (13:47 +0000)]
2007-07-05  Alp Toker  <alp.toker@collabora.co.uk>

        Reviewed by Mark Rowe.

        GraphicsContextCairo code style cleanup

        Follow the cr naming convention for cairo_t*.
        Remove trailing whitespace.
        Replace C casts with C++ casts.
        Avoid needless casts.

        * platform/graphics/cairo/GraphicsContextCairo.cpp:
        (WebCore::GraphicsContext::strokeArc): Save/restore the graphics state.
        * platform/graphics/cairo/ImageBufferCairo.cpp:
        * platform/graphics/cairo/ImageCairo.cpp: Avoid the confusing ctxt/context naming scheme.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24016 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-07-05 Alp Toker <alp.toker@collabora.co.uk>
bdash [Thu, 5 Jul 2007 13:45:16 +0000 (13:45 +0000)]
2007-07-05  Alp Toker  <alp.toker@collabora.co.uk>

        Reviewed by Mark Rowe.

        Cairo SVGImage::nativeImageForCurrentFrame() has no return

        Return the Cairo surface from the frame cache.

        Also add a fall-through else macro with notImplemented() so that future
        ports do not make the same mistake.

        * platform/graphics/svg/SVGImage.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24015 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-07-05 Alp Toker <alp.toker@collabora.co.uk>
bdash [Thu, 5 Jul 2007 13:43:44 +0000 (13:43 +0000)]
2007-07-05  Alp Toker  <alp.toker@collabora.co.uk>

        Reviewed by Mark Rowe.

        Cairo animated GIF support is broken

        Implement ImageSource::frameIsCompleteAtIndex() to enable animated GIFs.

        * platform/graphics/cairo/ImageSourceCairo.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24014 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd a Skipped file for Leopard.
aroben [Thu, 5 Jul 2007 09:15:19 +0000 (09:15 +0000)]
Add a Skipped file for Leopard.

Reviewed by Mark.

* mac/leopard/Skipped: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24013 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWarn about tests in the Skipped file that succeeded
aroben [Thu, 5 Jul 2007 08:21:09 +0000 (08:21 +0000)]
Warn about tests in the Skipped file that succeeded

* Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoRemoved unused install-win-extras script
aroben [Thu, 5 Jul 2007 08:10:16 +0000 (08:10 +0000)]
Removed unused install-win-extras script

Rubberstamped by Mark.

* Scripts/install-win-extras: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoShow the test's extension in the results page
aroben [Thu, 5 Jul 2007 07:51:52 +0000 (07:51 +0000)]
Show the test's extension in the results page

* Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd more options for controlling the interpretation of the Skipped file
aroben [Thu, 5 Jul 2007 07:49:57 +0000 (07:49 +0000)]
Add more options for controlling the interpretation of the Skipped file

Reviewed by Mark.

* Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd --skipped-only option to run-webkit-tests
aroben [Thu, 5 Jul 2007 06:56:50 +0000 (06:56 +0000)]
Add --skipped-only option to run-webkit-tests

When this option is specified, only those tests listed in the Skipped
file are run.

Reviewed by Mark.

* Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24008 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoClean up/alphabetize the run-webkit-tests help message
aroben [Thu, 5 Jul 2007 06:42:00 +0000 (06:42 +0000)]
Clean up/alphabetize the run-webkit-tests help message

* Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoEnable a Leopard-specific Skipped list.
aroben [Thu, 5 Jul 2007 06:24:03 +0000 (06:24 +0000)]
Enable a Leopard-specific Skipped list.

Reviewed by Mark.

* Scripts/run-webkit-tests: Check for Leopard.
* Scripts/webkitdirs.pm: Added isTiger/isLeopard.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago... and it was reviewed by Adam.
bdash [Thu, 5 Jul 2007 06:12:57 +0000 (06:12 +0000)]
... and it was reviewed by Adam.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-07-04 Matt Perry <mpComplete@gmail.com>
bdash [Thu, 5 Jul 2007 06:08:56 +0000 (06:08 +0000)]
2007-07-04  Matt Perry  <mpComplete@gmail.com>

        Fix for http://bugs.webkit.org/show_bug.cgi?id=13400
        Bug 13400: REGRESSION (r20809-20814): No back entry created for navigations created by assigning to document.location

        Treat userGesture as always true for setLocation, forcing a back/forward
        entry to be created.

        * bindings/js/JSHTMLDocumentCustom.cpp:

2007-07-04  Matt Perry  <mpComplete@gmail.com>

        Test for http://bugs.webkit.org/show_bug.cgi?id=13400
        Bug 13400: REGRESSION (r20809-20814): No back entry created for navigations created by assigning to document.location

        Test that assigning to document.location in various ways adds an
        item to the back/forward list.

        * http/tests/navigation/document-location-click-expected.txt: Added.
        * http/tests/navigation/document-location-click-timeout-expected.txt: Added.
        * http/tests/navigation/document-location-click-timeout.html: Added.
        * http/tests/navigation/document-location-click.html: Added.
        * http/tests/navigation/document-location-mouseover-expected.txt: Added.
        * http/tests/navigation/document-location-mouseover.html: Added.
        * http/tests/navigation/document-location-onload-expected.txt: Added.
        * http/tests/navigation/document-location-onload.html: Added.
        * http/tests/navigation/resources/document-location.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoRestore MouseEventWithHitTestResults::targetNode's old behavior
aroben [Thu, 5 Jul 2007 06:04:56 +0000 (06:04 +0000)]
Restore MouseEventWithHitTestResults::targetNode's old behavior

Reviewed by Mark.

Fixes fast/images/imagemap-case and fast/replace/image-map.

* page/MouseEventWithHitTestResults.cpp:
(WebCore::MouseEventWithHitTestResults::targetNode): Use the inner
node, not the inner non-shared node.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoMac, Qt, and Gdk build fixes.
aroben [Thu, 5 Jul 2007 05:21:28 +0000 (05:21 +0000)]
Mac, Qt, and Gdk build fixes.

* page/EventHandler.h:
* page/gdk/EventHandlerGdk.cpp:
* page/mac/EventHandlerMac.mm:
* page/qt/EventHandlerQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix the Qt/Gdk builds.
aroben [Thu, 5 Jul 2007 03:23:48 +0000 (03:23 +0000)]
Fix the Qt/Gdk builds.

* page/gdk/EventHandlerGdk.cpp:
* page/qt/EventHandlerQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoMove tooltip logic down into WebCore so that it can be shared cross-platform
aroben [Thu, 5 Jul 2007 03:00:55 +0000 (03:00 +0000)]
Move tooltip logic down into WebCore so that it can be shared cross-platform


        Move tooltip logic down into WebCore so that it can be shared cross-platform

        Reviewed by Sam.

        * page/Chrome.cpp:
        (WebCore::Chrome::setToolTip): Added.
        * page/Chrome.h:
        * page/ChromeClient.h:
        * page/EventHandler.cpp:
        (WebCore::EventHandler::mouseMoved): Call Chrome::setToolTip.
        * platform/graphics/svg/SVGImageEmptyClients.h:

        Added stubs for Gdk:

        * platform/gdk/ChromeClientGdk.h:
        * platform/gdk/TemporaryLinkStubs.cpp:


        Move tooltip logic down into WebCore so that it can be shared cross-platform

        Reviewed by Sam.

        * WebCoreSupport/WebChromeClient.h:
        * WebCoreSupport/WebChromeClient.mm:
        (WebChromeClient::setToolTip): Added.
        * WebView/WebHTMLView.mm: Removed _resetCachedWebPreferences.
        (-[WebHTMLView _updateMouseoverWithEvent:]): Removed tooltip code.
        (-[WebHTMLView initWithFrame:]): Removed call to
        (-[WebHTMLView setDataSource:]): Ditto.
        * WebView/WebHTMLViewInternal.h: Removed showsURLsInToolTips ivar.
        * WebView/WebHTMLViewPrivate.h: Added declaration for _setTooltip so
        that WebChromeClient can call it.


        Added a stub for WebChromeClient::setToolTip

        Reviewed by Sam.

        * WebChromeClient.cpp:
        * WebChromeClient.h:


        Added a stub for ChromeClientQt::setToolTip

        Reviewed by Sam.

        * WebCoreSupport/ChromeClientQt.cpp:
        * WebCoreSupport/ChromeClientQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@24000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd/initialize Settings::showsURLsInToolTips
aroben [Thu, 5 Jul 2007 03:00:41 +0000 (03:00 +0000)]
Add/initialize Settings::showsURLsInToolTips


        Add Settings::showsURLsInToolTips

        Reviewed by Sam.

        * WebCore.exp:
        * page/Settings.cpp:
        * page/Settings.h:


        Initialize Settings::showsURLsInToolTips

        Reviewed by Sam.

        * WebView/WebView.mm:
        (-[WebView _updateWebCoreSettingsFromPreferences:]):


        Initialize Settings::showsURLsInToolTips

        Reviewed by Sam.

        * WebView.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoMove logic for calling mouseDidMoveOverElement into WebCore
aroben [Thu, 5 Jul 2007 03:00:29 +0000 (03:00 +0000)]
Move logic for calling mouseDidMoveOverElement into WebCore


        Move logic for calling mouseDidMoveOverElement into WebCore

        Reviewed by Sam.

        * page/EventHandler.cpp:
        (WebCore::EventHandler::mouseMoved): Added. Calls Chrome::mouseDidMoveOverElement.
        (WebCore::EventHandler::handleMouseMoveEvent): Now takes an optional
        HitTestResult* parameter which is used to communicate to the caller the
        node the mouse is over.
        * page/EventHandler.h:
        * page/mac/EventHandlerMac.mm:
        (WebCore::EventHandler::mouseMoved): Changed to call the overloaded
        (WebCore::EventHandler::passMouseMoveEventToSubframe): Pass hoveredNode
        through to the subframe so we can get the deepest node hovered, not
        just the node's parent frame.
        * page/win/EventHandlerWin.cpp:
        (WebCore::EventHandler::passMouseMoveEventToSubframe): Ditto.


        Removed call to mouseDidMoveOverElement now that WebCore handles it

        Reviewed by Sam.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _updateMouseoverWithEvent:]):


        Removed call to mouseDidMoveOverElement now that WebCore handles it

        Reviewed by Sam.

        * WebView.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd Chrome::mouseDidMoveOverElement
aroben [Thu, 5 Jul 2007 03:00:16 +0000 (03:00 +0000)]
Add Chrome::mouseDidMoveOverElement


        Add Chrome::mouseDidMoveOverElement

        This does the work of calling up to the ChromeClient (which will call
        the UI delegate).

        Reviewed by Sam.

        * page/Chrome.cpp:
        (WebCore::Chrome::mouseDidMoveOverElement): Added.
        * page/Chrome.h:
        * page/ChromeClient.h:
        * platform/graphics/svg/SVGImageEmptyClients.h: Updated for change to
        * platform/gdk/ChromeClientGdk.h:
        * platform/gdk/TemporaryLinkStubs.cpp:


        Add WebChromeClient::mouseDidMoveOverElement

        This is not called yet.

        Reviewed by Sam.

        * WebCoreSupport/WebChromeClient.h:
        * WebCoreSupport/WebChromeClient.mm:


        Add WebChromeClient::mouseDidMoveOverElement

        This is not called yet.

        Reviewed by Sam.

        * WebChromeClient.cpp:
        * WebChromeClient.h:


        Added a stub for ChromeClientQt::mouseDidMoveOverElement

        Reviewed by Sam.

        * WebCoreSupport/ChromeClientQt.cpp:
        * WebCoreSupport/ChromeClientQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoChanged PlatformMouseEvent to store the modifier flags of the event
aroben [Thu, 5 Jul 2007 03:00:03 +0000 (03:00 +0000)]
Changed PlatformMouseEvent to store the modifier flags of the event

Reviewed by Sam.

* platform/PlatformMouseEvent.h:
* platform/mac/PlatformMouseEventMac.mm:
* platform/win/PlatformMouseEventWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd HitTestResult::setToNonShadowAncestor
aroben [Thu, 5 Jul 2007 02:59:52 +0000 (02:59 +0000)]
Add HitTestResult::setToNonShadowAncestor

Reviewed by Sam.

* page/EventHandler.cpp:
(WebCore::EventHandler::hitTestResultAtPoint): Moved logic into
* rendering/HitTestResult.cpp:
* rendering/HitTestResult.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoChange MouseEventWithHitTestResults to hold onto a HitTestResult
aroben [Thu, 5 Jul 2007 02:59:41 +0000 (02:59 +0000)]
Change MouseEventWithHitTestResults to hold onto a HitTestResult

Reviewed by Sam.

* dom/Document.cpp:
* page/MouseEventWithHitTestResults.cpp:
* page/MouseEventWithHitTestResults.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago - take out infinity tests from the test for bug 5292262 (see below) for now...
darin [Thu, 5 Jul 2007 02:52:25 +0000 (02:52 +0000)]
    - take out infinity tests from the test for bug 5292262 (see below) for now since they
          give different results on PowerPC and Intel and are not an important part of the intent
          of this test anyway; the bug was about normal numbers, not edge cases like infinity

        If we want to test the infinity behavior, we should make a separate test later.

        * fast/objc/longlongTest-expected.txt: Removed results from infinity tests.
        * fast/objc/longlongTest.html: Removed infinity tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Not reviewed, gdk build fix.
pewtermoose [Thu, 5 Jul 2007 01:16:15 +0000 (01:16 +0000)]
    Not reviewed, gdk build fix.

        * platform/gdk/FrameGdk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
antti [Wed, 4 Jul 2007 22:54:49 +0000 (22:54 +0000)]

        Reviewed by John.

        Test for Repro crash due to infinite recursion in HTMLParser::handleError @ youos.com

        * fast/table/incomplete-table-in-fragment-hang-expected.txt: Added.
        * fast/table/incomplete-table-in-fragment-hang.html: Added.


        Reviewed by John.

        Fix Repro crash due to infinite recursion in HTMLParser::handleError @ youos.com

        It is possible to add table parts (thead etc) without table ancestor to a document fragment. If a new table element
        was added to such a part, as in

        div.innerHTML = '<tbody><table>';

        the parser error handling code would try to pop the previous table as normal. However since
        the table does not actually exist nothing would happen and parser would go to infinite recursion.

        Solution here is to pop table parts one by one when handling the error inside a fragment instead of trying to pop
        the table straight away (as it might not exist).

        * html/HTMLParser.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoPatch from Qing Zhao to fix combobox rendering
staikos [Wed, 4 Jul 2007 21:33:18 +0000 (21:33 +0000)]
Patch from Qing Zhao to fix combobox rendering

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoCompile
staikos [Wed, 4 Jul 2007 21:23:50 +0000 (21:23 +0000)]

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
weinig [Wed, 4 Jul 2007 20:04:31 +0000 (20:04 +0000)]

        Reviewed by Mitz.

        Test for http://bugs.webkit.org/show_bug.cgi?id=14504
        REGRESSION (r23573): Amazon Book Excerpt can not be viewed in recent nightly

        * fast/dom/Window/window-property-shadowing-expected.txt: Added.
        * fast/dom/Window/window-property-shadowing.html: Added.


        Reviewed by Mitz.

        Patch for http://bugs.webkit.org/show_bug.cgi?id=14504
        REGRESSION (r23573): Amazon Book Excerpt can not be viewed in recent nightly

        - Made it possible (again) to shadow window properties with local variable names.

        Test: fast/dom/Window/window-property-shadowing.html

        * bindings/js/JSDOMWindowCustom.cpp:
        * bindings/js/kjs_window.cpp:
        * bindings/scripts/CodeGeneratorJS.pm:
        * page/DOMWindow.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adam.
aliceli1 [Wed, 4 Jul 2007 18:37:11 +0000 (18:37 +0000)]
    Reviewed by Adam.

        Fixed <rdar://problem/5225119> support smart pasting on Windows

        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
            Added new files
        * editing/SmartReplace.cpp: Added.
            Added non-CF implementation placeholder
        * editing/SmartReplace.h: Added.
        * editing/SmartReplaceCF.cpp: Added.
            Added new implementation

        * bridge/win/FrameWin.cpp:
        * page/Frame.h:
        * page/mac/FrameMac.mm:
            Removed old declaration and implementation

        * editing/ReplaceSelectionCommand.cpp:
            Changed to call the new function instead of old

        * page/mac/WebCoreFrameBridge.h:
        * page/mac/WebCoreFrameBridge.mm:
            Removed old declaration and implementation
        (-[WebCoreFrameBridge smartInsertForString:replacingRange:beforeString:afterString:]):
            Changed to call the new function instead of old

        * platform/win/PasteboardWin.cpp:
            Register new clipboard format
            Set data for smartpaste format on clipboard
            Added non-stub implementation

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoReenable some code for 64-bit now that <rdar://problem/5311640> and <rdar://problem...
thatcher [Wed, 4 Jul 2007 18:33:18 +0000 (18:33 +0000)]
Reenable some code for 64-bit now that <rdar://problem/5311640> and <rdar://problem/5311690> are resolved.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoPatch from Qing Zhao: Similar to the PlatformScrollbar fixes, adjust the
staikos [Wed, 4 Jul 2007 15:15:15 +0000 (15:15 +0000)]
Patch from Qing Zhao: Similar to the PlatformScrollbar fixes, adjust the
painter to make the styler draw all subcontrols, and in this case the focus
rect, in the proper location

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-07-04 Mitz Pettel <mitz@webkit.org>
bdash [Wed, 4 Jul 2007 10:56:08 +0000 (10:56 +0000)]
2007-07-04  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Maciej.

        - fix http://bugs.webkit.org/show_bug.cgi?id=14495
          REGRESSION: Wrong cursor is displayed during drag and drop when text is selected

        No test possible because DumpRenderTree cannot query the current cursor.

        * page/EventHandler.cpp:
        (WebCore::EventHandler::selectCursor): Changed into a member function and
        added that if the last mouse down event could not have started a
        selection, then the cursor should not change to an I-beam unconditionally.
        * page/EventHandler.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2007-07-04 Holger Hans Peter Freyther <zecke@selfish.org>
bdash [Wed, 4 Jul 2007 10:52:57 +0000 (10:52 +0000)]
2007-07-04  Holger Hans Peter Freyther  <zecke@selfish.org>

        Reviewed by Rob Buis.

        A little progress in tracking dependencies.

        * WebCore.pro: Add DEPENDPATH for the Gdk port.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago * StringsNotToBeLocalized.txt: Updated for recent changes.
darin [Wed, 4 Jul 2007 03:02:32 +0000 (03:02 +0000)]
    * StringsNotToBeLocalized.txt: Updated for recent changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
thatcher [Wed, 4 Jul 2007 01:07:36 +0000 (01:07 +0000)]
    Reviewed by Darin.

        Remove HIWebView in 64-bit.

        Also disable a few calls that are now gone in 64-bit and filed these bugs:

        <rdar://problem/5311653> WebKit needs to adopt HIGetMousePosition where we used GetGlobalMouse before
        <rdar://problem/5311648> WebKit needs to move off of CopyEvent in WebBaseNetscapePluginView
        <rdar://problem/5311640> WebKit needs a new solution for HISearchWindowShow on 64-bit

        * Carbon/CarbonUtils.m:
        * Carbon/CarbonWindowAdapter.m:
        * Carbon/CarbonWindowContentView.m:
        * Carbon/CarbonWindowFrame.m:
        * Carbon/HIViewAdapter.m:
        * Carbon/HIWebView.m:
        * Configurations/WebKit.xcconfig:
        * Plugins/WebBaseNetscapePluginView.mm:
        (+[WebBaseNetscapePluginView getCarbonEvent:]):
        * WebKit.LP64.exp: Added.
        * WebView/WebView.mm:
        (-[WebView _searchWithSpotlightFromMenu:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoDisable the strict aliasing warning until <rdar://problem/5311093> is fixed.
thatcher [Wed, 4 Jul 2007 01:04:11 +0000 (01:04 +0000)]
Disable the strict aliasing warning until <rdar://problem/5311093> is fixed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago64-bit build fix.
thatcher [Wed, 4 Jul 2007 01:02:32 +0000 (01:02 +0000)]
64-bit build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFixed update-webkit-localizable-strings to work with new extract-localizable-strings
aroben [Wed, 4 Jul 2007 00:58:41 +0000 (00:58 +0000)]
Fixed update-webkit-localizable-strings to work with new extract-localizable-strings

Got rid of extract-webkit-localizable-strings because it was trying to
do update-webkit-localizable-strings' job.

Rubberstamped by Darin.

* Scripts/extract-webkit-localizable-strings: Removed.
* Scripts/update-webkit-localizable-strings: Renamed from

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoMerge the Windows and Mac localized strings and exceptions files
aroben [Wed, 4 Jul 2007 00:40:57 +0000 (00:40 +0000)]
Merge the Windows and Mac localized strings and exceptions files


        Merge the Windows and Mac localized strings and exceptions files

        Reviewed by Darin and Anders.

        * English.lproj/Localizable.strings: Added Windows strings.
        * StringsNotToBeLocalized.txt: Renamed from WebKit/English.lproj/StringsNotToBeLocalized.txt.


        Merge the Windows and Mac localized strings and exceptions files

        Reviewed by Darin and Anders.

        * English.lproj/Localizable.strings: Added Mac strings.
        * English.lproj/StringsNotToBeLocalized.txt: Removed.


        Modify scripts to keep Mac/Windows localized strings in sync

        extract-webkit-localizable-strings now handles extracting strings from
        both the Mac and Windows WebKit ports and updating their respective
        Localizable.strings files. extract-localizable-strings is now really a
        piece of plumbing rather than a top-level tool.

        Reviewed by Darin and Anders.

        * Scripts/extract-localizable-strings: Changed to handle multiple
        * Scripts/extract-webkit-localizable-strings: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Removed printf I accidently left in.
adele [Wed, 4 Jul 2007 00:29:31 +0000 (00:29 +0000)]
    Removed printf I accidently left in.

        * Misc/WebNSURLExtras.m: (mapHostNames):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
darin [Wed, 4 Jul 2007 00:04:19 +0000 (00:04 +0000)]

        Reviewed by Tim Hatcher.

        - tests for <rdar://problem/5221297> Font family name in the cssText for a DOMCSSStyleDeclaration needs quotes

        * editing/style/font-family-with-space-expected.txt: Added.
        * editing/style/font-family-with-space.html: Added.

        * fast/inspector/style-expected.txt: Updated expected results to expect "Lucida Grande" in quote marks.


        Reviewed by Tim Hatcher.

        - fix <rdar://problem/5221297> Font family name in the cssText for a DOMCSSStyleDeclaration needs quotes

        Test: editing/style/font-family-with-space.html

        * css/FontFamilyValue.cpp:
        (WebCore::isValidCSSIdentifier): Added. Implements the same rule that the CSS lexer does.
        (WebCore::quoteStringIfNeeded): Changed to call isValidCSSIdentifier instead of just
        checking for a leading "#" character.
        * editing/markup.cpp:
        (WebCore::escapeTextForMarkup): Changed to take a String parameter for better efficiency.
        (WebCore::renderedText): Changed to return a String for better efficiency.
        (WebCore::addNamespace): Updated to pass String to escapeTextForMarkup.
        (WebCore::startMarkup): Updated to pass String to escapeTextForMarkup. Added missing call
        to escapeTextForMarkup in the special case for the style property.
        (WebCore::createMarkup): Changed from single quotes to double quotes and also added missing
        call to escapeTextForMarkup in two special cases for the style property.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoUpdating comment
adele [Tue, 3 Jul 2007 23:54:08 +0000 (23:54 +0000)]
Updating comment

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
weinig [Tue, 3 Jul 2007 23:19:14 +0000 (23:19 +0000)]
    Reviewed by Darin.

        Twelfth round of fixes for implicit 64-32 bit conversion errors.

        - Add casts and accompanying FIXMEs to avoid remaining compiler errors.

        * WebCore.xcodeproj/project.pbxproj:
        * loader/FrameLoader.cpp:
        * loader/FrameLoader.h:
        * loader/ResourceLoader.cpp:
        * platform/network/mac/ResourceHandleMac.mm:
        (-[WebCoreResourceHandleAsDelegate connection:didReceiveData:lengthReceived:]):
        (-[WebCoreResourceHandleAsDelegate connection:willStopBufferingData:]):
        * platform/network/mac/ResourceResponseMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
adele [Tue, 3 Jul 2007 23:16:02 +0000 (23:16 +0000)]

        Reviewed by Darin.

        Test for: <rdar://problem/5292988> domain names shouldn't contain ignorable characters

        * fast/encoding/idn-security-expected.txt: Added.
        * fast/encoding/idn-security.html: Added.
        * win/Skipped: Blocked by <rdar://problem/5301954>.


        Reviewed by Darin.

        Fix for: <rdar://problem/5292988> domain names shouldn't contain ignorable characters

        * Misc/WebNSURLExtras.m:
        (isLookalikeCharacter): Renamed.  Also excludes any non-printable character,
         any character considered as whitespace that isn't already converted to a space by ICU, any ignorable character,
         and any character excluded in Mozilla's blacklist: http://kb.mozillazine.org/Network.IDN.blacklist_chars


        Reviewed by Darin.

        Extended DumpRenderTree to test encoding and decoding host names.

        * DumpRenderTree/DumpRenderTree.m:
        (+[LayoutTestController isSelectorExcludedFromWebScript:]): Added cases for encodeHostName and decodeHostName.
        (+[LayoutTestController webScriptNameForSelector:]): ditto.
        (-[LayoutTestController decodeHostName:]): Added.
        (-[LayoutTestController encodeHostName:]): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
weinig [Tue, 3 Jul 2007 22:51:56 +0000 (22:51 +0000)]
    Reviewed by Darin.

        Eleventh round of fixes for implicit 64-32 bit conversion errors.

        Add functions to test long long and unsigned long long.

        * DumpRenderTree/DumpRenderTree.m:
        (+[LayoutTestController isSelectorExcludedFromWebScript:]):
        (+[LayoutTestController webScriptNameForSelector:]):
        (-[LayoutTestController objCLongLongRoundTrip:]):
        (-[LayoutTestController objCUnsignedLongLongRoundTrip:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
weinig [Tue, 3 Jul 2007 22:37:15 +0000 (22:37 +0000)]

        Reviewed by Darin.

        Eleventh round of fixes for implicit 64-32 bit conversion errors.

        - Fixes a real bug where where we were setting long long and unsigned long long
          values to a long field.

        * bindings/objc/objc_utility.mm:


        Reviewed by Darin.

        Eleventh round of fixes for implicit 64-32 bit conversion errors.

        * fast/objc: Added.
        * fast/objc/longlongTest-expected.txt: Added.
        * fast/objc/longlongTest.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Maciej.
darin [Tue, 3 Jul 2007 22:02:27 +0000 (22:02 +0000)]
    Reviewed by Maciej.

        - fix <rdar://problem/5310848> WebDataSource lifetime problem -- may be cause of the leaks seen on the buildbot

        * WebView/WebDataSource.mm:
        (-[WebDataSourcePrivate dealloc]): Added a call to the new detachDataSource function.
        (-[WebDataSourcePrivate finalize]): Ditto.

        * WebView/WebDocumentLoaderMac.h: Added detachDataSource function to be used when the
        WebDataSource is deallocated. Added retain/releaseDataSource helper functions to be
        used to retain and release the data source object. Replaced the m_hasEverBeenDetached
        boolean with a more primitive and hence easier to understand m_isDataSourceRetained boolean.

        * WebView/WebDocumentLoaderMac.mm:
        (WebDocumentLoaderMac::WebDocumentLoaderMac): Initialize m_isDataSourceRetained to false.
        (WebDocumentLoaderMac::setDataSource): Call retainDataSource instead of calling HardRetain
        on the dataSource parameter. Also updated a comment.
        (WebDocumentLoaderMac::attachToFrame): Call retainDataSource unconditionally rather than
        trying to use m_hasEverBeenDetached to decide if a retain is needed. Also got rid of an
        assertion that m_loadingResources is empty -- not important any more.
        (WebDocumentLoaderMac::detachFromFrame): Call releaseDataSource instead of using
        HardRelease, but only if m_loadingResources is empty. If it's non-empty, then we'll
        do the releaseDataSource later in decreaseLoadCount.
        (WebDocumentLoaderMac::increaseLoadCount): Call retainDataSource unconditionally
        rather than calling HardRetain only if the old set of resources was empty.
        (WebDocumentLoaderMac::decreaseLoadCount): Call releaseDataSource if m_loadingResources
        is empty and we're not attached to a frame. If we are attached to a frame, then
        we'll do the releaseDataSource later in detachFromFrame.
        (WebDocumentLoaderMac::retainDataSource): Added. Calls CFRetain, but only if the data
        source is not already retained (according to the boolean).
        (WebDocumentLoaderMac::releaseDataSource): Added. Calls CFRelease, but only if the data
        source is currently retained (according to the boolean).
        (WebDocumentLoaderMac::detachDataSource): Added. Sets m_dataSource to nil. Since this
        is only called from WebDataSource's dealloc and finalize methods, it won't ever be called
        when the m_isDataSourceRetained boolean is true.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adam.
andersca [Tue, 3 Jul 2007 22:01:29 +0000 (22:01 +0000)]
    Reviewed by Adam.

        Nothing shown in plugin area when trying to play content using the DivX plugin

        Defer calling SetWindow for the DivX plugin, just like we do with the WMP plugin.

        * plugins/win/PluginViewWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Brady Eidson.
weinig [Tue, 3 Jul 2007 21:35:25 +0000 (21:35 +0000)]
    Reviewed by Brady Eidson.

        Tenth round of fixes for implicit 64-32 bit conversion errors.

        - Add explicit casts.

        * kjs/dtoa.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago - forgot to check in one file in the fix for <rdar://problem/5307880>
darin [Tue, 3 Jul 2007 21:21:56 +0000 (21:21 +0000)]
    - forgot to check in one file in the fix for <rdar://problem/5307880>
          some classes need finalize methods because of non-trivial work done in dealloc methods

        * WebView/WebView.mm: (-[WebViewPrivate finalize]): Delete identifierMap so it doesn't leak.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Brady Eidson.
weinig [Tue, 3 Jul 2007 21:17:44 +0000 (21:17 +0000)]
    Reviewed by Brady Eidson.

        Ninth round of fixes for implicit 64-32 bit conversion errors.

        - Fix function signature to use unsigned long instead of unsigned long long.

        * loader/ProgressTracker.cpp:
        * loader/ProgressTracker.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23953 268f45cc-cd09-0410-ab3c-d52691b4dbfc