WebKit-https.git
14 years agoWebKitSite:
ddkilzer [Thu, 22 Mar 2007 04:11:19 +0000 (04:11 +0000)]
WebKitSite:

        Reviewed by Adam.

        * building/checkout.html: Add link to svn 1.4 client for Mac OS X 10.4.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Fixed bad version of results that I check in accidentally.
ggaren [Thu, 22 Mar 2007 04:09:38 +0000 (04:09 +0000)]
    Fixed bad version of results that I check in accidentally.

        * svg/dom/string-list-parser-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Beth Dakin.
ggaren [Thu, 22 Mar 2007 04:05:28 +0000 (04:05 +0000)]
    Reviewed by Beth Dakin.

        A little cleanup based work I've been doing on the SVG parsers.

        * ksvg2/svg/SVGParserUtilities.h:
        (WebCore::skipString):
        * ksvg2/svg/SVGPreserveAspectRatio.cpp: Moved checkString into
        SVGParserUtilities.h, so it could be with all its friends. Renamed
        "checkString" to "skipString" to match the rest of the code and to be
        clear about which functions move the buffer pointer.
        (WebCore::SVGPreserveAspectRatio::parsePreserveAspectRatio):
        * ksvg2/svg/SVGTransformable.cpp:
        (WebCore::SVGTransformable::parseTransformAttribute): Changed gotos into
        returns. Removed unnecessary magic number.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
ggaren [Thu, 22 Mar 2007 03:50:06 +0000 (03:50 +0000)]
LayoutTests:

        Reviewed by Beth Dakin.

        Added fuzz tester for the SVG rgb color parser.

        * svg/dom/rgb-color-parser-expected.txt: Added.
        * svg/dom/rgb-color-parser.html: Added.

WebCore:

        Reviewed by Beth Dakin.

        Fixed <rdar://problem/5078471> SVG rgb color parser runs past end of
        buffer when running fuzzing test

        * ksvg2/svg/SVGColor.cpp:
        (WebCore::parseNumberOrPercent): Check for past the end condition.
        (WebCore::SVGColor::colorFromRGBColorString): Reversed "read past end
        of buffer, then check if you're past the end" logic.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
ggaren [Thu, 22 Mar 2007 03:37:25 +0000 (03:37 +0000)]
LayoutTests:

        Reviewed by Beth Dakin.

        Added fuzz tester for the path parser.

        * svg/dom/path-parser-expected.txt: Added.
        * svg/dom/path-parser.html: Added.

WebCore:

        Reviewed by Beth Dakin.

        Fixed <rdar://problem/5079410> SVG path parser hangs, exhausts memory when
        running fuzzer test

        * ksvg2/svg/SVGParserUtilities.cpp:
        (WebCore::SVGPathParser::parseSVG): Don't assume that extra digits are
        always preceded by an 'M' or an 'm'.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Beth Dakin.
ggaren [Thu, 22 Mar 2007 03:28:59 +0000 (03:28 +0000)]
    Reviewed by Beth Dakin.

        Added fuzz tester for the string list parser.

        * svg/dom/string-list-parser-expected.txt: Added.
        * svg/dom/string-list-parser.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Beth Dakin.
ggaren [Thu, 22 Mar 2007 03:26:16 +0000 (03:26 +0000)]
    Reviewed by Beth Dakin.

        Added fuzz tester for the length list parser.

        * svg/dom/length-list-parser-expected.txt: Added.
        * svg/dom/length-list-parser.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Beth Dakin.
ggaren [Thu, 22 Mar 2007 03:21:01 +0000 (03:21 +0000)]
    Reviewed by Beth Dakin.

        Factored randomizing functions into their own file, in preparation for future
        tests that rely on them.

        * svg/dom/resources/scripted-random.js: Added.
        * svg/dom/transform-parser.html: Factored out scripted-random.js, added
        a small string that increases the normal-seemingness of the last test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago New results after rolling out r19828 in r20352.
thatcher [Thu, 22 Mar 2007 03:12:10 +0000 (03:12 +0000)]
    New results after rolling out r19828 in r20352.

        * fast/overflow/scrollRevealButton-expected.checksum:
        * fast/overflow/scrollRevealButton-expected.png:
        * fast/overflow/scrollRevealButton-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adam
sullivan [Thu, 22 Mar 2007 01:42:53 +0000 (01:42 +0000)]
    Reviewed by Adam

        - fixed <rdar://problem/5079700> REGRESSION (r19702): Name/password aren't autofilled
          or saved for .Mac homepage login

        * page/mac/FrameMac.mm:
        (WebCore::Frame::searchForLabelsBeforeElement):
        don't count empty strings as valid results

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by darin
justing [Thu, 22 Mar 2007 00:48:46 +0000 (00:48 +0000)]
    Reviewed by darin

        * editing/markup.cpp:
        (WebCore::styleFromMatchedRulesAndInlineDecl):
        Release the RefPtr to avoid increasing/decreasing
        the refcount unnecessarily.
        (WebCore::propertyMissingOrEqualToNone): Added and used
        instead of converting values to strings.
        (WebCore::elementHasTextDecorationProperty):
        (WebCore::createMarkup):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
thatcher [Thu, 22 Mar 2007 00:31:46 +0000 (00:31 +0000)]
    Reviewed by Darin.

        <rdar://problem/5076599> JavaScriptCore has a weak export (vtable for KJS::JSCell)

        * JavaScriptCore.exp: Remove __ZTVN3KJS6JSCellE.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - some specs to propose by email
mjs [Wed, 21 Mar 2007 23:59:24 +0000 (23:59 +0000)]
    - some specs to propose by email

        * specs/HTML_Timed_Media_Elements.html: Added.
        * specs/Timed_Media_CSS.html: Added.
        * specs/Timed_Media_Elements-Open_Issues.html: Added.
        * specs/mediaelement.css: Added.
        * specs/movie-status-states.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
justing [Wed, 21 Mar 2007 23:58:00 +0000 (23:58 +0000)]
LayoutTests:

        Reviewed by oliver

        <rdar://problem/5075944>
        REGRESSION: Partially selected underlined content pastes as plain text

        Tests for the bug:
        * editing/pasteboard/5075944-expected.checksum: Added.
        * editing/pasteboard/5075944-expected.png: Added.
        * editing/pasteboard/5075944-expected.txt: Added.
        * editing/pasteboard/5075944.html: Added.
        Tests that the element that has the text-decoration
        and all its descendants down to the common ancestor
        are included in the copied markup (instead of the
        text-decoration property being treated as though it
        were inheritable and placed on the style span wrapper):
        * editing/pasteboard/5075944-2-expected.checksum: Added.
        * editing/pasteboard/5075944-2-expected.png: Added.
        * editing/pasteboard/5075944-2-expected.txt: Added.
        * editing/pasteboard/5075944-2.html: Added.
        Tests that moveParagraphs gets underlining right (it doesn't
        use annotation):
        * editing/pasteboard/5075944-3-expected.checksum: Added.
        * editing/pasteboard/5075944-3-expected.png: Added.
        * editing/pasteboard/5075944-3-expected.txt: Added.
        * editing/pasteboard/5075944-3.html: Added.

WebCore:

        Reviewed by oliver

        <rdar://problem/5075944>
        REGRESSION: Partially selected underlined content pastes as plain text

        We stopped adding markup for all the ancestors
        of lastClosed up to the commonAncestorBlock
        because it was adding a lot of unnecessary markup.
        This caused us to lose underlining when copying a
        partially selected underlined element (even though
        we put all styles that the copied markup inherits
        into a style span, because the text-decoration
        isn't inheritable).

        * editing/markup.cpp:
        (WebCore::styleFromMatchedRulesAndInlineDecl): Moved
        code here.
        (WebCore::elementHasTextDecorationProperty): Added.
        (WebCore::createMarkup): If the copied markup has a
        text-decoration because some common ancestor has
        a text-decoration property set, include that ancestor
        and all its descendants in the copied markup.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-03-21 Oliver Hunt <oliver@apple.com>
oliver [Wed, 21 Mar 2007 21:59:06 +0000 (21:59 +0000)]
2007-03-21  Oliver Hunt  <oliver@apple.com>

        Reviewed by Antti.
WebCore:
        Update a few SVG attribute parsers to be more defensive against
        reading beyond the end of input.

        Fixes rdar://problem/5077218 -- SVG transform parser runs past
        end of buffer when running fuzzing test

        * ksvg2/svg/SVGParserUtilities.cpp:
        (WebCore::SVGPathParser::parseSVG):
        * ksvg2/svg/SVGParserUtilities.h:
        (WebCore::skipOptionalSpacesOrDelimiter):
        * ksvg2/svg/SVGTransformable.cpp:
        (WebCore::parseTransformParamList):
        (WebCore::SVGTransformable::parseTransformAttribute):

LayoutTests:
        Fuzz test for SVG transform parser

        * svg/dom/transform-parser-expected.txt: Added.
        * svg/dom/transform-parser.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Mitz.
ap [Wed, 21 Mar 2007 19:06:02 +0000 (19:06 +0000)]
    Reviewed by Mitz.

        http://bugs.webkit.org/show_bug.cgi?id=13140
        Crash after loading SVG fragment with XMLHttpRequest (Yosemite Map Geology Layer)

        Test: svg/carto.net/frameless-svg-parse-error.html

        * ksvg2/misc/SVGDocumentExtensions.cpp:
        (WebCore::SVGDocumentExtensions::reportError): Added a null check.
        (WebCore::SVGDocumentExtensions::reportWarning): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Geoff.
adele [Wed, 21 Mar 2007 17:55:19 +0000 (17:55 +0000)]
    Reviewed by Geoff.

        * API/JSStringRef.cpp: (JSStringIsEqual): Added JSLock.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix the compile when USE(MULTIPLE_THREADS) isn't defined
zack [Wed, 21 Mar 2007 09:30:26 +0000 (09:30 +0000)]
Fix the compile when USE(MULTIPLE_THREADS) isn't defined

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Fix for <rdar://problem/5072678> Crash in
bdakin [Wed, 21 Mar 2007 07:24:22 +0000 (07:24 +0000)]
    Fix for <rdar://problem/5072678> Crash in
        RenderLayer::scrollRectToVisible with MallocScribble enabled

        I tried to fix this earlier today but my fix caused a regression
        scrolling through RSS pages. It turns out that sometimes scroll
        events need to propagate immediately, and sometimes they must be
        delayed or they risk deleting objects that are expected to be
        around after the event has propagated. Mitz's original fix made
        sheduleEvent() only delay events that happen during layout. This
        fix marks two other places in addition to layout where events also
        need to be delayed. These two places are places that were marked
        with FIXMEs that Mitz removed in his original patch. (There was a
        third FIXME in RenderLayer::updateScrollInfoAfterLayout() but that
        case is only called through layout and is covered by Mitz's
        original patch.)

        * page/FrameView.cpp:
        (WebCore::FrameView::~FrameView): Added assertion.
        (WebCore::FrameView::layout): Call new functions to increment and
        decrement the queued events count.
        (WebCore::FrameView::pauseScheduledEvents):
        (WebCore::FrameView::resumeScheduledEvents): Decrement queued
        events count and dispatch events if the count has zeroed.
        * page/FrameView.h:
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::scrollRectToVisible):
        (WebCore::Marquee::start):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-03-21 Mitz Pettel <mitz@webkit.org>
bdash [Wed, 21 Mar 2007 07:21:37 +0000 (07:21 +0000)]
2007-03-21  Mitz Pettel  <mitz@webkit.org>

        Reviewed by John Sullivan.

        - fix http://bugs.webkit.org/show_bug.cgi?id=13130
          REGRESSION: Sometimes a frame resizer keeps following the mouse after mouseup

        * rendering/RenderFrameSet.cpp:
        (WebCore::RenderFrameSet::userResize): Reordered the code to allow resizing
        to be terminated by a mouseup event regardless of whether the frameset needs
        layout.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Oliver.
andersca [Wed, 21 Mar 2007 05:46:49 +0000 (05:46 +0000)]
    Reviewed by Oliver.

        <rdar://problem/5077252>
        In NetNewsWire 2.1.1 and 3.0d62, a crash occurs after triple-clicking a link on the page

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::load):
        Move the m_inStopAllLoaders check to the load function that's common for loading a request or substitute data.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Anders
beidson [Wed, 21 Mar 2007 05:39:57 +0000 (05:39 +0000)]
    Reviewed by Anders

        <rdar://problem/5073391> and http://bugs.webkit.org/show_bug.cgi?id=13137

        Crash in IconDatabase when private browsing is enabled.

        The problem was caused by http://trac.webkit.org/projects/webkit/changeset/20182
        which changed many uses of char[] and Vector<char> to SharedBuffer.  The patch
        tended to literally replace a Vector<char> with RefPtr<SharedBuffers> but forgot
        to enforce the concept that Vector<char>'s always exist, whereas RefPtr<SharedBuffers>
        can be null.  This led to derefs.

        I took the opportunity to rework the iconDB functions to live in a SharedBuffer
        world, as that didn't exist when they were originally written - now they just return
        SharedBuffers instead of taking a Vector<char>& as a parameter

        * loader/icon/IconDatabase.cpp:
        (WebCore::IconDatabase::imageDataForIconURL): Return a SharedBuffer
        (WebCore::IconDatabase::iconForPageURL): Null check the SharedBuffer before asking
          it if it's empty
        (WebCore::IconDatabase::imageDataForIconURLQuery): Return a new SharedBuffer

        * loader/icon/IconDatabase.h: Return SharedBuffer's instead of taking Vector<char>&'s

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Rubberstamped by Adele.
aroben [Wed, 21 Mar 2007 01:24:02 +0000 (01:24 +0000)]
    Rubberstamped by Adele.

        Roll out r20348 because it was causing crashes.

        * page/FrameView.cpp:
        (WebCore::FrameViewPrivate::FrameViewPrivate):
        (WebCore::FrameView::layout):
        (WebCore::FrameView::scheduleEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-03-20 Matt Lilek <pewtermoose@gmail.com>
bdash [Wed, 21 Mar 2007 00:46:43 +0000 (00:46 +0000)]
2007-03-20  Matt Lilek  <pewtermoose@gmail.com>

        Reviewed by Darin.

        Clear up the steps necessary to get a patch landed.

        http://bugs.webkit.org/show_bug.cgi?id=12877 - Bug 12877: "Contributing Code" page could be clearer
        http://bugs.webkit.org/show_bug.cgi?id=8690 - Bug 8690: Contributing code doesn't mention what to do with new files

        * coding/contributing.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoBuild fix.
thatcher [Wed, 21 Mar 2007 00:11:36 +0000 (00:11 +0000)]
Build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Kevin Decker.
thatcher [Tue, 20 Mar 2007 23:57:09 +0000 (23:57 +0000)]
    Reviewed by Kevin Decker.

        Rolling out part of r19828 that caused a scrolling regression in Mail.

        <rdar://problem/4820817> Message jumps around when trying to select text

        * platform/mac/ScrollViewMac.mm:
        (WebCore::ScrollView::visibleContentRect):
        (WebCore::ScrollView::updateContents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Geoff and Adam.
mjs [Tue, 20 Mar 2007 23:57:01 +0000 (23:57 +0000)]
    Reviewed by Geoff and Adam.

        - make USE(MULTIPLE_THREADS) support more portable
        http://bugs.webkit.org/show_bug.cgi?id=13069

        - fixed a threadsafety bug discovered by testing this

        - enhanced threadsafety assertions in collector

        * API/JSCallbackObject.cpp:
        (KJS::JSCallbackObject::~JSCallbackObject): This destructor can't
        DropAllLocks around the finalize callback, because it gets called
        from garbage collection and we can't let other threads collect!

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * kjs/JSLock.cpp:
        (KJS::JSLock::currentThreadIsHoldingLock): Added new function
        to allow stronger assertions than just that the lock is held
        by some thread (you can now assert that the current thread is
        holding it, given the new JSLock design).
        * kjs/JSLock.h:
        * kjs/collector.cpp: Refactored for portability plus added some
        stronger assertions.
        (KJS::Collector::allocate):
        (KJS::currentThreadStackBase):
        (KJS::Collector::registerAsMainThread):
        (KJS::onMainThread):
        (KJS::PlatformThread::PlatformThread):
        (KJS::getCurrentPlatformThread):
        (KJS::Collector::Thread::Thread):
        (KJS::destroyRegisteredThread):
        (KJS::Collector::registerThread):
        (KJS::Collector::markCurrentThreadConservatively):
        (KJS::suspendThread):
        (KJS::resumeThread):
        (KJS::getPlatformThreadRegisters):
        (KJS::otherThreadStackPointer):
        (KJS::otherThreadStackBase):
        (KJS::Collector::markOtherThreadConservatively):
        (KJS::Collector::markStackObjectsConservatively):
        (KJS::Collector::protect):
        (KJS::Collector::unprotect):
        (KJS::Collector::collectOnMainThreadOnly):
        (KJS::Collector::markMainThreadOnlyObjects):
        (KJS::Collector::collect):
        * kjs/collector.h:
        * wtf/FastMalloc.cpp:
        (WTF::fastMallocSetIsMultiThreaded):
        * wtf/FastMallocInternal.h:
        * wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by John
beidson [Tue, 20 Mar 2007 23:24:14 +0000 (23:24 +0000)]
    Reviewed by John

        <rdar://5071341> - Crash in IconLoader::finishLoading()

        Though the reproducibility of the crash is still elusive, there's been a crasher likely uncovered
        Hyatt's recent caching changings to the IconLoader.  This crash tends to hit on sites without favicons,
        that serve up complex 404 pages, often when the load is cancelled or redirected.  Occasionally, it *seems*
        the IconLoader is getting failed/cancelled twice.

        This patch adds some assertions and a "fail gracefully in a release build" check that will have to
        serve us until we know more about the cause.

        * loader/icon/IconLoader.cpp:
        (WebCore::IconLoader::didFail): Add an assertion to catch this case
        (WebCore::IconLoader::finishLoading): Add an assertion to catch the case, and fail
          gracefully in debug builds.  Also add an efficiency check to not commit to the DB if there is no
          IconURL

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
antti [Tue, 20 Mar 2007 22:01:08 +0000 (22:01 +0000)]
    Reviewed by Darin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=10747
        REGRESSION: Using two fingers on a trackpad to scroll inside a text area makes the whole page move
        <rdar://problem/5045710>

        Eat smooth scroll events in WebCore if pointer is over scrollable area. Not
        really a good fix, smooth scrolling should be supported properly. It should do for now.

        * page/EventHandler.cpp:
        (WebCore::EventHandler::handleWheelEvent):
        * rendering/RenderListBox.cpp:
        (WebCore::RenderListBox::isScrollable):
        * rendering/RenderListBox.h:
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::isScrollable):
        * rendering/RenderObject.h:
        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::isScrollable):
        * rendering/RenderTextControl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Geoff.
bdakin [Tue, 20 Mar 2007 20:13:37 +0000 (20:13 +0000)]
    Reviewed by Geoff.

        Covered by existing test case.

        Fix for <rdar://problem/5072678> Crash in
        RenderLayer::scrollRectToVisible with MallocScribble enabled

        This removes some code that was added with http://bugs.webkit.org/
        show_bug.cgi?id=8360. This code was not needed to fix that bug, but
        the idea behind it was that there are times when it is safe for
        scheduleEvent() to propagate the event immediately. The
        MallocScribble crash revealed that this assumption was a bit too
        broad; the cause of the crash was that we were propagating events
        immediately when it was not safe. Mitz and I discussed this online
        and we agree that the safest solution is to revert to the old
        behavior here, and always delay the propagation of the event.

        * page/FrameView.cpp:
        (WebCore::FrameViewPrivate::FrameViewPrivate):
        (WebCore::FrameView::layout):
        (WebCore::FrameView::scheduleEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by John Sullivan
beidson [Tue, 20 Mar 2007 19:56:23 +0000 (19:56 +0000)]
    Reviewed by John Sullivan

        Add some very helpful logging to the IconLoader's SubresourceLoaderClient impl.

        * loader/icon/IconLoader.cpp:
        (WebCore::IconLoader::didReceiveResponse):
        (WebCore::IconLoader::didReceiveData):
        (WebCore::IconLoader::didFail):
        (WebCore::IconLoader::didFinishLoading):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
justing [Tue, 20 Mar 2007 19:09:53 +0000 (19:09 +0000)]
LayoutTests:

        Reviewed by darin

        <rdar://problem/5071074>
        REGRESSION: Links are pasted as plain text at certain positions

        * editing/pasteboard/5071074-2-expected.checksum: Added.
        * editing/pasteboard/5071074-2-expected.png: Added.
        * editing/pasteboard/5071074-2-expected.txt: Added.
        * editing/pasteboard/5071074-2.html: Added.

WebCore:

        Reviewed by darin

        <rdar://problem/5071074>
        REGRESSION: Links are pasted as plain text at certain positions

        moveParagraphs calls createMarkup without annotation, which leaves
        out anchor elements that aren't fully selected.

        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::moveParagraphs): We don't want
        createMarkup to do full annotation here.  Doing so could include
        special ancestor blocks, which would prevent the copied content
        from appearing in the destination paragraph when it's re-inserted.
        Annotation would also inline styles from style sheets,  which is
        unnecessary because the content is being moved to the same
        document it's being moved from.
        Added a new bool to createMarkup that when true allows markup for
        special ancestors as long as they are inline when annotation is off.
        * editing/markup.cpp:
        (WebCore::createMarkup): Don't set specialCommonAncestor if annotation
        is off, unless it's inline and we've been told it's ok to include such
        elements.
        * editing/markup.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
ap [Tue, 20 Mar 2007 17:21:07 +0000 (17:21 +0000)]
    Reviewed by Darin.

        http://bugs.webkit.org/show_bug.cgi?id=12497
        Implement XPath result ordering.

WebCore:
        XPath::NodeVector typedef is replaced with a real XPath::NodeSet class that knows how
        to sort itself, and can remember whether it has been already sorted.

        * CMakeLists.txt:
        * WebCore.pro:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        Added XPathNodeSet files.

        * xml/XPathExpression.cpp: Fixed includes.

        * xml/XPathFunctions.cpp:
        (WebCore::XPath::FunId::evaluate): Mark the resulting node-set as unsorted.
        (WebCore::XPath::FunLocalName::evaluate): Replacing NodeVector with NodeSet.
        (WebCore::XPath::FunNamespaceURI::evaluate): Ditto.
        (WebCore::XPath::FunName::evaluate): Ditto.
        (WebCore::XPath::FunCount::evaluate): Ditto.
        (WebCore::XPath::FunSum::evaluate): Ditto.

        * xml/XPathNodeSet.cpp: Added.
        (WebCore::XPath::parentWithDepth):
        (WebCore::XPath::sortBlock):
        (WebCore::XPath::NodeSet::sort): Sort the node-set in document order.
        (WebCore::XPath::NodeSet::reverse): Reverse the order (useful for making axes such as
        parent or ancestor sorted).
        (WebCore::XPath::NodeSet::firstNode): Returns the first node in document order; currently
        implemented via fully sorting the node-set, but this can obviously be optimized.
        (WebCore::XPath::NodeSet::anyNode): Added for symmetry with firstNode().

        * xml/XPathNodeSet.h: Added.
        (WebCore::XPath::NodeSet::NodeSet):
        (WebCore::XPath::NodeSet::operator=):
        (WebCore::XPath::NodeSet::size):
        (WebCore::XPath::NodeSet::isEmpty):
        (WebCore::XPath::NodeSet::operator[]):
        (WebCore::XPath::NodeSet::reserveCapacity):
        (WebCore::XPath::NodeSet::clear):
        (WebCore::XPath::NodeSet::swap):
        (WebCore::XPath::NodeSet::append):
        (WebCore::XPath::NodeSet::markSorted):
        (WebCore::XPath::NodeSet::isSorted):
        Most of these methods just call Vector counterparts.

        * xml/XPathParser.cpp: Updated the copyright notice.

        * xml/XPathPath.cpp:
        (WebCore::XPath::Filter::evaluate): Replacing NodeVector with NodeSet.
        (WebCore::XPath::Path::evaluate): Ditto.
        (WebCore::XPath::LocationPath::evaluate): Replacing NodeVector with NodeSet. This function
        always marks the result as unsorted, because it is hard to tell whether a step breaks node order.
        Identifying and implementing special cases when it is not necessary to do so is an important
        future optimization.

        * xml/XPathPath.h: Replacing NodeVector with NodeSet.
        * xml/XPathPredicate.cpp:
        (WebCore::XPath::EqTestOp::compare): Replacing NodeVector with NodeSet.
        (WebCore::XPath::Union::evaluate): Replacing NodeVector with NodeSet. Currently, Union just
        marks the result as unordered; we can consider using merge sort to avoid this.

        * xml/XPathResult.cpp:
        (WebCore::XPathResult::XPathResult): Replacing NodeVector with NodeSet.
        (WebCore::XPathResult::singleNodeValue): Ditto.
        (WebCore::XPathResult::snapshotLength): Ditto.
        (WebCore::XPathResult::iterateNext): Ditto.
        (WebCore::XPathResult::snapshotItem): Ditto.
        (WebCore::XPathResult::convertTo): Ditto. Sort the result when requested to.

        * xml/XPathResult.h: Replacing NodeVector with NodeSet.

        * xml/XPathStep.cpp:
        (WebCore::XPath::Step::evaluate): If the input is not sorted, mark the output as such, too.
        (WebCore::XPath::Step::nodesInAxis): Fixed a number of bugs when enumerating with an
        attribute context node.
        (WebCore::XPath::Step::nodeTestMatches): Replacing NodeVector with NodeSet.
        * xml/XPathStep.h: Ditto.

        * xml/XPathUtil.cpp:
        (WebCore::XPath::isValidContextNode): XPath data model doesn't put attribute data into child
        nodes, so passing such node as a context could cause problems.

        * xml/XPathUtil.h: Removed NodeVector typedef.

        * xml/XPathValue.cpp:
        (WebCore::XPath::Value::Value):
        (WebCore::XPath::Value::toNodeSet):
        (WebCore::XPath::Value::toBoolean):
        (WebCore::XPath::Value::toNumber):
        (WebCore::XPath::Value::toString):
        * xml/XPathValue.h:
        (WebCore::XPath::Value::):
        (WebCore::XPath::Value::isNodeSet):
        Replacing NodeVector with NodeSet.

LayoutTests:
        * fast/xpath/document-order-expected.txt: Added.
        * fast/xpath/document-order.html: Added.

        * fast/xpath/text-nodes-expected.txt:
        * fast/xpath/text-nodes.html:
        * fast/xpath/4XPath/Core/test_step-expected.txt:
        Updated results for tests that now pass.

        * fast/xpath/xpath-test-pre.js: Added.
        * fast/xpath/4XPath/Core/test.js:
        Moved checkSnapshot() to a separate file.

        * fast/xpath/4XPath/Core/test_core_functions.html:
        * fast/xpath/4XPath/Core/test_location_path.html:
        * fast/xpath/4XPath/Core/test_nodeset_expr.html:
        * fast/xpath/4XPath/Core/test_parser.html:
        * fast/xpath/4XPath/Core/test_predicate_list.html:
        * fast/xpath/4XPath/Core/test_step.html:
        Load xpath-test-pre.js for checkSnapshot().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-03-21 Mark Rowe <mrowe@apple.com>
bdash [Tue, 20 Mar 2007 15:18:46 +0000 (15:18 +0000)]
2007-03-21  Mark Rowe  <mrowe@apple.com>

        Build fix.

        * bindings/objc/WebScriptObject.mm:
        (-[WebScriptObject methodForSelector:]):
        (-[WebScriptObject respondsToSelector:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-03-21 Mark Rowe <mrowe@apple.com>
bdash [Tue, 20 Mar 2007 15:11:12 +0000 (15:11 +0000)]
2007-03-21  Mark Rowe  <mrowe@apple.com>

        Reviewed by Tim Hatcher.

        Fix for http://bugs.webkit.org/show_bug.cgi?id=13129.
        Bug 13129: Democracy Player dies in NSException from WebScriptObject on startup.

        Some cross-language scripting bridges use the presence of -(int)count to determine
        whether to treat objects as sequence-like.  All WebScriptObject's exposed this method
        which lead to non-collection WebScriptObject's being mishandled by PyObjC.  We now
        expose -count only when the object we wrap looks like a collection from a JavaScript
        point of view (eg, it has a length property).

        * bindings/objc/WebScriptObject.mm:
        (-[WebScriptObject _shouldRespondToCount]):
        (-[WebScriptObject methodForSelector:]):
        (-[WebScriptObject respondsToSelector:]):
        (-[WebScriptObject _count]):
        * bindings/objc/WebScriptObjectPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago * page/EventHandler.cpp: (WebCore::EventHandler::handleMouseMoveEvent):
darin [Tue, 20 Mar 2007 14:51:50 +0000 (14:51 +0000)]
    * page/EventHandler.cpp: (WebCore::EventHandler::handleMouseMoveEvent):
        Fix obvious typo in the change from last night -- forgot to assign to the variable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoRefactor fonts a bit for portability.
hyatt [Tue, 20 Mar 2007 09:11:09 +0000 (09:11 +0000)]
Refactor fonts a bit for portability.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adam.
aroben [Tue, 20 Mar 2007 09:04:57 +0000 (09:04 +0000)]
    Reviewed by Adam.

        Stub out a couple of CFNetwork backend functions.

        * platform/network/ResourceHandle.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-03-19 Oliver Hunt <oliver@apple.com>
oliver [Tue, 20 Mar 2007 08:10:36 +0000 (08:10 +0000)]
2007-03-19  Oliver Hunt  <oliver@apple.com>

        Reviewed by Ada.

        Protect against possibility of JS detaching a frame (and losing its view)
        midway through a mouse move.

        * page/EventHandler.cpp:
        (WebCore::EventHandler::handleMouseMoveEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
ap [Tue, 20 Mar 2007 05:58:59 +0000 (05:58 +0000)]
    Reviewed by Darin.

        http://bugs.webkit.org/show_bug.cgi?id=13107
        XPath should raise an exception when trying to parse an unknown function

        Test: fast/xpath/invalid-functions.html

        * xml/XPathFunctions.cpp:
        (WebCore::XPath::createFunction): Return 0 if the function couldn't be created.
        * xml/XPathGrammar.y: Handle nulls returned from createFunction().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Dave Hyatt.
andersca [Tue, 20 Mar 2007 02:45:08 +0000 (02:45 +0000)]
    Reviewed by Dave Hyatt.

        <rdar://problem/5067983>
        iSale: Crash occurs at WebFrameLoaderClient::dispatchDecidePolicyForMIMEType() when attempting to load a HTML template

        Restore old behavior (broke in r14533) where the resource load and download delegates are retained for as long as the
        data source is loading.

        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::createDocumentLoader):
        * WebView/WebDocumentLoaderMac.h:
        * WebView/WebDocumentLoaderMac.mm:
        (WebDocumentLoaderMac::setDataSource):
        (WebDocumentLoaderMac::decreaseLoadCount):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago * kjs/value.h: Roll ~JSValue change out. It was causing problems. I'll do...
darin [Tue, 20 Mar 2007 01:05:45 +0000 (01:05 +0000)]
    * kjs/value.h: Roll ~JSValue change out. It was causing problems. I'll do it right later.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Speculative fix for why ASSERT_MAIN_THREAD didn't work for me. (The
ggaren [Tue, 20 Mar 2007 00:50:29 +0000 (00:50 +0000)]
    Speculative fix for why ASSERT_MAIN_THREAD didn't work for me. (The
        documentation says "non-zero," not "1."

        * Misc/WebKitLogging.m:
        (WebKitRunningOnMainThread):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by John Sullivan.
ggaren [Tue, 20 Mar 2007 00:46:36 +0000 (00:46 +0000)]
    Reviewed by John Sullivan.

        Fixed <rdar://problem/5073380> REGRESSION: Crash occurs at WTF::fastFree()
        when reloading liveconnect page (applet)

        Best to use free when you use malloc, especially when malloc and delete
        use completely different libraries.

        * bindings/jni/jni_runtime.cpp:
        (JavaMethod::~JavaMethod):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
adele [Tue, 20 Mar 2007 00:30:49 +0000 (00:30 +0000)]
LayoutTests:

        Reviewed by Beth.

        Test for http://bugs.webkit.org/show_bug.cgi?id=13087
        <rdar://problem/5064316> REGRESSION: Allow setting the checked attribute in js and in markup for unnamed radio buttons (dominos.com)

        * fast/forms/radio_checked_name-expected.txt: Added.
        * fast/forms/radio_checked_name.html: Added.

WebCore:

        Reviewed by Beth.

        Fix for http://bugs.webkit.org/show_bug.cgi?id=13087
        <rdar://problem/5064316> REGRESSION: Allow setting the checked attribute in js and in markup for unnamed radio buttons (dominos.com)

        Test: fast/forms/radio_checked_name.html

        We were matching a WinIE quirk that does not allow a user to check and uncheck an unnamed radio button.  But they still
        allow the checked attribute to be set in html, and changed in javascript.  So this change matches that behavior.

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::parseMappedAttribute): We no longer need a special call to setChecked when parsing the name
         attribute, since we setChecked will now work with unnamed radio buttons.
        (WebCore::HTMLInputElement::preDispatchEventHandler): Added comment.
        (WebCore::HTMLInputElement::setChecked): Don't check for the unnamed radio button case here.
        (WebCore::HTMLInputElement::postDispatchEventHandler): Don't call setChecked for unnamed radio buttons.
        (WebCore::HTMLInputElement::defaultEventHandler): ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Rubberstamped by Oliver.
aroben [Tue, 20 Mar 2007 00:27:55 +0000 (00:27 +0000)]
    Rubberstamped by Oliver.

        * bridge/JavaScriptStatistics.cpp: Added missing header for
        correctness.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore:
andrew [Tue, 20 Mar 2007 00:16:09 +0000 (00:16 +0000)]
JavaScriptCore:

        Reviewed by Maciej.

        Really set Xcode editor to use 4 space indentation (http://webkit.org/coding/coding-style.html)

        * JavaScriptCore.xcodeproj/project.pbxproj:

JavaScriptGlue:

        Reviewed by Maciej.

        Really set Xcode editor to use 4 space indentation (http://webkit.org/coding/coding-style.html)

        * JavaScriptGlue.xcodeproj/project.pbxproj:

WebCore:

        Reviewed by Maciej.

        Really set Xcode editor to use 4 space indentation (http://webkit.org/coding/coding-style.html)

        * WebCore.xcodeproj/project.pbxproj:

WebKit:

        Reviewed by Maciej.

        Really set Xcode editor to use 4 space indentation (http://webkit.org/coding/coding-style.html)

        * WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Geoff.
darin [Mon, 19 Mar 2007 23:50:43 +0000 (23:50 +0000)]
    Reviewed by Geoff.

        - Changed list size threshold to 5 based on testing.

        I was testing the i-Bench JavaScript with the list statistics
        dumping on, and discovered that there were many 5-element lists.
        The fast case for lists was for 4 elements and fewer. By changing
        the threshold to 5 elements we get a measurable speedup. I believe
        this will help real web pages too, not just the benchmark.

        * kjs/list.cpp: Change constant from 4 to 5.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago * kjs/value.h: Oops, fix build.
darin [Mon, 19 Mar 2007 23:28:04 +0000 (23:28 +0000)]
    * kjs/value.h: Oops, fix build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Geoff.
darin [Mon, 19 Mar 2007 23:12:23 +0000 (23:12 +0000)]
    Reviewed by Geoff.

        - remove ~JSValue; tiny low-risk performance boost

        * kjs/value.h: Remove unneeded empty virtual destructor from JSValue.
        The only class derived from JSValue is JSCell and it already has a
        virtual destructor. Declaring an empty constructor in JSValue had one
        good effect: it marked the destructor private, making it a compile
        time error to try to destroy a JSValue; but that's not a likely
        mistake for someone to make. It had two bad effects: (1) it caused gcc,
        at least, to generate code to fix up the virtual table pointer to
        point to the JSValue version of the virtual table inside the destructor
        of all classes derived from JSValue directly or indirectly; (2) it
        caused JSValue to be a polymorphic class so required a virtual table for
        it. It's cleaner to not have either of those.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago * English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.
darin [Mon, 19 Mar 2007 22:54:21 +0000 (22:54 +0000)]
    * English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
justing [Mon, 19 Mar 2007 22:39:31 +0000 (22:39 +0000)]
LayoutTests:

        Reviewed by darin

        <rdar://problem/5071074>
        REGRESSION: Links that aren't fully selected copy and paste as only text

        * editing/pasteboard/5071074-expected.checksum: Added.
        * editing/pasteboard/5071074-expected.png: Added.
        * editing/pasteboard/5071074-expected.txt: Added.
        * editing/pasteboard/5071074.html: Added.

WebCore:

        Reviewed by darin

        <rdar://problem/5071074>
        REGRESSION: Links that aren't fully selected copy and paste as only text

        We stopped adding markup for all commonAncestorBlocks
        and the ancestors of lastClosed up to them because it
        was adding a lot of unnecessary markup.

        * editing/markup.cpp:
        (WebCore::createMarkup): Also include markup for nodes
        up to an enclosing anchor.  Cleaned up the code for
        including special common ancestors a bit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoReviewed by Lars Knoll.
zimmermann [Mon, 19 Mar 2007 19:41:17 +0000 (19:41 +0000)]
Reviewed by Lars Knoll.

Fix crash when opening a SVG document which contains SVG elements, but no <svg> root element.
Moving the mouse was crashing WebKit. Fixes svg/hixie/dynamic/006.xml.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Hyatt.
adele [Mon, 19 Mar 2007 19:31:22 +0000 (19:31 +0000)]
    Reviewed by Hyatt.

        - fix http://bugs.webkit.org/show_bug.cgi?id=13117
        REGRESSION (r14658): Flickering text fields when updating via javascript

        * page/Frame.cpp:
        (WebCore::Frame::forceLayout): Added a flag to allow partial relayout.
        * page/Frame.h:
        * page/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge forceLayoutAdjustingViewSize:]): Allow partial relayout
        if not adjusting view size.
        (-[WebCoreFrameBridge needsLayout]): Changed to check for pending subtree
        layout instead of just whether the root needs layout.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoReviewed by Maciej.
zimmermann [Mon, 19 Mar 2007 19:28:12 +0000 (19:28 +0000)]
Reviewed by Maciej.

Make JS function calls on POD-types (ie. SVGLength) take effect.
Calling ie. newValueInSpecifiedUnits on SVGLength works as expected.

This worked fine before we switched to SVGLength POD type, so this
can be considered as P1 regression fix.

Partly fix svg/hixie/dynamic/005-broken.svg. We match Opera now though
it's not yet completly fixed. Setting baseVal attribute on SVGAnimatedString
doesn't work as expected - needs a seperated fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adam.
adele [Mon, 19 Mar 2007 18:21:52 +0000 (18:21 +0000)]
    Reviewed by Adam.

        Adding comments and a little cleanup from my last checkin.

        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::setSelectedIndex): Removed commented out assert.  Added comment about how we use onChange.
        (WebCore::HTMLSelectElement::selectAll): Added comment about how we use saveLastSelection and onChange.
        (WebCore::HTMLSelectElement::dispatchFocusEvent): ditto.
        (WebCore::HTMLSelectElement::dispatchBlurEvent): ditto.
        (WebCore::HTMLSelectElement::menuListDefaultEventHandler): ditto.
        (WebCore::HTMLSelectElement::listBoxDefaultEventHandler): ditto.
        (WebCore::HTMLSelectElement::menuListOnChange): Added assert that usesMenuList() is true.
        (WebCore::HTMLSelectElement::listBoxOnChange): Added assert that usesMenuList() is false.
        (WebCore::HTMLSelectElement::saveLastSelection): Added early return for menu lists.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoReviewed by Maciej.
zimmermann [Mon, 19 Mar 2007 16:57:19 +0000 (16:57 +0000)]
Reviewed by Maciej.

Import Hixie's SVG testsuite. It highlights one bug, one regression in JS and one crash.
The crashing file is marked with "-disabled", the broken ones with "-broken".

Landing fixes for the certain bugs/regressions seperated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Justin
sullivan [Mon, 19 Mar 2007 13:17:48 +0000 (13:17 +0000)]
    Reviewed by Justin

        - fixed <rdar://problem/5071238> REGRESSION: opt-cmd-B to show Bookmarks view does
        nothing when form field has focus

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _handleStyleKeyEquivalent:]):
        we were counting any set of modifiers plus 'b' as the standard key equivalent for
        toggling Bold; now we only accept command+'b'

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-03-19 Mitz Pettel <mitz@webkit.org>
bdash [Mon, 19 Mar 2007 12:46:58 +0000 (12:46 +0000)]
2007-03-19  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Tim Hatcher.

        - fix http://bugs.webkit.org/show_bug.cgi?id=13091
          REGRESSION (r20075): Wrong text style and pixel break in Apple Store Locator HUD

        Test: fast/innerHTML/additional-inline-style.html

        * editing/markup.cpp:
        (WebCore::startMarkup): Changed to add inline style based on CSS rules only
        in AnnotateForInterchange mode.

2007-03-19  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Tim Hatcher.

        - test and updated result for http://bugs.webkit.org/show_bug.cgi?id=13091
          REGRESSION (r20075): Wrong text style and pixel break in Apple Store Locator HUD

        * editing/pasteboard/paste-table-002-expected.txt:
        * fast/innerHTML/additional-inline-style-expected.txt: Added.
        * fast/innerHTML/additional-inline-style.html: Added.
        * webarchive/test-duplicate-resources-expected.txt:
        * webarchive/test-frameset-expected.txt:
        * webarchive/test-link-href-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agocompile fix for qt
zack [Mon, 19 Mar 2007 08:19:41 +0000 (08:19 +0000)]
compile fix for qt

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
aroben [Mon, 19 Mar 2007 08:00:07 +0000 (08:00 +0000)]
WebCore:

        Reviewed by Hyatt and Maciej.

        Renamed WebCoreJavaScript to JavaScriptStatistics and made it C++ as
        part of <rdar://problem/5071653>.

        All layout tests pass.

        * WebCore.exp: Updated.
        * WebCore.xcodeproj/project.pbxproj: Updated.
        * bridge/JavaScriptStatistics.cpp: Moved from
        bridge/mac/WebCoreJavaScript.mm, and converted to C++.
        (WebCore::collect):
        (WebCore::JavaScriptStatistics::objectCount):
        (WebCore::JavaScriptStatistics::interpreterCount):
        (WebCore::JavaScriptStatistics::protectedObjectCount):
        (WebCore::JavaScriptStatistics::rootObjectTypeCounts):
        (WebCore::JavaScriptStatistics::garbageCollect):
        (WebCore::JavaScriptStatistics::garbageCollectOnAlternateThread):
        (WebCore::JavaScriptStatistics::shouldPrintExceptions):
        (WebCore::JavaScriptStatistics::setShouldPrintExceptions):
        * bridge/JavaScriptStatistics.h: Added.
        * bridge/mac/WebCoreJavaScript.h: Removed.
        * bridge/mac/WebCoreJavaScript.mm: Removed.

WebKit:

        Reviewed by Hyatt and Maciej.

        Updated WebCoreStatistics for the conversion of WebCoreJavaScript to
        C++.

        * Misc/WebCoreStatistics.mm:
        (+[WebCoreStatistics javaScriptObjectsCount]):
        (+[WebCoreStatistics javaScriptInterpretersCount]):
        (+[WebCoreStatistics javaScriptProtectedObjectsCount]):
        (+[WebCoreStatistics javaScriptRootObjectTypeCounts]): Moved
        conversion to NSCountedSet here from WebCore.
        (+[WebCoreStatistics garbageCollectJavaScriptObjects]):
        (+[WebCoreStatistics garbageCollectJavaScriptObjectsOnAlternateThread:]):
        (+[WebCoreStatistics shouldPrintExceptions]):
        (+[WebCoreStatistics setShouldPrintExceptions:]):
        (+[WebCoreStatistics javaScriptReferencedObjectsCount]):
        (+[WebCoreStatistics javaScriptRootObjectClasses]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoUpdate SVG tests now that painting happens after onload.
hyatt [Mon, 19 Mar 2007 07:40:20 +0000 (07:40 +0000)]
Update SVG tests now that painting happens after onload.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoUpdate tests for minimum font size change.
hyatt [Mon, 19 Mar 2007 07:36:07 +0000 (07:36 +0000)]
Update tests for minimum font size change.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoUpdate tests for minimum font size change.
hyatt [Mon, 19 Mar 2007 07:35:16 +0000 (07:35 +0000)]
Update tests for minimum font size change.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoUpdate tests for minimum font size change.
hyatt [Mon, 19 Mar 2007 07:34:42 +0000 (07:34 +0000)]
Update tests for minimum font size change.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoUpdate tests for minimum font size change.
hyatt [Mon, 19 Mar 2007 07:34:01 +0000 (07:34 +0000)]
Update tests for minimum font size change.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Update the minimum font size pref to match the actual default setting in...
hyatt [Mon, 19 Mar 2007 07:32:47 +0000 (07:32 +0000)]
    Update the minimum font size pref to match the actual default setting in Safari.  It should have been 1
        all this time and not 9.

        Reviewed by aroben

        * DumpRenderTree/DumpRenderTree.m:
        (dumpRenderTree):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore:
mjs [Mon, 19 Mar 2007 05:43:47 +0000 (05:43 +0000)]
JavaScriptCore:

        Reviewed by Mark.

        - avoid static construction (and global variable access) in a smarter, more portable way,
        to later enable MUTLI_THREAD mode to work on other platforms and compilers.

        * kjs/CommonIdentifiers.cpp: Added. New class to hold all the shared identifiers.
        (KJS::CommonIdentifiers::CommonIdentifiers):
        (KJS::CommonIdentifiers::shared):
        * kjs/CommonIdentifiers.h: Added.

        * kjs/ExecState.h:
        (KJS::ExecState::propertyNames): Hand the CommonIdentifiers instance here for easy access.
        (KJS::ExecState::ExecState):

        * API/JSObjectRef.cpp:
        (JSObjectMakeConstructor):
        * CMakeLists.txt:
        * JavaScriptCore.exp:
        * JavaScriptCore.pri:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * JavaScriptCoreSources.bkl:
        * bindings/runtime_array.cpp:
        (RuntimeArray::getOwnPropertySlot):
        (RuntimeArray::put):
        * bindings/runtime_method.cpp:
        (RuntimeMethod::getOwnPropertySlot):
        * kjs/array_object.cpp:
        (ArrayInstance::getOwnPropertySlot):
        (ArrayInstance::put):
        (ArrayInstance::deleteProperty):
        (ArrayProtoFunc::ArrayProtoFunc):
        (ArrayProtoFunc::callAsFunction):
        (ArrayObjectImp::ArrayObjectImp):
        * kjs/bool_object.cpp:
        (BooleanPrototype::BooleanPrototype):
        (BooleanProtoFunc::BooleanProtoFunc):
        (BooleanProtoFunc::callAsFunction):
        (BooleanObjectImp::BooleanObjectImp):
        * kjs/completion.h:
        (KJS::Completion::Completion):
        * kjs/date_object.cpp:
        (KJS::DateProtoFunc::DateProtoFunc):
        (KJS::DateObjectImp::DateObjectImp):
        (KJS::DateObjectFuncImp::DateObjectFuncImp):
        * kjs/error_object.cpp:
        (ErrorPrototype::ErrorPrototype):
        (ErrorProtoFunc::ErrorProtoFunc):
        (ErrorProtoFunc::callAsFunction):
        (ErrorObjectImp::ErrorObjectImp):
        (ErrorObjectImp::construct):
        (NativeErrorPrototype::NativeErrorPrototype):
        (NativeErrorImp::NativeErrorImp):
        (NativeErrorImp::construct):
        (NativeErrorImp::callAsFunction):
        * kjs/function.cpp:
        (KJS::FunctionImp::getOwnPropertySlot):
        (KJS::FunctionImp::put):
        (KJS::FunctionImp::deleteProperty):
        (KJS::FunctionImp::getParameterName):
        (KJS::DeclaredFunctionImp::construct):
        (KJS::IndexToNameMap::unMap):
        (KJS::Arguments::Arguments):
        (KJS::ActivationImp::getOwnPropertySlot):
        (KJS::ActivationImp::deleteProperty):
        (KJS::GlobalFuncImp::GlobalFuncImp):
        * kjs/function_object.cpp:
        (FunctionPrototype::FunctionPrototype):
        (FunctionProtoFunc::FunctionProtoFunc):
        (FunctionProtoFunc::callAsFunction):
        (FunctionObjectImp::FunctionObjectImp):
        (FunctionObjectImp::construct):
        * kjs/grammar.y:
        * kjs/identifier.cpp:
        * kjs/identifier.h:
        * kjs/interpreter.cpp:
        (KJS::Interpreter::init):
        (KJS::Interpreter::initGlobalObject):
        * kjs/interpreter.h:
        * kjs/lookup.h:
        * kjs/math_object.cpp:
        (MathFuncImp::MathFuncImp):
        * kjs/nodes.cpp:
        (ArrayNode::evaluate):
        (FuncDeclNode::processFuncDecl):
        (FuncExprNode::evaluate):
        * kjs/number_object.cpp:
        (NumberPrototype::NumberPrototype):
        (NumberProtoFunc::NumberProtoFunc):
        (NumberObjectImp::NumberObjectImp):
        * kjs/object.cpp:
        (KJS::JSObject::put):
        (KJS::JSObject::defaultValue):
        (KJS::JSObject::hasInstance):
        * kjs/object.h:
        (KJS::JSObject::getOwnPropertySlot):
        * kjs/object_object.cpp:
        (ObjectPrototype::ObjectPrototype):
        (ObjectProtoFunc::ObjectProtoFunc):
        (ObjectObjectImp::ObjectObjectImp):
        * kjs/regexp_object.cpp:
        (RegExpPrototype::RegExpPrototype):
        (RegExpProtoFunc::RegExpProtoFunc):
        (RegExpObjectImp::RegExpObjectImp):
        * kjs/string_object.cpp:
        (KJS::StringInstance::getOwnPropertySlot):
        (KJS::StringInstance::put):
        (KJS::StringInstance::deleteProperty):
        (KJS::StringPrototype::StringPrototype):
        (KJS::StringProtoFunc::StringProtoFunc):
        (KJS::StringProtoFunc::callAsFunction):
        (KJS::StringObjectImp::StringObjectImp):
        (KJS::StringObjectFuncImp::StringObjectFuncImp):
        * kjs/testkjs.cpp:
        (TestFunctionImp::TestFunctionImp):

WebCore:

        Reviewed by Mark.

        - avoid static construction (and global variable access) in a smarter, more portable way,
        to later enable MUTLI_THREAD mode to work on other platforms and compilers.

        * bindings/js/JSCustomXPathNSResolver.cpp:
        (WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
        * bindings/js/JSHTMLInputElementBase.cpp:
        (WebCore::JSHTMLInputElementBaseFunction::JSHTMLInputElementBaseFunction):
        * bindings/js/JSHTMLOptionElementConstructor.cpp:
        (WebCore::JSHTMLOptionElementConstructor::JSHTMLOptionElementConstructor):
        * bindings/js/JSXMLHttpRequest.cpp:
        (KJS::JSXMLHttpRequestConstructorImp::JSXMLHttpRequestConstructorImp):
        * bindings/js/JSXSLTProcessor.cpp:
        (KJS::XSLTProcessorConstructorImp::XSLTProcessorConstructorImp):
        * bindings/js/kjs_dom.cpp:
        (KJS::DOMNamedNodeMap::getOwnPropertySlot):
        (KJS::DOMNamedNodesCollection::getOwnPropertySlot):
        * bindings/js/kjs_events.cpp:
        (KJS::JSAbstractEventListener::handleEvent):
        * bindings/js/kjs_html.cpp:
        (KJS::HTMLElementFunction::HTMLElementFunction):
        (KJS::JSHTMLCollection::getOwnPropertySlot):
        * bindings/js/kjs_window.cpp:
        (KJS::ScheduledAction::execute):
        * bindings/objc/WebScriptObject.mm:
        * bindings/scripts/CodeGeneratorJS.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore:
andrew [Mon, 19 Mar 2007 05:05:33 +0000 (05:05 +0000)]
JavaScriptCore:

        Reviewed by Mark Rowe

        Set Xcode editor to use 4 space indentation (http://webkit.org/coding/coding-style.html)

        * JavaScriptCore.xcodeproj/project.pbxproj:

JavaScriptGlue:

        Reviewed by Mark Rowe

        Set Xcode editor to use 4 space indentation (http://webkit.org/coding/coding-style.html)

        * JavaScriptGlue.xcodeproj/project.pbxproj:

WebCore:

        Reviewed by Mark Rowe

        Set Xcode editor to use 4 space indentation (http://webkit.org/coding/coding-style.html)

        * WebCore.xcodeproj/project.pbxproj:

WebKit:

        Reviewed by Mark Rowe

        Set Xcode editor to use 4 space indentation (http://webkit.org/coding/coding-style.html)

        * WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoland update results for frame pixel changes.
hyatt [Mon, 19 Mar 2007 04:57:20 +0000 (04:57 +0000)]
land update results for frame pixel changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLand updated results for frames pixel tests.
hyatt [Mon, 19 Mar 2007 04:53:45 +0000 (04:53 +0000)]
Land updated results for frames pixel tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAdd layout test for frame borders case.
hyatt [Mon, 19 Mar 2007 04:53:04 +0000 (04:53 +0000)]
Add layout test for frame borders case.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Fix for REGRESSION bug 13108, frame borders being painted when they shouldn...
hyatt [Mon, 19 Mar 2007 04:50:45 +0000 (04:50 +0000)]
    Fix for REGRESSION bug 13108, frame borders being painted when they shouldn't be.  Rework both frame borders
        and resizing to be more like other browsers.

        Reviewed by ggaren

        fast/frames/no-frame-borders.html

        * html/HTMLFrameElement.cpp:
        (WebCore::HTMLFrameElement::HTMLFrameElement):
        (WebCore::HTMLFrameElement::attach):
        (WebCore::HTMLFrameElement::parseMappedAttribute):
        * html/HTMLFrameElement.h:
        (WebCore::HTMLFrameElement::hasFrameBorder):
        * html/HTMLFrameElementBase.cpp:
        (WebCore::HTMLFrameElementBase::HTMLFrameElementBase):
        (WebCore::HTMLFrameElementBase::parseMappedAttribute):
        * html/HTMLFrameElementBase.h:
        * html/HTMLFrameSetElement.cpp:
        (WebCore::HTMLFrameSetElement::attach):
        * html/HTMLFrameSetElement.h:
        (WebCore::HTMLFrameSetElement::hasFrameBorder):
        * html/HTMLIFrameElement.cpp:
        (WebCore::HTMLIFrameElement::HTMLIFrameElement):
        * rendering/RenderFrame.cpp:
        (WebCore::RenderFrame::edgeInfo):
        * rendering/RenderFrame.h:
        * rendering/RenderFrameSet.cpp:
        (WebCore::RenderFrameSet::paint):
        (WebCore::RenderFrameSet::GridAxis::resize):
        (WebCore::RenderFrameSet::fillFromEdgeInfo):
        (WebCore::RenderFrameSet::computeEdgeInfo):
        (WebCore::RenderFrameSet::edgeInfo):
        (WebCore::RenderFrameSet::layout):
        (WebCore::RenderFrameSet::startResizing):
        (WebCore::RenderFrameSet::continueResizing):
        (WebCore::RenderFrameSet::canResizeRow):
        (WebCore::RenderFrameSet::canResizeColumn):
        (WebCore::RenderFrameSet::splitPosition):
        (WebCore::RenderFrameSet::hitTestSplit):
        (WebCore::RenderFrameSet::dump):
        * rendering/RenderFrameSet.h:
        (WebCore::):
        (WebCore::FrameEdgeInfo::FrameEdgeInfo):
        (WebCore::FrameEdgeInfo::preventResize):
        (WebCore::FrameEdgeInfo::allowBorder):
        (WebCore::FrameEdgeInfo::setPreventResize):
        (WebCore::FrameEdgeInfo::setAllowBorder):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-03-19 Mark Rowe <mrowe@apple.com>
bdash [Mon, 19 Mar 2007 04:32:24 +0000 (04:32 +0000)]
2007-03-19  Mark Rowe  <mrowe@apple.com>

        Rubber-stamped by Brady.

        Update references to bugzilla.opendarwin.org with bugs.webkit.org.

        * bindings/c/c_utility.cpp:
        (KJS::Bindings::convertUTF8ToUTF16):
        * kjs/function.cpp:
        (KJS::FunctionImp::callAsFunction):
        * kjs/grammar.y:
        * kjs/keywords.table:
        * kjs/lexer.cpp:
        (KJS::Lexer::shift):

2007-03-19  Mark Rowe  <mrowe@apple.com>

        Rubber-stamped by Brady.

        Update references to bugzilla.opendarwin.org with bugs.webkit.org.

        * ChangeLog:
        * WebCore.vcproj/WebCore/build-generated-files.sh:
        * manual-tests/ATSU-bad-layout.html:
        * manual-tests/accidental-strict-mode.html:
        * manual-tests/applet-param-no-name.html:
        * manual-tests/bidi-parens.html:
        * manual-tests/bugzilla-3855.html:
        * manual-tests/bugzilla-4840.html:
        * manual-tests/bugzilla-6821.html:
        * manual-tests/containing-block-position-chage.html:
        * manual-tests/contenteditable-link.html:
        * manual-tests/css3-cursor-fallback-quirks.html:
        * manual-tests/css3-cursor-fallback-strict.html:
        * manual-tests/custom-cursors.html:
        * manual-tests/dictionary-scrolled-iframe.html:
        * manual-tests/dom-manipulation-on-resize.html:
        * manual-tests/drag-image-to-address-bar.html:
        * manual-tests/empty-link-target.html:
        * manual-tests/empty-title-popup.html:
        * manual-tests/first-line-style-crash.html:
        * manual-tests/invalid-mouse-event.html:
        * manual-tests/left-overflow-repaint.html:
        * manual-tests/linkjump-3.html:
        * manual-tests/log-keypress-events.html:
        * manual-tests/named-window-blank-target.html:
        * manual-tests/plain-text-paste.html:
        * manual-tests/plugin-controller-datasource.html:
        * manual-tests/pre-tab-selection-rect.html:
        * manual-tests/redirection-target.html:
        * manual-tests/redraw-page-cache-visited-links.html:
        * manual-tests/reset-initiatedDrag.html:
        * manual-tests/resources/named-window-blank-target-step2.html:
        * manual-tests/resources/named-window-blank-target-step3.html:
        * manual-tests/resources/named-window-blank-target-step4.html:
        * manual-tests/resources/redraw-page-cache-visited-links-2.html:
        * manual-tests/scrollbar-hittest.html:
        * manual-tests/scrollbar-hittest2.html:
        * manual-tests/subview-click-assertion.html:
        * manual-tests/tabbing-input-google.html:
        * manual-tests/text-field-autoscroll.html:
        * manual-tests/textarea-after-stylesheet-link.html:
        * manual-tests/textarea-focus.html:
        * manual-tests/whitespace-pre-affinity.html:

2007-03-19  Mark Rowe  <mrowe@apple.com>

        Rubber-stamped by Brady.

        Update references to bugzilla.opendarwin.org with bugs.webkit.org.

        * WebInspector/webInspector/inspector.css:
        * WebView/WebHTMLView.mm:
        (-[WebHTMLView firstRectForCharacterRange:]):
        * WebView/WebView.mm:
        (-[WebView initWithFrame:frameName:groupName:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Added a random JS benchmark.
mjs [Mon, 19 Mar 2007 02:34:01 +0000 (02:34 +0000)]
    Added a random JS benchmark.

        * misc/morph.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoRoll out r20297, fix for http://bugs.webkit.org/show_bug.cgi?id=13091, as it causes...
bdash [Mon, 19 Mar 2007 01:50:14 +0000 (01:50 +0000)]
Roll out r20297, fix for bugs.webkit.org/show_bug.cgi?id=13091, as it causes regressions in layout tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Mark.
weinig [Mon, 19 Mar 2007 01:40:18 +0000 (01:40 +0000)]
    Reviewed by Mark.

        Update results after Hyatt's patch in r20268.

        * tables/mozilla/bugs/bug137388-2-expected.checksum:
        * tables/mozilla/bugs/bug137388-2-expected.png:
        * tables/mozilla/bugs/bug137388-2-expected.txt:
        * tables/mozilla/bugs/bug137388-3-expected.checksum:
        * tables/mozilla/bugs/bug137388-3-expected.png:
        * tables/mozilla/bugs/bug137388-3-expected.txt:
        * tables/mozilla/bugs/bug50695-2-expected.checksum:
        * tables/mozilla/bugs/bug50695-2-expected.png:
        * tables/mozilla/bugs/bug50695-2-expected.txt:
        * tables/mozilla_expected_failures/bugs/bug137388-1-expected.checksum:
        * tables/mozilla_expected_failures/bugs/bug137388-1-expected.png:
        * tables/mozilla_expected_failures/bugs/bug137388-1-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Not reviewed - gdk build fix.
kjk [Mon, 19 Mar 2007 00:39:49 +0000 (00:39 +0000)]
    Not reviewed - gdk build fix.

        * platform/gdk/ScrollViewGdk.cpp:
        (WebCore::ScrollView::update): add a stub

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Hyatt
beidson [Mon, 19 Mar 2007 00:37:19 +0000 (00:37 +0000)]
    Reviewed by Hyatt

        http://bugs.webkit.org/show_bug.cgi?id=13111
        When stopped a load before it completes, partial images become the
        broken image icon

        * loader/loader.cpp:
        (WebCore::Loader::didFail): Split off into a method that knows the
          difference between failed and cancelled.  If a load is cancelled,
          don't call error() on the object - only remove it from the cache
        (WebCore::Loader::cancelRequests): Call didFail(loader, true)
        * loader/loader.h: Added didFail(SubresourceLoader*, bool cancelled)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-03-18 Mitz Pettel <mitz@webkit.org>
bdash [Sun, 18 Mar 2007 23:42:39 +0000 (23:42 +0000)]
2007-03-18  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Adele.

        - fix http://bugs.webkit.org/show_bug.cgi?id=13101
          REGRESSION (NativeTextField): Specifying word-wrap:break-word makes text field wrap

        Test: fast/forms/input-text-word-wrap.html

        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::createInnerTextStyle): Force the inner block to
        'word-wrap:normal'.

2007-03-18  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Adele.

        - test for http://bugs.webkit.org/show_bug.cgi?id=13101
          REGRESSION (NativeTextField): Specifying word-wrap:break-word makes text field wrap

        * fast/forms/input-text-word-wrap-expected.checksum: Added.
        * fast/forms/input-text-word-wrap-expected.png: Added.
        * fast/forms/input-text-word-wrap-expected.txt: Added.
        * fast/forms/input-text-word-wrap.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-03-18 Mitz Pettel <mitz@webkit.org>
bdash [Sun, 18 Mar 2007 23:40:26 +0000 (23:40 +0000)]
2007-03-18  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Tim Hatcher.

        - fix http://bugs.webkit.org/show_bug.cgi?id=13091
          REGRESSION (r20075): Wrong text style and pixel break in Apple Store Locator HUD

        Test: fast/innerHTML/additional-inline-style.html

        * editing/markup.cpp:
        (WebCore::startMarkup): Changed to add inline style based on CSS rules only
        in AnnotateForInterchange mode.

2007-03-18  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Tim Hatcher.

        - test and updated result for http://bugs.webkit.org/show_bug.cgi?id=13091
          REGRESSION (r20075): Wrong text style and pixel break in Apple Store Locator HUD

        * editing/pasteboard/paste-table-002-expected.txt:
        * fast/innerHTML/additional-inline-style-expected.txt: Added.
        * fast/innerHTML/additional-inline-style.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-03-18 Dan Waylonis <waylonis@mac.com>
bdash [Sun, 18 Mar 2007 23:25:01 +0000 (23:25 +0000)]
2007-03-18  Dan Waylonis  <waylonis@mac.com>

        Reviewed by Tim Hatcher.

        Fix http://bugs.webkit.org/show_bug.cgi?id=13005
        Bug 13005: WebScriptObject +throwException needs NULL check.

        Add checking for NULL interpreter before throwing exception.

        * bindings/objc/WebScriptObject.mm:
        (+[WebScriptObject throwException:]):

2007-03-18  Dan Waylonis  <waylonis@mac.com>

        Reviewed by Tim Hatcher.

        DumpRenderTree changes for http://bugs.webkit.org/show_bug.cgi?id=13005
        Bug 13005: WebScriptObject +throwException needs NULL check.

        Add tests to ensure that a plugin can safely throw an exception in dealloc.

        * DumpRenderTree/ObjCPlugin.h:
        * DumpRenderTree/ObjCPlugin.m:
        (+[ObjCPlugin webScriptNameForKey:]):
        (+[ObjCPlugin isKeyExcludedFromWebScript:]):
        (-[ObjCPlugin dealloc]):

2007-03-18  Dan Waylonis  <waylonis@mac.com>

        Reviewed by Tim Hatcher.

        Tests for http://bugs.webkit.org/show_bug.cgi?id=13005
        Bug 13005: WebScriptObject +throwException needs NULL check.

        A plugin that throws on dealloc can crash WebKit.

        * plugins/throw-on-dealloc-expected.txt: Added.
        * plugins/throw-on-dealloc.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore:
ggaren [Sun, 18 Mar 2007 23:02:39 +0000 (23:02 +0000)]
JavaScriptCore:

        Reviewed by Oliver Hunt.

        Exposed some extra toUInt32 functionality, as part of the fix for
        REGRESSION: Incomplete document.all implementation breaks abtelectronics.com
        (Style Change Through JavaScript Blanks Content)

        * JavaScriptCore.exp:
        * kjs/identifier.h:
        (KJS::Identifier::toUInt32):

LayoutTests:

        Reviewed by Oliver Hunt.

        Layout test for http://bugs.webkit.org/show_bug.cgi?id=13106
        REGRESSION: Incomplete document.all implementation breaks abtelectronics.com
        (Style Change Through JavaScript Blanks Content)

        * fast/dom/collection-null-like-arguments-expected.txt: Added.
        * fast/dom/collection-null-like-arguments.html: Added.

WebCore:

        Reviewed by Oliver Hunt.

        Fixed http://bugs.webkit.org/show_bug.cgi?id=13106
        REGRESSION: Incomplete document.all implementation breaks abtelectronics.com
        (Style Change Through JavaScript Blanks Content)

        When indexing into collections, treat the empty string as an invalid argument,
        instead of the number 0.

        * bindings/js/kjs_html.cpp:
        (KJS::JSHTMLCollection::getOwnPropertySlot):
        (KJS::JSHTMLCollection::callAsFunction):
        (KJS::JSHTMLCollectionPrototypeFunction::callAsFunction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Removed duplicate export name.
ggaren [Sun, 18 Mar 2007 18:10:40 +0000 (18:10 +0000)]
    Removed duplicate export name.

        * JavaScriptCore.exp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej Stachowiak.
ggaren [Sun, 18 Mar 2007 18:07:21 +0000 (18:07 +0000)]
    Reviewed by Maciej Stachowiak.

        Fixed <rdar://problem/5064964> Repro ASSERT failure in JS Bindings when
        closing window @ lowtrades.bptrade.com

        Unfortunately, the bindings depend on UString and Identifier as string
        representations. So, they need to acquire the JSLock when doing something
        that will ref/deref their strings.

        Layout tests, the original site, and Java, Flash, and Quicktime on the
        web work. No leaks reported. No automated test for this because testing
        the Java bindings, like math, is hard.

        * bindings/runtime.h: Made Noncopyable, just to be sure.

        * bindings/c/c_class.cpp:
        (KJS::Bindings::CClass::~CClass): Acquire the JSLock and explicitly clear the keys
        in our hashtable, since they're UString::Reps, and ref/deref aren't thread-safe.
        (KJS::Bindings::CClass::methodsNamed): Also acquire the JSLock when adding
        keys to the table, since the table ref's them.
        (KJS::Bindings::CClass::fieldNamed): ditto.

        * bindings/c/c_utility.cpp: Removed dead function.
        (KJS::Bindings::convertValueToNPVariant): Acquire the JSLock because doing
        it recursively is pretty cheap, and it's just too confusing to tell whether
        all our callers do it for us.
        (KJS::Bindings::convertNPVariantToValue): ditto
        * bindings/c/c_utility.h:

        * bindings/jni/jni_class.cpp: Same deal as c_class.cpp.
        (JavaClass::JavaClass):
        (JavaClass::~JavaClass):

        * bindings/jni/jni_instance.cpp: Same deal as c_utility.cpp.
        (JavaInstance::stringValue):
        * bindings/jni/jni_jsobject.cpp:
        (JavaJSObject::convertValueToJObject):

        * bindings/jni/jni_runtime.cpp:
        (JavaMethod::~JavaMethod): Moved from header, for clarity.
        (appendClassName): Made this static, so the set of callers is known, and
        we can assert that we hold the JSLock. Also changed it to take a UString
        reference, which makes the calling code simpler.
        (JavaMethod::signature): Store the ASCII value we care about instead of
        a UString, since UString is so much more hassle. Hold the JSLock while
        building up the temporary UString.

        * bindings/jni/jni_runtime.h: Nixed dead code in JavaMethod.
        (KJS::Bindings::JavaString::JavaString): Hold a UString::Rep instead of
        a UString, so we can acquire the JSLock and explicitly release it.
        (KJS::Bindings::JavaString::_commonInit):
        (KJS::Bindings::JavaString::~JavaString):
        (KJS::Bindings::JavaString::UTF8String):
        (KJS::Bindings::JavaString::uchars):
        (KJS::Bindings::JavaString::length):
        (KJS::Bindings::JavaString::ustring):

        * bindings/jni/jni_utility.cpp:
        (KJS::Bindings::convertArrayInstanceToJavaArray): Made this static, so
        the set of callers is known, and we can assert that we hold the JSLock.
        (KJS::Bindings::convertValueToJValue): Acquire the JSLock because doing
        it recursively is pretty cheap, and it's just too confusing to tell whether
        all our callers do it for us.

        * bindings/objc/objc_runtime.h: Nixed some dead code.
        * bindings/objc/objc_utility.mm:
        (KJS::Bindings::convertNSStringToString): Same drill as above.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Geoff.
ap [Sun, 18 Mar 2007 17:39:21 +0000 (17:39 +0000)]
    Reviewed by Geoff.

        http://bugs.webkit.org/show_bug.cgi?id=13105
        REGRESSION: an exception raised when calculating base value of a dot expression is not returned

        Test: fast/js/dot-node-base-exception.html

        * kjs/nodes.cpp:
        (FunctionCallDotNode::evaluate): Added the necessary KJS_CHECKEXCEPTIONVALUE.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2007-03-18 Steve Falkenburg <sfalken@apple.com>
sfalken [Sun, 18 Mar 2007 17:36:21 +0000 (17:36 +0000)]
2007-03-18  Steve Falkenburg  <sfalken@apple.com>

        Build fix.

        * JavaScriptCore.vcproj/testkjs/testkjs.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Use fillRect instead of drawLine, since drawLine has some odd behavior (it...
hyatt [Sun, 18 Mar 2007 11:34:02 +0000 (11:34 +0000)]
    Use fillRect instead of drawLine, since drawLine has some odd behavior (it's only used for borders).

        Reviewed by aroben

        * platform/graphics/IntRect.h:
        * rendering/RenderFrameSet.cpp:
        (WebCore::RenderFrameSet::paintColumnBorder):
        (WebCore::RenderFrameSet::paintRowBorder):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Change the frameborder color to be light gray for framesets.
hyatt [Sun, 18 Mar 2007 11:11:34 +0000 (11:11 +0000)]
    Change the frameborder color to be light gray for framesets.

        Reviewed by aroben

        * rendering/RenderFrameSet.cpp:
        (WebCore::borderFillColor):
        (WebCore::RenderFrameSet::paintColumnBorder):
        (WebCore::RenderFrameSet::paintRowBorder):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Make iframes work properly with frameborder="0".
hyatt [Sun, 18 Mar 2007 10:53:59 +0000 (10:53 +0000)]
    Make iframes work properly with frameborder="0".

        Reviewed by aroben

        * html/HTMLIFrameElement.cpp:
        (WebCore::HTMLIFrameElement::mapToEntry):
        (WebCore::HTMLIFrameElement::parseMappedAttribute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAdd new iframe layout test.
hyatt [Sun, 18 Mar 2007 10:52:51 +0000 (10:52 +0000)]
Add new iframe layout test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLand corrected results for frame changes.
hyatt [Sun, 18 Mar 2007 10:00:20 +0000 (10:00 +0000)]
Land corrected results for frame changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLand corrected results for frame changes.
hyatt [Sun, 18 Mar 2007 09:58:34 +0000 (09:58 +0000)]
Land corrected results for frame changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLand corrected results for frame changes.
hyatt [Sun, 18 Mar 2007 09:57:55 +0000 (09:57 +0000)]
Land corrected results for frame changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLand corrected results for frame changes.
hyatt [Sun, 18 Mar 2007 09:57:22 +0000 (09:57 +0000)]
Land corrected results for frame changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLand corrected results for frame changes.
hyatt [Sun, 18 Mar 2007 09:56:50 +0000 (09:56 +0000)]
Land corrected results for frame changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLand corrected results for frame changes.
hyatt [Sun, 18 Mar 2007 09:56:17 +0000 (09:56 +0000)]
Land corrected results for frame changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLand corrected results for frame changes.
hyatt [Sun, 18 Mar 2007 09:55:39 +0000 (09:55 +0000)]
Land corrected results for frame changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLand corrected results for frame changes.
hyatt [Sun, 18 Mar 2007 09:54:56 +0000 (09:54 +0000)]
Land corrected results for frame changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLand corrected results for frame changes.
hyatt [Sun, 18 Mar 2007 09:54:02 +0000 (09:54 +0000)]
Land corrected results for frame changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20277 268f45cc-cd09-0410-ab3c-d52691b4dbfc