alp@webkit.org [Fri, 16 Nov 2007 22:27:03 +0000 (22:27 +0000)]
2007-11-16 Doug Turner <dougt@meer.net>
Reviewed by Alp.
http://bugs.webkit.org/show_bug.cgi?id=16018
build bustage when building on debian 4.0
Fix build bustage on GTK+ with older versions of Pango.
Don't cache the return value since the docs say it can change.
* platform/gtk/Language.cpp:
(WebCore::defaultLanguage):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27858
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 16 Nov 2007 21:55:14 +0000 (21:55 +0000)]
Windows build fix
* JavaScriptCore.vcproj/testkjs/testkjs.vcproj: Add a new include path
and ignore the int -> bool conversion warning.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27857
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan@apple.com [Fri, 16 Nov 2007 19:21:42 +0000 (19:21 +0000)]
Reviewed by Brady
* WebKit.exp:
Exported some new database-related symbols
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27856
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Fri, 16 Nov 2007 19:06:23 +0000 (19:06 +0000)]
* WebKit.xcodeproj/project.pbxproj: WebDatabaseManagerPrivate.h, also!
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27855
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Fri, 16 Nov 2007 18:59:25 +0000 (18:59 +0000)]
* WebKit.xcodeproj/project.pbxproj: Mark WebSecurityOriginPrivate.h private so
it is exported
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27854
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Fri, 16 Nov 2007 17:34:57 +0000 (17:34 +0000)]
WebKit/mac:
Reviewed by John
Database management API tweaks
Fleshed out "WebSecurityOrigin" to be the API object representing an origin. This relieves some
burden off WebDatabaseManager and allows usage/quota operations on the SecurityOrigin object itself
Also added a new subdirectory for Storage related API - Why are we afraid to add new directories to
the WebKit tree?
* Misc/WebSecurityOrigin.mm: Removed.
* Misc/WebSecurityOriginInternal.h: Removed.
* Misc/WebSecurityOriginPrivate.h: Removed.
* Storage/WebDatabaseManager.mm: Work in terms of WebSecurityOrigin
* Storage/WebDatabaseManagerPrivate.h:
* Storage/WebSecurityOrigin.mm: Added.
(-[WebSecurityOriginPrivate initWithProtocol:domain:port:]):
(-[WebSecurityOriginPrivate initWithWebCoreSecurityOrigin:]):
(-[WebSecurityOriginPrivate finalize]):
(-[WebSecurityOriginPrivate dealloc]):
(-[WebSecurityOrigin initWithProtocol:domain:]):
(-[WebSecurityOrigin initWithProtocol:domain:port:]):
(-[WebSecurityOrigin protocol]):
(-[WebSecurityOrigin domain]):
(-[WebSecurityOrigin port]):
(-[WebSecurityOrigin usage]):
(-[WebSecurityOrigin quota]):
(-[WebSecurityOrigin setQuota:]): Clients will set quotas on the WebSecurityOrigin object itself
(-[WebSecurityOrigin dealloc]):
(-[WebSecurityOrigin _initWithWebCoreSecurityOriginData:]):
* Storage/WebSecurityOriginInternal.h: Added.
* Storage/WebSecurityOriginPrivate.h: Added.
WebKit:
Reviewed by John
Database management API tweaks
* WebKit.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27853
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Fri, 16 Nov 2007 17:25:17 +0000 (17:25 +0000)]
Build fix
* platform/SecurityOriginData.h:
(WebCore::operator!=): Whoops!
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27852
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Fri, 16 Nov 2007 17:13:20 +0000 (17:13 +0000)]
Reviewed by Sam
Further purify DatabaseTracker to use SecurityOriginData instead of "a String"
* WebCore.base.exp:
* WebCore.xcodeproj/project.pbxproj:
* WebCore.vcproj/WebCore.vcproj
* WebCore.pro
* platform/SecurityOriginData.cpp: Added.
(WebCore::SecurityOriginData::SecurityOriginData): Add a constructor that takes a "stringIdentifier"-style string,
since that form is what will be stored in the Databases.db on disk
(WebCore::SecurityOriginData::stringIdentifier):
* platform/SecurityOriginData.h:
(WebCore::SecurityOriginData::protocol):
(WebCore::SecurityOriginData::host):
(WebCore::SecurityOriginData::port):
* storage/DatabaseTracker.cpp:
(WebCore::SecurityOriginDataHash::hash): Follow the pattern Darin set in FontCache.cpp to make a decent hash for
a SecurityOriginData object
(WebCore::SecurityOriginDataHash::equal):
(WebCore::SecurityOriginDataTraits::deletedValue): "file::1" will never exist in normal operation
(WebCore::SecurityOriginDataTraits::emptyValue): "file::2" will never exist in normal operation
(WebCore::DatabaseTracker::fullPathForDatabase):
(WebCore::DatabaseTracker::populateOrigins):
(WebCore::DatabaseTracker::origins):
(WebCore::DatabaseTracker::addDatabase):
* storage/DatabaseTracker.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27851
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Fri, 16 Nov 2007 12:22:34 +0000 (12:22 +0000)]
Rubberstamped by Eric.
Full update of the SVG pixel tests - all files containing text show rendering improvements.
Text looks more 'bold' as it's supposed to be according to the W3C reference rendering, not
sure what commit actually caused it - but it's better now.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27850
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Fri, 16 Nov 2007 12:20:01 +0000 (12:20 +0000)]
Windows build fix.
* WebCore.vcproj/WebCore.vcproj: Removed VoidCallback.cpp, added JSCustomVoidCallback.{h,cpp}.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27849
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Fri, 16 Nov 2007 11:20:56 +0000 (11:20 +0000)]
Reviewed by Eric.
Fixes: http://bugs.webkit.org/show_bug.cgi?id=12290
Implement all SVGTextContentElement DOM methods.
This is the last missing SVG text feature. SVG fonts is next.
Added testcase: svg/custom/text-dom-01-f.svg (tests all new methods)
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27848
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Fri, 16 Nov 2007 10:49:40 +0000 (10:49 +0000)]
Fix Windows debug build.
Rubber-stamped by Eric
* pcre/pcre_exec.cpp: (match): Removed ASSERT_NOT_REACHED assertions that were making MSVC
complain about unreachable code.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27847
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Fri, 16 Nov 2007 07:47:52 +0000 (07:47 +0000)]
2007-11-15 Mark Rowe <mrowe@apple.com>
Gtk build fix.
* kjs/Parser.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27846
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Fri, 16 Nov 2007 07:44:18 +0000 (07:44 +0000)]
Mac build and header search path sanity fix.
Reviewed by Sam Weinig and Tim Hatcher.
Move base setting for HEADER_SEARCH_PATHS into Base.xcconfig, and extend
it in JavaScriptCore.xcconfig. This removes the need to override it on a
per-target basis inside the .xcodeproj file.
* Configurations/Base.xcconfig:
* Configurations/JavaScriptCore.xcconfig:
* JavaScriptCore.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27845
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Fri, 16 Nov 2007 07:08:05 +0000 (07:08 +0000)]
2007-11-15 Mark Rowe <mrowe@apple.com>
Qt build fix.
* kjs/Parser.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27844
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele@apple.com [Fri, 16 Nov 2007 07:00:50 +0000 (07:00 +0000)]
WebCore:
Reviewed by Oliver.
Fix for <rdar://problem/
5566652> CrashTracer: [USER] 3 crashes in Safari at HTMLSelectElement::menuListDefaultEventHandler (reproducible on mactc30.com)
Test: fast/forms/menulist-no-renderer-onmousedown.html
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::defaultEventHandler): Nil check the renderer here. None of the default behavior makes sense if there's no renderer.
(WebCore::HTMLSelectElement::listBoxDefaultEventHandler): Moved the nil check to the main defaultEventHandler.
LayoutTests:
Reviewed by Oliver.
Test for <rdar://problem/
5566652> CrashTracer: [USER] 3 crashes in Safari at HTMLSelectElement::menuListDefaultEventHandler (reproducible on mactc30.com)
* fast/forms/menulist-no-renderer-onmousedown-expected.txt: Added.
* fast/forms/menulist-no-renderer-onmousedown.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27843
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Fri, 16 Nov 2007 06:54:09 +0000 (06:54 +0000)]
Reviewed by Eric Seidel.
Another round of grammar / parsing cleanup.
1. Created distinct parser calls for parsing function bodies vs
programs. This will help later with optimizing global variable access.
2. Turned Parser into a singleton. Cleaned up Lexer's singleton
interface.
3. Modified Lexer to free a little more memory when done lexing. (Added
FIXMEs for similar issues that I didn't fix.)
4. Changed Lexer::makeIdentifier and Lexer::makeUString to start
respecting the arguments passed to them. (No behavior change, but this
problem could have caused serious problems for an unsuspecting user of
these functions.)
5. Removed KJS_DEBUG_MEM because it was bit-rotted.
6. Removed Parser::prettyPrint because the same work was simpler to do
at the call site.
7. Some renames:
"Parser::accept" => "Parser::didFinishParsing"
"Parser::sid" => "Parser::m_sourceID"
"Lexer::doneParsing" => "Lexer::clear"
"sid" => "sourceId"
"lineno" => "lineNo"
* JavaScriptCore.exp:
* kjs/Parser.cpp:
(KJS::Parser::Parser):
(KJS::Parser::parseProgram):
(KJS::Parser::parseFunctionBody):
(KJS::Parser::parse):
(KJS::Parser::didFinishParsing):
(KJS::parser):
* kjs/Parser.h:
(KJS::Parser::sourceId):
* kjs/function.cpp:
(KJS::GlobalFuncImp::callAsFunction):
* kjs/function_object.cpp:
(FunctionObjectImp::construct):
* kjs/grammar.y:
* kjs/interpreter.cpp:
(KJS::Interpreter::checkSyntax):
(KJS::Interpreter::evaluate):
* kjs/interpreter.h:
* kjs/lexer.cpp:
(kjsyylex):
(KJS::lexer):
(KJS::Lexer::Lexer):
(KJS::Lexer::~Lexer):
(KJS::Lexer::scanRegExp):
(KJS::Lexer::doneParsing):
(KJS::Lexer::makeIdentifier):
(KJS::Lexer::makeUString):
* kjs/lexer.h:
(KJS::Lexer::pattern):
(KJS::Lexer::flags):
(KJS::Lexer::sawError):
* kjs/nodes.cpp:
(KJS::Node::Node):
(KJS::FunctionBodyNode::FunctionBodyNode):
* kjs/nodes.h:
* kjs/testkjs.cpp:
(prettyPrintScript):
(kjsmain):
* kjs/ustring.cpp:
* kjs/ustring.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27842
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Fri, 16 Nov 2007 06:25:36 +0000 (06:25 +0000)]
Reviewed by Adele.
Fix <rdar://problem/
5601598>
The movie tag should do initialization on need and not during startup.
Initialize Movie MIME type hash on demand
* platform/MIMETypeRegistry.cpp:
(WebCore::initialiseSupportedMovieMIMETypes):
(WebCore::initialiseMIMETypeRegistry):
(WebCore::MIMETypeRegistry::isSupportedMovieMIMEType):
(WebCore::MIMETypeRegistry::getSupportedMovieMIMETypes):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27841
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Fri, 16 Nov 2007 06:18:22 +0000 (06:18 +0000)]
2007-11-15 Mark Rowe <mrowe@apple.com>
Build fix for Qt on Windows.
* xml/XPathStep.cpp:
(WebCore::XPath::Step::nodesInAxis):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27840
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Fri, 16 Nov 2007 06:15:18 +0000 (06:15 +0000)]
Reviewed by Mark Rowe.
Bug 14761: Web Inspector leaks JS objects and DOM nodes
http://bugs.webkit.org/show_bug.cgi?id=14761
* page/InspectorController.cpp:
(WebCore::InspectorController::~InspectorController):
Change the tear down order so that inspectorDestroyed() is called before
InspectorController private data is set to Zero. The inspectorDestroyed()
call ends up closing the WebView and triggering InspectorController::close()
which unprotects m_scriptObject. This didn't happen when the private data
was cleared before calling inspectorDestroyed().
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27839
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Fri, 16 Nov 2007 06:10:30 +0000 (06:10 +0000)]
2007-11-15 Mark Rowe <mrowe@apple.com>
Gtk build fix.
* WebCore.pro:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27838
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Fri, 16 Nov 2007 06:04:45 +0000 (06:04 +0000)]
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=15989
XPath queries with predicates incorrectly retains the current node across unions
Test: fast/xpath/union-context-node.xhtml
* xml/XPathPath.cpp:
(WebCore::XPath::LocationPath::evaluate): Restore context after evaluation.
* xml/XPathStep.cpp:
(WebCore::XPath::Step::evaluate): Do not backup context, as we can easily re-create it.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27837
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Fri, 16 Nov 2007 06:02:20 +0000 (06:02 +0000)]
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=15448
Import XPath test suite from amachang.art-code.org
Test by Hitoshi Amano <seijro@gmail.com>.
* fast/xpath/xpath-functional-test-expected.txt: Added.
* fast/xpath/xpath-functional-test.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27836
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Fri, 16 Nov 2007 06:00:53 +0000 (06:00 +0000)]
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=15988
REGRESSION: XPath preceding-axis query misses nested elements
Test: fast/xpath/preceding-axis.xhtml
* xml/XPathStep.cpp:
(WebCore::XPath::Step::nodesInAxis): Hopefully correct this time.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27835
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Fri, 16 Nov 2007 01:21:32 +0000 (01:21 +0000)]
Reviewed by Mark Rowe and Sam.
This corrects a couple of issues in the Web Inspector where selected search results
would not have the right text color when the window is inactive or the results are focused.
* page/inspector/inspector.css:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27834
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Fri, 16 Nov 2007 01:04:48 +0000 (01:04 +0000)]
Reviewed by Sam.
Bug 16007: REGRESSION: Disclosure triangle click zone for resource categories is off by 10 pixels
http://bugs.webkit.org/show_bug.cgi?id=16007
Makes the click width an option on TreeElement and make ResourceCategoryTreeElement
a true subclass of TreeElement. The click width for ResourceCategoryTreeElement is
20 pixels, and the default is 10 pixels.
* page/inspector/ResourceCategory.js:
* page/inspector/treeoutline.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27833
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 16 Nov 2007 00:42:55 +0000 (00:42 +0000)]
Reviewed by Brady.
Pass a VoidCallback to Database::transaction and Database::changeVersion.
This is not yet hooked up to the database machinery.
* WebCore.vcproj/WebCore.vcproj:
* bindings/js/JSDatabaseCustom.cpp:
(WebCore::JSDatabase::changeVersion):
(WebCore::JSDatabase::transaction):
* storage/Database.cpp:
(WebCore::Database::changeVersion):
(WebCore::Database::transaction):
* storage/Database.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27832
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Fri, 16 Nov 2007 00:40:24 +0000 (00:40 +0000)]
<rdar://problem/
5601548> REGRESSION: All SourceElements and their children leak after a syntax error
Reviewed by Darin.
Add a stub node to maintain the Vector of SourceElements until assignment.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27831
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 16 Nov 2007 00:17:54 +0000 (00:17 +0000)]
2007-11-15 Eric Seidel <eric@webkit.org>
Reviewed by Sam.
Abstract most of RMATCH into MatchStack functions.
SunSpider claims this, combined with the last 2 patches was a 1% speedup, 10% for dna-regexp.
* pcre/pcre_exec.cpp:
(MatchStack::canUseStackBufferForNextFrame):
(MatchStack::allocateNextFrame):
(MatchStack::pushNewFrame):
(MatchStack::frameIsStackAllocated):
(MatchStack::popCurrentFrame):
(MatchStack::unrollAnyHeapAllocatedFrames):
(match):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27830
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 16 Nov 2007 00:16:21 +0000 (00:16 +0000)]
2007-11-15 Eric Seidel <eric@webkit.org>
Reviewed by Sam.
Remove RETURN_ERROR, add MatchStack
* pcre/pcre_exec.cpp:
(MatchStack::MatchStack):
(MatchStack::unrollAnyHeapAllocatedFrames):
(matchError):
(match):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27829
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 16 Nov 2007 00:14:33 +0000 (00:14 +0000)]
2007-11-15 Eric Seidel <eric@webkit.org>
Reviewed by Sam.
Clean up match function to match WebKit style
* JavaScriptCore.xcodeproj/project.pbxproj:
* pcre/pcre_exec.cpp:
(match):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27828
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Fri, 16 Nov 2007 00:07:44 +0000 (00:07 +0000)]
Reviewed by Adam.
Bug 16005: Hovering in the breadcrumbs causes jumpy behavior
http://bugs.webkit.org/show_bug.cgi?id=16005
Hovering over cumbs no longer exposes new crumbs. Clicking on a collapsed
crumb will expose as many hidden crumbs as possible to the user. Also crumbs
that have ID attributes will compact to the ID over the tag name.
* page/inspector/DocumentPanel.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27827
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 15 Nov 2007 23:53:19 +0000 (23:53 +0000)]
Reviewed by Sam.
Make the VoidCallback DOM interface behave more like our other DOM interfaces.
* bindings/js/JSCustomVoidCallback.h: Added.
* bindings/js/JSCustomVoidCallback.cpp: Added.
(WebCore::JSCustomVoidCallback::JSCustomVoidCallback):
(WebCore::JSCustomVoidCallback::handleEvent):
VoidCallback implementation that wraps a JS object.
(WebCore::toVoidCallback):
New method that creates a VoidCallback implementation given a JS object.
* bindings/scripts/CodeGeneratorJS.pm:
Specify that VoidCallback can fail conversion and add a custom conversion function.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::movieCuePointReached):
Call handleEvent on the callback.
(WebCore::HTMLMediaElement::removeCuePoint):
Comment out parts of this method, it has already been removed in the HTML5 spec and it relies
on overriding VoidCallback equality.
* html/VoidCallback.cpp: Removed.
* html/VoidCallback.h:
(WebCore::VoidCallback::VoidCallback):
(WebCore::VoidCallback::~VoidCallback):
Make this an abstract class with a pure virtual handleEvent method.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27826
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 15 Nov 2007 23:42:41 +0000 (23:42 +0000)]
Fix <rdar://
5485108> Type-select while a <select> menu is open doesn't work
There were two things broken here:
- WebView now requires a WM_CHAR message to be sent before it will
create a keyboard event with a charCode, but we were only sending
a WM_KEYDOWN event.
- The popup menu was not updating its focused index when the
<select> element's selectedIndex changed.
Reviewed by Adele.
* platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenu::updateFromElement): Update the focused index from
the client's selected index.
(WebCore::PopupWndProc): When we receive a WM_CHAR message for a
printable character, manufacture a WM_KEYDOWN message for it and post
both that and the current WM_CHAR message to the WebView.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27825
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Thu, 15 Nov 2007 23:23:54 +0000 (23:23 +0000)]
Build fix
* storage/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::fullPathForDatabase):
(WebCore::DatabaseTracker::databaseNamesForOrigin):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27824
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justin.garcia@apple.com [Thu, 15 Nov 2007 22:54:29 +0000 (22:54 +0000)]
Forgot this new expected result in my previous check-in.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27823
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Thu, 15 Nov 2007 22:29:34 +0000 (22:29 +0000)]
Reviewed by John and Sam
Stubbing out everything required for a WebKit API for databases
Biggest change in WebCore is that we passed around SecurityOriginData as the representation
of a SecurityOrigin, instead of a String or a SecurityOrigin itself (which is an opaque object
that has a different purpose besides just hanging on to the data)
* WebCore.base.exp:
* WebCore.xcodeproj/project.pbxproj:
* platform/SecurityOrigin.cpp:
* platform/SecurityOrigin.h:
* platform/SecurityOriginData.h: Added. Simple object to encapsulate the 3
pieces of data in the SecurityOrigin tuple
(WebCore::SecurityOriginData::SecurityOriginData):
(WebCore::SecurityOriginData::protocol):
(WebCore::SecurityOriginData::host):
(WebCore::SecurityOriginData::port):
(WebCore::SecurityOriginData::toString): Simple concatenation of the 3 components,
colon separated
* storage/Database.cpp:
(WebCore::Database::Database): Use SecurityOriginData instead
* storage/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::fullPathForDatabase):
(WebCore::DatabaseTracker::databaseNamesForOrigin):
(WebCore::DatabaseTracker::deleteDatabasesWithOrigin):
(WebCore::DatabaseTracker::deleteDatabase):
* storage/DatabaseTracker.h:
* storage/DatabaseTrackerClient.h: Added. For dispatching notifications up to WebKit
(WebCore::DatabaseTrackerClient::~DatabaseTrackerClient):2007-11-15 Jon Honeycutt <jhoneycutt@apple.com>
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27822
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Thu, 15 Nov 2007 22:27:14 +0000 (22:27 +0000)]
WebCore:
Reviewed by John and Sam
Stubbing out everything required for a WebKit API for databases
Biggest change in WebCore is that we passed around SecurityOriginData as the representation
of a SecurityOrigin, instead of a String or a SecurityOrigin itself (which is an opaque object
that has a different purpose besides just hanging on to the data)
* WebCore.base.exp:
* WebCore.xcodeproj/project.pbxproj:
* platform/SecurityOrigin.cpp:
* platform/SecurityOrigin.h:
* platform/SecurityOriginData.h: Added. Simple object to encapsulate the 3
pieces of data in the SecurityOrigin tuple
(WebCore::SecurityOriginData::SecurityOriginData):
(WebCore::SecurityOriginData::protocol):
(WebCore::SecurityOriginData::host):
(WebCore::SecurityOriginData::port):
(WebCore::SecurityOriginData::toString): Simple concatenation of the 3 components,
colon separated
* storage/Database.cpp:
(WebCore::Database::Database): Use SecurityOriginData instead
* storage/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::fullPathForDatabase):
(WebCore::DatabaseTracker::databaseNamesForOrigin):
(WebCore::DatabaseTracker::deleteDatabasesWithOrigin):
(WebCore::DatabaseTracker::deleteDatabase):
* storage/DatabaseTracker.h:
* storage/DatabaseTrackerClient.h: Added. For dispatching notifications up to WebKit
(WebCore::DatabaseTrackerClient::~DatabaseTrackerClient):
WebKit:
Reviewed by John
Stubbing out everything required for a WebKit API for databases
* WebKit.xcodeproj/project.pbxproj:
WebKit/mac:
Reviewed by John
Stubbing out everything required for a WebKit API for databases
These interfaces seem to provide everything we need for UI and management at the browser level
* Misc/WebDatabaseManager.h: Removed.
* Misc/WebDatabaseManager.mm: Removed.
* Misc/WebDatabaseManagerPrivate.h: Removed.
* Misc/WebSecurityOrigin.mm: Added. Object that acts as a container for the "SecurityOrigin tuple"
(protocol, domain, and port)
(-[WebSecurityOriginPrivate initWithProtocol:domain:port:]):
(-[WebSecurityOriginPrivate dealloc]):
(-[WebSecurityOrigin initWithProtocol:domain:]):
(-[WebSecurityOrigin initWithProtocol:domain:port:]):
(-[WebSecurityOrigin protocol]):
(-[WebSecurityOrigin domain]):
(-[WebSecurityOrigin port]):
(-[WebSecurityOrigin dealloc]):
(-[WebSecurityOrigin _initWithWebCoreSecurityOriginData:WebCore::]):
* Misc/WebSecurityOriginInternal.h: Added.
* Misc/WebSecurityOriginPrivate.h: Added.
* Storage/WebDatabaseManager.mm: Added.
(+[WebDatabaseManager sharedWebDatabaseManager]):
(-[WebDatabaseManager origins]): Get a list of all origins currently tracked
(-[WebDatabaseManager detailsForOrigin:]): Get the current usage and current quota for the given origin
(-[WebDatabaseManager databasesWithOrigin:]): Get all databases for a certain origin
(-[WebDatabaseManager detailsForDatabase:withOrigin:]): Get all details about a specific database
(-[WebDatabaseManager setQuota:forOrigin:]): Change origin-wide quota
(-[WebDatabaseManager deleteAllDatabases]):
(-[WebDatabaseManager deleteAllDatabasesWithOrigin:]):
(-[WebDatabaseManager deleteDatabase:withOrigin:]):
* Storage/WebDatabaseManagerPrivate.h: Added.
* Storage/WebDatabaseManagerInternal.h: Added.
(WebKitInitializeDatabasesIfNecessary): One-time initialization of database-related things
* Storage/WebDatabaseTrackerClient.h: Added. Stubbed out client for notifications
* Storage/WebDatabaseTrackerClient.mm: Added.
(WebDatabaseTrackerClient::sharedWebDatabaseTrackerClient):
(WebDatabaseTrackerClient::WebDatabaseTrackerClient):
(WebDatabaseTrackerClient::~WebDatabaseTrackerClient):
(WebDatabaseTrackerClient::dispatchDidModifyOrigin):
(WebDatabaseTrackerClient::dispatchDidModifyDatabase):
* WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]): Do one-time initialization of
Database-related things here
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27821
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jhoneycutt@apple.com [Thu, 15 Nov 2007 22:23:42 +0000 (22:23 +0000)]
2007-11-15 Jon Honeycutt <jhoneycutt@apple.com>
Reviewed by Anders.
NP_ASFILEONLY streams should not buffer data in m_deliveryData.
* plugins/win/PluginStreamWin.cpp:
(WebCore::PluginStreamWin::didReceiveData):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27820
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 15 Nov 2007 22:02:47 +0000 (22:02 +0000)]
Revert accidental change. andersca--
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27819
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justin.garcia@apple.com [Thu, 15 Nov 2007 21:52:41 +0000 (21:52 +0000)]
WebCore:
Reviewed by Adele Peterson.
<rdar://problem/
5497643> Crash at Node::isDescendantOf when switching out of Edit HTML Source mode
A textarea that contained the selection was removed but the selection wasn't cleared,
and we'd crash in code that assumed a valid, in-document selection.
* editing/SelectionController.cpp:
(WebCore::removingNodeRemovesPosition): Clear the selection if the node being removed is the
shadowAncestorNode of the node that contains the position, not just if the node being removed
contains that shadowAncestorNode.
LayoutTests:
Reviewed by Adele Peterson.
<rdar://problem/
5497643> Crash at Node::isDescendantOf when switching out of Edit HTML Source mode
* editing/selection/
5497643-expected.txt: Added.
* editing/selection/
5497643.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27818
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 15 Nov 2007 21:35:28 +0000 (21:35 +0000)]
Make run-safari actually work on Windows
* Scripts/run-safari: Fixed the order of arguments to cp, and added a
chdir call.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27817
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Thu, 15 Nov 2007 21:22:57 +0000 (21:22 +0000)]
Reviewed by Maciej.
Fix logic error: calculateGlyphBoundaries takes RTL text into account itself, no need to adjust offsets before.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27816
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 15 Nov 2007 20:27:44 +0000 (20:27 +0000)]
WebCore:
Reviewed by Brady.
<rdar://problem/
5562470>
openDatabase does not work when the version string is empty
If the string is empty, pass a real empty string to sqlite3_bind_text16.
* platform/sql/SQLiteStatement.cpp:
(WebCore::SQLiteStatement::bindText):
LayoutTests:
Reviewed by Brady.
<rdar://problem/
5562470>
openDatabase does not work when the version string is empty
* storage/open-database-empty-version-expected.txt: Added.
* storage/open-database-empty-version.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27815
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 15 Nov 2007 19:49:25 +0000 (19:49 +0000)]
Reviewed by Brady.
Get rid of SQLiteStatement::bindText and rename bindText16 to bindText.
Remove the copy parameter from bindText and bindBlob and always copy passed in data instead.
* loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::setIconIDForPageURLInSQLDatabase):
(WebCore::IconDatabase::removePageURLFromSQLDatabase):
(WebCore::IconDatabase::getIconIDForIconURLFromSQLDatabase):
(WebCore::IconDatabase::addIconURLToSQLDatabase):
(WebCore::IconDatabase::getImageDataForIconURLFromSQLDatabase):
(WebCore::IconDatabase::writeIconSnapshotToSQLDatabase):
* platform/sql/SQLiteStatement.cpp:
(WebCore::SQLiteStatement::prepare):
* platform/sql/SQLiteStatement.h:
* storage/Database.cpp:
(WebCore::setTextValueInDatabase):
* storage/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::fullPathForDatabase):
(WebCore::DatabaseTracker::databaseNamesForOrigin):
(WebCore::DatabaseTracker::addDatabase):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27813
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Thu, 15 Nov 2007 18:39:19 +0000 (18:39 +0000)]
Windows build fix.
* JavaScriptCore.vcproj/JavaScriptCore.make:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27812
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Thu, 15 Nov 2007 08:01:00 +0000 (08:01 +0000)]
WebCore:
Rubberstamped by Sam
* platform/SecurityOrigin.h: Lets make this an unsigned short and *not* rule out half the possible ports?
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27811
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Thu, 15 Nov 2007 05:59:40 +0000 (05:59 +0000)]
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=15982
Improve JSString UTF-8 decoding
* API/JSStringRef.cpp:
(JSStringCreateWithUTF8CString): Use strict decoding, return 0 on error.
* wtf/unicode/UTF8.cpp:
(WTF::Unicode::convertUTF16ToUTF8):
(WTF::Unicode::convertUTF8ToUTF16):
* wtf/unicode/UTF8.h:
Made these function names start with a lower case letter.
* kjs/ustring.cpp: (KJS::UString::UTF8String): Updated for the above renaming.
* bindings/c/c_utility.cpp:
(KJS::Bindings::convertUTF8ToUTF16WithLatin1Fallback): Renamed to highlight the difference
from convertUTF8ToUTF16 in wtf/unicode.
(KJS::Bindings::convertNPStringToUTF16): Updated for the above renaming.
(KJS::Bindings::identifierFromNPIdentifier): Ditto.
* bindings/c/c_utility.h: Made convertUTF8ToUTF16WithLatin1Fallback() a file static.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27810
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Thu, 15 Nov 2007 05:49:44 +0000 (05:49 +0000)]
Reviewed by Justin Garcia.
http://bugs.webkit.org/show_bug.cgi?id=15781
REGRESSION: Ligatures fail to form when typing in Devanagari (because WebKit can't handle
a marked range that covers half of a composed character sequence)
Test: platform/mac/editing/input/devanagari-ligature.html
This fix is somewhat of a hack, as it asks editing commands to work with invalid selections.
However, this is not entirely new for them, as Roman accents are typed in a similar manner.
In the future, we probably want to make commands work with ranges (or Positions explicitly).
* editing/Editor.cpp:
(WebCore::Editor::selectComposition): Force selection to composition range.
* editing/InsertTextCommand.cpp:
(WebCore::InsertTextCommand::input): Force ending selection to inserted text range.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27809
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Thu, 15 Nov 2007 05:17:40 +0000 (05:17 +0000)]
Rubber-stamped by Anders.
Fix the Xcode project file after it was messed up in r27402.
* JavaScriptCore.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27808
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 15 Nov 2007 02:40:31 +0000 (02:40 +0000)]
2007-11-14 Eric Seidel <eric@webkit.org>
Reviewed by Oliver.
More PCRE style cleanup.
* pcre/pcre_compile.cpp:
(compile_regex):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27807
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 15 Nov 2007 02:02:33 +0000 (02:02 +0000)]
Clean up the bison conflict checking script
Reviewed by Geoff.
* DerivedSources.make:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27806
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 15 Nov 2007 02:00:15 +0000 (02:00 +0000)]
2007-11-14 Eric Seidel <eric@webkit.org>
Reviewed by Geoff.
Another round of PCRE cleanups: inlines
SunSpider claims that this, combined with my previous PCRE cleanup were a 0.7% speedup, go figure.
* pcre/pcre_compile.cpp:
(jsRegExpCompile):
* pcre/pcre_exec.cpp:
(match):
(jsRegExpExecute):
* pcre/pcre_internal.h:
(PUT):
(GET):
(PUT2):
(GET2):
(isNewline):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27805
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Thu, 15 Nov 2007 01:55:34 +0000 (01:55 +0000)]
For future use
* images/DroseraPic.png: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27804
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 15 Nov 2007 01:34:59 +0000 (01:34 +0000)]
Updates to Safari launching now that 3.0.4 is released
Reviewed by Sam.
* FindSafari/FindSafari.cpp:
(getWebViewCLSID): Use version-independent ProgID.
* Scripts/run-safari: Use run-webkit-nightly.cmd.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27803
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 15 Nov 2007 01:17:31 +0000 (01:17 +0000)]
2007-11-14 Eric Seidel <eric@webkit.org>
Reviewed by Sam.
Give PCRE a (small) bath.
Fix some formating and break things off into separate functions
http://bugs.webkit.org/show_bug.cgi?id=15993
* pcre/pcre_compile.cpp:
(calculateCompiledPatternLengthAndFlags):
(printCompiledRegExp):
(returnError):
(jsRegExpCompile):
* pcre/pcre_internal.h:
(compile_data::compile_data):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27802
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Thu, 15 Nov 2007 01:04:40 +0000 (01:04 +0000)]
Try to make this test less timing dependent.
* http/tests/media/video-play-stall.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27801
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin@apple.com [Wed, 14 Nov 2007 23:48:52 +0000 (23:48 +0000)]
WebCore:
Reviewed by Hyatt.
Fix for <rdar://problem/
5540855> REGRESSION: Combination of client-
side image map and <a> tag is not working properly (15522)
* html/HTMLMapElement.cpp:
(WebCore::HTMLMapElement::checkDTD): Allow <map> to have both block
and inline children rather than just block children. This matches
Firefox.
LayoutTests:
Reviewed by Hyatt.
Tests for <rdar://problem/
5540855> REGRESSION: Combination of
client-side image map and <a> tag is not working properly (15522)
New test:
* fast/images/image-map-anchor-children.html: Added.
* fast/images/resources/boston.gif: Added.
* platform/mac/fast/images/image-map-anchor-children-
expected.checksum: Added.
* platform/mac/fast/images/image-map-anchor-children-expected.png:
Added.
* platform/mac/fast/images/image-map-anchor-children-expected.txt:
Added.
This test was broken and is fixed now! I had to edit the test
itself because it was written in the html that the two <map>
examples were failing, but now they succeed.
* fast/invalid/residual-style.html:
* platform/mac/fast/invalid/residual-style-expected.checksum:
* platform/mac/fast/invalid/residual-style-expected.png:
* platform/mac/fast/invalid/residual-style-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27800
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Wed, 14 Nov 2007 22:59:29 +0000 (22:59 +0000)]
Reviewed by Eric Seidel.
Cleaned up the JavaScript grammar a bit.
1. Changed BlockNode to always hold a child vector (which may be empty),
eliminating a few NULL-check branches in the common execution case.
2. Changed the Block production to correctly report its starting and
ending line numbers to the debugger. (It used to report its ending line
as its starting line.) Also, removed duplicate line-reporting code
inside the BlockNode constructor.
3. Moved curly braces up from FunctionBody production into parent
productions. (I had to move the line number reporting code, too, since
it depends on the location of the curly braces.) This matches the ECMA
spec more closely, and makes some future changes I plan easier.
4. Fixed statementList* convenience functions to deal appropriately with
empty Vectors.
SunSpider reports a small and statistically insignificant speedup.
* kjs/grammar.y:
* kjs/nodes.cpp:
(KJS::statementListPushFIFO):
(KJS::statementListGetDeclarations):
(KJS::statementListInitializeDeclarationStack):
(KJS::statementListInitializeVariableAccessStack):
(KJS::BlockNode::BlockNode):
(KJS::BlockNode::optimizeVariableAccess):
(KJS::BlockNode::getDeclarations):
(KJS::BlockNode::execute):
(KJS::FunctionBodyNode::initializeDeclarationStacks):
(KJS::FunctionBodyNode::optimizeVariableAccess):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27799
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Wed, 14 Nov 2007 22:57:45 +0000 (22:57 +0000)]
Change Interfaces to be a "Static Library" project
Being a Utility project meant that Interfaces was rebuilding every
time (Utility projects are supposed to handle their own dependencies).
Interfaces isn't really a static library, but it means that VS will
handle dependencies for us (and not complain about missing manifests
like it did when the project was an Application).
* WebKit.vcproj/Interfaces.vcproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27798
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Wed, 14 Nov 2007 22:56:44 +0000 (22:56 +0000)]
Shut up FixMIDLHeaders.pl
* WebKit.vcproj/FixMIDLHeaders.pl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27797
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justin.garcia@apple.com [Wed, 14 Nov 2007 22:33:07 +0000 (22:33 +0000)]
WebCore:
Reviewed by Alexey Proskuryakov.
<rdar://problem/
5546763> CrashTracer: [USER] 362 crashes at WebCore::DeleteSelectionCommand::mergeParagraphs
* editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::handleGeneralDelete):
Removed an irrelevant FIXME.
(WebCore::DeleteSelectionCommand::mergeParagraphs): If the block that contained the end of the selection
hasn't been removed but has been emptied by deletion, we would to try and fail to create a VisiblePosition
inside that block, which could lead to a crash. If that happens, there's no content in the block to move,
so just remove the block and return.
Preserve m_needPlaceholder during the call to moveParagraphs, since it may change it and since it does
its own placeholder insertion when necessary.
(WebCore::DeleteSelectionCommand::doApply): No need to check m_needPlaceholder before calling mergeParagraphs,
because it handles preserving m_needPlaceholder when it calls moveParagraphs.
LayoutTests:
Reviewed by Alexey Proskuryakov.
<rdar://problem/
5546763> CrashTracer: [USER] 362 crashes at WebCore::DeleteSelectionCommand::mergeParagraphs
* editing/deleting/
5546763-expected.txt: Added.
* editing/deleting/
5546763.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27796
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 14 Nov 2007 22:30:35 +0000 (22:30 +0000)]
WebKitTools:
Reviewed by Adam.
<rdar://problem/
5309081>
In DRT, "plugin.logDestroy = true" not working on Windows.
* DumpRenderTree/win/TestNetscapePlugin/main.c:
(NPP_Destroy):
LayoutTests:
Reviewed by Adam.
<rdar://problem/
5309081>
In DRT, "plugin.logDestroy = true" not working on Windows.
Remove now succeeding test from the skipped list.
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27795
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Wed, 14 Nov 2007 22:09:44 +0000 (22:09 +0000)]
Remove the WebKit dependancy from WebKitSystemInterface.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27794
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Wed, 14 Nov 2007 22:08:45 +0000 (22:08 +0000)]
Fix ChangeLog order
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27793
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Wed, 14 Nov 2007 22:07:26 +0000 (22:07 +0000)]
Change Interfaces to use a Utility configuration
It had previously been marked as an "Application (.exe)", which is
wrong but worked with most versions of Visual Studio.
Rubberstamped by Steve.
* WebKit.vcproj/Interfaces.vcproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27792
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Wed, 14 Nov 2007 21:44:50 +0000 (21:44 +0000)]
Try to make this test less timing dependent.
* media/video-currentTime-set-expected.txt:
* media/video-currentTime-set.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27791
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Wed, 14 Nov 2007 20:36:28 +0000 (20:36 +0000)]
2007-11-14 Eric Seidel <eric@webkit.org>
Reviewed by Sam.
* sunspider: add --shark-cache for L2 Cache Miss profiling
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27790
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Wed, 14 Nov 2007 19:19:09 +0000 (19:19 +0000)]
Reviewed by Adam.
Bug 14380: Long DOM ancestry breadcrumb lists get cut off
http://bugs.webkit.org/show_bug.cgi?id=14380
The breadcumbs will now be compacted and collapsed if there isn't enough room
to show everything. The collapsing algorithm always affects the crumbs that
are farthest away from the selected or hovered crumb first.
* page/inspector/DocumentPanel.js:
* page/inspector/inspector.css:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27789
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 14 Nov 2007 19:10:50 +0000 (19:10 +0000)]
WebKit/win:
Reviewed by Adam.
Get the new focus window from the wParam instead of calling GetFocus().
Also, send blur even if there is no focused frame.
* WebView.cpp:
(WebViewWndProc):
WebKitTools:
Reviewed by Adam.
<rdar://problem/
5141186>
window.layoutTestController.setWindowIsKey is not implemented in DRT.
Implement setWindowIsKey.
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::setWindowIsKey):
LayoutTests:
Reviewed by Adam.
* platform/win/Skipped:
Remove fast/dom/Window/window-onFocus.html since it succeeds now.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27788
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Wed, 14 Nov 2007 18:53:59 +0000 (18:53 +0000)]
Another build fix for systems without Cygwin in their PATH
* WebKit.vcproj/Interfaces.vcproj: Add Cygwin to the PATH in the
Post-Build Event.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27787
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 14 Nov 2007 18:36:06 +0000 (18:36 +0000)]
Use the correct include path.
* platform/Cursor.h:
* plugins/win/PluginPackageWin.h:
* plugins/win/PluginStreamWin.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27786
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Wed, 14 Nov 2007 06:59:32 +0000 (06:59 +0000)]
2007-11-13 Mark Rowe <mrowe@apple.com>
Gtk build fix. Replace incorrect use of the LOG macro with g_print.
* Api/webkitgtkpage.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27785
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Wed, 14 Nov 2007 06:46:31 +0000 (06:46 +0000)]
WebCore:
Reviewed by Adam
http://bugs.webkit.org/show_bug.cgi?id=15976 - ASSERT/crash when SQLTransactionCallback throws an exception
* storage/SQLTransaction.cpp:
(WebCore::SQLTransaction::deliverTransactionCallback): Make a transaction error for the case where the
SQLTransactionCallback fails
(WebCore::SQLTransaction::deliverTransactionErrorCallback): Don't assert on the error callback, but null check it
and make the commit/rollback decision accordingly
LayoutTests:
Reviewed by Adam
Fix for http://bugs.webkit.org/show_bug.cgi?id=15976
* storage: Added - There will soon be an entire suite in here!
* storage/transaction_callback_exception_crash-expected.txt: Added.
* storage/transaction_callback_exception_crash.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27784
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Wed, 14 Nov 2007 06:25:33 +0000 (06:25 +0000)]
Add the http/tests/media directory to the Windows Skipped file
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27783
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Wed, 14 Nov 2007 05:40:57 +0000 (05:40 +0000)]
2007-11-13 Christian Dywan <christian@twotoasts.de>
Reviewed by Alp.
http://bugs.webkit.org/show_bug.cgi?id=15891
[GTK] Javascript console and dialogs are not implemented
Implement signals for script dialogs and console messages.
* Api/webkitgtk-marshal.list:
* Api/webkitgtkpage.cpp:
* Api/webkitgtkpage.h:
* WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::addMessageToConsole):
(WebKit::ChromeClient::runJavaScriptAlert):
(WebKit::ChromeClient::runJavaScriptConfirm):
(WebKit::ChromeClient::runJavaScriptPrompt):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27782
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Wed, 14 Nov 2007 03:48:44 +0000 (03:48 +0000)]
Fix <rdar://problem/
5365030> calling dataWithPDFInsideRect on an SVG with a gradient crashes (14780)
Reviewed by Anders.
When drawing directly to PDF CG may delay the use of the gradient function until outside our
standard drawing path, which in turn could let us invalidate the caches before they were used.
To work around this we now store the cached stops in a RefCounted object, so that we can ensure
that cache exists as long as required.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27781
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Wed, 14 Nov 2007 03:04:11 +0000 (03:04 +0000)]
Build fix: changed Shared to RefCounted.
* WebCoreSupport/ChromeClientQt.h:
* WebCoreSupport/ContextMenuClientQt.cpp:
* WebCoreSupport/ContextMenuClientQt.h:
* WebCoreSupport/EditorClientQt.h:
* WebCoreSupport/FrameLoaderClientQt.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27780
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 14 Nov 2007 02:33:51 +0000 (02:33 +0000)]
Fix Windows build.
* platform/Cursor.h:
* plugins/win/PluginPackageWin.h:
* plugins/win/PluginStreamWin.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27779
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 14 Nov 2007 02:20:14 +0000 (02:20 +0000)]
Add RefCounted.h (And remove Shared.h)
* JavaScriptCore.vcproj/WTF/WTF.vcproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27778
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Wed, 14 Nov 2007 02:19:24 +0000 (02:19 +0000)]
Build fix.
* kjs/regexp.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27777
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Wed, 14 Nov 2007 02:05:26 +0000 (02:05 +0000)]
JavaScriptCore:
Reviewed by Anders Carlsson.
Renamed Shared to RefCounted.
* API/JSClassRef.h:
* JavaScriptCore.xcodeproj/project.pbxproj:
* kjs/interpreter.h:
* kjs/regexp.h:
* wtf/RefCounted.h: Copied from JavaScriptCore/wtf/Shared.h.
(WTF::RefCounted::RefCounted):
* wtf/Shared.h: Removed.
JavaScriptGlue:
Reviewed by Anders Carlsson.
Renamed Shared to RefCounted.
* ForwardingHeaders/wtf/RefCounted.h: Copied from JavaScriptGlue/ForwardingHeaders/wtf/Shared.h.
* ForwardingHeaders/wtf/Shared.h: Removed.
WebCore:
Reviewed by Anders Carlsson.
Renamed Shared to RefCounted.
* ForwardingHeaders/wtf/RefCounted.h: Copied from WebCore/ForwardingHeaders/wtf/Shared.h.
* ForwardingHeaders/wtf/Shared.h: Removed.
* bindings/js/JSSVGPODTypeWrapper.h:
* css/CSSFontFace.h:
* css/CSSRuleList.h:
* css/Counter.h:
* css/Pair.h:
* css/Rect.h:
* css/StyleBase.h:
* css/StyleSheetList.h:
* dom/Attribute.h:
* dom/Clipboard.h:
* dom/DOMImplementation.h:
* dom/Event.h:
* dom/EventListener.h:
* dom/NamedNodeMap.h:
* dom/NodeFilter.h:
* dom/NodeFilterCondition.h:
* dom/NodeList.h:
* dom/QualifiedName.h:
* dom/Range.h:
* dom/RangeException.h:
* dom/RegisteredEventListener.h:
* dom/Traversal.h:
* editing/EditCommand.h:
* history/BackForwardList.h:
* history/CachedPage.h:
* history/HistoryItem.cpp:
(WebCore::HistoryItem::HistoryItem):
* history/HistoryItem.h:
* html/CanvasGradient.h:
* html/CanvasPattern.h:
* html/CanvasRenderingContext2D.h:
* html/CanvasStyle.h:
* html/HTMLCollection.h:
* html/MediaError.h:
* html/TimeRanges.h:
* html/VoidCallback.h:
* ksvg2/css/SVGRenderStyle.cpp:
(WebCore::SVGRenderStyle::SVGRenderStyle):
* ksvg2/css/SVGRenderStyle.h:
* ksvg2/css/SVGRenderStyleDefs.cpp:
(StyleFillData::StyleFillData):
(StyleStrokeData::StyleStrokeData):
(StyleStopData::StyleStopData):
(StyleTextData::StyleTextData):
(StyleClipData::StyleClipData):
(StyleMaskData::StyleMaskData):
(StyleMarkerData::StyleMarkerData):
(StyleMiscData::StyleMiscData):
* ksvg2/css/SVGRenderStyleDefs.h:
* ksvg2/svg/SVGAngle.cpp:
(WebCore::SVGAngle::SVGAngle):
* ksvg2/svg/SVGAngle.h:
* ksvg2/svg/SVGAnimatedTemplate.h:
* ksvg2/svg/SVGElementInstanceList.h:
* ksvg2/svg/SVGException.h:
* ksvg2/svg/SVGList.h:
* ksvg2/svg/SVGPathSeg.h:
* ksvg2/svg/SVGPreserveAspectRatio.cpp:
(WebCore::SVGPreserveAspectRatio::SVGPreserveAspectRatio):
* ksvg2/svg/SVGPreserveAspectRatio.h:
* ksvg2/svg/SVGRenderingIntent.h:
* ksvg2/svg/SVGTransform.h:
* ksvg2/svg/SVGUnitTypes.h:
* loader/DocumentLoader.h:
* loader/FormState.h:
* loader/ResourceLoader.h:
* loader/TextResourceDecoder.h:
* loader/icon/IconRecord.h:
* page/BarInfo.h:
* page/Console.h:
* page/DOMSelection.h:
* page/DOMWindow.h:
* page/Frame.h:
* page/History.h:
* page/InspectorController.cpp:
* page/Plugin.h:
* page/Screen.h:
* platform/ArrayImpl.h:
* platform/CString.h:
* platform/Cursor.h:
* platform/DeprecatedValueListImpl.cpp:
(WebCore::DeprecatedValueListImpl::Private::Private):
* platform/FileChooser.h:
* platform/FontFallbackList.h:
* platform/FontFamily.cpp:
(WebCore::FontFamily::FontFamily):
* platform/FontFamily.h:
* platform/FontSelector.h:
* platform/GlyphPageTreeNode.h:
* platform/PopupMenu.h:
* platform/RegularExpression.cpp:
* platform/ScrollBar.h:
* platform/SharedBuffer.h:
* platform/StringImpl.h:
* platform/graphics/Icon.h:
* platform/graphics/svg/SVGResource.h:
* platform/network/FormData.cpp:
(WebCore::FormData::FormData):
* platform/network/FormData.h:
* platform/network/ResourceHandle.h:
* platform/network/ResourceHandleClient.h:
* rendering/RenderStyle.cpp:
(WebCore::StyleSurroundData::StyleSurroundData):
(WebCore::StyleBoxData::StyleBoxData):
(WebCore::StyleVisualData::StyleVisualData):
(WebCore::StyleBackgroundData::StyleBackgroundData):
(WebCore::StyleMarqueeData::StyleMarqueeData):
(WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData):
(WebCore::StyleMultiColData::StyleMultiColData):
(WebCore::StyleTransformData::StyleTransformData):
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleInheritedData::StyleInheritedData):
* rendering/RenderStyle.h:
* rendering/SVGCharacterLayoutInfo.h:
(WebCore::SVGCharOnPath::SVGCharOnPath):
* storage/SQLResultSetRowList.h:
* xml/DOMParser.h:
* xml/XMLHttpRequest.h:
* xml/XMLSerializer.h:
* xml/XPathEvaluator.h:
* xml/XPathExpression.h:
* xml/XPathNSResolver.h:
* xml/XPathResult.h:
* xml/XPathValue.h:
* xml/XSLTProcessor.h:
WebKit/mac:
Reviewed by Anders Carlsson.
Renamed Shared to RefCounted.
* ForwardingHeaders/wtf/RefCounted.h: Copied from WebKit/mac/ForwardingHeaders/wtf/Shared.h.
* ForwardingHeaders/wtf/Shared.h: Removed.
* WebCoreSupport/WebContextMenuClient.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27776
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Wed, 14 Nov 2007 01:54:01 +0000 (01:54 +0000)]
Reviewed by Mark Rowe
Remove errantly added files, and fix the idl (for reference's sake)
* storage/JSCustomSQLStatementCallback.h: Removed.
* storage/JSCustomSQLStatementErrorCallback.h: Removed.
* storage/JSCustomSQLTransactionCallback.h: Removed.
* storage/JSCustomSQLTransactionErrorCallback.h: Removed.
* storage/SQLStatementCallback.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27775
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Wed, 14 Nov 2007 01:41:11 +0000 (01:41 +0000)]
Fix a bug and improve upon Brady's fix
Reviewed by Anders.
* bindings/js/JSSQLTransactionCustom.cpp:
(WebCore::JSSQLTransaction::executeSql): Made the code a little
clearer and more correct.
* loader/icon/IconDatabase.cpp: Put parentheses around the expansion
of IS_ICON_SYNC_THREAD() so that ASSERT_NOT_SYNC_THREAD() does the
comparison it meant to.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27774
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Wed, 14 Nov 2007 01:39:32 +0000 (01:39 +0000)]
Fix Qt and Gtk builds.
* WebCore.pro: Remove non-generated idl files.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27773
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Wed, 14 Nov 2007 01:36:25 +0000 (01:36 +0000)]
2007-11-13 Mark Rowe <mrowe@apple.com>
Remove removed file from the project.
* WebCore.pro:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27772
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Wed, 14 Nov 2007 01:30:14 +0000 (01:30 +0000)]
WebKitTools:
Reviewed by Adam Roben.
Fix for <rdar://problem/
5382579>
http/tests/security/cross-frame-access-put.html reports large
negative numbers for screenLeft and screenTop (Mac reports "0")
* DumpRenderTree/win/UIDelegate.cpp:
(UIDelegate::UIDelegate): Initialize the RECT.
(UIDelegate::setFrame): copy the contents of the rect, not the pointer.
(UIDelegate::webViewFrame): ditto.
* DumpRenderTree/win/UIDelegate.h: Use a RECT not a RECT*
LayoutTests:
Reviewed by Adam Roben.
Fix for <rdar://problem/
5382579>
http/tests/security/cross-frame-access-put.html reports large
negative numbers for screenLeft and screenTop (Mac reports "0")
* platform/win/Skipped: remove http/tests/security/cross-frame-access-put.html
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27771
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Wed, 14 Nov 2007 01:29:03 +0000 (01:29 +0000)]
Release build fix
* bindings/js/JSSQLTransactionCustom.cpp:
(WebCore::JSSQLTransaction::executeSql):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27770
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kmccullough@apple.com [Wed, 14 Nov 2007 01:05:58 +0000 (01:05 +0000)]
WebKit/win:
Reviewed by Adam.
- Make Drosera show source, source URLs, and function stack on Windows
and some minor fixes.
* WebScriptCallFrame.cpp: Fixed a bug where the callFrame was not reffed
properly before being returned, and changed functionName() to check for
Null or if the name is empty.
(EnumScopes::Clone):
(WebScriptCallFrame::WebScriptCallFrame):
(WebScriptCallFrame::createInstance):
(WebScriptCallFrame::caller):
(WebScriptCallFrame::functionName):
* WebScriptCallFrame.h: Ditto
* WebScriptDebugServer.cpp: Made the listenerSet static since we were
already treating it as if it were. Removed the EnumViews stuff. This
was added by Steve to demonstrate DCOM and he thought it would be needed
by Drosera, but I don't believe it will be.
Implemented suspendProcessIfPaused() also added calls to it at the end
of several functions to ensure we pause if Drosera has told WebKit to.
(WebScriptDebugServer::WebScriptDebugServer):
(WebScriptDebugServer::sharedWebScriptDebugServer):
(WebScriptDebugServer::addListener):
(WebScriptDebugServer::removeListener):
(WebScriptDebugServer::suspendProcessIfPaused):
(WebScriptDebugServer::didLoadMainResourceForDataSource):
(WebScriptDebugServer::didParseSource):
(WebScriptDebugServer::failedToParseSource):
(WebScriptDebugServer::didEnterCallFrame):
(WebScriptDebugServer::willExecuteStatement):
(WebScriptDebugServer::willLeaveCallFrame):
(WebScriptDebugServer::exceptionWasRaised):
* WebScriptDebugServer.h: Ditto.
* WebScriptDebugger.cpp: The important change here is that leaveFrame()
is called before willLeaveCallFrame(). I think there is some EOL stuff
going on too.
- It was the implementing of these functions that allows source, the
source URLs and function stack to be displayed.
(WebScriptDebugger::callEvent):
(WebScriptDebugger::atStatement):
(WebScriptDebugger::returnEvent):
(WebScriptDebugger::exception):
(WebScriptDebugger::enterFrame):
(WebScriptDebugger::leaveFrame):
* WebView.cpp: Removed the EnumView functions.
(WebView::WebView):
(WebView::~WebView):
WebKitTools:
Reviewed by Adam.
- Make Drosera show source, source URLs, and function stack on Windows,
and some minor fixes.
* Drosera/DebuggerDocument.cpp: Force source to always update display.
(DebuggerDocument::updateFileSource):
* Drosera/debugger.js: Force source to always update display.
* Drosera/win/DebuggerClient.cpp: Create the needed functions for the
menu controls.
(DebuggerClient::resume):
(DebuggerClient::pause):
(DebuggerClient::stepInto):
(DebuggerClient::stepOver):
(DebuggerClient::stepOut):
(DebuggerClient::showConsole):
(DebuggerClient::closeCurrentFile):
* Drosera/win/DebuggerClient.h: Ditto.
* Drosera/win/DebuggerDocumentPlatform.cpp: Changed
getPlatformCurrentFunctionStack to not use an unecessary HRESULT and
removed two bugs. 1) caller could be in a bad state when asked to
assign into it. 2) BSTRs were not created correctly.
(DebuggerDocument::getPlatformCurrentFunctionStack):
* Drosera/win/Drosera.cpp: Hook up the menu controls.
(droseraWndProc):
(handleCommand):
(Drosera::resume):
(Drosera::pause):
(Drosera::stepInto):
(Drosera::stepOver):
(Drosera::stepOut):
(Drosera::showConsole):
(Drosera::closeCurrentFile):
* Drosera/win/Drosera.h: Hook up the menu controls.
* Drosera/win/ServerConnection.cpp: Removed unncessary server connection
functions, added a null check, and fixed another bug where caller could
be in a bad state when asked to assign into it.
(ServerConnection::didLoadMainResourceForDataSource):
(ServerConnection::getCallerFrame):
* Drosera/win/ServerConnection.h: Safety first.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27769
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Wed, 14 Nov 2007 00:58:41 +0000 (00:58 +0000)]
Build fix
Reviewed by Geoff.
* kjs/regexp.h: Added a missing #include.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27768
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 14 Nov 2007 00:51:31 +0000 (00:51 +0000)]
Reviewed by Adam.
Make this a text-only test.
* fast/dom/Window/window-onFocus-expected.txt: Added.
* fast/dom/Window/window-onFocus.html:
* platform/mac/fast/dom/Window/window-onFocus-expected.checksum: Removed.
* platform/mac/fast/dom/Window/window-onFocus-expected.png: Removed.
* platform/mac/fast/dom/Window/window-onFocus-expected.txt: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27767
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Wed, 14 Nov 2007 00:49:21 +0000 (00:49 +0000)]
Reviewed by Darin Adler.
- fix <http://bugs.webkit.org/show_bug.cgi?id=13371>
DumpRenderTree --pixel-tests renders each test twice
* DumpRenderTree/mac/DumpRenderTree.mm:
(dumpRenderTree): Removed the --paint option because the painting code
is always exercised as a result of
-[FrameLoadDelegate webView:didFinishLoadFromFrame:]
calling -displayIfNeeded.
(dump): Changed to always grab the image from the window since the view
is always displayed.
(runTest):
(displayWebView):
* Scripts/run-webkit-tests: No need to pass --paint to DumpRenderTree
because it always paints.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27766
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Wed, 14 Nov 2007 00:44:38 +0000 (00:44 +0000)]
Fix <rdar://
5346832> Infinite recursion when opening Web Inspector on more than one tab
WebCore:
Add WindowMessageBroadcaster
This class is used to listen in on messages sent to HWNDs. Multiple
WindowMessageListeners can be notified about messages sent to a single
HWND, and one WindowMessageListener can listen to messages from
multiple HWNDs.
Reviewed by Ada.
* WebCore.vcproj/WebCore.vcproj: Added new files to project.
* platform/win/WindowMessageBroadcaster.cpp: Added.
(WebCore::instancesMap): Static helper.
(WebCore::WindowMessageBroadcaster::addListener): Registers a listener
for a particular HWND.
(WebCore::WindowMessageBroadcaster::removeListener): Removes a
listener for a particular HWND.
(WebCore::WindowMessageBroadcaster::WindowMessageBroadcaster):
(WebCore::WindowMessageBroadcaster::~WindowMessageBroadcaster):
(WebCore::WindowMessageBroadcaster::destroy): Removes this broadcaster
from the instancesMap, removes all of its listeners, unsubclasses the
window, and deletes the broadcaster.
(WebCore::WindowMessageBroadcaster::unsubclassWindow): Unsubclasses
the window (which means that SubclassedWndProc won't be called again
for this window).
(WebCore::WindowMessageBroadcaster::SubclassedWndProc): Notifies all
the listeners about every message sent to the HWND
* platform/win/WindowMessageBroadcaster.h: Added.
(WebCore::WindowMessageBroadcaster::listeners):
(WebCore::WindowMessageBroadcaster::originalWndProc):
* platform/win/WindowMessageListener.h: Added.
WebKit/win:
Fix <rdar://
5346832> Infinite recursion when opening Web Inspector on more than one tab
The bug was that multiple WebNodeHighlights would subclass the same
browser window, leading to infinite recursion within
SubclassedWndProc.
WebNodeHighlight is now a WindowMessageListener, and lets
WindowMessageBroadcaster handle subclassing the window.
Reviewed by Ada.
* WebNodeHighlight.cpp:
(WebNodeHighlight::WebNodeHighlight): Initialize m_observedWindow
member.
(WebNodeHighlight::~WebNodeHighlight): Unregister as a listener for
m_observedWindow.
(WebNodeHighlight::highlight): Register as a listener.
(WebNodeHighlight::windowReceivedMessage): Do the work that used to be
done in SubclassedWndProc.
* WebNodeHighlight.h: Made WebNodeHighlight a WindowMessageListener,
and renamed m_subclassedWindow to m_observedWindow.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27765
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Wed, 14 Nov 2007 00:44:12 +0000 (00:44 +0000)]
Build fix for systems that don't have Cygwin in their PATH
* WebKit.vcproj/Interfaces.vcproj: Put Cygwin in the PATH before
trying to run bash.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27764
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Wed, 14 Nov 2007 00:30:19 +0000 (00:30 +0000)]
JavaScriptCore:
Reviewed by Sam Weinig.
Moved Shared.h into wtf so it could be used in more places. Deployed
Shared in places where JSCore previously had hand-rolled ref-counting
classes.
* API/JSClassRef.cpp:
(OpaqueJSClass::OpaqueJSClass):
* API/JSClassRef.h:
* API/JSObjectRef.cpp:
(JSClassRetain):
(JSClassRelease):
* JavaScriptCore.vcproj/WTF/WTF.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* kjs/interpreter.cpp:
(KJS::Interpreter::init):
* kjs/interpreter.h:
* kjs/regexp.cpp:
(KJS::RegExp::RegExp):
* kjs/regexp.h:
* wtf/Shared.h: Copied from WebCore/platform/Shared.h.
JavaScriptGlue:
Reviewed by Sam Weinig.
Moved Shared.h into wtf so it could be used in more places.
* ForwardingHeaders/wtf/Shared.h: Added.
WebCore:
Reviewed by Sam Weinig.
Moved Shared.h into wtf so it could be used in more places. Retained
TreeShared, but moved it to its own file, TreeShared.h.
* ForwardingHeaders/wtf/Shared.h: Added.
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSSVGPODTypeWrapper.h:
* css/CSSFontFace.h:
* css/CSSRuleList.h:
* css/Counter.h:
* css/Pair.h:
* css/Rect.h:
* css/StyleBase.h:
* css/StyleSheetList.h:
* dom/Clipboard.h:
* dom/DOMImplementation.h:
* dom/Event.h:
* dom/EventListener.h:
* dom/NamedNodeMap.h:
* dom/NodeFilterCondition.h:
* dom/NodeList.h:
* dom/Range.h:
* dom/RangeException.h:
* dom/RegisteredEventListener.h:
* dom/Traversal.h:
* history/BackForwardList.h:
* history/CachedPage.h:
* history/HistoryItem.h:
* html/CanvasGradient.h:
* html/CanvasPattern.h:
* html/HTMLCollection.h:
* html/MediaError.h:
* html/TimeRanges.h:
* html/VoidCallback.h:
* ksvg2/css/SVGRenderStyleDefs.h:
* ksvg2/svg/SVGAnimatedTemplate.h:
* ksvg2/svg/SVGElementInstanceList.h:
* ksvg2/svg/SVGList.h:
* ksvg2/svg/SVGPathSeg.h:
* ksvg2/svg/SVGPreserveAspectRatio.h:
* ksvg2/svg/SVGRenderingIntent.h:
* ksvg2/svg/SVGTransform.h:
* ksvg2/svg/SVGUnitTypes.h:
* loader/DocumentLoader.h:
* loader/FormState.h:
* loader/ResourceLoader.h:
* loader/TextResourceDecoder.h:
* loader/icon/IconRecord.h:
* page/BarInfo.h:
* page/Console.h:
* page/DOMSelection.h:
* page/DOMWindow.h:
* page/History.h:
* page/InspectorController.cpp:
* page/Plugin.h:
* page/Screen.h:
* platform/ArrayImpl.h:
* platform/CString.h:
* platform/DeprecatedValueListImpl.cpp:
* platform/FontFallbackList.h:
* platform/FontFamily.h:
* platform/FontSelector.h:
* platform/GlyphPageTreeNode.h:
* platform/PopupMenu.h:
* platform/RegularExpression.cpp:
* platform/ScrollBar.h:
* platform/Shared.h: Removed.
* platform/SharedBuffer.h:
* platform/StringImpl.h:
* platform/graphics/Icon.h:
* platform/graphics/svg/SVGResource.h:
* platform/network/FormData.h:
* platform/network/ResourceHandleClient.h:
* rendering/RenderStyle.h:
* rendering/SVGCharacterLayoutInfo.h:
* storage/SQLResultSetRowList.h:
* xml/DOMParser.h:
* xml/XMLSerializer.h:
* xml/XPathEvaluator.h:
* xml/XPathExpression.h:
* xml/XPathNSResolver.h:
* xml/XPathResult.h:
WebKit/mac:
Reviewed by Sam Weinig.
Moved Shared.h into wtf so it could be used in more places.
* ChangeLog:
* WebCoreSupport/WebContextMenuClient.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27763
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Wed, 14 Nov 2007 00:26:48 +0000 (00:26 +0000)]
Squashed commit of the following:
commit
3e6cb737b3b823b4bf177b9e0c2fcfcc38baf46d
Author: Brady Eidson <beidson@apple.com>
Date: Tue Nov 13 16:22:36 2007 -0800
Changelog for commit
commit
4be13a5ef17685368e68a76292b785c99da1d7f2
Author: Brady Eidson <beidson@apple.com>
Date: Tue Nov 13 16:19:34 2007 -0800
Make inspector work with new API
commit
c500ed90c32b31fbc37a183c8ae5427f36b9ccc2
Author: Brady Eidson <beidson@apple.com>
Date: Tue Nov 13 14:37:16 2007 -0800
Woops!
commit
c61b147f35a2801c340f82054d177914da6ccde5
Author: Brady Eidson <beidson@apple.com>
Date: Tue Nov 13 11:45:40 2007 -0800
Ander's review comments
commit
f3dc2683acc5730cbab8758226adae3e35f7263b
Author: Brady Eidson <beidson@apple.com>
Date: Mon Nov 12 18:05:21 2007 -0800
Initial vcproj changes after the rebase
commit
c8cf9be275479ff1fb39b911e5165f07fcd5ae34
Author: Brady Eidson <beidson@apple.com>
Date: Mon Nov 12 18:02:30 2007 -0800
Fixed Changelog a bit
commit
c9790cde9b79e25690f1c0b34b9c1e77d2f4449f
Author: Brady Eidson <beidson@apple.com>
Date: Mon Nov 12 16:53:48 2007 -0800
Finish the rebase/trunk merge
commit
663ad85619ec677eb5c52bed3c59b8b3f50de624
Author: Brady Eidson <beidson@apple.com>
Date: Tue Nov 6 11:54:26 2007 -0800
VCProj changes for new SQL api + blind attempt at keeping qt/gtk going
commit
2aceeb3bdfa6894bb4e93c0b129867059e9cdad7
Author: Brady Eidson <beidson@apple.com>
Date: Mon Nov 5 15:27:55 2007 -0800
Changelog edit cleanup
commit
a05f11fa4fa0ba935eb28df6d9628f29a4074d7a
Author: Brady Eidson <beidson@apple.com>
Date: Mon Nov 5 15:25:27 2007 -0800
Changelog entries and small style cleanup
commit
a2d34a78d06f446f4bdb6ea1797dfb91cfc336fe
Author: Brady Eidson <beidson@apple.com>
Date: Mon Nov 5 13:37:10 2007 -0800
Minor edit
commit
eaf0aa9c07cfeb54df312c130677ecbc60728c5f
Author: Brady Eidson <beidson@apple.com>
Date: Mon Nov 5 13:32:20 2007 -0800
Do version check at time of executeSql
commit
3bac84615badcc810f44ebf14d1679bffd4cc8fb
Author: Brady Eidson <beidson@apple.com>
Date: Mon Nov 5 13:04:14 2007 -0800
Newline = t3h gone
commit
de7cfcf737b1a6143b74f1cc60955c317877ca27
Author: Brady Eidson <beidson@apple.com>
Date: Mon Nov 5 13:02:11 2007 -0800
Example + inspector fixes
commit
536b119c219de72c97fe6756e226a36bef5e6880
Author: Brady Eidson <beidson@apple.com>
Date: Mon Nov 5 11:47:30 2007 -0800
DatabaseExample works
commit
fff79aa99dbf47955bc37ca325928460fc41a59e
Author: Brady Eidson <beidson@apple.com>
Date: Mon Nov 5 10:36:59 2007 -0800
Remove the old, now unused DatabaseCallback
commit
06bc8e16ad346b755f767ce8e7849da819ccf96f
Author: Brady Eidson <beidson@apple.com>
Date: Mon Nov 5 09:57:36 2007 -0800
Sort project file
commit
741084d108ec994ff513e18c3d7a3153f6dd6bb5
Author: Brady Eidson <beidson@apple.com>
Date: Mon Nov 5 09:30:37 2007 -0800
Sort the project file
commit
2e77cec4337db174f56269b7fb406d81ebb1de7d
Author: Brady Eidson <beidson@apple.com>
Date: Thu Nov 1 16:01:03 2007 -0700
Yay! Change version even works!
commit
05c2ed1f22e3b689dd453ea300154492937f46db
Author: Brady Eidson <beidson@apple.com>
Date: Thu Nov 1 15:19:56 2007 -0700
Nuke some DRT changes
commit
9b5b9b25c45d7d4720e4ddf4a31f163fb4f7faf2
Author: Brady Eidson <beidson@apple.com>
Date: Thu Nov 1 15:05:59 2007 -0700
Nuke some printfs
commit
8503eecdefa95278a15246bb4eed2dccb69af12a
Author: Brady Eidson <beidson@apple.com>
Date: Thu Nov 1 13:44:32 2007 -0700
Added "current transaction" to Database and reworked how scheduling goes
commit
f70354c9a84d654d28894ab3c6b13679ce494fc3
Author: Brady Eidson <beidson@apple.com>
Date: Thu Nov 1 11:49:26 2007 -0700
Things are largely working. Still need to clean up loose ends in the sticky notes demo and do further testing
commit
417665cd15f020c22af5691577e5c8a072630839
Author: Brady Eidson <beidson@apple.com>
Date: Thu Nov 1 00:00:47 2007 -0700
Transaction steps are almost locked up completely. Still need the SQLError for the transaction error callback and actually implementing ::execute() on the SQLStatement
commit
752d572acd4d1d9832976b4869284e554845205a
Author: Anders Carlsson <andersca@apple.com>
Date: Wed Oct 31 18:52:55 2007 -0700
Forgot this.
commit
2c8f2689d212296961a841c579a2f93609858862
Author: Anders Carlsson <andersca@apple.com>
Date: Wed Oct 31 18:31:05 2007 -0700
Merge.
commit
7540d4fa7ef858400d9f834cba976a439394412d
Author: Brady Eidson <beidson@apple.com>
Date: Wed Oct 31 17:14:30 2007 -0700
Even closer!
commit
143a70a5d026ab9fab1b5de91f826effcd481527
Author: Brady Eidson <beidson@apple.com>
Date: Wed Oct 31 16:43:31 2007 -0700
Merge project file correctly
commit
11207e7b6e391a4052fc41f6db42ce30449c7e3e
Author: Anders Carlsson <andersca@apple.com>
Date: Wed Oct 31 11:04:35 2007 -0700
Remove more unused methods.
commit
9a0d306d467eb9aa8c19825da03b7abe318c609c
Author: Anders Carlsson <andersca@apple.com>
Date: Wed Oct 31 11:01:35 2007 -0700
Add SQLTransactionCallback.idl
commit
12e2fa2858145e3895320293462ec441c35a7e3d
Author: Anders Carlsson <andersca@apple.com>
Date: Wed Oct 31 10:47:17 2007 -0700
Fix build.
commit
02f4631705b0f6e0bd3c715c64f4938ea53f4670
Author: Brady Eidson <beidson@apple.com>
Date: Tue Oct 30 23:36:24 2007 -0700
All steps now take place in the right order, following the right rules - only thing missing is the actual SQL executing!
commit
6a8c0d7d2beb745c070c55b14beac9a47d373fc4
Author: Brady Eidson <beidson@apple.com>
Date: Tue Oct 30 18:20:35 2007 -0700
Closer and closer we roll
commit
f945446453ae48a28d6e2f3dcce4660feae0da79
Author: Brady Eidson <beidson@apple.com>
Date: Tue Oct 30 17:59:25 2007 -0700
Things are really rolling - transaction steps 1-5 are called as expected. Downhill from here
commit
138b49b62bc8f3d05b1171e280d403e8b15ef9c4
Author: Brady Eidson <beidson@apple.com>
Date: Tue Oct 30 14:50:14 2007 -0700
Use pointer-to-member functions for the transaction steps... !!!
commit
3eb4f794861827f5c88cd8c36efb144cdc537bd5
Author: Anders Carlsson <andersca@apple.com>
Date: Tue Oct 30 14:45:59 2007 -0700
Remove more old cruft.
commit
f18835f0709b4aff00903738974dbebb11a224f0
Author: Brady Eidson <beidson@apple.com>
Date: Tue Oct 30 13:55:05 2007 -0700
Restore that comment
commit
35b2eac5ac3ec338cc2a8a4fe611f85e62c72dd6
Author: Brady Eidson <beidson@apple.com>
Date: Tue Oct 30 12:08:29 2007 -0700
Closer, still, to the new model working. Lotsa little tweaks
commit
a8476702a7d9bb38b8e15966e837ceca5858e9b2
Author: Anders Carlsson <andersca@apple.com>
Date: Tue Oct 30 11:23:02 2007 -0700
Wrap changeVersion.
commit
aa0d8cc6aaaf674de341996555306eb9f122de3c
Author: Brady Eidson <beidson@apple.com>
Date: Mon Oct 29 22:35:16 2007 -0700
Dummy callback as part of transaction steps acheived! And other architectural changes
commit
01c0a92daf764375be79753bc7bc417aa0205168
Author: Brady Eidson <beidson@apple.com>
Date: Mon Oct 29 18:23:00 2007 -0700
Have a the first chunk of transaction steps occuring asynchronously with stubs and printf()s - should be downhill from here. Also updated the DatabaseExample.html for the portion of the new API that works so far.
commit
6b6e9e7a064424cd6b70489de80c79e7ae950b38
Author: Brady Eidson <beidson@apple.com>
Date: Mon Oct 29 17:32:30 2007 -0700
Made DatabaseTasks create mutex/conditions on demand, and renamed the internal sqlitedatabase
commit
99d06513090c2b4e04edda82d82108cf97da245a
Author: Anders Carlsson <andersca@apple.com>
Date: Mon Oct 29 16:30:52 2007 -0700
Fix bug.
commit
83def2ce73fa001f5bda3e152ca60e58c563dbed
Author: Anders Carlsson <andersca@apple.com>
Date: Mon Oct 29 15:17:45 2007 -0700
Remove some cruft.
commit
9f2c8c21d06d6b379426449357f1ee00a25faeee
Author: Anders Carlsson <andersca@apple.com>
Date: Mon Oct 29 14:45:54 2007 -0700
More bindings.
commit
9eae9135ed17179b7bcd225648272d24b76de8b9
Author: Brady Eidson <beidson@apple.com>
Date: Mon Oct 29 14:19:34 2007 -0700
Adapt to new openDatabase() method
commit
2e1dad857b190634f4394475e925d2dc518ae1fe
Author: Brady Eidson <beidson@apple.com>
Date: Mon Oct 29 12:05:53 2007 -0700
More infrastructure changes for the new spec, getting really close now!
commit
b0d8ca9dc7ffe1a424070d5f8587346eca56b76b
Author: Brady Eidson <beidson@apple.com>
Date: Fri Oct 26 17:25:41 2007 -0700
More stubbing of infrastructure
commit
bb8c6528208a24f129af9a8c09763989e5723157
Author: Anders Carlsson <andersca@apple.com>
Date: Fri Oct 26 15:38:16 2007 -0700
Remove SQLVersionChangeCallback.h
commit
c77ec8b1d2a7c8cb7a6a0bc42b089c34541cdf83
Author: Brady Eidson <beidson@apple.com>
Date: Fri Oct 26 15:28:08 2007 -0700
Make it build (removed the old changeVersion)
commit
e205fd2d6cb0cd4e6dd47cf4b6609196d0d8e87d
Author: Brady Eidson <beidson@apple.com>
Date: Fri Oct 26 14:53:15 2007 -0700
Even more progress in the architecture change
commit
322f576e2ed8c584244335f918302169c81ea39f
Author: Anders Carlsson <andersca@apple.com>
Date: Fri Oct 26 14:52:22 2007 -0700
Add JSSQLTransactionCustom.cpp.
commit
22d0b184e1d5d92574b5caf2b73eb6c7faae84be
Author: Anders Carlsson <andersca@apple.com>
Date: Fri Oct 26 13:21:55 2007 -0700
Add new API to Database.
commit
910660c7668f2728850990f8984045de9e41423f
Author: Anders Carlsson <andersca@apple.com>
Date: Fri Oct 26 11:48:33 2007 -0700
Add more .IDL files
commit
4d0cbb5b3e8c57076ce0cb743f8a52a5e31c0219
Author: Brady Eidson <beidson@apple.com>
Date: Fri Oct 26 11:20:54 2007 -0700
Further groundwork for new API (does not build)
commit
d6420aacd1bf610ca53eced12e61ecd074f31bd7
Author: Brady Eidson <beidson@apple.com>
Date: Thu Oct 25 18:02:23 2007 -0700
Further stubs and adaptations to the new API
commit
ea80b0c14037cfbdccf322146b26b62df2aa8211
Author: Brady Eidson <beidson@apple.com>
Date: Thu Oct 25 15:51:43 2007 -0700
Remove closeTransaction()
commit
4e701837674e07111da80a476135f5b73e25210f
Author: Brady Eidson <beidson@apple.com>
Date: Thu Oct 25 14:05:40 2007 -0700
Further stubbing and API-matching cleanup
commit
f667cf3c7847069a6720296710876394954611bd
Author: Anders Carlsson <andersca@apple.com>
Date: Wed Oct 24 16:32:58 2007 -0700
Add extra arguments to Window.openDatabase.
commit
efbbe3016a31a9c4a717de25d831406288f8126d
Author: Anders Carlsson <andersca@apple.com>
Date: Wed Oct 24 14:21:22 2007 -0700
cleanup.
commit
b70a8252a588eee36d06835bad5793361ced35c5
Author: Anders Carlsson <andersca@apple.com>
Date: Wed Oct 24 12:31:06 2007 -0700
Stub out a couple of new classes.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27762
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Tue, 13 Nov 2007 22:14:04 +0000 (22:14 +0000)]
Reviewed by Beth Dakin.
- fix <rdar://problem/
5551163> REGRESSION: Cursor does not change to arrow on "X" button in google maps, making it hard to click
* css/html4.css: Added a 'cursor: auto' rule for links.
* manual-tests/link-cursor-auto.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27761
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Tue, 13 Nov 2007 21:59:47 +0000 (21:59 +0000)]
Reviewed by Beth Dakin.
- fix <rdar://problem/
5516272> Reproducible crash in RenderObject::setStyle involving going Back from a non-HTML document (Bookmarks view, PDF view)
The root cause for the crash is that when a non-HTML view enters the
frame, the frame's document pointer keeps pointing at the last HTML-type
document it contained. This patch does not address the root cause, but
makes changes to account for that condition.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::receivedMainResourceError): Do not change the
frame's current document's page cache state here.
(WebCore::FrameLoader::invalidateCurrentItemCachedPage): If the frame's
current document is in fact the history item being invalidated, then
set its page cache state here.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27760
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Tue, 13 Nov 2007 20:37:17 +0000 (20:37 +0000)]
2007-11-13 Eric Seidel <eric@webkit.org>
Reviewed by Maciej.
Add an ASSERT to getTruncatedInt32 to enforce proper usage.
Best part about this patch? It doesn't break the web!
* kjs/JSImmediate.h:
(KJS::JSImmediate::getTruncatedInt32):
(KJS::JSImmediate::toDouble):
(KJS::JSImmediate::getUInt32):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27759
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Tue, 13 Nov 2007 20:08:27 +0000 (20:08 +0000)]
WebCore:
Reviewed by Adele.
Fix that 'timeupdate' and 'waiting' events were never dispatched.
Add explicit m_paused attribute instead of trying to derive paused state from
underlying media. Call updatePlayState() to start/stop media playback
when any attribute that affects active playback state changes. This matches
specification text.
Test: http/tests/media/video-play-stall.html
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::setReadyState):
(WebCore::HTMLMediaElement::paused):
(WebCore::HTMLMediaElement::play):
(WebCore::HTMLMediaElement::pause):
(WebCore::HTMLMediaElement::checkIfSeekNeeded):
(WebCore::HTMLMediaElement::movieDidEnd):
(WebCore::HTMLMediaElement::updatePlayState):
* html/HTMLMediaElement.h:
LayoutTests:
Reviewed by Adele.
- add HTTP media test for stalling load
- update tests that don't specifically test autoplay feature to not use autoplay
attribute since playback may start before event listeners are registered
* http/tests/media: Added.
* http/tests/media/video-load-and-stall.cgi: Added.
* http/tests/media/video-play-stall-expected.txt: Added.
* http/tests/media/video-play-stall.html: Added.
* media/video-autoplay.html:
* media/video-dom-loopstart.html:
* media/video-end.html:
* media/video-loopcount.html:
* media/video-loopend.html:
* media/video-loopstart.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27758
268f45cc-cd09-0410-ab3c-
d52691b4dbfc