kenneth@webkit.org [Fri, 13 Nov 2009 20:50:33 +0000 (20:50 +0000)]
WebKitTools: Make the Qt Linux only --valgrind feature, suppress errors
defined in the SuppressedValgrindErrors file.
Reviewed by Simon Hausmann.
* Scripts/run-webkit-tests:
LayoutTests: Add a file for suppressing invalid valgrind errors (Qt / Linux only)
Reviewed by Simon Hausmann.
* platform/qt/SuppressedValgrindErrors: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50965
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Fri, 13 Nov 2009 20:42:16 +0000 (20:42 +0000)]
JSValueProtect and JSValueUnprotect don't protect API wrapper values
https://bugs.webkit.org/show_bug.cgi?id=31485
Reviewed by Geoff Garen.
Make JSValueProtect/Unprotect use a new 'toJS' function, 'toJSForGC' that
does not attempt to to strip out API wrapper objects.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50964
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
krit@webkit.org [Fri, 13 Nov 2009 20:35:46 +0000 (20:35 +0000)]
2009-11-13 Dirk Schulze <krit@webkit.org>
Reviewed by Gustavo Noronha.
[CAIRO] shadow support for Canvas and SVG
[https://bugs.webkit.org/show_bug.cgi?id=30960]
We currently fill a path with solid color instead of filling
a clipping path. This causes problems on some composite operators,
since Cairo modifies the area outside the path.
This fixes the behavior of WebKitGtk on fast/canvas/canvas-composite-alpha.html
Thanks to Benjamin Otte for tracking the bug down.
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::setPlatformFill):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50963
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 13 Nov 2009 20:29:54 +0000 (20:29 +0000)]
2009-11-13 İsmail Dönmez <ismail@namtrac.org>
Reviewed by Antti Koivisto.
Fix typo, ce_time.cpp should be ce_time.c
* JavaScriptCore.pri:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50962
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dumi@chromium.org [Fri, 13 Nov 2009 20:25:06 +0000 (20:25 +0000)]
Adding Chromium's DatabaseTracker implementation.
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=31440
WebCore:
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* storage/DatabaseTracker.h:
* storage/chromium/DatabaseTrackerChromium.cpp:
(WebCore::DatabaseTracker::fullPathForDatabase):
(WebCore::DatabaseTracker::getMaxSizeForDatabase):
* storage/chromium/QuotaTracker.cpp:
(WebCore::QuotaTracker::updateDatabaseSize):
* storage/chromium/QuotaTracker.h:
WebKit/chromium:
* WebKit.gyp:
* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::exceededDatabaseQuota):
* src/DatabaseObserver.cpp: Added.
(WebCore::DatabaseObserver::databaseOpened):
(WebCore::DatabaseObserver::databaseModified):
(WebCore::DatabaseObserver::databaseClosed):
* src/WebDatabase.cpp:
(WebKit::WebDatabase::name):
(WebKit::WebDatabase::displayName):
(WebKit::WebDatabase::estimatedSize):
(WebKit::WebDatabase::securityOrigin):
(WebKit::WebDatabase::updateDatabaseSize):
* src/WebSecurityOrigin.cpp:
(WebKit::WebSecurityOrigin::toString):
(WebKit::WebSecurityOrigin::databaseIdentifier):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50961
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 13 Nov 2009 20:21:44 +0000 (20:21 +0000)]
2009-11-13 Carol Szabo <carol.szabo@nokia.com>
Reviewed by Darin Adler.
The CounterNode class is missing some basic tree navigation methods common in other WebKit trees such as the rendering tree
https://bugs.webkit.org/show_bug.cgi?id=31213
Added tree navigation methods that permit full implementation of CSS2.1
counter feature without using recursion proportional to the counter
tree depth.
No new tests because I did not find any bug that is fixed by this
commit yet, this just reduces the size of the patch for 11031 and
helps respond to some concerns regarding that patch.
* rendering/CounterNode.cpp:
(WebCore::CounterNode::CounterNode):
(WebCore::CounterNode::nextInPreOrderAfterChildren):
(WebCore::CounterNode::nextInPreOrder):
Added to support non-recursive tree traversal necessary for
efficient full implementation of CSS2.1 counters.
(WebCore::CounterNode::lastDescendant):
(WebCore::CounterNode::previousInPreOrder):
Moved this methods such that they occupy a place similar to that of
identically named methods on the render tree. This allows for their
broader use needed in full implementation of CSS2.1 counters.
(WebCore::CounterNode::resetRenderer):
(WebCore::CounterNode::resetRenderers):
(WebCore::CounterNode::recount):
(WebCore::CounterNode::insertAfter):
(WebCore::CounterNode::removeChild):
Changed such that insertion/removal of a counter, triggers not only
recalculation of PrefixWidths, but also reassesment of values in
counter nodes. This is the basis full implementation of CSS2.1
counters. It does not change current behavior by much because of
changes needed to the recalculation algorithm, but those are comming
in the patch for 11031.
(WebCore::showTreeAndMark):
* rendering/CounterNode.h:
* rendering/RenderCounter.cpp:
(WebCore::counter):
Only changed argument type to prepare for implementation of Darin
Adler's recommendation for the patch to 11031.
(WebCore::RenderCounter::invalidate):
(WebCore::destroyCounterNodeChildren):
(WebCore::RenderCounter::destroyCounterNodes):
* rendering/RenderCounter.h:
* rendering/RenderObjectChildList.cpp:
(WebCore::invalidateCountersInContainer):
(WebCore::RenderObjectChildList::invalidateCounters):
* rendering/RenderObjectChildList.h:
Added the ability to restrict invalidation to counters with a given
identifier.
Also invalidated counters that are on the child container itself
which were missed by the previous algorithm, but were a valid case.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50960
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kenneth@webkit.org [Fri, 13 Nov 2009 20:04:24 +0000 (20:04 +0000)]
Set the locale to C and not to the current one in use on the system.
Reviewed by Simon Hausmann.
* DumpRenderTree/qt/DumpRenderTree.cpp:
(WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50959
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 13 Nov 2009 19:56:43 +0000 (19:56 +0000)]
2009-11-13 Vitaly Repeshko <vitalyr@chromium.org>
Reviewed by Dimitri Glazkov.
[V8] Protect SVG animated properties from destruction in bindings.
https://bugs.webkit.org/show_bug.cgi?id=31474
See http://crbug.com/26719.
Tested by LayoutTests/svg/custom/js-update-transform-addition.svg
under Valgrind.
Made sure we keep a reference to SVG properties while setting a
context:
* bindings/scripts/CodeGeneratorV8.pm:
* bindings/v8/V8Proxy.h:
(WebCore::V8Proxy::withSVGContext):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50958
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Fri, 13 Nov 2009 19:30:29 +0000 (19:30 +0000)]
Disable websocket tests on Windows, as the server cannot start on buildbot.
Filed <https://bugs.webkit.org/show_bug.cgi?id=31479> to investigate this issue.
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50957
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Fri, 13 Nov 2009 19:21:24 +0000 (19:21 +0000)]
[CAIRO] shadow support for Canvas and SVG.
[https://bugs.webkit.org/show_bug.cgi?id=30960]
Reviewed by Alexey Proskuryakov.
Incorporate Benjamin Otte's recommendations to avoid
a buffer overrun, and small performance improvement.
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::copyContextProperties): Correctly size output
storage for cairo_get_dash to avoid buffer overrun.
(WebCore::drawPathShadow): Prefer cairo_fill_extents
to slower cairo_stroke_extents when not drawing shadows.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50956
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Fri, 13 Nov 2009 19:19:39 +0000 (19:19 +0000)]
Restoring parst of ChangeLog that were somehow deleted with my latest commit.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50955
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dumi@chromium.org [Fri, 13 Nov 2009 19:14:56 +0000 (19:14 +0000)]
Do not register Chromium's HTML5 DB VFS as the default
VFS. Otherwise, other sqlite DB users in the same process will
stop working.
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=31462
* platform/sql/chromium/SQLiteFileSystemChromium.cpp:
(WebCore::SQLiteFileSystem::openDatabase):
* platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:
(WebCore::SQLiteFileSystem::registerSQLiteVFS):
* platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp:
(WebCore::SQLiteFileSystem::registerSQLiteVFS):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50954
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Fri, 13 Nov 2009 18:51:48 +0000 (18:51 +0000)]
Windows build fix
* platform/network/cf/SocketStreamHandleCFNet.cpp:
(WebCore::SocketStreamHandle::SocketStreamHandle): Explicitly cast "-1" to CFOptionFlags,
avoiding a sign mismatch warning.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50953
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Fri, 13 Nov 2009 18:47:40 +0000 (18:47 +0000)]
Release build fix.
* platform/network/cf/SocketStreamHandleCFNet.cpp:
(WebCore::SocketStreamHandle::readStreamCallback):
(WebCore::SocketStreamHandle::writeStreamCallback):
Use ASSERT_UNUSED for unused stream parameter.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50952
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Fri, 13 Nov 2009 18:14:59 +0000 (18:14 +0000)]
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=31441
Implement SocketStreamHandleCFNet
Existing WebSocket tests now pass on Mac. No proxy support yet.
* platform/network/SocketStreamHandleClient.h:
* platform/network/cf/SocketStreamHandle.h:
(WebCore::SocketStreamHandle::shouldUseSSL):
(WebCore::SocketStreamHandle::refAuthenticationClient):
(WebCore::SocketStreamHandle::derefAuthenticationClient):
(WebCore::SocketStreamHandle::):
* platform/network/cf/SocketStreamHandleCFNet.cpp:
(WebCore::SocketStreamHandle::SocketStreamHandle):
(WebCore::SocketStreamHandle::chooseProxy):
(WebCore::SocketStreamHandle::createStreams):
(WebCore::SocketStreamHandle::copyCFStreamDescription):
(WebCore::SocketStreamHandle::readStreamCallback):
(WebCore::SocketStreamHandle::writeStreamCallback):
(WebCore::SocketStreamHandle::~SocketStreamHandle):
(WebCore::SocketStreamHandle::platformSend):
(WebCore::SocketStreamHandle::platformClose):
(WebCore::SocketStreamHandle::receivedCredential):
(WebCore::SocketStreamHandle::receivedRequestToContinueWithoutCredential):
(WebCore::SocketStreamHandle::receivedCancellation):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50951
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dimich@chromium.org [Fri, 13 Nov 2009 18:07:03 +0000 (18:07 +0000)]
Fix worker-timeout.html layout test that fails in Chromium harness.
https://bugs.webkit.org/show_bug.cgi?id=31452
Reviewed by Darin Adler.
* fast/workers/worker-timeout.html:
Stop logging timer messages at the same time as calling NotifyDone() because
in test harness Chromium uses for workers it does not capture the output immediately.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50950
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Fri, 13 Nov 2009 17:51:15 +0000 (17:51 +0000)]
Build correction. No review.
The WinCairo build requires ENABLE_FILTERS to work properly.
* win/tools/vsprops/WinCairo.vsprops:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50949
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 13 Nov 2009 17:50:11 +0000 (17:50 +0000)]
2009-11-13 Yaar Schnitman <yaar@chromium.org>
Reviewed by Dimitri Glazkov.
Rolling Chromium dependencies to match Chromium revision 31834.
https://bugs.webkit.org/show_bug.cgi?id=31445
* DEPS:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50948
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Fri, 13 Nov 2009 17:26:27 +0000 (17:26 +0000)]
2009-11-12 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: preload status bar button glyphs
in order to prevent them from flickering (take 2).
https://bugs.webkit.org/show_bug.cgi?id=31439
* inspector/front-end/inspector.js:
(preloadImages):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50947
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Fri, 13 Nov 2009 17:10:48 +0000 (17:10 +0000)]
2009-11-13 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Adam Barth.
Chromium: [REGRESSION] Crash while stopping on a breakpoint.
Rolling back r50890.
https://bugs.webkit.org/show_bug.cgi?id=31467
* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::canAccessPrivate):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50946
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 13 Nov 2009 17:10:45 +0000 (17:10 +0000)]
Build fix
* Interfaces/WebKit.idl: Un-sort the #includes again. Apparently they
are order-dependent!
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50945
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 13 Nov 2009 17:05:38 +0000 (17:05 +0000)]
Touch WebKit.idl to fix the Windows build
* Interfaces/WebKit.idl: Sorted #includes.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50944
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 13 Nov 2009 16:58:58 +0000 (16:58 +0000)]
Finish replacing worldIDs with world objects
The only remaining use of worldIDs was in a method only used by DRT
for the isolated worlds tests.
Fixes <http://webkit.org/b/31414> Replace worldIDs with world objects
Reviewed by Mark Rowe.
WebKit/mac:
* WebView/WebFrame.mm:
(-[WebFrame _stringByEvaluatingJavaScriptFromString:withGlobalObject:inScriptWorld:]):
* WebView/WebFramePrivate.h:
Renamed from
_stringByEvaluatingJavaScriptInIsolatedWorld:WithGobalObject:FromString:.
Now takes a WebScriptWorld instead of a worldID, so we don't need to
maintain a map of worldID -> world anymore.
WebKit/win:
* Interfaces/IWebFramePrivate.idl:
* WebFrame.cpp:
(WebFrame::stringByEvaluatingJavaScriptInScriptWorld):
* WebFrame.h:
Renamed from stringByEvaluatingJavaScriptInIsolatedWorld. Now takes an
IWebScriptWorld instead of a worldID, so we don't need to maintain a
map of worldID -> world anymore.
WebKitTools:
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::evaluateScriptInIsolatedWorld):
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::evaluateScriptInIsolatedWorld):
Updated for changes to WebFrame. Now holds the map of worldID -> world
at this level instead of making WebKit do it.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50943
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Fri, 13 Nov 2009 16:43:10 +0000 (16:43 +0000)]
[Qt] Ensure the DRT does not output anything until first test is run
Reviewed by Simon Hausmann.
* DumpRenderTree/qt/DumpRenderTree.cpp:
* DumpRenderTree/qt/DumpRenderTree.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50942
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kenneth@webkit.org [Fri, 13 Nov 2009 16:11:47 +0000 (16:11 +0000)]
Clear the undo stack in before each new test run.
Reviewed by Tor Arne Vestbø.
Locally fixes 3 incorrect layouts, 9 timeouts and 7 crashes.
* DumpRenderTree/qt/DumpRenderTree.cpp:
(WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50941
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Fri, 13 Nov 2009 15:06:34 +0000 (15:06 +0000)]
Update documentation for the Qt API
Reviewed by Simon Hausmann.
* Api/qgraphicswebview.cpp:
* Api/qwebelement.cpp:
* Api/qwebframe.cpp:
* Api/qwebsettings.cpp:
* Api/qwebview.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50940
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
krit@webkit.org [Fri, 13 Nov 2009 14:57:13 +0000 (14:57 +0000)]
2009-11-13 Dirk Schulze <krit@webkit.org>
Reviewed by Gustavo Noronha.
[CAIRO] shadow support for Canvas and SVG
[https://bugs.webkit.org/show_bug.cgi?id=30960]
This is the fix of a regression, caused by the shadow patch
from the bug above. Reinserted the save and restore calls
that were accidently removed by the previous patch.
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::setPlatformFill):
(WebCore::setPlatformStroke):
Skip fast/canvas/canvas-shadow.html we need to enable filters
on cairo to pass this test.
* platform/gtk/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50939
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 13 Nov 2009 13:49:29 +0000 (13:49 +0000)]
2009-11-13 Andras Becsi <becsi.andras@stud.u-szeged.hu>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Enable Page Cache if setMaximumPagesInCache needs it.
This fixes https://bugs.webkit.org/show_bug.cgi?id=31266.
* Api/qwebsettings.cpp:
(QWebSettingsPrivate::apply):
(QWebSettings::setMaximumPagesInCache):
2009-11-13 Andras Becsi <becsi.andras@stud.u-szeged.hu>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Add WebKitUsesPageCachePreferenceKey overriding support to DRT's LayoutTestController.
* DumpRenderTree/qt/DumpRenderTree.cpp:
(WebCore::WebPage::resetSettings):
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::overridePreference):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50938
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 13 Nov 2009 13:21:34 +0000 (13:21 +0000)]
2009-11-13 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Fix initial QWebView focus behavior.
focusController->setFocused(true) was not always called.
https://bugs.webkit.org/show_bug.cgi?id=31466
* Api/qwebpage.cpp:
(QWebPagePrivate::focusInEvent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50937
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Fri, 13 Nov 2009 13:12:35 +0000 (13:12 +0000)]
Use correct install-path when running qdoc3
Reviewed by Simon Hausmann.
* docs/docs.pri:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50936
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Fri, 13 Nov 2009 10:45:16 +0000 (10:45 +0000)]
2009-11-13 Pavel Feldman <pfeldman@chromium.org>
Not reviewed. Reverting r50908 since it makes inspector tests
time out.
https://bugs.webkit.org/show_bug.cgi?id=31439
* inspector/front-end/inspector.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50935
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kov@webkit.org [Fri, 13 Nov 2009 10:21:30 +0000 (10:21 +0000)]
Skip one new test.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50934
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Fri, 13 Nov 2009 09:51:49 +0000 (09:51 +0000)]
2009-11-13 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Timothy Hatcher.
Enable 'console.profile()' and 'console.profileEnd()'
regardless of JAVASCRIPT_DEBUGGER.
https://bugs.webkit.org/show_bug.cgi?id=31293
* WebCore.gypi:
* bindings/js/JSConsoleCustom.cpp:
(WebCore::JSConsole::profile):
(WebCore::JSConsole::profileEnd):
* bindings/v8/custom/V8ConsoleCustom.cpp: Added.
(WebCore::CALLBACK_FUNC_DECL):
* bindings/v8/custom/V8CustomBinding.h:
* page/Console.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50933
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Fri, 13 Nov 2009 09:34:01 +0000 (09:34 +0000)]
Chromium build fix.
Reviewed by NOBODY.
* bindings/v8/ScriptController.h:
(WebCore::ScriptController::evaluateInWorld): Add a dummy
method which isn't called in chromium to make things compile.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50932
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 13 Nov 2009 08:11:44 +0000 (08:11 +0000)]
2009-11-13 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Update committers.py based on svn records
https://bugs.webkit.org/show_bug.cgi?id=31366
This list was generated using validate-committer-lists from
https://bugs.webkit.org/show_bug.cgi?id=30970
and makes committers.py current for committers who have
committed in the last 3 years.
* Scripts/modules/committers.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50931
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Fri, 13 Nov 2009 07:52:22 +0000 (07:52 +0000)]
When exiting full-screen video, rather than resetting the system UI
mode, restore it to what it was when full-screen mode was entered.
Reviewed by Adele Peterson.
* WebView/WebVideoFullscreenController.h: Cleaned up style, removed
unnecessary imports, and added _savedUIMode and _savedUIOptions ivars.
* WebView/WebVideoFullscreenController.mm:
(-[WebVideoFullscreenController delegate]): Cleaned up style.
(-[WebVideoFullscreenController setDelegate:]): Ditto.
(-[WebVideoFullscreenController windowDidExitFullscreen]): Restore the
system UI mode.
(-[WebVideoFullscreenController windowDidEnterFullscreen]): Save the
system UI mode.
* WebView/WebView.mm: Added now-necessary import.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50930
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 13 Nov 2009 06:42:43 +0000 (06:42 +0000)]
2009-11-12 Anantanarayanan G Iyengar <ananta@chromium.org>
Reviewed by Adam Barth.
The document-html and window-html tests don't use a setTimeout to notify that the
test is completed. The layout test plugin now issues the notifyDone call via
javascript.
https://bugs.webkit.org/show_bug.cgi?id=31067
* plugins/document-open.html:
* plugins/window-open.html:
2009-11-12 Anantanarayanan G Iyengar <ananta@chromium.org>
Reviewed by Adam Barth.
The document-open.html test was flaky at times. The test invokes the layout test plugin
which in its destroy stream handler opens a new document. This basically tears down the
stream and the associated plugin instance, which causes a crash when the plugin stream
dereferences an invalid m_client pointer which points to the PluginView instance which
is invalid at this time. Fix is to set the m_client pointer to NULL in the stop function
and check for the same.
https://bugs.webkit.org/show_bug.cgi?id=31067
* plugins/PluginStream.cpp:
(WebCore::PluginStream::stop):
(WebCore::PluginStream::destroyStream):
2009-11-12 Anantanarayanan G Iyengar <ananta@chromium.org>
Reviewed by Adam Barth.
The document-open.html test was flaky at times. The test invokes the layout test plugin
which in its destroy stream handler opens a new document. This basically tears down the
stream and the associated plugin instance. The pluginLog function in the layout test
plugin attempts to retrieve the window script object on a torn down plugin instance
which crashed consistently on windows in the debugger. The functions which issue
these logs already have a valid window script object. We now have variants of the pluginLog
function which take in a window script object with and without variable arguments.
https://bugs.webkit.org/show_bug.cgi?id=31067
* DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
(pluginLogWithWindowObject):
(pluginLogWithWindowObjectVariableArgs):
(pluginLog):
(notifyTestCompletion):
(testDocumentOpen):
(testWindowOpen):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50929
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dumi@chromium.org [Fri, 13 Nov 2009 05:17:55 +0000 (05:17 +0000)]
Renaming some parameters passed to DB-related methods to better
indicate their purpose.
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=31449
WebCore:
* platform/chromium/ChromiumBridge.h:
WebKit/chromium:
* public/WebKitClient.h:
* src/ChromiumBridge.cpp:
(WebCore::ChromiumBridge::databaseOpenFile):
(WebCore::ChromiumBridge::databaseDeleteFile):
(WebCore::ChromiumBridge::databaseGetFileAttributes):
(WebCore::ChromiumBridge::databaseGetFileSize):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50928
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 13 Nov 2009 05:08:00 +0000 (05:08 +0000)]
2009-11-12 Steve VanDeBogart <vandebo@chromium.org>
Reviewed by Adam Barth.
Calculate the time offset only if we were able to parse
the date string. This saves an IPC in Chromium for
invalid date strings.
https://bugs.webkit.org/show_bug.cgi?id=31416
* wtf/DateMath.cpp:
(WTF::parseDateFromNullTerminatedCharacters):
(JSC::parseDateFromNullTerminatedCharacters):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50927
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 13 Nov 2009 04:59:25 +0000 (04:59 +0000)]
2009-11-12 Kinuko Yasuda <kinuko@google.com>
Reviewed by Adam Barth.
Makes the output of fast/events/mouse-click-events.html independent
of the window size.
https://bugs.webkit.org/show_bug.cgi?id=31405
* fast/events/mouse-click-events-expected.txt:
* fast/events/script-tests/mouse-click-events.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50926
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Fri, 13 Nov 2009 04:36:56 +0000 (04:36 +0000)]
2009-11-12 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
Transformed reflected elements are clipped inside element with opacity
https://bugs.webkit.org/show_bug.cgi?id=30957
transparencyClipBox() attemped to minimize the size of the transparency layer by mapping
each clip rect into painting space before taking the unions. This, however, did not work
correctly with combinations of reflections and transforms. Fixed by unioning the
clipRect and mapping through transforms along the way.
Also leave some #ifdeffed code in beginTransparencyLayers() that makes it easy to see
where the transparency layers are.
Test: fast/reflections/opacity-reflection-transform.html
* rendering/RenderLayer.cpp:
(WebCore::expandClipRectForDescendantsAndReflection):
(WebCore::transparencyClipBox):
(WebCore::RenderLayer::beginTransparencyLayers):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50925
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 13 Nov 2009 03:05:42 +0000 (03:05 +0000)]
2009-11-12 Adam Barth <abarth@webkit.org>
Reviewed by Darin Fisher.
Improve SecurityOrigin::toString comment
https://bugs.webkit.org/show_bug.cgi?id=31041
* page/SecurityOrigin.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50924
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hamaji@chromium.org [Fri, 13 Nov 2009 02:37:09 +0000 (02:37 +0000)]
2009-11-12 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
externalRepresentation should take Frame as the argument
https://bugs.webkit.org/show_bug.cgi?id=31393
No new tests as this is just a refactoring.
* WebCore.base.exp:
* rendering/RenderTreeAsText.cpp:
(WebCore::externalRepresentation):
* rendering/RenderTreeAsText.h:
2009-11-12 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
externalRepresentation should take Frame as the argument
https://bugs.webkit.org/show_bug.cgi?id=31393
No new tests as this is just a refactoring.
* webkit/webkitwebframe.cpp:
(webkit_web_frame_dump_render_tree):
2009-11-12 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
externalRepresentation should take Frame as the argument
https://bugs.webkit.org/show_bug.cgi?id=31393
No new tests as this is just a refactoring.
* Misc/WebCoreStatistics.mm:
(-[WebFrame renderTreeAsExternalRepresentation]):
2009-11-12 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
externalRepresentation should take Frame as the argument
https://bugs.webkit.org/show_bug.cgi?id=31393
No new tests as this is just a refactoring.
* Api/qwebframe.cpp:
(QWebFrame::renderTreeDump):
2009-11-12 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Darin Adler.
externalRepresentation should take Frame as the argument
https://bugs.webkit.org/show_bug.cgi?id=31393
No new tests as this is just a refactoring.
* WebFrame.cpp:
(WebFrame::renderTreeAsExternalRepresentation):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50923
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
benm@google.com [Fri, 13 Nov 2009 02:22:41 +0000 (02:22 +0000)]
[Android] The Android specific files in page/Android are out of date.
https://bugs.webkit.org/show_bug.cgi?id=31437
Reviewed by Dimitri Glazkov.
No tests required.
* page/android/DragControllerAndroid.cpp:
(WebCore::DragController::dragOperation): Added.
(WebCore::DragController::cleanupAfterSystemDrag):
* page/android/EventHandlerAndroid.cpp:
(WebCore::EventHandler::accessKeyModifiers): Added.
* page/android/InspectorControllerAndroid.cpp: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50922
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 13 Nov 2009 01:59:51 +0000 (01:59 +0000)]
2009-11-12 Joanmarie Diggs <joanmarie.diggs@gmail.com>
Reviewed by Gustavo Noronha Silva.
https://bugs.webkit.org/show_bug.cgi?id=30997
[Gtk] Implemment AtkDocument
Added testing support for AtkDocument implementation.
* accessibility/document-attributes.html: Added.
* accessibility/document-attributes-expected.txt: Added.
* platform/mac/Skipped:
* platform/win/Skipped:
2009-11-12 Joanmarie Diggs <joanmarie.diggs@gmail.com>
Reviewed by Gustavo Noronha Silva.
https://bugs.webkit.org/show_bug.cgi?id=30997
[Gtk] Implemment AtkDocument
Added testing support.
* DumpRenderTree/AccessibilityUIElement.cpp:
* DumpRenderTree/AccessibilityUIElement.h:
(getDocumentEncodingCallback):
(getDocumentURICallback):
(AccessibilityUIElement::getJSClass):
* DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
* DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::documentEncoding):
(AccessibilityUIElement::documentURI):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50921
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Fri, 13 Nov 2009 01:47:45 +0000 (01:47 +0000)]
WebCore: [CAIRO] shadow support for Canvas and SVG.
[https://bugs.webkit.org/show_bug.cgi?id=30960]
Reviewed by Simon Fraser.
Implement Canvas/SVG shadow support for Cairo. This patch
uses the filter code from SVG Filters. That means that it is
necessary to activate filters to see the shadows.
Test: fast/canvas/canvas-shadow.html
* GNUmakefile.am:
* WebCore.vcproj/WebCore.vcproj: Add new ImageBufferFilter files.
* platform/graphics/GraphicsContext.h:
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(GraphicsContext::calculateShadowBufferDimensions): New helper routine.
(WebCore::setPlatformFill):
(WebCore::setPlatformStroke):
(WebCore::copyContextProperties):
(WebCore::drawPathShadow):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::drawPath):
(WebCore::GraphicsContext::setPlatformShadow):
(WebCore::GraphicsContext::createPlatformShadow):
* platform/graphics/cairo/ImageCairo.cpp:
(WebCore::BitmapImage::draw): Add filter effect.
* platform/graphics/filters/Filter.h: Correct 'const' signatures.
* platform/graphics/filters/ImageBufferFilter.cpp: Added.
* platform/graphics/filters/ImageBufferFilter.h: Added.
* svg/graphics/filters/SVGFilter.cpp: Correct 'const' signatures.
* svg/graphics/filters/SVGFilter.h: Correct 'const' signatures.
LayoutTests: Some tests for canvas shadow.
Patch by Dirk Schulze <krit@webkit.org> on 2009-11-11
Reviewed by Simon Fraser.
* fast/canvas/canvas-shadow-expected.txt: Added.
* fast/canvas/canvas-shadow.html: Added.
* fast/canvas/script-tests/canvas-shadow.js: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50920
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dimich@chromium.org [Fri, 13 Nov 2009 01:12:20 +0000 (01:12 +0000)]
Add postTaskToMainThread to ScriptExecutionContext.
Move the code to post task to the main thread into a new method on ScriptExecutionContext,
to use as a helper implementation of the virtual ScriptExecutionContext::postTask(Task) in
contexts that live on the main thread.
https://bugs.webkit.org/show_bug.cgi?id=31427
Reviewed by Alexey Proskuryakov.
No new tests - simply moving the code.
* dom/Document.cpp:
(WebCore::Document::postTask):
* dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContextTaskTimer::ScriptExecutionContextTaskTimer):
(WebCore::ScriptExecutionContextTaskTimer::fired):
(WebCore::PerformTaskData::PerformTaskData):
(WebCore::PerformTaskData::performTask):
(WebCore::ScriptExecutionContext::postTaskToMainThread):
* dom/ScriptExecutionContext.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50919
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Fri, 13 Nov 2009 00:44:23 +0000 (00:44 +0000)]
2009-11-12 Simon Fraser <simon.fraser@apple.com>
Reviewed by Darin Adler.
Fix crash when removing compositing layers when GC is enabled
https://bugs.webkit.org/show_bug.cgi?id=31429
Workaround <rdar://problem/
7390716> by special-casing the removal
of all sublayers when GC is enabled.
* platform/graphics/mac/GraphicsLayerCA.mm:
(WebCore::safeSetSublayers):
(WebCore::GraphicsLayerCA::updateSublayerList):
(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50918
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bweinstein@apple.com [Fri, 13 Nov 2009 00:38:37 +0000 (00:38 +0000)]
Rubber-stamped by Steve Falkenburg.
Add failing tests to Skipped list.
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50917
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Fri, 13 Nov 2009 00:28:29 +0000 (00:28 +0000)]
Rollout r50896 until i can work out why it causes failures.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50916
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Fri, 13 Nov 2009 00:23:47 +0000 (00:23 +0000)]
Remove LIBRARY directive from def file to fix Debug_All target.
Reviewed by Stephanie Lewis.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50915
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
snej@chromium.org [Fri, 13 Nov 2009 00:17:26 +0000 (00:17 +0000)]
The last of the V8 binding optimizations.
- Replace string-valued element accessors with a shared getter/setter function.
- Change error handling flow of control to avoid extra branches and function calls.
https://bugs.webkit.org/show_bug.cgi?id=31443
Reviewed by Dimitri Glazkov.
* bindings/scripts/CodeGeneratorV8.pm:
* bindings/v8/V8Binding.cpp:
(WebCore::getElementStringAttr): Body of string-valued Element getter function.
(WebCore::setElementStringAttr): Body of string-valued Element setter function.
* bindings/v8/V8Binding.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50914
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kov@webkit.org [Thu, 12 Nov 2009 23:48:18 +0000 (23:48 +0000)]
Skipping tests that fail intermitently.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50913
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kov@webkit.org [Thu, 12 Nov 2009 23:46:05 +0000 (23:46 +0000)]
Add ChangeLog entry to the last commit
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50912
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kov@webkit.org [Thu, 12 Nov 2009 23:39:23 +0000 (23:39 +0000)]
Revert "Export fastMalloc, fastCalloc, fastRealloc and fastFree on GCC/Unix"
This reverts commit
d3f6ad156fc2ba883fdff85e7121bee9537cd021.
Conflicts:
JavaScriptCore/ChangeLog
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50911
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Thu, 12 Nov 2009 23:21:04 +0000 (23:21 +0000)]
WebCore: Fix for <rdar://problem/
7267951>
Canvas methods should reject uses of NaN and Infinity.
Reviewed by Oliver Hunt.
Test: fast/canvas/canvas-with-illegal-args.html
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::scale):
(WebCore::CanvasRenderingContext2D::rotate):
(WebCore::CanvasRenderingContext2D::translate):
(WebCore::CanvasRenderingContext2D::transform):
(WebCore::CanvasRenderingContext2D::setTransform):
LayoutTests: Test for <rdar://problem/
7267951>
Canvas methods should reject uses of NaN and Infinity.
Reviewed by Oliver Hunt.
* fast/canvas/canvas-with-illegal-args-expected.txt: Added.
* fast/canvas/canvas-with-illegal-args.html: Added.
* fast/canvas/script-tests/canvas-with-illegal-args.js: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50910
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Thu, 12 Nov 2009 23:07:25 +0000 (23:07 +0000)]
2009-11-12 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: profile timeline panel, fix obvious problems.
https://bugs.webkit.org/show_bug.cgi?id=31432
* inspector/front-end/AbstractTimelinePanel.js:
(WebInspector.AbstractTimelinePanel.prototype.updateGraphDividersIfNeeded):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._setWindowPosition):
(WebInspector.TimelineCalculator):
(WebInspector.TimelineCalculator.prototype.get minimumBoundary):
(WebInspector.TimelineCalculator.prototype.get maximumBoundary):
(WebInspector.TimelineCalculator.prototype.reset):
(WebInspector.TimelineCalculator.prototype.updateBoundaries):
(WebInspector.TimelineCalculator.prototype.formatValue):
(WebInspector.TimelineGraph):
(WebInspector.TimelineGraph.prototype.refresh):
* inspector/front-end/utilities.js:
(Element.prototype.hasStyleClass):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50909
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Thu, 12 Nov 2009 23:04:24 +0000 (23:04 +0000)]
2009-11-12 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: preload status bar button glyphs
in order to prevent them from flickering.
https://bugs.webkit.org/show_bug.cgi?id=31439
* inspector/front-end/inspector.js:
(preloadImages):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50908
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 12 Nov 2009 22:41:15 +0000 (22:41 +0000)]
Replace worldIDs with world objects
Part of <http://webkit.org/b/31414> Implement new SPI for dealing with
user scripts/stylesheets and isolated worlds
Reviewed by Sam Weinig.
WebCore:
Covered by existing tests.
* WebCore.base.exp: Update exported symbols to match what now exists
and is needed by WebKit.
* bindings/js/ScheduledAction.cpp:
(WebCore::ScheduledAction::execute): Updated for function rename.
* bindings/js/ScriptController.cpp: Removed code that dealt with
worldIDs.
(WebCore::ScriptController::createWorld): Added. Returns a new world
suitable for use on the main thread.
(WebCore::ScriptController::executeScriptInWorld): Renamed from
executeScriptInIsolatedWorld, since this works just fine with a
"normal" world.
* bindings/js/ScriptController.h: Added createWorld, removed functions
that took worldIDs, renamed executeScriptInIsolatedWorld to
executeScriptInWorld.
* page/Frame.cpp:
(WebCore::Frame::injectUserScripts):
(WebCore::Frame::injectUserScriptsForWorld):
Updated for changes to UserScriptMap and ScriptController.
* page/Frame.h: Changed injectUserScriptsForWorld to take a
DOMWrapperWorld* instead of a worldID.
* page/PageGroup.cpp:
(WebCore::PageGroup::addUserScriptToWorld):
(WebCore::PageGroup::addUserStyleSheetToWorld):
(WebCore::PageGroup::removeUserScriptFromWorld):
(WebCore::PageGroup::removeUserStyleSheetFromWorld):
(WebCore::PageGroup::removeUserScriptsFromWorld):
(WebCore::PageGroup::removeUserStyleSheetsFromWorld):
* page/PageGroup.h:
Changed these functions to take a DOMWrapperWorld* instead of a
worldID. Also updated for changes to UserScript and UserStyleSheet.
* page/UserScript.h:
* page/UserStyleSheet.h: Changed not to hold a worldID, since it was
never used.
* page/UserScriptTypes.h:
* page/UserStyleSheetTypes.h: Changed UserScriptMap and
UserStyleSheetMap to use a RefPtr<DOMWrapperWorld> instead of a
worldID as their key type.
WebKit:
* WebKit.xcodeproj/project.pbxproj: Added WebScriptWorld to the project.
WebKit/mac:
WebScriptWorld is the new object that represents a world. The only
place worldID is still used is in -[WebFrame
_stringByEvaluatingJavaScriptInIsolatedWorld:WithGlobalObject:FromString:],
but that will change soon.
* WebKit.exp: Export WebScriptWorld.
* WebView/WebFrame.mm:
(-[WebFrame _stringByEvaluatingJavaScriptInIsolatedWorld:WithGlobalObject:FromString:]):
Moved the bizarre world caching/creation logic that DRT depends on
here from the findWorld function in ScriptController.cpp. Updated to
use ScriptController::executeScriptInWorld instead of
ScriptController::executeScriptInIsolatedWorld.
(-[WebFrame _contextForWorld:]): Renamed from contextForWorldID:. Now
takes a WebScriptWorld.
* WebView/WebFramePrivate.h: Replaced contextForWorldID: with
_contextForWorld:.
* WebView/WebScriptWorld.h: Added.
* WebView/WebScriptWorld.mm: Added.
(-[WebScriptWorld initWithWorld:]): Store the passed-in world in our
_private member.
(-[WebScriptWorld init]): Create a new DOMWrapperWorld and pass it to
-initWithWorld:.
(-[WebScriptWorld dealloc]): Release _private.
(+[WebScriptWorld standardWorld]): Returns a shared instance that
represents WebCore's mainThreadNormalWorld().
(+[WebScriptWorld world]): Returns a new instance.
(core): Returns the DOMWrapperWorld for this WebScriptWorld.
* WebView/WebScriptWorldInternal.h: Added.
* WebView/WebView.mm:
(+[WebView _addUserScriptToGroup:world:source:url:whitelist:blacklist:injectionTime:]):
(+[WebView _addUserStyleSheetToGroup:world:source:url:whitelist:blacklist:]):
(+[WebView _removeUserScriptFromGroup:world:url:]):
(+[WebView _removeUserStyleSheetFromGroup:world:url:]):
(+[WebView _removeUserScriptsFromGroup:world:]):
(+[WebView _removeUserStyleSheetsFromGroup:world:]):
* WebView/WebViewPrivate.h:
Changed these functions to take a WebScriptWorld instead of a worldID.
WebKit/win:
WebScriptWorld is the new object that represents a world. The only
place worldID is still used is in
IWebFramePrivate::stringByEvaluatingJavaScriptInIsolatedWorld, but
that will change soon.
* ForEachCoClass.h: Added WebScriptWorld.
* Interfaces/IWebFramePrivate.idl: Replaced contextForWorldID with
contextForWorld.
* Interfaces/IWebScriptWorld.idl: Added.
* Interfaces/IWebViewPrivate.idl: Changed the user script/stylesheet
functions to take an IWebScriptWorld instead of a worldID.
* Interfaces/WebKit.idl: Added WebScriptWorld.
* WebFrame.cpp:
(WebFrame::contextForWorld): Renamed from contextForWorldID. Now takes
an IWebScriptWorld.
(WebFrame::stringByEvaluatingJavaScriptInIsolatedWorld): Moved the
bizarre world caching/creation logic that DRT depends on here from the
findWorld function in ScriptController.cpp. Updated to use
ScriptController::executeScriptInWorld instead of
ScriptController::executeScriptInIsolatedWorld.
* WebFrame.h: Replaced contextForWorldID with contextForWorld.
* WebScriptWorld.cpp: Added.
(WebScriptWorld::WebScriptWorld):
(WebScriptWorld::~WebScriptWorld):
(WebScriptWorld::createInstance):
(WebScriptWorld::AddRef):
(WebScriptWorld::Release):
(WebScriptWorld::QueryInterface):
Standard COM class implementations.
(WebScriptWorld::standardWorld): Returns a shared instance that represents
WebCore's mainThreadNormalWorld().
* WebScriptWorld.h: Added.
(WebScriptWorld::world): Simple getter.
* WebKit.vcproj/Interfaces.vcproj: Added IWebScriptWorld.idl.
* WebKit.vcproj/WebKit.vcproj: Added WebScriptWorld.
* WebKitClassFactory.cpp: Added WebScriptWorld.
* WebView.cpp:
(WebView::addUserScriptToGroup):
(WebView::addUserStyleSheetToGroup):
(WebView::removeUserScriptFromGroup):
(WebView::removeUserStyleSheetFromGroup):
(WebView::removeUserScriptsFromGroup):
(WebView::removeUserStyleSheetsFromGroup):
* WebView.h:
Changed these functions to take an IWebScriptWorld instead of a worldID.
WebKitTools:
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::addUserScript):
(LayoutTestController::addUserStyleSheet):
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::addUserScript):
(LayoutTestController::addUserStyleSheet):
Changed these functions to create a new WebJSWorld each time they're
called and to pass that world to WebKit.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50907
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 12 Nov 2009 22:40:38 +0000 (22:40 +0000)]
Small clean-up in WebView's user content functions
Preparation for <http://webkit.org/b/31414> Implement new SPI for
dealing with user scripts/stylesheets and isolated worlds
Reviewed by Dave Hyatt.
* WebView.cpp:
(toString):
(toKURL):
Added these helper functions to convert BSTRs to WebCore types.
(toStringVector):
(WebView::addUserScriptToGroup):
(WebView::addUserStyleSheetToGroup):
(WebView::removeUserScriptFromGroup):
(WebView::removeUserStyleSheetFromGroup):
(WebView::removeUserScriptsFromGroup):
(WebView::removeUserStyleSheetsFromGroup):
(WebView::removeAllUserContentFromGroup):
Use the new helper functions.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50906
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bweinstein@apple.com [Thu, 12 Nov 2009 22:24:26 +0000 (22:24 +0000)]
Fixes <http://webkit.org/b/31260>.
Web Inspector: Main Resources Other than HTML are mis-detected.
Reviewed by Tim Hatcher.
Even if the resource is a main resource, look at its CachedResource type,
because it might be an image, stylesheet, or JavaScript file, and we
want to show them all correctly.
* inspector/InspectorResource.cpp:
(WebCore::InspectorResource::cachedResourceType): Move this method out so it can be called in multiple places.
(WebCore::InspectorResource::type):
* inspector/InspectorResource.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50905
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Thu, 12 Nov 2009 22:13:49 +0000 (22:13 +0000)]
Skip an accessibility test that covers functionality not available on Tiger or Leopard.
* platform/mac-leopard/Skipped:
* platform/mac-tiger/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50904
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kov@webkit.org [Thu, 12 Nov 2009 22:07:10 +0000 (22:07 +0000)]
Skipping one more new test, and a number of other tests, with bugs
filled.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50903
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Thu, 12 Nov 2009 21:33:10 +0000 (21:33 +0000)]
Remove a now-empty directory that I missed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50902
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Thu, 12 Nov 2009 21:32:14 +0000 (21:32 +0000)]
Fix results for fast/dom/Window/window-properties.html after r50893.
* fast/dom/Window/window-properties-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50901
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Thu, 12 Nov 2009 21:32:11 +0000 (21:32 +0000)]
Move a misplaced accessibility test from platform/mac-snowleopard/accessibility to accessibility,
and the results from platform/mac-snowleopard/accessibility to platform/mac/accessibility.
Rubber-stamped by Anders Carlsson.
* accessibility/aria-list-and-listitem.html: Renamed from LayoutTests/platform/mac-snowleopard/accessibility/aria-list-and-listitem.html.
* platform/mac/accessibility/aria-list-and-listitem-expected.txt: Renamed from LayoutTests/platform/mac-snowleopard/accessibility/aria-list-and-listitem-expected.txt.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50900
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Thu, 12 Nov 2009 21:32:08 +0000 (21:32 +0000)]
Land updated results for file-url-mimetypes-2.html and file-url-mimetypes-3.html.
Rubber-stamped by Brady Eidson.
* platform/mac-snowleopard/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt: Copied from LayoutTests/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt.
* platform/mac-snowleopard/platform/mac/fast/loader/file-url-mimetypes-3-expected.txt: Copied from LayoutTests/platform/mac/fast/loader/file-url-mimetypes-3-expected.txt.
* platform/mac/fast/loader/file-url-mimetypes-2-expected.txt:
* platform/mac/fast/loader/file-url-mimetypes-3-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50899
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kov@webkit.org [Thu, 12 Nov 2009 21:28:54 +0000 (21:28 +0000)]
2009-11-12 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Unreviewed. Skipped new tests, a test that keeps failing despite
not failing locally, and a new DnD test.
* platform/gtk/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50898
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
snej@chromium.org [Thu, 12 Nov 2009 21:17:23 +0000 (21:17 +0000)]
Table-driven setup for V8 binding template callback functions. 100k in code savings.
https://bugs.webkit.org/show_bug.cgi?id=31420
Reviewed by Dimitri Glazkov.
* bindings/scripts/CodeGeneratorV8.pm: Change generated ConfigureXXXTemplate fn
to call configureTemplate().
* bindings/v8/V8Binding.cpp:
(WebCore::configureTemplate): New function; does all the standard configuration work.
(WebCore::createCallback): De-inlined wrapper for FunctionTemplate creation.
* bindings/v8/V8Binding.h:
* bindings/v8/V8Proxy.cpp:
(WebCore::batchConfigureAttributes): Just wrapped the very long fn parameter list.
(WebCore::batchConfigureCallbacks): New function, used by configureTemplate.
(WebCore::batchConfigureConstants): Just wrapped the very long fn parameter list.
* bindings/v8/V8Proxy.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50897
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Thu, 12 Nov 2009 21:07:51 +0000 (21:07 +0000)]
Start unifying entry logic for function and eval code.
Reviewed by Gavin Barraclough.
Eval now uses a ret instruction to end execution, and sets up
a callframe more in line with what we do for function entry.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50896
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dumi@chromium.org [Thu, 12 Nov 2009 21:03:24 +0000 (21:03 +0000)]
Unreviewed, fix Chromium build after trac.webkit.org/changeset/50876.
* platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50895
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric.carlson@apple.com [Thu, 12 Nov 2009 21:02:41 +0000 (21:02 +0000)]
2009-11-12 Eric Carlson <eric.carlson@apple.com>
Unreviewed, build fix.
Skipped tests need path relative to LayoutTests folder, not just
test name.
* platform/gtk/Skipped:
* platform/mac-leopard/Skipped:
* platform/mac-tiger/Skipped:
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50894
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric.carlson@apple.com [Thu, 12 Nov 2009 20:23:15 +0000 (20:23 +0000)]
2009-11-12 Eric Carlson <eric.carlson@apple.com>
Reviewed by Dan Bernstein.
<rdar://problem/
7388969> Add DOM API for fullscreen video
DOM API for fullscreen <video>.
Tests: media/media-fullscreen-inline.html
media/media-fullscreen-not-in-document.html
* dom/EventNames.h:
Add webkitbeginfullscreen and webkitendfullscreen.
* html/HTMLAttributeNames.in:
Add onwebkitbeginfullscreen and onwebkitendfullscreen.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::parseMappedAttribute):
Deal with onwebkitbeginfullscreen and onwebkitendfullscreen.
(WebCore::HTMLMediaElement::enterFullscreen):
Schedule webkitbeginfullscreenEvent event, don't set m_isFullscreen unless we
actually do enter fullscreen.
(WebCore::HTMLMediaElement::exitFullscreen):
Schedule webkitendfullscreenEvent event.
(WebCore::HTMLMediaElement::webkitEnterFullScreen):
(WebCore::HTMLMediaElement::webkitExitFullScreen):
(WebCore::HTMLMediaElement::webkitSupportsFullscreen):
(WebCore::HTMLMediaElement::webkitDisplayingFullscreen):
New, access to fullscreen properties and methods.
* html/HTMLMediaElement.h:
* html/HTMLMediaElement.idl:
Declare methods needed for fullscreen API.
* html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::supportsFullscreen):
Return false if a movie does not have video.
* page/DOMWindow.h:
Add webkitbeginfullscreen and webkitendfullscreen.
2009-11-12 Eric Carlson <eric.carlson@apple.com>
Reviewed by Dan Bernstein.
<rdar://problem/
7388969> Add DOM API for fullscreen video
Tests for fullscreen <video> DOM API.
* media/media-fullscreen-inline-expected.txt: Added.
* media/media-fullscreen-inline.html: Added.
* media/media-fullscreen-not-in-document-expected.txt: Added.
* media/media-fullscreen-not-in-document.html: Added.
* media/media-fullscreen.js: Added.
* platform/gtk/Skipped:
* platform/mac-tiger/Skipped:
* platform/win/Skipped:
Skipped on platforms that don't support fullscreen yet.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50893
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Thu, 12 Nov 2009 20:16:46 +0000 (20:16 +0000)]
Reviewed by David Levin.
https://bugs.webkit.org/show_bug.cgi?id=31426
Some WebSocket tests don't properly listen to close event
* websocket/tests/script-tests/handshake-error.js:
* websocket/tests/script-tests/simple.js:
Made the tests clear second-chance timer on finish, avoiding confusing output when running
them in Safari.
* websocket/tests/script-tests/frame-length-longer-than-buffer.js:
* websocket/tests/script-tests/frame-length-skip.js:
* websocket/tests/frame-length-longer-than-buffer-expected.txt:
* websocket/tests/frame-length-skip-expected.txt:
These tests now finish properly.
* websocket/tests/handshake-error-expected.txt:
* websocket/tests/simple-expected.txt:
I'm getting an extra empty line for these tests, which is surprising. But since I didn't
change anything, I assume that it should be there.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50892
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 12 Nov 2009 20:03:56 +0000 (20:03 +0000)]
2009-11-12 Adam Barth <abarth>
Reviewed by Dimitri Glazkov.
[Chromium] reload-subframe-object.html fails
https://bugs.webkit.org/show_bug.cgi?id=31398
More closely match FrameLoaderClient.mm. Turns out we don't want to
use MIMETypeRegistry::getMIMETypeForPath because we can't distinguish
between application/octet-stream and lack of knowledge of the MIME
type.
Covered by reload-subframe-object.html.
* src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::objectContentType):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50891
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 12 Nov 2009 19:56:01 +0000 (19:56 +0000)]
2009-11-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
[Chromium] Sify compose button alerts error
https://bugs.webkit.org/show_bug.cgi?id=31394
Test that we're using the calling security context in a simple case.
* http/tests/security/calling-versus-current-expected.txt: Added.
* http/tests/security/calling-versus-current.html: Added.
2009-11-12 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
[Chromium] Sify compose button alerts error
https://bugs.webkit.org/show_bug.cgi?id=31394
Test: http/tests/security/calling-versus-current.html
We're supposed to use the calling context for security checks. In JSC
land, this is the lexicalGlobalObject.
* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::canAccessPrivate):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50890
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
japhet@chromium.org [Thu, 12 Nov 2009 19:24:01 +0000 (19:24 +0000)]
2009-11-12 Nate Chapin <japhet@chromium.org>
Unreviewed, Chromium build fix.
Add new accessibility enum values to Chromium enums from
http://trac.webkit.org/changeset/50865 and
http://trac.webkit.org/changeset/50883.
https://bugs.webkit.org/show_bug.cgi?id=31424
* public/WebAccessibilityRole.h:
(WebKit::):
* src/AssertMatchingEnums.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50889
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dbates@webkit.org [Thu, 12 Nov 2009 19:21:52 +0000 (19:21 +0000)]
2009-11-12 Daniel Bates <dbates@webkit.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=30291
Fixes an issue where the returned drop effect is incorrect when
effectAllowed == "uninitialized".
According to section 7.9.2 of the HTML 5 spec.
<http://dev.w3.org/html5/spec/Overview.html#the-dragevent-and-datatransfer-interfaces>
when effectAllowed = "uninitialized" the resulting dropEffect should be the
user-specified dropEffect (i.e. "copy", "move", "link") and "none" for any
other case.
No test cases are included because we have an existing test case from
bug #24731.
* dom/Clipboard.cpp:
(WebCore::dragOpFromIEOp): Added case for op == "uninitialized".
2009-11-12 Daniel Bates <dbates@webkit.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=30291
Rebased results for existing test case fast/events/drag-and-drop.html
from bug #24731.
Now, we can run the part of the test when effectAllowed == "uninitialized".
* fast/events/drag-and-drop-expected.txt: Rebased results.
* fast/events/drag-and-drop.html: Removed notice about this bug (#30291).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50888
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 12 Nov 2009 18:46:20 +0000 (18:46 +0000)]
2009-11-12 Nicolas Weber <thakis@chromium.org>
Reviewed by Dimitri Glazkov.
Send |keypress()| events for keys with cmd down, like safari.
Test: Hit cmd-shift-a on unixpapa.com/js/testkey.html , should show a
keypress() event.
* src/mac/WebInputEventFactory.mm:
(WebKit::WebInputEventFactory::keyboardEvent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50887
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Thu, 12 Nov 2009 18:35:39 +0000 (18:35 +0000)]
2009-11-12 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Do not highlight node on refresh.
https://bugs.webkit.org/show_bug.cgi?id=31419
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.reset):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50886
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Thu, 12 Nov 2009 18:23:56 +0000 (18:23 +0000)]
2009-11-12 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Minor timeline fixes.
https://bugs.webkit.org/show_bug.cgi?id=31417
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._getRecordDetails):
(WebInspector.TimelineRecordTreeElement.prototype.onattach):
(WebInspector.TimelineRecordTreeElement.prototype._updateDetails):
(WebInspector.TimelineRecordTreeElement.prototype.refresh):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50885
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Thu, 12 Nov 2009 17:44:56 +0000 (17:44 +0000)]
SnowLeopard build fix.
Renamed initWithClient to initWithAuthenticationClient.
* platform/network/mac/AuthenticationMac.mm:
(-[WebCoreAuthenticationClientAsChallengeSender initWithAuthenticationClient:]):
(WebCore::AuthenticationChallenge::setAuthenticationClient):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50884
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 12 Nov 2009 17:37:39 +0000 (17:37 +0000)]
2009-11-12 Chris Fleizach <cfleizach@apple.com>
Reviewed by Darin Adler.
ARIA: add alert type roles
https://bugs.webkit.org/show_bug.cgi?id=31392
* platform/mac/accessibility/aria-alerts-expected.txt: Added.
* platform/mac/accessibility/aria-alerts.html: Added.
2009-11-12 Chris Fleizach <cfleizach@apple.com>
Reviewed by Darin Adler.
ARIA: add alert type roles
https://bugs.webkit.org/show_bug.cgi?id=31392
Test: platform/mac/accessibility/aria-alerts.html
* accessibility/AccessibilityObject.h:
* accessibility/AccessibilityRenderObject.cpp:
* accessibility/mac/AccessibilityObjectWrapper.mm:
2009-11-12 Chris Fleizach <cfleizach@apple.com>
Reviewed by Darin Adler.
ARIA: add alert type roles
https://bugs.webkit.org/show_bug.cgi?id=31392
* English.lproj/Localizable.strings:
* StringsNotToBeLocalized.txt:
2009-11-12 Chris Fleizach <cfleizach@apple.com>
Reviewed by Darin Adler.
ARIA: add alert type roles
https://bugs.webkit.org/show_bug.cgi?id=31392
* WebCoreSupport/WebViewFactory.mm:
(-[WebViewFactory AXARIAContentGroupText:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50883
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Thu, 12 Nov 2009 17:18:02 +0000 (17:18 +0000)]
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=31386
Make Mac AuthenticationChallenge usable from cross-platform code
No change in behavior, so no tests.
* platform/network/ResourceHandle.cpp:
(WebCore::ResourceHandle::clearAuthentication):
* platform/network/ResourceHandleInternal.h:
(WebCore::ResourceHandleInternal::ResourceHandleInternal):
Don't store m_currentCFChallenge, which was only used for a single assertion. Unlike the
NSURLConnection case, CF challenge doesn't carry a sender with it, so the copy in web challenge
is identical.
* platform/network/cf/AuthenticationChallenge.h:
(WebCore::AuthenticationChallenge::setAuthenticationClient): Added a setter to match the new
Mac interface. Previously, one had to create a new AuthenticationChallenge to replace client.
* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Fixed assertions after removal
of m_currentCFChallenge. Also, there is no need to set client now, as it's guaranteed to
be already set.
* platform/network/mac/AuthenticationChallenge.h:
(WebCore::AuthenticationChallenge::m_sender): Explained the existence of this member to the
best of my understanding.
(WebCore::AuthenticationChallenge::m_nsChallenge): Renamed from m_macChallenge to prevent
confusion with "mac" and "web" challenges in ResourceHandleInternal.
* platform/network/mac/AuthenticationMac.mm:
(WebCoreAuthenticationClientAsChallengeSender): Added a Obj-C wrapper for AuthenticationClient,
making it possible to use the latter with NSURLAuthenticationChallenge.
(WebCore::AuthenticationChallenge::AuthenticationChallenge): Updated for m_macChallenge ->
m_nsChallenge renaming.
(WebCore::AuthenticationChallenge::setAuthenticationClient): Wrap the client in Obj-C and
set it as sender (or unset, if client is null).
* platform/network/mac/ResourceHandleMac.mm:
(WebCoreResourceHandleAsDelegate) WebCoreResourceHandleAsDelegate no longer doubles as
authentication challenge sender.
(WebCore::ResourceHandle::~ResourceHandle): A navigation can happen underneath an
authentication sheet.
(WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Form m_currentWebChallenge
using the new setAuthenticationClient() method.
(WebCore::ResourceHandle::didCancelAuthenticationChallenge): Fixed an incorrect assertion.
Since didCancelAuthenticationChallenge is called by connection, the passed challenge is
the original Mac one, not the one we created for use with authentication sheet. I don't
know when a connection would cancel authentication in practice, so I haven't tested this.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50882
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 12 Nov 2009 17:08:01 +0000 (17:08 +0000)]
2009-11-12 Patrick Mueller <Patrick_Mueller@us.ibm.com>
Reviewed by Timothy Hatcher.
Web Inspector: breakpoint sidebar entries should allow click over entire list item
https://bugs.webkit.org/show_bug.cgi?id=31411
No new tests; no new functionality, small usability change.
* inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector.BreakpointsSidebarPane.prototype._appendBreakpointElement):
(WebInspector.BreakpointsSidebarPane.prototype._appendBreakpointElement.breakpointClicked):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50881
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 12 Nov 2009 17:00:22 +0000 (17:00 +0000)]
2009-11-12 Patrick Mueller <Patrick_Mueller@us.ibm.com>
Reviewed by Timothy Hatcher.
Web Inspector: breakpoints in named evals are not restored after a reload
https://bugs.webkit.org/show_bug.cgi?id=31375
Manual test added
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.addScript):
* manual-tests/inspector/bp-in-named-eval-after-reload.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50880
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tonikitoo@webkit.org [Thu, 12 Nov 2009 14:37:31 +0000 (14:37 +0000)]
[Qt] Various doc fixes
https://bugs.webkit.org/show_bug.cgi?id=31358
Reviewed by Jan Alonzo.
QWebPage's constructor docs are mentioning "QWebView":
"Constructs an empty QWebView with parent".
* Api/qwebpage.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50879
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zoltan@webkit.org [Thu, 12 Nov 2009 14:13:57 +0000 (14:13 +0000)]
Rubber-stamped by Tor Arne Vestbø.
Patch by Andras Becsi <becsi.andras@stud.u-szeged.hu> on 2009-11-12
[Qt] Update outdated metrics in layout tests after change to Qt 4.6 on the buildbot.
* platform/qt/css1/basic/class_as_selector-expected.txt:
* platform/qt/css1/basic/comments-expected.txt:
* platform/qt/css1/basic/containment-expected.txt:
* platform/qt/css1/basic/contextual_selectors-expected.txt:
* platform/qt/css1/basic/grouping-expected.txt:
* platform/qt/css1/basic/id_as_selector-expected.txt:
* platform/qt/css1/basic/inheritance-expected.txt:
* platform/qt/css1/box_properties/acid_test-expected.txt:
* platform/qt/css1/box_properties/border-expected.txt:
* platform/qt/css1/box_properties/border_bottom-expected.txt:
* platform/qt/css1/box_properties/border_bottom_inline-expected.txt:
* platform/qt/css1/box_properties/border_bottom_width-expected.txt:
* platform/qt/css1/box_properties/border_bottom_width_inline-expected.txt:
* platform/qt/css1/box_properties/border_color-expected.txt:
* platform/qt/css1/box_properties/border_color_inline-expected.txt:
* platform/qt/css1/box_properties/border_inline-expected.txt:
* platform/qt/css1/box_properties/border_left-expected.txt:
* platform/qt/css1/box_properties/border_left_inline-expected.txt:
* platform/qt/css1/box_properties/border_left_width-expected.txt:
* platform/qt/css1/box_properties/border_left_width_inline-expected.txt:
* platform/qt/css1/box_properties/border_right-expected.txt:
* platform/qt/css1/box_properties/border_right_inline-expected.txt:
* platform/qt/css1/box_properties/border_right_width-expected.txt:
* platform/qt/css1/box_properties/border_right_width_inline-expected.txt:
* platform/qt/css1/box_properties/border_style-expected.txt:
* platform/qt/css1/box_properties/border_style_inline-expected.txt:
* platform/qt/css1/box_properties/border_top-expected.txt:
* platform/qt/css1/box_properties/border_top_inline-expected.txt:
* platform/qt/css1/box_properties/border_top_width-expected.txt:
* platform/qt/css1/box_properties/border_top_width_inline-expected.txt:
* platform/qt/css1/box_properties/border_width-expected.txt:
* platform/qt/css1/box_properties/border_width_inline-expected.txt:
* platform/qt/css1/box_properties/clear-expected.txt:
* platform/qt/css1/box_properties/clear_float-expected.txt:
* platform/qt/css1/box_properties/float-expected.txt:
* platform/qt/css1/box_properties/float_elements_in_series-expected.txt:
* platform/qt/css1/box_properties/float_margin-expected.txt:
* platform/qt/css1/box_properties/float_on_text_elements-expected.txt:
* platform/qt/css1/box_properties/height-expected.txt:
* platform/qt/css1/box_properties/margin-expected.txt:
* platform/qt/css1/box_properties/margin_bottom-expected.txt:
* platform/qt/css1/box_properties/margin_bottom_inline-expected.txt:
* platform/qt/css1/box_properties/margin_inline-expected.txt:
* platform/qt/css1/box_properties/margin_left-expected.txt:
* platform/qt/css1/box_properties/margin_left_inline-expected.txt:
* platform/qt/css1/box_properties/margin_right-expected.txt:
* platform/qt/css1/box_properties/margin_right_inline-expected.txt:
* platform/qt/css1/box_properties/margin_top-expected.txt:
* platform/qt/css1/box_properties/margin_top_inline-expected.txt:
* platform/qt/css1/box_properties/padding-expected.txt:
* platform/qt/css1/box_properties/padding_bottom-expected.txt:
* platform/qt/css1/box_properties/padding_bottom_inline-expected.txt:
* platform/qt/css1/box_properties/padding_inline-expected.txt:
* platform/qt/css1/box_properties/padding_left-expected.txt:
* platform/qt/css1/box_properties/padding_left_inline-expected.txt:
* platform/qt/css1/box_properties/padding_right-expected.txt:
* platform/qt/css1/box_properties/padding_right_inline-expected.txt:
* platform/qt/css1/box_properties/padding_top-expected.txt:
* platform/qt/css1/box_properties/padding_top_inline-expected.txt:
* platform/qt/css1/box_properties/width-expected.txt:
* platform/qt/css1/cascade/cascade_order-expected.txt:
* platform/qt/css1/cascade/important-expected.txt:
* platform/qt/css1/classification/display-expected.txt:
* platform/qt/css1/classification/list_style-expected.txt:
* platform/qt/css1/classification/list_style_image-expected.txt:
* platform/qt/css1/classification/list_style_position-expected.txt:
* platform/qt/css1/classification/list_style_type-expected.txt:
* platform/qt/css1/classification/white_space-expected.txt:
* platform/qt/css1/color_and_background/background-expected.txt:
* platform/qt/css1/color_and_background/background_attachment-expected.txt:
* platform/qt/css1/color_and_background/background_color-expected.txt:
* platform/qt/css1/color_and_background/background_image-expected.txt:
* platform/qt/css1/color_and_background/background_position-expected.txt:
* platform/qt/css1/color_and_background/background_repeat-expected.txt:
* platform/qt/css1/color_and_background/color-expected.txt:
* platform/qt/css1/conformance/forward_compatible_parsing-expected.txt:
* platform/qt/css1/font_properties/font-expected.txt:
* platform/qt/css1/font_properties/font_family-expected.txt:
* platform/qt/css1/font_properties/font_size-expected.txt:
* platform/qt/css1/font_properties/font_style-expected.txt:
* platform/qt/css1/font_properties/font_variant-expected.txt:
* platform/qt/css1/font_properties/font_weight-expected.txt:
* platform/qt/css1/formatting_model/canvas-expected.txt:
* platform/qt/css1/formatting_model/floating_elements-expected.txt:
* platform/qt/css1/formatting_model/height_of_lines-expected.txt:
* platform/qt/css1/formatting_model/horizontal_formatting-expected.txt:
* platform/qt/css1/formatting_model/inline_elements-expected.txt:
* platform/qt/css1/formatting_model/replaced_elements-expected.txt:
* platform/qt/css1/formatting_model/vertical_formatting-expected.txt:
* platform/qt/css1/pseudo/anchor-expected.txt:
* platform/qt/css1/pseudo/firstletter-expected.txt:
* platform/qt/css1/pseudo/firstline-expected.txt:
* platform/qt/css1/pseudo/multiple_pseudo_elements-expected.txt:
* platform/qt/css1/pseudo/pseudo_elements_in_selectors-expected.txt:
* platform/qt/css1/text_properties/letter_spacing-expected.txt:
* platform/qt/css1/text_properties/line_height-expected.txt:
* platform/qt/css1/text_properties/text_align-expected.txt:
* platform/qt/css1/text_properties/text_decoration-expected.txt:
* platform/qt/css1/text_properties/text_indent-expected.txt:
* platform/qt/css1/text_properties/text_transform-expected.txt:
* platform/qt/css1/text_properties/vertical_align-expected.txt:
* platform/qt/css1/text_properties/word_spacing-expected.txt:
* platform/qt/css1/units/color_units-expected.txt:
* platform/qt/css1/units/length_units-expected.txt:
* platform/qt/css1/units/percentage_units-expected.txt:
* platform/qt/css1/units/urls-expected.txt:
* platform/qt/css2.1/t040102-keywords-00-b-expected.txt:
* platform/qt/css2.1/t040102-keywords-01-b-expected.txt:
* platform/qt/css2.1/t040103-case-00-b-expected.txt:
* platform/qt/css2.1/t040103-case-01-c-expected.txt:
* platform/qt/css2.1/t040103-escapes-00-b-expected.txt:
* platform/qt/css2.1/t040103-escapes-01-b-expected.txt:
* platform/qt/css2.1/t040103-escapes-02-d-expected.txt:
* platform/qt/css2.1/t040103-escapes-03-b-expected.txt:
* platform/qt/css2.1/t040103-escapes-04-b-expected.txt:
* platform/qt/css2.1/t040103-escapes-05-c-expected.txt:
* platform/qt/css2.1/t040103-escapes-06-b-expected.txt:
* platform/qt/css2.1/t040103-escapes-07-b-expected.txt:
* platform/qt/css2.1/t040103-escapes-08-b-expected.txt:
* platform/qt/css2.1/t040103-ident-00-c-expected.txt:
* platform/qt/css2.1/t040103-ident-01-c-expected.txt:
* platform/qt/css2.1/t040103-ident-02-c-expected.txt:
* platform/qt/css2.1/t040103-ident-03-c-expected.txt:
* platform/qt/css2.1/t040103-ident-04-c-expected.txt:
* platform/qt/css2.1/t040103-ident-05-c-expected.txt:
* platform/qt/css2.1/t040103-ident-06-c-expected.txt:
* platform/qt/css2.1/t040103-ident-07-c-expected.txt:
* platform/qt/css2.1/t040103-ident-08-c-expected.txt:
* platform/qt/css2.1/t040103-ident-09-c-expected.txt:
* platform/qt/css2.1/t040103-ident-10-c-expected.txt:
* platform/qt/css2.1/t040103-ident-11-c-expected.txt:
* platform/qt/css2.1/t040103-ident-12-c-expected.txt:
* platform/qt/css2.1/t040103-ident-13-c-expected.txt:
* platform/qt/css2.1/t040105-atkeyw-00-b-expected.txt:
* platform/qt/css2.1/t040105-atkeyw-01-b-expected.txt:
* platform/qt/css2.1/t040105-atkeyw-02-b-expected.txt:
* platform/qt/css2.1/t040105-atrule-00-b-expected.txt:
* platform/qt/css2.1/t040105-atrule-01-b-expected.txt:
* platform/qt/css2.1/t040105-atrule-02-b-expected.txt:
* platform/qt/css2.1/t040105-atrule-03-b-expected.txt:
* platform/qt/css2.1/t040105-atrule-04-b-expected.txt:
* platform/qt/css2.1/t040105-import-00-b-expected.txt:
* platform/qt/css2.1/t040105-import-01-b-expected.txt:
* platform/qt/css2.1/t040109-c17-comments-00-b-expected.txt:
* platform/qt/css2.1/t040109-c17-comments-01-b-expected.txt:
* platform/qt/css2.1/t0402-c71-fwd-parsing-00-f-expected.txt:
* platform/qt/css2.1/t0402-c71-fwd-parsing-01-f-expected.txt:
* platform/qt/css2.1/t0402-c71-fwd-parsing-02-f-expected.txt:
* platform/qt/css2.1/t0402-c71-fwd-parsing-03-f-expected.txt:
* platform/qt/css2.1/t0402-c71-fwd-parsing-04-f-expected.txt:
* platform/qt/css2.1/t0402-syntax-01-f-expected.txt:
* platform/qt/css2.1/t0402-syntax-02-f-expected.txt:
* platform/qt/css2.1/t0402-syntax-03-f-expected.txt:
* platform/qt/css2.1/t0402-syntax-04-f-expected.txt:
* platform/qt/css2.1/t0402-syntax-05-f-expected.txt:
* platform/qt/css2.1/t0402-syntax-06-f-expected.txt:
* platform/qt/css2.1/t040302-c61-ex-len-00-b-a-expected.txt:
* platform/qt/css2.1/t040302-c61-phys-len-00-b-expected.txt:
* platform/qt/css2.1/t040302-c61-rel-len-00-b-ag-expected.txt:
* platform/qt/css2.1/t040304-c64-uri-00-a-g-expected.txt:
* platform/qt/css2.1/t040306-c63-color-00-b-ag-expected.txt:
* platform/qt/css2.1/t040306-syntax-01-f-expected.txt:
* platform/qt/css2.1/t040307-syntax-01-b-expected.txt:
* platform/qt/css2.1/t1202-counter-00-b-expected.txt:
* platform/qt/css2.1/t1202-counter-01-b-expected.txt:
* platform/qt/css2.1/t1202-counter-02-b-expected.txt:
* platform/qt/css2.1/t1202-counter-03-b-expected.txt:
* platform/qt/css2.1/t1202-counter-04-b-expected.txt:
* platform/qt/css2.1/t1202-counter-05-b-expected.txt:
* platform/qt/css2.1/t1202-counter-06-b-expected.txt:
* platform/qt/css2.1/t1202-counter-07-b-expected.txt:
* platform/qt/css2.1/t1202-counter-08-b-expected.txt:
* platform/qt/css2.1/t1202-counter-09-b-expected.txt:
* platform/qt/css2.1/t1202-counter-11-b-expected.txt:
* platform/qt/css2.1/t1202-counter-12-b-expected.txt:
* platform/qt/css2.1/t1202-counter-13-b-expected.txt:
* platform/qt/css2.1/t1202-counter-14-b-expected.txt:
* platform/qt/css2.1/t1202-counter-15-b-expected.txt:
* platform/qt/css2.1/t1202-counter-16-f-expected.txt:
* platform/qt/css2.1/t1202-counters-00-b-expected.txt:
* platform/qt/css2.1/t1202-counters-01-b-expected.txt:
* platform/qt/css2.1/t1202-counters-02-b-expected.txt:
* platform/qt/css2.1/t1202-counters-03-b-expected.txt:
* platform/qt/css2.1/t1202-counters-05-b-expected.txt:
* platform/qt/css2.1/t1202-counters-06-b-expected.txt:
* platform/qt/css2.1/t1202-counters-07-b-expected.txt:
* platform/qt/css2.1/t1202-counters-08-b-expected.txt:
* platform/qt/css2.1/t1202-counters-09-b-expected.txt:
* platform/qt/css2.1/t1202-counters-11-b-expected.txt:
* platform/qt/css2.1/t1202-counters-12-b-expected.txt:
* platform/qt/css2.1/t1202-counters-13-b-expected.txt:
* platform/qt/css2.1/t1202-counters-14-b-expected.txt:
* platform/qt/css2.1/t1202-counters-15-b-expected.txt:
* platform/qt/css2.1/t1202-counters-16-c-expected.txt:
* platform/qt/css2.1/t1202-counters-17-d-expected.txt:
* platform/qt/css2.1/t1202-counters-18-f-expected.txt:
* platform/qt/css2.1/t1205-c561-list-displ-00-b-expected.txt:
* platform/qt/css2.1/t1205-c563-list-type-00-b-expected.txt:
* platform/qt/css2.1/t1205-c563-list-type-01-b-expected.txt:
* platform/qt/css2.1/t1205-c564-list-img-00-b-g-expected.txt:
* platform/qt/css2.1/t1205-c565-list-pos-00-b-expected.txt:
* platform/qt/css2.1/t1205-c566-list-stl-01-c-g-expected.txt:
* platform/qt/css2.1/t140201-c532-bgcolor-00-a-expected.txt:
* platform/qt/css2.1/t140201-c532-bgcolor-01-b-expected.txt:
* platform/qt/css2.1/t140201-c533-bgimage-00-a-expected.txt:
* platform/qt/css2.1/t140201-c533-bgimage-01-b-g-expected.txt:
* platform/qt/css2.1/t140201-c534-bgre-00-b-ag-expected.txt:
* platform/qt/css2.1/t140201-c535-bg-fixd-00-b-g-expected.txt:
* platform/qt/css2.1/t140201-c536-bgpos-00-b-ag-expected.txt:
* platform/qt/css2.1/t1503-c522-font-family-00-b-expected.txt:
* platform/qt/css2.1/t1504-c523-font-style-00-b-expected.txt:
* platform/qt/css2.1/t1504-c543-txt-decor-00-d-g-expected.txt:
* platform/qt/css2.1/t1505-c524-font-var-00-b-expected.txt:
* platform/qt/css2.1/t1506-c525-font-wt-00-b-expected.txt:
* platform/qt/css2.1/t1507-c526-font-sz-00-b-expected.txt:
* platform/qt/css2.1/t1507-c526-font-sz-01-b-a-expected.txt:
* platform/qt/css2.1/t1507-c526-font-sz-02-b-a-expected.txt:
* platform/qt/css2.1/t1507-c526-font-sz-03-f-a-expected.txt:
* platform/qt/css2.1/t1508-c527-font-00-b-expected.txt:
* platform/qt/css2.1/t1508-c527-font-01-b-expected.txt:
* platform/qt/css2.1/t1508-c527-font-02-b-expected.txt:
* platform/qt/css2.1/t1508-c527-font-03-b-expected.txt:
* platform/qt/css2.1/t1508-c527-font-04-b-expected.txt:
* platform/qt/css2.1/t1508-c527-font-05-b-expected.txt:
* platform/qt/css2.1/t1508-c527-font-06-b-expected.txt:
* platform/qt/css2.1/t1508-c527-font-07-b-expected.txt:
* platform/qt/css2.1/t1508-c527-font-08-b-expected.txt:
* platform/qt/css2.1/t1508-c527-font-09-b-expected.txt:
* platform/qt/css2.1/t1508-c527-font-10-c-expected.txt:
* platform/qt/css2.1/t170602-bdr-conflct-w-00-d-expected.txt:
* platform/qt/css2.1/t170602-bdr-conflct-w-01-d-expected.txt:
* platform/qt/css2.1/t170602-bdr-conflct-w-02-d-expected.txt:
* platform/qt/css2.1/t170602-bdr-conflct-w-03-d-expected.txt:
* platform/qt/css2.1/t170602-bdr-conflct-w-04-d-expected.txt:
* platform/qt/css2.1/t170602-bdr-conflct-w-05-d-expected.txt:
* platform/qt/css2.1/t170602-bdr-conflct-w-06-d-expected.txt:
* platform/qt/css2.1/t170602-bdr-conflct-w-07-d-expected.txt:
* platform/qt/css2.1/t170602-bdr-conflct-w-08-d-expected.txt:
* platform/qt/css2.1/t170602-bdr-conflct-w-09-d-expected.txt:
* platform/qt/css2.1/t170602-bdr-conflct-w-10-d-expected.txt:
* platform/qt/css2.1/t170602-bdr-conflct-w-11-d-expected.txt:
* platform/qt/css2.1/t170602-bdr-conflct-w-12-d-expected.txt:
* platform/qt/css2.1/t170602-bdr-conflct-w-13-d-expected.txt:
* platform/qt/css2.1/t170602-bdr-conflct-w-14-d-expected.txt:
* platform/qt/css2.1/t170602-bdr-conflct-w-15-d-expected.txt:
* platform/qt/css2.1/t170602-bdr-conflct-w-16-d-expected.txt:
* platform/qt/css2.1/t170602-bdr-conflct-w-17-d-expected.txt:
* platform/qt/css2.1/t170602-bdr-conflct-w-18-d-expected.txt:
* platform/qt/css2.1/t170602-bdr-conflct-w-19-d-expected.txt:
* platform/qt/css2.1/t170602-bdr-conflct-w-20-d-expected.txt:
* platform/qt/css2.1/t170602-bdr-conflct-w-21-d-expected.txt:
* platform/qt/css2.1/t170602-bdr-conflct-w-22-d-expected.txt:
* platform/qt/css2.1/t170602-bdr-conflct-w-23-d-expected.txt:
* platform/qt/css2.1/t170602-bdr-conflct-w-24-d-expected.txt:
* platform/qt/css2.1/t170602-bdr-conflct-w-25-d-expected.txt:
* platform/qt/css2.1/t170602-bdr-conflct-w-26-d-expected.txt:
* platform/qt/css2.1/t170602-bdr-conflct-w-27-d-expected.txt:
* platform/qt/css2.1/t170602-bdr-conflct-w-28-d-expected.txt:
* platform/qt/css2.1/t170602-bdr-conflct-w-29-d-expected.txt:
* platform/qt/css2.1/t170602-bdr-conflct-w-30-d-expected.txt:
* platform/qt/css2.1/t170602-bdr-conflct-w-31-d-expected.txt:
* platform/qt/css2.1/t170602-bdr-conflct-w-32-d-expected.txt:
* platform/qt/css2.1/t170602-bdr-conflct-w-33-d-expected.txt:
* platform/qt/css2.1/t170602-bdr-conflct-w-34-d-expected.txt:
* platform/qt/css2.1/t170602-bdr-conflct-w-35-d-expected.txt:
* platform/qt/css2.1/t170602-bdr-conflct-w-36-d-expected.txt:
* platform/qt/css2.1/t170602-bdr-conflct-w-37-d-expected.txt:
* platform/qt/css2.1/t170602-bdr-conflct-w-38-d-expected.txt:
* platform/qt/css2.1/t170602-bdr-conflct-w-39-d-expected.txt:
* platform/qt/css2.1/t170602-bdr-conflct-w-40-d-expected.txt:
* platform/qt/css2.1/t170602-bdr-conflct-w-41-d-expected.txt:
* platform/qt/css2.1/t170602-bdr-conflct-w-42-d-expected.txt:
* platform/qt/css2.1/t170602-bdr-conflct-w-43-d-expected.txt:
* platform/qt/css2.1/t170602-bdr-conflct-w-44-d-expected.txt:
* platform/qt/css2.1/t170602-bdr-conflct-w-45-d-expected.txt:
* platform/qt/css2.1/t170602-bdr-conflct-w-46-d-expected.txt:
* platform/qt/css2.1/t170602-bdr-conflct-w-47-d-expected.txt:
* platform/qt/css2.1/t170602-bdr-conflct-w-48-d-expected.txt:
* platform/qt/css2.1/t170602-bdr-conflct-w-49-d-expected.txt:
* platform/qt/editing/inserting/break-blockquote-after-delete-expected.txt:
* platform/qt/fast/backgrounds/001-expected.txt:
* platform/qt/fast/backgrounds/animated-svg-as-background-expected.txt:
* platform/qt/fast/backgrounds/background-inherit-color-bug-expected.txt:
* platform/qt/fast/backgrounds/background-origin-root-element-expected.txt:
* platform/qt/fast/backgrounds/background-position-1-expected.txt:
* platform/qt/fast/backgrounds/background-position-rounding-expected.txt:
* platform/qt/fast/backgrounds/body-generated-image-propagated-to-root-expected.txt:
* platform/qt/fast/backgrounds/mask-composite-expected.txt:
* platform/qt/fast/backgrounds/repeat/mask-negative-offset-repeat-expected.txt:
* platform/qt/fast/backgrounds/repeat/negative-offset-repeat-expected.txt:
* platform/qt/fast/backgrounds/repeat/noRepeatCorrectClip-expected.txt:
* platform/qt/fast/backgrounds/size/backgroundSize15-expected.txt:
* platform/qt/fast/backgrounds/size/zero-expected.txt:
* platform/qt/fast/backgrounds/solid-color-context-restore-expected.txt:
* platform/qt/fast/backgrounds/svg-as-background-1-expected.txt:
* platform/qt/fast/backgrounds/svg-as-background-2-expected.txt:
* platform/qt/fast/backgrounds/svg-as-background-3-expected.txt:
* platform/qt/fast/backgrounds/svg-as-background-4-expected.txt:
* platform/qt/fast/backgrounds/svg-as-background-5-expected.txt:
* platform/qt/fast/backgrounds/svg-as-background-6-expected.txt:
* platform/qt/fast/block/float/avoidance-percent-width-compat-expected.txt:
* platform/qt/fast/block/float/avoidance-percent-width-strict-expected.txt:
* platform/qt/fast/block/margin-collapse/block-inside-inline/001-expected.txt:
* platform/qt/fast/block/margin-collapse/block-inside-inline/002-expected.txt:
* platform/qt/fast/block/margin-collapse/block-inside-inline/003-expected.txt:
* platform/qt/fast/block/margin-collapse/block-inside-inline/004-expected.txt:
* platform/qt/fast/block/margin-collapse/block-inside-inline/005-expected.txt:
* platform/qt/fast/block/margin-collapse/block-inside-inline/006-expected.txt:
* platform/qt/fast/block/margin-collapse/block-inside-inline/010-expected.txt:
* platform/qt/fast/block/margin-collapse/block-inside-inline/011-expected.txt:
* platform/qt/fast/block/margin-collapse/block-inside-inline/012-expected.txt:
* platform/qt/fast/block/margin-collapse/block-inside-inline/015-expected.txt:
* platform/qt/fast/block/margin-collapse/block-inside-inline/016-expected.txt:
* platform/qt/fast/block/margin-collapse/block-inside-inline/017-expected.txt:
* platform/qt/fast/block/margin-collapse/block-inside-inline/018-expected.txt:
* platform/qt/fast/block/margin-collapse/block-inside-inline/019-expected.txt:
* platform/qt/fast/block/margin-collapse/block-inside-inline/020-expected.txt:
* platform/qt/fast/block/margin-collapse/block-inside-inline/021-expected.txt:
* platform/qt/fast/block/margin-collapse/block-inside-inline/022-expected.txt:
* platform/qt/fast/block/margin-collapse/block-inside-inline/025-expected.txt:
* platform/qt/fast/borders/border-radius-constraints-expected.txt:
* platform/qt/fast/borders/border-radius-split-inline-expected.txt:
* platform/qt/fast/box-shadow/basic-shadows-expected.txt:
* platform/qt/fast/box-shadow/inset-expected.txt:
* platform/qt/fast/box-shadow/transform-fringing-expected.txt:
* platform/qt/fast/canvas/canvas-before-css-expected.txt:
* platform/qt/fast/canvas/canvas-composite-expected.txt:
* platform/qt/fast/canvas/canvas-empty-image-pattern-expected.txt:
* platform/qt/fast/canvas/canvas-transform-identity-expected.txt:
* platform/qt/fast/canvas/canvas-transform-infinity-expected.txt:
* platform/qt/fast/canvas/canvas-transform-multiply-expected.txt:
* platform/qt/fast/canvas/canvas-transform-nan-expected.txt:
* platform/qt/fast/canvas/canvas-transform-non-invertible-expected.txt:
* platform/qt/fast/canvas/canvas-transform-skewed-expected.txt:
* platform/qt/fast/canvas/canvas-transforms-during-path-expected.txt:
* platform/qt/fast/canvas/canvas-zoom-expected.txt:
* platform/qt/fast/canvas/drawImage-expected.txt:
* platform/qt/fast/canvas/drawImage-with-globalAlpha-expected.txt:
* platform/qt/fast/canvas/image-pattern-rotate-expected.txt:
* platform/qt/fast/canvas/shadow-offset-1-expected.txt:
* platform/qt/fast/canvas/shadow-offset-2-expected.txt:
* platform/qt/fast/canvas/shadow-offset-3-expected.txt:
* platform/qt/fast/canvas/shadow-offset-4-expected.txt:
* platform/qt/fast/canvas/shadow-offset-5-expected.txt:
* platform/qt/fast/canvas/shadow-offset-6-expected.txt:
* platform/qt/fast/canvas/shadow-offset-7-expected.txt:
* platform/qt/fast/css/attribute-selector-dynamic-expected.txt:
* platform/qt/fast/css/font-smoothing-expected.txt:
* platform/qt/fast/css/getComputedStyle/marginComputedStyle-expected.txt:
* platform/qt/fast/css/nested-floating-relative-position-percentages-expected.txt:
* platform/qt/fast/css/nth-child-dynamic-expected.txt:
* platform/qt/fast/css/pseudo-cache-stale-expected.txt:
* platform/qt/fast/css/rem-dynamic-scaling-expected.txt:
* platform/qt/fast/css/rem-units-on-root-expected.txt:
* platform/qt/fast/css/text-input-with-webkit-border-radius-expected.txt:
* platform/qt/fast/css/text-rendering-expected.txt:
* platform/qt/fast/doctypes/001-expected.txt:
* platform/qt/fast/doctypes/002-expected.txt:
* platform/qt/fast/doctypes/004-expected.txt:
* platform/qt/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.txt:
* platform/qt/fast/dynamic/anchor-lock-expected.txt:
* platform/qt/fast/dynamic/genContentDestroyChildren-expected.txt:
* platform/qt/fast/dynamic/window-resize-scrollbars-test-expected.txt:
* platform/qt/fast/dynamic/window-scrollbars-test-expected.txt:
* platform/qt/fast/forms/basic-buttons-expected.txt:
* platform/qt/fast/forms/basic-inputs-expected.txt:
* platform/qt/fast/forms/button-style-color-expected.txt:
* platform/qt/fast/forms/isindex-placeholder-expected.txt:
* platform/qt/fast/forms/menulist-style-color-expected.txt:
* platform/qt/fast/forms/search-vertical-alignment-expected.txt:
* platform/qt/fast/forms/text-style-color-expected.txt:
* platform/qt/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
* platform/qt/fast/forms/textarea-placeholder-set-attribute-expected.txt:
* platform/qt/fast/forms/textarea-placeholder-set-value-expected.txt:
* platform/qt/fast/frames/frame-navigation-expected.txt:
* platform/qt/fast/frames/frame-scrolling-attribute-expected.txt:
* platform/qt/fast/frames/frameset-style-recalc-expected.txt:
* platform/qt/fast/frames/iframe-scrolling-attribute-expected.txt:
* platform/qt/fast/frames/viewsource-on-image-file-expected.txt:
* platform/qt/fast/gradients/crash-on-zero-radius-expected.txt:
* platform/qt/fast/history/clicked-link-is-visited-expected.txt:
* platform/qt/fast/images/animated-gif-with-offsets-expected.txt:
* platform/qt/fast/images/image-in-map-expected.txt:
* platform/qt/fast/images/svg-as-background-expected.txt:
* platform/qt/fast/images/svg-width-100p-as-background-expected.txt:
* platform/qt/fast/lists/ol-start-parsing-expected.txt:
* platform/qt/fast/multicol/positioned-with-constrained-height-expected.txt:
* platform/qt/fast/overflow/overflow-with-local-background-attachment-expected.txt:
* platform/qt/fast/overflow/position-fixed-transform-clipping-expected.txt:
* platform/qt/fast/reflections/abs-position-in-reflection-expected.txt:
* platform/qt/fast/reflections/transparent-reflected-sublayers-expected.txt:
* platform/qt/fast/repaint/line-in-scrolled-clipped-block-expected.txt:
* platform/qt/fast/repaint/rel-positioned-inline-with-overflow-expected.txt:
* platform/qt/fast/table/fixed-table-with-percent-inside-percent-table-expected.txt:
* platform/qt/fast/table/fixed-table-with-percent-width-inside-auto-table-expected.txt:
* platform/qt/fast/table/fixed-table-with-percent-width-inside-div-expected.txt:
* platform/qt/fast/table/fixed-table-with-percent-width-inside-extra-large-div-expected.txt:
* platform/qt/fast/table/fixed-table-with-percent-width-inside-fixed-width-table-expected.txt:
* platform/qt/fast/table/fixed-table-with-small-percent-width-expected.txt:
* platform/qt/fast/text/international/hindi-whitespace-expected.txt:
* platform/qt/fast/text/international/khmer-selection-expected.txt:
* platform/qt/fast/text/shadow-translucent-fill-expected.txt:
* platform/qt/fast/text/text-letter-spacing-expected.txt:
* platform/qt/fast/transforms/bounding-rect-zoom-expected.txt:
* platform/qt/fast/xsl/document-function-expected.txt:
* platform/qt/plugins/netscape-dom-access-expected.txt:
* platform/qt/svg/custom/createImageElement2-expected.txt:
* platform/qt/svg/filters/feComposite-expected.txt:
* platform/qt/svg/filters/sourceAlpha-expected.txt:
* platform/qt/tables/mozilla/bugs/adforce_imgis_com-expected.txt:
* platform/qt/tables/mozilla/bugs/bug196870-expected.txt:
* platform/qt/tables/mozilla/bugs/bug56201-expected.txt:
* platform/qt/tables/mozilla/bugs/bug92647-2-expected.txt:
* platform/qt/tables/mozilla/other/slashlogo-expected.txt:
* platform/qt/tables/mozilla_expected_failures/bugs/bug23847-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50878
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 12 Nov 2009 14:05:59 +0000 (14:05 +0000)]
2009-11-12 Richard Moe Gustavsen <richard.gustavsen@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Disable pthread_setname_np.
This allows Qt builds on Mac from 10.6 to run on earlier version
where this symbol is not present.
https://bugs.webkit.org/show_bug.cgi?id=31403
* wtf/Platform.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50877
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 12 Nov 2009 13:52:50 +0000 (13:52 +0000)]
2009-11-12 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Custom printing shrink factors
https://bugs.webkit.org/show_bug.cgi?id=29042
This reverts commit r49769. The public API for this needs to be reviewed
before its inclusion in Qt.
* page/PrintContext.cpp:
(WebCore::PrintContext::begin):
* page/Settings.cpp:
(WebCore::Settings::Settings):
* page/Settings.h:
2009-11-12 Benjamin Poulain <benjamin.poulain@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Custom printing shrink factors
https://bugs.webkit.org/show_bug.cgi?id=29042
This reverts commit r49769. The public API for this needs to be reviewed
before its inclusion in Qt.
* Api/qwebsettings.cpp:
(QWebSettingsPrivate::apply):
(QWebSettings::QWebSettings):
* Api/qwebsettings.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50876
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 12 Nov 2009 13:28:20 +0000 (13:28 +0000)]
2009-11-12 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Resource errors/warnings not shown in the Resource tree.
Error/Warning bubbles are not displayed next to the resource in the
Resources panel if those occur before the resource is attached to the tree.
https://bugs.webkit.org/show_bug.cgi?id=31404
Test: manual-tests/inspector/styled-error-bubbles-in-scripts.html
* inspector/front-end/AbstractTimelinePanel.js:
(WebInspector.AbstractTimelinePanel.prototype.removeItem):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourceSidebarTreeElement.prototype.onattach):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50875
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 12 Nov 2009 12:44:56 +0000 (12:44 +0000)]
2009-11-12 Thiago Macieira <thiago.macieira@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Fix linking on Linux 32-bit.
It was missing the ".text" directive at the top of the file,
indicating that code would follow. Without it, the assembler created
"NOTYPE" symbols, which would result in linker errors.
https://bugs.webkit.org/show_bug.cgi?id=30863
* jit/JITStubs.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50874
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 12 Nov 2009 10:39:57 +0000 (10:39 +0000)]
2009-11-12 Philippe Normand <pnormand@igalia.com>
Reviewed by Jan Alonzo.
https://bugs.webkit.org/show_bug.cgi?id=31047
[GTK] Failing test media/video-played-ranges-1.html
Follow-up of r50726, don't block the UI thread when calling
gst_element_get_state(). Also fixed a compilation warning and some
static casts.
* platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
(WebCore::playbackPosition):
(WebCore::MediaPlayerPrivate::seek):
(WebCore::MediaPlayerPrivate::setRate):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50873
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 12 Nov 2009 10:32:22 +0000 (10:32 +0000)]
2009-11-12 Philippe Normand <pnormand@igalia.com>
Reviewed by Jan Alonzo.
https://bugs.webkit.org/show_bug.cgi?id=31047
[GTK] Failing test media/video-played-ranges-1.html
don't pause pipeline if already paused, same for play()
* platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivate::play):
(WebCore::MediaPlayerPrivate::pause):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50872
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 12 Nov 2009 09:03:32 +0000 (09:03 +0000)]
2009-11-12 Kinuko Yasuda <kinuko@google.com>
Reviewed by David Levin.
Support Gtk scrollwheel behavior for horizontal scrollbars on Linux
Chromium too.
https://bugs.webkit.org/show_bug.cgi?id=31292
No new tests. (Corresponding test for Gtk+ is
platform/gtk/scrollbars/overflow-scrollbar-horizontal-wheel-scroll.html)
* page/EventHandler.cpp:
* page/chromium/EventHandlerChromium.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50871
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hamaji@chromium.org [Thu, 12 Nov 2009 08:37:42 +0000 (08:37 +0000)]
2009-11-12 Shinichiro Hamaji <hamaji@chromium.org>
Unreviewed test fix by skipping a new test introduced in
https://bugs.webkit.org/show_bug.cgi?id=22249
* platform/gtk/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50870
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hamaji@chromium.org [Thu, 12 Nov 2009 08:15:48 +0000 (08:15 +0000)]
2009-11-12 Yuta Kitamura <yutak@chromium.org>
Reviewed by Eric Seidel.
Prevent text inside a multi-column block from being split into columns.
If the tentative height of a multi-column block was too small, we need to
expand the block height and try to layout again, in order to prevent text
from being split into different columns.
CSS Multicolumn text is split awkwardly
https://bugs.webkit.org/show_bug.cgi?id=22249
* fast/multicol/single-line.html: Added.
* fast/multicol/single-line-expected.checksum: Added.
* fast/multicol/single-line-expected.png: Added.
* fast/multicol/single-line-expected.txt: Added.
2009-11-12 Yuta Kitamura <yutak@chromium.org>
Reviewed by Eric Seidel.
Prevent text inside a multi-column block from being split into columns.
If the tentative height of a multi-column block was too small, we need to
expand the block height and try to layout again, in order to prevent text
from being split into different columns.
CSS Multicolumn text is split awkwardly
https://bugs.webkit.org/show_bug.cgi?id=22249
Test: fast/multicol/single-line.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutColumns):
* rendering/RenderBlock.h:
* rendering/RenderLineBoxList.cpp:
(WebCore::RenderLineBoxList::paint):
* rendering/RenderView.h:
(WebCore::RenderView::setTruncatedAt):
(WebCore::RenderView::setMinimumColumnHeight):
(WebCore::RenderView::minimumColumnHeight):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50869
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Thu, 12 Nov 2009 06:43:52 +0000 (06:43 +0000)]
2009-11-11 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
A test for a bug that RenderFileUploadControl isn't initialized with
multiple files. This test is skipped on ports which have no
eventSender.beginDragWithFiles().
https://bugs.webkit.org/show_bug.cgi?id=31195
* fast/forms/input-file-re-render.html: Added.
* platform/gtk/Skipped:
* platform/mac/fast/forms/input-file-re-render-expected.checksum: Added.
* platform/mac/fast/forms/input-file-re-render-expected.png: Added.
* platform/mac/fast/forms/input-file-re-render-expected.txt: Added.
* platform/qt/Skipped:
* platform/win/Skipped:
2009-11-11 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Fix a bug that RenderFileUploadControl isn't initialized with multiple files.
https://bugs.webkit.org/show_bug.cgi?id=31195
Test: fast/forms/input-file-re-render.html
* rendering/RenderFileUploadControl.cpp:
(WebCore::RenderFileUploadControl::RenderFileUploadControl):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50868
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dumi@chromium.org [Thu, 12 Nov 2009 05:58:28 +0000 (05:58 +0000)]
Fixing Chromium's POSIX VFS implementation, by adding the required
"used file descriptors" logic.
Reviewed by Dimitri Glazkov.
https://bugs.webkit.org/show_bug.cgi?id=31275
* platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50867
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dbates@webkit.org [Thu, 12 Nov 2009 05:46:22 +0000 (05:46 +0000)]
2009-11-11 Daniel Bates <dbates@webkit.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=31326
Makes the output for test fast/events/drag-and-drop.html pretty.
Now, it is easier to read for a human to read understand the results.
* fast/events/drag-and-drop-expected.txt: Rebased result.
* fast/events/drag-and-drop.html: Modified to make the output pretty.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@50866
268f45cc-cd09-0410-ab3c-
d52691b4dbfc