darin [Mon, 19 Dec 2005 19:51:09 +0000 (19:51 +0000)]
Reviewed by Geoff Garen and Eric Seidel.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=4923
stop using <ostream> in WebCore, eliminating the <cmath> troubles it causes
* kxmlcore/AlwaysInline.h: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12225
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Fri, 16 Dec 2005 08:04:58 +0000 (08:04 +0000)]
Reviewed by Maciej.
* JSRun.cpp: (JSRun::Evaluate): Updated for change to Interpreter::evaluate.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12224
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Thu, 15 Dec 2005 20:10:43 +0000 (20:10 +0000)]
Reviewed by Tim Hatcher.
* JavaScriptGlue.xcodeproj/project.pbxproj: Removed some redundant build
settings, turned off prebinding explicitly for our Development and
Deployment builds, remove .exp file from sources. All "clean-up".
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12223
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Wed, 14 Dec 2005 01:12:32 +0000 (01:12 +0000)]
Adding release markers.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12222
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Wed, 14 Dec 2005 01:00:12 +0000 (01:00 +0000)]
- Fixed build after Anders's last checkin to JavaScriptCore.
Reviewed by darin.
* UserObjectImp.cpp:
(UserObjectImp::userObjectGetter): Updated to reflect new argument that
getters take (unused here).
* UserObjectImp.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12221
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Tue, 13 Dec 2005 11:04:16 +0000 (11:04 +0000)]
Reviewed by Eric.
- added forwarding header for HashCountedSet
* kxmlcore/HashCountedSet.h: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12220
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Sun, 11 Dec 2005 02:03:35 +0000 (02:03 +0000)]
Rubber stamped by Maciej.
- updated for KJS class renaming
* many files and functions
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12219
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Sun, 11 Dec 2005 00:35:59 +0000 (00:35 +0000)]
Reviewed by Maciej.
- eliminated the old Undefined(), Null(), Boolean(), Number(), and String()
Code now uses jsUndefined(), jsNull(), jsBoolean(), jsNumber(), and jsString().
* JSUtils.cpp:
(JSObjectKJSValue):
* UserObjectImp.cpp:
(UserObjectImp::callAsFunction):
(UserObjectImp::toPrimitive):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12218
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Tue, 6 Dec 2005 02:35:54 +0000 (02:35 +0000)]
- added new forwarding headers
* kxmlcore/PassRefPtr.h: Added.
* kxmlcore/RefPtr.h: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12217
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Sun, 27 Nov 2005 03:10:03 +0000 (03:10 +0000)]
Rubber stamped by Eric.
- renamed InterpreterLock to JSLock
* JSUtils.cpp:
(CFStringToUString):
(JSObjectKJSValue):
(KJSValueToCFTypeInternal):
* JSValueWrapper.cpp:
(JSValueWrapper::JSObjectCopyPropertyNames):
(JSValueWrapper::JSObjectCopyProperty):
(JSValueWrapper::JSObjectSetProperty):
(JSValueWrapper::JSObjectCallFunction):
(JSValueWrapper::JSObjectCopyCFValue):
* JavaScriptGlue.cpp:
(JSRunCreate):
(JSCollect):
(JSLockInterpreter):
(JSUnlockInterpreter):
* UserObjectImp.cpp:
(UserObjectImp::callAsFunction):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12216
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Wed, 23 Nov 2005 05:40:07 +0000 (05:40 +0000)]
Reviewed by Geoff.
Updated to use new API to drop all locks.
* JavaScriptGlue.cpp:
(JSLockInterpreter):
(JSUnlockInterpreter):
* UserObjectImp.cpp:
(UserObjectImp::callAsFunction):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12215
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Wed, 16 Nov 2005 01:45:19 +0000 (01:45 +0000)]
Reviewed by mjs.
- Part of the fix for <rdar://problem/
4342216> Installer crash in
KJS::ValueImp::marked() when garbage collector runs inside call to
ConstantValues::init()
Added locking in JSRunCreate, since JSRun::JSRun constructs an object.
* JavaScriptGlue.cpp:
(JSRunCreate):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12214
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Fri, 11 Nov 2005 05:15:02 +0000 (05:15 +0000)]
Reviewed by Maciej.
- Fixed <rdar://problem/
4334445> installer crashed on my
dual g4 450Mhz after clicking language
- Reversed backwards NULL check.
- Inserted guards against NULL fJSUserObject data member.
- Cleaned up some style.
* JSUtils.cpp:
(KJSValueToCFTypeInternal):
* UserObjectImp.cpp:
(UserObjectImp::~UserObjectImp):
(UserObjectImp::callAsFunction):
(UserObjectImp::userObjectGetter):
(UserObjectImp::getOwnPropertySlot):
(UserObjectImp::put):
(UserObjectImp::mark):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12212
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Fri, 4 Nov 2005 17:02:05 +0000 (17:02 +0000)]
Reviewed by Darin.
* JavaScriptGlue.xcodeproj/project.pbxproj:
Fixed the FRAMEWORK_SEARCH_PATHS to look in the WebKit
Frameworks for the Default config.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12211
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Fri, 4 Nov 2005 01:36:35 +0000 (01:36 +0000)]
Tools:
Reviewed by Darin and Vicki.
* Scripts/build-root: now builds in a sandbox and wont replace your system WebKit or Safari
will now also build JavaScriptGlue and WebKitSystemInterface
JavaScriptGlue:
Reviewed by Darin and Vicki.
* JavaScriptGlue.xcodeproj/project.pbxproj:
Change to use $(SYSTEM_LIBRARY_DIR) consistently and place
$(NEXT_ROOT) in a few spots to make build-root work.
WebBrowser:
Reviewed by Darin and Vicki.
* WebBrowser.xcodeproj/project.pbxproj:
Change to use $(SYSTEM_LIBRARY_DIR) consistently and place
$(NEXT_ROOT) in a few spots to make build-root work.
WebKitSystemInterface:
Reviewed by Darin and Vicki.
* WebKitSystemInterface.xcodeproj/project.pbxproj:
Change to use $(SYSTEM_LIBRARY_DIR) consistently and place
$(NEXT_ROOT) in a few spots to make build-root work.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12210
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Wed, 2 Nov 2005 00:53:05 +0000 (00:53 +0000)]
top level:
Reviewed by: Eric.
<rdar://problem/
4324107> get JavaScriptGlue working with TOT JavaScriptCore again
* Makefile.am: re-enable JavaScriptGlue in the build
JavaScriptGlue:
Reviewed by: Eric.
<rdar://problem/
4324107> get JavaScriptGlue working with TOT JavaScriptCore again
- reverted all this stuff to use ReferenceList instead of IdentifierSequencedSet
* JSUtils.cpp:
(KJSValueToCFTypeInternal):
* JSValueWrapper.cpp:
(JSValueWrapper::JSObjectCopyPropertyNames):
* UserObjectImp.cpp:
(UserObjectImp::propList):
* UserObjectImp.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12209
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Wed, 12 Oct 2005 20:28:43 +0000 (20:28 +0000)]
Setup the proper Framework search path for the Default config.
Prepping for a TOT submission and build by B&I.
* JavaScriptGlue.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12208
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Mon, 10 Oct 2005 23:32:34 +0000 (23:32 +0000)]
Reviewed by Eric.
- converted tabs to spaces, NULL to 0, added some (void), got rid of __ prefixes
in headers (reserved for compiler/library)
* Info.plist:
* JSBase.cpp:
* JSBase.h:
* JSObject.cpp:
* JSObject.h:
* JSRun.cpp:
* JSRun.h:
* JSUtils.cpp:
* JSUtils.h:
* JSValueWrapper.cpp:
* JSValueWrapper.h:
* JavaScriptGlue.cpp:
* JavaScriptGlue.h:
* UserObjectImp.cpp:
* UserObjectImp.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12206
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Mon, 10 Oct 2005 18:54:37 +0000 (18:54 +0000)]
* .cvsignore: Added. Ignore Makefile.in and Makefile.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12205
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Sat, 8 Oct 2005 00:18:43 +0000 (00:18 +0000)]
Reviewed by Maciej.
Build fix, needed to disable RTTI. Upgraded to a native target.
* JavaScriptGlue.xcodeproj/project.pbxproj:
* Info.plist
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12204
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Fri, 7 Oct 2005 04:22:50 +0000 (04:22 +0000)]
top level:
Reviewed by Eric and Darin.
<rdar://problem/
4260506> Port JavaScriptGlue to TOT JavaScriptCore
* Makefile.am:
* configure.in:
JavaScriptGlue:
Reviewed by Eric and Darin.
<rdar://problem/
4260506> Port JavaScriptGlue to TOT JavaScriptCore
* JSRun.cpp:
(JSRun::JSRun):
(JSRun::GlobalObject):
* JSRun.h:
(JSInterpreter::JSInterpreter):
* JSUtils.cpp:
(KJSValueToJSObject):
(JSObjectKJSValue):
(KJSValueToCFTypeInternal):
(KJSValueToCFType):
* JSUtils.h:
* JSValueWrapper.cpp:
(JSValueWrapper::JSValueWrapper):
(JSValueWrapper::GetValue):
(JSValueWrapper::JSObjectCopyPropertyNames):
(JSValueWrapper::JSObjectCopyProperty):
(JSValueWrapper::JSObjectSetProperty):
(JSValueWrapper::JSObjectCallFunction):
(JSValueWrapper::JSObjectMark):
* JSValueWrapper.h:
* JavaScriptGlue.cpp:
(JSRunCopyGlobalObject):
* JavaScriptGlue.xcodeproj/project.pbxproj:
* Makefile.am: Added.
* UserObjectImp.cpp:
(UserObjectPrototypeImp::GlobalUserObjectPrototypeImp):
(UserObjectImp::UserObjectImp):
(UserObjectImp::callAsFunction):
(UserObjectImp::getPropertyNames):
(UserObjectImp::userObjectGetter):
(UserObjectImp::getOwnPropertySlot):
(UserObjectImp::put):
(UserObjectImp::toPrimitive):
(UserObjectImp::mark):
* UserObjectImp.h:
* kxmlcore/FastMalloc.h: Added.
* kxmlcore/HashSet.h: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12203
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Thu, 6 Oct 2005 04:36:04 +0000 (04:36 +0000)]
Forgot to commit this to TOT way back when; will be useful when actually porting JSGlue.
Reviewed by Geoff.
- fixed <rdar://problem/
4214783> REGRESSION: kjs_fast_malloc crash due to lack of locking on multiple threads (seen selecting volumes in the installer)
Make sure to lock using the InterpreterLock class in all places that need it
(including anything that uses the collector, the parser, the protect count hash table,
and anything that allocates via fast_malloc).
* JSUtils.cpp:
(CFStringToUString):
(JSObjectKJSValue):
(KJSValueToCFTypeInternal):
* JSUtils.h:
* JSValueWrapper.cpp:
(JSValueWrapper::JSObjectCopyPropertyNames):
(JSValueWrapper::JSObjectCopyProperty):
(JSValueWrapper::JSObjectSetProperty):
(JSValueWrapper::JSObjectCallFunction):
(JSValueWrapper::JSObjectCopyCFValue):
* JavaScriptGlue.cpp:
(JSCollect):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12202
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Wed, 28 Sep 2005 01:48:47 +0000 (01:48 +0000)]
Reviewed by Maciej.
<rdar://problem/
4223297> JavaScriptGlue: Submit 64-bit compatible versions of your API and SPIs by September 15
* JavaScriptGlue.h: Changed UInt32 to CFTypeID for JSTypeID
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12200
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Wed, 7 Sep 2005 01:21:47 +0000 (01:21 +0000)]
-upgraded project files to XCode 2.1
* JavaScriptGlue.pbproj/project.pbxproj: Removed.
* JavaScriptGlue.xcodeproj/.cvsignore: Added.
* JavaScriptGlue.xcodeproj/project.pbxproj: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12194
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Tue, 6 Sep 2005 08:10:03 +0000 (08:10 +0000)]
Rubber stamped by hyatt.
- initial import of JavaScriptGlue into our repository
* English.lproj/InfoPlist.strings: Added.
* JSBase.cpp: Added.
(JSBase::JSBase):
(JSBase::~JSBase):
(JSBase::Retain):
(JSBase::Release):
(JSBase::RetainCount):
(JSBase::GetTypeID):
(JSBase::CopyDescription):
(JSBase::Equal):
* JSBase.h: Added.
* JSObject.cpp: Added.
(JSUserObject::JSUserObject):
(JSUserObject::~JSUserObject):
(JSUserObject::CopyPropertyNames):
(JSUserObject::CopyProperty):
(JSUserObject::SetProperty):
(JSUserObject::ImplementsCall):
(JSUserObject::CallFunction):
(JSUserObject::CopyCFValue):
(JSUserObject::Equal):
(JSUserObject::Mark):
(JSUserObject::GetData):
* JSObject.h: Added.
(JSUserObject::DataType):
* JSRun.cpp: Added.
(JSRun::JSRun):
(JSRun::~JSRun):
(JSRun::Flags):
(JSRun::GetSource):
(JSRun::GlobalObject):
(JSRun::GetInterpreter):
(JSRun::Evaluate):
(JSRun::CheckSyntax):
* JSRun.h: Added.
(JSInterpreter::JSInterpreter):
(JSInterpreter::JSInterpreter::~JSInterpreter):
(JSInterpreter::Flags):
* JSUtils.cpp: Added.
(CFStringToUString):
(UStringToCFString):
(CFStringToIdentifier):
(IdentifierToCFString):
(KJSValueToJSObject):
(JSObjectKJSValue):
(KJSValueToCFTypeInternal):
(KJSValueToCFType):
(GetCFNull):
* JSUtils.h: Added.
(RetainCFType):
(ReleaseCFType):
* JSValueWrapper.cpp: Added.
(JSValueWrapper::JSValueWrapper):
(JSValueWrapper::~JSValueWrapper):
(JSValueWrapper::GetValue):
(JSValueWrapper::GetExecState):
(JSValueWrapper::GetJSObectCallBacks):
(JSValueWrapper::JSObjectDispose):
(JSValueWrapper::JSObjectCopyPropertyNames):
(JSValueWrapper::JSObjectCopyProperty):
(JSValueWrapper::JSObjectSetProperty):
(JSValueWrapper::JSObjectCallFunction):
(JSValueWrapper::JSObjectCopyCFValue):
(JSValueWrapper::JSObjectMark):
* JSValueWrapper.h: Added.
* JavaScriptGlue.cpp: Added.
(JSSetCFNull):
(JSGetCFNull):
(JSRetain):
(JSRelease):
(JSCopyDescription):
(JSEqual):
(JSGetTypeID):
(JSGetRetainCount):
(JSObjectCreate):
(JSObjectCreateInternal):
(JSObjectCopyCFValue):
(JSObjectGetData):
(JSObjectCopyProperty):
(JSObjectSetProperty):
(JSObjectCallFunction):
(JSRunCreate):
(JSRunCopySource):
(JSRunCopyGlobalObject):
(JSRunEvaluate):
(JSRunCheckSyntax):
(JSCollect):
(JSTypeGetCFArrayCallBacks):
(JSCFRetain):
(JSCFRelease):
(JSObjectCreateWithCFType):
(CFJSObjectDispose):
(JSObjectCopyPropertyNames):
(CFJSObjectCopyProperty):
(CFJSObjectSetProperty):
(CFJSObjectCopyCFValue):
(CFJSObjectEqual):
(CFJSObjectCopyPropertyNames):
(JSCreateCFArrayFromJSArray):
(JSCreateJSArrayFromCFArray):
(JSLockInterpreter):
(JSUnlockInterpreter):
* JavaScriptGlue.exp: Added.
* JavaScriptGlue.h: Added.
* JavaScriptGlue.pbproj/project.pbxproj: Added.
* UserObjectImp.cpp: Added.
(UserObjectPrototypeImp::UserObjectPrototypeImp):
(UserObjectPrototypeImp::GlobalUserObjectPrototypeImp):
(UserObjectImp::UserObjectImp):
(UserObjectImp::~UserObjectImp):
(UserObjectImp::classInfo):
(UserObjectImp::implementsCall):
(UserObjectImp::call):
(UserObjectImp::propList):
(UserObjectImp::hasProperty):
(UserObjectImp::get):
(UserObjectImp::put):
(UserObjectImp::GetJSUserObject):
(UserObjectImp::toPrimitive):
(UserObjectImp::toBoolean):
(UserObjectImp::toNumber):
(UserObjectImp::toString):
(UserObjectImp::mark):
* UserObjectImp.h: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12191
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Thu, 19 Jan 2006 00:59:35 +0000 (00:59 +0000)]
It's called pure virtual for a reason. (Fingers crossed.)
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12184
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Thu, 19 Jan 2006 00:51:18 +0000 (00:51 +0000)]
Umm. Yeah. Let's try making BrowserExtensionMac actually declare and use a class called BrowserExtensionMac.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12183
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Thu, 19 Jan 2006 00:43:27 +0000 (00:43 +0000)]
Remove KParts using from WebCoreFrameBridge.mm (yes, more bustage).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12182
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Thu, 19 Jan 2006 00:39:28 +0000 (00:39 +0000)]
Make sure FrameView includes MacFrame.h on mac only.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12181
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Thu, 19 Jan 2006 00:30:54 +0000 (00:30 +0000)]
More Mac build bustage. Fix the dashboard region call to still cast to MacFrame.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12180
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Thu, 19 Jan 2006 00:15:35 +0000 (00:15 +0000)]
OMG I BROKE THE MAC. (Fixed)
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12179
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Wed, 18 Jan 2006 23:59:23 +0000 (23:59 +0000)]
Eliminate uses of MacFrame in cross-platform code.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12178
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Wed, 18 Jan 2006 21:14:52 +0000 (21:14 +0000)]
Make the signals/stubs/slots compile on Win32 by removing #imports.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12177
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Wed, 18 Jan 2006 21:12:23 +0000 (21:12 +0000)]
Reviewed by Hyatt.
- change KWQList to use qsort instead of CFArraySort
* kwq/KWQListImpl.cpp:
(compareFuncWrapper): Wrapper that uses global variables to overcome the lack
of a "data" pointer in qsort. Could have used qsort_r but that would be less portable.
(KWQListImpl::sort): Use qsort instead of CFArraySortValues.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12176
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Wed, 18 Jan 2006 20:19:11 +0000 (20:19 +0000)]
Reviewed by Beth.
- changed the three signal/slot related files from ObjC++ to C++ files
* WebCore.xcodeproj/project.pbxproj:
* kwq/KWQSignal.cpp: Added.
* kwq/KWQSignal.mm: Removed.
* kwq/KWQSignalStubs.cpp: Added.
* kwq/KWQSignalStubs.mm: Removed.
* kwq/KWQSlot.cpp: Added.
* kwq/KWQSlot.mm: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12175
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Wed, 18 Jan 2006 19:48:38 +0000 (19:48 +0000)]
Add KWQListImpl.cpp to Win32 but ifdef out all the LAME LAME LAME CF dependencies.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12174
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Wed, 18 Jan 2006 19:31:59 +0000 (19:31 +0000)]
Make testkjs.exe compile without warnings.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12172
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Wed, 18 Jan 2006 19:31:12 +0000 (19:31 +0000)]
Make Win32 WebCore build again.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12171
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Wed, 18 Jan 2006 17:19:57 +0000 (17:19 +0000)]
LayoutTests:
Reviewed by Hyatt.
- test for http://bugzilla.opendarwin.org/show_bug.cgi?id=6618
Inline in RTL block with overflow:auto and left border makes scroll bar appear
* fast/overflow/overflow-rtl-inline-scrollbar-expected.checksum: Added.
* fast/overflow/overflow-rtl-inline-scrollbar-expected.png: Added.
* fast/overflow/overflow-rtl-inline-scrollbar-expected.txt: Added.
* fast/overflow/overflow-rtl-inline-scrollbar.html: Added.
WebCore:
Test: fast/overflow/overflow-rtl-inline-scrollbar.html
Reviewed by Hyatt.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6618
Inline in RTL block with overflow:auto and left border makes scroll bar appear
Inline flows were always returning 0 for leftmostPosition(). Their real leftmost
edges are determined by their inline boxes, which
RenderBlock::leftmostPosition already takes into account.
* khtml/rendering/render_flow.cpp:
(RenderFlow::lowestPosition): Don't descend into inline flows.
(RenderFlow::rightmostPosition): Ditto.
(RenderFlow::leftmostPosition): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12170
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Wed, 18 Jan 2006 16:51:31 +0000 (16:51 +0000)]
2006-01-18 Anders Carlsson <andersca@mac.com>
Fix build.
* khtml/ecma/kjs_navigator.cpp:
* page/FrameView.cpp:
Remove kstandarddirs.h includes.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12169
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Wed, 18 Jan 2006 08:57:47 +0000 (08:57 +0000)]
Fixed change log.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12168
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Wed, 18 Jan 2006 08:56:19 +0000 (08:56 +0000)]
Reviewed by Hyatt.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6646
compile CSS sources in instead of reading them from disk
* WebCore.vcproj/WebCore/WebCore.vcproj:
* WebCore.vcproj/WebCore/build-generated-files.sh:
* css/make-css-file-arrays.pl: Added. Used to generate C array forms of the ".css" files.
* css/UserAgentStyleSheets.cpp: Added. Used to indirectly compile the generated file.
* WebCore.xcodeproj/project.pbxproj: Added new source files. Added a build phase to
invoke the make-css-file-arrays.pl script. Removed the .css files, which no longer need
to be installed as part of the final package.
* css/cssstyleselector.cpp: (WebCore::parseUASheet): Removed code to read user agent
sheets from disk. Replaced with code that gets them from compiled-in arrays instead.
Uses a pretty lame DOMString hack that could be reworked some day.
(WebCore::CSSStyleSelector::loadDefaultStyle): Change to load from arrays intead of disk.
* css/html4.css: Added missing license header, tweaked format a bit.
* css/quirks.css: Added missing license header, tweaked format.
* css/svg.css: Moved from ksvg2/css directory.
* ksvg2/css/svg.css: Moved to top level css directory.
* page/Frame.cpp: Removed includes of qfile.h and kstandarddirs.h.
* ForwardingHeaders/kstandarddirs.h: Removed.
* ForwardingHeaders/qfile.h: Removed.
* kwq/KWQFile.h: Removed.
* kwq/KWQFile.mm: Removed.
* kwq/KWQKStandardDirs.h: Removed.
* kwq/KWQKStandardDirs.mm: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12167
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Wed, 18 Jan 2006 06:41:46 +0000 (06:41 +0000)]
Reviewed by Maciej.
- Remove the now-unused KRenderingPaintServerImage[Quartz].
* WebCore.xcodeproj/project.pbxproj:
* kcanvas/KCanvasTreeDebug.cpp:
* kcanvas/device/KRenderingPaintServer.h:
* kcanvas/device/KRenderingPaintServerImage.cpp: Removed.
* kcanvas/device/KRenderingPaintServerImage.h: Removed.
* kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
* kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
* kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
* ksvg2/svg/SVGFEImageElementImpl.cpp:
* kwq/KWQPainter.mm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12166
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Wed, 18 Jan 2006 06:16:57 +0000 (06:16 +0000)]
Reviewed by John Sullivan.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6377
<rdar://problem/
4400315> All XML crashes in TOT with JavaScript disabled (6377)
* bridge/mac/MacFrame.mm:
(MacFrame::bindingRootObject): Assert that this is only called when JavaScript is enabled.
(MacFrame::windowScriptObject): Return 0 if JavaScript is disabled.
(MacFrame::windowScriptNPObject): Ditto.
(MacFrame::partClearedInBegin): Don't call the "window script object available" call if
JavaScript is disabled.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12165
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Wed, 18 Jan 2006 05:55:15 +0000 (05:55 +0000)]
Reviewed by darin
Layout tests for:
<http://bugzilla.opendarwin.org/show_bug.cgi?id=6632>
REGRESSION: Selection includes spaces that it shouldn't
<rdar://problem/
4407845>
REGRESSION (TOT): blank space before found text selected at http://www.schepers.cc/comiclink
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12164
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Wed, 18 Jan 2006 05:53:15 +0000 (05:53 +0000)]
Reviewed by darin
<http://bugzilla.opendarwin.org/show_bug.cgi?id=6632>
REGRESSION: Selection includes spaces that it shouldn't
<rdar://problem/
4407845>
REGRESSION (TOT): blank space before found text selected at http://www.schepers.cc/comiclinks.html
Layout test added:
* editing/selection/after-line-wrap.html
* khtml/editing/visible_position.cpp:
(khtml::VisiblePosition::previous): Don't stop at the first candidate,
it may be visually equivalent to the original position.
* khtml/xml/dom_position.cpp:
(DOM::Position::upstream): Don't move to a position on a different line.
(DOM::Position::downstream): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12163
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Wed, 18 Jan 2006 04:33:55 +0000 (04:33 +0000)]
Reviewed by Anders.
- http://bugzilla.opendarwin.org/show_bug.cgi?id=6611
add assertions to check correct use of hash table iterators
* kxmlcore/HashTable.h:
(KXMLCore::addIterator): Added. Helper function that adds an iterator to the list
maintained by the specified hash table.
(KXMLCore::removeIterator): Added. Helper function that removes an iterator from
the list maintained by the hash table it's in.
(KXMLCore::HashTableConstIterator::HashTableConstIterator): Added a HashTable
parameter, ignored when not debugging. Call addIterator.
(KXMLCore::HashTableConstIterator::~HashTableConstIterator):
(KXMLCore::HashTableConstIterator::operator=): Call removeIterator.
(KXMLCore::HashTableConstIterator::operator*): Call checkValidity.
(KXMLCore::HashTableConstIterator::operator->): Ditto.
(KXMLCore::HashTableConstIterator::operator++): Ditto.
(KXMLCore::HashTableConstIterator::operator==): Ditto.
(KXMLCore::HashTableConstIterator::operator!=): Ditto.
(KXMLCore::HashTableConstIterator::checkValidity): Checks that the hash table
pointer is not 0 and if there are two iterators that both point at the same table.
(KXMLCore::HashTableIterator::HashTableIterator): Changed to use the const iterator
as an implementation detail, to avoid having two separate iterator implementations.
(KXMLCore::HashTableIterator::operator*): Ditto.
(KXMLCore::HashTableIterator::operator->): Ditto.
(KXMLCore::HashTableIterator::operator++): Ditto.
(KXMLCore::HashTableIterator::operator==): Ditto.
(KXMLCore::HashTableIterator::operator!=): Ditto.
(KXMLCore::HashTable::HashTable): Initialize pointer to head of iterators list.
(KXMLCore::HashTable::~HashTable): Added call to invalidateIterators.
(KXMLCore::HashTable::makeIterator): Pass this pointer.
(KXMLCore::HashTable::makeConstIterator): Ditto.
(KXMLCore::HashTable::insert): Call invalidateIterators, since this is a public
entry point that modifies the hash table.
(KXMLCore::HashTable::remove): Ditto.
(KXMLCore::HashTable::clear): Ditto.
(KXMLCore::HashTable::swap): Ditto.
(KXMLCore::HashTable::invalidateIterators): Added. Walks the iterators list and
clears out the table, next, and previous pointers in all of them, and then clears
the head so we have an empty list.
(KXMLCore::addIterator): Added. Adds the iterator the the linked list in the
passed-in table, and points the iterator at the table.
(KXMLCore::removeIterator): Added. Removes the iterator from the linked list in
the passed-in table.
* kxmlcore/HashTraits.h: A bit of tweaking and formatting.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12162
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Wed, 18 Jan 2006 04:16:26 +0000 (04:16 +0000)]
Deployment builds now use -O2
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12161
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin [Wed, 18 Jan 2006 01:33:53 +0000 (01:33 +0000)]
Reviewed by Darin.
Fix for <rdar://problem/
4112029> With Quartz scaling on, Safari incorrectly
handles mouseover effects
The location of an event in the window should be converted to the superview
of the contentView to do accurate hitTesting.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12160
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin [Wed, 18 Jan 2006 01:18:31 +0000 (01:18 +0000)]
Reviewed by Geoff.
Test for <rdar://problem/
4405836> REGRESSION: crash at
webmail.aol.com when deleting mail in
khtml::RenderTableCell::collapsedBottomBorder() const + 232
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12159
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Tue, 17 Jan 2006 23:56:12 +0000 (23:56 +0000)]
Moving the webkit.opendarwin.org site into our Subversion repository.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12158
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Tue, 17 Jan 2006 22:49:14 +0000 (22:49 +0000)]
Fix group path for rendering in project file.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12157
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Tue, 17 Jan 2006 22:46:54 +0000 (22:46 +0000)]
Fix build bustage caused by my partial commit.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12156
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Tue, 17 Jan 2006 21:07:37 +0000 (21:07 +0000)]
Move khtml/rendering to WebCore/rendering.
* WebCore.xcodeproj/project.pbxproj:
* khtml/rendering: Removed.
* khtml/rendering/DataRef.h: Removed.
* khtml/rendering/InlineTextBox.cpp: Removed.
* khtml/rendering/InlineTextBox.h: Removed.
* khtml/rendering/RenderText.cpp: Removed.
* khtml/rendering/RenderText.h: Removed.
* khtml/rendering/RenderTextFragment.cpp: Removed.
* khtml/rendering/RenderTextFragment.h: Removed.
* khtml/rendering/bidi.cpp: Removed.
* khtml/rendering/bidi.h: Removed.
* khtml/rendering/break_lines.cpp: Removed.
* khtml/rendering/break_lines.h: Removed.
* khtml/rendering/font.cpp: Removed.
* khtml/rendering/font.h: Removed.
* khtml/rendering/render_applet.cpp: Removed.
* khtml/rendering/render_applet.h: Removed.
* khtml/rendering/render_arena.cpp: Removed.
* khtml/rendering/render_arena.h: Removed.
* khtml/rendering/render_block.cpp: Removed.
* khtml/rendering/render_block.h: Removed.
* khtml/rendering/render_box.cpp: Removed.
* khtml/rendering/render_box.h: Removed.
* khtml/rendering/render_br.cpp: Removed.
* khtml/rendering/render_br.h: Removed.
* khtml/rendering/render_button.cpp: Removed.
* khtml/rendering/render_button.h: Removed.
* khtml/rendering/render_canvas.cpp: Removed.
* khtml/rendering/render_canvas.h: Removed.
* khtml/rendering/render_canvasimage.cpp: Removed.
* khtml/rendering/render_canvasimage.h: Removed.
* khtml/rendering/render_container.cpp: Removed.
* khtml/rendering/render_container.h: Removed.
* khtml/rendering/render_flexbox.cpp: Removed.
* khtml/rendering/render_flexbox.h: Removed.
* khtml/rendering/render_flow.cpp: Removed.
* khtml/rendering/render_flow.h: Removed.
* khtml/rendering/render_form.cpp: Removed.
* khtml/rendering/render_form.h: Removed.
* khtml/rendering/render_frames.cpp: Removed.
* khtml/rendering/render_frames.h: Removed.
* khtml/rendering/render_image.cpp: Removed.
* khtml/rendering/render_image.h: Removed.
* khtml/rendering/render_inline.cpp: Removed.
* khtml/rendering/render_inline.h: Removed.
* khtml/rendering/render_layer.cpp: Removed.
* khtml/rendering/render_layer.h: Removed.
* khtml/rendering/render_line.cpp: Removed.
* khtml/rendering/render_line.h: Removed.
* khtml/rendering/render_list.cpp: Removed.
* khtml/rendering/render_list.h: Removed.
* khtml/rendering/render_object.cpp: Removed.
* khtml/rendering/render_object.h: Removed.
* khtml/rendering/render_replaced.cpp: Removed.
* khtml/rendering/render_replaced.h: Removed.
* khtml/rendering/render_style.cpp: Removed.
* khtml/rendering/render_style.h: Removed.
* khtml/rendering/render_table.cpp: Removed.
* khtml/rendering/render_table.h: Removed.
* khtml/rendering/render_theme.cpp: Removed.
* khtml/rendering/render_theme.h: Removed.
* khtml/rendering/render_theme_mac.h: Removed.
* khtml/rendering/render_theme_mac.mm: Removed.
* khtml/rendering/table_layout.cpp: Removed.
* khtml/rendering/table_layout.h: Removed.
* rendering: Added.
* rendering/DataRef.h: Added.
* rendering/InlineTextBox.cpp: Added.
* rendering/InlineTextBox.h: Added.
* rendering/RenderText.cpp: Added.
* rendering/RenderText.h: Added.
* rendering/RenderTextFragment.cpp: Added.
* rendering/RenderTextFragment.h: Added.
* rendering/bidi.cpp: Added.
* rendering/bidi.h: Added.
* rendering/break_lines.cpp: Added.
* rendering/break_lines.h: Added.
* rendering/font.cpp: Added.
* rendering/font.h: Added.
* rendering/render_applet.cpp: Added.
* rendering/render_applet.h: Added.
* rendering/render_arena.cpp: Added.
* rendering/render_arena.h: Added.
* rendering/render_block.cpp: Added.
* rendering/render_block.h: Added.
* rendering/render_box.cpp: Added.
* rendering/render_box.h: Added.
* rendering/render_br.cpp: Added.
* rendering/render_br.h: Added.
* rendering/render_button.cpp: Added.
* rendering/render_button.h: Added.
* rendering/render_canvas.cpp: Added.
* rendering/render_canvas.h: Added.
* rendering/render_canvasimage.cpp: Added.
* rendering/render_canvasimage.h: Added.
* rendering/render_container.cpp: Added.
* rendering/render_container.h: Added.
* rendering/render_flexbox.cpp: Added.
* rendering/render_flexbox.h: Added.
* rendering/render_flow.cpp: Added.
* rendering/render_flow.h: Added.
* rendering/render_form.cpp: Added.
* rendering/render_form.h: Added.
* rendering/render_frames.cpp: Added.
* rendering/render_frames.h: Added.
* rendering/render_image.cpp: Added.
* rendering/render_image.h: Added.
* rendering/render_inline.cpp: Added.
* rendering/render_inline.h: Added.
* rendering/render_layer.cpp: Added.
* rendering/render_layer.h: Added.
* rendering/render_line.cpp: Added.
* rendering/render_line.h: Added.
* rendering/render_list.cpp: Added.
* rendering/render_list.h: Added.
* rendering/render_object.cpp: Added.
* rendering/render_object.h: Added.
* rendering/render_replaced.cpp: Added.
* rendering/render_replaced.h: Added.
* rendering/render_style.cpp: Added.
* rendering/render_style.h: Added.
* rendering/render_table.cpp: Added.
* rendering/render_table.h: Added.
* rendering/render_theme.cpp: Added.
* rendering/render_theme.h: Added.
* rendering/render_theme_mac.h: Added.
* rendering/render_theme_mac.mm: Added.
* rendering/table_layout.cpp: Added.
* rendering/table_layout.h: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12155
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Tue, 17 Jan 2006 20:52:42 +0000 (20:52 +0000)]
Land support for a style method on DOMAttr from JS that will
allow the Web Inspector to include presentational attributes
in the style list.
Reviewed by xenon
* khtml/ecma/kjs_dom.cpp:
(KJS::DOMAttr::getValueProperty):
* khtml/ecma/kjs_dom.h:
(KJS::DOMAttr::):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12154
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin [Tue, 17 Jan 2006 19:40:55 +0000 (19:40 +0000)]
Reviewed by Hyatt and Darin
Fix for <rdar://problem/
4405836> REGRESSION: crash at webmail.aol.com
when deleting mail in khtml::RenderTableCell::collapsedBottomBorder() const
+ 232
RenderTableCell::collapsedBottomBorder() gets nextCell by calling
table()->cellBelow(this). In the case of the crash, cellBelow() returns
a pointer to a table cell that was already destroyed. cellBelow() thinks
that the pointer is still good because the grid of cells has not been updated
because all of this code is called through the hitTest and the hitTest does
not update the layout. The fix that I have is simply it have the hitTest call
updateLayout(). This is the only change in behavior. The rest of the patch
preserves behavior for simulated clicks. fast/events/stopPropagation-submit
caught this problem that arose from calling updateLayout() in the hitTest;
we should always have an x and y position of 0 for simulated clicks. This
preserves that behavior by keeping track of whether a click is simulated or not.`
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12153
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Tue, 17 Jan 2006 18:14:53 +0000 (18:14 +0000)]
Patch by Duncan Wilcox, reviewed by Darin.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6609
Use Selection instead of SelectionController where possible
This patch replaces the use of SelectionController with Selection in the edit commands.
It also cleans up the relationship between Selection and SelectionController:
SelectionController used to need to be friend to Selection to call validate()
on it, now validation is enforced on every update of Selection.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12152
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Tue, 17 Jan 2006 17:35:59 +0000 (17:35 +0000)]
LayoutTests:
Reviewed by Darin.
- test for http://bugzilla.opendarwin.org/show_bug.cgi?id=5926
Assertion failure in HTMLGenericFormElementImpl::removedFromTree
* fast/dom/generic-form-element-assert.html: Added.
* fast/dom/generic-form-element-assert-expected.txt: Added.
WebCore:
Test: fast/dom/generic-form-element-assert.html
Reviewed and reworked by Darin.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5926
Assertion failure in HTMLGenericFormElementImpl::removedFromTree
* khtml/html/HTMLGenericFormElementImpl.cpp: Tweaked formatting and namespaces
a bit. Removed unneeded includes.
(WebCore::findRoot): Added helper function.
(WebCore::HTMLGenericFormElementImpl::removedFromTree): Rewrote to do the check
in a simpler way, since the two separate cases amounted to the same check.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12151
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Tue, 17 Jan 2006 17:29:19 +0000 (17:29 +0000)]
Updated copyright dates (oops, forgot).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12150
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Tue, 17 Jan 2006 17:28:35 +0000 (17:28 +0000)]
Reviewed by Anders.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6610
change RefPtr so that it works when deref ends up deleting the RefPtr
* kxmlcore/PassRefPtr.h: Always set m_ptr before calling deref.
* kxmlcore/RefPtr.h: Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12149
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Tue, 17 Jan 2006 09:00:14 +0000 (09:00 +0000)]
2006-01-17 Mark Rowe <opendarwin.org@bdash.net.nz>
Reviewed by eseidel.
Fix second part of WebCore-no-SVG fails to build.
http://bugzilla.opendarwin.org/show_bug.cgi?id=6607
* WebCore.xcodeproj/project.pbxproj:
Mark three headers as private rather than project in the WebCore-no-SVG target.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12148
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Tue, 17 Jan 2006 07:39:33 +0000 (07:39 +0000)]
Reviewed by hyatt
* kwq/KWQVectorImpl.cpp:
(KWQVectorImpl::append): Assign the new item to index m_count, not m_size.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12147
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Tue, 17 Jan 2006 06:53:35 +0000 (06:53 +0000)]
2006-01-17 Mark Rowe <opendarwin.org@bdash.net.nz>
Reviewed by eseidel.
WebCore-SVG fails to build.
http://bugzilla.opendarwin.org/show_bug.cgi?id=6607
* WebCore.xcodeproj/project.pbxproj:
Fix build of WebCore-no-SVG target. Removes SVG specific files and adds new
files omitted from the target.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12146
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Tue, 17 Jan 2006 06:50:20 +0000 (06:50 +0000)]
2006-01-16 Eric Seidel <eseidel@apple.com>
Fixed test case to remove invisible chars (thus fixing test).
* svg/custom/recursive-clippath.svg:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12145
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Tue, 17 Jan 2006 05:41:49 +0000 (05:41 +0000)]
(1) Fix build bustage by properly marking the moved Obj-C
bindings files as private.
(2) Move khtml/css to WebCore/css.
(3) Eliminate the kdom/css forwarding headers.
* ForwardingHeaders/kdom/css: Removed.
* ForwardingHeaders/kdom/css/CSSPrimitiveValueImpl.h: Removed.
* ForwardingHeaders/kdom/css/CSSStyleDeclarationImpl.h: Removed.
* ForwardingHeaders/kdom/css/CSSStyleRuleImpl.h: Removed.
* ForwardingHeaders/kdom/css/CSSStyleSelector.h: Removed.
* ForwardingHeaders/kdom/css/CSSStyleSheetImpl.h: Removed.
* ForwardingHeaders/kdom/css/CSSValueImpl.h: Removed.
* ForwardingHeaders/kdom/css/CSSValueListImpl.h: Removed.
* ForwardingHeaders/kdom/css/KDOMCSSParser.h: Removed.
* ForwardingHeaders/kdom/css/MediaListImpl.h: Removed.
* ForwardingHeaders/kdom/css/RGBColorImpl.h: Removed.
* ForwardingHeaders/kdom/css/RenderStyle.h: Removed.
* ForwardingHeaders/kdom/css/StyleSheetListImpl.h: Removed.
* WebCore+SVG/RGBColorImpl.cpp:
* WebCore.xcodeproj/project.pbxproj:
* css: Added.
* css/css_base.cpp: Added.
* css/css_base.h: Added.
* css/css_computedstyle.cpp: Added.
* css/css_computedstyle.h: Added.
* css/css_grammar.y: Added.
* css/css_ruleimpl.cpp: Added.
* css/css_ruleimpl.h: Added.
* css/css_stylesheetimpl.cpp: Added.
* css/css_stylesheetimpl.h: Added.
* css/css_valueimpl.cpp: Added.
* css/css_valueimpl.h: Added.
* css/csshelper.cpp: Added.
* css/csshelper.h: Added.
* css/cssparser.cpp: Added.
* css/cssparser.h: Added.
* css/cssproperties.in: Added.
* css/cssstyleselector.cpp: Added.
* css/cssstyleselector.h: Added.
* css/cssvalues.in: Added.
* css/html4.css: Added.
* css/makeprop: Added.
* css/maketokenizer: Added.
* css/makevalues: Added.
* css/quirks.css: Added.
* css/tokenizer.flex: Added.
* khtml/css: Removed.
* khtml/css/css_base.cpp: Removed.
* khtml/css/css_base.h: Removed.
* khtml/css/css_computedstyle.cpp: Removed.
* khtml/css/css_computedstyle.h: Removed.
* khtml/css/css_grammar.y: Removed.
* khtml/css/css_ruleimpl.cpp: Removed.
* khtml/css/css_ruleimpl.h: Removed.
* khtml/css/css_stylesheetimpl.cpp: Removed.
* khtml/css/css_stylesheetimpl.h: Removed.
* khtml/css/css_valueimpl.cpp: Removed.
* khtml/css/css_valueimpl.h: Removed.
* khtml/css/csshelper.cpp: Removed.
* khtml/css/csshelper.h: Removed.
* khtml/css/cssparser.cpp: Removed.
* khtml/css/cssparser.h: Removed.
* khtml/css/cssproperties.in: Removed.
* khtml/css/cssstyleselector.cpp: Removed.
* khtml/css/cssstyleselector.h: Removed.
* khtml/css/cssvalues.in: Removed.
* khtml/css/html4.css: Removed.
* khtml/css/makeprop: Removed.
* khtml/css/maketokenizer: Removed.
* khtml/css/makevalues: Removed.
* khtml/css/quirks.css: Removed.
* khtml/css/tokenizer.flex: Removed.
* ksvg2/css/SVGCSSStyleSelector.cpp:
* ksvg2/ecma/Ecma.cpp:
* ksvg2/misc/KCanvasRenderingStyle.cpp:
* ksvg2/misc/KCanvasRenderingStyle.h:
* ksvg2/svg/SVGAnimationElementImpl.cpp:
* ksvg2/svg/SVGClipPathElementImpl.cpp:
* ksvg2/svg/SVGColorImpl.cpp:
* ksvg2/svg/SVGColorImpl.h:
* ksvg2/svg/SVGDOMImplementationImpl.cpp:
* ksvg2/svg/SVGDocumentImpl.cpp:
* ksvg2/svg/SVGElementImpl.cpp:
* ksvg2/svg/SVGGradientElementImpl.cpp:
* ksvg2/svg/SVGMaskElementImpl.cpp:
* ksvg2/svg/SVGStyleElementImpl.cpp:
* ksvg2/svg/SVGStyledElementImpl.h:
* ksvg2/svg/SVGTextElementImpl.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12144
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Tue, 17 Jan 2006 05:41:32 +0000 (05:41 +0000)]
Rubber stamped by Maciej.
Check for a new "WebKitDeveloperExtras" default when
including the "Inspect Element" context menu item.
We should retire the other one eventually.
* WebView.subproj/WebView.m:
(-[WebView _menuForElement:defaultItems:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12143
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Tue, 17 Jan 2006 02:37:42 +0000 (02:37 +0000)]
2006-01-16 Eric Seidel <eseidel@apple.com>
Reviewed by beth.
A proactive test case to prevent crashes in recursive clippath defs
* svg/custom/recursive-clippath-expected.checksum: Added.
* svg/custom/recursive-clippath-expected.png: Added.
* svg/custom/recursive-clippath-expected.txt: Added.
* svg/custom/recursive-clippath.svg: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12142
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Tue, 17 Jan 2006 02:20:35 +0000 (02:20 +0000)]
JavaScriptCore:
Reviewed by darin.
- Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=6322
DateProtoFuncImp::callAsFunction can crash due to lack of type checking
* kjs/date_object.cpp:
(KJS::DateProtoFunc::callAsFunction): Type check calls to all methods.
This matches section 15.9.5 in the spec.
LayoutTests:
- Added layout test for
http://bugzilla.opendarwin.org/show_bug.cgi?id=6322
DateProtoFuncImp::callAsFunction can crash due to lack of type checking
* fast/js/date-proto-generic-invocation-expected.txt: Added.
* fast/js/date-proto-generic-invocation.html: Added.
* fast/js/resources/date-proto-generic-invocation.js: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12141
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Tue, 17 Jan 2006 00:35:38 +0000 (00:35 +0000)]
Move the Objective-C dom bindings from kwq to bindings/objc.
Reviewed by eseidel
* WebCore.xcodeproj/project.pbxproj:
* bindings: Added.
* bindings/js: Added.
* bindings/objc: Added.
* bindings/objc/DOM.h: Added.
* bindings/objc/DOM.mm: Added.
* bindings/objc/DOMCSS.h: Added.
* bindings/objc/DOMCSS.mm: Added.
* bindings/objc/DOMCore.h: Added.
* bindings/objc/DOMEvents.h: Added.
* bindings/objc/DOMEvents.mm: Added.
* bindings/objc/DOMEventsInternal.h: Added.
* bindings/objc/DOMExtensions.h: Added.
* bindings/objc/DOMHTML.h: Added.
* bindings/objc/DOMHTML.mm: Added.
* bindings/objc/DOMHTMLInternal.h: Added.
* bindings/objc/DOMInternal.h: Added.
* bindings/objc/DOMInternal.mm: Added.
* bindings/objc/DOMPrivate.h: Added.
* bindings/objc/DOMRange.h: Added.
* bindings/objc/DOMStylesheets.h: Added.
* bindings/objc/DOMTraversal.h: Added.
* bindings/objc/DOMUtility.mm: Added.
* bindings/objc/DOMViews.h: Added.
* bindings/objc/DOMViews.mm: Added.
* bindings/objc/DOMViewsInternal.h: Added.
* kwq/DOM-CSS.mm: Removed.
* kwq/DOM.h: Removed.
* kwq/DOM.mm: Removed.
* kwq/DOMCSS.h: Removed.
* kwq/DOMCore.h: Removed.
* kwq/DOMEvents.h: Removed.
* kwq/DOMEvents.mm: Removed.
* kwq/DOMEventsInternal.h: Removed.
* kwq/DOMExtensions.h: Removed.
* kwq/DOMHTML.h: Removed.
* kwq/DOMHTML.mm: Removed.
* kwq/DOMHTMLInternal.h: Removed.
* kwq/DOMInternal.h: Removed.
* kwq/DOMInternal.mm: Removed.
* kwq/DOMPrivate.h: Removed.
* kwq/DOMRange.h: Removed.
* kwq/DOMStylesheets.h: Removed.
* kwq/DOMTraversal.h: Removed.
* kwq/DOMUtility.mm: Removed.
* kwq/DOMViews.h: Removed.
* kwq/DOMViews.mm: Removed.
* kwq/DOMViewsInternal.h: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12140
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Mon, 16 Jan 2006 23:43:30 +0000 (23:43 +0000)]
Fix bugzilla url
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12139
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Mon, 16 Jan 2006 23:41:38 +0000 (23:41 +0000)]
2006-01-17 Anders Carlsson <andersca@mac.com>
Reviewed by Timothy Hatcher.
- http://bugzilla.opendarwin.org/show_bug.cgi?id=5367
Web Inspector: finish node attributes
* WebInspector.subproj/webInspector/inspector.css:
* WebInspector.subproj/webInspector/inspector.html:
* WebInspector.subproj/webInspector/inspector.js:
Add initial support for element attributes.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12138
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan [Mon, 16 Jan 2006 22:25:29 +0000 (22:25 +0000)]
Reviewed by Vicki Murley.
- fixed <rdar://problem/
4409288> REGRESSION (TOT): When no selection is present on page,
Jump to Selection doesn't beep
* WebView.subproj/WebHTMLView.m:
(-[WebHTMLView _hasInsertionPoint]):
new helper method
(-[NSArray validateUserInterfaceItem:]):
Don't validate this menu item (or a couple of others) if the selection is a caret and
the page isn't editable. In that state, there is no visible selection so this menu item
doesn't make sense. I suspect this was broken by some editing-related change that makes
selectionState return WebSelectionStateCaret here where it used to return WebSelectionStateNone.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12137
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Mon, 16 Jan 2006 22:01:49 +0000 (22:01 +0000)]
Fix by Mitz Pettel. Reviewed by Hyatt, landed by ap.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6473
REGRESSION: Serious painting problems on new iLife and iWorks pages
* khtml/css/css_grammar.y:
(DOM::getPropertyID): Undo the mapping of -moz-opacity and -moz-border-radius to
opacity and border-radius, respectively.
* khtml/rendering/render_box.cpp:
(RenderBox::setStyle): Set the object's layer to 0 before removing the layer,
to allow child layers to update their positions correctly.
* khtml/rendering/render_layer.cpp:
(khtml::RenderLayer::removeOnlyThisLayer): Update the positions of all children
of the layer being removed.
* manual-tests/bugzilla-6473.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12136
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Mon, 16 Jan 2006 21:46:06 +0000 (21:46 +0000)]
Patch by Mark Rowe. Reviewed by Darin, landed by ap.
Fix typo in CSSPrimitiveValueImpl::setStringValue.
* khtml/css/css_valueimpl.cpp:
(DOM::CSSPrimitiveValueImpl::setStringValue): Change >> to > and fix formatting.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12135
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Mon, 16 Jan 2006 20:34:00 +0000 (20:34 +0000)]
Reviewed by Justin.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5401
[WebCoreBridge firstRectForDOMRange:] works incorrectly for the first character after a line wrap
Test: editing/input/wrapped-line-char-rect.html
* bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge firstRectForDOMRange:]):
Use DOWNSTREAM affinity for the range start
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12134
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Mon, 16 Jan 2006 20:25:51 +0000 (20:25 +0000)]
Reviewed by darin
<http://bugzilla.opendarwin.org/show_bug.cgi?id=5127>
REGRESSION: problems making selection with left edge at right edge of image
<rdar://problem/
4364427>
triple-click includes first item on next line (www.apple.com, but I think I've seen it elsewhere)
* editing/selection/replaced-boundaries-1-expected.checksum: Added.
* editing/selection/replaced-boundaries-1-expected.png: Added.
* editing/selection/replaced-boundaries-1-expected.txt: Added.
* editing/selection/replaced-boundaries-1.html: Added.
* editing/selection/replaced-boundaries-2-expected.checksum: Added.
* editing/selection/replaced-boundaries-2-expected.png: Added.
* editing/selection/replaced-boundaries-2-expected.txt: Added.
* editing/selection/replaced-boundaries-2.html: Added.
* editing/selection/replaced-boundaries-3-expected.checksum: Added.
* editing/selection/replaced-boundaries-3-expected.png: Added.
* editing/selection/replaced-boundaries-3-expected.txt: Added.
* editing/selection/replaced-boundaries-3.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12133
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Mon, 16 Jan 2006 20:24:33 +0000 (20:24 +0000)]
Reviewed by darin
<http://bugzilla.opendarwin.org/show_bug.cgi?id=5127>
REGRESSION: problems making selection with left edge at right edge of image
<rdar://problem/
4364427>
triple-click includes first item on next line (www.apple.com, but I think I've seen it elsewhere)
Don't paint the selection tint on replaced elements
if the selections starts at the end or ends at the start.
* khtml/rendering/render_image.cpp:
(RenderImage::paint):
* khtml/rendering/render_replaced.cpp:
(WebCore::RenderReplaced::isSelected):
(WebCore::RenderWidget::paint):
* khtml/rendering/render_replaced.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12132
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tomernic [Mon, 16 Jan 2006 20:04:31 +0000 (20:04 +0000)]
Fixed <rdar://problem/
4211707> NPAPI ref count behavior differs with Mozilla
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12131
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Mon, 16 Jan 2006 17:56:26 +0000 (17:56 +0000)]
- actually removed QPtrDict itself
* ForwardingHeaders/qptrdict.h: Removed.
* WebCore.xcodeproj/project.pbxproj: Removed KWQPtrDict* files.
* kwq/KWQPtrDict.h: Removed.
* kwq/KWQPtrDictImpl.cpp: Removed.
* kwq/KWQPtrDictImpl.h: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12130
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Mon, 16 Jan 2006 17:52:23 +0000 (17:52 +0000)]
Reviewed by John Sullivan.
- removed all uses of QPtrDict, most uses of QMap
* khtml/ecma/kjs_dom.cpp: Converted tabs to spaces.
(KJS::DOMNode::mark): Switched from QPtrDict to HashSet.
* khtml/ecma/kjs_events.cpp: Converted tabs to spaces.
(KJS::JSUnprotectedEventListener::JSUnprotectedEventListener): Use HashMap.
(KJS::JSEventListener::JSEventListener): Use HashMap.
(KJS::JSLazyEventListener::parseCode): Use HashMap.
* khtml/ecma/kjs_html.cpp: Convert tabs to spaces.
(KJS::KJS::HTMLElement::classInfo): Use HashMap.
* khtml/ecma/kjs_window.cpp: Convert tabs to spaces.
(KJS::Window::~Window): Use HashMap.
(KJS::Window::getJSEventListener): Ditto.
(KJS::Window::getJSUnprotectedEventListener): Ditto.
(KJS::WindowQObject::parentDestroyed): Ditto.
(KJS::WindowQObject::installTimeout): Ditto.
(KJS::WindowQObject::pauseTimeouts): Ditto.
(KJS::WindowQObject::resumeTimeouts): Ditto.
(KJS::WindowQObject::clearTimeout): Ditto.
(KJS::WindowQObject::timerEvent): Ditto.
* khtml/ecma/kjs_window.h: Use HashMap.
* khtml/ecma/xmlhttprequest.cpp: Convert tabs to spaces.
(KJS::XMLHttpRequest::requestsByDocument): Use HashMap/Set.
(KJS::XMLHttpRequest::addToRequestsByDocument): Ditto.
(KJS::XMLHttpRequest::removeFromRequestsByDocument): Ditto.
(KJS::XMLHttpRequest::cancelRequests): Ditto.
* khtml/ecma/xmlhttprequest.h: Ditto.
* khtml/editing/apply_style_command.cpp:
(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): Use HashMap.
* khtml/rendering/render_canvas.cpp:
(RenderCanvas::selectionRect): Use HashMap.
(RenderCanvas::setSelection): Ditto.
* khtml/rendering/render_flow.cpp: (RenderFlow::paintLines): Use HashSet.
* khtml/rendering/render_line.cpp: (khtml::InlineFlowBox::paint): Use HashSet.
* khtml/rendering/render_object.h: Used HashSet.
Converted tabs to spaces and did namespace changes too.
* khtml/xml/DocumentImpl.cpp:
(DocumentImpl::DocumentImpl): Use HashSet and HashMap.
(DocumentImpl::~DocumentImpl): Ditto.
(DocumentImpl::registerDisconnectedNodeWithEventListeners): Ditto.
(DocumentImpl::unregisterDisconnectedNodeWithEventListeners): Ditto.
(DocumentImpl::removeAllDisconnectedNodeEventListeners): Ditto.
(DocumentImpl::addImageMap): Ditto.
(DocumentImpl::removeImageMap): Ditto.
(DocumentImpl::getImageMap): Ditto.
(DocumentImpl::addMarker): Ditto.
(DocumentImpl::copyMarkers): Ditto.
(DocumentImpl::removeMarkers): Ditto.
(DocumentImpl::markersForNode): Ditto.
(DocumentImpl::shiftMarkers): Ditto.
(DocumentImpl::radioButtonChecked): Ditto.
(DocumentImpl::checkedRadioButtonForGroup): Ditto.
(DocumentImpl::removeRadioButtonGroup): Ditto.
* khtml/xml/DocumentImpl.h: Use HashSet and HashMap.
* khtml/xml/NodeImpl.cpp:
(WebCore::NodeImpl::registerNodeList): Use HashSet.
(WebCore::NodeImpl::unregisterNodeList): Ditto.
(WebCore::NodeImpl::notifyLocalNodeListsAttributeChanged): Ditto.
(WebCore::NodeImpl::notifyNodeListsAttributeChanged): Ditto.
(WebCore::NodeImpl::notifyLocalNodeListsChildrenChanged): Ditto.
(WebCore::NodeImpl::notifyNodeListsChildrenChanged): Ditto.
(WebCore::NodeImpl::getElementsByTagName): Moved here so we don't have
to include NodeListImpl.h in the header.
* khtml/xml/NodeImpl.h: Use HashSet. Reduced includes.
* khtml/xml/dom_elementimpl.cpp:
(WebCore::MappedAttributeKey): Added. Hash table key.
(WebCore::MappedAttributeKeyTraits): Added. Hash table key traits.
(WebCore::MappedAttributeHash): Added. Hash function.
(WebCore::StyledElementImpl::getMappedAttributeDecl): Use HashMap.
(WebCore::StyledElementImpl::setMappedAttributeDecl): Ditto.
(WebCore::StyledElementImpl::removeMappedAttributeDecl): Ditto.
(WebCore::MappedAttributeHash::hash): Added. Hash function.
* khtml/xml/dom_elementimpl.h: Use HashMap.
* khtml/html/html_imageimpl.cpp:
(WebCore::HTMLMapElementImpl::parseMappedAttribute): Update m_name handling
to use AtomicString.
* khtml/html/html_imageimpl.h:
(WebCore::HTMLMapElementImpl::getName): Change to return const AtomicString&.
* khtml/dom/dom_string.h: Added a default argument to substring, also
reduced includes and updated namespace.
* khtml/xml/dom_stringimpl.h: Ditto.
* bridge/mac/WebCoreFrameBridge.mm: Switched to new WebCore namespace.
Updated includes for header changes.
* kcanvas/RenderForeignObject.cpp: Ditto.
* kcanvas/RenderForeignObject.h: Ditto.
* kcanvas/RenderSVGImage.h: Ditto.
* kcanvas/device/quartz/KCanvasResourcesQuartz.h: Ditto.
* khtml/css/css_ruleimpl.cpp: Ditto.
* khtml/css/css_valueimpl.h: Ditto.
* khtml/ecma/kjs_dom.h: Ditto.
* khtml/ecma/kjs_html.h: Ditto.
* khtml/editing/composite_edit_command.cpp: Ditto.
* khtml/editing/delete_selection_command.cpp: Ditto.
* khtml/html/html_tableimpl.cpp: Ditto.
* khtml/khtml_events.cpp: Ditto.
* khtml/rendering/RenderText.cpp: Ditto.
* khtml/rendering/render_block.cpp: Ditto.
* khtml/rendering/render_br.cpp: Ditto.
* khtml/rendering/render_inline.cpp: Ditto.
* khtml/rendering/render_object.cpp: Ditto.
* khtml/rendering/render_replaced.cpp: Ditto.
* khtml/xml/dom2_rangeimpl.cpp: Ditto.
* kwq/DOM.mm: Ditto.
* page/Frame.cpp: Ditto.
* kcanvas/KCanvasResources.cpp: (KCanvasMarker::draw): Updated because a
constant moved into the WebCore namespace.
* kcanvas/RenderSVGText.cpp: (RenderSVGText::nodeAtPoint): Ditto.
* kcanvas/RenderSVGText.h: Ditto.
* kcanvas/device/quartz/KCanvasItemQuartz.h: Ditto.
* kcanvas/device/quartz/KCanvasItemQuartz.mm:
(KCanvasItemQuartz::paint): Ditto.
(KCanvasItemQuartz::nodeAtPoint): Ditto.
* kcanvas/device/quartz/KCanvasResourcesQuartz.mm:
(KCanvasContainerQuartz::paint): Ditto.
* khtml/xbl/xbl_binding_manager.cpp: Removed include of qptrddict.h.
* khtml/xbl/xbl_binding_manager.h: Removed include of qptrddict.h.
* khtml/xbl/xbl_docimpl.h: Removed include of qptrddict.h.
* khtml/xml/dom_xmlimpl.cpp: Changed to use RefPtr for strings.
* khtml/xml/dom_xmlimpl.h: Ditto.
* ksvg2/css/SVGRenderStyle.h: Reduced includes a bit and added newly-needed ones.
* ksvg2/misc/KSVGTimeScheduler.cpp: Ditto.
* ksvg2/svg/SVGPointImpl.cpp: Ditto.
* kwq/KWQNamespace.h: Removed QColor, QCursor, and redundant declaration of QRgb
(now in qcolor.h). Also converted tabs to spaces.
* kwq/KWQPainter.h: Added newly-needed include.
* kwq/KWQPtrVector.h: Added append function.
* kwq/KWQVectorImpl.cpp: (KWQVectorImpl::append): Added.
* kwq/KWQVectorImpl.h: Added append.
* kwq/KWQRenderTreeDebug.cpp: Updated to no longer use transparentColor constant.
* kwq/KWQWMatrix.cpp: Changed name to QMatrix to allow forward declarations.
* kwq/KWQWMatrix.h: Ditto.
* loader/Cache.cpp: (khtml::Cache::clear): Use deleteAllValues for clearer code.
* loader/CachedCSSStyleSheet.cpp: Reduced includes a lot, moving them from .h to .cpp.
* loader/CachedCSSStyleSheet.h: Ditto.
* loader/CachedImage.cpp: Ditto.
* loader/CachedImage.h: Ditto.
* loader/CachedImageCallback.cpp: Ditto.
* loader/CachedObject.cpp: Ditto.
* loader/CachedObject.h: Ditto.
* loader/CachedObjectClient.h: Ditto.
* loader/CachedObjectClientWalker.cpp: Ditto.
* loader/CachedObjectClientWalker.h: Ditto.
* loader/CachedScript.cpp: Ditto.
* loader/CachedScript.h: Ditto.
* loader/CachedXSLStyleSheet.cpp: Ditto.
* loader/loader.cpp:
(WebCore::Loader::Loader): Changed to use HashMap.
(WebCore::Loader::~Loader): Ditto.
(WebCore::Loader::servePendingRequests): Ditto.
(WebCore::Loader::slotFinished): Ditto.
(WebCore::Loader::slotReceivedResponse): Ditto.
(WebCore::Loader::slotData): Ditto.
(WebCore::Loader::numRequests): Ditto.
(WebCore::Loader::cancelRequests): Ditto.
(WebCore::Loader::jobForRequest): Ditto.
* loader/loader.h: Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12129
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Mon, 16 Jan 2006 09:03:42 +0000 (09:03 +0000)]
2006-01-16 Eric Seidel <eseidel@apple.com>
Reviewed by darin.
Remove usage of Tahoma font. (previous commit was incomplete)
http://bugzilla.opendarwin.org/show_bug.cgi?id=6569
* fast/box-sizing/percentage-height-expected.checksum:
* fast/box-sizing/percentage-height-expected.png:
* fast/box-sizing/percentage-height-expected.txt:
* fast/box-sizing/percentage-height.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12128
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Mon, 16 Jan 2006 08:49:46 +0000 (08:49 +0000)]
Reviewed by Maciej.
- fix problem with ++, ==, and != on const iterators in
HashMaps that are using the pointer specialization
* kxmlcore/HashMapPtrSpec.h:
(KXMLCore::PointerHashConstIteratorAdapter::operator++): Change type to const_iterator.
(KXMLCore::PointerHashConstIteratorAdapter::operator==): Ditto.
(KXMLCore::PointerHashConstIteratorAdapter::operator!=): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12127
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Mon, 16 Jan 2006 08:30:20 +0000 (08:30 +0000)]
* WebCore.xcodeproj/project.pbxproj: Move config.h in project file to match
where it is in the source tree.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12126
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Mon, 16 Jan 2006 08:05:34 +0000 (08:05 +0000)]
2006-01-16 Anders Carlsson <andersca@mac.com>
Reviewed by Darin.
* WebInspector.subproj/webInspector/inspector.js:
Use defined NodeType values instead of integers.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12125
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Mon, 16 Jan 2006 07:50:30 +0000 (07:50 +0000)]
2006-01-15 Eric Seidel <eseidel@apple.com>
Update out-of-date pixel results.
* fast/dom/dom-parse-serialize-expected.checksum:
* fast/dom/dom-parse-serialize-expected.png:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12124
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Mon, 16 Jan 2006 02:45:51 +0000 (02:45 +0000)]
Reviewed by Darin.
* fast/box-sizing/percentage-height-expected.txt:
* fast/box-sizing/percentage-height.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12123
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Mon, 16 Jan 2006 02:42:36 +0000 (02:42 +0000)]
WebCore:
Reviewed by Darin.
Support for the new DOM Inspector.
* khtml/ecma/kjs_dom.cpp: exposes scrollIntoViewIfNeeded to JS
* khtml/ecma/kjs_dom.h:
* khtml/rendering/RenderText.cpp:
(RenderText::lineBoxRects): returns text run rects
* khtml/rendering/RenderText.h:
* khtml/rendering/render_container.cpp:
(RenderContainer::lineBoxRects): returns all child line box rects
* khtml/rendering/render_container.h:
* khtml/rendering/render_object.cpp:
(RenderObject::lineBoxRects): returns an empty list
* khtml/rendering/render_object.h:
* khtml/xml/dom_elementimpl.cpp:
(ElementImpl::scrollIntoViewIfNeeded): scrolls only if needed, bool decides to center to align to nearest edge
* khtml/xml/dom_elementimpl.h: Ditto
* kwq/DOM.mm:
(-[DOMNode boundingBox]): returns the bounding box for a node
(-[DOMNode lineBoxRects]): returns text runs for a node
* kwq/DOMCore.h: added missing @protocol DOMEventListener and @class DOMEvent
* kwq/DOMExtensions.h: removes methods that haven't been API reviewed
* kwq/DOMPrivate.h: new pending public API added for the Inspector
WebKit:
Reviewed by Darin.
New DOM Inspector that lives in WebKit and is accessible from any WebView.
Accessible from a contextual menu when the WebKitEnableInspectElementContextMenuItem default is
true or you have a development build. Browsing the tree, serialized HTML and CSS rules work.
To always enable enter the following in the Terminal (change the bundle id to affect other WebKit apps):
defaults write com.apple.Safari WebKitEnableInspectElementContextMenuItem -bool true
http://bugzilla.opendarwin.org/show_bug.cgi?id=6571
* English.lproj/Localizable.strings:
* English.lproj/StringsNotToBeLocalized.txt: reorder of the entries
* Misc.subproj/WebKitNSStringExtras.h:
* Misc.subproj/WebKitNSStringExtras.m:
(-[NSString _webkit_stringByCollapsingWhitespaceCharacters]): collapses consecutive whitespace into a single space
* WebCoreSupport.subproj/WebFrameBridge.m:
(-[WebFrameBridge pluginViewWithPackage:attributeNames:attributeValues:baseURL:]): cleanup
(-[WebFrameBridge viewForPluginWithURL:attributeNames:attributeValues:MIMEType:]): call the new UI delegate method
* WebInspector.subproj: Added.
* WebInspector.subproj/WebInspector.h: Added.
* WebInspector.subproj/WebInspector.m: Added.
(+[WebInspector sharedWebInspector]):
(-[WebInspector init]):
(-[WebInspector initWithWebFrame:]):
(-[WebInspector dealloc]):
(-[WebInspector window]):
(-[WebInspector windowDidLoad]):
(-[WebInspector windowWillClose:]):
(-[WebInspector showWindow:]):
(-[WebInspector setWebFrame:]):
(-[WebInspector webFrame]):
(-[WebInspector setRootDOMNode:]):
(-[WebInspector rootDOMNode]):
(-[WebInspector setFocusedDOMNode:]):
(-[WebInspector focusedDOMNode]):
(-[WebInspector setSearchQuery:]):
(-[WebInspector searchQuery]):
(-[WebInspector searchResults]):
(-[WebInspector showOptionsMenu]):
(-[WebInspector selectNewRoot:]):
(-[WebInspector resizeTopArea:]):
(-[WebInspector treeViewScrollTo:]):
(-[WebInspector treeViewOffsetTop]):
(-[WebInspector treeViewScrollHeight]):
(-[WebInspector traverseTreeBackward]):
(-[WebInspector traverseTreeForward]):
(-[WebInspector _toggleIgnoreWhitespace:]):
(-[WebInspector _highlightNode:]):
(-[WebInspector _nodeHighlightExpired:]):
(-[WebInspector _focusRootNode:]):
(-[WebInspector _revealAndSelectNodeInTree:]):
(-[WebInspector _showSearchResults:]):
(-[WebInspector _refreshSearch]):
(-[WebInspector _update]):
(-[WebInspector _updateRoot]):
(-[WebInspector _updateTreeScrollbar]):
(+[WebInspector isSelectorExcludedFromWebScript:]):
(+[WebInspector webScriptNameForSelector:]):
(+[WebInspector isKeyExcludedFromWebScript:]):
(-[WebInspector handleEvent:]):
(-[WebInspector webView:didFinishLoadForFrame:]):
(-[WebInspector webView:plugInViewWithArguments:]):
(-[WebInspector outlineView:numberOfChildrenOfItem:]):
(-[WebInspector outlineView:isItemExpandable:]):
(-[WebInspector outlineView:child:ofItem:]):
(-[WebInspector outlineView:objectValueForTableColumn:byItem:]):
(-[WebInspector outlineView:willDisplayOutlineCell:forTableColumn:item:]):
(-[WebInspector outlineViewItemDidCollapse:]):
(-[WebInspector outlineViewSelectionDidChange:]):
(-[WebInspectorPrivate dealloc]):
(-[DOMHTMLElement _addClassName:]): Helper method for the Inspector to append style classes
(-[DOMHTMLElement _removeClassName:]): Helper method for the Inspector to remove style classes
(-[DOMNode _contentPreview]):
(-[DOMNode _isAncestorOfNode:]):
(-[DOMNode _isDescendantOfNode:]):
(-[DOMNode _isWhitespace]):
(-[DOMNode _lengthOfChildNodesIgnoringWhitespace]):
(-[DOMNode _childNodeAtIndexIgnoringWhitespace:]):
(-[DOMNode _nextSiblingSkippingWhitespace]):
(-[DOMNode _previousSiblingSkippingWhitespace]):
(-[DOMNode _firstChildSkippingWhitespace]):
(-[DOMNode _lastChildSkippingWhitespace]):
(-[DOMNode _firstAncestorCommonWithNode:]):
(-[DOMNode _traverseNextNodeStayingWithin:]):
(-[DOMNode _traverseNextNodeSkippingWhitespaceStayingWithin:]):
(-[DOMNode _traversePreviousNode]):
(-[DOMNode _traversePreviousNodeSkippingWhitespace]):
(-[DOMNode _nodeTypeName]):
(-[DOMNode _shortDisplayName]):
(-[DOMNode _displayName]):
* WebInspector.subproj/WebInspectorInternal.h: Added.
* WebInspector.subproj/WebInspectorOutlineView.h: Added.
* WebInspector.subproj/WebInspectorOutlineView.m: Added.
(-[WebInspectorOutlineView isOpaque]):
(-[WebInspectorOutlineView _highlightColorForCell:]):
(-[WebInspectorOutlineView _highlightRow:clipRect:]):
(-[WebInspectorOutlineView drawBackgroundInClipRect:]):
* WebInspector.subproj/WebInspectorPanel.h: Added.
* WebInspector.subproj/WebInspectorPanel.m: Added.
(-[WebInspectorPanel canBecomeKeyWindow]):
(-[WebInspectorPanel canBecomeMainWindow]):
(-[WebInspectorPanel moveWindow:]):
(-[WebInspectorPanel resizeWindow:]):
(-[WebInspectorPanel sendEvent:]):
* WebInspector.subproj/WebNodeHighlight.h: Added.
* WebInspector.subproj/WebNodeHighlight.m: Added.
(-[WebNodeHighlight initWithBounds:andRects:forView:]):
(-[WebNodeHighlight dealloc]):
(-[WebNodeHighlight fractionComplete]):
(-[WebNodeHighlight expire]):
(-[WebNodeHighlight redraw:]):
* WebInspector.subproj/WebNodeHighlightView.h: Added.
* WebInspector.subproj/WebNodeHighlightView.m: Added.
(-[WebNodeHighlightView roundedRect:withRadius:]):
(-[WebNodeHighlightView initWithHighlight:andRects:forView:]):
(-[WebNodeHighlightView dealloc]):
(-[WebNodeHighlightView isOpaque]):
(-[WebNodeHighlightView drawRect:]):
* WebInspector.subproj/webInspector: Added.
* WebInspector.subproj/webInspector/Images: Added.
* WebInspector.subproj/webInspector/Images/close.png: Added.
* WebInspector.subproj/webInspector/Images/closePressed.png: Added.
* WebInspector.subproj/webInspector/Images/downTriangle.png: Added.
* WebInspector.subproj/webInspector/Images/menu.png: Added.
* WebInspector.subproj/webInspector/Images/menuPressed.png: Added.
* WebInspector.subproj/webInspector/Images/popupFill.png: Added.
* WebInspector.subproj/webInspector/Images/popupFillPressed.png: Added.
* WebInspector.subproj/webInspector/Images/popupLeft.png: Added.
* WebInspector.subproj/webInspector/Images/popupLeftPressed.png: Added.
* WebInspector.subproj/webInspector/Images/popupRight.png: Added.
* WebInspector.subproj/webInspector/Images/popupRightPressed.png: Added.
* WebInspector.subproj/webInspector/Images/rightTriangle.png: Added.
* WebInspector.subproj/webInspector/Images/scrollThumbBottom.png: Added.
* WebInspector.subproj/webInspector/Images/scrollThumbMiddle.png: Added.
* WebInspector.subproj/webInspector/Images/scrollThumbTop.png: Added.
* WebInspector.subproj/webInspector/Images/scrollTrackBottom.png: Added.
* WebInspector.subproj/webInspector/Images/scrollTrackMiddle.png: Added.
* WebInspector.subproj/webInspector/Images/scrollTrackTop.png: Added.
* WebInspector.subproj/webInspector/Images/squareButtonRight.png: Added.
* WebInspector.subproj/webInspector/Images/squareButtonRightPressed.png: Added.
* WebInspector.subproj/webInspector/Images/upTriangle.png: Added.
* WebInspector.subproj/webInspector/inspector.css: Added.
* WebInspector.subproj/webInspector/inspector.html: Added.
* WebInspector.subproj/webInspector/inspector.js: Added.
* WebKit.xcodeproj/project.pbxproj: Adds Web Inspector files
* WebView.subproj/WebUIDelegatePrivate.h: new UI delegate method to supply a replacement view for plugins
* WebView.subproj/WebView.m:
(-[WebView _menuForElement:defaultItems:]): Add a new context menu item for inspecting
(-[WebView _inspectElement:]): Context menu item target for inspecting
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12122
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Mon, 16 Jan 2006 01:29:54 +0000 (01:29 +0000)]
Reviewed by Eric.
- changed WebCore namespace change to work on Win32 as well as Mac OS X
* WebCorePrefix.h: Removed things needed cross-platform.
* config.h: Moved from khtml subdirectory. Added defines from
WebCorePrefix.h, and added a define that makes KSVG a synonym for WebCore.
* khtml/config.h: Removed.
* khtml/css/css_grammar.y: Changed SVG functions to use function name rather
than namespace to avoid collision with the XML and HTML DOM. Changes tabs to spaces.
* khtml/css/css_valueimpl.cpp:
(WebCore::propertyID): Add SVG properties ot the ones understood here.
This allows us to set SVG properties from JavaScript.
* ksvg2/scripts/cssmakeprops: Put functions inside the namespace to avoid compiler
warning, and renamed functions to include CSS and SVG.
* ksvg2/scripts/cssmakevalues: Ditto.
* ksvg2/svg/SVGStyledElementImpl.cpp: (SVGStyledElementImpl::parseMappedAttribute):
Use property ID function by its new name.
* ksvg2/ksvg.h: Renamed ExceptionCode to SVGExceptionCode.
* khtml/ecma/XSLTProcessor.cpp: Moved "config.h" header up above the ifdef so that
the ifdef works.
* khtml/xbl/xbl_binding.cpp: Ditto.
* khtml/xbl/xbl_binding_manager.cpp: Ditto.
* khtml/xbl/xbl_docimpl.cpp: Ditto.
* khtml/xbl/xbl_protobinding.cpp: Ditto.
* khtml/xbl/xbl_tokenizer.cpp: Ditto.
* khtml/xsl/xsl_stylesheetimpl.cpp: Ditto.
* khtml/xsl/xslt_processorimpl.cpp: Ditto.
* loader/CachedXBLDocument.cpp: Ditto.
* ksvg2/svg/SVGFELightElementImpl.h: Removed include of "config.h". That's supposed
to only be included by code files, not headers.
* ksvg2/svg/SVGFEDistantLightElementImpl.cpp: Added missing include of "config.h".
Did a few other tweaks to the file.
* ksvg2/svg/SVGFEPointLightElementImpl.cpp: Ditto.
* ksvg2/svg/SVGFESpotLightElementImpl.cpp: Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12121
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Mon, 16 Jan 2006 00:38:47 +0000 (00:38 +0000)]
2006-01-15 Eric Seidel <eseidel@apple.com>
Rubber-stamped by darin.
Updated files w/ missing copyrights from Oliver.
* kcanvas/device/quartz/filters/WKArithmeticFilter.cikernel:
* kcanvas/device/quartz/filters/WKDistantLightFilter.cikernel:
* kcanvas/device/quartz/filters/WKPointLightFilter.cikernel:
* kcanvas/device/quartz/filters/WKSpotLightFilter.cikernel:
* ksvg2/svg/SVGAnimatedColorImpl.cpp:
* ksvg2/svg/SVGAnimatedColorImpl.h:
* ksvg2/svg/SVGFEDiffuseLightingElementImpl.cpp:
* ksvg2/svg/SVGFEDiffuseLightingElementImpl.h:
* ksvg2/svg/SVGFEDistantLightElementImpl.cpp:
* ksvg2/svg/SVGFEDistantLightElementImpl.h:
* ksvg2/svg/SVGFELightElementImpl.cpp:
* ksvg2/svg/SVGFELightElementImpl.h:
* ksvg2/svg/SVGFEPointLightElementImpl.cpp:
* ksvg2/svg/SVGFEPointLightElementImpl.h:
* ksvg2/svg/SVGFESpecularLightingElementImpl.cpp:
* ksvg2/svg/SVGFESpecularLightingElementImpl.h:
* ksvg2/svg/SVGFESpotLightElementImpl.cpp:
* ksvg2/svg/SVGFESpotLightElementImpl.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12120
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Sun, 15 Jan 2006 23:37:25 +0000 (23:37 +0000)]
Oops, didn't check in these two files!
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12119
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Sun, 15 Jan 2006 23:32:02 +0000 (23:32 +0000)]
Reviewed and tweaked a bit by Darin.
Fix for <http://bugzilla.opendarwin.org/show_bug.cgi?id=6523>
"Extract data from SelectionController"
This patch refactors the data portions of SelectionController into its
own class, "Selection".
The extracted data are the base/extent/start/end positions and cursor
affinity. Also a couple cached values generated by validation are kept around
in the new class.
This patch does away with all the different affinities
(start/end/base/extent) that were never implemented properly, since affinity
only makes sense when the selection is a caret (as per discussion with mjs and
darin on #webkit).
No test cases added because this is a refactoring.
* WebCore.xcodeproj/project.pbxproj:
* bridge/mac/MacFrame.mm:
(MacFrame::findString):
(MacFrame::advanceToNextMisspelling):
(MacFrame::baseWritingDirectionForSelectionStart):
(MacFrame::respondToChangedSelection):
* bridge/mac/WebCoreFrameBridge.mm:
(-[WebCoreFrameBridge selectionState]):
(-[WebCoreFrameBridge selectNSRange:]):
(-[WebCoreFrameBridge selectionAffinity]):
(-[WebCoreFrameBridge setMarkDOMRange:]):
(-[WebCoreFrameBridge ensureSelectionVisible]):
(-[WebCoreFrameBridge rangeOfCharactersAroundCaret]):
* khtml/editing/Selection.cpp: Added.
(khtml::Selection::Selection):
(khtml::Selection::clear):
(khtml::Selection::toRange):
(khtml::Selection::validate):
(khtml::Selection::adjustForEditableContent):
(khtml::Selection::debugPosition):
* khtml/editing/Selection.h: Added.
(khtml::Selection::):
(khtml::Selection::state):
(khtml::Selection::setAffinity):
(khtml::Selection::affinity):
(khtml::Selection::setBase):
(khtml::Selection::setExtent):
(khtml::Selection::setStart):
(khtml::Selection::setEnd):
(khtml::Selection::base):
(khtml::Selection::extent):
(khtml::Selection::start):
(khtml::Selection::end):
(khtml::Selection::isNone):
(khtml::Selection::isCaret):
(khtml::Selection::isRange):
(khtml::Selection::isCaretOrRange):
(khtml::Selection::isBaseFirst):
(khtml::operator==):
(khtml::operator!=):
* khtml/editing/SelectionController.cpp:
(khtml::SelectionController::SelectionController):
(khtml::SelectionController::operator=):
(khtml::SelectionController::moveTo):
(khtml::SelectionController::setModifyBias):
(khtml::SelectionController::modifyExtendingRightForward):
(khtml::SelectionController::modifyMovingRightForward):
(khtml::SelectionController::modifyExtendingLeftBackward):
(khtml::SelectionController::modifyMovingLeftBackward):
(khtml::SelectionController::modify):
(khtml::SelectionController::expandUsingGranularity):
(khtml::SelectionController::xPosForVerticalArrowNavigation):
(khtml::SelectionController::clear):
(khtml::SelectionController::setBase):
(khtml::SelectionController::setExtent):
(khtml::SelectionController::toString):
(khtml::SelectionController::getRangeAt):
(khtml::SelectionController::frame):
(khtml::SelectionController::collapseToEnd):
(khtml::SelectionController::collapseToStart):
(khtml::SelectionController::layout):
(khtml::SelectionController::caretRect):
(khtml::SelectionController::needsCaretRepaint):
(khtml::SelectionController::paintCaret):
(khtml::SelectionController::debugRenderer):
(khtml::SelectionController::formatForDebugger):
(khtml::SelectionController::showTree):
* khtml/editing/SelectionController.h:
(khtml::SelectionController::state):
(khtml::SelectionController::affinity):
(khtml::SelectionController::base):
(khtml::SelectionController::extent):
(khtml::SelectionController::start):
(khtml::SelectionController::end):
(khtml::SelectionController::isNone):
(khtml::SelectionController::isCaret):
(khtml::SelectionController::isRange):
(khtml::SelectionController::isCaretOrRange):
(khtml::SelectionController::toRange):
(khtml::SelectionController::baseNode):
(khtml::SelectionController::extentNode):
(khtml::SelectionController::baseOffset):
(khtml::SelectionController::extentOffset):
(khtml::SelectionController::anchorNode):
(khtml::SelectionController::anchorOffset):
(khtml::SelectionController::focusNode):
(khtml::SelectionController::focusOffset):
(khtml::operator==):
* khtml/editing/apply_style_command.cpp:
(khtml::ApplyStyleCommand::updateStartEnd):
* khtml/editing/break_blockquote_command.cpp:
(khtml::BreakBlockquoteCommand::doApply):
* khtml/editing/delete_selection_command.cpp:
(khtml::DeleteSelectionCommand::initializePositionData):
(khtml::DeleteSelectionCommand::handleGeneralDelete):
(khtml::DeleteSelectionCommand::doApply):
* khtml/editing/insert_line_break_command.cpp:
(khtml::InsertLineBreakCommand::doApply):
* khtml/editing/insert_paragraph_separator_command.cpp:
(khtml::InsertParagraphSeparatorCommand::doApply):
* khtml/editing/insert_text_command.cpp:
(khtml::InsertTextCommand::input):
* khtml/editing/move_selection_command.cpp:
(khtml::MoveSelectionCommand::doApply):
* khtml/editing/replace_selection_command.cpp:
(khtml::ReplaceSelectionCommand::doApply):
(khtml::ReplaceSelectionCommand::completeHTMLReplacement):
* khtml/editing/typing_command.cpp:
(khtml::TypingCommand::deleteKeyPressed):
(khtml::TypingCommand::forwardDeleteKeyPressed):
(khtml::TypingCommand::markMisspellingsAfterTyping):
* khtml/xml/DocumentImpl.cpp:
(DocumentImpl::updateSelection):
* kwq/KWQAccObject.mm:
(-[KWQAccObject accessibilityAttributeValue:]):
(-[KWQAccObject doAXTextMarkerRangeForLine:]):
* kwq/KWQRenderTreeDebug.cpp:
(writeSelection):
* page/Frame.cpp:
(Frame::selectContentsOfNode):
(Frame::shouldChangeSelection):
(Frame::computeAndSetTypingStyle):
(Frame::applyStyle):
(Frame::applyParagraphStyle):
(Frame::selectFrameElementInParentIfFullySelected):
(Frame::revealSelection):
(Frame::centerSelectionInVisibleArea):
(Frame::styleForSelectionStart):
* <a few other files, including editing ones>: Added includes since Selection.h and
SelectionController.h now include fewer things.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12118
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Sun, 15 Jan 2006 22:38:00 +0000 (22:38 +0000)]
LayoutTests:
Reviewed by Darin.
- test for http://bugzilla.opendarwin.org/show_bug.cgi?id=5619
CSS2: pre-wrap has overflow/selection problems
* fast/text/whitespace/pre-wrap-overflow-selection-expected.checksum: Added.
* fast/text/whitespace/pre-wrap-overflow-selection-expected.png: Added.
* fast/text/whitespace/pre-wrap-overflow-selection-expected.txt: Added.
* fast/text/whitespace/pre-wrap-overflow-selection.html: Added.
WebCore:
Test: fast/text/whitespace/pre-wrap-overflow-selection.html
Reviewed by Darin.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5619
CSS2: pre-wrap has overflow/selection problems
* khtml/rendering/InlineTextBox.cpp:
(khtml::InlineTextBox::selectionRect): Clip selection rect to the text box
(khtml::InlineTextBox::paintSelection): Clip selection painting to the text box.
* khtml/rendering/bidi.cpp: (khtml::RenderBlock::computeHorizontalPositionsForLine):
Remove code that re-added border width, since it is already included in availableWidth.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12117
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Sun, 15 Jan 2006 21:52:24 +0000 (21:52 +0000)]
Reviewed by Anders.
- fix regression in duplicate ID layout test
* khtml/xml/DocumentImpl.cpp:
(DocumentImpl::getElementById): Change to take AtomicString, so we can use
the string pointer as a hash key and not worry about ref'ing the pointer or
about object lifetime since the string will be stored for the lifetime of the
ID attribute. Also update for the counted set formerly named m_idCount to use
its new name, m_duplicateIds.
(DocumentImpl::addElementById): Ditto.
(DocumentImpl::removeElementById): Ditto.
(DocumentImpl::recalcStyleSelector): Pass a DOMStringImpl* (see below).
* khtml/xml/DocumentImpl.h: Change functions to take AtomicString.
* kcanvas/KCanvasFilters.cpp: (getFilterById): Use AtomicString.
* kcanvas/KCanvasFilters.h: Ditto.
* kcanvas/KCanvasResources.cpp:
(getResourceById): Ditto.
(getMarkerById): Ditto.
(getClipperById): Ditto.
(getMaskerById): Ditto.
(getPaintServerById): Ditto.
* kcanvas/KCanvasResources.h: Ditto.
* khtml/ecma/kjs_window.cpp: (KJS::Window::getOwnPropertySlot): Ditto.
* khtml/html/HTMLLabelElementImpl.cpp:
(DOM::HTMLLabelElementImpl::formElement): Ditto.
* khtml/xml/NodeListImpl.cpp: (DOM::NodeListImpl::itemById): Ditto.
* khtml/xml/NodeListImpl.h: Ditto. Also removed unnecessary "virtual".
* khtml/ecma/kjs_css.cpp:
(KJS::DOMStyleSheetList::nameGetter): Pass a DOMStringImpl*, which gets
converted to an AtomicString implicitly, rather than a DOMString, which
does not. (But that's a crazy rule -- we should change this around long term.)
(KJS::DOMStyleSheetList::getOwnPropertySlot): Ditto.
* khtml/ecma/kjs_dom.cpp:
(KJS::DOMNodeList::nameGetter): Ditto.
(KJS::DOMNodeList::getOwnPropertySlot): Ditto.
(KJS::DOMDocumentProtoFunc::callAsFunction): Ditto.
- Merge khtml, DOM, and KDOM into one big namespace, WebCore.
* WebCorePrefix.h: Use defined to map the old namespace names to WebCore.
Now that this is done in the prefix, we can start actually calling it by
that name, phase out the old names, then remove the defines.
- other changes
* khtml/xml/DocumentTypeImpl.cpp: Converted tabs to spaces.
* khtml/xml/dom2_eventsimpl.cpp: Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12116
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Sun, 15 Jan 2006 20:04:57 +0000 (20:04 +0000)]
2006-01-15 Alexander Kellett <lypanov@kde.org>
Reviewed and landed by Anders.
http://bugzilla.opendarwin.org/show_bug.cgi?id=6553
Remove KCanvasCommonArgs and pass around RenderPath objects instead.
* WebCore.xcodeproj/project.pbxproj:
* kcanvas/KCanvasCreator.h:
* kcanvas/KCanvasItem.cpp:
* kcanvas/KCanvasItem.h:
* kcanvas/KCanvasTypes.h: Removed.
* kcanvas/device/KRenderingDevice.cpp:
* kcanvas/device/KRenderingDevice.h:
* kcanvas/device/KRenderingFillPainter.h:
* kcanvas/device/KRenderingPaintServer.h:
* kcanvas/device/KRenderingStrokePainter.h:
* kcanvas/device/quartz/KCanvasItemQuartz.mm:
(KCanvasItemQuartz::paint):
* kcanvas/device/quartz/KRenderingDeviceQuartz.h:
* kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
(drawShadingWithStyle):
(KRenderingPaintServerLinearGradientQuartz::draw):
(KRenderingPaintServerRadialGradientQuartz::draw):
* kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
* kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
(KRenderingPaintServerSolidQuartz::draw):
(KRenderingPaintServerPatternQuartz::draw):
(KRenderingPaintServerImageQuartz::draw):
* ksvg2/misc/KCanvasRenderingStyle.cpp:
* ksvg2/svg/SVGPatternElementImpl.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12115
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin [Sun, 15 Jan 2006 15:14:52 +0000 (15:14 +0000)]
Reviewed by Hyatt.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6528
remove all use of QDict from WebCore
I ran performance tests and the change results in a slight improvement.
* bridge/mac/MacFrame.h: Removed include of KWQDict.h. Changed didTellBridgeAboutLoad
and haveToldBridgeAboutLoad functions to take DOMString instead of QString. Changed
urlsBridgeKnowsAbout from a QDict to a HashMap.
* bridge/mac/MacFrame.mm:
(MacFrame::didTellBridgeAboutLoad): Updated to use QDict and DOMString.
(MacFrame::haveToldBridgeAboutLoad): Ditto.
* khtml/editing/jsediting.h: Removed include of qdict.h.
* khtml/rendering/render_frames.cpp: Removed include of qdict.h. Put file inside the
khtml namespace instead of just using the namespace. Changed tabs to spaces.
(khtml::RenderPartObject::updateWidget): Changed the local variable uniqueParamNames
to be a HashSet instead of a QDict.
* khtml/xml/DocumentImpl.h: Removed include of qdict.h, changed m_elementsById, m_idCount,
and m_elementsByAccessKey to use HashMap and HashCountedSet instead of QDict.
* khtml/xml/DocumentImpl.cpp: Changed tabs to spaces.
(DocumentImpl::getElementById): Updated to use HashMap for m_elementsById and HashCountedSet
for m_idCount.
(DocumentImpl::addElementById): Ditto. Remove code to clear m_accessKeyDictValid,
since setDocumentChanged already takes care of that.
(DocumentImpl::removeElementById): Ditto.
(DocumentImpl::getElementByAccessKey): Updated to use HashMap for m_elementsByAccessKey.
(DocumentImpl::setDocumentChanged): Rearranged to do a couple fewer branches. Clear out
the m_elementsByAccessKey map when clearing m_accessKeyMapValid to avoid keeping stale
pointers around.
* ksvg2/svg/SVGDocumentImpl.cpp: Removed include of q3dict.h.
* WebCore.vcproj/WebCore/WebCore.vcproj: Removed obsolete QDict sources.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* ForwardingHeaders/q3dict.h: Removed.
* ForwardingHeaders/qdict.h: Removed.
* kwq/KWQDict.h: Removed.
* kwq/KWQDictImpl.cpp: Removed.
* kwq/KWQDictImpl.h: Removed.
* WebCore+SVG/SVGNamesWrapper.cpp: Touched this file just so I could build again.
* kwq/KWQKURL.h: Removed unused canonicalURL, _path, _user, _pass, and _host functions.
* kwq/KWQKURL.mm: Changed tabs to spaces, removed unused functions, replaced NULL with 0.
* kwq/KWQLoader.mm: Changed tabs to spaces.
(KWQServeRequest): Removed QString conversion from call to didTellBridgeAboutLoad.
(KWQServeSynchronousRequest): Ditto.
(KWQCheckCacheObjectStatus): Ditto. Same for haveToldBridgeAboutLoad.
* loader/Cache.h: Removed include of qdict.h. Changed declaration of the LRUList struct
to just be a forward declaration. Changed tabs to spaces. Removed the static data member
called "cache". Added a static member function called get. Renamed removeCacheEntry to remove.
* loader/Cache.cpp: Put file inside the khtml namespace instead of just using the
namespace. Changed tabs to spaces. Changed the main cache itself to a HashMap and
made it a static variable local to this file instead of a static data member of Cache
to hide its type from the header. Also made the LRUList type private to this file.
(khtml::Cache::init): Create a HashMap instead of a QDict.
(khtml::Cache::clear): To replace the use of setAutoDelete, write a loop to delete all the
items in the cache map.
(khtml::Cache::requestImage): Change code to use HashMap functions instead of QDict.
(khtml::Cache::requestStyleSheet): Ditto.
(khtml::Cache::preloadStyleSheet): Ditto.
(khtml::Cache::requestScript): Ditto.
(khtml::Cache::preloadScript): Ditto.
(khtml::Cache::requestXSLStyleSheet): Ditto.
(khtml::Cache::requestXBLDocument): Ditto.
(khtml::Cache::removeCacheEntry): Ditto.
(khtml::Cache::FastLog2): Fixed this for 64-bit compiles.
(khtml::Cache::getStatistics): Ditto.
(khtml::Cache::flushAll): Ditto.
(khtml::Cache::get): Added. Function used by the loader.
* loader/CachedObject.h: Removed include of qdict.h.
* loader/DocLoader.h: Removed include of qdict.h.
* loader/DocLoader.cpp: (khtml::DocLoader::needReload): Changed to use new get function of
Cache instead of getting at the map directly. Also changed call to removeCacheEntry
to remove because it was renamed.
* loader/CachedImage.cpp: (khtml::CachedImage::data): Changed call to removeCacheEntry
to remove because it was renamed.
* loader/CachedImageCallback.cpp: (khtml::CachedImageCallback::handleError): Ditto.
* loader/loader.cpp:
(khtml::Loader::slotFinished): Ditto.
(khtml::Loader::cancelRequests): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12114
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap [Sun, 15 Jan 2006 14:39:26 +0000 (14:39 +0000)]
Reviewed by Anders.
- fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6561
run-javascriptcore-tests doesn't work
* JavaScriptCore/tests/mozilla/Getopt/Mixed.pm:
Changed revision number to 1.8 (broken by svn migration).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12113
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Sun, 15 Jan 2006 12:28:43 +0000 (12:28 +0000)]
2006-01-15 Eric Seidel <eseidel@apple.com>
Disabling broken test until results can be consistent:
http://bugzilla.opendarwin.org/show_bug.cgi?id=6560
* dom/xhtml/level2/html/HTMLIFrameElement11.xhtml: Removed.
* dom/xhtml/level2/html/HTMLIFrameElement11.xhtml-disabled: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12112
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Sun, 15 Jan 2006 12:03:43 +0000 (12:03 +0000)]
2006-01-15 Eric Seidel <eseidel@apple.com>
Disabling broken test until timezone bug is fixed:
http://bugzilla.opendarwin.org/show_bug.cgi?id=6547
* fast/js/kde/Date-expected.txt: Removed.
* fast/js/kde/Date.html: Removed.
* fast/js/kde/Date.html-disabled: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12111
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Sun, 15 Jan 2006 11:48:27 +0000 (11:48 +0000)]
2006-01-14 David Kilzer <ddkilzer@kilzer.net>
Reviewed and landed by Anders.
* kjs/create_hash_table: Fixed comment typo.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12110
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eseidel [Sun, 15 Jan 2006 11:47:18 +0000 (11:47 +0000)]
2006-01-15 Alexander Kellett <lypanov@kde.org>
Reviewed by eseidel.
<mask> inside <defs> crashes Safari.
http://bugzilla.opendarwin.org/show_bug.cgi?id=6548
* ksvg2/svg/SVGMaskElementImpl.cpp:
(KSVG::SVGMaskElementImpl::drawMaskerContent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12109
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
git://git.webkit.org / WebKit-https.git / log