sfalken@apple.com [Wed, 17 Nov 2010 18:31:16 +0000 (18:31 +0000)]
Update WebKitSystemInterfaceWin.
Rubber-stamped by Adam Roben.
* win/lib/WebKitSystemInterface.lib:
* win/lib/WebKitSystemInterface_debug.lib:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72219
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Wed, 17 Nov 2010 18:13:50 +0000 (18:13 +0000)]
Make changes to the Mac WebKit2 Skipped file trigger Windows builds
We use that file on Windows!
Fixes <http://webkit.org/b/49643> Changes to
LayoutTests/platform/mac-wk2 should trigger a Windows build, but don't
Reviewed by Steve Falkenburg.
* Scripts/webkitpy/common/config/build.py:
(_should_file_trigger_build): Added the mac-wk2 directory and make it
trigger builds on SnowLeopard and Windows.
* Scripts/webkitpy/common/config/build_unittest.py:
(ShouldBuildTest.test_should_build): Added a test.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72218
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Wed, 17 Nov 2010 18:03:03 +0000 (18:03 +0000)]
Update Windows results after r72125 and r72173
* platform/win/css2.1/t1202-counter-04-b-expected.txt:
* platform/win/css2.1/t1202-counters-04-b-expected.txt:
* platform/win/fast/blockflow/border-vertical-lr-expected.txt:
* platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/win/fast/dom/prototype-inheritance-2-expected.txt:
* platform/win/fast/dom/prototype-inheritance-expected.txt:
* platform/win/fast/js/global-constructors-expected.txt:
* platform/win/fast/text/international/complex-character-based-fallback-expected.txt:
* platform/win/fast/text/international/hebrew-vowels-expected.txt:
* platform/win/transforms/2d/hindi-rotated-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72217
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 17 Nov 2010 17:56:33 +0000 (17:56 +0000)]
2010-11-17 Tenghui Zhu <ztenghui@google.com>
Reviewed by Jeremy Orlow.
profileCallback and profileEndCallback should be guarded with ENABLE_JAVASCRIPT_DEBUGGER
https://bugs.webkit.org/show_bug.cgi?id=49623
No new tests. Just a compiling error fix.
* bindings/v8/custom/V8ConsoleCustom.cpp:
Add the guard ENABLE_JAVA_SCRIPT_DEBUGGER to profileCallback and profileEndCallback
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72216
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Wed, 17 Nov 2010 17:45:47 +0000 (17:45 +0000)]
Update WebKit2 skipped list.
Rubber-stamped by Jon Honeycutt.
* platform/mac-wk2/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72215
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Wed, 17 Nov 2010 17:39:39 +0000 (17:39 +0000)]
2010-11-17 Satish Sampath <satish@chromium.org>
Reviewed by Jeremy Orlow.
Clear the speech input mock explicitly before each test.
https://bugs.webkit.org/show_bug.cgi?id=49660
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::setMockSpeechInputResult):
* DumpRenderTree/chromium/LayoutTestController.h:
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::speechInputController):
(WebViewHost::reset): Invoke speech input mock's clearResults method.
* DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost::speechInputControllerMock): Moved mock from LayoutTestController.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72214
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 17 Nov 2010 17:28:34 +0000 (17:28 +0000)]
2010-11-17 John Knottenbelt <jknotten@chromium.org>
Reviewed by Jeremy Orlow.
Introduce GeoNotifierVector typedef for increased readability
https://bugs.webkit.org/show_bug.cgi?id=49597
* page/Geolocation.cpp:
(WebCore::Geolocation::Watchers::getNotifiersVector):
(WebCore::Geolocation::sendError):
(WebCore::Geolocation::sendPosition):
(WebCore::Geolocation::stopTimer):
(WebCore::Geolocation::stopTimersForOneShots):
(WebCore::Geolocation::stopTimersForWatchers):
(WebCore::Geolocation::cancelRequests):
(WebCore::Geolocation::cancelAllRequests):
(WebCore::Geolocation::handleError):
(WebCore::Geolocation::makeSuccessCallbacks):
* page/Geolocation.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72213
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Wed, 17 Nov 2010 17:25:01 +0000 (17:25 +0000)]
2010-11-17 Simon Fraser <simon.fraser@apple.com>
Reviewed by Adam Roben.
https://bugs.webkit.org/show_bug.cgi?id=45567
Add stubbed-out layer-backed drawing area for Windows.
Add implementations of LayerBackedDrawingArea and
LayerBackedDrawingAreaProxy for Windows, and add them
to the vcproj.
* UIProcess/LayerBackedDrawingAreaProxy.cpp:
* UIProcess/win/LayerBackedDrawingAreaProxyWin.cpp: Added.
(WebKit::LayerBackedDrawingAreaProxy::page):
(WebKit::LayerBackedDrawingAreaProxy::platformSetSize):
(WebKit::LayerBackedDrawingAreaProxy::attachCompositingContext):
(WebKit::LayerBackedDrawingAreaProxy::detachCompositingContext):
(WebKit::LayerBackedDrawingAreaProxy::paint):
* UIProcess/win/WebView.cpp:
(WebKit::WebView::pageDidEnterAcceleratedCompositing):
(WebKit::WebView::pageDidLeaveAcceleratedCompositing):
(WebKit::WebView::switchToDrawingAreaTypeIfNecessary):
* UIProcess/win/WebView.h:
* WebProcess/WebPage/LayerBackedDrawingArea.cpp:
* WebProcess/WebPage/win/LayerBackedDrawingAreaWin.cpp: Added.
(WebKit::LayerBackedDrawingArea::platformInit):
(WebKit::LayerBackedDrawingArea::platformClear):
(WebKit::LayerBackedDrawingArea::attachCompositingContext):
(WebKit::LayerBackedDrawingArea::detachCompositingContext):
(WebKit::LayerBackedDrawingArea::setRootCompositingLayer):
(WebKit::LayerBackedDrawingArea::scheduleCompositingLayerSync):
(WebKit::LayerBackedDrawingArea::syncCompositingLayers):
* win/WebKit2.vcproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72212
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 17 Nov 2010 17:08:31 +0000 (17:08 +0000)]
2010-11-17 John Knottenbelt <jknotten@chromium.org>
Reviewed by Jeremy Orlow.
Add a layout test to check that Geoposition timestamps are
well-formed. See https://bugs.webkit.org/show_bug.cgi?id=48518
* fast/dom/Geolocation/script-tests/timestamp.js: Added.
(checkPosition):
* fast/dom/Geolocation/timestamp-expected.txt: Added.
* fast/dom/Geolocation/timestamp.html: Added.
2010-11-17 John Knottenbelt <jknotten@chromium.org>
Reviewed by Jeremy Orlow.
Convert correctly between GeolocationPosition and Geoposition
timestamp formats.
https://bugs.webkit.org/show_bug.cgi?id=48518
Test: fast/dom/Geolocation/timestamp.html
* page/Geolocation.cpp:
(WebCore::createGeoposition):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72211
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
chang.shu@nokia.com [Wed, 17 Nov 2010 16:48:16 +0000 (16:48 +0000)]
2010-11-17 Chang Shu <chang.shu@nokia.com>
Reviewed by Antonio Gomes.
[Mac] Unskip the test that is passing now.
Test: fast/events/spatial-navigation/snav-single-select.html
* platform/mac/Skipped:
2010-11-17 Chang Shu <chang.shu@nokia.com>
Reviewed by Antonio Gomes.
[Mac] Suppress single select popup menu when spatial navigation is enabled on Mac.
This makes spatial navigation work properly for single select box.
Test: fast/events/spatial-navigation/snav-single-select.html
* dom/SelectElement.cpp:
(WebCore::nextValidIndex):
(WebCore::SelectElement::menuListDefaultEventHandler):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72210
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer@apple.com [Wed, 17 Nov 2010 16:36:04 +0000 (16:36 +0000)]
<webkit.org/b/49634> Make overflow guards in WTF::String::utf8 explicit
Reviewed by Darin Adler.
Add an explicit overflow check prior to allocating our buffer,
rather than implicitly relying on the guard in convertUTF16ToUTF8.
* wtf/text/WTFString.cpp:
(WTF::String::utf8):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72209
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antonm@chromium.org [Wed, 17 Nov 2010 16:13:49 +0000 (16:13 +0000)]
Not reviewed, rebaselining fast/js/regexp-overflow.html
https://bugs.webkit.org/show_bug.cgi?id=49665
* platform/chromium-mac/fast/js/regexp-overflow-expected.txt:
* platform/chromium-win/fast/js/regexp-overflow-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72208
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 17 Nov 2010 15:52:43 +0000 (15:52 +0000)]
2010-11-17 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r72197.
http://trac.webkit.org/changeset/72197
https://bugs.webkit.org/show_bug.cgi?id=49661
broke fast/regex/test1.html (Requested by stampho on #webkit).
* runtime/JSGlobalData.h:
* runtime/RegExp.cpp:
(JSC::RegExpRepresentation::~RegExpRepresentation):
(JSC::RegExp::compile):
(JSC::RegExp::match):
* tests/mozilla/expected.html:
* wtf/Platform.h:
* yarr/RegexCompiler.cpp:
* yarr/RegexCompiler.h:
* yarr/RegexInterpreter.cpp:
* yarr/RegexInterpreter.h:
* yarr/RegexJIT.cpp:
(JSC::Yarr::jitCompileRegex):
* yarr/RegexJIT.h:
(JSC::Yarr::RegexCodeBlock::RegexCodeBlock):
(JSC::Yarr::RegexCodeBlock::~RegexCodeBlock):
(JSC::Yarr::RegexCodeBlock::getFallback):
(JSC::Yarr::RegexCodeBlock::setFallback):
(JSC::Yarr::executeRegex):
* yarr/RegexParser.h:
* yarr/RegexPattern.h:
2010-11-17 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r72197.
http://trac.webkit.org/changeset/72197
https://bugs.webkit.org/show_bug.cgi?id=49661
broke fast/regex/test1.html (Requested by stampho on #webkit).
* fast/js/regexp-look-ahead-empty-expected.txt:
* fast/js/regexp-overflow-expected.txt:
* fast/js/script-tests/regexp-overflow.js:
* fast/js/sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.2/15.10.2.5_Term/S15.10.2.5_A1_T4-expected.txt:
* fast/js/sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.2/15.10.2.8_Atom/S15.10.2.8_A2_T1-expected.txt:
* fast/js/sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.6/15.10.6.2_RegExp.prototype.exec/S15.10.6.2_A1_T6-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72207
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
satish@chromium.org [Wed, 17 Nov 2010 15:17:06 +0000 (15:17 +0000)]
2010-11-17 Satish Sampath <satish@chromium.org>
Reviewed by Jeremy Orlow.
Clear the speech input mock explicitly before each test.
https://bugs.webkit.org/show_bug.cgi?id=49660
* platform/mock/SpeechInputClientMock.cpp:
(WebCore::SpeechInputClientMock::clearResults): Added clearResults method.
* platform/mock/SpeechInputClientMock.h:
2010-11-17 Satish Sampath <satish@chromium.org>
Reviewed by Jeremy Orlow.
Clear the speech input mock explicitly before each test.
https://bugs.webkit.org/show_bug.cgi?id=49660
* public/WebSpeechInputControllerMock.h:
* src/WebSpeechInputControllerMockImpl.cpp:
(WebKit::WebSpeechInputControllerMockImpl::clearResults): Added method to clear results.
* src/WebSpeechInputControllerMockImpl.h:
2010-11-17 Satish Sampath <satish@chromium.org>
Reviewed by Jeremy Orlow.
Clear the speech input mock explicitly before each test.
https://bugs.webkit.org/show_bug.cgi?id=49660
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::setMockSpeechInputResult):
* DumpRenderTree/chromium/LayoutTestController.h:
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::speechInputController):
(WebViewHost::reset): Invoke speech input mock's clearResults method.
* DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost::speechInputControllerMock): Moved mock from LayoutTestController.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72206
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Wed, 17 Nov 2010 14:49:29 +0000 (14:49 +0000)]
2010-11-17 Alexander Pavlov <apavlov@chromium.org>
[Chromium] Unreviewed, fix Chromium-Mac build from r72189.
* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::getDoubleValue):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72205
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hans@chromium.org [Wed, 17 Nov 2010 14:06:54 +0000 (14:06 +0000)]
2010-11-17 Hans Wennborg <hans@chromium.org>
Reviewed by Jeremy Orlow.
IndexedDB: IDBKey::whereSyntax should impose conditions on all columns
https://bugs.webkit.org/show_bug.cgi?id=49601
The WHERE clause should specifiy a condition for each key column to
make sure that the ObjectStoreData_composit index can be used when
querying the object store based on key. Not using the index causes
severe performance degradation for common IDB operations.
* storage/IDBKey.cpp:
(WebCore::IDBKey::whereSyntax):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72204
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Wed, 17 Nov 2010 14:04:20 +0000 (14:04 +0000)]
2010-11-17 Alexander Pavlov <apavlov@chromium.org>
Unreviewed, specify IRC nickname in committers.py.
* Scripts/webkitpy/common/config/committers.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72203
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
benjamin.poulain@nokia.com [Wed, 17 Nov 2010 13:50:16 +0000 (13:50 +0000)]
[Qt] [WK2] The focus switching does not seems to work with QGraphicsWKView
https://bugs.webkit.org/show_bug.cgi?id=49545
Reviewed by Kenneth Rohde Christiansen.
Implement focus switching with Tab. This is now done asynchronously,
waiting for webkit to call takeFocus() and switching the widget.
Since the focus can change between the Tab press and the callback,
QGraphicsWKView::focusNextPrevChildCallback() make sure the view still has
focus before passing it to the next widget.
* UIProcess/API/qt/qgraphicswkview.cpp:
(QGraphicsWKView::QGraphicsWKView):
(QGraphicsWKView::focusNextPrevChildCallback):
(QGraphicsWKView::focusNextPrevChild):
* UIProcess/API/qt/qgraphicswkview.h:
* UIProcess/API/qt/qwkpage.cpp:
(QWKPagePrivate::takeFocus):
* UIProcess/API/qt/qwkpage.h:
* UIProcess/API/qt/qwkpage_p.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72202
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antonm@chromium.org [Wed, 17 Nov 2010 13:32:01 +0000 (13:32 +0000)]
Not reviewed, disabling fast/css/getFloatValueForUnit.html.
https://bugs.webkit.org/show_bug.cgi?id=49656
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72201
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 17 Nov 2010 13:30:20 +0000 (13:30 +0000)]
2010-11-17 Eric Uhrhane <ericu@chromium.org>
Reviewed by David Levin.
[Chromium] implementation of async FileWriter for workers
https://bugs.webkit.org/show_bug.cgi?id=47681
Tests are in a separate changelist.
* platform/CrossThreadCopier.h: Changed CrossThreadCopier[Base] to support PassRefPtrs
2010-11-17 Eric Uhrhane <ericu@chromium.org>
Reviewed by David Levin.
[Chromium] implementation of async FileWriter for workers
https://bugs.webkit.org/show_bug.cgi?id=47681
Tests are in a separate changelist.
Added new files.
* WebKit.gyp:
* src/WorkerAsyncFileSystemChromium.cpp: Added WorkerAsyncFileWriterChromium construction.
* src/WorkerAsyncFileWriterChromium.cpp: Added.
* src/WorkerAsyncFileWriterChromium.h: Added.
This class bridges between the context and main threads for the WorkerAsyncFileWriterChromium.
* src/WorkerFileWriterCallbacksBridge.cpp: Added.
* src/WorkerFileWriterCallbacksBridge.h: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72200
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Wed, 17 Nov 2010 13:26:34 +0000 (13:26 +0000)]
2010-11-17 Pavel Feldman <pfeldman@chromium.org>
Not reviewed. Commenting out failing Qt inspector tests. Need to fix harness.
* platform/qt/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72199
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antonm@chromium.org [Wed, 17 Nov 2010 13:24:42 +0000 (13:24 +0000)]
Not reviewed, now disabling for real fast/css/line-height-determined-by-primary-font.html.
https://bugs.webkit.org/show_bug.cgi?id=49653
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72198
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Wed, 17 Nov 2010 13:15:56 +0000 (13:15 +0000)]
YARR JIT should fallback to YARR Interpreter instead of PCRE.
https://bugs.webkit.org/show_bug.cgi?id=46719
Patch by Peter Varga <pvarga@inf.u-szeged.hu> on 2010-11-17
Reviewed by Gavin Barraclough.
Remove the ENABLE_YARR macro and the option of matching regular
expressions with PCRE from JavaScriptCore.
JavaScriptCore:
* runtime/JSGlobalData.h:
* runtime/RegExp.cpp:
(JSC::RegExp::compile):
(JSC::RegExp::match):
* tests/mozilla/expected.html:
* wtf/Platform.h:
* yarr/RegexCompiler.cpp:
* yarr/RegexCompiler.h:
* yarr/RegexInterpreter.cpp:
(JSC::Yarr::byteCompileRegex):
* yarr/RegexInterpreter.h:
* yarr/RegexJIT.cpp:
(JSC::Yarr::jitCompileRegex):
* yarr/RegexJIT.h:
(JSC::Yarr::RegexCodeBlock::RegexCodeBlock):
(JSC::Yarr::RegexCodeBlock::~RegexCodeBlock):
(JSC::Yarr::RegexCodeBlock::getFallback):
(JSC::Yarr::RegexCodeBlock::isFallback):
(JSC::Yarr::RegexCodeBlock::setFallback):
(JSC::Yarr::executeRegex):
* yarr/RegexParser.h:
* yarr/RegexPattern.h:
LayoutTests:
* fast/js/regexp-look-ahead-empty-expected.txt:
* fast/js/regexp-overflow-expected.txt:
* fast/js/script-tests/regexp-overflow.js:
* fast/js/sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.2/15.10.2.5_Term/S15.10.2.5_A1_T4-expected.txt:
* fast/js/sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.2/15.10.2.8_Atom/S15.10.2.8_A2_T1-expected.txt:
* fast/js/sputnik/Conformance/15_Native_Objects/15.10_RegExp/15.10.6/15.10.6.2_RegExp.prototype.exec/S15.10.6.2_A1_T6-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72197
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 17 Nov 2010 13:09:59 +0000 (13:09 +0000)]
2010-11-17 John Mellor <johnme@chromium.org>
Reviewed by Darin Fisher.
[chromium] Expose frame flattening setting in WebSettings.
https://bugs.webkit.org/show_bug.cgi?id=49621
* public/WebSettings.h:
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setFrameFlatteningEnabled):
* src/WebSettingsImpl.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72196
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Wed, 17 Nov 2010 13:03:43 +0000 (13:03 +0000)]
2010-11-17 Alexander Pavlov <apavlov@chromium.org>
Unreviewed, remove stale Chromium test expectations to fix build.
* platform/chromium-linux/fast/css/getFloatValueForUnit-expected.png: Removed.
* platform/chromium-win/fast/css/getFloatValueForUnit-expected.png: Removed.
* platform/mac-leopard/fast/css/getFloatValueForUnit-expected.png: Removed.
* platform/mac/fast/css/getFloatValueForUnit-expected.png: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72195
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Wed, 17 Nov 2010 12:54:14 +0000 (12:54 +0000)]
[NRWT] Make http locking similar to perl implementation
https://bugs.webkit.org/show_bug.cgi?id=49187
Patch by Gabor Rapcsanyi <rgabor@inf.u-szeged.hu> on 2010-11-17
Reviewed by Tony Chang.
* Scripts/webkitpy/common/system/file_lock.py: Added.
* Scripts/webkitpy/common/system/file_lock_unittest.py: Added.
* Scripts/webkitpy/layout_tests/port/http_lock.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72194
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Wed, 17 Nov 2010 12:37:49 +0000 (12:37 +0000)]
2010-11-17 Andreas Kling <kling@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
Don't prohibit scrolling in tiled backing store mode.
We delegate scrolling instead.
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72193
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 17 Nov 2010 12:19:52 +0000 (12:19 +0000)]
2010-11-17 Jonathan Backer <backer@chromium.org>
Reviewed by Kenneth Russell.
[Chromium] Resize initiated by renderer.
https://bugs.webkit.org/show_bug.cgi?id=49617
To address synchronization issues with resizing, make resize work like DARWIN.
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::resize):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72192
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alex@webkit.org [Wed, 17 Nov 2010 12:06:28 +0000 (12:06 +0000)]
2010-11-17 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
[gtk] r69119 modified just the gtk2 version of the
scrolled_window_paint function but not the gtk3 version
https://bugs.webkit.org/show_bug.cgi?id=49585
Use gtk_paint_shadow the same as the actual code from GTK+. Avoid
using state and use the same values we are using for gtk2 in the
paint function.
* platform/gtk/ScrollbarThemeGtk.cpp:
(WebCore::ScrollbarThemeGtk::paintButton): Initialized the
depressed attribute of the state variable to avoid using it
without initialization.
* platform/gtk/gtk3drawing.c:
(moz_gtk_scrolled_window_paint):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72191
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alex@webkit.org [Wed, 17 Nov 2010 11:41:24 +0000 (11:41 +0000)]
2010-11-17 Alejandro G. Castro <alex@igalia.com>
Unreviewed, GTK expectations update after r72116 and r72141.
* platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/gtk/fast/dom/prototype-inheritance-expected.txt:
* platform/gtk/fast/forms/linebox-overflow-in-textarea-padding-expected.txt:
* platform/gtk/fast/js/global-constructors-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72190
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Wed, 17 Nov 2010 11:39:59 +0000 (11:39 +0000)]
2010-11-16 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Simon Fraser.
CSSPrimitiveValue.getFloatValue does not convert sizes
https://bugs.webkit.org/show_bug.cgi?id=35770
Extended getFloatValueForUnit and CSSPrimitiveValue tests. The former has been made text-only,
which allowed to get rid of a number of unnecessary baselines.
* fast/css/CSSPrimitiveValue-exceptions-expected.txt:
* fast/css/getFloatValueForUnit-expected.txt: Added.
* fast/css/getFloatValueForUnit.html:
* fast/css/resources/CSSPrimitiveValue-exceptions.js:
* platform/chromium-linux/fast/css/getFloatValueForUnit-expected.checksum: Removed.
* platform/chromium-win/fast/css/getFloatValueForUnit-expected.checksum: Removed.
* platform/chromium-win/fast/css/getFloatValueForUnit-expected.txt: Removed.
* platform/mac-leopard/fast/css/getFloatValueForUnit-expected.checksum: Removed.
* platform/mac/fast/css/getFloatValueForUnit-expected.checksum: Removed.
* platform/mac/fast/css/getFloatValueForUnit-expected.txt: Removed.
* platform/qt/fast/css/getFloatValueForUnit-expected.txt: Removed.
2010-11-16 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Simon Fraser.
CSSPrimitiveValue.getFloatValue does not convert sizes
https://bugs.webkit.org/show_bug.cgi?id=35770
Implemented all same-category unit conversions (length, angle, time, frequency) and retained
absolute-relative (cm, mm, in, pt, pc) length conversions intact.
Illegal unit conversion attempts will throw an INVALID_ACCESS_ERR DOMException.
* css/CSSPrimitiveValue.cpp:
(WebCore::unitCategory):
(WebCore::conversionToCanonicalUnitsScaleFactor):
(WebCore::CSSPrimitiveValue::getDoubleValue):
(WebCore::CSSPrimitiveValue::canonicalUnitTypeForCategory):
(WebCore::CSSPrimitiveValue::getDoubleValueInternal):
(WebCore::CSSPrimitiveValue::getIdent):
* css/CSSPrimitiveValue.h:
(WebCore::CSSPrimitiveValue::getFloatValue):
(WebCore::CSSPrimitiveValue::getIntValue):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72189
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 17 Nov 2010 11:29:42 +0000 (11:29 +0000)]
2010-11-17 Ademar de Souza Reis Jr. <ademar.reis@openbossa.org>
Reviewed by Andreas Kling.
Document::nodesFromRect() has wrong source code documentation
https://bugs.webkit.org/show_bug.cgi?id=49610
* dom/Document.h: fix nodesFromRect() documentation
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72188
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antonm@chromium.org [Wed, 17 Nov 2010 11:21:16 +0000 (11:21 +0000)]
Not reviewed, disabling three layout tests for Chromium.
https://bugs.webkit.org/show_bug.cgi?id=49653
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72187
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Wed, 17 Nov 2010 11:03:40 +0000 (11:03 +0000)]
Extend YARR Interpreter with beginning character look-up optimization
https://bugs.webkit.org/show_bug.cgi?id=45751
Patch by Peter Varga <pvarga@inf.u-szeged.hu> on 2010-11-17
Reviewed by Gavin Barraclough.
Add beginning character look-up optimization which sets the start
index to the first possible successful pattern match.
Extend YARR Interpreter with lookupForBeginChars function which
implements the beginning character look-up optimization.
* yarr/RegexInterpreter.cpp:
(JSC::Yarr::Interpreter::InputStream::readPair):
(JSC::Yarr::Interpreter::InputStream::isNotAvailableInput):
(JSC::Yarr::Interpreter::lookupForBeginChars):
(JSC::Yarr::Interpreter::matchDisjunction):
(JSC::Yarr::Interpreter::interpret):
* yarr/RegexInterpreter.h:
(JSC::Yarr::BytecodePattern::BytecodePattern):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72186
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Wed, 17 Nov 2010 11:01:52 +0000 (11:01 +0000)]
[Qt] Improve painting performance on 16-bit displays
Reviewed by Kenneth Christiansen.
When the default pixmap depth is 16-bit, then use RGB16 instead of
RGB32 for the chunks, to avoid unnecessary conversions and reduce
chunk size. The conversions happen as images as QPixmaps have 16-bit
depth and the tiles on the ui process are also backed by QPixmaps.
* Shared/qt/UpdateChunk.cpp:
(WebKit::UpdateChunk::size):
(WebKit::UpdateChunk::createImage):
* Shared/qt/UpdateChunk.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72185
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Wed, 17 Nov 2010 10:54:59 +0000 (10:54 +0000)]
[Qt] Add support for use GStreamer with the Qt build
Reviewed by Kenneth Christiansen, Tor Arne Vestbø.
JavaScriptCore:
Enable the build/inclusion of the wtf/QObject convenience classes.
* JavaScriptCore.pri:
* wtf/wtf.pri:
WebCore:
Make it possible to use gstreamer with the Qt build via the USE_GSTREAMER macro. The
integration is rather basic at this point, allowing for software based rendering
only at the moment. AC integration and fullscreen playback is still missing.
* WebCore.pro: Added a bunch of gstreamer files to the build and guard it as a
build option with the USE_GSTREAMER macro.
* platform/graphics/MediaPlayer.cpp:
(WebCore::installedMediaEngines): Don't use the generic media player registration
when using GStreamer. These #ifdefs should be removed, but the gstreamer folks want
to be able to build with gstreamer _and_ another backend simultaenously.
* platform/graphics/gstreamer/ImageGStreamer.h:
* platform/graphics/gstreamer/ImageGStreamerQt.cpp: Added.
(ImageGStreamer::createImage):
(ImageGStreamer::ImageGStreamer):
(ImageGStreamer::~ImageGStreamer):
* platform/graphics/gstreamer/PlatformVideoWindowPrivate.h: Added.
* platform/graphics/gstreamer/PlatformVideoWindowQt.cpp: Added.
(FullScreenVideoWindow::FullScreenVideoWindow):
(FullScreenVideoWindow::keyPressEvent):
(FullScreenVideoWindow::event):
(PlatformVideoWindow::PlatformVideoWindow):
(PlatformVideoWindow::~PlatformVideoWindow):
(PlatformVideoWindow::prepareForOverlay):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72184
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Wed, 17 Nov 2010 10:49:32 +0000 (10:49 +0000)]
2010-11-17 MORITA Hajime <morrita@google.com>
Reviewed by Kent Tamura.
[Chromium][DRT] EventSender.contextClick() should aware spellchecking
https://bugs.webkit.org/show_bug.cgi?id=49366
- EvenSender: Checked WebContextMenuData.misspelledWord and added extra context menu entries
according to the spellchecker suggestion
- MockSpellCheck: add fillSuggestionList to provide fake suggestions.
test_expectations.txt will be changed after this change is ported to test_shell.
* DumpRenderTree/chromium/EventSender.cpp:
(makeMenuItemStringsFor):
(EventSender::contextClick):
* DumpRenderTree/chromium/MockSpellCheck.cpp:
(MockSpellCheck::fillSuggestionList):
(MockSpellCheck::initializeIfNeeded):
* DumpRenderTree/chromium/MockSpellCheck.h:
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::mockSpellCheck):
* DumpRenderTree/chromium/WebViewHost.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72183
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Wed, 17 Nov 2010 10:48:08 +0000 (10:48 +0000)]
2010-11-17 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [REGRESSION] editing disabled styles breaks style bodies.
https://bugs.webkit.org/show_bug.cgi?id=49602
* inspector/styles-new-API-expected.txt:
* inspector/styles-new-API.html:
2010-11-17 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [REGRESSION] editing disabled styles breaks style bodies.
https://bugs.webkit.org/show_bug.cgi?id=49602
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyle::setPropertyText):
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertyTreeElement.prototype.get name):
(WebInspector.StylePropertyTreeElement.prototype.get priority):
(WebInspector.StylePropertyTreeElement.prototype.get value):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72182
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 17 Nov 2010 10:02:17 +0000 (10:02 +0000)]
2010-11-17 Stuart Morgan <stuartmorgan@chromium.org>
Reviewed by Dimitri Glazkov.
Fix click count for mouse-up events.
- clickCount for mouse up was lost in conversion from NSEvent
- clickCount was also lost when disptaching events through the
plugin mouse capture event codepath.
https://bugs.webkit.org/show_bug.cgi?id=49290
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleInputEvent):
* src/mac/WebInputEventFactory.mm:
(WebKit::WebInputEventFactory::mouseEvent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72181
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 17 Nov 2010 09:42:41 +0000 (09:42 +0000)]
2010-11-17 Peter Varga <pvarga@inf.u-szeged.hu>
Reviewed by Gavin Barraclough.
Collect the beginning characters in a RegExp pattern for look-up
optimization
https://bugs.webkit.org/show_bug.cgi?id=45748
Extend the YARR's parser with an algorithm which collects the potential
beginning characters from a RegExp pattern for later look-up optimization.
* yarr/RegexCompiler.cpp:
(JSC::Yarr::BeginCharHelper::BeginCharHelper):
(JSC::Yarr::BeginCharHelper::addBeginChar):
(JSC::Yarr::BeginCharHelper::merge):
(JSC::Yarr::BeginCharHelper::addCharacter):
(JSC::Yarr::BeginCharHelper::linkHotTerms):
(JSC::Yarr::RegexPatternConstructor::RegexPatternConstructor):
(JSC::Yarr::RegexPatternConstructor::addBeginTerm):
(JSC::Yarr::RegexPatternConstructor::setupDisjunctionBeginTerms):
(JSC::Yarr::RegexPatternConstructor::setupAlternativeBeginTerms):
(JSC::Yarr::RegexPatternConstructor::setupBeginChars):
(JSC::Yarr::compileRegex):
* yarr/RegexPattern.h:
(JSC::Yarr::TermChain::TermChain):
(JSC::Yarr::BeginChar::BeginChar):
(JSC::Yarr::RegexPattern::RegexPattern):
(JSC::Yarr::RegexPattern::reset):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72180
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aestes@apple.com [Wed, 17 Nov 2010 09:24:35 +0000 (09:24 +0000)]
Two more tests needing new results after r72173.
* platform/mac/editing/selection/caret-rtl-expected.txt:
* platform/mac/transforms/2d/hindi-rotated-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72179
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aestes@apple.com [Wed, 17 Nov 2010 08:45:12 +0000 (08:45 +0000)]
More results needing new results after r72173.
* platform/mac/fast/text/backslash-to-yen-sign-euc-expected.txt:
* platform/mac/fast/text/backslash-to-yen-sign-expected.txt:
* platform/mac/fast/text/international/bidi-mirror-he-ar-expected.txt:
* platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72178
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aestes@apple.com [Wed, 17 Nov 2010 08:37:00 +0000 (08:37 +0000)]
The following results needed new results after r72173.
* editing/selection/extend-selection-bidi-expected.txt:
* platform/mac/editing/deleting/
5144139-2-expected.checksum:
* platform/mac/editing/deleting/
5144139-2-expected.png:
* platform/mac/editing/deleting/
5144139-2-expected.txt:
* platform/mac/editing/selection/caret-rtl-2-expected.checksum:
* platform/mac/editing/selection/caret-rtl-2-expected.png:
* platform/mac/editing/selection/caret-rtl-2-expected.txt:
* platform/mac/editing/selection/extend-selection-bidi-expected.checksum:
* platform/mac/editing/selection/extend-selection-bidi-expected.png:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72177
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Wed, 17 Nov 2010 08:05:39 +0000 (08:05 +0000)]
2010-11-17 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r72160.
http://trac.webkit.org/changeset/72160
https://bugs.webkit.org/show_bug.cgi?id=49646
Broke lots of fast/profiler tests, among others (Requested by
aroben on #webkit).
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
(JSC::CodeBlock::functionRegisterForBytecodeOffset):
(JSC::CodeBlock::shrinkToFit):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::addFunctionRegisterInfo):
* bytecode/Opcode.h:
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitCallVarargs):
(JSC::BytecodeGenerator::emitReturn):
(JSC::BytecodeGenerator::emitConstruct):
* bytecompiler/BytecodeGenerator.h:
(JSC::CallArguments::profileHookRegister):
* bytecompiler/NodesCodegen.cpp:
(JSC::CallArguments::CallArguments):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::unwindCallFrame):
(JSC::Interpreter::throwException):
(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::privateExecute):
* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
* jit/JIT.h:
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_profile_will_call):
(JSC::JIT::emit_op_profile_did_call):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_profile_will_call):
(JSC::JIT::emit_op_profile_did_call):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* jit/JITStubs.h:
* profiler/Profile.cpp:
(JSC::Profile::Profile):
* profiler/ProfileGenerator.cpp:
(JSC::ProfileGenerator::addParentForConsoleStart):
(JSC::ProfileGenerator::willExecute):
(JSC::ProfileGenerator::didExecute):
(JSC::ProfileGenerator::stopProfiling):
* profiler/ProfileGenerator.h:
* profiler/ProfileNode.cpp:
(JSC::ProfileNode::ProfileNode):
(JSC::ProfileNode::willExecute):
* profiler/ProfileNode.h:
(JSC::ProfileNode::create):
(JSC::ProfileNode::operator==):
* profiler/Profiler.cpp:
(JSC::dispatchFunctionToProfiles):
(JSC::Profiler::willExecute):
(JSC::Profiler::didExecute):
* profiler/Profiler.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72176
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Wed, 17 Nov 2010 07:43:57 +0000 (07:43 +0000)]
Ignore files from libdispatch/zlib
Rubber-stamped by Eric Seidel.
* win/include: Modified property svn:ignore.
* win/lib: Modified property svn:ignore.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72175
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Wed, 17 Nov 2010 07:24:08 +0000 (07:24 +0000)]
Move QTMovieWin's settings into a vsprops file
Fixes <http://webkit.org/b/49644> QTMovieWin should use a vsprops file
Reviewed by Steve Falkenburg.
* WebCore.vcproj/QTMovieWin.vcproj:
* WebCore.vcproj/QTMovieWinCommon.vsprops: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72174
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aestes@apple.com [Wed, 17 Nov 2010 06:45:50 +0000 (06:45 +0000)]
WebKit mishandles line boxes where the content height exceeds the
specified line-height.
https://bugs.webkit.org/show_bug.cgi?id=49410
Reviewed by Dave Hyatt.
WebCore:
If a line height is explicitly specified on a text box and fallback
fonts are in use, only the primary font should be considered when
computing the box's ascent and descent. This prevents the inline box
from being sized larger than the specified line height.
This patch also fixes a math error when computing a used font's descent
in the case where line height isn't explicitly set. This change results
in a number of layout tests needing re-baselining.
Test: fast/css/line-height-determined-by-primary-font.html
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::computeLogicalBoxHeights):
LayoutTests:
* fast/css/line-height-determined-by-primary-font.html: Added.
* platform/mac/fast/css/line-height-determined-by-primary-font-expected.checksum: Added.
* platform/mac/fast/css/line-height-determined-by-primary-font-expected.png: Added.
* platform/mac/fast/css/line-height-determined-by-primary-font-expected.txt: Added.
The following test results were re-baselined:
* platform/mac/css2.1/t0805-c5518-brdr-t-01-e-expected.checksum:
* platform/mac/css2.1/t0805-c5518-brdr-t-01-e-expected.png:
* platform/mac/css2.1/t0805-c5518-brdr-t-01-e-expected.txt:
* platform/mac/css2.1/t0805-c5519-brdr-r-00-a-expected.checksum:
* platform/mac/css2.1/t0805-c5519-brdr-r-00-a-expected.png:
* platform/mac/css2.1/t0805-c5519-brdr-r-00-a-expected.txt:
* platform/mac/css2.1/t0805-c5520-brdr-b-01-e-expected.checksum:
* platform/mac/css2.1/t0805-c5520-brdr-b-01-e-expected.png:
* platform/mac/css2.1/t0805-c5520-brdr-b-01-e-expected.txt:
* platform/mac/css2.1/t0805-c5521-brdr-l-00-a-expected.checksum:
* platform/mac/css2.1/t0805-c5521-brdr-l-00-a-expected.png:
* platform/mac/css2.1/t0805-c5521-brdr-l-00-a-expected.txt:
* platform/mac/css2.1/t0805-c5521-brdr-l-01-e-expected.checksum:
* platform/mac/css2.1/t0805-c5521-brdr-l-01-e-expected.png:
* platform/mac/css2.1/t0805-c5521-brdr-l-01-e-expected.txt:
* platform/mac/css2.1/t0805-c5521-ibrdr-l-00-a-expected.checksum:
* platform/mac/css2.1/t0805-c5521-ibrdr-l-00-a-expected.png:
* platform/mac/css2.1/t0805-c5521-ibrdr-l-00-a-expected.txt:
* platform/mac/css2.1/t0905-c414-flt-02-c-expected.checksum:
* platform/mac/css2.1/t0905-c414-flt-02-c-expected.png:
* platform/mac/css2.1/t0905-c414-flt-02-c-expected.txt:
* platform/mac/css2.1/t0905-c414-flt-03-c-expected.checksum:
* platform/mac/css2.1/t0905-c414-flt-03-c-expected.png:
* platform/mac/css2.1/t0905-c414-flt-03-c-expected.txt:
* platform/mac/css2.1/t0905-c414-flt-04-c-expected.checksum:
* platform/mac/css2.1/t0905-c414-flt-04-c-expected.png:
* platform/mac/css2.1/t0905-c414-flt-04-c-expected.txt:
* platform/mac/css2.1/t0905-c414-flt-fit-01-d-g-expected.checksum:
* platform/mac/css2.1/t0905-c414-flt-fit-01-d-g-expected.png:
* platform/mac/css2.1/t0905-c414-flt-fit-01-d-g-expected.txt:
* platform/mac/css2.1/t0905-c5525-fltblck-01-d-expected.checksum:
* platform/mac/css2.1/t0905-c5525-fltblck-01-d-expected.png:
* platform/mac/css2.1/t0905-c5525-fltblck-01-d-expected.txt:
* platform/mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.checksum:
* platform/mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.png:
* platform/mac/css2.1/t0905-c5525-fltcont-00-d-g-expected.txt:
* platform/mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum:
* platform/mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png:
* platform/mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt:
* platform/mac/css2.1/t0905-c5525-fltwidth-02-c-g-expected.checksum:
* platform/mac/css2.1/t0905-c5525-fltwidth-02-c-g-expected.png:
* platform/mac/css2.1/t0905-c5525-fltwidth-02-c-g-expected.txt:
* platform/mac/css2.1/t0905-c5525-fltwidth-03-c-g-expected.checksum:
* platform/mac/css2.1/t0905-c5525-fltwidth-03-c-g-expected.png:
* platform/mac/css2.1/t0905-c5525-fltwidth-03-c-g-expected.txt:
* platform/mac/css2.1/t0905-c5525-fltwrap-00-b-expected.checksum:
* platform/mac/css2.1/t0905-c5525-fltwrap-00-b-expected.png:
* platform/mac/css2.1/t0905-c5525-fltwrap-00-b-expected.txt:
* platform/mac/css2.1/t090501-c414-flt-01-b-expected.checksum:
* platform/mac/css2.1/t090501-c414-flt-01-b-expected.png:
* platform/mac/css2.1/t090501-c414-flt-01-b-expected.txt:
* platform/mac/css2.1/t090501-c414-flt-03-b-g-expected.checksum:
* platform/mac/css2.1/t090501-c414-flt-03-b-g-expected.png:
* platform/mac/css2.1/t090501-c414-flt-03-b-g-expected.txt:
* platform/mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.checksum:
* platform/mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.png:
* platform/mac/css2.1/t090501-c5525-flt-l-00-b-g-expected.txt:
* platform/mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.checksum:
* platform/mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.png:
* platform/mac/css2.1/t090501-c5525-flt-r-00-b-g-expected.txt:
* platform/mac/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.checksum:
* platform/mac/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.png:
* platform/mac/css2.1/t100304-c43-rpl-bbx-01-d-g-expected.txt:
* platform/mac/css2.1/t1202-counter-03-b-expected.checksum:
* platform/mac/css2.1/t1202-counter-03-b-expected.png:
* platform/mac/css2.1/t1202-counter-03-b-expected.txt:
* platform/mac/css2.1/t1202-counter-04-b-expected.checksum:
* platform/mac/css2.1/t1202-counter-04-b-expected.png:
* platform/mac/css2.1/t1202-counter-04-b-expected.txt:
* platform/mac/css2.1/t1202-counter-09-b-expected.checksum:
* platform/mac/css2.1/t1202-counter-09-b-expected.png:
* platform/mac/css2.1/t1202-counter-09-b-expected.txt:
* platform/mac/css2.1/t1202-counters-03-b-expected.checksum:
* platform/mac/css2.1/t1202-counters-03-b-expected.png:
* platform/mac/css2.1/t1202-counters-03-b-expected.txt:
* platform/mac/css2.1/t1202-counters-04-b-expected.checksum:
* platform/mac/css2.1/t1202-counters-04-b-expected.png:
* platform/mac/css2.1/t1202-counters-04-b-expected.txt:
* platform/mac/css2.1/t1202-counters-09-b-expected.checksum:
* platform/mac/css2.1/t1202-counters-09-b-expected.png:
* platform/mac/css2.1/t1202-counters-09-b-expected.txt:
* platform/mac/fast/blockflow/vertical-font-fallback-expected.checksum:
* platform/mac/fast/blockflow/vertical-font-fallback-expected.png:
* platform/mac/fast/blockflow/vertical-font-fallback-expected.txt:
* platform/mac/fast/css/beforeSelectorOnCodeElement-expected.checksum:
* platform/mac/fast/css/beforeSelectorOnCodeElement-expected.png:
* platform/mac/fast/css/beforeSelectorOnCodeElement-expected.txt:
* platform/mac/fast/css/font-face-opentype-expected.checksum:
* platform/mac/fast/css/font-face-opentype-expected.png:
* platform/mac/fast/css/font-face-opentype-expected.txt:
* platform/mac/fast/css/rtl-ordering-expected.checksum:
* platform/mac/fast/css/rtl-ordering-expected.png:
* platform/mac/fast/css/rtl-ordering-expected.txt:
* platform/mac/fast/css/text-overflow-ellipsis-bidi-expected.checksum:
* platform/mac/fast/css/text-overflow-ellipsis-bidi-expected.png:
* platform/mac/fast/css/text-overflow-ellipsis-bidi-expected.txt:
* platform/mac/fast/css/text-overflow-ellipsis-expected.checksum:
* platform/mac/fast/css/text-overflow-ellipsis-expected.png:
* platform/mac/fast/css/text-overflow-ellipsis-expected.txt:
* platform/mac/fast/css/text-overflow-ellipsis-strict-expected.checksum:
* platform/mac/fast/css/text-overflow-ellipsis-strict-expected.png:
* platform/mac/fast/css/text-overflow-ellipsis-strict-expected.txt:
* platform/mac/fast/css/text-security-expected.checksum:
* platform/mac/fast/css/text-security-expected.png:
* platform/mac/fast/css/text-security-expected.txt:
* platform/mac/fast/encoding/denormalised-voiced-japanese-chars-expected.checksum:
* platform/mac/fast/encoding/denormalised-voiced-japanese-chars-expected.png:
* platform/mac/fast/encoding/denormalised-voiced-japanese-chars-expected.txt:
* platform/mac/fast/encoding/invalid-UTF-8-expected.checksum:
* platform/mac/fast/encoding/invalid-UTF-8-expected.png:
* platform/mac/fast/encoding/invalid-UTF-8-expected.txt:
* platform/mac/fast/events/updateLayoutForHitTest-expected.checksum:
* platform/mac/fast/events/updateLayoutForHitTest-expected.png:
* platform/mac/fast/events/updateLayoutForHitTest-expected.txt:
* platform/mac/fast/forms/select-visual-hebrew-expected.checksum:
* platform/mac/fast/forms/select-visual-hebrew-expected.png:
* platform/mac/fast/forms/select-visual-hebrew-expected.txt:
* platform/mac/fast/forms/select-writing-direction-natural-expected.checksum:
* platform/mac/fast/forms/select-writing-direction-natural-expected.png:
* platform/mac/fast/forms/select-writing-direction-natural-expected.txt:
* platform/mac/fast/forms/visual-hebrew-text-field-expected.checksum:
* platform/mac/fast/forms/visual-hebrew-text-field-expected.png:
* platform/mac/fast/forms/visual-hebrew-text-field-expected.txt:
* platform/mac/fast/repaint/repaint-across-writing-mode-boundary-expected.checksum:
* platform/mac/fast/repaint/repaint-across-writing-mode-boundary-expected.png:
* platform/mac/fast/repaint/repaint-across-writing-mode-boundary-expected.txt:
* platform/mac/fast/text/atsui-multiple-renderers-expected.checksum:
* platform/mac/fast/text/atsui-multiple-renderers-expected.png:
* platform/mac/fast/text/atsui-multiple-renderers-expected.txt:
* platform/mac/fast/text/bidi-embedding-pop-and-push-same-expected.checksum:
* platform/mac/fast/text/bidi-embedding-pop-and-push-same-expected.png:
* platform/mac/fast/text/bidi-embedding-pop-and-push-same-expected.txt:
* platform/mac/fast/text/capitalize-boundaries-expected.checksum:
* platform/mac/fast/text/capitalize-boundaries-expected.png:
* platform/mac/fast/text/capitalize-boundaries-expected.txt:
* platform/mac/fast/text/cg-fallback-bolding-expected.checksum:
* platform/mac/fast/text/cg-fallback-bolding-expected.png:
* platform/mac/fast/text/cg-fallback-bolding-expected.txt:
* platform/mac/fast/text/complex-text-opacity-expected.checksum:
* platform/mac/fast/text/complex-text-opacity-expected.png:
* platform/mac/fast/text/complex-text-opacity-expected.txt:
* platform/mac/fast/text/in-rendered-text-rtl-expected.checksum:
* platform/mac/fast/text/in-rendered-text-rtl-expected.png:
* platform/mac/fast/text/in-rendered-text-rtl-expected.txt:
* platform/mac/fast/text/international/001-expected.checksum:
* platform/mac/fast/text/international/001-expected.png:
* platform/mac/fast/text/international/001-expected.txt:
* platform/mac/fast/text/international/002-expected.checksum:
* platform/mac/fast/text/international/002-expected.png:
* platform/mac/fast/text/international/002-expected.txt:
* platform/mac/fast/text/international/003-expected.checksum:
* platform/mac/fast/text/international/003-expected.png:
* platform/mac/fast/text/international/003-expected.txt:
* platform/mac/fast/text/international/bidi-AN-after-L-expected.checksum:
* platform/mac/fast/text/international/bidi-AN-after-L-expected.png:
* platform/mac/fast/text/international/bidi-AN-after-L-expected.txt:
* platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.checksum:
* platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.png:
* platform/mac/fast/text/international/bidi-AN-after-empty-run-expected.txt:
* platform/mac/fast/text/international/bidi-CS-after-AN-expected.checksum:
* platform/mac/fast/text/international/bidi-CS-after-AN-expected.png:
* platform/mac/fast/text/international/bidi-CS-after-AN-expected.txt:
* platform/mac/fast/text/international/bidi-L2-run-reordering-expected.checksum:
* platform/mac/fast/text/international/bidi-L2-run-reordering-expected.png:
* platform/mac/fast/text/international/bidi-L2-run-reordering-expected.txt:
* platform/mac/fast/text/international/bidi-LDB-2-CSS-expected.checksum:
* platform/mac/fast/text/international/bidi-LDB-2-CSS-expected.png:
* platform/mac/fast/text/international/bidi-LDB-2-CSS-expected.txt:
* platform/mac/fast/text/international/bidi-LDB-2-HTML-expected.checksum:
* platform/mac/fast/text/international/bidi-LDB-2-HTML-expected.png:
* platform/mac/fast/text/international/bidi-LDB-2-HTML-expected.txt:
* platform/mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.checksum:
* platform/mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.png:
* platform/mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
* platform/mac/fast/text/international/bidi-european-terminators-expected.checksum:
* platform/mac/fast/text/international/bidi-european-terminators-expected.png:
* platform/mac/fast/text/international/bidi-european-terminators-expected.txt:
* platform/mac/fast/text/international/bidi-fallback-font-weight-expected.checksum:
* platform/mac/fast/text/international/bidi-fallback-font-weight-expected.png:
* platform/mac/fast/text/international/bidi-fallback-font-weight-expected.txt:
* platform/mac/fast/text/international/bidi-ignored-for-first-child-inline-expected.checksum:
* platform/mac/fast/text/international/bidi-ignored-for-first-child-inline-expected.png:
* platform/mac/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt:
* platform/mac/fast/text/international/bidi-innertext-expected.checksum:
* platform/mac/fast/text/international/bidi-innertext-expected.png:
* platform/mac/fast/text/international/bidi-innertext-expected.txt:
* platform/mac/fast/text/international/bidi-linebreak-001-expected.checksum:
* platform/mac/fast/text/international/bidi-linebreak-001-expected.png:
* platform/mac/fast/text/international/bidi-linebreak-001-expected.txt:
* platform/mac/fast/text/international/bidi-linebreak-002-expected.checksum:
* platform/mac/fast/text/international/bidi-linebreak-002-expected.png:
* platform/mac/fast/text/international/bidi-linebreak-002-expected.txt:
* platform/mac/fast/text/international/bidi-linebreak-003-expected.checksum:
* platform/mac/fast/text/international/bidi-linebreak-003-expected.png:
* platform/mac/fast/text/international/bidi-linebreak-003-expected.txt:
* platform/mac/fast/text/international/bidi-listbox-atsui-expected.checksum:
* platform/mac/fast/text/international/bidi-listbox-atsui-expected.png:
* platform/mac/fast/text/international/bidi-listbox-atsui-expected.txt:
* platform/mac/fast/text/international/bidi-listbox-expected.checksum:
* platform/mac/fast/text/international/bidi-listbox-expected.png:
* platform/mac/fast/text/international/bidi-listbox-expected.txt:
* platform/mac/fast/text/international/bidi-menulist-expected.checksum:
* platform/mac/fast/text/international/bidi-menulist-expected.png:
* platform/mac/fast/text/international/bidi-menulist-expected.txt:
* platform/mac/fast/text/international/bidi-mirror-he-ar-expected.checksum:
* platform/mac/fast/text/international/bidi-mirror-he-ar-expected.png:
* platform/mac/fast/text/international/bidi-mirror-he-ar-expected.txt:
* platform/mac/fast/text/international/bidi-neutral-run-expected.checksum:
* platform/mac/fast/text/international/bidi-neutral-run-expected.png:
* platform/mac/fast/text/international/bidi-neutral-run-expected.txt:
* platform/mac/fast/text/international/bidi-override-expected.checksum:
* platform/mac/fast/text/international/bidi-override-expected.png:
* platform/mac/fast/text/international/bidi-override-expected.txt:
* platform/mac/fast/text/international/danda-space-expected.checksum:
* platform/mac/fast/text/international/danda-space-expected.png:
* platform/mac/fast/text/international/danda-space-expected.txt:
* platform/mac/fast/text/international/hebrew-vowels-expected.checksum:
* platform/mac/fast/text/international/hebrew-vowels-expected.png:
* platform/mac/fast/text/international/hebrew-vowels-expected.txt:
* platform/mac/fast/text/international/hindi-spacing-expected.checksum:
* platform/mac/fast/text/international/hindi-spacing-expected.png:
* platform/mac/fast/text/international/hindi-spacing-expected.txt:
* platform/mac/fast/text/international/hindi-whitespace-expected.checksum:
* platform/mac/fast/text/international/hindi-whitespace-expected.png:
* platform/mac/fast/text/international/hindi-whitespace-expected.txt:
* platform/mac/fast/text/international/plane2-expected.checksum:
* platform/mac/fast/text/international/plane2-expected.png:
* platform/mac/fast/text/international/plane2-expected.txt:
* platform/mac/fast/text/international/rtl-caret-expected.checksum:
* platform/mac/fast/text/international/rtl-caret-expected.png:
* platform/mac/fast/text/international/rtl-caret-expected.txt:
* platform/mac/fast/text/international/thai-baht-space-expected.checksum:
* platform/mac/fast/text/international/thai-baht-space-expected.png:
* platform/mac/fast/text/international/thai-baht-space-expected.txt:
* platform/mac/fast/text/international/thai-line-breaks-expected.checksum:
* platform/mac/fast/text/international/thai-line-breaks-expected.png:
* platform/mac/fast/text/international/thai-line-breaks-expected.txt:
* platform/mac/fast/text/international/wrap-CJK-001-expected.checksum:
* platform/mac/fast/text/international/wrap-CJK-001-expected.png:
* platform/mac/fast/text/international/wrap-CJK-001-expected.txt:
* platform/mac/mathml/presentation/attributes-expected.checksum:
* platform/mac/mathml/presentation/attributes-expected.png:
* platform/mac/mathml/presentation/attributes-expected.txt:
* platform/mac/mathml/presentation/fractions-expected.checksum:
* platform/mac/mathml/presentation/fractions-expected.png:
* platform/mac/mathml/presentation/fractions-expected.txt:
* platform/mac/mathml/presentation/fractions-vertical-alignment-expected.checksum:
* platform/mac/mathml/presentation/fractions-vertical-alignment-expected.png:
* platform/mac/mathml/presentation/fractions-vertical-alignment-expected.txt:
* platform/mac/mathml/presentation/mo-expected.checksum:
* platform/mac/mathml/presentation/mo-expected.png:
* platform/mac/mathml/presentation/mo-expected.txt:
* platform/mac/mathml/presentation/over-expected.checksum:
* platform/mac/mathml/presentation/over-expected.png:
* platform/mac/mathml/presentation/over-expected.txt:
* platform/mac/mathml/presentation/roots-expected.checksum:
* platform/mac/mathml/presentation/roots-expected.png:
* platform/mac/mathml/presentation/roots-expected.txt:
* platform/mac/mathml/presentation/row-alignment-expected.checksum:
* platform/mac/mathml/presentation/row-alignment-expected.png:
* platform/mac/mathml/presentation/row-alignment-expected.txt:
* platform/mac/mathml/presentation/row-expected.txt:
* platform/mac/mathml/presentation/style-expected.txt:
* platform/mac/mathml/presentation/sub-expected.txt:
* platform/mac/mathml/presentation/subsup-expected.txt:
* platform/mac/mathml/presentation/sup-expected.checksum:
* platform/mac/mathml/presentation/sup-expected.png:
* platform/mac/mathml/presentation/sup-expected.txt:
* platform/mac/mathml/presentation/tables-expected.checksum:
* platform/mac/mathml/presentation/tables-expected.png:
* platform/mac/mathml/presentation/tables-expected.txt:
* platform/mac/mathml/presentation/tokenElements-expected.txt:
* platform/mac/mathml/presentation/under-expected.checksum:
* platform/mac/mathml/presentation/under-expected.png:
* platform/mac/mathml/presentation/under-expected.txt:
* platform/mac/mathml/presentation/underover-expected.checksum:
* platform/mac/mathml/presentation/underover-expected.png:
* platform/mac/mathml/presentation/underover-expected.txt:
* platform/mac/mathml/xHeight-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72173
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Wed, 17 Nov 2010 05:56:42 +0000 (05:56 +0000)]
2010-11-15 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Darin Adler.
ScriptElementData should be a private member of ScriptElement
https://bugs.webkit.org/show_bug.cgi?id=49578
Privatized m_data of ScriptElement. Added haveFiredLoadEvent, setHaveFiredLoadEvent, createdByParser,
and isEvaluated to ScriptElement to proxy calls from HTMLScriptElement and SVGScriptElement to ScriptElementData.
No tests are added since this is a cleanup.
* dom/ScriptElement.h:
(WebCore::ScriptElement::haveFiredLoadEvent): Added.
(WebCore::ScriptElement::setHaveFiredLoadEvent): Added.
(WebCore::ScriptElement::createdByParser): Added.
(WebCore::ScriptElement::isEvaluated): Added.
* html/HTMLScriptElement.cpp:
(WebCore::HTMLScriptElement::dispatchLoadEvent): Calls haveFiredLoadEvent and setHaveFiredLoadEvent.
(WebCore::HTMLScriptElement::cloneElementWithoutAttributesAndChildren): Calls isEvaluated.
* html/HTMLScriptElement.h:
(WebCore::HTMLScriptElement::text): Calls scriptContent.
(WebCore::HTMLScriptElement::haveFiredLoadEvent): Calls haveFiredLoadEvent.
* svg/SVGScriptElement.cpp:
(WebCore::SVGScriptElement::svgAttributeChanged): Calls haveFiredLoadEvent and createdByParser.
(WebCore::SVGScriptElement::insertedIntoDocument): Calls createdByParser.
(WebCore::SVGScriptElement::finishParsingChildren): Calls setHaveFiredLoadEvent.
(WebCore::SVGScriptElement::haveLoadedRequiredResources): Ditto.
(WebCore::SVGScriptElement::dispatchLoadEvent): Calls haveFiredLoadEvent.
(WebCore::SVGScriptElement::cloneElementWithoutAttributesAndChildren): Calls createdByParser,
haveFiredLoadEvent, and setHaveFiredLoadEvent.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72172
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Wed, 17 Nov 2010 04:52:02 +0000 (04:52 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=49320
Minor ResourceLoadScheduler cleanups
Reviewed by Darin Adler.
* loader/ResourceLoadScheduler.cpp:
(WebCore::ResourceLoadScheduler::scheduleLoad):
(WebCore::ResourceLoadScheduler::servePendingRequests):
(WebCore::ResourceLoadScheduler::HostInformation::~HostInformation):
(WebCore::ResourceLoadScheduler::HostInformation::remove):
(WebCore::ResourceLoadScheduler::HostInformation::hasRequests):
* loader/ResourceLoadScheduler.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72171
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Wed, 17 Nov 2010 04:13:06 +0000 (04:13 +0000)]
Add a baselineType member to RootInlineBox that caches whether the default baseline behavior for that
line should be ideographic or alphabetic. Add a requiresIdeographicsBaseline recursive function to
InlineFlowBox that scans for the use of any vertical fonts.
Reviewed by Sam Weinig.
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::requiresIdeographicBaseline):
* rendering/InlineFlowBox.h:
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::RootInlineBox):
(WebCore::RootInlineBox::alignBoxesInBlockDirection):
* rendering/RootInlineBox.h:
(WebCore::RootInlineBox::baselineType):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72168
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Wed, 17 Nov 2010 03:35:01 +0000 (03:35 +0000)]
Update WebKit2 skipped list.
Rubber-stamped by Jon Honeycutt.
* platform/mac-wk2/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72167
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Wed, 17 Nov 2010 03:24:52 +0000 (03:24 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=31223
Make primitive values immutable.
Patch by Antti Koivisto <koivisto@iki.fi> on 2010-11-16
Reviewed by Adam Barth.
Update test cases for behavior change and test computed style too. Note that there are some
failures in the results demonstrating unrelated bugs in CSSPrimitiveValues.
* fast/dom/script-tests/setPrimitiveValue-exceptions.js:
(checkThrows):
* fast/dom/setPrimitiveValue.html:
* fast/dom/setPrimitiveValue-exceptions-expected.txt
* fast/dom/setPrimitiveValue-expected.txt
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72166
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Wed, 17 Nov 2010 03:24:39 +0000 (03:24 +0000)]
Add FontBaseline.h and make ascent and descent take a baseline parameter so that both an
alphabetic and ideographic baseline can be requested.
Reviewed by Sam Weinig.
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/Font.h:
(WebCore::Font::ascent):
(WebCore::Font::descent):
* platform/graphics/FontBaseline.h: Added.
* platform/graphics/SimpleFontData.h:
(WebCore::SimpleFontData::ascent):
(WebCore::SimpleFontData::descent):
(WebCore::SimpleFontData::height):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72165
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Wed, 17 Nov 2010 03:20:32 +0000 (03:20 +0000)]
Make sure the pref for minimum font size is just explicitly set to 0 every time,
since the bots have 1 stuck in their plist otherwise.
Reviewed by Sam Weinig.
* DumpRenderTree/mac/DumpRenderTree.mm:
(resetDefaultsToConsistentValues):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72164
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Wed, 17 Nov 2010 03:15:47 +0000 (03:15 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=31223
Make primitive values immutable.
Patch by Antti Koivisto <koivisto@iki.fi> on 2010-11-16
Reviewed by Adam Barth.
Make CSSPrimitiveValue setFloatValue and setStringValue always throw NO_MODIFICATION_ALLOWED exception.
Reasoning:
- these setters never worked correctly, style was not invalidated so changing values would have no effect on rendering
- computed style is immutable in all cases, and it wasn't
- no other engine seems to support mutable primitives, as a result there is no content using these APIs
- mutable primitive values are pointless, the usual way to change the value of a propertly is to replace it with a new value
- allowing mutation of primitive values makes optimizations harder
* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::setFloatValue):
(WebCore::CSSPrimitiveValue::setStringValue):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72163
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Wed, 17 Nov 2010 03:13:27 +0000 (03:13 +0000)]
WebKit2: Support enabling site-specific quirks
<rdar://problem/
8451371>
https://bugs.webkit.org/show_bug.cgi?id=46076
Reviewed by Adam Roben.
* Shared/WebPreferencesStore.cpp:
(WebKit::WebPreferencesStore::WebPreferencesStore):
(WebKit::WebPreferencesStore::encode):
(WebKit::WebPreferencesStore::decode):
* Shared/WebPreferencesStore.h:
Add needsSiteSpecificQuirks;
* UIProcess/API/C/WKAPICast.h:
(WebKit::toFontSmoothingLevel):
(WebKit::toAPI):
Move FontSmoothing conversion functions here.
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetFontSmoothingLevel):
(WKPreferencesGetFontSmoothingLevel):
(WKPreferencesSetAcceleratedCompositingEnabled):
(WKPreferencesGetAcceleratedCompositingEnabled):
(WKPreferencesSetCompositingBordersVisible):
(WKPreferencesGetCompositingBordersVisible):
(WKPreferencesSetCompositingRepaintCountersVisible):
(WKPreferencesGetCompositingRepaintCountersVisible):
(WKPreferencesSetNeedsSiteSpecificQuirks):
(WKPreferencesGetNeedsSiteSpecificQuirks):
Add WKPreferencesSetNeedsSiteSpecificQuirks/WKPreferencesGetNeedsSiteSpecificQuirks
and move implementations from WKPreferencesPrivate.cpp here.
* UIProcess/API/C/WKPreferencesPrivate.cpp: Removed.
* UIProcess/API/C/WKPreferencesPrivate.h:
Add Add WKPreferencesSetNeedsSiteSpecificQuirks/WKPreferencesGetNeedsSiteSpecificQuirks.
* UIProcess/WebPreferences.cpp:
(WebKit::WebPreferences::setNeedsSiteSpecificQuirks):
(WebKit::WebPreferences::needsSiteSpecificQuirks):
* UIProcess/WebPreferences.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
Pipe through needsSiteSpecificQuirks.
* WebKit2.xcodeproj/project.pbxproj:
* WebKit2.pro:
* win/WebKit2.vcproj:
Update for removed files.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72162
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Wed, 17 Nov 2010 03:11:17 +0000 (03:11 +0000)]
Update SVG layout test.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72161
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Wed, 17 Nov 2010 03:03:34 +0000 (03:03 +0000)]
Bug 49635 - Profiler implementation is fragile
Reviewed by Sam Weinig.
The profile presently requires the exception handling mechanism to explicitly
remove all stack frames that are exited during the exception unwind mechanism.
This is fragile in a number of ways:
* We have to change bytecode register allocation when compiling code to run
when profiling, to preserve the callee function (this is also required to
call did_call after the call has returned).
* In the JIT we have to maintain additional data structures
(CodeBlock::RareData::m_functionRegisterInfos) to map back to the register
containing the callee.
* In the interpreter we use 'magic values' to offset into the instruction
stream to rediscover the register containing the function.
Instead, move profiling into the head and tail of functions.
* This correctly accounts the cost of the call itself to the caller.
* This allows us to access the callee function object from the callframe.
* This means that at the point a call is made we can track the stack depth
on the ProfileNode.
* When unwinding we can simply report the depth at which the exception is
being handled - all call frames above this level are freed.
* JavaScriptCore.xcodeproj/project.pbxproj:
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
(JSC::CodeBlock::shrinkToFit):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::bytecodeOffset):
(JSC::CodeBlock::methodCallLinkInfo):
* bytecode/Opcode.h:
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitCallVarargs):
(JSC::BytecodeGenerator::emitReturn):
(JSC::BytecodeGenerator::emitConstruct):
* bytecompiler/BytecodeGenerator.h:
(JSC::CallArguments::count):
* bytecompiler/NodesCodegen.cpp:
(JSC::CallArguments::CallArguments):
* interpreter/Interpreter.cpp:
(JSC::ProfileHostCall::ProfileHostCall):
(JSC::ProfileHostCall::~ProfileHostCall):
(JSC::Interpreter::unwindCallFrame):
(JSC::Interpreter::throwException):
(JSC::Interpreter::execute):
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::privateExecute):
* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
* jit/JIT.h:
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_profile_has_called):
(JSC::JIT::emit_op_profile_will_return):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_profile_has_called):
(JSC::JIT::emit_op_profile_will_return):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* jit/JITStubs.h:
* profiler/Profile.cpp:
(JSC::Profile::Profile):
* profiler/ProfileGenerator.cpp:
(JSC::ProfileGenerator::addParentForConsoleStart):
(JSC::ProfileGenerator::willExecute):
(JSC::ProfileGenerator::didExecute):
(JSC::ProfileGenerator::exceptionUnwind):
(JSC::ProfileGenerator::stopProfiling):
* profiler/ProfileGenerator.h:
* profiler/ProfileNode.cpp:
(JSC::ProfileNode::ProfileNode):
(JSC::ProfileNode::willExecute):
* profiler/ProfileNode.h:
(JSC::ProfileNode::create):
(JSC::ProfileNode::operator==):
(JSC::ProfileNode::exec):
* profiler/Profiler.cpp:
(JSC::dispatchFunctionToProfiles):
(JSC::Profiler::hasCalled):
(JSC::Profiler::willEvaluate):
(JSC::Profiler::willReturn):
(JSC::Profiler::didEvaluate):
(JSC::Profiler::exceptionUnwind):
* profiler/Profiler.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72160
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bweinstein@apple.com [Wed, 17 Nov 2010 02:58:01 +0000 (02:58 +0000)]
Touch Platform.h to force a rebuild for Windows.
Reviewed by Adam Roben and Steve Falkenburg.
* wtf/Platform.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72159
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Wed, 17 Nov 2010 02:39:32 +0000 (02:39 +0000)]
Force a clean build for Windows projects using precompiled headers. Unreviewed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72158
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Wed, 17 Nov 2010 02:37:28 +0000 (02:37 +0000)]
2010-11-16 Mihai Parparita <mihaip@chromium.org>
Reviewed by Tony Chang.
Rebaseline server: display test results
https://bugs.webkit.org/show_bug.cgi?id=49626
Adds basic result display to the rebaseline server. On the Python side
this involves:
- Parsing the unexpected_results.json into a dictionary.
- Serving it as JSON under /results.json.
(the JSON -> dict -> JSON transform isn't strictly necessary right now,
but I'll need to have access to the parsed results on the Python side
for follow-up changes).
On the web UI side this adds:
- Markup for display image and text results (expected, actual, diff),
and JS for populating it.
- Markup for breaking down test results by failure type and directory,
and JS for populating it.
* Scripts/webkitpy/tool/commands/data/rebaselineserver/index.html:
* Scripts/webkitpy/tool/commands/data/rebaselineserver/main.css:
* Scripts/webkitpy/tool/commands/data/rebaselineserver/main.js:
* Scripts/webkitpy/tool/commands/data/rebaselineserver/util.js: Added.
* Scripts/webkitpy/tool/commands/rebaselineserver.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72157
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Wed, 17 Nov 2010 02:24:42 +0000 (02:24 +0000)]
2010-11-16 Dirk Pranke <dpranke@chromium.org>
Reviewed by Ojan Vafai.
See Chromium issue http://codereview.chromium.org/
5133001/ - we
are modifying the build bots to pass in the builder name with
the "GPU" string appended instead of appending it in the code.
https://bugs.webkit.org/show_bug.cgi?id=49636
* Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72156
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Wed, 17 Nov 2010 02:21:51 +0000 (02:21 +0000)]
Fix horizontal scrolling via the mousewheel/trackpad on Windows
Reviewed by Mark Rowe.
* Shared/win/WebEventFactory.cpp: Fixed typo in the
WM_VISTA_MOUSEHWHEEL constant.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72155
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Wed, 17 Nov 2010 02:20:10 +0000 (02:20 +0000)]
2010-11-16 Mihai Parparita <mihaip@chromium.org>
Update the pixel expectations for fast/reflections, fast/replaced, fast/ruby, fast/runin, and fast/text for the Mac port.
For the tests that currently fail on Snow Leopard with --pixel-tests
--tolerance 0, this moves the current pixel results to mac-leopard and
adds new Snow Leopard-specific results to platform/mac.
List of files omitted due to length but composed entirely of moves from
platform/mac to platform/mac-leopard and newly added files in
platform/mac.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72154
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Wed, 17 Nov 2010 01:49:24 +0000 (01:49 +0000)]
2010-11-16 Mihai Parparita <mihaip@chromium.org>
Update the pixel expectations for fast/html, fast/images, fast/innerHTML, fast/inspector-support, fast/loader, fast/media, fast/multicol, and fast/parser for the Mac port.
For the tests that currently fail on Snow Leopard with --pixel-tests
--tolerance 0, this moves the current pixel results to mac-leopard and
adds new Snow Leopard-specific results to platform/mac.
List of files omitted due to length but composed entirely of moves from
platform/mac to platform/mac-leopard and newly added files in
platform/mac.
Also includes updated baselines for fast/forms after r72052 changed how
placeholders are rendered.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72153
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Wed, 17 Nov 2010 01:03:34 +0000 (01:03 +0000)]
2010-11-16 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam Roben.
Disable LTCG for Windows Release builds. Add new Release_LTCG configuration.
https://bugs.webkit.org/show_bug.cgi?id=49632
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.vcproj/WTF/WTF.vcproj:
* JavaScriptCore.vcproj/jsc/jsc.vcproj:
* JavaScriptCore.vcproj/testapi/testapi.vcproj:
2010-11-16 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam Roben.
Disable LTCG for Windows Release builds. Add new Release_LTCG configuration.
https://bugs.webkit.org/show_bug.cgi?id=49632
* WebKit.vcproj/Interfaces.vcproj:
* WebKit.vcproj/WebKit.make:
* WebKit.vcproj/WebKit.sln:
* WebKit.vcproj/WebKit.submit.sln:
* WebKit.vcproj/WebKit.vcproj:
* WebKit.vcproj/WebKitGUID.vcproj:
2010-11-16 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam Roben.
Disable LTCG for Windows Release builds. Add new Release_LTCG configuration.
https://bugs.webkit.org/show_bug.cgi?id=49632
* WebCore.vcproj/QTMovieWin.vcproj:
* WebCore.vcproj/WebCore.make:
* WebCore.vcproj/WebCore.sln:
* WebCore.vcproj/WebCore.vcproj:
2010-11-16 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam Roben.
Disable LTCG for Windows Release builds. Add new Release_LTCG configuration.
https://bugs.webkit.org/show_bug.cgi?id=49632
* DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
* DumpRenderTree/win/DumpRenderTree.vcproj:
* DumpRenderTree/win/ImageDiff.vcproj:
* MiniBrowser/MiniBrowser.vcproj:
* TestWebKitAPI/win/TestWebKitAPI.vcproj:
* WebKitLauncherWin/WebKitLauncherWin.vcproj:
* WebKitTestRunner/win/InjectedBundle.vcproj:
* WebKitTestRunner/win/WebKitTestRunner.vcproj:
* WinLauncher/WinLauncher.vcproj:
* record-memory-win/record-memory-win.vcproj:
2010-11-16 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam Roben.
Disable LTCG for Windows Release builds. Add new Release_LTCG configuration.
https://bugs.webkit.org/show_bug.cgi?id=49632
* win/WebKit2.make:
* win/WebKit2.submit.sln:
* win/WebKit2.vcproj:
* win/WebKit2WebProcess.vcproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72152
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Wed, 17 Nov 2010 01:02:40 +0000 (01:02 +0000)]
Versioning.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72151
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Wed, 17 Nov 2010 00:36:06 +0000 (00:36 +0000)]
2010-11-16 Dirk Pranke <dpranke@chromium.org>
Reviewed by Ojan Vafai.
new-run-webkit-tests: rename TestInfo to TestInput, move image hash to work thread
Rename the TestInfo class to TestInput to be clearer about its
function, and move the checksum-reading code into dump_render_tree_thread
to avoid cross-thread access.
https://bugs.webkit.org/show_bug.cgi?id=49573
* Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72149
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 17 Nov 2010 00:19:25 +0000 (00:19 +0000)]
Handle converting a ResourceHandle to a download
https://bugs.webkit.org/show_bug.cgi?id=49631
Reviewed by Sam Weinig.
* WebProcess/Downloads/Download.h:
Add startWithHandle.
* WebProcess/Downloads/DownloadManager.h:
* WebProcess/Downloads/DownloadManager.cpp:
(WebKit::DownloadManager::convertHandleToDownload):
Create a new Download object and call startWithHandle on it.
* WebProcess/Downloads/cf/DownloadCFNet.cpp:
(WebKit::Download::startWithHandle):
Add stub.
* WebProcess/Downloads/mac/DownloadMac.mm:
(WebKit::Download::startWithHandle):
Create an NSURLDownload object from passed in ResourceHandle.
* WebProcess/Downloads/qt/DownloadQt.cpp:
(WebKit::Download::startWithHandle):
Add stub.
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::download):
Call WebFrame::convertHandleToDownload.
* WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::convertHandleToDownload):
Call DownloadManager::convertHandleToDownload.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72148
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Wed, 17 Nov 2010 00:18:04 +0000 (00:18 +0000)]
Fix bustage. Remove the minimum font size pref setting in DumpRenderTree.
* DumpRenderTree/mac/DumpRenderTree.mm:
(resetDefaultsToConsistentValues):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72147
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
slewis@apple.com [Tue, 16 Nov 2010 23:54:36 +0000 (23:54 +0000)]
<rdar://problem/
8624267> Leak creating offscreen webview running fast/dom tests
Reviewed by Geoff Garen.
WebKit/mac:
Make a static provider for WebDeviceOrientationProviderMock. The old code allocated a new WebDeviceOrientationProviderMock for
every WebView, and the WebKit API doesn't support that ownership model.
* WebView/WebDeviceOrientationProviderMock.h:
* WebView/WebDeviceOrientationProviderMock.mm:
(+[WebDeviceOrientationProviderMock shared]):
WebKitTools:
Use shared DeviceOrientationProviderMock. The old allocation method created a new WebDeviceOrientationProviderMock
for every WebView, and the WebKit API doesn't support that ownership model.
I also fixed a leak in setMockDeviceOrientation by adding a missing release.
* DumpRenderTree/mac/DumpRenderTree.mm:
(createWebViewAndOffscreenWindow):
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::setMockDeviceOrientation):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72146
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 16 Nov 2010 23:52:41 +0000 (23:52 +0000)]
Set the original URL for downloads
https://bugs.webkit.org/show_bug.cgi?id=49628
Reviewed by John Sullivan.
WebCore:
Export symbols needed by WebKit2.
* WebCore.exp.in:
WebKit2:
* WebProcess/Downloads/DownloadManager.cpp:
(WebKit::DownloadManager::startDownload):
* WebProcess/Downloads/DownloadManager.h:
startDownload now takes the originating web page.
* WebProcess/Downloads/cf/DownloadCFNet.cpp:
(WebKit::Download::start):
start now takes the originating web page.
* WebProcess/Downloads/mac/DownloadMac.mm:
(WebKit::originatingURL):
(WebKit::setOriginalURLForDownload):
Port code over from WebKit1 that sets the download URL.
(WebKit::Download::start):
Call setOriginalURLForDownload.
* WebProcess/Downloads/qt/DownloadQt.cpp:
(WebKit::Download::start):
start now takes the originating web page.
* WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::startDownload):
Pass the web page to DownloadManager::startDownload.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72145
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dpranke@chromium.org [Tue, 16 Nov 2010 23:32:21 +0000 (23:32 +0000)]
2010-11-16 Dirk Pranke <dpranke@chromium.org>
Reviewed by Ojan Vafai.
new-run-webkit-tests: log the process id in --verbose mode
As part of the switch to multi-process mode, we should log the
process id when running w/ --verbose.
https://bugs.webkit.org/show_bug.cgi?id=49571
* Scripts/webkitpy/layout_tests/layout_package/printing.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72143
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Tue, 16 Nov 2010 23:28:53 +0000 (23:28 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=11004
Reviewed by Dan Bernstein.
font-size:0 is ignored. Remove the minimum font size of 1 in CSSStyleSelector.
Change the pref value for minimum font size from 1 to 0. Make sure to never use the NSFont's size,
since it doesn't honor a size of 0. Instead pass the size in to the FontPlatformData(NSFont*) version
of the constructor rather than using [NSFont pointSize].
https://bugs.webkit.org/show_bug.cgi?id=49582
Negative leading is not handled correctly. There are two bugs here. The first is that
maxAscent and maxDescent can be negative, so we need a notion of whether or not we have
set them before so that we can allow them to be < 0.
The second issue is that we should understand where fonts will end up relative to
our baseline (excluding line height), and only allow those boxes to impact ascent and
descent if the actual font box (without factoring in line height) is above or below the
root line box baseline.
Added fast/css/negative-leading.html
These two bug fixes have to land together to keep the Acid 3 test rendering correctly.
WebCore:
* WebCore.exp.in:
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::getComputedSizeFromSpecifiedSize):
* platform/graphics/cocoa/FontPlatformData.h:
* platform/graphics/cocoa/FontPlatformDataCocoa.mm:
(WebCore::FontPlatformData::FontPlatformData):
* platform/graphics/mac/FontCacheMac.mm:
(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::createFontPlatformData):
* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::smallCapsFontData):
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::computeLogicalBoxHeights):
* rendering/InlineFlowBox.h:
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::alignBoxesInBlockDirection):
WebKit/mac:
* Misc/WebKitNSStringExtras.mm:
(-[NSString _web_drawAtPoint:font:textColor:allowingFontSmoothing:]):
(-[NSString _web_widthWithFont:]):
* Misc/WebStringTruncator.mm:
(fontFromNSFont):
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
WebKit/win:
* WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings):
WebKit2:
* Shared/WebPreferencesStore.cpp:
(WebKit::WebPreferencesStore::WebPreferencesStore):
LayoutTests:
* fast/css/negative-leading.html: Added.
* platform/mac/fast/compact/001-expected.checksum:
* platform/mac/fast/compact/001-expected.png:
* platform/mac/fast/compact/001-expected.txt:
* platform/mac/fast/css/negative-leading-expected.checksum: Added.
* platform/mac/fast/css/negative-leading-expected.png: Added.
* platform/mac/fast/css/negative-leading-expected.txt: Added.
* platform/mac/fast/forms/linebox-overflow-in-textarea-padding-expected.checksum:
* platform/mac/fast/forms/linebox-overflow-in-textarea-padding-expected.png:
* platform/mac/fast/forms/linebox-overflow-in-textarea-padding-expected.txt:
* platform/mac/fast/parser/style-script-head-test-expected.png:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72141
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 16 Nov 2010 23:27:13 +0000 (23:27 +0000)]
2010-11-16 Peter Varga <pvarga@inf.u-szeged.hu>
Reviewed by Gavin Barraclough.
The number of recursive match calls isn't limited in YARR Interpreter
https://bugs.webkit.org/show_bug.cgi?id=47906
Check the number of the matchDisjunction recursive calls to avoid unbounded
recursion.
Now the matchDisjunction function returns JSRegExpResult instead of bool.
The JSRegExpResult enum contains the result of matching or the error code
of the failure (like HitLimit) which terminates the matching.
The error codes are based on pcre's jsRegExpExecute error codes.
* yarr/RegexInterpreter.cpp:
(JSC::Yarr::Interpreter::parenthesesDoBacktrack):
(JSC::Yarr::Interpreter::matchParentheses):
(JSC::Yarr::Interpreter::backtrackParentheses):
(JSC::Yarr::Interpreter::matchDisjunction):
(JSC::Yarr::Interpreter::matchNonZeroDisjunction):
(JSC::Yarr::Interpreter::interpret):
(JSC::Yarr::Interpreter::Interpreter):
* yarr/RegexInterpreter.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72140
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Tue, 16 Nov 2010 22:55:17 +0000 (22:55 +0000)]
Removed lines for tests that are now passing after r72137.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72138
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Tue, 16 Nov 2010 22:51:22 +0000 (22:51 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=49611
REGRESSION (r72115): 5 layout tests are broken
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadFrameRequest): Roll change from
https://bugs.webkit.org/show_bug.cgi?id=48603 out. I'll roll
it back in after fixing the failing tests.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72137
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Tue, 16 Nov 2010 22:43:06 +0000 (22:43 +0000)]
2010-11-16 Steve Falkenburg <sfalken@apple.com>
Reviewed by Adam Roben.
Use vsprops files for common settings in Windows WebKit
https://bugs.webkit.org/show_bug.cgi?id=49622
* WebKit.vcproj/WebKit.vcproj:
* WebKit.vcproj/WebKitCommon.vsprops: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72136
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Tue, 16 Nov 2010 22:08:26 +0000 (22:08 +0000)]
<rdar://problem/
8672000> REGRESSION (r72040): Error image with alt text can cause style to be frozen in a subtree
https://bugs.webkit.org/show_bug.cgi?id=49579
Reviewed by Simon Fraser.
WebCore:
r72040 introduced a call to setNeedsStyleRecalc() from RenderImage::imageChanged(). When imageChanged()
got called beneath recalcStyle() on some ancestor element, the result was that the ancestor’s
childNeedsStyleRecalc flag got cleared, but its descendants all the way down to the image did not.
Thereafter, setNeedsStyleRecalc() would fail to propagate from that subtree up to the root. The fix
is to avoid the newly-added setNeedsStyleRecalc() in most cases, including during reclacStyle(), and
just keep it for when it is needed.
Tests: fast/block/float/015.html
fast/images/style-access-during-imageChanged-style-freeze.html
* dom/Document.cpp:
(WebCore::Document::isPendingStyleRecalc): Added.
* dom/Document.h:
* rendering/RenderImage.cpp:
(WebCore::RenderImage::imageChanged): Only defer intrinsic size compoutation if a style recalc
is coming (indicating that current style() is stale).
LayoutTests:
* fast/block/float/015.html: Copied from LayoutTests/fast/block/float/015.html-disabled.
* fast/block/float/015.html-disabled: Removed.
* fast/images/style-access-during-imageChanged-style-freeze-expected.txt: Added.
* fast/images/style-access-during-imageChanged-style-freeze.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72135
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bweinstein@apple.com [Tue, 16 Nov 2010 21:56:46 +0000 (21:56 +0000)]
Rest of the Windows build fix.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72134
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Tue, 16 Nov 2010 21:44:22 +0000 (21:44 +0000)]
Unreviewed Chromium expectations update.
* platform/chromium/test_expectations.txt: Added
the failure expectations for 5 tests which are failing
due to r72115 (and filed bug 49620 about the issue).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72133
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Tue, 16 Nov 2010 21:41:52 +0000 (21:41 +0000)]
Windows build fix pt 1.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72132
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 16 Nov 2010 21:30:32 +0000 (21:30 +0000)]
Fix clang++ build.
* Scripts/webkit2/messages.py:
* WebProcess/WebPage/WebInspector.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72131
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zmo@google.com [Tue, 16 Nov 2010 21:23:41 +0000 (21:23 +0000)]
2010-11-11 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Implement UNPACK_COLORSPACE_CONVERSION_WEBGL
https://bugs.webkit.org/show_bug.cgi?id=47196
* src/WebImageDecoder.cpp:
(WebKit::WebImageDecoder::init): Add ignoreGammaAndColorProfile parameter.
2010-11-11 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Implement UNPACK_COLORSPACE_CONVERSION_WEBGL
https://bugs.webkit.org/show_bug.cgi?id=47196
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::texImage2DImpl): Apply UNPACK_COLORSPACE_CONVERSION settings to image uploading.
(WebCore::WebGLRenderingContext::texSubImage2DImpl): Ditto.
* platform/graphics/GraphicsContext3D.cpp:
(WebCore::GraphicsContext3D::extractImageData): Ditto.
* platform/graphics/GraphicsContext3D.h:
* platform/graphics/ImageSource.cpp:
(WebCore::ImageSource::ImageSource): Add ignoreGammaColorProfile parameter.
(WebCore::ImageSource::setData): Ditto.
* platform/graphics/ImageSource.h:
* platform/graphics/cg/GraphicsContext3DCG.cpp:
(WebCore::GraphicsContext3D::getImageData): Ditto.
* platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::ImageSource::ImageSource): Ditto.
* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3D::getImageData): Ditto.
* platform/graphics/qt/ImageDecoderQt.cpp:
(WebCore::ImageDecoder::create): Ditto.
(WebCore::ImageDecoderQt::ImageDecoderQt): Ditto.
* platform/graphics/qt/ImageDecoderQt.h:
* platform/graphics/skia/GraphicsContext3DSkia.cpp:
(WebCore::GraphicsContext3D::getImageData): Ditto.
* platform/image-decoders/ImageDecoder.cpp:
(WebCore::ImageDecoder::create): Ditto.
* platform/image-decoders/ImageDecoder.h:
(WebCore::ImageDecoder::ImageDecoder): Ditto.
* platform/image-decoders/bmp/BMPImageDecoder.cpp:
(WebCore::BMPImageDecoder::BMPImageDecoder):
* platform/image-decoders/bmp/BMPImageDecoder.h:
* platform/image-decoders/gif/GIFImageDecoder.cpp:
(WebCore::GIFImageDecoder::GIFImageDecoder): Ditto.
* platform/image-decoders/gif/GIFImageDecoder.h:
* platform/image-decoders/ico/ICOImageDecoder.cpp:
(WebCore::ICOImageDecoder::ICOImageDecoder): Ditto.
(WebCore::ICOImageDecoder::decodeAtIndex): Ditto.
* platform/image-decoders/ico/ICOImageDecoder.h:
* platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
(WebCore::JPEGImageDecoder::JPEGImageDecoder): Ditto.
* platform/image-decoders/jpeg/JPEGImageDecoder.h:
* platform/image-decoders/png/PNGImageDecoder.cpp:
(WebCore::PNGImageDecoder::PNGImageDecoder): Ditto.
(WebCore::PNGImageDecoder::headerAvailable): Ignore gamma settings if ignoreGammaAndColorProfile is true.
* platform/image-decoders/png/PNGImageDecoder.h:
* platform/image-decoders/webp/WEBPImageDecoder.cpp:
(WebCore::WEBPImageDecoder::WEBPImageDecoder): Add ignoreGammaAndColorProfile parameter.
* platform/image-decoders/webp/WEBPImageDecoder.h:
2010-11-11 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Implement UNPACK_COLORSPACE_CONVERSION_WEBGL
https://bugs.webkit.org/show_bug.cgi?id=47196
* fast/canvas/webgl/gl-teximage-expected.txt:
* fast/canvas/webgl/gl-teximage.html: Testing that if UNPACK_COLORSPACE_CONVERSION is NONE, gamma settings are not applied to images.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72130
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 16 Nov 2010 21:15:28 +0000 (21:15 +0000)]
Fix clang++ build.
* WebCoreSupport/WebFrameLoaderClient.mm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72129
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric.carlson@apple.com [Tue, 16 Nov 2010 21:12:58 +0000 (21:12 +0000)]
2010-11-16 Eric Carlson <eric.carlson@apple.com>
Unreviewed attempt to fix GTK build after http://trac.webkit.org/changeset/72117
* platform/graphics/MediaPlayer.cpp:
(WebCore::installedMediaEngines):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72128
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Tue, 16 Nov 2010 21:11:26 +0000 (21:11 +0000)]
JavaScriptCore: https://bugs.webkit.org/show_bug.cgi?id=49606
Reviewed by Oliver Hunt.
The bug here is that we read the prototype from the RHS argument using a regular
op_get_by_id before op_instanceof has checked that this is an object implementing
HasInstance. This incorrect behaviour gives rise to further unnecessary complexity
in the code base, since we have additional logic (implemented using the
GetByIdExceptionInfo data structures on CodeBlock) to convert not an object errors
from the get_by_id into invalid parameter errors. Having fixed this bug this code
is all redundant, since in these cases the get_by_id will never have been reached.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
(JSC::CodeBlock::shrinkToFit):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::addExpressionInfo):
* bytecode/Opcode.h:
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::emitCheckHasInstance):
* bytecompiler/BytecodeGenerator.h:
* bytecompiler/NodesCodegen.cpp:
(JSC::InstanceOfNode::emitBytecode):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::throwException):
(JSC::Interpreter::privateExecute):
* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):
* jit/JIT.h:
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_check_has_instance):
(JSC::JIT::emit_op_instanceof):
(JSC::JIT::emitSlow_op_check_has_instance):
(JSC::JIT::emitSlow_op_instanceof):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_check_has_instance):
(JSC::JIT::emit_op_instanceof):
(JSC::JIT::emitSlow_op_check_has_instance):
(JSC::JIT::emitSlow_op_instanceof):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* jit/JITStubs.h:
* runtime/ExceptionHelpers.cpp:
(JSC::createInterruptedExecutionException):
(JSC::createTerminatedExecutionException):
(JSC::createUndefinedVariableError):
(JSC::createNotAFunctionError):
(JSC::createNotAnObjectError):
* runtime/ExceptionHelpers.h:
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
* runtime/JSGlobalData.h:
* runtime/JSNotAnObject.cpp:
(JSC::JSNotAnObject::toPrimitive):
(JSC::JSNotAnObject::getPrimitiveNumber):
(JSC::JSNotAnObject::toBoolean):
(JSC::JSNotAnObject::toNumber):
(JSC::JSNotAnObject::toString):
(JSC::JSNotAnObject::toObject):
(JSC::JSNotAnObject::getOwnPropertySlot):
(JSC::JSNotAnObject::getOwnPropertyDescriptor):
(JSC::JSNotAnObject::put):
(JSC::JSNotAnObject::deleteProperty):
(JSC::JSNotAnObject::getOwnPropertyNames):
* runtime/JSNotAnObject.h:
(JSC::JSNotAnObject::JSNotAnObject):
* runtime/JSObject.h:
(JSC::JSObject::isActivationObject):
* runtime/JSValue.cpp:
(JSC::JSValue::toObjectSlowCase):
(JSC::JSValue::synthesizeObject):
(JSC::JSValue::synthesizePrototype):
LayoutTests: Bug 49606 - instanceof should only get the prototype property if the RHS operand implements HasInstance
Reviewed by Oliver Hunt.
* fast/js/instanceof-XMLHttpRequest-expected.txt: Copied from LayoutTests/fast/js/instanceof-operator-expected.txt.
* fast/js/instanceof-XMLHttpRequest.html: Copied from LayoutTests/fast/js/instanceof-operator.html.
* fast/js/script-tests/instanceof-XMLHttpRequest.js: Copied from LayoutTests/fast/js/script-tests/instanceof-operator.js.
- renamed existing testcase; these really test XMLHttpRequest objects, rather than the instanceof operator.
* fast/js/instanceof-operator-expected.txt:
* fast/js/script-tests/instanceof-operator.js:
- added test case for: javascript: ({} instanceof { get prototype(){ alert("Error!"); } })
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72127
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 16 Nov 2010 20:49:36 +0000 (20:49 +0000)]
Add WKPageCanShowMIMEType
https://bugs.webkit.org/show_bug.cgi?id=49612
Reviewed by Sam Weinig.
* UIProcess/API/C/WKPage.cpp:
(WKPageCanShowMIMEType):
* UIProcess/API/C/WKPage.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::canShowMIMEType):
* UIProcess/WebPageProxy.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72126
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Tue, 16 Nov 2010 19:39:53 +0000 (19:39 +0000)]
Unreviewed. Update Qt specific expected results after r72116.
Remove CSS Variable support
https://bugs.webkit.org/show_bug.cgi?id=49483
* platform/qt/fast/dom/Window/window-properties-expected.txt:
* platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/qt/fast/dom/prototype-inheritance-expected.txt:
* platform/qt/fast/js/global-constructors-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72125
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zmo@google.com [Tue, 16 Nov 2010 19:30:32 +0000 (19:30 +0000)]
2010-11-12 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Refactor GL backend flags
https://bugs.webkit.org/show_bug.cgi?id=49460
* public/WebGraphicsContext3D.h: Remove GL flag queries at this level.
* src/GraphicsContext3DChromium.cpp: Ditto.
* src/GraphicsContext3DInternal.h: Ditto.
* src/WebGraphicsContext3DDefaultImpl.cpp: Ditto.
* src/WebGraphicsContext3DDefaultImpl.h: Ditto.
2010-11-12 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Refactor GL backend flags
https://bugs.webkit.org/show_bug.cgi?id=49460
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::WebGLRenderingContext): Call setupFlags().
(WebCore::WebGLRenderingContext::initializeNewContext): Remove flag initialization to setupFlags().
(WebCore::WebGLRenderingContext::setupFlags): Initialize GL flags.
(WebCore::WebGLRenderingContext::getRenderbufferParameter): Use accessor function instead of member.
(WebCore::WebGLRenderingContext::renderbufferStorage): Ditto.
* html/canvas/WebGLRenderingContext.h: Use flags set in setupFlags instead of querying underlying GL implementation.
(WebCore::WebGLRenderingContext::isGLES2Compliant):
(WebCore::WebGLRenderingContext::isGLES2NPOTStrict):
(WebCore::WebGLRenderingContext::isErrorGeneratedOnOutOfBoundsAccesses):
(WebCore::WebGLRenderingContext::isResourceSafe):
(WebCore::WebGLRenderingContext::isDepthStencilSupported):
* platform/graphics/Extensions3D.h: Add NPOT extension.
* platform/graphics/GraphicsContext3D.h: Remove GL flag queries at this level.
* platform/graphics/chromium/Extensions3DChromium.h: Add resource_safe and strict_attribs extensions.
* platform/graphics/mac/GraphicsContext3DMac.mm: Remove GL flag queries at this level.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72124
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbr@google.com [Tue, 16 Nov 2010 19:19:17 +0000 (19:19 +0000)]
2010-11-16 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
WebIDL conversions from string to number and array to number should not generate TypeError
https://bugs.webkit.org/show_bug.cgi?id=49218
Recent SVG-related changes to the StrictTypeChecking extended attribute in
CodeGeneratorJS.pm and CodeGeneratorV8.pm were not correct according to the Web IDL and
ECMA-262 specifications. In particular, when an attribute or function argument is specified
as a number type (floating-point or integer), passing in a String or object is not supposed
to raise an exception.
The original intent of the StrictTypeChecking extended attribute was to properly raise
TypeError when an interface type is required, but the supplied object does not implement the
interface type (http://dev.w3.org/2006/webapi/WebIDL/#es-interface). Historically WebKit has
silently passed null to the C++ bindings in this case. The handling of strings in the
original StrictTypeChecking implementation was also incorrect, raising exceptions when it
should not.
The semantics of StrictTypeChecking have been changed to enforce only the restrictions on
interface types. The V8 custom bindings for WebGL have been updated to match the behavior of
the autogenerated code.
Test: fast/canvas/webgl/type-conversion-test.html
* bindings/scripts/CodeGeneratorJS.pm:
* bindings/scripts/CodeGeneratorV8.pm:
* bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
(WebCore::getObjectParameter):
(WebCore::V8WebGLRenderingContext::getFramebufferAttachmentParameterCallback):
(WebCore::V8WebGLRenderingContext::getParameterCallback):
(WebCore::V8WebGLRenderingContext::getProgramParameterCallback):
(WebCore::V8WebGLRenderingContext::getShaderParameterCallback):
(WebCore::vertexAttribAndUniformHelperf):
2010-11-16 Kenneth Russell <kbr@google.com>
Reviewed by Dimitri Glazkov.
WebIDL conversions from string to number and array to number should not generate TypeError
https://bugs.webkit.org/show_bug.cgi?id=49218
Updated SVG tests which were incorrectly expecting exceptions to be raised when the Web IDL
and ECMA-262 specifications state that none should be. Incorporated WebGL test from Khronos
repository verifying the passing objects of various types to APIs.
Ran all layout tests in Safari on Mac OS X.
* fast/canvas/webgl/type-conversion-test-expected.txt: Added.
* fast/canvas/webgl/type-conversion-test.html: Added.
* svg/dom/SVGAngle-expected.txt:
* svg/dom/SVGAnimatedBoolean-expected.txt:
* svg/dom/SVGAnimatedEnumeration-expected.txt:
* svg/dom/SVGAnimatedInteger-expected.txt:
* svg/dom/SVGAnimatedNumber-expected.txt:
* svg/dom/SVGLength-expected.txt:
* svg/dom/SVGMatrix-expected.txt:
* svg/dom/SVGNumber-expected.txt:
* svg/dom/SVGPoint-expected.txt:
* svg/dom/SVGPreserveAspectRatio-expected.txt:
* svg/dom/SVGRect-expected.txt:
* svg/dom/SVGTransform-expected.txt:
* svg/dom/script-tests/SVGAngle.js:
* svg/dom/script-tests/SVGAnimatedBoolean.js:
* svg/dom/script-tests/SVGAnimatedEnumeration.js:
* svg/dom/script-tests/SVGAnimatedInteger.js:
* svg/dom/script-tests/SVGAnimatedNumber.js:
* svg/dom/script-tests/SVGLength.js:
* svg/dom/script-tests/SVGMatrix.js:
* svg/dom/script-tests/SVGNumber.js:
* svg/dom/script-tests/SVGPoint.js:
* svg/dom/script-tests/SVGPreserveAspectRatio.js:
* svg/dom/script-tests/SVGRect.js:
* svg/dom/script-tests/SVGTransform.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72123
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 16 Nov 2010 19:00:58 +0000 (19:00 +0000)]
Make WebPageProxy::decidePolicyForMIMEType a tad synchronous
https://bugs.webkit.org/show_bug.cgi?id=49605
Reviewed by Sam Weinig.
Change the DecidePolicyForMIMEType message to be synchronous, and if the policy listener is
invoked from within the decidePolicyForMIMEType callback return the policy information as out
parameters. This is needed in order to convert a loading connection to a download.
* Platform/CoreIPC/HandleMessage.h:
(CoreIPC::callMemberFunction):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::receivedPolicyDecision):
(WebKit::WebPageProxy::decidePolicyForMIMEType):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDecidePolicyForMIMEType):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72122
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Tue, 16 Nov 2010 18:58:05 +0000 (18:58 +0000)]
Windows build fix.
* DerivedSources.cpp: Removing CSS Variables generated files.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72121
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Tue, 16 Nov 2010 18:50:55 +0000 (18:50 +0000)]
Remove unnecessary def file, remove outdated def files from vcproj.
Rubber stamped by Adam Roben.
* WebKit.vcproj/WebKit.vcproj:
* WebKit.vcproj/WebKit_debug.def: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72120
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric.carlson@apple.com [Tue, 16 Nov 2010 18:44:46 +0000 (18:44 +0000)]
2010-11-16 Eric Carlson <eric.carlson@apple.com>
Reviewed by John Sullivan.
getMIMEType(s)ForExtension should consult system mapping
https://bugs.webkit.org/show_bug.cgi?id=49497
No new tests possible.
* platform/MIMETypeRegistry.cpp:
(WebCore::MIMETypeRegistry::getMediaMIMETypeForExtension): Add the type returned by getMIMETypeForExtension.
Put the result of mediaMIMETypeMap().get() in a local variable and test instead of calling
constains() and then get().
(WebCore::MIMETypeRegistry::getMediaMIMETypesForExtension): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72119
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Tue, 16 Nov 2010 18:35:47 +0000 (18:35 +0000)]
Unreviewed baseline update for Windows.
Update test expectations following r72052.
* platform/win/fast/blockflow/vertical-font-fallback-expected.txt: Added.
* platform/win/fast/forms/search-placeholder-value-changed-expected.txt:
* platform/win/fast/forms/textarea-placeholder-pseudo-style-expected.txt:
* platform/win/fast/forms/textarea-placeholder-set-attribute-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72118
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric.carlson@apple.com [Tue, 16 Nov 2010 18:28:22 +0000 (18:28 +0000)]
2010-11-16 Eric Carlson <eric.carlson@apple.com>
Reviewed by Darin Adler.
Rename QTKit based media engine class name
https://bugs.webkit.org/show_bug.cgi?id=36663
No new tests as this just renames a class and restructures existing code.
* platform/graphics/MediaPlayer.cpp:
(WebCore::installedMediaEngines): Use a macro with the platform media player class name to reduce the
number of #ifs in the code.
* platform/graphics/mac/MediaPlayerPrivateQTKit.h: Rename MediaPlayerPrivate to MediaPlayerPrivateQTKit.
* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::create):
(WebCore::MediaPlayerPrivateQTKit::registerMediaEngine):
(WebCore::MediaPlayerPrivateQTKit::MediaPlayerPrivateQTKit):
(WebCore::MediaPlayerPrivateQTKit::~MediaPlayerPrivateQTKit):
(WebCore::MediaPlayerPrivateQTKit::createQTMovie):
(WebCore::MediaPlayerPrivateQTKit::createQTMovieView):
(WebCore::MediaPlayerPrivateQTKit::detachQTMovieView):
(WebCore::MediaPlayerPrivateQTKit::createQTVideoRenderer):
(WebCore::MediaPlayerPrivateQTKit::destroyQTVideoRenderer):
(WebCore::MediaPlayerPrivateQTKit::createQTMovieLayer):
(WebCore::MediaPlayerPrivateQTKit::destroyQTMovieLayer):
(WebCore::MediaPlayerPrivateQTKit::currentRenderingMode):
(WebCore::MediaPlayerPrivateQTKit::preferredRenderingMode):
(WebCore::MediaPlayerPrivateQTKit::setUpVideoRendering):
(WebCore::MediaPlayerPrivateQTKit::tearDownVideoRendering):
(WebCore::MediaPlayerPrivateQTKit::hasSetUpVideoRendering):
(WebCore::MediaPlayerPrivateQTKit::createQTTime):
(WebCore::MediaPlayerPrivateQTKit::resumeLoad):
(WebCore::MediaPlayerPrivateQTKit::load):
(WebCore::MediaPlayerPrivateQTKit::loadInternal):
(WebCore::MediaPlayerPrivateQTKit::prepareToPlay):
(WebCore::MediaPlayerPrivateQTKit::platformMedia):
(WebCore::MediaPlayerPrivateQTKit::platformLayer):
(WebCore::MediaPlayerPrivateQTKit::play):
(WebCore::MediaPlayerPrivateQTKit::pause):
(WebCore::MediaPlayerPrivateQTKit::duration):
(WebCore::MediaPlayerPrivateQTKit::currentTime):
(WebCore::MediaPlayerPrivateQTKit::seek):
(WebCore::MediaPlayerPrivateQTKit::doSeek):
(WebCore::MediaPlayerPrivateQTKit::cancelSeek):
(WebCore::MediaPlayerPrivateQTKit::seekTimerFired):
(WebCore::MediaPlayerPrivateQTKit::paused):
(WebCore::MediaPlayerPrivateQTKit::seeking):
(WebCore::MediaPlayerPrivateQTKit::naturalSize):
(WebCore::MediaPlayerPrivateQTKit::hasVideo):
(WebCore::MediaPlayerPrivateQTKit::hasAudio):
(WebCore::MediaPlayerPrivateQTKit::supportsFullscreen):
(WebCore::MediaPlayerPrivateQTKit::setVolume):
(WebCore::MediaPlayerPrivateQTKit::hasClosedCaptions):
(WebCore::MediaPlayerPrivateQTKit::setClosedCaptionsVisible):
(WebCore::MediaPlayerPrivateQTKit::setRate):
(WebCore::MediaPlayerPrivateQTKit::setPreservesPitch):
(WebCore::MediaPlayerPrivateQTKit::buffered):
(WebCore::MediaPlayerPrivateQTKit::maxTimeSeekable):
(WebCore::MediaPlayerPrivateQTKit::maxTimeLoaded):
(WebCore::MediaPlayerPrivateQTKit::bytesLoaded):
(WebCore::MediaPlayerPrivateQTKit::totalBytes):
(WebCore::MediaPlayerPrivateQTKit::cancelLoad):
(WebCore::MediaPlayerPrivateQTKit::cacheMovieScale):
(WebCore::MediaPlayerPrivateQTKit::isReadyForVideoSetup):
(WebCore::MediaPlayerPrivateQTKit::prepareForRendering):
(WebCore::MediaPlayerPrivateQTKit::updateStates):
(WebCore::MediaPlayerPrivateQTKit::loadStateChanged):
(WebCore::MediaPlayerPrivateQTKit::rateChanged):
(WebCore::MediaPlayerPrivateQTKit::sizeChanged):
(WebCore::MediaPlayerPrivateQTKit::timeChanged):
(WebCore::MediaPlayerPrivateQTKit::didEnd):
(WebCore::MediaPlayerPrivateQTKit::setSize):
(WebCore::MediaPlayerPrivateQTKit::setVisible):
(WebCore::MediaPlayerPrivateQTKit::hasAvailableVideoFrame):
(WebCore::MediaPlayerPrivateQTKit::repaint):
(WebCore::MediaPlayerPrivateQTKit::paintCurrentFrameInContext):
(WebCore::MediaPlayerPrivateQTKit::paint):
(WebCore::MediaPlayerPrivateQTKit::getSupportedTypes):
(WebCore::MediaPlayerPrivateQTKit::supportsType):
(WebCore::MediaPlayerPrivateQTKit::isAvailable):
(WebCore::MediaPlayerPrivateQTKit::disableUnsupportedTracks):
(WebCore::MediaPlayerPrivateQTKit::sawUnsupportedTracks):
(WebCore::MediaPlayerPrivateQTKit::supportsAcceleratedRendering):
(WebCore::MediaPlayerPrivateQTKit::acceleratedRenderingStateChanged):
(WebCore::MediaPlayerPrivateQTKit::hasSingleSecurityOrigin):
(WebCore::MediaPlayerPrivateQTKit::movieLoadType):
(WebCore::MediaPlayerPrivateQTKit::setPreload):
(WebCore::MediaPlayerPrivateQTKit::mediaTimeForTimeValue):
(-[WebCoreMovieObserver initWithCallback:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72117
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Tue, 16 Nov 2010 18:25:46 +0000 (18:25 +0000)]
Reviewed by Dave Hyatt.
https://bugs.webkit.org/show_bug.cgi?id=49483
Remove CSS Variable support
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72116
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Tue, 16 Nov 2010 18:15:19 +0000 (18:15 +0000)]
2010-11-16 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
https://bugs.webkit.org/show_bug.cgi?id=48603
Boolean logic mistake in local file check
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadFrameRequest): Fix logic so that both checks have to pass
before accepting a local file load.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72115
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Tue, 16 Nov 2010 18:04:52 +0000 (18:04 +0000)]
2010-11-15 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
Harden additional string functions against large lengths
https://bugs.webkit.org/show_bug.cgi?id=49574
* wtf/text/CString.cpp:
(WTF::CString::init): Check for length that is too large for CString.
(WTF::CString::newUninitialized): Ditto.
(WTF::CString::copyBufferIfNeeded): Fix types so the length stays
in a size_t.
* wtf/text/WTFString.cpp:
(WTF::String::append): Check for length that is too large.
2010-11-15 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
Harden additional string functions against large lengths
https://bugs.webkit.org/show_bug.cgi?id=49574
* platform/text/TextCodecUTF16.cpp:
(WebCore::TextCodecUTF16::encode): Check for length that is
too large for size_t.
* platform/text/TextStream.cpp:
(WebCore::TextStream::operator<<): Check for length that is
too large for size_t.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@72114
268f45cc-cd09-0410-ab3c-
d52691b4dbfc