WebKit-https.git
12 years ago2009-10-02 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 2 Oct 2009 08:20:58 +0000 (08:20 +0000)]
2009-10-02  Adam Barth  <abarth@webkit.org>

        Unreviewed attempted build fix by Xcode magic.

        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49014 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-02 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 2 Oct 2009 08:03:35 +0000 (08:03 +0000)]
2009-10-02  Adam Barth  <abarth@webkit.org>

        Unreviewed build fix.  Actually add the new files.

        * loader/RedirectScheduler.cpp: Added.
        (WebCore::ScheduledRedirection::):
        (WebCore::ScheduledRedirection::ScheduledRedirection):
        (WebCore::RedirectScheduler::RedirectScheduler):
        (WebCore::RedirectScheduler::~RedirectScheduler):
        (WebCore::RedirectScheduler::redirectScheduledDuringLoad):
        (WebCore::RedirectScheduler::clear):
        (WebCore::RedirectScheduler::scheduleRedirect):
        (WebCore::RedirectScheduler::mustLockBackForwardList):
        (WebCore::RedirectScheduler::scheduleLocationChange):
        (WebCore::RedirectScheduler::scheduleFormSubmission):
        (WebCore::RedirectScheduler::scheduleRefresh):
        (WebCore::RedirectScheduler::locationChangePending):
        (WebCore::RedirectScheduler::scheduleHistoryNavigation):
        (WebCore::RedirectScheduler::timerFired):
        (WebCore::RedirectScheduler::schedule):
        (WebCore::RedirectScheduler::startTimer):
        (WebCore::RedirectScheduler::cancel):
        * loader/RedirectScheduler.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49013 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-01 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 2 Oct 2009 07:57:48 +0000 (07:57 +0000)]
2009-10-01  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        Move RedirectScheduler to its own file
        https://bugs.webkit.org/show_bug.cgi?id=29952

        This change is purely code motion.

        No behavior change.

        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * loader/FrameLoader.cpp:
        * loader/FrameLoader.h:
        * loader/RedirectScheduler.cpp: Added.
        (WebCore::ScheduledRedirection::):
        (WebCore::ScheduledRedirection::ScheduledRedirection):
        (WebCore::RedirectScheduler::RedirectScheduler):
        (WebCore::RedirectScheduler::~RedirectScheduler):
        (WebCore::RedirectScheduler::redirectScheduledDuringLoad):
        (WebCore::RedirectScheduler::clear):
        (WebCore::RedirectScheduler::scheduleRedirect):
        (WebCore::RedirectScheduler::mustLockBackForwardList):
        (WebCore::RedirectScheduler::scheduleLocationChange):
        (WebCore::RedirectScheduler::scheduleFormSubmission):
        (WebCore::RedirectScheduler::scheduleRefresh):
        (WebCore::RedirectScheduler::locationChangePending):
        (WebCore::RedirectScheduler::scheduleHistoryNavigation):
        (WebCore::RedirectScheduler::timerFired):
        (WebCore::RedirectScheduler::schedule):
        (WebCore::RedirectScheduler::startTimer):
        (WebCore::RedirectScheduler::cancel):
        * loader/RedirectScheduler.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-02 Dave MacLachlan <dmaclach@gmail.com>
eric@webkit.org [Fri, 2 Oct 2009 07:41:49 +0000 (07:41 +0000)]
2009-10-02  Dave MacLachlan  <dmaclach@gmail.com>

        Reviewed by David Levin.

        Clean up warnings in WebCore/bindings/v8/npruntime.cpp
        https://bugs.webkit.org/show_bug.cgi?id=29971

        Gets rid of warnings on gcc about using anonymous namespaces
          warning: 'StringKeyHashTraits' has a base
          'WTF::GenericHashTraits<<unnamed>::StringKey>'
          whose type uses the anonymous namespace
        and
          warning: 'WTF::PairHashTraits<StringKeyHashTraits,
          WTF::HashTraits<PrivateIdentifier*> >' has a base
          'WTF::GenericHashTraits<std::pair<<unnamed>::StringKey,
          PrivateIdentifier*> >' whose type uses the anonymous namespace

        No tests required.

        * bindings/v8/npruntime.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAllow enabling and disabling of the JIT through a qmake variable.
hausmann@webkit.org [Fri, 2 Oct 2009 07:31:22 +0000 (07:31 +0000)]
Allow enabling and disabling of the JIT through a qmake variable.

Patch by Jørgen Lind <jorgen.lind@nokia.com> on 2009-10-02
Reviewed by Simon Hausmann.

Qt's configure may set this variable through .qmake.cache if a
commandline option is given and/or the compile test for hwcap.h
failed/succeeded.

* JavaScriptCore.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-01 Drew Wilson <atwilson@chromium.org>
eric@webkit.org [Fri, 2 Oct 2009 04:01:38 +0000 (04:01 +0000)]
2009-10-01  Drew Wilson  <atwilson@chromium.org>

        Reviewed by David Levin.

        Remove clone count from worker-cloneport.html as it's flakey on multi-process ports like Chromium.
        https://bugs.webkit.org/show_bug.cgi?id=29698

        * fast/workers/worker-cloneport-expected.txt:
        * fast/workers/worker-cloneport.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix the Tiger build. Don't unconditionally enable 3D canvas as it is not supported...
mrowe@apple.com [Fri, 2 Oct 2009 02:50:27 +0000 (02:50 +0000)]
Fix the Tiger build.  Don't unconditionally enable 3D canvas as it is not supported on Tiger.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49008 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-01 Laszlo Gombos <laszlo.1.gombos@nokia.com>
laszlo.1.gombos@nokia.com [Fri, 2 Oct 2009 00:58:45 +0000 (00:58 +0000)]
2009-10-01  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Unreviewed, build fix.

        [Qt] Symbian build break after r48976.
        unix is set for Symbian in the Qt build system.

        * WebKit.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agohttps://bugs.webkit.org/show_bug.cgi?id=29906
cmarrin@apple.com [Fri, 2 Oct 2009 00:25:12 +0000 (00:25 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=29906
Turn on compile time switch for WebGL, but have runtime switch default to off

This also fixes LayoutTests which broke with the flag turned on, and
fixes a crash found in the LayoutTests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRoll out r49004 since it broke the debug build.
mrowe@apple.com [Thu, 1 Oct 2009 23:49:28 +0000 (23:49 +0000)]
Roll out r49004 since it broke the debug build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoTake one branch instead of two to test for JSValue().
ggaren@apple.com [Thu, 1 Oct 2009 23:32:48 +0000 (23:32 +0000)]
Take one branch instead of two to test for JSValue().

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-01
Reviewed by Sam Weinig.

1.1% SunSpider speedup.

* jit/JITCall.cpp:
(JSC::JIT::compileOpCall):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_to_jsnumber):
(JSC::JIT::emit_op_create_arguments):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emit_op_put_by_val): Test for the empty value tag, instead
of testing for the cell tag with a 0 payload.

* runtime/JSValue.cpp:
(JSC::JSValue::description): Added support for dumping the new empty value,
and deleted values, in debug builds.

* runtime/JSValue.h:
(JSC::JSValue::JSValue()): Construct JSValue() with the empty value tag.

(JSC::JSValue::JSValue(JSCell*)): Convert null pointer to the empty value
tag, to avoid having two different c++ versions of null / empty.

(JSC::JSValue::operator bool): Test for the empty value tag, instead
of testing for the cell tag with a 0 payload.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore: Fix for <rdar://problem/7264725> Re-add a vendor prefix to box-
bdakin@apple.com [Thu, 1 Oct 2009 23:00:22 +0000 (23:00 +0000)]
WebCore: Fix for <rdar://problem/7264725> Re-add a vendor prefix to box-
shadow (29927)
-and corresponding-
https://bugs.webkit.org/show_bug.cgi?id=29927

Reviewed by Dan Bernstein.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::ShadowParseContext::ShadowParseContext):
(WebCore::ShadowParseContext::commitValue):
(WebCore::ShadowParseContext::commitLength):
(WebCore::ShadowParseContext::commitColor):
(WebCore::cssPropertyID):
* css/CSSPropertyNames.in:
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
* page/animation/AnimationBase.cpp:
(WebCore::ensurePropertyMap):

LayoutTests: Updated test results for <rdar://problem/7264725> Re-add a vendor
prefix to box-shadow (29927)
-and corresponding-
https://bugs.webkit.org/show_bug.cgi?id=29927

Reviewed by Dan Bernstein.

* platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/qt/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* svg/css/getComputedStyle-basic-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-01 Yaar Schnitman <yaar@chromium.org>
eric@webkit.org [Thu, 1 Oct 2009 22:21:34 +0000 (22:21 +0000)]
2009-10-01  Yaar Schnitman  <yaar@chromium.org>

        Reviewed by Dimitri Glazkov.

        Make it possible to override the list of feature defines when building
        downstream.

        https://bugs.webkit.org/show_bug.cgi?id=29979

        * chromium/features.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-01 Brian Weinstein <bweinstein@apple.com>
bweinstein@apple.com [Thu, 1 Oct 2009 21:56:02 +0000 (21:56 +0000)]
2009-10-01  Brian Weinstein  <bweinstein@apple.com>

        Rubber-stamped by Adam Roben.

        Added fast/inline/relative-positioned-overflow.html to Skipped list because
        it hits an asssert in Windows debug builds. Assertion failure is being tracked
        by <https://bugs.webkit.org/show_bug.cgi?id=29966>.

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRubber-stamped by Sam Weinig.
bdakin@apple.com [Thu, 1 Oct 2009 21:24:51 +0000 (21:24 +0000)]
Rubber-stamped by Sam Weinig.

Appeasing the Bot.

* platform/mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-01 Brian Weinstein <bweinstein@apple.com>
bweinstein@apple.com [Thu, 1 Oct 2009 21:19:52 +0000 (21:19 +0000)]
2009-10-01  Brian Weinstein  <bweinstein@apple.com>

        Reviewed by Beth Dakin.

        Update expected Windows results after new CSS Text Kerning changes.

        * platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
        * platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
        * platform/win/fast/css/text-rendering-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-01 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Thu, 1 Oct 2009 20:46:45 +0000 (20:46 +0000)]
2009-10-01  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        Set the type for the fake event, otherwise the test ASSERTs in
        debug builds.

        * tests/testhittestresult.c:
        (load_status_cb):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRubberstamped by Simon Hausmann.
kenneth@webkit.org [Thu, 1 Oct 2009 20:44:42 +0000 (20:44 +0000)]
Rubberstamped by Simon Hausmann.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-01
Disable HTTP loading tests that fail on the buildbot.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoREGRESSION: fast/workers/dedicated-worker-lifecycle.html failing intermittently on...
atwilson@chromium.org [Thu, 1 Oct 2009 20:27:05 +0000 (20:27 +0000)]
REGRESSION: fast/workers/dedicated-worker-lifecycle.html failing intermittently on leopard bot
https://bugs.webkit.org/show_bug.cgi?id=29344

Reviewed by Eric Seidel.

* fast/workers/resources/dedicated-worker-lifecycle.js:
(runTests):
Allocate objects on the stack to try to force a GC to eliminate flakiness.
* fast/workers/resources/worker-util.js:
(gc):
Added an optional "forceAlloc" parameter which causes a more extensive stack-clobbering algorithm to be run.
(waitUntilThreadCountMatches):
Pass the forceAlloc flag to gc() to try to force unreferenced workers to get GC'd.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRubber-stamped by Sam Weinig.
bdakin@apple.com [Thu, 1 Oct 2009 20:24:08 +0000 (20:24 +0000)]
Rubber-stamped by Sam Weinig.

At bad merge at some point in the development of my patch must have
put TextRenderMode.h in a weird spot in the xcodeproj. Moving it
back where it belongs!

* WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-01 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 1 Oct 2009 20:12:40 +0000 (20:12 +0000)]
2009-10-01  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        Remove FrameLoader::schedule* APIs
        https://bugs.webkit.org/show_bug.cgi?id=29950

        Change clients of FrameLoader::schedule* to call redirectScheduler
        directly.

        No behavior change.

        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::setLocation):
        (WebCore::createWindow):
        (WebCore::JSDOMWindow::open):
        * bindings/js/JSDocumentCustom.cpp:
        (WebCore::JSDocument::setLocation):
        * bindings/js/JSLocationCustom.cpp:
        (WebCore::navigateIfAllowed):
        (WebCore::JSLocation::reload):
        * bindings/v8/V8Utilities.cpp:
        (WebCore::navigateIfAllowed):
        * bindings/v8/custom/V8DOMWindowCustom.cpp:
        (WebCore::createWindow):
        (WebCore::CALLBACK_FUNC_DECL):
        * bindings/v8/custom/V8LocationCustom.cpp:
        (WebCore::CALLBACK_FUNC_DECL):
        * dom/Document.cpp:
        (WebCore::Document::implicitClose):
        (WebCore::Document::processHttpEquiv):
        * html/HTMLTokenizer.cpp:
        (WebCore::HTMLTokenizer::write):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::requestFrame):
        (WebCore::FrameLoader::submitForm):
        (WebCore::FrameLoader::receivedFirstData):
        * loader/FrameLoader.h:
        * loader/appcache/ApplicationCacheGroup.cpp:
        (WebCore::ApplicationCacheGroup::selectCache):
        * page/History.cpp:
        (WebCore::History::back):
        (WebCore::History::forward):
        (WebCore::History::go):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoJust removing a comment I accidentally committed earlier.
bdakin@apple.com [Thu, 1 Oct 2009 20:08:11 +0000 (20:08 +0000)]
Just removing a comment I accidentally committed earlier.

* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::getCFStringAttributes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-30 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Thu, 1 Oct 2009 19:54:25 +0000 (19:54 +0000)]
2009-09-30  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Darin Adler.

        Clean up use of const and mutable in StorageMap
        https://bugs.webkit.org/show_bug.cgi?id=29933

        What's the point of having every single member variable be mutable and nearly
        every method be const?  Let's clean it up.

        * storage/StorageMap.cpp:
        (WebCore::StorageMap::setIteratorToIndex):
        (WebCore::StorageMap::key):
        (WebCore::StorageMap::importItem):
        * storage/StorageMap.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRubberstamped by Simon Hausmann.
kenneth@webkit.org [Thu, 1 Oct 2009 19:32:26 +0000 (19:32 +0000)]
Rubberstamped by Simon Hausmann.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-01
Enable Local tests for Qt.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRubberstamped by Simon Hausmann.
kenneth@webkit.org [Thu, 1 Oct 2009 19:21:36 +0000 (19:21 +0000)]
Rubberstamped by Simon Hausmann.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-01
Enable HTTP loading tests for Qt.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore: Fix for <rdar://problem/6934421> Support CSS for Text Kerning and
bdakin@apple.com [Thu, 1 Oct 2009 19:19:34 +0000 (19:19 +0000)]
WebCore: Fix for <rdar://problem/6934421> Support CSS for Text Kerning and
ligature
-and corresponding-
https://bugs.webkit.org/show_bug.cgi?id=6136

Reviewed by Dave Hyatt.

This patch makes the SVG CSS property text-rendering work with any
HTML, much like it does in Firefox. It accepts four possible input
values: auto, optimizeSpeed, optimizeLegibility, and
geometricPrecision. Right now, in this implementation, here is what
those values correspond to:

auto = optimizeSpeed = what we normally when the value's not set
optimizeLegibility = geometricPrecision = ligatures + kerning

Add new file TextRenderingMode.h to the project files.
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:

CSS support for the new CSSPropertyTextRendering
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator TextRenderingMode):
* css/CSSPropertyNames.in:
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
* css/CSSValueKeywords.in:

All the old SVG CSS support for this property can go away. When
it's used in SVG, it will just fall into the normal HTML case.
* css/SVGCSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue):
* css/SVGCSSParser.cpp:
(WebCore::CSSParser::parseSVGValue):
* css/SVGCSSPropertyNames.in:
* css/SVGCSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applySVGProperty):
* css/SVGCSSValueKeywords.in:

FontDescription stores the m_textRendering bit.
* platform/graphics/FontDescription.h:
(WebCore::FontDescription::FontDescription):
(WebCore::FontDescription::textRenderingMode):
(WebCore::FontDescription::setTextRenderingMode):
(WebCore::FontDescription::operator==):

We want to fall into the complex text rendering code path if
kerning and ligatures have been enabled with this property.
* platform/graphics/FontFastPath.cpp:
(WebCore::Font::canUseGlyphCache):

Now takes a TextRenderingMode as a parameter.
* platform/graphics/SimpleFontData.h:

New header for the enum.
* platform/graphics/TextRenderingMode.h: Added.
(WebCore::):

getCFStringAttributes() now takes a TextRenderingMode as an
attribute.
* platform/graphics/mac/CoreTextController.cpp:
(WebCore::CoreTextController::collectCoreTextRunsForCharacters):

Enable kerning and ligatures whenever the TextRenderingMode is
OptimizeLegibility or GeometricPrecision
* platform/graphics/mac/FontMacATSUI.mm:
(WebCore::disableLigatures):
(WebCore::initializeATSUStyle):
(WebCore::ATSULayoutParameters::initialize):
* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::getCFStringAttributes):

More SVG CSS stuff that isn't needed anymore since SVG will use the
new HTML CSS implementation.
* rendering/style/SVGRenderStyle.h:
(WebCore::SVGRenderStyle::InheritedFlags::operator==):
(WebCore::SVGRenderStyle::setBitDefaults):
* rendering/style/SVGRenderStyleDefs.h:

LayoutTests: Tests for <rdar://problem/6934421> Support CSS for Text Kerning and
ligature
-and corresponding-
https://bugs.webkit.org/show_bug.cgi?id=6136

Reviewed by Dave Hyatt.

New tests.
* fast/css/parsing-text-rendering-expected.txt: Added.
* fast/css/parsing-text-rendering.html: Added.
* fast/css/resources/parsing-text-rendering.js: Added.
(test):
* fast/css/text-rendering.html: Added.
* platform/mac/fast/css/text-rendering-expected.checksum: Added.
* platform/mac/fast/css/text-rendering-expected.png: Added.
* platform/mac/fast/css/text-rendering-expected.txt: Added.

New and improved results.
* platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.checksum:
* platform/mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png:
* platform/mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
* svg/css/getComputedStyle-basic-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-01 Yongjun Zhang <yongjun.zhang@nokia.com>
eric@webkit.org [Thu, 1 Oct 2009 19:18:02 +0000 (19:18 +0000)]
2009-10-01  Yongjun Zhang  <yongjun.zhang@nokia.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=29187

        Don't inline ~ListRefPtr() to work around winscw compiler forward declaration
        bug regarding templated classes.

        The compiler bug is reported at:
        https://xdabug001.ext.nokia.com/bugzilla/show_bug.cgi?id=9812

        The change will be reverted when the above bug is fixed in winscw compiler.

        * wtf/ListRefPtr.h:
        (WTF::::~ListRefPtr):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRubberstamped by Simon Hausmann.
kenneth@webkit.org [Thu, 1 Oct 2009 19:10:56 +0000 (19:10 +0000)]
Rubberstamped by Simon Hausmann.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-01
Enable URI tests for Qt, skip the single test we don't pass.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-01 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Thu, 1 Oct 2009 18:29:31 +0000 (18:29 +0000)]
2009-10-01  Nate Chapin  <japhet@chromium.org>

        Reviewed by Darin Adler.

        Add baseline pngs for a couple of tests that currently only have checksums.

        https://bugs.webkit.org/show_bug.cgi?id=28322

        * platform/mac/fast/borders/border-radius-constraints-expected.png: Added.
        * platform/mac/fast/borders/border-radius-split-inline-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRubberstamped by Simon Hausmann.
kenneth@webkit.org [Thu, 1 Oct 2009 18:14:24 +0000 (18:14 +0000)]
Rubberstamped by Simon Hausmann.

WebKitTools:

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-01
Enable HTTP tests for Qt

* Scripts/run-webkit-tests:

LayoutTests:

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-01
Enable HTTP tests for Qt, and skip the subdirs we don't pass yet.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-01 Yaar Schnitman <yaar@chromium.org>
eric@webkit.org [Thu, 1 Oct 2009 18:08:49 +0000 (18:08 +0000)]
2009-10-01  Yaar Schnitman  <yaar@chromium.org>

        Reviewed by Dimitri Glazkov.

        Added windows-specific dependencies, updated some revisions and
        re-organized file to make revision tracking easier. Also removed
        extensions/v8 dependency that is no longer needed upstream.

        https://bugs.webkit.org/show_bug.cgi?id=29973

        * chromium/DEPS:
2009-10-01  Yaar Schnitman  <yaar@chromium.org>

        Reviewed by Dimitri Glazkov.

        build-webkit --chromium now also works on cygwin.

        https://bugs.webkit.org/show_bug.cgi?id=29973

        * Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-01 Yury Semikhatsky <yurys@chromium.org>
eric@webkit.org [Thu, 1 Oct 2009 17:41:07 +0000 (17:41 +0000)]
2009-10-01  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Timothy Hatcher.

        Use isClosure property of scope proxy to decide whether the
        scope is a closure.

        https://bugs.webkit.org/show_bug.cgi?id=29965

        * inspector/front-end/ScopeChainSidebarPane.js:
        (WebInspector.ScopeChainSidebarPane.prototype.update):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-01 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 1 Oct 2009 17:29:32 +0000 (17:29 +0000)]
2009-10-01  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dave Hyatt.

        Odd color transitions on anchors with transition-property: all
        https://bugs.webkit.org/show_bug.cgi?id=29911

        When transitioning maybe-invalid colors, if the source and destination
        color are both invalid, then don't animate.

        This fixes an issue where a child element of an element running a color
        transition, with -webkit-transition-property:all, would show a color change.
        This happened because the "maybe invalid color" logic copied the color style
        into -webkit-text-fill-color for both endpoints, causing -webkit-text-fill-color
        to animate while the transition ran, and to then to disappear when the transition
        finished.

        Test: transitions/color-transition-all.html

        * page/animation/AnimationBase.cpp:
        (WebCore::PropertyWrapperMaybeInvalidColor::equals):
        (WebCore::PropertyWrapperMaybeInvalidColor::blend):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-01 Victor Wang <victorw@chromium.org>
eric@webkit.org [Thu, 1 Oct 2009 17:25:36 +0000 (17:25 +0000)]
2009-10-01  Victor Wang  <victorw@chromium.org>

        Reviewed by Oliver Hunt.

        Allow dragging a node who has child nodes.

        https://bugs.webkit.org/show_bug.cgi?id=28632

        * fast/events/drag-parent-node-expected.txt: Added.
        * fast/events/drag-parent-node.html: Added.
        * fast/events/resources/bookmark.gif: Added.
2009-10-01  Victor Wang  <victorw@chromium.org>

        Reviewed by Oliver Hunt.

        Allow dragging a node who has child nodes.

        https://bugs.webkit.org/show_bug.cgi?id=28632

        Test: fast/events/drag-parent-node.html

        * page/EventHandler.cpp:
        (WebCore::EventHandler::shouldDragAutoNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-01 Philippe Normand <pnormand@igalia.com>
eric@webkit.org [Thu, 1 Oct 2009 17:17:12 +0000 (17:17 +0000)]
2009-10-01  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Gustavo Noronha.

        [GTK] media player: better mute support
        https://bugs.webkit.org/show_bug.cgi?id=29960

        Handle volume and mute state with the two corresponding properties
        of playbin2.

        * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::MediaPlayerPrivate::setMuted):
        (WebCore::MediaPlayerPrivate::setVolume):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-01 Philippe Normand <pnormand@igalia.com>
eric@webkit.org [Thu, 1 Oct 2009 17:09:36 +0000 (17:09 +0000)]
2009-10-01  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Gustavo Noronha.

        [GTK] video sink pad template colorspace is wrong
        https://bugs.webkit.org/show_bug.cgi?id=29953

        Set sink pad template colorspace depending on byte order.

        * platform/graphics/gtk/VideoSinkGStreamer.cpp:
        (webkit_video_sink_idle_func):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-01 Vitaly Repeshko <vitalyr@chromium.org>
eric@webkit.org [Thu, 1 Oct 2009 17:01:50 +0000 (17:01 +0000)]
2009-10-01  Vitaly Repeshko  <vitalyr@chromium.org>

        Reviewed by Dimitri Glazkov.

        [V8] Refactored V8 event listeners:
        (This change should fix http://crbug.com/21079 and
        https://bugs.webkit.org/show_bug.cgi?id=29093.)
         o All listeners use weak handles to JS objects to avoid creating
           cycles and leaking memory.
         o "Object" variants of listeners removed.
         o All event accessor callbacks are generated.
         o Custom event accessors removed.
         o All wrappers have hidden dependencies on their listeners to
           prevent listeners from being collected.
         o All variats of getEventListener function grouped in V8DOMWrapper.
         o Pointers to C++ EventListener wrappers are stored in JS objects
           instead of event listener lists.
        https://bugs.webkit.org/show_bug.cgi?id=29825

        * WebCore.gypi: Removed "Object" listeners.
        * bindings/scripts/CodeGeneratorV8.pm: Now handles event accessors.
        * bindings/v8/DOMObjectsInclude.h:

        V8AbstractEventListener manages weak JS handle:
        * bindings/v8/V8AbstractEventListener.cpp:
        (WebCore::weakEventListenerCallback):
        (WebCore::V8AbstractEventListener::V8AbstractEventListener):
        (WebCore::V8AbstractEventListener::~V8AbstractEventListener):
        (WebCore::V8AbstractEventListener::handleEvent):
        (WebCore::V8AbstractEventListener::disposeListenerObject):
        (WebCore::V8AbstractEventListener::setListenerObject):
        * bindings/v8/V8AbstractEventListener.h:
        (WebCore::V8AbstractEventListener::cast):
        (WebCore::V8AbstractEventListener::isLazy):
        (WebCore::V8AbstractEventListener::getListenerObject):
        (WebCore::V8AbstractEventListener::getExistingListenerObject):
        (WebCore::V8AbstractEventListener::hasExistingListenerObject):
        (WebCore::V8AbstractEventListener::disconnectFrame):
        (WebCore::V8AbstractEventListener::disconnected):
        (WebCore::V8AbstractEventListener::prepareListenerObject):
        (WebCore::V8AbstractEventListener::lineNumber):
        (WebCore::V8AbstractEventListener::virtualisAttribute):

        Grouped getEventListener functions:
        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::getTemplate):
        (WebCore::V8DOMWrapper::getEventListener):
        * bindings/v8/V8DOMWrapper.h:

        Removed most event listener objects bookkeeping:
        * bindings/v8/V8EventListenerList.cpp:
        * bindings/v8/V8EventListenerList.h:
        (WebCore::V8EventListenerList::findWrapper):
        (WebCore::V8EventListenerList::clearWrapper):
        (WebCore::V8EventListenerList::doFindWrapper):
        (WebCore::V8EventListenerList::getHiddenProperty):
        (WebCore::V8EventListenerList::findOrCreateWrapper):

        Added hidden properties for storing EventListener wrappers:
        * bindings/v8/V8HiddenPropertyName.cpp:
        (WebCore::V8HiddenPropertyName::listener):
        (WebCore::V8HiddenPropertyName::attributeListener):
        * bindings/v8/V8HiddenPropertyName.h:

        * bindings/v8/V8LazyEventListener.cpp:
        (WebCore::V8LazyEventListener::V8LazyEventListener):
        (WebCore::V8LazyEventListener::callListenerFunction):
        (WebCore::V8LazyEventListener::prepareListenerObject):
        * bindings/v8/V8LazyEventListener.h:
        (WebCore::V8LazyEventListener::isLazy):
        * bindings/v8/V8ObjectEventListener.cpp: Removed.
        * bindings/v8/V8ObjectEventListener.h: Removed.
        * bindings/v8/V8Proxy.cpp:
        (WebCore::V8Proxy::disconnectFrame):
        (WebCore::V8Proxy::disconnectEventListeners):
        * bindings/v8/V8Proxy.h:
        * bindings/v8/V8WorkerContextEventListener.cpp:
        (WebCore::V8WorkerContextEventListener::reportError):
        (WebCore::V8WorkerContextEventListener::getReceiverObject):
        * bindings/v8/V8WorkerContextEventListener.h:
        * bindings/v8/V8WorkerContextObjectEventListener.cpp: Removed.
        * bindings/v8/V8WorkerContextObjectEventListener.h: Removed.
        * bindings/v8/WorkerContextExecutionProxy.cpp:
        (WebCore::WorkerContextExecutionProxy::dispose):
        (WebCore::WorkerContextExecutionProxy::initContextIfNeeded):
        (WebCore::WorkerContextExecutionProxy::findOrCreateEventListener):
        * bindings/v8/WorkerContextExecutionProxy.h:
        * bindings/v8/custom/V8AbstractWorkerCustom.cpp:
        (WebCore::CALLBACK_FUNC_DECL):
        * bindings/v8/custom/V8CustomBinding.h:
        * bindings/v8/custom/V8CustomEventListener.cpp:
        (WebCore::V8EventListener::V8EventListener):
        (WebCore::V8EventListener::getListenerFunction):
        (WebCore::V8EventListener::callListenerFunction):
        * bindings/v8/custom/V8CustomEventListener.h:
        * bindings/v8/custom/V8DOMApplicationCacheCustom.cpp:
        (WebCore::CALLBACK_FUNC_DECL):
        * bindings/v8/custom/V8DOMWindowCustom.cpp:
        (WebCore::CALLBACK_FUNC_DECL):
        * bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:
        * bindings/v8/custom/V8MessagePortCustom.cpp:
        (WebCore::getEventListener):
        (WebCore::CALLBACK_FUNC_DECL):
        * bindings/v8/custom/V8NodeCustom.cpp:
        (WebCore::CALLBACK_FUNC_DECL):
        * bindings/v8/custom/V8NotificationCenterCustom.cpp:
        (WebCore::CALLBACK_FUNC_DECL):
        * bindings/v8/custom/V8SVGElementInstanceCustom.cpp:
        (WebCore::CALLBACK_FUNC_DECL):
        * bindings/v8/custom/V8WebSocketCustom.cpp:
        * bindings/v8/custom/V8WorkerContextCustom.cpp:
        (WebCore::CALLBACK_FUNC_DECL):
        * bindings/v8/custom/V8WorkerCustom.cpp:
        * bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:
        * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
        (WebCore::CALLBACK_FUNC_DECL):
        * bindings/v8/custom/V8XMLHttpRequestUploadCustom.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoMake Software Input Panel requests work with QGraphicsWebView
hausmann@webkit.org [Thu, 1 Oct 2009 16:59:28 +0000 (16:59 +0000)]
Make Software Input Panel requests work with QGraphicsWebView
_and_ QWebView by sharing the event code in handleSoftwareInputPanel().

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2009-10-01
Reviewed by Tor Arne Vestbø.

* Api/qwebpage.cpp:
(QWebPagePrivate::mouseReleaseEvent):
(QWebPagePrivate::handleSoftwareInputPanel):
* Api/qwebpage_p.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-01 Zoltan Horvath <zoltan@webkit.org>
zoltan@webkit.org [Thu, 1 Oct 2009 16:22:43 +0000 (16:22 +0000)]
2009-10-01  Zoltan Horvath  <zoltan@webkit.org>

        Reviewed by Simon Hausmann.

        [Qt] Allow custom memory allocation control for the whole JavaScriptCore
        https://bugs.webkit.org/show_bug.cgi?id=27029

        Since in JavaScriptCore almost every class which has been instantiated by operator new is
        inherited from FastAllocBase (bug #20422), we disable customizing global operator new for the Qt-port
        when USE_SYSTEM_MALLOC=0.

        Add #include <unistd.h> to FastMalloc.cpp because it's used by TCMalloc_PageHeap::scavengerThread().
        (It's needed for the functionality of TCmalloc.)

        Add TCSystemAlloc.cpp to JavaScriptCore.pri if USE_SYSTEM_MALLOC is disabled.

        * JavaScriptCore.pri:
        * wtf/FastMalloc.cpp:
        (WTF::sleep):
        * wtf/FastMalloc.h:

2009-10-01  Zoltan Horvath  <zoltan@webkit.org>

        Reviewed by Simon Hausmann.

        [Qt] Don't use TCmalloc in DumpRenderTree
        https://bugs.webkit.org/show_bug.cgi?id=27029

        Add USE_SYSTEM_MALLOC macro to the DRT's profile to avoid using TCmalloc in Qt's DRT.

        * DumpRenderTree/qt/DumpRenderTree.pro:

2009-10-01  Zoltan Horvath  <zoltan@webkit.org>

        Reviewed by Simon Hausmann.

        [Qt] Enable TCmalloc for the Linux, Mac and Windows Qt-port
        https://bugs.webkit.org/show_bug.cgi?id=27029

        Remove USE_SYSTEM_MALLOC for Linux, Mac and Windows Qt-port from WebKit.pri,
        so these Qt-ports will use TCmalloc as other ports.

        * WebKit.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoLand expected failure results for two tests on Windows
aroben@apple.com [Thu, 1 Oct 2009 15:35:08 +0000 (15:35 +0000)]
Land expected failure results for two tests on Windows

These failures are covered by <http://webkit.org/b/29963> and
<http://webkit.org/b/29964>.

Rubber-stamped in advance by Eric Carlson.

* platform/win/fast/events/mouse-drag-from-frame-to-other-frame-expected.txt:
Added.
* platform/win/fast/forms/basic-inputs-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRename QWebGraphicsItem to QGraphicsWebView
vestbo@webkit.org [Thu, 1 Oct 2009 15:28:45 +0000 (15:28 +0000)]
Rename QWebGraphicsItem to QGraphicsWebView

Patch by Alexis Menard <alexis.menard@nokia.com> on 2009-10-01
Reviewed by Tor Arne Vestbø.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-01 Dumitru Daniliuc <dumi@chromium.org>
eric@webkit.org [Thu, 1 Oct 2009 15:26:41 +0000 (15:26 +0000)]
2009-10-01  Dumitru Daniliuc  <dumi@chromium.org>

        Reviewed by Dimitri Glazkov.

        Read-only transactions do not change file sizes and therefore
        should not trigger quota updates.

        https://bugs.webkit.org/show_bug.cgi?id=29945

        * storage/SQLTransaction.cpp:
        (WebCore::SQLTransaction::openTransactionAndPreflight):
        (WebCore::SQLTransaction::runStatements):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48973 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-28 Antonio Gomes <tonikitoo@webkit.org>
tonikitoo@webkit.org [Thu, 1 Oct 2009 14:31:08 +0000 (14:31 +0000)]
2009-09-28  Antonio Gomes   <tonikitoo@webkit.org>

    Reviewed by Simon Hausmann.

    https://bugs.webkit.org/show_bug.cgi?id=29248
    [Qt] [API] Make it possible to have 'invisible' loads

    Make QWebFrame's setHtml and setContent methods to not change
    session and global history at all.

    * Api/qwebframe.cpp:
    (QWebFrame::setHtml):
    (QWebFrame::setContent):
    * tests/qwebframe/qwebframe.pro:
    * tests/qwebframe/tst_qwebframe.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix list box scrolling by correctly overriding the scroll()
timothy@apple.com [Thu, 1 Oct 2009 13:18:03 +0000 (13:18 +0000)]
Fix list box scrolling by correctly overriding the scroll()
function on RenderBox.

<rdar://problem/7255440> REGRESSION (r48683): Mousewheel scrolling
of listboxes is broken (29756)

Reviewed by Dan Bernstein.

* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::scroll):
* rendering/RenderListBox.h:
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::scroll):
* rendering/RenderTextControlSingleLine.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-01 Yury Semikhatsky <yurys@chromium.org>
eric@webkit.org [Thu, 1 Oct 2009 13:17:04 +0000 (13:17 +0000)]
2009-10-01  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Timothy Hatcher.

        Make a copy of listeners array before dispatching an event in
        WebInspector.Object.prototype.dispatchEventToListeners. Otherwise if current
        listener removes itself from the array next listener will be skipped.

        https://bugs.webkit.org/show_bug.cgi?id=29920

        * inspector/front-end/Object.js:
        (WebInspector.Object.prototype.dispatchEventToListeners): make a copy of listeners array before dispatching an event

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48970 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-01 Andras Becsi <becsi.andras@stud.u-szeged.hu>
zoltan@webkit.org [Thu, 1 Oct 2009 13:02:37 +0000 (13:02 +0000)]
2009-10-01  Andras Becsi  <becsi.andras@stud.u-szeged.hu>

        Reviewed by Simon Hausmann.

        [Qt] Skip fast/table/008.html until a solution for the crash on the buildbot is found.

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFixed software input panel support on web input elements.
hausmann@webkit.org [Thu, 1 Oct 2009 12:43:49 +0000 (12:43 +0000)]
Fixed software input panel support on web input elements.

Patch by Kristian Amlie <kristian.amlie@nokia.com> on 2009-10-01
Reviewed by Simon Hausmann.

Send the RequestSoftwareInputPanel event if the element supports focus
and the element is clicked.

* Api/qwebpage.cpp:
(QWebPagePrivate::QWebPagePrivate):
(QWebPagePrivate::mousePressEvent):
(QWebPagePrivate::mouseReleaseEvent):
* Api/qwebpage_p.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoImplementation for QWebPage::inputMethodQuery and QWebPagePrivate::inputMethodEvent
hausmann@webkit.org [Thu, 1 Oct 2009 12:43:40 +0000 (12:43 +0000)]
Implementation for QWebPage::inputMethodQuery and QWebPagePrivate::inputMethodEvent

Patch by Joe Ligman <joseph.ligman@nokia.com> on 2009-10-01
Reviewed by Simon Hausmann.

https://bugs.webkit.org/show_bug.cgi?id=29681

Some additional changes from Kristian Amlie <kristian.amlie@nokia.com>:

    * Fixed surrounding text to exclude preedit string
    * Avoid emission of microFocusChanged during setComposition()

* Api/qwebpage.cpp:
(QWebPagePrivate::inputMethodEvent):
(QWebPage::inputMethodQuery):
* WebCoreSupport/EditorClientQt.cpp:
(WebCore::EditorClientQt::respondToChangedSelection):
* tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage::inputMethods):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-01 Jakub Wieczorek <faw217@gmail.com>
eric@webkit.org [Thu, 1 Oct 2009 10:43:22 +0000 (10:43 +0000)]
2009-10-01  Jakub Wieczorek  <faw217@gmail.com>

        Reviewed by Simon Hausmann.

        [Qt] Implement eventSender.scheduleAsynchronousClick().

        https://bugs.webkit.org/show_bug.cgi?id=29931

        * platform/qt/Skipped:
2009-10-01  Jakub Wieczorek  <faw217@gmail.com>

        Reviewed by Simon Hausmann.

        [Qt] Implement eventSender.scheduleAsynchronousClick().

        https://bugs.webkit.org/show_bug.cgi?id=29931

        * DumpRenderTree/qt/jsobjects.cpp:
        (EventSender::scheduleAsynchronousClick):
        * DumpRenderTree/qt/jsobjects.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-01 Jakub Wieczorek <faw217@gmail.com>
eric@webkit.org [Thu, 1 Oct 2009 10:35:53 +0000 (10:35 +0000)]
2009-10-01  Jakub Wieczorek  <faw217@gmail.com>

        Reviewed by Simon Hausmann.

        [Qt] Implement setPopupBlockingEnabled() in the LayoutTestController and remove
        fast/events/open-window-from-another-frame.html from the Skipped list.

        https://bugs.webkit.org/show_bug.cgi?id=29930

        * platform/qt/Skipped:
2009-10-01  Jakub Wieczorek  <faw217@gmail.com>

        Reviewed by Simon Hausmann.

        [Qt] Implement setPopupBlockingEnabled() in the LayoutTestController and remove
        fast/events/open-window-from-another-frame.html from the Skipped list.

        https://bugs.webkit.org/show_bug.cgi?id=29930

        * DumpRenderTree/qt/jsobjects.cpp:
        (LayoutTestController::setPopupBlockingEnabled):
        * DumpRenderTree/qt/jsobjects.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-01 Martin Robinson <martin.james.robinson@gmail.com>
eric@webkit.org [Thu, 1 Oct 2009 09:02:30 +0000 (09:02 +0000)]
2009-10-01  Martin Robinson  <martin.james.robinson@gmail.com>

        Reviewed by Xan Lopez.

        [GTK] GtkIMContext filtering interferes with DOM key events
        https://bugs.webkit.org/show_bug.cgi?id=28733

        Add new key event test ensuring that IME keypresses are handled.

        * GNUmakefile.am:
2009-10-01  Martin Robinson  <martin.james.robinson@gmail.com>

        Reviewed by Xan Lopez.

        [GTK] GtkIMContext filtering interferes with DOM key events
        https://bugs.webkit.org/show_bug.cgi?id=28733

        Re-enable skipped tests which were previously failing.

        * platform/gtk/Skipped:
2009-10-01  Martin Robinson  <martin.james.robinson@gmail.com>

        Reviewed by Xan Lopez.

        [GTK] GtkIMContext filtering interferes with DOM key events
        https://bugs.webkit.org/show_bug.cgi?id=28733

        Ensure that keyboard events filtered by the GtkIMContext still create
        the proper DOM events.

        No tests added. Instead previously skipped tests have been enabled.

        * platform/gtk/KeyEventGtk.cpp:
        (WebCore::keyIdentifierForGdkKeyCode):
        (WebCore::singleCharacterString):
2009-10-01  Martin Robinson  <martin.james.robinson@gmail.com>

        Reviewed by Xan Lopez.

        [GTK] GtkIMContext filtering interferes with DOM key events
        https://bugs.webkit.org/show_bug.cgi?id=28733

        Ensure that keyboard events filtered by the GtkIMContext still create
        the proper DOM events.

        * WebCoreSupport/EditorClientGtk.cpp:
        (WebKit::clearPendingIMData):
        (WebKit::imContextCommitted):
        (WebKit::imContextPreeditChanged):
        (WebKit::EditorClient::shouldBeginEditing):
        (WebKit::EditorClient::shouldEndEditing):
        (WebKit::interpretEditorCommandKeyEvent):
        (WebKit::handleCaretBrowsingKeyboardEvent):
        (WebKit::EditorClient::handleKeyboardEvent):
        (WebKit::EditorClient::handleInputMethodKeydown):
        * tests/testkeyevents.c: Added.
        (test_info_new):
        (test_info_destroy):
        (key_event_fixture_setup):
        (key_event_fixture_teardown):
        (key_press_event_cb):
        (key_release_event_cb):
        (load_status_cb):
        (map_event_cb):
        (test_keypress):
        (main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-10-01 Philippe Normand <pnormand@igalia.com>
eric@webkit.org [Thu, 1 Oct 2009 08:19:35 +0000 (08:19 +0000)]
2009-10-01  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] data: uri support in media player
        https://bugs.webkit.org/show_bug.cgi?id=29842

        Check presence of gstreamer-pbutils-0.10.

        * configure.ac:
2009-10-01  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] data: uri support in media player
        https://bugs.webkit.org/show_bug.cgi?id=29842

        Re-enable media/audio-data-url.html.

        * platform/gtk/Skipped:
2009-10-01  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] data: uri support in media player
        https://bugs.webkit.org/show_bug.cgi?id=29842

        New GStreamer element to handle data: uris. For now only base64
        encoded data is supported. Decoded data is handed over to
        giostreamsrc.

        * GNUmakefile.am:
        * platform/graphics/gtk/DataSourceGStreamer.cpp: Added.
        (_do_init):
        (webkit_data_src_base_init):
        (webkit_data_src_class_init):
        (webkit_data_src_reset):
        (webkit_data_src_init):
        (webkit_data_src_finalize):
        (webkit_data_src_uri_get_type):
        (webkit_data_src_uri_get_protocols):
        (webkit_data_src_uri_get_uri):
        (webkit_data_src_uri_set_uri):
        (webkit_data_src_uri_handler_init):
        * platform/graphics/gtk/DataSourceGStreamer.h: Added.
        * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::do_gst_init):
        (WebCore::MediaPlayerPrivate::MediaPlayerPrivate):
        (WebCore::MediaPlayerPrivate::mimeTypeCache):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUnreviewed.
cam@webkit.org [Thu, 1 Oct 2009 06:24:19 +0000 (06:24 +0000)]
Unreviewed.

Added myself to the list of committers.

* Scripts/modules/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-30 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Thu, 1 Oct 2009 05:56:03 +0000 (05:56 +0000)]
2009-09-30  Daniel Bates  <dbates@webkit.org>

        Reviewed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=29944

        Reduces false positives in the XSSAuditor by explicitly allowing requests
        that do not contain illegal URI characters.

        As a side effect of this change, the tests property-inject.html,
        property-escape-noquotes.html, and property-escape-noquotes-tab-slash-chars.html
        fail because these attacks do not contain any illegal URI characters and
        thus are now allowed by the XSSAuditor, where previously they weren't. A future
        change may reinstate this functionality.

        Tests: http/tests/security/xssAuditor/script-tag-safe2.html
               http/tests/security/xssAuditor/script-tag-safe3.html

        * page/XSSAuditor.cpp:
        (WebCore::isIllegalURICharacter): Added method.
        (WebCore::XSSAuditor::canEvaluate):
        (WebCore::XSSAuditor::canCreateInlineEventListener):
        (WebCore::XSSAuditor::findInRequest): Added parameter
        allowRequestIfNoIllegalURICharacters.
        * page/XSSAuditor.h:
2009-09-30  Daniel Bates  <dbates@webkit.org>

        Reviewed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=29944

        Tests that the XSSAuditor allows requests that do not contain illegal URI
        characters.

        Added a notice regarding the failure of tests property-inject.html,
        property-escape-noquotes.html and property-escape-noquotes-tab-slash-chars.html,
        and rebased the expected results of these tests.

        * http/tests/security/xssAuditor/property-escape-noquotes-expected.txt:
        * http/tests/security/xssAuditor/property-escape-noquotes-tab-slash-chars-expected.txt:
        * http/tests/security/xssAuditor/property-escape-noquotes-tab-slash-chars.html:
        * http/tests/security/xssAuditor/property-escape-noquotes.html:
        * http/tests/security/xssAuditor/property-inject-expected.txt:
        * http/tests/security/xssAuditor/property-inject.html:
        * http/tests/security/xssAuditor/resources/safe-script-noquotes.js: Added.
        * http/tests/security/xssAuditor/resources/script-tag-safe2.html: Added.
        * http/tests/security/xssAuditor/resources/script-tag-safe3.html: Added.
        * http/tests/security/xssAuditor/script-tag-safe2-expected.txt: Added.
        * http/tests/security/xssAuditor/script-tag-safe2.html: Added.
        * http/tests/security/xssAuditor/script-tag-safe3-expected.txt: Added.
        * http/tests/security/xssAuditor/script-tag-safe3.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoreproducible freeze and crash on closing form popup at bosch-home.nl
oliver@apple.com [Thu, 1 Oct 2009 05:52:56 +0000 (05:52 +0000)]
reproducible freeze and crash on closing form popup at bosch-home.nl
https://bugs.webkit.org/show_bug.cgi?id=28948

Reviewed by Maciej Stachowiak.

showModalDialog calls getDirect on what is actually a window shell,
so ends up not getting a value (since no value can ever be placed
directly on the shell), which leads to incorrect behaviour.

We use a manual test rather than automatic as it was not
possible to get a modal run loop to work inside DRT.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-30 Kent Tamura <tkent@chromium.org>
eric@webkit.org [Thu, 1 Oct 2009 05:49:39 +0000 (05:49 +0000)]
2009-09-30  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Adler.

        Add ValidityState.tooLong support for <input> and <textarea>.
        https://bugs.webkit.org/show_bug.cgi?id=27454

        * fast/forms/ValidityState-tooLong-input-expected.txt: Added.
        * fast/forms/ValidityState-tooLong-input.html: Added.
        * fast/forms/ValidityState-tooLong-textarea-expected.txt: Added.
        * fast/forms/ValidityState-tooLong-textarea.html: Added.
        * fast/forms/script-tests/ValidityState-tooLong-input.js: Added.
        * fast/forms/script-tests/ValidityState-tooLong-textarea.js: Added.
2009-09-30  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Adler.

        Adds ValidityState.tooLong support for <input> and <textarea>.

        Introduces tooLong() in HTMLFormControlElement and it always returns false.
        HTMLInputElement and HTMLTextAreaElement overrides it and checks the text
        length and maxLength.  tooLong() should work only for `dirty' values.
        So, introduces m_isDirty flag for HTMLTextAreaElement, and
        !m_data.value().isNull() works as a dirty flag for HTMLInputElement.

        Renames parameter names of setMaxLength().

        https://bugs.webkit.org/show_bug.cgi?id=27454

        Tests: fast/forms/ValidityState-tooLong-input.html
               fast/forms/ValidityState-tooLong-textarea.html

        * html/HTMLFormControlElement.h:
        (WebCore::HTMLFormControlElement::tooLong):
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::tooLong):
        (WebCore::HTMLInputElement::setMaxLength):
        * html/HTMLInputElement.h:
        * html/HTMLTextAreaElement.cpp:
        (WebCore::HTMLTextAreaElement::HTMLTextAreaElement):
        (WebCore::HTMLTextAreaElement::reset):
        (WebCore::HTMLTextAreaElement::updateValue):
        (WebCore::HTMLTextAreaElement::setMaxLength):
        (WebCore::HTMLTextAreaElement::tooLong):
        * html/HTMLTextAreaElement.h:
        * html/ValidityState.h:
        (WebCore::ValidityState::tooLong):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-30 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 1 Oct 2009 04:25:41 +0000 (04:25 +0000)]
2009-09-30  Adam Barth  <abarth@webkit.org>

        Reviewed by Maciej Stachowiak.

        Factor RedirectScheduler out of FrameLoader
        https://bugs.webkit.org/show_bug.cgi?id=29948

        This change introduces a new sub-object of Frame, redirectScheduler.
        The redirectScheduler is responsible for scheduling redirects.

        This change leaves the code for the redirectScheduler in
        FrameLoader.cpp.  A future change will move the class into its own
        file.

        No behavior change (hopefully!).

        * loader/FrameLoader.cpp:
        (WebCore::RedirectScheduler::RedirectScheduler):
        (WebCore::RedirectScheduler::~RedirectScheduler):
        (WebCore::RedirectScheduler::redirectScheduledDuringLoad):
        (WebCore::RedirectScheduler::clear):
        (WebCore::FrameLoader::FrameLoader):
        (WebCore::FrameLoader::setDefersLoading):
        (WebCore::FrameLoader::stopLoading):
        (WebCore::FrameLoader::didOpenURL):
        (WebCore::FrameLoader::didExplicitOpen):
        (WebCore::FrameLoader::cancelAndClear):
        (WebCore::FrameLoader::clear):
        (WebCore::FrameLoader::checkCompleted):
        (WebCore::FrameLoader::isScheduledLocationChangePending):
        (WebCore::FrameLoader::scheduleHTTPRedirection):
        (WebCore::RedirectScheduler::scheduleRedirect):
        (WebCore::RedirectScheduler::mustLockBackForwardList):
        (WebCore::FrameLoader::scheduleLocationChange):
        (WebCore::RedirectScheduler::scheduleLocationChange):
        (WebCore::FrameLoader::scheduleFormSubmission):
        (WebCore::RedirectScheduler::scheduleFormSubmission):
        (WebCore::FrameLoader::scheduleRefresh):
        (WebCore::RedirectScheduler::scheduleRefresh):
        (WebCore::RedirectScheduler::locationChangePending):
        (WebCore::FrameLoader::scheduleHistoryNavigation):
        (WebCore::RedirectScheduler::scheduleHistoryNavigation):
        (WebCore::RedirectScheduler::timerFired):
        (WebCore::FrameLoader::provisionalLoadStarted):
        (WebCore::RedirectScheduler::schedule):
        (WebCore::RedirectScheduler::startTimer):
        (WebCore::RedirectScheduler::cancel):
        (WebCore::FrameLoader::completed):
        (WebCore::FrameLoader::open):
        * loader/FrameLoader.h:
        (WebCore::FrameLoader::committedFirstRealDocumentLoad):
        * page/Frame.cpp:
        (WebCore::Frame::Frame):
        (WebCore::Frame::redirectScheduler):
        * page/Frame.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBuild fix, not reviewed.
mjs@apple.com [Thu, 1 Oct 2009 03:37:01 +0000 (03:37 +0000)]
Build fix, not reviewed.

More Windows build fixes for https://bugs.webkit.org/show_bug.cgi?id=29943

* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::willSendRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBuild fix, not reviewed.
mjs@apple.com [Thu, 1 Oct 2009 03:14:09 +0000 (03:14 +0000)]
Build fix, not reviewed.

Fix windows build for fix for https://bugs.webkit.org/show_bug.cgi?id=29943

* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::willSendRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-30 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 1 Oct 2009 02:59:33 +0000 (02:59 +0000)]
2009-09-30  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Fisher.

        [V8] HTMLAudioElement, HTMLImageElement, and HTMLOptionElement are constructable, but they shouldn't be.
        Only Audio, Image, and Option should be constructable.
        https://bugs.webkit.org/show_bug.cgi?id=29940

        Test: fast/dom/dom-constructor.html

        * WebCore.gypi: Added new files to project.
        * bindings/scripts/CodeGeneratorV8.pm: Modified to generate custom constructors.
        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::getTemplate): Removed handling of HTMLImageElement, HTMLOptionElement
          and HTMLAudioElement construction.
        * bindings/v8/V8HTMLAudioElementConstructor.h: Added.
        * bindings/v8/V8HTMLImageElementConstructor.h: Added.
        * bindings/v8/V8HTMLOptionElementConstructor.h: Added.
        * bindings/v8/V8Index.cpp: Added new headers.
        * bindings/v8/V8Index.h: Added Audio, Image and Option decls.
        * bindings/v8/custom/V8CustomBinding.h: Ditto.
        * bindings/v8/custom/V8DOMWindowCustom.cpp:
        (WebCore::ACCESSOR_GETTER): Added custom constructors.
        * bindings/v8/custom/V8HTMLAudioElementConstructor.cpp:
        (WebCore::V8HTMLImageElementConstructor::GetTemplate): Added custom template creator.
        * bindings/v8/custom/V8HTMLOptionElementConstructor.cpp:
        (WebCore::V8HTMLOptionElementConstructor::GetTemplate): Ditto.
        * bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
        (WebCore::V8HTMLImageElementConstructor::GetTemplate): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-30 Gabor Loki <loki@inf.u-szeged.hu>
eric@webkit.org [Thu, 1 Oct 2009 01:13:02 +0000 (01:13 +0000)]
2009-09-30  Gabor Loki  <loki@inf.u-szeged.hu>

        Reviewed by George Staikos.

        Defines two pseudo-platforms for ARM and Thumb-2 instruction set.
        https://bugs.webkit.org/show_bug.cgi?id=29122

        Introduces WTF_PLATFORM_ARM_TRADITIONAL and WTF_PLATFORM_ARM_THUMB2
        macros on ARM platforms. The PLATFORM(ARM_THUMB2) should be used
        when Thumb-2 instruction set is the required target. The
        PLATFORM(ARM_TRADITIONAL) is for generic ARM instruction set. In
        case where the code is common the PLATFORM(ARM) have to be used.

        Modified by George Wright  <gwright@rim.com> to correctly work
        with the RVCT-defined __TARGET_ARCH_ARM and __TARGET_ARCH_THUMB
        compiler macros, as well as adding readability changes.

        * wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-30 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Thu, 1 Oct 2009 01:09:09 +0000 (01:09 +0000)]
2009-09-30  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Brady Eidson.

        307 redirects should pass along http body and Content-Type header
        https://bugs.webkit.org/show_bug.cgi?id=29943

        Follow-up fix for:
        <rdar://problem/3802660> SAP: 307 (Temporary Redirect) responses should use POST, not GET

        Test: http/tests/loading/resources/redirect-methods-result.php

        * platform/network/cf/ResourceHandleCFNet.cpp:
        (WebCore::willSendRequest): Pass along http body and Content-Type header.
        * platform/network/mac/ResourceHandleMac.mm:
        (-[WebCoreResourceHandleAsDelegate connection:willSendRequest:redirectResponse:]): ditto
2009-09-30  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Brady Eidson.

        307 redirects should pass along http body and Content-Type header
        https://bugs.webkit.org/show_bug.cgi?id=29943

        Follow-up fix for:
        <rdar://problem/3802660> SAP: 307 (Temporary Redirect) responses should use POST, not GET

        * http/tests/loading/redirect-methods.html: Updated test to show the http body and content-type header.
        * http/tests/loading/redirect-methods-expected.txt:
        * http/tests/loading/resources/redirect-methods-result.php:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFixed https://bugs.webkit.org/show_bug.cgi?id=29941
ggaren@apple.com [Thu, 1 Oct 2009 00:40:10 +0000 (00:40 +0000)]
Fixed https://bugs.webkit.org/show_bug.cgi?id=29941
REGRESSION (r48882-r48888): Many memory leaks on SnowLeopard leaks bot

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-30
Reviewed by Mark Rowe.

Forgot to implement a destructor for JSDOMWindowBaseData, so it was
leaking its RefPtr data member.

* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::destroyJSDOMWindowBaseData):
* bindings/js/JSDOMWindowBase.h:
(WebCore::JSDOMWindowBase::JSDOMWindowBaseData::JSDOMWindowBaseData::JSDOMWindowBaseData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoMake sure the removal of user stylesheets results in all of the WebViews being updated to
hyatt@apple.com [Thu, 1 Oct 2009 00:13:39 +0000 (00:13 +0000)]
Make sure the removal of user stylesheets results in all of the WebViews being updated to
reflect the changes.

Reviewed by Tim Hatcher.

* page/PageGroup.cpp:
(WebCore::PageGroup::removeUserContentWithURLForWorld):
(WebCore::PageGroup::removeUserContentForWorld):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-30 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Wed, 30 Sep 2009 22:30:46 +0000 (22:30 +0000)]
2009-09-30  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Dimitri Glazkov.

        Use a script-tests directory rather than a resources directory for DOM Storage
        https://bugs.webkit.org/show_bug.cgi?id=29938

        Use a script-tests directory rather than a resources directory for DOM Storage.
        This matches up with what's been done elsewhere in the tree.

        * storage/domstorage/localstorage/clear.html:
        * storage/domstorage/resources: Removed.
        * storage/domstorage/resources/clear.js: Removed.
        * storage/domstorage/script-tests: Copied from LayoutTests/storage/domstorage/resources.
        * storage/domstorage/sessionstorage/clear.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-30 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 30 Sep 2009 22:06:17 +0000 (22:06 +0000)]
2009-09-30  Eric Seidel  <eric@webkit.org>

        No review, just adding Geoff to the list of reviewers.

        * Scripts/modules/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoDevirtualise array toString conversion
oliver@apple.com [Wed, 30 Sep 2009 21:32:51 +0000 (21:32 +0000)]
Devirtualise array toString conversion

Reviewed by Geoff Garen.

Tweak the implementation of Array.prototype.toString to have a fast path
when acting on a true JSArray.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoREGRESSION(r47440): drop down menus at americanexpress.com disappear on mouse out
mitz@apple.com [Wed, 30 Sep 2009 21:15:03 +0000 (21:15 +0000)]
REGRESSION(r47440): drop down menus at americanexpress.com disappear on mouse out
https://bugs.webkit.org/show_bug.cgi?id=29209

Reviewed by Sam Weinig.

WebCore:

Test: fast/inline/relative-positioned-overflow.html

* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::computeVerticalOverflow): Add self-painting
inlines to overflow to ensure that they are included in hit-testing.

LayoutTests:

* fast/inline/relative-positioned-overflow-expected.txt: Added.
* fast/inline/relative-positioned-overflow.html: Added.
* platform/mac/fast/repaint/transform-absolute-in-positioned-container-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix for <rdar://problem/7259706>
weinig@apple.com [Wed, 30 Sep 2009 20:56:33 +0000 (20:56 +0000)]
Fix for <rdar://problem/7259706>
Need WebKit API or SPI on Mac and Windows to test whether it's safe to load a page in a new tab/window

Reviewed by Dan Bernstein.

WebKit/mac:

* WebView/WebFrame.mm:
(-[WebFrame _allowsFollowingLink:]):
* WebView/WebFramePrivate.h:

WebKit/win:

* Interfaces/IWebFramePrivate.idl:
* WebFrame.cpp:
(WebFrame::allowsFollowingLink):
* WebFrame.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-30 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 30 Sep 2009 20:19:35 +0000 (20:19 +0000)]
2009-09-30  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Mark Rowe.

        transforms/3d tests are not run in Release builds
        https://bugs.webkit.org/show_bug.cgi?id=29827

        Make sure we export the WebCoreHas3DRendering symbol in Release builds,
        because this symbols is used by run-webkit-tests (via 'nm') to detect whether
        WebCore was built with ENABLE_3D_RENDERING turned on.

        * DerivedSources.make:
        * WebCore.3DRendering.exp: Added.
        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdded the WebKit Layout Tests fonts that are referenced in
mitz@apple.com [Wed, 30 Sep 2009 19:44:34 +0000 (19:44 +0000)]
Added the WebKit Layout Tests fonts that are referenced in
LayoutTests/platform/win/css2.1/resources/Mac-compatible-font-fallback.css

Reviewed by Sam Weinig.

* DumpRenderTree/fonts/WebKit Layout Tests 2.ttf: Added.
* DumpRenderTree/fonts/WebKit Layout Tests.ttf: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd the failed URL to the ErrorPageExtension, as it is quite
kenneth@webkit.org [Wed, 30 Sep 2009 19:38:05 +0000 (19:38 +0000)]
Add the failed URL to the ErrorPageExtension, as it is quite
useful for creating error pages.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-09-30
Reviewed by David Hyatt.

* Api/qwebpage.h:
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::callErrorPageExtension):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBuild fix for QT. Didn't know WebCore.pro existed.
jorlow@chromium.org [Wed, 30 Sep 2009 19:33:02 +0000 (19:33 +0000)]
Build fix for QT.  Didn't know WebCore.pro existed.

Patch by Jeremy Orlow <jorlow@chromium.org> on 2009-09-30
* WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore: Add a method for removal of user scripts and stylesheets by URL from a speci...
hyatt@apple.com [Wed, 30 Sep 2009 19:25:57 +0000 (19:25 +0000)]
WebCore: Add a method for removal of user scripts and stylesheets by URL from a specific world.

Reviewed by Adam Roben.

* page/PageGroup.cpp:
(WebCore::PageGroup::removeUserContentURLForWorld):
* page/PageGroup.h:

WebKit/mac: Add the ability to remove user stylesheets and scripts by URL.

Reviewed by Adam Roben.

* WebView/WebView.mm:
(+[WebView _removeUserContentFromGroup:url:worldID:]):
* WebView/WebViewPrivate.h:

WebKit/win: Add the ability to remove user stylesheets and scripts by URL.

Reviewed by Adam Roben.

* Interfaces/IWebViewPrivate.idl:
* WebView.cpp:
(WebView::removeUserContentWithURLFromGroup):
* WebView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-30 Chris Hawk <hawk@chromium.org>
eric@webkit.org [Wed, 30 Sep 2009 19:01:12 +0000 (19:01 +0000)]
2009-09-30  Chris Hawk  <hawk@chromium.org>

        Reviewed by Dimitri Glazkov.

        Fix for conditionals in the WebCore gyp file, which contained two separate
        'conditions' values for the webcore target. The first entry was ignored,
        resulting in some missine defines.
        https://bugs.webkit.org/show_bug.cgi?id=29907

        * WebCore.gyp/WebCore.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-21 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Wed, 30 Sep 2009 18:52:39 +0000 (18:52 +0000)]
2009-09-21  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Adam Barth.

        DOM Storage needs to be more careful about where "ThreadSafe" objects are destroyed.
        https://bugs.webkit.org/show_bug.cgi?id=29265

        DOM Storage needs to be more careful about where "ThreadSafe" objects are
        destroyed.  With the current code, there actually isn't a race condition, but
        it sure would be easy for someone to introduce one.  A bunch of
        ThreadSafeShared objects have RefPtrs to objects that are NOT ThreadSafeShared
        objects.  If it were possible any of these objects' destructors to be fired off
        the main thread, then the you'd have a race condition.  The code should be more
        clear and self-documenting about how things related to each other.

        Since the lifetime of a LocalStorageTask is bounded by the LocalStorageThread
        which is bounded by the StorageSyncManager, StorageAreaImpl, and
        StorageAreaSync, there's no reason for LocalStorageTask to store anything other
        than pointers.  By breaking this dependency, we can eliminate the risk.

        Note that we _could_ have LocalStorageThread's task queue just store
        LocalStorageTask*'s rather than RefPtr<LocalStorageTask>s but then we'd need to
        manually take care of deleting.  It'd probably also be possible to change
        LocalStorageThread around so that it needn't hold onto a reference of itself
        and have a more deterministic shutdown, but my initial attempts to do so
        failed, and I decided it wasn't worth changing.  The queue is killed before
        hand, so the thread is 100% impotent before the main thread continues anyway.

        The constructors and destructors of StorageSyncManager, StorageAreaImpl, and
        StorageAreaSync now have ASSERTs to verify they're running on the main thread.
        I'm fairly positive that it'd be impossible to hit these asserts and the fact
        that these classes are no longer ThreadSafeShared should make it clear how
        they're meant to be used, but I think it's worth it to be extra sure.  Of
        course, ideally, we'd have such an assert every time a ref is incremented or
        decremented.

        Behavior should be unchanged and this is just an internal code cleanup, so no
        new tests.

        * storage/LocalStorageTask.cpp:
        (WebCore::LocalStorageTask::LocalStorageTask):
        (WebCore::LocalStorageTask::performTask):
        * storage/LocalStorageTask.h:
        (WebCore::LocalStorageTask::createImport):
        (WebCore::LocalStorageTask::createSync):
        (WebCore::LocalStorageTask::createTerminate):
        * storage/LocalStorageThread.cpp:
        (WebCore::LocalStorageThread::scheduleImport):
        (WebCore::LocalStorageThread::scheduleSync):
        * storage/LocalStorageThread.h:
        * storage/StorageArea.h:
        * storage/StorageAreaImpl.cpp:
        (WebCore::StorageAreaImpl::~StorageAreaImpl):
        (WebCore::StorageAreaImpl::StorageAreaImpl):
        * storage/StorageAreaSync.cpp:
        (WebCore::StorageAreaSync::StorageAreaSync):
        (WebCore::StorageAreaSync::~StorageAreaSync):
        * storage/StorageSyncManager.cpp:
        (WebCore::StorageSyncManager::StorageSyncManager):
        (WebCore::StorageSyncManager::~StorageSyncManager):
        (WebCore::StorageSyncManager::scheduleImport):
        (WebCore::StorageSyncManager::scheduleSync):
        * storage/StorageSyncManager.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48939 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBuildfix for platforms using JSVALUE32.
ggaren@apple.com [Wed, 30 Sep 2009 18:26:28 +0000 (18:26 +0000)]
Buildfix for platforms using JSVALUE32.
https://bugs.webkit.org/show_bug.cgi?id=29915

Patch by Csaba Osztrogonac <oszi@inf.u-szeged.hu> on 2009-09-30
Reviewed by Geoffrey Garen.

After http://trac.webkit.org/changeset/48905 the build broke in JSVALUE32 case.
Also removed unreachable code.

* jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_add):
 - Declaration of "OperandTypes types" moved before first use.
 - Typos fixed: dst modified to result, regT2 added.
 - Unreachable code removed.
(JSC::JIT::emitSlow_op_add):
 - Missing declaration of "OperandTypes types" added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48938 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-28 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Wed, 30 Sep 2009 18:17:12 +0000 (18:17 +0000)]
2009-09-28  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Darin Fisher.

        Chromium needs to be able to override the way storage events are delivered
        https://bugs.webkit.org/show_bug.cgi?id=29655

        Chromium needs to be able to override the way storage events are delivered.
        This replaced https://bugs.webkit.org/show_bug.cgi?id=29257 because it'll be
        faster (no vtables and extra allocation) and somewhat cleaner (no dependency
        injection).  This is necessary because Chromium needs to transport events across
        a process barrier and then dispatch them without use of a Frame*.

        Behavior should not change with this, so no updates to tests.

        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * storage/StorageAreaImpl.cpp:
        (WebCore::StorageAreaImpl::setItem):
        (WebCore::StorageAreaImpl::removeItem):
        (WebCore::StorageAreaImpl::clear):
        * storage/StorageAreaImpl.h:
        * storage/StorageEventDispatcher.cpp: Copied from WebCore/storage/StorageAreaImpl.cpp.
        (WebCore::StorageEventDispatcher::dispatch):
        * storage/StorageEventDispatcher.h: Added.  (Well, technically in the other half of this patch.)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoVersioning.
mrowe@apple.com [Wed, 30 Sep 2009 18:15:19 +0000 (18:15 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48936 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoNeed to check NULL frame in EventHandler::updateDragAndDrop.
jianli@chromium.org [Wed, 30 Sep 2009 17:52:33 +0000 (17:52 +0000)]
Need to check NULL frame in EventHandler::updateDragAndDrop.
https://bugs.webkit.org/show_bug.cgi?id=29929

Reviewed by Darin Adler.

WebCore:

Test: http/tests/misc/drag-over-iframe-invalid-source-crash.html

* page/EventHandler.cpp:
(WebCore::EventHandler::updateDragAndDrop):

LayoutTests:

Add a new test for the bug.

* http/tests/misc/drag-over-iframe-invalid-source-crash-expected.txt: Added.
* http/tests/misc/drag-over-iframe-invalid-source-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48934 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoSet the svn:mime-type property of recently-added PNG files to image/png.
mitz@apple.com [Wed, 30 Sep 2009 17:33:54 +0000 (17:33 +0000)]
Set the svn:mime-type property of recently-added PNG files to image/png.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-29 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 30 Sep 2009 17:21:48 +0000 (17:21 +0000)]
2009-09-29  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        ASSERTION FAILED: !repaintContainer || repaintContainer == this
        https://bugs.webkit.org/show_bug.cgi?id=29755

        Generalize the fix for this bug to account for cases where there may be multiple
        containing blocks between the repaint container, and the container of the element
        being repainted.

        Test: compositing/repaint/opacity-between-absolute2.html

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::mapLocalToContainer):
        Call offsetFromAncestorContainer() to get the correct offset.

        (WebCore::RenderBox::computeRectForRepaint): Ditto
        * rendering/RenderInline.cpp:
        (WebCore::RenderInline::computeRectForRepaint): Ditto.

        * rendering/RenderObject.h:
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::offsetFromAncestorContainer):
        New method that computes an offset from some object in the ancestor container() chain.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-30 Csaba Osztrogonac <oszi@inf.u-szeged.hu>
ddkilzer@apple.com [Wed, 30 Sep 2009 17:15:22 +0000 (17:15 +0000)]
2009-09-30  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>

        Reviewed by David Kilzer.

        Make sunspider scripts work on Windows platform.
        https://bugs.webkit.org/show_bug.cgi?id=29656

        * Scripts/run-sunspider: Perl scripts invoked with same Perl interpreter.
        * Scripts/sunspider-compare-results: Perl scripts invoked with same Perl interpreter.
        * Scripts/webkitdirs.pm: currentPerlPath() added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-30 Yaar Schnitman <yaar@chromium.org>
eric@webkit.org [Wed, 30 Sep 2009 17:13:11 +0000 (17:13 +0000)]
2009-09-30  Yaar Schnitman  <yaar@chromium.org>

        Reviewed by Dimitri Glazkov.

        1. Keeping up with downstream revisions.
        2. Turning off v8 snapshot build step.

        https://bugs.webkit.org/show_bug.cgi?id=29928

        * chromium/DEPS

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-30 Andras Becsi <becsi.andras@stud.u-szeged.hu>
eric@webkit.org [Wed, 30 Sep 2009 15:35:10 +0000 (15:35 +0000)]
2009-09-30  Andras Becsi  <becsi.andras@stud.u-szeged.hu>

        Reviewed by Simon Hausmann.

        [Qt] Fix TextCodecQt::decode method after r48752 to return a non-null string if the length of the input is 0.
        This fixes https://bugs.webkit.org/show_bug.cgi?id=29736.

        * platform/text/qt/TextCodecQt.cpp:
        (WebCore::TextCodecQt::decode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoReduce heap size on Symbian from 64MB to 8MB.
hausmann@webkit.org [Wed, 30 Sep 2009 14:20:07 +0000 (14:20 +0000)]
Reduce heap size on Symbian from 64MB to 8MB.

Patch by Janne Koskinen <janne.p.koskinen@digia.com> on 2009-09-30
Reviewed by Simon Hausmann.

This is not a perfect fix, it requires more fine tuning.
But this makes it possible again to debug in the emulator,
which is more important in order to be able to fix other
run-time issues.

* runtime/Collector.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[Qt] Update Skipped after #48873 and some expected files, whose
hausmann@webkit.org [Wed, 30 Sep 2009 12:16:33 +0000 (12:16 +0000)]
[Qt] Update Skipped after #48873 and some expected files, whose
problems are the same (default font size reconciliation
16px/13px), but the previous update didn't contain them.

Patch by Renata Hodovan <hodovan.renata@stud.u-szeged.hu> on 2009-09-30
Reviewed by Simon Hausmann.

* platform/qt/Skipped:
* platform/qt/css2.1/t040103-ident-04-c-expected.txt:
* platform/qt/css2.1/t0402-c71-fwd-parsing-00-f-expected.txt:
* platform/qt/css2.1/t040304-c64-uri-00-a-g-expected.txt:
* platform/qt/css2.1/t040306-syntax-01-f-expected.txt:
* platform/qt/css2.1/t1202-counter-05-b-expected.txt:
* platform/qt/css2.1/t140201-c535-bg-fixd-00-b-g-expected.txt:
* platform/qt/css2.1/t1507-c526-font-sz-03-f-a-expected.txt:
* platform/qt/css2.1/t170602-bdr-conflct-w-00-d-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-30 Shinichiro Hamaji <hamaji@chromium.org>
eric@webkit.org [Wed, 30 Sep 2009 12:02:00 +0000 (12:02 +0000)]
2009-09-30  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by David Levin.

        Move message-port-multi.js from resources to script-tests
        https://bugs.webkit.org/show_bug.cgi?id=29798

        Revert r48823. message-port-multi.js needs custom HTML.

        * fast/events/message-port-multi-expected.txt:
        * fast/events/message-port-multi.html:
        * fast/events/resources/message-port-multi.js: Added.
        (channel.port2.onmessage):
        * fast/events/script-tests/message-port-multi.js: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-30 Shinichiro Hamaji <hamaji@chromium.org>
eric@webkit.org [Wed, 30 Sep 2009 10:49:08 +0000 (10:49 +0000)]
2009-09-30  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by David Kilzer.

        Change remaining references in tests from bugzilla.opendarwin.org to bugs.webkit.org
        https://bugs.webkit.org/show_bug.cgi?id=12140

        Fixes for JS files.

        * fast/js/date-preserve-milliseconds-expected.txt:
        * fast/js/script-tests/array-float-delete.js:
        * fast/js/script-tests/array-tostring-ignore-separator.js:
        * fast/js/script-tests/date-big-setmonth.js:
        * fast/js/script-tests/date-negative-setmonth.js:
        * fast/js/script-tests/date-preserve-milliseconds.js:
        * fast/js/script-tests/number-tofixed.js:
        * fast/js/script-tests/object-extra-comma.js:
        * fast/js/script-tests/object-prototype-constructor.js:
        * fast/js/script-tests/object-prototype-toLocaleString.js:
        * fast/js/script-tests/regexp-lastindex.js:
        * fast/js/script-tests/regexp-stack-overflow.js:
        * fast/js/script-tests/string-split-ignore-case.js:
        * fast/js/script-tests/toString-exception.js:
        * fast/js/script-tests/toString-overrides.js:
        * fast/js/script-tests/toString-stack-overflow.js:
        * fast/js/toString-stack-overflow-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-30 Steve Block <steveblock@google.com>
eric@webkit.org [Wed, 30 Sep 2009 08:55:48 +0000 (08:55 +0000)]
2009-09-30  Steve Block  <steveblock@google.com>

        Reviewed by Darin Adler.

        Geolocation LayoutTests should use an HTML template.
        https://bugs.webkit.org/show_bug.cgi?id=29179

        Updates Geolocation LayoutTests to correctly use an HTML template so that
        individual HTML files can be generated using make-script-test-wrappers.
        This requires a new js-test-post.js which allows for asynchronous tests.

        * fast/dom/Geolocation/resources/TEMPLATE.html: Modified. Updated to use new js-test-post.js.
        * fast/dom/Geolocation/resources/js-test-post.js: Added. Allows for asynchronous tests.

        * fast/dom/Geolocation/resources/argument-types.js: Modified. Sepcifies synchronous test.
        * fast/dom/Geolocation/argument-types.html: Modified. Updated to use new js-test-post.js.

        * fast/dom/Geolocation/resources/callback-exception.js: Modified. Specifies asynchronous test.
        * fast/dom/Geolocation/callback-exception.html: Modified. Updated to use new js-test-post.js.
        * fast/dom/Geolocation/callback-exception-expected.txt: Modified. Adds successfullyParsed.

        * fast/dom/Geolocation/resources/enabled.js: Modified. Sepcifies synchronous test.
        * fast/dom/Geolocation/enabled.html: Modified. Updated to use new js-test-post.js.

        * fast/dom/Geolocation/resources/error.js: Modified. Specifies asynchronous test.
        * fast/dom/Geolocation/error.html: Modified. Updated to use new js-test-post.js.
        * fast/dom/Geolocation/error-expected.txt: Modified. Adds successfullyParsed.

        * fast/dom/Geolocation/resources/permission-denied.js: Modified. Specifies asynchronous test.
        * fast/dom/Geolocation/permission-denied.html: Modified. Updated to use new js-test-post.js.
        * fast/dom/Geolocation/permission-denied-expected.txt: Modified. Adds successfullyParsed.

        * fast/dom/Geolocation/resources/permission-denied-stops-watches.js: Modified. Specifies asynchronous test.
        * fast/dom/Geolocation/permission-denied-stops-watches.html: Modified. Updated to use new js-test-post.js.
        * fast/dom/Geolocation/permission-denied-stops-watches-expected.txt: Modified. Adds successfullyParsed.

        * fast/dom/Geolocation/resources/position-string.js: Modified. Specifies asynchronous test.
        * fast/dom/Geolocation/position-string.html: Modified. Updated to use new js-test-post.js.
        * fast/dom/Geolocation/position-string-expected.txt: Modified. Adds successfullyParsed.

        * fast/dom/Geolocation/resources/reentrant-error.js: Modified. Specifies asynchronous test.
        * fast/dom/Geolocation/reentrant-error.html: Modified. Updated to use new js-test-post.js.
        * fast/dom/Geolocation/reentrant-error-expected.txt: Modified. Adds successfullyParsed.

        * fast/dom/Geolocation/resources/reentrant-success.js: Modified. Specifies asynchronous test.
        * fast/dom/Geolocation/reentrant-success.html: Modified. Updated to use new js-test-post.js.
        * fast/dom/Geolocation/reentrant-success-expected.txt: Modified. Adds successfullyParsed.

        * fast/dom/Geolocation/resources/success.js: Modified. Specifies asynchronous test.
        * fast/dom/Geolocation/success.html: Modified. Updated to use new js-test-post.js.
        * fast/dom/Geolocation/success-expected.txt: Modified. Adds successfullyParsed.

        * fast/dom/Geolocation/resources/timeout.js: Modified. Specifies asynchronous test.
        * fast/dom/Geolocation/timeout.html: Modified. Updated to use new js-test-post.js.
        * fast/dom/Geolocation/timeout-expected.txt: Modified. Adds successfullyParsed.

        * fast/dom/Geolocation/resources/timeout-zero.js: Modified. Specifies asynchronous test.
        * fast/dom/Geolocation/timeout-zero.html: Modified. Updated to use new js-test-post.js.
        * fast/dom/Geolocation/timeout-zero-expected.txt: Modified. Adds successfullyParsed.

        * fast/dom/Geolocation/resources/watch.js: Modified. Specifies asynchronous test.
        * fast/dom/Geolocation/watch.html: Updated to use new js-test-post.js.
        * fast/dom/Geolocation/watch-expected.txt: Modified. Adds successfullyParsed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-30 Csaba Osztrogonac <oszi@inf.u-szeged.hu>
eric@webkit.org [Wed, 30 Sep 2009 08:13:03 +0000 (08:13 +0000)]
2009-09-30  Csaba Osztrogonac  <oszi@inf.u-szeged.hu>

        Reviewed by Darin Adler.

        Platform specific null device replaced with a platform independent.
        https://bugs.webkit.org/show_bug.cgi?id=29544

        * sunspider: Using File::Spec->devnull() instead of /dev/null and NUL.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix CRASH() macro for Symbian build.
hausmann@webkit.org [Wed, 30 Sep 2009 07:48:40 +0000 (07:48 +0000)]
Fix CRASH() macro for Symbian build.

Patch by Janne Koskinen <janne.p.koskinen@digia.com> on 2009-09-30
Reviewed by Simon Hausmann.

* wtf/Assertions.h: Added missing }

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-29 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Wed, 30 Sep 2009 06:55:11 +0000 (06:55 +0000)]
2009-09-29  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Eric Seidel.

        Change remaining references in tests from bugzilla.opendarwin.org to bugs.webkit.org
        https://bugs.webkit.org/show_bug.cgi?id=12140

        Remove opendarwin URLs from href="".
        This change doesn't change pixel test results.

        * editing/pasteboard/display-block-on-spans.html:
        * editing/pasteboard/drop-text-without-selection.html:
        * editing/pasteboard/paste-text-019.html:
        * editing/selection/6476.html:
        * editing/selection/7152-1.html:
        * editing/selection/7152-2.html:
        * editing/selection/after-line-wrap.html:
        * editing/selection/click-start-of-line.html:
        * editing/selection/leave-requested-block.html:
        * editing/selection/select-from-textfield-outwards.html:
        * fast/block/basic/text-indent-rtl.html:
        * fast/block/float/nopaint-after-layer-destruction.html:
        * fast/block/float/nopaint-after-layer-destruction2.html:
        * fast/block/float/table-relayout.html:
        * fast/block/float/vertical-move-relayout.html:
        * fast/block/positioning/height-change.html:
        * fast/block/positioning/relayout-on-position-change.html:
        * fast/block/positioning/window-height-change.html:
        * fast/css-generated-content/hover-style-change.html: Added property allow-tabs.
        * fast/css/error-in-last-decl.html:
        * fast/css/ex-after-font-variant.html:
        * fast/css/find-next-layer.html:
        * fast/css/first-letter-detach.html:
        * fast/css/font-shorthand-weight-only.html:
        * fast/css/hover-subselector.html:
        * fast/css/invalidation-errors-2.html:
        * fast/css/invalidation-errors-3.html:
        * fast/css/invalidation-errors.html:
        * fast/css/resize-corner-tracking.html:
        * fast/css/rtl-ordering.html:
        * fast/css/universal-hover-quirk.html:
        * fast/dom/Element/class-attribute-whitespace.html: Added property allow-tabs.
        * fast/dom/HTMLHeadElement/head-link-style-href-check.html:
        * fast/dom/HTMLLinkElement/pending-stylesheet-count.html:
        * fast/dynamic/layer-hit-test-crash.html:
        * fast/dynamic/selection-highlight-adjust.html:
        * fast/encoding/resources/%25%u0435 0 %xx%%%ulike.html:
        * fast/events/event-sender-mouse-moved.html:
        * fast/events/resources/drag-outside-window-frame.html:
        * fast/forms/button-cannot-be-nested.html:
        * fast/forms/button-generated-content.html:
        * fast/forms/button-inner-block-reuse.html:
        * fast/forms/button-white-space.html:
        * fast/forms/floating-textfield-relayout.html:
        * fast/forms/form-hides-table.html:
        * fast/forms/visual-hebrew-text-field.html:
        * fast/history/clicked-link-is-visited.html:
        * fast/history/resources/clicked-link-is-visited-2.html:
        * fast/inline-block/overflow-clip.html:
        * fast/invalid/missing-address-end-tag.html:
        * fast/invalid/missing-dl-end-tag.html:
        * fast/invalid/missing-dt-end-tag.html:
        * fast/invalid/missing-font-end-tag.html:
        * fast/js/exception-linenums-in-html-3.html:
        * fast/js/missing-style-end-tag-js.html:
        * fast/layers/opacity-outline.html:
        * fast/lists/list-style-none-crash.html:
        * fast/lists/markers-in-selection.html:
        * fast/lists/scrolled-marker-paint.html:
        * fast/overflow/image-selection-highlight.html:
        * fast/overflow/overflow-rtl-inline-scrollbar.html:
        * fast/parser/broken-comments-vs-parsing-mode.html:
        * fast/parser/nofoo-tags-inside-paragraph.html:
        * fast/parser/remove-block-in-residual-style.html:
        * fast/repaint/backgroundSizeRepaint.html:
        * fast/repaint/border-repaint-glitch.html:
        * fast/repaint/bugzilla-3509.html:
        * fast/repaint/bugzilla-5699.html:
        * fast/repaint/bugzilla-6278.html:
        * fast/repaint/bugzilla-6388.html:
        * fast/repaint/bugzilla-6473.html:
        * fast/repaint/bugzilla-7235.html:
        * fast/repaint/clipped-relative.html:
        * fast/repaint/containing-block-position-change.html:
        * fast/repaint/flexible-box-overflow-horizontal.html:
        * fast/repaint/flexible-box-overflow.html:
        * fast/repaint/float-move-during-layout.html:
        * fast/repaint/inline-outline-repaint.html:
        * fast/repaint/layer-outline-horizontal.html:
        * fast/repaint/layer-outline.html:
        * fast/repaint/line-overflow.html:
        * fast/repaint/outline-repaint-glitch.html:
        * fast/repaint/outline-shrinking.html:
        * fast/repaint/repaint-resized-overflow.html:
        * fast/repaint/static-to-positioned.html:
        * fast/repaint/table-cell-move.html:
        * fast/repaint/table-extra-bottom-grow.html:
        * fast/repaint/text-shadow-horizontal.html:
        * fast/repaint/text-shadow.html:
        * fast/replaced/applet-rendering-java-disabled.html:
        * fast/replaced/image-solid-color-with-alpha.html:
        * fast/replaced/inline-box-wrapper-handover.html:
        * fast/replaced/pdf-as-image.html:
        * fast/table/absolute-table-at-bottom.html:
        * fast/table/add-before-anonymous-child.html:
        * fast/table/border-collapsing/003.html:
        * fast/table/border-collapsing/border-collapsing-head-foot.html:
        * fast/table/border-collapsing/rtl-border-collapsing.html:
        * fast/table/cell-absolute-child.html:
        * fast/table/click-near-anonymous-table.html:
        * fast/table/edge-offsets.html:
        * fast/table/empty-section-crash.html:
        * fast/table/fixed-table-non-cell-in-row.html:
        * fast/table/form-with-table-style.html:
        * fast/table/row-height-recalc.html:
        * fast/table/rtl-cell-display-none-assert.html:
        * fast/table/text-field-baseline.html:
        * fast/text/atsui-small-caps-punctuation-size.html:
        * fast/text/atsui-spacing-features.html:
        * fast/text/basic/015.html:
        * fast/text/capitalize-empty-generated-string.html:
        * fast/text/in-rendered-text-rtl.html:
        * fast/text/international/rtl-caret.html:
        * fast/text/midword-break-hang.html:
        * fast/text/whitespace/pre-wrap-overflow-selection.html:
        * fast/text/whitespace/pre-wrap-spaces-after-newline.html:
        * fast/tokenizer/missing-style-end-tag-1.html:
        * fast/tokenizer/missing-style-end-tag-2.html:
        * fast/tokenizer/missing-title-end-tag-1.html:
        * fast/tokenizer/missing-title-end-tag-2.html:
        * http/tests/misc/iframe404.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoInlined a few math operations.
ggaren@apple.com [Wed, 30 Sep 2009 04:46:57 +0000 (04:46 +0000)]
Inlined a few math operations.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-09-29
Reviewed by Gavin Barraclough.

~1% SunSpider speedup.

* jit/JIT.h:
* jit/JITArithmetic.cpp:
(JSC::JIT::compileBinaryArithOpSlowCase):
(JSC::JIT::emitSlow_op_add):
(JSC::JIT::emitSlow_op_mul):
(JSC::JIT::emit_op_sub):
(JSC::JIT::emitSlow_op_sub): Don't take a stub call when operating on
a constant int and a double.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix a couple of bugs with patterns. Move the setting of the document URL to before...
hyatt@apple.com [Wed, 30 Sep 2009 02:46:52 +0000 (02:46 +0000)]
Fix a couple of bugs with patterns.  Move the setting of the document URL to before the style
selector gets constructed so that pattern match testing gets the correct URL.

Reviewed by Jon Honeycutt.

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::begin):
* page/UserContentURLPattern.cpp:
(WebCore::UserContentURLPattern::parse):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Rubber-stamped by Brady Eidson.
ap@apple.com [Wed, 30 Sep 2009 02:02:47 +0000 (02:02 +0000)]
    Rubber-stamped by Brady Eidson.

        Assertion failure in http/tests/xmlhttprequest/failed-auth.html.

        I couldn't find out why this only started to happen now, but it was incorrect to check
        persistence of a credential returned by CredentialStorage::get() without checking that it
        was non-null. When there is no credential for the protection space in storage, get()
        returns a new object, and Credentil constructor doesn't initialize m_persistence.

        * platform/network/mac/ResourceHandleMac.mm:
        (-[WebCoreSynchronousLoader connection:didReceiveAuthenticationChallenge:]): Moved the
        assertion after credential null check.
        (WebCore::ResourceHandle::didReceiveAuthenticationChallenge): Added the same persistence
        assertion, matching sync code (and CF one, as well).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRubberstamped by Dan Bernstein.
beidson@apple.com [Wed, 30 Sep 2009 02:00:44 +0000 (02:00 +0000)]
Rubberstamped by Dan Bernstein.

Fix license and some sorting in new files.

WebKit/mac:

* WebView/WebHistoryDelegate.h:
* WebView/WebNavigationData.h:
* WebView/WebNavigationData.mm:

WebKitTools:

* DumpRenderTree/mac/HistoryDelegate.h:
* DumpRenderTree/mac/HistoryDelegate.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2009-09-29 Yaar Schnitman <yaar@chromium.org>
eric@webkit.org [Wed, 30 Sep 2009 01:46:26 +0000 (01:46 +0000)]
2009-09-29  Yaar Schnitman  <yaar@chromium.org>

        Reviewed by David Kilzer.

        Fixed how error codes are handled.
        https://bugs.webkit.org/show_bug.cgi?id=29898

        * Scripts/update-webkit:
        * Scripts/update-webkit-chromium:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUpdated way-out-of-date sorting throughout the dump methods/flags.
beidson@apple.com [Wed, 30 Sep 2009 01:36:42 +0000 (01:36 +0000)]
Updated way-out-of-date sorting throughout the dump methods/flags.

Reviewed by John Sullivan.

* DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(dumpAsPDFCallback):
(dumpAsTextCallback):
(dumpFrameLoadCallbacksCallback):
(dumpResourceLoadCallbacksCallback):
(LayoutTestController::staticFunctions):

* DumpRenderTree/LayoutTestController.h:
(LayoutTestController::dumpAsText):
(LayoutTestController::setDumpAsText):
(LayoutTestController::dumpFrameLoadCallbacks):
(LayoutTestController::setDumpFrameLoadCallbacks):
(LayoutTestController::dumpSelectionRect):
(LayoutTestController::setDumpSelectionRect):
(LayoutTestController::dumpSourceAsWebArchive):
(LayoutTestController::setDumpSourceAsWebArchive):
(LayoutTestController::dumpStatusCallbacks):
(LayoutTestController::setDumpStatusCallbacks):
(LayoutTestController::dumpTitleChanges):
(LayoutTestController::setDumpTitleChanges):
(LayoutTestController::dumpWillCacheResponse):
(LayoutTestController::setDumpWillCacheResponse):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebKit Mac API should provide a delegate interface for global history.
beidson@apple.com [Wed, 30 Sep 2009 01:35:33 +0000 (01:35 +0000)]
WebKit Mac API should provide a delegate interface for global history.
<rdar://problem/7042773> and https://webkit.org/b/29904

Reviewed by John Sullivan.

WebKit:

* WebKit.xcodeproj/project.pbxproj:

WebKit/mac:

* WebView/WebHistoryDelegate.h: Added. New interface for WebKit clients to implement to manage
  their own global history store.

Object to store all of the bits of data relevant to a page visit:
* WebView/WebNavigationData.h: Added.
* WebView/WebNavigationData.mm: Added.
(-[WebNavigationDataPrivate dealloc]):
(-[WebNavigationData initWithURLString:title:originalRequest:response:hasSubstituteData:clientRedirectSource:]):
(-[WebNavigationData url]):
(-[WebNavigationData title]):
(-[WebNavigationData originalRequest]):
(-[WebNavigationData response]):
(-[WebNavigationData hasSubstituteData]):
(-[WebNavigationData clientRedirectSource]):
(-[WebNavigationData dealloc]):

* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::updateGlobalHistory): If the delegate exists, don't use the built-in WebHistory.
  If the implementation for this method exists, call it.
(WebFrameLoaderClient::updateGlobalHistoryRedirectLinks): Ditto

* WebView/WebDelegateImplementationCaching.h:
* WebView/WebDelegateImplementationCaching.mm:
(WebViewGetHistoryDelegateImplementations):
(CallHistoryDelegate):

* WebView/WebView.mm:
(-[WebView _cacheHistoryDelegateImplementations]):
(-[WebView setHistoryDelegate:]):
(-[WebView historyDelegate]):
* WebView/WebViewData.h:
* WebView/WebViewPrivate.h:

WebKitTools:

Adding the dumping of global history delegate callbacks.

* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:

Automatically dump history delegate callbacks for tests with "globalhistory/" in their URL:
* DumpRenderTree/mac/DumpRenderTree.mm:
(createWebViewAndOffscreenWindow):
(allocateGlobalControllers):
(shouldLogFrameLoadDelegates):
(shouldLogHistoryDelegates):
(runTest):

Dump history delegate callbacks:
* DumpRenderTree/mac/HistoryDelegate.h: Added.
* DumpRenderTree/mac/HistoryDelegate.mm: Added.
(-[HistoryDelegate webView:didNavigateWithNavigationData:inFrame:]):
(-[HistoryDelegate webView:didPerformClientRedirectFromURL:toURL:inFrame:]):
(-[HistoryDelegate webView:didPerformServerRedirectFromURL:toURL:inFrame:]):

LayoutTests:

* http/tests/globalhistory: Added.
* http/tests/globalhistory/history-delegate-basic-302-redirect-expected.txt: Added.
* http/tests/globalhistory/history-delegate-basic-302-redirect.html: Added.
* http/tests/globalhistory/history-delegate-basic-refresh-redirect-expected.txt: Added.
* http/tests/globalhistory/history-delegate-basic-refresh-redirect.html: Added.
* http/tests/resources/notify-done.html: Added.
* http/tests/resources/redirect.php: Augment to optionally do "Refresh:"-style redirects.

Skip these new tests on all platforms that don't have history delegates (yet):
* platform/gtk/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48914 268f45cc-cd09-0410-ab3c-d52691b4dbfc