akling@apple.com [Fri, 15 Feb 2013 21:30:17 +0000 (21:30 +0000)]
ShareableElementData should use zero-length array for storage.
<http://webkit.org/b/109959>
Reviewed by Anders Carlsson.
Use a zero-length Attribute array instead of always casting from void* to an array.
It was done this way originally because I didn't know we could sidestep the MSVC
build error with some #pragma hackery.
* dom/DocumentSharedObjectPool.cpp:
(WebCore::DocumentSharedObjectPool::cachedShareableElementDataWithAttributes):
* dom/Element.cpp:
(WebCore::sizeForShareableElementDataWithAttributeCount):
(WebCore::ShareableElementData::ShareableElementData):
(WebCore::ShareableElementData::~ShareableElementData):
(WebCore::UniqueElementData::UniqueElementData):
* dom/Element.h:
(ShareableElementData):
(WebCore::ElementData::attributeItem):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143044
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Fri, 15 Feb 2013 21:18:20 +0000 (21:18 +0000)]
Implement RenderGrid::computeIntrinsicLogicalWidths
https://bugs.webkit.org/show_bug.cgi?id=109881
Reviewed by Tony Chang.
For now this is not observable due to the FIXMEs for unimplemented bits
of computePreferredLogicalWidths. But, soon, I'll be removing the computePreferredLogicalWidths
override entirely and instead use RenderBlock's, which will also address the
RenderGrid FIXMEs.
* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::computeIntrinsicLogicalWidths):
const_cast the usages of m_grid. Alternately, we could stack allocate it, but there's disagreement on
whether that's the right choice. See https://bugs.webkit.org/show_bug.cgi?id=109880.
(WebCore::RenderGrid::computePreferredLogicalWidths):
* rendering/RenderGrid.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143043
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 15 Feb 2013 21:16:39 +0000 (21:16 +0000)]
Flexbox should ignore firstLine pseudo element.
https://bugs.webkit.org/show_bug.cgi?id=104485
Patch by Xueqing Huang <huangxueqing@baidu.com> on 2013-02-15
Reviewed by Tony Chang.
Source/WebCore:
Spec[1] said that "None of the properties defined in this module
apply to '::first-line' or '::first-letter' pseudo-elements." and
css2[2] define "The :first-line pseudo-element can only be attached
to a block container element."
[1]http://dev.w3.org/csswg/css3-flexbox/#display-flex
[2]http://www.w3.org/TR/CSS2/selector.html#first-line-pseudo
tests:
css3/flexbox/flexbox-ignore-firstLine.html
css3/flexbox/flexitem-firstLine-valid.html
css3/flexbox/inline-flexbox-ignore-firstLine.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::firstLineBlock):
LayoutTests:
Spec[1] said that "None of the properties defined in this module
apply to '::first-line' or '::first-letter' pseudo-elements." and
css2[2] define "The :first-line pseudo-element can only be attached
to a block container element."
[1]http://dev.w3.org/csswg/css3-flexbox/#display-flex
[2]http://www.w3.org/TR/CSS2/selector.html#first-line-pseudo
some case by Kenny Lu <kanghaol@oupeng.com>
* css3/flexbox/flex-item-firstLine-valid-expected.txt: Added.
* css3/flexbox/flex-item-firstLine-valid.html: Added.
* css3/flexbox/flexbox-ignore-firstLine-expected.txt: Added.
* css3/flexbox/flexbox-ignore-firstLine.html: Added.
* css3/flexbox/inline-flexbox-ignore-firstLine-expected.txt: Added.
* css3/flexbox/inline-flexbox-ignore-firstLine.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143042
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Fri, 15 Feb 2013 21:05:33 +0000 (21:05 +0000)]
Unreviewed, rolling out parts of r142731.
http://trac.webkit.org/changeset/142731
https://bugs.webkit.org/show_bug.cgi?id=109672
This patch broke the GTK+ gyp build. Roll out the changes there,
since they were actually unnecessary.
* gyp/Configuration.gypi.in:
* gyp/Dependencies.gyp:
* gyp/JavaScriptCore.gyp:
* gyp/WTF.gyp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143039
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 15 Feb 2013 21:03:03 +0000 (21:03 +0000)]
A storage area should know its storage type
https://bugs.webkit.org/show_bug.cgi?id=109964
Reviewed by Andreas Kling.
* WebProcess/Storage/StorageAreaProxy.cpp:
(WebKit::StorageAreaProxy::StorageAreaProxy):
(WebKit::StorageAreaProxy::disabledByPrivateBrowsingInFrame):
* WebProcess/Storage/StorageAreaProxy.h:
(StorageAreaProxy):
* WebProcess/Storage/StorageNamespaceProxy.cpp:
(WebKit::StorageNamespaceProxy::storageType):
(WebKit):
* WebProcess/Storage/StorageNamespaceProxy.h:
(StorageNamespaceProxy):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143038
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alecflett@chromium.org [Fri, 15 Feb 2013 21:01:49 +0000 (21:01 +0000)]
IndexedDB: Implement SharedBuffer version of put()
https://bugs.webkit.org/show_bug.cgi?id=109092
Reviewed by Adam Barth.
Source/WebCore:
Switch IDBDatabaseBackendInterface::put over
to SharedBuffer, to avoid buffer copies of the value.
No new tests, this is a refactor.
* Modules/indexeddb/IDBBackingStore.cpp:
(WebCore::IDBBackingStore::putRecord):
* Modules/indexeddb/IDBBackingStore.h:
(WebCore):
(IDBBackingStore):
* Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::PutOperation::create):
(WebCore::PutOperation::PutOperation):
(PutOperation):
(WebCore::IDBDatabaseBackendImpl::put):
* Modules/indexeddb/IDBDatabaseBackendImpl.h:
(IDBDatabaseBackendImpl):
* Modules/indexeddb/IDBDatabaseBackendInterface.h:
(WebCore):
* Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::put):
Source/WebKit/chromium:
Implement SharedBuffer/WebData version of
IDBDatabaseBackendInterface::put, and put
temporary scaffolding in until chrome is ready.
* src/IDBDatabaseBackendProxy.cpp:
(WebKit::IDBDatabaseBackendProxy::put):
* src/IDBDatabaseBackendProxy.h:
(IDBDatabaseBackendProxy):
* src/WebIDBDatabaseImpl.cpp:
(WebKit::WebIDBDatabaseImpl::put):
(WebKit):
* src/WebIDBDatabaseImpl.h:
(WebIDBDatabaseImpl):
* tests/IDBDatabaseBackendTest.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143037
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pdr@google.com [Fri, 15 Feb 2013 20:56:45 +0000 (20:56 +0000)]
Rebaseline 7 SVG tests after r142765.
Unreviewed rebaseline of test expectations.
* platform/chromium-linux/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.png:
* platform/chromium-linux/svg/as-image/img-preserveAspectRatio-support-2-expected.png:
* platform/chromium-linux/svg/as-image/svg-image-change-content-size-expected.png:
* platform/chromium-linux/svg/wicd/test-scalable-background-image1-expected.png:
* platform/chromium-linux/svg/wicd/test-scalable-background-image2-expected.png:
* platform/chromium-mac-lion/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.png:
* platform/chromium-mac-lion/svg/as-image/img-preserveAspectRatio-support-2-expected.png:
* platform/chromium-mac-lion/svg/as-image/svg-image-change-content-size-expected.png:
* platform/chromium-mac-lion/svg/wicd/test-scalable-background-image1-expected.png:
* platform/chromium-mac-lion/svg/wicd/test-scalable-background-image2-expected.png:
* platform/chromium-mac-snowleopard/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.png:
* platform/chromium-mac-snowleopard/svg/as-image/svg-image-change-content-size-expected.png:
* platform/chromium-mac-snowleopard/svg/wicd/test-scalable-background-image1-expected.png:
* platform/chromium-mac-snowleopard/svg/wicd/test-scalable-background-image2-expected.png:
* platform/chromium-mac/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.png:
* platform/chromium-mac/svg/as-image/img-preserveAspectRatio-support-2-expected.png:
* platform/chromium-mac/svg/as-image/svg-image-change-content-size-expected.png:
* platform/chromium-mac/svg/as-image/svg-non-integer-scaled-image-expected.png:
* platform/chromium-mac/svg/wicd/test-scalable-background-image1-expected.png:
* platform/chromium-mac/svg/wicd/test-scalable-background-image2-expected.png:
* platform/chromium-win/svg/as-image/animated-svg-as-image-no-fixed-intrinsic-size-expected.png:
* platform/chromium-win/svg/as-image/img-preserveAspectRatio-support-2-expected.png:
* platform/chromium-win/svg/as-image/svg-image-change-content-size-expected.png:
* platform/chromium-win/svg/as-image/svg-non-integer-scaled-image-expected.png:
* platform/chromium-win/svg/wicd/test-scalable-background-image1-expected.png:
* platform/chromium-win/svg/wicd/test-scalable-background-image2-expected.png:
* platform/chromium/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143036
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enne@google.com [Fri, 15 Feb 2013 20:50:00 +0000 (20:50 +0000)]
[chromium] Mark inspector/profiler/heap-snapshot-get-profile-crash.html flaky crasher
https://bugs.webkit.org/show_bug.cgi?id=109963
Unreviewed gardening.
* platform/chromium/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143035
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 15 Feb 2013 20:49:08 +0000 (20:49 +0000)]
Implement StorageAreaProxy::length
https://bugs.webkit.org/show_bug.cgi?id=109962
Reviewed by Andreas Kling.
Source/WebCore:
Export a symbol needed by WebKit2.
* WebCore.exp.in:
Source/WebKit2:
* WebProcess/Storage/StorageAreaProxy.cpp:
(WebKit::StorageAreaProxy::length):
Load the values if needed and then return the length.
(WebKit::StorageAreaProxy::disabledByPrivateBrowsingInFrame):
Add helper function.
(WebKit::StorageAreaProxy::loadValuesIfNeeded):
Just allocate the hash map for now.
* WebProcess/Storage/StorageAreaProxy.h:
(StorageAreaProxy):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143034
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zandobersek@gmail.com [Fri, 15 Feb 2013 20:45:54 +0000 (20:45 +0000)]
webkit-patch suggest-reviewers should limit itself to 5 reviewers
https://bugs.webkit.org/show_bug.cgi?id=107528
Reviewed by Eric Seidel.
* Scripts/webkitpy/common/checkout/checkout.py:
(Checkout.suggested_reviewers): Iterate through the sorted commit info list,
scraping reviewers from the commit information and in the end producing a list
of reviewers that's sorted from the most to least recent activity of any reviewer
that has reviewed or authored patches for the changed files.
* Scripts/webkitpy/tool/commands/queries.py:
(SuggestReviewers): Use the SuggestReviewers step instead of reimplementing much of
the same logic.
(SuggestReviewers._prepare_state): Force the reviewer suggestion because the option
defaults to False.
* Scripts/webkitpy/tool/steps/suggestreviewers.py:
(SuggestReviewers.run): Only list the first five suggested reviewers, now printed out
on a single line. Only ask for CC-ing the suggested reviewers to the bug if the
bug ID is located in the command's state.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143033
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aelias@chromium.org [Fri, 15 Feb 2013 20:35:33 +0000 (20:35 +0000)]
[chromium] WebInputEventBuilders should not reverse page scale
https://bugs.webkit.org/show_bug.cgi?id=109901
Reviewed by James Robinson.
Though in theory logical that if WebInputEvent -> PlatformEvent
conversions divide by page scale, then the reverse builders should
multiply, in reality the only user of the reverse builders is
plugins which expect the same coordinate space as WebCore.
* src/WebInputEventConversion.cpp:
(WebKit::updateWebMouseEventFromWebCoreMouseEvent):
(WebKit::WebMouseEventBuilder::WebMouseEventBuilder):
(WebKit::addTouchPoints):
(WebKit::WebGestureEventBuilder::WebGestureEventBuilder):
* tests/WebInputEventConversionTest.cpp:
(WebCore::TEST):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143032
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 15 Feb 2013 20:05:57 +0000 (20:05 +0000)]
Remove const from a bunch of StorageArea member functions
https://bugs.webkit.org/show_bug.cgi?id=109957
Reviewed by Beth Dakin.
Source/WebCore:
StorageArea is an abstract base class, and its subclasses might want to mutate the object
when certain member functions are called so remove const from all member functions.
* storage/StorageArea.h:
(WebCore):
(StorageArea):
(WebCore::StorageArea::~StorageArea):
(WebCore::StorageArea::incrementAccessCount):
(WebCore::StorageArea::decrementAccessCount):
(WebCore::StorageArea::closeDatabaseIfIdle):
* storage/StorageAreaImpl.cpp:
(WebCore::StorageAreaImpl::canAccessStorage):
(WebCore::StorageAreaImpl::length):
(WebCore::StorageAreaImpl::key):
(WebCore::StorageAreaImpl::getItem):
(WebCore::StorageAreaImpl::contains):
(WebCore::StorageAreaImpl::memoryBytesUsedByCache):
* storage/StorageAreaImpl.h:
(StorageAreaImpl):
Source/WebKit/chromium:
Update for WebCore changes.
* src/StorageAreaProxy.cpp:
(WebCore::StorageAreaProxy::length):
(WebCore::StorageAreaProxy::key):
(WebCore::StorageAreaProxy::getItem):
(WebCore::StorageAreaProxy::contains):
(WebCore::StorageAreaProxy::canAccessStorage):
(WebCore::StorageAreaProxy::memoryBytesUsedByCache):
* src/StorageAreaProxy.h:
(StorageAreaProxy):
Source/WebKit2:
Update for WebCore changes.
* WebProcess/Storage/StorageAreaProxy.cpp:
(WebKit::StorageAreaProxy::length):
(WebKit::StorageAreaProxy::key):
(WebKit::StorageAreaProxy::getItem):
(WebKit::StorageAreaProxy::contains):
(WebKit::StorageAreaProxy::canAccessStorage):
(WebKit::StorageAreaProxy::memoryBytesUsedByCache):
* WebProcess/Storage/StorageAreaProxy.h:
(StorageAreaProxy):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143031
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 15 Feb 2013 19:59:41 +0000 (19:59 +0000)]
DeleteButtonController::enable and disable should be called via a RAII object
https://bugs.webkit.org/show_bug.cgi?id=109550
Reviewed by Enrica Casucci.
Added DeleteButtonControllerDisableScope, a friend class of DeleteButtonController,
and made DeleteButtonController::enable/disable private.
* dom/ContainerNode.cpp:
* editing/CompositeEditCommand.cpp:
(WebCore::EditCommandComposition::unapply):
(WebCore::EditCommandComposition::reapply):
(WebCore::CompositeEditCommand::apply):
* editing/DeleteButtonController.h:
(WebCore):
(DeleteButtonController):
(DeleteButtonControllerDisableScope):
(WebCore::DeleteButtonControllerDisableScope::DeleteButtonControllerDisableScope):
(WebCore::DeleteButtonControllerDisableScope::~DeleteButtonControllerDisableScope):
* editing/markup.cpp:
(WebCore::createMarkup):
(WebCore::createFragmentFromNodes):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143030
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pdr@google.com [Fri, 15 Feb 2013 19:58:06 +0000 (19:58 +0000)]
Rebaseline 4 svg/zoom/page tests after r142765
Unreviewed rebaseline of test expectations.
* platform/chromium-linux/svg/zoom/page/zoom-background-images-expected.png:
* platform/chromium-linux/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
* platform/chromium-linux/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.png:
* platform/chromium-linux/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png:
* platform/chromium-mac-lion/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
* platform/chromium-mac-snowleopard/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
* platform/chromium-mac/svg/zoom/page/zoom-background-images-expected.png:
* platform/chromium-mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
* platform/chromium-mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.png:
* platform/chromium-mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png:
* platform/chromium-win/svg/zoom/page/zoom-background-images-expected.png:
* platform/chromium-win/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.png:
* platform/chromium-win/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.png:
* platform/chromium-win/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.png:
* platform/chromium/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143029
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mvujovic@adobe.com [Fri, 15 Feb 2013 19:54:53 +0000 (19:54 +0000)]
Source/WebCore: Add code from other branch.
[CSS Shaders] Parse src property in @-webkit-filter at-rules
https://bugs.webkit.org/show_bug.cgi?id=109770
Reviewed by Dean Jackson.
This patch implements the parsing for the CSS src property in @-webkit-filter at-rules.
The Filter Effects spec [1] specifies its syntax:
src: [ <uri> [format(<string>)]?]#
In practice, it can look like:
src: url(shader.vs) format('x-shader/x-vertex'),
url(shader.fs) format('x-shader/x-fragment');
This src property is similar to the src property in CSS font-face rules, but a little
different. The CSS Fonts spec [2] specifies:
src: [ <uri> [format(<string>#)]? | <font-face-name> ]#
The syntax for a <font-face-name> is a unique font face name enclosed by "local("
and ")".
Unlike the filter src property, the font face src property accepts the local function
[e.g. src: local("SomeFont");]. Also, the font face src property accepts a list of strings
instead of just one string in its format function.
[1]: https://dvcs.w3.org/hg/FXTF/raw-file/tip/filters/index.html#custom-filter-src
[2]: http://www.w3.org/TR/css3-fonts/#src-desc
Tests: css3/filters/custom-with-at-rule-syntax/parsing-src-property-invalid.html
css3/filters/custom-with-at-rule-syntax/parsing-src-property-valid.html
* css/CSSGrammar.y.in:
Set (and unset) a flag called "m_inFilterRule", which tells us if we are in a
@-webkit-filter at-rule or in a @font-face at-rule when we encounter a src property.
We parse the two variants of the src property separately so that we can create different
objects (WebKitCSSShaderValue vs. CSSFontFaceSrcValue) and because their syntax is a
little different.
* css/CSSParser.cpp:
(WebCore::CSSParser::CSSParser):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseFilterRuleSrcUriAndFormat):
Parses a URI and format pair found in the @-webkit-filter src property.
(WebCore::CSSParser::parseFilterRuleSrc):
Parse the @-webkit-filter src property.
* css/CSSParser.h:
(CSSParser):
* css/WebKitCSSShaderValue.cpp:
(WebCore::WebKitCSSShaderValue::customCssText):
WebKitCSSShaderValue now has an m_format member, which needs to be included in its
cssText.
(WebCore::WebKitCSSShaderValue::reportDescendantMemoryUsage):
* css/WebKitCSSShaderValue.h:
(WebCore::WebKitCSSShaderValue::format):
(WebCore::WebKitCSSShaderValue::setFormat):
(WebKitCSSShaderValue):
LayoutTests: [CSS Shaders] Parse src property in @-webkit-filter at-rules
https://bugs.webkit.org/show_bug.cgi?id=109770
Reviewed by Dean Jackson.
Add positive and negative parsing tests for the @-webkit-filter src property.
* css3/filters/custom-with-at-rule-syntax/parsing-src-property-invalid-expected.txt: Added.
* css3/filters/custom-with-at-rule-syntax/parsing-src-property-invalid.html: Added.
* css3/filters/custom-with-at-rule-syntax/parsing-src-property-valid-expected.txt: Added.
* css3/filters/custom-with-at-rule-syntax/parsing-src-property-valid.html: Added.
* css3/filters/custom-with-at-rule-syntax/script-tests/parsing-src-property-invalid.js: Added.
(testInvalidSrcProperty):
* css3/filters/custom-with-at-rule-syntax/script-tests/parsing-src-property-valid.js: Added.
(testSrcProperty):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143028
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Fri, 15 Feb 2013 19:54:09 +0000 (19:54 +0000)]
Merged the global function cache into the source code cache
https://bugs.webkit.org/show_bug.cgi?id=108660
Reviewed by Sam Weinig.
Responding to review comments by Darin Adler.
../JavaScriptCore:
* runtime/CodeCache.h:
(JSC::SourceCodeKey::SourceCodeKey): Don't initialize m_name and m_flags
in the hash table deleted value because they're meaningless.
../WTF:
* wtf/HashTraits.h: Added a using directive to simplify client code.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143027
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pdr@google.com [Fri, 15 Feb 2013 19:53:17 +0000 (19:53 +0000)]
Rebaseline 4 tests after r142765
Unreviewed rebaseline of test expectations.
* platform/chromium-linux/css2.1/
20110323/background-intrinsic-004-expected.png:
* platform/chromium-linux/css2.1/
20110323/background-intrinsic-005-expected.png:
* platform/chromium-linux/svg/as-border-image/svg-as-border-image-expected.png:
* platform/chromium-linux/svg/as-image/same-image-two-instances-expected.png:
* platform/chromium-mac-lion/css2.1/
20110323/background-intrinsic-004-expected.png:
* platform/chromium-mac-lion/css2.1/
20110323/background-intrinsic-005-expected.png:
* platform/chromium-mac-lion/svg/as-border-image/svg-as-border-image-expected.png:
* platform/chromium-mac-snowleopard/css2.1/
20110323/background-intrinsic-004-expected.png:
* platform/chromium-mac-snowleopard/css2.1/
20110323/background-intrinsic-005-expected.png:
* platform/chromium-mac/css2.1/
20110323/background-intrinsic-004-expected.png:
* platform/chromium-mac/css2.1/
20110323/background-intrinsic-005-expected.png:
* platform/chromium-mac/svg/as-border-image/svg-as-border-image-expected.png:
* platform/chromium-mac/svg/as-image/same-image-two-instances-expected.png:
* platform/chromium-win/css2.1/
20110323/background-intrinsic-004-expected.png:
* platform/chromium-win/css2.1/
20110323/background-intrinsic-005-expected.png:
* platform/chromium-win/svg/as-border-image/svg-as-border-image-expected.png:
* platform/chromium-win/svg/as-image/same-image-two-instances-expected.png:
* platform/chromium/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143026
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pablof@motorola.com [Fri, 15 Feb 2013 19:50:33 +0000 (19:50 +0000)]
Unreviewed. Add myself as a committer.
* Scripts/webkitpy/common/config/committers.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143025
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fpizlo@apple.com [Fri, 15 Feb 2013 19:47:44 +0000 (19:47 +0000)]
DFG AbstractState should filter operands to NewArray more precisely
https://bugs.webkit.org/show_bug.cgi?id=109900
Reviewed by Mark Hahnenberg.
NewArray for primitive indexing types speculates that the inputs are the appropriate
primitives. Now, the CFA filters the abstract state accordingly, as well.
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143024
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pdr@google.com [Fri, 15 Feb 2013 19:46:32 +0000 (19:46 +0000)]
Rebaseline 3 tests after r142765
Unreviewed rebaseline of test expectations.
* platform/chromium-linux/fast/backgrounds/size/contain-and-cover-expected.png:
* platform/chromium-linux/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
* platform/chromium-linux/fast/writing-mode/block-level-images-expected.png:
* platform/chromium-mac/fast/backgrounds/size/contain-and-cover-expected.png:
* platform/chromium-mac/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
* platform/chromium-mac/fast/writing-mode/block-level-images-expected.png:
* platform/chromium-win-xp/fast/backgrounds/size/contain-and-cover-zoomed-expected.png: Added.
* platform/chromium-win/fast/backgrounds/size/contain-and-cover-expected.png:
* platform/chromium-win/fast/backgrounds/size/contain-and-cover-zoomed-expected.png:
* platform/chromium-win/fast/writing-mode/block-level-images-expected.png:
* platform/chromium/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143023
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
roger_fong@apple.com [Fri, 15 Feb 2013 19:17:32 +0000 (19:17 +0000)]
Get Win EWS startup script checked into tree so we can make changes to all the EWS bots more easily.
* EWSTools/start-queue-win.sh: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143022
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric.carlson@apple.com [Fri, 15 Feb 2013 19:15:33 +0000 (19:15 +0000)]
Crash occurs at WebCore::TextTrackList::length() when enabling closed captions in movie
https://bugs.webkit.org/show_bug.cgi?id=109886
Reviewed by Dean Jackson.
Source/WebCore:
No new tests, media/media-captions.html does not crash with this change.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::markCaptionAndSubtitleTracksAsUnconfigured): Early return when
m_textTracks is NULL.
LayoutTests:
* platform/mac/TestExpectations: Remove media/media-captions.html.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143021
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Fri, 15 Feb 2013 19:11:38 +0000 (19:11 +0000)]
TokenPreloadScanner should be able to scan CompactHTMLTokens
https://bugs.webkit.org/show_bug.cgi?id=109861
Reviewed by Eric Seidel.
This patch moves the main scanning logic for the TokenPreloadScanner to
a templated scanCommon routine that can scan either an HTMLToken or a
CompactHTMLToken. This patch will let the BackgroundHTMLParser preload
scan its CompactHTMLTokens.
* html/parser/CSSPreloadScanner.cpp:
(WebCore):
(WebCore::CSSPreloadScanner::scanCommon):
(WebCore::CSSPreloadScanner::scan):
* html/parser/CSSPreloadScanner.h:
(CSSPreloadScanner):
- Tweak the CSSPreloadScanner API slightly to make it easier to
call from templated code.
* html/parser/HTMLPreloadScanner.cpp:
(WebCore::TokenPreloadScanner::tagIdFor):
(WebCore):
(WebCore::TokenPreloadScanner::StartTagScanner::processAttributes):
(TokenPreloadScanner::StartTagScanner):
(WebCore::TokenPreloadScanner::scan):
(WebCore::TokenPreloadScanner::scanCommon):
(WebCore::TokenPreloadScanner::updatePredictedBaseURL):
(WebCore::HTMLPreloadScanner::scan):
* html/parser/HTMLPreloadScanner.h:
(TokenPreloadScanner):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143020
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alexis@webkit.org [Fri, 15 Feb 2013 19:06:30 +0000 (19:06 +0000)]
WebKit shouldn't accept "none, none" in transition shorthand property.
https://bugs.webkit.org/show_bug.cgi?id=108751
Reviewed by Dean Jackson.
Source/WebCore:
http://dev.w3.org/csswg/css3-transitions/#transition-shorthand-property
specifies that if there is more than one transition defined in the
shorthand and any of them has a value of 'none' then the declaration is
invalid. This patch fixes the problem by passing a parsing context to
track if a keyword has been set for the transition-property and if so
then use it to invalidate or not the declaration.
Test: transitions/transitions-parsing.html
* css/CSSParser.cpp:
(AnimationParseContext):
(WebCore::AnimationParseContext::AnimationParseContext):
(WebCore::AnimationParseContext::commitFirstAnimation): track whether
it's the first <single-transition/animation> or not defined in the
shorthand.
(WebCore::AnimationParseContext::hasCommittedFirstAnimation):
(WebCore::AnimationParseContext::commitAnimationPropertyKeywordInShorthand):
In the shorthand as soon as a keyword has been found then the parsing
is 'finished', if any other animation/transition declaration part of
the shorthand are with a keyword then it's invalid.
(WebCore::AnimationParseContext::animationPropertyKeywordInShorthandAllowed):
(WebCore::AnimationParseContext::hasSeenAnimationPropertyKeyword):
(WebCore::AnimationParseContext::sawAnimationPropertyKeyword):
(WebCore):
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseAnimationShorthand):
(WebCore::CSSParser::parseTransitionShorthand):
(WebCore::CSSParser::parseAnimationProperty):
* css/CSSParser.h:
(WebCore):
LayoutTests:
Extend exisiting tests to cover the bug. Modify old tests with invalid declarations.
* fast/css/transform-inline-style-expected.txt:
* fast/css/transform-inline-style-remove-expected.txt:
* fast/css/transform-inline-style-remove.html:
* fast/css/transform-inline-style.html:
* transitions/transitions-parsing-expected.txt:
* transitions/transitions-parsing.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143019
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
akling@apple.com [Fri, 15 Feb 2013 18:56:27 +0000 (18:56 +0000)]
Yarr: Use OwnPtr to make pattern/disjunction/character-class ownership clearer.
<http://webkit.org/b/109218>
Reviewed by Benjamin Poulain.
- Let classes that manage lifetime of other objects hold on to them with OwnPtr instead of raw pointers.
- Placed some strategic Vector::shrinkToFit(), ::reserveInitialCapacity() and ::swap().
668 kB progression on Membuster3.
* yarr/YarrInterpreter.cpp:
(JSC::Yarr::ByteCompiler::atomParenthesesSubpatternEnd):
(JSC::Yarr::ByteCompiler::emitDisjunction):
(ByteCompiler):
* yarr/YarrInterpreter.h:
(JSC::Yarr::BytecodePattern::BytecodePattern):
(BytecodePattern):
* yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::opCompileParenthesesSubpattern):
(JSC::Yarr::YarrGenerator::opCompileParentheticalAssertion):
(JSC::Yarr::YarrGenerator::opCompileBody):
* yarr/YarrPattern.cpp:
(JSC::Yarr::CharacterClassConstructor::charClass):
(JSC::Yarr::YarrPatternConstructor::YarrPatternConstructor):
(JSC::Yarr::YarrPatternConstructor::reset):
(JSC::Yarr::YarrPatternConstructor::atomPatternCharacter):
(JSC::Yarr::YarrPatternConstructor::atomCharacterClassEnd):
(JSC::Yarr::YarrPatternConstructor::copyDisjunction):
(JSC::Yarr::YarrPatternConstructor::setupDisjunctionOffsets):
(JSC::Yarr::YarrPatternConstructor::checkForTerminalParentheses):
(JSC::Yarr::YarrPatternConstructor::optimizeBOL):
(JSC::Yarr::YarrPatternConstructor::containsCapturingTerms):
(JSC::Yarr::YarrPatternConstructor::optimizeDotStarWrappedExpressions):
* yarr/YarrPattern.h:
(JSC::Yarr::PatternDisjunction::addNewAlternative):
(PatternDisjunction):
(YarrPattern):
(JSC::Yarr::YarrPattern::reset):
(JSC::Yarr::YarrPattern::newlineCharacterClass):
(JSC::Yarr::YarrPattern::digitsCharacterClass):
(JSC::Yarr::YarrPattern::spacesCharacterClass):
(JSC::Yarr::YarrPattern::wordcharCharacterClass):
(JSC::Yarr::YarrPattern::nondigitsCharacterClass):
(JSC::Yarr::YarrPattern::nonspacesCharacterClass):
(JSC::Yarr::YarrPattern::nonwordcharCharacterClass):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143018
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
akling@apple.com [Fri, 15 Feb 2013 18:55:06 +0000 (18:55 +0000)]
Unbreak webkit-patch -- can't have both Committer and Contributor entry with same e-mail address.
* Scripts/webkitpy/common/config/committers.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143017
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jdiggs@igalia.com [Fri, 15 Feb 2013 18:33:39 +0000 (18:33 +0000)]
Unreviewed. Add myself as a committer.
* Scripts/webkitpy/common/config/committers.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143016
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 15 Feb 2013 18:29:49 +0000 (18:29 +0000)]
NRWT: ML Debug Test bot is timing out after cleaning up ports
https://bugs.webkit.org/show_bug.cgi?id=109912
Reviewed by Simon Fraser.
Added more debug messgaes to diagnose the issue.
* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.run):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143015
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
akling@apple.com [Fri, 15 Feb 2013 18:28:12 +0000 (18:28 +0000)]
ElementData: Move leafy things out of the base class.
<http://webkit.org/b/109888>
Reviewed by Antti Koivisto.
- Moved functions for mutating/adding/removing attributes into UniqueElementData.
Attempts to modify shared element data will now fail at compile-time.
- Removed mutableAttributeVector() and have call sites access the vector directly.
- Move immutableAttributeArray() to ShareableElementData.
- Move some function bodies from Element.h to Element.cpp since all clients are in there.
* dom/Element.cpp:
(WebCore::Element::addAttributeInternal):
(WebCore::ShareableElementData::ShareableElementData):
(WebCore::UniqueElementData::makeShareableCopy):
(WebCore::UniqueElementData::addAttribute):
(WebCore::UniqueElementData::removeAttribute):
(WebCore::ElementData::reportMemoryUsage):
(WebCore::UniqueElementData::getAttributeItem):
(WebCore::UniqueElementData::attributeItem):
* dom/Element.h:
(ElementData):
(WebCore::ShareableElementData::immutableAttributeArray):
(ShareableElementData):
(UniqueElementData):
(WebCore::ElementData::length):
(WebCore::ElementData::attributeItem):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143014
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
csaavedra@igalia.com [Fri, 15 Feb 2013 18:27:49 +0000 (18:27 +0000)]
Unreviewed. Add myself as a committer.
* Scripts/webkitpy/common/config/committers.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143013
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ch.dumez@sisa.samsung.com [Fri, 15 Feb 2013 18:24:08 +0000 (18:24 +0000)]
Unreviewed. Update Yi Shen, Antonio Gomes and Laszlo Gombos'
emails on their behalf.
* Scripts/webkitpy/common/config/committers.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143012
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sudarsana.nagineni@linux.intel.com [Fri, 15 Feb 2013 17:53:14 +0000 (17:53 +0000)]
Unreviewed EFL gardening.
Skip failing tests on EFL wk1 and wk2 bots.
* platform/efl-wk2/TestExpectations:
* platform/efl/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143011
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 15 Feb 2013 17:31:39 +0000 (17:31 +0000)]
[CSS Exclusions] Enable shape-inside support for circles
https://bugs.webkit.org/show_bug.cgi?id=109713
Patch by Hans Muller <hmuller@adobe.com> on 2013-02-15
Reviewed by Dirk Schulze.
Source/WebCore:
Removed the test that disabled circle values for shape-inside.
The remaining support for circles, which is based on rounded rectangles
whose width/height is equal to their radiusX/radiusY, has not changed.
Test: fast/exclusions/shape-inside/shape-inside-circle.html
* rendering/ExclusionShapeInsideInfo.h:
(WebCore::ExclusionShapeInsideInfo::isEnabledFor): Now only disallows ellipse.
LayoutTests:
Added a test for circle shape-inside values.
* fast/exclusions/shape-inside/shape-inside-circle-expected.html: Added.
* fast/exclusions/shape-inside/shape-inside-circle.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143010
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ch.dumez@sisa.samsung.com [Fri, 15 Feb 2013 17:09:46 +0000 (17:09 +0000)]
[Soup] Leverage new soup_cookie_jar_get_cookie_list() API
https://bugs.webkit.org/show_bug.cgi?id=109931
Reviewed by Kenneth Rohde Christiansen.
In several cases, the CookieJarSoup implementation was retrieving / copying ALL the
cookies using soup_cookie_jar_all_cookies() and then using soup_cookie_applies_to_uri()
to filter out cookies it is not interested in. This was inefficient.
In libsoup 2.40, soup_cookie_jar_get_cookie_list() was introduced to retrieve only the
cookies that apply to a given URI. This patch leverages this new API in CookieJarSoup's
getRawCookies() and deleteCookie(). This way, only the cookies we are interested in
are retrieved and copied. Libsoup does not need to iterate over all the cookies itself
because it keeps the cookies in a hash table using the host names as key.
No new tests, no behavior change.
* platform/network/soup/CookieJarSoup.cpp:
(WebCore::getRawCookies):
(WebCore::deleteCookie):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143009
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 15 Feb 2013 17:09:32 +0000 (17:09 +0000)]
[EFL][WK2] Use C API inside BatteryProvider and NetworkInfoProvider
https://bugs.webkit.org/show_bug.cgi?id=107821
Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2013-02-15
Reviewed by Anders Carlsson.
BatteryProvider and NetworkInfoProvider should use C API
instead of accessing the internal C++ classes directly.
* UIProcess/API/efl/ewk_context.cpp:
(EwkContext::EwkContext):
* UIProcess/efl/BatteryProvider.cpp:
(BatteryProvider::~BatteryProvider):
(BatteryProvider::create):
(BatteryProvider::BatteryProvider):
(BatteryProvider::didChangeBatteryStatus):
* UIProcess/efl/BatteryProvider.h:
(BatteryProvider):
* UIProcess/efl/NetworkInfoProvider.cpp:
(NetworkInfoProvider::create):
(NetworkInfoProvider::NetworkInfoProvider):
(NetworkInfoProvider::~NetworkInfoProvider):
* UIProcess/efl/NetworkInfoProvider.h:
(NetworkInfoProvider):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143008
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mikhail.pozdnyakov@intel.com [Fri, 15 Feb 2013 17:07:40 +0000 (17:07 +0000)]
[WK2][EFL]REGRESSION (r141978): ewk_view_type_check api test failing
https://bugs.webkit.org/show_bug.cgi?id=109038
Reviewed by Anders Carlsson.
EFL API is defensive by its nature and expects graceful handling of wrong function arguments
whereas webkit implementation code does not. This patch adds new 'toEwkViewChecked' function,
which provides handling of wrong arguments, to be used within EFL API layer code.
* UIProcess/API/efl/EwkView.cpp:
(toEwkView):
EwkView* toEwkView(const Ewk_View_Smart_Data* smartData) is not exported anymore
as it's used within EwkView class only.
(EwkView::handleTouchMove):
* UIProcess/API/efl/EwkView.h:
* UIProcess/API/efl/ewk_view.cpp:
(toEwkViewChecked):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143007
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 15 Feb 2013 17:05:09 +0000 (17:05 +0000)]
Web Inspector: Added an option to split Elements and Sources sidebars in two panes.
https://bugs.webkit.org/show_bug.cgi?id=109298.
Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-02-15
Reviewed by Vsevolod Vlasov.
Introduced the "Split sidebar" context menu option that splits the horizontal sidebar into two panes.
The width split ratio is 1:1 by default and is preserved when the Inspector window is resized.
Elements sidebar is split into two tabbed panes, Sources sidebar is split into a pane stack and a tabbed pane.
No new tests.
* inspector/front-end/DOMBreakpointsSidebarPane.js:
(WebInspector.DOMBreakpointsSidebarPane.Proxy.prototype._reattachBody):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.get this):
(WebInspector.ElementsPanel):
(WebInspector.ElementsPanel.prototype._sidebarContextMenuEventFired):
(WebInspector.ElementsPanel.prototype._populateContextMenuForSidebar.toggleSetting):
(WebInspector.ElementsPanel.prototype.get _arrangeSidebarPanes.get this):
(WebInspector.ElementsPanel.prototype.addExtensionSidebarPane):
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._onCreateSidebarPane):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
(WebInspector.ScriptsPanel.prototype._appendUISourceCodeItems):
(WebInspector.ScriptsPanel.prototype._contextMenuEventFired):
(WebInspector.ScriptsPanel.prototype._sidebarContextMenuEventFired):
(WebInspector.ScriptsPanel.prototype._populateContextMenuForSidebar.toggleSetting):
(WebInspector.ScriptsPanel.prototype.get _arrangeSidebarPanes.get this):
* inspector/front-end/SidebarPane.js:
(WebInspector.SidebarPane):
(WebInspector.SidebarPane.prototype.expand):
(WebInspector.SidebarPane.prototype.onContentReady):
(WebInspector.SidebarPane.prototype._setExpandCallback):
(WebInspector.SidebarPane.prototype.wasShown):
(WebInspector.SidebarPaneTitle):
(WebInspector.SidebarPaneTitle.prototype._expand):
(WebInspector.SidebarPaneTitle.prototype._collapse):
(WebInspector.SidebarPaneTitle.prototype._toggleExpanded):
(WebInspector.SidebarPaneTitle.prototype._onTitleKeyDown):
(WebInspector.SidebarPaneStack):
(WebInspector.SidebarPaneStack.prototype.addPane):
(WebInspector.SidebarTabbedPane):
(WebInspector.SidebarTabbedPane.prototype.addPane):
* inspector/front-end/SidebarView.js:
* inspector/front-end/SplitView.js:
(WebInspector.SplitView):
(WebInspector.SplitView.prototype.get mainElement):
(WebInspector.SplitView.prototype.get sidebarElement):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143006
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vsevik@chromium.org [Fri, 15 Feb 2013 16:53:55 +0000 (16:53 +0000)]
Web Inspector: Several consecutive Backspace or Delete strikes should not be marked as undoable state.
https://bugs.webkit.org/show_bug.cgi?id=109915
Reviewed by Pavel Feldman.
Source/WebCore:
Extracted _isEditRangeUndoBoundary() and _isEditRangeAdjacentToLastCommand() in TextEditorModel
to detect if markUndoableState() call is needed before and after editRange.
* inspector/front-end/TextEditorModel.js:
(WebInspector.TextRange.prototype.immediatelyPrecedes):
(WebInspector.TextRange.prototype.immediatelyFollows):
(WebInspector.TextEditorModel.endsWithBracketRegex.):
LayoutTests:
* inspector/editor/text-editor-undo-redo-expected.txt:
* inspector/editor/text-editor-undo-redo.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143005
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ch.dumez@sisa.samsung.com [Fri, 15 Feb 2013 16:49:14 +0000 (16:49 +0000)]
[EFL][WK2] Have WebView subclass PageClient
https://bugs.webkit.org/show_bug.cgi?id=109684
Reviewed by Anders Carlsson.
Stop constructing the PageClient in EwkView. PageClient is an internal
class and we should not use it directly in our Ewk implementation.
Instead, have WebView subclass PageClient. The PageClient implementation
just calls WebView methods otherwise.
* PlatformEfl.cmake:
* UIProcess/API/efl/EwkView.cpp:
(EwkView::EwkView):
(EwkView::setSize):
* UIProcess/API/efl/EwkView.h:
(WebKit):
(EwkView):
(EwkView::webView):
* UIProcess/API/efl/ewk_view.cpp:
* UIProcess/efl/PageClientBase.cpp: Removed.
* UIProcess/efl/PageClientBase.h: Removed.
* UIProcess/efl/PageClientDefaultImpl.cpp: Removed.
* UIProcess/efl/PageClientDefaultImpl.h: Removed.
* UIProcess/efl/PageClientLegacyImpl.cpp: Removed.
* UIProcess/efl/PageClientLegacyImpl.h: Removed.
* UIProcess/efl/PageLoadClientEfl.cpp:
(WebKit::PageLoadClientEfl::didCommitLoadForFrame):
* UIProcess/efl/PageViewportControllerClientEfl.h:
* UIProcess/efl/WebPageProxyEfl.cpp:
(WebKit::WebPageProxy::viewWidget):
* UIProcess/efl/WebView.cpp:
(WebKit::WebView::WebView):
(WebKit::WebView::~WebView):
(WebKit::WebView::initialize):
(WebKit):
(WebKit::WebView::evasObject):
(WebKit::WebView::setThemePath):
(WebKit::WebView::setDrawsBackground):
(WebKit::WebView::drawsBackground):
(WebKit::WebView::setDrawsTransparentBackground):
(WebKit::WebView::drawsTransparentBackground):
(WebKit::WebView::suspendActiveDOMObjectsAndAnimations):
(WebKit::WebView::resumeActiveDOMObjectsAndAnimations):
(WebKit::WebView::didCommitLoad):
(WebKit::WebView::updateViewportSize):
(WebKit::WebView::didChangeContentsSize):
(WebKit::WebView::createDrawingAreaProxy):
(WebKit::WebView::setViewNeedsDisplay):
(WebKit::WebView::displayView):
(WebKit::WebView::scrollView):
(WebKit::WebView::viewSize):
(WebKit::WebView::isViewWindowActive):
(WebKit::WebView::isViewFocused):
(WebKit::WebView::isViewVisible):
(WebKit::WebView::isViewInWindow):
(WebKit::WebView::processDidCrash):
(WebKit::WebView::didRelaunchProcess):
(WebKit::WebView::pageClosed):
(WebKit::WebView::toolTipChanged):
(WebKit::WebView::setCursor):
(WebKit::WebView::setCursorHiddenUntilMouseMoves):
(WebKit::WebView::registerEditCommand):
(WebKit::WebView::clearAllEditCommands):
(WebKit::WebView::canUndoRedo):
(WebKit::WebView::executeUndoRedo):
(WebKit::WebView::screenToWindow):
(WebKit::WebView::windowToScreen):
(WebKit::WebView::doneWithKeyEvent):
(WebKit::WebView::doneWithTouchEvent):
(WebKit::WebView::createPopupMenuProxy):
(WebKit::WebView::createContextMenuProxy):
(WebKit::WebView::createColorChooserProxy):
(WebKit::WebView::setFindIndicator):
(WebKit::WebView::enterAcceleratedCompositingMode):
(WebKit::WebView::exitAcceleratedCompositingMode):
(WebKit::WebView::updateAcceleratedCompositingMode):
(WebKit::WebView::didCommitLoadForMainFrame):
(WebKit::WebView::didFinishLoadingDataForCustomRepresentation):
(WebKit::WebView::customRepresentationZoomFactor):
(WebKit::WebView::setCustomRepresentationZoomFactor):
(WebKit::WebView::flashBackingStoreUpdates):
(WebKit::WebView::findStringInCustomRepresentation):
(WebKit::WebView::countStringMatchesInCustomRepresentation):
(WebKit::WebView::updateTextInputState):
(WebKit::WebView::handleDownloadRequest):
(WebKit::WebView::convertToDeviceSpace):
(WebKit::WebView::convertToUserSpace):
(WebKit::WebView::didChangeViewportProperties):
(WebKit::WebView::pageDidRequestScroll):
(WebKit::WebView::didRenderFrame):
(WebKit::WebView::pageTransitionViewportReady):
* UIProcess/efl/WebView.h:
(WebKit):
(WebView):
(WebKit::WebView::pageRef):
(WebKit::WebView::page):
(WebKit::WebView::canScrollView):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143004
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aandrey@chromium.org [Fri, 15 Feb 2013 16:26:41 +0000 (16:26 +0000)]
Fix inconsistency in WebGLRenderingContext.idl for getAttribLocation
https://bugs.webkit.org/show_bug.cgi?id=109892
Reviewed by Kentaro Hara.
* html/canvas/WebGLRenderingContext.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143003
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sudarsana.nagineni@linux.intel.com [Fri, 15 Feb 2013 16:21:35 +0000 (16:21 +0000)]
Unreviewed EFL gardening.
Skip failing WebGL conformance tests added in r142851.
* platform/efl-wk2/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143002
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kov@webkit.org [Fri, 15 Feb 2013 16:12:53 +0000 (16:12 +0000)]
Unreviewed build fix.
* Source/autotools/SetupLibtool.m4: Move AR_FLAGS definition so it comes before dolt
and libtool initialization, thus having an effect once again.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143001
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aandrey@chromium.org [Fri, 15 Feb 2013 15:56:51 +0000 (15:56 +0000)]
Web Inspector: [Canvas] show replay log grouped by draw calls
https://bugs.webkit.org/show_bug.cgi?id=109592
Reviewed by Pavel Feldman.
Source/WebCore:
Show canvas capturing log grouped by drawing calls.
Drive-by: extended Array.prototype with a handy peekLast function.
Drive-by: removed code dups in few places.
* inspector/front-end/CanvasProfileView.js:
(WebInspector.CanvasProfileView):
(WebInspector.CanvasProfileView.prototype.dispose):
(WebInspector.CanvasProfileView.prototype._onReplayStepClick):
(WebInspector.CanvasProfileView.prototype._onReplayDrawingCallClick):
(WebInspector.CanvasProfileView.prototype._onReplayLastStepClick):
(WebInspector.CanvasProfileView.prototype._replayTraceLog.didReplayTraceLog):
(WebInspector.CanvasProfileView.prototype._replayTraceLog):
(WebInspector.CanvasProfileView.prototype._didReceiveTraceLog):
(WebInspector.CanvasProfileView.prototype._selectedCallIndex):
(WebInspector.CanvasProfileView.prototype._selectedDrawCallGroupIndex):
(WebInspector.CanvasProfileView.prototype._appendCallNode):
* inspector/front-end/DataGrid.js:
(WebInspector.DataGrid.prototype.setColumnVisible):
(WebInspector.DataGridNode.prototype.set hasChildren):
(WebInspector.DataGridNode.prototype.set revealed):
(WebInspector.DataGridNode.prototype.get leftPadding):
* inspector/front-end/externs.js:
(Array.prototype.peekLast):
* inspector/front-end/utilities.js:
LayoutTests:
A test to dump canvas replay log.
* inspector/profiler/canvas2d/canvas-replay-log-grid-expected.txt: Added.
* inspector/profiler/canvas2d/canvas-replay-log-grid.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143000
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Fri, 15 Feb 2013 15:47:28 +0000 (15:47 +0000)]
Web Inspector: highlight record revealed in Timeline
https://bugs.webkit.org/show_bug.cgi?id=109930
Reviewed by Pavel Feldman.
Revealed timeline record is now highlighted with yellow background
that fades out in 2 seconds.
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._revealRecord):
(WebInspector.TimelinePanel.prototype._refreshRecords):
(WebInspector.TimelinePanel.prototype._clearRecordHighlight):
* inspector/front-end/timelinePanel.css:
(.highlighted-timeline-record):
(@-webkit-keyframes timeline_record_highlight):
(to):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142999
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vsevik@chromium.org [Fri, 15 Feb 2013 15:45:50 +0000 (15:45 +0000)]
Web Inspector: Pass original selection to textModel to correctly restore it after undo.
https://bugs.webkit.org/show_bug.cgi?id=109911
Reviewed by Pavel Feldman.
Source/WebCore:
We can distinguish backspace pressed with and without selection now.
* inspector/front-end/DefaultTextEditor.js:
(WebInspector.TextEditorMainPanel.prototype._applyDomUpdates):
(WebInspector.DefaultTextEditor.WordMovementController.prototype._handleCtrlBackspace):
* inspector/front-end/TextEditorModel.js:
(WebInspector.TextEditorCommand):
(WebInspector.TextEditorModel.endsWithBracketRegex.):
LayoutTests:
* inspector/editor/text-editor-undo-redo-expected.txt:
* inspector/editor/text-editor-undo-redo.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142998
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 15 Feb 2013 15:33:57 +0000 (15:33 +0000)]
[Qt] Restore URL Scheme Delegates after QtWebProcess crash
https://bugs.webkit.org/show_bug.cgi?id=108808
When the QtWebProcess crashes, the registered URL Scheme
Delegates are not properly restored over IPC in the newly
launched process instance.
Patch by Milian Wolff <milian.wolff@kdab.com> on 2013-02-15
Reviewed by Simon Hausmann.
* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::didRelaunchProcess):
(QQuickWebViewPrivate::updateSchemeDelegates):
* UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewPrivate):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142997
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 15 Feb 2013 15:25:41 +0000 (15:25 +0000)]
[BlackBerry] Remove redundant requireAuth parameter of NetworkJob::notifyAuthReceived
https://bugs.webkit.org/show_bug.cgi?id=109855
Patch by Joe Mason <jmason@rim.com> on 2013-02-15
Reviewed by Yong Li.
Internal PR: 296697
Internally Reviewed By: Leo Yang
Code cleanup: The requireAuth parameter of NetworkJob::notifyAuthReceived is redundant as its value
can be determined from "result" - if result is AuthResultRetry, requireAuth is false, otherwise it
is true.
No new tests as there is no behaviour change.
* platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::notifyAuthReceived):
* platform/network/blackberry/NetworkJob.h:
(NetworkJob):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142996
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
atwilson@chromium.org [Fri, 15 Feb 2013 14:56:50 +0000 (14:56 +0000)]
Unreviewed chromium rebaselines for r142947.
* platform/chromium-mac/media/track/track-cue-rendering-vertical-expected.png:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142995
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vsevik@chromium.org [Fri, 15 Feb 2013 14:55:52 +0000 (14:55 +0000)]
Web Inspector: Redo in text editor should always collapse selection to end.
https://bugs.webkit.org/show_bug.cgi?id=109907
Reviewed by Pavel Feldman.
Source/WebCore:
* inspector/front-end/TextEditorModel.js:
(WebInspector.TextEditorModel.endsWithBracketRegex.):
LayoutTests:
* inspector/editor/text-editor-undo-redo-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142994
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sudarsana.nagineni@linux.intel.com [Fri, 15 Feb 2013 14:53:58 +0000 (14:53 +0000)]
Unreviewed EFL gardening.
Skip failing tests after r142947.
* platform/efl/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142993
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
atwilson@chromium.org [Fri, 15 Feb 2013 14:42:46 +0000 (14:42 +0000)]
Unreviewed chromium expectations changes for r142947.
* platform/chromium-mac-lion/media/audio-repaint-expected.png:
* platform/chromium-mac-lion/media/controls-after-reload-expected.png:
* platform/chromium-mac-lion/media/controls-strict-expected.png:
* platform/chromium-mac-lion/media/controls-styling-expected.png:
* platform/chromium-mac-lion/media/controls-styling-strict-expected.png:
* platform/chromium-mac-lion/media/controls-without-preload-expected.png:
* platform/chromium-mac-lion/media/media-document-audio-repaint-expected.png:
* platform/chromium-mac-lion/media/track/track-cue-rendering-horizontal-expected.png: Added.
* platform/chromium-mac-lion/media/video-controls-rendering-expected.png:
* platform/chromium-mac-lion/media/video-display-toggle-expected.png:
* platform/chromium-mac-lion/media/video-playing-and-pause-expected.png:
* platform/chromium-mac-snowleopard/media/audio-repaint-expected.png:
* platform/chromium-mac-snowleopard/media/controls-after-reload-expected.png:
* platform/chromium-mac-snowleopard/media/controls-strict-expected.png:
* platform/chromium-mac-snowleopard/media/controls-styling-expected.png:
* platform/chromium-mac-snowleopard/media/controls-styling-strict-expected.png:
* platform/chromium-mac-snowleopard/media/controls-without-preload-expected.png:
* platform/chromium-mac-snowleopard/media/media-document-audio-repaint-expected.png:
* platform/chromium-mac-snowleopard/media/track/track-cue-rendering-horizontal-expected.png:
* platform/chromium-mac-snowleopard/media/video-controls-rendering-expected.png:
* platform/chromium-mac-snowleopard/media/video-display-toggle-expected.png:
* platform/chromium-mac-snowleopard/media/video-playing-and-pause-expected.png:
* platform/chromium-mac/media/audio-repaint-expected.png:
* platform/chromium-mac/media/controls-after-reload-expected.png:
* platform/chromium-mac/media/controls-strict-expected.png:
* platform/chromium-mac/media/controls-styling-expected.png:
* platform/chromium-mac/media/controls-styling-strict-expected.png:
* platform/chromium-mac/media/controls-without-preload-expected.png:
* platform/chromium-mac/media/media-document-audio-repaint-expected.png:
* platform/chromium-mac/media/track/track-cue-rendering-horizontal-expected.png:
* platform/chromium-mac/media/video-controls-rendering-expected.png:
* platform/chromium-mac/media/video-display-toggle-expected.png:
* platform/chromium-mac/media/video-playing-and-pause-expected.png:
* platform/chromium-mac/media/video-zoom-controls-expected.txt:
* platform/chromium-win/media/audio-repaint-expected.png:
* platform/chromium-win/media/controls-after-reload-expected.png:
* platform/chromium-win/media/controls-strict-expected.png:
* platform/chromium-win/media/controls-styling-expected.png:
* platform/chromium-win/media/controls-styling-strict-expected.png:
* platform/chromium-win/media/controls-without-preload-expected.png:
* platform/chromium-win/media/media-document-audio-repaint-expected.png:
* platform/chromium-win/media/track/track-cue-rendering-horizontal-expected.png:
* platform/chromium-win/media/video-controls-rendering-expected.png:
* platform/chromium-win/media/video-display-toggle-expected.png:
* platform/chromium-win/media/video-playing-and-pause-expected.png:
* platform/chromium/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142992
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kadam@inf.u-szeged.hu [Fri, 15 Feb 2013 14:38:13 +0000 (14:38 +0000)]
[Qt] Unreviewed gardening. Skip failing tests.
* platform/qt/TestExpectations:
* platform/qt/fast/replaced/width100percent-image-expected.png: Added after r142931.
* platform/qt/fast/replaced/width100percent-image-expected.txt: Added after r142931.
* platform/qt/tables/mozilla_expected_failures/bugs/bug85016-expected.png: Added after r142931.
* platform/qt/tables/mozilla_expected_failures/bugs/bug85016-expected.txt: Added after r142931.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142991
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sudarsana.nagineni@linux.intel.com [Fri, 15 Feb 2013 14:20:54 +0000 (14:20 +0000)]
Unreviewed EFL gardening.
Rebaselining after r142931 and r142759.
* platform/efl/fast/replaced/width100percent-image-expected.png:
* platform/efl/fast/replaced/width100percent-image-expected.txt:
* platform/efl/svg/dom/SVGLengthList-basics-expected.txt: Removed.
* platform/efl/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
* platform/efl/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142990
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 15 Feb 2013 14:15:53 +0000 (14:15 +0000)]
[v8] persistent handle dispose before last use
https://bugs.webkit.org/show_bug.cgi?id=109927
Patch by Dan Carney <dcarney@google.com> on 2013-02-15
Reviewed by Jochen Eisinger.
No new tests. No change in functionality.
* bindings/v8/ScriptWrappable.h:
(WebCore::ScriptWrappable::weakCallback):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142989
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
keishi@webkit.org [Fri, 15 Feb 2013 14:05:04 +0000 (14:05 +0000)]
PagePopupController.formatMonth should support short month format
https://bugs.webkit.org/show_bug.cgi?id=109530
Reviewed by Kent Tamura.
Source/WebCore:
PagePopupController.formatMonth should support short month format so we
can use it in the new calendar picker.
Tested by LocaleMacTest::formatMonth.
* page/PagePopupController.cpp:
(WebCore::PagePopupController::formatMonth): Take an extra bool argument to switch to short month format.
* page/PagePopupController.h:
(PagePopupController):
* page/PagePopupController.idl:
* platform/text/LocaleICU.cpp:
(WebCore::LocaleICU::shortMonthFormat):
(WebCore):
* platform/text/LocaleICU.h:
(LocaleICU):
* platform/text/LocaleNone.cpp:
(WebCore::shortMonthFormat):
(WebCore):
* platform/text/PlatformLocale.cpp:
(WebCore::DateTimeStringBuilder::visitField):
(WebCore::Locale::formatDateTime):
* platform/text/PlatformLocale.h:
(Locale):
* platform/text/mac/LocaleMac.h:
(LocaleMac):
* platform/text/mac/LocaleMac.mm:
(WebCore::LocaleMac::shortMonthFormat):
(WebCore):
* platform/text/win/LocaleWin.cpp:
(WebCore::LocaleWin::shortMonthFormat): Windows doesn't have a short
month format so we just replace MMMM with MMM.
(WebCore):
* platform/text/win/LocaleWin.h:
(LocaleWin):
Source/WebKit/chromium:
* tests/LocaleMacTest.cpp:
(LocaleMacTest::formatMonth):
(TEST_F):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142988
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
keishi@webkit.org [Fri, 15 Feb 2013 13:36:51 +0000 (13:36 +0000)]
Add setValue and closePopup methods to PagePopupController
https://bugs.webkit.org/show_bug.cgi?id=109897
Reviewed by Kent Tamura.
.:
* ManualTests/forms/calendar-picker.html: Added mock setValue and closePopup implementation.
* ManualTests/forms/color-suggestion-picker.html: Ditto.
Source/WebCore:
The new calendar picker (Bug 109439) needs to set a value without
closing the popup. We can't do that with the existing
setValueAndClosePopup.
No new tests. Existing calendar picker and color suggestion picker tests
that closing and setting values work properly.
* Resources/pagepopups/pickerCommon.js:
(Picker.prototype.submitValue): Stop using setValueAndClosePopup.
(Picker.prototype.handleCancel): Ditto.
* page/PagePopupClient.h:
(PagePopupClient):
* page/PagePopupController.cpp:
(WebCore::PagePopupController::setValue): Sets value to element without closing popup.
(WebCore):
(WebCore::PagePopupController::closePopup): Just closes popup.
* page/PagePopupController.h:
(PagePopupController):
* page/PagePopupController.idl:
Source/WebKit/blackberry:
* WebCoreSupport/ColorPickerClient.cpp:
(WebCore::ColorPickerClient::setValue): Added empty implementation.
(WebCore):
* WebCoreSupport/ColorPickerClient.h:
(ColorPickerClient):
* WebCoreSupport/DatePickerClient.cpp:
(WebCore::DatePickerClient::setValue): Ditto.
(WebCore):
* WebCoreSupport/DatePickerClient.h:
(DatePickerClient):
* WebCoreSupport/SelectPopupClient.cpp:
(WebCore::SelectPopupClient::setValue): Ditto.
(WebCore):
* WebCoreSupport/SelectPopupClient.h:
(SelectPopupClient):
Source/WebKit/chromium:
* src/ColorChooserPopupUIController.cpp:
(WebKit::ColorChooserPopupUIController::setValue):
(WebKit):
* src/ColorChooserPopupUIController.h:
(ColorChooserPopupUIController):
* src/DateTimeChooserImpl.cpp:
(WebKit::DateTimeChooserImpl::setValueAndClosePopup): Use setValue and closePopup.
(WebKit):
(WebKit::DateTimeChooserImpl::setValue):
(WebKit::DateTimeChooserImpl::closePopup):
* src/DateTimeChooserImpl.h:
(DateTimeChooserImpl):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142987
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
gyuyoung.kim@samsung.com [Fri, 15 Feb 2013 13:18:25 +0000 (13:18 +0000)]
Unreviewed EFL WK1 gardening.
EFL WK1 doesn't support WebGL conformance tests which were added by r142847.
* platform/efl-wk1/TestExpectations: Skipped WebGL conformance tests.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142986
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
atwilson@chromium.org [Fri, 15 Feb 2013 13:04:52 +0000 (13:04 +0000)]
Unreviewed chromium expectations update for r142955.
* platform/chromium-mac/svg/filters/filter-hidden-content-expected.png: Added.
* platform/chromium-win/svg/filters/filter-hidden-content-expected.png: Renamed from LayoutTests/platform/chromium-linux/svg/filters/filter-hidden-content-expected.png.
* platform/chromium/svg/filters/filter-hidden-content-expected.txt: Renamed from LayoutTests/platform/chromium-linux/svg/filters/filter-hidden-content-expected.txt.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142985
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihnea@adobe.com [Fri, 15 Feb 2013 13:00:03 +0000 (13:00 +0000)]
[CSS Regions] RenderRegion should inherit from RenderBlock
https://bugs.webkit.org/show_bug.cgi?id=74132
Reviewed by Julien Chaffraix.
Source/WebCore:
Change the base class for RenderRegion to be RenderBlock instead of RenderReplaced.
Per spec http://dev.w3.org/csswg/css3-regions/#the-flow-from-property, a region is a non-replaced block container.
This change is covered by the existing regions tests (in fast/region and fast/repaint).
The RenderFlowThread object is a self-painting layer (it requires layer and is positioned).
Because of that, the RenderFlowThread object is responsible for painting its children,
the collected objects. When the RenderRegion::paintObject is called during paint, it delegates painting
of content collected inside the flow thread to the associated RenderFlowThread object.
Since we do not want to paint the flow thread content multiple times (for each paint phase
in which the RenderRegion::paintObject is called), we allow RenderFlowThread painting only for
selection and foreground paint phases.
* rendering/RenderBox.cpp: Clean-up the code from regions specific stuff, now that the regions are render blocks.
(WebCore::RenderBox::computePositionedLogicalWidth):
(WebCore::RenderBox::computePositionedLogicalHeight):
* rendering/RenderLayerBacking.cpp: A region should always render content from its associated flow thread,
even when it does not have children of its own.
(WebCore::RenderLayerBacking::isSimpleContainerCompositingLayer):
* rendering/RenderMultiColumnSet.cpp: Make changes to match the new inheritance for RenderRegion.
(WebCore::RenderMultiColumnSet::paint):
(WebCore::RenderMultiColumnSet::paintColumnRules):
* rendering/RenderMultiColumnSet.h:
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::RenderRegion):
(WebCore::RenderRegion::paintObject):
(WebCore::RenderRegion::styleDidChange):
(WebCore::RenderRegion::layoutBlock):
(WebCore::RenderRegion::insertedIntoTree):
(WebCore::RenderRegion::willBeRemovedFromTree):
(WebCore::RenderRegion::computePreferredLogicalWidths): Use this method instead of min/maxPreferredLogicalWidth.
(WebCore::RenderRegion::updateLogicalHeight):
* rendering/RenderRegion.h: For now, assume the region is not allowed to have children.
When we will implement the processing model for pseudo-elements http://dev.w3.org/csswg/css3-regions/#processing-model,
we will have to remove this function. By having this function return false i was able to leave some tests unchanged.
LayoutTests:
Fix tests that were failing after the inheritance change.
* fast/regions/flows-dependency-dynamic-remove.html: As a block, an empty region can self collapse,
which was not possible for a replaced element. I used '-webkit-margin-collapse: separate' to prevent
margins self collapsing for body and avoid recreating the expectations.
I want regions margins to be able to self collapse, just like the other block elements.
* fast/regions/flows-dependency-same-flow.html: Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142984
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 15 Feb 2013 12:30:27 +0000 (12:30 +0000)]
Web Inspector: implement smart braces functionality
https://bugs.webkit.org/show_bug.cgi?id=109200
Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-02-15
Reviewed by Pavel Feldman.
Source/WebCore:
- implement SmartBraceController which will handle character insertions
and override them if brace character was inserted. Additionally it
should handle Backspace key and override it if a cursor is located
inside of a bracket pair.
- guard smart brace functionality via experiment checkbox.
New test: inspector/editor/text-editor-smart-braces.html
* inspector/front-end/DefaultTextEditor.js:
(WebInspector.TextEditorMainPanel):
(WebInspector.TextEditorMainPanel.prototype._registerShortcuts):
(WebInspector.TextEditorMainPanel.prototype._handleKeyPress):
(WebInspector.TextEditorMainPanel.SmartBraceController):
(WebInspector.TextEditorMainPanel.SmartBraceController.prototype.registerShortcuts):
(WebInspector.TextEditorMainPanel.SmartBraceController.prototype.registerCharOverrides):
(WebInspector.TextEditorMainPanel.SmartBraceController.prototype._handleBackspace):
(WebInspector.TextEditorMainPanel.SmartBraceController.prototype._handleBracePairInsertion):
(WebInspector.TextEditorMainPanel.SmartBraceController.prototype._handleClosingBraceOverride):
* inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
Tools:
Fix eventSender.keyDown implementation to correctly process opening
round brace symbol.
* DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
(WebTestRunner):
(WebTestRunner::EventSender::keyDown):
LayoutTests:
* inspector/editor/text-editor-smart-braces-expected.txt: Added.
* inspector/editor/text-editor-smart-braces.html: Added.
* platform/efl/TestExpectations:
* platform/mac/TestExpectations:
* platform/qt/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142983
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 15 Feb 2013 12:28:19 +0000 (12:28 +0000)]
[CSS Regions][Mac] fast/regions/full-screen-video-from-region.html hits an assertion in RenderFlowThread::removeRenderBoxRegionInfo
https://bugs.webkit.org/show_bug.cgi?id=106075
Patch by Andrei Bucur <abucur@adobe.com> on 2013-02-15
Reviewed by Tony Chang.
Source/WebCore:
The crash is caused by two issues.
The first problem is how a block inside a flow thread determines if the children needs relayout or not.
When the region chain is invalidated, the information is lost so we need to return true, even for the
enclosing RenderFlowThread. Because the video renderer is the first child of the flow thread this doesn't
happen.
The patch implements this behaviour by inspecting both if the region chain has changed and
if the block has no range computed yet.
The second problem is RenderMedia not inheriting from RenderBlock. The logic of child relayout doesn't apply
to it. In the test case, when the full screen button is pressed, the region changes width to fill the viewport,
the chain is invalidated and the box info hash map is cleared. When the video is laid out again (after fixing
the first issue) it has the same size so the controls don't do a layout. They remain without box info inside
the flow thread, thus causing the assertion.
The patch forces the controls to relayout if the region chain was invalidated. We can't use the
logicalWidthChangedInRegions method because it is block specific. This will be fixed in a later patch.
Tests: No new tests. fast/regions/full-screen-video-from-region.html no longer crashes.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::checkForPaginationLogicalHeightChange):
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::RenderFlowThread):
(WebCore::RenderFlowThread::layout):
(WebCore::RenderFlowThread::logicalWidthChangedInRegions):
* rendering/RenderFlowThread.h: Renamed pageLogicalHeightChanged to pageLogicalSizeChanged.
* rendering/RenderMedia.cpp:
(WebCore::RenderMedia::layout):
LayoutTests:
Removed the crash/fail expectation for fast/regions/full-screen-video-from-region.html.
* platform/mac/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142982
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
atwilson@chromium.org [Fri, 15 Feb 2013 12:25:13 +0000 (12:25 +0000)]
Unreviewed chromium expectation changes after r142931.
* platform/chromium-mac-lion/fast/replaced/width100percent-image-expected.png:
* platform/chromium-mac-lion/fast/replaced/width100percent-image-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/replaced/width100percent-image-expected.txt.
* platform/chromium-mac-lion/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
* platform/chromium-mac-snowleopard/fast/replaced/width100percent-image-expected.png:
* platform/chromium-mac-snowleopard/fast/replaced/width100percent-image-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/replaced/width100percent-image-expected.txt.
* platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
* platform/chromium-mac/fast/replaced/width100percent-image-expected.png:
* platform/chromium-mac/fast/replaced/width100percent-image-expected.txt:
* platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
* platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug85016-expected.txt: Removed.
* platform/chromium-win/fast/replaced/width100percent-image-expected.png:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
* tables/mozilla_expected_failures/bugs/bug85016-expected.txt: Renamed from LayoutTests/platform/mac/tables/mozilla_expected_failures/bugs/bug85016-expected.txt.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142981
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zandobersek@gmail.com [Fri, 15 Feb 2013 12:18:43 +0000 (12:18 +0000)]
Unreviewed GTK gardening.
* platform/gtk/TestExpectations: Adding expectations for tests that need checking after r142947.
* platform/gtk/fast/replaced/width100percent-image-expected.txt: Added. Rebaselining after r142931.
* platform/gtk/tables/mozilla_expected_failures/bugs/bug85016-expected.txt: Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142980
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
allan.jensen@digia.com [Fri, 15 Feb 2013 12:09:08 +0000 (12:09 +0000)]
Source/WebCore: [CoordGfx] Regression from r135212: big layers with transform animations sometime fail to render tiles
https://bugs.webkit.org/show_bug.cgi?id=109179
Reviewed by Jocelyn Turcotte.
Fix adjustForContentsRect logic for AC layers that are higher or wider than the visible rect.
Force updates of the visible rect while it is animating, and until we have done one last update after
it stops animating.
Test: compositing/transitions/transform-on-large-layer.html
* platform/graphics/TiledBackingStore.cpp:
(WebCore::TiledBackingStore::adjustForContentsRect):
(WebCore::TiledBackingStore::computeCoverAndKeepRect):
* platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::CoordinatedGraphicsLayer):
(WebCore::CoordinatedGraphicsLayer::flushCompositingStateForThisLayerOnly):
(WebCore::CoordinatedGraphicsLayer::computePixelAlignment):
(WebCore::CoordinatedGraphicsLayer::computeTransformedVisibleRect):
* platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h:
(CoordinatedGraphicsLayer):
LayoutTests: [CoordGfx] Regression from r135212: big layers with transform animations sometime fail to render tiles.
https://bugs.webkit.org/show_bug.cgi?id=109179
Reviewed by Jocelyn Turcotte.
Test of a large layer with an animated transform. Skipped on WK1 due to resize event not firing in DRT.
* compositing/transitions/transform-on-large-layer-expected.html: Added.
* compositing/transitions/transform-on-large-layer.html: Added.
* platform/mac/TestExpectations:
* platform/qt-5.0-wk1/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142979
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 15 Feb 2013 11:40:27 +0000 (11:40 +0000)]
Unreviewed, rolling out r142876.
http://trac.webkit.org/changeset/142876
https://bugs.webkit.org/show_bug.cgi?id=109920
Broke relative URL linkification in the computed styles pane
(Requested by apavlov on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-15
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane.prototype._rebuildSectionsForStyleRules):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142978
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
allan.jensen@digia.com [Fri, 15 Feb 2013 10:46:33 +0000 (10:46 +0000)]
Simplify hitTestResultAtPoint and nodesFromRect APIs
https://bugs.webkit.org/show_bug.cgi?id=95720
.:
Reviewed by Julien Chaffraix.
Update exported symbols.
* Source/autotools/symbols.filter:
Source/WebCore:
Reviewed by Julien Chaffraix.
The existing API was overloaded and could be simplified by passing all the bool arguments in
a HitTestRequest argument. This should also help clarify the call as the enum values explicitely
state what they do.
* WebCore.exp.in:
* WebCore.order:
* dom/Document.cpp:
(WebCore::Document::nodesFromRect):
* dom/Document.h:
(Document):
* page/ContextMenuController.cpp:
(WebCore::ContextMenuController::createContextMenu):
* page/DragController.cpp:
(WebCore::DragController::canProcessDrag):
(WebCore::DragController::startDrag):
* page/EventHandler.cpp:
(WebCore::EventHandler::hitTestResultAtPoint):
(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::handleGestureEvent):
(WebCore::EventHandler::handleGestureForTextSelectionOrContextMenu):
(WebCore::EventHandler::bestClickableNodeForTouchPoint):
(WebCore::EventHandler::bestContextMenuNodeForTouchPoint):
(WebCore::EventHandler::bestZoomableAreaForTouchPoint):
(WebCore::EventHandler::handleTouchEvent):
* page/EventHandler.h:
(WebCore):
(EventHandler):
* page/FocusController.cpp:
(WebCore::updateFocusCandidateIfNeeded):
* page/Frame.cpp:
(WebCore::Frame::visiblePositionForPoint):
(WebCore::Frame::documentAtPoint):
* page/TouchDisambiguation.cpp:
(WebCore::findGoodTouchTargets):
* rendering/HitTestRequest.h:
(WebCore::HitTestRequest::allowsFrameScrollbars):
* testing/Internals.cpp:
(WebCore::Internals::nodesFromRect):
Source/WebKit/blackberry:
Reviewed by Julien Chaffraix.
Update calls to new API.
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::contextNode):
(BlackBerry::WebKit::WebPagePrivate::nodeForZoomUnderPoint):
(BlackBerry::WebKit::WebPagePrivate::handleMouseEvent):
(BlackBerry::WebKit::WebPage::nodeAtDocumentPoint):
(BlackBerry::WebKit::WebPagePrivate::hitTestResult):
* WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::visiblePositionForPointIgnoringClipping):
Source/WebKit/chromium:
Reviewed by Julien Chaffraix.
Update calls to new API.
* src/ContextMenuClientImpl.cpp:
(WebKit::selectMisspelledWord):
* src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::dispatchDecidePolicyForNavigationAction):
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::characterIndexForPoint):
* src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::isRectTopmost):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleMouseDown):
(WebKit::WebViewImpl::computeBlockBounds):
(WebKit::WebViewImpl::bestTouchLinkNode):
(WebKit::WebViewImpl::hitTestResultForWindowPos):
Source/WebKit/efl:
Reviewed by Julien Chaffraix.
Update calls to new API.
* ewk/ewk_frame.cpp:
(ewk_frame_hit_test_new):
Source/WebKit/mac:
Reviewed by Julien Chaffraix.
Update calls to new API.
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::actionDictionary):
* WebView/WebFrame.mm:
(-[WebFrame elementAtPoint:]):
* WebView/WebHTMLView.mm:
(-[WebHTMLView elementAtPoint:allowShadowContent:]):
Source/WebKit/qt:
Reviewed by Julien Chaffraix.
Update calls to new API.
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::dispatchDecidePolicyForNavigationAction):
* WebCoreSupport/QWebFrameAdapter.cpp:
(QWebFrameAdapter::hitTestContent):
* WebCoreSupport/QWebPageAdapter.cpp:
(QWebPageAdapter::TouchAdjuster::findCandidatePointForTouch):
(QWebPageAdapter::handleSoftwareInputPanel):
(QWebPageAdapter::updatePositionDependentMenuActions):
Source/WebKit/win:
Reviewed by Julien Chaffraix.
Update calls to new API.
* WebActionPropertyBag.cpp:
(WebActionPropertyBag::Read):
* WebKit.vcproj/WebKitExports.def.in:
* WebView.cpp:
(WebView::handleContextMenuEvent):
(WebView::elementAtPoint):
Source/WebKit/wx:
Reviewed by Julien Chaffraix.
Update calls to new API.
* WebFrame.cpp:
(WebKit::WebFrame::HitTest):
Source/WebKit2:
Reviewed by Julien Chaffraix and Maciej Stachowiak.
Update calls to new API and update exported symbols.
* WebProcess/InjectedBundle/InjectedBundleNavigationAction.cpp:
(WebKit::InjectedBundleNavigationAction::InjectedBundleNavigationAction):
* WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::hitTest):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::handleContextMenuEvent):
(WebKit::WebPage::highlightPotentialActivation):
(WebKit::WebPage::findZoomableAreaForPoint):
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::characterIndexForPoint):
(WebKit::WebPage::performDictionaryLookupAtLocation):
(WebKit::WebPage::shouldDelayWindowOrderingEvent):
(WebKit::WebPage::acceptsFirstMouse):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142977
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Fri, 15 Feb 2013 10:37:39 +0000 (10:37 +0000)]
Web Inspector: make component-based compile-front-end happy
https://bugs.webkit.org/show_bug.cgi?id=109798
Reviewed by Vsevolod Vlasov.
* inspector/Inspector.json:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::setVariableValue):
* inspector/InspectorDebuggerAgent.h:
(InspectorDebuggerAgent):
* inspector/compile-front-end.py:
* inspector/front-end/AuditResultView.js:
* inspector/front-end/CPUProfileView.js:
* inspector/front-end/DataGrid.js:
* inspector/front-end/InspectorFrontendAPI.js:
(InspectorFrontendAPI.loadTimelineFromURL):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142976
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Fri, 15 Feb 2013 10:29:12 +0000 (10:29 +0000)]
Web Inspector: Implement tracking of active stylesheets in the frontend
https://bugs.webkit.org/show_bug.cgi?id=105828
Reviewed by Pavel Feldman.
Source/WebCore:
- This change introduces the CSS.styleSheetAdded() and CSS.styleSheetRemoved() events
that update the frontend with all active stylesheet changes in the inspected page.
As such, fetching stylesheet headers from the backend manually is no longer needed,
and many asynchronous methods have been turned into normal accessors.
- One notable change to the stylesheet binding process is that when a via-inspector stylesheet
is created, it is instantly reported through the instrumentation, and the viaInspectorStyleSheet() method
is [indirectly] called recursively from bindStyleSheet(). Thus, the actual creation and registration
of the respective InspectorStyleSheet have been moved into bindStyleSheet(),
which relies upon the m_creatingViaInspectorStyleSheet flag.
Test: inspector/styles/stylesheet-tracking.html
* dom/DocumentStyleSheetCollection.cpp:
(WebCore::DocumentStyleSheetCollection::updateActiveStyleSheets): Instrumented.
* inspector/Inspector.json: Add events, update the CSS domain description.
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::InspectorCSSAgent):
(WebCore::InspectorCSSAgent::clearFrontend):
(WebCore::InspectorCSSAgent::enable): Push all existing stylesheet headers into the frontend.
(WebCore::InspectorCSSAgent::activeStyleSheetsUpdated): Push added/removed stylesheet into the frontend.
(WebCore::InspectorCSSAgent::getAllStyleSheets): Slightly refactored to make use of collectAllStyleSheets().
(WebCore::InspectorCSSAgent::collectAllStyleSheets): Added to collect InspectorStyleSheets rather than headers.
(WebCore::InspectorCSSAgent::collectStyleSheets):
(WebCore::InspectorCSSAgent::bindStyleSheet): Binds via-inspector stylesheets, too.
(WebCore::InspectorCSSAgent::unbindStyleSheet): Now we can unbind stylesheets upon their removal from the document.
(WebCore::InspectorCSSAgent::viaInspectorStyleSheet): Modifies m_creatingViaInspectorStyleSheet when necessary.
(WebCore::InspectorCSSAgent::detectOrigin): Modified to make use of m_creatingViaInspectorStyleSheet.
(WebCore::InspectorCSSAgent::buildObjectForRule): Removed extraneous bound InspectorStyleSheet 0-check.
* inspector/InspectorCSSAgent.h:
* inspector/InspectorInstrumentation.cpp: Instrumentation of active stylesheet set updates.
(WebCore::InspectorInstrumentation::activeStyleSheetsUpdatedImpl):
* inspector/InspectorInstrumentation.h: Ditto.
(WebCore::InspectorInstrumentation::activeStyleSheetsUpdated):
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel.prototype.styleSheetHeaders):
(WebInspector.CSSStyleModel.prototype._styleSheetAdded): Added.
(WebInspector.CSSStyleModel.prototype._styleSheetRemoved): Added.
(WebInspector.CSSStyleModel.prototype.viaInspectorResourceForRule):
(WebInspector.CSSStyleModelResourceBinding.prototype._setHeaderForStyleSheetId):
(WebInspector.CSSStyleModelResourceBinding.prototype.resourceURLForStyleSheetId):
(WebInspector.CSSStyleModelResourceBinding.prototype.styleSheetIdForResource):
(WebInspector.CSSStyleModelResourceBinding.prototype._headerKey): Calculate the (frameID + URL) key for CSSStyleSheetHeader.
(WebInspector.CSSStyleModelResourceBinding.prototype._createInspectorResource):
(WebInspector.CSSStyleModelResourceBinding.prototype._inspectorResource):
(WebInspector.CSSStyleModelResourceBinding.prototype._reset):
(WebInspector.CSSDispatcher.prototype.styleSheetAdded): Added.
(WebInspector.CSSDispatcher.prototype.styleSheetRemoved): Added.
* inspector/front-end/SASSSourceMapping.js: Get rid of async implementations.
(WebInspector.SASSSourceMapping.prototype._styleSheetChanged):
* inspector/front-end/StylesSidebarPane.js: Ditto.
(WebInspector.StylePropertiesSection.prototype._createRuleOriginNode):
* inspector/front-end/StylesSourceMapping.js: Ditto.
(WebInspector.StyleContentBinding.prototype._innerStyleSheetChanged):
LayoutTests:
* inspector/styles/resources/stylesheet-tracking.css: Added.
* inspector/styles/stylesheet-tracking-expected.txt: Added.
* inspector/styles/stylesheet-tracking.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142975
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 15 Feb 2013 10:22:27 +0000 (10:22 +0000)]
Implement the -webkit-margin-collapse properties correct rendering
https://bugs.webkit.org/show_bug.cgi?id=108168
Patch by Andrei Bucur <abucur@adobe.com> on 2013-02-15
Reviewed by David Hyatt.
Source/WebCore:
The patch implements the correct behavior for the -webkit-margin-collapse properties:
- a value of "discard" on a margin will truncate all the margins collapsing with it;
- a value of "separate" will prevent the margin to collapse;
- a value of "collapse" is the default collapse behavior.
The implementation is aware of multiple writing-modes:
- if the writing mode of a child is parallel with the writing mode of the container and has the same direction,
the -webkit-margin-collapse properties on the child are left as is;
- if the writing mode of a child is parallel with the writing mode of the container but has a different direction,
the -webkit-margin-collapse properties on the child are reversed;
- if the writing mode of a child is perpendicular on the writing mode of the container,
the -webkit-margin-collapse properties on the child are ignored;
I. The "discard" value implementation
There are two new bits (before and after) added on the RenderBlockRareData structure specifying if the margins
of the block will be discarded or not. We can't rely only on the value from style() because
it's possible a block to discard it's margins because it has collapsed with a children that
specified "discard" for -webkit-margin-collapse. However, the bits are set only if it is
required.
Another bit is added on the MarginInfo structure specifying if the margin has to be discarded or not. When
collapsing at the before side of a block it will hold information if the container block needs to discard
or not. If the collapsing happens between siblings/with after side of the container it will tell if the previous
child discards the margin or not. The self collapsing blocks are a special case. If any of its margins
discards then both its margins discard and all the other margins collapsing with it.
To ensure an optimal behavior it is asserted margin values can't be set on the MarginInfo object if the
discard flag is active. If this happens it may indicate someone ignored the possibility of the margin being
discarded altogether and incorrectly updated the margin values.
Float clearing also needs to change because it may force margins to stop collapsing. If this happens the discard
flags and margins needs to be restored to their values before the collapse.
II. The "separate" value implementation
The implementation for separate was not changed too much. I've added new accessor methods for the property
that take writing mode into consideration and I've removed some code that didn't work correctly in layoutBlockChild.
The problem was the marginInfo structure was cleared if the child was specifying the "separate" value for before.
This is wrong because you lose the margin information of the previous child/before side.
Tests: fast/block/margin-collapse/webkit-margin-collapse-container.html
fast/block/margin-collapse/webkit-margin-collapse-floats.html
fast/block/margin-collapse/webkit-margin-collapse-siblings-bt.html
fast/block/margin-collapse/webkit-margin-collapse-siblings.html
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::MarginInfo::MarginInfo):
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::collapseMargins):
(WebCore::RenderBlock::clearFloatsIfNeeded):
(WebCore::RenderBlock::marginBeforeEstimateForChild):
(WebCore::RenderBlock::estimateLogicalTopPosition):
(WebCore::RenderBlock::setCollapsedBottomMargin):
(WebCore::RenderBlock::handleAfterSideOfBlock):
(WebCore::RenderBlock::layoutBlockChild):
(WebCore::RenderBlock::setMustDiscardMarginBefore):
(WebCore):
(WebCore::RenderBlock::setMustDiscardMarginAfter):
(WebCore::RenderBlock::mustDiscardMarginBefore):
(WebCore::RenderBlock::mustDiscardMarginAfter):
(WebCore::RenderBlock::mustDiscardMarginBeforeForChild):
(WebCore::RenderBlock::mustDiscardMarginAfterForChild):
(WebCore::RenderBlock::mustSeparateMarginBeforeForChild):
(WebCore::RenderBlock::mustSeparateMarginAfterForChild):
* rendering/RenderBlock.h:
(RenderBlock):
(WebCore::RenderBlock::initMaxMarginValues):
(MarginInfo):
(WebCore::RenderBlock::MarginInfo::setPositiveMargin):
(WebCore::RenderBlock::MarginInfo::setNegativeMargin):
(WebCore::RenderBlock::MarginInfo::setPositiveMarginIfLarger):
(WebCore::RenderBlock::MarginInfo::setNegativeMarginIfLarger):
(WebCore::RenderBlock::MarginInfo::setMargin):
(WebCore::RenderBlock::MarginInfo::setCanCollapseMarginAfterWithChildren):
(WebCore::RenderBlock::MarginInfo::setDiscardMargin):
(WebCore::RenderBlock::MarginInfo::discardMargin):
(WebCore::RenderBlock::RenderBlockRareData::RenderBlockRareData):
(WebCore::RenderBlock::RenderBlockRareData::positiveMarginBeforeDefault):
(RenderBlockRareData):
* rendering/style/RenderStyle.h:
LayoutTests:
Four new tests covering the -webkit-margin-collapse property basic behavior: collapsing
between a block container and its children, collapsing between sibling boxes in both TTB
and BTT direction. The last test verifies if a container's before margin correctly resets
the discard value after a clear of the child that initally caused it.
* fast/block/margin-collapse/webkit-margin-collapse-container-expected.html: Added.
* fast/block/margin-collapse/webkit-margin-collapse-container.html: Added.
* fast/block/margin-collapse/webkit-margin-collapse-floats-expected.html: Added.
* fast/block/margin-collapse/webkit-margin-collapse-floats.html: Added.
* fast/block/margin-collapse/webkit-margin-collapse-siblings-bt-expected.html: Added.
* fast/block/margin-collapse/webkit-margin-collapse-siblings-bt.html: Added.
* fast/block/margin-collapse/webkit-margin-collapse-siblings-expected.html: Added.
* fast/block/margin-collapse/webkit-margin-collapse-siblings.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142974
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jochen@chromium.org [Fri, 15 Feb 2013 09:49:03 +0000 (09:49 +0000)]
Speculative build fix for chromium-win.
Unreviewed build fix.
Add declarations of the copy constructor and assignment operator to
WebTestProxyBase, so VS doesn't try to generate them.
* DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142973
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 15 Feb 2013 09:44:19 +0000 (09:44 +0000)]
[Qt] Port GCController to JSC C API
https://bugs.webkit.org/show_bug.cgi?id=109690
Patch by Simon Hausmann <simon.hausmann@digia.com> on 2013-02-15
Reviewed by Benjamin Poulain.
Source/WebKit/qt:
Add hooks to retrieve JSContextRef and window object.
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::getJSWindowObject):
* WebCoreSupport/DumpRenderTreeSupportQt.h:
Tools:
Rename TestRunner to TestRunnerQt to avoid conflict when
including TestRunner.h in the future.
Replaced QObject based GCController implementation with JSC C API
based one.
* DumpRenderTree/qt/DumpRenderTree.pro:
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::DumpRenderTree):
(WebCore::DumpRenderTree::open):
(WebCore::DumpRenderTree::initJSObjects):
(WebCore::methodNameStringForFailedTest):
* DumpRenderTree/qt/DumpRenderTreeQt.h:
(WebCore::DumpRenderTree::testRunner):
(DumpRenderTree):
* DumpRenderTree/qt/GCControllerQt.cpp:
(GCController::getJSObjectCount):
* DumpRenderTree/qt/GCControllerQt.h: Removed.
* DumpRenderTree/qt/TestRunnerQt.cpp:
(TestRunnerQt::TestRunnerQt):
(TestRunnerQt::reset):
(TestRunnerQt::dumpNotifications):
(TestRunnerQt::processWork):
(TestRunnerQt::maybeDump):
(TestRunnerQt::dumpAsText):
(TestRunnerQt::waitUntilDone):
(TestRunnerQt::setViewModeMediaFeature):
(TestRunnerQt::webHistoryItemCount):
(TestRunnerQt::keepWebHistory):
(TestRunnerQt::notifyDone):
(TestRunnerQt::windowCount):
(TestRunnerQt::grantWebNotificationPermission):
(TestRunnerQt::ignoreLegacyWebNotificationPermissionRequests):
(TestRunnerQt::denyWebNotificationPermission):
(TestRunnerQt::removeAllWebNotificationPermissions):
(TestRunnerQt::simulateWebNotificationClick):
(TestRunnerQt::simulateLegacyWebNotificationClick):
(TestRunnerQt::display):
(TestRunnerQt::displayInvalidatedRegion):
(TestRunnerQt::clearBackForwardList):
(TestRunnerQt::pathToLocalResource):
(TestRunnerQt::dumpEditingCallbacks):
(TestRunnerQt::dumpFrameLoadCallbacks):
(TestRunnerQt::dumpProgressFinishedCallback):
(TestRunnerQt::dumpUserGestureInFrameLoadCallbacks):
(TestRunnerQt::dumpResourceLoadCallbacks):
(TestRunnerQt::dumpResourceResponseMIMETypes):
(TestRunnerQt::dumpWillCacheResponse):
(TestRunnerQt::dumpHistoryCallbacks):
(TestRunnerQt::setWillSendRequestReturnsNullOnRedirect):
(TestRunnerQt::setWillSendRequestReturnsNull):
(TestRunnerQt::setWillSendRequestClearHeader):
(TestRunnerQt::setDeferMainResourceDataLoad):
(TestRunnerQt::queueBackNavigation):
(TestRunnerQt::queueForwardNavigation):
(TestRunnerQt::queueLoad):
(TestRunnerQt::queueLoadHTMLString):
(TestRunnerQt::queueReload):
(TestRunnerQt::queueLoadingScript):
(TestRunnerQt::queueNonLoadingScript):
(TestRunnerQt::provisionalLoad):
(TestRunnerQt::timerEvent):
(TestRunnerQt::encodeHostName):
(TestRunnerQt::decodeHostName):
(TestRunnerQt::closeWebInspector):
(TestRunnerQt::setDeveloperExtrasEnabled):
(TestRunnerQt::setAsynchronousSpellCheckingEnabled):
(TestRunnerQt::showWebInspector):
(TestRunnerQt::evaluateInWebInspector):
(TestRunnerQt::goBack):
(TestRunnerQt::setDefersLoading):
(TestRunnerQt::setAllowUniversalAccessFromFileURLs):
(TestRunnerQt::setAllowFileAccessFromFileURLs):
(TestRunnerQt::setAppCacheMaximumSize):
(TestRunnerQt::setAutofilled):
(TestRunnerQt::setValueForUser):
(TestRunnerQt::setFixedContentsSize):
(TestRunnerQt::setPrivateBrowsingEnabled):
(TestRunnerQt::setSpatialNavigationEnabled):
(TestRunnerQt::setPopupBlockingEnabled):
(TestRunnerQt::setPluginsEnabled):
(TestRunnerQt::setPOSIXLocale):
(TestRunnerQt::setWindowIsKey):
(TestRunnerQt::setMainFrameIsFirstResponder):
(TestRunnerQt::setJavaScriptCanAccessClipboard):
(TestRunnerQt::setXSSAuditorEnabled):
(TestRunnerQt::dispatchPendingLoadRequests):
(TestRunnerQt::clearAllApplicationCaches):
(TestRunnerQt::clearApplicationCacheForOrigin):
(TestRunnerQt::localStorageDiskUsageForOrigin):
(TestRunnerQt::setApplicationCacheOriginQuota):
(TestRunnerQt::applicationCacheDiskUsageForOrigin):
(TestRunnerQt::originsWithApplicationCache):
(TestRunnerQt::setCacheModel):
(TestRunnerQt::setDatabaseQuota):
(TestRunnerQt::clearAllDatabases):
(TestRunnerQt::addOriginAccessWhitelistEntry):
(TestRunnerQt::removeOriginAccessWhitelistEntry):
(TestRunnerQt::setCustomPolicyDelegate):
(TestRunnerQt::waitForPolicyDelegate):
(TestRunnerQt::overridePreference):
(TestRunnerQt::setUserStyleSheetLocation):
(TestRunnerQt::setCaretBrowsingEnabled):
(TestRunnerQt::setAuthorAndUserStylesEnabled):
(TestRunnerQt::setUserStyleSheetEnabled):
(TestRunnerQt::setDomainRelaxationForbiddenForURLScheme):
(TestRunnerQt::callShouldCloseOnWebView):
(TestRunnerQt::setScrollbarPolicy):
(TestRunnerQt::setSmartInsertDeleteEnabled):
(TestRunnerQt::setSelectTrailingWhitespaceEnabled):
(TestRunnerQt::execCommand):
(TestRunnerQt::isCommandEnabled):
(TestRunnerQt::findString):
(TestRunnerQt::markerTextForListItem):
(TestRunnerQt::computedStyleIncludingVisitedInfo):
(TestRunnerQt::elementDoesAutoCompleteForElementWithId):
(TestRunnerQt::authenticateSession):
(TestRunnerQt::setIconDatabaseEnabled):
(TestRunnerQt::setMockDeviceOrientation):
(TestRunnerQt::setGeolocationPermission):
(TestRunnerQt::numberOfPendingGeolocationPermissionRequests):
(TestRunnerQt::setGeolocationPermissionCommon):
(TestRunnerQt::setMockGeolocationPositionUnavailableError):
(TestRunnerQt::setMockGeolocationPosition):
(TestRunnerQt::addMockSpeechInputResult):
(TestRunnerQt::setMockSpeechInputDumpRect):
(TestRunnerQt::startSpeechInput):
(TestRunnerQt::evaluateScriptInIsolatedWorldAndReturnValue):
(TestRunnerQt::evaluateScriptInIsolatedWorld):
(TestRunnerQt::addUserStyleSheet):
(TestRunnerQt::removeAllVisitedLinks):
(TestRunnerQt::addURLToRedirect):
(TestRunnerQt::originsWithLocalStorage):
(TestRunnerQt::deleteAllLocalStorage):
(TestRunnerQt::deleteLocalStorageForOrigin):
(TestRunnerQt::observeStorageTrackerNotifications):
(TestRunnerQt::syncLocalStorage):
(TestRunnerQt::resetPageVisibility):
(TestRunnerQt::setPageVisibility):
(TestRunnerQt::setAutomaticLinkDetectionEnabled):
(TestRunnerQt::setTextDirection):
(TestRunnerQt::setAlwaysAcceptCookies):
(TestRunnerQt::setAlwaysBlockCookies):
(TestRunnerQt::setAudioData):
* DumpRenderTree/qt/TestRunnerQt.h:
(TestRunnerQt):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142972
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 15 Feb 2013 09:02:22 +0000 (09:02 +0000)]
[EFL] fast/forms/input-text-scroll-left-on-blur.html is passing now
https://bugs.webkit.org/show_bug.cgi?id=109896
Unreviewed efl gardening.
The expectations are added by r140250 and the test seems to be passing now.
Patch by KwangYong Choi <ky0.choi@samsung.com> on 2013-02-15
* platform/efl/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142971
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zherczeg@webkit.org [Fri, 15 Feb 2013 09:00:51 +0000 (09:00 +0000)]
ChangeLog fix for bug 109689.
https://bugs.webkit.org/show_bug.cgi?id=109689
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142970
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Fri, 15 Feb 2013 07:45:16 +0000 (07:45 +0000)]
Web Inspector: always show memory size in Mb on the native memory graph
https://bugs.webkit.org/show_bug.cgi?id=109813
Reviewed by Pavel Feldman.
Memory size vlue is alway shown in Mb on the native memory graph.
* inspector/front-end/NativeMemoryGraph.js:
(WebInspector.NativeMemoryCounterUI.prototype.updateCurrentValue):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142969
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 15 Feb 2013 07:15:01 +0000 (07:15 +0000)]
[WK2] Rename from scrollOffset to scrollDelta in WebChromeClient.
https://bugs.webkit.org/show_bug.cgi?id=109885
Patch by Huang Dongsung <luxtella@company100.net> on 2013-02-14
Reviewed by Simon Fraser.
Chrome sends a scroll delta to WebChromeClient but WebChromeClient names it
scrollOffset. So this patch corrects this misnaming.
In addition, all subclasses of LayerTreeHost don't use the misnamed
scrollOffset in scrollNonCompositedContents(), so this patch removes the
scrollOffset argument.
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::scroll):
* WebProcess/WebCoreSupport/WebChromeClient.h:
(WebChromeClient):
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
(WebKit::CoordinatedLayerTreeHost::scrollNonCompositedContents):
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:
(CoordinatedLayerTreeHost):
* WebProcess/WebPage/DrawingArea.h:
(DrawingArea):
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::scroll):
* WebProcess/WebPage/DrawingAreaImpl.h:
(DrawingAreaImpl):
* WebProcess/WebPage/LayerTreeHost.h:
(LayerTreeHost):
* WebProcess/WebPage/gtk/LayerTreeHostGtk.cpp:
(WebKit::LayerTreeHostGtk::scrollNonCompositedContents):
* WebProcess/WebPage/gtk/LayerTreeHostGtk.h:
(LayerTreeHostGtk):
* WebProcess/WebPage/mac/LayerTreeHostMac.h:
(LayerTreeHostMac):
* WebProcess/WebPage/mac/LayerTreeHostMac.mm:
(WebKit::LayerTreeHostMac::scrollNonCompositedContents):
* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
(RemoteLayerTreeDrawingArea):
* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::scroll):
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
(TiledCoreAnimationDrawingArea):
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::scroll):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142968
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aandrey@chromium.org [Fri, 15 Feb 2013 07:01:31 +0000 (07:01 +0000)]
Use GL typedefs in WebGLRenderingContext.idl
https://bugs.webkit.org/show_bug.cgi?id=109060
Reviewed by Kenneth Russell.
Use GL typedefs in WebGLRenderingContext.idl according to the specs.
Added a FIXME about inconsistency with the current WebGL spec for getAttribLocation.
Tested manually that generators V8, JS, ObjC, GObject, CPP produce same output.
* html/canvas/WebGLRenderingContext.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142967
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Fri, 15 Feb 2013 06:41:10 +0000 (06:41 +0000)]
Merged the global function cache into the source code cache
https://bugs.webkit.org/show_bug.cgi?id=108660
Reviewed by Sam Weinig.
This has a few benefits:
(*) Saves a few kB by removing a second cache data structure.
(*) Reduces the worst case memory usage of the cache by 1.75X. (Heavy
use of 'new Function' and other techniques could cause us to fill
both root caches, and they didn't trade off against each other.)
(*) Paves the way for future improvements based on a non-trivial
cache key (for example, shrinkable pointer to the key string, and
more precise cache size accounting).
Also cleaned up the cache implementation and simplified it a bit.
* heap/Handle.h:
(HandleBase):
* heap/Strong.h:
(Strong): Build!
* runtime/CodeCache.cpp:
(JSC):
(JSC::CodeCache::getCodeBlock):
(JSC::CodeCache::generateFunctionCodeBlock):
(JSC::CodeCache::getFunctionExecutableFromGlobalCode):
(JSC::CodeCache::usedFunctionCode): Updated for three interface changes:
(*) SourceCodeKey is a class, not a pair.
(*) Table values are abstract pointers, since they can be executables
or code blocks. (In a future patch, I'd like to change this so we
always store only code blocks. But that's too much for one patch.)
(*) The cache function is named "set" because it always overwrites
unconditionally.
* runtime/CodeCache.h:
(CacheMap):
(JSC::CacheMap::find):
(JSC::CacheMap::set):
(JSC::CacheMap::clear): Added support for specifying hash traits, so we
can use a SourceCodeKey.
Removed side table and random number generator to save space and reduce
complexity. Hash tables are already random, so we don't need another source
of randomness.
(SourceCodeKey):
(JSC::SourceCodeKey::SourceCodeKey):
(JSC::SourceCodeKey::isHashTableDeletedValue):
(JSC::SourceCodeKey::hash):
(JSC::SourceCodeKey::isNull):
(JSC::SourceCodeKey::operator==):
(JSC::SourceCodeKeyHash::hash):
(JSC::SourceCodeKeyHash::equal):
(SourceCodeKeyHash):
(SourceCodeKeyHashTraits):
(JSC::SourceCodeKeyHashTraits::isEmptyValue): A SourceCodeKey is just a
fancy triplet: source code string; function name (or null, for non-functions);
and flags. Flags and function name distinguish between functions and programs
with identical code, so they can live in the same cache.
I chose to use the source code string as the primary hashing reference
because it's likely to be unique. We can use profiling to choose another
technique in future, if collisions between functions and programs prove
to be hot. I suspect they won't.
(JSC::CodeCache::clear):
(CodeCache): Removed the second cache.
* heap/Handle.h:
(HandleBase):
* heap/Strong.h:
(Strong):
* runtime/CodeCache.cpp:
(JSC):
(JSC::CodeCache::getCodeBlock):
(JSC::CodeCache::generateFunctionCodeBlock):
(JSC::CodeCache::getFunctionExecutableFromGlobalCode):
(JSC::CodeCache::usedFunctionCode):
* runtime/CodeCache.h:
(JSC):
(CacheMap):
(JSC::CacheMap::find):
(JSC::CacheMap::set):
(JSC::CacheMap::clear):
(SourceCodeKey):
(JSC::SourceCodeKey::SourceCodeKey):
(JSC::SourceCodeKey::isHashTableDeletedValue):
(JSC::SourceCodeKey::hash):
(JSC::SourceCodeKey::isNull):
(JSC::SourceCodeKey::operator==):
(JSC::SourceCodeKeyHash::hash):
(JSC::SourceCodeKeyHash::equal):
(SourceCodeKeyHash):
(SourceCodeKeyHashTraits):
(JSC::SourceCodeKeyHashTraits::isEmptyValue):
(JSC::CodeCache::clear):
(CodeCache):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142966
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vsevik@chromium.org [Fri, 15 Feb 2013 06:39:03 +0000 (06:39 +0000)]
Web Inspector: Copy-pasting selected text over itself should be an undoable state.
https://bugs.webkit.org/show_bug.cgi?id=109830
Reviewed by Pavel Feldman.
Source/WebCore:
* inspector/front-end/TextEditorModel.js:
(WebInspector.TextEditorModel.endsWithBracketRegex.):
LayoutTests:
* inspector/editor/text-editor-undo-redo-expected.txt:
* inspector/editor/text-editor-undo-redo.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142965
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 15 Feb 2013 06:33:14 +0000 (06:33 +0000)]
Remove a test expectation now that the culprit has been rolled out in r142962.
* platform/mac/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142964
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vsevik@chromium.org [Fri, 15 Feb 2013 06:29:40 +0000 (06:29 +0000)]
Unreviewed chromium test fix: incorrect field was used for UISourceCode url.
* src/js/Tests.js:
(.TestSuite.prototype.testNoScriptDuplicatesOnPanelSwitch.checkNoDuplicates):
(.TestSuite.prototype.uiSourceCodesToString_):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142963
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 15 Feb 2013 06:26:36 +0000 (06:26 +0000)]
Unreviewed, rolling out r142889.
http://trac.webkit.org/changeset/142889
https://bugs.webkit.org/show_bug.cgi?id=109891
It caused an assertion failure in scrollbars/overflow-
scrollbar-combinations.html (Requested by tkent on #webkit).
Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-14
Source/WebCore:
* rendering/RenderBox.cpp:
(WebCore::borderWidthChanged):
(WebCore::RenderBox::styleDidChange):
LayoutTests:
* fast/block/dynamic-padding-border-expected.txt: Removed.
* fast/block/dynamic-padding-border.html: Removed.
* fast/table/border-collapsing/cached-change-row-border-width-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142962
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 15 Feb 2013 06:21:16 +0000 (06:21 +0000)]
Add assertion failure expectations on Mac per bugs 109869 and 109890.
* platform/mac/TestExpectations:
* platform/mac-wk2/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142961
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 15 Feb 2013 05:59:02 +0000 (05:59 +0000)]
Caret positioned at the end of a text line (followed by an empty block) in vertical writing mode disappears when pressing the right/down arrow key.
https://bugs.webkit.org/show_bug.cgi?id=106452
Patch by Arpita Bahuguna <arpitabahuguna@gmail.com> on 2013-02-14
Reviewed by Ryosuke Niwa.
Source/WebCore:
Pressing the down or the right arrow key at the end of a text line in
vertical writing mode would make the caret dissapear. This occurs only
when the text line is followed by an empty block.
When trying to compute the next position for placing the caret (for
down/right key), we try to ascertain whether the renderer (in this
case the empty block) is a valid candidate or not. For blockFlow
elements we check against their height.
In vertical writing mode though we would fail such a check since we
should instead be comparing against the renderer's width and not
it's height. Thus, a valid position for the placement of the caret
was not found in such a case.
Test: editing/selection/caret-at-end-of-text-line-followed-by-empty-block-in-vertical-mode.html
* dom/Position.cpp:
(WebCore::Position::isCandidate):
* dom/PositionIterator.cpp:
(WebCore::PositionIterator::isCandidate):
Instead of checking against the height(), check against the
logicalHeight() of the renderer has been added. logicalHeight()
on blockFlow renderer's returns a value in accordance with
the writing mode.
LayoutTests:
* editing/selection/caret-at-end-of-text-line-followed-by-empty-block-in-vertical-mode-expected.txt: Added.
* editing/selection/caret-at-end-of-text-line-followed-by-empty-block-in-vertical-mode.html: Added.
Layout test case added for verifying that pressing the down or the right arrow
key at the end of the text line in vertical writing mode will not make the caret
dissapear.
Caret positions at the start, the end, and after pressing the right and the down
arrow keys at the end of the text line, are compared for verification.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142960
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 15 Feb 2013 05:55:36 +0000 (05:55 +0000)]
Windows build fix after r142957.
* dom/DOMAllInOne.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142959
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 15 Feb 2013 05:47:52 +0000 (05:47 +0000)]
Fix a typo introduced in r142705.
Without this fix, text-input-controller.html can fail when DeleteButtonController is enabled.
e.g. "run-webkit-tests platform/mac/editing/deleting/deletionUI-single-instance.html
platform/mac/editing/input/text-input-controller.html --child-processes=1"
* editing/Editor.cpp:
(WebCore::Editor::avoidIntersectionWithDeleteButtonController):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142958
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hayato@chromium.org [Fri, 15 Feb 2013 04:38:39 +0000 (04:38 +0000)]
Factor Event retargeting code.
https://bugs.webkit.org/show_bug.cgi?id=109156
Reviewed by Dimitri Glazkov.
To supoort Touch event retargeting (bug 107800), we have to factor
event retargeting code so that it can support not only MouseEvent,
but also other events.
New class, EventRetargeter, was introduced. From now,
EventDispatchMediator (and its subclasses) should call, if event
retargeting is required, an appropriate function provided in
EventRetargeter rather than calling
EventDispatcher::adjustRelatedTarget(), which was removed in this
patch.
No tests. No change in behavior.
* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* dom/EventDispatchMediator.cpp:
* dom/EventDispatcher.cpp:
(WebCore):
(WebCore::EventDispatcher::ensureEventPath): Changed to return an EventPath, which will be used by EventRetargeter.
(WebCore::EventDispatcher::dispatchScopedEvent):
(WebCore::EventDispatcher::dispatchEvent):
(WebCore::EventDispatcher::dispatchEventPostProcess):
* dom/EventDispatcher.h:
(WebCore):
(EventDispatcher):
* dom/EventRetargeter.cpp: Added.
(WebCore):
(WebCore::inTheSameScope):
(WebCore::determineDispatchBehavior):
(WebCore::EventRetargeter::calculateEventPath): Factored out from EventDispatcher::ensureEventPath().
(WebCore::EventRetargeter::adjustForMouseEvent):
(WebCore::EventRetargeter::adjustForFocusEvent):
(WebCore::EventRetargeter::adjustForRelatedTarget):
(WebCore::EventRetargeter::calculateAdjustedNodes): Factored out from EventRelatedTargetAjuster::adjustRelatedTarget().
(WebCore::EventRetargeter::buildRelatedNodeMap): Factored out from EventRelatedTargetAjuster::adjustRelatedTarget().
(WebCore::EventRetargeter::findRelatedNode):
* dom/EventRetargeter.h: Added.
(WebCore):
(EventRetargeter):
(WebCore::EventRetargeter::eventTargetRespectingTargetRules):
* dom/FocusEvent.cpp:
(WebCore::FocusEventDispatchMediator::dispatchEvent): Changed to call EventRetargeter::adjustForFocusEvent().
(WebCore::BlurEventDispatchMediator::dispatchEvent): Ditto.
(WebCore::FocusInEventDispatchMediator::dispatchEvent): Ditto.
(WebCore::FocusOutEventDispatchMediator::dispatchEvent): Ditto.
* dom/MouseEvent.cpp:
(WebCore::MouseEventDispatchMediator::dispatchEvent): Changed to call EventRetargeter::adjustForMouseEvent().
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142957
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Fri, 15 Feb 2013 04:28:45 +0000 (04:28 +0000)]
Reverting r142861. Hit testing inside of style recalc is fundamentally wrong
Source/WebCore:
* page/EventHandler.cpp:
(WebCore::EventHandler::selectCursor):
(WebCore::EventHandler::handleMouseMoveEvent):
* page/EventHandler.h:
* rendering/RenderObject.cpp:
(WebCore::RenderObject::setStyle):
(WebCore::areNonIdenticalCursorListsEqual):
(WebCore::areCursorsEqual):
(WebCore::RenderObject::styleDidChange):
LayoutTests:
* fast/events/mouse-cursor-change-expected.txt: Removed.
* fast/events/mouse-cursor-change.html: Removed.
* fast/events/mouse-cursor-no-mousemove-expected.txt: Removed.
* fast/events/mouse-cursor-no-mousemove.html: Removed.
* platform/mac/TestExpectations:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142956
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
fmalita@chromium.org [Fri, 15 Feb 2013 03:58:18 +0000 (03:58 +0000)]
[SVG] Cached filter results are not invalidated on repaint rect change
https://bugs.webkit.org/show_bug.cgi?id=106221
Reviewed by Dean Jackson.
Source/WebCore:
Since the cached filter results are not invalidated for different repaint rects, we need
to render the content of the whole filter region upfront (otherwise elements not visible
during the initial paint due to scrolling/window size/etc. are never redrawn).
Tests: svg/filters/filter-hidden-content-expected.svg
svg/filters/filter-hidden-content.svg
* rendering/svg/RenderSVGResourceFilter.cpp:
(WebCore::RenderSVGResourceFilter::applyResource):
(WebCore::RenderSVGResourceFilter::drawingRegion):
(WebCore):
* rendering/svg/RenderSVGResourceFilter.h:
(FilterData):
(RenderSVGResourceFilter):
Track the filter drawing region in FilterData.
* rendering/svg/SVGRenderingContext.cpp:
(WebCore::SVGRenderingContext::~SVGRenderingContext):
(WebCore::SVGRenderingContext::prepareToRenderSVGContent):
* rendering/svg/SVGRenderingContext.h:
Update paintInfo.rect to cover the whole drawing region while rendering filter content, and
restore it when done.
LayoutTests:
* svg/filters/filter-hidden-content-expected.svg: Added.
* svg/filters/filter-hidden-content.svg: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142955
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
roger_fong@apple.com [Fri, 15 Feb 2013 03:57:57 +0000 (03:57 +0000)]
Unreviewed. Some final touch-ups to the VS2010 WebKit solution before nuking the VS2005 solution.
Remove un-needed include directories and force includes.
Update exports file.
* WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
* WebKit.vcxproj/common.props:
* DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherCommon.props:
* DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherCommon.props:
* DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj:
* DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters:
* TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj:
* TestWebKitAPI/TestWebKitAPI.vcxproj/TestWebKitAPI.vcxproj.filters:
* WinLauncher/WinLauncher.vcxproj/WinLauncherCommon.props:
* win/record-memory/record-memoryCommon.props:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* JavaScriptCore.vcxproj/JavaScriptCoreCommon.props:
* JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:
* JavaScriptCore.vcxproj/jsc/jscCommon.props:
* JavaScriptCore.vcxproj/testRegExp/testRegExp.vcxproj:
* JavaScriptCore.vcxproj/testapi/testapi.vcxproj:
* WTF.vcxproj/WTFCommon.props:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142954
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Fri, 15 Feb 2013 03:07:49 +0000 (03:07 +0000)]
Unreviewed rebaselining following r142940.
* fast/events/onerror-no-constructor-expected.txt:
* platform/chromium/fast/events/onerror-no-constructor-expected.txt: Copied from LayoutTests/fast/events/onerror-no-constructor-expected.txt.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142953
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 15 Feb 2013 02:38:02 +0000 (02:38 +0000)]
[EFL] Correct the mismatched cursor map
https://bugs.webkit.org/show_bug.cgi?id=109655
Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2013-02-14
Reviewed by Laszlo Gombos.
Correct the mismatched ECORE_X_CURSOR values in the cursor map.
* platform/efl/EflScreenUtilities.cpp:
(WebCore::CursorMap::CursorMap):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142952
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
haraken@chromium.org [Fri, 15 Feb 2013 02:07:25 +0000 (02:07 +0000)]
Unreviewed. Rebaselined run-bindings-tests.
* bindings/scripts/test/CPP/WebDOMTestObj.cpp:
(WebDOMTestObj::anyAttribute):
(WebDOMTestObj::setAnyAttribute):
* bindings/scripts/test/CPP/WebDOMTestObj.h:
* bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
(webkit_dom_test_obj_get_any_attribute):
* bindings/scripts/test/JS/JSTestTypedefs.cpp:
(WebCore::jsTestTypedefsPrototypeFunctionFuncWithClamp):
* bindings/scripts/test/V8/V8TestTypedefs.cpp:
(WebCore::TestTypedefsV8Internal::funcWithClampCallback):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142951
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kareng@chromium.org [Fri, 15 Feb 2013 02:02:18 +0000 (02:02 +0000)]
adding myself as a committer
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142950
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kareng@chromium.org [Fri, 15 Feb 2013 02:00:50 +0000 (02:00 +0000)]
adding myself as a committer
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142949
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
roger_fong@apple.com [Fri, 15 Feb 2013 01:42:21 +0000 (01:42 +0000)]
Commented out code meant to be deleted.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142948
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 15 Feb 2013 01:39:18 +0000 (01:39 +0000)]
Convert media controls from DeprecatedFlexibleBox to FlexibleBox
https://bugs.webkit.org/show_bug.cgi?id=109775
Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-02-14
Reviewed by Ojan Vafai.
Source/WebCore:
Covered by existing tests in media/.
* css/mediaControls.css:
* css/mediaControlsBlackBerry.css:
* css/mediaControlsChromium.css:
* css/mediaControlsChromiumAndroid.css:
* css/mediaControlsEfl.css:
* css/mediaControlsGtk.css:
* css/mediaControlsQt.css:
* css/mediaControlsQuickTime.css:
Automated search and replace of old flexbox CSS rules to new ones.
Minor tuning of the chromium rules.
* rendering/RenderMediaControlElements.cpp:
(WebCore::RenderMediaControlTimeDisplay::RenderMediaControlTimeDisplay):
(WebCore::RenderMediaControlTimeDisplay::layout):
* rendering/RenderMediaControlElements.h:
Make media controls inherit from RenderFlexibleBox
LayoutTests:
Rebaselined lots of tests. There were two kinds of changes:
- Replaced the RenderDeprecatedFlexibleBox class name with
RenderFlexibleBox, and minor printing differences
- Slight positioning/size changes due to a different algorithm for
shrinking elements (old flexbox shrinks elements evenly, new flexbox
shrinks in proportion to the size of the flex item)
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142947
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
roger_fong@apple.com [Fri, 15 Feb 2013 01:28:57 +0000 (01:28 +0000)]
Build fix for Windows.
* Modules/webdatabase/SQLTransactionStateMachine.cpp:
(WebCore::nameForSQLTransactionState):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142946
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 15 Feb 2013 01:23:50 +0000 (01:23 +0000)]
Mac rebaseline after r142931.
* platform/chromium-mac/fast/replaced/width100percent-image-expected.txt: Added.
* platform/chromium/fast/replaced/width100percent-image-expected.txt: Removed.
* platform/mac/fast/replaced/width100percent-image-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug85016-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142945
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dino@apple.com [Fri, 15 Feb 2013 01:19:55 +0000 (01:19 +0000)]
Inspector doesn't show rules from pluginsStyleSheet
https://bugs.webkit.org/show_bug.cgi?id=109872
Reviewed by Darin Adler.
Make sure getWrapperForRuleInSheets collects the rules
from CSSDefaultStyleSheets::plugInsStyleSheet.
Making a test for this is difficult because the rules in
this sheet only apply to snapshotted plugins at the moment,
which are disabled in DRT, and would require a fairly long
timeout in the test.
* css/InspectorCSSOMWrappers.cpp:
(WebCore::InspectorCSSOMWrappers::getWrapperForRuleInSheets):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142944
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dino@apple.com [Fri, 15 Feb 2013 01:19:33 +0000 (01:19 +0000)]
Clicking outside captions menu should dismiss it
https://bugs.webkit.org/show_bug.cgi?id=109648
Unreviewed. Adding the files I forgot to commit in r142774.
* media/video-controls-captions-trackmenu-hide-on-click.html: Added.
* platform/mac/media/video-controls-captions-trackmenu-hide-on-click-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142943
268f45cc-cd09-0410-ab3c-
d52691b4dbfc