andersca@apple.com [Fri, 12 Dec 2008 20:31:37 +0000 (20:31 +0000)]
2008-12-12 Anders Carlsson <andersca@apple.com>
Revert some accidentally committed changes.
* NetscapeCocoaPlugin/NetscapeCocoaPlugin.xcodeproj/project.pbxproj:
* NetscapeCocoaPlugin/main.m:
(handleDraw):
(handleMouseEvent):
(NPP_HandleEvent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39249
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 12 Dec 2008 20:29:28 +0000 (20:29 +0000)]
2008-12-12 Anders Carlsson <andersca@apple.com>
Reviewed by Kevin Decker.
Add a sample Core Animation NPAPI plug-in.
* NetscapeCocoaPlugin/NetscapeCocoaPlugin.xcodeproj/project.pbxproj:
* NetscapeCocoaPlugin/main.m:
(handleDraw):
(handleMouseEvent):
(NPP_HandleEvent):
* NetscapeCoreAnimationPlugin: Added.
* NetscapeCoreAnimationPlugin/Composition.qtz: Added.
* NetscapeCoreAnimationPlugin/English.lproj: Added.
* NetscapeCoreAnimationPlugin/English.lproj/InfoPlist.strings: Added.
* NetscapeCoreAnimationPlugin/Info.plist: Added.
* NetscapeCoreAnimationPlugin/NetscapeCoreAnimationPlugin.xcodeproj: Added.
* NetscapeCoreAnimationPlugin/NetscapeCoreAnimationPlugin.xcodeproj/project.pbxproj: Added.
* NetscapeCoreAnimationPlugin/main.m: Added.
(NP_Initialize):
(NP_GetEntryPoints):
(NP_Shutdown):
(NPP_New):
(NPP_Destroy):
(NPP_SetWindow):
(NPP_NewStream):
(NPP_DestroyStream):
(NPP_WriteReady):
(NPP_Write):
(NPP_StreamAsFile):
(NPP_Print):
(handleMouseClick):
(NPP_HandleEvent):
(NPP_URLNotify):
(NPP_GetValue):
(NPP_SetValue):
* NetscapeCoreAnimationPlugin/test.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39248
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Fri, 12 Dec 2008 18:10:52 +0000 (18:10 +0000)]
Delete the previous timer-queue timer in the main thread, just prior to scheduling a new timer.
The code previously called DeleteTimerQueueTimer in the timer callback proc.
The new technique simplifies the code, since we now create and delete timers on the
same thread, and don't access the timer queue or timer handles in the callback.
This allows us to remove some mutex use, and more importantly, it solves a race
condition that was occuring between ChangeTimerQueueTimer and DeleteTimerQueueTimer.
Since the timer callback isn't passed the timer handle, we were retrieving that handle
via a global. If the timer callback code was entered, but then a new timer was immediately
scheduled (prior to the callback acquiring the mutex and calling DeleteTimerQueueTimer),
there was a small window where the timer could be re-scheduled via ChangeTimerQueueTimer
and then immediately deleted once the already running callback acquired the mutex and
then called DeleteTimerQueueTimer. This resulted in the newly scheduled timer never firing.
Reviewed by Oliver Hunt.
* platform/win/SharedTimerWin.cpp:
(WebCore::queueTimerProc): Don't delete the timer in the callback.
(WebCore::setSharedTimerFireTime): Always delete and create the timer instead of using ChangeTimerQueueTimer.
(WebCore::stopSharedTimer): Call DeleteTimerQueueTimer directly.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39247
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Fri, 12 Dec 2008 18:06:42 +0000 (18:06 +0000)]
2008-12-12 Kai Brüning <kai@granus.net>
Reviewed and tweaked by Darin Adler.
- fix https://bugs.webkit.org/show_bug.cgi?id=18205
DOMNode objects are garbage collected although there are strong references
<rdar://problem/
6441200>
Fixes resurrection bug for wrapper objects by using an NSMapTable with zeroing weak
memory for the wrapper reference for DOMWrapperCache (DOMInternal.mm),
JSWrapperCache (WebScriptObject.mm) and wrapperCache (DOMRGBColor.mm).
BUILDING_ON_TIGER is used to create a Leopard-only NSMapTable or an old-style
procedural map table for Tiger systems.
No regression tests yet since we don't currently run any tests in GC mode.
* bindings/objc/DOMInternal.h: added WebCore::createWrapperCache for use by all three caches
* bindings/objc/DOMInternal.mm:
(WebCore::createWrapperCache): Contains the compile-time check for map table creation
(WebCore::getDOMWrapper): HashMap -> NSMapTable
(WebCore::addDOMWrapper): ditto
(WebCore::removeDOMWrapper): ditto
* bindings/objc/DOMObject.mm: removed [DOMObject finalize]
* bindings/objc/DOMRGBColor.mm: removed [DOMRGBColor finalize]
(WebCore::getWrapperForRGB): CFMutableDictionaryRef -> NSMapTable
(WebCore::setWrapperForRGB): ditto
(WebCore::removeWrapperForRGB): ditto
* bindings/objc/WebScriptObject.mm:
(WebCore::getJSWrapper): HashMap -> NSMapTable
(WebCore::addJSWrapper): ditto
(WebCore::removeJSWrapper): ditto
(-[WebScriptObject finalize]): removed call of removeJSWrapper()
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39246
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zecke@webkit.org [Fri, 12 Dec 2008 17:42:21 +0000 (17:42 +0000)]
2008-12-12 Brent Fulgham <bfulgham@gmail.com>
Reviewed by Adam Roben.
https://bugs.webkit.org/show_bug.cgi?id=22809
Increase timeout in call to initWithURL so that people actually see
new web pages when they type URLs rather than a blank screen.
* WinLauncher/WinLauncher.cpp:
(loadURL): Increase timeout in initWithURL from 0 to 60 seconds.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39245
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Fri, 12 Dec 2008 17:30:40 +0000 (17:30 +0000)]
2008-12-12 Darin Adler <darin@apple.com>
* Scripts/do-webcore-rename: Add a renaming idea.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39244
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@chromium.org [Fri, 12 Dec 2008 16:10:23 +0000 (16:10 +0000)]
2008-12-12 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=22813
Remove unused references to JSDOMBinding, CallFrame, and JSLock.
* dom/Node.cpp: Removed CallFrame and JSLock header includes.
* loader/FrameLoader.cpp: Removed JSDOMBinding header include.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39243
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zecke@webkit.org [Fri, 12 Dec 2008 16:09:11 +0000 (16:09 +0000)]
Update the WebKit.qrc and add a script to automatically generate the file.
With the way rcc and qmake work this can not be done at build time
as the WebKit.qrc must sit inside the directory that contains the files
and at build time we may not change the content of the source directory.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39242
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zecke@webkit.org [Fri, 12 Dec 2008 16:08:48 +0000 (16:08 +0000)]
Back out r39222 as this is breaking the build on Gentoo (aclocal-1.10)
The m4 directory does not exist and we now have a compile issue on
Gentoo systems.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39241
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Fri, 12 Dec 2008 14:11:04 +0000 (14:11 +0000)]
REGRESSION: Canvas is broken in high dpi mode
<rdar://problem/
6432739> <https://bugs.webkit.org/show_bug.cgi?id=22823>
Reviewed by Alexey Proskuryakov.
Simply made sure that we correctly scale the graphics context to
account for the difference between logical and buffer resolution.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39240
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Fri, 12 Dec 2008 13:49:40 +0000 (13:49 +0000)]
2008-12-12 Simon Hausmann <hausmann@webkit.org>
Reviewed by Tor Arne Vestbø.
Fix pressing return/enter not triggering any action on web sites
that define event handlers, such as the JS console in the web
inspector.
Process the key events in the DOM first and if not handled map them
to editor actions.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39239
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Fri, 12 Dec 2008 13:18:30 +0000 (13:18 +0000)]
2008-12-12 Tor Arne Vestbø <tavestbo@trolltech.com>
Rubber-stamped by Oliver Hunt.
Share PluginView::paintMissingPluginIcon() between ports
Also, enable this feature for Qt/X11, Qt/Mac and GTK
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39238
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Fri, 12 Dec 2008 13:16:39 +0000 (13:16 +0000)]
2008-12-12 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Simon Hausmann.
[Qt/Mac] Implement PluginView::updatePluginWidget()
We should update the window and clip rect regardless of whether or
not the plugin has been loaded, for example to ensure that the
missing plugin image is placed correctly.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39237
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Fri, 12 Dec 2008 13:15:15 +0000 (13:15 +0000)]
2008-12-12 Tor Arne Vestbø <tavestbo@trolltech.com>
Rubber-stamped by Oliver Hunt.
Make PluginView::updatePluginWidget() non-const
We can do this now since frameRectsChanged() is no longer const. This
also allows us to get rid of the mutables in the PluginView.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39236
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Fri, 12 Dec 2008 13:09:28 +0000 (13:09 +0000)]
2008-12-12 Tor Arne Vestbø <tavestbo@trolltech.com>
Rubber-stamped by Oliver Hunt.
Remove mutables from EmbeddedWidget
We can do this now that frameRectsChanged() is no longer const
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39235
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Fri, 12 Dec 2008 11:35:30 +0000 (11:35 +0000)]
2008-12-12 Ariya Hidayat <ariya.hidayat@trolltech.com>
Reviewed by Simon Hausmann.
Create the plugin widget even though the web page has no associated
view. This prevents the plugin to be uselessly constructed more than once.
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::createPlugin):
* tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage::createViewlessPlugin):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39234
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Fri, 12 Dec 2008 10:54:42 +0000 (10:54 +0000)]
2008-12-12 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Simon Hausmann.
Implement ImageSource::filenameExtension() for the Qt port
We're using QImageReader::imageFormat().toLower() to check
that the image format is supported, and if it is we store
the resulting extension when creating the ImageDecoderQt.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39233
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Fri, 12 Dec 2008 09:42:16 +0000 (09:42 +0000)]
2008-12-11 Enrico Ros <enrico.ros@m31.com>
Reviewed by Simon Hausmann.
Fix the broken focus behavior that happened when QWebPage lost
focus to a popup menu.
The previous code didn't notify the QWebPage at all when the
focus was back in (breaking focus rects, caret blinking, ...).
By the way when a popup is show, 2 FocusOut events are delivered
to the QWebPage, but this doesn't seem to hurt.
Added a test to check popup opening, closing a lineedit blinks.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39232
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Fri, 12 Dec 2008 08:22:35 +0000 (08:22 +0000)]
2008-12-11 Ariya Hidayat <ariya.hidayat@trolltech.com>
Reviewed by Tor Arne Vestbø.
When the web page is navigated away, delete the instance
of the native plugin.
http://trolltech.com/developer/task-tracker/index_html?id=214946&method=entry
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::):
* tests/qwebpage/tst_qwebpage.cpp:
(PluginTrackedPage::PluginTrackedPage):
(PluginTrackedPage::createPlugin):
(tst_QWebPage::destroyPlugin):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39231
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Fri, 12 Dec 2008 08:03:20 +0000 (08:03 +0000)]
Fix typo
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39230
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Fri, 12 Dec 2008 08:02:09 +0000 (08:02 +0000)]
2008-12-11 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Remove dependancy on having the Instruction buffer in order to
deref Structures used for property access and global resolves.
Instead, we put references to the necessary Structures in axillary
data structures on the CodeBlock. This is not an ideal solution,
as we still pay for having the Structures in two places and we
would like to eventually just hold on to offsets into the machine
code buffer.
- Also removes CodeBlock bloat in non-JIT by #ifdefing the JIT
only data structures.
* GNUmakefile.am:
* JavaScriptCore.pri:
* JavaScriptCore.scons:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* JavaScriptCoreSources.bkl:
* bytecode/CodeBlock.cpp:
(JSC::isGlobalResolve):
(JSC::isPropertyAccess):
(JSC::instructionOffsetForNth):
(JSC::printGlobalResolveInfo):
(JSC::printStructureStubInfo):
(JSC::CodeBlock::printStructures):
(JSC::CodeBlock::dump):
(JSC::CodeBlock::~CodeBlock):
(JSC::CodeBlock::shrinkToFit):
* bytecode/CodeBlock.h:
(JSC::GlobalResolveInfo::GlobalResolveInfo):
(JSC::getNativePC):
(JSC::CodeBlock::instructions):
(JSC::CodeBlock::getStubInfo):
(JSC::CodeBlock::getBytecodeIndex):
(JSC::CodeBlock::addPropertyAccessInstruction):
(JSC::CodeBlock::addGlobalResolveInstruction):
(JSC::CodeBlock::numberOfStructureStubInfos):
(JSC::CodeBlock::addStructureStubInfo):
(JSC::CodeBlock::structureStubInfo):
(JSC::CodeBlock::addGlobalResolveInfo):
(JSC::CodeBlock::globalResolveInfo):
(JSC::CodeBlock::numberOfCallLinkInfos):
(JSC::CodeBlock::addCallLinkInfo):
(JSC::CodeBlock::callLinkInfo):
* bytecode/Instruction.h:
(JSC::PolymorphicAccessStructureList::PolymorphicStubInfo::set):
(JSC::PolymorphicAccessStructureList::PolymorphicAccessStructureList):
* bytecode/Opcode.h:
(JSC::):
* bytecode/StructureStubInfo.cpp: Copied from bytecode/CodeBlock.cpp.
(JSC::StructureStubInfo::deref):
* bytecode/StructureStubInfo.h: Copied from bytecode/CodeBlock.h.
(JSC::StructureStubInfo::StructureStubInfo):
(JSC::StructureStubInfo::initGetByIdSelf):
(JSC::StructureStubInfo::initGetByIdProto):
(JSC::StructureStubInfo::initGetByIdChain):
(JSC::StructureStubInfo::initGetByIdSelfList):
(JSC::StructureStubInfo::initGetByIdProtoList):
(JSC::StructureStubInfo::initPutByIdTransition):
(JSC::StructureStubInfo::initPutByIdReplace):
(JSC::StructureStubInfo::):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitResolve):
(JSC::BytecodeGenerator::emitGetById):
(JSC::BytecodeGenerator::emitPutById):
(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitConstruct):
(JSC::BytecodeGenerator::emitCatch):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::tryCTICachePutByID):
(JSC::Interpreter::tryCTICacheGetByID):
(JSC::Interpreter::cti_op_get_by_id_self_fail):
(JSC::getPolymorphicAccessStructureListSlot):
(JSC::Interpreter::cti_op_get_by_id_proto_list):
(JSC::Interpreter::cti_op_resolve_global):
* jit/JIT.cpp:
(JSC::JIT::JIT):
(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):
(JSC::JIT::privateCompile):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::compileGetByIdHotPath):
(JSC::JIT::compilePutByIdHotPath):
(JSC::JIT::compileGetByIdSlowCase):
(JSC::JIT::compilePutByIdSlowCase):
(JSC::JIT::privateCompileGetByIdSelfList):
(JSC::JIT::privateCompileGetByIdProtoList):
(JSC::JIT::privateCompileGetByIdChainList):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39229
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
slewis@apple.com [Fri, 12 Dec 2008 07:51:09 +0000 (07:51 +0000)]
2008-12-11 Stephanie Lewis <slewis@apple.com>
Reviewed by Geoff Garen
Account for the size of the response and request headers as well as other overhead
when calculating the size a resource takes up in the cache. Halts unbounded
growth in the cache. Reduced stress test memory high water marks by > 50%.
Uses estimates gathered from the stress test to set the overhead size.
A version of the patch was created that calculated most of the sizes, but it was
decided that the patch was still at a basic level an estimate. What gains it made
in accuracy was offset by the complexity involved in creating and updating the
estimate.
* loader/Cache.cpp:
(WebCore::Cache::resourceAccessed):
(WebCore::Cache::TypeStatistic::addResource):
(WebCore::Cache::dumpLRULists):
* loader/CachedResource.cpp:
(WebCore::CachedResource::overheadSize):
* loader/CachedResource.h:
(WebCore::CachedResource::size):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39228
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cwzwarich@webkit.org [Fri, 12 Dec 2008 07:28:27 +0000 (07:28 +0000)]
2008-12-11 Cameron Zwarich <zwarich@apple.com>
Rubber-stamped by Mark Rowe.
Roll out r39212 due to assertion failures during layout tests, multiple
layout test failures, memory leaks, and obvious incorrectness.
WebKit/mac:
* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.mm:
(-[WebPreferences fullDocumentTeardownEnabled]):
* WebView/WebPreferencesPrivate.h:
WebKit/win:
* Interfaces/IWebPreferencesPrivate.idl:
* WebPreferenceKeysPrivate.h:
* WebPreferences.cpp:
* WebPreferences.h:
WebKitTools:
* DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::staticFunctions):
* DumpRenderTree/LayoutTestController.h:
* DumpRenderTree/mac/DumpRenderTree.mm:
(resetWebViewToConsistentStateBeforeTesting):
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
* DumpRenderTree/win/DumpRenderTree.cpp:
(resetWebViewToConsistentStateBeforeTesting):
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::pauseTransitionAtTimeOnElementWithId):
LayoutTests:
* security/override-preferences-2-expected.txt: Removed.
* security/override-preferences-2.html: Removed.
* security/override-preferences-expected.txt: Removed.
* security/override-preferences.html: Removed.
* security/override-zzz-reset-expected.txt: Removed.
* security/override-zzz-reset.html: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39227
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Fri, 12 Dec 2008 04:20:17 +0000 (04:20 +0000)]
2008-12-11 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Remove CTI_ARGUMENTS mode, use va_start implementation on Windows,
unifying JIT callback (cti_*) argument access on OS X & Windows
No performance impact.
* interpreter/Interpreter.h:
* jit/JIT.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
* jit/JIT.h:
* jit/JITInlineMethods.h:
(JSC::JIT::emitCTICall):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::privateCompilePutByIdTransition):
* wtf/Platform.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39226
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Fri, 12 Dec 2008 02:02:14 +0000 (02:02 +0000)]
Reviewed by Holger Freyther.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=22814
Add <wml> image element support. Based on HTML/SVGImage{Element/Loader}, with
the only difference that WML defines a second source attribute 'localsrc', that
takes precedence over the 'src' attribute. If loading the 'localsrc' attribute
fails, the user agent should try loading the 'src' attribute. If both fail the
'alt' fallback content will be used - just like in HTML.
Fixes: fast/wml/img-localsrc.wml (<img> and 'localsrc' attribute)
fast/wml/img-src-localsrc-alt.wml ('localsrc'/'src' fallback handling)
fast/wml/img-src.wml (<img> and 'src' attribute)
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39225
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
slewis@apple.com [Fri, 12 Dec 2008 01:15:17 +0000 (01:15 +0000)]
2008-12-11 Stephanie Lewis <slewis@apple.com>
Fix build.
* WebView/WebView.mm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39224
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zecke@webkit.org [Fri, 12 Dec 2008 01:01:11 +0000 (01:01 +0000)]
Make webkit_web_view_set_window_features internal
Calling this method will not result in a notify::window-features
signal being emitted. This would allow replacing a
WebKitWebWindowFeature on a WebKitWebView without anyone noticing
and the client code would monitor the wrong object.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39223
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zecke@webkit.org [Fri, 12 Dec 2008 00:37:16 +0000 (00:37 +0000)]
2008-12-11 Daniel Macks <dmacks@netspace.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=22714
Put libtool macro files in subdir that it wants.
* GNUmakefile.am:
* configure.ac:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39222
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zecke@webkit.org [Fri, 12 Dec 2008 00:37:00 +0000 (00:37 +0000)]
2008-12-11 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=22043
Do not run into the WebCore::DocumentLoader::updateLoading
ASSERT on Gtk+/CURL when trying to load tests from our LayoutTests.
Do not call setPrimaryLoadComplete when the
activeDocumentLoader has already been replaced. This can happen
when a script executed from within FramerLoader::didFinishLoading will
navigate to another URL.
The assertion is caused by existing tests (e.g.
fast/history/clicked-link-is-visited.html) reproducing this with
network backends not equal to curl is tough or maybe not
even possible.
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::setPrimaryLoadComplete):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39221
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
slewis@apple.com [Fri, 12 Dec 2008 00:20:16 +0000 (00:20 +0000)]
2008-12-11 Stephanie Lewis <slewis@apple.com>
Reviewed by Oliver Hunt.
Empty Web cache before quitting a debug build in order
to report accurate CachedResource leaks.
* WebView/WebView.mm:
(-[WebView _close]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39220
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Thu, 11 Dec 2008 23:42:12 +0000 (23:42 +0000)]
Reviewed by Eric Seidel.
- Remove some dead, commented-out code from WMLAElement.
- Add missing virtual destructor for <noop>, as suggested by Alexey.
- Refactor addHTMLAlignment in a static helper function to share with WML.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39219
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Thu, 11 Dec 2008 22:33:51 +0000 (22:33 +0000)]
<rdar://problem/
6302405> Crash (null-deref) when using :before pseudoselector with content CSS rule in SVG
<https://bugs.webkit.org/show_bug.cgi?id=22804>
Reviewed by Adele Peterson.
This issue was caused by css generated content resulting in non-svg flowboxes
being injected into SVG content. As SVG spec does not describe behaviour in
this case, and neither Opera nor Firefox displays such generated content, so
now we make svg text layout and rendering just ignore any such content.
Test: svg/css/crash-css-generated-content.xhtml
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39218
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cwzwarich@webkit.org [Thu, 11 Dec 2008 21:56:07 +0000 (21:56 +0000)]
2008-12-11 Cameron Zwarich <zwarich@apple.com>
Reviewed by Dave Hyatt.
Bug 21256: REGRESSION (r36906): horizontally repeating image leaves ghosts when vertical scrolling
<https://bugs.webkit.org/show_bug.cgi?id=21256>
<rdar://problem/
6362978>
The ScrollView refactoring in r36906 caused the ScrollView and the
platform widget to disagree about whether optimizing scrolling via
blitting is allowed. The easiest way to fix this is to make ScrollView
simply ask the platform widget whether this is safe on platforms that
are affected.
It is not possible to write a layout test for this bug because it
involves the back/forward cache.
* platform/ScrollView.cpp:
(WebCore::ScrollView::ScrollView):
(WebCore::ScrollView::setCanBlitOnScroll):
(WebCore::ScrollView::canBlitOnScroll):
(WebCore::ScrollView::platformSetCanBlitOnScroll):
(WebCore::ScrollView::platformCanBlitOnScroll):
* platform/ScrollView.h:
* platform/mac/ScrollViewMac.mm:
(WebCore::ScrollView::platformSetCanBlitOnScroll):
(WebCore::ScrollView::platformCanBlitOnScroll):
* platform/wx/ScrollViewWx.cpp:
(WebCore::ScrollView::platformSetCanBlitOnScroll):
(WebCore::ScrollView::platformCanBlitOnScroll):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39217
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 11 Dec 2008 21:27:39 +0000 (21:27 +0000)]
2008-12-11 Anders Carlsson <andersca@apple.com>
Fix Tiger build.
* Misc/WebNSDataExtras.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39216
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 11 Dec 2008 21:26:24 +0000 (21:26 +0000)]
WebKit/mac:
2008-12-11 Anders Carlsson <andersca@apple.com>
Reviewed by Cameron Zwarich.
https://bugs.webkit.org/show_bug.cgi?id=22797
REGRESSION: Crash at http://news.cnet.com/8301-17939_109-
10119149-2.html
Make sure to protect the stream because destroyStream can otherwise cause it to be deleted.
* Plugins/WebBaseNetscapePluginStream.mm:
(WebNetscapePluginStream::destroyStreamWithReason):
LayoutTests:
2008-12-11 Anders Carlsson <andersca@apple.com>
Reviewed by Cameron Zwarich.
https://bugs.webkit.org/show_bug.cgi?id=22797
REGRESSION: Crash at http://news.cnet.com/8301-17939_109-
10119149-2.html
* http/tests/plugins/get-url-expected.txt: Added.
* http/tests/plugins/get-url.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39215
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Thu, 11 Dec 2008 20:44:38 +0000 (20:44 +0000)]
Reviewed by Eric Seidel.
Fix typo in doctype (correct wapforum.org URL)
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39214
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zecke@webkit.org [Thu, 11 Dec 2008 19:16:20 +0000 (19:16 +0000)]
2008-12-11 Brent Fulgham <bfulgham@gmail.com>
Reviewed by Adam Roben.
https://bugs.webkit.org/show_bug.cgi?id=22808
Correct build break due to malformed XML in Visual Studio project
following @r39205 change.
* WebCore.vcproj/WebCore.vcproj: Correct file entry so project loads.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39213
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 11 Dec 2008 19:10:47 +0000 (19:10 +0000)]
2008-12-10 Glenn Wilson <gwilson@google.com>
Reviewed by Adam Roben.
Added new methods for overriding default WebPreference values
and for resetting preferences to their defaults.
https://bugs.webkit.org/show_bug.cgi?id=20534
* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.mm:
(-[WebPreferences resetToDefaults]): new method
(-[WebPreferences overridePreference:flag:]): new method
* WebView/WebPreferencesPrivate.h: new method signatures
2008-12-10 Glenn Wilson <gwilson@google.com>
Reviewed by Adam Roben.
Added support for overriding default preferences per-test.
https://bugs.webkit.org/show_bug.cgi?id=20534
Two new methods were added: resetToDefaults and overridePreference.
* Interfaces/IWebPreferencesPrivate.idl: new method signatures
* WebPreferenceKeysPrivate.h: added new key for internal state
* WebPreferences.cpp: added new methods
(WebPreferences::overridePreference): new method
(WebPreferences::resetToDefaults): new method
* WebPreferences.h: new method signatures
2008-12-10 Glenn Wilson <gwilson@google.com>
Reviewed by Adam Roben.
Changed LayoutTestController and DumpRenderTree to allow for manual
overriding of default preferences at test time. Also added support for
resetting the preferences after each test.
https://bugs.webkit.org/show_bug.cgi?id=20534
* DumpRenderTree/LayoutTestController.cpp: Added callback method for overriding preferences
* DumpRenderTree/LayoutTestController.h: Added signature for callback
* DumpRenderTree/win/DumpRenderTree.cpp: Added calls to reset preferences after each test if necessary
* DumpRenderTree/win/LayoutTestControllerWin.cpp: Added JS override function
* DumpRenderTree/mac/DumpRenderTree.mm: Added calls to reset preferences after each test if necessary
* DumpRenderTree/mac/LayoutTestControllerMac.mm: Added JS override function
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39212
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cmarrin@apple.com [Thu, 11 Dec 2008 16:24:32 +0000 (16:24 +0000)]
Reviewed by Dave Hyatt.
Fixed https://bugs.webkit.org/show_bug.cgi?id=22738
This gets rid of the per-animation timers which were used when an animation
started, ended and looped. Their job is now done by the main AnimationController's
timer. It is now set to fire as needed. For instance, if there is a delay, it will
fire after the delay time and then every 30ms to run the animation. The start, loop
and end events are generated as needed during the firing of this timer.
I had to add one more bit of code. When animation timers used to fire the animation events.
This would always happen from the RunLoop, so any style changes that happened in the
event handler would get picked up on the next updateRendering() call. But now the start
event is generated during the styleIsAvailable() call, which is in the middle of the
updateRendering() cycle. And calling an event handler in the middle of updateRendering()
is not allowed and causes style changes to get missed. We already have a mechanism in
AnimationController to defer updateRendering() calls. So I added logic to defer all
event handling to there. Now, I put any request for event handling into a list and ask
for a deferred updateRendering() call. When that deferred timer fires, I go through that
list, send all the events and then call updateRendering().
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39211
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Thu, 11 Dec 2008 15:57:00 +0000 (15:57 +0000)]
2008-12-11 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Simon Hausmann.
Allow applications to save and restore their state between loads.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39210
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Thu, 11 Dec 2008 15:45:47 +0000 (15:45 +0000)]
2008-12-11 Simon Hausmann <simon.hausmann@nokia.com>
Fix the Qt build with an empty filenameExtension() implementation.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39209
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zecke@webkit.org [Thu, 11 Dec 2008 15:03:43 +0000 (15:03 +0000)]
Fix crash in the cairo implementation of the SVGPaintServer
For SVGFonts the RenderObject can be zero. The existing SVGFont
test cases is exposing this bug. Qt and other ports have fixed
this issue by adding null checks as well.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39208
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zecke@webkit.org [Thu, 11 Dec 2008 14:46:52 +0000 (14:46 +0000)]
2008-12-11 Holger Freyther <zecke@selfish.org>
Reviewed by Simon Hausmann.
https://bugs.webkit.org/show_bug.cgi?id=20953
Make the Qt port follow the Win, Mac, Gtk+ port in regard to Font
handling. FontQt.cpp from now on is only implementing the complex path. Create
FontFallbackListQt.cpp and FontPlatformDataQt.cpp to work within
the framework set by the Font code.
Sharing the Font.cpp implementation allows the Qt port to support
the CSS font faces and SVG fonts.
Split out the Qt4.3 Font handling into FonQt43.cpp to allow to more
easily deprecate it.
This commit is removing a lot of #ifdefs from Font.h as the Qt Font
implementation is now in line with the rest of WebCore.
* WebCore.pro:
* platform/graphics/Font.h: Remove #ifdefs
(WebCore::Font::letterSpacing):
(WebCore::Font::setLetterSpacing):
(WebCore::Font::isPlatformFont):
* platform/graphics/FontFallbackList.h:
* platform/graphics/SimpleFontData.cpp:
(WebCore::SimpleFontData::SimpleFontData):
(WebCore::SimpleFontData::platformGlyphInit): There is no GlyphCache
on Qt, move the initialisation over.
(WebCore::SimpleFontData::~SimpleFontData):
* platform/graphics/SimpleFontData.h:
(WebCore::SimpleFontData::getQtFont):
* platform/graphics/qt/FontCacheQt.cpp:
(WebCore::FontCache::getCachedFontPlatformData): Remove unused parameter
(WebCore::FontCache::releaseFontData): Add to build
* platform/graphics/qt/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::~FontCustomPlatformData):
(WebCore::FontCustomPlatformData::fontPlatformData):
(WebCore::createFontCustomPlatformData):
* platform/graphics/qt/FontCustomPlatformData.h:
* platform/graphics/qt/FontFallbackListQt.cpp: Added.
(WebCore::FontFallbackList::FontFallbackList):
(WebCore::FontFallbackList::invalidate):
(WebCore::FontFallbackList::releaseFontData):
(WebCore::FontFallbackList::determinePitch):
(WebCore::FontFallbackList::fontDataAt):
(WebCore::FontFallbackList::fontDataForCharacters):
(WebCore::FontFallbackList::setPlatformFont):
* platform/graphics/qt/FontPlatformData.h:
(WebCore::FontPlatformData::font):
(WebCore::FontPlatformData::size):
* platform/graphics/qt/FontPlatformDataQt.cpp: Added.
(WebCore::FontPlatformData::FontPlatformData):
* platform/graphics/qt/FontQt.cpp:
(WebCore::Font::drawComplexText):
(WebCore::Font::floatWidthForComplexText):
(WebCore::Font::offsetForPositionForComplexText):
(WebCore::Font::selectionRectForComplexText):
(WebCore::Font::font):
* platform/graphics/qt/FontQt43.cpp: Added. Moved Qt4.3 code from FontQt.cpp
(WebCore::Font::drawComplexText):
(WebCore::Font::floatWidthForComplexText):
(WebCore::Font::offsetForPositionForComplexText):
(WebCore::Font::selectionRectForComplexText):
* platform/graphics/qt/GlyphPageTreeNodeQt.cpp:
(WebCore::GlyphPageTreeNode::pruneTreeCustomFontData):
(WebCore::GlyphPageTreeNode::pruneTreeFontData):
* platform/graphics/qt/SimpleFontDataQt.cpp:
(WebCore::SimpleFontData::determinePitch):
(WebCore::SimpleFontData::containsCharacters):
(WebCore::SimpleFontData::platformInit):
(WebCore::SimpleFontData::platformGlyphInit):
(WebCore::SimpleFontData::platformDestroy):
* platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::adjustButtonStyle): Avoid crashes.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39207
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zecke@webkit.org [Thu, 11 Dec 2008 14:14:46 +0000 (14:14 +0000)]
WebCorv
2008-12-11 Holger Freyther <zecke@selfish.org>
Reviewed by Simon Hausmann.
https://bugs.webkit.org/show_bug.cgi?id=20953
For Qt it is not pratical to have a FontCache and GlyphPageTreeNode
implementation. This is one of the reasons why the Qt port is currently not
using WebCore/platform/graphics/Font.cpp. By allowing to not use
the simple/fast-path the Qt port will be able to use it.
Introduce USE(FONT_FAST_PATH) and define it for every port but the
Qt one.
* platform/graphics/Font.cpp:
(WebCore::Font::drawText):
(WebCore::Font::floatWidth):
(WebCore::Font::selectionRectForText):
(WebCore::Font::offsetForPosition):
* platform/graphics/Font.h:
JavaScriptCore
2008-12-11 Holger Freyther <zecke@selfish.org>
Reviewed by Simon Hausmann.
https://bugs.webkit.org/show_bug.cgi?id=20953
For Qt it is not pratical to have a FontCache and GlyphPageTreeNode
implementation. This is one of the reasons why the Qt port is currently not
using WebCore/platform/graphics/Font.cpp. By allowing to not use
the simple/fast-path the Qt port will be able to use it.
Introduce USE(FONT_FAST_PATH) and define it for every port but the
Qt one.
* wtf/Platform.h: Enable USE(FONT_FAST_PATH)
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39206
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zecke@webkit.org [Thu, 11 Dec 2008 11:18:46 +0000 (11:18 +0000)]
2008-12-11 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=20953
Split out the font fast path from Fast.cpp into FontFastPath.cpp. This
will allow the Qt port to share most of WebCore::Font
implementation but the fast path. Qt does not provide the API to get
individual Glyphs making the fast path hard to support.
* GNUmakefile.am:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* WebCoreSources.bkl:
* platform/graphics/Font.cpp:
* platform/graphics/FontFastPath.cpp: Added.
(WebCore::Font::glyphDataForCharacter):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39205
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zecke@webkit.org [Thu, 11 Dec 2008 11:15:38 +0000 (11:15 +0000)]
2008-12-04 Gabor Loki <loki@inf.u-szeged.hu>
Reviewed by Darin Adler and landed by Holger Freyther.
<https://bugs.webkit.org/show_bug.cgi?id=22648>
Fix threading on Qt-port and Gtk-port for Sampling tool.
* wtf/ThreadingGtk.cpp:
(WTF::waitForThreadCompletion):
* wtf/ThreadingQt.cpp:
(WTF::waitForThreadCompletion):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39204
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zecke@webkit.org [Thu, 11 Dec 2008 10:22:40 +0000 (10:22 +0000)]
2008-12-11 Robert Carr <racarr@svn.gnome.org>
Reviewed by Holger Freyther.
https://bugs.webkit.org/show_bug.cgi?id=22560
Code in PlatformScreenGtk for screenDepth and screenRect can not
assume that the platformWindow for the widget has a valid "window"
member. For example in the case of, a new browser view opening as a
child of a GtkNotebook, but never being switched to, or manually
realized. Solve by using the toplevel window of the widget, rather
than the widget itself.
* platform/gtk/PlatformScreenGtk.cpp:
(WebCore::screenDepth):
(WebCore::screenRect):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39203
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Thu, 11 Dec 2008 10:20:57 +0000 (10:20 +0000)]
2008-12-08 Dean McNamee <deanm@chromium.org>
Reviewed by Darin Adler.
Always append a trailing slash when using PHP's sys_get_temp_dir().
This allows these tests to run on Linux, where this API returns the
directory without a trailing slash.
* http/tests/xmlhttprequest/resources/access-control-basic-preflight-cache-invalidation.php:
* http/tests/xmlhttprequest/resources/access-control-basic-preflight-cache-timeout.php:
* http/tests/xmlhttprequest/resources/access-control-basic-preflight-cache.php:
* http/tests/xmlhttprequest/resources/portabilityLayer.php:
* http/tests/xmlhttprequest/resources/reset-temp-file.php:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39202
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Thu, 11 Dec 2008 10:09:50 +0000 (10:09 +0000)]
2008-12-08 Tor Arne Vestbø <tavestbo@trolltech.com>
Reviewed by Darin Adler and Holger Freyther.
Make Widget::frameRectsChanged() and overrides non-const
This will hopefully allow us to get rid of some of the mutables in
the classes that react to the callback by changing their own state.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39201
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zecke@webkit.org [Thu, 11 Dec 2008 10:03:28 +0000 (10:03 +0000)]
Reimplement RenderTheme::caretBlinkInterval for Qt.
The QApplication::cursorFlashTime is in milliseconds and describes
the whole cycle while WebCore expects half a cycle.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39200
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
vestbo@webkit.org [Thu, 11 Dec 2008 08:27:10 +0000 (08:27 +0000)]
2008-12-09 Trenton Schulz <trenton.schulz@nokia.com>
Reviewed by Tor Arne Vestbø.
[Qt/Mac] Don't call HIGetScaleFactor() if we're not on Tiger or better
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39199
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cwzwarich@webkit.org [Thu, 11 Dec 2008 06:27:36 +0000 (06:27 +0000)]
2008-12-10 Cameron Zwarich <zwarich@apple.com>
Reviewed by Oliver Hunt.
Bug 22734: Debugger crashes when stepping into a function call in a return statement
<https://bugs.webkit.org/show_bug.cgi?id=22734>
<rdar://problem/
6426796>
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator): The DebuggerCallFrame uses
the 'this' value stored in a callFrame, so op_convert_this should be
emitted at the beginning of a function body when generating bytecode
with debug hooks.
* debugger/DebuggerCallFrame.cpp:
(JSC::DebuggerCallFrame::thisObject): The assertion inherent in the call
to asObject() here is valid, because any 'this' value should have been
converted to a JSObject*.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39198
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Thu, 11 Dec 2008 04:35:13 +0000 (04:35 +0000)]
2008-12-10 Gavin Barraclough <barraclough@apple.com>
Reviewed by Geoff Garen.
Port more of the JIT to use the MacroAssembler interface.
Everything in the main pass, bar a few corner cases (operations with required
registers, or calling convention code). Slightly refactors array creation,
moving the offset calculation into the callFrame into C code (reducing code
planted).
Overall this appears to be a 1% win on v8-tests, due to the smaller immediates
being planted (in jfalse in particular).
* interpreter/Interpreter.cpp:
(JSC::Interpreter::cti_op_new_array):
* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):
* jit/JIT.h:
* wrec/WRECGenerator.cpp:
(JSC::WREC::Generator::generateEnter):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39197
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Thu, 11 Dec 2008 02:42:05 +0000 (02:42 +0000)]
Rubber-stamped by George Staikos.
Update WML pixel test results, after adding <template> support.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39196
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 11 Dec 2008 02:41:42 +0000 (02:41 +0000)]
2008-12-10 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler.
Implement support for NPN_PostURL/NPN_PostURLNotify in WebKit.
* Plugins/Hosted/NetscapePluginInstanceProxy.h:
Add stopAllStreams.
* Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::stopAllStreams):
Factored out this from ::destroy.
(WebKit::NetscapePluginInstanceProxy::destroy):
Call stopAllStreams().
(WebKit::NetscapePluginInstanceProxy::pluginHostDied):
Ditto.
(WebKit::NetscapePluginInstanceProxy::loadURL):
Handle post being true. This code has been copied from WebNetscapePluginView.mm (for now).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39195
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Thu, 11 Dec 2008 02:34:51 +0000 (02:34 +0000)]
Reviewed by Eric Seidel and George Staikos.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=22799
Add WML <template> support. The <template> element is specified at deck-level
and declares a template for all <card> elements in the document.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39194
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Thu, 11 Dec 2008 02:14:04 +0000 (02:14 +0000)]
2008-12-09 Dmitry Titov <dimich@chromium.org>
Reviewed by Darin Adler.
Fix memory leak - need to call stopActiveDOMObjects
when cached pages get destroyed.
https://bugs.webkit.org/show_bug.cgi?id=22753
* dom/Document.cpp:
(WebCore::Document::detach):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39193
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Thu, 11 Dec 2008 01:55:06 +0000 (01:55 +0000)]
2008-12-10 Simon Fraser <simon.fraser@apple.com>
Reviewed by Antti Koivisto
<rdar://problem/
6431224>
When updating the value of a slider, don't mark the parents
as needing layout, because the size of the slider can never
change. This fixes full-page repaints in some cases.
* rendering/RenderSlider.cpp:
(WebCore::RenderSlider::updateFromElement):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39192
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Thu, 11 Dec 2008 01:51:57 +0000 (01:51 +0000)]
WebKitTools:
2008-12-10 Brady Eidson <beidson@apple.com>
Reviewed by Darin
Implement the new policy delegate (including navigation type and permissive mode) for DRT/win
* DumpRenderTree/win/DumpRenderTree.cpp:
* DumpRenderTree/win/DumpRenderTreeWin.h:
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::setCustomPolicyDelegate):
* DumpRenderTree/win/PolicyDelegate.cpp:
(PolicyDelegate::PolicyDelegate):
(PolicyDelegate::decidePolicyForNavigationAction):
* DumpRenderTree/win/PolicyDelegate.h:
(PolicyDelegate::setPermissive):
LayoutTests:
2008-12-10 Brady Eidson <beidson@apple.com>
Reviewed by Darin
Most of these policy delegate related tests will now pass with accompanying DRT changes.
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39191
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pol@apple.com [Thu, 11 Dec 2008 01:49:49 +0000 (01:49 +0000)]
2008-12-10 Pierre-Olivier Latour <pol@apple.com>
Reviewed by Darin Adler.
Replaced outdated reference image for svg/webarchive/svg-cursor-subresources.svg
https://bugs.webkit.org/show_bug.cgi?id=22801
* platform/mac/svg/webarchive/svg-cursor-subresources-expected.checksum:
* platform/mac/svg/webarchive/svg-cursor-subresources-expected.png:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39190
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 11 Dec 2008 01:25:52 +0000 (01:25 +0000)]
2008-12-10 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler.
Move two NSData category methods to WebNSDataExtras.m.
* Misc/WebNSDataExtras.h:
* Misc/WebNSDataExtras.m:
(-[NSData _web_startsWithBlankLine]):
(-[NSData _web_locationAfterFirstBlankLine]):
* Plugins/WebNetscapePluginView.mm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39189
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer@apple.com [Thu, 11 Dec 2008 01:01:10 +0000 (01:01 +0000)]
Updated Radar bug reference.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39188
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pol@apple.com [Thu, 11 Dec 2008 00:48:35 +0000 (00:48 +0000)]
2008-12-10 Pierre-Olivier Latour <pol@apple.com>
Reviewed by Darin Adler.
Rewrote animations/animation-test-helpers.js to take advantage of the pauseAnimationAtTimeOnElementWithId()
API when available in DRT.
Updated all animations tests that check for values of animated CSS properties to use these new helper functions.
https://bugs.webkit.org/show_bug.cgi?id=22796
* animations/animation-test-helpers.js:
(isCloseEnough):
(checkExpectedValue):
(endTest):
(startTest):
(runAnimationTest):
* animations/big-rotation-expected.txt:
* animations/big-rotation.html:
* animations/change-keyframes-expected.txt:
* animations/change-keyframes-name-expected.txt:
* animations/change-keyframes-name.html:
* animations/change-keyframes.html:
* animations/change-one-anim-expected.txt:
* animations/change-one-anim.html:
* animations/generic-from-to-expected.txt:
* animations/generic-from-to.html:
* animations/import-expected.txt:
* animations/import.html:
* animations/keyframe-timing-functions-expected.txt:
* animations/keyframe-timing-functions.html:
* animations/keyframes-comma-separated-expected.txt:
* animations/keyframes-comma-separated.html:
* animations/keyframes-expected.txt:
* animations/keyframes-from-missing.html:
* animations/keyframes-out-of-order-expected.txt:
* animations/keyframes-out-of-order.html:
* animations/keyframes-to-missing.html:
* animations/keyframes.html:
* animations/lineheight-animation-expected.txt:
* animations/lineheight-animation.html:
* animations/matrix-anim-expected.txt:
* animations/matrix-anim.html:
* animations/multiple-animations-expected.txt:
* animations/multiple-animations.html:
* animations/multiple-keyframes-expected.txt:
* animations/multiple-keyframes.html:
* animations/transition-and-animation-1-expected.txt:
* animations/transition-and-animation-1.html:
* animations/transition-and-animation-2-expected.txt:
* animations/transition-and-animation-2.html:
* animations/width-using-ems-expected.txt:
* animations/width-using-ems.html:
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39187
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alice.liu@apple.com [Thu, 11 Dec 2008 00:00:16 +0000 (00:00 +0000)]
WebCore:
2008-12-10 Alice Liu <alice.liu@apple.com>
Manual test for https://bugs.webkit.org/show_bug.cgi?id=20685
Reviewed by Darin Adler.
* manual-tests/drag-image-to-desktop.html: Added.
LayoutTests:
2008-12-10 Alice Liu <alice.liu@apple.com>
Adding tweak to .conf files needed for
WebCore/manual-tests/drag-image-to-desktop.html
Reviewed by Darin Adler.
* http/conf/apache2-debian-httpd.conf:
* http/conf/apache2-httpd.conf:
* http/conf/cygwin-httpd.conf:
* http/conf/httpd.conf:
* http/tests/misc/resources/generatedimage.bat: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39186
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alice.liu@apple.com [Wed, 10 Dec 2008 23:57:53 +0000 (23:57 +0000)]
WebCore:
2008-12-10 Alice Liu <alice.liu@apple.com>
fixed https://bugs.webkit.org/show_bug.cgi?id=20685
Reviewed by Darin Adler.
Manual test case is manual-tests/drag-image-to-desktop.html
Added new files to projects
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* page/DragController.cpp:
(WebCore::DragController::startDrag):
* platform/MIMETypeRegistry.cpp:
(WebCore::initializeSupportedImageMIMETypes):
(WebCore::initializeSupportedImageMIMETypesForEncoding):
These changes add a method to obtain the extension for an image
* platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::filenameExtension):
* platform/graphics/BitmapImage.h:
* platform/graphics/Image.h:
(WebCore::Image::filenameExtension):
* platform/graphics/ImageSource.h:
* platform/graphics/cairo/ImageSourceCairo.cpp:
(WebCore::ImageSource::filenameExtension):
* platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::ImageSource::filenameExtension):
These changes added a utility that returns the preferred extension for a UTI
* platform/graphics/cg/ImageSourceCG.h: Added.
* platform/graphics/cg/ImageSourceCGMac.mm: Added.
(WebCore::MIMETypeForImageSourceType):
(WebCore::preferredExtensionForImageSourceType):
* platform/graphics/cg/ImageSourceCGWin.cpp: Added.
(WebCore::MIMETypeForImageSourceType):
(WebCore::preferredExtensionForImageSourceType):
* platform/mac/MIMETypeRegistryMac.mm:
moved getMIMETypeForUTI to ImageSourceCGMac.mm
Ask image for its file extension instead of relying on MIME type and file path
* platform/win/ClipboardWin.cpp:
(WebCore::createGlobalImageFileDescriptor):
Remove extraneous code from getPreferredExtensionForMIMEType.
Also moved getMIMETypeForUTI to ImageSourceCGWin.cpp
* platform/win/MIMETypeRegistryWin.cpp:
(WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType):
WebKit/mac:
2008-12-10 Alice Liu <alice.liu@apple.com>
fixed https://bugs.webkit.org/show_bug.cgi?id=20685
Reviewed by Darin Adler.
* Misc/WebNSPasteboardExtras.mm:
Ask image for its file extension instead of falling back on MIME type and file path.
Also moved this code to before setting the pasteboard data so as not to set any if
no extension can be determined.
(-[NSPasteboard _web_declareAndWriteDragImageForElement:URL:title:archive:source:]):
* WebView/WebHTMLView.mm:
Fixed a separate but related long-standing bug of how the filename for the promised
drag data is determined by asking the image for a proper file extension.
(-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39185
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Wed, 10 Dec 2008 21:33:18 +0000 (21:33 +0000)]
2008-12-10 Sam Weinig <sam@webkit.org>
Fix non-JIT builds.
* bytecode/CodeBlock.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39184
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Wed, 10 Dec 2008 20:57:09 +0000 (20:57 +0000)]
2008-12-10 Simon Fraser <simon.fraser@apple.com>
Potential build fix. The forward declaration of FloatPoint should
be inside the WebCore namespace.
* platform/graphics/FloatPoint3D.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39183
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Wed, 10 Dec 2008 20:05:53 +0000 (20:05 +0000)]
2008-12-10 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
<rdar://problem/
6428332> Remove the CTI return address table from CodeBlock
Step 2:
Convert the return address table from a HashMap to a sorted Vector. This
reduces the size of the data structure by ~4.5MB on Membuster head.
SunSpider reports a 0.5% progression.
* bytecode/CodeBlock.cpp:
(JSC::sizeInBytes): Generic method to get the cost of a Vector.
(JSC::CodeBlock::dumpStatistics): Add dumping of member sizes.
* bytecode/CodeBlock.h:
(JSC::PC::PC): Struct representing NativePC -> VirtualPC mappings.
(JSC::getNativePC): Helper for binary chop.
(JSC::CodeBlock::getBytecodeIndex): Used to get the VirtualPC from a
NativePC using a binary chop of the pcVector.
(JSC::CodeBlock::pcVector): Accessor.
* interpreter/Interpreter.cpp:
(JSC::vPCForPC): Use getBytecodeIndex instead of jitReturnAddressVPCMap().get().
(JSC::Interpreter::cti_op_instanceof): Ditto.
(JSC::Interpreter::cti_op_resolve): Ditto.
(JSC::Interpreter::cti_op_resolve_func): Ditto.
(JSC::Interpreter::cti_op_resolve_skip): Ditto.
(JSC::Interpreter::cti_op_resolve_with_base): Ditto.
(JSC::Interpreter::cti_op_throw): Ditto.
(JSC::Interpreter::cti_op_in): Ditto.
(JSC::Interpreter::cti_vm_throw): Ditto.
* jit/JIT.cpp:
(JSC::JIT::privateCompile): Reserve exact capacity and fill the pcVector.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39182
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Wed, 10 Dec 2008 20:03:47 +0000 (20:03 +0000)]
2008-12-10 Simon Fraser <simon.fraser@apple.com>
Reviewed by Sam Weinig
https://bugs.webkit.org/show_bug.cgi?id=22793
Cleanup FloatPoint3D: inline the getters and setters,
fix a potential divide-by-zero in normalize(), and add
a FloatPoint constructor.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39181
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jchaffraix@webkit.org [Wed, 10 Dec 2008 19:18:58 +0000 (19:18 +0000)]
2008-12-10 Julien Chaffraix <jchaffraix@webkit.org>
Reviewed by Eric Seidel.
Bug 22665: Remove setCreatedByParser(bool) from the few elements that use it
https://bugs.webkit.org/show_bug.cgi?id=22665
- Removed setCreatedByParser from style and link elements.
- Removed XMLTokenizer::eventuallyMarkAsCreatedByParser.
* dom/XMLTokenizer.cpp:
* dom/XMLTokenizer.h:
* dom/XMLTokenizerLibxml2.cpp:
(WebCore::XMLTokenizer::startElementNs):
* dom/XMLTokenizerQt.cpp:
(WebCore::XMLTokenizer::parseStartElement):
* html/HTMLElementFactory.cpp:
(WebCore::linkConstructor):
(WebCore::styleConstructor):
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::HTMLLinkElement):
* html/HTMLLinkElement.h:
* html/HTMLStyleElement.cpp:
(WebCore::HTMLStyleElement::HTMLStyleElement):
* html/HTMLStyleElement.h:
* html/HTMLTagNames.in:
* svg/SVGStyleElement.cpp:
(WebCore::SVGStyleElement::SVGStyleElement):
* svg/SVGStyleElement.h:
* svg/svgtags.in:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39180
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Wed, 10 Dec 2008 18:58:09 +0000 (18:58 +0000)]
2008-12-10 Geoffrey Garen <ggaren@apple.com>
Reviewed by Sam :( Weinig.
Added a test for http://trac.webkit.org/changeset/39162.
* fast/regex/malformed-escapes-expected.txt: Added.
* fast/regex/malformed-escapes.html: Added.
* fast/regex/resources/malformed-escapes.js: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39179
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Wed, 10 Dec 2008 18:37:32 +0000 (18:37 +0000)]
WebCore:
2008-12-10 Brady Eidson <beidson@apple.com>
Reviewed by Darin
https://bugs.webkit.org/show_bug.cgi?id=22194 and <rdar://problem/
6388378> -
Dialog when going back to a page from whence you submitted a form
http://trac.webkit.org/changeset/37317 changed the manner in which headers are added to
http requests, which caused the networking layer to have an incomplete set of headers
just before consulting the Policy Delegate. This caused a cache miss and incorrectly made
us believe we'd be resubmitting the form.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadItem): Being careful to maintain the new behavior required by
the Origin header mechanism as discussed in bug 22194, restore the previous behavior of
setting all the headers before the networking layer is asked about the cache lookup.
WebKitTools:
2008-12-10 Brady Eidson <beidson@apple.com>
Reviewed by Darin
Change the custom policy delegate to actually allow navigation for tests that need it.
The new behavior is opt-in and doesn't require any changes in old tests.
* DumpRenderTree/LayoutTestController.cpp:
(setCustomPolicyDelegateCallback): Allow for a second boolean argument to set the permissive flag on the custom
policy delegate, which will be false by default to maintain original behavior.
* DumpRenderTree/LayoutTestController.h:
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::setCustomPolicyDelegate):
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::setCustomPolicyDelegate): Partially stubbed out for now.
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::setCustomPolicyDelegate): Still stubbed out, but with new param.
* DumpRenderTree/mac/PolicyDelegate.h:
* DumpRenderTree/mac/PolicyDelegate.mm:
(-[PolicyDelegate webView:decidePolicyForNavigationAction:request:frame:decisionListener:]): If the permissive flag
is set, allow the navigation.
(-[PolicyDelegate setPermissive:]): Change the behavior between "use" and "ignore" - allowing navigation or not.
LayoutTests:
2008-12-10 Brady Eidson <beidson@apple.com>
Reviewed by Darin
New layout tests for testing the fix for https://bugs.webkit.org/show_bug.cgi?id=22194:
* http/tests/navigation/post-goback-repost-policy-expected.txt: Added.
* http/tests/navigation/post-goback-repost-policy.html: Added.
* http/tests/navigation/resources/goback-with-policydelegate.html: Added.
* http/tests/navigation/resources/post-target-policy-test.html: Added.
Updated layout test results for the new "custom policy delegate" mechanism:
* fast/encoding/mailto-always-utf-8-expected.txt:
* fast/forms/mailto/advanced-get-expected.txt:
* fast/forms/mailto/advanced-put-expected.txt:
* fast/forms/mailto/get-multiple-items-expected.txt:
* fast/forms/mailto/get-multiple-items-text-plain-expected.txt:
* fast/forms/mailto/get-multiple-items-x-www-form-urlencoded-expected.txt:
* fast/forms/mailto/get-non-ascii-always-utf-8-expected.txt:
* fast/forms/mailto/get-non-ascii-expected.txt:
* fast/forms/mailto/get-non-ascii-text-plain-expected.txt:
* fast/forms/mailto/get-non-ascii-text-plain-latin-1-expected.txt:
* fast/forms/mailto/get-overwrite-query-expected.txt:
* fast/forms/mailto/post-append-query-expected.txt:
* fast/forms/mailto/post-multiple-items-expected.txt:
* fast/forms/mailto/post-multiple-items-multipart-form-data-expected.txt:
* fast/forms/mailto/post-multiple-items-text-plain-expected.txt:
* fast/forms/mailto/post-multiple-items-x-www-form-urlencoded-expected.txt:
* fast/forms/mailto/post-text-plain-expected.txt:
* fast/forms/mailto/post-text-plain-with-accept-charset-expected.txt:
* http/tests/security/feed-urls-from-remote-expected.txt:
Skip the new test on Windows until the policy delegate can be enhanced there:
* platform/win/Skipped:
(It is already implicitly skipped for qt and gtk)
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39178
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@chromium.org [Wed, 10 Dec 2008 18:27:22 +0000 (18:27 +0000)]
2008-12-10 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Timothy Hatcher.
Add back ability to end all profiling via console by invoking profileEnd
with no arguments.
* page/Console.cpp:
(WebCore::Console::profileEnd): Removed title null-checking and
subsequent early exit.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39177
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pol@apple.com [Wed, 10 Dec 2008 18:00:55 +0000 (18:00 +0000)]
2008-12-10 Pierre-Olivier Latour <pol@apple.com>
Reviewed by Darin Adler.
KeyframeAnimation::animate() needs to compute the elapsed animation time
properly taking into account its paused state.
https://bugs.webkit.org/show_bug.cgi?id=22773
Test: animations/animation-drt-api-multiple-keyframes.html
* page/animation/KeyframeAnimation.cpp:
(WebCore::KeyframeAnimation::animate):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39176
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Wed, 10 Dec 2008 17:18:12 +0000 (17:18 +0000)]
2008-12-10 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein
Part of
https://bugs.webkit.org/show_bug.cgi?id=22570
Rename methods on RenderLayer for clarity:
clearClipRects -> clearClipRectsIncludingDescendants
clearClipRect -> clearClipRects
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39175
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kevino@webkit.org [Wed, 10 Dec 2008 17:06:15 +0000 (17:06 +0000)]
wx build fix after the script call stack/frame additions.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39174
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zecke@webkit.org [Wed, 10 Dec 2008 16:41:50 +0000 (16:41 +0000)]
2008-12-10 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Simon Hausmann.
API changes discussed with Simon Hausmann, Tor Arne
Vestbø, Ariya Hidayat...
* Api/qwebdatabase.cpp:
(QWebDatabase::fileName):
(QWebDatabase::removeDatabase):
* Api/qwebdatabase.h:
* Api/qwebframe.cpp:
(QWebFrame::scroll):
(QWebFrame::scrollPosition):
(QWebFrame::setScrollPosition):
* Api/qwebframe.h:
* Api/qwebpage.cpp:
(QWebPage::setContentEditable):
(QWebPage::isContentEditable):
(QWebPage::extension):
* Api/qwebpage.h:
* Api/qwebsecurityorigin.cpp:
* Api/qwebsettings.cpp:
(QWebSettingsPrivate::apply):
(QWebSettings::QWebSettings):
* Api/qwebsettings.h:
* QtLauncher/main.cpp:
(MainWindow::setEditable):
* WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::exceededDatabaseQuota):
(WebCore::ChromeClientQt::runOpenPanel):
* WebCoreSupport/EditorClientQt.cpp:
(WebCore::EditorClientQt::isEditable):
* tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage::database):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39173
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zecke@webkit.org [Wed, 10 Dec 2008 16:35:41 +0000 (16:35 +0000)]
2008-12-10 Srinivasa Rao M. Hamse <msrinirao@gmail.com>
Reviewed by Holger Freyther.
F1-F12 key mappings for WebKit Gtk Port
* platform/gtk/KeyEventGtk.cpp:
(WebCore::windowsKeyCodeForKeyEvent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39172
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Wed, 10 Dec 2008 16:06:43 +0000 (16:06 +0000)]
2008-12-10 Enrico Ros <enrico.ros@m31.com>
Reviewed by Simon Hausmann.
Fix the Qt build when SVG is disabled. A broken dependancy caused
unnecessary rebuilds even with no changes.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39171
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Wed, 10 Dec 2008 15:59:24 +0000 (15:59 +0000)]
2008-12-09 Balazs Kelemen <Kelemen.Balazs.3@stud.u-szeged.hu>
Reviewed by Simon Hausmann.
Extended QtLauncher so now it can load pages from an url list
one by one. This can be useful for testing purposes (eq. leak hunting).
The -r option activates this feature.
https://bugs.webkit.org/show_bug.cgi?id=20932
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39170
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Wed, 10 Dec 2008 12:49:56 +0000 (12:49 +0000)]
2008-12-10 Hironori Bono <hbono@chromium.org>
Reviewed by Alexey Proskuryakov.
Bug 21820: Unable to enter the Tamil UNICODE Characters via Thamizha Phonetic IME
https://bugs.webkit.org/show_bug.cgi?id=21820
<rdar://problem/
5683248> Typing backspace to delete a diacritical mark also deletes the character before (Arabic)
<rdar://problem/
5702038> Backspace removes Thai Character in wrong sequence
Tests: editing/deleting/delete-ligature-001.html
editing/deleting/delete-ligature-002.html
editing/deleting/delete-ligature-003.html
* editing/TypingCommand.cpp:
(WebCore::TypingCommand::deleteKeyPressed): Delete only the last character
of a ligature which consists of multiple Unicode characters when deleting it with
a backspace key.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39169
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Wed, 10 Dec 2008 12:23:36 +0000 (12:23 +0000)]
2008-12-10 David Levin <levin@chromium.org>
Reviewed by Alexey Proskuryakov.
https://bugs.webkit.org/show_bug.cgi?id=22177
Fix the windows build by removing calls to notifyFormStateChanged
where they didn't appear in the original reviewed patch.
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::type):
(WebCore::HTMLInputElement::attach):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39168
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Wed, 10 Dec 2008 09:10:32 +0000 (09:10 +0000)]
2008-12-10 Simon Hausmann <hausmann@webkit.org>
Fix the Qt build, added const to Node* parameter after change
in signature.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39167
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Wed, 10 Dec 2008 08:15:08 +0000 (08:15 +0000)]
Rubber-stamped by Maciej Stachowiak.
<rdar://problem/
5959165> Crash in a number of iExploder tests in WebCore::CachedImage::notifyObservers
Add a test for a crash that is no longer reproducible.
* fast/css/mask-missing-image-crash-expected.txt: Added.
* fast/css/mask-missing-image-crash.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39166
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Wed, 10 Dec 2008 07:59:56 +0000 (07:59 +0000)]
Rubber-stamped by Dan Bernstein.
https://bugs.webkit.org/show_bug.cgi?id=19762
Crash in svg/webarchive/svg-cursor-subresources.svg
* svg/webarchive/svg-cursor-subresources.svg: Copied from LayoutTests/svg/webarchive/svg-cursor-subresources.svg-disabled.
* svg/webarchive/svg-cursor-subresources.svg-disabled: Removed.
Re-enabling the test.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39165
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Wed, 10 Dec 2008 07:54:04 +0000 (07:54 +0000)]
JavaScriptCore:
2008-12-09 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Added WREC support for an assertion followed by a quantifier. Fixed
PCRE to match.
* wrec/WRECParser.cpp:
(JSC::WREC::Parser::parseParentheses): Throw away the quantifier, since
it's meaningless. (Firefox does the same.)
* pcre/pcre_compile.cpp:
(compileBranch): ditto.
LayoutTests:
2008-12-09 Geoffrey Garen <ggaren@apple.com>
Reviewed by Oliver Hunt.
Added a test for an assertion followed by a quantifier.
* fast/regex/quantified-assertions-expected.txt: Added.
* fast/regex/quantified-assertions.html: Added.
* fast/regex/resources/quantified-assertions.js: Copied from fast/regex/resources/alternative-length-miscalculation.js.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39164
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Wed, 10 Dec 2008 06:48:36 +0000 (06:48 +0000)]
2008-12-09 Adam Barth <abarth@webkit.org>
Reviewed by Sam Weinig.
Add ScriptController::updateSecurityOrigin to notify the bindings
that a document's securityOrigin has been updated. This is used by
V8 to update its security context.
* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::updateSecurityOrigin):
* bindings/js/ScriptController.h:
* dom/Document.cpp:
(WebCore::Document::setDomain):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39163
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Wed, 10 Dec 2008 04:59:06 +0000 (04:59 +0000)]
JavaScriptCore:
2008-12-09 Geoffrey Garen <ggaren@apple.com>
Reviewed by Cameron Zwarich.
In preparation for compiling WREC without PCRE:
Further relaxed WREC's parsing to be more web-compatible. Fixed PCRE to
match in cases where it didn't already.
Changed JavaScriptCore to report syntax errors detected by WREC, rather
than falling back on PCRE any time WREC sees an error.
* pcre/pcre_compile.cpp:
(checkEscape): Relaxed parsing of \c and \N escapes to be more
web-compatible.
* runtime/RegExp.cpp:
(JSC::RegExp::RegExp): Only fall back on PCRE if WREC has not reported
a syntax error.
* wrec/WREC.cpp:
(JSC::WREC::Generator::compileRegExp): Fixed some error reporting to
match PCRE.
* wrec/WRECParser.cpp: Added error messages that match PCRE.
(JSC::WREC::Parser::consumeGreedyQuantifier):
(JSC::WREC::Parser::parseParentheses):
(JSC::WREC::Parser::parseCharacterClass):
(JSC::WREC::Parser::parseNonCharacterEscape): Updated the above functions to
use the new setError API.
(JSC::WREC::Parser::consumeEscape): Relaxed parsing of \c \N \u \x \B
to be more web-compatible.
(JSC::WREC::Parser::parseAlternative): Distinguish between a malformed
quantifier and a quantifier with no prefix, like PCRE does.
(JSC::WREC::Parser::consumeParenthesesType): Updated to use the new setError API.
* wrec/WRECParser.h:
(JSC::WREC::Parser::error):
(JSC::WREC::Parser::syntaxError):
(JSC::WREC::Parser::parsePattern):
(JSC::WREC::Parser::reset):
(JSC::WREC::Parser::setError): Store error messages instead of error codes,
to provide for exception messages. Use a setter for reporting errors, so
errors detected early are not overwritten by errors detected later.
LayoutTests:
2008-12-09 Geoffrey Garen <ggaren@apple.com>
Reviewed by Cameron Zwarich.
Updated regular expression layout tests to be agnostic between WREC
and PCRE quirks. Also, updated results to match new, more web-compatible
regular expression parsing.
* fast/js/regexp-charclass-crash-expected.txt:
* fast/js/regexp-charclass-crash.html:
* fast/js/regexp-no-extensions-expected.txt:
* fast/js/resources/regexp-no-extensions.js:
* fast/regex/test1-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39162
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Wed, 10 Dec 2008 04:22:00 +0000 (04:22 +0000)]
2008-12-09 Gavin Barraclough <barraclough@apple.com>
Reviewed by Oliver Hunt.
Use va_args to access cti function arguments.
https://bugs.webkit.org/show_bug.cgi?id=22774
This may be a minor regression, but we'll take the hit if so to reduce fragility.
* interpreter/Interpreter.cpp:
* interpreter/Interpreter.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39161
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Wed, 10 Dec 2008 01:42:26 +0000 (01:42 +0000)]
Fix gdb-safari on Tiger.
gdb on Tiger does not take the -arch flag, so do not pass it.
Rubber-stamped by Ada Chan.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39160
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pam@chromium.org [Wed, 10 Dec 2008 01:35:03 +0000 (01:35 +0000)]
2008-12-09 David Levin <levin@chromium.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=22512
Add a test to check for checks when attaching an event to a document created by
'document.implementation.createDocument'.
* fast/events/create-document-crash-on-attach-event-expected.txt: Added.
* fast/events/create-document-crash-on-attach-event.html: Added.
* fast/events/resources/create-document-crash-on-attach-event.js: Added.
(doc.onload):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39159
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pam@chromium.org [Wed, 10 Dec 2008 01:28:20 +0000 (01:28 +0000)]
2008-12-09 David Levin <levin@chromium.org>
Reviewed by Eric Seidel.
Add a test to check the event order for context clicks on Windows.
https://bugs.webkit.org/show_bug.cgi?id=22505
* platform/win/fast/events/context-click-events-expected.txt: Added.
* platform/win/fast/events/context-click-events.html: Added.
* platform/win/fast/events/resources: Added.
* platform/win/fast/events/resources/TEMPLATE.html: Added.
* platform/win/fast/events/resources/context-click-events.js: Added.
(clickHandler):
(traceMouseEvent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39158
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Wed, 10 Dec 2008 00:39:46 +0000 (00:39 +0000)]
2008-12-09 Sam Weinig <sam@webkit.org>
Reviewed twice by Cameron Zwarich.
Fix for https://bugs.webkit.org/show_bug.cgi?id=22752
Clear SymbolTable after codegen for Function codeblocks that
don't require an activation
This is a ~1.5MB improvement on Membuster-head.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpStatistics): Add logging of non-empty symbol tables
and total size used by symbol tables.
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::generate): Clear the symbol table here.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39157
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Wed, 10 Dec 2008 00:26:13 +0000 (00:26 +0000)]
2008-12-09 Sam Weinig <sam@webkit.org>
Reviewed by Geoffrey Garen.
Remove unnecessary extra lookup when throwing an exception.
We used to first lookup the target offset using getHandlerForVPC
and then we would lookup the native code stub using
nativeExceptionCodeForHandlerVPC. Instead, we can just pass around
the HandlerInfo.
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::handlerForVPC): Return the HandlerInfo.
* bytecode/CodeBlock.h: Remove nativeExceptionCodeForHandlerVPC.
* interpreter/Interpreter.cpp:
(JSC::Interpreter::throwException): Return a HandlerInfo instead of
and Instruction offset.
(JSC::Interpreter::privateExecute): Get the offset from HandlerInfo.
(JSC::Interpreter::cti_op_throw): Get the native code from the HandleInfo.
(JSC::Interpreter::cti_vm_throw): Ditto.
* interpreter/Interpreter.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39156
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 10 Dec 2008 00:14:18 +0000 (00:14 +0000)]
2008-12-09 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler.
Fix typecast.
* WebView/WebHTMLView.mm:
(-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39155
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 10 Dec 2008 00:13:56 +0000 (00:13 +0000)]
2008-12-09 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler.
Implement software rendering of hosted plug-ins.
* Plugins/Hosted/NetscapePluginHostProxy.mm:
(WKPCInvalidateRect):
New MiG function. This is called by the plug-in host when it has drawn something.
* Plugins/Hosted/WebHostedNetscapePluginView.h:
* Plugins/Hosted/WebHostedNetscapePluginView.mm:
(-[WebHostedNetscapePluginView createPlugin]):
Create a software renderer.
(-[WebHostedNetscapePluginView destroyPlugin]):
Destroy the software renderer.
(-[WebHostedNetscapePluginView drawRect:]):
Draw using the software renderer.
* Plugins/Hosted/WebKitPluginClient.defs:
Add InvalidateRect.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39154
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Wed, 10 Dec 2008 00:11:46 +0000 (00:11 +0000)]
No review, build fix only.
Fix a few config issues to let the Chromium Windows WebCore build get further.
* WebCore.scons:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39153
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
brettw@chromium.org [Wed, 10 Dec 2008 00:01:39 +0000 (00:01 +0000)]
Reviewed by Dave Hyatt.
https://bugs.webkit.org/show_bug.cgi?id=22177
Add a callback on ChromeClient that the state of form elements on
the page has changed. This is to allow clients implementing session
saving to know when the current state is dirty.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39152
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 9 Dec 2008 23:51:33 +0000 (23:51 +0000)]
2008-12-09 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Make sure to pause null events for hosted plug-ins as well.
* WebView/WebHTMLView.mm:
(-[WebHTMLView _pauseNullEventsForAllNetscapePlugins]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39151
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 9 Dec 2008 23:49:09 +0000 (23:49 +0000)]
2008-12-09 Anders Carlsson <andersca@apple.com>
Reviewed by Darin Adler.
* Plugins/Hosted/NetscapePluginHostProxy.h:
* Plugins/Hosted/NetscapePluginHostProxy.mm:
(WebKit::NetscapePluginHostProxy::NetscapePluginHostProxy):
(WebKit::NetscapePluginHostProxy::~NetscapePluginHostProxy):
Unfortunately we can't use a libdispatch source right now, because of <rdar://problem/
6393180>.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@39150
268f45cc-cd09-0410-ab3c-
d52691b4dbfc