WebKit-https.git
9 years ago[Chromium] Expose deviceScaleFactor to WebKit API
fsamuel@chromium.org [Fri, 4 Nov 2011 17:10:03 +0000 (17:10 +0000)]
[Chromium] Expose deviceScaleFactor to WebKit API
https://bugs.webkit.org/show_bug.cgi?id=70614

Reviewed by Darin Fisher.

This exposes the device scale factor to the Chromium-WebKit API.
This scale factor is the ratio between the current device's DPI
and the target device's DPI.

For details on how this can be accessed from CSS and javascript, please
see here:

http://developer.android.com/guide/webapps/targeting.html#DensityCSS

* public/WebView.h:
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::deviceScaleFactor):
(WebKit::WebViewImpl::setDeviceScaleFactor):
* src/WebViewImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Don't warn about disabling WebKit2 when qmake does recursive includes
vestbo@webkit.org [Fri, 4 Nov 2011 17:06:06 +0000 (17:06 +0000)]
[Qt] Don't warn about disabling WebKit2 when qmake does recursive includes

Reviewed by Simon Hausmann.

* qmake/mkspecs/features/default_pre.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd NetscapePlugin::convertFromRootView
andersca@apple.com [Fri, 4 Nov 2011 17:04:15 +0000 (17:04 +0000)]
Add NetscapePlugin::convertFromRootView
https://bugs.webkit.org/show_bug.cgi?id=71526

Reviewed by Sam Weinig.

Source/WebCore:

Export some symbols that WebKit2 needs.

* WebCore.exp.in:

Source/WebKit2:

* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::convertFromRootView):
New function that converts a point from root view coordinates to plug-in coordinates.
Returns false if the conversion can't be done.

* WebProcess/Plugins/Netscape/NetscapePlugin.h:
* WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::fillInCocoaEventFromMouseEvent):
(WebKit::initializeMouseEvent):
(WebKit::NetscapePlugin::platformHandleMouseEvent):
(WebKit::NetscapePlugin::platformHandleWheelEvent):
(WebKit::NetscapePlugin::platformHandleMouseEnterEvent):
(WebKit::NetscapePlugin::platformHandleMouseLeaveEvent):
Use convertFromRootView instead of subtracting m_frameRectInWindowCoordinates.location() from the
event position (which is in root view coordinates).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix svn properties on layout test result files I checked in.
tony@chromium.org [Fri, 4 Nov 2011 17:00:15 +0000 (17:00 +0000)]
Fix svn properties on layout test result files I checked in.

* platform/chromium-linux/printing/single-line-must-not-be-split-into-two-pages-expected.png: Added property svn:mime-type.
* platform/chromium-win/printing/setPrinting-expected.txt: Added property svn:eol-style.
* platform/chromium-win/printing/single-line-must-not-be-split-into-two-pages-expected.png: Added property svn:mime-type.
* platform/chromium-win/printing/single-line-must-not-be-split-into-two-pages-expected.txt: Added property svn:eol-style.
* platform/mac/printing/setPrinting-expected.txt: Added property svn:eol-style.
* platform/mac/printing/single-line-must-not-be-split-into-two-pages-expected.txt: Added property svn:eol-style.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Don't error out on wrong Qt version when qmake does recursive includes
vestbo@webkit.org [Fri, 4 Nov 2011 16:55:42 +0000 (16:55 +0000)]
[Qt] Don't error out on wrong Qt version when qmake does recursive includes

Reviewed by Simmon Hausmann.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Fix incorrect visibility/scissor rect for threaded compositing
enne@google.com [Fri, 4 Nov 2011 16:41:19 +0000 (16:41 +0000)]
[chromium] Fix incorrect visibility/scissor rect for threaded compositing
https://bugs.webkit.org/show_bug.cgi?id=70962

Reviewed by James Robinson.

Source/WebCore:

In order to properly scroll independent of layout on the compositor
thread, we have to apply the scroll to the right layer. Previously,
the NonCompositedContentHost was the root of the graphics layer tree
with all other layers underneath it. However, applying a scroll to
that layer would also scroll the clip layer for the main frame
underneath it, causing visibility issues.

This patch moves the NonCompositedHost to be a child of the
RenderLayerCompositor's scroll layer. This was exposed on
RenderLayerCompositor, because there's no other way to get to this
layer in a way that doesn't make assumptions about the structure of
the layers on a frame.

This also removes the hacks in calculateVisibleLayerRect and
tilingTransform for scroll position.

Partially tested by existing compositor tests. Manually tested
threaded compositing scrolling.

* platform/graphics/chromium/NonCompositedContentHost.cpp:
(WebCore::NonCompositedContentHost::setScrollLayer):
(WebCore::NonCompositedContentHost::setViewport):
(WebCore::NonCompositedContentHost::scrollLayer):
* platform/graphics/chromium/NonCompositedContentHost.h:
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::create):
(WebCore::CCLayerTreeHost::CCLayerTreeHost):
(WebCore::CCLayerTreeHost::applyScrollDeltas):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCLayerTreeHost::setRootLayer):
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.h:
(WebCore::CCLayerTreeHostCommon::calculateVisibleLayerRect):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::findScrollLayer):
(WebCore::CCLayerTreeHostImpl::setRootLayer):
(WebCore::CCLayerTreeHostImpl::scrollRootLayer):
(WebCore::CCLayerTreeHostImpl::processScrollDeltas):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
* platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::CCTiledLayerImpl::tilingTransform):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::scrollLayer):
* rendering/RenderLayerCompositor.h:

Source/WebKit/chromium:

* src/WebLayerTreeViewImpl.cpp:
(WebKit::WebLayerTreeViewImpl::WebLayerTreeViewImpl):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setRootGraphicsLayer):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
* tests/CCLayerTreeHostTest.cpp:
(WTF::MockLayerTreeHost::MockLayerTreeHost):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Disable VIDEO_TRACK for now
philn@webkit.org [Fri, 4 Nov 2011 16:09:24 +0000 (16:09 +0000)]
[GTK] Disable VIDEO_TRACK for now
https://bugs.webkit.org/show_bug.cgi?id=71547

Reviewed by Gustavo Noronha Silva.

.:

* configure.ac: VIDEO_TRACK is still a moving target, it's best to
disable it for now.

LayoutTests:

Skip media/track tests and rebaseline involved fast/dom test results.

* platform/gtk/Skipped:
* platform/gtk/fast/dom/Window/window-properties-expected.txt:
* platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed gardening.
ossy@webkit.org [Fri, 4 Nov 2011 15:48:51 +0000 (15:48 +0000)]
[Qt] Unreviewed gardening.

* platform/qt/Skipped: Disable inspector tests temporarily because of a bug near build system refactoring.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed gardening: 8th chunk of baselines for Chromium-Skia
caryclark@google.com [Fri, 4 Nov 2011 15:31:12 +0000 (15:31 +0000)]
Unreviewed gardening: 8th chunk of baselines for Chromium-Skia
on Leopard.

[Omitting 602 of 608 files for brevity.]

* platform/chromium-mac-leopard/css3/bdi-element-expected.png: Added.
* platform/chromium-mac-leopard/css3/bdi-element-expected.txt: Added.
* platform/chromium-mac-leopard/fast/text/international/bidi-mirror-he-ar-expected.png: Added.
...
* platform/chromium-mac-leopard/transforms/no_transform_hit_testing-expected.png: Added.
* platform/chromium-mac-leopard/transforms/svg-vs-css-expected.png: Added.
* platform/chromium-mac-leopard/transitions/move-after-transition-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Disable STDIN check before cleaning build dir
vestbo@webkit.org [Fri, 4 Nov 2011 15:29:40 +0000 (15:29 +0000)]
[Qt] Disable STDIN check before cleaning build dir

It didn't work on the bots.

Reviewed by Ossy.

* Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Don't build all of webkit when running build-jsc
vestbo@webkit.org [Fri, 4 Nov 2011 15:20:50 +0000 (15:20 +0000)]
[Qt] Don't build all of webkit when running build-jsc

In case the whole webkit project was built, but we then subsequently
want to build only JSC, we need to run make in the proper subdirectory.

This also means the incremental target needs to be added to all
makefiles.

Reviewed by Simon Hausmann.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Look for STDIN instead of STDOUT when asking to clean the build dir
vestbo@webkit.org [Fri, 4 Nov 2011 15:20:32 +0000 (15:20 +0000)]
[Qt] Look for STDIN instead of STDOUT when asking to clean the build dir

Reviewed by Ossy.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix run-javascriptcore-tests for Qt when it's executed by the bot.
hausmann@webkit.org [Fri, 4 Nov 2011 14:54:05 +0000 (14:54 +0000)]
Fix run-javascriptcore-tests for Qt when it's executed by the bot.

Reviewed by Tor Arne Vestbø.

* Scripts/webkitdirs.pm:
(jscProductDir): jsc path changed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Error out early if trying to build against Qt < 4.8
vestbo@webkit.org [Fri, 4 Nov 2011 14:03:20 +0000 (14:03 +0000)]
[Qt] Error out early if trying to build against Qt < 4.8

Reviewed by Simon Hausmann.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix run-launcher for Qt and Gtk.
hausmann@webkit.org [Fri, 4 Nov 2011 13:47:23 +0000 (13:47 +0000)]
Fix run-launcher for Qt and Gtk.

Rubber-stamped by Tor Arne Vestbø.

* Scripts/webkitdirs.pm:
(isWK2): Re-add isWK2(), as it's used in run-launcher.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Ignore '-2' if passed to build-webkit. WebKit2 is now built by default.
vestbo@webkit.org [Fri, 4 Nov 2011 13:39:40 +0000 (13:39 +0000)]
[Qt] Ignore '-2' if passed to build-webkit. WebKit2 is now built by default.

Reviewed by Simon Hausmann.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Use web view title as window title in MiniBrowser
carlosgc@webkit.org [Fri, 4 Nov 2011 13:37:12 +0000 (13:37 +0000)]
[GTK] Use web view title as window title in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=71544

Reviewed by Philippe Normand.

* MiniBrowser/gtk/BrowserWindow.c:
(webViewURIChanged): Removed extra space.
(webViewTitleChanged): Set window title using
webkit_web_view_get_title().
(browser_window_init): Set initial default window title.
(browserWindowConstructed): Connect to WebView notify::title
signal.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Refactor and clean up the qmake build system
vestbo@webkit.org [Fri, 4 Nov 2011 13:19:58 +0000 (13:19 +0000)]
[Qt] Refactor and clean up the qmake build system

The qmake build system has accumulated a bit of cruft and redundancy
over time. There's also a fairly tight coupling between how to build
the various targets, and _what_ to build, making it harder to add new
rules or sources. This patch aims to elevate these issues somewhat.

This is a short-list of the changes:

  * The rules for how to build targets are now mostly contained as
    prf-files in Tools/qmake/mkspecs/features. Using mkspecs also
    allows us to do pre- and post-processing of each project file,
    which helps to clean up the actual project files.

  * Derived sources are no longer generated as a separate make-step
    but is part of each target's project file as a subdir. Makefile
    rules are used to ensure that we run make on the derived sources
    before running qmake on the actual target makefile. This makes
    it easier to keep a proper dependency between derived sources
    and the target.

  * We use GNU make and the compiler to generate dependencies on
    UNIX-based systems running Qt 5. This allows us to lessen the
    need to run qmake, which should reduce compile time.

  * WebKit2 is now build by default if building with Qt 5. It can
    be disabled by passing --no-webkit2 to build-webkit.

The result of these changes are hopefully a cleaner and easier
build system to modify, and faster build times due to no longer
running qmake on every single build. It's also a first step
towards possibly generating the list of sources using another
build system.

https://bugs.webkit.org/show_bug.cgi?id=71222

Reviewed by Simon Hausmann.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Support programmatic scrolling with the QTouchWebView
kenneth@webkit.org [Fri, 4 Nov 2011 12:28:18 +0000 (12:28 +0000)]
[Qt] Support programmatic scrolling with the QTouchWebView

Reviewed by Simon Hausmann.

As more code can be shared between the programmatic scrolling and the
method for ensuring that the contents are within valid bounds, this
patch includes a bit of refactoring as well.

* UIProcess/API/qt/qdesktopwebview_p.h:
(QDesktopWebViewPrivate::scrollPositionRequested):
* UIProcess/API/qt/qtouchwebview.cpp:
(QTouchWebViewPrivate::scrollPositionRequested):
* UIProcess/API/qt/qtouchwebview_p.h:
* UIProcess/qt/QtTouchViewInterface.cpp:
(WebKit::QtTouchViewInterface::scrollPositionRequested):
* UIProcess/qt/QtTouchViewInterface.h:
* UIProcess/qt/QtViewInterface.h:
* UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::event):
(WebKit::boundPosition):
(WebKit::QtViewportInteractionEngine::pagePositionRequest):
(WebKit::QtViewportInteractionEngine::computePosRangeForItemAtScale):
(WebKit::QtViewportInteractionEngine::ensureContentWithinViewportBoundary):
(WebKit::QtViewportInteractionEngine::setConstraints):
(WebKit::QtViewportInteractionEngine::pinchGestureEnded):
(WebKit::QtViewportInteractionEngine::contentViewportChanged):
* UIProcess/qt/QtViewportInteractionEngine.h:
* UIProcess/qt/QtWebPageProxy.cpp:
(QtWebPageProxy::pageDidRequestScroll):
* UIProcess/qt/QtWebPageProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] MediaStream API: Fixing wrong path for PeerConnectionHandler.h in WebCore.gyp
commit-queue@webkit.org [Fri, 4 Nov 2011 11:23:18 +0000 (11:23 +0000)]
[chromium] MediaStream API: Fixing wrong path for PeerConnectionHandler.h in WebCore.gyp
https://bugs.webkit.org/show_bug.cgi?id=71548

Patch by Tommy Widenflycht <tommyw@google.com> on 2011-11-04
Reviewed by Tony Gentilcore.

* WebCore.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove deprecated free functions in port.factory
eric@webkit.org [Fri, 4 Nov 2011 09:20:06 +0000 (09:20 +0000)]
Remove deprecated free functions in port.factory
https://bugs.webkit.org/show_bug.cgi?id=71494

Unreviewed.  Fixing exception seen when running test-webkitpy.

Sorry, I previously had deleted the relevant rebaseline-chromium-webkit-tests
unittest, since that script is nearly ready to be deleted.  But I added
it back at the last second and failed to run the tests. :(
This fixes the exception the bots were seeing.

* Scripts/webkitpy/style/checkers/test_expectations.py:
* Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
* Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[WINCE] Use default LocalizationStrategy
paroga@webkit.org [Fri, 4 Nov 2011 09:13:14 +0000 (09:13 +0000)]
[WINCE] Use default LocalizationStrategy
https://bugs.webkit.org/show_bug.cgi?id=71495

Reviewed by Adam Roben.

Use LocalizationStrategy from WebCore instead of using a copy of the strings in WebKit.

* WebCoreSupport/PlatformStrategiesWinCE.cpp:
* WebCoreSupport/PlatformStrategiesWinCE.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, skip some fast/viewport failing tests on GTK after r99195.
philn@webkit.org [Fri, 4 Nov 2011 09:04:22 +0000 (09:04 +0000)]
Unreviewed, skip some fast/viewport failing tests on GTK after r99195.

* platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Use standard booleand data type.
gyuyoung.kim@samsung.com [Fri, 4 Nov 2011 08:53:20 +0000 (08:53 +0000)]
[EFL] Use standard booleand data type.
https://bugs.webkit.org/show_bug.cgi?id=71433

This is a fourth step in order to be more compliant with WebKit coding style.
Use standard boolean data type instead of efl boolean data type. It makes efl port
is more close to webkit coding style.

Reviewed by Zoltan Herczeg.

* WebCoreSupport/ChromeClientEfl.cpp:
* WebCoreSupport/FrameLoaderClientEfl.cpp:
* ewk/ewk_contextmenu.cpp:
* ewk/ewk_cookies.cpp:
* ewk/ewk_frame.cpp:
* ewk/ewk_history.cpp:
* ewk/ewk_js.cpp:
* ewk/ewk_main.cpp:
* ewk/ewk_network.cpp:
* ewk/ewk_private.h:
* ewk/ewk_protocol_handler.cpp:
* ewk/ewk_protocol_handler_soup.cpp:
* ewk/ewk_settings.cpp:
* ewk/ewk_tiled_backing_store.cpp:
* ewk/ewk_tiled_matrix.cpp:
* ewk/ewk_tiled_model.cpp:
* ewk/ewk_util.cpp:
* ewk/ewk_view.cpp:
* ewk/ewk_view_single.cpp:
* ewk/ewk_view_tiled.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed CMake build fix for !ENABLE(SQL_DATABASE).
paroga@webkit.org [Fri, 4 Nov 2011 08:20:50 +0000 (08:20 +0000)]
Unreviewed CMake build fix for !ENABLE(SQL_DATABASE).

* CMakeLists.txt: Always compile the SQLite source files, since they are required for build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Unreviewed gardening.
yutak@chromium.org [Fri, 4 Nov 2011 08:06:45 +0000 (08:06 +0000)]
[Chromium] Unreviewed gardening.

* platform/chromium/test_expectations.txt: Add more expectations for recent test flakinesses.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMore code clean-up in DFG 32_64
commit-queue@webkit.org [Fri, 4 Nov 2011 07:45:37 +0000 (07:45 +0000)]
More code clean-up in DFG 32_64
https://bugs.webkit.org/show_bug.cgi?id=71540

Remove unnecessary code duplications, and fix compilation warnings.

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-11-04
Reviewed by Gavin Barraclough.

* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::emitCount):
(JSC::DFG::JITCompiler::setSamplingFlag):
(JSC::DFG::JITCompiler::clearSamplingFlag):
(JSC::DFG::JITCompiler::jitAssertIsCell):
* dfg/DFGJITCompiler32_64.cpp:
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDe-virtualize JSObject::hasInstance
ossy@webkit.org [Fri, 4 Nov 2011 07:35:18 +0000 (07:35 +0000)]
De-virtualize JSObject::hasInstance
https://bugs.webkit.org/show_bug.cgi?id=71430

Unreviewed rolling out r99238, because it made a test crash on all platform.

* API/JSCallbackObject.h:
* API/JSCallbackObjectFunctions.h:
(JSC::::hasInstance):
* API/JSValueRef.cpp:
(JSValueIsInstanceOfConstructor):
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/ClassInfo.h:
* runtime/JSBoundFunction.cpp:
(JSC::JSBoundFunction::hasInstance):
* runtime/JSBoundFunction.h:
* runtime/JSCell.cpp:
* runtime/JSCell.h:
* runtime/JSObject.cpp:
(JSC::JSObject::hasInstance):
* runtime/JSObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, forgot to skip a new test in r99261.
eric.carlson@apple.com [Fri, 4 Nov 2011 04:53:36 +0000 (04:53 +0000)]
Unreviewed, forgot to skip a new test in r99261.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION (r99076): Pasting into password fields is broken
rniwa@webkit.org [Fri, 4 Nov 2011 04:52:03 +0000 (04:52 +0000)]
REGRESSION (r99076): Pasting into password fields is broken
https://bugs.webkit.org/show_bug.cgi?id=71483

Reviewed by Darin Adler.

The bug was caused by plainText serializing secured (instead of original) text.
Fixed the bug by adding new TextIterator behavior that serializes the original text
and using it in ReplacementFragment::ReplacementFragment.

* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplacementFragment::ReplacementFragment):
* editing/TextIterator.cpp:
(WebCore::TextIterator::TextIterator):
(WebCore::TextIterator::emitText):
* editing/TextIterator.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd TrackEvent
eric.carlson@apple.com [Fri, 4 Nov 2011 04:18:05 +0000 (04:18 +0000)]
Add TrackEvent
https://bugs.webkit.org/show_bug.cgi?id=71178

Reviewed by Sam Weinig.

Source/WebCore:

Test: fast/events/constructors/track-event-constructor.html

* CMakeLists.txt: Add new files for TrackEvent.
* CodeGenerators.pri: Ditto.
* DerivedSources.cpp: Ditto.
* DerivedSources.make: Ditto.
* GNUmakefile.am: Ditto.
* GNUmakefile.list.am: Ditto.
* WebCore.gypi: Ditto.
* WebCore.pro: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* bindings/generic/EventConstructors.h: Ditto.
* bindings/gobject/GNUmakefile.am: Ditto.
* bindings/gobject/WebKitHTMLElementWrapperFactory.cpp: Ditto.
* bindings/js/JSBindingsAllInOne.cpp: Ditto.

* bindings/js/JSDictionary.cpp:
(WebCore::JSDictionary::convertValue): Add method to convert to a Track.
* bindings/js/JSDictionary.h:

* bindings/js/JSEventConstructors.cpp:  Add new files for TrackEvent.

* bindings/js/JSTrackCustom.cpp: Added.
(WebCore::toTrack): New, convert from a JSValue to a Track.
(WebCore::toJS): New, return a JS wrapper for a Track.
* bindings/js/JSTrackCustom.h: Added.

* bindings/js/JSTrackEventCustom.cpp: Added.
(WebCore::JSTrackEvent::track): New, returns a TextEvent's 'track' attribute.

* bindings/v8/OptionsObject.cpp:
(WebCore::OptionsObject::get): Returns RefPtr<TrackBase>.

* bindings/v8/custom/V8EventConstructors.cpp: Add Track initializing constructor.

* bindings/v8/custom/V8TrackEventCustom.cpp: Added.
(WebCore::V8TrackEvent::trackAccessorGetter): New, returns a TextEvent's 'track' attribute.

* dom/EventFactory.in: Add TrackEvent.

* dom/EventNames.h: Add 'addtrack' event.

* html/TextTrack.cpp:
(WebCore::TextTrack::TextTrack): Call new base class constructor.
* html/TextTrack.h: Now derive from BaseTrack for the day we implement VideoTrack and AudioTrack.

* html/track/TrackBase.cpp: Added.
(WebCore::TrackBase::TrackBase):
(WebCore::TrackBase::~TrackBase):
* html/track/TrackBase.h: Added.
(WebCore::TrackBase::type): Return the track type.

* html/track/TrackEvent.cpp: Added.
(WebCore::TrackEventInit::TrackEventInit):
(WebCore::TrackEvent::TrackEvent):
(WebCore::TrackEvent::~TrackEvent):
(WebCore::TrackEvent::interfaceName):
* html/track/TrackEvent.h: Added.
(WebCore::TrackEvent::create):
(WebCore::TrackEvent::isTrackEvent):
(WebCore::TrackEvent::track):
* html/track/TrackEvent.idl: Added.

* page/DOMWindow.idl: Add TrackEvent.

LayoutTests:

* fast/events/constructors/track-event-constructor-expected.txt: Added.
* fast/events/constructors/track-event-constructor.html: Added.
* platform/chromium/test_expectations.txt:
* platform/gtk/fast/dom/Window/window-properties-expected.txt:
* platform/gtk/fast/js/global-constructors-expected.txt:
* platform/mac/Skipped:
* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Unreviewed gardening.
yutak@chromium.org [Fri, 4 Nov 2011 03:44:30 +0000 (03:44 +0000)]
[Chromium] Unreviewed gardening.

* platform/chromium/test_expectations.txt: Apply recent expectation changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoJS Test Harness: Remove successfullyParsed from more tests
arv@chromium.org [Fri, 4 Nov 2011 02:16:03 +0000 (02:16 +0000)]
JS Test Harness: Remove successfullyParsed from more tests
https://bugs.webkit.org/show_bug.cgi?id=71533

Reviewed by Ojan Vafai.

* LayoutTests/*: Remove successfullyParsed

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoOptimize canvas fills / drawImage when covering entire canvas
commit-queue@webkit.org [Fri, 4 Nov 2011 01:55:30 +0000 (01:55 +0000)]
Optimize canvas fills / drawImage when covering entire canvas
https://bugs.webkit.org/show_bug.cgi?id=70789

Patch by Ben Wells <benwells@chromium.org> on 2011-11-03
Reviewed by Stephen White.

If we're filling a rect or drawing an image, and it covers the entire canvas, we don't
need to worry about clearing outside the area updated by the operation if we're in
a composite mode that requires this (such as source-in, copy, etc.). In this case we
can take the simple path through the code and save a clear (for copy) or a temporary
image buffer (for the other modes).

No new tests - optimization, behaviour is unchanged and covered by existing tests.

* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::fillRect):
(WebCore::CanvasRenderingContext2D::drawImage):
(WebCore::CanvasRenderingContext2D::rectContainsCanvas):
* html/canvas/CanvasRenderingContext2D.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDe-virtualize JSObject::getPropertyNames
mhahnenberg@apple.com [Fri, 4 Nov 2011 01:32:18 +0000 (01:32 +0000)]
De-virtualize JSObject::getPropertyNames
https://bugs.webkit.org/show_bug.cgi?id=71306

Reviewed by Darin Adler.

Source/JavaScriptCore:

Added getPropertyNames to the MethodTable, changed all the virtual
implementations of getPropertyNames to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.

* API/JSObjectRef.cpp:
(JSObjectCopyPropertyNames):
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* debugger/DebuggerActivation.cpp:
(JSC::DebuggerActivation::getOwnPropertyNames):
* runtime/ClassInfo.h:
* runtime/JSCell.cpp:
(JSC::JSCell::getPropertyNames):
* runtime/JSCell.h:
* runtime/JSObject.cpp:
(JSC::JSObject::getPropertyNames):
(JSC::JSObject::getOwnPropertyNames):
* runtime/JSObject.h:
* runtime/JSPropertyNameIterator.cpp:
(JSC::JSPropertyNameIterator::create):
* runtime/ScopeChain.cpp:
(JSC::ScopeChainNode::print):
* runtime/Structure.cpp:
(JSC::Structure::getPropertyNamesFromStructure):
* runtime/Structure.h:

Source/JavaScriptGlue:

Added getPropertyNames to the MethodTable, changed all the virtual
implementations of getPropertyNames to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.

* JSUtils.cpp:
(KJSValueToCFTypeInternal):
* JSValueWrapper.cpp:
(JSValueWrapper::JSObjectCopyPropertyNames):

Source/WebCore:

No new tests.

Added getPropertyNames to the MethodTable, changed all the virtual
implementations of getPropertyNames to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.

* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::JSDOMWindow::getPropertyNames):
* bindings/js/JSDOMWindowShell.cpp:
(WebCore::JSDOMWindowShell::getPropertyNames):
* bindings/js/JSDOMWindowShell.h:
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
* bridge/NP_jsobject.cpp:
(_NPN_Enumerate):
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::convertValueToQVariantMap):

Source/WebKit/mac:

Added getPropertyNames to the MethodTable, changed all the virtual
implementations of getPropertyNames to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.

* Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::enumerate):

Source/WebKit2:

Added getPropertyNames to the MethodTable, changed all the virtual
implementations of getPropertyNames to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.

* WebProcess/Plugins/Netscape/NPJSObject.cpp:
(WebKit::NPJSObject::enumerate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoEnable ctrl-arrow move cursor by word in visual order in cr-win by command line flag.
xji@chromium.org [Fri, 4 Nov 2011 01:18:16 +0000 (01:18 +0000)]
Enable ctrl-arrow move cursor by word in visual order in cr-win by command line flag.
https://bugs.webkit.org/show_bug.cgi?id=71163

Reviewed by Ryosuke Niwa.

Source/WebCore:

Add m_visualWordMovementEnabled page setting, trigger visual word movement
function (instead of logical one) when it is set as true.

right|leftWordPosition() are tested in editing/selection/move-by-word-visually*
by using --webkit-visual-word flag.

* editing/FrameSelection.cpp:
(WebCore::FrameSelection::modifyMovingRight):
(WebCore::FrameSelection::modifyMovingLeft):
(WebCore::FrameSelection::visualWordMovementEnabled):
* editing/FrameSelection.h:
* page/Settings.cpp:
(WebCore::Settings::Settings):
* page/Settings.h:
(WebCore::Settings::setVisualWordMovementEnabled):
(WebCore::Settings::visualWordMovementEnabled):

Source/WebKit/chromium:

To minimize the risk to LTR users, we enable this feature first to chromium win
by command line flag. This and corresponding changset in chromium
(http://codereview.chromium.org/8400078/)
should be removed after this feature is enabled without command line flag.

The work flow is:
1. (chromium) adds command line flag --enable-visual-word-movement,
   pass it to WebCore::Settings through WebPreferences.
2. in FrameSelection::modifyMovingLeft|Right, when 'visualWordMovementEnabled' is true in page's Settings,
   trigger visual word movement instead of logical one.

* public/WebSettings.h:
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setVisualWordMovementEnabled):
* src/WebSettingsImpl.h:

Tools:

* DumpRenderTree/chromium/WebPreferences.cpp: Set visualWordMovementEabled to false in DRT.
(WebPreferences::applyTo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCorrect usage of LayoutUnits and integers in Table rendering classes
leviw@chromium.org [Fri, 4 Nov 2011 00:56:59 +0000 (00:56 +0000)]
Correct usage of LayoutUnits and integers in Table rendering classes
https://bugs.webkit.org/show_bug.cgi?id=71500

Reviewed by Darin Adler.

Fixing the Table layout classes to operate on integers -- sub-pixel table layout breaks
the spec. Meanwhile correcting the Table rendering classes themselves to still use
LayoutUnits.

No new tests -- no change in behavior.

* rendering/AutoTableLayout.cpp: Reverting to operating on integers.
(WebCore::AutoTableLayout::recalcColumn):
(WebCore::AutoTableLayout::computePreferredLogicalWidths):
(WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
(WebCore::AutoTableLayout::layout):
* rendering/AutoTableLayout.h: Reverting to operating on integers.
* rendering/FixedTableLayout.cpp: Ditto.
(WebCore::FixedTableLayout::computePreferredLogicalWidths):
(WebCore::FixedTableLayout::layout):
* rendering/RenderTable.h: Switching to LayoutUnits.
(WebCore::RenderTable::getColumnPos):
(WebCore::RenderTable::bordersPaddingAndSpacingInRowDirection):
* rendering/RenderTableCell.cpp: Switching to LayoutUnits.
(WebCore::RenderTableCell::updateLogicalWidth):
(WebCore::RenderTableCell::setOverrideHeightFromRowHeight):
(WebCore::RenderTableCell::computeRectForRepaint):
(WebCore::RenderTableCell::cellBaselinePosition):
(WebCore::RenderTableCell::scrollbarsChanged):
* rendering/RenderTableCell.h: Switching to LayoutUnits
* rendering/RenderTableSection.cpp: Ditto.
(WebCore::RenderTableSection::setCellLogicalWidths):
(WebCore::RenderTableSection::layoutRows):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Notify scheduler on SwapBuffers in threaded compositor mode
jamesr@google.com [Fri, 4 Nov 2011 00:31:27 +0000 (00:31 +0000)]
[chromium] Notify scheduler on SwapBuffers in threaded compositor mode
https://bugs.webkit.org/show_bug.cgi?id=71381

Reviewed by Kenneth Russell.

* platform/graphics/chromium/cc/CCScheduler.cpp:
(WebCore::CCScheduler::didSwapBuffers):
* platform/graphics/chromium/cc/CCScheduler.h:
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::drawLayersAndSwapOnImplThread):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Added ewk_tile_memory_size_get function
commit-queue@webkit.org [Fri, 4 Nov 2011 00:27:07 +0000 (00:27 +0000)]
[EFL] Added ewk_tile_memory_size_get function
https://bugs.webkit.org/show_bug.cgi?id=71213

Patch by Tomasz Morawski <t.morawski@samsung.com> on 2011-11-03
Reviewed by Anders Carlsson.

Added the ewk_tile_memory_size_get function returns size of used memory by given tile. Simplify and cleanup
the code.

* ewk/ewk_tiled_model.cpp:
(ewk_tile_memory_size_get):
(ewk_tile_unused_cache_flush):
(ewk_tile_unused_cache_tile_get):
(ewk_tile_unused_cache_tile_put):
* ewk/ewk_tiled_model.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd Stub.h and Stub.cpp to Source-level WTF project
abarth@webkit.org [Fri, 4 Nov 2011 00:17:48 +0000 (00:17 +0000)]
Add Stub.h and Stub.cpp to Source-level WTF project
https://bugs.webkit.org/show_bug.cgi?id=71497

Reviewed by Eric Seidel.

This patch adds some stub files and a skelton GYP build file as a
starting point for the new Source-level WTF project.  Other build
systems and actual code will arrive in future patches.

* Stub.cpp: Added.
* Stub.h: Added.
* WTF.gyp/WTF.gyp: Added.
* WTF.gypi: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoGet rid of NetscapePlugin::m_clipRectInWindowCoordinates
andersca@apple.com [Fri, 4 Nov 2011 00:13:45 +0000 (00:13 +0000)]
Get rid of NetscapePlugin::m_clipRectInWindowCoordinates
https://bugs.webkit.org/show_bug.cgi?id=71521

Reviewed by Dan Bernstein.

* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::geometryDidChange):
* WebProcess/Plugins/Netscape/NetscapePlugin.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUse convertToRootView(IntPoint()) instead of m_frameRectInWindowCoordinates.location...
andersca@apple.com [Fri, 4 Nov 2011 00:13:39 +0000 (00:13 +0000)]
Use convertToRootView(IntPoint()) instead of m_frameRectInWindowCoordinates.location() where possible
https://bugs.webkit.org/show_bug.cgi?id=71520

Reviewed by Dan Bernstein.

* WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
(WebKit::NetscapePlugin::scheduleWindowedGeometryUpdate):
(WebKit::NetscapePlugin::platformPaint):
* WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
(WebKit::NetscapePlugin::platformHandleMouseEvent):
(WebKit::NetscapePlugin::platformHandleWheelEvent):
(WebKit::NetscapePlugin::platformHandleMouseEnterEvent):
(WebKit::NetscapePlugin::platformHandleMouseLeaveEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove an obsolete comment.
tony@chromium.org [Fri, 4 Nov 2011 00:10:18 +0000 (00:10 +0000)]
Remove an obsolete comment.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd NetscapePlugin::convertToRootView
andersca@apple.com [Thu, 3 Nov 2011 23:55:21 +0000 (23:55 +0000)]
Add NetscapePlugin::convertToRootView
https://bugs.webkit.org/show_bug.cgi?id=71519

Reviewed by Darin Adler.

Yet another step towards eliminating uses of m_frameRectInWindowCoordinates.

Also, use the "root view" terminology, since that's really what we mean here.

* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::callSetWindow):
Use convertToRootView to get the plug-in location and clip rect in root view coordinates.

(WebKit::NetscapePlugin::convertToRootView):
Apply the m_pluginToRootViewTransform.mapPoint transform.

* WebProcess/Plugins/Netscape/NetscapePlugin.h:
Add convertToRootView.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCMake: Add missing WebGL IDL file html/canvas/WebGLContextEvent.idl
dbates@webkit.org [Thu, 3 Nov 2011 23:42:29 +0000 (23:42 +0000)]
CMake: Add missing WebGL IDL file html/canvas/WebGLContextEvent.idl

Rubber-stamped by Martin Robinson

* CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCMake: Only generate from WebGL IDLs when building with WebGL
dbates@webkit.org [Thu, 3 Nov 2011 23:35:04 +0000 (23:35 +0000)]
CMake: Only generate from WebGL IDLs when building with WebGL
https://bugs.webkit.org/show_bug.cgi?id=71516

Reviewed by Martin Robinson.

* CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove support for LegacyDefaultOptionalArguments
arv@chromium.org [Thu, 3 Nov 2011 23:26:47 +0000 (23:26 +0000)]
Remove support for LegacyDefaultOptionalArguments
https://bugs.webkit.org/show_bug.cgi?id=71489

Reviewed by Darin Adler.

This removes support for LegacyDefaultOptionalArguments and [RequiresAllArguments=Raise].
[RequiresAllArguments=Raise] is now the standard behavior so it would be a no op.

No new tests. Covered by existing tests.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateArgumentsCountCheck): Check the "RequiresAllArguments" extended attribute and generate code
                               that returns undefined if there are missing arguments.
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateArgumentsCountCheck): Ditto.
* bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
(WebCore::jsTestMediaQueryListListenerPrototypeFunctionMethod): Add generated argument count checks.
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjPrototypeFunctionVoidMethodWithArgs): Ditto.
(WebCore::jsTestObjPrototypeFunctionIntMethodWithArgs): Ditto.
(WebCore::jsTestObjPrototypeFunctionObjMethodWithArgs): Ditto.
(WebCore::jsTestObjPrototypeFunctionSerializedValue): Ditto.
(WebCore::jsTestObjPrototypeFunctionIdbKey): Ditto.
(WebCore::jsTestObjPrototypeFunctionOptionsObject): Ditto.
(WebCore::jsTestObjPrototypeFunctionCustomArgsAndException): Ditto.
(WebCore::jsTestObjPrototypeFunctionAddEventListener): Ditto.
(WebCore::jsTestObjPrototypeFunctionRemoveEventListener): Ditto.
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndArg): Ditto.
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndOptionalArg): Ditto.
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGesture): Ditto.
(WebCore::jsTestObjPrototypeFunctionWithDynamicFrameAndUserGestureASAD): Ditto.
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndOptionalArg): Ditto.
(WebCore::jsTestObjPrototypeFunctionMethodWithNonOptionalArgAndTwoOptionalArgs): Ditto.
(WebCore::jsTestObjPrototypeFunctionMethodWithCallbackArg): Ditto.
(WebCore::jsTestObjPrototypeFunctionMethodWithNonCallbackArgAndCallbackArg): Ditto.
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod1): Ditto.
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod2): Ditto.
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod3): Ditto.
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod4): Ditto.
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod5): Ditto.
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod6): Ditto.
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod7): Ditto.
* bindings/scripts/test/TestCallback.idl: Remove LegacyDefaultOptionalArguments.
* bindings/scripts/test/TestMediaQueryListListener.idl: Ditto.
* bindings/scripts/test/TestObj.idl: Remove LegacyDefaultOptionalArguments and [RequiresAllArguments=Raise]
* bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp: Remove LegacyDefaultOptionalArguments.
(WebCore::TestMediaQueryListListenerInternal::methodCallback): Add generated argument count checks.
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjInternal::voidMethodWithArgsCallback): Ditto.
(WebCore::TestObjInternal::intMethodWithArgsCallback): Ditto.
(WebCore::TestObjInternal::objMethodWithArgsCallback): Ditto.
(WebCore::TestObjInternal::serializedValueCallback): Ditto.
(WebCore::TestObjInternal::idbKeyCallback): Ditto.
(WebCore::TestObjInternal::optionsObjectCallback): Ditto.
(WebCore::TestObjInternal::customArgsAndExceptionCallback): Ditto.
(WebCore::TestObjInternal::withDynamicFrameAndArgCallback): Ditto.
(WebCore::TestObjInternal::withDynamicFrameAndOptionalArgCallback): Ditto.
(WebCore::TestObjInternal::withDynamicFrameAndUserGestureCallback): Ditto.
(WebCore::TestObjInternal::withDynamicFrameAndUserGestureASADCallback): Ditto.
(WebCore::TestObjInternal::methodWithNonOptionalArgAndOptionalArgCallback): Ditto.
(WebCore::TestObjInternal::methodWithNonOptionalArgAndTwoOptionalArgsCallback): Ditto.
(WebCore::TestObjInternal::methodWithCallbackArgCallback): Ditto.
(WebCore::TestObjInternal::methodWithNonCallbackArgAndCallbackArgCallback): Ditto.
(WebCore::TestObjInternal::overloadedMethod1Callback): Ditto.
(WebCore::TestObjInternal::overloadedMethod2Callback): Ditto.
(WebCore::TestObjInternal::overloadedMethod3Callback): Ditto.
(WebCore::TestObjInternal::overloadedMethod4Callback): Ditto.
(WebCore::TestObjInternal::overloadedMethod5Callback): Ditto.
(WebCore::TestObjInternal::overloadedMethod6Callback): Ditto.
(WebCore::TestObjInternal::overloadedMethod7Callback): Ditto.
(WebCore::TestObjInternal::enabledAtRuntimeMethod1Callback): Ditto.
(WebCore::TestObjInternal::enabledAtRuntimeMethod2Callback): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMove plug-in size and backing store checks to PluginProxy::updateBackingStore
andersca@apple.com [Thu, 3 Nov 2011 23:17:44 +0000 (23:17 +0000)]
Move plug-in size and backing store checks to PluginProxy::updateBackingStore
https://bugs.webkit.org/show_bug.cgi?id=71508

Reviewed by Darin Adler.

* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::geometryDidChange):
Remove code to send back an empty backing store if the plug-in size is empty
or doesn't need a backing store. This check is now done...

(WebKit::PluginProxy::updateBackingStore):
...here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoGet rid of PluginControllerProxy::m_frameRectInWindowCoordinates
andersca@apple.com [Thu, 3 Nov 2011 23:17:39 +0000 (23:17 +0000)]
Get rid of PluginControllerProxy::m_frameRectInWindowCoordinates
https://bugs.webkit.org/show_bug.cgi?id=71506

Reviewed by Darin Adler.

* PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::geometryDidChange):
This no longer needs to take the frame rect in window coordinates.

* PluginProcess/PluginControllerProxy.h:
* PluginProcess/PluginControllerProxy.messages.in:
Remove frameRectInWindowCoordinates from the GeometryDidChange message.

* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::geometryDidChange):
Don't pass frameRectInWindowCoordinates when sending GeometryDidChange.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99242 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoGet rid of Plugin::wantsWindowRelativeCoordinates()
andersca@apple.com [Thu, 3 Nov 2011 23:17:34 +0000 (23:17 +0000)]
Get rid of Plugin::wantsWindowRelativeCoordinates()
https://bugs.webkit.org/show_bug.cgi?id=71504

Reviewed by Darin Adler.

Since all Plugin subclasses now return false for wantsWindowRelativeCoordinates,
we can go ahead and remove it.

* PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::paint):
* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::snapshot):
* WebProcess/Plugins/Netscape/NetscapePlugin.h:
* WebProcess/Plugins/PDF/BuiltInPDFView.cpp:
* WebProcess/Plugins/PDF/BuiltInPDFView.h:
* WebProcess/Plugins/Plugin.h:
* WebProcess/Plugins/PluginProxy.cpp:
* WebProcess/Plugins/PluginProxy.h:
* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNetscapePlugin::wantsWindowRelativeCoordinates should return false for all ports
andersca@apple.com [Thu, 3 Nov 2011 23:17:27 +0000 (23:17 +0000)]
NetscapePlugin::wantsWindowRelativeCoordinates should return false for all ports
https://bugs.webkit.org/show_bug.cgi?id=71501

Reviewed by Darin Adler.

* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::wantsWindowRelativeCoordinates):
Return false.

* WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
(WebKit::NetscapePlugin::platformGeometryDidChange):
Use m_pluginSize instead of m_frameRectInWindowCoordinates.size().

(WebKit::NetscapePlugin::platformPaint):
No need to translate back and forth between window and plug-in relative coordinates anymore.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoChange remaining callers of releaseRef to call leakRef
darin@apple.com [Thu, 3 Nov 2011 23:04:46 +0000 (23:04 +0000)]
Change remaining callers of releaseRef to call leakRef
https://bugs.webkit.org/show_bug.cgi?id=71422

../JavaScriptCore:

* wtf/text/AtomicString.cpp:
(WTF::HashAndUTF8CharactersTranslator::translate): Use leakRef.

../WebCore:

Reviewed by Darin Fisher.

* bindings/objc/WebScriptObject.mm:
(-[WebScriptObject _setImp:originRootObject:rootObject:]):
(-[WebScriptObject _setOriginRootObject:andRootObject:]):
* bridge/NP_jsobject.cpp:
(_NPN_CreateScriptObject):
* dom/QualifiedName.cpp:
(WebCore::QNameComponentsTranslator::translate):
* history/PageCache.cpp:
(WebCore::PageCache::add):
* html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::additionalAttributeStyleDecls):
(WebCore::HTMLTableElement::addSharedCellBordersDecl):
(WebCore::HTMLTableElement::addSharedGroupDecls):
* platform/graphics/cg/ImageSourceCG.cpp:
(WebCore::ImageSource::createFrameAtIndex):
* platform/graphics/mac/FontCustomPlatformData.cpp:
(WebCore::createFontCustomPlatformData):
* platform/mac/ContextMenuMac.mm:
(WebCore::ContextMenu::releasePlatformDescription):
* platform/mac/SharedBufferMac.mm:
(WebCore::SharedBuffer::createCFData):
* rendering/RenderMediaControlsChromium.cpp:
(WebCore::platformResource):
Use leakRef.

../WebKit/chromium:

* public/WebPrivatePtr.h:
(WebKit::WebPrivatePtr::WebPrivatePtr):
(WebKit::WebPrivatePtr::operator=):
* src/WebDOMEvent.cpp:
(WebKit::WebDOMEvent::WebDOMEvent):
* src/WebData.cpp:
(WebKit::WebData::assign):
(WebKit::WebData::WebData):
(WebKit::WebData::operator=):
* src/WebDragData.cpp:
(WebKit::WebDragData::initialize):
(WebKit::WebDragData::WebDragData):
(WebKit::WebDragData::operator=):
* src/WebHTTPBody.cpp:
(WebKit::WebHTTPBody::initialize):
(WebKit::WebHTTPBody::WebHTTPBody):
(WebKit::WebHTTPBody::operator=):
(WebKit::WebHTTPBody::ensureMutable):
* src/WebNodeCollection.cpp:
(WebKit::WebNodeCollection::WebNodeCollection):
* src/WebNodeList.cpp:
(WebKit::WebNodeList::WebNodeList):
* src/WebNotification.cpp:
(WebKit::WebNotification::WebNotification):
(WebKit::WebNotification::operator=):
* src/WebRange.cpp:
(WebKit::WebRange::WebRange):
(WebKit::WebRange::operator=):
* src/WebSecurityOrigin.cpp:
(WebKit::WebSecurityOrigin::WebSecurityOrigin):
(WebKit::WebSecurityOrigin::operator=):
* src/WebThreadSafeData.cpp:
(WebKit::WebThreadSafeData::WebThreadSafeData):
Use leakRef.

../WebKit/efl:

Reviewed by Darin Fisher.

* ewk/ewk_history.cpp:
(ewk_history_item_new): Use leakRef.

../WebKit/gtk:

Reviewed by Darin Fisher.

* webkit/webkitwebdatasource.cpp:
(WebKit::kitNew):
* webkit/webkitwebhistoryitem.cpp:
(webkit_web_history_item_new):
(webkit_web_history_item_new_with_data):
(webkit_web_history_item_copy):
(WebKit::kit):
* webkit/webkitwebresource.cpp:
(webkit_web_resource_new_with_core_resource):
(webkit_web_resource_init_with_core_resource):
Use leakRef.

../WebKit/mac:

Reviewed by Darin Fisher.

* History/WebBackForwardList.mm:
(-[WebBackForwardList initWithBackForwardList:]):
* History/WebHistoryItem.mm:
(-[WebHistoryItem copyWithZone:]):
(-[WebHistoryItem initWithWebCoreHistoryItem:]):
* Plugins/Hosted/WebHostedNetscapePluginView.mm:
(-[WebHostedNetscapePluginView createPlugin]):
* Plugins/WebNetscapePluginView.mm:
(-[WebNetscapePluginView createPlugin]):
* WebCoreSupport/WebOpenPanelResultListener.mm:
* WebView/WebDataSource.mm:
(-[WebDataSource _initWithDocumentLoader:]):
* WebView/WebResource.mm:
(-[WebResourcePrivate initWithCoreResource:]):
Use leakRef.

../WebKit/win:

Reviewed by Darin Fisher.

* WebCache.cpp:
(WebCache::statistics):
* WebDatabaseManager.cpp:
(WebDatabaseManager::origins):
(WebDatabaseManager::databasesWithOrigin):
* WebHistoryItem.cpp:
(WebHistoryItem::redirectURLs):
* WebKitClassFactory.cpp:
(leakRefFromCreateInstance):
(WebKitClassFactory::CreateInstance):
* WebScriptWorld.cpp:
(WebScriptWorld::standardWorld):
Use leakRef.

../WebKit2:

Reviewed by Darin Fisher.

* Platform/mac/ModuleMac.mm:
(WebKit::Module::load):
* Shared/API/c/WKArray.cpp:
(WKArrayCreate):
* Shared/API/c/WKData.cpp:
(WKDataCreate):
* Shared/API/c/WKDictionary.cpp:
(WKDictionaryCopyKeys):
* Shared/API/c/WKGeometry.cpp:
(WKPointCreate):
(WKSizeCreate):
(WKRectCreate):
* Shared/API/c/WKMutableArray.cpp:
(WKMutableArrayCreate):
* Shared/API/c/WKMutableDictionary.cpp:
(WKMutableDictionaryCreate):
* Shared/API/c/WKNumber.cpp:
(WKBooleanCreate):
(WKDoubleCreate):
(WKUInt64Create):
* Shared/API/c/WKSharedAPICast.h:
(WebKit::toCopiedAPI):
(WebKit::toCopiedURLAPI):
* Shared/API/c/cf/WKErrorCF.cpp:
(WKErrorCreateWithCFError):
* Shared/API/c/cf/WKURLRequestCF.cpp:
(WKURLRequestCreateWithCFURLRequest):
* Shared/API/c/cf/WKURLResponseCF.cpp:
(WKURLResponseCreateWithCFURLResponse):
* Shared/API/c/mac/WKURLRequestNS.mm:
(WKURLRequestCreateWithNSURLRequest):
* Shared/API/c/mac/WKURLResponseNS.mm:
(WKURLResponseCreateWithNSURLResponse):
* Shared/cf/ArgumentCodersCF.cpp:
(CoreIPC::decode):
* UIProcess/API/C/WKBackForwardList.cpp:
(WKBackForwardListCopyBackListWithLimit):
(WKBackForwardListCopyForwardListWithLimit):
* UIProcess/API/C/WKContext.cpp:
(WKContextCreate):
(WKContextCreateWithInjectedBundlePath):
* UIProcess/API/C/WKCredential.cpp:
(WKCredentialCreate):
(WKCredentialCreateWithCertificateInfo):
* UIProcess/API/C/WKDatabaseManager.cpp:
(WKDatabaseManagerGetOriginKey):
(WKDatabaseManagerGetOriginQuotaKey):
(WKDatabaseManagerGetOriginUsageKey):
(WKDatabaseManagerGetDatabaseDetailsKey):
(WKDatabaseManagerGetDatabaseDetailsNameKey):
(WKDatabaseManagerGetDatabaseDetailsDisplayNameKey):
(WKDatabaseManagerGetDatabaseDetailsExpectedUsageKey):
(WKDatabaseManagerGetDatabaseDetailsCurrentUsageKey):
* UIProcess/API/C/WKFrame.cpp:
(WKFrameCopyChildFrames):
* UIProcess/API/C/WKGeolocationPosition.cpp:
(WKGeolocationPositionCreate):
* UIProcess/API/C/WKGrammarDetail.cpp:
(WKGrammarDetailCreate):
* UIProcess/API/C/WKPage.cpp:
(WKPageGetSessionHistoryURLValueType):
(WKPageCopySessionState):
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesCreateWithIdentifier):
* UIProcess/API/C/win/WKView.cpp:
(WKViewCreate):
* UIProcess/win/WebUndoClient.cpp:
(WebKit::WebUndoClient::registerEditCommand):
* WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
(WKBundleFrameCopyChildFrames):
* WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp:
(WKBundleNodeHandleCreate):
(WKBundleNodeHandleCopyDocument):
(WKBundleNodeHandleCopyHTMLTableCellElementCellAbove):
(WKBundleNodeHandleCopyDocumentFrame):
(WKBundleNodeHandleCopyHTMLFrameElementContentFrame):
(WKBundleNodeHandleCopyHTMLIFrameElementContentFrame):
* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageCopyTrackedRepaintRects):
* WebProcess/InjectedBundle/API/c/WKBundleScriptWorld.cpp:
(WKBundleScriptWorldCreateWorld):
Use leakRef.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDe-virtualize JSObject::hasInstance
mhahnenberg@apple.com [Thu, 3 Nov 2011 22:40:39 +0000 (22:40 +0000)]
De-virtualize JSObject::hasInstance
https://bugs.webkit.org/show_bug.cgi?id=71430

Reviewed by Darin Adler.

Added hasInstance to the MethodTable, changed all the virtual
implementations of hasInstance to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.

* API/JSCallbackObject.h:
* API/JSCallbackObjectFunctions.h:
(JSC::::hasInstance):
* API/JSValueRef.cpp:
(JSValueIsInstanceOfConstructor):
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/ClassInfo.h:
* runtime/JSBoundFunction.cpp:
(JSC::JSBoundFunction::hasInstance):
* runtime/JSBoundFunction.h:
* runtime/JSCell.cpp:
(JSC::JSCell::hasInstance):
* runtime/JSCell.h:
* runtime/JSObject.cpp:
(JSC::JSObject::hasInstance):
* runtime/JSObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Remove unused clipboard methods
dcheng@chromium.org [Thu, 3 Nov 2011 22:28:51 +0000 (22:28 +0000)]
[chromium] Remove unused clipboard methods
https://bugs.webkit.org/show_bug.cgi?id=71512

Reviewed by Tony Chang.

Source/WebCore:

* platform/chromium/PlatformSupport.h:

Source/WebKit/chromium:

* public/WebClipboard.h:
(WebKit::WebClipboard::getSequenceNumber):
(WebKit::WebClipboard::readAvailableTypes):
(WebKit::WebClipboard::writeImage):
* src/PlatformSupport.cpp:
(WebCore::PlatformSupport::clipboardGetSequenceNumber):
(WebCore::PlatformSupport::clipboardReadAvailableTypes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99237 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix tst_QDeclarativeWebView::basicProperties() and historyNav() autotests
commit-queue@webkit.org [Thu, 3 Nov 2011 20:37:20 +0000 (20:37 +0000)]
Fix tst_QDeclarativeWebView::basicProperties() and historyNav() autotests
https://bugs.webkit.org/show_bug.cgi?id=61042

Patch by Rafael Brandao <rafael.lobo@openbossa.org> on 2011-11-03
Reviewed by Simon Hausmann.

At some points we didn't have any guarantee that a favicon has been loaded, so now
it stops to wait for the IconChanged signal. It also had some file paths in wrong format,
making some files to not be resolved and comparing meaningless bitmaps.

* tests/qdeclarativewebview/tst_qdeclarativewebview.cpp:
(tst_QDeclarativeWebView::initTestCase):
(tst_QDeclarativeWebView::basicProperties):
(tst_QDeclarativeWebView::historyNav):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: Implement TextTrackCueList.
annacc@chromium.org [Thu, 3 Nov 2011 20:28:55 +0000 (20:28 +0000)]
Source/WebCore: Implement TextTrackCueList.
https://bugs.webkit.org/show_bug.cgi?id=70451

Reviewed by Eric Carlson.

Test: media/track/track-text-track-cue-list.html

* html/LoadableTextTrack.cpp:
(WebCore::LoadableTextTrack::newCuesAvailable):
    Update TextTrack's TextTrackCueList (m_cues) when new cues are discovered.
* html/TextTrack.cpp:
(WebCore::TextTrack::TextTrack):
    Create an empty TextTrackCueList upon TextTrack creation.
(WebCore::TextTrack::cues):
    Return this TextTrack's list of cues.

Implement TextTrackCueList functionality:
* html/TextTrackCueList.cpp:
(WebCore::TextTrackCueList::TextTrackCueList):
(WebCore::TextTrackCueList::length):
(WebCore::TextTrackCueList::item):
(WebCore::TextTrackCueList::getCueById):
(WebCore::TextTrackCueList::add):
(WebCore::TextTrackCueList::remove):
(WebCore::TextTrackCueList::contains):
* html/TextTrackCueList.h:
(WebCore::TextTrackCueList::~TextTrackCueList):

LayoutTests: Tests for TextTrackCueList implementation.
https://bugs.webkit.org/show_bug.cgi?id=70451

Reviewed by Eric Carlson.

* media/track/track-text-track-cue-list-expected.txt: Added.
* media/track/track-text-track-cue-list.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove deprecated free functions in port.factory
eric@webkit.org [Thu, 3 Nov 2011 20:24:16 +0000 (20:24 +0000)]
Remove deprecated free functions in port.factory
https://bugs.webkit.org/show_bug.cgi?id=71494

Reviewed by Adam Barth.

I removed port.factory.get, get_all, and all_port_names -- long-since deprecated
free functions in factory.py.  To remove these required fixing all callsites
to use MockHost, Host, or PortFactory where appropriate.  After this change
we're only left with a handfull of places where we inappropraitely use a
real Executive, FileSystem or User object during unittesting.

* Scripts/webkitpy/common/checkout/baselineoptimizer_unittest.py:
 - These PortFactory overrides were from an earlier edition of my previous patch
   in the end, I removed MockPortFactory so all tests ended up with this same
   real PortFactory() with a MockHost.  This was simply redundent code.
* Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
 - Use MockHost to get a mocked-out PortFactory.
* Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
 - This code has no access to a Host object, so we just use a default PortFactory
   for now.  This will still incorrectly create real Executive/FileSystem objects
   durring unittesting, which is wrong. :(
* Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
 - Use a MockHost to get a mocked PortFactory.
* Scripts/webkitpy/layout_tests/controllers/test_expectations_editor_unittest.py:
 - Use a MockHost to get a mocked PortFactory.
* Scripts/webkitpy/layout_tests/models/test_configuration_unittest.py:
 - ditto.
* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
 - ditto.
* Scripts/webkitpy/layout_tests/port/__init__.py:
 - factory.get no longer exists.  Yay!
* Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
 - Use a MockHost to get a mocked PortFactory.
   To do this efficiently, I created a helper function
   and combined all these (mostly redundant) tests into one test
   with several calls to the helper function.
* Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
 - Pass MockUser and MockExecutive in these port testing subclasses.
 - I also removed a bunch of unecessary uses of mocktool. namespacing.
* Scripts/webkitpy/layout_tests/port/chromium_win.py:
 - Awesome windows hacks should only happen on win32.  Once we started
   using MockExecutives these 'svn help' commands started printing in
   other tests, which is how I found this bug.
* Scripts/webkitpy/layout_tests/port/dryrun.py:
 - DryRunPort has no Host, so just use a PortFactory() directly.
   This will do the wrong thing if we're unittesting the DryRun port
   but it's no worse than the existing code.
* Scripts/webkitpy/layout_tests/port/factory.py:
 - Remove the free functions.
 - Fix argument overriding to be able to override None.
* Scripts/webkitpy/layout_tests/port/factory_unittest.py:
 - Use a mocked-out PortFactory during testing.
* Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
 - Pass MockExecutive and MockUser to these manual Port instantiations.
* Scripts/webkitpy/layout_tests/port/mock_drt.py:
 - No access to a Host object here, so just using PortFactory directly.
   This is wrong, but no more wrong than the existing code was.
* Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
 - Use a MockHost to get a mocked out PortFactory.
* Scripts/webkitpy/layout_tests/port/test.py:
 - Use our fancy _set_default_overriding_none system to clean this code up and pass a MockExecutive.
* Scripts/webkitpy/layout_tests/port/win.py:
 - Don't run cmd /c ver from WinPort.__init__ or it shows up in unittests which have logging MockExecutive
   now that we're actually passing MockExecutive to most Port instantiations during testing.
* Scripts/webkitpy/layout_tests/port/win_unittest.py:
 - Pass our new "unittesting" bool to _detect_version when actually unittesting.
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
 - Host is the future.
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
 - Use a MockHost to get a mocked out PortFactory.  Once we have a mocked PortFactory
   we don't need to pass MockUser explicitly, it does that automatically for us.
* Scripts/webkitpy/layout_tests/views/printing_unittest.py:
 - Use a MockHost to get a mocked out PortFactory.
* Scripts/webkitpy/style/checkers/test_expectations.py:
 - We don't have access to a Host object, so using PortFactory() directly.
* Scripts/webkitpy/style/checkers/test_expectations_unittest.py:
 - Remove unused variable.
* Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests.py:
 - Host isn't accessible here, so using PortFactory() directly, which
   although unfortunate is no worse than before.
* Scripts/webkitpy/to_be_moved/rebaseline_chromium_webkit_tests_unittest.py:
 - Testing is much easier when you don't need to hack global state...
* Scripts/webkitpy/tool/commands/expectations.py:
 - Use the port_factory on the tool.
* Scripts/webkitpy/tool/commands/rebaseline.py:
 - ditto.
* Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
 - This unittest was wrong.  It was trying to pass the tool object, but failing to pass
   the arguments in the right order.  Fixing that made it use a MockFileSystem
   (like it had been trying to), which then required us to actually populate
   that MockFileSystem with fake expectation files (instead of using the ones on the real disk).
* Scripts/webkitpy/tool/commands/rebaselineserver.py:
 - Get the port_factory from the tool.
* Scripts/webkitpy/tool/servers/gardeningserver.py:
 - Ditto.
* Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
 - Use a MockHost to get a mocked out Port object.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoJIT-specific code should be able to refer to register types even on JIT-disabled...
fpizlo@apple.com [Thu, 3 Nov 2011 20:21:45 +0000 (20:21 +0000)]
JIT-specific code should be able to refer to register types even on JIT-disabled builds
https://bugs.webkit.org/show_bug.cgi?id=71498

Reviewed by Gavin Barraclough.

* assembler/MacroAssembler.h:
(MacroAssembler::MacroAssembler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMark tests as slow in chromium.
tony@chromium.org [Thu, 3 Nov 2011 20:20:39 +0000 (20:20 +0000)]
Mark tests as slow in chromium.

fast/frames/lots-of-iframes.html and fast/frames/lots-of-objects.html
are already marked as timing out, but maybe they will pass in release
if we give them enough time.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNetscapePlugin should use plug-in relative coordinates on Mac
andersca@apple.com [Thu, 3 Nov 2011 20:19:11 +0000 (20:19 +0000)]
NetscapePlugin should use plug-in relative coordinates on Mac
https://bugs.webkit.org/show_bug.cgi?id=71486

Reviewed by Adam Roben.

* PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::paint):
Don't translate the graphics context when the plug-in doesn't want window relative coordinates.
This also fixed a bug I introduced in my previous commit where we'd always pass the dirty rect in
plug-in coordinates even if the plug-in wants window relative coordinates.

* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::snapshot):
Don't do the whole translate dance if the plug-in doesn't want window relative coordinates.

(WebKit::NetscapePlugin::wantsWindowRelativeCoordinates):
Return false for PLATFORM_ARCHITECTURE(MAC).

* WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::NetscapePlugin::platformPaint):
Simplify code now that we know that the we're always given plug-in relative coordinates.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoIndexedDB result of deleting a record should be true or false
commit-queue@webkit.org [Thu, 3 Nov 2011 19:41:31 +0000 (19:41 +0000)]
IndexedDB result of deleting a record should be true or false
https://bugs.webkit.org/show_bug.cgi?id=60197

Patch by Joshua Bell <jsbell@chromium.org> on 2011-11-03
Reviewed by David Levin.

Source/WebCore:

IDBObjectStore.delete() was incorrectly firing an error if there
was no record to remove. Match the spec, and return true/false
as success values instead. Bring JSC binding implementation of
SerializedScriptValue more in line with V8 version for methods
called from IDB code.

Test: storage/indexeddb/mozilla/delete-result.html

* bindings/js/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::createFromWire):
(WebCore::SerializedScriptValue::undefinedValue):
(WebCore::SerializedScriptValue::booleanValue):
* bindings/js/SerializedScriptValue.h:
* bindings/v8/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::nullValue):
(WebCore::SerializedScriptValue::undefinedValue):
(WebCore::SerializedScriptValue::booleanValue):
* bindings/v8/SerializedScriptValue.h:
* storage/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::deleteInternal):

LayoutTests:

Add tests for IDBObjectStore.delete() - should succeed if
record exists or not, and return true/false as success value.

* storage/indexeddb/mozilla/delete-result-expected.txt: Added.
* storage/indexeddb/mozilla/delete-result.html: Added.
* storage/indexeddb/objectstore-basics-expected.txt:
* storage/indexeddb/objectstore-basics.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImplement allow-popups for iframe@sandbox
abarth@webkit.org [Thu, 3 Nov 2011 19:29:20 +0000 (19:29 +0000)]
Implement allow-popups for iframe@sandbox
https://bugs.webkit.org/show_bug.cgi?id=66505

Reviewed by Eric Seidel.

Source/WebCore:

There's been some discussion in the HTML working group about adding an
allow-popups directive to the iframe sandbox.  Microsoft has added it
to IE10 platform preview and is fairly adamant about this feature
because it's needed by one or their products that's planning to use
iframe sandbox.  Hixie says he'll add it to the spec once we implement
it, so here's our implementation.  (See discussion in the W3C linked in
the bug for more details.)

This patch lands most of the infrastructure for this feature, but it
doesn't actually enable the feature.  I'll enable it in a follow-up
patch.

Tests: http/tests/security/popup-allowed-by-sandbox-is-sandboxed-control.html
       http/tests/security/popup-allowed-by-sandbox-is-sandboxed.html
       http/tests/security/popup-allowed-by-sandbox-when-allowed.html

* html/HTMLIFrameElement.cpp:
(WebCore::HTMLIFrameElement::parseMappedAttribute):
* loader/FrameLoader.h:
(WebCore::FrameLoader::forceSandboxFlags):
* loader/FrameLoaderTypes.h:
* page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::parseSandboxPolicy):
* page/SecurityOrigin.h:
(WebCore::SecurityOrigin::sandboxFlags):
* svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::dataChanged):

LayoutTests:

Test that the allow-popups directive works as expected.  Note:
no-popup-from-sandbox.html verifies that we still block popups without
the directive.

These tests currently have expected.txt results that show failures, but
they will pass once this feature is enabled.

* http/tests/security/popup-allowed-by-sandbox-is-sandboxed-control-expected.txt: Added.
* http/tests/security/popup-allowed-by-sandbox-is-sandboxed-control.html: Added.
* http/tests/security/popup-allowed-by-sandbox-is-sandboxed-expected.txt: Added.
* http/tests/security/popup-allowed-by-sandbox-is-sandboxed.html: Added.
* http/tests/security/popup-allowed-by-sandbox-when-allowed-expected.txt: Added.
* http/tests/security/popup-allowed-by-sandbox-when-allowed.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd stubs for WTF and Platform
abarth@webkit.org [Thu, 3 Nov 2011 19:25:25 +0000 (19:25 +0000)]
Add stubs for WTF and Platform
https://bugs.webkit.org/show_bug.cgi?id=71492

Reviewed by Eric Seidel.

Source/Platform:

This patch creates the Platform directory, which begins the process of
moving Platform out of WebCore.

Source/WTF:

This patch creates the WTF directory, which begins the process of
moving WTF out of JavaScriptCore.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] DRT: Allow choosing which backing store to use.
commit-queue@webkit.org [Thu, 3 Nov 2011 19:15:42 +0000 (19:15 +0000)]
[EFL] DRT: Allow choosing which backing store to use.
https://bugs.webkit.org/show_bug.cgi?id=70532

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-11-03
Reviewed by Antonio Gomes.

This change makes it possible to change the backing store used by DRT
from Tiled Backing Store (TBS) to Single Backing Store (SBS) by
setting the environment variable DRT_USE_SINGLE_BACKING_STORE to 1.

* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::createView):
* DumpRenderTree/efl/DumpRenderTreeView.cpp:
(shouldUseSingleBackingStore):
(chooseAndInitializeAppropriateSmartClass):
(drtViewAdd):
* DumpRenderTree/efl/DumpRenderTreeView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed gardening after r99212.
jchaffraix@webkit.org [Thu, 3 Nov 2011 18:48:14 +0000 (18:48 +0000)]
Unreviewed gardening after r99212.

* platform/chromium-win/fast/repaint/table-extra-bottom-grow-expected.png:
* platform/chromium/test_expectations.txt:
Rebaselined the test on Chromium Windows.

* platform/efl/Skipped:
I forgot to check the visual baseline on EFL. The EFL port does not seem to have the
repaint result (likely due to lack of support) thus it does not need a rebaseline.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCorrect chromium expectations for setPrinting and single-line-must-not-be-split-into...
tony@chromium.org [Thu, 3 Nov 2011 18:42:10 +0000 (18:42 +0000)]
Correct chromium expectations for setPrinting and single-line-must-not-be-split-into-two-pages.
https://bugs.webkit.org/show_bug.cgi?id=71080

* platform/chromium-cg-mac-leopard/printing/setPrinting-expected.png: Removed.
* platform/chromium-mac-leopard/printing/setPrinting-expected.txt: Removed.
* platform/chromium-mac-leopard/printing/single-line-must-not-be-split-into-two-pages-expected.txt: Removed.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDe-virtualize JSObject::className
mhahnenberg@apple.com [Thu, 3 Nov 2011 18:20:08 +0000 (18:20 +0000)]
De-virtualize JSObject::className
https://bugs.webkit.org/show_bug.cgi?id=71428

Reviewed by Sam Weinig.

Source/JavaScriptCore:

Added className to the MethodTable, changed all the virtual
implementations of className to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.

* API/JSCallbackObject.h:
* API/JSCallbackObjectFunctions.h:
(JSC::::className):
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* debugger/DebuggerActivation.cpp:
(JSC::DebuggerActivation::className):
* debugger/DebuggerActivation.h:
* jsc.cpp:
(GlobalObject::createStructure):
* profiler/Profiler.cpp:
(JSC::Profiler::createCallIdentifier):
* runtime/ClassInfo.h:
* runtime/JSCell.cpp:
(JSC::JSCell::className):
* runtime/JSCell.h:
* runtime/JSObject.cpp:
(JSC::JSObject::className):
* runtime/JSObject.h:
* runtime/ObjectPrototype.cpp:
(JSC::objectProtoFuncToString):
* testRegExp.cpp:
(GlobalObject::createStructure):

Source/JavaScriptGlue:

Added className to the MethodTable, changed all the virtual
implementations of className to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.

* JSUtils.cpp:
(KJSValueToCFTypeInternal):

Source/WebCore:

No new tests.

Added className to the MethodTable, changed all the virtual
implementations of className to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.

* bindings/js/JSDOMWindowShell.cpp:
(WebCore::JSDOMWindowShell::className):
* bindings/js/JSDOMWindowShell.h:
* bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::JSInjectedScriptHost::internalConstructorName):
* bridge/testqtbindings.cpp:
(Global::className):

Source/WebKit/efl:

Added className to the MethodTable, changed all the virtual
implementations of className to static ones, and replaced
all call sites with corresponding lookups in the MethodTable.

* ewk/ewk_js.cpp:
(ewk_js_npobject_to_object):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd Clock class and platform-specific implementations.
jer.noble@apple.com [Thu, 3 Nov 2011 18:05:15 +0000 (18:05 +0000)]
Add Clock class and platform-specific implementations.
https://bugs.webkit.org/show_bug.cgi?id=71341

Reviewed by Sam Weinig.

Source/JavaScriptCore:

Add WTF_USE_COREAUDIO macro for use by PlatformClockCA.

* wtf/Platform.h:

Source/WebCore:

No new tests; these classes will be used and tested by the MediaController feature.

Adds a abstract Clock class and two concrete, platform-specific subclasses.

Clock provides a basic interface for starting, stopping, and querying a generic timeline.
PlatformClockCA implements this interface using a CoreAudio CAClock object, which uses
the default audio device's hardware clock as a timing source. PlatformClockPOSIX
implements this interface using gettimeofday() as its timing source.

* WebCore.xcodeproj/project.pbxproj:
* platform/Clock.cpp: Added.
(Clock::create): Creates a platform-specific clock.
* platform/Clock.h: Added.
(WebCore::Clock::~Clock):
(WebCore::Clock::Clock):
* platform/mac/PlatformClockCA.cpp: Added.
(PlatformClockCA::PlatformClockCA):
(PlatformClockCA::~PlatformClockCA):
(PlatformClockCA::setCurrentTime):
(PlatformClockCA::currentTime):
(PlatformClockCA::setPlayRate):
(PlatformClockCA::PlatformClockCA::playRate):
(PlatformClockCA::start):
(PlatformClockCA::stop):
* platform/mac/PlatformClockCA.h: Added.
(WebCore::PlatformClockCA::isRunning):
* platform/posix/PlatformClockPOSIX.cpp: Added.
(timevalToFloat):
(timevalDelta):
(PlatformClockPOSIX::PlatformClockPOSIX):
(PlatformClockPOSIX::setCurrentTime):
(PlatformClockPOSIX::currentTime):
(PlatformClockPOSIX::setPlayRate):
(PlatformClockPOSIX::PlatformClockPOSIX::playRate):
(PlatformClockPOSIX::start):
(PlatformClockPOSIX::stop):
(PlatformClockPOSIX::now):
* platform/posix/PlatformClockPOSIX.h: Added.
(WebCore::PlatformClockPOSIX::isRunning):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Brought back TIMEOUT for show-hide-table-rows.html
caseq@chromium.org [Thu, 3 Nov 2011 17:57:40 +0000 (17:57 +0000)]
Unreviewed. Brought back TIMEOUT for show-hide-table-rows.html

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99221 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoJS Test Harness: Remove more link tags
arv@chromium.org [Thu, 3 Nov 2011 17:53:14 +0000 (17:53 +0000)]
JS Test Harness: Remove more link tags
https://bugs.webkit.org/show_bug.cgi?id=71339

Reviewed by Ojan Vafai.

Tools:

* Scripts/make-new-script-test:
(writeTestFile): Don't output <link>

LayoutTests:

* LayoutTest/*: Remove links to js-test-style.css.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99220 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoIndexedDB: Object stores not persisting between sessions
commit-queue@webkit.org [Thu, 3 Nov 2011 17:46:03 +0000 (17:46 +0000)]
IndexedDB: Object stores not persisting between sessions
https://bugs.webkit.org/show_bug.cgi?id=71313

Patch by Joshua Bell <jsbell@chromium.org> on 2011-11-03
Reviewed by Tony Chang.

Logic flaw introduced with r98806 skipped the loading of object stores
during subsequent sessions.

* storage/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl):
(WebCore::IDBDatabaseBackendImpl::openInternal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: fix heap profiler rendering and resize.
pfeldman@chromium.org [Thu, 3 Nov 2011 17:42:20 +0000 (17:42 +0000)]
Web Inspector: fix heap profiler rendering and resize.
https://bugs.webkit.org/show_bug.cgi?id=71484

Reviewed by Yury Semikhatsky.

* inspector/front-end/DetailedHeapshotView.js:
(WebInspector.DetailedHeapshotView.prototype.wasShown.profileCallback2):
(WebInspector.DetailedHeapshotView.prototype.wasShown):
(WebInspector.DetailedHeapshotView.prototype._changeView):
(WebInspector.DetailedHeapshotView.prototype._startRetainersHeaderDragging):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPatch by Thouraya ANDOLSI <thouraya.andolsi@st.com> on 2011-11-03
commit-queue@webkit.org [Thu, 3 Nov 2011 17:41:41 +0000 (17:41 +0000)]
Patch by Thouraya ANDOLSI <thouraya.andolsi@st.com> on 2011-11-03
Reviewed by Martin Robinson.

[GTK] arguments passed to build-jsc are not taken into account
https://bugs.webkit.org/show_bug.cgi?id=58333

* Scripts/build-jsc:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed evening gardening.
ossy@webkit.org [Thu, 3 Nov 2011 17:37:10 +0000 (17:37 +0000)]
[Qt] Unreviewed evening gardening.

* platform/qt/test_expectations.txt: Remove a useless entry.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99215 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed evening gardening. Add platform specific expected results after r98989.
ossy@webkit.org [Thu, 3 Nov 2011 17:34:39 +0000 (17:34 +0000)]
[Qt] Unreviewed evening gardening. Add platform specific expected results after r98989.

* platform/qt/svg/filters/invalidate-on-child-layout-expected.png: Added.
* platform/qt/svg/filters/invalidate-on-child-layout-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed evening gardening. Skip failing tests.
ossy@webkit.org [Thu, 3 Nov 2011 17:26:56 +0000 (17:26 +0000)]
[Qt] Unreviewed evening gardening. Skip failing tests.

* platform/qt-mac/Skipped:
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoStop abusing RenderTableSection::needsRecalcCells logic
jchaffraix@webkit.org [Thu, 3 Nov 2011 17:20:01 +0000 (17:20 +0000)]
Stop abusing RenderTableSection::needsRecalcCells logic
https://bugs.webkit.org/show_bug.cgi?id=71420

Reviewed by Darin Adler.

Source/WebCore:

Change covered by existing tests like fast/repaint/table-extra-bottom-grow.html
and fast/table/row-height-recalc* (among others).

Cell recalculation is very expensive and should only be called when the section's structure
changed in a way that requires a safe update to its structure (like removing a row as our
column split may not be appropriate anymore).

The current code would abuse cell recalculation to actually reset the logical height on the
RowStruct. This change makes it do the right thing.

* rendering/RenderTableCell.h:
* rendering/RenderTableRow.h:
Removed styleWillChange override as it was unneeded.

* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::styleDidChange):
* rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::styleDidChange):
Move the code from styleWillChange to styleDidChange.

* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::rowLogicalHeightChanged):
This function just reset the height on the |RowStruct| which is the
only part of recalcCells that we would need.

(WebCore::RenderTableSection::rowIndexForRenderer):
Added this function to find out which index a column has (strangely
RenderTableRow does not have this information).

* rendering/RenderTableSection.h: Added the 2 previous functions.

LayoutTests:

* platform/chromium-linux/fast/repaint/table-extra-bottom-grow-expected.png:
Update this test as this is a progression: we are not over-repainting the table
anymore.

* platform/chromium/test_expectations.txt:
* platform/efl/Skipped:
* platform/mac/Skipped:
* platform/qt/test_expectations.txt:
Skipped the test here as it needs a rebaseline.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed rebaselining. Unskipped progress-event-constructor.html in Qt-Arm
haraken@chromium.org [Thu, 3 Nov 2011 17:16:58 +0000 (17:16 +0000)]
Unreviewed rebaselining. Unskipped progress-event-constructor.html in Qt-Arm
since the failure is fixed in r99161.

* platform/qt-arm/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPluginControllerProxy's dirty rect should be in plug-in coordinates
andersca@apple.com [Thu, 3 Nov 2011 17:13:38 +0000 (17:13 +0000)]
PluginControllerProxy's dirty rect should be in plug-in coordinates
https://bugs.webkit.org/show_bug.cgi?id=71481

Reviewed by Sam Weinig.

* PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::paint):
Convert the dirty rect to window coordinates before passing it to the plug-in.

(WebKit::PluginControllerProxy::invalidate):
No need to convert the dirty rect to window coordinates.

(WebKit::PluginControllerProxy::paintEntirePlugin):
Use m_pluginSize instead of m_frameRectInWindowCoordinates.isEmpty.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Refactor WebFrameImpl::createFrameView() to use Frame:createView
fsamuel@chromium.org [Thu, 3 Nov 2011 17:06:59 +0000 (17:06 +0000)]
[Chromium] Refactor WebFrameImpl::createFrameView() to use Frame:createView
https://bugs.webkit.org/show_bug.cgi?id=70507

Reviewed by Darin Fisher.

No change in functionality except for fixed layout mode. Fixed layout mode has
not been fully upstreamed yet, so no new tests yet:
https://bugs.webkit.org/show_bug.cgi?id=70562 will address this.

This patch also fixes https://bugs.webkit.org/show_bug.cgi?id=70555
It was decided that fixed layout mode might need to be disabled for some content,
and so this change enables the embedder to decide whether to enable fixed layout on
navigation.

* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::createFrameView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Show url of history items in a status bar in MiniBrowser
carlosgc@webkit.org [Thu, 3 Nov 2011 17:06:51 +0000 (17:06 +0000)]
[GTK] Show url of history items in a status bar in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=71474

Reviewed by Martin Robinson.

* MiniBrowser/gtk/BrowserWindow.c:
(browserWindowSetStatusText): Set status text and show/hide the
status label.
(resetStatusText): Reset status text when history menu is hidden.
(browserWindowHistoryItemSelected): Show url of currently selected
history item.
(browserWindowCreateBackForwardMenu): Connect to hide signal of
menu to reset the status text.
(browserWindowConstructed): Use GtkOverlay if available to show
status text.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Add back/forward menus to MiniBrowser using WebKit2 GTK+ API
carlosgc@webkit.org [Thu, 3 Nov 2011 17:01:42 +0000 (17:01 +0000)]
[GTK] Add back/forward menus to MiniBrowser using WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=71466

Reviewed by Martin Robinson.

* MiniBrowser/gtk/BrowserWindow.c:
(browserWindowHistoryItemActivated): Go to selected back formard
list item using webkit_web_view_go_to_back_forward_list_item()
(browserWindowCreateBackForwardMenu): Create a GtkMenu for the
given GList of WebKitBackForwardListItems.
(browserWindowUpdateNavigationActions): Enable/disable back and
forward buttons depending on whether it's possible to go
back/forward. Create a menu for back and forward toolbar buttons.
(backForwadlistChanged): Call browserWindowUpdateNavigationActions().
(browserWindowConstructed): Connect to WebKitBackForwardList
changed signal.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUse the right function to determine whether NPWindow coordinates should be window...
andersca@apple.com [Thu, 3 Nov 2011 16:54:23 +0000 (16:54 +0000)]
Use the right function to determine whether NPWindow coordinates should be window relative
https://bugs.webkit.org/show_bug.cgi?id=71480

Reviewed by Adam Roben.

We want to use wantsWindowRelativeNPWindowCoordinates here, and not wantsWindowRelativeCoordinates
which is a temporary function that will be removed (and that returns the wrong value!)

* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::geometryDidChange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCSSRuleList: Move rule orphaning from deleteRule() out to callers.
commit-queue@webkit.org [Thu, 3 Nov 2011 16:31:26 +0000 (16:31 +0000)]
CSSRuleList: Move rule orphaning from deleteRule() out to callers.
https://bugs.webkit.org/show_bug.cgi?id=71470

Patch by Andreas Kling <kling@webkit.org> on 2011-11-03
Reviewed by Antti Koivisto.

Rule parenting is the responsibility of the owner rule (the rule containing
the rule list), so move parent clearing out of CSSRuleList::deleteRule() and
into the (two) call sites.

* css/CSSMediaRule.cpp:
(WebCore::CSSMediaRule::deleteRule):
* css/CSSRuleList.cpp:
(WebCore::CSSRuleList::deleteRule):
* css/WebKitCSSKeyframesRule.cpp:
(WebCore::WebKitCSSKeyframesRule::deleteRule):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: do not map scripts generated with document.write to the document resou...
pfeldman@chromium.org [Thu, 3 Nov 2011 16:28:29 +0000 (16:28 +0000)]
Web Inspector: do not map scripts generated with document.write to the document resources.
https://bugs.webkit.org/show_bug.cgi?id=71114

Reviewed by Yury Semikhatsky.

* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel):
(WebInspector.DebuggerPresentationModel.prototype._addScript):
(WebInspector.DebuggerPresentationModel.prototype._bindScriptToRawSourceCode):
(WebInspector.DebuggerPresentationModel.prototype.uiSourceCodes):
(WebInspector.DebuggerPresentationModel.prototype.setFormatSource):
(WebInspector.DebuggerPresentationModel.prototype._consoleCleared):
(WebInspector.DebuggerPresentationModel.prototype._rawSourceCodeForScriptWithURL):
(WebInspector.DebuggerPresentationModel.prototype._rawSourceCodeForScript):
(WebInspector.DebuggerPresentationModel.prototype._scriptForRawSourceCode):
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.reset):
* inspector/front-end/RawSourceCode.js:
(WebInspector.RawSourceCode.prototype._createSourceMapping.didRequestContent.didFormatContent):
(WebInspector.RawSourceCode.prototype._createSourceMapping.didRequestContent):
(WebInspector.RawSourceCode.prototype._createSourceMapping):
* inspector/front-end/Script.js:
(WebInspector.Script.prototype.editSource):
(WebInspector.Script.prototype.isInlineScript):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Remove Maemo specific code paths
hausmann@webkit.org [Thu, 3 Nov 2011 16:16:37 +0000 (16:16 +0000)]
[Qt] Remove Maemo specific code paths
https://bugs.webkit.org/show_bug.cgi?id=71476

Reviewed by Kenneth Rohde Christiansen.

.:

* Source/WebKit.pri:

Source/WebCore:

* WebCore.pri:
* features.pri:
* plugins/PluginPackage.cpp:
(WebCore::PluginPackage::determineQuirks):
* plugins/PluginView.cpp:
(WebCore::PluginView::setValue):
* plugins/PluginView.h:
* plugins/qt/PluginViewQt.cpp:
(WebCore::PluginView::updatePluginWidget):
(WebCore::PluginView::paint):
(WebCore::PluginView::platformGetValueStatic):

Source/WebKit/qt:

* Api/qwebpage.cpp:
(QWebPage::userAgentForUrl):
* Api/qwebview.cpp:
(QWebView::QWebView):
* QtWebKit.pro:
* WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::createSelectPopup):
* WebCoreSupport/EditorClientQt.cpp:
(WebCore::EditorClientQt::setInputMethodState):
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::createPlugin):
* WebCoreSupport/QtMaemoWebPopup.cpp: Removed.
* WebCoreSupport/QtMaemoWebPopup.h: Removed.
* tests/qgraphicswebview/tst_qgraphicswebview.cpp:
(tst_QGraphicsWebView::focusInputTypes):
* tests/qwebframe/tst_qwebframe.cpp:
* tests/qwebview/tst_qwebview.cpp:
(tst_QWebView::focusInputTypes):

Tools:

* QtTestBrowser/launcherwindow.cpp:
(LauncherWindow::~LauncherWindow):
(LauncherWindow::init):
(LauncherWindow::showLinkHover):
(LauncherWindow::selectElements):
(LauncherWindow::showFPS):
(LauncherWindow::updateFPS):
* QtTestBrowser/launcherwindow.h:
(WindowOptions::WindowOptions):
* QtTestBrowser/locationedit.cpp:
* QtTestBrowser/locationedit.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Show load progress information in MiniBrowser using WebKit2 GTK+ API
carlosgc@webkit.org [Thu, 3 Nov 2011 16:13:49 +0000 (16:13 +0000)]
[GTK] Show load progress information in MiniBrowser using WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=71461

Reviewed by Martin Robinson.

* MiniBrowser/gtk/BrowserWindow.c:
(resetEntryProgress): Reset the entry progress after a while when
load has been completed.
(webViewLoadProgressChanged): Update location entry progress.
(browserWindowConstructed): Connect to WebView
notify::estimated-load-progress signal.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Remove WebKit2 C API from MiniBrowser
carlosgc@webkit.org [Thu, 3 Nov 2011 16:10:42 +0000 (16:10 +0000)]
[GTK] Remove WebKit2 C API from MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=71459

Reviewed by Martin Robinson.

Use the GTK+ API instead to add minimum functionality. The other
features will be ported to GTK+ API in following patches.

* MiniBrowser/gtk/BrowserWindow.c:
(activateUriEntryCallback): Use webkit_web_view_load_uri().
(goBackCallback): Use webkit_web_view_go_back().
(goForwardCallback): Use webkit_web_view_go_forward().
(webViewURIChanged): Update location entry with current uri using
webkit_web_view_get_uri().
(browserWindowFinalize):
(browserWindowGetProperty):
(browserWindowSetProperty):
(browser_window_init):
(browserWindowConstructed): Connect to notify::uri signal of
WebView to be notified when the URI changes.
(browser_window_class_init):
(browser_window_new): Use WebKitWebView.
(browser_window_get_view): Use WebKitWebView
* MiniBrowser/gtk/BrowserWindow.h:
* MiniBrowser/gtk/GNUmakefile.am:
* MiniBrowser/gtk/WebBundle/WebBundleMain.c: Removed.
* MiniBrowser/gtk/main.c:
(loadURI): Use webkit_web_view_new().
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed build fix after r99195.
hausmann@webkit.org [Thu, 3 Nov 2011 16:07:22 +0000 (16:07 +0000)]
Unreviewed build fix after r99195.

The right name is restrictMinimumScaleFactorToViewportSize.

* UIProcess/API/qt/qtouchwebview.cpp:
(QTouchWebViewPrivate::updateViewportConstraints):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Use WEBKIT_API instead of WK_EXPORT in WebKitEnumTypes.h
carlosgc@webkit.org [Thu, 3 Nov 2011 16:04:49 +0000 (16:04 +0000)]
[GTK] Use WEBKIT_API instead of WK_EXPORT in WebKitEnumTypes.h
https://bugs.webkit.org/show_bug.cgi?id=71457

Reviewed by Martin Robinson.

* GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Bounce back limits are wrong in some situations
kenneth@webkit.org [Thu, 3 Nov 2011 15:40:22 +0000 (15:40 +0000)]
[Qt] Bounce back limits are wrong in some situations
https://bugs.webkit.org/show_bug.cgi?id=71471

Reviewed by Simon Hausmann.

The valid position points were in viewport coordinates, but we were
requiring valid position points in content coordinates.

* UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::animateContentIntoBoundariesIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPatch by Jesus Sanchez-Palencia <jesus@webkit.org> on 2011-11-03
hausmann@webkit.org [Thu, 3 Nov 2011 15:31:38 +0000 (15:31 +0000)]
Patch by Jesus Sanchez-Palencia <jesus@webkit.org> on 2011-11-03
Reviewed by Kenneth Rohde Christiansen.

[Qt] QtWebKit should have documentation clarifying its mobile features usage
https://bugs.webkit.org/show_bug.cgi?id=41465

Add "QtWebKit Goes Mobile" documentation

* docs/qtwebkit-goes-mobile.qdoc: Added.
* docs/qtwebkit.qdoc: Linked to qtwebkit-goes-mobile documentation
* docs/webkitsnippets/qtwebkit_goes_mobile_snippets.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemoving line in computeViewportAttributes that enforces a minimum scale factor to...
fsamuel@chromium.org [Thu, 3 Nov 2011 15:22:16 +0000 (15:22 +0000)]
Removing line in computeViewportAttributes that enforces a minimum scale factor to never allow zooming out more than viewport
https://bugs.webkit.org/show_bug.cgi?id=70609

Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Operations in computeViewportAttributes that are not a part of the spec:

http://www.w3.org/TR/2011/WD-css-device-adapt-20110915/#constraining-viewport-property-values

were moved into the functions restrictMinimumScaleFactorToViewportSize and
restrictScaleFactorToInitialScaleIfNotUserScalable.

* WebCore.exp.in:
* dom/ViewportArguments.cpp:
(WebCore::computeViewportAttributes):
(WebCore::restrictMinimumScaleFactorToViewportSize):
(WebCore::restrictScaleFactorToInitialScaleIfNotUserScalable):
* dom/ViewportArguments.h:

Source/WebKit/efl:

* ewk/ewk_view.cpp:
(_ewk_view_viewport_attributes_compute):

Source/WebKit/gtk:

* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::dumpConfigurationForViewport):
* webkit/webkitviewportattributes.cpp:
(webkitViewportAttributesRecompute):

Source/WebKit/qt:

* Api/qwebpage.cpp:
(QWebPage::viewportAttributesForSize):
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
(DumpRenderTreeSupportQt::viewportAsText):

Source/WebKit2:

* UIProcess/API/qt/qtouchwebview.cpp:
(QTouchWebViewPrivate::updateViewportConstraints):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::viewportConfigurationAsText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] Fix the signal signature of the loadFailed API test.
abecsi@webkit.org [Thu, 3 Nov 2011 15:21:06 +0000 (15:21 +0000)]
[Qt][WK2] Fix the signal signature of the loadFailed API test.

Rubber-stamped by Simon Hausmann.

* UIProcess/API/qt/tests/commonviewtests/webviewabstraction.cpp:
(WebViewAbstraction::touchViewLoadFailed):
(WebViewAbstraction::desktopViewLoadFailed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99194 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unable to start MiniBrowser after run-webkit-tests
hausmann@webkit.org [Thu, 3 Nov 2011 15:05:21 +0000 (15:05 +0000)]
[Qt] Unable to start MiniBrowser after run-webkit-tests
https://bugs.webkit.org/show_bug.cgi?id=71469

Reviewed by Csaba Osztrogonác.

* Scripts/run-launcher: Pass @ARGV instead of @args, which is stripped
from things like -2. Neither Gtk or Qt MiniBrowser like unknown command
line arguments.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99193 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Fix an assertion under WebPage::setViewportSize.
jocelyn.turcotte@nokia.com [Thu, 3 Nov 2011 14:49:43 +0000 (14:49 +0000)]
[Qt] Fix an assertion under WebPage::setViewportSize.
https://bugs.webkit.org/show_bug.cgi?id=71473

Reviewed by Simon Hausmann.

The web view can have an empty size and it causes the assert in computeViewportAttributes.
Don't notify the web page of such a size change in this case.

* UIProcess/API/qt/qtouchwebview.cpp:
(QTouchWebViewPrivate::updateViewportSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99192 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed expectations update.
caseq@chromium.org [Thu, 3 Nov 2011 14:44:40 +0000 (14:44 +0000)]
Unreviewed expectations update.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed build fix, sigh.
andreas.kling@nokia.com [Thu, 3 Nov 2011 14:42:28 +0000 (14:42 +0000)]
Unreviewed build fix, sigh.

* css/CSSFontFaceRule.h:
* css/CSSMutableStyleDeclaration.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99190 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, skipping 3 new svg tests presenting pixel differences
philn@webkit.org [Thu, 3 Nov 2011 14:39:11 +0000 (14:39 +0000)]
Unreviewed, skipping 3 new svg tests presenting pixel differences
between the 32-bits and 64-bits bots.

* platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99189 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[WK2] State variable name refactor in WebPageProxy.cpp
commit-queue@webkit.org [Thu, 3 Nov 2011 14:32:17 +0000 (14:32 +0000)]
[WK2] State variable name refactor in WebPageProxy.cpp
https://bugs.webkit.org/show_bug.cgi?id=71467

Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2011-11-03
Reviewed by Andreas Kling.

Renaming m_inDecidePolicyForMIMEType to m_inDecidePolicyForResponse after
https://bugs.webkit.org/show_bug.cgi?id=55827 .

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::receivedPolicyDecision):
(WebKit::WebPageProxy::decidePolicyForResponse):
* UIProcess/WebPageProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@99188 268f45cc-cd09-0410-ab3c-d52691b4dbfc