WebKit-https.git
9 years agoUnreviewed fix for the test. The amount of used memory was calculated incorrectly.
loislo@chromium.org [Mon, 10 Oct 2011 16:58:23 +0000 (16:58 +0000)]
Unreviewed fix for the test. The amount of used memory was calculated incorrectly.

* inspector/performance/resources/network-append-30-requests.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Linkifier.reset throw an exception if it is called after reset of...
loislo@chromium.org [Mon, 10 Oct 2011 16:40:44 +0000 (16:40 +0000)]
Web Inspector: Linkifier.reset throw an exception if it is called after reset of debuggerPresentationModel.
https://bugs.webkit.org/show_bug.cgi?id=69756

Reviewed by Yury Semikhatsky.

* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.Linkifier.prototype.reset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: RawSourceCode could be mapped to multiple sources.
podivilov@chromium.org [Mon, 10 Oct 2011 16:09:22 +0000 (16:09 +0000)]
Web Inspector: RawSourceCode could be mapped to multiple sources.
https://bugs.webkit.org/show_bug.cgi?id=68526

Source/WebCore:

Replace SourceMapping.uiSourceCode with SourceMapping.uiSourceCodeList as there could be more
then one UISourceCode associated with a RawSourceCode.

Reviewed by Pavel Feldman.

* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype._sourceMappingUpdated):
(WebInspector.DebuggerPresentationModel.prototype._updateSourceMapping):
(WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoints):
(WebInspector.PresentationCallFrame.prototype.get url):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype.canSetContent):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype.setContent):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._uiSourceCodeReplaced):
* inspector/front-end/SourceFile.js:
(WebInspector.RawSourceCode.prototype._saveSourceMapping):
(WebInspector.RawSourceCode.PlainSourceMapping):
(WebInspector.RawSourceCode.PlainSourceMapping.prototype.rawLocationToUILocation):
(WebInspector.RawSourceCode.PlainSourceMapping.prototype.uiSourceCodeList):
(WebInspector.RawSourceCode.FormattedSourceMapping):
(WebInspector.RawSourceCode.FormattedSourceMapping.prototype.rawLocationToUILocation):
(WebInspector.RawSourceCode.FormattedSourceMapping.prototype.uiSourceCodeList):

LayoutTests:

Reviewed by Pavel Feldman.

* inspector/debugger/raw-source-code.html:
* inspector/debugger/scripts-panel.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoShrink RenderLayer and ScrollableArea.
andreas.kling@nokia.com [Mon, 10 Oct 2011 14:51:44 +0000 (14:51 +0000)]
Shrink RenderLayer and ScrollableArea.
https://bugs.webkit.org/show_bug.cgi?id=69759

Reviewed by Antti Koivisto.

Rearrange the members of RenderLayer and its base class ScrollableArea
to maximize struct packing, shrinking RenderLayer by one CPU word on
32-bit (and two on 64-bit.)

This reduces memory consumption by 134 kB (on 64-bit) when loading the
full HTML5 spec.

* platform/ScrollableArea.h:
(WebCore::ScrollableArea::verticalScrollElasticity):
(WebCore::ScrollableArea::horizontalScrollElasticity):
(WebCore::ScrollableArea::scrollbarOverlayStyle):

    Cast the now-bitfield members to the appropriate enum types.

* rendering/RenderLayer.h:
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer):

    Move shouldBeNormalFlowOnly() call out of initializer list since it
    depends on m_renderer being initialized.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed gardening after r96958.
kbalazs@webkit.org [Mon, 10 Oct 2011 14:47:07 +0000 (14:47 +0000)]
Unreviewed gardening after r96958.
https://bugs.webkit.org/show_bug.cgi?id=69757

Unreviewed gardening.

Patch by Zsolt FehĂ©r <feherzs@inf.u-szeged.hu> on 2011-10-10

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-10-10 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Mon, 10 Oct 2011 14:06:25 +0000 (14:06 +0000)]
2011-10-10  Pavel Podivilov  <podivilov@chromium.org>

        Unreviewed, fix test after r97056.

        * inspector/debugger/script-formatter-expected.txt:
        * inspector/debugger/script-formatter.html:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Skia on Chromium Mac] Set canExpandAroundIdeographsInComplexText to true
caryclark@google.com [Mon, 10 Oct 2011 13:07:53 +0000 (13:07 +0000)]
[Skia on Chromium Mac] Set canExpandAroundIdeographsInComplexText to true
https://bugs.webkit.org/show_bug.cgi?id=69656
https://bugs.webkit.org/show_bug.cgi?id=62987
https://bugs.webkit.org/show_bug.cgi?id=62889

Reviewed by Stephen White.

Skia on Linux and Windows uses different font engines from
Skia on Mac. After determining that the underlying CoreText
can handle it, enabling this allows justification to work
correctly.

Tests: fast/text/justify-ideograph-complex.html

* platform/graphics/skia/FontSkia.cpp:
(WebCore::Font::canExpandAroundIdeographsInComplexText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: memory leak in Resource panel.
loislo@chromium.org [Mon, 10 Oct 2011 13:04:00 +0000 (13:04 +0000)]
Web Inspector: memory leak in Resource panel.
https://bugs.webkit.org/show_bug.cgi?id=69754

Reviewed by Yury Semikhatsky.

* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.reset):
* inspector/front-end/View.js:
(WebInspector.View.prototype.childViews):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: saving JavaScript after live edit resets scroller position.
podivilov@chromium.org [Mon, 10 Oct 2011 12:40:19 +0000 (12:40 +0000)]
Web Inspector: saving JavaScript after live edit resets scroller position.
https://bugs.webkit.org/show_bug.cgi?id=69340

Source/WebCore:

Do not recreate SourceFrame when content is changed. Instead, update text model in existing SourceFrame.

Reviewed by Yury Semikhatsky.

* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.setScriptSource.didEditScriptSource):
(WebInspector.DebuggerPresentationModel.prototype.setScriptSource):
* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame):
* inspector/front-end/RawSourceCode.js:
(WebInspector.RawSourceCode.prototype.setCompilerSourceMappingProvider):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._setReadOnly):
(WebInspector.SourceFrame.prototype.contentChanged):
* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode.prototype.contentChanged):

LayoutTests:

Reviewed by Yury Semikhatsky.

* inspector/debugger/raw-source-code-expected.txt:
* inspector/debugger/raw-source-code.html:
* inspector/debugger/scripts-panel.html:
* inspector/debugger/ui-source-code-expected.txt:
* inspector/debugger/ui-source-code.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97056 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed test fix for r97050.
loislo@chromium.org [Mon, 10 Oct 2011 11:43:40 +0000 (11:43 +0000)]
Unreviewed test fix for r97050.

* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoShrink RenderListItem on 64-bit.
andreas.kling@nokia.com [Mon, 10 Oct 2011 11:29:53 +0000 (11:29 +0000)]
Shrink RenderListItem on 64-bit.
https://bugs.webkit.org/show_bug.cgi?id=69751

Reviewed by Kenneth Rohde Christiansen.

Rearrange members to utilize the padding at the end of RenderBlock.
This shrinks RenderListItem by 8 bytes on 64-bit, reducing memory consumption
by 60 kB when loading the full HTML5 spec.

* rendering/RenderListItem.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97054 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-10-10 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Mon, 10 Oct 2011 11:27:59 +0000 (11:27 +0000)]
2011-10-10  Pavel Podivilov  <podivilov@chromium.org>

        Unreviewed, mark CCThreadTest.startPostAndWaitOnCondition as flaky on win and mac.

        * tests/CCThreadTest.cpp:
        (WebKit::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97053 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoShrink RootInlineBox.
andreas.kling@nokia.com [Mon, 10 Oct 2011 10:14:25 +0000 (10:14 +0000)]
Shrink RootInlineBox.
https://bugs.webkit.org/show_bug.cgi?id=69707

Reviewed by Antti Koivisto.

Move the bitfields from RootInlineBox up into its base class (InlineFlowBox.)
This shrinks RootInlineBox by one CPU word without growing InlineFlowBox.
Enum bitfields were changed to "unsigned" for the MSVC signedness quirk.

Also move one 32-bit member to the head of RootInlineBox so it falls into the
padding at the end of InlineFlowBox on 64-bit.

This reduces memory consumption by 780 kB (on 64-bit) when loading the full
HTML5 spec.

* rendering/InlineFlowBox.h:
(WebCore::InlineFlowBox::InlineFlowBox):
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::RootInlineBox):
(WebCore::RootInlineBox::lineBreakBidiStatus):
* rendering/RootInlineBox.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-10-10 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Mon, 10 Oct 2011 10:08:08 +0000 (10:08 +0000)]
2011-10-10  Pavel Podivilov  <podivilov@chromium.org>

        Unreviewed, attempt to fix chromium mac build after r97034.

        * platform/ScrollAnimatorNone.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97051 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: small memory leak in scripts panel.
loislo@chromium.org [Mon, 10 Oct 2011 09:54:02 +0000 (09:54 +0000)]
Web Inspector: small memory leak in scripts panel.
https://bugs.webkit.org/show_bug.cgi?id=69744

Scripts panel doesn't clean the list of child views.

Reviewed by Yury Semikhatsky.

* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype._debuggerReset):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._uiSourceCodeRemoved):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97050 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: allow to start WorkerContext paused
yurys@chromium.org [Mon, 10 Oct 2011 09:33:18 +0000 (09:33 +0000)]
Web Inspector: allow to start WorkerContext paused
https://bugs.webkit.org/show_bug.cgi?id=69635

Source/WebCore:

Allow to pause WorkerContext on start.

Reviewed by Pavel Feldman.

* bindings/v8/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::setPauseOnNextStatement):
* bindings/v8/WorkerScriptDebugServer.cpp:
(WebCore::WorkerScriptDebugServer::runMessageLoopOnPause):
* bindings/v8/WorkerScriptDebugServer.h:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::willEvaluateWorkerScript):
* inspector/InspectorInstrumentation.h:
* inspector/InspectorRuntimeAgent.cpp:
(WebCore::InspectorRuntimeAgent::InspectorRuntimeAgent):
(WebCore::InspectorRuntimeAgent::~InspectorRuntimeAgent):
(WebCore::InspectorRuntimeAgent::pauseWorkerContext): this method will start
running worker message loop in "debug" mode, i.e. it will process only inspector
tasks until method InspectorRuntimeAgent::resume is called.
(WebCore::InspectorRuntimeAgent::resume):
* inspector/InspectorRuntimeAgent.h:
* inspector/WorkerDebuggerAgent.cpp:
* inspector/WorkerDebuggerAgent.h:
* inspector/WorkerInspectorController.cpp:
(WebCore::WorkerInspectorController::WorkerInspectorController):
(WebCore::WorkerInspectorController::resume): method which is called from WebKit layer
when it is known that inspector state was restored and it is OK to resume worker execution.
* inspector/WorkerInspectorController.h:
* workers/DedicatedWorkerThread.cpp:
(WebCore::DedicatedWorkerThread::create):
(WebCore::DedicatedWorkerThread::DedicatedWorkerThread):
* workers/DedicatedWorkerThread.h:
* workers/SharedWorkerThread.cpp:
(WebCore::SharedWorkerThread::create):
(WebCore::SharedWorkerThread::SharedWorkerThread):
* workers/SharedWorkerThread.h:
* workers/WorkerMessagingProxy.cpp:
(WebCore::WorkerMessagingProxy::startWorkerContext):
(WebCore::WorkerMessagingProxy::disconnectFromInspector):
(WebCore::WorkerMessagingProxy::sendMessageToInspector):
* workers/WorkerThread.cpp:
(WebCore::WorkerThreadStartupData::create):
(WebCore::WorkerThreadStartupData::WorkerThreadStartupData):
(WebCore::WorkerThread::WorkerThread): WorkerThread is passed a booleand flag indicating
whether the context should be paused and wait for explicit resume command before it
starts running its script.
(WebCore::WorkerThread::workerThread):
* workers/WorkerThread.h:

Source/WebKit/chromium:

Expose methods for pausing shared worker on start.

Reviewed by Pavel Feldman.

* public/WebSharedWorker.h:
(WebKit::WebSharedWorker::pauseWorkerContextOnStart): specifies that the worker
context should be paused and weit for explicit call to resumeWorkerContext before
running its script.
(WebKit::WebSharedWorker::resumeWorkerContext):
* src/WebSharedWorkerImpl.cpp:
(WebKit::WebSharedWorkerImpl::WebSharedWorkerImpl):
(WebKit::WebSharedWorkerImpl::startWorkerContext):
(WebKit::WebSharedWorkerImpl::pauseWorkerContextOnStart):
(WebKit::resumeWorkerContextTask):
(WebKit::WebSharedWorkerImpl::resumeWorkerContext):
(WebKit::WebSharedWorkerImpl::attachDevTools):
(WebKit::reconnectToWorkerContextInspectorTask):
(WebKit::WebSharedWorkerImpl::reattachDevTools):
(WebKit::WebSharedWorkerImpl::detachDevTools):
(WebKit::WebSharedWorkerImpl::dispatchDevToolsMessage):
* src/WebSharedWorkerImpl.h:
* src/WebWorkerClientImpl.cpp:
(WebKit::WebWorkerClientImpl::startWorkerContext):
(WebKit::WebWorkerClientImpl::updateInspectorStateCookie):
* src/WebWorkerClientImpl.h:
* src/WebWorkerImpl.cpp:
(WebKit::WebWorkerImpl::startWorkerContext):
(WebKit::WebWorkerImpl::detachDevTools):
(WebKit::WebWorkerImpl::dispatchDevToolsMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97049 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Fix build with qreal == float on MeeGo 1.2 Harmattan
hausmann@webkit.org [Mon, 10 Oct 2011 09:21:41 +0000 (09:21 +0000)]
[Qt] Fix build with qreal == float on MeeGo 1.2 Harmattan

Reviewed by Andreas Kling.

Explicitly choose the qreal variant of qMin, since QPointF is using qreal.

* UIProcess/qt/ViewportInteractionEngine.cpp:
(WebKit::ViewportInteractionEngine::animateContentPositionIntoBoundariesIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Add methods to reload the view to WebKit2 GTK+ API
carlosgc@webkit.org [Mon, 10 Oct 2011 09:20:19 +0000 (09:20 +0000)]
[GTK] Add methods to reload the view to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=69613

Reviewed by Martin Robinson.

* UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_reload):
(webkit_web_view_reload_bypass_cache):
* UIProcess/API/gtk/WebKitWebView.h:
* UIProcess/API/gtk/tests/testloading.c:
(loadReloadProvisionalLoadStarted):
(loadReloadLoadFinished):
(testLoadTimeoutFinishLoop):
(testLoadReload):
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r97045.
commit-queue@webkit.org [Mon, 10 Oct 2011 09:03:28 +0000 (09:03 +0000)]
Unreviewed, rolling out r97045.
http://trac.webkit.org/changeset/97045
https://bugs.webkit.org/show_bug.cgi?id=69746

makes apple bots very crashy :( (Requested by kling on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-10

Source/JavaScriptCore:

* config.h:

Source/WebCore:

* css/CSSStyleApplyProperty.cpp:
(WebCore::ApplyPropertyColor::applyInheritValue):
* page/animation/AnimationBase.cpp:
(WebCore::PropertyWrapperMaybeInvalidColor::PropertyWrapperMaybeInvalidColor):
(WebCore::PropertyWrapperSVGPaint::PropertyWrapperSVGPaint):
(WebCore::AnimationBase::ensurePropertyMap):
* platform/graphics/Color.h:
(WebCore::Color::Color):
* rendering/style/BorderValue.h:
(WebCore::BorderValue::BorderValue):
(WebCore::BorderValue::isTransparent):
(WebCore::BorderValue::operator==):
(WebCore::BorderValue::color):
* rendering/style/OutlineValue.h:
(WebCore::OutlineValue::operator==):
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::setBorderLeftColor):
(WebCore::InheritedFlags::setBorderRightColor):
(WebCore::InheritedFlags::setBorderTopColor):
(WebCore::InheritedFlags::setBorderBottomColor):
(WebCore::InheritedFlags::setOutlineColor):
(WebCore::InheritedFlags::setColumnRuleColor):
(WebCore::InheritedFlags::fillPaintColor):
(WebCore::InheritedFlags::strokePaintColor):
(WebCore::InheritedFlags::borderLeftColor):
(WebCore::InheritedFlags::borderRightColor):
(WebCore::InheritedFlags::borderTopColor):
(WebCore::InheritedFlags::borderBottomColor):
(WebCore::InheritedFlags::backgroundColor):
(WebCore::InheritedFlags::color):
(WebCore::InheritedFlags::columnRuleColor):
(WebCore::InheritedFlags::outlineColor):
(WebCore::InheritedFlags::textEmphasisColor):
(WebCore::InheritedFlags::textFillColor):
(WebCore::InheritedFlags::textStrokeColor):
(WebCore::InheritedFlags::stopColor):
(WebCore::InheritedFlags::floodColor):
(WebCore::InheritedFlags::lightingColor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoShrink BorderValue.
andreas.kling@nokia.com [Mon, 10 Oct 2011 07:50:48 +0000 (07:50 +0000)]
Shrink BorderValue.
https://bugs.webkit.org/show_bug.cgi?id=69521

Reviewed by Antti Koivisto.

Source/JavaScriptCore:

* config.h: Touch to force full rebuild.

Source/WebCore:

Unroll BorderValue's Color member so we can pack the color's validity flag
in BorderValue's bitfield.

This shrinks BorderValue by 32 bit, which in turn shrinks BorderData by
16 bytes. This reduces memory consumption by 760 kB when loading the full
HTML5 spec.

* platform/graphics/Color.h:
(WebCore::Color::Color):

    Allow construction of Color objects with specific validity.

* rendering/style/BorderValue.h:
(WebCore::BorderValue::BorderValue):
(WebCore::BorderValue::isTransparent):
(WebCore::BorderValue::operator==):
(WebCore::BorderValue::setColor):
(WebCore::BorderValue::color):
* rendering/style/OutlineValue.h:
(WebCore::OutlineValue::operator==):

    Unroll m_color into BorderValue by splitting it into an RGBA32 and a bool.
    Made those variables private and added color(), setColor() accessors.

* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::setBorderLeftColor):
(WebCore::InheritedFlags::setBorderRightColor):
(WebCore::InheritedFlags::setBorderTopColor):
(WebCore::InheritedFlags::setBorderBottomColor):
(WebCore::InheritedFlags::setOutlineColor):
(WebCore::InheritedFlags::setColumnRuleColor):

    Added a SET_BORDERVALUE_COLOR macro and use that instead of SET_VAR
    when setting BorderValue colors.

(WebCore::InheritedFlags::fillPaintColor):
(WebCore::InheritedFlags::strokePaintColor):
(WebCore::InheritedFlags::borderLeftColor):
(WebCore::InheritedFlags::borderRightColor):
(WebCore::InheritedFlags::borderTopColor):
(WebCore::InheritedFlags::borderBottomColor):
(WebCore::InheritedFlags::backgroundColor):
(WebCore::InheritedFlags::color):
(WebCore::InheritedFlags::columnRuleColor):
(WebCore::InheritedFlags::outlineColor):
(WebCore::InheritedFlags::textEmphasisColor):
(WebCore::InheritedFlags::textFillColor):
(WebCore::InheritedFlags::textStrokeColor):
(WebCore::InheritedFlags::stopColor):
(WebCore::InheritedFlags::floodColor):
(WebCore::InheritedFlags::lightingColor):

    Made color getters return "Color" instead of "const Color&" since
    BorderValue no longer has an actual object to return the reference to.

* css/CSSStyleApplyProperty.cpp:
(WebCore::ApplyPropertyColor::applyInheritValue):
* page/animation/AnimationBase.cpp:
(WebCore::PropertyWrapperColor::PropertyWrapperColor):
(WebCore::PropertyWrapperColor::blend):
(WebCore::PropertyWrapperMaybeInvalidColor::PropertyWrapperMaybeInvalidColor):
(WebCore::PropertyWrapperSVGPaint::PropertyWrapperSVGPaint):
(WebCore::AnimationBase::ensurePropertyMap):

    Adapt to RenderStyle color getters now returning "Color" instead of
    "const Color&".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMissing m_notificationPresenter initialization in WorkerThread constructor
yurys@chromium.org [Mon, 10 Oct 2011 07:15:15 +0000 (07:15 +0000)]
Missing m_notificationPresenter initialization in WorkerThread constructor
https://bugs.webkit.org/show_bug.cgi?id=69741

Added missing m_notificationPresenter(0)

Reviewed by Pavel Feldman.

* workers/WorkerThread.cpp:
(WebCore::WorkerThread::WorkerThread):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Refactor zoom related APIs.
ryuan.choi@samsung.com [Mon, 10 Oct 2011 05:57:49 +0000 (05:57 +0000)]
[EFL] Refactor zoom related APIs.
https://bugs.webkit.org/show_bug.cgi?id=62842

Current zoom apis can't support the case of using both page zoom and text
zoom.

As a first step to refactor, this split ewk_{view|frame}_zoom_{get|set}
to use both page_zoom and text zoom individually.
In addition, introduce ewk_view_scale_{get|set} to support proportional scaling.

ewk_view_zoom_{get|set} will remain unchanged until the behavior of smart_zoom
was changed.

Reviewed by Antonio Gomes.

* ewk/ewk_frame.cpp: Remove ewk_frame_zoom_text_only_{get|set}.
(ewk_frame_page_zoom_get): Renamed from ewk_frame_zoom_get().
(ewk_frame_page_zoom_set): Renamed from ewk_frame_zoom_set().
(ewk_frame_text_zoom_get): Extracted from ewk_frame_zoom_get().
(ewk_frame_text_zoom_set): Extracted from ewk_frame_zoom_set().
* ewk/ewk_frame.h:
* ewk/ewk_view.cpp: Remove ewk_view_zoom_text_only_{get|set}
(_ewk_view_smart_zoom_set): Change ewk_frame_zoom_get() to ewk_frame_page_zoom_get().
(ewk_view_zoom_get): Change ewk_frame_zoom_get() to ewk_frame_page_zoom_get().
(ewk_view_page_zoom_get): Extracted from ewk_view_zoom_get().
(ewk_view_page_zoom_set): Extracted from ewk_view_zoom_set().
(ewk_view_scale_get): Added.
(ewk_view_scale_set): Added.
(ewk_view_text_zoom_get): Extracted from ewk_view_zoom_get().
(ewk_view_text_zoom_set): Extracted from ewk_view_zoom_set().
(ewk_view_zoom_weak_set): Change ewk_frame_zoom_get to ewk_frame_page_zoom_get().
(ewk_view_zoom_animated_set): Change ewk_frame_zoom_get() to ewk_frame_page_zoom_get().
(ewk_view_pre_render_region): Change ewk_frame_zoom_get() to ewk_frame_page_zoom_get().
(ewk_view_pre_render_relative_radius): Change ewk_frame_zoom_get() to ewk_frame_page_zoom_get().
* ewk/ewk_view.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97043 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAnother attempt to fix the Leopard Intel Debug build after changeset 97034 <http...
dbates@webkit.org [Mon, 10 Oct 2011 05:09:22 +0000 (05:09 +0000)]
Another attempt to fix the Leopard Intel Debug build after changeset 97034 <trac.webkit.org/changeset/97034>
(https://bugs.webkit.org/show_bug.cgi?id=68035)

* page/FrameView.cpp:
(WebCore::FrameView::zoomAnimatorTransformChanged): Explicitly convert a double precision result
to a single precision result. I am unsure if this fix is correct. We need to look into this some
more. See <https://bugs.webkit.org/show_bug.cgi?id=69739> for more details.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAttempt to fix the Leopard Intel Debug build after changeset 97034 <http://trac.webki...
dbates@webkit.org [Mon, 10 Oct 2011 04:54:35 +0000 (04:54 +0000)]
Attempt to fix the Leopard Intel Debug build after changeset 97034 <trac.webkit.org/changeset/97034>
(https://bugs.webkit.org/show_bug.cgi?id=68035)

* page/FrameView.cpp:
(WebCore::FrameView::zoomAnimatorTransformChanged): Explicitly convert double precision result to
an integer. I am unsure if this fix is correct. We need to look into this some more. See
<https://bugs.webkit.org/show_bug.cgi?id=69739> for more details.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix Lion, Leopard and Snow Leopard builds after changeset 97034 <http://trac.webkit...
dbates@webkit.org [Mon, 10 Oct 2011 04:28:58 +0000 (04:28 +0000)]
Fix Lion, Leopard and Snow Leopard builds after changeset 97034 <trac.webkit.org/changeset/97034>
(https://bugs.webkit.org/show_bug.cgi?id=68035)
https://bugs.webkit.org/show_bug.cgi?id=69735

Patch by Luke Macpherson <macpherson@chromium.org> on 2011-10-09
Reviewed by Daniel Bates.

Source/WebCore:

* testing/Internals.cpp:
Mark unused parameters to prevent compile errors when GESTURE_EVENTS and SMOOTH_SCROLLING are disabled.
(WebCore::Internals::setEnableScrollAnimator):
(WebCore::Internals::setZoomAnimatorTransform):
(WebCore::Internals::setZoomParameters):

Source/WebKit2:

* WebProcess/Plugins/PDF/BuiltInPDFView.h:
Add symbols that are now required by ScrollableArea.
(WebKit::BuiltInPDFView::zoomAnimatorTransformChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImprove Null or Undefined test in 32_64 DFG
commit-queue@webkit.org [Mon, 10 Oct 2011 04:05:27 +0000 (04:05 +0000)]
Improve Null or Undefined test in 32_64 DFG
https://bugs.webkit.org/show_bug.cgi?id=69734

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-10-09
Reviewed by Darin Adler.

Currently Null or Undefined value test in 32_64 DFG will check
Null and Undefined tag separately and introduce one more branch.
It can be improved in the way how the baseline JIT is doing - by
relying on the fact that "UndefinedTag + 1 == NullTag and NullTag & 1".

* dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::nonSpeculativeNonPeepholeCompareNull):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove redundant code of HTMLSelectElement.
tkent@chromium.org [Mon, 10 Oct 2011 03:25:36 +0000 (03:25 +0000)]
Remove redundant code of HTMLSelectElement.
https://bugs.webkit.org/show_bug.cgi?id=69701

Reviewed by Darin Adler.

No new tests, just a refactoring.

* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::deselectItems):
Rename inner deselectItems() to deselectItemsWithoutValidation().
(WebCore::HTMLSelectElement::setSelectedIndex):
Rename a callsite of another setSelectedIndex() to setSelectedIndexInternal().
(WebCore::HTMLSelectElement::setSelectedIndexByUser):
ditto, and update a callsite of updateSelectedState().
(WebCore::HTMLSelectElement::listBoxSelectItem):
Update a callsite of updateSelectedState().
(WebCore::HTMLSelectElement::activeSelectionEndListIndex):
Update a callsite of lastSelectedListIndex().
(WebCore::HTMLSelectElement::selectAll):
Update callsites of functions which are changed to non-static.
(WebCore::HTMLSelectElement::saveLastSelection):
Merge a static function and a non-static function.
(WebCore::HTMLSelectElement::setActiveSelectionAnchorIndex): ditto.
(WebCore::HTMLSelectElement::setActiveSelectionEndIndex): ditto.
(WebCore::HTMLSelectElement::updateListBoxSelection): ditto.
(WebCore::HTMLSelectElement::listBoxOnChange): ditto.
(WebCore::HTMLSelectElement::menuListOnChange): ditto.
(WebCore::HTMLSelectElement::scrollToSelection): ditto.
(WebCore::HTMLSelectElement::setOptionsChangedOnRenderer): Made this non-static.
(WebCore::HTMLSelectElement::setRecalcListItems):
Merge a static function and a non-static function.
(WebCore::HTMLSelectElement::selectedIndex): ditto.
(WebCore::HTMLSelectElement::setSelectedIndexInternal):
Made this non-static, and renamed from setSelectedIndex() because
of conflict with an existing function.
(WebCore::HTMLSelectElement::optionToListIndex):
Merge a static function and a non-static function.
(WebCore::HTMLSelectElement::listToOptionIndex): ditto.
(WebCore::HTMLSelectElement::dispatchFocusEvent):
Update a callsite of function which is changed to no-staic.
(WebCore::HTMLSelectElement::dispatchBlurEvent): ditto.
(WebCore::HTMLSelectElement::deselectItemsWithoutValidation):
Made this non-static, and renamed from deselectItems() to avoid conflict.
(WebCore::HTMLSelectElement::restoreFormControlState):
Update a callsite of function which is changed to no-staic.
(WebCore::HTMLSelectElement::reset): ditto.
(WebCore::HTMLSelectElement::platformHandleKeydownEvent): Made this non-static.
(WebCore::HTMLSelectElement::menuListDefaultEventHandler): ditto.
(WebCore::HTMLSelectElement::updateSelectedState): ditto.
(WebCore::HTMLSelectElement::listBoxDefaultEventHandler): ditto.
(WebCore::HTMLSelectElement::defaultEventHandler):
Merged a static function and a non-static function.
(WebCore::HTMLSelectElement::lastSelectedListIndex): Made this non-static.
(WebCore::HTMLSelectElement::typeAheadFind): ditto.
(WebCore::HTMLSelectElement::accessKeySetSelectedIndex): ditto.
* html/HTMLSelectElement.h:
* html/HTMLSelectElementWin.cpp:
(WebCore::HTMLSelectElement::platformHandleKeydownEvent): Made this non-static.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoJSVALUE32_64 DFG JIT - Bug fix for ConvertThis
commit-queue@webkit.org [Mon, 10 Oct 2011 03:11:10 +0000 (03:11 +0000)]
JSVALUE32_64 DFG JIT - Bug fix for ConvertThis
https://bugs.webkit.org/show_bug.cgi?id=69721

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-10-09
Reviewed by Darin Adler.

* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove "near miss" XSS vulnerabilities in garden-o-matic
abarth@webkit.org [Mon, 10 Oct 2011 02:29:02 +0000 (02:29 +0000)]
Remove "near miss" XSS vulnerabilities in garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=69708

Reviewed by David Levin.

Collin Jackson did a security audit of garden-o-matic.  He hasn't found
any actual vulnerabilities yet, but he did identify a couple "near
misses" where a slight change in garden-o-matic could lead to a
vulnerability.  This patch removes those potential issues.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/Bugzilla.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97036 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCSP should log unrecognized directives to the console
abarth@webkit.org [Mon, 10 Oct 2011 01:15:21 +0000 (01:15 +0000)]
CSP should log unrecognized directives to the console
https://bugs.webkit.org/show_bug.cgi?id=69728

Reviewed by Sam Weinig.

Source/WebCore:

Several of the web developers who have been experimenting with CSP have
run into trouble with directives we don't support.  For example, one
developer was confused for a while why image-src didn't do what he
expected.  Logging a message to the console will help these folks
figure out what's going on.

* page/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::reportUnrecognizedDirective):
(WebCore::ContentSecurityPolicy::addDirective):
* page/ContentSecurityPolicy.h:

LayoutTests:

Update expected results to include new console message about unrecognized directives.

* http/tests/security/contentSecurityPolicy/directive-parsing-expected.txt:
* http/tests/security/contentSecurityPolicy/inline-script-blocked-goofy-expected.txt:
* http/tests/security/contentSecurityPolicy/inline-script-blocked-javascript-url-expected.txt:
* http/tests/security/contentSecurityPolicy/javascript-url-allowed-expected.txt:
* http/tests/security/contentSecurityPolicy/javascript-url-blocked-expected.txt:
* http/tests/security/contentSecurityPolicy/script-loads-with-img-src-expected.txt:
* http/tests/security/contentSecurityPolicy/script-src-in-iframe-expected.txt:
* http/tests/security/contentSecurityPolicy/script-src-none-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Zoom animator front-end
wjmaclean@chromium.org [Mon, 10 Oct 2011 00:21:51 +0000 (00:21 +0000)]
[chromium] Zoom animator front-end
https://bugs.webkit.org/show_bug.cgi?id=68035

Source/WebCore:

Adds necessary components to ScrollAnimatorNone to support a zoom animation
feature. Includes test infrastructure via testing/Internals to capture
in-progress texture scaling (zoom-animator-scale-test.html) as well as a
final view --- after pageScaleFactor has been applied --- in zoom-animator-scale-test2.html.

Removes temporary test fields from Settings.

Reviewed by Kenneth Russell.

Test: platform/chromium/compositing/zoom-animator-scale-test2.html

* page/EventHandler.cpp:
(WebCore::EventHandler::handleGestureEvent):
* page/FrameView.cpp:
(WebCore::FrameView::zoomAnimatorTransformChanged):
* page/FrameView.h:
* page/Settings.cpp:
(WebCore::Settings::Settings):
* page/Settings.h:
* platform/ScrollAnimator.cpp:
(WebCore::ScrollAnimator::ScrollAnimator):
(WebCore::ScrollAnimator::notifyZoomChanged):
(WebCore::ScrollAnimator::zoomTranslation):
(WebCore::ScrollAnimator::resetZoom):
(WebCore::ScrollAnimator::setZoomParametersForTest):
* platform/ScrollAnimator.h:
(WebCore::ScrollAnimator::zoomScale):
* platform/ScrollAnimatorNone.cpp:
(WebCore::ScrollAnimatorNone::ZoomData::ZoomData):
(WebCore::ScrollAnimatorNone::ZoomData::animateZoom):
(WebCore::ScrollAnimatorNone::ScrollAnimatorNone):
(WebCore::ScrollAnimatorNone::zoom):
(WebCore::ScrollAnimatorNone::handleGestureEvent):
(WebCore::ScrollAnimatorNone::animationTimerFired):
* platform/ScrollAnimatorNone.h:
* platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::zoomAnimatorTransformChanged):
* platform/ScrollableArea.h:
* testing/Internals.cpp:
(WebCore::Internals::setEnableScrollAnimator):
(WebCore::Internals::setZoomAnimatorTransform):
(WebCore::Internals::getPageScaleFactor):
(WebCore::Internals::setZoomParameters):
* testing/Internals.h:
* testing/Internals.idl:

Source/WebKit/chromium:

Modifications to get zoom texture-scale parameters from ScaleAnimator directly
instead of via Settings.

Reviewed by Kenneth Russell.

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setRootLayerNeedsDisplay):

LayoutTests:

Reviewed by Kenneth Russell.

* platform/chromium-gpu-linux/platform/chromium/compositing/zoom-animator-scale-test2-expected.png: Added.
* platform/chromium/compositing/zoom-animator-scale-test.html:
* platform/chromium/compositing/zoom-animator-scale-test2-expected.txt: Added.
* platform/chromium/compositing/zoom-animator-scale-test2.html: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove unused callOperation code of DFG JIT on X86
fpizlo@apple.com [Sun, 9 Oct 2011 22:40:01 +0000 (22:40 +0000)]
Remove unused callOperation code of DFG JIT on X86
https://bugs.webkit.org/show_bug.cgi?id=69722

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-10-09
Reviewed by Filip Pizlo.

* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::callOperation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/9484496> REGRESSION (WebKit2): Checkboxes and radio buttons are drawn...
mitz@apple.com [Sun, 9 Oct 2011 20:15:47 +0000 (20:15 +0000)]
<rdar://problem/9484496> REGRESSION (WebKit2): Checkboxes and radio buttons are drawn 1 pixel too high, not repainted properly
https://bugs.webkit.org/show_bug.cgi?id=69727

Reviewed by Anders Carlsson.

* platform/mac/ThemeMac.mm: Made WebCoreFlippedView an NSControl subclass so that the NSButtonCell
used to draw checkboxes and radio buttons can make it its controlView, and consequently check and
obey its flippedness.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97032 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoJSVALUE32_64 DFG JIT - fillJSValue with a pair of GPRs should not set the registerFor...
commit-queue@webkit.org [Sun, 9 Oct 2011 20:14:47 +0000 (20:14 +0000)]
JSVALUE32_64 DFG JIT - fillJSValue with a pair of GPRs should not set the registerFormat to be DataFormatJSDouble
https://bugs.webkit.org/show_bug.cgi?id=69720

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-10-09
Reviewed by Filip Pizlo.

In JSVALUE32_64 DFG, DataFormatJSDouble is assumed to be represented by
a FPR and will be used for further optimizations, though we currently
don't fully utilize it. For now when filling a JS value which was
spilled as a JSDouble with a pair of GPRs, we'll set the registerFormat
to DataFormatJS to avoid compilation errors.

* dfg/DFGJITCodeGenerator32_64.cpp:
(JSC::DFG::JITCodeGenerator::fillJSValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97031 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDFG should not always speculate that a ByVal access has an integer index
fpizlo@apple.com [Sun, 9 Oct 2011 20:07:36 +0000 (20:07 +0000)]
DFG should not always speculate that a ByVal access has an integer index
https://bugs.webkit.org/show_bug.cgi?id=69716

Reviewed by Oliver Hunt.

1% win on SunSpider, neutral elsewhere.

* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::callOperation):
* dfg/DFGNode.h:
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::byValHasIntBase):
(JSC::DFG::Propagator::clobbersWorld):
(JSC::DFG::Propagator::getMethodLoadElimination):
(JSC::DFG::Propagator::checkStructureLoadElimination):
(JSC::DFG::Propagator::getByOffsetLoadElimination):
(JSC::DFG::Propagator::getPropertyStorageLoadElimination):
(JSC::DFG::Propagator::performNodeCSE):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoChange bug of tap-highlight-color.html to bug 66577 and close bug 48544.
jnd@chromium.org [Sun, 9 Oct 2011 13:09:42 +0000 (13:09 +0000)]
Change bug of tap-highlight-color.html to bug 66577 and close bug 48544.
https://bugs.webkit.org/show_bug.cgi?id=48544

Unreviewed.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97027 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed weekend gardening, skip failing tests
ossy@webkit.org [Sun, 9 Oct 2011 10:39:11 +0000 (10:39 +0000)]
[Qt] Unreviewed weekend gardening, skip failing tests

* platform/qt-mac/Skipped:
* platform/qt-wk2/Skipped:
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix value profiling in 32_64 JIT
commit-queue@webkit.org [Sun, 9 Oct 2011 10:19:23 +0000 (10:19 +0000)]
Fix value profiling in 32_64 JIT
https://bugs.webkit.org/show_bug.cgi?id=69717

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-10-09
Reviewed by Filip Pizlo.

Current value profiling for 32_64 JIT is broken and cannot record
correct predicated types, which results in many speculation failures
in the 32_64 DFG JIT, fallbacks to baseline JIT, and re-optimizations
again and again.
With this fix 32_64 DFG JIT can demonstrate real performance gains.

* bytecode/ValueProfile.cpp:
(JSC::ValueProfile::computeStatistics):
* bytecode/ValueProfile.h:
(JSC::ValueProfile::classInfo):
(JSC::ValueProfile::numberOfSamples):
(JSC::ValueProfile::isLive):
(JSC::ValueProfile::numberOfInt32s):
(JSC::ValueProfile::numberOfDoubles):
(JSC::ValueProfile::numberOfBooleans):
(JSC::ValueProfile::dump):
    Empty value check should be performed on decoded JSValue,
    as for 32_64 empty value is not identical to encoded 0.
* jit/JIT.cpp:
(JSC::JIT::privateCompile):
* jit/JITInlineMethods.h:
(JSC::JIT::emitValueProfilingSite):
* jit/JITStubCall.h:
(JSC::JITStubCall::callWithValueProfiling):
    Record the right profiling result for 32_64.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97025 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed weekend gardening.
ossy@webkit.org [Sun, 9 Oct 2011 10:02:58 +0000 (10:02 +0000)]
[Qt] Unreviewed weekend gardening.

* platform/qt/fast/images/color-jpeg-with-color-profile-expected.png: Added after r96970.
* platform/qt/fast/images/color-jpeg-with-color-profile-expected.txt: Added after r96970.
* platform/qt/http/tests/security/xss-DENIED-xsl-document-securityOrigin-expected.txt: Added after r97021.
* platform/qt/svg/clip-path/clip-path-transform-1-expected.png: Added after r96712.
* platform/qt/svg/clip-path/clip-path-transform-1-expected.txt: Added after r96712.
* platform/qt/svg/clip-path/clip-path-transform-2-expected.png: Added after r96712.
* platform/qt/svg/clip-path/clip-path-transform-2-expected.txt: Added after r96712.
* platform/qt/svg/custom/grayscale-gradient-mask-2-expected.png: Added after r96470.
* platform/qt/svg/custom/grayscale-gradient-mask-2-expected.txt: Added after r96470.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDo not compare the first glyph to itself in Font::drawGlyphBuffer()
benjamin@webkit.org [Sun, 9 Oct 2011 10:00:09 +0000 (10:00 +0000)]
Do not compare the first glyph to itself in Font::drawGlyphBuffer()
https://bugs.webkit.org/show_bug.cgi?id=69715

Reviewed by Andreas Kling.

When looking for glyphs with similar properties, we should
skip the first one since the comparison of fontData
and offset will always fail.

This is covered by the existing tests.

* platform/graphics/FontFastPath.cpp:
(WebCore::Font::drawGlyphBuffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove 32 bit restrictions in DFG JIT
commit-queue@webkit.org [Sun, 9 Oct 2011 08:08:48 +0000 (08:08 +0000)]
Remove 32 bit restrictions in DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=69711

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-10-09
Reviewed by Filip Pizlo.

op_call/op_construct support was disabled for 32 bit DFG JIT because
there was regression in javascriptcore tests. Now the bugs are fixed
and there should be no regression. This makes 32 bit DFG have the same
capability as 64 bit DFG, and improves the coverage.

* dfg/DFGCapabilities.h:
(JSC::DFG::canCompileOpcode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97022 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] http/tests/security/xss-DENIED-xsl-document-securityOrigin.xml fails
commit-queue@webkit.org [Sun, 9 Oct 2011 07:23:28 +0000 (07:23 +0000)]
[Qt] http/tests/security/xss-DENIED-xsl-document-securityOrigin.xml fails
https://bugs.webkit.org/show_bug.cgi?id=69700

Patch by Sergey Glazunov <serg.glazunov@gmail.com> on 2011-10-09
Reviewed by Adam Barth.

* http/tests/security/xss-DENIED-xsl-document-securityOrigin.xml:
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97021 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMake ThreadGlobalData members use OwnPtr
jschuh@chromium.org [Sun, 9 Oct 2011 00:24:25 +0000 (00:24 +0000)]
Make ThreadGlobalData members use OwnPtr
https://bugs.webkit.org/show_bug.cgi?id=69710

Reviewed by Adam Barth.

No functional changes. No new tests required.

* platform/ThreadGlobalData.cpp:
(WebCore::ThreadGlobalData::ThreadGlobalData):
(WebCore::ThreadGlobalData::~ThreadGlobalData):
(WebCore::ThreadGlobalData::destroy):
* platform/ThreadGlobalData.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97017 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd static version of JSCell::getConstructData
mhahnenberg@apple.com [Sat, 8 Oct 2011 23:26:41 +0000 (23:26 +0000)]
Add static version of JSCell::getConstructData
https://bugs.webkit.org/show_bug.cgi?id=69673

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Added static version of getConstructData to all classes that
override it and changed the virtual versions to call the static
versions.  This is the first step in de-virtualizing JSCell::getConstructData.

* API/JSCallbackConstructor.cpp:
(JSC::JSCallbackConstructor::getConstructData):
* API/JSCallbackConstructor.h:
* API/JSCallbackObject.h:
* API/JSCallbackObjectFunctions.h:
(JSC::::getConstructData):
* runtime/ArrayConstructor.cpp:
(JSC::ArrayConstructor::getConstructData):
* runtime/ArrayConstructor.h:
* runtime/BooleanConstructor.cpp:
(JSC::BooleanConstructor::getConstructData):
* runtime/BooleanConstructor.h:
* runtime/DateConstructor.cpp:
(JSC::DateConstructor::getConstructData):
* runtime/DateConstructor.h:
* runtime/ErrorConstructor.cpp:
(JSC::ErrorConstructor::getConstructData):
* runtime/ErrorConstructor.h:
* runtime/FunctionConstructor.cpp:
(JSC::FunctionConstructor::getConstructData):
* runtime/FunctionConstructor.h:
* runtime/JSCell.cpp:
(JSC::JSCell::getConstructData):
* runtime/JSCell.h:
* runtime/JSFunction.cpp:
(JSC::JSFunction::getConstructData):
* runtime/JSFunction.h:
* runtime/NativeErrorConstructor.cpp:
(JSC::NativeErrorConstructor::getConstructData):
* runtime/NativeErrorConstructor.h:
* runtime/NumberConstructor.cpp:
(JSC::NumberConstructor::getConstructData):
* runtime/NumberConstructor.h:
* runtime/ObjectConstructor.cpp:
(JSC::ObjectConstructor::getConstructData):
* runtime/ObjectConstructor.h:
* runtime/RegExpConstructor.cpp:
(JSC::RegExpConstructor::getConstructData):
* runtime/RegExpConstructor.h:
* runtime/StringConstructor.cpp:
(JSC::StringConstructor::getConstructData):
* runtime/StringConstructor.h:

Source/WebCore:

No new tests.

Added static version of getConstructData to all classes that
override it and changed the virtual versions to call the static
versions.  This is the first step in de-virtualizing JSCell::getConstructData.

* bindings/js/JSAudioConstructor.cpp:
(WebCore::JSAudioConstructor::getConstructData):
* bindings/js/JSAudioConstructor.h:
* bindings/js/JSImageConstructor.cpp:
(WebCore::JSImageConstructor::getConstructData):
* bindings/js/JSImageConstructor.h:
* bindings/js/JSOptionConstructor.cpp:
(WebCore::JSOptionConstructor::getConstructData):
* bindings/js/JSOptionConstructor.h:
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateConstructorDeclaration):
(GenerateConstructorDefinition):
* bindings/scripts/test/JS/JSTestInterface.cpp:
(WebCore::JSTestInterfaceConstructor::getConstructData):
* bridge/runtime_object.cpp:
(JSC::Bindings::RuntimeObject::getConstructData):
* bridge/runtime_object.h:

Source/WebKit2:

Added static version of getConstructData to all classes that
override it and changed the virtual versions to call the static
versions.  This is the first step in de-virtualizing JSCell::getConstructData.

* WebProcess/Plugins/Netscape/JSNPObject.cpp:
(WebKit::JSNPObject::getConstructData):
* WebProcess/Plugins/Netscape/JSNPObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97016 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd static version of JSCell::getOwnPropertySlot
mhahnenberg@apple.com [Sat, 8 Oct 2011 21:31:32 +0000 (21:31 +0000)]
Add static version of JSCell::getOwnPropertySlot
https://bugs.webkit.org/show_bug.cgi?id=69593

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Added static version of getOwnPropertySlot to every class that overrides
JSCell::getOwnPropertySlot.  The virtual versions now call the static versions.
This is the first step in de-virtualizing JSCell::getOwnPropertySlot.

* JavaScriptCore.exp:
* debugger/DebuggerActivation.cpp:
(JSC::DebuggerActivation::getOwnPropertySlot):
* debugger/DebuggerActivation.h:
* runtime/Arguments.cpp:
(JSC::Arguments::getOwnPropertySlot):
* runtime/Arguments.h:
* runtime/ArrayConstructor.h:
* runtime/ArrayPrototype.cpp:
(JSC::ArrayPrototype::getOwnPropertySlot):
* runtime/ArrayPrototype.h:
* runtime/BooleanPrototype.cpp:
(JSC::BooleanPrototype::getOwnPropertySlot):
* runtime/BooleanPrototype.h:
* runtime/DateConstructor.cpp:
(JSC::DateConstructor::getOwnPropertySlot):
* runtime/DateConstructor.h:
* runtime/DatePrototype.cpp:
(JSC::DatePrototype::getOwnPropertySlot):
* runtime/DatePrototype.h:
* runtime/ErrorPrototype.cpp:
(JSC::ErrorPrototype::getOwnPropertySlot):
* runtime/ErrorPrototype.h:
* runtime/JSActivation.cpp:
(JSC::JSActivation::getOwnPropertySlot):
* runtime/JSActivation.h:
* runtime/JSArray.cpp:
(JSC::JSArray::getOwnPropertySlot):
* runtime/JSArray.h:
* runtime/JSBoundFunction.cpp:
(JSC::JSBoundFunction::getOwnPropertySlot):
* runtime/JSBoundFunction.h:
* runtime/JSByteArray.cpp:
(JSC::JSByteArray::getOwnPropertySlot):
* runtime/JSByteArray.h:
* runtime/JSCell.cpp:
(JSC::JSCell::getOwnPropertySlot):
* runtime/JSCell.h:
* runtime/JSFunction.cpp:
(JSC::JSFunction::getOwnPropertySlot):
* runtime/JSFunction.h:
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::getOwnPropertySlot):
* runtime/JSGlobalObject.h:
* runtime/JSNotAnObject.cpp:
(JSC::JSNotAnObject::getOwnPropertySlot):
* runtime/JSNotAnObject.h:
* runtime/JSONObject.cpp:
(JSC::JSONObject::getOwnPropertySlot):
* runtime/JSONObject.h:
* runtime/JSObject.cpp:
(JSC::JSObject::getOwnPropertySlot):
* runtime/JSObject.h:
(JSC::JSObject::getOwnPropertySlot):
* runtime/JSStaticScopeObject.cpp:
(JSC::JSStaticScopeObject::getOwnPropertySlot):
* runtime/JSStaticScopeObject.h:
* runtime/JSString.cpp:
(JSC::JSString::getOwnPropertySlot):
* runtime/JSString.h:
* runtime/MathObject.cpp:
(JSC::MathObject::getOwnPropertySlot):
* runtime/MathObject.h:
* runtime/NumberConstructor.cpp:
(JSC::NumberConstructor::getOwnPropertySlot):
* runtime/NumberConstructor.h:
* runtime/NumberPrototype.cpp:
(JSC::NumberPrototype::getOwnPropertySlot):
* runtime/NumberPrototype.h:
* runtime/ObjectConstructor.cpp:
(JSC::ObjectConstructor::getOwnPropertySlot):
* runtime/ObjectConstructor.h:
* runtime/ObjectPrototype.cpp:
(JSC::ObjectPrototype::getOwnPropertySlot):
* runtime/ObjectPrototype.h:
* runtime/RegExpConstructor.cpp:
(JSC::RegExpConstructor::getOwnPropertySlot):
* runtime/RegExpConstructor.h:
* runtime/RegExpMatchesArray.h:
(JSC::RegExpMatchesArray::getOwnPropertySlot):
* runtime/RegExpObject.cpp:
(JSC::RegExpObject::getOwnPropertySlot):
* runtime/RegExpObject.h:
* runtime/RegExpPrototype.cpp:
(JSC::RegExpPrototype::getOwnPropertySlot):
* runtime/RegExpPrototype.h:
* runtime/StringConstructor.cpp:
(JSC::StringConstructor::getOwnPropertySlot):
* runtime/StringConstructor.h:
* runtime/StringObject.cpp:
(JSC::StringObject::getOwnPropertySlot):
* runtime/StringObject.h:
* runtime/StringPrototype.cpp:
(JSC::StringPrototype::getOwnPropertySlot):
* runtime/StringPrototype.h:

Source/JavaScriptGlue:

Added static version of getOwnPropertySlot to every class that overrides
JSCell::getOwnPropertySlot.  The virtual versions now call the static versions.
This is the first step in de-virtualizing JSCell::getOwnPropertySlot.

* UserObjectImp.cpp:
(UserObjectImp::getOwnPropertySlot):
* UserObjectImp.h:

Source/WebCore:

No new tests.

Added static version of getOwnPropertySlot to every class that overrides
JSCell::getOwnPropertySlot.  The virtual versions now call the static versions.
This is the first step in de-virtualizing JSCell::getOwnPropertySlot.

* bindings/js/JSDOMWindowShell.cpp:
(WebCore::JSDOMWindowShell::getOwnPropertySlot):
* bindings/js/JSDOMWindowShell.h:
* bridge/objc/objc_runtime.h:
* bridge/objc/objc_runtime.mm:
(JSC::Bindings::ObjcFallbackObjectImp::getOwnPropertySlot):
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::QtRuntimeMetaMethod::getOwnPropertySlot):
(JSC::Bindings::QtRuntimeConnectionMethod::getOwnPropertySlot):
* bridge/qt/qt_runtime.h:
* bridge/runtime_array.cpp:
(JSC::RuntimeArray::getOwnPropertySlot):
* bridge/runtime_array.h:
* bridge/runtime_method.cpp:
(JSC::RuntimeMethod::getOwnPropertySlot):
* bridge/runtime_method.h:
* bridge/runtime_object.cpp:
(JSC::Bindings::RuntimeObject::getOwnPropertySlot):
* bridge/runtime_object.h:

Source/WebKit2:

Added static version of getOwnPropertySlot to every class that overrides
JSCell::getOwnPropertySlot.  The virtual versions now call the static versions.
This is the first step in de-virtualizing JSCell::getOwnPropertySlot.

* WebProcess/Plugins/Netscape/JSNPObject.cpp:
(WebKit::JSNPObject::getOwnPropertySlot):
* WebProcess/Plugins/Netscape/JSNPObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97015 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoJSVALUE32_64 DFG JIT - GetLocal should produce a cell result for Array predictions
commit-queue@webkit.org [Sat, 8 Oct 2011 20:42:13 +0000 (20:42 +0000)]
JSVALUE32_64 DFG JIT - GetLocal should produce a cell result for Array predictions
https://bugs.webkit.org/show_bug.cgi?id=69699

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-10-08
Reviewed by Filip Pizlo.

It should match SetLocal where only payload is stored for array predictions.

* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97014 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoJSVALUE32_64 DFG JIT - Bug fixes for Branch and LogicalNot
commit-queue@webkit.org [Sat, 8 Oct 2011 20:40:03 +0000 (20:40 +0000)]
JSVALUE32_64 DFG JIT - Bug fixes for Branch and LogicalNot
https://bugs.webkit.org/show_bug.cgi?id=69702

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-10-08
Reviewed by Filip Pizlo.

There are some errors in generating code for Branch and LogicalNot,
when the operand is predicted as ObjectOrOther.

* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compileObjectOrOtherLogicalNot):
(JSC::DFG::SpeculativeJIT::emitObjectOrOtherBranch):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97013 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Implement drag and drop support in WebKit2
mrobinson@webkit.org [Sat, 8 Oct 2011 17:46:00 +0000 (17:46 +0000)]
[GTK] Implement drag and drop support in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=63706

Reviewed by Philippe Normand.

Source/WebCore:

* platform/DragData.h:
* platform/gtk/DataObjectGtk.cpp:
(WebCore::DataObjectGtk::text): Mark as const.
(WebCore::DataObjectGtk::markup): Ditto.
(WebCore::DataObjectGtk::urlLabel): Ditto.
* platform/gtk/DataObjectGtk.h: Remove unused member
m_dragContext.
(WebCore::DataObjectGtk::url): Mark as const.
(WebCore::DataObjectGtk::uriList): Ditto.
(WebCore::DataObjectGtk::filenames): Ditto.
(WebCore::DataObjectGtk::image): Ditto.
(WebCore::DataObjectGtk::hasText): Ditto.
(WebCore::DataObjectGtk::hasMarkup): Ditto.
(WebCore::DataObjectGtk::hasURIList): Ditto.
(WebCore::DataObjectGtk::hasURL): Ditto.
(WebCore::DataObjectGtk::hasFilenames): Ditto.
(WebCore::DataObjectGtk::hasImage): Ditto.
* platform/gtk/DragIcon.cpp: Added. A helper which takes care of
creating a transparent drag window for drags.
* platform/gtk/DragIcon.h: Added.

Source/WebKit2:

* GNUmakefile.am: Add new files to compilation.
* Shared/gtk/ArgumentCodersGtk.cpp: Added.
(CoreIPC::encodeImage): Encode a GdkPixbuf.
(CoreIPC::decodeImage): Decode a GdkPixbuf.
(CoreIPC::encodeDataObject): Encode a DataObjectGtk.
(CoreIPC::decodeDataObject): Decode a DataObjectGtk.
(CoreIPC::::encode): Encode DragData.
(CoreIPC::::decode): Decode DragData.
* Shared/gtk/ArgumentCodersGtk.h:
* UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::startDrag):
* UIProcess/API/gtk/PageClientImpl.h:
* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkit_web_view_base_init): Set the view as a potential drop destination.
(webkitWebViewBaseDragDataGet): Added, delegate to GtkDragAndDropHelper.
(webkitWebViewBaseDragEnd): Ditto.
(webkitWebViewBaseDragDataReceived): Ditto.
(webkitWebViewBaseDragEnter): Ditto.
(webkitWebViewBaseDragMotion): Ditto.
(doDragLeaveLater): Ditto.
(webkitWebViewBaseDragLeave): Ditto.
(webkitWebViewBaseDragDrop): Ditto.
(webkit_web_view_base_class_init): Override GtkWidget drag and drop methods.
(webkitWebViewBaseStartDrag): Calls gtk_drag_begin() to start a drag operation.
* UIProcess/API/gtk/WebKitWebViewBasePrivate.h: Add webkitWebViewBaseStartDrag().
* UIProcess/PageClient.h: Add startDrag().
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::performDragControllerAction): Share the Qt version.
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* WebProcess/WebCoreSupport/WebDragClient.cpp:
* WebProcess/WebCoreSupport/gtk/WebDragClientGtk.cpp: Added.
* WebProcess/WebPage/WebPage.cpp: Add drag support for GTK+.
* WebProcess/WebPage/WebPage.h: Ditto.
* WebProcess/WebPage/WebPage.messages.in: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[WK2] Update Skipped file
qi.2.zhang@nokia.com [Sat, 8 Oct 2011 16:12:10 +0000 (16:12 +0000)]
[WK2] Update Skipped file
https://bugs.webkit.org/show_bug.cgi?id=69650

Reviewed by Andreas Kling.

Unskip passed ApplicationCache test cases.

* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] [WK2] Wrong handling of visibility in QTouchWebPage
commit-queue@webkit.org [Sat, 8 Oct 2011 15:37:23 +0000 (15:37 +0000)]
[Qt] [WK2] Wrong handling of visibility in QTouchWebPage
https://bugs.webkit.org/show_bug.cgi?id=69670

Patch by Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com> on 2011-10-08
Reviewed by Andreas Kling.

Replace QTouchWebPage visibility handling by Show/Hide events with use of
QSGItem::visibleChanged signal.

* UIProcess/API/qt/qtouchwebpage.cpp:
(QTouchWebPage::QTouchWebPage):
(QTouchWebPage::event):
(QTouchWebPage::onVisibleChanged):
* UIProcess/API/qt/qtouchwebpage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd support for ADDRESS_SANITIZER in RenderArena
inferno@chromium.org [Sat, 8 Oct 2011 14:19:36 +0000 (14:19 +0000)]
Add support for ADDRESS_SANITIZER in RenderArena
allocate, free calls.
https://bugs.webkit.org/show_bug.cgi?id=69636

Reviewed by Darin Adler.

Use malloc, free directly without using the debug header. Otherwise,
we won't be able to detect out of bounds access in debug header.

* rendering/RenderArena.cpp:
(WebCore::RenderArena::allocate):
(WebCore::RenderArena::free):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed weekend gardening.
ossy@webkit.org [Sat, 8 Oct 2011 13:10:20 +0000 (13:10 +0000)]
[Qt] Unreviewed weekend gardening.

* platform/qt-4.8/editing/deleting/merge-whitespace-pre-expected.txt: Updated after 96886.
* platform/qt/Skipped: Skip http/tests/security/xss-DENIED-xsl-document-securityOrigin.xml - http://webkit.org/b/69700
* platform/qt/fast/css/text-transform-select-expected.png: Added after r96987.
* platform/qt/fast/css/text-transform-select-expected.txt: Added after r96987.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97008 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove some static functions of HTMLSelectElement
tkent@chromium.org [Sat, 8 Oct 2011 09:05:18 +0000 (09:05 +0000)]
Remove some static functions of HTMLSelectElement
https://bugs.webkit.org/show_bug.cgi?id=69621

Reviewed by Darin Adler.

Merge a static function and the corresponding non-static member function
into one function if there are no other callers of the static function.

No new tests, just a refactoring.

* html/HTMLFormControlElement.h:
Make formControlName() protected because it is called from
HTMLSelectElement.
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::parseMappedAttribute):
Remove two argument of parseMultipleAttribute().
(WebCore::HTMLSelectElement::selectAll):
Merged the static function and the member function.
(WebCore::HTMLSelectElement::dispatchFocusEvent): ditto.
(WebCore::HTMLSelectElement::dispatchBlurEvent): ditto.
(WebCore::HTMLSelectElement::saveFormControlState): ditto.
(WebCore::HTMLSelectElement::restoreFormControlState):
(WebCore::HTMLSelectElement::parseMultipleAttribute):
 - Make this non-static member function.
 - Use reattachIfAttached().
(WebCore::HTMLSelectElement::appendFormData): Merged.
(WebCore::HTMLSelectElement::reset): ditto.
(WebCore::HTMLSelectElement::insertedIntoTree): ditto.
(WebCore::HTMLSelectElement::accessKeySetSelectedIndex): ditto.
(WebCore::HTMLSelectElement::length): Merged with optionCount().
* html/HTMLSelectElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r96996.
commit-queue@webkit.org [Sat, 8 Oct 2011 08:54:57 +0000 (08:54 +0000)]
Unreviewed, rolling out r96996.
http://trac.webkit.org/changeset/96996
https://bugs.webkit.org/show_bug.cgi?id=69697

It broke all tests on the Qt bot (Requested by Ossy_night on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-08

Source/JavaScriptCore:

* API/JSCallbackFunction.cpp:
(JSC::JSCallbackFunction::getCallDataVirtual):
* API/JSCallbackFunction.h:
* API/JSCallbackObject.h:
* API/JSCallbackObjectFunctions.h:
(JSC::::getCallDataVirtual):
* API/JSObjectRef.cpp:
(JSObjectIsFunction):
(JSObjectCallAsFunction):
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/ArrayConstructor.cpp:
(JSC::ArrayConstructor::getCallDataVirtual):
* runtime/ArrayConstructor.h:
* runtime/BooleanConstructor.cpp:
(JSC::BooleanConstructor::getCallDataVirtual):
* runtime/BooleanConstructor.h:
* runtime/DateConstructor.cpp:
(JSC::DateConstructor::getCallDataVirtual):
* runtime/DateConstructor.h:
* runtime/Error.cpp:
(JSC::StrictModeTypeErrorFunction::StrictModeTypeErrorFunction):
(JSC::StrictModeTypeErrorFunction::create):
(JSC::StrictModeTypeErrorFunction::constructThrowTypeError):
(JSC::StrictModeTypeErrorFunction::getConstructData):
(JSC::StrictModeTypeErrorFunction::callThrowTypeError):
(JSC::StrictModeTypeErrorFunction::getCallDataVirtual):
(JSC::StrictModeTypeErrorFunction::getCallData):
(JSC::StrictModeTypeErrorFunction::createStructure):
(JSC::createTypeErrorFunction):
* runtime/Error.h:
* runtime/ErrorConstructor.cpp:
(JSC::ErrorConstructor::getCallDataVirtual):
* runtime/ErrorConstructor.h:
* runtime/FunctionConstructor.cpp:
(JSC::FunctionConstructor::getCallDataVirtual):
* runtime/FunctionConstructor.h:
* runtime/FunctionPrototype.cpp:
(JSC::FunctionPrototype::getCallDataVirtual):
* runtime/FunctionPrototype.h:
* runtime/InternalFunction.cpp:
(JSC::InternalFunction::finishCreation):
* runtime/InternalFunction.h:
* runtime/JSCell.cpp:
(JSC::JSCell::getCallDataVirtual):
* runtime/JSCell.h:
(JSC::getCallData):
* runtime/JSFunction.cpp:
(JSC::JSFunction::getCallDataVirtual):
* runtime/JSFunction.h:
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
(JSC::JSGlobalObject::visitChildren):
* runtime/JSGlobalObject.h:
* runtime/JSONObject.cpp:
(JSC::Stringifier::Stringifier):
(JSC::Stringifier::toJSON):
(JSC::Stringifier::appendStringifiedValue):
* runtime/JSObject.cpp:
(JSC::JSObject::put):
* runtime/JSObject.h:
* runtime/NativeErrorConstructor.cpp:
(JSC::NativeErrorConstructor::getCallDataVirtual):
* runtime/NativeErrorConstructor.h:
* runtime/NumberConstructor.cpp:
(JSC::NumberConstructor::getCallDataVirtual):
* runtime/NumberConstructor.h:
* runtime/ObjectConstructor.cpp:
(JSC::ObjectConstructor::getCallDataVirtual):
* runtime/ObjectConstructor.h:
* runtime/Operations.cpp:
(JSC::jsTypeStringForValue):
(JSC::jsIsObjectType):
(JSC::jsIsFunctionType):
* runtime/PropertySlot.cpp:
(JSC::PropertySlot::functionGetter):
* runtime/RegExpConstructor.cpp:
(JSC::RegExpConstructor::getCallDataVirtual):
* runtime/RegExpConstructor.h:
* runtime/StringConstructor.cpp:
(JSC::StringConstructor::getCallDataVirtual):
* runtime/StringConstructor.h:
* runtime/Structure.h:

Source/JavaScriptGlue:

* JSValueWrapper.cpp:
(JSValueWrapper::JSObjectCallFunction):
* UserObjectImp.cpp:
(UserObjectImp::getCallDataVirtual):
* UserObjectImp.h:

Source/WebCore:

* WebCore.exp.in:
* bindings/js/JSCallbackData.cpp:
(WebCore::JSCallbackData::invokeCallback):
* bindings/js/JSCustomXPathNSResolver.cpp:
(WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
* bindings/js/JSErrorHandler.cpp:
(WebCore::JSErrorHandler::handleEvent):
* bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::handleEvent):
* bindings/js/JSHTMLAllCollectionCustom.cpp:
(WebCore::JSHTMLAllCollection::getCallDataVirtual):
* bindings/js/JSHTMLAppletElementCustom.cpp:
(WebCore::JSHTMLAppletElement::getCallDataVirtual):
* bindings/js/JSHTMLEmbedElementCustom.cpp:
(WebCore::JSHTMLEmbedElement::getCallDataVirtual):
* bindings/js/JSHTMLObjectElementCustom.cpp:
(WebCore::JSHTMLObjectElement::getCallDataVirtual):
* bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::JSInjectedScriptHost::evaluate):
* bindings/js/JSPluginElementFunctions.cpp:
(WebCore::runtimeObjectGetCallData):
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
* bridge/objc/objc_runtime.h:
* bridge/objc/objc_runtime.mm:
(JSC::Bindings::ObjcFallbackObjectImp::getCallDataVirtual):
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::QtRuntimeMetaMethod::getCallDataVirtual):
(JSC::Bindings::QtRuntimeConnectionMethod::call):
(JSC::Bindings::QtRuntimeConnectionMethod::getCallDataVirtual):
(JSC::Bindings::isJavaScriptFunction):
* bridge/qt/qt_runtime.h:
* bridge/runtime_method.cpp:
(JSC::RuntimeMethod::getCallDataVirtual):
* bridge/runtime_method.h:
* bridge/runtime_object.cpp:
(JSC::Bindings::RuntimeObject::getCallDataVirtual):
* bridge/runtime_object.h:

Source/WebKit/mac:

* Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::invokeDefault):

Source/WebKit2:

* WebProcess/Plugins/Netscape/JSNPMethod.cpp:
(WebKit::JSNPMethod::getCallDataVirtual):
* WebProcess/Plugins/Netscape/JSNPMethod.h:
* WebProcess/Plugins/Netscape/JSNPObject.cpp:
(WebKit::JSNPObject::getCallDataVirtual):
* WebProcess/Plugins/Netscape/JSNPObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDFG JIT - only Array predictions can result in unboxed cells in register file
fpizlo@apple.com [Sat, 8 Oct 2011 08:15:53 +0000 (08:15 +0000)]
DFG JIT - only Array predictions can result in unboxed cells in register file
https://bugs.webkit.org/show_bug.cgi?id=69695

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-10-08
Reviewed by Filip Pizlo.

In current DFG JIT, only array predictions can result in unboxed cells
in register file, not for the other cell predictions.

* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::ValueSource::forPrediction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSnow Leopard build fix after r96976. Apparently we just need a full rebuild.
rniwa@webkit.org [Sat, 8 Oct 2011 07:31:44 +0000 (07:31 +0000)]
Snow Leopard build fix after r96976. Apparently we just need a full rebuild.

* config.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agobug fixes for ArrayPush and ArrayPop in 32_64 DFG JIT
commit-queue@webkit.org [Sat, 8 Oct 2011 07:04:06 +0000 (07:04 +0000)]
bug fixes for ArrayPush and ArrayPop in 32_64 DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=69696

Patch by Yuqiang Xian <yuqiang.xian@intel.com> on 2011-10-07
Reviewed by Filip Pizlo.

On 32-bit, we should use TimesEight (8) instead of ScalePtr (4)
to compute the address of a JS array element.

* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd static version of JSCell::deleteProperty
mhahnenberg@apple.com [Sat, 8 Oct 2011 06:37:45 +0000 (06:37 +0000)]
Add static version of JSCell::deleteProperty
https://bugs.webkit.org/show_bug.cgi?id=69659

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Added static version of both versions of put to all classes that
override them and changed the virtual versions to call the static
versions.  This is the first step in de-virtualizing JSCell::deleteProperty.

* API/JSCallbackObject.h:
* API/JSCallbackObjectFunctions.h:
(JSC::::deleteProperty):
* debugger/DebuggerActivation.cpp:
(JSC::DebuggerActivation::deleteProperty):
* debugger/DebuggerActivation.h:
* runtime/Arguments.cpp:
(JSC::Arguments::deleteProperty):
* runtime/Arguments.h:
* runtime/JSActivation.cpp:
(JSC::JSActivation::deleteProperty):
* runtime/JSActivation.h:
* runtime/JSArray.cpp:
(JSC::JSArray::deleteProperty):
* runtime/JSArray.h:
* runtime/JSCell.cpp:
(JSC::JSCell::deleteProperty):
* runtime/JSCell.h:
* runtime/JSFunction.cpp:
(JSC::JSFunction::deleteProperty):
* runtime/JSFunction.h:
* runtime/JSNotAnObject.cpp:
(JSC::JSNotAnObject::deleteProperty):
* runtime/JSNotAnObject.h:
* runtime/JSObject.cpp:
(JSC::JSObject::deleteProperty):
* runtime/JSObject.h:
* runtime/JSVariableObject.cpp:
(JSC::JSVariableObject::deleteProperty):
* runtime/JSVariableObject.h:
* runtime/RegExpMatchesArray.h:
(JSC::RegExpMatchesArray::deleteProperty):
* runtime/StrictEvalActivation.cpp:
(JSC::StrictEvalActivation::deleteProperty):
* runtime/StrictEvalActivation.h:
* runtime/StringObject.cpp:
(JSC::StringObject::deleteProperty):
* runtime/StringObject.h:

Source/WebCore:

No new tests.

Added static version of both versions of put to all classes that
override them and changed the virtual versions to call the static
versions.  This is the first step in de-virtualizing JSCell::deleteProperty.

* bridge/objc/objc_runtime.h:
* bridge/objc/objc_runtime.mm:
(JSC::Bindings::ObjcFallbackObjectImp::deleteProperty):
* bridge/runtime_array.cpp:
(JSC::RuntimeArray::deleteProperty):
* bridge/runtime_array.h:
* bridge/runtime_object.cpp:
(JSC::Bindings::RuntimeObject::deleteProperty):
* bridge/runtime_object.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[JSC]Two tests fails after r95489 & r95488
rniwa@webkit.org [Sat, 8 Oct 2011 05:37:52 +0000 (05:37 +0000)]
[JSC]Two tests fails after r95489 & r95488
https://bugs.webkit.org/show_bug.cgi?id=68428

Move V8-specific results to Chromium and put JSC result in cross-platform directory.
Also unskip the tests on Mac.

* http/tests/security/document-all-expected.txt:
* http/tests/security/window-named-proto-expected.txt:
* platform/chromium/http/tests/security/document-all-expected.txt: Copied from
LayoutTests/http/tests/security/document-all-expected.txt.
* platform/chromium/http/tests/security/window-named-proto-expected.txt: Copied from
LayoutTests/http/tests/security/window-named-proto-expected.txt.
* platform/gtk/http/tests/security/document-all-expected.txt: Removed.
* platform/gtk/http/tests/security/window-named-proto-expected.txt: Removed.
* platform/mac/Skipped:
* platform/qt/http/tests/security/document-all-expected.txt: Removed.
* platform/qt/http/tests/security/window-named-proto-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd WKPageContextMenuClient callback when context menu is dismissed
jeffm@apple.com [Sat, 8 Oct 2011 02:46:20 +0000 (02:46 +0000)]
Add WKPageContextMenuClient callback when context menu is dismissed
https://bugs.webkit.org/show_bug.cgi?id=69553

Add contextMenuDismissed callback to WKPageContextMenuClient, and bump the API
version of this client to 1 so we continue to work with old clients.

* Shared/APIClientTraits.cpp: Added array of interface sizes for WKPageContextMenuClient.
* Shared/APIClientTraits.h: Added APIClientTraits for WKPageContextMenuClient.

* UIProcess/API/C/WKPage.h: Added contextMenuDismissed callback to WKPageContextMenuClient and bumped kWKPageContextMenuClientCurrentVersion.

* UIProcess/WebPageContextMenuClient.cpp:
(WebKit::WebPageContextMenuClient::contextMenuDismissed): Added.

* UIProcess/WebPageContextMenuClient.h: Added WebPageContextMenuClient::contextMenuDismissed().

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::internalShowContextMenu): Notify client when context menu is dismissed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@97000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMake isXMLMIMEType regex use TLS
jschuh@chromium.org [Sat, 8 Oct 2011 02:22:21 +0000 (02:22 +0000)]
Make isXMLMIMEType regex use TLS
https://bugs.webkit.org/show_bug.cgi?id=69665

Reviewed by Adam Barth.

Source/WebCore:

Test: fast/workers/worker-multi-startup.html

* dom/DOMImplementation.cpp:
(WebCore::XMLMIMETypeRegExp::XMLMIMETypeRegExp):
(WebCore::XMLMIMETypeRegExp::~XMLMIMETypeRegExp):
(WebCore::XMLMIMETypeRegExp::isXMLMIMEType):
(WebCore::DOMImplementation::isXMLMIMEType):
* dom/DOMImplementation.h:
* platform/ThreadGlobalData.cpp:
(WebCore::ThreadGlobalData::ThreadGlobalData):
(WebCore::ThreadGlobalData::destroy):
* platform/ThreadGlobalData.h:
(WebCore::ThreadGlobalData::xmlTypeRegExp):

LayoutTests:

* fast/workers/worker-multi-startup-expected.txt: Added.
* fast/workers/worker-multi-startup.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Allow failure of another Mac Skia test.
simonjam@chromium.org [Sat, 8 Oct 2011 02:08:11 +0000 (02:08 +0000)]
[Chromium] Allow failure of another Mac Skia test.

Unreviewed.

* platform/chromium/test_expectations.txt: Added first-of-type-pseudo-class.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r96847.
commit-queue@webkit.org [Sat, 8 Oct 2011 02:01:51 +0000 (02:01 +0000)]
Unreviewed, rolling out r96847.
http://trac.webkit.org/changeset/96847
https://bugs.webkit.org/show_bug.cgi?id=69684

may have caused memory regression on win chromium (Requested
by simonjam on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-07

* platform/graphics/chromium/FontChromiumWin.cpp:
(WebCore::Font::drawGlyphs):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove getCallDataVirtual methods
mhahnenberg@apple.com [Sat, 8 Oct 2011 01:44:10 +0000 (01:44 +0000)]
Remove getCallDataVirtual methods
https://bugs.webkit.org/show_bug.cgi?id=69186

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Removed all getCallDataVirtual methods and replaced their call sites
with an explicit lookup in the MethodTable.

* API/JSCallbackFunction.cpp:
* API/JSCallbackFunction.h:
* API/JSCallbackObject.h:
* API/JSCallbackObjectFunctions.h:
* API/JSObjectRef.cpp:
(JSObjectIsFunction):
(JSObjectCallAsFunction):
* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/ArrayConstructor.cpp:
* runtime/ArrayConstructor.h:
* runtime/BooleanConstructor.cpp:
* runtime/BooleanConstructor.h:
* runtime/DateConstructor.cpp:
* runtime/DateConstructor.h:
* runtime/Error.cpp:
(JSC::createTypeErrorFunction):

Moved StrictModeTypeErrorFunction to Error.h in order to be able to include
the class definition in JSGlobalObject.cpp.
* runtime/Error.h:
(JSC::StrictModeTypeErrorFunction::StrictModeTypeErrorFunction):
(JSC::StrictModeTypeErrorFunction::create):
(JSC::StrictModeTypeErrorFunction::constructThrowTypeError):
(JSC::StrictModeTypeErrorFunction::getConstructData):
(JSC::StrictModeTypeErrorFunction::callThrowTypeError):
(JSC::StrictModeTypeErrorFunction::getCallData):
(JSC::StrictModeTypeErrorFunction::createStructure):
* runtime/ErrorConstructor.cpp:
* runtime/ErrorConstructor.h:
* runtime/FunctionConstructor.cpp:
* runtime/FunctionConstructor.h:
* runtime/FunctionPrototype.cpp:
* runtime/FunctionPrototype.h:

To allow subclasses of InternalFunction (e.g. QtRuntimeMethod) to not have
to declare their own ClassInfo if they don't override getCallData, provided
an implementation that calls ASSERT_NOT_REACHED if called, providing roughly the same
functionality as of the pure virtual method InternalFunction used to have.
Also made this new implementation protected rather than private for the same reason.
Also added an ASSERT in InternalFunction::finishCreation to make sure that whatever
object is being created provides their own implementation of getCallData.  This
just makes execution fail earlier in a place where the source of the error is
easy to trace.  These ASSERTs are better than putting a null in the MethodTable because
they appear much more intentional to anybody who fails to provide their own
implementation or who tries to explicitly call InternalFunction::getCallData.
* runtime/InternalFunction.cpp:
(JSC::InternalFunction::finishCreation):
(JSC::InternalFunction::getCallData):
* runtime/InternalFunction.h:
* runtime/JSCell.cpp:
* runtime/JSCell.h:
* runtime/JSFunction.cpp:
* runtime/JSFunction.h:

Added a global structure to JSGlobalObject for StrictModeTypeErrorFunction to enable
it to be reused rather than creating a new Structure every time we instantiate it.
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
(JSC::JSGlobalObject::visitChildren):
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::strictModeTypeErrorFunctionStructure):
* runtime/JSONObject.cpp:
(JSC::Stringifier::Stringifier):
(JSC::Stringifier::toJSON):
(JSC::Stringifier::appendStringifiedValue):
* runtime/JSObject.cpp:
(JSC::JSObject::put):
* runtime/JSObject.h:
(JSC::getCallData):
* runtime/NativeErrorConstructor.cpp:
* runtime/NativeErrorConstructor.h:
* runtime/NumberConstructor.cpp:
* runtime/NumberConstructor.h:
* runtime/ObjectConstructor.cpp:
* runtime/ObjectConstructor.h:
* runtime/Operations.cpp:
(JSC::jsTypeStringForValue):
(JSC::jsIsObjectType):
(JSC::jsIsFunctionType):
* runtime/PropertySlot.cpp:
(JSC::PropertySlot::functionGetter):
* runtime/RegExpConstructor.cpp:
* runtime/RegExpConstructor.h:
* runtime/StringConstructor.cpp:
* runtime/StringConstructor.h:
* runtime/Structure.h:

Source/JavaScriptGlue:

Removed all getCallDataVirtual methods and replaced their call sites
with an explicit lookup in the MethodTable.

* JSValueWrapper.cpp:
(JSValueWrapper::JSObjectCallFunction):
* UserObjectImp.cpp:
* UserObjectImp.h:

Source/WebCore:

No new tests.

Removed all getCallDataVirtual methods and replaced their call sites
with an explicit lookup in the MethodTable.

* WebCore.exp.in:
* bindings/js/JSCallbackData.cpp:
(WebCore::JSCallbackData::invokeCallback):
* bindings/js/JSCustomXPathNSResolver.cpp:
(WebCore::JSCustomXPathNSResolver::lookupNamespaceURI):
* bindings/js/JSErrorHandler.cpp:
(WebCore::JSErrorHandler::handleEvent):
* bindings/js/JSEventListener.cpp:
(WebCore::JSEventListener::handleEvent):
* bindings/js/JSHTMLAllCollectionCustom.cpp:
* bindings/js/JSHTMLAppletElementCustom.cpp:
* bindings/js/JSHTMLEmbedElementCustom.cpp:
* bindings/js/JSHTMLObjectElementCustom.cpp:
* bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::JSInjectedScriptHost::evaluate):
* bindings/js/JSPluginElementFunctions.cpp:
(WebCore::runtimeObjectGetCallData):
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
* bridge/objc/objc_runtime.h:
* bridge/objc/objc_runtime.mm:
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::QtRuntimeConnectionMethod::call):
(JSC::Bindings::isJavaScriptFunction):
* bridge/qt/qt_runtime.h:
(JSC::Bindings::QtRuntimeMetaMethod::createStructure):
(JSC::Bindings::QtRuntimeConnectionMethod::createStructure):
* bridge/runtime_method.cpp:
* bridge/runtime_method.h:
* bridge/runtime_object.cpp:
* bridge/runtime_object.h:

Source/WebKit/mac:

Removed all getCallDataVirtual methods and replaced their call sites
with an explicit lookup in the MethodTable.

* Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::invokeDefault):

Source/WebKit2:

Removed all getCallDataVirtual methods and replaced their call sites
with an explicit lookup in the MethodTable.

* WebProcess/Plugins/Netscape/JSNPMethod.cpp:
* WebProcess/Plugins/Netscape/JSNPMethod.h:
* WebProcess/Plugins/Netscape/JSNPObject.cpp:
* WebProcess/Plugins/Netscape/JSNPObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd missing break statement.
oliver@apple.com [Sat, 8 Oct 2011 00:43:58 +0000 (00:43 +0000)]
Add missing break statement.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[WinCairo] Unreviewed Skiplist update to get bot green.
bfulgham@webkit.org [Sat, 8 Oct 2011 00:41:11 +0000 (00:41 +0000)]
[WinCairo] Unreviewed Skiplist update to get bot green.

* platform/wincairo/Skipped: Turn off a few more tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSupport some string intrinsics in the DFG JIT
oliver@apple.com [Sat, 8 Oct 2011 00:06:51 +0000 (00:06 +0000)]
Support some string intrinsics in the DFG JIT
https://bugs.webkit.org/show_bug.cgi?id=69678

Reviewed by Gavin Barraclough.

Add support for charAt and charCodeAt intrinsics in the DFG.

* create_hash_table:
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleIntrinsic):
* dfg/DFGIntrinsic.h:
* dfg/DFGNode.h:
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::performNodeCSE):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileGetCharCodeAt):
* dfg/DFGSpeculativeJIT.h:
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd static version of JSCell::put
mhahnenberg@apple.com [Sat, 8 Oct 2011 00:06:07 +0000 (00:06 +0000)]
Add static version of JSCell::put
https://bugs.webkit.org/show_bug.cgi?id=69382

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Added static version of both versions of put to all classes that
override them and changed the virtual versions to call the static
versions.

* API/JSCallbackObject.h:
* API/JSCallbackObjectFunctions.h:
(JSC::::put):
* JavaScriptCore.exp:
* debugger/DebuggerActivation.cpp:
(JSC::DebuggerActivation::put):
* debugger/DebuggerActivation.h:
* runtime/Arguments.cpp:
(JSC::Arguments::put):
* runtime/Arguments.h:
* runtime/JSActivation.cpp:
(JSC::JSActivation::put):
* runtime/JSActivation.h:
* runtime/JSArray.cpp:
(JSC::JSArray::put):
* runtime/JSArray.h:
* runtime/JSByteArray.cpp:
(JSC::JSByteArray::put):
* runtime/JSByteArray.h:
* runtime/JSCell.cpp:
(JSC::JSCell::put):
* runtime/JSCell.h:
* runtime/JSFunction.cpp:
(JSC::JSFunction::put):
* runtime/JSFunction.h:
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::put):
* runtime/JSGlobalObject.h:
* runtime/JSNotAnObject.cpp:
(JSC::JSNotAnObject::put):
* runtime/JSNotAnObject.h:
* runtime/JSObject.cpp:
(JSC::JSObject::put):
* runtime/JSObject.h:
* runtime/JSStaticScopeObject.cpp:
(JSC::JSStaticScopeObject::put):
* runtime/JSStaticScopeObject.h:
* runtime/ObjectPrototype.cpp:
(JSC::ObjectPrototype::put):
* runtime/ObjectPrototype.h:
* runtime/RegExpConstructor.cpp:
(JSC::RegExpConstructor::put):
* runtime/RegExpConstructor.h:
* runtime/RegExpMatchesArray.h:
(JSC::RegExpMatchesArray::put):
* runtime/RegExpObject.cpp:
(JSC::RegExpObject::put):
* runtime/RegExpObject.h:
* runtime/StringObject.cpp:
(JSC::StringObject::put):
* runtime/StringObject.h:

Source/JavaScriptGlue:

Added static version of both versions of put to all classes that
override them and changed the virtual versions to call the static
versions.

* UserObjectImp.cpp:
(UserObjectImp::put):
* UserObjectImp.h:

Source/WebCore:

No new tests.

Added static version of both versions of put to all classes that
override them and changed the virtual versions to call the static
versions.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::JSTestObj::put):
* bindings/scripts/test/JS/JSTestObj.h:
* bridge/objc/objc_runtime.h:
* bridge/objc/objc_runtime.mm:
(JSC::Bindings::ObjcFallbackObjectImp::put):
* bridge/runtime_array.cpp:
(JSC::RuntimeArray::put):
* bridge/runtime_array.h:
* bridge/runtime_object.cpp:
(JSC::Bindings::RuntimeObject::put):
* bridge/runtime_object.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago https://bugs.webkit.org/show_bug.cgi?id=69471
commit-queue@webkit.org [Fri, 7 Oct 2011 23:58:42 +0000 (23:58 +0000)]
 https://bugs.webkit.org/show_bug.cgi?id=69471

 We now wrap the window script NPObject which is requested by NPAPI plugins for
 scripting. The wrapped NPObject pointer maintains a weak reference to the
 window script NPObject and is cleared out when the window script object is destroyed.
 The NPObject wrapper is destroyed when the last outstanding reference is released.

 Reviewed by Nate Chapin.

 No tests added as there is no change in functionality.

Patch by Anantanarayanan G Iyengar <ananta@chromium.org> on 2011-10-07

* WebCore.gypi:
* bindings/v8/NPObjectWrapper.cpp: Added.
(WebCore::NPObjectWrapper::NPObjectWrapper):
(WebCore::NPObjectWrapper::create):
(WebCore::NPObjectWrapper::clear):
(WebCore::NPObjectWrapper::getWrapper):
(WebCore::NPObjectWrapper::getUnderlyingNPObject):
(WebCore::NPObjectWrapper::getObjectForCall):
(WebCore::NPObjectWrapper::NPAllocate):
(WebCore::NPObjectWrapper::NPDeallocate):
(WebCore::NPObjectWrapper::NPPInvalidate):
(WebCore::NPObjectWrapper::NPHasMethod):
(WebCore::NPObjectWrapper::NPInvoke):
(WebCore::NPObjectWrapper::NPInvokeDefault):
(WebCore::NPObjectWrapper::NPHasProperty):
(WebCore::NPObjectWrapper::NPGetProperty):
(WebCore::NPObjectWrapper::NPSetProperty):
(WebCore::NPObjectWrapper::NPRemoveProperty):
(WebCore::NPObjectWrapper::NPNEnumerate):
(WebCore::NPObjectWrapper::NPNConstruct):
(WebCore::NPObjectWrapper::NPInvokePrivate):
* bindings/v8/NPObjectWrapper.h: Added.
* bindings/v8/NPV8Object.cpp:
(_NPN_EvaluateHelper):
* bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::ScriptController):
(WebCore::ScriptController::clearScriptObjects):
(WebCore::ScriptController::windowScriptNPObject):
* bindings/v8/ScriptController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebkit API for compositor
commit-queue@webkit.org [Fri, 7 Oct 2011 23:38:39 +0000 (23:38 +0000)]
Webkit API for compositor
https://bugs.webkit.org/show_bug.cgi?id=69107

Patch by Antoine Labour <piman@chromium.org> on 2011-10-07
Reviewed by Darin Fisher.

Source/WebCore:

Covered by existing compositing tests.

* platform/graphics/chromium/ContentLayerChromium.h:

Source/WebKit/chromium:

* WebKit.gyp:
* public/WebContentLayer.h: Added.
(WebKit::WebContentLayer::WebContentLayer):
(WebKit::WebContentLayer::~WebContentLayer):
(WebKit::WebContentLayer::operator=):
* public/WebContentLayerClient.h: Added.
(WebKit::WebContentLayerClient::~WebContentLayerClient):
* public/WebLayer.h: Added.
(WebKit::WebLayer::WebLayer):
(WebKit::WebLayer::operator=):
(WebKit::WebLayer::to):
(WebKit::WebLayer::toConst):
(WebKit::WebLayer::unwrap):
(WebKit::WebLayer::constUnwrap):
(WebKit::operator==):
(WebKit::operator!=):
* public/WebLayerClient.h: Added.
(WebKit::WebLayerClient::~WebLayerClient):
* public/WebLayerTreeView.h: Added.
(WebKit::WebLayerTreeView::Settings::Settings):
(WebKit::WebLayerTreeView::WebLayerTreeView):
(WebKit::WebLayerTreeView::~WebLayerTreeView):
(WebKit::WebLayerTreeView::operator=):
(WebKit::operator==):
(WebKit::operator!=):
* public/WebLayerTreeViewClient.h: Added.
(WebKit::WebLayerTreeViewClient::~WebLayerTreeViewClient):
* src/WebContentLayer.cpp: Added.
(WebKit::WebContentLayer::create):
(WebKit::WebContentLayer::setDrawsContent):
(WebKit::WebContentLayer::drawsContent):
(WebKit::WebContentLayer::setNeedsDisplay):
(WebKit::WebContentLayer::dirtyRect):
(WebKit::WebContentLayer::WebContentLayer):
(WebKit::WebContentLayer::operator=):
(WebKit::WebContentLayer::operator PassRefPtr<WebContentLayerImpl>):
* src/WebContentLayerImpl.cpp: Added.
(WebKit::WebContentLayerImpl::create):
(WebKit::WebContentLayerImpl::WebContentLayerImpl):
(WebKit::WebContentLayerImpl::~WebContentLayerImpl):
(WebKit::WebContentLayerImpl::setDrawsContent):
(WebKit::WebContentLayerImpl::drawsContent):
(WebKit::WebContentLayerImpl::paintContents):
(WebKit::WebContentLayerImpl::notifySyncRequired):
* src/WebContentLayerImpl.h: Added.
* src/WebLayer.cpp: Added.
(WebKit::WebLayer::create):
(WebKit::WebLayer::~WebLayer):
(WebKit::WebLayer::reset):
(WebKit::WebLayer::assign):
(WebKit::WebLayer::equals):
(WebKit::WebLayer::rootLayer):
(WebKit::WebLayer::parent):
(WebKit::WebLayer::addChild):
(WebKit::WebLayer::insertChild):
(WebKit::WebLayer::replaceChild):
(WebKit::WebLayer::removeFromParent):
(WebKit::WebLayer::removeAllChildren):
(WebKit::WebLayer::setAnchorPoint):
(WebKit::WebLayer::anchorPoint):
(WebKit::WebLayer::setAnchorPointZ):
(WebKit::WebLayer::anchorPointZ):
(WebKit::WebLayer::setBounds):
(WebKit::WebLayer::bounds):
(WebKit::WebLayer::setMasksToBounds):
(WebKit::WebLayer::masksToBounds):
(WebKit::WebLayer::setMaskLayer):
(WebKit::WebLayer::maskLayer):
(WebKit::WebLayer::setOpacity):
(WebKit::WebLayer::opacity):
(WebKit::WebLayer::setOpaque):
(WebKit::WebLayer::opaque):
(WebKit::WebLayer::setPosition):
(WebKit::WebLayer::position):
(WebKit::WebLayer::setSublayerTransform):
(WebKit::WebLayer::sublayerTransform):
(WebKit::WebLayer::setTransform):
(WebKit::WebLayer::transform):
(WebKit::WebLayer::WebLayer):
(WebKit::WebLayer::operator=):
(WebKit::WebLayer::operator PassRefPtr<LayerChromium>):
* src/WebLayerImpl.cpp: Added.
(WebKit::WebLayerImpl::create):
(WebKit::WebLayerImpl::WebLayerImpl):
(WebKit::WebLayerImpl::~WebLayerImpl):
(WebKit::WebLayerImpl::drawsContent):
(WebKit::WebLayerImpl::paintContents):
(WebKit::WebLayerImpl::notifySyncRequired):
* src/WebLayerImpl.h: Added.
* src/WebLayerTreeView.cpp: Added.
(WebKit::WebLayerTreeView::Settings::operator CCSettings):
(WebKit::WebLayerTreeView::create):
(WebKit::WebLayerTreeView::reset):
(WebKit::WebLayerTreeView::assign):
(WebKit::WebLayerTreeView::equals):
(WebKit::WebLayerTreeView::composite):
(WebKit::WebLayerTreeView::setViewportSize):
(WebKit::WebLayerTreeView::viewportSize):
(WebKit::WebLayerTreeView::WebLayerTreeView):
(WebKit::WebLayerTreeView::operator=):
(WebKit::WebLayerTreeView::operator PassRefPtr<CCLayerTreeHost>):
* src/WebLayerTreeViewImpl.cpp: Added.
(WebKit::WebLayerTreeViewImpl::create):
(WebKit::WebLayerTreeViewImpl::WebLayerTreeViewImpl):
(WebKit::WebLayerTreeViewImpl::~WebLayerTreeViewImpl):
(WebKit::WebLayerTreeViewImpl::animateAndLayout):
(WebKit::WebLayerTreeViewImpl::applyScrollDelta):
(WebKit::WebLayerTreeViewImpl::createLayerTreeHostContext3D):
(WebKit::WebLayerTreeViewImpl::didRecreateGraphicsContext):
(WebKit::WebLayerTreeViewImpl::scheduleComposite):
* src/WebLayerTreeViewImpl.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd a Content-Security-Policy to garden-o-matic
abarth@webkit.org [Fri, 7 Oct 2011 23:38:24 +0000 (23:38 +0000)]
Add a Content-Security-Policy to garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=69668

Reviewed by David Levin.

This will help mitigate cross-site script and will also help us dogfood CSP.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/garden-o-matic.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRefactor DFG to make for use of callOperation
barraclough@apple.com [Fri, 7 Oct 2011 23:38:03 +0000 (23:38 +0000)]
Refactor DFG to make for use of callOperation
https://bugs.webkit.org/show_bug.cgi?id=69672

Reviewed by Oliver Hunt.

* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::callOperation):
    - Added new callOperation calls, don't ASSERT flushed (use helpers for unexpected calls, too).
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
    - Switch operationNewObject/operationCreateThis to return Cells,
    - Added C_DFGOperation_E/C_DFGOperation_EC/J_DFGOperation_EA/J_DFGOperation_EJA call types.
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):
    - Replace code plating calls to operations to with calls to callOperation.
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compileLogicalNot):
(JSC::DFG::SpeculativeJIT::emitBranch):
(JSC::DFG::SpeculativeJIT::compile):
    - Replace code plating calls to operations to with calls to callOperation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCSS text-transform should apply to select elements
commit-queue@webkit.org [Fri, 7 Oct 2011 23:29:50 +0000 (23:29 +0000)]
CSS text-transform should apply to select elements
https://bugs.webkit.org/show_bug.cgi?id=69503

Patch by Ben Wells <benwells@chromium.org> on 2011-10-07
Reviewed by Ojan Vafai.

Source/WebCore:

Select elements are drawn in two ways depending on whether they are multiple and what their size is.
Neither method previously handled text-transforms. Both of these rendering styles are now updated to transform
their text correctly.

Test: fast/css/text-transform-select.html

* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::updateFromElement):
(WebCore::RenderListBox::paintItemForeground):
* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::updateOptionsWidth):
(WebCore::RenderMenuList::setText):
(WebCore::RenderMenuList::itemText):
* rendering/RenderText.cpp:
(WebCore::makeCapitalized):
(WebCore::applyTextTransform):
(WebCore::RenderText::setTextInternal):
(WebCore::RenderText::textWithoutTranscoding):
* rendering/RenderText.h:

LayoutTests:

* fast/css/text-transform-select-expected.txt: Added.
* fast/css/text-transform-select.html: Added.
* platform/chromium-linux/fast/css/text-transform-select-expected.png: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFirst round of unit tests for CCLayerTreeHostCommon.
commit-queue@webkit.org [Fri, 7 Oct 2011 23:20:29 +0000 (23:20 +0000)]
First round of unit tests for CCLayerTreeHostCommon.
https://bugs.webkit.org/show_bug.cgi?id=69197

Patch by Shawn Singh <shawnsingh@chromium.org> on 2011-10-07
Reviewed by James Robinson.

This round of tests focuses on verifying the computation of matrix transforms
in calculateDrawTransformsAndVisibility.

* WebKit.gypi:
* tests/CCLayerTreeHostCommonTest.cpp: Added.
(WebCore::setLayerPropertiesForTesting):
(WebCore::executeCalculateDrawTransformsAndVisibility):
(WebCore::remove3DComponentOfMatrix):
(WebCore::LayerChromiumWithForcedDrawsContent::LayerChromiumWithForcedDrawsContent):
(WebCore::LayerChromiumWithForcedDrawsContent::drawsContent):
(WebCore::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agofix a crash when loading non-html multipart data
tony@chromium.org [Fri, 7 Oct 2011 23:18:35 +0000 (23:18 +0000)]
fix a crash when loading non-html multipart data
https://bugs.webkit.org/show_bug.cgi?id=69675

Reviewed by Adam Barth.

Source/WebCore:

setupForReplaceByMIMEType calls DocumentWriter::end().  This leads to
a crash on Mac because WebHTMLRepresentation() calls commitLoad(nil),
which tries to write to the DocumentWriter.  By just inlining the code
to load the last page, we avoid this crash (and makes the non-html
multipart code more like the html multipart code).

* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::maybeFinishLoadingMultipartContent):

LayoutTests:

* http/tests/multipart/load-last-non-html-frame.php: Ensure same
  output on Apple Mac and Chromium (was getting different number of
  trailing new lines).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoXSLT-generated document should inherit its SecurityOrigin from the source document
commit-queue@webkit.org [Fri, 7 Oct 2011 23:00:04 +0000 (23:00 +0000)]
XSLT-generated document should inherit its SecurityOrigin from the source document
https://bugs.webkit.org/show_bug.cgi?id=69661

Patch by Sergey Glazunov <serg.glazunov@gmail.com> on 2011-10-07
Reviewed by Adam Barth.

Source/WebCore:

Test: http/tests/security/xss-DENIED-xsl-document-securityOrigin.xml

* xml/XSLTProcessor.cpp:
(WebCore::XSLTProcessor::createDocumentFromSource):

LayoutTests:

* http/tests/security/xss-DENIED-xsl-document-securityOrigin-expected.txt: Added.
* http/tests/security/xss-DENIED-xsl-document-securityOrigin.xml: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSupport string indexing in the DFG
oliver@apple.com [Fri, 7 Oct 2011 22:11:51 +0000 (22:11 +0000)]
Support string indexing in the DFG
https://bugs.webkit.org/show_bug.cgi?id=69671

Reviewed by Gavin Barraclough.

Emit code to support inline indexing of strings

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileGetByValOnString):
    Shared code to perform string indexing.
* dfg/DFGSpeculativeJIT.h:
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
    Use compileGetByValOnString if we predict that the base object
    is a string in GetByVal.
* runtime/JSString.h:
(JSC::JSString::offsetOfFiberCount):
(JSC::JSString::offsetOfValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[WinCairo] Unreviewed Skiplist update to get WinCairo bot green.
bfulgham@webkit.org [Fri, 7 Oct 2011 22:00:18 +0000 (22:00 +0000)]
[WinCairo] Unreviewed Skiplist update to get WinCairo bot green.

* platform/wincairo/Skipped: Skip a few failing test categories.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRe-enable a test fixed by r93529.
rniwa@webkit.org [Fri, 7 Oct 2011 21:30:07 +0000 (21:30 +0000)]
Re-enable a test fixed by r93529.

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDFG ConvertThis speculation logic is wrong
fpizlo@apple.com [Fri, 7 Oct 2011 20:52:56 +0000 (20:52 +0000)]
DFG ConvertThis speculation logic is wrong
https://bugs.webkit.org/show_bug.cgi?id=69663

Reviewed by Oliver Hunt.

* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::fixupNode):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago [Mac] Scrollbars in embedded PDFs should update when system preferences change
ap@apple.com [Fri, 7 Oct 2011 20:43:41 +0000 (20:43 +0000)]
    [Mac] Scrollbars in embedded PDFs should update when system preferences change
        https://bugs.webkit.org/show_bug.cgi?id=69654

        Reviewed by Simon Fraser.

        * WebProcess/Plugins/PDF/BuiltInPDFView.h: Added an scrollbarStyleChanged() override.
        ScrollAnimatorMac sets scrollbar frame to a bogus (0, 0, thickness, thickness) one when style
        changes, and expects clients to move them back in place.

        * WebProcess/Plugins/PDF/BuiltInPDFView.cpp:
        (WebKit::BuiltInPDFView::isOnActivePage): Fixed a typo that prevented ScrollAnimatorMac from
        updating style of PDF view scrollbars.
        (WebKit::BuiltInPDFView::scrollbarStyleChanged): Reposition scrollbars and content after
        style change. The behavior is not perfect in edge cases, but roughly matches ScrollView.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-10-07 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Fri, 7 Oct 2011 20:27:01 +0000 (20:27 +0000)]
2011-10-07  Oliver Hunt  <oliver@apple.com>

        Verify that our call speculation is valid.

        Reviewed by Filip Pizlo.

        Before specialising an intrinsic we need to verify that
        we our speculation is correct.

        * dfg/DFGByteCodeParser.cpp:
        (JSC::DFG::ByteCodeParser::parseBlock):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[WinCairo] Unreviewed build correction for the build bot.
bfulgham@webkit.org [Fri, 7 Oct 2011 20:24:33 +0000 (20:24 +0000)]
[WinCairo] Unreviewed build correction for the build bot.

* JavaScriptCore.vcproj/JavaScriptCore.sln: Add the missing
Release_Cairo_CFLite and Debug_Cairo_CFLite targets so that
build-jsc can find the target it needs to run the JSC tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r96944.
commit-queue@webkit.org [Fri, 7 Oct 2011 20:23:45 +0000 (20:23 +0000)]
Unreviewed, rolling out r96944.
http://trac.webkit.org/changeset/96944
https://bugs.webkit.org/show_bug.cgi?id=69662

Caused many tests to crash on Snow Leopard (Requested by rniwa
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-07

* css/CSSStyleApplyProperty.cpp:
(WebCore::ApplyPropertyColor::applyInheritValue):
* page/animation/AnimationBase.cpp:
(WebCore::PropertyWrapperMaybeInvalidColor::PropertyWrapperMaybeInvalidColor):
(WebCore::PropertyWrapperSVGPaint::PropertyWrapperSVGPaint):
(WebCore::AnimationBase::ensurePropertyMap):
* platform/graphics/Color.h:
(WebCore::Color::Color):
* rendering/style/BorderValue.h:
(WebCore::BorderValue::BorderValue):
(WebCore::BorderValue::isTransparent):
(WebCore::BorderValue::operator==):
(WebCore::BorderValue::color):
* rendering/style/OutlineValue.h:
(WebCore::OutlineValue::operator==):
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::setBorderLeftColor):
(WebCore::InheritedFlags::setBorderRightColor):
(WebCore::InheritedFlags::setBorderTopColor):
(WebCore::InheritedFlags::setBorderBottomColor):
(WebCore::InheritedFlags::setOutlineColor):
(WebCore::InheritedFlags::setColumnRuleColor):
(WebCore::InheritedFlags::fillPaintColor):
(WebCore::InheritedFlags::strokePaintColor):
(WebCore::InheritedFlags::borderLeftColor):
(WebCore::InheritedFlags::borderRightColor):
(WebCore::InheritedFlags::borderTopColor):
(WebCore::InheritedFlags::borderBottomColor):
(WebCore::InheritedFlags::backgroundColor):
(WebCore::InheritedFlags::color):
(WebCore::InheritedFlags::columnRuleColor):
(WebCore::InheritedFlags::outlineColor):
(WebCore::InheritedFlags::textEmphasisColor):
(WebCore::InheritedFlags::textFillColor):
(WebCore::InheritedFlags::textStrokeColor):
(WebCore::InheritedFlags::stopColor):
(WebCore::InheritedFlags::floodColor):
(WebCore::InheritedFlags::lightingColor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=69658
hyatt@apple.com [Fri, 7 Oct 2011 20:15:11 +0000 (20:15 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=69658

[CSS3 Regions] Box painting of overflow into regions is incorrect because children were being
incorrectly clamped to their containing block region ranges. Change the clamping model so that
renderRegionForLine no longer does it. A block will now truly have an accurate range across
all the regions that paint it. Instead, do the clamping at the time a child box asks the containing
block for its information. At that time clamp to the start and end regions, so that we never ask
a containing block for info about a region that it doesn't exist in.

Reviewed by Anders Carlsson.

Source/WebCore:

Added new test in fast/regions and updated an old result to be correct.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::pageLogicalHeightForOffset):
(WebCore::RenderBlock::pageRemainingLogicalHeightForOffset):
(WebCore::RenderBlock::regionAtBlockOffset):
(WebCore::RenderBlock::clampToStartAndEndRegions):
* rendering/RenderBlock.h:
* rendering/RenderBox.cpp:
(WebCore::RenderBox::borderBoxRectInRegion):
(WebCore::RenderBox::containingBlockLogicalWidthForContentInRegion):
(WebCore::RenderBox::renderBoxRegionInfo):
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::renderRegionForLine):
(WebCore::RenderFlowThread::regionLogicalWidthForLine):
(WebCore::RenderFlowThread::regionLogicalHeightForLine):
(WebCore::RenderFlowThread::regionRemainingLogicalHeightForLine):
(WebCore::RenderFlowThread::mapFromFlowToRegion):
(WebCore::RenderFlowThread::setRegionRangeForBox):
* rendering/RenderFlowThread.h:

LayoutTests:

* fast/regions/bottom-overflow-out-of-first-region.html: Added.
* fast/regions/top-overflow-out-of-second-region.html:
* platform/mac/fast/regions/bottom-overflow-out-of-first-region-expected.png: Added.
* platform/mac/fast/regions/bottom-overflow-out-of-first-region-expected.txt: Added.
* platform/mac/fast/regions/top-overflow-out-of-second-region-expected.png:
* platform/mac/fast/regions/top-overflow-out-of-second-region-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove compile time flag ENABLE_PASSWORD_ECHO
commit-queue@webkit.org [Fri, 7 Oct 2011 20:05:34 +0000 (20:05 +0000)]
Remove compile time flag ENABLE_PASSWORD_ECHO
https://bugs.webkit.org/show_bug.cgi?id=69647

Source/WebCore:

As we have runtime flag in the page/Settings, we should remove this redundant compile time flag.

Patch by Chang Shu <cshu@webkit.org> on 2011-10-07
Reviewed by Andreas Kling.

* config.h:
* page/Settings.cpp:
(WebCore::Settings::Settings):

Source/WebKit/qt:

As we have runtime flag in the page/Settings, we should remove this redundant compile time flag.

Patch by Chang Shu <cshu@webkit.org> on 2011-10-07
Reviewed by Andreas Kling.

* Api/qwebsettings.cpp:
(QWebSettingsPrivate::apply):

LayoutTests:

WK2 tests are passing after r96740 (bug 68924).

Patch by Chang Shu <cshu@webkit.org> on 2011-10-07
Reviewed by Andreas Kling.

* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBug 69562 - AccessibilityImageMapLink holds onto it's parent even after it's been...
cfleizach@apple.com [Fri, 7 Oct 2011 19:45:14 +0000 (19:45 +0000)]
Bug 69562 - AccessibilityImageMapLink holds onto it's parent even after it's been freed
https://bugs.webkit.org/show_bug.cgi?id=69562

Source/WebCore:

Some fake objects, like AXImageMapLink, have weak references to their parent's (since they are fake objects and
need some connection to the parent). However, if the parent disappears before the child, then we're left with a
out of date reference to that parent.

The fix is to allow these elements to clear their parentage when the parent goes away.

Reviewed by Darin Adler.

Test: accessibility/image-map-update-parent-crash.html

* accessibility/AccessibilityMenuListOption.cpp:
(WebCore::AccessibilityMenuListOption::isVisible):
* accessibility/AccessibilityMenuListPopup.cpp:
(WebCore::AccessibilityMenuListPopup::isOffScreen):
(WebCore::AccessibilityMenuListPopup::isEnabled):
(WebCore::AccessibilityMenuListPopup::press):
(WebCore::AccessibilityMenuListPopup::addChildren):
(WebCore::AccessibilityMenuListPopup::childrenChanged):
* accessibility/AccessibilityMockObject.h:
(WebCore::AccessibilityMockObject::detachFromParent):
* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::clearChildren):
* accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::detachFromParent):
* accessibility/AccessibilitySlider.cpp:
(WebCore::AccessibilitySliderThumb::elementRect):
* accessibility/AccessibilityTableColumn.cpp:
(WebCore::AccessibilityTableColumn::headerObjectForSection):

LayoutTests:

Reviewed by Darin Adler.

* accessibility/image-map-update-parent-crash-expected.txt: Added.
* accessibility/image-map-update-parent-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96973 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPack StyleRareNonInheritedData even harder on 64-bit.
commit-queue@webkit.org [Fri, 7 Oct 2011 19:32:32 +0000 (19:32 +0000)]
Pack StyleRareNonInheritedData even harder on 64-bit.
https://bugs.webkit.org/show_bug.cgi?id=69648

Patch by Andreas Kling <kling@webkit.org> on 2011-10-07
Reviewed by Benjamin Poulain.

Rearrange the members of StyleRareNonInheritedData to fold as much
as possible into the padding at the end of RefCounted.

This shrinks StyleRareNonInheritedData by 16 bytes on 64-bit,
reducing memory consumption by another 140 kB when loading the
full HTML5 spec.

* rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
* rendering/style/StyleRareNonInheritedData.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoChromium rebaseline. The test started to pass after r96873.
rniwa@webkit.org [Fri, 7 Oct 2011 19:28:49 +0000 (19:28 +0000)]
Chromium rebaseline. The test started to pass after r96873.

* platform/chromium-mac-snowleopard/editing/pasteboard/paste-text-006-expected.png: Added.
* platform/chromium-win/editing/pasteboard/paste-text-006-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: Enable color profiles, unless profile is grayscale
caryclark@google.com [Fri, 7 Oct 2011 19:26:47 +0000 (19:26 +0000)]
Source/WebCore: Enable color profiles, unless profile is grayscale
https://bugs.webkit.org/show_bug.cgi?id=69622
https://bugs.webkit.org/show_bug.cgi?id=49950
http://code.google.com/p/chromium/issues/detail?id=80844

Further specialize the earlier fix described in 49950 to
allow color profiles in YCbCr images, but disallow color
profiles marked as grayData.
(see http://www.color.org/ICC1v42_2006-05.pdf 7.2.6 )

Reviewed by Adam Barth.

Test: fast/images/gray-scale-jpeg-with-color-profile.html
      fast/images/color-jpeg-with-color-profile.html

* platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
(WebCore::readColorProfile):
(WebCore::JPEGImageReader::decode):

LayoutTests: Reviewed by Adam Barth.

Add a image with a color profile that's not gray.
https://bugs.webkit.org/show_bug.cgi?id=69622

Test that we properly render JPEGs with embedded non-gray color profiles.

* fast/images/color-jpeg-with-color-profile.html: Added.
* fast/images/resources/icc-v2-gbr.jpg: Added.
* platform/chromium-mac/fast/images/color-jpeg-with-color-profile-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96970 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r96938.
ossy@webkit.org [Fri, 7 Oct 2011 19:25:00 +0000 (19:25 +0000)]
Unreviewed, rolling out r96938.
http://trac.webkit.org/changeset/96938
https://bugs.webkit.org/show_bug.cgi?id=69653

It broke zillion tests and make testing so slow (Requested by
ossy_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-07

Source/WebKit2:

* UIProcess/WebContext.cpp:
* UIProcess/WebContext.h:
* UIProcess/efl/WebContextEfl.cpp:
(WebKit::WebContext::applicationCacheDirectory):
* UIProcess/gtk/WebContextGtk.cpp:
(WebKit::WebContext::applicationCacheDirectory):
* UIProcess/mac/WebContextMac.mm:
(WebKit::WebContext::applicationCacheDirectory):
* UIProcess/qt/WebContextQt.cpp:
(WebKit::WebContext::applicationCacheDirectory):
* UIProcess/win/WebContextWin.cpp:
(WebKit::WebContext::applicationCacheDirectory):

LayoutTests:

* platform/qt-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed gardening after r96958.
ossy@webkit.org [Fri, 7 Oct 2011 19:23:24 +0000 (19:23 +0000)]
Unreviewed gardening after r96958.

* platform/qt/test_expectations.txt: Remove a file, because it is skipped too.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Rebaseline test after r96870.
simonjam@chromium.org [Fri, 7 Oct 2011 19:17:35 +0000 (19:17 +0000)]
[Chromium] Rebaseline test after r96870.

Unreviewed.

* platform/chromium-cg-mac-leopard/editing/pasteboard/merge-end-blockquote-expected.png:
* platform/chromium-cg-mac/editing/pasteboard/merge-end-blockquote-expected.png: Removed.
* platform/chromium-mac/editing/pasteboard/merge-end-blockquote-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAX: re-organize fake elements to use new AccessibilityMockObject
cfleizach@apple.com [Fri, 7 Oct 2011 19:12:59 +0000 (19:12 +0000)]
AX: re-organize fake elements to use new AccessibilityMockObject
https://bugs.webkit.org/show_bug.cgi?id=69588

This adds an AccessibilityMockObject for "fake" elements to descend from.
Its benefit is to consolidate the various ways that these fake elements are setting
and returning their parent objects.

No functional change, hence no new tests.

Reviewed by Jon Honeycutt.

* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* accessibility/AccessibilityARIAGrid.cpp:
(WebCore::AccessibilityARIAGrid::addChildren):
* accessibility/AccessibilityImageMapLink.cpp:
(WebCore::AccessibilityImageMapLink::AccessibilityImageMapLink):
* accessibility/AccessibilityImageMapLink.h:
(WebCore::AccessibilityImageMapLink::node):
* accessibility/AccessibilityMenuList.cpp:
(WebCore::AccessibilityMenuList::addChildren):
* accessibility/AccessibilityMenuList.h:
(WebCore::toAccessibilityMenuList):
* accessibility/AccessibilityMenuListOption.cpp:
(WebCore::AccessibilityMenuListOption::AccessibilityMenuListOption):
(WebCore::AccessibilityMenuListOption::isVisible):
* accessibility/AccessibilityMenuListOption.h:
* accessibility/AccessibilityMenuListPopup.cpp:
(WebCore::AccessibilityMenuListPopup::AccessibilityMenuListPopup):
(WebCore::AccessibilityMenuListPopup::isOffScreen):
(WebCore::AccessibilityMenuListPopup::isEnabled):
(WebCore::AccessibilityMenuListPopup::menuListOptionAccessibilityObject):
(WebCore::AccessibilityMenuListPopup::press):
(WebCore::AccessibilityMenuListPopup::addChildren):
(WebCore::AccessibilityMenuListPopup::childrenChanged):
(WebCore::AccessibilityMenuListPopup::didUpdateActiveOption):
* accessibility/AccessibilityMenuListPopup.h:
* accessibility/AccessibilityMockObject.cpp: Added.
(WebCore::AccessibilityMockObject::AccessibilityMockObject):
(WebCore::AccessibilityMockObject::~AccessibilityMockObject):
* accessibility/AccessibilityMockObject.h: Added.
(WebCore::AccessibilityMockObject::parentObject):
(WebCore::AccessibilityMockObject::setParent):
(WebCore::AccessibilityMockObject::detachFromParent):
* accessibility/AccessibilitySlider.cpp:
(WebCore::AccessibilitySlider::addChildren):
(WebCore::AccessibilitySliderThumb::AccessibilitySliderThumb):
(WebCore::AccessibilitySliderThumb::elementRect):
* accessibility/AccessibilitySlider.h:
* accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::addChildren):
(WebCore::AccessibilityTable::headerContainer):
* accessibility/AccessibilityTable.h:
(WebCore::toAccessibilityTable):
* accessibility/AccessibilityTableColumn.cpp:
(WebCore::AccessibilityTableColumn::AccessibilityTableColumn):
(WebCore::AccessibilityTableColumn::setParent):
(WebCore::AccessibilityTableColumn::headerObject):
(WebCore::AccessibilityTableColumn::headerObjectForSection):
(WebCore::AccessibilityTableColumn::accessibilityIsIgnored):
(WebCore::AccessibilityTableColumn::addChildren):
* accessibility/AccessibilityTableColumn.h:
* accessibility/AccessibilityTableHeaderContainer.cpp:
(WebCore::AccessibilityTableHeaderContainer::AccessibilityTableHeaderContainer):
(WebCore::AccessibilityTableHeaderContainer::accessibilityIsIgnored):
(WebCore::AccessibilityTableHeaderContainer::addChildren):
* accessibility/AccessibilityTableHeaderContainer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix 32-bit build.
oliver@apple.com [Fri, 7 Oct 2011 18:57:41 +0000 (18:57 +0000)]
Fix 32-bit build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix chromium compile when using the components build. This test
tony@chromium.org [Fri, 7 Oct 2011 18:55:13 +0000 (18:55 +0000)]
Fix chromium compile when using the components build.  This test
helper file is using methods not available when compiling as a dll.

* WebKit.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION(r96257): fast/repaint/selection-clear.html fail
rniwa@webkit.org [Fri, 7 Oct 2011 18:47:57 +0000 (18:47 +0000)]
REGRESSION(r96257): fast/repaint/selection-clear.html fail
https://bugs.webkit.org/show_bug.cgi?id=69060

Reviewed by Enrica Casucci.

After r96257, we no longer clear selection upon node removal so the selection should
still be rendered after the node removal in this test.

Changed the color of selection from red to green to indicate the success.

* fast/repaint/selection-clear.html:
* platform/mac/fast/repaint/selection-clear-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSupport direct calls to intrinsic functions
oliver@apple.com [Fri, 7 Oct 2011 18:39:45 +0000 (18:39 +0000)]
Support direct calls to intrinsic functions
https://bugs.webkit.org/show_bug.cgi?id=69646

Reviewed by Gavin Barraclough.

Add support for optimising non-method_check calls
to intrinsic functions (eg. when Math.abs, etc are
cached in local variables).

* bytecode/CodeBlock.h:
(JSC::getCallLinkInfoBytecodeIndex):
    Support searching CallLinkInfos by bytecode index
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
    Add support for linked calls in addition to method_check
    when searching for intrinsics
* dfg/DFGNode.h:
(JSC::DFG::Node::hasFunctionCheckData):
(JSC::DFG::Node::function):
    Add ability to store a JSFunction* in a node - this is safe
    as the function will be marked by the codeblock we're compiling
* dfg/DFGPropagator.cpp:
(JSC::DFG::Propagator::propagateNodePredictions):
(JSC::DFG::Propagator::checkFunctionElimination):
(JSC::DFG::Propagator::performNodeCSE):
    Add support for new CheckFunction node, and implement CSE pass.
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
    Rather trivial implementation of CheckFunction
* jit/JIT.cpp:
(JSC::JIT::privateCompile):
* jit/JIT.h:
* jit/JITCall.cpp:
(JSC::JIT::compileOpCall):
* jit/JITCall32_64.cpp:
(JSC::JIT::compileOpCall):
    Need to propagate bytecode index for calls now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMake IconLoader a CachedResourceClient instead of a SubresourceLoaderClient.
japhet@chromium.org [Fri, 7 Oct 2011 18:16:03 +0000 (18:16 +0000)]
Make IconLoader a CachedResourceClient instead of a SubresourceLoaderClient.
This is one of the steps required to remove the SubresourceLoaderClient interface,
which will simplify the layering in the loader.
https://bugs.webkit.org/show_bug.cgi?id=69567

Reviewed by Adam Barth.

No new tests, no functionality change intended.

* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* loader/cache/CachedRawResource.cpp: Added.
* loader/cache/CachedRawResource.h: Added.
* loader/cache/CachedResource.cpp:
* loader/cache/CachedResource.h:
(WebCore::CachedResource::ignoreForRequestCount): Renamed and generalized from isLinkResource(),
    which was only used to decided whether the CachedResource should count toward
    CachedResourceLoader::requestCount().
* loader/cache/CachedResourceLoader.cpp:
* loader/cache/CachedResourceLoader.h:
* loader/cache/CachedResourceRequest.cpp:
* loader/cache/CachedResourceRequest.h:
* loader/icon/IconLoader.cpp: Get a CachedResource instead of a SubresourceLoader.
(WebCore::IconLoader::notifyFinished): Merge in the status code check that was in didReceiveResponse(),
    since we won't be checking any callbacks before the load completes.
* loader/icon/IconLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Update test_expectations after V8 roll.
simonjam@chromium.org [Fri, 7 Oct 2011 18:14:06 +0000 (18:14 +0000)]
[Chromium] Update test_expectations after V8 roll.

Unreviewed.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@96960 268f45cc-cd09-0410-ab3c-d52691b4dbfc