WebKit-https.git
11 years ago Unreviewed trivial warning fix.
abecsi@webkit.org [Tue, 9 Feb 2010 15:30:07 +0000 (15:30 +0000)]
Unreviewed trivial warning fix.

* Scripts/build-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdd possibility of passing parameters to build-webkit by environment variable,
abecsi@webkit.org [Tue, 9 Feb 2010 15:22:47 +0000 (15:22 +0000)]
Add possibility of passing parameters to build-webkit by environment variable,
because the buildbot slaves can't control the arguments.

Patch by Gabor Rapcsanyi <rgabor@inf.u-szeged.hu> on 2010-02-09
Reviewed by Tor Arne Vestbø.

* Scripts/build-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-09 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Tue, 9 Feb 2010 15:15:08 +0000 (15:15 +0000)]
2010-02-09  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Upstream JavaScript part of DevTools WebKit API implementation(now
        with the added files).

        https://bugs.webkit.org/show_bug.cgi?id=34744

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-09 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Tue, 9 Feb 2010 15:03:13 +0000 (15:03 +0000)]
2010-02-09  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Upstream JavaScript part of DevTools WebKit API implementation

        https://bugs.webkit.org/show_bug.cgi?id=34744

        * WebKit.gypi: Added.
        * src/js/DebuggerAgent.js: Added.
        (devtools.DebuggerAgent):
        (devtools.DebuggerAgent.prototype.reset):
        (devtools.DebuggerAgent.prototype.initUI):
        (devtools.DebuggerAgent.prototype.resolveScriptSource.this.requestSeqToCallback_.cmd.getSequenceNumber):
        (devtools.DebuggerAgent.prototype.resolveScriptSource):
        (devtools.DebuggerAgent.prototype.pauseExecution):
        (devtools.DebuggerAgent.prototype.addBreakpoint):
        (devtools.DebuggerAgent.prototype.removeBreakpoint):
        (devtools.DebuggerAgent.prototype.updateBreakpoint):
        (devtools.DebuggerAgent.prototype.stepIntoStatement):
        (devtools.DebuggerAgent.prototype.stepOutOfFunction):
        (devtools.DebuggerAgent.prototype.stepOverStatement):
        (devtools.DebuggerAgent.prototype.resumeExecution):
        (devtools.DebuggerAgent.prototype.createExceptionMessage_):
        (devtools.DebuggerAgent.prototype.showPendingExceptionMessage_):
        (devtools.DebuggerAgent.prototype.clearExceptionMessage_):
        (devtools.DebuggerAgent.prototype.pauseOnExceptions):
        (devtools.DebuggerAgent.prototype.setPauseOnExceptions):
        (devtools.DebuggerAgent.prototype.requestEvaluate):
        (devtools.DebuggerAgent.prototype.resolveChildren):
        (devtools.DebuggerAgent.prototype.resolveScope.this.requestSeqToCallback_.cmd.getSequenceNumber):
        (devtools.DebuggerAgent.prototype.resolveScope):
        (devtools.DebuggerAgent.prototype.resolveFrameVariables_.scopeResponseHandler):
        (devtools.DebuggerAgent.prototype.resolveFrameVariables_):
        (devtools.DebuggerAgent.prototype.resolveCompletionsOnFrame):
        (devtools.DebuggerAgent.prototype.getScriptContextType):
        (devtools.DebuggerAgent.prototype.requestClearBreakpoint_):
        (devtools.DebuggerAgent.prototype.requestChangeBreakpoint_):
        (devtools.DebuggerAgent.prototype.requestBacktrace_):
        (devtools.DebuggerAgent.sendCommand_):
        (devtools.DebuggerAgent.prototype.stepCommand_):
        (devtools.DebuggerAgent.prototype.requestLookup_):
        (devtools.DebuggerAgent.prototype.setContextId_.this.requestSeqToCallback_.cmd.getSequenceNumber):
        (devtools.DebuggerAgent.prototype.setContextId_):
        (devtools.DebuggerAgent.prototype.handleDebuggerOutput_):
        (devtools.DebuggerAgent.prototype.handleBreakEvent_):
        (devtools.DebuggerAgent.prototype.handleExceptionEvent_):
        (devtools.DebuggerAgent.prototype.handleScriptsResponse_):
        (devtools.DebuggerAgent.prototype.isScriptFromInspectedContext_):
        (devtools.DebuggerAgent.prototype.handleSetBreakpointResponse_):
        (devtools.DebuggerAgent.prototype.handleAfterCompileEvent_):
        (devtools.DebuggerAgent.prototype.addScriptInfo_):
        (devtools.DebuggerAgent.prototype.handleClearBreakpointResponse_):
        (devtools.DebuggerAgent.prototype.handleBacktraceResponse_):
        (devtools.DebuggerAgent.prototype.doHandleBacktraceResponse_):
        (devtools.DebuggerAgent.prototype.evaluateInCallFrame):
        (devtools.DebuggerAgent.prototype.invokeCallbackForResponse_):
        (devtools.DebuggerAgent.prototype.formatCallFrame_):
        (devtools.DebuggerAgent.formatObjectProperties_):
        (devtools.DebuggerAgent.propertiesToProxies_):
        (devtools.DebuggerAgent.formatObjectProxy_):
        (devtools.DebuggerAgent.webkitToV8LineNumber_):
        (devtools.DebuggerAgent.v8ToWwebkitLineNumber_):
        (devtools.ScriptInfo):
        (devtools.ScriptInfo.prototype.getLineOffset):
        (devtools.ScriptInfo.prototype.getContextType):
        (devtools.ScriptInfo.prototype.getUrl):
        (devtools.ScriptInfo.prototype.isUnresolved):
        (devtools.ScriptInfo.prototype.getBreakpointInfo):
        (devtools.ScriptInfo.prototype.addBreakpointInfo):
        (devtools.ScriptInfo.prototype.removeBreakpointInfo):
        (devtools.BreakpointInfo):
        (devtools.BreakpointInfo.prototype.getLine):
        (devtools.BreakpointInfo.prototype.getV8Id):
        (devtools.BreakpointInfo.prototype.setV8Id):
        (devtools.BreakpointInfo.prototype.markAsRemoved):
        (devtools.BreakpointInfo.prototype.isRemoved):
        (devtools.CallFrame):
        (devtools.CallFrame.prototype.evaluate_):
        (devtools.DebugCommand):
        (devtools.DebugCommand.prototype.getSequenceNumber):
        (devtools.DebugCommand.prototype.toJSONProtocol):
        (devtools.DebuggerMessage):
        (devtools.DebuggerMessage.prototype.getType):
        (devtools.DebuggerMessage.prototype.getEvent):
        (devtools.DebuggerMessage.prototype.getCommand):
        (devtools.DebuggerMessage.prototype.getRequestSeq):
        (devtools.DebuggerMessage.prototype.isRunning):
        (devtools.DebuggerMessage.prototype.isSuccess):
        (devtools.DebuggerMessage.prototype.getMessage):
        (devtools.DebuggerMessage.prototype.getBody):
        (devtools.DebuggerMessage.prototype.lookup):
        * src/js/DevTools.js: Added.
        (devtools.dispatch):
        (devtools.ToolsAgent):
        (devtools.ToolsAgent.prototype.reset):
        (devtools.ToolsAgent.prototype.evaluateJavaScript):
        (devtools.ToolsAgent.prototype.getDebuggerAgent):
        (devtools.ToolsAgent.prototype.getProfilerAgent):
        (devtools.ToolsAgent.prototype.frameNavigate_):
        (devtools.ToolsAgent.prototype.dispatchOnClient_):
        (devtools.ToolsAgent.prototype.evaluate):
        (WebInspector.setResourcesPanelEnabled):
        (debugPrint):
        (devtools):
        (WebInspector.loaded):
        ():
        (WebInspector.ScriptView.prototype.setupSourceFrameIfNeeded):
        (WebInspector.ScriptView.prototype.didResolveScriptSource_):
        (WebInspector.UnresolvedPropertyValue):
        (WebInspector.UIString):
        (WebInspector.resourceTrackingWasEnabled):
        (WebInspector.resourceTrackingWasDisabled):
        (WebInspector.TestController.prototype.runAfterPendingDispatches):
        (WebInspector.queuesAreEmpty):
        (WebInspector.pausedScript):
        * src/js/DevToolsHostStub.js: Added.
        (.RemoteDebuggerAgentStub):
        (.RemoteDebuggerAgentStub.prototype.getContextId):
        (.RemoteProfilerAgentStub):
        (.RemoteProfilerAgentStub.prototype.getActiveProfilerModules):
        (.RemoteProfilerAgentStub.prototype.getLogLines):
        (.RemoteToolsAgentStub):
        (.RemoteToolsAgentStub.prototype.dispatchOnInjectedScript):
        (.RemoteToolsAgentStub.prototype.dispatchOnInspectorController):
        (.RemoteToolsAgentStub.prototype.executeVoidJavaScript):
        (.ProfilerStubHelper):
        (.ProfilerStubHelper.GetInstance):
        (.ProfilerStubHelper.prototype.StopProfiling):
        (.ProfilerStubHelper.prototype.StartProfiling):
        (.ProfilerStubHelper.prototype.getActiveProfilerModules):
        (.ProfilerStubHelper.prototype.getLogLines):
        (.RemoteDebuggerCommandExecutorStub):
        (.RemoteDebuggerCommandExecutorStub.prototype.DebuggerCommand):
        (.RemoteDebuggerCommandExecutorStub.prototype.DebuggerPauseScript):
        (.RemoteDebuggerCommandExecutorStub.prototype.sendResponse_):
        (.DevToolsHostStub):
        (.DevToolsHostStub.prototype.reset):
        (.DevToolsHostStub.prototype.setting):
        (.DevToolsHostStub.prototype.setSetting):
        * src/js/HeapProfilerPanel.js: Added.
        (WebInspector.ProfilesPanel.prototype.addSnapshot):
        (WebInspector.HeapSnapshotView):
        (WebInspector.HeapSnapshotView.prototype.get statusBarItems):
        (WebInspector.HeapSnapshotView.prototype.get profile):
        (WebInspector.HeapSnapshotView.prototype.set profile):
        (WebInspector.HeapSnapshotView.prototype.show):
        (WebInspector.HeapSnapshotView.prototype.hide):
        (WebInspector.HeapSnapshotView.prototype.resize):
        (WebInspector.HeapSnapshotView.prototype.refresh):
        (WebInspector.HeapSnapshotView.prototype.refreshShowAsPercents):
        (WebInspector.HeapSnapshotView.prototype._deleteSearchMatchedFlags):
        (WebInspector.HeapSnapshotView.prototype.searchCanceled):
        (WebInspector.HeapSnapshotView.prototype.performSearch):
        (WebInspector.HeapSnapshotView.prototype.jumpToFirstSearchResult.WebInspector.CPUProfileView.prototype.jumpToFirstSearchResult.jumpToLastSearchResult.WebInspector.CPUProfileView.prototype.jumpToLastSearchResult.jumpToNextSearchResult.WebInspector.CPUProfileView.prototype.jumpToNextSearchResult.jumpToPreviousSearchResult.WebInspector.CPUProfileView.prototype.jumpToPreviousSearchResult.showingFirstSearchResult.WebInspector.CPUProfileView.prototype.showingFirstSearchResult.showingLastSearchResult.WebInspector.CPUProfileView.prototype.showingLastSearchResult._jumpToSearchResult.WebInspector.CPUProfileView.prototype._jumpToSearchResult.refreshVisibleData):
        (WebInspector.HeapSnapshotView.prototype._changeBase):
        (WebInspector.HeapSnapshotView.prototype._createSnapshotDataGridList):
        (WebInspector.HeapSnapshotView.prototype._mouseDownInDataGrid):
        (WebInspector.HeapSnapshotView.prototype.get _isShowingAsPercent):
        (WebInspector.HeapSnapshotView.prototype._percentClicked):
        (WebInspector.HeapSnapshotView.prototype._resetDataGridList):
        (WebInspector.HeapSnapshotView.prototype._sortData):
        (WebInspector.HeapSnapshotView.prototype._updateBaseOptions):
        (WebInspector.HeapSnapshotView.prototype._updatePercentButton):
        (WebInspector.HeapSnapshotView.prototype._updateSummaryGraph):
        (WebInspector.HeapSnapshotView.SearchHelper.operations.LESS):
        (WebInspector.HeapSnapshotView.SearchHelper.operations.LESS_OR_EQUAL):
        (WebInspector.HeapSnapshotView.SearchHelper.operations.EQUAL):
        (WebInspector.HeapSnapshotView.SearchHelper.operations.GREATER_OR_EQUAL):
        (WebInspector.HeapSnapshotView.SearchHelper.operations.GREATER):
        (WebInspector.HeapSnapshotView.SearchHelper.parseOperationAndNumber):
        (WebInspector.HeapSummaryCalculator):
        (WebInspector.HeapSummaryCalculator.prototype.computeSummaryValues):
        (WebInspector.HeapSummaryCalculator.prototype.formatValue):
        (WebInspector.HeapSummaryCalculator.prototype.get showAsPercent):
        (WebInspector.HeapSummaryCalculator.prototype.set showAsPercent):
        (WebInspector.HeapSummaryCountCalculator):
        (WebInspector.HeapSummaryCountCalculator.prototype._highFromLow):
        (WebInspector.HeapSummaryCountCalculator.prototype._valueToString):
        (WebInspector.HeapSummarySizeCalculator):
        (WebInspector.HeapSummarySizeCalculator.prototype._highFromLow):
        (WebInspector.HeapSnapshotSidebarTreeElement):
        (WebInspector.HeapSnapshotSidebarTreeElement.prototype.get mainTitle):
        (WebInspector.HeapSnapshotSidebarTreeElement.prototype.set mainTitle):
        (WebInspector.HeapSnapshotDataGridNodeWithRetainers):
        (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.get _hasRetainers):
        (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.get _parent):
        (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype._populate.if):
        (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype._populate):
        (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.produceDiff):
        (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.sort):
        (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.signForDelta):
        (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.showDeltaAsPercent):
        (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.getTotalCount):
        (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.getTotalSize):
        (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.get countPercent):
        (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.get sizePercent):
        (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.get countDeltaPercent):
        (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.get sizeDeltaPercent):
        (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.get data):
        (WebInspector.HeapSnapshotDataGridNodeWithRetainers.prototype.createCell):
        (WebInspector.HeapSnapshotDataGridNode):
        (WebInspector.HeapSnapshotDataGridList):
        (WebInspector.HeapSnapshotDataGridList.prototype.appendChild):
        (WebInspector.HeapSnapshotDataGridList.prototype.insertChild):
        (WebInspector.HeapSnapshotDataGridList.prototype.removeChildren):
        (WebInspector.HeapSnapshotDataGridList.prototype.populateChildren):
        (WebInspector.HeapSnapshotDataGridList.propertyComparator.comparator):
        (WebInspector.HeapSnapshotDataGridList.propertyComparator):
        (WebInspector.HeapSnapshotDataGridRetainerNode):
        (WebInspector.HeapSnapshotDataGridRetainerNode.prototype.get sizePercent):
        (WebInspector.HeapSnapshotDataGridRetainerNode.prototype.get sizeDeltaPercent):
        (WebInspector.HeapSnapshotDataGridRetainerNode.prototype._calculateRetainers):
        (WebInspector.HeapSnapshotProfileType):
        (WebInspector.HeapSnapshotProfileType.prototype.get buttonTooltip):
        (WebInspector.HeapSnapshotProfileType.prototype.get buttonStyle):
        (WebInspector.HeapSnapshotProfileType.prototype.buttonClicked):
        (WebInspector.HeapSnapshotProfileType.prototype.get welcomeMessage):
        (WebInspector.HeapSnapshotProfileType.prototype.createSidebarTreeElementForProfile):
        (WebInspector.HeapSnapshotProfileType.prototype.createView):
        ():
        * src/js/InjectDispatch.js: Added.
        (InspectorControllerDispatcher.dispatch):
        (ApuAgentDispatcher.dispatchToApu):
        (dispatch):
        (devtools):
        * src/js/InspectorControllerImpl.js: Added.
        (devtools.InspectorBackendImpl):
        (devtools.InspectorBackendImpl.prototype.toggleNodeSearch):
        (devtools.InspectorBackendImpl.prototype.debuggerEnabled):
        (devtools.InspectorBackendImpl.prototype.profilerEnabled):
        (devtools.InspectorBackendImpl.prototype.addBreakpoint):
        (devtools.InspectorBackendImpl.prototype.removeBreakpoint):
        (devtools.InspectorBackendImpl.prototype.updateBreakpoint):
        (devtools.InspectorBackendImpl.prototype.pauseInDebugger):
        (devtools.InspectorBackendImpl.prototype.resumeDebugger):
        (devtools.InspectorBackendImpl.prototype.stepIntoStatementInDebugger):
        (devtools.InspectorBackendImpl.prototype.stepOutOfFunctionInDebugger):
        (devtools.InspectorBackendImpl.prototype.stepOverStatementInDebugger):
        (devtools.InspectorBackendImpl.prototype.setPauseOnExceptionsState):
        (devtools.InspectorBackendImpl.prototype.pauseOnExceptionsState):
        (devtools.InspectorBackendImpl.prototype.pauseOnExceptions):
        (devtools.InspectorBackendImpl.prototype.setPauseOnExceptions):
        (devtools.InspectorBackendImpl.prototype.startProfiling):
        (devtools.InspectorBackendImpl.prototype.stopProfiling):
        (devtools.InspectorBackendImpl.prototype.getProfileHeaders):
        (devtools.InspectorBackendImpl.prototype.addFullProfile):
        (devtools.InspectorBackendImpl.prototype.getProfile):
        (devtools.InspectorBackendImpl.prototype.takeHeapSnapshot):
        (devtools.InspectorBackendImpl.prototype.dispatchOnInjectedScript):
        (devtools.InspectorBackendImpl.prototype.installInspectorControllerDelegate_):
        (devtools.InspectorBackendImpl.prototype.callInspectorController_):
        * src/js/ProfilerAgent.js: Added.
        (devtools.ProfilerAgent):
        (devtools.ProfilerAgent.prototype.setupProfilerProcessorCallbacks):
        (devtools.ProfilerAgent.prototype.initializeProfiling):
        (devtools.ProfilerAgent.prototype.startProfiling):
        (devtools.ProfilerAgent.prototype.stopProfiling):
        (devtools.ProfilerAgent.prototype.didGetActiveProfilerModules_):
        (devtools.ProfilerAgent.prototype.didGetLogLines_):
        * src/js/ProfilerProcessor.js: Added.
        (devtools.profiler.WebKitViewBuilder):
        (devtools.profiler.WebKitViewBuilder.prototype.createViewNode):
        (devtools.profiler.WebKitViewNode):
        (set get devtools.profiler.WebKitViewNode.prototype.initFuncInfo_):
        (devtools.profiler.JsProfile):
        (devtools.profiler.JsProfile.prototype.skipThisFunction):
        (devtools.profiler.Processor):
        (devtools.profiler.Processor.prototype.printError):
        (devtools.profiler.Processor.prototype.skipDispatch):
        (devtools.profiler.Processor.prototype.setCallbacks):
        (devtools.profiler.Processor.prototype.setNewProfileCallback):
        (devtools.profiler.Processor.prototype.processProfiler_.switch.break):
        (devtools.profiler.Processor.prototype.processProfiler_):
        (devtools.profiler.Processor.prototype.processCodeCreation_):
        (devtools.profiler.Processor.prototype.processCodeMove_):
        (devtools.profiler.Processor.prototype.processCodeDelete_):
        (devtools.profiler.Processor.prototype.processFunctionCreation_):
        (devtools.profiler.Processor.prototype.processFunctionMove_):
        (devtools.profiler.Processor.prototype.processFunctionDelete_):
        (devtools.profiler.Processor.prototype.processTick_):
        (devtools.profiler.Processor.prototype.processTickV2_):
        (devtools.profiler.Processor.prototype.processHeapSampleBegin_):
        (devtools.profiler.Processor.prototype.processHeapSampleStats_):
        (devtools.profiler.Processor.prototype.processHeapSampleItem_):
        (devtools.profiler.Processor.prototype.processHeapJsConsItem_):
        (devtools.profiler.Processor.prototype.processHeapJsRetItem_.mergeRetainers):
        (devtools.profiler.Processor.prototype.processHeapJsRetItem_):
        (devtools.profiler.Processor.prototype.processHeapSampleEnd_):
        (devtools.profiler.Processor.prototype.createProfileForView):
        * src/js/Tests.js: Added.
        (.TestSuite):
        (.TestSuite.prototype.fail):
        (.TestSuite.prototype.assertEquals):
        (.TestSuite.prototype.assertTrue):
        (.TestSuite.prototype.assertContains):
        (.TestSuite.prototype.takeControl):
        (.TestSuite.prototype.releaseControl):
        (.TestSuite.prototype.reportOk_):
        (.TestSuite.prototype.reportFailure_):
        (.TestSuite.prototype.runTest):
        (.TestSuite.prototype.showPanel):
        (.TestSuite.prototype.addSniffer.receiver.methodName):
        (.TestSuite.prototype.addSniffer):
        (.TestSuite.prototype.testHostIsPresent):
        (.TestSuite.prototype.testElementsTreeRoot):
        (.TestSuite.prototype.testMainResource):
        (.TestSuite.prototype.testResourceContentLength.this.addSniffer.):
        (.TestSuite.prototype.testResourceHeaders):
        (.TestSuite.prototype.testCachedResourceMimeType.this.addSniffer.):
        (.TestSuite.prototype.testCachedResourceMimeType):
        (.TestSuite.prototype.testProfilerTab):
        (.TestSuite.prototype.testScriptsTabIsPopulatedOnInspectedPageRefresh.waitUntilScriptIsParsed):
        (.TestSuite.prototype.testScriptsTabIsPopulatedOnInspectedPageRefresh.checkScriptsPanel):
        (.TestSuite.prototype.testScriptsTabIsPopulatedOnInspectedPageRefresh):
        (.TestSuite.prototype.testNoScriptDuplicatesOnPanelSwitch.switchToElementsTab):
        (.TestSuite.prototype.testNoScriptDuplicatesOnPanelSwitch.switchToScriptsTab):
        (.TestSuite.prototype.testNoScriptDuplicatesOnPanelSwitch.checkScriptsPanel):
        (.TestSuite.prototype.testNoScriptDuplicatesOnPanelSwitch.checkNoDuplicates):
        (.TestSuite.prototype.testPauseOnException):
        (.TestSuite.prototype.testPauseWhenLoadingDevTools):
        (.TestSuite.prototype.testPauseWhenScriptIsRunning.testScriptPauseAfterDelay):
        (.TestSuite.prototype.testPauseWhenScriptIsRunning.testScriptPause):
        (.TestSuite.prototype.testPauseWhenScriptIsRunning):
        (.TestSuite.prototype.optionsToString_):
        (.TestSuite.prototype.evaluateInConsole_):
        (.TestSuite.prototype.waitForSetBreakpointResponse_):
        (.TestSuite.prototype.testEvalOnCallFrame.setBreakpointCallback):
        (.TestSuite.prototype.testEvalOnCallFrame.waitForBreakpointHit):
        (.TestSuite.prototype.testCompletionOnPause):
        (.TestSuite.prototype.testCompletionOnPause.testLocalsCompletion):
        (.TestSuite.prototype.testCompletionOnPause.testThisCompletion):
        (.TestSuite.prototype.testCompletionOnPause.testFieldCompletion):
        (.TestSuite.prototype.testCompletionOnPause.checkCompletions):
        (.TestSuite.prototype.testAutoContinueOnSyntaxError.checkScriptsList):
        (.TestSuite.prototype.testAutoContinueOnSyntaxError.waitForExceptionEvent.test):
        (.TestSuite.prototype.testAutoContinueOnSyntaxError.waitForExceptionEvent):
        (.TestSuite.prototype._checkExecutionLine):
        (.TestSuite.prototype._scriptsAreParsed):
        (.TestSuite.prototype._waitForScriptPause):
        (.TestSuite.prototype._checkSourceFrameWhenLoaded.checkExecLine):
        (.TestSuite.prototype._checkSourceFrameWhenLoaded):
        (.TestSuite.prototype._performSteps.doNextAction):
        (.TestSuite.prototype._performSteps):
        (.TestSuite.prototype._executeCodeWhenScriptsAreParsed.executeFunctionInInspectedPage):
        (.TestSuite.prototype._waitUntilScriptsAreParsed.waitForAllScripts):
        (.TestSuite.prototype._waitUntilScriptsAreParsed):
        (.TestSuite.prototype._executeFunctionForStepTest):
        (.TestSuite.prototype.testStepOver):
        (.TestSuite.prototype.testStepOut):
        (.TestSuite.prototype.testStepIn):
        (.TestSuite.prototype._evaluateXpath):
        (.TestSuite.prototype._findNode):
        (.TestSuite.prototype._findText):
        (.TestSuite.prototype._nodeIterator):
        (.TestSuite.prototype._checkScopeSectionDiv):
        (.TestSuite.prototype._expandScopeSections.updateListener):
        (.TestSuite.prototype._expandScopeSections):
        (.TestSuite.prototype.testExpandScope):
        (.TestSuite.prototype.testExpandScope.examineScopes):
        (.TestSuite.prototype._findChildProperty):
        (.TestSuite.prototype._hookGetPropertiesCallback.accessor.getProperties):
        (.TestSuite.prototype._hookGetPropertiesCallback.try):
        (.TestSuite.prototype._hookGetPropertiesCallback):
        (.TestSuite.prototype.testDebugIntrinsicProperties.expandLocalScope):
        (.TestSuite.prototype.testDebugIntrinsicProperties):
        (.TestSuite.prototype.testDebugIntrinsicProperties.expandAndCheckNextProperty):
        (.TestSuite.prototype.testDebugIntrinsicProperties.checkProperty):
        (.TestSuite.createKeyEvent):
        (.TestSuite.prototype.testConsoleLog.assertNext):
        (.TestSuite.prototype.testConsoleLog):
        (.TestSuite.prototype.testEvalGlobal.initEval):
        (.TestSuite.prototype.testEvalGlobal):
        (.TestSuite.prototype.testShowStoragePanel.this.addSniffer.):
        (.TestSuite.prototype.testShowStoragePanel.this.addSniffer):
        (.uiTests.runAllTests):
        (.uiTests.runTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoThree small string fixes:
barraclough@apple.com [Tue, 9 Feb 2010 11:55:39 +0000 (11:55 +0000)]
Three small string fixes:
(1) StringBuilder::release should CRASH if the buffer allocation failed.
(2) Remove weird, dead code from JSString::tryGetValue, replace with an ASSERT.
(3) Move UString::createFromUTF8 out to the API, as tryCreateStringFromUTF8.
    This is only used from the API, and (now) unlike other UString::create
    methods may return UString::null() to indicate failure cases.  Better
    handle these in the API.

Reviewed by Oliver Hunt.

* API/JSClassRef.cpp:
(tryCreateStringFromUTF8):
(OpaqueJSClass::OpaqueJSClass):
(OpaqueJSClassContextData::OpaqueJSClassContextData):
* runtime/JSString.h:
(JSC::Fiber::tryGetValue):
* runtime/StringBuilder.h:
(JSC::StringBuilder::release):
* runtime/UString.cpp:
(JSC::UString::UString):
(JSC::UString::from):
(JSC::UString::find):
* runtime/UString.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-09 Yuzo Fujishima <yuzo@google.com>
yuzo@google.com [Tue, 9 Feb 2010 11:13:01 +0000 (11:13 +0000)]
2010-02-09  Yuzo Fujishima  <yuzo@google.com>

        Unreviewed.

        Fix build brekage introduced by r54536.

        Add the following two to Skipped:
        fast/css/inline-element-line-break.html and
        fast/css/pseudo-element-line-break.html

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-09 Chang Shu <Chang.Shu@nokia.com>
eric@webkit.org [Tue, 9 Feb 2010 10:40:22 +0000 (10:40 +0000)]
2010-02-09  Chang Shu  <Chang.Shu@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] Enable http/tests/appcache but skip the failed cases.
        https://bugs.webkit.org/show_bug.cgi?id=34713

        * platform/qt/Skipped:
2010-02-09  Chang Shu  <Chang.Shu@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] Enable appcache feature.
        https://bugs.webkit.org/show_bug.cgi?id=34713

        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
        (WebCore::WebPage::WebPage):
        * DumpRenderTree/qt/main.cpp:
        (main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-09 Kwang Yul Seo <skyul@company100.net>
eric@webkit.org [Tue, 9 Feb 2010 10:24:12 +0000 (10:24 +0000)]
2010-02-09  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Eric Seidel.

        [BREWMP] Port KURL::fileSystemPath
        https://bugs.webkit.org/show_bug.cgi?id=34516

        Convert a file URL to a file path by prefixing
        AEEFS_HOME_DIR to access files relative to the current
        module directory in a case-sensitive manner.

        As IWeb "file:" engine opens files in BREW's application-relative
        file namespace, we follow the same policy here.

        * platform/brew/KURLBrew.cpp: Added.
        (WebCore::KURL::fileSystemPath):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-09 Noam Rosenthal <noam.rosenthal@nokia.com>
eric@webkit.org [Tue, 9 Feb 2010 10:07:58 +0000 (10:07 +0000)]
2010-02-09  Noam Rosenthal  <noam.rosenthal@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] the above website does not render properly when in compositing mode
        https://bugs.webkit.org/show_bug.cgi?id=34681

        http://media.24ways.org/2009/15/spinner-alt.html now renders correctly

        * platform/graphics/qt/GraphicsLayerQt.cpp:
        (WebCore::MaskEffectQt::MaskEffectQt): implement mask as
        QGraphicsEffect
        (WebCore::MaskEffectQt::draw): reimp
        (WebCore::GraphicsLayerQtImpl::GraphicsLayerQtImpl): init the effect
        (WebCore::GraphicsLayerQtImpl::paint): no need for drawContents
        (WebCore::GraphicsLayerQtImpl::flushChanges): make sure to update the
        mask layer, not just the actual children

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-09 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 9 Feb 2010 10:01:39 +0000 (10:01 +0000)]
2010-02-09  Eric Seidel  <eric@webkit.org>

        Reviewed by Shinichiro Hamaji.

        storage/database-lock-after-reload.html is flakey
        https://bugs.webkit.org/show_bug.cgi?id=29154

        * platform/mac/Skipped: Skip for now to keep the bots green until someone can take a look.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-09 Janne Koskinen <janne.p.koskinen@digia.com>
eric@webkit.org [Tue, 9 Feb 2010 09:51:35 +0000 (09:51 +0000)]
2010-02-09  Janne Koskinen  <janne.p.koskinen@digia.com>

        Reviewed by Laszlo Gombos.

        [Qt] use nanval() for Symbian as nonInlineNaN
        https://bugs.webkit.org/show_bug.cgi?id=34170

        numeric_limits<double>::quiet_NaN is broken in Symbian
        causing NaN to be evaluated as a number.

        * runtime/JSValue.cpp:
        (JSC::nonInlineNaN):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-09 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Tue, 9 Feb 2010 09:39:16 +0000 (09:39 +0000)]
2010-02-09  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Darin Adler.

        Add modified version of CSS2.1 test suite for paged media
        https://bugs.webkit.org/show_bug.cgi?id=34695

        Note that page-break-inside-000 is failing now.

        * platform/qt/Skipped:
        * platform/win/Skipped:
        * printing/css2.1/README.txt: Added.
        * printing/css2.1/page-break-after-000-expected.txt: Added.
        * printing/css2.1/page-break-after-000.html: Added.
        * printing/css2.1/page-break-after-001-expected.txt: Added.
        * printing/css2.1/page-break-after-001.html: Added.
        * printing/css2.1/page-break-after-002-expected.txt: Added.
        * printing/css2.1/page-break-after-002.html: Added.
        * printing/css2.1/page-break-after-004-expected.txt: Added.
        * printing/css2.1/page-break-after-004.html: Added.
        * printing/css2.1/page-break-before-000-expected.txt: Added.
        * printing/css2.1/page-break-before-000.html: Added.
        * printing/css2.1/page-break-before-001-expected.txt: Added.
        * printing/css2.1/page-break-before-001.html: Added.
        * printing/css2.1/page-break-before-002-expected.txt: Added.
        * printing/css2.1/page-break-before-002.html: Added.
        * printing/css2.1/page-break-inside-000-expected.txt: Added.
        * printing/css2.1/page-break-inside-000.html: Added.
        * printing/resources/paged-media-test-utils.js: Added.
        (pageNumberShouldBe):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-09 Kwang Yul Seo <skyul@company100.net>
eric@webkit.org [Tue, 9 Feb 2010 09:35:03 +0000 (09:35 +0000)]
2010-02-09  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Laszlo Gombos.

        [BREWMP] Fix macro redefinition error in BREWMP simulator build.
        https://bugs.webkit.org/show_bug.cgi?id=34738

        Remove warning: 'FAR' macro redefinition.

        * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-07 Yuzo Fujishima <yuzo@google.com>
yuzo@google.com [Tue, 9 Feb 2010 09:16:36 +0000 (09:16 +0000)]
2010-02-07  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by Dan Bernstein.

        Fix the following bugs:
        https://bugs.webkit.org/show_bug.cgi?id=18926 - dt:after generate a line break. Boost documentation page renders poorly
        https://bugs.webkit.org/show_bug.cgi?id=7276 - Most W3C padding related tests fail

        css2.1/t0803-c5504-imrgn-l-02-b-ag-expected.html and css2.1/t0804-c5509-ipadn-l-02-b-ag-expected.html have been rebaselined
        because the original expected values are incorrect, judging from the test description and how IE 8.0, Firefox 3.6, and Opera 10.10 render the pages.
        fast/dom/clone-node-dynamic-style-expected.html have been also rebaselined because the original expected values assumes a line break.
        Expected values under platform/qt need not be updated because the tests are in the Skipped file for the platform.

        * fast/css/inline-element-line-break.html: Added.
        * fast/css/pseudo-element-line-break.html: Added.
        * platform/mac/css2.1/t0803-c5504-imrgn-l-02-b-ag-expected.checksum:
        * platform/mac/css2.1/t0803-c5504-imrgn-l-02-b-ag-expected.png:
        * platform/mac/css2.1/t0803-c5504-imrgn-l-02-b-ag-expected.txt:
        * platform/mac/css2.1/t0804-c5509-ipadn-l-02-b-ag-expected.checksum:
        * platform/mac/css2.1/t0804-c5509-ipadn-l-02-b-ag-expected.png:
        * platform/mac/css2.1/t0804-c5509-ipadn-l-02-b-ag-expected.txt:
        * platform/mac/fast/css/inline-element-line-break-expected.checksum: Added.
        * platform/mac/fast/css/inline-element-line-break-expected.png: Added.
        * platform/mac/fast/css/inline-element-line-break-expected.txt: Added.
        * platform/mac/fast/css/pseudo-element-line-break-expected.checksum: Added.
        * platform/mac/fast/css/pseudo-element-line-break-expected.png: Added.
        * platform/mac/fast/css/pseudo-element-line-break-expected.txt: Added.
        * platform/mac/fast/dom/clone-node-dynamic-style-expected.checksum:
        * platform/mac/fast/dom/clone-node-dynamic-style-expected.png:
        * platform/mac/fast/dom/clone-node-dynamic-style-expected.txt:
2010-02-07  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by Dan Bernstein.

        Fix the following bugs:
        https://bugs.webkit.org/show_bug.cgi?id=18926 - dt:after generate a line break. Boost documentation page renders poorly
        https://bugs.webkit.org/show_bug.cgi?id=7276 - Most W3C padding related tests fail

        Tests: fast/css/inline-element-line-break.html
               fast/css/pseudo-element-line-break.html

        findNextLineBreak() unconditionally allowed lines to break between elements when no other line breaking opportunity had been found,
        but that was unnecessary and led to incorrect layout. Disallow that kind of line breaks.

        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::RenderBlock::findNextLineBreak):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-09 Avi Drissman <avi@chromium.org>
eric@webkit.org [Tue, 9 Feb 2010 08:52:05 +0000 (08:52 +0000)]
2010-02-09  Avi Drissman  <avi@chromium.org>

        Reviewed by David Levin.

        Chromium Mac: Control-A shouldn't select all/Control-C shouldn't copy
        https://bugs.webkit.org/show_bug.cgi?id=34615

        * fast/events/attempt-select-all-with-wrong-modifier-expected.txt: Added.
        * fast/events/attempt-select-all-with-wrong-modifier.html: Added.
2010-02-09  Avi Drissman  <avi@chromium.org>

        Reviewed by David Levin.

        Chromium Mac: Control-A shouldn't select all/Control-C shouldn't copy
        https://bugs.webkit.org/show_bug.cgi?id=34615

        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::keyEventDefault):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdd a soft modulo operation to ARM JIT using a trampoline function.
loki@webkit.org [Tue, 9 Feb 2010 08:50:22 +0000 (08:50 +0000)]
Add a soft modulo operation to ARM JIT using a trampoline function.
The performance progression is about ~1.8% on ARMv7
https://bugs.webkit.org/show_bug.cgi?id=34424

Patch by Tamas Szirbucz <szirbucz@inf.u-szeged.hu> on 2010-02-09
Reviewed by Gavin Barraclough.

Developed in cooperation with Gabor Loki.

* jit/JIT.h:
* jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_mod):
(JSC::JIT::emitSlow_op_mod):
* jit/JITOpcodes.cpp:
(JSC::JIT::softModulo):
* jit/JITStubs.h:
(JSC::JITThunks::ctiSoftModulo):
* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-09 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Tue, 9 Feb 2010 08:32:53 +0000 (08:32 +0000)]
2010-02-09  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Darin Adler.

        Provide a way to get total number of pages to be printed
        https://bugs.webkit.org/show_bug.cgi?id=34699

        * platform/gtk/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:
        * printing/numberOfPages-expected.txt: Added.
        * printing/numberOfPages.html: Added.
        * printing/script-tests/numberOfPages.js: Added.
        (createParagraph):
2010-02-09  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Darin Adler.

        Provide a way to get total number of pages to be printed
        https://bugs.webkit.org/show_bug.cgi?id=34699

        Test: printing/numberOfPages.html

        * WebCore.base.exp:
        * page/PrintContext.cpp:
        (WebCore::PrintContext::pageNumberForElement):
        (WebCore::PrintContext::numberOfPages):
        * page/PrintContext.h:
        (WebCore::PrintContext::pageRects):
2010-02-09  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Darin Adler.

        Provide a way to get total number of pages to be printed
        https://bugs.webkit.org/show_bug.cgi?id=34699

        * Misc/WebCoreStatistics.h:
        * Misc/WebCoreStatistics.mm:
        (-[WebFrame numberOfPages:pageWidthInPixels:]):
2010-02-09  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Darin Adler.

        Provide a way to get total number of pages to be printed
        https://bugs.webkit.org/show_bug.cgi?id=34699

        * DumpRenderTree/LayoutTestController.cpp:
        (parsePageParameters):
        (pageNumberForElementByIdCallback):
        (numberOfPagesCallback):
        (LayoutTestController::staticFunctions):
        * DumpRenderTree/LayoutTestController.h:
        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
        (LayoutTestController::numberOfPages):
        * DumpRenderTree/mac/LayoutTestControllerMac.mm:
        (LayoutTestController::numberOfPages):
        * DumpRenderTree/win/LayoutTestControllerWin.cpp:
        (LayoutTestController::numberOfPages):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
barraclough@apple.com [Tue, 9 Feb 2010 07:53:51 +0000 (07:53 +0000)]
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* runtime/StringPrototype.cpp:

Reviewed by NOBODY (SL/win build fixes).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoMake String.replace throw an exception on out-of-memory, rather than
barraclough@apple.com [Tue, 9 Feb 2010 07:40:57 +0000 (07:40 +0000)]
Make String.replace throw an exception on out-of-memory, rather than
returning a null (err, empty-ish) string.  Move String::replaceRange
and String::spliceSubstringsWithSeparators out to StringPrototype -
these were fairly specific use anyway, and we can better integrate
throwing the JS expcetion this way.

Reviewed by Oliver Hunt

Also removes redundant assignment operator from UString.

* JavaScriptCore.exp:
* runtime/StringPrototype.cpp:
(JSC::StringRange::StringRange):
(JSC::jsSpliceSubstringsWithSeparators):
(JSC::jsReplaceRange):
(JSC::stringProtoFuncReplace):
* runtime/UString.cpp:
* runtime/UString.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdd numerous parse-only tests.
zherczeg@webkit.org [Tue, 9 Feb 2010 07:32:11 +0000 (07:32 +0000)]
Add numerous parse-only tests.
https://bugs.webkit.org/show_bug.cgi?id=34019

Patch by Zoltan Herczeg <zherczeg@inf.u-szeged.hu> on 2010-02-09
Reviewed by Oliver Hunt.

The input file contains a lot of strings, and tests whether they are
valid JavaScript code snippets or contains various syntax errors.
No semantic checks: even if a tests throws an exception, which is not
syntax error, it is considered successfull.

* fast/js/parser-syntax-check-expected.txt: Added.
* fast/js/parser-syntax-check.html: Added.
* fast/js/script-tests/parser-syntax-check.js: Added.
(runTest):
(valid):
(invalid):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-08 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Tue, 9 Feb 2010 07:15:15 +0000 (07:15 +0000)]
2010-02-08  Shinichiro Hamaji  <hamaji@chromium.org>

        Unreviewed GTK+ test fix.

        Web site is stuck loading forever
        https://bugs.webkit.org/show_bug.cgi?id=31227

        It seems the following bug is addressing this issue.
        [GTK] Needs proper reporting of frame loader callbacks, in DRT
        https://bugs.webkit.org/show_bug.cgi?id=32170

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-08 Kwang Yul Seo <skyul@company100.net>
eric@webkit.org [Tue, 9 Feb 2010 07:15:12 +0000 (07:15 +0000)]
2010-02-08  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Eric Seidel.

        [BREWMP] Undefine WTF_OS_WINDOWS and WTF_PLATFORM_WIN
        https://bugs.webkit.org/show_bug.cgi?id=34561

        As the binary for simulator is built with MSVC 2005,
        WTF_OS_WINDOWS and WTF_PLATFORM_WIN are defined.
        Undefine them as we don't target Windows.

        * wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-08 Dominic Cooney <dominicc@google.com>
eric@webkit.org [Tue, 9 Feb 2010 06:48:48 +0000 (06:48 +0000)]
2010-02-08  Dominic Cooney  <dominicc@google.com>

        Reviewed by Adam Barth.

        [V8] Move Element custom methods into generic bindings

        This patch moves the security checks in setAttribute,
        setAttributeNode, setAttributeNS and setAttributeNodeNS from
        V8ElementCustom into the generic bindings so that they can be
        reused in other bindings. This is in a similar vein to
        <https://bugs.webkit.org/attachment.cgi?id=45872>.

        https://bugs.webkit.org/show_bug.cgi?id=34554

        LayoutTests: None

        * WebCore.gypi:
        * bindings/generic/BindingElement.h: Added.
        (WebCore::::setAttribute):
        (WebCore::::setAttributeNode):
        (WebCore::::setAttributeNS):
        (WebCore::::setAttributeNodeNS):
        * bindings/v8/V8Binding.h:
        * bindings/v8/custom/V8ElementCustom.cpp:
        (WebCore::V8Element::setAttributeCallback):
        (WebCore::V8Element::setAttributeNodeCallback):
        (WebCore::V8Element::setAttributeNSCallback):
        (WebCore::V8Element::setAttributeNodeNSCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-08 Hayato Ito <hayato@chromium.org>
hamaji@chromium.org [Tue, 9 Feb 2010 06:17:04 +0000 (06:17 +0000)]
2010-02-08  Hayato Ito  <hayato@chromium.org>

        Reviewed by Darin Adler.

        Schedule a loading request when there are many in-flight requests beyond
        the limit to avoid forever page loading.

        https://bugs.webkit.org/show_bug.cgi?id=31227

        * http/tests/loading/load-javascript-after-many-xhrs-expected.txt: Added.
        * http/tests/loading/load-javascript-after-many-xhrs.html: Added.
        * http/tests/loading/resources/zero-length.js: Added.
        * http/tests/loading/resources/zero-length.txt: Added.
2010-02-08  Hayato Ito  <hayato@chromium.org>

        Reviewed by Darin Adler.

        Schedule a loading request when there are many in-flight requests beyond
        the limit to avoid forever page loading.

        https://bugs.webkit.org/show_bug.cgi?id=31227

        Test: http/tests/loading/load-javascript-after-many-xhrs.html

        * loader/loader.cpp:
        (WebCore::Loader::Host::servePendingRequests):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoREGRESSION (before r54472): Various tests in fast/workers are crashing on the buildbot.
levin@chromium.org [Tue, 9 Feb 2010 05:19:00 +0000 (05:19 +0000)]
REGRESSION (before r54472): Various tests in fast/workers are crashing on the buildbot.
https://bugs.webkit.org/show_bug.cgi?id=34728

Reviewed by Gavin Barraclough.

The core part of the fix is to change WebCoreJSClientData::m_normalWorld
from DOMWrapperWorld to RefPtr<DOMWrapperWorld> so that the DOMWrapperWorld
is really ref counted.

No new tests because current tests sufficiently cover this as evidenced as
the buildbot crashes.

* bindings/js/JSDOMBinding.cpp:
(WebCore::DOMWrapperWorld::~DOMWrapperWorld): Made this robust to m_globalData
being 0.
* bindings/js/JSDOMBinding.h:
(WebCore::DOMWrapperWorld::create): Made this class follow the standard
create pattern for RefCounted classes.
(WebCore::DOMWrapperWorld::detachFromGlobalData): Since this class can
now outlive JSGlobalData, this method tells it to stop using its JSGlobalData.
(WebCore::WebCoreJSClientData::WebCoreJSClientData): Adjusted due to
m_normalWorld being a RefPtr.
(WebCore::WebCoreJSClientData::~WebCoreJSClientData): Ditto (and added
asserts for the FIXME).
(WebCore::WebCoreJSClientData::normalWorld): Ditto.
* bindings/js/ScriptController.cpp:
(WebCore::IsolatedWorld::create): Made the constructor protected.
(WebCore::IsolatedWorld::IsolatedWorld): Made the constructor protected, so
that code would have to use the create method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-08 Evan Martin <evan@chromium.org>
eric@webkit.org [Tue, 9 Feb 2010 03:05:36 +0000 (03:05 +0000)]
2010-02-08  Evan Martin  <evan@chromium.org>

        dlopen() knows how to search the library search path, so just rely on
        it.  While I'm at it, print out the dlerror() error message on failure.

        [chromium] webgl shouldn't hard code library search path
        https://bugs.webkit.org/show_bug.cgi?id=34659

        * src/GraphicsContext3D.cpp:
        (WebCore::GraphicsContext3DInternal::GLConnection::GLConnection):
        (WebCore::GraphicsContext3DInternal::GLConnection::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-08 Kinuko Yasuda <kinuko@chromium.org>
eric@webkit.org [Tue, 9 Feb 2010 02:48:44 +0000 (02:48 +0000)]
2010-02-08  Kinuko Yasuda  <kinuko@chromium.org>

        Reviewed by David Levin.

        Remove special utf-8 tag from Chromium cilpboard code because
        we now have the corresponding code in generic clipboard framework
        code in chromium (since it's needed by other places than in Web
        page rendering) and no longer need the separate workaround code in
        WebKit.
        https://bugs.webkit.org/show_bug.cgi?id=34567

        Test: (for regression) editing/pasteboard

        * platform/chromium/ClipboardChromium.cpp:
        (WebCore::ClipboardChromium::writeRange):
        * platform/chromium/PasteboardChromium.cpp:
        (WebCore::Pasteboard::writeSelection):
        (WebCore::Pasteboard::documentFragment):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-08 Chris Rogers <crogers@google.com>
eric@webkit.org [Tue, 9 Feb 2010 02:31:19 +0000 (02:31 +0000)]
2010-02-08  Chris Rogers  <crogers@google.com>

        Reviewed by Darin Adler.

        audio engine: add Vector3 class
        https://bugs.webkit.org/show_bug.cgi?id=34548

        * wtf/Vector3.h: Added.
        (WebCore::Vector3::Vector3):
        (WebCore::Vector3::abs):
        (WebCore::Vector3::isZero):
        (WebCore::Vector3::normalize):
        (WebCore::Vector3::x):
        (WebCore::Vector3::y):
        (WebCore::Vector3::z):
        (WebCore::operator+):
        (WebCore::operator-):
        (WebCore::operator*):
        (WebCore::dot):
        (WebCore::cross):
        (WebCore::distance):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoCrash due to layout not done in case involving removal of absolute positioning
darin@apple.com [Tue, 9 Feb 2010 02:12:06 +0000 (02:12 +0000)]
Crash due to layout not done in case involving removal of absolute positioning
https://bugs.webkit.org/show_bug.cgi?id=34734
rdar://problem/7588280

Reviewed by Dan Bernstein.

WebCore:

Test: fast/dynamic/position-change-layout.html

* rendering/RenderObject.cpp:
(WebCore::RenderObject::styleDidChange): Call markContainingBlocksForLayout in
a case where the object already needs layout, but might have a new containing
block and so needs to mark the new containing block.

LayoutTests:

* fast/dynamic/position-change-layout-expected.txt: Added.
* fast/dynamic/position-change-layout.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-08 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Tue, 9 Feb 2010 01:24:37 +0000 (01:24 +0000)]
2010-02-08  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        Fix warning in clang++

        * runtime/Structure.h:
        (JSC::Structure::propertyStorageSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-08 Charlie Reis <creis@chromium.org>
eric@webkit.org [Tue, 9 Feb 2010 00:32:26 +0000 (00:32 +0000)]
2010-02-08  Charlie Reis  <creis@chromium.org>

        Reviewed by Darin Adler.

        onbeforeunload not called at window close + frame or iframe focused
        https://bugs.webkit.org/show_bug.cgi?id=27481

        Chromium and WebKit on Windows will now fire beforeunload handlers
        even if an inner frame is focused.

        Layout tests aren't able to test this bug, since it requires closing
        the actual browser window, not calling window.close().  Instead,
        test with WebCore/manual-tests/onbeforeunload-focused-iframe.html.

        * manual-tests/onbeforeunload-focused-iframe.html: Added.
        * manual-tests/resources/focused-iframe.html: Added.
2010-02-08  Charlie Reis  <creis@chromium.org>

        Reviewed by Darin Adler.

        onbeforeunload not called at window close + frame or iframe focused
        https://bugs.webkit.org/show_bug.cgi?id=27481
        http://code.google.com/p/chromium/issues/detail?id=32615
        http://code.google.com/p/chromium/issues/detail?id=17157

        Chromium and WebKit on Windows will now fire beforeunload handlers
        even if an inner frame is focused.

        Layout tests aren't able to test this bug, since it requires closing
        the actual browser window, not calling window.close().  Instead,
        test with WebCore/manual-tests/onbeforeunload-focused-iframe.html.

        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::dispatchBeforeUnloadEvent):
2010-02-08  Charlie Reis  <creis@chromium.org>

        Reviewed by Darin Adler.

        onbeforeunload not called at window close + frame or iframe focused
        https://bugs.webkit.org/show_bug.cgi?id=27481

        Chromium and WebKit on Windows will now fire beforeunload handlers
        even if an inner frame is focused.

        Layout tests aren't able to test this bug, since it requires closing
        the actual browser window, not calling window.close().  Instead,
        test with WebCore/manual-tests/onbeforeunload-focused-iframe.html.

        * WebView.cpp:
        (WebView::shouldClose):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoMake makeString CRASH if we fail to allocate a string.
barraclough@apple.com [Mon, 8 Feb 2010 23:43:26 +0000 (23:43 +0000)]
Make makeString CRASH if we fail to allocate a string.

Reviewed by Geoff Garen.

(tryMakeString or jsMakeNontrivialString can be used where we
expect allocation may fail and want to handle the error).

* runtime/JSStringBuilder.h:
(JSC::jsMakeNontrivialString):
* runtime/UString.h:
(JSC::tryMakeString):
(JSC::makeString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Addressing review feedback.
ap@apple.com [Mon, 8 Feb 2010 23:28:54 +0000 (23:28 +0000)]
    Addressing review feedback.

        * bridge/c/c_instance.h: Removed argument name.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Darin Adler.
ap@apple.com [Mon, 8 Feb 2010 23:27:19 +0000 (23:27 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=34727
        Assertion crashes and freezes when plug-in property access results in an exception

        Test: plugins/netscape-plugin-property-access-exception.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-08 Pavel Feldman <pfeldman@chromium.org>
eric@webkit.org [Mon, 8 Feb 2010 23:27:10 +0000 (23:27 +0000)]
2010-02-08  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by David Levin.

        WebKit/chromium: Custom context menu does not work in inspector.
        https://bugs.webkit.org/show_bug.cgi?id=34711

        * src/WebDevToolsFrontendImpl.cpp:
        (WebKit::WebDevToolsFrontendImpl::jsShowContextMenu):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRubber Stamped by Oliver Hunt.
barraclough@apple.com [Mon, 8 Feb 2010 23:13:49 +0000 (23:13 +0000)]
Rubber Stamped by Oliver Hunt.

Remove a couple of unnecesary C-style casts spotted by Darin.

* runtime/JSGlobalObjectFunctions.cpp:
(JSC::encode):
(JSC::globalFuncEscape):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoSwitch some more StringBuilder/jsNontrivialString code to use
barraclough@apple.com [Mon, 8 Feb 2010 23:04:34 +0000 (23:04 +0000)]
Switch some more StringBuilder/jsNontrivialString code to use
JSStringBuilder/jsMakeNontrivialString - these methods will
throw an exception if we hit out-of-memory, rather than just
CRASHing.

Reviewed by Geoff Garen.

* runtime/FunctionPrototype.cpp:
(JSC::functionProtoFuncToString):
* runtime/JSGlobalObjectFunctions.cpp:
(JSC::encode):
(JSC::decode):
(JSC::globalFuncEscape):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Backport No'am Rosenthal's frame rate measurement
kenneth@webkit.org [Mon, 8 Feb 2010 22:58:50 +0000 (22:58 +0000)]
[Qt] Backport No'am Rosenthal's frame rate measurement

Reviewed by Ariya Hidayat.

* QtLauncher/main.cpp:
(LauncherWindow::LauncherWindow):
(LauncherApplication::handleUserOptions):
* QtLauncher/webview.cpp:
(WebViewGraphicsBased::WebViewGraphicsBased):
(WebViewGraphicsBased::enableFrameRateMeasurement):
(WebViewGraphicsBased::updateFrameRate):
(WebViewGraphicsBased::paintEvent):
* QtLauncher/webview.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-08 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Mon, 8 Feb 2010 22:43:07 +0000 (22:43 +0000)]
2010-02-08  Nate Chapin  <japhet@chromium.org>

        Reviewed by Darin Fisher.

        Check that the index passed into BackForwardListClientImpl::itemAtIndex()
        is valid, and return null if it isn't.

        https://bugs.webkit.org/show_bug.cgi?id=34722

        * src/BackForwardListClientImpl.cpp:
        (WebKit::BackForwardListClientImpl::itemAtIndex):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUse an empty identifier instead of a null identifier for parse
barraclough@apple.com [Mon, 8 Feb 2010 22:26:59 +0000 (22:26 +0000)]
Use an empty identifier instead of a null identifier for parse
tokens without an identifier.

Reviewed by Sam Weinig.

This helps encapsulate the null UStringImpl within UString.

* parser/Grammar.y:
* parser/NodeConstructors.h:
(JSC::ContinueNode::ContinueNode):
(JSC::BreakNode::BreakNode):
(JSC::ForInNode::ForInNode):
* runtime/CommonIdentifiers.cpp:
(JSC::CommonIdentifiers::CommonIdentifiers):
* runtime/CommonIdentifiers.h:
* runtime/FunctionPrototype.cpp:
(JSC::FunctionPrototype::FunctionPrototype):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-08 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Mon, 8 Feb 2010 21:55:50 +0000 (21:55 +0000)]
2010-02-08  Dirk Schulze  <krit@webkit.org>

        Unreviewed build fix of ChromiumWin.

        * platform/graphics/chromium/TransparencyWin.cpp:
        (WebCore::):
        (WebCore::TransparencyWin::setupLayerForOpaqueCompositeLayer):
        (WebCore::TransparencyWin::setupTransformForKeepTransform):
        * platform/graphics/chromium/TransparencyWin.h:
        * rendering/RenderThemeChromiumWin.cpp:
        (WebCore::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-08 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Mon, 8 Feb 2010 21:48:12 +0000 (21:48 +0000)]
2010-02-08  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        [GTK] Implement FrameLoaderClient::hasWebView
        https://bugs.webkit.org/show_bug.cgi?id=34682

        Used for sanity-check ASSERTS in the FrameLoader code.

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::hasWebView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Put the test back on skipped list - it needs a newer version of Safari to...
ap@apple.com [Mon, 8 Feb 2010 21:35:24 +0000 (21:35 +0000)]
    Put the test back on skipped list - it needs a newer version of Safari to pass.

        * platform/mac-snowleopard/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore: Adding a way to get the set of all open database handles pointing
dumi@chromium.org [Mon, 8 Feb 2010 21:20:01 +0000 (21:20 +0000)]
WebCore: Adding a way to get the set of all open database handles pointing
to a given database.
https://bugs.webkit.org/show_bug.cgi?id=34619

Reviewed by Jeremy Orlow.

Sometimes we need to be able to close all handles to a database as
soon as possible (to delete the DB file, for example).

* storage/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::getOpenDatabases):
* storage/DatabaseTracker.h:
* storage/chromium/DatabaseTrackerChromium.cpp:
(WebCore::DatabaseTracker::addOpenDatabase):
(WebCore::DatabaseTracker::removeOpenDatabase):
(WebCore::DatabaseTracker::getOpenDatabases):

WebKit/chromium: Adding a way to close all database handles pointing to a certain
database as soon as possible.
https://bugs.webkit.org/show_bug.cgi?id=34619

Reviewed by Jeremy Orlow.

* public/WebDatabase.h:
* src/WebDatabase.cpp:
(WebKit::WebDatabase::closeDatabaseImmediately):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-08 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Mon, 8 Feb 2010 20:55:42 +0000 (20:55 +0000)]
2010-02-08  Dirk Schulze  <krit@webkit.org>

        Unreviewed windows build-fix.

        * page/win/FrameCGWin.cpp:
        (WebCore::drawRectIntoContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Anders Carlsson.
ap@apple.com [Mon, 8 Feb 2010 20:53:49 +0000 (20:53 +0000)]
    Reviewed by Anders Carlsson.

        <rdar://problem/6530010> OOP: Support NPN_SetException

        Tested by plugins/netscape-throw-exception.html (removed it from skipped list).

        * Plugins/Hosted/NetscapePluginHostProxy.mm:
        (WKPCSetException):
        * Plugins/Hosted/NetscapePluginInstanceProxy.h:
        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::globalExceptionString):
        (WebKit::NetscapePluginInstanceProxy::setGlobalException):
        (WebKit::NetscapePluginInstanceProxy::moveGlobalExceptionToExecState):
        * Plugins/Hosted/ProxyInstance.mm:
        (WebKit::ProxyInstance::invoke):
        (WebKit::ProxyInstance::getPropertyNames):
        (WebKit::ProxyInstance::fieldValue):
        (WebKit::ProxyInstance::setFieldValue):
        * Plugins/Hosted/WebKitPluginClient.defs:
        Route exception string to a global that's checked after calling into plug-in (just like in
        in-process case).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-08 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Mon, 8 Feb 2010 20:30:42 +0000 (20:30 +0000)]
2010-02-08  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        Add back an AffineTransform class for use by SVG
        https://bugs.webkit.org/show_bug.cgi?id=33750

        This adds back AffineTransform. This saves additional 4% memory consumption
        on the 50k rects stress test: https://bugs.webkit.org/attachment.cgi?id=46721
        It also makes it possible to optimize the calculations internally of
        AffineTransform to the needs of 2D transformations (the second benefit for SVG,
        which uses transformations relative often at the moment.
        Everything that is 2D related (like images, patterns, gradients, fonts), uses
        AffineTransform now.

        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSSVGMatrixCustom.cpp:
        (WebCore::JSSVGMatrix::multiply):
        (WebCore::JSSVGMatrix::inverse):
        (WebCore::JSSVGMatrix::rotateFromVector):
        * bindings/js/JSSVGPODTypeWrapper.h:
        * bindings/scripts/CodeGeneratorJS.pm:
        * bindings/scripts/CodeGeneratorObjC.pm:
        * bindings/scripts/CodeGeneratorV8.pm:
        * bindings/v8/V8Index.h:
        * bindings/v8/custom/V8SVGMatrixCustom.cpp:
        (WebCore::V8SVGMatrix::multiplyCallback):
        (WebCore::V8SVGMatrix::inverseCallback):
        (WebCore::V8SVGMatrix::rotateFromVectorCallback):
        * html/HTMLCanvasElement.cpp: Changed to AffineTransform now
        (WebCore::HTMLCanvasElement::baseTransform):
        * html/HTMLCanvasElement.h:
        * platform/graphics/FloatPoint.cpp:
        (WebCore::FloatPoint::matrixTransform):
        * platform/graphics/FloatPoint.h:
        * platform/graphics/GeneratedImage.cpp:
        (WebCore::GeneratedImage::drawPattern):
        * platform/graphics/GeneratedImage.h:
        * platform/graphics/Gradient.cpp:
        (WebCore::Gradient::setGradientSpaceTransform):
        (WebCore::Gradient::setPlatformGradientSpaceTransform):
        * platform/graphics/Gradient.h:
        (WebCore::Gradient::gradientSpaceTransform):
        * platform/graphics/GraphicsContext.h:
        * platform/graphics/Image.cpp:
        (WebCore::Image::drawTiled):
        * platform/graphics/Image.h:
        * platform/graphics/ImageBuffer.h:
        (WebCore::ImageBuffer::baseTransform):
        * platform/graphics/Path.h:
        * platform/graphics/Pattern.cpp:
        (WebCore::Pattern::setPatternSpaceTransform):
        * platform/graphics/Pattern.h:
        (WebCore::Pattern::create):
        (WebCore::Pattern::tileImage):
        * platform/graphics/cairo/FontCairo.cpp:
        (WebCore::Font::drawGlyphs):
        * platform/graphics/cairo/GraphicsContextCairo.cpp:
        (WebCore::setPlatformFill):
        (WebCore::setPlatformStroke):
        (WebCore::GraphicsContext::getCTM):
        * platform/graphics/cairo/ImageCairo.cpp:
        (WebCore::Image::drawPattern):
        * platform/graphics/cairo/PathCairo.cpp:
        * platform/graphics/cairo/PatternCairo.cpp:
        (WebCore::Pattern::createPlatformPattern):
        * platform/graphics/cg/GraphicsContextCG.cpp:
        (WebCore::GraphicsContext::getCTM):
        * platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:
        (WebCore::GraphicsContextPlatformPrivate::concatCTM):
        * platform/graphics/cg/ImageCG.cpp:
        (WebCore::Image::drawPattern):
        * platform/graphics/cg/PathCG.cpp:
        * platform/graphics/cg/PatternCG.cpp:
        (WebCore::Pattern::createPlatformPattern):
        * platform/graphics/haiku/GraphicsContextHaiku.cpp:
        (WebCore::GraphicsContext::getCTM):
        * platform/graphics/haiku/ImageHaiku.cpp:
        (WebCore::Image::drawPattern):
        * platform/graphics/haiku/PathHaiku.cpp:
        * platform/graphics/qt/FontQt.cpp:
        (WebCore::Font::drawComplexText):
        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::getCTM):
        (WebCore::GraphicsContext::fillPath):
        (WebCore::GraphicsContext::strokePath):
        (WebCore::GraphicsContext::fillRect):
        * platform/graphics/qt/ImageQt.cpp:
        (WebCore::Image::drawPattern):
        * platform/graphics/qt/PathQt.cpp:
        * platform/graphics/qt/PatternQt.cpp:
        (WebCore::Pattern::createPlatformPattern):
        * platform/graphics/skia/GradientSkia.cpp:
        (WebCore::Gradient::setPlatformGradientSpaceTransform):
        * platform/graphics/skia/GraphicsContextSkia.cpp:
        (WebCore::GraphicsContext::getCTM):
        * platform/graphics/skia/ImageSkia.cpp:
        (WebCore::Image::drawPattern):
        * platform/graphics/skia/PathSkia.cpp:
        * platform/graphics/skia/PatternSkia.cpp:
        (WebCore::Pattern::platformPattern):
        * platform/graphics/skia/SkiaFontWin.cpp:
        (WebCore::windowsCanHandleTextDrawing):
        * platform/graphics/transforms/AffineTransform.cpp:
        (WebCore::AffineTransform::makeIdentity): needed by some parts of WebCore
        (WebCore::AffineTransform::scale): Didn't scale the complete matrix
        (WebCore::AffineTransform::translate): Didn't respect other transformations
        (WebCore::AffineTransform::shear): direct calculation, no extra multiply of matrices
        (WebCore::AffineTransform::map):
        (WebCore::AffineTransform::mapPoint):
        (WebCore::AffineTransform::mapRect):
        * platform/graphics/transforms/AffineTransform.h:
        (WebCore::AffineTransform::isIdentityOrTranslation):
        * platform/graphics/transforms/TransformationMatrix.cpp:
        (WebCore::TransformationMatrix::toAffineTransform):
        * platform/graphics/transforms/TransformationMatrix.h:
        * platform/graphics/win/FontCGWin.cpp:
        (WebCore::drawGDIGlyphs):
        * platform/graphics/win/GraphicsContextCGWin.cpp:
        * platform/graphics/win/GraphicsContextCairoWin.cpp:
        * platform/graphics/win/GraphicsContextWin.cpp:
        (WebCore::GraphicsContextPlatformPrivate::concatCTM):
        * platform/graphics/wince/FontWince.cpp:
        * platform/graphics/wince/GraphicsContextWince.cpp:
        (WebCore::GraphicsContextPlatformPrivate::concatCTM):
        (WebCore::GraphicsContext::fillPath):
        (WebCore::GraphicsContext::strokePath):
        (WebCore::GraphicsContext::getCTM):
        (WebCore::GraphicsContext::drawBitmapPattern):
        * platform/graphics/wince/ImageBufferWince.cpp:
        (WebCore::):
        (WebCore::BufferedImage::drawPattern):
        * platform/graphics/wince/PathWince.cpp:
        (WebCore::Path::transform):
        * platform/graphics/wince/PlatformPathWince.cpp:
        (WebCore::drawPolygons):
        (WebCore::PathPolygon::transform):
        (WebCore::PlatformPathElement::transform):
        (WebCore::PlatformPath::strokePath):
        (WebCore::PlatformPath::fillPath):
        (WebCore::PlatformPath::transform):
        * platform/graphics/wince/PlatformPathWince.h:
        (WebCore::):
        * platform/graphics/wx/GraphicsContextWx.cpp:
        (WebCore::GraphicsContext::getCTM):
        * platform/graphics/wx/ImageWx.cpp:
        (WebCore::BitmapImage::drawPattern):
        (WebCore::Image::drawPattern):
        * platform/graphics/wx/PathWx.cpp:
        * platform/gtk/RenderThemeGtk.cpp:
        (WebCore::paintMozillaGtkWidget):
        * plugins/win/PluginViewWin.cpp:
        (WebCore::PluginView::paintWindowedPluginIntoContext):
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::localTransform):
        * rendering/RenderBox.h:
        * rendering/RenderBoxModelObject.cpp:
        (WebCore::RenderBoxModelScaleData::RenderBoxModelScaleData):
        (WebCore::RenderBoxModelScaleData::transform):
        (WebCore::RenderBoxModelScaleData::setTransform):
        (WebCore::RenderBoxModelScaleObserver::shouldPaintBackgroundAtLowQuality):
        (WebCore::RenderBoxModelObject::paintBoxShadow):
        * rendering/RenderForeignObject.cpp:
        (WebCore::RenderForeignObject::translationForAttributes):
        (WebCore::RenderForeignObject::localToParentTransform):
        * rendering/RenderForeignObject.h:
        (WebCore::RenderForeignObject::localTransform):
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::paintLayer):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::localTransform):
        (WebCore::RenderObject::localToParentTransform):
        (WebCore::RenderObject::absoluteTransform):
        * rendering/RenderObject.h:
        * rendering/RenderPath.cpp:
        (WebCore::RenderPath::localToParentTransform):
        (WebCore::RenderPath::localTransform):
        * rendering/RenderPath.h:
        * rendering/RenderSVGHiddenContainer.h:
        (WebCore::RenderSVGHiddenContainer::absoluteTransform):
        * rendering/RenderSVGImage.h:
        (WebCore::RenderSVGImage::localToParentTransform):
        (WebCore::RenderSVGImage::localTransform):
        * rendering/RenderSVGRoot.cpp:
        (WebCore::RenderSVGRoot::localToBorderBoxTransform):
        (WebCore::RenderSVGRoot::localToRepaintContainerTransform):
        (WebCore::RenderSVGRoot::localToParentTransform):
        (WebCore::RenderSVGRoot::absoluteTransform):
        (WebCore::RenderSVGRoot::localTransform):
        * rendering/RenderSVGRoot.h:
        * rendering/RenderSVGText.h:
        (WebCore::RenderSVGText::localToParentTransform):
        (WebCore::RenderSVGText::localTransform):
        * rendering/RenderSVGTransformableContainer.cpp:
        (WebCore::RenderSVGTransformableContainer::localToParentTransform):
        (WebCore::RenderSVGTransformableContainer::localTransform):
        (WebCore::RenderSVGTransformableContainer::calculateLocalTransform):
        * rendering/RenderSVGTransformableContainer.h:
        * rendering/RenderSVGViewportContainer.cpp:
        (WebCore::RenderSVGViewportContainer::markerBoundaries):
        (WebCore::RenderSVGViewportContainer::markerContentTransformation):
        (WebCore::RenderSVGViewportContainer::viewportTransform):
        (WebCore::RenderSVGViewportContainer::localToParentTransform):
        (WebCore::RenderSVGViewportContainer::absoluteTransform):
        * rendering/RenderSVGViewportContainer.h:
        * rendering/SVGCharacterLayoutInfo.cpp:
        (WebCore::SVGChar::characterTransform):
        * rendering/SVGCharacterLayoutInfo.h:
        (WebCore::SVGTextChunkWalker::operator()):
        * rendering/SVGInlineTextBox.cpp:
        (WebCore::SVGInlineTextBox::calculateGlyphBoundaries):
        (WebCore::SVGInlineTextBoxClosestCharacterToPositionWalker::chunkPortionCallback):
        (WebCore::SVGInlineTextBoxSelectionRectWalker::chunkPortionCallback):
        (WebCore::SVGInlineTextBox::paintCharacters):
        (WebCore::SVGInlineTextBox::paintDecoration):
        * rendering/SVGMarkerLayoutInfo.h:
        (WebCore::MarkerLayout::MarkerLayout):
        * rendering/SVGRenderSupport.cpp:
        (WebCore::applyTransformToPaintInfo):
        * rendering/SVGRenderSupport.h:
        * rendering/SVGRenderTreeAsText.cpp:
        (WebCore::operator<<):
        * rendering/SVGRenderTreeAsText.h:
        * rendering/SVGRootInlineBox.cpp:
        (WebCore::SVGRootInlineBoxPaintWalker::chunkPortionCallback):
        (WebCore::applyTextLengthCorrectionToTextChunk):
        (WebCore::SVGRootInlineBox::buildLayoutInformation):
        * rendering/TransformState.cpp:
        (WebCore::TransformState::applyTransform):
        * rendering/TransformState.h:
        * svg/GradientAttributes.h:
        (WebCore::GradientAttributes::gradientTransform):
        (WebCore::GradientAttributes::setGradientTransform):
        * svg/PatternAttributes.h:
        (WebCore::PatternAttributes::patternTransform):
        (WebCore::PatternAttributes::setPatternTransform):
        * svg/SVGAnimateMotionElement.cpp:
        (WebCore::SVGAnimateMotionElement::resetToBaseValue):
        (WebCore::SVGAnimateMotionElement::calculateAnimatedValue):
        (WebCore::SVGAnimateMotionElement::applyResultsToTarget):
        * svg/SVGAnimateMotionElement.h:
        * svg/SVGAnimateTransformElement.cpp:
        * svg/SVGAnimateTransformElement.h:
        * svg/SVGElement.h:
        (WebCore::SVGElement::supplementalTransform):
        * svg/SVGFitToViewBox.cpp:
        (WebCore::SVGFitToViewBox::viewBoxToViewTransform):
        * svg/SVGFitToViewBox.h:
        * svg/SVGLocatable.cpp:
        (WebCore::SVGLocatable::getCTM):
        (WebCore::SVGLocatable::getScreenCTM):
        (WebCore::SVGLocatable::getTransformToElement):
        * svg/SVGLocatable.h:
        * svg/SVGMarkerElement.cpp:
        (WebCore::SVGMarkerElement::viewBoxToViewTransform):
        * svg/SVGMarkerElement.h:
        * svg/SVGMaskElement.cpp:
        (WebCore::SVGMaskElement::drawMaskerContent):
        * svg/SVGMatrix.idl:
        * svg/SVGPatternElement.cpp:
        (WebCore::SVGPatternElement::buildPattern):
        * svg/SVGPreserveAspectRatio.cpp:
        (WebCore::SVGPreserveAspectRatio::getCTM):
        * svg/SVGPreserveAspectRatio.h:
        * svg/SVGSVGElement.cpp:
        (WebCore::SVGSVGElement::viewport):
        (WebCore::SVGSVGElement::createSVGMatrix):
        (WebCore::SVGSVGElement::createSVGTransformFromMatrix):
        (WebCore::SVGSVGElement::getCTM):
        (WebCore::SVGSVGElement::getScreenCTM):
        (WebCore::SVGSVGElement::viewBoxToViewTransform):
        * svg/SVGSVGElement.h:
        * svg/SVGStyledLocatableElement.cpp:
        (WebCore::SVGStyledLocatableElement::getCTM):
        (WebCore::SVGStyledLocatableElement::getScreenCTM):
        * svg/SVGStyledLocatableElement.h:
        * svg/SVGStyledTransformableElement.cpp:
        (WebCore::SVGStyledTransformableElement::getCTM):
        (WebCore::SVGStyledTransformableElement::getScreenCTM):
        (WebCore::SVGStyledTransformableElement::animatedLocalTransform):
        (WebCore::SVGStyledTransformableElement::supplementalTransform):
        * svg/SVGStyledTransformableElement.h:
        (WebCore::SVGStyledTransformableElement::isStyledTransformable):
        (WebCore::SVGStyledTransformableElement::toPathData):
        * svg/SVGTextContentElement.cpp:
        (WebCore::SVGInlineTextBoxQueryWalker::chunkPortionCallback):
        * svg/SVGTextElement.cpp:
        (WebCore::SVGTextElement::getScreenCTM):
        (WebCore::SVGTextElement::getCTM):
        (WebCore::SVGTextElement::animatedLocalTransform):
        (WebCore::SVGTextElement::supplementalTransform):
        * svg/SVGTextElement.h:
        * svg/SVGTextPathElement.cpp:
        * svg/SVGTransform.cpp:
        (SVGTransform::SVGTransform):
        (SVGTransform::matrix):
        (SVGTransform::setMatrix):
        * svg/SVGTransform.h:
        * svg/SVGTransformDistance.cpp:
        (WebCore::SVGTransformDistance::SVGTransformDistance):
        (WebCore::SVGTransformDistance::scaledDistance):
        (WebCore::SVGTransformDistance::isZero):
        * svg/SVGTransformDistance.h:
        * svg/SVGTransformList.cpp:
        (SVGTransformList::createSVGTransformFromMatrix):
        (SVGTransformList::concatenate):
        (SVGTransformList::valueAsString):
        * svg/SVGTransformList.h:
        * svg/SVGTransformable.cpp:
        (WebCore::SVGTransformable::getCTM):
        (WebCore::SVGTransformable::getScreenCTM):
        (WebCore::SVGTransformable::parseTransformValue):
        * svg/SVGTransformable.h:
        (WebCore::SVGTransformable::):
        * svg/graphics/SVGPaintServerGradient.cpp:
        (WebCore::SVGPaintServerGradient::gradientTransform):
        (WebCore::SVGPaintServerGradient::setGradientTransform):
        (WebCore::clipToTextMask):
        (WebCore::SVGPaintServerGradient::setup):
        * svg/graphics/SVGPaintServerGradient.h:
        * svg/graphics/SVGPaintServerPattern.cpp:
        (WebCore::SVGPaintServerPattern::patternTransform):
        (WebCore::SVGPaintServerPattern::setPatternTransform):
        (WebCore::SVGPaintServerPattern::setup):
        * svg/graphics/SVGPaintServerPattern.h:
        * svg/graphics/SVGResourceClipper.cpp:
        (WebCore::SVGResourceClipper::applyClip):
        * svg/graphics/SVGResourceMarker.cpp:
        (WebCore::SVGResourceMarker::markerTransformation):
        (WebCore::SVGResourceMarker::draw):
        * svg/graphics/SVGResourceMarker.h:
        * svg/graphics/filters/SVGFEImage.cpp:
        * svg/graphics/filters/SVGFETile.cpp:
        (WebCore::FETile::apply):

2010-02-08  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        Add back an AffineTransform class for use by SVG
        https://bugs.webkit.org/show_bug.cgi?id=33750

        Some negative zero problems fixed, but new one were added on other places. A seperate
        patch should fix it all at once.
        use-on-disallowed-foreign-object-3 and 4 had wrong results. The old SVG code
        with TransformationMatrix used translateRight, that was wrong at this place and is
        fixed now.

        * platform/mac/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/fonts-elem-01-t-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/fonts-elem-02-t-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/fonts-elem-03-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/fonts-elem-07-b-expected.txt:
        * platform/mac/svg/custom/use-on-disallowed-foreign-object-3-expected.txt:
        * platform/mac/svg/custom/use-on-disallowed-foreign-object-4-expected.txt:
        * svg/dom/SVGMatrix-interface-expected.txt:
        * svg/dom/SVGMatrix-interface.xhtml:

2010-02-08  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        Add back an AffineTransform class for use by SVG
        https://bugs.webkit.org/show_bug.cgi?id=33750

        Use AffineTransform instead of TransformationMatrix here.

        * tests/TransparencyWinTest.cpp:
        (WebCore::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-08 Stephen White <senorblanco@chromium.org>
senorblanco@chromium.org [Mon, 8 Feb 2010 20:25:21 +0000 (20:25 +0000)]
2010-02-08  Stephen White  <senorblanco@chromium.org>

        Reviewed by Dimitri Glazkov.

        Make an inline function containing a static var out-of-line.  This is
        a workaround for Xcode 3.1 bug radar 7070016.  We tripped on this in
        deviceRGBColorSpaceRef on the Chromium canaries.  This is a proactive
        fix for the same problem in sRGBColorSpaceRef().

        https://bugs.webkit.org/show_bug.cgi?id=34663

        * platform/graphics/cg/GraphicsContextCG.cpp:
        (WebCore::sRGBColorSpaceRef):
        * platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Make overridePreference complain when it does not
kenneth@webkit.org [Mon, 8 Feb 2010 19:42:42 +0000 (19:42 +0000)]
[Qt] Make overridePreference complain when it does not
support the preference given.

Reviewed by Tor Arne Vestbø.

* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::overridePreference):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-08 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Mon, 8 Feb 2010 19:32:10 +0000 (19:32 +0000)]
2010-02-08  Nate Chapin  <japhet@chromium.org>

        Reviewed by Dimitri Glazkov.

        [V8] Unify the WorkerContext V8 object wrapping code with
        the standard V8 object wrapping code.

        https://bugs.webkit.org/show_bug.cgi?id=34658

        * bindings/scripts/CodeGeneratorV8.pm:
        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::instantiateV8Object):
        (WebCore::V8DOMWrapper::convertEventTargetToV8Object):
        * bindings/v8/V8WorkerContextEventListener.cpp:
        (WebCore::V8WorkerContextEventListener::handleEvent):
        (WebCore::V8WorkerContextEventListener::getReceiverObject):
        * bindings/v8/WorkerContextExecutionProxy.cpp:
        * bindings/v8/WorkerContextExecutionProxy.h:
        * bindings/v8/custom/V8NotificationCenterCustom.cpp:
        (WebCore::V8NotificationCenter::createHTMLNotificationCallback):
        (WebCore::V8NotificationCenter::createNotificationCallback):
        * bindings/v8/custom/V8WorkerContextCustom.cpp:
        (WebCore::toV8):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-08 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Mon, 8 Feb 2010 19:18:52 +0000 (19:18 +0000)]
2010-02-08  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Xan Lopez.

        Bump version to 1.1.21, and adjust library versioning accordingly.

        * configure.ac:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBuild fix, add needed export
bweinstein@apple.com [Mon, 8 Feb 2010 18:54:24 +0000 (18:54 +0000)]
Build fix, add needed export

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago[Qt] Set stdout/stderr to binary mode for DRT on Windows
vestbo@webkit.org [Mon, 8 Feb 2010 18:30:16 +0000 (18:30 +0000)]
[Qt] Set stdout/stderr to binary mode for DRT on Windows

Reviewed by Kenneth Rohde Christiansen.

This makes sure we don't end up with lots of CRLFs in the
DRT output, which breaks tons of results. Matches what
the Windows DRT does.

* DumpRenderTree/qt/main.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-08 Kwang Yul Seo <skyul@company100.net>
eric@webkit.org [Mon, 8 Feb 2010 18:21:59 +0000 (18:21 +0000)]
2010-02-08  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Darin Adler.

        Use fastStrDup instead of strdup
        https://bugs.webkit.org/show_bug.cgi?id=33943

        Replace strdup/free with fastStrDup/fastFree.

        * bridge/IdentifierRep.h:
        (WebCore::IdentifierRep::IdentifierRep):
        * bridge/jni/JNIBridge.cpp:
        (JavaMethod::~JavaMethod):
        (appendClassName):
        (JavaMethod::signature):
        * bridge/jni/jsc/JavaClassJSC.cpp:
        (JavaClass::JavaClass):
        (JavaClass::~JavaClass):
        * platform/network/curl/ResourceHandleCurl.cpp:
        (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
        * platform/network/curl/ResourceHandleManager.cpp:
        (WebCore::ResourceHandleManager::~ResourceHandleManager):
        (WebCore::ResourceHandleManager::setCookieJarFileName):
        (WebCore::ResourceHandleManager::initializeHandle):
        * plugins/PluginStream.cpp:
        (WebCore::PluginStream::~PluginStream):
        (WebCore::PluginStream::startStream):
        * xml/XSLTProcessorLibxslt.cpp:
        (WebCore::xsltParamArrayFromParameterMap):
        (WebCore::freeXsltParamArray):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoInclude header position in World Transform used for plugin positioning.
bfulgham@webkit.org [Mon, 8 Feb 2010 18:20:57 +0000 (18:20 +0000)]
Include header position in World Transform used for plugin positioning.
https://bugs.webkit.org/show_bug.cgi?id=34709

Reviewed by Adam Roben.

* WebFrame.cpp:
(WebFrame::spoolPage): Correct WinCairo plugin print positioning to
  account for header size.  Existing code ignored this, causing
  plugins to overlay other elements.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBuild fix for Qt on Windows.
vestbo@webkit.org [Mon, 8 Feb 2010 17:37:25 +0000 (17:37 +0000)]
Build fix for Qt on Windows.

Reviewed by Kenneth Rohde Christiansen.

Don't use noreturn directly since it's a gcc attribute.
Instead use the NO_RETURN macro from AlwaysInline.h

* QtLauncher/QtLauncher.pro:
* QtLauncher/utils.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-08 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Mon, 8 Feb 2010 17:33:05 +0000 (17:33 +0000)]
2010-02-08  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Fix last problematic SVG testcase, update coords-trans-01-b.svg win results, marking the end of the baseline regeneration for all platforms.

        * platform/win/svg/W3C-SVG-1.1/coords-trans-01-b-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-08 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Mon, 8 Feb 2010 16:09:25 +0000 (16:09 +0000)]
2010-02-08  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Should turn Qt slave green again, all platform specific results updated.

        * platform/qt/svg/filters/subRegion-one-effect-expected.txt:
        * platform/qt/svg/filters/subRegion-two-effects-expected.txt:
        * platform/qt/svg/text/selection-background-color-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix Qt build on Windows.
vestbo@webkit.org [Mon, 8 Feb 2010 16:06:16 +0000 (16:06 +0000)]
Fix Qt build on Windows.

Reviewed by Simon Hausmann.

nmake fails to pick the right cpp file, so we have to
rename the file to to a unique name.

* WebCore.pro:
* platform/graphics/qt/FontCustomPlatformDataQt.cpp: Renamed from WebCore/platform/graphics/qt/FontCustomPlatformData.cpp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-08 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Mon, 8 Feb 2010 16:01:39 +0000 (16:01 +0000)]
2010-02-08  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Hopefully the last set of updates for Gtk/Qt/Win/Mac.

        * platform/gtk/svg/custom/text-zoom-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/animate-elem-82-t-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/coords-trans-01-b-expected.txt:
        * platform/qt/svg/filters/feComposite-expected.txt:
        * platform/qt/svg/filters/feGaussianBlur-expected.txt:
        * platform/qt/svg/filters/feMerge-expected.txt:
        * platform/qt/svg/filters/feMerge-wrong-input-expected.txt:
        * platform/qt/svg/filters/feOffset-expected.txt:
        * platform/qt/svg/filters/feTile-expected.txt:
        * platform/qt/svg/filters/filter-source-position-expected.txt:
        * platform/qt/svg/filters/shadow-on-filter-expected.txt:
        * platform/qt/svg/filters/shadow-on-rect-with-filter-expected.txt:
        * platform/qt/svg/filters/sourceAlpha-expected.txt:
        * platform/qt/svg/filters/subRegion-in-userSpace-expected.txt:
        * platform/win/svg/custom/inline-svg-in-xhtml-expected.txt:
        * platform/win/svg/hixie/mixed/003-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoNotify user that run-webkit-tests has to be run under Cygwin
vestbo@webkit.org [Mon, 8 Feb 2010 15:57:55 +0000 (15:57 +0000)]
Notify user that run-webkit-tests has to be run under Cygwin

Reviewed by Simon Hausmann.

The script will bail out if run under Windows shell or Msys.

* Scripts/run-webkit-tests:
* Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-08 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Mon, 8 Feb 2010 15:39:23 +0000 (15:39 +0000)]
2010-02-08  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Attempt to fix all mac/win bots (expect for leopard which already passes)

        * platform/mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt:
        * platform/mac/svg/custom/junk-data-expected.txt:
        * platform/mac/svg/custom/missing-xlink-expected.txt:
        * platform/mac/svg/hixie/error/012-expected.txt:
        * platform/mac/svg/text/text-intro-05-t-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-08 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Mon, 8 Feb 2010 15:09:26 +0000 (15:09 +0000)]
2010-02-08  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Next set of Qt DRT result updates.

        * platform/qt/svg/custom/js-update-image-and-display-expected.txt:
        * platform/qt/svg/custom/js-update-image-and-display3-expected.txt:
        * platform/qt/svg/custom/marker-opacity-expected.txt:
        * platform/qt/svg/custom/marker-referencePoint-expected.txt:
        * platform/qt/svg/custom/marker-strokeWidth-changes-expected.txt:
        * platform/qt/svg/custom/mask-with-default-value-expected.txt:
        * platform/qt/svg/custom/relative-sized-deep-shadow-tree-content-expected.txt:
        * platform/qt/svg/custom/relative-sized-shadow-tree-content-expected.txt:
        * platform/qt/svg/custom/relative-sized-use-on-symbol-expected.txt:
        * platform/qt/svg/custom/text-xy-updates-SVGList-expected.txt:
        * platform/qt/svg/custom/transformedMaskFails-expected.txt:
        * platform/qt/svg/custom/use-on-symbol-inside-pattern-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-08 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Mon, 8 Feb 2010 15:04:13 +0000 (15:04 +0000)]
2010-02-08  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Update mac-tiger specific SVG results.

        * platform/mac-tiger/svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
        * platform/mac-tiger/svg/hixie/text/003-expected.txt:
        * platform/mac-tiger/svg/hixie/text/003a-expected.txt:
        * platform/mac-tiger/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt:
        * platform/mac-tiger/svg/hixie/viewbox/preserveAspectRatio/002-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-08 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Mon, 8 Feb 2010 14:59:22 +0000 (14:59 +0000)]
2010-02-08  Nikolas Zimmermann  <nzimmermann@rim.com>

        Not reviewed. Fixing first set of platform specific SVG results for the Qt port.
        Unfortunately the bots exit after 20 test failures, so I can't fix the whole set of expected txt files in one go :(

        * platform/qt/svg/css/arrow-with-shadow-expected.txt:
        * platform/qt/svg/css/circle-in-mask-with-shadow-expected.txt:
        * platform/qt/svg/css/clippath-with-shadow-expected.txt:
        * platform/qt/svg/css/mask-with-shadow-expected.txt:
        * platform/qt/svg/css/path-with-shadow-expected.txt:
        * platform/qt/svg/css/shadow-and-opacity-expected.txt: Added.
        * platform/qt/svg/css/shadow-with-large-radius-expected.txt: Added.
        * platform/qt/svg/css/shadow-with-negative-offset-expected.txt: Added.
        * platform/qt/svg/css/stars-with-shadow-expected.txt:
        * platform/qt/svg/custom/createImageElement-expected.txt:
        * platform/qt/svg/custom/createImageElement2-expected.txt:
        * platform/qt/svg/custom/empty-mask-expected.txt:
        * platform/qt/svg/custom/js-repaint-rect-on-path-with-stroke-expected.txt: Added.
        * platform/qt/svg/custom/js-update-image-and-display2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-08 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Mon, 8 Feb 2010 14:26:33 +0000 (14:26 +0000)]
2010-02-08  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        All SVG *-expected.txt files contain wrong results
        https://bugs.webkit.org/show_bug.cgi?id=34703

        Finally dump meaningful information for SVG layout tests.
        Use 'absoluteClippedOverflowRect' which goes through the same code paths used
        to actually calculate repaint rects etc - instead of the legacy CSS-unaware
        code path that mapped 'repaintRectInLocalCoordinates' through 'absoluteTransform'.
        Remove absoluteTransform() - a long standing TODO, finally not needed anymore.

        Despite SVGRenderTreeAsText, SVGPaintServerGradient was also using absoluteTransform().
        Rewrite the code in question, fixing svg/W3C-SVG-1.1/pserver-grad-08-b.svg alignment issues
        when scaling/panning text using gradient on stroke/fill. Affects some other gradient tests as well.

        As we're now dumping clipped overflow rects any problems with repaint rects will become
        immediate visible - it turns out we're not supporting the overflow rules on the outermost <svg>
        element properly (repaint rects and bounding boxes need to take special SVG overflow rules into account).
        Fixing that magically gives pixel-perfect clipped overflow rects for all types of shapes/text/containers.

        Note: This will break any overriden platform-specific SVG results, need to wait for build bots in order to update them.

        * rendering/RenderObject.cpp: Remove absoluteTransform() method, centralize overflow query code in SVGRenderSupport::isOverflowHidden().
        * rendering/RenderObject.h: Remove absoluteTransform() method.
        * rendering/RenderSVGHiddenContainer.h: Ditto.
        * rendering/RenderSVGRoot.cpp:
        (WebCore::RenderSVGRoot::paint): Use SVGRenderSupport::isOverflowHidden() to query SVG overflow mode.
        (WebCore::RenderSVGRoot::computeRectForRepaint): Respect SVG overflow rules here: clip repaintRect against overflow rect _before_ passing
                                                         along to RenderBox. This is the key issue behind wrong absoluteClippedOverflowRect() values.
        (WebCore::RenderSVGRoot::nodeAtPoint): Use SVGRenderSupport::isOverflowHidden() to query SVG overflow mode.
        * rendering/RenderSVGRoot.h: Remove absoluteTransform(). Don't expose viewportSize() anymore.
        * rendering/RenderSVGText.cpp:
        (WebCore::RenderSVGText::strokeBoundingBox): Fix default stroke width to 1. This was the only wrong place -> fixes repaint rects for stroked text.
        * rendering/RenderSVGViewportContainer.cpp: Remove absoluteTransform() method.
        (WebCore::RenderSVGViewportContainer::pointIsInsideViewportClip): Use SVGRenderSupport::isOverflowHidden() to query SVG overflow mode.
        * rendering/RenderSVGViewportContainer.h: Remove absoluteTransform() method.
        * rendering/SVGRenderSupport.cpp: Refactored overflow queries in one place, centralizing SVG specific assumptions about overflowX/Y.
        (WebCore::SVGRenderBase::isOverflowHidden):
        * rendering/SVGRenderSupport.h:
        * rendering/SVGRenderTreeAsText.cpp: Dump absoluteClippedOverflowRect() instead of absoluteTransform().mapRect(repaintRectInLocalCoordinates()).
        (WebCore::writePositionAndStyle): Affects all layout tests dumping render trees.
        * svg/graphics/SVGPaintServerGradient.cpp: Rewrite Gradient on text fill/stroke support on Cg, to avoid using absoluteTransform().
        (WebCore::absoluteTransformForRenderer):
        (WebCore::createMaskAndSwapContextForTextGradient):
        (WebCore::clipToTextMask):
        (WebCore::SVGPaintServerGradient::setup):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoSuppressed check-webkit-style's underscore check in Qt's autotests.
cjerdonek@webkit.org [Mon, 8 Feb 2010 13:26:01 +0000 (13:26 +0000)]
Suppressed check-webkit-style's underscore check in Qt's autotests.
Also made the path-specific filter check case-insensitive.

Reviewed by Shinichiro Hamaji.

https://bugs.webkit.org/show_bug.cgi?id=34574

* Scripts/webkitpy/style/checker.py:
  - Added a list element to _PATH_RULES_SPECIFIER for
    directories that should be excluded from the
    "readability/naming" category (the category that relates to
    underscores in identifiers, for example).

* Scripts/webkitpy/style/checker_unittest.py:
  - Added an "end-to-end" test for "WebKit/qt/tests/".

* Scripts/webkitpy/style/filter.py:
  - Altered FilterConfiguration's should_check() method to
    check for path substring matches case-insensitively.

* Scripts/webkitpy/style/filter_unittest.py:
  - Added a test to check case-insensitive path substring matching.

* Scripts/webkitpy/style/processors/cpp.py:
  - Removed the hard-coded "WebKit/gtk/webkit/" path reference
    since this is now taken care of by the _PATH_RULES_SPECIFIER
    configuration variable.

* Scripts/webkitpy/style/processors/cpp_unittest.py:
  - Removed the unit test for the GTK directory since this
    is now taken care of by the checker._PATH_RULES_SPECIFIER
    end-to-end tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBuild fix for make distcheck.
kov@webkit.org [Mon, 8 Feb 2010 13:21:38 +0000 (13:21 +0000)]
Build fix for make distcheck.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-08 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Mon, 8 Feb 2010 13:06:34 +0000 (13:06 +0000)]
2010-02-08  Xan Lopez  <xlopez@igalia.com>

        Try to do some clean-up in our Skipped list.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-08 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Mon, 8 Feb 2010 12:47:19 +0000 (12:47 +0000)]
2010-02-08  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        Generate new results for this test.

        * platform/gtk/editing/execCommand/indent-paragraphs-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-08 Tony Chang <tony@chromium.org>
eric@webkit.org [Mon, 8 Feb 2010 11:04:37 +0000 (11:04 +0000)]
2010-02-08  Tony Chang  <tony@chromium.org>

        Reviewed by Darin Adler.

        Convert editing/execCommand/indent-paragraphs.html to use dumpAsText.
        The test copies HTML to the text output, so it doesn't really need
        to dump the render tree.

        The test was added in r49985, but didn't include pixel results.
        https://bugs.webkit.org/show_bug.cgi?id=34625

        * platform/mac/editing/execCommand/indent-paragraphs-expected.txt: Modified.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-08 Leith Bade <leith@leithalweapon.geek.nz>
eric@webkit.org [Mon, 8 Feb 2010 10:48:17 +0000 (10:48 +0000)]
2010-02-08  Leith Bade  <leith@leithalweapon.geek.nz>

        Reviewed by Darin Adler.

        Fixes: https://bugs.webkit.org/show_bug.cgi?id=34637
        Corrects the newline inserted into WebKitOutputDir, and WebKitLibrariesDir Windows
        environemnt variables when there is a space in the user's /home path.

        * Scripts/webkitdirs.pm:
         - Added missing quotes around $sourceDir in argument list of cygpath in determineWindowsSourceDir().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed RVCT build fix.
hausmann@webkit.org [Mon, 8 Feb 2010 09:33:12 +0000 (09:33 +0000)]
Unreviewed RVCT build fix.

Similar to r54391, don't import the cmath functions from std:: for RVCT.

* wtf/MathExtras.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-07 Tony Chang <tony@chromium.org>
tony@chromium.org [Mon, 8 Feb 2010 00:42:00 +0000 (00:42 +0000)]
2010-02-07  Tony Chang  <tony@chromium.org>

        Reviewed by Darin Adler.

        Fix 2 pixel test baselines that are incorrect but passing
        the fuzzy image diff.

        editing/deleting/5390681.html should show a cursor, but doesn't.
        In r42549, whitespace collapsing was changed but
        editing/pasteboard/5387578.html's result wasn't updated to
        reflect the collapsed whitespace.
        https://bugs.webkit.org/show_bug.cgi?id=34632

        * platform/mac/editing/deleting/5390681-2-expected.checksum:
        * platform/mac/editing/deleting/5390681-2-expected.png:
        * platform/mac/editing/pasteboard/5387578-expected.checksum:
        * platform/mac/editing/pasteboard/5387578-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-07 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Sun, 7 Feb 2010 22:26:34 +0000 (22:26 +0000)]
2010-02-07  Daniel Bates  <dbates@webkit.org>

        Unreviewed, fix Tiger layout test failure.

        https://bugs.webkit.org/show_bug.cgi?id=34402

        Adds expected layout test results for Tiger build.

        * platform/mac-tiger/fast/lists/w3-css3-list-styles-numeric-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-07 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Sun, 7 Feb 2010 21:43:17 +0000 (21:43 +0000)]
2010-02-07  Daniel Bates  <dbates@webkit.org>

        Unreviewed, fix layout test bots.

        https://bugs.webkit.org/show_bug.cgi?id=34402

        Adds expected layout test results for Leopard, Windows, and Qt ports.

        * platform/mac-leopard/fast/lists: Added.
        * platform/mac-leopard/fast/lists/w3-css3-list-styles-numeric-expected.txt: Added.
        * platform/qt/fast/lists/w3-css3-list-styles-numeric-expected.txt: Added.
        * platform/win/fast/lists/w3-css3-list-styles-numeric-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-07 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Sun, 7 Feb 2010 21:08:10 +0000 (21:08 +0000)]
2010-02-07  Daniel Bates  <dbates@webkit.org>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=34402

        Implements all of the numeric CSS3 list-style-types as per
        section 4.3 of the CSS3 Lists module <http://www.w3.org/TR/css3-lists/#numeric>.

        Test: fast/lists/w3-css3-list-styles-numeric.html

        * css/CSSPrimitiveValueMappings.h:
        (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
        * css/CSSValueKeywords.in:
        * inspector/front-end/SourceCSSTokenizer.re2js:
        * platform/text/CharacterNames.h: Added constant hyphenMinus.
        * rendering/RenderListMarker.cpp:
        (WebCore::): Defined enum SequenceType.
        (WebCore::toAlphabeticOrNumeric): Added.
        (WebCore::toAlphabetic): Modified to call WebCore::toAlphabeticOrNumeric.
        (WebCore::toNumeric): Added.
        (WebCore::listMarkerSuffix):
        (WebCore::listMarkerText):
        (WebCore::RenderListMarker::paint):
        (WebCore::RenderListMarker::calcPrefWidths):
        (WebCore::RenderListMarker::getRelativeMarkerRect):
        * rendering/style/RenderStyle.h:
        (WebCore::):
        * rendering/style/RenderStyleConstants.h: Added numeric list style types
        and fixed indent level for the enum values.
        (WebCore::):
2010-02-07  Daniel Bates  <dbates@webkit.org>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=34402

        Tests that all of the numeric CSS3 list-style-types are supported.

        * fast/lists/w3-css3-list-styles-numeric.html: Added.
        * platform/mac/fast/lists/w3-css3-list-styles-numeric-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-07 Ismail Donmez <ismail@namtrac.org>
eric@webkit.org [Sun, 7 Feb 2010 20:47:15 +0000 (20:47 +0000)]
2010-02-07  Ismail Donmez  <ismail@namtrac.org>

        Reviewed by Darin Adler.

        Include wtf/StringExtras.h for strdup definition, which
        is needed for WinCE.

        * bridge/IdentifierRep.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-07 Pavel Feldman <pfeldman@chromium.org>
eric@webkit.org [Sun, 7 Feb 2010 12:52:21 +0000 (12:52 +0000)]
2010-02-07  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Fragment-held Elements Not Shown in Inspector.

        https://bugs.webkit.org/show_bug.cgi?id=34680

        * inspector/console-dirxml-expected.txt:
        * inspector/console-dirxml.html:
2010-02-07  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Fragment-held Elements Not Shown in Inspector.

        https://bugs.webkit.org/show_bug.cgi?id=34680

        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::pushChildNodesToFrontend):
        (WebCore::InspectorDOMAgent::buildObjectForNode):
        * inspector/front-end/ElementsTreeOutline.js:
        (WebInspector.ElementsTreeElement.prototype._nodeTitleInfo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-07 Jian Li <jianli@chromium.org>
eric@webkit.org [Sun, 7 Feb 2010 12:35:36 +0000 (12:35 +0000)]
2010-02-07  Jian Li  <jianli@chromium.org>

        Reviewed by Darin Fisher.

        [chromium] Change chromium interface to handle DownloadURL format.
        https://bugs.webkit.org/show_bug.cgi?id=34655

        * platform/chromium/ChromiumDataObject.cpp:
        (WebCore::ChromiumDataObject::clear):
        (WebCore::ChromiumDataObject::hasData):
        (WebCore::ChromiumDataObject::ChromiumDataObject):
        * platform/chromium/ChromiumDataObject.h:
        * platform/chromium/ClipboardChromium.cpp:
        (WebCore::ClipboardChromium::setData):
2010-02-07  Jian Li  <jianli@chromium.org>

        Reviewed by Darin Fisher.

        [chromium] Change chromium interface to handle DownloadURL format.
        https://bugs.webkit.org/show_bug.cgi?id=34655

        * public/WebDragData.h:
        * src/WebDragData.cpp:
        (WebKit::WebDragData::downloadMetadata):
        (WebKit::WebDragData::setDownloadMetadata):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRubber-stamped by Kenneth Rohde Christiansen.
ossy@webkit.org [Sun, 7 Feb 2010 11:42:48 +0000 (11:42 +0000)]
Rubber-stamped by Kenneth Rohde Christiansen.

[Qt] Missing fast/frames/flattening/resources/frameset-flattening-subframe-resize.html
https://bugs.webkit.org/show_bug.cgi?id=34662

Missing file added from the original bug: https://bugs.webkit.org/show_bug.cgi?id=32717

* fast/frames/flattening/resources: Added.
* fast/frames/flattening/resources/frameset-flattening-subframe-resize.html: Added.
* platform/qt/Skipped: frameset-flattening-subframe-resize.html unskipped.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-06 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Sat, 6 Feb 2010 20:18:51 +0000 (20:18 +0000)]
2010-02-06  Dimitri Glazkov  <dglazkov@chromium.org>

        No review, rolling out r54364.
        http://trac.webkit.org/changeset/54364
        https://bugs.webkit.org/show_bug.cgi?id=34464

        Introduced asserts in layout tests, needs more testing
        locally.

        * accessibility/chromium/AXObjectCacheChromium.cpp:
        (WebCore::AXObjectCache::postPlatformNotification):
        * page/chromium/ChromeClientChromium.h:
2010-02-06  Dimitri Glazkov  <dglazkov@chromium.org>

        No review, rolling out r54364.
        http://trac.webkit.org/changeset/54364
        https://bugs.webkit.org/show_bug.cgi?id=34464

        Introduced asserts in layout tests, needs more testing
        locally.

        * public/WebViewClient.h:
        * src/ChromeClientImpl.cpp:
        * src/ChromeClientImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-06 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Sat, 6 Feb 2010 19:02:34 +0000 (19:02 +0000)]
2010-02-06  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Adam Barth.

        Using inlines and function-level statics don't mix, according to gcc.
        https://bugs.webkit.org/show_bug.cgi?id=34663

        De-inline deviceRGBColorSpaceRef to avoid gcc-bug landmines.

        It appears that the initialization check, generated by gcc doesn't account
        for a possibility that the function may be inlined, resulting in lazy
        initialization failure for more than one inlined instance of the function.

        No behavior change, so no new tests.

        * platform/graphics/cg/GraphicsContextCG.cpp:
        (WebCore::deviceRGBColorSpaceRef):
        * platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoChange UStringImpl::create to CRASH if the string cannot be allocated,
barraclough@apple.com [Sat, 6 Feb 2010 08:55:31 +0000 (08:55 +0000)]
Change UStringImpl::create to CRASH if the string cannot be allocated,
rather than returning a null string (which will behave like a zero-length
string if used).

Reviewed by Geoff Garen.

Also move createRep function from UString to become new overloaded
UStringImpl::create methods.  In doing so, bring their behaviour closer to
being in line with WebCore::StringImpl, in removing the behaviour that they
can be used to produce null UStrings (ASSERT the char* provided is non-null).
This behaviour of converting null C-strings to null UStrings is inefficient
(cmompared to just using UString::null()), incompatible with WebCore::StringImpl's
behaviour, and may generate unexpected behaviour, since in many cases a null
UString can be used like an empty string.

With these changes UStringImpl need not have a concept of null impls, we can
start transitioning this to become an implementation detail of UString, that
internally it chooses to use a null-object rather than an actually zero impl
pointer.

* JavaScriptCore.exp:
* debugger/Debugger.cpp:
(JSC::Debugger::recompileAllJSFunctions):
* debugger/DebuggerCallFrame.cpp:
(JSC::DebuggerCallFrame::calculatedFunctionName):
* parser/Parser.cpp:
(JSC::Parser::parse):
* profiler/Profile.cpp:
(JSC::Profile::Profile):
* profiler/ProfileGenerator.cpp:
(JSC::ProfileGenerator::stopProfiling):
* runtime/Error.cpp:
(JSC::Error::create):
(JSC::throwError):
* runtime/ExceptionHelpers.cpp:
(JSC::createError):
* runtime/Identifier.cpp:
(JSC::Identifier::add):
* runtime/PropertyNameArray.cpp:
(JSC::PropertyNameArray::add):
* runtime/UString.cpp:
(JSC::initializeUString):
(JSC::UString::UString):
(JSC::UString::operator=):
* runtime/UString.h:
(JSC::UString::isNull):
(JSC::UString::null):
(JSC::UString::rep):
(JSC::UString::UString):
* runtime/UStringImpl.cpp:
(JSC::UStringImpl::create):
* runtime/UStringImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Oliver Hunt.
ap@apple.com [Sat, 6 Feb 2010 06:32:07 +0000 (06:32 +0000)]
    Reviewed by Oliver Hunt.

        https://bugs.webkit.org/show_bug.cgi?id=34670
        TestNetscapePlugin should work with Firefox

        * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: (NPP_New): Default to Carbon if
        browser doesn't tell what it supports.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-05 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Sat, 6 Feb 2010 05:37:58 +0000 (05:37 +0000)]
2010-02-05  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Gustavo Noronha Silva.

        [Gtk] Implement layoutTestController.pageNumberForElementById
        https://bugs.webkit.org/show_bug.cgi?id=34572

        * platform/gtk/Skipped:
2010-02-05  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Gustavo Noronha Silva.

        [Gtk] Implement layoutTestController.pageNumberForElementById
        https://bugs.webkit.org/show_bug.cgi?id=34572

        * webkit/webkitprivate.h:
        * webkit/webkitwebframe.cpp:
        (webkit_web_frame_page_number_for_element_by_id):
2010-02-05  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Gustavo Noronha Silva.

        [Gtk] Implement layoutTestController.pageNumberForElementById
        https://bugs.webkit.org/show_bug.cgi?id=34572

        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
        (LayoutTestController::pageNumberForElementById):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdded an ASSERT to catch an implausible but theoretically possible leak.
ggaren@apple.com [Sat, 6 Feb 2010 04:25:52 +0000 (04:25 +0000)]
Added an ASSERT to catch an implausible but theoretically possible leak.

Reviewed by Dan Bernstein.

In theory, if malloc allocated a UChar buffer directly after a StringImpl,
the StringImpl might incorrecly assume that the UChar buffer was inline,
and fail to delete it.

This ASSERT is somewhat academic, since we don't use the same allocator
in debug builds, but oh well.

* platform/text/StringImpl.cpp:
(WebCore::StringImpl::StringImpl):
(WebCore::StringImpl::createUninitialized):
* platform/text/StringImpl.h: Separated the inline buffer StringImpl
constructor from the out-of-line buffer StringImpl constructor. Made
the former ASSERT that its buffer was indeed inline, and the latter ASSERT
that its buffer was indeed not inline.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRemoved these special Windows expected results because they represented
ggaren@apple.com [Sat, 6 Feb 2010 02:50:44 +0000 (02:50 +0000)]
Removed these special Windows expected results because they represented
incorrect behavior, fixed by a recent patch of mine.

Reviewed by Beth Dakin.

* platform/win/fast/events/mouse-drag-from-frame-to-other-frame-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-05 James Hawkins <jhawkins@chromium.org>
eric@webkit.org [Sat, 6 Feb 2010 02:44:55 +0000 (02:44 +0000)]
2010-02-05  James Hawkins  <jhawkins@chromium.org>

        Reviewed by David Levin.

        [Chromium] Rename autocomplete* to suggestions* to prepare for the
        refactoring of AutocompletePopupMenuClient.

        https://bugs.webkit.org/show_bug.cgi?id=34664

        * public/WebView.h:
        * src/AutocompletePopupMenuClient.cpp:
        (WebKit::AutocompletePopupMenuClient::popupDidHide):
        * src/EditorClientImpl.cpp:
        (WebKit::EditorClientImpl::textFieldDidEndEditing):
        (WebKit::EditorClientImpl::doAutofill):
        * src/WebViewImpl.cpp:
        (WebKit::):
        (WebKit::WebViewImpl::WebViewImpl):
        (WebKit::WebViewImpl::mouseDown):
        (WebKit::WebViewImpl::autocompleteHandleKeyEvent):
        (WebKit::WebViewImpl::setFocus):
        (WebKit::WebViewImpl::applyAutofillSuggestions):
        (WebKit::WebViewImpl::hideAutofillPopup):
        (WebKit::WebViewImpl::hideSuggestionsPopup):
        (WebKit::WebViewImpl::refreshSuggestionsPopup):
        * src/WebViewImpl.h:
        (WebKit::WebViewImpl::suggestionsPopupDidHide):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-05 Kwang Yul Seo <skyul@company100.net>
eric@webkit.org [Sat, 6 Feb 2010 02:28:06 +0000 (02:28 +0000)]
2010-02-05  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Eric Seidel.

        [BREWMP] Define SYSTEM_MALLOC 1
        https://bugs.webkit.org/show_bug.cgi?id=34640

        Make BREWMP use system malloc because FastMalloc is not ported.

        * wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-05 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Sat, 6 Feb 2010 01:30:24 +0000 (01:30 +0000)]
2010-02-05  Eric Carlson  <eric.carlson@apple.com>

        Unreviewed revert of r54454, until I can generate new results

        * media/video-loop-expected.txt:
        * media/video-loop.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Fixed changed virtual function in GraphicsLayerCACF and call order issues
cmarrin@apple.com [Sat, 6 Feb 2010 01:10:58 +0000 (01:10 +0000)]
    Fixed changed virtual function in GraphicsLayerCACF and call order issues
        https://bugs.webkit.org/show_bug.cgi?id=34348

        The correct virtual function in GraphicsLayerCACF is now being
        called. We also fixed an issue in QTMovieWin where the size
        of the movie was not being set correctly because the call order
        was changed.

        I also changed the order of a couple of calls in QTMovieWin to account
        for changed calling order from the logic above.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-05 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Sat, 6 Feb 2010 00:49:11 +0000 (00:49 +0000)]
2010-02-05  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Oliver Hunt.

        https://bugs.webkit.org/show_bug.cgi?id=33671
        [GTK] media/video-loop.html fails intermittently on Gtk Bots

        Rewrite test to make it less timing dependent.

        * media/video-loop-expected.txt:
        * media/video-loop.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-03 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Sat, 6 Feb 2010 00:41:31 +0000 (00:41 +0000)]
2010-02-03  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Eric Seidel.

        Add a simple test implementation and the WebKit Mac implementation
        for the layout_tests/port package. Also add a simple test driver of
        that interface.

        https://bugs.webkit.org/show_bug.cgi?id=34511

        * Scripts/webkitpy/layout_tests/driver_test.py: Added.
        * Scripts/webkitpy/layout_tests/port/__init__.py:
        * Scripts/webkitpy/layout_tests/port/mac.py: Added.
        * Scripts/webkitpy/layout_tests/port/test.py: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-03 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Sat, 6 Feb 2010 00:01:04 +0000 (00:01 +0000)]
2010-02-03  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Eric Siedel.

        Refactor the port package into an object-oriented style and merge
        path_utils into it. We add a 'base' and a 'chromium' object to the
        port package; this will allow us to easily add new ports (like
        WebKit Mac).

        https://bugs.webkit.org/show_bug.cgi?id=34511

        * Scripts/rebaseline-chromium-webkit-tests:
        * Scripts/run-chromium-webkit-tests:
        * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
        * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_files.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_shell_thread.py:
        * Scripts/webkitpy/layout_tests/port/__init__.py:
        * Scripts/webkitpy/layout_tests/port/apache_http_server.py:
        * Scripts/webkitpy/layout_tests/port/base.py: Added.
        * Scripts/webkitpy/layout_tests/port/chromium.py: Added.
        * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
        * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
        * Scripts/webkitpy/layout_tests/port/chromium_win.py:
        * Scripts/webkitpy/layout_tests/port/http_server.py:
        * Scripts/webkitpy/layout_tests/port/http_server_base.py:
        * Scripts/webkitpy/layout_tests/port/path_utils.py: Removed.
        * Scripts/webkitpy/layout_tests/port/websocket_server.py:
        * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:
        * Scripts/webkitpy/layout_tests/run_chromium_webkit_tests.py:
        * Scripts/webkitpy/layout_tests/test_types/fuzzy_image_diff.py:
        * Scripts/webkitpy/layout_tests/test_types/image_diff.py:
        * Scripts/webkitpy/layout_tests/test_types/test_type_base.py:
        * Scripts/webkitpy/layout_tests/test_types/text_diff.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2010-02-05 James Hawkins <jhawkins@chromium.org>
eric@webkit.org [Fri, 5 Feb 2010 23:11:12 +0000 (23:11 +0000)]
2010-02-05  James Hawkins  <jhawkins@chromium.org>

        Reviewed by David Levin.

        [Chromium] Remove an unused forward declaration in WebKitClient.h.

        https://bugs.webkit.org/show_bug.cgi?id=34622

        * public/WebKitClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Mark Rowe.
kdecker@apple.com [Fri, 5 Feb 2010 22:53:14 +0000 (22:53 +0000)]
    Reviewed by Mark Rowe.

        https://bugs.webkit.org/show_bug.cgi?id=34661
        <rdar://problem/7614067> REGRESSION (Safari 4.0-> Safari 4.0.4): NPP_SetWindow no longer sets a clipRect of (0,0,0,0) when it becomes hidden

        * Plugins/Hosted/WebHostedNetscapePluginView.mm:
        (-[WebHostedNetscapePluginView updateAndSetWindow]): When clipping out NPDrawingModelCoreAnimation plug-ins, provide a zero'd out clipRect.
        * Plugins/WebBaseNetscapePluginView.h: Moved superviewsHaveSuperviews to the base class.
        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView superviewsHaveSuperviews]): Added to the base class; extracted from WebNetscapePluginView.
        (-[WebBaseNetscapePluginView shouldClipOutPlugin]): Added new method with code extracted from WebNetscapePluginView.
        * Plugins/WebNetscapePluginView.mm:
        (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]): When clipping out NPDrawingModelCoreAnimation plug-ins, provide a zero'd out clipRect.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoHorizontal scrollbar works in reverse at milliondollarcu.be
enrica@apple.com [Fri, 5 Feb 2010 22:40:59 +0000 (22:40 +0000)]
Horizontal scrollbar works in reverse at milliondollarcu.be
<rdar://problem/7556121>
https://bugs.webkit.org/show_bug.cgi?id=33848

Reviewed by Simon Fraser.

Added a manual test.

* manual-tests/win: Added.
* manual-tests/win/horizontal-scroll-composited.html: Added.
* platform/graphics/win/WKCACFLayerRenderer.cpp:
(WebCore::WKCACFLayerRenderer::setScrollFrame):
(WebCore::WKCACFLayerRenderer::setRootChildLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRubber-stamped by Kenneth Rohde Christiansen.
ossy@webkit.org [Fri, 5 Feb 2010 22:24:29 +0000 (22:24 +0000)]
Rubber-stamped by Kenneth Rohde Christiansen.

[Qt] Missing fast/frames/flattening/resources/frameset-flattening-subframe-resize.html
https://bugs.webkit.org/show_bug.cgi?id=34662

* platform/qt/Skipped: fast/frames/flattening/frameset-flattening-subframe-resize.html skipped until fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRubber-stamped by Kenneth Rohde Christiansen.
ossy@webkit.org [Fri, 5 Feb 2010 22:04:11 +0000 (22:04 +0000)]
Rubber-stamped by Kenneth Rohde Christiansen.

Update expected results after r54441 to make buildbot happy.

* platform/qt/fast/frames/flattening/frameset-flattening-advanced-expected.txt: Updated.
* platform/qt/fast/frames/flattening/frameset-flattening-subframesets-expected.txt: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@54444 268f45cc-cd09-0410-ab3c-d52691b4dbfc