WebKit-https.git
10 years ago2011-04-25 Leo Yang <leo.yang@torchmobile.com.cn>
leo.yang@torchmobile.com.cn [Tue, 26 Apr 2011 02:04:12 +0000 (02:04 +0000)]
2011-04-25  Leo Yang  <leo.yang@torchmobile.com.cn>

        Reviewed by Nikolas Zimmermann.

        ASSERT failure in SVGUseElement
        https://bugs.webkit.org/show_bug.cgi?id=59313

        In SVGUseElement::insertedIntoDocument(), ASSERT(!m_isPendingResource)
        was wrong because the document may not be well-formed.

        This patch asserts the element is not pending on resource or the
        document is not well-formed.

        Test: svg/custom/use-crash-in-non-wellformed-document.svg

        * svg/SVGUseElement.cpp:
        (WebCore::isWellFormedDocument):
        (WebCore::SVGUseElement::insertedIntoDocument):
2011-04-25  Leo Yang  <leo.yang@torchmobile.com.cn>

        Reviewed by Nikolas Zimmermann.

        ASSERT failure in SVGUseElement
        https://bugs.webkit.org/show_bug.cgi?id=59313

        Test case to verify webkit doesn't crash when a <use> element
        is pending on resource and the document is not well-formed.
        Test passes if no crash occurs in debug mode.

        * svg/custom/use-crash-in-non-wellformed-document-expected.txt: Added.
        * svg/custom/use-crash-in-non-wellformed-document.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Tue, 26 Apr 2011 02:02:29 +0000 (02:02 +0000)]
2011-04-25  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Tony Chang.

        Convert fast/loader/start-load-in-unload.html to dumpAsText
        https://bugs.webkit.org/show_bug.cgi?id=59384

        * fast/loader/start-load-in-unload-expected.txt: Added.
        * fast/loader/start-load-in-unload.html:
        * platform/chromium-linux/fast/loader/start-load-in-unload-expected.png: Removed.
        * platform/chromium-win/fast/loader/start-load-in-unload-expected.png: Removed.
        * platform/chromium-win/fast/loader/start-load-in-unload-expected.txt: Removed.
        * platform/gtk/fast/loader/start-load-in-unload-expected.png: Removed.
        * platform/gtk/fast/loader/start-load-in-unload-expected.txt: Removed.
        * platform/mac-leopard/fast/loader/start-load-in-unload-expected.png: Removed.
        * platform/mac/fast/loader/start-load-in-unload-expected.png: Removed.
        * platform/mac/fast/loader/start-load-in-unload-expected.txt: Removed.
        * platform/qt/fast/loader/start-load-in-unload-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Tony Chang <tony@chromium.org>
tony@chromium.org [Tue, 26 Apr 2011 01:59:27 +0000 (01:59 +0000)]
2011-04-25  Tony Chang  <tony@chromium.org>

        Reviewed by Antonio Gomes.

        replace a setTimeout with a onload event to save 2 seconds in a test
        https://bugs.webkit.org/show_bug.cgi?id=59350

        * http/tests/security/xssAuditor/meta-tag-http-refresh-javascript-url.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Tue, 26 Apr 2011 01:44:00 +0000 (01:44 +0000)]
2011-04-25  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Ojan Vafai.

        Convert fast/events/event-sender-mouse-moved.html to dumpAsText
        https://bugs.webkit.org/show_bug.cgi?id=59366

        * fast/events/event-sender-mouse-moved-expected.txt: Added.
        * fast/events/event-sender-mouse-moved.html:
        * platform/chromium-linux/fast/events/event-sender-mouse-moved-expected.png: Removed.
        * platform/chromium-win/fast/events/event-sender-mouse-moved-expected.png: Removed.
        * platform/chromium-win/fast/events/event-sender-mouse-moved-expected.txt: Removed.
        * platform/gtk/fast/events/event-sender-mouse-moved-expected.txt: Removed.
        * platform/mac-leopard/fast/events/event-sender-mouse-moved-expected.png: Removed.
        * platform/mac/fast/events/event-sender-mouse-moved-expected.png: Removed.
        * platform/mac/fast/events/event-sender-mouse-moved-expected.txt: Removed.
        * platform/qt/fast/events/event-sender-mouse-moved-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=59405
barraclough@apple.com [Tue, 26 Apr 2011 01:40:25 +0000 (01:40 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=59405
DFG JIT - add type speculation for integer & array types, for vars & args.

Reviewed by Geoff Garen.

If a var or argument is used as the base for a GetByVal or PutByVal access
we are speculating that it is of type Array (we only generate code on the
speculative path to perform array accesses). By typing the var or args slot
as Array, and checking on entry to the function (in the case of args), and
each time the local is written to, we can avoid a type check at each point
the array is accessed. This will typically hoist type checks out of loops.

Similarly, any local that is incremented or decremented, or is the input or
output or a bitwise operator, is likely to be an integer. By typing the
local as int32 we can avoid speculation checks on access, and tagging when
writing to the slot. All accesses can become 32bit instead of 64.

* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::set):
(JSC::DFG::ByteCodeParser::predictArray):
(JSC::DFG::ByteCodeParser::predictInt32):
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGGraph.h:
(JSC::DFG::PredictionSlot::PredictionSlot):
(JSC::DFG::Graph::Graph):
(JSC::DFG::Graph::predict):
(JSC::DFG::Graph::getPrediction):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileFunction):
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::tagFor):
(JSC::DFG::JITCompiler::payloadFor):
* dfg/DFGNode.h:
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::checkArgumentTypes):
(JSC::DFG::SpeculativeJIT::initializeVariableTypes):
* dfg/DFGSpeculativeJIT.h:
* runtime/Executable.cpp:
(JSC::tryDFGCompile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Tue, 26 Apr 2011 01:23:23 +0000 (01:23 +0000)]
2011-04-25  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, expectations change. Remove tests that are no longer
        failing.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Igor Oliveira <igor.oliveira@openbossa.org>
commit-queue@webkit.org [Tue, 26 Apr 2011 00:31:36 +0000 (00:31 +0000)]
2011-04-25  Igor Oliveira  <igor.oliveira@openbossa.org>

        Reviewed by Tony Chang.

        Move complexity from DataTransferItemsChromium and DataTransferItemChromium for base class
        https://bugs.webkit.org/show_bug.cgi?id=59028

        The DataTransferItemsChromium and DataTransferItemChromium code can be reused by other platforms.
        Moving the code for base class we can reduce the efforts to support DataTransferItems
        element in different platforms.

        * Android.mk:
        * CMakeLists.txt:
        * GNUmakefile.list.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * dom/DataTransferItem.cpp:
        (WebCore::DataTransferItem::DataTransferItem):
        (WebCore::DataTransferItem::owner):
        (WebCore::DataTransferItem::kind):
        (WebCore::DataTransferItem::type):
        * dom/DataTransferItem.h:
        * dom/DataTransferItems.cpp: Copied from Source/WebCore/platform/chromium/DataTransferItemsChromium.cpp.
        (WebCore::DataTransferItems::DataTransferItems):
        (WebCore::DataTransferItems::length):
        (WebCore::DataTransferItems::item):
        (WebCore::DataTransferItems::deleteItem):
        (WebCore::DataTransferItems::clear):
        (WebCore::DataTransferItems::add):
        * dom/DataTransferItems.h:
        * platform/chromium/DataTransferItemChromium.cpp:
        (WebCore::DataTransferItem::create):
        (WebCore::DataTransferItemChromium::DataTransferItemChromium):
        (WebCore::DataTransferItemChromium::getAsString):
        (WebCore::DataTransferItemChromium::getAsFile):
        * platform/chromium/DataTransferItemChromium.h:
        * platform/chromium/DataTransferItemsChromium.cpp:
        (WebCore::DataTransferItemsChromium::DataTransferItemsChromium):
        * platform/chromium/DataTransferItemsChromium.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Chris Marrin <cmarrin@apple.com>
cmarrin@apple.com [Tue, 26 Apr 2011 00:24:54 +0000 (00:24 +0000)]
2011-04-25  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Simon Fraser.

        REGRESSION(75137): directly composited images are double-drawn sometimes
        https://bugs.webkit.org/show_bug.cgi?id=58632

        Depending on the order of operations (layout, creating compositing
        layers and creating simple image layers) a layer can have both image
        content and have m_drawsContent=true. In this case 2 copies of the image
        are drawn in the layer. If the image has alpha, it looks wrong.

        I added an updateDrawsContent() call after setting the image contents
        to make sure it's correct.

        I couldn't create a test case that shows the problem because layerTreeAsText()
        doesn't emit enough info to show this level of detail. I've opened
        https://bugs.webkit.org/show_bug.cgi?id=59352 to fix that.

        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::updateImageContents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix OwnPtr strict mode violation in MessageQueue.h
levin@chromium.org [Tue, 26 Apr 2011 00:18:00 +0000 (00:18 +0000)]
Fix OwnPtr strict mode violation in MessageQueue.h
https://bugs.webkit.org/show_bug.cgi?id=59400

Reviewed by James Robinson.

* wtf/MessageQueue.h:
(WTF::::waitForMessage):
(WTF::::waitForMessageFilteredWithTimeout):
(WTF::::tryGetMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Kenneth Russell <kbr@google.com>
abarth@webkit.org [Tue, 26 Apr 2011 00:13:01 +0000 (00:13 +0000)]
2011-04-25  Kenneth Russell  <kbr@google.com>

        Reviewed by David Levin.

        Fix OwnPtr strict errors in InlineFlowBox.cpp
        https://bugs.webkit.org/show_bug.cgi?id=59392

        * rendering/InlineFlowBox.cpp:
        (WebCore::InlineFlowBox::setLayoutOverflow):
        (WebCore::InlineFlowBox::setVisualOverflow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Kenneth Russell <kbr@google.com>
abarth@webkit.org [Tue, 26 Apr 2011 00:11:09 +0000 (00:11 +0000)]
2011-04-25  Kenneth Russell  <kbr@google.com>

        Reviewed by David Levin.

        Fix OwnPtr strict errors in TransformState.cpp
        https://bugs.webkit.org/show_bug.cgi?id=59380

        * rendering/TransformState.cpp:
        (WebCore::TransformState::applyTransform):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 26 Apr 2011 00:07:41 +0000 (00:07 +0000)]
2011-04-25  Adam Barth  <abarth@webkit.org>

        Reviewed by James Robinson.

        DOMWindow.cpp should work with strict OwnPtrs
        https://bugs.webkit.org/show_bug.cgi?id=59356

        * page/DOMWindow.cpp:
        (WebCore::PostMessageTimer::fired):
        (WebCore::DOMWindow::postMessageTimerFired):
        * page/DOMWindow.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Adam Klein <adamk@chromium.org>
adamk@chromium.org [Tue, 26 Apr 2011 00:06:17 +0000 (00:06 +0000)]
2011-04-25  Adam Klein  <adamk@chromium.org>

        Reviewed by James Robinson.

        Fix OwnPtr strict errors in some SVG classes.
        https://bugs.webkit.org/show_bug.cgi?id=59395

        * rendering/style/SVGRenderStyleDefs.cpp:
        (WebCore::StyleShadowSVGData::StyleShadowSVGData):
        * svg/SVGSVGElement.cpp:
        (WebCore::SVGSVGElement::SVGSVGElement):
        * svg/SVGStyledTransformableElement.cpp:
        (WebCore::SVGStyledTransformableElement::supplementalTransform):
        * svg/SVGTextElement.cpp:
        (WebCore::SVGTextElement::supplementalTransform):
        * svg/graphics/SVGImage.cpp:
        (WebCore::SVGImage::dataChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 26 Apr 2011 00:04:06 +0000 (00:04 +0000)]
2011-04-25  Adam Barth  <abarth@webkit.org>

        Re-land changes to ValidationMessage.

        * html/ValidationMessage.cpp:
        (WebCore::ValidationMessage::setMessage):
        (WebCore::ValidationMessage::setMessageDOMAndStartTimer):
        (WebCore::ValidationMessage::requestToHideMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Tue, 26 Apr 2011 00:00:08 +0000 (00:00 +0000)]
2011-04-25  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, build fix.

        Change FAILS_ to DISABLED_ in r84813.

        * tests/TransparencyWinTest.cpp:
        (WebCore::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Mon, 25 Apr 2011 23:56:49 +0000 (23:56 +0000)]
2011-04-25  Ojan Vafai  <ojan@chromium.org>

        Reviewed by James Robinson.

        fix OwnPtr strict error in FrameView.cpp
        https://bugs.webkit.org/show_bug.cgi?id=59402

        * page/FrameView.cpp:
        (WebCore::FrameView::FrameView):
        (WebCore::FrameView::addWidgetToUpdate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Adam Klein <adamk@chromium.org>
adamk@chromium.org [Mon, 25 Apr 2011 23:55:41 +0000 (23:55 +0000)]
2011-04-25  Adam Klein  <adamk@chromium.org>

        Unreviewed, rolling out r84844.
        http://trac.webkit.org/changeset/84844
        https://bugs.webkit.org/show_bug.cgi?id=59395

        Checked in too much.

        * rendering/style/SVGRenderStyleDefs.cpp:
        (WebCore::StyleShadowSVGData::StyleShadowSVGData):
        * svg/SVGDocumentExtensions.cpp:
        (WebCore::SVGDocumentExtensions::removePendingResource):
        * svg/SVGSVGElement.cpp:
        (WebCore::SVGSVGElement::SVGSVGElement):
        * svg/SVGStyledTransformableElement.cpp:
        (WebCore::SVGStyledTransformableElement::supplementalTransform):
        * svg/SVGTextElement.cpp:
        (WebCore::SVGTextElement::supplementalTransform):
        * svg/graphics/SVGImage.cpp:
        (WebCore::SVGImage::dataChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 25 Apr 2011 23:54:38 +0000 (23:54 +0000)]
2011-04-25  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        JavaScriptCore should play nice strict OwnPtrs
        https://bugs.webkit.org/show_bug.cgi?id=59401

        * dfg/DFGByteCodeParser.cpp:
        (JSC::DFG::ByteCodeParser::parse):
        * heap/Heap.cpp:
        (JSC::TypeCounter::TypeCounter):
        * jit/JITStubs.cpp:
        (JSC::JITThunks::JITThunks):
        * parser/JSParser.cpp:
        (JSC::JSParser::Scope::Scope):
        * yarr/YarrJIT.cpp:
        (JSC::Yarr::YarrGenerator::GenerationState::addParenthesesTail):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Adrienne Walker <enne@google.com>
enne@google.com [Mon, 25 Apr 2011 23:52:51 +0000 (23:52 +0000)]
2011-04-25  Adrienne Walker  <enne@google.com>

        Reviewed by David Levin.

        Make ActiveDOMCallback play nice with OwnPtr strict mode
        https://bugs.webkit.org/show_bug.cgi?id=59398

        * bindings/generic/ActiveDOMCallback.cpp:
        (WebCore::ActiveDOMCallback::ActiveDOMCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Adam Klein <adamk@chromium.org>
adamk@chromium.org [Mon, 25 Apr 2011 23:51:13 +0000 (23:51 +0000)]
2011-04-25  Adam Klein  <adamk@chromium.org>

        Reviewed by James Robinson.

        Fix OwnPtr strict errors in some SVG classes.
        https://bugs.webkit.org/show_bug.cgi?id=59395

        * rendering/style/SVGRenderStyleDefs.cpp:
        (WebCore::StyleShadowSVGData::StyleShadowSVGData):
        * svg/SVGSVGElement.cpp:
        (WebCore::SVGSVGElement::SVGSVGElement):
        * svg/SVGStyledTransformableElement.cpp:
        (WebCore::SVGStyledTransformableElement::supplementalTransform):
        * svg/SVGTextElement.cpp:
        (WebCore::SVGTextElement::supplementalTransform):
        * svg/graphics/SVGImage.cpp:
        (WebCore::SVGImage::dataChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 James Robinson <jamesr@chromium.org>
jamesr@google.com [Mon, 25 Apr 2011 23:45:49 +0000 (23:45 +0000)]
2011-04-25  James Robinson  <jamesr@chromium.org>

        Unreviewed, rolling out r84835.
        http://trac.webkit.org/changeset/84835
        https://bugs.webkit.org/show_bug.cgi?id=59394

        Breaks compile because Deque<OwnPtr> doesn't work

        * dom/XMLDocumentParserLibxml2.cpp:
        (WebCore::PendingCallbacks::~PendingCallbacks):
        (WebCore::PendingCallbacks::appendStartElementNSCallback):
        (WebCore::PendingCallbacks::appendEndElementNSCallback):
        (WebCore::PendingCallbacks::appendCharactersCallback):
        (WebCore::PendingCallbacks::appendProcessingInstructionCallback):
        (WebCore::PendingCallbacks::appendCDATABlockCallback):
        (WebCore::PendingCallbacks::appendCommentCallback):
        (WebCore::PendingCallbacks::appendInternalSubsetCallback):
        (WebCore::PendingCallbacks::appendErrorCallback):
        (WebCore::XMLDocumentParser::XMLDocumentParser):
        * html/ValidationMessage.cpp:
        (WebCore::ValidationMessage::setMessage):
        (WebCore::ValidationMessage::setMessageDOMAndStartTimer):
        (WebCore::ValidationMessage::requestToHideMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 James Robinson <jamesr@chromium.org>
jamesr@google.com [Mon, 25 Apr 2011 23:43:16 +0000 (23:43 +0000)]
2011-04-25  James Robinson  <jamesr@chromium.org>

        Reviewed by Sam Weinig.

        Fix OwnPtr strict mode violation in ImageBufferCG
        https://bugs.webkit.org/show_bug.cgi?id=59396

        * platform/graphics/cg/ImageBufferCG.cpp:
        (WebCore::ImageBuffer::ImageBuffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebKit2: Should be able to inspect Web Inspector in Debug Builds
bweinstein@apple.com [Mon, 25 Apr 2011 23:43:04 +0000 (23:43 +0000)]
WebKit2: Should be able to inspect Web Inspector in Debug Builds
https://bugs.webkit.org/show_bug.cgi?id=59378

Reviewed by Adam Roben.

* UIProcess/WebInspectorProxy.cpp:
(WebKit::createInspectorPageGroup): Creates an inspector page group and enables
    developer extras in a debug build.
(WebKit::WebInspectorProxy::inspectorPageGroup): Calls createInspectorPageGroup.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Sam Weinig <sam@webkit.org>
weinig@apple.com [Mon, 25 Apr 2011 23:41:59 +0000 (23:41 +0000)]
2011-04-25  Sam Weinig  <sam@webkit.org>

        Reviewed by Adam Roben.

        Leaks Viewer throws "Cannot post cyclic structures" in Safari 5
        https://bugs.webkit.org/show_bug.cgi?id=56090

        Make LeaksViewer work with versions of browsers that don't support message
        passing of cyclic structures.

        * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParser.js:
        (LeaksParser.this._worker.onmessage):
        (LeaksParser):
        (LeaksParser.prototype.addLeaksFile):
        Use LeaksParserImpl directly if we don't support passing cyclic structures.

        * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserImpl.js: Copied from BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js.
        (LeaksParserImpl):
        (LeaksParserImpl.prototype.addLeaksFile):
        (LeaksParserImpl.prototype._incorporateLeaks):
        * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
        (onmessage):
        Factor out LeaksParser implementation into LeaksParserImpl.js.

        * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/Utilities.js:
        (workersSupportCyclicStructures):
        Add function to detect if workers support passing cyclic structures.

        * BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/index.html:
        Add LeaksParserImpl.js include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoConvert a test to dump as text.
mitz@apple.com [Mon, 25 Apr 2011 23:41:46 +0000 (23:41 +0000)]
Convert a test to dump as text.

Reviewed by Sam Weinig.

* fast/dom/jsDevicePixelRatio-expected.txt: Added.
* fast/dom/jsDevicePixelRatio.html:
* platform/chromium-linux/fast/dom/jsDevicePixelRatio-expected.png: Removed.
* platform/chromium-win/fast/dom/jsDevicePixelRatio-expected.png: Removed.
* platform/chromium-win/fast/dom/jsDevicePixelRatio-expected.txt: Removed.
* platform/gtk/fast/dom/jsDevicePixelRatio-expected.png: Removed.
* platform/gtk/fast/dom/jsDevicePixelRatio-expected.txt: Removed.
* platform/mac-leopard/fast/dom/jsDevicePixelRatio-expected.png: Removed.
* platform/mac/fast/dom/jsDevicePixelRatio-expected.png: Removed.
* platform/mac/fast/dom/jsDevicePixelRatio-expected.txt: Removed.
* platform/qt/fast/dom/jsDevicePixelRatio-expected.png: Removed.
* platform/qt/fast/dom/jsDevicePixelRatio-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Huang Dongsung <luxtella@company100.net>
commit-queue@webkit.org [Mon, 25 Apr 2011 23:39:06 +0000 (23:39 +0000)]
2011-04-25  Huang Dongsung  <luxtella@company100.net>

        Reviewed by Dirk Schulze.

        [Skia] Remove an unused local variable in PlatformContextSkia::readbackHardwareToSoftware().
        https://bugs.webkit.org/show_bug.cgi?id=59308

        An unused local variable is created and even allocates heap memory.

        * platform/graphics/skia/PlatformContextSkia.cpp:
        (WebCore::PlatformContextSkia::readbackHardwareToSoftware):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoQt build fix: Updated files not used by other ports for rename.
ggaren@apple.com [Mon, 25 Apr 2011 23:37:52 +0000 (23:37 +0000)]
Qt build fix: Updated files not used by other ports for rename.

* bindings/js/JSTouchCustom.cpp:
(WebCore::toJSNewlyCreated):
* bindings/js/JSTouchListCustom.cpp:
(WebCore::toJSNewlyCreated):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Adrienne Walker <enne@google.com>
enne@google.com [Mon, 25 Apr 2011 23:36:53 +0000 (23:36 +0000)]
2011-04-25  Adrienne Walker  <enne@google.com>

        Reviewed by David Levin.

        WebCore/css/CSS* files should play nice with strict OwnPtrs
        https://bugs.webkit.org/show_bug.cgi?id=59382

        * css/CSSFontFaceSource.cpp:
        (WebCore::CSSFontFaceSource::getFontData):
        * css/CSSParser.cpp:
        (WebCore::CSSParser::addProperty):
        (WebCore::CSSParser::parseValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 25 Apr 2011 23:35:45 +0000 (23:35 +0000)]
2011-04-25  Adam Barth  <abarth@webkit.org>

        Reviewed by James Robinson.

        ValidationMessage and XMLDocumentParserLibxml2 should play nice with strict OwnPtrs
        https://bugs.webkit.org/show_bug.cgi?id=59394

        * dom/XMLDocumentParserLibxml2.cpp:
        (WebCore::PendingCallbacks::PendingCallbacks):
        (WebCore::PendingCallbacks::appendStartElementNSCallback):
        (WebCore::PendingCallbacks::appendEndElementNSCallback):
        (WebCore::PendingCallbacks::appendCharactersCallback):
        (WebCore::PendingCallbacks::appendProcessingInstructionCallback):
        (WebCore::PendingCallbacks::appendCDATABlockCallback):
        (WebCore::PendingCallbacks::appendCommentCallback):
        (WebCore::PendingCallbacks::appendInternalSubsetCallback):
        (WebCore::PendingCallbacks::appendErrorCallback):
        (WebCore::XMLDocumentParser::XMLDocumentParser):
        * html/ValidationMessage.cpp:
        (WebCore::ValidationMessage::setMessage):
        (WebCore::ValidationMessage::setMessageDOMAndStartTimer):
        (WebCore::ValidationMessage::requestToHideMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Mon, 25 Apr 2011 23:35:18 +0000 (23:35 +0000)]
2011-04-25  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, GTK rebaseline and skip a couple of failing tests.

        * platform/gtk/Skipped: skip
        http/tests/security/mixedContent/insecure-css-in-main-frame.html
        and editing/text-iterator/findString.html
        * platform/gtk/fast/dom/HTMLMeterElement/meter-element-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 James Robinson <jamesr@chromium.org>
jamesr@google.com [Mon, 25 Apr 2011 23:30:05 +0000 (23:30 +0000)]
2011-04-25  James Robinson  <jamesr@chromium.org>

        Reviewed by Adam Barth.

        Fix OwnPtr strictness issues in WebCore/inspector/
        https://bugs.webkit.org/show_bug.cgi?id=59387

        * inspector/InspectorAgent.cpp:
        (WebCore::InspectorAgent::InspectorAgent):
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::InspectorController):
        * inspector/InspectorStyleSheet.cpp:
        (WebCore::InspectorStyleSheet::ensureSourceData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemoved XPathNamespace because it was unused
ggaren@apple.com [Mon, 25 Apr 2011 23:25:27 +0000 (23:25 +0000)]
Removed XPathNamespace because it was unused
https://bugs.webkit.org/show_bug.cgi?id=59381

Reviewed by Beth Dakin.

This allows us to make Node::ownerDocument() non-virtual, though it has
the unhappy side-effect of rebuilding the world.

* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj: Bye bye dead code.

* dom/Node.h: Hello fast code!

* xml/XPathNamespace.cpp: Removed.
* xml/XPathNamespace.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMove text-only results of a test that was switched to dump as text in r72166
mitz@apple.com [Mon, 25 Apr 2011 23:25:09 +0000 (23:25 +0000)]
Move text-only results of a test that was switched to dump as text in r72166
alongside the test, and remove old expected pixel results.

* fast/dom/setPrimitiveValue-expected.txt: Added.
* platform/chromium-linux/fast/dom/setPrimitiveValue-expected.png: Removed.
* platform/chromium-win/fast/dom/setPrimitiveValue-expected.png: Removed.
* platform/gtk/fast/dom/setPrimitiveValue-expected.txt: Removed.
* platform/mac-leopard/fast/dom/setPrimitiveValue-expected.png: Removed.
* platform/mac/fast/dom/setPrimitiveValue-expected.png: Removed.
* platform/mac/fast/dom/setPrimitiveValue-expected.txt: Removed.
* platform/qt/fast/dom/setPrimitiveValue-expected.png: Removed.
* platform/qt/fast/dom/setPrimitiveValue-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 25 Apr 2011 23:24:57 +0000 (23:24 +0000)]
2011-04-25  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        HistoryItemMac should play nice with OwnPtrs
        https://bugs.webkit.org/show_bug.cgi?id=59388

        * history/mac/HistoryItemMac.mm:
        (WebCore::HistoryItem::setTransientProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix strict OwnPtrs in ContextMenuController.cpp
levin@chromium.org [Mon, 25 Apr 2011 23:20:57 +0000 (23:20 +0000)]
Fix strict OwnPtrs in ContextMenuController.cpp
https://bugs.webkit.org/show_bug.cgi?id=59375

Reviewed by Kenneth Russell.

* page/ContextMenuController.cpp:
(WebCore::ContextMenuController::createContextMenu):
(WebCore::separatorItem):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 25 Apr 2011 23:19:50 +0000 (23:19 +0000)]
2011-04-25  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        CheckedRadioButton should play nice with strict OwnPtr
        https://bugs.webkit.org/show_bug.cgi?id=59386

        * dom/CheckedRadioButtons.cpp:
        (WebCore::CheckedRadioButtons::addButton):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 25 Apr 2011 23:17:04 +0000 (23:17 +0000)]
2011-04-25  Adam Barth  <abarth@webkit.org>

        Reviewed by David Levin.

        Resource*.cpp should play nice with strict OwnPtrs
        https://bugs.webkit.org/show_bug.cgi?id=59383

        * bridge/runtime_method.cpp:
        (JSC::RuntimeMethod::RuntimeMethod):
        * platform/network/ResourceHandle.cpp:
        (WebCore::ResourceHandle::ResourceHandle):
        * platform/network/ResourceResponseBase.cpp:
        (WebCore::ResourceResponseBase::adopt):
        (WebCore::ResourceResponseBase::copyData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Jeff Miller <jeffm@apple.com>
jeffm@apple.com [Mon, 25 Apr 2011 23:15:47 +0000 (23:15 +0000)]
2011-04-25  Jeff Miller  <jeffm@apple.com>

        Reviewed by Timothy Hatcher.

        Treat strings defined with UI_STRING_LOCALIZE_LATER_KEY() as debugging strings in extract-localizable-strings
        https://bugs.webkit.org/show_bug.cgi?id=59373

        * Scripts/extract-localizable-strings: Add UI_STRING_LOCALIZE_LATER_KEY() to isDebugMacro var.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix.
mrowe@apple.com [Mon, 25 Apr 2011 23:14:34 +0000 (23:14 +0000)]
Build fix.

* wtf/ListHashSet.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebKit2: Web Inspector's style sidebar fails to display when inspecting element
bweinstein@apple.com [Mon, 25 Apr 2011 23:09:56 +0000 (23:09 +0000)]
WebKit2: Web Inspector's style sidebar fails to display when inspecting element
https://bugs.webkit.org/show_bug.cgi?id=58071
<rdar://problem/9243093>

Reviewed by Timothy Hatcher.

When creating our WebKit2 inspector views, we were creating them on both Mac and Windows
with the empty rect for their initial size. Before we sized them correctly, the inspector
was calling window.innerWidth on them, which returned 0, making the sidebar take up 0 pixels.

* UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::platformCreateInspectorPage): Create the window with the initial window width
    and height.
* UIProcess/win/WebInspectorProxyWin.cpp:
(WebKit::WebInspectorProxy::platformCreateInspectorPage): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoConvert fast/events/label-focus.html to a text only test
adele@apple.com [Mon, 25 Apr 2011 23:09:14 +0000 (23:09 +0000)]
Convert fast/events/label-focus.html to a text only test
https://bugs.webkit.org/show_bug.cgi?id=59364

Reviewed by Adam Roben.

* fast/events/label-focus-expected.txt: Copied from LayoutTests/platform/mac/fast/events/label-focus-expected.txt.
* fast/events/label-focus.html:
* platform/chromium-linux/fast/events/label-focus-expected.png: Removed.
* platform/chromium-win/fast/events/label-focus-expected.png: Removed.
* platform/chromium-win/fast/events/label-focus-expected.txt: Removed.
* platform/gtk/fast/events/label-focus-expected.png: Removed.
* platform/gtk/fast/events/label-focus-expected.txt: Removed.
* platform/mac-leopard/fast/events/label-focus-expected.png: Removed.
* platform/mac/fast/events/label-focus-expected.png: Removed.
* platform/mac/fast/events/label-focus-expected.txt: Removed.
* platform/qt/fast/events/label-focus-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 25 Apr 2011 23:08:40 +0000 (23:08 +0000)]
2011-04-25  Adam Barth  <abarth@webkit.org>

        Reviewed by David Levin.

        Page*.cpp and objc_runtime.mm should play nice with strict OwnPtrs
        https://bugs.webkit.org/show_bug.cgi?id=59374

        * bridge/objc/objc_runtime.mm:
        (JSC::Bindings::callObjCFallbackObject):
        * page/Page.cpp:
        (WebCore::Page::Page):
        (WebCore::Page::initGroup):
        * page/PageGroup.cpp:
        (WebCore::PageGroup::addUserScriptToWorld):
        (WebCore::PageGroup::addUserStyleSheetToWorld):
        * page/mac/PageMac.cpp:
        (WebCore::Page::addSchedulePair):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBug 59370 - DFG JIT - fix leak of BlocksBlocks
barraclough@apple.com [Mon, 25 Apr 2011 23:06:10 +0000 (23:06 +0000)]
Bug 59370 - DFG JIT - fix leak of BlocksBlocks
(put the blocks immediately into an OwnPtr).

Reviewed by Oliver Hunt.

* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parse):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix: This time for sure!
ggaren@apple.com [Mon, 25 Apr 2011 23:02:45 +0000 (23:02 +0000)]
Build fix: This time for sure!

* dom/make_names.pl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix: Let's edit the script instead of the autogenrated file. That
ggaren@apple.com [Mon, 25 Apr 2011 22:58:01 +0000 (22:58 +0000)]
Build fix: Let's edit the script instead of the autogenrated file. That
way, our change will stand the test of time.

* dom/make_names.pl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChanged a test to dump as text.
mitz@apple.com [Mon, 25 Apr 2011 22:57:35 +0000 (22:57 +0000)]
Changed a test to dump as text.

Reviewed by Sam Weinig.

* fast/css/affected-by-hover-after-style-change.html:
* platform/gtk/fast/css/affected-by-hover-after-style-change-expected.png: Removed.
* platform/gtk/fast/css/affected-by-hover-after-style-change-expected.txt: Removed.
* platform/mac/fast/css/affected-by-hover-after-style-change-expected.png: Removed.
* platform/mac/fast/css/affected-by-hover-after-style-change-expected.txt: Removed.
* platform/qt/fast/css/affected-by-hover-after-style-change-expected.png: Removed.
* platform/qt/fast/css/affected-by-hover-after-style-change-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Mon, 25 Apr 2011 22:56:14 +0000 (22:56 +0000)]
2011-04-25  Daniel Bates  <dbates@webkit.org>

        Reviewed by Sam Weinig.

        Convert LayoutTests/fast/events/onloadFrameCrash.html from pixel test to text-based test
        https://bugs.webkit.org/show_bug.cgi?id=59362

        * fast/events/onloadFrameCrash-expected.txt: Added.
        * fast/events/onloadFrameCrash.html: Modified to dump as text.
        * platform/gtk/fast/events/onloadFrameCrash-expected.png: Removed.
        * platform/gtk/fast/events/onloadFrameCrash-expected.txt: Removed.
        * platform/mac/fast/events/onloadFrameCrash-expected.png: Removed.
        * platform/mac/fast/events/onloadFrameCrash-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 25 Apr 2011 22:56:00 +0000 (22:56 +0000)]
2011-04-25  Adam Barth  <abarth@webkit.org>

        Reviewed by David Levin.

        Fix strict OwnPtrs in HTMLMediaElement and HTTPHeaderMap
        https://bugs.webkit.org/show_bug.cgi?id=59368

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::HTMLMediaElement):
        * platform/network/HTTPHeaderMap.cpp:
        (WebCore::HTTPHeaderMap::copyData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 James Robinson <jamesr@chromium.org>
jamesr@google.com [Mon, 25 Apr 2011 22:54:02 +0000 (22:54 +0000)]
2011-04-25  James Robinson  <jamesr@chromium.org>

        Reviewed by Adam Barth.

        Fix strict OwnPtr violations in Render*.cpp
        https://bugs.webkit.org/show_bug.cgi?id=59361

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::RenderBlock):
        (WebCore::RenderBlock::finishDelayUpdateScrollInfo):
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::addLayoutOverflow):
        (WebCore::RenderBox::addVisualOverflow):
        * rendering/RenderButton.cpp:
        (WebCore::RenderButton::styleDidChange):
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::updateTransform):
        (WebCore::RenderLayer::paintChildLayerIntoColumns):
        (WebCore::RenderLayer::hitTestChildLayerColumns):
        (WebCore::RenderLayer::ensureBacking):
        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::styleDidChange):
        * rendering/RenderView.cpp:
        (WebCore::RenderView::compositor):
        * rendering/style/RenderStyle.cpp:
        (WebCore::RenderStyle::addCachedPseudoStyle):
        (WebCore::RenderStyle::accessCounterDirectives):
        (WebCore::RenderStyle::accessAnimations):
        (WebCore::RenderStyle::accessTransitions):
        * rendering/svg/RenderSVGResourceFilter.cpp:
        (WebCore::RenderSVGResourceFilter::applyResource):
        * rendering/svg/SVGResources.cpp:
        (WebCore::SVGResources::SVGResources):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 25 Apr 2011 22:48:31 +0000 (22:48 +0000)]
2011-04-25  Adam Barth  <abarth@webkit.org>

        Attempt to fix the compile.

        * platform/graphics/MediaPlayer.cpp:
        (WebCore::MediaPlayer::loadWithNextMediaEngine):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Mon, 25 Apr 2011 22:47:57 +0000 (22:47 +0000)]
2011-04-25  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by James Robinson.

        Suppress test failure in Chromium webkit_unit_tests.
        https://bugs.webkit.org/show_bug.cgi?id=59358

        Looks like this started failing after
        http://trac.webkit.org/changeset/84631.

        * tests/TransparencyWinTest.cpp:
        (WebCore::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMerged CREATE_DOM_NODE_WRAPPER and CREATE_DOM_OBJECT_WRAPPER into
ggaren@apple.com [Mon, 25 Apr 2011 22:47:32 +0000 (22:47 +0000)]
Merged CREATE_DOM_NODE_WRAPPER and CREATE_DOM_OBJECT_WRAPPER into
CREATE_DOM_WRAPPER because there's no meaningful difference between
them anymore.

Rubber-stamped by Beth Dakin.

* bindings/js/JSCDATASectionCustom.cpp:
(WebCore::toJSNewlyCreated):
* bindings/js/JSCSSRuleCustom.cpp:
(WebCore::toJS):
* bindings/js/JSCSSValueCustom.cpp:
(WebCore::toJS):
* bindings/js/JSDOMBinding.h:
* bindings/js/JSDocumentCustom.cpp:
(WebCore::toJS):
* bindings/js/JSElementCustom.cpp:
(WebCore::toJSNewlyCreated):
* bindings/js/JSEventCustom.cpp:
(WebCore::toJS):
* bindings/js/JSHTMLCollectionCustom.cpp:
(WebCore::toJS):
* bindings/js/JSImageDataCustom.cpp:
(WebCore::toJS):
* bindings/js/JSNodeCustom.cpp:
(WebCore::createWrapperInline):
* bindings/js/JSSVGPathSegCustom.cpp:
(WebCore::toJS):
* bindings/js/JSStyleSheetCustom.cpp:
(WebCore::toJS):
* bindings/js/JSTextCustom.cpp:
(WebCore::toJSNewlyCreated):
* bindings/js/JSWebKitCSSMatrixCustom.cpp:
(WebCore::JSWebKitCSSMatrixConstructor::constructJSWebKitCSSMatrix):
* bindings/js/JSWebSocketCustom.cpp:
(WebCore::JSWebSocketConstructor::constructJSWebSocket):
* bindings/js/JSXMLHttpRequestCustom.cpp:
(WebCore::JSXMLHttpRequestConstructor::constructJSXMLHttpRequest):
* bindings/js/JSXSLTProcessorCustom.cpp:
(WebCore::JSXSLTProcessorConstructor::constructJSXSLTProcessor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 25 Apr 2011 22:45:59 +0000 (22:45 +0000)]
2011-04-25  Adam Barth  <abarth@webkit.org>

        Reviewed by James Robinson.

        HTMLDocumentParser should play nice with OwnPtrs
        https://bugs.webkit.org/show_bug.cgi?id=59363

        * html/parser/HTMLDocumentParser.cpp:
        (WebCore::HTMLDocumentParser::pumpTokenizer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 25 Apr 2011 22:41:34 +0000 (22:41 +0000)]
2011-04-25  Adam Barth  <abarth@webkit.org>

        Reviewed by James Robinson.

        Frame.cpp should work with strict OwnPtrs
        https://bugs.webkit.org/show_bug.cgi?id=59360

        * page/Frame.cpp:
        (WebCore::createRegExpForLabels):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoChanged a test to dump as text.
mitz@apple.com [Mon, 25 Apr 2011 22:39:45 +0000 (22:39 +0000)]
Changed a test to dump as text.

Reviewed by Adam Roben.

* fast/css/zoom-property-parsing-expected.txt: Added.
* fast/css/zoom-property-parsing.html:
* platform/chromium-linux/fast/css/zoom-property-parsing-expected.png: Removed.
* platform/chromium-win/fast/css/zoom-property-parsing-expected.png: Removed.
* platform/chromium-win/fast/css/zoom-property-parsing-expected.txt: Removed.
* platform/gtk/fast/css/zoom-property-parsing-expected.png: Removed.
* platform/gtk/fast/css/zoom-property-parsing-expected.txt: Removed.
* platform/mac-leopard/fast/css/zoom-property-parsing-expected.png: Removed.
* platform/mac/fast/css/zoom-property-parsing-expected.png: Removed.
* platform/mac/fast/css/zoom-property-parsing-expected.txt: Removed.
* platform/qt/fast/css/zoom-property-parsing-expected.png: Removed.
* platform/qt/fast/css/zoom-property-parsing-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 25 Apr 2011 22:38:14 +0000 (22:38 +0000)]
2011-04-25  Adam Barth  <abarth@webkit.org>

        Reviewed by David Levin.

        Fix strict OwnPtr in Element.cpp
        https://bugs.webkit.org/show_bug.cgi?id=59357

        * dom/NodeRareData.h:
        (WebCore::NodeRareData::ensureEventTargetData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Mon, 25 Apr 2011 22:32:35 +0000 (22:32 +0000)]
2011-04-25  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, expectations change.

        Missed the Chromium Mac baseline in the previous change.

        * platform/chromium-mac/fast/dom/HTMLAnchorElement/set-href-attribute-host-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 25 Apr 2011 22:28:32 +0000 (22:28 +0000)]
2011-04-25  Adam Barth  <abarth@webkit.org>

        Reviewed by David Levin.

        Fix strict OwnPtr issues in Media*.cpp
        https://bugs.webkit.org/show_bug.cgi?id=59354

        There's still a tricky case in MediaPlayer.cpp, but we'll worry about
        that later.

        * css/MediaQueryMatcher.cpp:
        (WebCore::MediaQueryMatcher::addListener):
        * dom/Document.cpp:
        * platform/graphics/MediaPlayer.cpp:
        (WebCore::createNullMediaPlayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 James Robinson <jamesr@chromium.org>
jamesr@google.com [Mon, 25 Apr 2011 22:22:36 +0000 (22:22 +0000)]
2011-04-25  James Robinson  <jamesr@chromium.org>

        Reviewed by David Levin.

        Fix strict OwnPtr violations in ListHashSet and RenderLayerCompositor
        https://bugs.webkit.org/show_bug.cgi?id=59353

        * wtf/ListHashSet.h:
        (WTF::::ListHashSet):
2011-04-25  James Robinson  <jamesr@chromium.org>

        Reviewed by David Levin.

        Fix strict OwnPtr violations in ListHashSet and RenderLayerCompositor
        https://bugs.webkit.org/show_bug.cgi?id=59353

        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::RenderLayerCompositor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix PassOwnPtr issues in Structure and JSGlobalData.cpp
levin@chromium.org [Mon, 25 Apr 2011 21:48:58 +0000 (21:48 +0000)]
Fix PassOwnPtr issues in Structure and JSGlobalData.cpp
https://bugs.webkit.org/show_bug.cgi?id=59347

Reviewed by Adam Barth.

* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
* runtime/Structure.cpp:
(JSC::Structure::copyPropertyTable):
(JSC::Structure::createPropertyMap):
* runtime/Structure.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Mon, 25 Apr 2011 21:48:34 +0000 (21:48 +0000)]
2011-04-25  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, expectations change.

        * platform/chromium-win/fast/dom/HTMLAnchorElement/set-href-attribute-host-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 25 Apr 2011 21:48:05 +0000 (21:48 +0000)]
2011-04-25  Adam Barth  <abarth@webkit.org>

        Reviewed by James Robinson.

        Worker*.cpp should work with strict OwnPtrs
        https://bugs.webkit.org/show_bug.cgi?id=59346

        * inspector/WorkerInspectorController.cpp:
        (WebCore::WorkerInspectorController::WorkerInspectorController):
        * workers/WorkerContext.cpp:
        (WebCore::WorkerContext::WorkerContext):
        * workers/WorkerRunLoop.cpp:
        (WebCore::WorkerRunLoop::WorkerRunLoop):
        * workers/WorkerScriptLoader.cpp:
        (WebCore::WorkerScriptLoader::createResourceRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 James Robinson <jamesr@chromium.org>
jamesr@google.com [Mon, 25 Apr 2011 21:21:29 +0000 (21:21 +0000)]
2011-04-25  James Robinson  <jamesr@chromium.org>

        Reviewed by Adam Barth.

        Remove bad use of OwnPtr::set() in IconDatabase.cpp
        https://bugs.webkit.org/show_bug.cgi?id=59344

        Needed for strict OwnPtr compliance.

        * loader/icon/IconDatabase.cpp:
        (WebCore::readySQLiteStatement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Mon, 25 Apr 2011 21:21:28 +0000 (21:21 +0000)]
2011-04-25  Oliver Hunt  <oliver@apple.com>

        Reviewed by Geoffrey Garen.

        Make ClassInfo required when creating a Structure
        https://bugs.webkit.org/show_bug.cgi?id=59340

        Add ClassInfo to all those types which currently don't
        have it, and add an assertion to Structure::create to
        ensure that the provided classInfo is not null.

        * runtime/Executable.h:
        (JSC::EvalExecutable::createStructure):
        (JSC::ProgramExecutable::createStructure):
        (JSC::FunctionExecutable::createStructure):
        * runtime/GetterSetter.cpp:
        * runtime/GetterSetter.h:
        (JSC::GetterSetter::createStructure):
        * runtime/JSAPIValueWrapper.cpp:
        * runtime/JSAPIValueWrapper.h:
        (JSC::JSAPIValueWrapper::createStructure):
        * runtime/JSCell.cpp:
        * runtime/JSCell.h:
        * runtime/JSString.cpp:
        * runtime/JSString.h:
        (JSC::RopeBuilder::createStructure):
        * runtime/Structure.h:
        (JSC::Structure::create):
        (JSC::JSCell::createDummyStructure):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoPropertyMapHashTable.h should use adoptPtr instead of implicit conversions to PassRefPtr.
levin@chromium.org [Mon, 25 Apr 2011 21:16:04 +0000 (21:16 +0000)]
PropertyMapHashTable.h should use adoptPtr instead of implicit conversions to PassRefPtr.
https://bugs.webkit.org/show_bug.cgi?id=59342

Reviewed by Adam Barth.

This patch is to prepare for the strict OwnPtr hack-a-thon.

* runtime/PropertyMapHashTable.h:
(JSC::PropertyTable::copy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 25 Apr 2011 20:57:09 +0000 (20:57 +0000)]
2011-04-25  Adam Barth  <abarth@webkit.org>

        Reviewed by Maciej Stachowiak.

        ImageBuffer.h should work with strict OwnPtrs
        https://bugs.webkit.org/show_bug.cgi?id=59341

        This patch is to prepare for the strict OwnPtr hack-a-thon.

        * platform/graphics/ImageBuffer.h:
        (WebCore::ImageBuffer::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Steve Falkenburg <sfalken@apple.com>
sfalken@apple.com [Mon, 25 Apr 2011 20:50:56 +0000 (20:50 +0000)]
2011-04-25  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Brian Weinstein.

        WebCore build on Windows should include windows.h in its precompiled header to speed builds
        https://bugs.webkit.org/show_bug.cgi?id=59339

        windows.h is included by several of the underlying wtf headers, including Atomics.h and
        ThreadingPrimitives.h anyway, so include it in the WebCorePrefix.h to speed up compilation.

        On my 8 core Mac Pro, this reduces a clean rebuild of debug WebCore from 8 minutes to 7 minutes
        (a 12% speedup).

        * WebCorePrefix.h: Include windows.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Thouraya ANDOLSI <thouraya.andolsi@st.com>
commit-queue@webkit.org [Mon, 25 Apr 2011 20:19:11 +0000 (20:19 +0000)]
2011-04-25  Thouraya ANDOLSI  <thouraya.andolsi@st.com>

        Reviewed by Gavin Barraclough.

        Rationalize MacroAssembler branch methods
        https://bugs.webkit.org/show_bug.cgi?id=58950

        split out the 'Condition' enum into 'RelationalCondition' and 'ResultCondition'
        and apply related changes (only for SH4 platforms).

        * assembler/MacroAssemblerSH4.cpp:
        * assembler/MacroAssemblerSH4.h:
        (JSC::MacroAssemblerSH4::compare32):
        (JSC::MacroAssemblerSH4::branch32WithUnalignedHalfWords):
        (JSC::MacroAssemblerSH4::branchDouble):
        (JSC::MacroAssemblerSH4::branch32):
        (JSC::MacroAssemblerSH4::branchTest8):
        (JSC::MacroAssemblerSH4::branch8):
        (JSC::MacroAssemblerSH4::branchTruncateDoubleToInt32):
        (JSC::MacroAssemblerSH4::test8):
        (JSC::MacroAssemblerSH4::branch16):
        (JSC::MacroAssemblerSH4::branchTest32):
        (JSC::MacroAssemblerSH4::branchAdd32):
        (JSC::MacroAssemblerSH4::branchMul32):
        (JSC::MacroAssemblerSH4::branchSub32):
        (JSC::MacroAssemblerSH4::branchOr32):
        (JSC::MacroAssemblerSH4::branchConvertDoubleToInt32):
        (JSC::MacroAssemblerSH4::branchPtrWithPatch):
        (JSC::MacroAssemblerSH4::SH4Condition):
        * assembler/SH4Assembler.h:
        (JSC::SH4Assembler::cmpEqImmR0):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 25 Apr 2011 20:16:06 +0000 (20:16 +0000)]
2011-04-25  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        PropertyMapHashTable should work with strict OwnPtr
        https://bugs.webkit.org/show_bug.cgi?id=59337

        This patch is in preparation for the strict OwnPtr hack-a-thon.

        * runtime/PropertyMapHashTable.h:
        (JSC::PropertyTable::PropertyTable):
        (JSC::PropertyTable::addDeletedOffset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Mon, 25 Apr 2011 20:00:50 +0000 (20:00 +0000)]
2011-04-25  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Crash in WebCore::FrameView::notifyPageThatContentAreaWillPaint()
        https://bugs.webkit.org/show_bug.cgi?id=59311

        * platform/gtk/MainFrameScrollbarGtk.cpp:
        (MainFrameScrollbarGtk::attachAdjustment): Before connecting an adjustment to a scrollbar
        disconnect any lingering signal handlers. This prevents an adjustment from controlling the
        active ScrollView and some zombie ScrollView.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNixed MarkStack::deprecatedAppend, since it has no clients left.
ggaren@apple.com [Mon, 25 Apr 2011 19:23:56 +0000 (19:23 +0000)]
Nixed MarkStack::deprecatedAppend, since it has no clients left.

Reviewed by Sam Weinig.

* heap/MarkStack.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAnother shot at fixing the EFL build.
ggaren@apple.com [Mon, 25 Apr 2011 19:21:31 +0000 (19:21 +0000)]
Another shot at fixing the EFL build.

* UseJSC.cmake:
* bindings/js/JSDOMBinding.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTry to fix EFL build.
ggaren@apple.com [Mon, 25 Apr 2011 19:13:08 +0000 (19:13 +0000)]
Try to fix EFL build.

* UseJSC.cmake: Added a missing file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Mon, 25 Apr 2011 18:56:02 +0000 (18:56 +0000)]
2011-04-25  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        Removed a use of markDOMObjectWrapper: ActiveDOMObjects, Workers, and MessagePorts
        https://bugs.webkit.org/show_bug.cgi?id=59333

        * WebCore.xcodeproj/project.pbxproj: Added .idl files for easier editing.

        * bindings/js/JSDOMBinding.cpp:
        * bindings/js/JSDOMBinding.h:
        * bindings/js/JSDocumentCustom.cpp:
        * bindings/js/JSWorkerContextCustom.cpp:
        (WebCore::JSWorkerContext::visitChildren): Removed now-unused functions.

        * bindings/scripts/CodeGeneratorJS.pm: Added support for ActiveDOMObject
        lifetime management.

        * dom/Document.idl: No need for a custom mark function anymore, since
        ActiveDOMObjets now manage their own lifetimes.

        * dom/MessagePort.cpp:
        (WebCore::MessagePort::hasPendingActivity): Correctly report that we
        have pending activity when we're remotely entangled, instead of relying
        on our clients to know this about us and do the check for us.

        * dom/MessagePort.h: FIXME!

        * dom/MessagePort.idl:
        * fileapi/DOMFileSystem.idl:
        * fileapi/FileReader.idl:
        * fileapi/FileWriter.idl:
        * notifications/Notification.idl:
        * notifications/NotificationCenter.idl:
        * page/EventSource.idl:
        * storage/IDBDatabase.idl:
        * storage/IDBRequest.idl:
        * storage/IDBTransaction.idl:
        * webaudio/AudioContext.idl:
        * websockets/WebSocket.idl:
        * workers/AbstractWorker.idl:
        * workers/SharedWorker.idl:
        * workers/Worker.idl: Opt in to ActiveDOMObject lifetime management.

        * workers/WorkerContext.cpp:
        (WebCore::WorkerContext::hasPendingActivity): No need to make up for
        MessagePort::hasPendingActivity being wrong anymore, since it's now right.

        * xml/XMLHttpRequest.idl: Opt in to ActiveDOMObject lifetime management.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt][WK2]fast/dom/shadow/gc-shadow.html fails
ossy@webkit.org [Mon, 25 Apr 2011 18:02:10 +0000 (18:02 +0000)]
[Qt][WK2]fast/dom/shadow/gc-shadow.html fails
https://bugs.webkit.org/show_bug.cgi?id=59335

* platform/qt-wk2/Skipped: Add fast/dom/shadow/gc-shadow.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] New tests introduced in r84742 fail
ossy@webkit.org [Mon, 25 Apr 2011 17:47:28 +0000 (17:47 +0000)]
[Qt] New tests introduced in r84742 fail
https://bugs.webkit.org/show_bug.cgi?id=59334

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWindows part of - WebKit2: Support docked mode for Web Inspector
bweinstein@apple.com [Mon, 25 Apr 2011 17:41:01 +0000 (17:41 +0000)]
Windows part of - WebKit2: Support docked mode for Web Inspector
https://bugs.webkit.org/show_bug.cgi?id=59134
<rdar://problem/8739005>

Reviewed by Adam Roben.

Implement attaching and detaching of the Web Inspector on Windows,
and also support setAttachedWindowHeight when the user changes the height
of the docked inspector.

This patch doesn't remember whether the user prefers attached or detached, and
doesn't remember the user's preferred docked height, but that will be a separate
bug.

* UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::attach): Set the attached flag and call platform-specific code.
(WebKit::WebInspectorProxy::detach): Ditto.
(WebKit::WebInspectorProxy::setAttachedWindowHeight): Call platform-specific code.
(WebKit::WebInspectorProxy::didClose): Set m_isVisible before calling platformClose. platformClose
    calls detach if the inspector was docked, and detach needs to know whether or not the window is
    visible.
* UIProcess/WebInspectorProxy.h:
* UIProcess/WebInspectorProxy.messages.in: Add new messages.
* UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::pageClient): Add a getter for the page client.
* UIProcess/win/WebInspectorProxyWin.cpp:
(WebKit::WebInspectorProxy::windowReceivedMessage): Relay WM_WINDOWPOSCHANGING messages from the inspected
    web view to the WebInspectorProxy.
(WebKit::WebInspectorProxy::onWebViewWindowPosChangingEvent): Resize the inspected web view to behave well
    with the docked inspector.
(WebKit::WebInspectorProxy::platformClose): If we are attached, detach before destroying.
(WebKit::WebInspectorProxy::platformAttach): Set the inspector's host window to be the inspected web view's parent
    window, so the inspected web view and the inspector are siblings.
(WebKit::WebInspectorProxy::platformDetach): Set the inspector's host window to be the standalone inspector window.
(WebKit::WebInspectorProxy::platformSetAttachedWindowHeight): Size the views.
* WebProcess/WebCoreSupport/WebInspectorClient.cpp:
* WebProcess/WebCoreSupport/WebInspectorClient.h:
* WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
(WebKit::WebInspectorFrontendClient::attachWindow): Call WebInspector::attach.
(WebKit::WebInspectorFrontendClient::closeWindow): Add a call to the InspectorController to disconnect the inspector frontend
    from the inspector backend. Without this line, when we close the attached inspector, it won't re-open, because the
    inspector controller still thinks there is a frontend. This matches WebKit1's behavior, although it seems like this is
    something WebCore should handle.
(WebKit::WebInspectorFrontendClient::detachWindow): Call WebInspector::detach.
(WebKit::WebInspectorFrontendClient::setAttachedWindowHeight): Call WebInspector::setAttachedWindowHeight.
* UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaImpl::sendUpdateBackingStoreState): Add an early return if the WebPageProxy's viewSize is empty.
    This can be needed if the inspector takes up the whole view, and it is useful to prevent a possible synchronous message
    from the UIProcess -> WebProcess to update a backing store that isn't visible in the first place.
* WebProcess/WebPage/WebInspector.cpp:
(WebKit::WebInspector::attach): Send a message to the UIProcess.
(WebKit::WebInspector::detach): Ditto.
(WebKit::WebInspector::setAttachedWindowHeight): Ditto.
* WebProcess/WebPage/WebInspector.h: Remove some dead code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed; add failing test to mac-wk2/Skipped list.
jer.noble@apple.com [Mon, 25 Apr 2011 17:24:03 +0000 (17:24 +0000)]
Unreviewed; add failing test to mac-wk2/Skipped list.

* platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Snow Leopard Intel WebKit2 Release Tests] editing/undo/undo-iframe-location-change...
jberlin@webkit.org [Mon, 25 Apr 2011 17:19:12 +0000 (17:19 +0000)]
[Snow Leopard Intel WebKit2 Release Tests] editing/undo/undo-iframe-location-change.html and
compositing/iframes/invisible-nested-iframe-show.html failing since r84037.
https://bugs.webkit.org/show_bug.cgi?id=58990

Add failing expected results for SL WK2 to get the bots green.

These tests are already Skipped on Windows or have their own expected results.

* platform/mac-wk2/compositing/iframes/invisible-nested-iframe-show-expected.txt: Added.
* platform/mac-wk2/editing/undo/undo-iframe-location-change-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd another HTMLProgressElement test to the Windows Skipped list to get the bots...
jberlin@webkit.org [Mon, 25 Apr 2011 17:18:47 +0000 (17:18 +0000)]
Add another HTMLProgressElement test to the Windows Skipped list to get the bots green,
since Windows does not have an implementation of HTMLProgressElement.

* platform/win/Skipped:
Add fast/dom/HTMLProgressElement/progress-writing-mode.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebKit2: Web Inspector: Support highlighting page elements
bweinstein@apple.com [Mon, 25 Apr 2011 17:10:51 +0000 (17:10 +0000)]
WebKit2: Web Inspector: Support highlighting page elements
https://bugs.webkit.org/show_bug.cgi?id=59263
<rdar://problem/8767659>

Reviewed by Alice Liu.

Support highlighting of page elements for the inspector in WebKit2 by
having the WebInspectorClient be a PageOverlay Client and be responsible
for calling InspectorController::drawNodeHighlight.

* WebProcess/WebCoreSupport/WebInspectorClient.cpp:
(WebKit::WebInspectorClient::highlight): Create our overlay if it hasn't been created,
    or call setNeedsDisplay if it has.
(WebKit::WebInspectorClient::hideHighlight): Uninstall the page overlay if it exists.
(WebKit::WebInspectorClient::pageOverlayDestroyed):
(WebKit::WebInspectorClient::willMoveToWebPage): If it's being destroyed (moving to a null
    WebPage), clear the member variable.
(WebKit::WebInspectorClient::didMoveToWebPage):
(WebKit::WebInspectorClient::drawRect): Call InspectorController::drawNodeHighlight.
(WebKit::WebInspectorClient::mouseEvent):
* WebProcess/WebCoreSupport/WebInspectorClient.h:
(WebKit::WebInspectorClient::WebInspectorClient): Add a new member variable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Mon, 25 Apr 2011 16:47:09 +0000 (16:47 +0000)]
2011-04-25  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: worker messages should be routed to corresponding worker front-end
        https://bugs.webkit.org/show_bug.cgi?id=59323

        Added WorkerManager which is responsible for routing messages between
        Page inspector front-end and Worker inspector front-ends.

        * WebCore.gypi:
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/WorkerManager.js: Added.
        (WebInspector.WorkerManager):
        (WebInspector.WorkerManager.loaded.InspectorFrontendHost.sendMessageToBackend):
        (WebInspector.WorkerManager.loaded.InspectorFrontendHost.loaded):
        (WebInspector.WorkerManager.loaded):
        (WebInspector.WorkerFrontendStub):
        (WebInspector.WorkerFrontendStub.prototype._receiveMessage):
        (WebInspector.WorkerDispatcher):
        (WebInspector.WorkerDispatcher.prototype._receiveMessage):
        (WebInspector.WorkerDispatcher.prototype.workerCreated):
        (WebInspector.WorkerDispatcher.prototype.dispatchMessageFromWorker):
        * inspector/front-end/inspector.html:
        * inspector/front-end/inspector.js:
        (WebInspector.loaded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Andrew Scherkus <scherkus@chromium.org>
scherkus@chromium.org [Mon, 25 Apr 2011 16:45:09 +0000 (16:45 +0000)]
2011-04-25  Andrew Scherkus  <scherkus@chromium.org>

        Reviewed by Dimitri Glazkov.

        Adding a few Chromium contributors to committers.py.

        https://bugs.webkit.org/show_bug.cgi?id=59327

        * Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Annie Sullivan <sullivan@chromium.org>
pfeldman@chromium.org [Mon, 25 Apr 2011 16:39:08 +0000 (16:39 +0000)]
2011-04-25  Annie Sullivan  <sullivan@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [Resources panel] Should be easy to copy data.
        https://bugs.webkit.org/show_bug.cgi?id=45662

        Adds context menu items to copy resource location, resource request headers, and resource response headers.

        * inspector/front-end/NetworkPanel.js:
        (WebInspector.NetworkPanel.prototype._contextMenu): Add new items to context menu.
        (WebInspector.NetworkPanel.prototype._exportLocation): Copy resource location to clipboard.
        (WebInspector.NetworkPanel.prototype._exportRequestHeaders): Copy resource request headers to clipboard.
        (WebInspector.NetworkPanel.prototype._exportResponseHeaders): Copy resource response headers to clipboard.
        * inspector/front-end/Resource.js:
        (WebInspector.Resource.prototype.get requestHeadersText): If _requestHeadersText is undefined, generate it from requestHeaders.
        (WebInspector.Resource.prototype.get responseHeadersText): If _responseHeadersText is undefined, generate it form responseHeaders.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Mon, 25 Apr 2011 15:51:35 +0000 (15:51 +0000)]
2011-04-25  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: CSS is parsed improperly when saved in UTF-8 with a BOM
        https://bugs.webkit.org/show_bug.cgi?id=59322

        * inspector/styles/parse-utf8-bom-expected.txt: Added.
        * inspector/styles/parse-utf8-bom.html: Added.
        * inspector/styles/resources/parse-utf8-bom-main.css: Added.
        (h1):
        (h2):
        * inspector/styles/resources/parse-utf8-bom-reset.css: Added.
2011-04-25  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: CSS is parsed improperly when saved in UTF-8 with a BOM
        https://bugs.webkit.org/show_bug.cgi?id=59322

        Use TextResourceDecoder to determine external stylesheet charsets correctly.

        Test: inspector/styles/parse-utf8-bom.html

        * inspector/InspectorStyleSheet.cpp:
        (WebCore::InspectorStyleSheet::originalStyleSheetText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd another HTMLProgressElement test to the Windows Skipped list to get the bots...
jberlin@webkit.org [Mon, 25 Apr 2011 15:13:41 +0000 (15:13 +0000)]
Add another HTMLProgressElement test to the Windows Skipped list to get the bots green,
since Windows does not have an implementation of HTMLProgressElement.

* platform/win/Skipped:
Add fast/dom/HTMLProgressElement/progress-writing-mode.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Mon, 25 Apr 2011 14:18:43 +0000 (14:18 +0000)]
2011-04-25  Pavel Feldman  <pfeldman@google.com>

        Not reviewed: Inspector.json cleanup.

        * inspector/Inspector.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Mon, 25 Apr 2011 14:12:28 +0000 (14:12 +0000)]
2011-04-25  Pavel Feldman  <pfeldman@google.com>

        Reviewed by Yury Semikhatsky.

        Web Inspector: move Frame and Resource Tree management into the Page agent.
        https://bugs.webkit.org/show_bug.cgi?id=59321

        * inspector/report-protocol-errors.html:
2011-04-25  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: introduce InspectorWorkerAgent
        https://bugs.webkit.org/show_bug.cgi?id=59320

        InspectorWorkerAgent is responsible for routing inspector messages
        between worker context inspector agents and corresponding worker
        inspector front-end.

        * CMakeLists.txt:
        * GNUmakefile.list.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * inspector/CodeGeneratorInspector.pm:
        * inspector/Inspector.json:
        * inspector/InspectorAgent.cpp:
        (WebCore::InspectorAgent::InspectorAgent):
        (WebCore::InspectorAgent::setFrontend):
        (WebCore::InspectorAgent::disconnectFrontend):
        * inspector/InspectorAgent.h:
        (WebCore::InspectorAgent::workerAgent):
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::connectFrontend):
        (WebCore::InspectorController::disconnectFrontend):
        * inspector/InspectorInstrumentation.cpp:
        (WebCore::InspectorInstrumentation::didStartWorkerContextImpl):
        * inspector/InspectorInstrumentation.h:
        (WebCore::InspectorInstrumentation::willStartWorkerContext):
        (WebCore::InspectorInstrumentation::didStartWorkerContext):
        * inspector/InspectorWorkerAgent.cpp: Added.
        (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::WorkerFrontendChannel):
        (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::~WorkerFrontendChannel):
        (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::id):
        (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::inspectorProxy):
        (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::sendMessageToFrontend):
        (WebCore::InspectorWorkerAgent::create):
        (WebCore::InspectorWorkerAgent::InspectorWorkerAgent):
        (WebCore::InspectorWorkerAgent::~InspectorWorkerAgent):
        (WebCore::InspectorWorkerAgent::setFrontend):
        (WebCore::InspectorWorkerAgent::clearFrontend):
        (WebCore::InspectorWorkerAgent::dispatchMessageOnWorkerInspector):
        (WebCore::InspectorWorkerAgent::didStartWorkerContext):
        * inspector/InspectorWorkerAgent.h: Added.
        * inspector/InstrumentingAgents.h:
        (WebCore::InstrumentingAgents::InstrumentingAgents):
        (WebCore::InstrumentingAgents::inspectorWorkerAgent):
        (WebCore::InstrumentingAgents::setInspectorWorkerAgent):
        * inspector/WorkerInspectorController.cpp:
        (WebCore::WorkerInspectorController::connectFrontend):
        * inspector/generate-inspector-idl:
        * workers/Worker.cpp:
        (WebCore::Worker::notifyFinished):
        * workers/WorkerContextInspectorProxy.h: Added. Platform-specific transport for inspector
        messages sent from the inspected page worker agent to the worker context inspector agents.
        (WebCore::WorkerContextInspectorProxy::connectFrontend):
        (WebCore::WorkerContextInspectorProxy::disconnectFrontend):
        (WebCore::WorkerContextInspectorProxy::sendMessageToWorkerContextInspector):
        (WebCore::WorkerContextInspectorProxy::~WorkerContextInspectorProxy):
        * workers/WorkerContextProxy.h:
        (WebCore::WorkerContextProxy::inspectorProxy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Mon, 25 Apr 2011 13:27:49 +0000 (13:27 +0000)]
2011-04-25  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: introduce InspectorWorkerAgent
        https://bugs.webkit.org/show_bug.cgi?id=59320

        InspectorWorkerAgent is responsible for routing inspector messages
        between worker context inspector agents and corresponding worker
        inspector front-end.

        * CMakeLists.txt:
        * GNUmakefile.list.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * inspector/CodeGeneratorInspector.pm:
        * inspector/Inspector.json:
        * inspector/InspectorAgent.cpp:
        (WebCore::InspectorAgent::InspectorAgent):
        (WebCore::InspectorAgent::setFrontend):
        (WebCore::InspectorAgent::disconnectFrontend):
        * inspector/InspectorAgent.h:
        (WebCore::InspectorAgent::workerAgent):
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::connectFrontend):
        (WebCore::InspectorController::disconnectFrontend):
        * inspector/InspectorInstrumentation.cpp:
        (WebCore::InspectorInstrumentation::didStartWorkerContextImpl):
        * inspector/InspectorInstrumentation.h:
        (WebCore::InspectorInstrumentation::willStartWorkerContext):
        (WebCore::InspectorInstrumentation::didStartWorkerContext):
        * inspector/InspectorWorkerAgent.cpp: Added.
        (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::WorkerFrontendChannel):
        (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::~WorkerFrontendChannel):
        (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::id):
        (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::inspectorProxy):
        (WebCore::InspectorWorkerAgent::WorkerFrontendChannel::sendMessageToFrontend):
        (WebCore::InspectorWorkerAgent::create):
        (WebCore::InspectorWorkerAgent::InspectorWorkerAgent):
        (WebCore::InspectorWorkerAgent::~InspectorWorkerAgent):
        (WebCore::InspectorWorkerAgent::setFrontend):
        (WebCore::InspectorWorkerAgent::clearFrontend):
        (WebCore::InspectorWorkerAgent::dispatchMessageOnWorkerInspector):
        (WebCore::InspectorWorkerAgent::didStartWorkerContext):
        * inspector/InspectorWorkerAgent.h: Added.
        * inspector/InstrumentingAgents.h:
        (WebCore::InstrumentingAgents::InstrumentingAgents):
        (WebCore::InstrumentingAgents::inspectorWorkerAgent):
        (WebCore::InstrumentingAgents::setInspectorWorkerAgent):
        * inspector/WorkerInspectorController.cpp:
        (WebCore::WorkerInspectorController::connectFrontend):
        * inspector/generate-inspector-idl:
        * workers/Worker.cpp:
        (WebCore::Worker::notifyFinished):
        * workers/WorkerContextInspectorProxy.h: Added. Platform-specific transport for inspector
        messages sent from the inspected page worker agent to the worker context inspector agents.
        (WebCore::WorkerContextInspectorProxy::connectFrontend):
        (WebCore::WorkerContextInspectorProxy::disconnectFrontend):
        (WebCore::WorkerContextInspectorProxy::sendMessageToWorkerContextInspector):
        (WebCore::WorkerContextInspectorProxy::~WorkerContextInspectorProxy):
        * workers/WorkerContextProxy.h:
        (WebCore::WorkerContextProxy::inspectorProxy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Mon, 25 Apr 2011 11:25:35 +0000 (11:25 +0000)]
2011-04-25  Pavel Feldman  <pfeldman@google.com>

        Reviewed by Yury Semikhatsky.

        Web Inspector: few protocol improvements.
        https://bugs.webkit.org/show_bug.cgi?id=59319

        * http/tests/inspector/inspector-test.js:
        (initialize_InspectorTest.InspectorTest.reloadPage):
2011-04-25  Pavel Feldman  <pfeldman@google.com>

        Reviewed by Yury Semikhatsky.

        Web Inspector: few protocol improvements.
        https://bugs.webkit.org/show_bug.cgi?id=59319

        - Page domain is documented
        - setUserAgentOverride is moved to the Network agent
        - setSearchingForNode -> setInspectModeEnabled
        - highlightDOMNode -> highlightNode
        - reloadPage -> reload
        - openInNewWindow -> open with optional parameter

        * inspector/Inspector.json:
        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::setInspectModeEnabled):
        (WebCore::InspectorDOMAgent::highlightNode):
        * inspector/InspectorDOMAgent.h:
        (WebCore::InspectorDOMAgent::hideNodeHighlight):
        * inspector/InspectorInstrumentation.cpp:
        (WebCore::InspectorInstrumentation::applyUserAgentOverrideImpl):
        * inspector/InspectorPageAgent.cpp:
        (WebCore::InspectorPageAgent::clearFrontend):
        (WebCore::InspectorPageAgent::reload):
        (WebCore::InspectorPageAgent::open):
        * inspector/InspectorPageAgent.h:
        * inspector/InspectorResourceAgent.cpp:
        (WebCore::InspectorResourceAgent::clearFrontend):
        (WebCore::InspectorResourceAgent::applyUserAgentOverride):
        (WebCore::InspectorResourceAgent::setUserAgentOverride):
        * inspector/InspectorResourceAgent.h:
        * inspector/front-end/AuditsPanel.js:
        (WebInspector.AuditsPanel.prototype._reloadResources):
        * inspector/front-end/ElementsPanel.js:
        (WebInspector.ElementsPanel.prototype.setSearchingForNode):
        * inspector/front-end/ExtensionServer.js:
        (WebInspector.ExtensionServer.prototype._onReload):
        * inspector/front-end/NetworkPanel.js:
        (WebInspector.NetworkDataGridNode.prototype._openInNewTab):
        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.FrameResourceTreeElement.prototype.ondblclick):
        * inspector/front-end/inspector.js:
        (WebInspector.highlightDOMNode):
        (WebInspector.openResource):
        (WebInspector.documentKeyDown):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Ryuan Choi <ryuan.choi@samsung.com>
commit-queue@webkit.org [Mon, 25 Apr 2011 11:18:00 +0000 (11:18 +0000)]
2011-04-25  Ryuan Choi  <ryuan.choi@samsung.com>

        Reviewed by Antonio Gomes.

        [EFL] Remove ewk_eapi.h
        https://bugs.webkit.org/show_bug.cgi?id=59091

        * ewk/EWebKit.h:
        * ewk/ewk_contextmenu.h:
        * ewk/ewk_cookies.h:
        * ewk/ewk_eapi.h: Removed.
        * ewk/ewk_frame.h:
        * ewk/ewk_history.h:
        * ewk/ewk_main.h:
        * ewk/ewk_settings.h:
        * ewk/ewk_tiled_matrix.h:
        * ewk/ewk_tiled_model.h:
        * ewk/ewk_window_features.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Mon, 25 Apr 2011 09:59:58 +0000 (09:59 +0000)]
2011-04-25  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Cameron Zwarich.

        Fix tests after URL parsing fix
        https://bugs.webkit.org/show_bug.cgi?id=59317

        * fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-host.js: Update
        expected behavior.
        * fast/dom/HTMLAnchorElement/script-tests/set-href-attribute-protocol.js: Update expected
        behavior.
        * fast/dom/HTMLAnchorElement/set-href-attribute-host-expected.txt: Update expectations.
        * fast/dom/HTMLAnchorElement/set-href-attribute-protocol-expected.txt: Update expectations.
        * fast/loader/url-parse-1-expected.txt: Update expectations.
        * http/tests/loading/cross-origin-XHR-willLoadRequest.html: Replace single slash
        in an http: URL with a double slash - the single slash seemed to be erroneous.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-25 Jon Lee <jonlee@apple.com>
commit-queue@webkit.org [Mon, 25 Apr 2011 08:26:32 +0000 (08:26 +0000)]
2011-04-25  Jon Lee  <jonlee@apple.com>

        Reviewed by Maciej Stachowiak.

        Overlay scroller hard to see on pages with dark background (59183)
        https://bugs.webkit.org/show_bug.cgi?id=59183
        <rdar://problem/8975367>

        Switch the scrollbar's overlay style depending on its frame's background color.
        This refactors the getDocumentBackgroundColor method needed for gestures. The style
        is determined and set on every paint() call to the Mac scrollbar theme.

        * WebCore.exp.in: adding method to allow changing style
        * page/Frame.cpp:
        (WebCore::Frame::getDocumentBackgroundColor): moving code from WebFrame for reuse by FrameView
        * page/Frame.h:
        * page/FrameView.cpp:
        (WebCore::FrameView::recommendedScrollbarOverlayStyle): overridden to suggest a style based on CSS background color
        * page/FrameView.h:
        * platform/ScrollTypes.h: new enum to represent different overlay scrollbar styles
        * platform/ScrollableArea.h:
        (WebCore::ScrollableArea::recommendedScrollbarOverlayStyle): new virtual function to return a suggested overlay style
        * platform/mac/ScrollbarThemeMac.mm:
        (WebCore::ScrollbarThemeMac::paint):
        * platform/mac/WebCoreSystemInterface.h:
        * platform/mac/WebCoreSystemInterface.mm:
2011-04-25  Jon Lee  <jonlee@apple.com>

        Reviewed by Maciej Stachowiak.

        Overlay scroller hard to see on pages with dark background (59183)
        https://bugs.webkit.org/show_bug.cgi?id=59183
        <rdar://problem/8975367>

        * WebCoreSupport/WebSystemInterface.mm:
        (InitWebCoreSystemInterface): adding method to allow changing style
2011-04-25  Jon Lee  <jonlee@apple.com>

        Reviewed by Maciej Stachowiak.

        Overlay scroller hard to see on pages with dark background (59183)
        https://bugs.webkit.org/show_bug.cgi?id=59183
        <rdar://problem/8975367>

        * WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
        (InitWebCoreSystemInterface): adding method to allow changing style
        * WebProcess/WebPage/WebFrame.cpp:
        (WebKit::WebFrame::getDocumentBackgroundColor): refactoring to use common code for retrieving background color

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdded Radar link
mitz@apple.com [Mon, 25 Apr 2011 07:28:18 +0000 (07:28 +0000)]
Added Radar link

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoREGRESSION (WK2): Holding down Option while dragging scrollbar thumb has no effect...
mitz@apple.com [Mon, 25 Apr 2011 07:26:53 +0000 (07:26 +0000)]
REGRESSION (WK2): Holding down Option while dragging scrollbar thumb has no effect (should make scroll distance equal mouse translation)
https://bugs.webkit.org/show_bug.cgi?id=59315

Reviewed by Maciej Stachowiak.

* platform/Scrollbar.cpp:
(WebCore::Scrollbar::Scrollbar): Initialize new member variables.
(WebCore::Scrollbar::moveThumb): Added a boolean draggingDocument parameter. When true, the document
is scrolled a distance equal to the change in the mouse position.
(WebCore::Scrollbar::mouseMoved): Check with the theme whether the mouse move event should drag
the document rather than the thumb, and pass the result to moveThumb.
(WebCore::Scrollbar::mouseUp): Reset m_draggingDocument.
* platform/Scrollbar.h:
* platform/ScrollbarTheme.h:
(WebCore::ScrollbarTheme::shouldDragDocumentInsteadOfThumb): Added. The base class implementation
returns false.
* platform/mac/ScrollbarThemeMac.h:
* platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::shouldDragDocumentInsteadOfThumb): Overridden to return true if the
Option key is down.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-24 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Mon, 25 Apr 2011 06:22:47 +0000 (06:22 +0000)]
2011-04-24  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, expectations change.

        Add Chromium baselines for fast/table/auto-100-percent-width.html.
        Mark fast/dom/HTMLMeterElement/meter-element.html and
        http/tests/misc/will-send-request-returns-null-on-redirect.html
        as failing - need triage.

        * platform/chromium-mac/fast/table/auto-100-percent-width-expected.png: Added.
        * platform/chromium-win/fast/table/auto-100-percent-width-expected.png: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-24 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 25 Apr 2011 05:36:32 +0000 (05:36 +0000)]
2011-04-24  Adam Barth  <abarth@webkit.org>

        Update Chromium results for standard-url.html (again).

        * platform/chromium-linux/fast/url/standard-url-expected.txt:
        * platform/chromium-mac/fast/url/standard-url-expected.txt:
        * platform/chromium-win/fast/url/standard-url-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-24 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Mon, 25 Apr 2011 00:47:17 +0000 (00:47 +0000)]
2011-04-24  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Sam Weinig.

        Removed a use of markDOMObjectWrapper: WebGL, XHR, workers; plus, more autogeneration
        https://bugs.webkit.org/show_bug.cgi?id=59307

        * WebCore.xcodeproj/project.pbxproj: Added Blob.idl, so it's easier to edit.

        * bindings/js/JSCSSRuleCustom.cpp:
        * bindings/js/JSCSSStyleDeclarationCustom.cpp:
        * bindings/js/JSCanvasRenderingContextCustom.cpp:
        * bindings/js/JSDOMApplicationCacheCustom.cpp: Autogenerate these instead
        of hand-coding them.

        * bindings/js/JSDOMBinding.h:
        (WebCore::root): Moved some GC helpers here from JSNodeCustom.h, because
        they're reasonably generic.

        * bindings/js/JSDOMImplementationCustom.cpp:
        * bindings/js/JSDOMStringMapCustom.cpp:
        * bindings/js/JSDOMTokenListCustom.cpp:
        * bindings/js/JSHTMLCollectionCustom.cpp:
        * bindings/js/JSMediaListCustom.cpp: Autogenerate these instead of
        hand-coding them.

        * bindings/js/JSMessageChannelCustom.cpp:
        (WebCore::JSMessageChannel::visitChildren):
        * bindings/js/JSMessagePortCustom.cpp:
        (WebCore::JSMessagePort::visitChildren): Use addOpaqueRoot instead of
        markDOMObjectWrapper. This is one of the few cases where a DOM object is
        considered a stand-alone root. It's not as efficient as the shared root
        case, but workers and message ports are very rare objects, so it's no
        big deal.

        * bindings/js/JSNamedNodeMapCustom.cpp: Autogenerate!

        * bindings/js/JSNodeCustom.h: Moved to JSDOMBinding.h.

        * bindings/js/JSSharedWorkerCustom.cpp:
        (WebCore::JSSharedWorker::visitChildren): Use addOpaqueRoot instead of
        markDOMObjectWrapper, as above. Once again, a stand-alone root.

        * bindings/js/JSStyleSheetCustom.cpp:
        * bindings/js/JSStyleSheetListCustom.cpp: Autogenerate!

        * bindings/js/JSWebGLRenderingContextCustom.cpp:
        (WebCore::JSWebGLRenderingContext::visitChildren): Use the opaque roots
        system for marking WebGL contexts and their associated satellite objects.

        * bindings/js/JSWorkerContextCustom.cpp:
        (WebCore::JSWorkerContext::visitChildren):
        * bindings/js/JSXMLHttpRequestCustom.cpp: Use addOpaqueRoot instead of
        markDOMObjectWrapper, as above. Once again, stand-alone roots.

        (WebCore::JSXMLHttpRequest::visitChildren):
        * bindings/js/JSXMLHttpRequestUploadCustom.cpp: No need to mark our owner
        XHR because it is not reachable from us.

        * bindings/scripts/CodeGeneratorJS.pm: Added autogeneration support for a
        bunch of repetitive cases of isReachableFromOpaqueRoots callbacks.

        * css/CSSRule.idl:
        * css/CSSStyleDeclaration.idl:
        * css/MediaList.idl:
        * css/StyleMedia.idl:
        * css/StyleSheet.idl:
        * css/StyleSheetList.idl:
        * dom/DOMImplementation.idl:
        * dom/DOMStringMap.idl:
        * dom/MessagePort.idl:
        * dom/NamedNodeMap.idl:
        * fileapi/Blob.idl:
        * html/DOMTokenList.idl: Opt in to autogeneration.

        * html/HTMLCanvasElement.cpp:
        (WebCore::HTMLCanvasElement::getContext): Standardized on PassOwnPtr/OwnPtr
        usage, to reduce human error and make ownership rules more obvious.

        * html/HTMLCollection.idl:
        * html/canvas/ArrayBuffer.idl: Opt in to autogeneration.

        * html/canvas/CanvasRenderingContext.cpp:
        * html/canvas/CanvasRenderingContext.h:
        (WebCore::CanvasRenderingContext::ref):
        (WebCore::CanvasRenderingContext::deref):
        * html/canvas/CanvasRenderingContext2D.h:
        (WebCore::CanvasRenderingContext2D::create):
        (WebCore::CanvasRenderingContext2D::state): Standardized on PassOwnPtr/OwnPtr
        usage, to reduce human error and make ownership rules more obvious.

        Inlined some functions to match our standard idiom and to make the code
        in the header document itself.

        * html/canvas/CanvasRenderingContext.idl: Opt in to autogeneration.

        * html/canvas/OESStandardDerivatives.cpp:
        (WebCore::OESStandardDerivatives::OESStandardDerivatives):
        (WebCore::OESStandardDerivatives::create):
        * html/canvas/OESStandardDerivatives.h:
        * html/canvas/OESStandardDerivatives.idl:
        * html/canvas/OESTextureFloat.cpp:
        (WebCore::OESTextureFloat::OESTextureFloat):
        (WebCore::OESTextureFloat::create):
        * html/canvas/OESTextureFloat.h:
        * html/canvas/OESTextureFloat.idl:
        * html/canvas/OESVertexArrayObject.cpp:
        (WebCore::OESVertexArrayObject::OESVertexArrayObject):
        (WebCore::OESVertexArrayObject::create):
        * html/canvas/OESVertexArrayObject.h:
        * html/canvas/OESVertexArrayObject.idl:
        * html/canvas/WebGLExtension.cpp:
        (WebCore::WebGLExtension::WebGLExtension):
        * html/canvas/WebGLExtension.h:
        (WebCore::WebGLExtension::ref):
        (WebCore::WebGLExtension::deref):
        (WebCore::WebGLExtension::context):
        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::~WebGLRenderingContext):
        (WebCore::WebGLRenderingContext::getExtension):
        * html/canvas/WebGLRenderingContext.h:
        * html/canvas/WebKitLoseContext.cpp:
        (WebCore::WebKitLoseContext::WebKitLoseContext):
        (WebCore::WebKitLoseContext::create):
        (WebCore::WebKitLoseContext::loseContext):
        * html/canvas/WebKitLoseContext.h:
        * html/canvas/WebKitLoseContext.idl: Updated the ownership model for WebGL
        canavs rendering contexts to match the model for 2D canvas rendering
        contexts. This makes garbage collection a lot more straightforward, but
        it also makes the behavior of these objects more reliable. (Previously,
        satellite objects would magically stop working when the last reference
        to their owner object was dropped. Now, satellite objects keep their owner
        alive through reference counting.)

        * loader/appcache/DOMApplicationCache.idl:
        * page/BarInfo.idl:
        * page/Console.idl:
        * page/DOMSelection.idl:
        * page/Geolocation.idl:
        * page/History.idl:
        * page/Location.idl:
        * page/Navigator.idl:
        * page/Screen.idl:
        * page/WorkerNavigator.idl:
        * plugins/DOMMimeTypeArray.h:
        (WebCore::DOMMimeTypeArray::frame):
        * plugins/DOMMimeTypeArray.idl:
        * plugins/DOMPluginArray.h:
        (WebCore::DOMPluginArray::frame):
        * plugins/DOMPluginArray.idl:
        * storage/Storage.idl:
        * workers/WorkerLocation.idl: Opt in to autogeneration.

        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::~XMLHttpRequest):
        * xml/XMLHttpRequest.h:
        * xml/XMLHttpRequestUpload.cpp:
        (WebCore::XMLHttpRequestUpload::scriptExecutionContext):
        * xml/XMLHttpRequestUpload.h:
        (WebCore::XMLHttpRequestUpload::create):
        (WebCore::XMLHttpRequestUpload::ref):
        (WebCore::XMLHttpRequestUpload::deref):
        (WebCore::XMLHttpRequestUpload::xmlHttpRequest):
        (WebCore::XMLHttpRequestUpload::toXMLHttpRequestUpload):
        * xml/XMLHttpRequestUpload.idl: Updated the ownership model for XHR and
        its associated upload object to match the model for canvas. This makes
        garbage collection a lot more straightforward, but it also makes the
        behavior of these objects more reliable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-24 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Sun, 24 Apr 2011 23:09:39 +0000 (23:09 +0000)]
2011-04-24  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r84759.
        http://trac.webkit.org/changeset/84759
        https://bugs.webkit.org/show_bug.cgi?id=59306

        Caused gc-shadow.html to start crashing in V8. (Requested by
        dglazkov|away on #webkit).

        * fast/dom/shadow/append-child-text-expected.txt: Removed.
        * fast/dom/shadow/append-child-text.html: Removed.
2011-04-24  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r84759.
        http://trac.webkit.org/changeset/84759
        https://bugs.webkit.org/show_bug.cgi?id=59306

        Caused gc-shadow.html to start crashing in V8. (Requested by
        dglazkov|away on #webkit).

        * dom/Node.cpp:
        (WebCore::NodeRendererFactory::createRendererAndStyle):
        (WebCore::Node::styleForRenderer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-24 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Sun, 24 Apr 2011 22:53:59 +0000 (22:53 +0000)]
2011-04-24  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by George Staikos.

        Handling of URLs like http:/example.com/ is incorrect
        https://bugs.webkit.org/show_bug.cgi?id=59300
        <rdar://problem/9231956>

        URLs like http:/example.com/ or http:example.com/ are now correctly
        canonicalized as http://example.com/

        The code still doesn't quite match other browsers - at least some
        other browsers seem to base parsing behavior on whether they
        recongize a scheme from a fixed list, and ignore whether // is
        present in the URL or not.

        * platform/KURL.cpp:
        (WebCore::isNonFileHierarchicalScheme): New helper function.
        (WebCore::KURL::parse): For a particular list of whitelisted schemes,
        assume they are hierarchical and need an authority even if there is no //
        after the :/
2011-04-24  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by George Staikos.

        Handling of URLs like http:/example.com/ is incorrect
        https://bugs.webkit.org/show_bug.cgi?id=59300
        <rdar://problem/9231956>

        Added some new test cases. Also updated results for the
        change. The changes are progressions.

        * fast/url/relative-expected.txt:
        * fast/url/script-tests/segments.js:
        * fast/url/script-tests/standard-url.js:
        * fast/url/segments-expected.txt:
        * fast/url/segments-from-data-url-expected.txt:
        * fast/url/standard-url-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84762 268f45cc-cd09-0410-ab3c-d52691b4dbfc