timothy@apple.com [Sun, 18 Nov 2007 06:40:27 +0000 (06:40 +0000)]
WebCore:
Reviewed by Mark Rowe.
Bug 13470: i18n: The Web Inspector is not localizable
http://bugs.webkit.org/show_bug.cgi?id=13470
Add support for localization to the Web Inspector. Clients need to
implement localizedStringsURL() to return the URL of the
InspectorLocalizedStrings.js that best matches the user's language.
* English.lproj: Added.
* English.lproj/InspectorLocalizedStrings.js: Added.
* WebCore.xcodeproj/project.pbxproj: Add InspectorLocalizedStrings.js.
* page/InspectorClient.h: Add localizedStringsURL.
* page/InspectorController.cpp: Add localizedStringsURL that calls
the client. Also added a version exposed to JavaScript.
* page/InspectorController.h: Add localizedStringsURL.
* page/inspector/ConsolePanel.js: Call WebInspector.UIString
for user visible strings.
* page/inspector/DatabasePanel.js: Ditto.
* page/inspector/DocumentPanel.js: Ditto.
* page/inspector/ImagePanel.js: Ditto.
* page/inspector/MetricsSidebarPane.js: Ditto.
* page/inspector/NetworkPanel.js: Ditto.
* page/inspector/Panel.js: Ditto.
* page/inspector/PropertiesSidebarPane.js: Ditto.
* page/inspector/Resource.js: Ditto.
* page/inspector/ResourceCategory.js: Ditto.
* page/inspector/SourcePanel.js: Ditto.
* page/inspector/StylesSidebarPane.js: Ditto.
* page/inspector/inspector.css: Use pre-wrap so database errors can use \n.
* page/inspector/inspector.html: Remove some user visible strings.
* page/inspector/inspector.js: Added WebInspector.UIString and call
WebInspector.UIString for user visible strings. Some code needed to be
moved to WebInspector.loaded to use UIString after the localized strings
get loaded.
* platform/graphics/svg/SVGImageEmptyClients.h:
(WebCore::SVGEmptyFrameLoaderClient::redirectDataToPlugin): Remove WebCore:: prefix.
(WebCore::SVGEmptyInspectorClient::createPage): Ditto.
(WebCore::SVGEmptyInspectorClient::localizedStringsURL): Add empty stub.
(WebCore::SVGEmptyInspectorClient::highlight): Remove WebCore:: prefix.
(WebCore::SVGEmptyInspectorClient::inspectedURLChanged): Ditto.
WebKit:
Reviewed by Mark Rowe.
Bug 13470: i18n: The Web Inspector is not localizable
http://bugs.webkit.org/show_bug.cgi?id=13470
Update the localized strings and the file encoding of WebInspectorClient.mm.
* English.lproj/Localizable.strings:
* StringsNotToBeLocalized.txt:
* WebKit.xcodeproj/project.pbxproj:
WebKit/gtk:
Reviewed by Mark Rowe.
Bug 13470: i18n: The Web Inspector is not localizable
http://bugs.webkit.org/show_bug.cgi?id=13470
* WebCoreSupport/InspectorClientGtk.cpp:
(WebKit::InspectorClient::localizedStringsURL): Empty stub.
* WebCoreSupport/InspectorClientGtk.h: Add localizedStringsURL.
WebKit/mac:
Reviewed by Mark Rowe.
Bug 13470: i18n: The Web Inspector is not localizable
http://bugs.webkit.org/show_bug.cgi?id=13470
Implement the localizedStringsURL() client method to return the
localized URL of InspectorLocalizedStrings.js in WebCore.
* WebCoreSupport/WebInspectorClient.h: Added localizedStringsURL.
* WebCoreSupport/WebInspectorClient.mm:
(WebInspectorClient::localizedStringsURL): Added.
(WebInspectorClient::updateWindowTitle): Localized the window title.
(-[WebInspectorWindowController init]): Remove a FIXME that dosen't make sense anymore.
(-[WebInspectorWindowController initWithInspectedWebView:]): Code style cleanup.
WebKit/qt:
Reviewed by Mark Rowe.
Bug 13470: i18n: The Web Inspector is not localizable
http://bugs.webkit.org/show_bug.cgi?id=13470
* WebCoreSupport/InspectorClientQt.cpp:
(WebCore::InspectorClientQt::localizedStringsURL): Empty stub.
* WebCoreSupport/InspectorClientQt.h: Added localizedStringsURL.
WebKit/win:
Reviewed by Mark Rowe.
Bug 13470: i18n: The Web Inspector is not localizable
http://bugs.webkit.org/show_bug.cgi?id=13470
* English.lproj/Localizable.strings: Updated.
* WebInspectorClient.cpp:
(WebInspectorClient::localizedStringsURL): Empty stub.
* WebInspectorClient.h: Added localizedStringsURL.
WebKit/wx:
Reviewed by Mark Rowe.
Bug 13470: i18n: The Web Inspector is not localizable
http://bugs.webkit.org/show_bug.cgi?id=13470
* WebKitSupport/InspectorClientWx.cpp:
(WebCore::InspectorClientWx::localizedStringsURL): Empty stub.
* WebKitSupport/InspectorClientWx.h: Added localizedStringsURL.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27883
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Sun, 18 Nov 2007 05:36:52 +0000 (05:36 +0000)]
Prevent testapi from reporting false leaks.
Clear out local variables pointing at JSObjectRefs to allow their values to be collected.
Reviewed by Sam Weinig.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27882
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Sun, 18 Nov 2007 05:36:29 +0000 (05:36 +0000)]
Prevent testapi from crashing if testapi.js can not be found by nil-checking the result of createStringWithContentsOfFile.
Reviewed by Sam Weinig.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27881
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Sun, 18 Nov 2007 01:14:41 +0000 (01:14 +0000)]
Remove IDL files from the WebCore.framework Resources.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27880
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Sat, 17 Nov 2007 23:14:40 +0000 (23:14 +0000)]
2007-11-17 Alp Toker <alp@atoker.com>
Reviewed by Eric.
http://bugs.webkit.org/show_bug.cgi?id=16032
JS minidom is not portable
Use a plain UTF-8 string instead of a CFString.
Print to stdout, not stderr like CFShow() would have done, since that
behaviour seems unintentional.
* API/minidom.c:
(main):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27879
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Sat, 17 Nov 2007 20:49:33 +0000 (20:49 +0000)]
Make it easy to run Safari in the debugger on Windows
WebKitSite:
Update Windows debugging instructions
Reviewed by Mark Rowe.
* building/debug.html:
WebKitTools:
Make it easy to run Safari in the debugger on Windows
I've added a new script, debug-safari, which launches Safari in the
debugger. On OS X it just calls gdb-safari.
Reviewed by Mark Rowe.
* FindSafari/FindSafari.cpp:
(_tmain): Added a /debugger flag, which in combination with
/printSafariLauncher will print a script that launches Safari in the
debugger.
* Scripts/debug-safari: Added.
* Scripts/run-safari: Changed to call runSafari().
* Scripts/run-webkit-nightly.cmd: Prepends the launcher script with
vsvars32.bat, which will let us find VS/VC++ Express, and passes the
first argument along to FindSafari.
* Scripts/webkitdirs.pm:
(sub runSafari): Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27878
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Sat, 17 Nov 2007 20:02:10 +0000 (20:02 +0000)]
Reviewed by Adam.
Reworte String.sprintf to fix many bad bugs and to not use RegExp. Also added
String.vsprintf so it can be used later for the localization function.
This version only supports argument reordering, precision for floats, and these
format characters: d, f, s and @. Any unsupported format characters are logged
and substituted like strings.
* page/inspector/utilities.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27877
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Sat, 17 Nov 2007 16:53:38 +0000 (16:53 +0000)]
Windows build fix.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27875
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Sat, 17 Nov 2007 10:39:11 +0000 (10:39 +0000)]
Windows build fix
WebKit:
* WebView.cpp:
(WebView::deleteSelection): Use canSmartCopyOrDelete() directly.
WebCore:
* editing/Editor.h: Made canSmartCopyOrDelete public, as Windows WebView still needs it.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27874
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Sat, 17 Nov 2007 08:58:24 +0000 (08:58 +0000)]
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=15969
Eliminate Editor::deleteRange()
No change in functionality.
WebCore:
* editing/CompositeEditCommand.h: Removed unimplemented deleteKeyPressed().
* editing/Editor.cpp:
(WebCore::Editor::deleteWithDirection):
(WebCore::Editor::cut):
(WebCore::Editor::performDelete):
* editing/Editor.h:
Moved relevant Editor::deleteRange() functionality to its callers.
Removed deleteSelectionWithSmartDelete(void), which was more confusing than helpful
in my opinion.
* editing/mac/EditorMac.mm:
(WebCore::initializeKillRingIfNeeded):
(WebCore::Editor::addToKillRing):
(WebCore::Editor::yank):
(WebCore::Editor::yankAndSelect):
(WebCore::Editor::setMark):
(WebCore::unionDOMRanges):
(WebCore::Editor::deleteToMark):
(WebCore::Editor::selectToMark):
(WebCore::Editor::swapWithMark):
Pushed kill ring handling down from WebCore.
* page/mac/WebCoreFrameBridge.h:
* page/mac/WebCoreFrameBridge.mm:
Removed setMarkDOMRange (the corresponding getter is still needed).
* WebCore.base.exp: No longer need to export Editor::deleteRange() and Editor::insertTextWithoutSendingTextEvent().
Export the new kill ring functions.
WebKit:
* WebView/WebHTMLView.mm:
(+[WebHTMLView initialize]):
(-[WebHTMLView yank:]):
(-[WebHTMLView yankAndSelect:]):
(-[WebHTMLView setMark:]):
(-[WebHTMLView deleteToMark:]):
(-[WebHTMLView selectToMark:]):
(-[WebHTMLView swapWithMark:]):
Pushed all kill ring methods to WebCore. They were guilty of using Editor::deleteRange()!
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27873
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Sat, 17 Nov 2007 08:28:23 +0000 (08:28 +0000)]
Reviewed by Adam Roben.
* Scripts/run-webkit-tests: Avoid an uninitialized warning if WEBKIT_TESTFONTS is not defined.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27872
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer@apple.com [Sat, 17 Nov 2007 06:47:50 +0000 (06:47 +0000)]
2007-11-16 Ryan Leavengood <leavengood@gmail.com>
Reviewed by David Kilzer.
Build fix: the needed headers for POSIX file functions were not
included.
* platform/posix/FileSystemPOSIX.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27871
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer@apple.com [Sat, 17 Nov 2007 06:42:36 +0000 (06:42 +0000)]
2007-11-16 Ryan Leavengood <leavengood@gmail.com>
Reviewed by David Kilzer.
The git config command was renamed to repo-config at some point. This
change tries git config and then git repo-config if the first fails.
* Scripts/prepare-ChangeLog:
(gitConfig):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27870
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Sat, 17 Nov 2007 05:10:41 +0000 (05:10 +0000)]
WebCore:
Reviewed by Darin Adler.
- fix the common case of <http://bugs.webkit.org/show_bug.cgi?id=15994>
REGRESSION: Incomplete repaint of CSS image substitution
Test: fast/repaint/clip-with-layout-delta.html
* rendering/LayoutState.cpp:
(WebCore::LayoutState::LayoutState): Account for layout delta when
pushing additional clip.
LayoutTests:
Reviewed by Darin Adler.
- repaint test for <http://bugs.webkit.org/show_bug.cgi?id=15994>
REGRESSION: Incomplete repaint of CSS image substitution
* fast/repaint/clip-with-layout-delta.html: Added.
* platform/mac/fast/repaint/clip-with-layout-delta-expected.checksum: Added.
* platform/mac/fast/repaint/clip-with-layout-delta-expected.png: Added.
* platform/mac/fast/repaint/clip-with-layout-delta-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27869
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Sat, 17 Nov 2007 04:05:51 +0000 (04:05 +0000)]
Reviewed by Adam.
<rdar://problem/
5603832>
XMLHttpRequest readyState 3 & responseText buffer issues.
Add wkSetCFURLRequestShouldContentSniff.
* win/include/WebKitSystemInterface/WebKitSystemInterface.h:
* win/lib/WebKitSystemInterface.lib:
* win/lib/WebKitSystemInterface_debug.lib:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27868
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Sat, 17 Nov 2007 02:13:48 +0000 (02:13 +0000)]
Fix ChangeLog
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27867
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Sat, 17 Nov 2007 02:10:16 +0000 (02:10 +0000)]
WebCore:
Reviewed by Adele.
Seeking related fixes, updates match to the latest specification
- rename loopCount of HTMLMediaElement to playCount
- add explicit seeking attribute to HTMLMediaElement to get semantics right
- implement the specification behavior that currentTime must immediately return seeked position in HTMLMediaElement
instead of MoviePrivateQTKit
- fix broken behavior when seeking past end of the media, add tests
- replace Movie didEnd callback with broader timeChanged callback (which gets called in didEnd case too)
- use setDelayCallbacks: in various MoviePrivateQTKit methods to avoid bug prone synchronous callbacks from QT, make
HTMLMediaElement not depend on synchronous callbacks
- do some cleanups and simplifications in MoviePrivateQTKit, get rid of m_rateBeforeSeek and m_blockStateUpdate variables
Tests: http/tests/media/video-seekable-stall.html
media/video-seeking.html
media/video-seek-past-end-paused.html
media/video-seek-past-end-playing.html
* html/HTMLAttributeNames.in:
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::load):
(WebCore::HTMLMediaElement::movieNetworkStateChanged):
(WebCore::HTMLMediaElement::setReadyState):
(WebCore::HTMLMediaElement::seek):
(WebCore::HTMLMediaElement::seeking):
(WebCore::HTMLMediaElement::currentTime):
(WebCore::HTMLMediaElement::ended):
(WebCore::HTMLMediaElement::play):
(WebCore::HTMLMediaElement::pause):
(WebCore::HTMLMediaElement::playCount):
(WebCore::HTMLMediaElement::setPlayCount):
(WebCore::HTMLMediaElement::checkIfSeekNeeded):
(WebCore::HTMLMediaElement::movieTimeChanged):
(WebCore::HTMLMediaElement::endedPlayback):
(WebCore::HTMLMediaElement::updateMovie):
* html/HTMLMediaElement.h:
* html/HTMLMediaElement.idl:
* platform/graphics/Movie.cpp:
(WebCore::Movie::timeChanged):
* platform/graphics/Movie.h:
(WebCore::MovieClient::movieTimeChanged):
* platform/graphics/mac/MoviePrivateQTKit.h:
* platform/graphics/mac/MoviePrivateQTKit.mm:
(WebCore::MoviePrivate::MoviePrivate):
(WebCore::MoviePrivate::load):
(WebCore::MoviePrivate::play):
(WebCore::MoviePrivate::pause):
(WebCore::MoviePrivate::currentTime):
(WebCore::MoviePrivate::seek):
(WebCore::MoviePrivate::doSeek):
(WebCore::MoviePrivate::cancelSeek):
(WebCore::MoviePrivate::seekTimerFired):
(WebCore::MoviePrivate::startCuePointTimerIfNeeded):
(WebCore::MoviePrivate::paused):
(WebCore::MoviePrivate::updateStates):
(WebCore::MoviePrivate::timeChanged):
(WebCore::MoviePrivate::didEnd):
LayoutTests:
Reviewed by Adele.
Seeking related test updates
- update to match specificiation
- rename loopCount to playCount everywhere
- timeupdate events during seek
- fix that some tests (like audio ones) depended on timing sensitive ordering of play and load events
- add text about what is being tested
Add new tests for seeking past end, seeking past loaded position and 'seeking' DOM attribute.
* http/tests/media/video-seekable-stall-expected.txt: Added.
* http/tests/media/video-seekable-stall.html: Added.
* media/audio-constructor-expected.txt:
* media/audio-constructor-src-expected.txt:
* media/audio-constructor-src.html:
* media/audio-constructor.html:
* media/video-dom-loopcount-expected.txt:
* media/video-dom-loopcount.html:
* media/video-dom-loopend-expected.txt:
* media/video-dom-loopend.html:
* media/video-dom-loopstart-expected.txt:
* media/video-dom-loopstart.html:
* media/video-dom-start-expected.txt:
* media/video-dom-start.html:
* media/video-loopcount-expected.txt:
* media/video-loopcount.html:
* media/video-loopend-expected.txt:
* media/video-loopend.html:
* media/video-loopstart-expected.txt:
* media/video-loopstart.html:
* media/video-seek-past-end-paused-expected.txt: Added.
* media/video-seek-past-end-paused.html: Added.
* media/video-seek-past-end-playing-expected.txt: Added.
* media/video-seek-past-end-playing.html: Added.
* media/video-seeking-expected.txt: Added.
* media/video-seeking.html: Added.
* media/video-test.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27866
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Sat, 17 Nov 2007 01:32:01 +0000 (01:32 +0000)]
WebCore:
Reviewed by Adam.
<rdar://problem/
5603832>
XMLHttpRequest readyState 3 & responseText buffer issues.
* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::makeFinalRequest):
Add new parameter which controls whether content sniffing should be turned off.
(WebCore::ResourceHandle::loadResourceSynchronously):
Always content sniff sync loads.
* platform/network/cf/ResourceRequestCFNet.cpp:
(WebCore::ResourceRequest::doUpdatePlatformRequest):
If the ResourceRequest already has a backing CFURLRequest, make a copy of it. This preserves
any properties set on the CFURLRequest.
LayoutTests:
Reviewed by Adam.
<rdar://problem/
5603832>
XMLHttpRequest readyState 3 & responseText buffer issues.
Remove http/tests/xmlhttprequest/small-chunks-response-text.html from the Skipped list.
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27865
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Sat, 17 Nov 2007 01:25:55 +0000 (01:25 +0000)]
Fix ChangeLog
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27864
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Sat, 17 Nov 2007 01:24:53 +0000 (01:24 +0000)]
WebKitTools:
Reviewed by Darin Adler and Sam Weinig.
- fix <rdar://problem/
5134075> fast/forms/select-type-ahead-non-latin.html fails on boomer
* DumpRenderTree/win/EventSender.cpp:
(keyDownCallback): For characters that cannot be entered on the active
keyboard layout, send a WM_CHAR message with the character along with
a WM_KEYDOWN message with a virtual key code of 255.
LayoutTests:
Reviewed by Darin Adler and Sam Weinig.
- remove fast/forms/select-type-ahead-non-latin.html after fixing <rdar://problem/
5134075>
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27863
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jhoneycutt@apple.com [Sat, 17 Nov 2007 01:16:56 +0000 (01:16 +0000)]
2007-11-16 Jon Honeycutt <jhoneycutt@apple.com>
Reviewed by Ollie.
<rdar://problem/
5605175> Crash closing or leaving window with ViewPoint
Media player plugin
ViewPoint plugin requires that we pass a valid NPSavedData* to
NPP_Destroy.
* plugins/win/PluginViewWin.cpp: Pass a valid NPSavedData* to
NPP_Destroy. If the plugin allocates data, discard it
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27862
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Sat, 17 Nov 2007 00:52:17 +0000 (00:52 +0000)]
Windows build fix.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27861
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Fri, 16 Nov 2007 23:50:45 +0000 (23:50 +0000)]
Build WebCore as a sub-framework of WebKit in all configurations.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27860
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Fri, 16 Nov 2007 22:43:36 +0000 (22:43 +0000)]
2007-11-16 Mark Rowe <mrowe@apple.com>
Reviewed by Eric.
Replace strings, identifier, buffer8 and buffer16 members of Lexer with vectors.
SunSpider claims this is a 0.7% speedup.
* kjs/lexer.cpp:
(KJS::Lexer::Lexer):
(KJS::Lexer::lex):
(KJS::Lexer::record8):
(KJS::Lexer::record16):
(KJS::Lexer::scanRegExp):
(KJS::Lexer::clear):
(KJS::Lexer::makeIdentifier):
(KJS::Lexer::makeUString):
* kjs/lexer.h:
* kjs/ustring.cpp:
(KJS::UString::UString): Add a convenience constructor that takes a const Vector<UChar>&.
* kjs/ustring.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27859
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Fri, 16 Nov 2007 22:27:03 +0000 (22:27 +0000)]
2007-11-16 Doug Turner <dougt@meer.net>
Reviewed by Alp.
http://bugs.webkit.org/show_bug.cgi?id=16018
build bustage when building on debian 4.0
Fix build bustage on GTK+ with older versions of Pango.
Don't cache the return value since the docs say it can change.
* platform/gtk/Language.cpp:
(WebCore::defaultLanguage):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27858
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Fri, 16 Nov 2007 21:55:14 +0000 (21:55 +0000)]
Windows build fix
* JavaScriptCore.vcproj/testkjs/testkjs.vcproj: Add a new include path
and ignore the int -> bool conversion warning.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27857
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan@apple.com [Fri, 16 Nov 2007 19:21:42 +0000 (19:21 +0000)]
Reviewed by Brady
* WebKit.exp:
Exported some new database-related symbols
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27856
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Fri, 16 Nov 2007 19:06:23 +0000 (19:06 +0000)]
* WebKit.xcodeproj/project.pbxproj: WebDatabaseManagerPrivate.h, also!
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27855
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Fri, 16 Nov 2007 18:59:25 +0000 (18:59 +0000)]
* WebKit.xcodeproj/project.pbxproj: Mark WebSecurityOriginPrivate.h private so
it is exported
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27854
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Fri, 16 Nov 2007 17:34:57 +0000 (17:34 +0000)]
WebKit/mac:
Reviewed by John
Database management API tweaks
Fleshed out "WebSecurityOrigin" to be the API object representing an origin. This relieves some
burden off WebDatabaseManager and allows usage/quota operations on the SecurityOrigin object itself
Also added a new subdirectory for Storage related API - Why are we afraid to add new directories to
the WebKit tree?
* Misc/WebSecurityOrigin.mm: Removed.
* Misc/WebSecurityOriginInternal.h: Removed.
* Misc/WebSecurityOriginPrivate.h: Removed.
* Storage/WebDatabaseManager.mm: Work in terms of WebSecurityOrigin
* Storage/WebDatabaseManagerPrivate.h:
* Storage/WebSecurityOrigin.mm: Added.
(-[WebSecurityOriginPrivate initWithProtocol:domain:port:]):
(-[WebSecurityOriginPrivate initWithWebCoreSecurityOrigin:]):
(-[WebSecurityOriginPrivate finalize]):
(-[WebSecurityOriginPrivate dealloc]):
(-[WebSecurityOrigin initWithProtocol:domain:]):
(-[WebSecurityOrigin initWithProtocol:domain:port:]):
(-[WebSecurityOrigin protocol]):
(-[WebSecurityOrigin domain]):
(-[WebSecurityOrigin port]):
(-[WebSecurityOrigin usage]):
(-[WebSecurityOrigin quota]):
(-[WebSecurityOrigin setQuota:]): Clients will set quotas on the WebSecurityOrigin object itself
(-[WebSecurityOrigin dealloc]):
(-[WebSecurityOrigin _initWithWebCoreSecurityOriginData:]):
* Storage/WebSecurityOriginInternal.h: Added.
* Storage/WebSecurityOriginPrivate.h: Added.
WebKit:
Reviewed by John
Database management API tweaks
* WebKit.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27853
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Fri, 16 Nov 2007 17:25:17 +0000 (17:25 +0000)]
Build fix
* platform/SecurityOriginData.h:
(WebCore::operator!=): Whoops!
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27852
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Fri, 16 Nov 2007 17:13:20 +0000 (17:13 +0000)]
Reviewed by Sam
Further purify DatabaseTracker to use SecurityOriginData instead of "a String"
* WebCore.base.exp:
* WebCore.xcodeproj/project.pbxproj:
* WebCore.vcproj/WebCore.vcproj
* WebCore.pro
* platform/SecurityOriginData.cpp: Added.
(WebCore::SecurityOriginData::SecurityOriginData): Add a constructor that takes a "stringIdentifier"-style string,
since that form is what will be stored in the Databases.db on disk
(WebCore::SecurityOriginData::stringIdentifier):
* platform/SecurityOriginData.h:
(WebCore::SecurityOriginData::protocol):
(WebCore::SecurityOriginData::host):
(WebCore::SecurityOriginData::port):
* storage/DatabaseTracker.cpp:
(WebCore::SecurityOriginDataHash::hash): Follow the pattern Darin set in FontCache.cpp to make a decent hash for
a SecurityOriginData object
(WebCore::SecurityOriginDataHash::equal):
(WebCore::SecurityOriginDataTraits::deletedValue): "file::1" will never exist in normal operation
(WebCore::SecurityOriginDataTraits::emptyValue): "file::2" will never exist in normal operation
(WebCore::DatabaseTracker::fullPathForDatabase):
(WebCore::DatabaseTracker::populateOrigins):
(WebCore::DatabaseTracker::origins):
(WebCore::DatabaseTracker::addDatabase):
* storage/DatabaseTracker.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27851
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Fri, 16 Nov 2007 12:22:34 +0000 (12:22 +0000)]
Rubberstamped by Eric.
Full update of the SVG pixel tests - all files containing text show rendering improvements.
Text looks more 'bold' as it's supposed to be according to the W3C reference rendering, not
sure what commit actually caused it - but it's better now.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27850
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Fri, 16 Nov 2007 12:20:01 +0000 (12:20 +0000)]
Windows build fix.
* WebCore.vcproj/WebCore.vcproj: Removed VoidCallback.cpp, added JSCustomVoidCallback.{h,cpp}.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27849
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Fri, 16 Nov 2007 11:20:56 +0000 (11:20 +0000)]
Reviewed by Eric.
Fixes: http://bugs.webkit.org/show_bug.cgi?id=12290
Implement all SVGTextContentElement DOM methods.
This is the last missing SVG text feature. SVG fonts is next.
Added testcase: svg/custom/text-dom-01-f.svg (tests all new methods)
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27848
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Fri, 16 Nov 2007 10:49:40 +0000 (10:49 +0000)]
Fix Windows debug build.
Rubber-stamped by Eric
* pcre/pcre_exec.cpp: (match): Removed ASSERT_NOT_REACHED assertions that were making MSVC
complain about unreachable code.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27847
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Fri, 16 Nov 2007 07:47:52 +0000 (07:47 +0000)]
2007-11-15 Mark Rowe <mrowe@apple.com>
Gtk build fix.
* kjs/Parser.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27846
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Fri, 16 Nov 2007 07:44:18 +0000 (07:44 +0000)]
Mac build and header search path sanity fix.
Reviewed by Sam Weinig and Tim Hatcher.
Move base setting for HEADER_SEARCH_PATHS into Base.xcconfig, and extend
it in JavaScriptCore.xcconfig. This removes the need to override it on a
per-target basis inside the .xcodeproj file.
* Configurations/Base.xcconfig:
* Configurations/JavaScriptCore.xcconfig:
* JavaScriptCore.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27845
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Fri, 16 Nov 2007 07:08:05 +0000 (07:08 +0000)]
2007-11-15 Mark Rowe <mrowe@apple.com>
Qt build fix.
* kjs/Parser.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27844
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele@apple.com [Fri, 16 Nov 2007 07:00:50 +0000 (07:00 +0000)]
WebCore:
Reviewed by Oliver.
Fix for <rdar://problem/
5566652> CrashTracer: [USER] 3 crashes in Safari at HTMLSelectElement::menuListDefaultEventHandler (reproducible on mactc30.com)
Test: fast/forms/menulist-no-renderer-onmousedown.html
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::defaultEventHandler): Nil check the renderer here. None of the default behavior makes sense if there's no renderer.
(WebCore::HTMLSelectElement::listBoxDefaultEventHandler): Moved the nil check to the main defaultEventHandler.
LayoutTests:
Reviewed by Oliver.
Test for <rdar://problem/
5566652> CrashTracer: [USER] 3 crashes in Safari at HTMLSelectElement::menuListDefaultEventHandler (reproducible on mactc30.com)
* fast/forms/menulist-no-renderer-onmousedown-expected.txt: Added.
* fast/forms/menulist-no-renderer-onmousedown.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27843
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Fri, 16 Nov 2007 06:54:09 +0000 (06:54 +0000)]
Reviewed by Eric Seidel.
Another round of grammar / parsing cleanup.
1. Created distinct parser calls for parsing function bodies vs
programs. This will help later with optimizing global variable access.
2. Turned Parser into a singleton. Cleaned up Lexer's singleton
interface.
3. Modified Lexer to free a little more memory when done lexing. (Added
FIXMEs for similar issues that I didn't fix.)
4. Changed Lexer::makeIdentifier and Lexer::makeUString to start
respecting the arguments passed to them. (No behavior change, but this
problem could have caused serious problems for an unsuspecting user of
these functions.)
5. Removed KJS_DEBUG_MEM because it was bit-rotted.
6. Removed Parser::prettyPrint because the same work was simpler to do
at the call site.
7. Some renames:
"Parser::accept" => "Parser::didFinishParsing"
"Parser::sid" => "Parser::m_sourceID"
"Lexer::doneParsing" => "Lexer::clear"
"sid" => "sourceId"
"lineno" => "lineNo"
* JavaScriptCore.exp:
* kjs/Parser.cpp:
(KJS::Parser::Parser):
(KJS::Parser::parseProgram):
(KJS::Parser::parseFunctionBody):
(KJS::Parser::parse):
(KJS::Parser::didFinishParsing):
(KJS::parser):
* kjs/Parser.h:
(KJS::Parser::sourceId):
* kjs/function.cpp:
(KJS::GlobalFuncImp::callAsFunction):
* kjs/function_object.cpp:
(FunctionObjectImp::construct):
* kjs/grammar.y:
* kjs/interpreter.cpp:
(KJS::Interpreter::checkSyntax):
(KJS::Interpreter::evaluate):
* kjs/interpreter.h:
* kjs/lexer.cpp:
(kjsyylex):
(KJS::lexer):
(KJS::Lexer::Lexer):
(KJS::Lexer::~Lexer):
(KJS::Lexer::scanRegExp):
(KJS::Lexer::doneParsing):
(KJS::Lexer::makeIdentifier):
(KJS::Lexer::makeUString):
* kjs/lexer.h:
(KJS::Lexer::pattern):
(KJS::Lexer::flags):
(KJS::Lexer::sawError):
* kjs/nodes.cpp:
(KJS::Node::Node):
(KJS::FunctionBodyNode::FunctionBodyNode):
* kjs/nodes.h:
* kjs/testkjs.cpp:
(prettyPrintScript):
(kjsmain):
* kjs/ustring.cpp:
* kjs/ustring.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27842
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Fri, 16 Nov 2007 06:25:36 +0000 (06:25 +0000)]
Reviewed by Adele.
Fix <rdar://problem/
5601598>
The movie tag should do initialization on need and not during startup.
Initialize Movie MIME type hash on demand
* platform/MIMETypeRegistry.cpp:
(WebCore::initialiseSupportedMovieMIMETypes):
(WebCore::initialiseMIMETypeRegistry):
(WebCore::MIMETypeRegistry::isSupportedMovieMIMEType):
(WebCore::MIMETypeRegistry::getSupportedMovieMIMETypes):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27841
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Fri, 16 Nov 2007 06:18:22 +0000 (06:18 +0000)]
2007-11-15 Mark Rowe <mrowe@apple.com>
Build fix for Qt on Windows.
* xml/XPathStep.cpp:
(WebCore::XPath::Step::nodesInAxis):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27840
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Fri, 16 Nov 2007 06:15:18 +0000 (06:15 +0000)]
Reviewed by Mark Rowe.
Bug 14761: Web Inspector leaks JS objects and DOM nodes
http://bugs.webkit.org/show_bug.cgi?id=14761
* page/InspectorController.cpp:
(WebCore::InspectorController::~InspectorController):
Change the tear down order so that inspectorDestroyed() is called before
InspectorController private data is set to Zero. The inspectorDestroyed()
call ends up closing the WebView and triggering InspectorController::close()
which unprotects m_scriptObject. This didn't happen when the private data
was cleared before calling inspectorDestroyed().
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27839
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Fri, 16 Nov 2007 06:10:30 +0000 (06:10 +0000)]
2007-11-15 Mark Rowe <mrowe@apple.com>
Gtk build fix.
* WebCore.pro:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27838
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Fri, 16 Nov 2007 06:04:45 +0000 (06:04 +0000)]
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=15989
XPath queries with predicates incorrectly retains the current node across unions
Test: fast/xpath/union-context-node.xhtml
* xml/XPathPath.cpp:
(WebCore::XPath::LocationPath::evaluate): Restore context after evaluation.
* xml/XPathStep.cpp:
(WebCore::XPath::Step::evaluate): Do not backup context, as we can easily re-create it.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27837
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Fri, 16 Nov 2007 06:02:20 +0000 (06:02 +0000)]
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=15448
Import XPath test suite from amachang.art-code.org
Test by Hitoshi Amano <seijro@gmail.com>.
* fast/xpath/xpath-functional-test-expected.txt: Added.
* fast/xpath/xpath-functional-test.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27836
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Fri, 16 Nov 2007 06:00:53 +0000 (06:00 +0000)]
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=15988
REGRESSION: XPath preceding-axis query misses nested elements
Test: fast/xpath/preceding-axis.xhtml
* xml/XPathStep.cpp:
(WebCore::XPath::Step::nodesInAxis): Hopefully correct this time.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27835
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Fri, 16 Nov 2007 01:21:32 +0000 (01:21 +0000)]
Reviewed by Mark Rowe and Sam.
This corrects a couple of issues in the Web Inspector where selected search results
would not have the right text color when the window is inactive or the results are focused.
* page/inspector/inspector.css:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27834
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Fri, 16 Nov 2007 01:04:48 +0000 (01:04 +0000)]
Reviewed by Sam.
Bug 16007: REGRESSION: Disclosure triangle click zone for resource categories is off by 10 pixels
http://bugs.webkit.org/show_bug.cgi?id=16007
Makes the click width an option on TreeElement and make ResourceCategoryTreeElement
a true subclass of TreeElement. The click width for ResourceCategoryTreeElement is
20 pixels, and the default is 10 pixels.
* page/inspector/ResourceCategory.js:
* page/inspector/treeoutline.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27833
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Fri, 16 Nov 2007 00:42:55 +0000 (00:42 +0000)]
Reviewed by Brady.
Pass a VoidCallback to Database::transaction and Database::changeVersion.
This is not yet hooked up to the database machinery.
* WebCore.vcproj/WebCore.vcproj:
* bindings/js/JSDatabaseCustom.cpp:
(WebCore::JSDatabase::changeVersion):
(WebCore::JSDatabase::transaction):
* storage/Database.cpp:
(WebCore::Database::changeVersion):
(WebCore::Database::transaction):
* storage/Database.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27832
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Fri, 16 Nov 2007 00:40:24 +0000 (00:40 +0000)]
<rdar://problem/
5601548> REGRESSION: All SourceElements and their children leak after a syntax error
Reviewed by Darin.
Add a stub node to maintain the Vector of SourceElements until assignment.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27831
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 16 Nov 2007 00:17:54 +0000 (00:17 +0000)]
2007-11-15 Eric Seidel <eric@webkit.org>
Reviewed by Sam.
Abstract most of RMATCH into MatchStack functions.
SunSpider claims this, combined with the last 2 patches was a 1% speedup, 10% for dna-regexp.
* pcre/pcre_exec.cpp:
(MatchStack::canUseStackBufferForNextFrame):
(MatchStack::allocateNextFrame):
(MatchStack::pushNewFrame):
(MatchStack::frameIsStackAllocated):
(MatchStack::popCurrentFrame):
(MatchStack::unrollAnyHeapAllocatedFrames):
(match):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27830
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 16 Nov 2007 00:16:21 +0000 (00:16 +0000)]
2007-11-15 Eric Seidel <eric@webkit.org>
Reviewed by Sam.
Remove RETURN_ERROR, add MatchStack
* pcre/pcre_exec.cpp:
(MatchStack::MatchStack):
(MatchStack::unrollAnyHeapAllocatedFrames):
(matchError):
(match):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27829
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 16 Nov 2007 00:14:33 +0000 (00:14 +0000)]
2007-11-15 Eric Seidel <eric@webkit.org>
Reviewed by Sam.
Clean up match function to match WebKit style
* JavaScriptCore.xcodeproj/project.pbxproj:
* pcre/pcre_exec.cpp:
(match):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27828
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Fri, 16 Nov 2007 00:07:44 +0000 (00:07 +0000)]
Reviewed by Adam.
Bug 16005: Hovering in the breadcrumbs causes jumpy behavior
http://bugs.webkit.org/show_bug.cgi?id=16005
Hovering over cumbs no longer exposes new crumbs. Clicking on a collapsed
crumb will expose as many hidden crumbs as possible to the user. Also crumbs
that have ID attributes will compact to the ID over the tag name.
* page/inspector/DocumentPanel.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27827
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 15 Nov 2007 23:53:19 +0000 (23:53 +0000)]
Reviewed by Sam.
Make the VoidCallback DOM interface behave more like our other DOM interfaces.
* bindings/js/JSCustomVoidCallback.h: Added.
* bindings/js/JSCustomVoidCallback.cpp: Added.
(WebCore::JSCustomVoidCallback::JSCustomVoidCallback):
(WebCore::JSCustomVoidCallback::handleEvent):
VoidCallback implementation that wraps a JS object.
(WebCore::toVoidCallback):
New method that creates a VoidCallback implementation given a JS object.
* bindings/scripts/CodeGeneratorJS.pm:
Specify that VoidCallback can fail conversion and add a custom conversion function.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::movieCuePointReached):
Call handleEvent on the callback.
(WebCore::HTMLMediaElement::removeCuePoint):
Comment out parts of this method, it has already been removed in the HTML5 spec and it relies
on overriding VoidCallback equality.
* html/VoidCallback.cpp: Removed.
* html/VoidCallback.h:
(WebCore::VoidCallback::VoidCallback):
(WebCore::VoidCallback::~VoidCallback):
Make this an abstract class with a pure virtual handleEvent method.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27826
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 15 Nov 2007 23:42:41 +0000 (23:42 +0000)]
Fix <rdar://
5485108> Type-select while a <select> menu is open doesn't work
There were two things broken here:
- WebView now requires a WM_CHAR message to be sent before it will
create a keyboard event with a charCode, but we were only sending
a WM_KEYDOWN event.
- The popup menu was not updating its focused index when the
<select> element's selectedIndex changed.
Reviewed by Adele.
* platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenu::updateFromElement): Update the focused index from
the client's selected index.
(WebCore::PopupWndProc): When we receive a WM_CHAR message for a
printable character, manufacture a WM_KEYDOWN message for it and post
both that and the current WM_CHAR message to the WebView.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27825
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Thu, 15 Nov 2007 23:23:54 +0000 (23:23 +0000)]
Build fix
* storage/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::fullPathForDatabase):
(WebCore::DatabaseTracker::databaseNamesForOrigin):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27824
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justin.garcia@apple.com [Thu, 15 Nov 2007 22:54:29 +0000 (22:54 +0000)]
Forgot this new expected result in my previous check-in.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27823
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Thu, 15 Nov 2007 22:29:34 +0000 (22:29 +0000)]
Reviewed by John and Sam
Stubbing out everything required for a WebKit API for databases
Biggest change in WebCore is that we passed around SecurityOriginData as the representation
of a SecurityOrigin, instead of a String or a SecurityOrigin itself (which is an opaque object
that has a different purpose besides just hanging on to the data)
* WebCore.base.exp:
* WebCore.xcodeproj/project.pbxproj:
* platform/SecurityOrigin.cpp:
* platform/SecurityOrigin.h:
* platform/SecurityOriginData.h: Added. Simple object to encapsulate the 3
pieces of data in the SecurityOrigin tuple
(WebCore::SecurityOriginData::SecurityOriginData):
(WebCore::SecurityOriginData::protocol):
(WebCore::SecurityOriginData::host):
(WebCore::SecurityOriginData::port):
(WebCore::SecurityOriginData::toString): Simple concatenation of the 3 components,
colon separated
* storage/Database.cpp:
(WebCore::Database::Database): Use SecurityOriginData instead
* storage/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::fullPathForDatabase):
(WebCore::DatabaseTracker::databaseNamesForOrigin):
(WebCore::DatabaseTracker::deleteDatabasesWithOrigin):
(WebCore::DatabaseTracker::deleteDatabase):
* storage/DatabaseTracker.h:
* storage/DatabaseTrackerClient.h: Added. For dispatching notifications up to WebKit
(WebCore::DatabaseTrackerClient::~DatabaseTrackerClient):2007-11-15 Jon Honeycutt <jhoneycutt@apple.com>
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27822
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Thu, 15 Nov 2007 22:27:14 +0000 (22:27 +0000)]
WebCore:
Reviewed by John and Sam
Stubbing out everything required for a WebKit API for databases
Biggest change in WebCore is that we passed around SecurityOriginData as the representation
of a SecurityOrigin, instead of a String or a SecurityOrigin itself (which is an opaque object
that has a different purpose besides just hanging on to the data)
* WebCore.base.exp:
* WebCore.xcodeproj/project.pbxproj:
* platform/SecurityOrigin.cpp:
* platform/SecurityOrigin.h:
* platform/SecurityOriginData.h: Added. Simple object to encapsulate the 3
pieces of data in the SecurityOrigin tuple
(WebCore::SecurityOriginData::SecurityOriginData):
(WebCore::SecurityOriginData::protocol):
(WebCore::SecurityOriginData::host):
(WebCore::SecurityOriginData::port):
(WebCore::SecurityOriginData::toString): Simple concatenation of the 3 components,
colon separated
* storage/Database.cpp:
(WebCore::Database::Database): Use SecurityOriginData instead
* storage/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::fullPathForDatabase):
(WebCore::DatabaseTracker::databaseNamesForOrigin):
(WebCore::DatabaseTracker::deleteDatabasesWithOrigin):
(WebCore::DatabaseTracker::deleteDatabase):
* storage/DatabaseTracker.h:
* storage/DatabaseTrackerClient.h: Added. For dispatching notifications up to WebKit
(WebCore::DatabaseTrackerClient::~DatabaseTrackerClient):
WebKit:
Reviewed by John
Stubbing out everything required for a WebKit API for databases
* WebKit.xcodeproj/project.pbxproj:
WebKit/mac:
Reviewed by John
Stubbing out everything required for a WebKit API for databases
These interfaces seem to provide everything we need for UI and management at the browser level
* Misc/WebDatabaseManager.h: Removed.
* Misc/WebDatabaseManager.mm: Removed.
* Misc/WebDatabaseManagerPrivate.h: Removed.
* Misc/WebSecurityOrigin.mm: Added. Object that acts as a container for the "SecurityOrigin tuple"
(protocol, domain, and port)
(-[WebSecurityOriginPrivate initWithProtocol:domain:port:]):
(-[WebSecurityOriginPrivate dealloc]):
(-[WebSecurityOrigin initWithProtocol:domain:]):
(-[WebSecurityOrigin initWithProtocol:domain:port:]):
(-[WebSecurityOrigin protocol]):
(-[WebSecurityOrigin domain]):
(-[WebSecurityOrigin port]):
(-[WebSecurityOrigin dealloc]):
(-[WebSecurityOrigin _initWithWebCoreSecurityOriginData:WebCore::]):
* Misc/WebSecurityOriginInternal.h: Added.
* Misc/WebSecurityOriginPrivate.h: Added.
* Storage/WebDatabaseManager.mm: Added.
(+[WebDatabaseManager sharedWebDatabaseManager]):
(-[WebDatabaseManager origins]): Get a list of all origins currently tracked
(-[WebDatabaseManager detailsForOrigin:]): Get the current usage and current quota for the given origin
(-[WebDatabaseManager databasesWithOrigin:]): Get all databases for a certain origin
(-[WebDatabaseManager detailsForDatabase:withOrigin:]): Get all details about a specific database
(-[WebDatabaseManager setQuota:forOrigin:]): Change origin-wide quota
(-[WebDatabaseManager deleteAllDatabases]):
(-[WebDatabaseManager deleteAllDatabasesWithOrigin:]):
(-[WebDatabaseManager deleteDatabase:withOrigin:]):
* Storage/WebDatabaseManagerPrivate.h: Added.
* Storage/WebDatabaseManagerInternal.h: Added.
(WebKitInitializeDatabasesIfNecessary): One-time initialization of database-related things
* Storage/WebDatabaseTrackerClient.h: Added. Stubbed out client for notifications
* Storage/WebDatabaseTrackerClient.mm: Added.
(WebDatabaseTrackerClient::sharedWebDatabaseTrackerClient):
(WebDatabaseTrackerClient::WebDatabaseTrackerClient):
(WebDatabaseTrackerClient::~WebDatabaseTrackerClient):
(WebDatabaseTrackerClient::dispatchDidModifyOrigin):
(WebDatabaseTrackerClient::dispatchDidModifyDatabase):
* WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]): Do one-time initialization of
Database-related things here
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27821
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jhoneycutt@apple.com [Thu, 15 Nov 2007 22:23:42 +0000 (22:23 +0000)]
2007-11-15 Jon Honeycutt <jhoneycutt@apple.com>
Reviewed by Anders.
NP_ASFILEONLY streams should not buffer data in m_deliveryData.
* plugins/win/PluginStreamWin.cpp:
(WebCore::PluginStreamWin::didReceiveData):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27820
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 15 Nov 2007 22:02:47 +0000 (22:02 +0000)]
Revert accidental change. andersca--
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27819
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justin.garcia@apple.com [Thu, 15 Nov 2007 21:52:41 +0000 (21:52 +0000)]
WebCore:
Reviewed by Adele Peterson.
<rdar://problem/
5497643> Crash at Node::isDescendantOf when switching out of Edit HTML Source mode
A textarea that contained the selection was removed but the selection wasn't cleared,
and we'd crash in code that assumed a valid, in-document selection.
* editing/SelectionController.cpp:
(WebCore::removingNodeRemovesPosition): Clear the selection if the node being removed is the
shadowAncestorNode of the node that contains the position, not just if the node being removed
contains that shadowAncestorNode.
LayoutTests:
Reviewed by Adele Peterson.
<rdar://problem/
5497643> Crash at Node::isDescendantOf when switching out of Edit HTML Source mode
* editing/selection/
5497643-expected.txt: Added.
* editing/selection/
5497643.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27818
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 15 Nov 2007 21:35:28 +0000 (21:35 +0000)]
Make run-safari actually work on Windows
* Scripts/run-safari: Fixed the order of arguments to cp, and added a
chdir call.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27817
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Thu, 15 Nov 2007 21:22:57 +0000 (21:22 +0000)]
Reviewed by Maciej.
Fix logic error: calculateGlyphBoundaries takes RTL text into account itself, no need to adjust offsets before.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27816
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 15 Nov 2007 20:27:44 +0000 (20:27 +0000)]
WebCore:
Reviewed by Brady.
<rdar://problem/
5562470>
openDatabase does not work when the version string is empty
If the string is empty, pass a real empty string to sqlite3_bind_text16.
* platform/sql/SQLiteStatement.cpp:
(WebCore::SQLiteStatement::bindText):
LayoutTests:
Reviewed by Brady.
<rdar://problem/
5562470>
openDatabase does not work when the version string is empty
* storage/open-database-empty-version-expected.txt: Added.
* storage/open-database-empty-version.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27815
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 15 Nov 2007 19:49:25 +0000 (19:49 +0000)]
Reviewed by Brady.
Get rid of SQLiteStatement::bindText and rename bindText16 to bindText.
Remove the copy parameter from bindText and bindBlob and always copy passed in data instead.
* loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::setIconIDForPageURLInSQLDatabase):
(WebCore::IconDatabase::removePageURLFromSQLDatabase):
(WebCore::IconDatabase::getIconIDForIconURLFromSQLDatabase):
(WebCore::IconDatabase::addIconURLToSQLDatabase):
(WebCore::IconDatabase::getImageDataForIconURLFromSQLDatabase):
(WebCore::IconDatabase::writeIconSnapshotToSQLDatabase):
* platform/sql/SQLiteStatement.cpp:
(WebCore::SQLiteStatement::prepare):
* platform/sql/SQLiteStatement.h:
* storage/Database.cpp:
(WebCore::setTextValueInDatabase):
* storage/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::fullPathForDatabase):
(WebCore::DatabaseTracker::databaseNamesForOrigin):
(WebCore::DatabaseTracker::addDatabase):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27813
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sfalken@apple.com [Thu, 15 Nov 2007 18:39:19 +0000 (18:39 +0000)]
Windows build fix.
* JavaScriptCore.vcproj/JavaScriptCore.make:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27812
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Thu, 15 Nov 2007 08:01:00 +0000 (08:01 +0000)]
WebCore:
Rubberstamped by Sam
* platform/SecurityOrigin.h: Lets make this an unsigned short and *not* rule out half the possible ports?
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27811
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Thu, 15 Nov 2007 05:59:40 +0000 (05:59 +0000)]
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=15982
Improve JSString UTF-8 decoding
* API/JSStringRef.cpp:
(JSStringCreateWithUTF8CString): Use strict decoding, return 0 on error.
* wtf/unicode/UTF8.cpp:
(WTF::Unicode::convertUTF16ToUTF8):
(WTF::Unicode::convertUTF8ToUTF16):
* wtf/unicode/UTF8.h:
Made these function names start with a lower case letter.
* kjs/ustring.cpp: (KJS::UString::UTF8String): Updated for the above renaming.
* bindings/c/c_utility.cpp:
(KJS::Bindings::convertUTF8ToUTF16WithLatin1Fallback): Renamed to highlight the difference
from convertUTF8ToUTF16 in wtf/unicode.
(KJS::Bindings::convertNPStringToUTF16): Updated for the above renaming.
(KJS::Bindings::identifierFromNPIdentifier): Ditto.
* bindings/c/c_utility.h: Made convertUTF8ToUTF16WithLatin1Fallback() a file static.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27810
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@webkit.org [Thu, 15 Nov 2007 05:49:44 +0000 (05:49 +0000)]
Reviewed by Justin Garcia.
http://bugs.webkit.org/show_bug.cgi?id=15781
REGRESSION: Ligatures fail to form when typing in Devanagari (because WebKit can't handle
a marked range that covers half of a composed character sequence)
Test: platform/mac/editing/input/devanagari-ligature.html
This fix is somewhat of a hack, as it asks editing commands to work with invalid selections.
However, this is not entirely new for them, as Roman accents are typed in a similar manner.
In the future, we probably want to make commands work with ranges (or Positions explicitly).
* editing/Editor.cpp:
(WebCore::Editor::selectComposition): Force selection to composition range.
* editing/InsertTextCommand.cpp:
(WebCore::InsertTextCommand::input): Force ending selection to inserted text range.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27809
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Thu, 15 Nov 2007 05:17:40 +0000 (05:17 +0000)]
Rubber-stamped by Anders.
Fix the Xcode project file after it was messed up in r27402.
* JavaScriptCore.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27808
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 15 Nov 2007 02:40:31 +0000 (02:40 +0000)]
2007-11-14 Eric Seidel <eric@webkit.org>
Reviewed by Oliver.
More PCRE style cleanup.
* pcre/pcre_compile.cpp:
(compile_regex):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27807
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 15 Nov 2007 02:02:33 +0000 (02:02 +0000)]
Clean up the bison conflict checking script
Reviewed by Geoff.
* DerivedSources.make:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27806
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 15 Nov 2007 02:00:15 +0000 (02:00 +0000)]
2007-11-14 Eric Seidel <eric@webkit.org>
Reviewed by Geoff.
Another round of PCRE cleanups: inlines
SunSpider claims that this, combined with my previous PCRE cleanup were a 0.7% speedup, go figure.
* pcre/pcre_compile.cpp:
(jsRegExpCompile):
* pcre/pcre_exec.cpp:
(match):
(jsRegExpExecute):
* pcre/pcre_internal.h:
(PUT):
(GET):
(PUT2):
(GET2):
(isNewline):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27805
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Thu, 15 Nov 2007 01:55:34 +0000 (01:55 +0000)]
For future use
* images/DroseraPic.png: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27804
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 15 Nov 2007 01:34:59 +0000 (01:34 +0000)]
Updates to Safari launching now that 3.0.4 is released
Reviewed by Sam.
* FindSafari/FindSafari.cpp:
(getWebViewCLSID): Use version-independent ProgID.
* Scripts/run-safari: Use run-webkit-nightly.cmd.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27803
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 15 Nov 2007 01:17:31 +0000 (01:17 +0000)]
2007-11-14 Eric Seidel <eric@webkit.org>
Reviewed by Sam.
Give PCRE a (small) bath.
Fix some formating and break things off into separate functions
http://bugs.webkit.org/show_bug.cgi?id=15993
* pcre/pcre_compile.cpp:
(calculateCompiledPatternLengthAndFlags):
(printCompiledRegExp):
(returnError):
(jsRegExpCompile):
* pcre/pcre_internal.h:
(compile_data::compile_data):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27802
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Thu, 15 Nov 2007 01:04:40 +0000 (01:04 +0000)]
Try to make this test less timing dependent.
* http/tests/media/video-play-stall.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27801
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin@apple.com [Wed, 14 Nov 2007 23:48:52 +0000 (23:48 +0000)]
WebCore:
Reviewed by Hyatt.
Fix for <rdar://problem/
5540855> REGRESSION: Combination of client-
side image map and <a> tag is not working properly (15522)
* html/HTMLMapElement.cpp:
(WebCore::HTMLMapElement::checkDTD): Allow <map> to have both block
and inline children rather than just block children. This matches
Firefox.
LayoutTests:
Reviewed by Hyatt.
Tests for <rdar://problem/
5540855> REGRESSION: Combination of
client-side image map and <a> tag is not working properly (15522)
New test:
* fast/images/image-map-anchor-children.html: Added.
* fast/images/resources/boston.gif: Added.
* platform/mac/fast/images/image-map-anchor-children-
expected.checksum: Added.
* platform/mac/fast/images/image-map-anchor-children-expected.png:
Added.
* platform/mac/fast/images/image-map-anchor-children-expected.txt:
Added.
This test was broken and is fixed now! I had to edit the test
itself because it was written in the html that the two <map>
examples were failing, but now they succeed.
* fast/invalid/residual-style.html:
* platform/mac/fast/invalid/residual-style-expected.checksum:
* platform/mac/fast/invalid/residual-style-expected.png:
* platform/mac/fast/invalid/residual-style-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27800
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren@apple.com [Wed, 14 Nov 2007 22:59:29 +0000 (22:59 +0000)]
Reviewed by Eric Seidel.
Cleaned up the JavaScript grammar a bit.
1. Changed BlockNode to always hold a child vector (which may be empty),
eliminating a few NULL-check branches in the common execution case.
2. Changed the Block production to correctly report its starting and
ending line numbers to the debugger. (It used to report its ending line
as its starting line.) Also, removed duplicate line-reporting code
inside the BlockNode constructor.
3. Moved curly braces up from FunctionBody production into parent
productions. (I had to move the line number reporting code, too, since
it depends on the location of the curly braces.) This matches the ECMA
spec more closely, and makes some future changes I plan easier.
4. Fixed statementList* convenience functions to deal appropriately with
empty Vectors.
SunSpider reports a small and statistically insignificant speedup.
* kjs/grammar.y:
* kjs/nodes.cpp:
(KJS::statementListPushFIFO):
(KJS::statementListGetDeclarations):
(KJS::statementListInitializeDeclarationStack):
(KJS::statementListInitializeVariableAccessStack):
(KJS::BlockNode::BlockNode):
(KJS::BlockNode::optimizeVariableAccess):
(KJS::BlockNode::getDeclarations):
(KJS::BlockNode::execute):
(KJS::FunctionBodyNode::initializeDeclarationStacks):
(KJS::FunctionBodyNode::optimizeVariableAccess):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27799
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Wed, 14 Nov 2007 22:57:45 +0000 (22:57 +0000)]
Change Interfaces to be a "Static Library" project
Being a Utility project meant that Interfaces was rebuilding every
time (Utility projects are supposed to handle their own dependencies).
Interfaces isn't really a static library, but it means that VS will
handle dependencies for us (and not complain about missing manifests
like it did when the project was an Application).
* WebKit.vcproj/Interfaces.vcproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27798
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Wed, 14 Nov 2007 22:56:44 +0000 (22:56 +0000)]
Shut up FixMIDLHeaders.pl
* WebKit.vcproj/FixMIDLHeaders.pl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27797
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justin.garcia@apple.com [Wed, 14 Nov 2007 22:33:07 +0000 (22:33 +0000)]
WebCore:
Reviewed by Alexey Proskuryakov.
<rdar://problem/
5546763> CrashTracer: [USER] 362 crashes at WebCore::DeleteSelectionCommand::mergeParagraphs
* editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::handleGeneralDelete):
Removed an irrelevant FIXME.
(WebCore::DeleteSelectionCommand::mergeParagraphs): If the block that contained the end of the selection
hasn't been removed but has been emptied by deletion, we would to try and fail to create a VisiblePosition
inside that block, which could lead to a crash. If that happens, there's no content in the block to move,
so just remove the block and return.
Preserve m_needPlaceholder during the call to moveParagraphs, since it may change it and since it does
its own placeholder insertion when necessary.
(WebCore::DeleteSelectionCommand::doApply): No need to check m_needPlaceholder before calling mergeParagraphs,
because it handles preserving m_needPlaceholder when it calls moveParagraphs.
LayoutTests:
Reviewed by Alexey Proskuryakov.
<rdar://problem/
5546763> CrashTracer: [USER] 362 crashes at WebCore::DeleteSelectionCommand::mergeParagraphs
* editing/deleting/
5546763-expected.txt: Added.
* editing/deleting/
5546763.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27796
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 14 Nov 2007 22:30:35 +0000 (22:30 +0000)]
WebKitTools:
Reviewed by Adam.
<rdar://problem/
5309081>
In DRT, "plugin.logDestroy = true" not working on Windows.
* DumpRenderTree/win/TestNetscapePlugin/main.c:
(NPP_Destroy):
LayoutTests:
Reviewed by Adam.
<rdar://problem/
5309081>
In DRT, "plugin.logDestroy = true" not working on Windows.
Remove now succeeding test from the skipped list.
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27795
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Wed, 14 Nov 2007 22:09:44 +0000 (22:09 +0000)]
Remove the WebKit dependancy from WebKitSystemInterface.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27794
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Wed, 14 Nov 2007 22:08:45 +0000 (22:08 +0000)]
Fix ChangeLog order
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27793
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Wed, 14 Nov 2007 22:07:26 +0000 (22:07 +0000)]
Change Interfaces to use a Utility configuration
It had previously been marked as an "Application (.exe)", which is
wrong but worked with most versions of Visual Studio.
Rubberstamped by Steve.
* WebKit.vcproj/Interfaces.vcproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27792
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antti@apple.com [Wed, 14 Nov 2007 21:44:50 +0000 (21:44 +0000)]
Try to make this test less timing dependent.
* media/video-currentTime-set-expected.txt:
* media/video-currentTime-set.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27791
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Wed, 14 Nov 2007 20:36:28 +0000 (20:36 +0000)]
2007-11-14 Eric Seidel <eric@webkit.org>
Reviewed by Sam.
* sunspider: add --shark-cache for L2 Cache Miss profiling
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27790
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
timothy@apple.com [Wed, 14 Nov 2007 19:19:09 +0000 (19:19 +0000)]
Reviewed by Adam.
Bug 14380: Long DOM ancestry breadcrumb lists get cut off
http://bugs.webkit.org/show_bug.cgi?id=14380
The breadcumbs will now be compacted and collapsed if there isn't enough room
to show everything. The collapsing algorithm always affects the crumbs that
are farthest away from the selected or hovered crumb first.
* page/inspector/DocumentPanel.js:
* page/inspector/inspector.css:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27789
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 14 Nov 2007 19:10:50 +0000 (19:10 +0000)]
WebKit/win:
Reviewed by Adam.
Get the new focus window from the wParam instead of calling GetFocus().
Also, send blur even if there is no focused frame.
* WebView.cpp:
(WebViewWndProc):
WebKitTools:
Reviewed by Adam.
<rdar://problem/
5141186>
window.layoutTestController.setWindowIsKey is not implemented in DRT.
Implement setWindowIsKey.
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::setWindowIsKey):
LayoutTests:
Reviewed by Adam.
* platform/win/Skipped:
Remove fast/dom/Window/window-onFocus.html since it succeeds now.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27788
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Wed, 14 Nov 2007 18:53:59 +0000 (18:53 +0000)]
Another build fix for systems without Cygwin in their PATH
* WebKit.vcproj/Interfaces.vcproj: Add Cygwin to the PATH in the
Post-Build Event.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27787
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Wed, 14 Nov 2007 18:36:06 +0000 (18:36 +0000)]
Use the correct include path.
* platform/Cursor.h:
* plugins/win/PluginPackageWin.h:
* plugins/win/PluginStreamWin.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27786
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrowe@apple.com [Wed, 14 Nov 2007 06:59:32 +0000 (06:59 +0000)]
2007-11-13 Mark Rowe <mrowe@apple.com>
Gtk build fix. Replace incorrect use of the LOG macro with g_print.
* Api/webkitgtkpage.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27785
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
beidson@apple.com [Wed, 14 Nov 2007 06:46:31 +0000 (06:46 +0000)]
WebCore:
Reviewed by Adam
http://bugs.webkit.org/show_bug.cgi?id=15976 - ASSERT/crash when SQLTransactionCallback throws an exception
* storage/SQLTransaction.cpp:
(WebCore::SQLTransaction::deliverTransactionCallback): Make a transaction error for the case where the
SQLTransactionCallback fails
(WebCore::SQLTransaction::deliverTransactionErrorCallback): Don't assert on the error callback, but null check it
and make the commit/rollback decision accordingly
LayoutTests:
Reviewed by Adam
Fix for http://bugs.webkit.org/show_bug.cgi?id=15976
* storage: Added - There will soon be an entire suite in here!
* storage/transaction_callback_exception_crash-expected.txt: Added.
* storage/transaction_callback_exception_crash.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27784
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Wed, 14 Nov 2007 06:25:33 +0000 (06:25 +0000)]
Add the http/tests/media directory to the Windows Skipped file
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27783
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alp@webkit.org [Wed, 14 Nov 2007 05:40:57 +0000 (05:40 +0000)]
2007-11-13 Christian Dywan <christian@twotoasts.de>
Reviewed by Alp.
http://bugs.webkit.org/show_bug.cgi?id=15891
[GTK] Javascript console and dialogs are not implemented
Implement signals for script dialogs and console messages.
* Api/webkitgtk-marshal.list:
* Api/webkitgtkpage.cpp:
* Api/webkitgtkpage.h:
* WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::addMessageToConsole):
(WebKit::ChromeClient::runJavaScriptAlert):
(WebKit::ChromeClient::runJavaScriptConfirm):
(WebKit::ChromeClient::runJavaScriptPrompt):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27782
268f45cc-cd09-0410-ab3c-
d52691b4dbfc