WebKit-https.git
15 years agoLayoutTests:
ddkilzer [Sun, 4 Mar 2007 15:47:21 +0000 (15:47 +0000)]
LayoutTests:

        Reviewed by Nikolas Zimmermann.

        - fix http://bugs.webkit.org/show_bug.cgi?id=12951
          REGRESSION (r19949): LayoutTests/fast/xsl/xslt-processer.html fails

        Fixed spelling of "processer" to "processor" in file names.

        * fast/xsl/xslt-processer-expected.txt: Removed.
        * fast/xsl/xslt-processer.html: Removed.
        * fast/xsl/xslt-processor-expected.txt: Added. Results progressed after fixing
        Bugzilla Bug 12735 (<rdar://problem/4545040>).
        * fast/xsl/xslt-processor.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
kmccullo [Sat, 3 Mar 2007 02:18:43 +0000 (02:18 +0000)]
LayoutTests:

        Reviewed by Geoff.

        - rdar://problem/4922454
        - This fixes a security issue by making remote referrers not able to access local
        resources, unless they register their schemes to be treated as local. The result is
        that those schemes can access local resources and cannot be accessed by remote
        referrers.
        Because this behavior is new a link-on-or-after check is made to determine if the
        app should use the older, less safe, behavior.

        * fast/loader/local-CSS-from-local-expected.txt: Added.
        * fast/loader/local-CSS-from-local.html: Added.
        * fast/loader/local-JavaScript-from-local-expected.txt: Added.
        * fast/loader/local-JavaScript-from-local.html: Added.
        * fast/loader/local-iFrame-source-from-local-expected.txt: Added.
        * fast/loader/local-iFrame-source-from-local.html: Added.
        * fast/loader/local-image-from-local-expected.txt: Added.
        * fast/loader/local-image-from-local.html: Added.
        * http/tests/security/local-CSS-from-remote-expected.txt: Added.
        * http/tests/security/local-CSS-from-remote.html: Added.
        * http/tests/security/local-JavaScript-from-remote-expected.txt: Added.
        * http/tests/security/local-JavaScript-from-remote.html: Added.
        * http/tests/security/local-iFrame-from-remote-expected.txt: Added.
        * http/tests/security/local-iFrame-from-remote.html: Added.
        * http/tests/security/local-image-from-remote-expected.txt: Added.
        * http/tests/security/local-image-from-remote.html: Added.
        * http/tests/security/resources/compass.jpg: Added.
        * http/tests/security/resources/cssStyle.css: Added.
        * http/tests/security/resources/localPage.html: Added.
        * http/tests/security/resources/localScript.js: Added.

WebCore:

        Reviewed by Geoff.

        - rdar://problem/4922454
        - This fixes a security issue by making remote referrers not able to access local
        resources, unless they register their schemes to be treated as local. The result is
        that those schemes can access local resources and cannot be accessed by remote
        referrers.
        Because this behavior is new a link-on-or-after check is made to determine if the
        app should use the older, less safe, behavior.

        * WebCore.exp: added exported functions
        * bindings/objc/DOM.mm: consolodated function to base class
        (-[DOMElement image]):
        (-[DOMElement _imageTIFFRepresentation]):
        * dom/Document.cpp: Cache the document's ability to load local resources.
        (WebCore::Document::Document):
        (WebCore::Document::setURL):
        (WebCore::Document::shouldBeAllowedToLoadLocalResources):
        (WebCore::Document::stylesheetLoaded):
        * dom/Document.h: Cache the docuent's ability to load local resources.
        (WebCore::Document::getPendingSheet):
        (WebCore::Document::isAllowedToLoadLocalResources):
        * html/HTMLImageLoader.cpp: Moved functionality into base class.
        (WebCore::HTMLImageLoader::updateFromElement):
        (WebCore::HTMLImageLoader::dispatchLoadEvent):
        * html/HTMLLinkElement.cpp: Handles null returns correctly now.
        * html/HTMLTokenizer.cpp: Moved functionality into base class.
        (WebCore::HTMLTokenizer::notifyFinished):
        * ksvg2/misc/SVGImageLoader.cpp: Moved functionality into base class.
        (WebCore::SVGImageLoader::dispatchLoadEvent):
        * loader/Cache.cpp: Checks if the cached resource can be loaded.
        (WebCore::Cache::requestResource):
        * loader/CachedCSSStyleSheet.cpp: Moved functionality into base class.
        (WebCore::CachedCSSStyleSheet::ref):
        (WebCore::CachedCSSStyleSheet::error):
        * loader/CachedImage.cpp: Moved functionality into base class.
        (WebCore::CachedImage::CachedImage):
        * loader/CachedImage.h: Moved functionality into base class.
        (WebCore::CachedImage::canRender):
        * loader/CachedResource.cpp: Cache if the CachedResource should be treated as local
        (WebCore::CachedResource::CachedResource):
        * loader/CachedResource.h: Moved functionality into base class.
        (WebCore::CachedResource::errorOccurred):
        (WebCore::CachedResource::shouldTreatAsLocal):
        * loader/CachedScript.cpp: Moved functionality into base class.
        (WebCore::CachedScript::CachedScript):
        * loader/CachedScript.h: Moved functionality into base class.
        (WebCore::CachedScript::schedule):
        * loader/CachedXBLDocument.cpp: Moved functionality into base class.
        (WebCore::CachedXBLDocument::error):
        * loader/CachedXSLStyleSheet.cpp: Moved functionality into base class.
        (WebCore::CachedXSLStyleSheet::error):
        * loader/FrameLoader.cpp: See comments for each function below.
        (WebCore::FrameLoader::loadSubframe): Use new canLoad.
        (WebCore::FrameLoader::restrictAccessToLocal): return value of linked-on-or-after check.
        (WebCore::FrameLoader::setRestrictAccessToLocal): set value for linked-on-or-after check.
        (WebCore::localSchemes): Return set of schemes that are to be treated as local.
        (WebCore::FrameLoader::loadPlugin): Use new canLoad.
        (WebCore::FrameLoader::canLoad): Now multiple functions that each do the same work but some can take advantage of the cached values, if they were computed previously.
        (WebCore::FrameLoader::shouldHideReferrer): Extracted out the logic to determine if the referrer should be hidden so it is only calculated when needed.
        (WebCore::FrameLoader::loadResourceSynchronously): No longer calls canLoad to get hideReferrer info.
        (WebCore::FrameLoader::registerSchemeAsLocal): Functionality to register a scheme to be treated as local.
        (WebCore::FrameLoader::treatURLAsLocal): Given a URL this function determines if it should be treated as local.
        * loader/FrameLoader.h: Declared functions for this security fix.  See above.
        * loader/MainResourceLoader.cpp: Optized order of bools to regain performance.
        (WebCore::MainResourceLoader::continueAfterContentPolicy):
        * loader/SubresourceLoader.cpp: Now restricts remote from loading local resources.
        (WebCore::SubresourceLoader::create):
        * page/EventHandler.cpp: Moved functionality into base class.
        (WebCore::selectCursor):
        * platform/KURL.cpp: KURLs need to check all the registered schemes now.
        (WebCore::KURL::isLocalFile):
        * rendering/HitTestResult.cpp: Moved functionality into base class.
        (WebCore::HitTestResult::image):
        * rendering/RenderImage.cpp: Moved functionality into base class.
        (WebCore::RenderImage::setCachedImage):
        (WebCore::RenderImage::imageChanged):
        (WebCore::RenderImage::paint):
        (WebCore::RenderImage::layout):
        (WebCore::RenderImage::calcAspectRatioWidth):
        (WebCore::RenderImage::calcAspectRatioHeight):
        * rendering/RenderImage.h: Moved functionality into base class.
        (WebCore::RenderImage::errorOccurred):
        * rendering/RenderListItem.cpp: Moved functionality into base class.
        (WebCore::RenderListItem::setStyle):
        * rendering/RenderListMarker.cpp: Moved functionality into base class.
        (WebCore::RenderListMarker::isImage):
        * xml/xmlhttprequest.cpp: Check doc's cached value instead of determining independently.
        (WebCore::XMLHttpRequest::urlMatchesDocumentDomain):

WebKit:

        Reviewed by Geoff.

        - rdar://problem/4922454
        - This fixes a security issue by making remote referrers not able to access local
        resources, unless they register their schemes to be treated as local. The result is
        that those schemes can access local resources and cannot be accessed by remote
        referrers.
        Because this behavior is new a link-on-or-after check is made to determine if the
        app should use the older, less safe, behavior.

        * Misc/WebKitVersionChecks.h: added linked-on-or-after check
        * Misc/WebNSAttributedStringExtras.mm: Moved functionalit into the base class.
        (fileWrapperForElement):
        * Plugins/WebNetscapePluginStream.mm: uses new canLoad functions
        * Plugins/WebPluginContainerCheck.mm: uses new canLoad functions
        (-[WebPluginContainerCheck _isForbiddenFileLoad]):
        * WebView/WebView.mm: make linked-on-or-after check and cache value, exposes SPI
        for registering a scheme as local.
        (-[WebView _commonInitializationWithFrameName:groupName:]):
        (+[WebView registerSchemeAsLocal:]):
        * WebView/WebViewPrivate.h: exposes SPI for registering a scheme as local.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
justing [Sat, 3 Mar 2007 01:46:44 +0000 (01:46 +0000)]
LayoutTests:

        Reviewed by kevin

        <rdar://problem/5028447>
        REGRESSION: Gmail Editor: Copied message text pastes at the wrong font size

        * editing/pasteboard/5028447-expected.checksum: Added.
        * editing/pasteboard/5028447-expected.png: Added.
        * editing/pasteboard/5028447-expected.txt: Added.
        * editing/pasteboard/5028447.html: Added.

WebCore:

        Reviewed by kevin

        <rdar://problem/5028447>
        REGRESSION: Gmail Editor: Copied message text pastes at the wrong font size

        * editing/markup.cpp:
        (WebCore::createMarkup): The style of the div that holds
        a fully selected body's styles didn't include styles inherited
        from the body's ancestors.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Tweaked parse-malloc-history to work with new malloc_history output format.
ggaren [Sat, 3 Mar 2007 00:48:34 +0000 (00:48 +0000)]
    Tweaked parse-malloc-history to work with new malloc_history output format.

        * Scripts/parse-malloc-history:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
justing [Fri, 2 Mar 2007 23:02:49 +0000 (23:02 +0000)]
LayoutTests:

        Reviewed by harrison

        <rdar://problem/4545040>
        innerHTML does not HTML-escape text nodes inside PRE elements
        <rdar://problem/5027857>
        Pasting into Mail from Safari's view-source window renders the HTML

        * editing/pasteboard/5027857-expected.checksum: Added.
        * editing/pasteboard/5027857-expected.png: Added.
        * editing/pasteboard/5027857-expected.txt: Added.
        * editing/pasteboard/5027857.html: Added.

WebCore:

        Reviewed by harrison

        <rdar://problem/4545040>
        innerHTML does not HTML-escape text nodes inside PRE elements
        <rdar://problem/5027857>
        Pasting into Mail from Safari's view-source window renders the HTML

        * editing/HTMLInterchange.cpp:
        (WebCore::convertHTMLTextToInterchangeFormat): Send this function
        the node that the text comes from as a parameter.  It shouldn't convert
        '\n's to spaces/nbsps if the text is coming from text where newlines are
        preserved.
        * editing/HTMLInterchange.h:
        * editing/markup.cpp:
        (WebCore::startMarkup): Escape text inside the children of PREs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
weinig [Fri, 2 Mar 2007 21:10:59 +0000 (21:10 +0000)]
WebCore:

        Reviewed by Anders.

        Try to fix the Qt build.

        * platform/qt/TemporaryLinkStubs.cpp: Add stubs.
        (WebCore::searchMenuNoRecentSearchesText):
        (WebCore::searchMenuRecentSearchesText):
        (WebCore::searchMenuClearRecentSearchesText):
        (WebCore::AXWebAreaText):
        (WebCore::AXLinkText):
        (WebCore::AXListMarkerText):
        (WebCore::AXImageMapText):
        (WebCore::AXHeadingText):

WebKitQt:

        Reviewed by Anders.

        Try to fix the Qt build

        * WebCoreSupport/DragClientQt.cpp:
        (WebCore::DragClientQt::willPerformDragDestinationAction):
        (WebCore::DragClientQt::dragControllerDestroyed):
        (WebCore::DragClientQt::createDragImageForLink):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-03-02 Steve Falkenburg <sfalken@apple.com>
sfalken [Fri, 2 Mar 2007 21:06:33 +0000 (21:06 +0000)]
2007-03-02  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Anders.

        Add unsigned int hash traits (matches existing unsigned long version)

        * wtf/HashTraits.h:
        (WTF::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Suggested by Darin.
harrison [Fri, 2 Mar 2007 21:06:26 +0000 (21:06 +0000)]
    Suggested by Darin.

        A more efficient solution to rdar://4961431.

        * bridge/mac/WebCoreAXObject.mm:
        (-[WebCoreAXObject accessibilityIsIgnored]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Kevin M.
aroben [Fri, 2 Mar 2007 19:55:21 +0000 (19:55 +0000)]
    Reviewed by Kevin M.

        Try to fix the Qt build.

        * kjs/DateMath.cpp:
        (KJS::msToGregorianDateTime): Removed unnecessary "struct" keyword.
        * kjs/DateMath.h: Moved forward declarations to the top of the file
        before they are used.
        * kjs/date_object.cpp:
        (KJS::formatLocaleDate): Changed to take a const GregorianDateTime&
        since GregorianDateTime is Noncopyable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
justing [Fri, 2 Mar 2007 19:53:42 +0000 (19:53 +0000)]
LayoutTests:

        Reviewed by john

        <rdar://problem/5032095>
        Gmail Editor: Copied text pastes on a new line instead of current line

        * editing/pasteboard/5032095-expected.checksum: Added.
        * editing/pasteboard/5032095-expected.png: Added.
        * editing/pasteboard/5032095-expected.txt: Added.
        * editing/pasteboard/5032095.html: Added.

WebCore:

        Reviewed by john

        <rdar://problem/5032095>
        Gmail Editor: Copied text pastes on a new line instead of current line

        Start merge failed to occur because positionAtStartOfInsertedContent
        had a bug.

        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::positionAtStartOfInsertedContent):
        Was failing when inserting <span><div>foo/div></span>. Return the
        inserted content's first VisiblePosition.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Kevin McCullough.
darin [Fri, 2 Mar 2007 17:42:20 +0000 (17:42 +0000)]
    Reviewed by Kevin McCullough.

        - fix http://bugs.webkit.org/show_bug.cgi?id=12867
          REGRESSION: BenchJS test 7 (dates) is 220% slower than in Safari 2.0.4

        * kjs/DateMath.h: Marked GregorianDateTime as noncopyable, since it has a non-trivial
        destructor and not the correspoding copy constructor or assignment operator.
        Changed the GregorianDateTime constructor to use member initialization syntax.
        Fixed the destructor to use the array delete operator, since timeZone is an array.

        * kjs/DateMath.cpp:
        (KJS::daysInYear): Changed to call isLeapYear so the rule is not repeated twice.
        (KJS::getUTCOffset): Added caching on PLATFORM(DARWIN), since we can rely on the
        notify_check function and "com.apple.system.timezone" to let us know when the
        offset has changed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix glyph map crasher.
hyatt [Fri, 2 Mar 2007 09:39:34 +0000 (09:39 +0000)]
Fix glyph map crasher.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej.
antti [Fri, 2 Mar 2007 08:22:45 +0000 (08:22 +0000)]
    Reviewed by Maciej.

        Fix for http://bugs.webkit.org/show_bug.cgi?id=12895
        REGRESSION: imagemap: pointer cursor is shown everywhere
        <rdar://problem/5028163>

        Image with imagemap should never itself be URLElement in hit test results.

        No layout test, cursor state can't be captured.

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::hitTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
antti [Fri, 2 Mar 2007 07:59:15 +0000 (07:59 +0000)]
LayoutTests:

        Reviewed by Maciej.

        HTTP layout test for http://bugs.webkit.org/show_bug.cgi?id=12690
        REGRESSION: can not log in to bank of america with TOT webkit
        <rdar://problem/4990044>

        also for
        http://bugs.webkit.org/show_bug.cgi?id=12604
        http://bugs.webkit.org/show_bug.cgi?id=12020

        * http/tests/misc/multiple-submit-expected.txt: Added.
        * http/tests/misc/multiple-submit.html: Added.
        * http/tests/misc/resources/post-echo-and-notify-done.cgi: Added.

WebCore:

        Reviewed by Maciej.

        Fix http://bugs.webkit.org/show_bug.cgi?id=12690
        REGRESSION: can not log in to bank of america with TOT webkit
        <rdar://problem/4990044>

        and http://bugs.webkit.org/show_bug.cgi?id=12604
        REGRESSION: After closing the "Would you like to save password" sheet, the form fails
        to submit automatically at http://www.mac.com/WebObjects/HomePage.woa
        <rdar://problem/4871752>

        and http://bugs.webkit.org/show_bug.cgi?id=12020
        REGRESSION: Flickr uploading broken
        <rdar://problem/4928662>

        Turn protection against multiple forms submission back on. This approach is buggy
        but it is way better than not having it at all. Not protecting against this
        breaks number of major sites.

        * bridge/mac/WebCoreAXObject.mm:
        (-[WebCoreAXObject accessibilityPerformAction:]):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::resetMultipleFormSubmissionProtection):
        (WebCore::FrameLoader::submitForm):
        (WebCore::FrameLoader::receivedMainResourceError):
        * loader/FrameLoader.h:
        * page/EventHandler.cpp:
        (WebCore::EventHandler::keyEvent):
        * page/Frame.cpp:
        (WebCore::Frame::setView):
        * page/mac/EventHandlerMac.mm:
        (WebCore::EventHandler::mouseDown):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
kmccullo [Fri, 2 Mar 2007 02:42:47 +0000 (02:42 +0000)]
LayoutTests:

        Reviewed by Adam.

        - Tests that the url of a document after an open is what it was before the open.

        * fast/loader/external-script-URL-location-expected.txt: Added.
        * fast/loader/external-script-URL-location.html: Added.
        * fast/loader/resources/external-script-URL-location.js: Added.

WebCore:

        Reviewed by Adam.

        - Added the test case: external-script-URL-location.html
        - Fix an issue where the url of a document is null after an open if the document
        has no parent.

        * dom/Document.cpp:
        (WebCore::Document::open):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19934 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
andersca [Fri, 2 Mar 2007 02:17:04 +0000 (02:17 +0000)]
    Reviewed by Darin.

        <rdar://problem/4960250>
        http://bugs.webkit.org/show_bug.cgi?id=11627
        REGRESSION: Reproducible crash at IMDb in WebCore::FrameLoader::stopLoadingSubframes

        In rare cases, we could end up calling checkLoadComplete twice for the same frame. This would cause the
        didFailProvisionalLoad delegate method to be called twice for the same frame, and also cause the provisional document loader
        to be reset to null when other code wasn't expecting it.

        This regressed in revision 10904 with the fix for <rdar://problem/4184719>. The fix is to only call stopLoading on the frame
        if either the document loader is loading, or the document is still being parsed. I've verified that the bug is still fixed and
        that no leaks occur.

        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::stopLoading):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
kjk [Fri, 2 Mar 2007 01:58:32 +0000 (01:58 +0000)]
    Reviewed by Darin.

        Fix ARM crash due to accessing non-4-byte-aligned memory
        as 32-bit values.

        * platform/AtomicString.cpp:
        (WebCore::UCharBufferTranslator::equal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by harrison
justing [Fri, 2 Mar 2007 01:57:12 +0000 (01:57 +0000)]
    Reviewed by harrison

        <rdar://problem/4838199>
        Integrate Mail and WebKit paste operations

        Provide subresources used to create the fragment as a
        convenience.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _documentFragmentFromPasteboard:inContext:allowPlainText:chosePlainText:]):
        Update the calls to the changed method.
        (-[WebHTMLView _documentFragmentFromPasteboard:forType:inContext:subresources:]):
        Give the caller the subresources in the WebArchive and RTF cases.
        * WebView/WebHTMLViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
harrison [Fri, 2 Mar 2007 01:53:50 +0000 (01:53 +0000)]
    Reviewed by Darin.

        <rdar://problem/5033905> Have the DOM secondary thread check raise an exception by default

        * platform/mac/ThreadCheck.mm:
        (WebCore::_WebCoreThreadViolationCheck):
        Initialize threadViolationIsException to true.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin
beidson [Thu, 1 Mar 2007 22:00:22 +0000 (22:00 +0000)]
    Reviewed by Darin

        <rdar://problem/5030628> - Crash opening a new window with the
        "New windows open to the same page" pref set

        * history/HistoryItem.cpp:
        (WebCore::HistoryItem::HistoryItem): Set the m_subItems vector capacity correctly

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej.
ap [Thu, 1 Mar 2007 17:08:24 +0000 (17:08 +0000)]
    Reviewed by Maciej.

        http://bugs.webkit.org/show_bug.cgi?id=12801
        Assertion failure in createMarkup() (root) when doing Select All, Copy in an SVG document

        Test: editing/pasteboard/createMarkup-assert.xml

        * editing/markup.cpp:
        (WebCore::createMarkup): Removed the assertion, because it's wrong in a non-HTML world.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Oliver and Hyatt.
aroben [Thu, 1 Mar 2007 07:43:27 +0000 (07:43 +0000)]
    Reviewed by Oliver and Hyatt.

        Fix <rdar://problem/5024233> Crash while using Find on empty document

        No layout test possible, as this involves a null document.

        * dom/Range.cpp:
        (WebCore::rangeOfContents): Added an ASSERT.
        * page/Frame.cpp:
        (WebCore::Frame::findString): Added a null-check for document().
        (WebCore::Frame::markAllMatchesForText): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-02-28 Oliver Hunt <oliver@apple.com>
oliver [Thu, 1 Mar 2007 03:25:29 +0000 (03:25 +0000)]
2007-02-28  Oliver Hunt  <oliver@apple.com>

        Reviewed by Maciej.

        Fixes <rdar://problem/5012009>

        When looking for a requested resource we should also check
        the set of manually added subresources if WebCore can't find it.

        * WebView/WebDataSource.mm:
        (-[WebDataSource subresourceForURL:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Tim H.
thatcher [Thu, 1 Mar 2007 01:30:53 +0000 (01:30 +0000)]
    Reviewed by Tim H.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=12887
        Bug#12887: [Drosera] Add ability to close loaded files

        * Drosera/DebuggerDocument.h:
        * Drosera/DebuggerDocument.m:
        (-[DebuggerDocument closeCurrentFile:]): Adds delegation to call a JS script to close files
        * Drosera/Drosera.xcodeproj/project.pbxproj:
        * Drosera/English.lproj/MainMenu.nib/classes.nib:
        * Drosera/English.lproj/MainMenu.nib/info.nib:
        * Drosera/English.lproj/MainMenu.nib/keyedobjects.nib: Adds Close Current File menu item
        * Drosera/debugger.html: Changed "no files loaded" to "<No files loaded>" to match Xcode style
        * Drosera/debugger.js: Adds implementation of closeFile() to unload currently loaded file

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Not reviewed - simple gdk build fix.
kjk [Thu, 1 Mar 2007 00:47:24 +0000 (00:47 +0000)]
    Not reviewed - simple gdk build fix.

        Add stubs for newly introduced localized strings.

        * platform/gdk/TemporaryLinkStubs.cpp:
        (WebCore::searchMenuNoRecentSearchesText):
        (WebCore::searchMenuRecentSearchesText):
        (WebCore::searchMenuClearRecentSearchesText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
beidson [Thu, 1 Mar 2007 00:01:57 +0000 (00:01 +0000)]
WebCore:

        Reviewed by Beth

        Move the Thread Safety Check functions into their own header for export to WebKit

        * WebCore.exp: Export the function
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/scripts/CodeGeneratorObjC.pm: Include the new header
        * platform/Logging.h: Move stuff to ThreadCheck.h
        * platform/ThreadCheck.h: Added.
        * platform/mac/LoggingMac.mm: Move stuff to ThreadCheck.mm
        * platform/mac/ThreadCheck.mm: Added.
        (WebCore::_WebCoreThreadViolationCheck):
        (WebCoreReportThreadViolation):

WebKit:

        Reviewed by Beth

        Start using the Thread Safety Check implemented in WebCore for the DOM bindings in the rest of
        the WebKit API instead of the ASSERT_MAIN_THREAD() hack

        * History/WebBackForwardList.mm:
        (-[WebBackForwardList initWithWebCoreBackForwardList:]):
        (-[WebBackForwardList init]):
        (-[WebBackForwardList dealloc]):
        (-[WebBackForwardList finalize]):
        * History/WebHistoryItem.mm:
        (-[WebHistoryItem initWithURLString:title:lastVisitedTimeInterval:]):
        (-[WebHistoryItem dealloc]):
        (-[WebHistoryItem finalize]):
        (-[WebHistoryItem copyWithZone:]):
        (-[WebHistoryItem initWithWebCoreHistoryItem:]):
        * Misc/WebIconDatabase.mm:
        (-[WebIconDatabase init]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Brady.
bdakin [Wed, 28 Feb 2007 23:46:58 +0000 (23:46 +0000)]
    Reviewed by Brady.

        Fix for http://bugs.webkit.org/show_bug.cgi?id=12923 REGRESSION:
        Assertion failure copying standalone image

        * platform/mac/PasteboardMac.mm:
        (WebCore::Pasteboard::writeImage): Use the CachedImage as the
        resource. This makes more sense anyway. There is no need to null-
        check the renderer or the CachedImage since we return early if
        there is no Image* and the HitTestResult::image() function checks
        for these things.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
adele [Wed, 28 Feb 2007 23:08:47 +0000 (23:08 +0000)]
WebCore:

        Reviewed by Beth.

        Fix for <rdar://problem/4887423> REGRESSION: search results popup menu strings are not localized
        and <rdar://problem/3517227> accessibility-related strings in WebCore are not localized

        Use localized strings from WebKit instead of hard coded strings.

        * bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject roleDescription]):
        * page/mac/WebCoreViewFactory.h:
        * platform/LocalizedStrings.h:
        * platform/mac/LocalizedStringsMac.mm:
        (WebCore::searchMenuNoRecentSearchesText):
        (WebCore::searchMenuRecentSearchesText):
        (WebCore::searchMenuClearRecentSearchesText):
        (WebCore::AXWebAreaText):
        (WebCore::AXLinkText):
        (WebCore::AXListMarkerText):
        (WebCore::AXImageMapText):
        (WebCore::AXHeadingText):
        * rendering/RenderTextControl.cpp: (WebCore::RenderTextControl::itemText):

WebKit:

        Reviewed by Beth.

        Fix for <rdar://problem/4887423> REGRESSION: search results popup menu strings are not localized
        and <rdar://problem/3517227> accessibility-related strings in WebCore are not localized

        * WebCoreSupport/WebViewFactory.mm:
        (-[WebViewFactory searchMenuNoRecentSearchesText]):
        (-[WebViewFactory searchMenuRecentSearchesText]):
        (-[WebViewFactory searchMenuClearRecentSearchesText]):
        (-[WebViewFactory AXWebAreaText]):
        (-[WebViewFactory AXLinkText]):
        (-[WebViewFactory AXListMarkerText]):
        (-[WebViewFactory AXImageMapText]):
        (-[WebViewFactory AXHeadingText]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Bradeee Eidson.
ggaren [Wed, 28 Feb 2007 19:56:47 +0000 (19:56 +0000)]
    Reviewed by Bradeee Eidson.

        Disabling this test for now because it fails on the buildbot but not on
        my Intel or PPC machines. I've filed http://bugs.webkit.org/show_bug.cgi?id=12930
        to track this issue.

        * fast/leaks/003.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
antti [Wed, 28 Feb 2007 15:46:40 +0000 (15:46 +0000)]
LayoutTests:

        Reviewed by Maciej.

        - test for http://bugs.webkit.org/show_bug.cgi?id=12911
        GoogleDocs: Ordered lists don't update immediately when start attribute changed

        * fast/lists/ol-start-dynamic-expected.checksum: Added.
        * fast/lists/ol-start-dynamic-expected.png: Added.
        * fast/lists/ol-start-dynamic-expected.txt: Added.
        * fast/lists/ol-start-dynamic.html: Added.

WebCore:

        Reviewed by Maciej.

        - fix http://bugs.webkit.org/show_bug.cgi?id=12911
        GoogleDocs: Ordered lists don't update immediately when start attribute changed

        Update list marker value when start attribute changes.

        * html/HTMLOListElement.cpp:
        (WebCore::HTMLOListElement::parseMappedAttribute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoReviewed by Maciej.
zimmermann [Wed, 28 Feb 2007 12:29:22 +0000 (12:29 +0000)]
Reviewed by Maciej.

Corrected the use of the new ENABLE() macros in some ksvg2/svg files.
Add new build-webkit flags "--(no-)xpath" / "--(no-)xslt", to be able
to switch off build features easily. Also add "--(no-)svg-experimental-features"
flag, to be able to test filters/animations/use/foreignObject easily.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-02-28 Mark Rowe <mrowe@apple.com>
bdash [Wed, 28 Feb 2007 09:00:23 +0000 (09:00 +0000)]
2007-02-28  Mark Rowe  <mrowe@apple.com>

        Reviewed by Maciej.

        <rdar://problem/5028473> WebKit allocates a huge number of NSCalendarDates while loading history file

        * History/WebHistory.mm:
        (-[WebHistoryPrivate insertItem:atDateIndex:]): Use lastVisitedTimeInterval rather than _lastVisitedDate to avoid allocating NSCalendarDates.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej.
rwlbuis [Wed, 28 Feb 2007 08:29:50 +0000 (08:29 +0000)]
    Reviewed by Maciej.

        http://bugs.webkit.org/show_bug.cgi?id=12609
        Any SVG element will create renderers even when children of HTML elements

        Allow creation of svg renderers only when parent is SVG, except for
        the <svg> element.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej.
rwlbuis [Wed, 28 Feb 2007 07:55:31 +0000 (07:55 +0000)]
    Reviewed by Maciej.

        http://bugs.webkit.org/show_bug.cgi?id=12913
        Markers do not render in webkit when it misses markerWidth or markerHeight attribute

        Set defaults for markerWidth/markerHeight so markers that do not specify them render.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Extending the timeout on this test to see if it fixes the buildbot failure.
ggaren [Wed, 28 Feb 2007 05:33:12 +0000 (05:33 +0000)]
    Extending the timeout on this test to see if it fixes the buildbot failure.
        (I don't get a failure locally.)

        * fast/leaks/003.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago * loader/ResourceLoader.cpp:
andersca [Wed, 28 Feb 2007 01:16:59 +0000 (01:16 +0000)]
    * loader/ResourceLoader.cpp:
        (WebCore::ResourceLoader::~ResourceLoader):
        Remove comment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
justing [Wed, 28 Feb 2007 01:08:25 +0000 (01:08 +0000)]
LayoutTests:

        Reviewed by oliver

        <rdar://problem/5027300>
        REGRESSION: Images inserted with align left/right are lost

        * editing/inserting/12882-expected.checksum: Added.
        * editing/inserting/12882-expected.png: Added.
        * editing/inserting/12882-expected.txt: Added.
        * editing/inserting/12882.html: Added.

WebCore:

        Reviewed by oliver

        <rdar://problem/5027300>
        REGRESSION: Images inserted with align left/right are lost

        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::shouldMerge):
        Don't attempt to merge to or from a position before
        or after a block because it will be a no-op and
        lead to infinite recursion.
        In this case it instead resulted in content loss because
        of bugs in start/endOfParagraph (5027702).
        * editing/visible_units.cpp: Added two FIXMEs for
        the problems with start/endOfParagraph.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Geoff.
andersca [Wed, 28 Feb 2007 00:38:00 +0000 (00:38 +0000)]
    Reviewed by Geoff.

        Make resource load delegate methods pass the right document loader.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::willSendRequest):
        (WebCore::FrameLoader::didReceiveResponse):
        (WebCore::FrameLoader::didReceiveData):
        (WebCore::FrameLoader::didFailToLoad):
        (WebCore::FrameLoader::didFinishLoad):
        (WebCore::FrameLoader::didReceiveAuthenticationChallenge):
        (WebCore::FrameLoader::didCancelAuthenticationChallenge):
        Use the resource loader's document loader instead of the active one.

        * loader/MainResourceLoader.cpp:
        (WebCore::MainResourceLoader::receivedError):
        Make it so we send the frame load delegate method before the resource load delegate method.
        This was a regression from 2.0 and was caused by the fix to rdar://problem/4609195. Because the way the loader
        now works, both delegate methods will be called.

        * loader/ResourceLoader.cpp:
        (WebCore::ResourceLoader::ResourceLoader):
        * loader/ResourceLoader.h:
        (WebCore::ResourceLoader::documentLoader):
        Add document loader pointer to ResourceLoader.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin Adler.
ggaren [Wed, 28 Feb 2007 00:26:22 +0000 (00:26 +0000)]
    Reviewed by Darin Adler.

        Follow-up to fixing http://bugs.webkit.org/show_bug.cgi?id=12659 | <rdar://problem/4954306>
        JS objects not collected after closing window @ ebay.com/maps.google.com

        Changed Interpreter cache of global constructors and prototypes from
        ProtectedPtrs to bare, marked pointers. ProtectedPtrs are inefficient,
        and they increase the risk of reference cycles. Also, Darin said something
        about ProtectedPtrs giving him warts.

        Also changed data members to precise types from generic JSObject*'s.

        Layout tests and JS tests pass.

        * kjs/SavedBuiltins.h:
        * kjs/interpreter.cpp:
        (KJS::Interpreter::init):
        (KJS::Interpreter::~Interpreter):
        (KJS::Interpreter::initGlobalObject): Moved Identifier::init() call to
        constructor, for clarity.
        (KJS::Interpreter::mark):
        * kjs/interpreter.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoOops! Forgot to check in this file.
ggaren [Wed, 28 Feb 2007 00:21:56 +0000 (00:21 +0000)]
Oops! Forgot to check in this file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
weinig [Wed, 28 Feb 2007 00:04:39 +0000 (00:04 +0000)]
LayoutTests:

        Reviewed by Hyatt.

        - repaint test for http://bugs.webkit.org/show_bug.cgi?id=12910
          REGRESSION (r18756-r18765): list-bullet doesn't redraw properly when changing the list's content using JavaScript

        * fast/repaint/list-marker-expected.checksum: Added.
        * fast/repaint/list-marker-expected.png: Added.
        * fast/repaint/list-marker-expected.txt: Added.
        * fast/repaint/list-marker.html: Added.

WebCore:

        Reviewed by Hyatt.

        - fix http://bugs.webkit.org/show_bug.cgi?id=12910
          REGRESSION (r18756-r18765): list-bullet doesn't redraw properly when changing the list's content using JavaScript

        Test: fast/repaint/list-marker.html

        * rendering/RenderListItem.cpp:
        (WebCore::RenderListItem::positionListMarker): Add the marker to the visual
        overflow of all its ancestor blocks up to the list item. This needs to be
        done here since the marker is positioned only after those blocks have been
        laid out.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-02-28 Mark Rowe <mrowe@apple.com>
bdash [Tue, 27 Feb 2007 23:38:51 +0000 (23:38 +0000)]
2007-02-28  Mark Rowe  <mrowe@apple.com>

        Reviewed by Tim Hatcher.

        <rdar://problem/4985524> Problem with Blot and ToT WebKit (decoding WebCoreScrollView)

        References to WebCoreScrollView as a subview of a WebHTMLView may be present in some NIB
        files, so NSUnarchiver must be still able to look up the WebCoreScrollView class.

        * WebKit.exp: Export WebCoreScrollView symbol.
        * WebView/WebHTMLView.mm: Add empty WebCoreScrollView class.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
antti [Tue, 27 Feb 2007 23:13:26 +0000 (23:13 +0000)]
LayoutTests:

        Reviewed by Hyatt.

        - test for http://bugs.webkit.org/show_bug.cgi?id=12918
        REGRESSION: Google Finance dropdown Flickers
        <rdar://4988039>

        * fast/events/mouseout-dead-node-expected.checksum: Added.
        * fast/events/mouseout-dead-node-expected.png: Added.
        * fast/events/mouseout-dead-node-expected.txt: Added.
        * fast/events/mouseout-dead-node.html: Added.

WebCore:

        Reviewed by Hyatt.

        - fix http://bugs.webkit.org/show_bug.cgi?id=12918
        REGRESSION: Google Finance dropdown Flickers
        <rdar://4988039>

        If a node dies while mouse is over it, it is still supposed to receive
        mouseout event (wasn't case in Tiger webkit). However this event should
        not propagate to any other nodes. This patch matches Firefox behavior in
        this respect.

        * dom/EventTargetNode.cpp:
        (WebCore::EventTargetNode::dispatchGenericEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Bumped up the wiggle room on this test because it's failing on the buildbot.
ggaren [Tue, 27 Feb 2007 23:10:52 +0000 (23:10 +0000)]
    Bumped up the wiggle room on this test because it's failing on the buildbot.
        (We're still well below the ~100 objects you would see in a real failure.)

        * fast/leaks/003.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoOops! Forgot to commit this file
ggaren [Tue, 27 Feb 2007 23:09:25 +0000 (23:09 +0000)]
Oops! Forgot to commit this file

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoJavaScriptCore:
ggaren [Tue, 27 Feb 2007 22:28:24 +0000 (22:28 +0000)]
JavaScriptCore:

        Reviewed by Maciej Stachowiak.

        Fixed http://bugs.webkit.org/show_bug.cgi?id=12659 | <rdar://problem/4954306>
        JS objects not collected after closing window @ ebay.com/maps.google.com

        Don't GC in the Interpreter destructor. For that to work, the Interpreter
        would have to NULL out all of its ProtectedPtrs before calling collect(). But
        we've decided that we don't want things to work that way, anyway. We want the
        client to be in charge of manual GC so that it can optimize cases when
        it will be destroying many interpreters at once
        (e.g., http://bugs.webkit.org/show_bug.cgi?id=12900).

        Also removed Interpreter::collect() because it was redundant with
        Collector::collect().

        * JavaScriptCore.exp:
        * kjs/interpreter.cpp:
        (KJS::Interpreter::~Interpreter):
        * kjs/testkjs.cpp:
        (TestFunctionImp::callAsFunction):

LayoutTests:

        Reviewed by Maciej Stachowiak.

        Test for http://bugs.webkit.org/show_bug.cgi?id=12659 | <rdar://problem/4954306>
        JS objects not collected after closing window @ ebay.com/maps.google.com

        * fast/leaks/003-expected.txt: Added.
        * fast/leaks/003.html: Added.

        * fast/dom/gc-10.html: Bumped the wiggle room threshold on this test by 2
        because it's failing on my machine with the patch applied but, according
        to the test notes, we're still well within the margin of error.

WebCore:

        Reviewed by Maciej Stachowiak.

        Fixed http://bugs.webkit.org/show_bug.cgi?id=12659 | <rdar://problem/4954306>
        JS objects not collected after closing window @ ebay.com/maps.google.com

        Garbage collect in the KJSProxy destructor, after clearing our reference
        to the interpreter, because that's when the interpreter has torn down fully.

        (Technically speaking, we can't *prove* that we have the only reference to
        our interpreter, but that's how it works in practice, and manual garbage
        collection is just an opportunistic optimization, so it's OK for it to
        work in practice even if it can't be proven in theory.)

        Layout tests pass. No leaks reported.

        * bindings/js/kjs_proxy.cpp:
        (WebCore::KJSProxy::~KJSProxy):
        * bindings/js/kjs_proxy.h:
        * page/Page.cpp:
        (WebCore::Page::~Page): Merged pageDestroyed() calls. Moved debug-only
        code to the bottom.
        * page/Frame.cpp:
        (WebCore::Frame::~Frame): Don't call getObject() because globalObject()
        returns a JSObject* already, and the call can leave a pointer to the Window
        object on the stack. Don't check for NULL because it is an invariant of
        JavaScriptCore that no JSObject* can be NULL. Do use a volatile pointer
        for w because the 'w = 0' assignment just screams to the compiler, "Don't
        generate any code for me!"

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Beth.
aroben [Tue, 27 Feb 2007 20:50:54 +0000 (20:50 +0000)]
    Reviewed by Beth.

        Fix <rdar://problem/5011905> REGRESSION: "Open Link" contextual menu
        item appears twice

        * WebCoreSupport/WebContextMenuClient.mm:
        (fixMenusToSendToOldClients): Remove the "Open Link" item from the
        default menu items array before sending it off to Tiger Mail.
        (WebContextMenuClient::getCustomMenuFromDefaultItems): Set the
        representedObject on every NSMenuItem to match our old (correct) API
        behavior.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by David Hyatt.
rwlbuis [Tue, 27 Feb 2007 20:31:10 +0000 (20:31 +0000)]
    Reviewed by David Hyatt.

        http://bugs.webkit.org/show_bug.cgi?id=4128
        !important is ignored in inline styling.

        Handle properties with !important flag better in inline
        style declarations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Bug 11435. Make sure RenderViews always paintBoxDecorations. They used...
hyatt [Tue, 27 Feb 2007 20:13:50 +0000 (20:13 +0000)]
    Bug 11435.  Make sure RenderViews always paintBoxDecorations.  They used to before I removed RenderView's
        paint method.  This fix restores the original behavior.

        Reviewed by mitz

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::setStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix for bug 12094, make sure setMinMaxKnown starts off false for the weird...
hyatt [Tue, 27 Feb 2007 19:51:12 +0000 (19:51 +0000)]
    Fix for bug 12094, make sure setMinMaxKnown starts off false for the weird/rare case of empty
        plaintext documents (which really are buggy and should be fixed to generate root elements).

        Reviewed by mitz

        * rendering/RenderView.cpp:
        (WebCore::RenderView::RenderView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-02-27 Dex Deacon <occupant4@gmail.com>
ap [Tue, 27 Feb 2007 18:45:44 +0000 (18:45 +0000)]
2007-02-27  Dex Deacon  <occupant4@gmail.com>

        Reviewed by Darin.

        Fixed the case where a BackForwardList of capacity==1 would grow without bound.

        * history/BackForwardList.cpp:
        (WebCore::BackForwardList::addItem):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-02-22 Lars Naesbye Christensen <lars@naesbye.dk>
ap [Tue, 27 Feb 2007 18:10:03 +0000 (18:10 +0000)]
2007-02-22  Lars Naesbye Christensen  <lars@naesbye.dk>

        Reviewed by Maciej.

        http://bugs.webkit.org/show_bug.cgi?id=12848
        Help cursor should have a white outline

        * Resources/helpCursor.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-02-27 Mitz Pettel <mitz@webkit.org>
ap [Tue, 27 Feb 2007 18:00:44 +0000 (18:00 +0000)]
2007-02-27  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Darin.

        - http://bugs.webkit.org/show_bug.cgi?id=12906
          REGRESSION: Canvas is pixelated when the page is opened in a background tab

        * WebCoreSupport/WebChromeClient.mm:
        (WebChromeClient::scaleFactor): If the view is not in a window, use the main
        screen's scale factor as a best guess.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej.
ap [Tue, 27 Feb 2007 17:48:35 +0000 (17:48 +0000)]
    Reviewed by Maciej.

        http://bugs.webkit.org/show_bug.cgi?id=12594
        REGRESSION: Strange highlight in active input area

        No automated test possible.

        * rendering/InlineTextBox.cpp:
        (WebCore::InlineTextBox::paint): Restore a check lost in r12792.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Small tweak to run-webkit-tests.
ggaren [Tue, 27 Feb 2007 16:18:54 +0000 (16:18 +0000)]
    Small tweak to run-webkit-tests.

        * Scripts/run-webkit-tests: Allow people with lots of RAM to run more than
        1000 MallocStackLogging tests at a time.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Mitz.
darin [Tue, 27 Feb 2007 14:08:52 +0000 (14:08 +0000)]
    Reviewed by Mitz.

        - fix http://bugs.webkit.org/show_bug.cgi?id=12908
          crash in http/tests/incremental/frame-focus-before-load.html

        * page/mac/EventHandlerMac.mm: (WebCore::EventHandler::focusDocumentView):
        Add null checks.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Alexey.
darin [Tue, 27 Feb 2007 14:05:50 +0000 (14:05 +0000)]
    Reviewed by Alexey.

        - fix http://bugs.webkit.org/show_bug.cgi?id=12909
          should use ICU, not TEC, for MacRoman decoding

        * platform/TextCodecICU.cpp: (WebCore::TextCodecICU::registerEncodingNames):
        Add "macroman" as an alias for "macintosh". We have seen that in use in mail,
        although I'm not sure it's used on the web.

        * platform/mac/mac-encodings.txt: Remove MacRoman line, which was added back
        as part of the patch for bug 4971226. But by adding it to the this file rather
        than the ICU codec, we get it only on Mac OS X. And long term we are trying to
        get rid of the use of TEC entirely, so we want this file to be as empty as
        possible.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - test for MacRoman encoding name alias
darin [Tue, 27 Feb 2007 14:05:39 +0000 (14:05 +0000)]
    - test for MacRoman encoding name alias

        * fast/encoding/charset-names-expected.txt: Added.
        * fast/encoding/charset-names.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago * fast/css/computed-style-expected.txt: Updated test result for
darin [Tue, 27 Feb 2007 13:02:55 +0000 (13:02 +0000)]
    * fast/css/computed-style-expected.txt: Updated test result for
        Hyatt's addition of -webkit-border-fit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej.
rwlbuis [Tue, 27 Feb 2007 10:12:21 +0000 (10:12 +0000)]
    Reviewed by Maciej.

        http://bugs.webkit.org/show_bug.cgi?id=12905
        Not all svg shapes should support markers

        Restrict marker usage to svg shapes polyline, polygon, line and path.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
adele [Tue, 27 Feb 2007 08:44:40 +0000 (08:44 +0000)]
LayoutTests:

        Reviewed by Lars.

        Updated test for http://bugs.webkit.org/show_bug.cgi?id=12902
        <rdar://problem/5012679> REGRESSION: Pressing return key doesn't
        move caret to next line after applying a font color in GMail

        * fast/frames/iframe-window-focus-expected.txt:
        * fast/frames/iframe-window-focus.html: Updated test to include insertion of newlines.

WebCore:

        Reviewed by Lars.

        Fix for http://bugs.webkit.org/show_bug.cgi?id=12902
        <rdar://problem/5012679> REGRESSION: Pressing return key doesn't
        move caret to next line after applying a font color in GMail

        Test: fast/frames/iframe-window-focus-2.html

        * page/EventHandler.h: Make focusDocumentView public.
        * page/Frame.cpp: (WebCore::Frame::focusWindow): Instead of just setting the focused frame,
          we should set also focus the document view.  The bug here was that since the subframe view
          wasn't the first responder, the key down event was going to the wrong frame.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
mjs [Tue, 27 Feb 2007 07:19:11 +0000 (07:19 +0000)]
LayoutTests:

        Reviewed by Oliver.

        - test cases for <rdar://problem/4946881> Recursive loop with <marker> not caught, crashes in WebCore::SVGPaintServer::draw (11244)
        http://bugs.webkit.org/show_bug.cgi?id=11244

        * svg/custom/circular-marker-reference-1-expected.checksum: Added.
        * svg/custom/circular-marker-reference-1-expected.png: Added.
        * svg/custom/circular-marker-reference-1-expected.txt: Added.
        * svg/custom/circular-marker-reference-1.svg: Added.
        * svg/custom/circular-marker-reference-2-expected.checksum: Added.
        * svg/custom/circular-marker-reference-2-expected.png: Added.
        * svg/custom/circular-marker-reference-2-expected.txt: Added.
        * svg/custom/circular-marker-reference-2.svg: Added.
        * svg/custom/circular-marker-reference-3-expected.checksum: Added.
        * svg/custom/circular-marker-reference-3-expected.png: Added.
        * svg/custom/circular-marker-reference-3-expected.txt: Added.
        * svg/custom/circular-marker-reference-3.svg: Added.
        * svg/custom/circular-marker-reference-4-expected.checksum: Added.
        * svg/custom/circular-marker-reference-4-expected.png: Added.
        * svg/custom/circular-marker-reference-4-expected.txt: Added.
        * svg/custom/circular-marker-reference-4.svg: Added.
        * svg/custom/non-circular-marker-reference-expected.checksum: Added.
        * svg/custom/non-circular-marker-reference-expected.png: Added.
        * svg/custom/non-circular-marker-reference-expected.txt: Added.
        * svg/custom/non-circular-marker-reference.svg: Added.

WebCore:

        Reviewed by Oliver.

        - fixed <rdar://problem/4946881> Recursive loop with <marker> not caught, crashes in WebCore::SVGPaintServer::draw (11244)
        http://bugs.webkit.org/show_bug.cgi?id=11244

        * platform/graphics/svg/SVGResourceMarker.cpp:
        (WebCore::SVGResourceMarker::draw): Use a HashSet to guard against
        reference cycles.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
mjs [Tue, 27 Feb 2007 05:30:48 +0000 (05:30 +0000)]
WebCore:

        Reviewed by Kevin McCullough.

        - fix Qt build for earlier SVG changes.

        * platform/graphics/svg/qt/SVGResourceFilterQt.cpp:

WebKitQt:

        Reviewed by Kevin McCullough.

        - fix Qt build for earlier SVG changes.

        * WebCoreSupport/EditCommandQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-02-26 Oliver Hunt <oliver@apple.com>
oliver [Tue, 27 Feb 2007 05:23:22 +0000 (05:23 +0000)]
2007-02-26  Oliver Hunt  <oliver@apple.com>

        Reviewed by Maciej.

        Fix for <rdar://problem/4827378>: Canvas with large height
        uses lots of memory, computer almost stops responding

        Put cap on maximum area of canvas, size is similar too the
        maximum size allowed by firefox (firefox seems to to cut off
        at area == 32767 * 9358).

        Also protect renderer against the possibility of a null context
        (this was triggering a CG warning)

        * html/HTMLCanvasElement.cpp:
        (WebCore::HTMLCanvasElement::createDrawingContext):
           Apply maximum canvas area
        (WebCore::HTMLCanvasElement::createPlatformImage):
           Protect against null CG Context

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-02-26 Mitz Pettel <mitz@webkit.org>
bdash [Tue, 27 Feb 2007 05:13:49 +0000 (05:13 +0000)]
2007-02-26  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Antti Koivisto.

        - fix http://bugs.webkit.org/show_bug.cgi?id=12899
          Ordered lists not updating dynamically with new styles
  <rdar://problem/4889356>

        Test: fast/lists/list-style-type-dynamic-change.html

        * rendering/RenderListMarker.cpp:
        (WebCore::RenderListMarker::setStyle): Made changing the marker type trigger
        updating of the marker.

2007-02-26  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Antti Koivisto.

        - test for http://bugs.webkit.org/show_bug.cgi?id=12899
          Ordered lists not updating dynamically with new styles

        * fast/lists/list-style-type-dynamic-change-expected.checksum: Added.
        * fast/lists/list-style-type-dynamic-change-expected.png: Added.
        * fast/lists/list-style-type-dynamic-change-expected.txt: Added.
        * fast/lists/list-style-type-dynamic-change.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Lars.
mjs [Tue, 27 Feb 2007 04:04:24 +0000 (04:04 +0000)]
    Reviewed by Lars.

        - set ENABLE_XSLT even when compiling without SVG support, since that is no
        longer hardcoded into config.h.

        * Scripts/build-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago JavaScriptCore:
kjk [Tue, 27 Feb 2007 01:56:16 +0000 (01:56 +0000)]
  JavaScriptCore:

        Reviewed by Adam Roben.

        Rename *_SUPPORT defines to ENABLE_*.

        * jscore.bkl:

  WebKitTools:

        Reviewed by Adam Roben.

        Rename *_SUPPORT defines to ENABLE_*.

        * GdkLauncher/gdklauncher.bkl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
adele [Tue, 27 Feb 2007 01:36:17 +0000 (01:36 +0000)]
LayoutTests:

        Reviewed by Maciej.

        Test for <rdar://problem/5012761> REGRESSION: form submit invokes wrong event handler

        * fast/events/submit-reset-nested-bubble-expected.txt: Added.
        * fast/events/submit-reset-nested-bubble.html: Added.

WebCore:

        Reviewed by Maciej.

        Fix for <rdar://problem/5012761> REGRESSION: form submit invokes wrong event handler

        Test: fast/events/submit-reset-nested-bubble.html

        * dom/EventTargetNode.h: Made handleLocalEvents virtual.
        * html/HTMLFormElement.cpp: (WebCore::HTMLFormElement::handleLocalEvents): If we're
          not in the capture phase, and the target is a different form, and we're handling
          the submitEvent or the resetEvent, then stop propagation of the event.  This matches
          Firefox behavior.  You can only get in this situation if misnested tags cause
          forms to be nested.
        * html/HTMLFormElement.h: Added handleLocalEvents.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Oliver Hunt.
darin [Tue, 27 Feb 2007 01:32:54 +0000 (01:32 +0000)]
    Reviewed by Oliver Hunt.

        - <rdar://problem/5021555> TextCodecICU does not use fallback mappings; it should

        * platform/TextCodecICU.cpp: (WebCore::TextCodecICU::createICUConverter):
        Added a call to ucnv_setFallback(TRUE).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-02-26 Oliver Hunt <oliver@apple.com>
oliver [Tue, 27 Feb 2007 01:16:05 +0000 (01:16 +0000)]
2007-02-26  Oliver Hunt  <oliver@apple.com>

        Reviewed by Adam.

        Fix for rdar://problem/5021127

        Need to add null check to node -- original Obj-C didn't need
        the null check due to the Obj-C null messaging semantics

        * editing/Editor.cpp:
        (WebCore::Editor::shouldInsertFragment):

Layout tests:
        Layout test for rdar://problem/5021127

        * fast/events/standalone-image-drag-to-editable-expected.checksum: Added.
        * fast/events/standalone-image-drag-to-editable-expected.png: Added.
        * fast/events/standalone-image-drag-to-editable-expected.txt: Added.
        * fast/events/standalone-image-drag-to-editable.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin and Geoff
sullivan [Tue, 27 Feb 2007 00:33:57 +0000 (00:33 +0000)]
    Reviewed by Darin and Geoff

        * WebView/WebHTMLView.mm:
        (coreGraphicsScreenPointForAppKitScreenPoint):
        This method was copied from WebBrowser, and it was wrong. Fixed it. This only
        affects the Dictionary pop-up panel.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Make text files render using white-space: pre-wrap instead of white-space...
hyatt [Tue, 27 Feb 2007 00:09:20 +0000 (00:09 +0000)]
    Make text files render using white-space: pre-wrap instead of white-space: pre.

        Reviewed by aroben

        * loader/TextDocument.cpp:
        (WebCore::TextTokenizer::write):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoUpdate expected results for overflow test.
hyatt [Mon, 26 Feb 2007 23:24:36 +0000 (23:24 +0000)]
Update expected results for overflow test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Back out the change to add fullyClippedContentRect. The layout test
hyatt [Mon, 26 Feb 2007 23:22:37 +0000 (23:22 +0000)]
    Back out the change to add fullyClippedContentRect.  The layout test
        was actually showing more correct results.

        * page/Frame.cpp:
        (WebCore::Frame::visibleSelectionRect):
        (WebCore::Frame::setIsActive):
        (WebCore::Frame::markAllMatchesForText):
        * platform/ScrollView.h:
        * platform/mac/ScrollViewMac.mm:
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::scrollRectToVisible):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Update web inspector to account for border-fit.
hyatt [Mon, 26 Feb 2007 22:55:04 +0000 (22:55 +0000)]
    Update web inspector to account for border-fit.

        Reviewed by darin

        * WebInspector/webInspector/inspector.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin Adler.
ggaren [Mon, 26 Feb 2007 22:43:06 +0000 (22:43 +0000)]
    Reviewed by Darin Adler.

        Re-arranged things to put deprecated methods at the bottom.

        * Misc/WebCoreStatistics.h:
        * Misc/WebCoreStatistics.mm:
        (+[WebCoreStatistics javaScriptNoGCAllowedObjectsCount]):
        (+[WebCoreStatistics javaScriptReferencedObjectsCount]):
        (+[WebCoreStatistics javaScriptRootObjectClasses]):
        * WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Land layout test demonstrating border-fit.
hyatt [Mon, 26 Feb 2007 22:42:58 +0000 (22:42 +0000)]
    Land layout test demonstrating border-fit.

        Reviewed by darin

        * fast/borders/border-fit-expected.checksum: Added.
        * fast/borders/border-fit-expected.png: Added.
        * fast/borders/border-fit-expected.txt: Added.
        * fast/borders/border-fit.html: Added.
        * fast/borders/resources/Balloon_12641896.tiff: Added.
        * fast/borders/resources/Balloon_8107502.tiff: Added.
        * fast/borders/resources/largePerson.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Add support for a new property called -webkit-border-fit. This property
hyatt [Mon, 26 Feb 2007 22:36:14 +0000 (22:36 +0000)]
    Add support for a new property called -webkit-border-fit.  This property
        has two values: border and lines.  The "border" value means the border and
        background paint normally at the border box level.  The "lines" value indicates
        that the border and background should shrink dynamically to snugly hug the
        line boxes of normal flow descendants.

        Reviewed by darin

        fast/borders/border-fit.html

        * WebCore.xcodeproj/project.pbxproj:
        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::):
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
        * css/CSSPropertyNames.in:
        * css/CSSValueKeywords.in:
        * css/cssparser.cpp:
        (WebCore::CSSParser::parseValue):
        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::adjustForBorderFit):
        (WebCore::RenderBlock::borderFitAdjust):
        * rendering/RenderBlock.h:
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::paintBoxDecorations):
        * rendering/RenderBox.h:
        (WebCore::RenderBox::borderFitAdjust):
        * rendering/RenderStyle.cpp:
        (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
        (WebCore::StyleRareNonInheritedData::operator==):
        (WebCore::RenderStyle::diff):
        * rendering/RenderStyle.h:
        (WebCore::):
        (WebCore::RenderStyle::borderFit):
        (WebCore::RenderStyle::setBorderFit):
        (WebCore::RenderStyle::initialBorderFit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Rubber stamped by Mitz.
mjs [Mon, 26 Feb 2007 22:32:17 +0000 (22:32 +0000)]
    Rubber stamped by Mitz.

        - fix layout tests by fixing discrepancy in feature macros.

        * WebInspector/WebInspector.m:
        (-[WebInspector _highlightNode:]):
        * WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin.
aroben [Mon, 26 Feb 2007 22:30:18 +0000 (22:30 +0000)]
    Reviewed by Darin.

        Build fix.

        * rendering/RenderTreeAsText.cpp: Can't use #ifndef with ENABLE() macro.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
adele [Mon, 26 Feb 2007 21:49:48 +0000 (21:49 +0000)]
LayoutTests:

        Reviewed by Adam.

        Test for <rdar://problem/4990700> Safari always crashes when attempting to edit/view
        Yahoo pipes in WebCore::HTMLSelectElement::optionToListIndex

        * fast/forms/select-out-of-bounds-index-expected.txt: Added.
        * fast/forms/select-out-of-bounds-index.html: Added.

WebCore:

        Reviewed by Adam.

        Fix for <rdar://problem/4990700> Safari always crashes when attempting to edit/view
        Yahoo pipes in WebCore::HTMLSelectElement::optionToListIndex

        Test: fast/forms/select-out-of-bounds-index.html

        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::setSelectedIndex): If we're about to deselect all options, then set m_lastOnChangeIndex to -1.
        (WebCore::HTMLSelectElement::optionToListIndex): Moved listSize to a local variable.  Rewrote using a simpler for-loop to prevent out-of-bounds errors.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Geoff.
andersca [Mon, 26 Feb 2007 21:11:42 +0000 (21:11 +0000)]
    Reviewed by Geoff.

        <rdar://problem/4816376>
        REGRESSION: NetNewsWire 3.0 - Crashes in WebDocumentLoaderMac::attachToFrame() (12674)

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::reload):
        Remove call to setPolicyDocumentLoader here, it's set by the ::load function that we end up calling.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoJavaScriptCore:
mjs [Mon, 26 Feb 2007 19:29:04 +0000 (19:29 +0000)]
JavaScriptCore:

        Reviewed by Lars.

        - <rdar://problem/5021698> Disable experimental SVG features (12883)

        * wtf/Platform.h: Add ENABLE() macro similar to HAVE() and USE(), to
        allow nicer handling of optional WebKit features.

WebCore:

        Reviewed by Lars.

        - fixed <rdar://problem/5021698> Disable experimental SVG features (12883)

        I added an ENABLE_SVG_EXPERIMENTAL_FEATURES define to guard all use of the experimental
        features, and used it to guard relevant tag names, elements, JS bindings and renderers.

        I also converted all the existing optional feature defines to
        ENABLE_FOO instead of FOO_SUPPORT since that is the more standard
        way to do it in open source projects and works with the handy new
        ENABLE() macro.

        * CMakeLists.txt:
        * DerivedSources.make:
        * Projects/gdk/webcore-gdk.bkl:
        * WebCore.pro:
        * WebCore.vcproj/WebCore/WebCore.vcproj:
        * WebCore.vcproj/WebCore/build-generated-files.sh:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSCustomXPathNSResolver.cpp:
        * bindings/js/JSCustomXPathNSResolver.h:
        * bindings/js/JSSVGElementWrapperFactory.cpp:
        * bindings/js/JSSVGElementWrapperFactory.h:
        * bindings/js/JSSVGMatrixCustom.cpp:
        * bindings/js/JSSVGPODTypeWrapper.h:
        * bindings/js/JSSVGPathSegCustom.cpp:
        * bindings/js/JSSVGPathSegListCustom.cpp:
        * bindings/js/JSSVGPointListCustom.cpp:
        * bindings/js/JSXSLTProcessor.cpp:
        * bindings/js/JSXSLTProcessor.h:
        * bindings/js/kjs_binding.cpp:
        (KJS::setDOMException):
        * bindings/js/kjs_css.cpp:
        (KJS::toJS):
        * bindings/js/kjs_dom.cpp:
        (KJS::toJS):
        * bindings/js/kjs_html.cpp:
        (KJS::HTMLElementFunction::callAsFunction):
        * bindings/js/kjs_proxy.cpp:
        * bindings/js/kjs_proxy.h:
        * bindings/js/kjs_window.cpp:
        (KJS::Window::getValueProperty):
        * bindings/objc/DOM.mm:
        (WebCore::createElementClassMap):
        (+[DOMNode _nodeWith:WebCore::]):
        * bindings/objc/DOMCSS.mm:
        (+[DOMCSSValue _CSSValueWith:WebCore::]):
        * bindings/objc/DOMCustomXPathNSResolver.h:
        * bindings/objc/DOMCustomXPathNSResolver.mm:
        * bindings/objc/DOMEvents.mm:
        (+[DOMEvent _eventWith:WebCore::]):
        * bindings/objc/DOMInternal.h:
        * bindings/objc/DOMSVGPathSegInternal.mm:
        * bindings/objc/DOMXPath.mm:
        * bindings/objc/ExceptionHandlers.mm:
        (WebCore::raiseDOMException):
        * bindings/objc/PublicDOMInterfaces.h:
        * bindings/scripts/CodeGeneratorJS.pm:
        * bindings/scripts/CodeGeneratorObjC.pm:
        * config.h:
        * css/CSSGrammar.y:
        * css/CSSStyleDeclaration.cpp:
        (WebCore::propertyID):
        * css/StyleBase.h:
        * css/cssparser.cpp:
        (WebCore::CSSParser::parseValue):
        * css/cssparser.h:
        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::loadDefaultStyle):
        (WebCore::CSSStyleSelector::initForStyleResolve):
        (WebCore::checkPseudoState):
        (WebCore::CSSStyleSelector::adjustRenderStyle):
        (WebCore::CSSStyleSelector::applyProperty):
        * css/cssstyleselector.h:
        * dom/DOMImplementation.cpp:
        (WebCore::DOMImplementation::hasFeature):
        (WebCore::DOMImplementation::createDocument):
        * dom/Document.cpp:
        (WebCore::Document::Document):
        (WebCore::Document::~Document):
        (WebCore::Document::createElement):
        (WebCore::Document::implicitClose):
        (WebCore::Document::recalcStyleSelector):
        (WebCore::Document::createEvent):
        * dom/Document.h:
        * dom/Document.idl:
        * dom/Event.cpp:
        * dom/Event.h:
        * dom/EventTarget.cpp:
        * dom/EventTarget.h:
        * dom/MappedAttributeEntry.h:
        (WebCore::):
        * dom/Node.cpp:
        (WebCore::Node::createRendererIfNeeded):
        (WebCore::Node::shadowAncestorNode):
        * dom/Node.h:
        * dom/ProcessingInstruction.cpp:
        (WebCore::ProcessingInstruction::ProcessingInstruction):
        (WebCore::ProcessingInstruction::checkStyleSheet):
        (WebCore::ProcessingInstruction::setCSSStyleSheet):
        * dom/ProcessingInstruction.h:
        * dom/Text.cpp:
        (WebCore::Text::createRenderer):
        * dom/XMLTokenizer.cpp:
        (WebCore::XMLTokenizer::startElementNs):
        (WebCore::XMLTokenizer::endElementNs):
        (WebCore::XMLTokenizer::processingInstruction):
        (WebCore::XMLTokenizer::end):
        (WebCore::XMLTokenizer::insertErrorMessageBlock):
        * dom/XMLTokenizer.h:
        * html/HTMLEmbedElement.cpp:
        * html/HTMLEmbedElement.h:
        * html/HTMLObjectElement.cpp:
        * html/HTMLObjectElement.h:
        * ksvg2/css/SVGCSSParser.cpp:
        * ksvg2/css/SVGCSSStyleSelector.cpp:
        * ksvg2/css/SVGRenderStyle.cpp:
        * ksvg2/css/SVGRenderStyle.h:
        * ksvg2/css/SVGRenderStyleDefs.cpp:
        * ksvg2/css/SVGRenderStyleDefs.h:
        * ksvg2/events/JSSVGLazyEventListener.cpp:
        * ksvg2/events/JSSVGLazyEventListener.h:
        * ksvg2/events/SVGZoomEvent.cpp:
        * ksvg2/events/SVGZoomEvent.h:
        * ksvg2/misc/KCanvasRenderingStyle.cpp:
        * ksvg2/misc/KCanvasRenderingStyle.h:
        * ksvg2/misc/PointerEventsHitRules.cpp:
        * ksvg2/misc/PointerEventsHitRules.h:
        * ksvg2/misc/SVGDocumentExtensions.cpp:
        * ksvg2/misc/SVGDocumentExtensions.h:
        * ksvg2/misc/SVGImageLoader.cpp:
        * ksvg2/misc/SVGImageLoader.h:
        * ksvg2/misc/SVGTimer.cpp:
        * ksvg2/misc/SVGTimer.h:
        * ksvg2/misc/TimeScheduler.cpp:
        * ksvg2/misc/TimeScheduler.h:
        * ksvg2/scripts/make_names.pl:
        * ksvg2/svg/ColorDistance.cpp:
        * ksvg2/svg/ColorDistance.h:
        * ksvg2/svg/GradientAttributes.h:
        * ksvg2/svg/LinearGradientAttributes.h:
        * ksvg2/svg/PatternAttributes.h:
        * ksvg2/svg/RadialGradientAttributes.h:
        * ksvg2/svg/SVGAElement.cpp:
        * ksvg2/svg/SVGAElement.h:
        * ksvg2/svg/SVGAngle.cpp:
        * ksvg2/svg/SVGAngle.h:
        * ksvg2/svg/SVGAnimateColorElement.cpp:
        * ksvg2/svg/SVGAnimateColorElement.h:
        * ksvg2/svg/SVGAnimateElement.cpp:
        * ksvg2/svg/SVGAnimateElement.h:
        * ksvg2/svg/SVGAnimateElement.idl:
        * ksvg2/svg/SVGAnimateMotionElement.cpp:
        * ksvg2/svg/SVGAnimateMotionElement.h:
        * ksvg2/svg/SVGAnimateTransformElement.cpp:
        * ksvg2/svg/SVGAnimateTransformElement.h:
        * ksvg2/svg/SVGAnimateTransformElement.idl:
        * ksvg2/svg/SVGAnimatedPathData.cpp:
        * ksvg2/svg/SVGAnimatedPathData.h:
        * ksvg2/svg/SVGAnimatedPoints.cpp:
        * ksvg2/svg/SVGAnimatedPoints.h:
        * ksvg2/svg/SVGAnimatedTemplate.h:
        * ksvg2/svg/SVGAnimationElement.cpp:
        * ksvg2/svg/SVGAnimationElement.h:
        * ksvg2/svg/SVGCircleElement.cpp:
        * ksvg2/svg/SVGCircleElement.h:
        * ksvg2/svg/SVGClipPathElement.cpp:
        * ksvg2/svg/SVGClipPathElement.h:
        * ksvg2/svg/SVGColor.cpp:
        * ksvg2/svg/SVGColor.h:
        * ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
        * ksvg2/svg/SVGComponentTransferFunctionElement.h:
        * ksvg2/svg/SVGCursorElement.cpp:
        * ksvg2/svg/SVGCursorElement.h:
        * ksvg2/svg/SVGDefsElement.cpp:
        * ksvg2/svg/SVGDefsElement.h:
        * ksvg2/svg/SVGDescElement.cpp:
        * ksvg2/svg/SVGDescElement.h:
        * ksvg2/svg/SVGDocument.cpp:
        * ksvg2/svg/SVGDocument.h:
        * ksvg2/svg/SVGElement.cpp:
        (WebCore::SVGElement::dispatchEvent):
        * ksvg2/svg/SVGElement.h:
        * ksvg2/svg/SVGElementInstance.cpp:
        * ksvg2/svg/SVGElementInstance.h:
        * ksvg2/svg/SVGElementInstance.idl:
        * ksvg2/svg/SVGElementInstanceList.cpp:
        * ksvg2/svg/SVGElementInstanceList.h:
        * ksvg2/svg/SVGElementInstanceList.idl:
        * ksvg2/svg/SVGEllipseElement.cpp:
        * ksvg2/svg/SVGEllipseElement.h:
        * ksvg2/svg/SVGException.h:
        * ksvg2/svg/SVGExternalResourcesRequired.cpp:
        * ksvg2/svg/SVGExternalResourcesRequired.h:
        * ksvg2/svg/SVGFEBlendElement.cpp:
        * ksvg2/svg/SVGFEBlendElement.h:
        * ksvg2/svg/SVGFEBlendElement.idl:
        * ksvg2/svg/SVGFEColorMatrixElement.cpp:
        * ksvg2/svg/SVGFEColorMatrixElement.h:
        * ksvg2/svg/SVGFEColorMatrixElement.idl:
        * ksvg2/svg/SVGFEComponentTransferElement.cpp:
        * ksvg2/svg/SVGFEComponentTransferElement.h:
        * ksvg2/svg/SVGFEComponentTransferElement.idl:
        * ksvg2/svg/SVGFECompositeElement.cpp:
        * ksvg2/svg/SVGFECompositeElement.h:
        * ksvg2/svg/SVGFECompositeElement.idl:
        * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
        * ksvg2/svg/SVGFEDiffuseLightingElement.h:
        * ksvg2/svg/SVGFEDiffuseLightingElement.idl:
        * ksvg2/svg/SVGFEDisplacementMapElement.cpp:
        * ksvg2/svg/SVGFEDisplacementMapElement.h:
        * ksvg2/svg/SVGFEDisplacementMapElement.idl:
        * ksvg2/svg/SVGFEDistantLightElement.cpp:
        * ksvg2/svg/SVGFEDistantLightElement.h:
        * ksvg2/svg/SVGFEDistantLightElement.idl:
        * ksvg2/svg/SVGFEFloodElement.cpp:
        * ksvg2/svg/SVGFEFloodElement.h:
        * ksvg2/svg/SVGFEFloodElement.idl:
        * ksvg2/svg/SVGFEFuncAElement.cpp:
        * ksvg2/svg/SVGFEFuncAElement.h:
        * ksvg2/svg/SVGFEFuncAElement.idl:
        * ksvg2/svg/SVGFEFuncBElement.cpp:
        * ksvg2/svg/SVGFEFuncBElement.h:
        * ksvg2/svg/SVGFEFuncBElement.idl:
        * ksvg2/svg/SVGFEFuncGElement.cpp:
        * ksvg2/svg/SVGFEFuncGElement.h:
        * ksvg2/svg/SVGFEFuncGElement.idl:
        * ksvg2/svg/SVGFEFuncRElement.cpp:
        * ksvg2/svg/SVGFEFuncRElement.h:
        * ksvg2/svg/SVGFEFuncRElement.idl:
        * ksvg2/svg/SVGFEGaussianBlurElement.cpp:
        * ksvg2/svg/SVGFEGaussianBlurElement.h:
        * ksvg2/svg/SVGFEGaussianBlurElement.idl:
        * ksvg2/svg/SVGFEImageElement.cpp:
        * ksvg2/svg/SVGFEImageElement.h:
        * ksvg2/svg/SVGFEImageElement.idl:
        * ksvg2/svg/SVGFELightElement.cpp:
        * ksvg2/svg/SVGFELightElement.h:
        * ksvg2/svg/SVGFEMergeElement.cpp:
        * ksvg2/svg/SVGFEMergeElement.h:
        * ksvg2/svg/SVGFEMergeElement.idl:
        * ksvg2/svg/SVGFEMergeNodeElement.cpp:
        * ksvg2/svg/SVGFEMergeNodeElement.h:
        * ksvg2/svg/SVGFEMergeNodeElement.idl:
        * ksvg2/svg/SVGFEOffsetElement.cpp:
        * ksvg2/svg/SVGFEOffsetElement.h:
        * ksvg2/svg/SVGFEOffsetElement.idl:
        * ksvg2/svg/SVGFEPointLightElement.cpp:
        * ksvg2/svg/SVGFEPointLightElement.h:
        * ksvg2/svg/SVGFEPointLightElement.idl:
        * ksvg2/svg/SVGFESpecularLightingElement.cpp:
        * ksvg2/svg/SVGFESpecularLightingElement.h:
        * ksvg2/svg/SVGFESpecularLightingElement.idl:
        * ksvg2/svg/SVGFESpotLightElement.cpp:
        * ksvg2/svg/SVGFESpotLightElement.h:
        * ksvg2/svg/SVGFESpotLightElement.idl:
        * ksvg2/svg/SVGFETileElement.cpp:
        * ksvg2/svg/SVGFETileElement.h:
        * ksvg2/svg/SVGFETileElement.idl:
        * ksvg2/svg/SVGFETurbulenceElement.cpp:
        * ksvg2/svg/SVGFETurbulenceElement.h:
        * ksvg2/svg/SVGFETurbulenceElement.idl:
        * ksvg2/svg/SVGFilterElement.cpp:
        * ksvg2/svg/SVGFilterElement.h:
        * ksvg2/svg/SVGFilterElement.idl:
        * ksvg2/svg/SVGFilterPrimitiveStandardAttributes.cpp:
        * ksvg2/svg/SVGFilterPrimitiveStandardAttributes.h:
        * ksvg2/svg/SVGFitToViewBox.cpp:
        * ksvg2/svg/SVGFitToViewBox.h:
        * ksvg2/svg/SVGForeignObjectElement.cpp:
        * ksvg2/svg/SVGForeignObjectElement.h:
        * ksvg2/svg/SVGForeignObjectElement.idl:
        * ksvg2/svg/SVGGElement.cpp:
        * ksvg2/svg/SVGGElement.h:
        * ksvg2/svg/SVGGradientElement.cpp:
        * ksvg2/svg/SVGGradientElement.h:
        * ksvg2/svg/SVGImageElement.cpp:
        * ksvg2/svg/SVGImageElement.h:
        * ksvg2/svg/SVGLangSpace.cpp:
        * ksvg2/svg/SVGLangSpace.h:
        * ksvg2/svg/SVGLength.cpp:
        * ksvg2/svg/SVGLength.h:
        * ksvg2/svg/SVGLengthList.cpp:
        * ksvg2/svg/SVGLengthList.h:
        * ksvg2/svg/SVGLineElement.cpp:
        * ksvg2/svg/SVGLineElement.h:
        * ksvg2/svg/SVGLinearGradientElement.cpp:
        * ksvg2/svg/SVGLinearGradientElement.h:
        * ksvg2/svg/SVGList.h:
        * ksvg2/svg/SVGListTraits.h:
        * ksvg2/svg/SVGLocatable.cpp:
        (WebCore::SVGLocatable::nearestViewportElement):
        (WebCore::SVGLocatable::farthestViewportElement):
        * ksvg2/svg/SVGLocatable.h:
        * ksvg2/svg/SVGMPathElement.cpp:
        * ksvg2/svg/SVGMPathElement.h:
        * ksvg2/svg/SVGMarkerElement.cpp:
        * ksvg2/svg/SVGMarkerElement.h:
        * ksvg2/svg/SVGMaskElement.cpp:
        * ksvg2/svg/SVGMaskElement.h:
        * ksvg2/svg/SVGMetadataElement.cpp:
        * ksvg2/svg/SVGMetadataElement.h:
        * ksvg2/svg/SVGNumberList.cpp:
        * ksvg2/svg/SVGNumberList.h:
        * ksvg2/svg/SVGPaint.cpp:
        * ksvg2/svg/SVGPaint.h:
        * ksvg2/svg/SVGParserUtilities.cpp:
        * ksvg2/svg/SVGParserUtilities.h:
        * ksvg2/svg/SVGPathElement.cpp:
        * ksvg2/svg/SVGPathElement.h:
        * ksvg2/svg/SVGPathSeg.h:
        * ksvg2/svg/SVGPathSegArc.cpp:
        * ksvg2/svg/SVGPathSegArc.h:
        * ksvg2/svg/SVGPathSegClosePath.cpp:
        * ksvg2/svg/SVGPathSegClosePath.h:
        * ksvg2/svg/SVGPathSegCurvetoCubic.cpp:
        * ksvg2/svg/SVGPathSegCurvetoCubic.h:
        * ksvg2/svg/SVGPathSegCurvetoCubicSmooth.cpp:
        * ksvg2/svg/SVGPathSegCurvetoCubicSmooth.h:
        * ksvg2/svg/SVGPathSegCurvetoQuadratic.cpp:
        * ksvg2/svg/SVGPathSegCurvetoQuadratic.h:
        * ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.cpp:
        * ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.h:
        * ksvg2/svg/SVGPathSegLineto.cpp:
        * ksvg2/svg/SVGPathSegLineto.h:
        * ksvg2/svg/SVGPathSegLinetoHorizontal.cpp:
        * ksvg2/svg/SVGPathSegLinetoHorizontal.h:
        * ksvg2/svg/SVGPathSegLinetoVertical.cpp:
        * ksvg2/svg/SVGPathSegLinetoVertical.h:
        * ksvg2/svg/SVGPathSegList.cpp:
        * ksvg2/svg/SVGPathSegList.h:
        * ksvg2/svg/SVGPathSegMoveto.cpp:
        * ksvg2/svg/SVGPathSegMoveto.h:
        * ksvg2/svg/SVGPatternElement.cpp:
        * ksvg2/svg/SVGPatternElement.h:
        * ksvg2/svg/SVGPointList.cpp:
        * ksvg2/svg/SVGPointList.h:
        * ksvg2/svg/SVGPolyElement.cpp:
        * ksvg2/svg/SVGPolyElement.h:
        * ksvg2/svg/SVGPolygonElement.cpp:
        * ksvg2/svg/SVGPolygonElement.h:
        * ksvg2/svg/SVGPolylineElement.cpp:
        * ksvg2/svg/SVGPolylineElement.h:
        * ksvg2/svg/SVGPreserveAspectRatio.cpp:
        * ksvg2/svg/SVGPreserveAspectRatio.h:
        * ksvg2/svg/SVGRadialGradientElement.cpp:
        * ksvg2/svg/SVGRadialGradientElement.h:
        * ksvg2/svg/SVGRectElement.cpp:
        * ksvg2/svg/SVGRectElement.h:
        * ksvg2/svg/SVGRenderingIntent.h:
        * ksvg2/svg/SVGSVGElement.cpp:
        * ksvg2/svg/SVGSVGElement.h:
        * ksvg2/svg/SVGScriptElement.cpp:
        * ksvg2/svg/SVGScriptElement.h:
        * ksvg2/svg/SVGSetElement.cpp:
        * ksvg2/svg/SVGSetElement.h:
        * ksvg2/svg/SVGStopElement.cpp:
        * ksvg2/svg/SVGStopElement.h:
        * ksvg2/svg/SVGStringList.cpp:
        * ksvg2/svg/SVGStringList.h:
        * ksvg2/svg/SVGStylable.cpp:
        * ksvg2/svg/SVGStylable.h:
        * ksvg2/svg/SVGStyleElement.cpp:
        * ksvg2/svg/SVGStyleElement.h:
        * ksvg2/svg/SVGStyledElement.cpp:
        (WebCore::SVGStyledElement::notifyAttributeChange):
        * ksvg2/svg/SVGStyledElement.h:
        * ksvg2/svg/SVGStyledLocatableElement.cpp:
        * ksvg2/svg/SVGStyledLocatableElement.h:
        * ksvg2/svg/SVGStyledTransformableElement.cpp:
        * ksvg2/svg/SVGStyledTransformableElement.h:
        * ksvg2/svg/SVGSwitchElement.cpp:
        * ksvg2/svg/SVGSwitchElement.h:
        * ksvg2/svg/SVGSymbolElement.cpp:
        * ksvg2/svg/SVGSymbolElement.h:
        * ksvg2/svg/SVGTRefElement.cpp:
        * ksvg2/svg/SVGTRefElement.h:
        * ksvg2/svg/SVGTSpanElement.cpp:
        * ksvg2/svg/SVGTSpanElement.h:
        * ksvg2/svg/SVGTests.cpp:
        * ksvg2/svg/SVGTests.h:
        * ksvg2/svg/SVGTextContentElement.cpp:
        * ksvg2/svg/SVGTextContentElement.h:
        * ksvg2/svg/SVGTextElement.cpp:
        * ksvg2/svg/SVGTextElement.h:
        * ksvg2/svg/SVGTextPositioningElement.cpp:
        * ksvg2/svg/SVGTextPositioningElement.h:
        * ksvg2/svg/SVGTitleElement.cpp:
        * ksvg2/svg/SVGTitleElement.h:
        * ksvg2/svg/SVGTransform.cpp:
        * ksvg2/svg/SVGTransform.h:
        * ksvg2/svg/SVGTransformDistance.cpp:
        * ksvg2/svg/SVGTransformDistance.h:
        * ksvg2/svg/SVGTransformList.cpp:
        * ksvg2/svg/SVGTransformList.h:
        * ksvg2/svg/SVGTransformable.cpp:
        * ksvg2/svg/SVGTransformable.h:
        * ksvg2/svg/SVGURIReference.cpp:
        * ksvg2/svg/SVGURIReference.h:
        * ksvg2/svg/SVGUnitTypes.h:
        * ksvg2/svg/SVGUseElement.cpp:
        * ksvg2/svg/SVGUseElement.h:
        * ksvg2/svg/SVGUseElement.idl:
        * ksvg2/svg/SVGViewElement.cpp:
        * ksvg2/svg/SVGViewElement.h:
        * ksvg2/svg/SVGZoomAndPan.cpp:
        * ksvg2/svg/SVGZoomAndPan.h:
        * ksvg2/svg/svgtags.in:
        * loader/Cache.cpp:
        (WebCore::createResource):
        (WebCore::Cache::getStatistics):
        * loader/Cache.h:
        * loader/CachedImage.cpp:
        (WebCore::CachedImage::createImage):
        * loader/CachedResource.h:
        (WebCore::CachedResource::):
        * loader/CachedResourceClient.h:
        * loader/CachedXBLDocument.cpp:
        * loader/CachedXBLDocument.h:
        * loader/CachedXSLStyleSheet.cpp:
        * loader/CachedXSLStyleSheet.h:
        * loader/DocLoader.cpp:
        * loader/DocLoader.h:
        * page/DOMWindow.idl:
        * page/EventHandler.cpp:
        (WebCore::EventHandler::handleMouseMoveEvent):
        (WebCore::selectCursor):
        * page/Frame.cpp:
        (WebCore::Frame::Frame):
        * page/PageState.cpp:
        (WebCore::PageState::PageState):
        (WebCore::PageState::restore):
        * platform/MimeTypeRegistry.cpp:
        (WebCore::initialiseSupportedNonImageMimeTypes):
        * platform/graphics/FloatPoint3D.cpp:
        * platform/graphics/FloatPoint3D.h:
        * platform/graphics/ImageBuffer.cpp:
        (WebCore::ImageBuffer::renderSubtreeToImage):
        * platform/graphics/svg/SVGImage.cpp:
        * platform/graphics/svg/SVGImage.h:
        * platform/graphics/svg/SVGImageEmptyClients.h:
        * platform/graphics/svg/SVGPaintServer.cpp:
        * platform/graphics/svg/SVGPaintServer.h:
        * platform/graphics/svg/SVGPaintServerGradient.cpp:
        * platform/graphics/svg/SVGPaintServerGradient.h:
        * platform/graphics/svg/SVGPaintServerLinearGradient.cpp:
        * platform/graphics/svg/SVGPaintServerLinearGradient.h:
        * platform/graphics/svg/SVGPaintServerPattern.cpp:
        * platform/graphics/svg/SVGPaintServerPattern.h:
        * platform/graphics/svg/SVGPaintServerRadialGradient.cpp:
        * platform/graphics/svg/SVGPaintServerRadialGradient.h:
        * platform/graphics/svg/SVGPaintServerSolid.cpp:
        * platform/graphics/svg/SVGPaintServerSolid.h:
        * platform/graphics/svg/SVGResource.cpp:
        * platform/graphics/svg/SVGResource.h:
        * platform/graphics/svg/SVGResourceClipper.cpp:
        * platform/graphics/svg/SVGResourceClipper.h:
        * platform/graphics/svg/SVGResourceFilter.cpp:
        * platform/graphics/svg/SVGResourceFilter.h:
        * platform/graphics/svg/SVGResourceMarker.cpp:
        * platform/graphics/svg/SVGResourceMarker.h:
        * platform/graphics/svg/SVGResourceMasker.cpp:
        * platform/graphics/svg/SVGResourceMasker.h:
        * platform/graphics/svg/cg/CgSupport.cpp:
        * platform/graphics/svg/cg/CgSupport.h:
        * platform/graphics/svg/cg/RenderPathCg.cpp:
        * platform/graphics/svg/cg/SVGPaintServerCg.cpp:
        * platform/graphics/svg/cg/SVGPaintServerGradientCg.cpp:
        * platform/graphics/svg/cg/SVGPaintServerPatternCg.cpp:
        * platform/graphics/svg/cg/SVGPaintServerSolidCg.cpp:
        * platform/graphics/svg/cg/SVGResourceClipperCg.cpp:
        * platform/graphics/svg/cg/SVGResourceFilterCg.mm:
        * platform/graphics/svg/cg/SVGResourceMaskerCg.mm:
        * platform/graphics/svg/filters/SVGDistantLightSource.h:
        * platform/graphics/svg/filters/SVGFEBlend.cpp:
        * platform/graphics/svg/filters/SVGFEBlend.h:
        * platform/graphics/svg/filters/SVGFEColorMatrix.cpp:
        * platform/graphics/svg/filters/SVGFEColorMatrix.h:
        * platform/graphics/svg/filters/SVGFEComponentTransfer.cpp:
        * platform/graphics/svg/filters/SVGFEComponentTransfer.h:
        * platform/graphics/svg/filters/SVGFEComposite.cpp:
        * platform/graphics/svg/filters/SVGFEComposite.h:
        * platform/graphics/svg/filters/SVGFEConvolveMatrix.cpp:
        * platform/graphics/svg/filters/SVGFEConvolveMatrix.h:
        * platform/graphics/svg/filters/SVGFEDiffuseLighting.cpp:
        * platform/graphics/svg/filters/SVGFEDiffuseLighting.h:
        * platform/graphics/svg/filters/SVGFEDisplacementMap.cpp:
        * platform/graphics/svg/filters/SVGFEDisplacementMap.h:
        * platform/graphics/svg/filters/SVGFEFlood.cpp:
        * platform/graphics/svg/filters/SVGFEFlood.h:
        * platform/graphics/svg/filters/SVGFEGaussianBlur.cpp:
        * platform/graphics/svg/filters/SVGFEGaussianBlur.h:
        * platform/graphics/svg/filters/SVGFEImage.cpp:
        * platform/graphics/svg/filters/SVGFEImage.h:
        * platform/graphics/svg/filters/SVGFEMerge.cpp:
        * platform/graphics/svg/filters/SVGFEMerge.h:
        * platform/graphics/svg/filters/SVGFEMorphology.cpp:
        * platform/graphics/svg/filters/SVGFEMorphology.h:
        * platform/graphics/svg/filters/SVGFEOffset.cpp:
        * platform/graphics/svg/filters/SVGFEOffset.h:
        * platform/graphics/svg/filters/SVGFESpecularLighting.cpp:
        * platform/graphics/svg/filters/SVGFESpecularLighting.h:
        * platform/graphics/svg/filters/SVGFETile.h:
        * platform/graphics/svg/filters/SVGFETurbulence.cpp:
        * platform/graphics/svg/filters/SVGFETurbulence.h:
        * platform/graphics/svg/filters/SVGFilterEffect.cpp:
        * platform/graphics/svg/filters/SVGFilterEffect.h:
        * platform/graphics/svg/filters/SVGLightSource.cpp:
        * platform/graphics/svg/filters/SVGLightSource.h:
        * platform/graphics/svg/filters/SVGPointLightSource.h:
        * platform/graphics/svg/filters/SVGSpotLightSource.h:
        * platform/graphics/svg/filters/cg/SVGFEBlendCg.mm:
        * platform/graphics/svg/filters/cg/SVGFEColorMatrixCg.mm:
        * platform/graphics/svg/filters/cg/SVGFEComponentTransferCg.mm:
        * platform/graphics/svg/filters/cg/SVGFECompositeCg.mm:
        * platform/graphics/svg/filters/cg/SVGFEDiffuseLightingCg.mm:
        * platform/graphics/svg/filters/cg/SVGFEDisplacementMapCg.mm:
        * platform/graphics/svg/filters/cg/SVGFEFloodCg.mm:
        * platform/graphics/svg/filters/cg/SVGFEGaussianBlurCg.mm:
        * platform/graphics/svg/filters/cg/SVGFEHelpersCg.h:
        * platform/graphics/svg/filters/cg/SVGFEHelpersCg.mm:
        * platform/graphics/svg/filters/cg/SVGFEImageCg.mm:
        * platform/graphics/svg/filters/cg/SVGFEMergeCg.mm:
        * platform/graphics/svg/filters/cg/SVGFEOffsetCg.mm:
        * platform/graphics/svg/filters/cg/SVGFESpecularLightingCg.mm:
        * platform/graphics/svg/filters/cg/SVGFETileCg.mm:
        * platform/graphics/svg/filters/cg/SVGFilterEffectCg.mm:
        * platform/graphics/svg/qt/SVGPaintServerGradientQt.cpp:
        * platform/graphics/svg/qt/SVGPaintServerLinearGradientQt.cpp:
        * platform/graphics/svg/qt/SVGPaintServerPatternQt.cpp:
        * platform/graphics/svg/qt/SVGPaintServerQt.cpp:
        * platform/graphics/svg/qt/SVGPaintServerRadialGradientQt.cpp:
        * platform/graphics/svg/qt/SVGPaintServerSolidQt.cpp:
        * platform/graphics/svg/qt/SVGResourceClipperQt.cpp:
        * platform/graphics/svg/qt/SVGResourceFilterQt.cpp:
        * platform/graphics/svg/qt/SVGResourceMaskerQt.cpp:
        * rendering/HitTestResult.cpp:
        (WebCore::HitTestResult::absoluteImageURL):
        (WebCore::HitTestResult::absoluteLinkURL):
        (WebCore::HitTestResult::isLiveLink):
        * rendering/RenderForeignObject.cpp:
        * rendering/RenderForeignObject.h:
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::isTransparent):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::containingBlock):
        * rendering/RenderObject.h:
        * rendering/RenderPath.cpp:
        * rendering/RenderPath.h:
        * rendering/RenderSVGBlock.cpp:
        * rendering/RenderSVGBlock.h:
        * rendering/RenderSVGContainer.cpp:
        * rendering/RenderSVGContainer.h:
        * rendering/RenderSVGGradientStop.cpp:
        * rendering/RenderSVGGradientStop.h:
        * rendering/RenderSVGHiddenContainer.cpp:
        * rendering/RenderSVGHiddenContainer.h:
        * rendering/RenderSVGImage.cpp:
        * rendering/RenderSVGImage.h:
        * rendering/RenderSVGInline.cpp:
        * rendering/RenderSVGInline.h:
        * rendering/RenderSVGInlineText.cpp:
        * rendering/RenderSVGInlineText.h:
        * rendering/RenderSVGTSpan.cpp:
        * rendering/RenderSVGTSpan.h:
        * rendering/RenderSVGText.cpp:
        * rendering/RenderSVGText.h:
        * rendering/RenderStyle.cpp:
        (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
        (WebCore::StyleRareNonInheritedData::~StyleRareNonInheritedData):
        (WebCore::StyleRareNonInheritedData::operator==):
        (WebCore::RenderStyle::RenderStyle):
        (WebCore::RenderStyle::inheritFrom):
        (WebCore::RenderStyle::operator==):
        (WebCore::RenderStyle::inheritedNotEqual):
        (WebCore::RenderStyle::diff):
        * rendering/RenderStyle.h:
        * rendering/RenderText.cpp:
        (WebCore::RenderText::setStyle):
        (WebCore::RenderText::setTextInternal):
        * rendering/RenderTreeAsText.cpp:
        (WebCore::write):
        (WebCore::externalRepresentation):
        * rendering/SVGInlineFlowBox.cpp:
        * rendering/SVGInlineFlowBox.h:
        * rendering/SVGRenderTreeAsText.cpp:
        * rendering/SVGRenderTreeAsText.h:
        * rendering/SVGRootInlineBox.cpp:
        * rendering/SVGRootInlineBox.h:
        * rendering/bidi.cpp:
        (WebCore::shouldPreserveNewline):
        (WebCore::RenderBlock::findNextLineBreak):
        * webcore-base.bkl:
        * xml/NativeXPathNSResolver.cpp:
        * xml/NativeXPathNSResolver.h:
        * xml/XPathEvaluator.cpp:
        * xml/XPathEvaluator.h:
        * xml/XPathExpression.cpp:
        * xml/XPathExpression.h:
        * xml/XPathExpressionNode.cpp:
        * xml/XPathExpressionNode.h:
        * xml/XPathFunctions.cpp:
        * xml/XPathFunctions.h:
        * xml/XPathGrammar.y:
        * xml/XPathNSResolver.cpp:
        * xml/XPathNSResolver.h:
        * xml/XPathNamespace.cpp:
        * xml/XPathNamespace.h:
        * xml/XPathParser.cpp:
        * xml/XPathParser.h:
        * xml/XPathPath.cpp:
        * xml/XPathPath.h:
        * xml/XPathPredicate.cpp:
        * xml/XPathPredicate.h:
        * xml/XPathResult.cpp:
        * xml/XPathResult.h:
        * xml/XPathStep.cpp:
        * xml/XPathStep.h:
        * xml/XPathUtil.cpp:
        * xml/XPathUtil.h:
        * xml/XPathValue.cpp:
        * xml/XPathValue.h:
        * xml/XPathVariableReference.cpp:
        * xml/XPathVariableReference.h:
        * xml/XSLImportRule.cpp:
        * xml/XSLImportRule.h:
        * xml/XSLStyleSheet.cpp:
        * xml/XSLStyleSheet.h:
        * xml/XSLTProcessor.cpp:
        * xml/XSLTProcessor.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-02-25 Mitz Pettel <mitz@webkit.org>
bdash [Mon, 26 Feb 2007 05:31:03 +0000 (05:31 +0000)]
2007-02-25  Mitz Pettel  <mitz@webkit.org>

        Reviewed by David Hyatt.

        - fix http://bugs.webkit.org/show_bug.cgi?id=12886
          Crash with Scriptalicious javascript library

        Test: fast/dynamic/float-withdrawal.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::layoutBlockChildren): Detect when a child block had
        intruding floats in a previous layout, and in that case force it to relayout.

2007-02-25  Mitz Pettel  <mitz@webkit.org>

        Reviewed by David Hyatt.

        - test for http://bugs.webkit.org/show_bug.cgi?id=12886
          Crash with Scriptalicious javascript library

        * fast/dynamic/float-withdrawal-expected.checksum: Added.
        * fast/dynamic/float-withdrawal-expected.png: Added.
        * fast/dynamic/float-withdrawal-expected.txt: Added.
        * fast/dynamic/float-withdrawal.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Revert my change to the default fill color. Just set the color to transparen...
hyatt [Mon, 26 Feb 2007 03:00:24 +0000 (03:00 +0000)]
    Revert my change to the default fill color.  Just set the color to transparent explicitly when
        drawing textarea resizer frames.

        * platform/graphics/GraphicsContext.cpp:
        (WebCore::GraphicsContextState::GraphicsContextState):
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::paintOverflowControls):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Update forgotten files.
weinig [Mon, 26 Feb 2007 02:28:16 +0000 (02:28 +0000)]
    Update forgotten files.

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::updateLayerPosition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoForgot to land FrameView.cpp in previous commit.
hyatt [Mon, 26 Feb 2007 02:07:56 +0000 (02:07 +0000)]
Forgot to land FrameView.cpp in previous commit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix for regression caused by changing the containing block of positioned...
hyatt [Mon, 26 Feb 2007 01:29:46 +0000 (01:29 +0000)]
    Fix for regression caused by changing the containing block of positioned elements with no positioned ancestor
        to be the initial containing block (represented in our tree by the RenderView).  Rework RenderView's layout
        to have very few special cases.   Now it will just relayout its children when the width/height of the
        view actually changes.  Positioned elements no longer get a special additional layout, since width/height
        adjustments are caught by the base class already anyway.

        Reviewed by mjs, darin

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::layoutBlock):
        * rendering/RenderFlexibleBox.cpp:
        (WebCore::RenderFlexibleBox::layoutBlock):
        (WebCore::RenderFlexibleBox::layoutVerticalBox):
        * rendering/RenderView.cpp:
        (WebCore::RenderView::RenderView):
        (WebCore::RenderView::layout):
        * rendering/RenderView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Not reviewed, build fix.
mjs [Mon, 26 Feb 2007 00:41:21 +0000 (00:41 +0000)]
    Not reviewed, build fix.

        - fix build breakage

        * platform/gdk/ScrollViewGdk.cpp:
        (WebCore::ScrollView::fullyClippedContentRect):
        * platform/qt/ScrollViewQt.cpp:
        (WebCore::ScrollView::fullyClippedContentRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam.
mjs [Sun, 25 Feb 2007 23:44:04 +0000 (23:44 +0000)]
    Reviewed by Adam.

        - fixed layout test failure in fast/overflow/scrollRevealButton

        I added a new ScrollView method, fullyClippedContentRect, that vies the content rect
        as clipped by all ancestor scroll views, not just this one. Currently it only works
        correctly on mac however. visibleContentRect, only accounting for the clipping from
        this particular scroll view, is sufficient for most purposes.

        * page/Frame.cpp:
        (WebCore::Frame::visibleSelectionRect):
        (WebCore::Frame::setIsActive):
        (WebCore::Frame::markAllMatchesForText):
        * platform/ScrollView.h:
        * platform/gdk/ScrollViewGdk.cpp:
        (WebCore::ScrolView::fullyClippedContentRect):
        * platform/mac/ScrollViewMac.mm:
        (WebCore::ScrollView::fullyClippedContentRect):
        * platform/qt/ScrollViewQt.cpp:
        (WebCore::ScrolView::fullyClippedContentRect):
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::scrollRectToVisible):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej.
andersca [Sun, 25 Feb 2007 22:23:11 +0000 (22:23 +0000)]
    Reviewed by Maciej.

        * building/checkout.html:
        Add Trac link to our SVN repository,

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Steve.
aroben [Sun, 25 Feb 2007 07:12:37 +0000 (07:12 +0000)]
    Reviewed by Steve.

        "Look Up in Dictionary" context menu item should be Mac-only for now,
        since it's only implemented on that platform (<rdar://problem/5021468>)

        * platform/ContextMenu.cpp:
        (WebCore::ContextMenu::populate): Wrap all instances of the dictionary
        menu item in #if PLATFORM(MAC).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
ggaren [Sun, 25 Feb 2007 02:14:54 +0000 (02:14 +0000)]
LayoutTests:

        Reviewed by Darin Adler.

        Layout tests for BidiRun leaks.

        * fast/leaks/001-expected.txt: Added.
        * fast/leaks/001.html: Added.
        * fast/leaks/002-expected.txt: Added.
        * fast/leaks/002.html: Added.

WebCore:

        Reviewed by Darin Adler.

        Fixed <rdar://problem/4987649> leaks in BidiRun::operator new seen while
        running WebKit unit tests

        In bidi.cpp, some functions allocate BidiRuns and put them in a global data
        structure, while others uses the BidiRuns in the global data structure.
        The caller is responsible for knowing which functions may allocate runs
        and which may use them, and calling deleteBidiRuns() at the appropriate time.

        The fix is to add some calls to deleteBidiRuns() where they were missing.

        I also added a BidiRun counter because these two leaks were introduced by
        our two bidi.cpp experts, so the odds that leaks will creep in again
        in the future seem pretty high.

        * rendering/bidi.cpp:
        (WebCore::RenderBlock::bidiReorderCharacters): Added  missing call to
        deleteBidiRuns().
        (WebCore::BidiRunCounter::~BidiRunCounter):
        (WebCore::BidiRun::operator delete):
        (WebCore::RenderBlock::layoutInlineChildren): Added missing call to
        deleteBidiRuns(). Moved call to deleteBidiRuns() to same scope as call to
        bidiReorderLine(), to emphasize that they go together like new/delete.
        In theory, the old code was just as good, but I didn't want to rely on
        theory.

WebKitTools:

        Reviewed by Darin Adler.

        * Scripts/run-webkit-tests: Stop ignoring BidiRun leaks, now that they're
        fixed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Kevin.
harrison [Sat, 24 Feb 2007 14:35:12 +0000 (14:35 +0000)]
    Reviewed by Kevin.

        <rdar://problem/4961431> Image with empty string alt tag should be ignored

        * bridge/mac/WebCoreAXObject.mm:
        (-[WebCoreAXObject accessibilityIsIgnored]):
        Ignore img element that has an alt attribute, but that string is empty.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoAdjust the animation a little bit to make it more natural.
zack [Sat, 24 Feb 2007 13:14:01 +0000 (13:14 +0000)]
Adjust the animation a little bit to make it more natural.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Anders.
ap [Sat, 24 Feb 2007 11:14:29 +0000 (11:14 +0000)]
    Reviewed by Anders.

        Fix the test not to include any custom content in its auto-generated HTML wrapper.

        * fast/js/resources/select-options-add.js:
        * fast/js/select-options-add-expected.txt:
        * fast/js/select-options-add.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago WebCore:
kjk [Sat, 24 Feb 2007 08:45:04 +0000 (08:45 +0000)]
  WebCore:

        Reviewed by Adam Roben.

        Gdk improvements.

        * platform/gdk/FrameGdk.cpp: only scroll on keydown, not both keydown and keyup.
        (WebCore::FrameGdk::keyPress):
        (WebCore::FrameGdk::handleGdkEvent):
        (WebCore::Frame::print):
        (WebCore::Frame::issueTransposeCommand):
        (WebCore::Frame::respondToChangedSelection):
        (WebCore::Frame::cleanupPlatformScriptObjects):
        (WebCore::Frame::dragImageForSelection):
        * platform/network/gdk/ResourceHandleManager.cpp: don't free memory that
        doesn't belong to us.
        (WebCore::ResourceHandleManager::downloadTimerCallback):

  WebKitTools:

        Reviewed by Adam Roben.

        Improve gdklauncher: add text field for entering url.

        * GdkLauncher/gdklauncher.bkl:
        * GdkLauncher/main.cpp:
        (strEmpty):
        (strEq):
        (handleGdkEvent):
        (goToUrlBarText):
        (goButtonClickedCb):
        (urlBarEnterCb):
        (registerRenderingAreaEvents):
        (frameResizeCb):
        (frameDestroyCb):
        (main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Anders.
kdecker [Sat, 24 Feb 2007 07:42:07 +0000 (07:42 +0000)]
    Reviewed by Anders.

        Fixed: <rdar://problem/4971226> REGRESSION: Replying to closed HTML mail message does not quote original body (12503)

        There were two problems here:

        * page/mac/WebCoreFrameBridge.mm:
        (+[WebCoreFrameBridge stringWithData:textEncodingName:]): The old code said  "if there is no text encoding name than
         assume WindowsLatin1 (iso-8859-1) and try to decode that". That's not sufficient because it doesn't handle the fallback
         case for unknown encodings. This method will now attempt to decode using WindowsLatin1 for unknown encoding types.
        * platform/mac/mac-encodings.txt: Added the missing "macroman" encoding type.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoLayoutTests:
weinig [Sat, 24 Feb 2007 02:55:24 +0000 (02:55 +0000)]
LayoutTests:

        Reviewed by Maciej.

        - updated test result for http://bugs.webkit.org/show_bug.cgi?id=12856
          REGRESSION (r13685): Canceling the suggestion popup does not revert the change

        * editing/deleting/delete-3800834-fix-expected.txt:

WebCore:

        Reviewed by Maciej.

        - fix http://bugs.webkit.org/show_bug.cgi?id=12856
          REGRESSION (r13685): Canceling the suggestion popup does not revert the change

        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::doApply): If the fragment to be inserted
        is empty, first delete the selection, and only then bail out.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam.
andersca [Sat, 24 Feb 2007 02:52:23 +0000 (02:52 +0000)]
    Reviewed by Adam.

        <rdar://problem/5001923>
        REGRESSION: Crash when navigating forward from an error page in WebFrameLoaderClient::dispatchDidReceiveContentLength

        Fix an error that was introduced in revision r18541. We should check if the provisional document loader
        has an unreachable URL, not the actual document loader.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::updateHistoryForCommit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@19836 268f45cc-cd09-0410-ab3c-d52691b4dbfc