WebKit-https.git
9 years ago Teach the Apple port how to build the test tools in build-webkit
lforschler@apple.com [Tue, 26 Jun 2012 23:54:46 +0000 (23:54 +0000)]
  Teach the Apple port how to build the test tools in build-webkit
      https://bugs.webkit.org/show_bug.cgi?id=89540

      Reviewed by Jon Lee & Simon Fraser.

      * BuildSlaveSupport/build.webkit.org-config/master.cfg:
      (RunWebKitTests.start): pass --no-build since tools should now be in the downloaded archive
      (RunUnitTests.start): ditto
      * Scripts/build-webkit: add tools to the projects build list

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoOnly show the platform-appropriate builders for non-layout test failures in garden...
ojan@chromium.org [Tue, 26 Jun 2012 23:43:03 +0000 (23:43 +0000)]
Only show the platform-appropriate builders for non-layout test failures in garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=90025

Reviewed by Simon Fraser.

Move the chromium-specific filtering code into config.js and replace it with a method on each platform
config. Also, let the webkit test step name be webkit_tests (build.chromium.org) or layout-test (build.webkit.org).

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/builders_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/config.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Use eina_file_ls() in EFL implementation of FileSystem listDirectory()
commit-queue@webkit.org [Tue, 26 Jun 2012 23:39:57 +0000 (23:39 +0000)]
[EFL] Use eina_file_ls() in EFL implementation of FileSystem listDirectory()
https://bugs.webkit.org/show_bug.cgi?id=89976

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-06-26
Reviewed by Antonio Gomes.

Rewrite EFL implementation of Filesystem listDirectory() in order to
use eina_file_ls() instead of POSIX C functions. This results in
shorter code.

No new tests, behavior has not changed.

* platform/efl/FileSystemEfl.cpp:
(WebCore::listDirectory):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCrash at WebCore::TextIterator::handleTextBox
commit-queue@webkit.org [Tue, 26 Jun 2012 23:34:21 +0000 (23:34 +0000)]
Crash at WebCore::TextIterator::handleTextBox
https://bugs.webkit.org/show_bug.cgi?id=89526
<rdar://problem/10305315>

Patch by Alice Cheng <alice_cheng@apple.com> on 2012-06-26
Reviewed by Darin Adler.

Source/WebCore:

The range used for marking becomes invalid after SpellingCorrectionCommand, due to changes in the DOM made by ReplaceSelectionCommand.
This invalid range caused marking to be incorrect, and Mail.app to crash when iterating through the invalid range.  To fix this,
recalculate the range for marking after SpellingCorrectionCommand.

Test: platform/mac/editing/spelling/autocorrection-blockquote-crash.html

* editing/AlternativeTextController.cpp:
(WebCore::AlternativeTextController::applyAlternativeTextToRange):
* editing/Editor.cpp:  (WebCore::Editor::markAndReplaceFor):
* testing/Internals.cpp:
(WebCore):
(WebCore::Internals::hasAutocorrectedMarker):
* testing/Internals.h: (Internals):
* testing/Internals.idl:

LayoutTests:

* platform/mac/editing/spelling/autocorrection-blockquote-crash-expected.txt: Added.
* platform/mac/editing/spelling/autocorrection-blockquote-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoConvert editing/inserting/font-size-clears-from-typing-style.html to a dump-as-markup...
rniwa@webkit.org [Tue, 26 Jun 2012 23:32:24 +0000 (23:32 +0000)]
Convert editing/inserting/font-size-clears-from-typing-style.html to a dump-as-markup test
https://bugs.webkit.org/show_bug.cgi?id=90024

Reviewed by Ojan Vafai.

Converted a script test to a dump-as-markup test because the test result can be understood much eaiser that way.

* editing/inserting/font-size-clears-from-typing-style-expected.txt:
* editing/inserting/font-size-clears-from-typing-style.html:
* editing/inserting/script-tests: Removed.
* editing/inserting/script-tests/TEMPLATE.html: Removed.
* editing/inserting/script-tests/font-size-clears-from-typing-style.js: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] HTML5 audio/video tags - loading http content from https page doesn't...
tsepez@chromium.org [Tue, 26 Jun 2012 23:18:31 +0000 (23:18 +0000)]
[chromium] HTML5 audio/video tags - loading http content from https page doesn't trigger warning.
https://bugs.webkit.org/show_bug.cgi?id=89906

Reviewed by Nate Chapin.

This patch treats mixed CachedRawResources as affecting the display of insecure content.

Source/WebCore:

Tests: http/tests/security/mixedContent/insecure-audio-video-in-main-frame.html
       http/tests/security/mixedContent/insecure-xhr-in-main-frame.html

* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::checkInsecureContent):

LayoutTests:

* http/tests/security/mixedContent/insecure-audio-video-in-main-frame-expected.txt: Added.
* http/tests/security/mixedContent/insecure-audio-video-in-main-frame.html: Added.
* http/tests/security/mixedContent/insecure-xhr-in-main-frame-expected.txt: Added.
* http/tests/security/mixedContent/insecure-xhr-in-main-frame.html: Added.
* http/tests/security/mixedContent/resources/frame-with-insecure-audio-video.html: Added.
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:
* platform/qt/TestExpectations:
* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agobackground-size:0 shows as 1px instead of invisible
commit-queue@webkit.org [Tue, 26 Jun 2012 23:08:09 +0000 (23:08 +0000)]
background-size:0 shows as 1px instead of invisible
https://bugs.webkit.org/show_bug.cgi?id=86942

Patch by Joe Thomas <joethomas@motorola.com> on 2012-06-26
Reviewed by Eric Seidel.

As per the specification http://www.w3.org/TR/css3-background/#background-size, if the background image's width or height resolves to zero,
this causes the image not to be displayed. The effect should be the same as if it had been a transparent image.
This is also mentioned in http://www.w3.org/TR/2002/WD-css3-background-20020802/#background-size.

Source/WebCore:

Test: fast/backgrounds/zero-background-size.html

* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::calculateFillTileSize):

LayoutTests:

* fast/backgrounds/size/zero.html:
* fast/backgrounds/zero-background-size-expected.html: Added.
* fast/backgrounds/zero-background-size.html: Added.
* platform/chromium/TestExpectations:
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/fast/backgrounds/size/zero-expected.png:
* platform/mac/fast/backgrounds/size/zero-expected.txt:
* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[v8] Clean up generated Dictionary-handling code
adamk@chromium.org [Tue, 26 Jun 2012 23:02:00 +0000 (23:02 +0000)]
[v8] Clean up generated Dictionary-handling code
https://bugs.webkit.org/show_bug.cgi?id=89994

Reviewed by Adam Barth.

No change in behavior, so no new tests.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateParametersCheck):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::optionsObjectCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix failing garden-o-matic unittests
ojan@chromium.org [Tue, 26 Jun 2012 23:00:43 +0000 (23:00 +0000)]
Fix failing garden-o-matic unittests
https://bugs.webkit.org/show_bug.cgi?id=90021

Reviewed by Adam Barth.

These had all just fallen out of date.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/checkout_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui_unittests.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoInclude stdio.h when DEBUG_AUDIONODE_REFERENCES is set
commit-queue@webkit.org [Tue, 26 Jun 2012 23:00:04 +0000 (23:00 +0000)]
Include stdio.h when DEBUG_AUDIONODE_REFERENCES is set
https://bugs.webkit.org/show_bug.cgi?id=89997

Patch by Raymond Toy <rtoy@google.com> on 2012-06-26
Reviewed by Eric Seidel.

No new tests needed for a compile issue

* Modules/webaudio/AudioNode.cpp:  Include stdio.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Use premultiplied alpha when extracting image data in WebGL
noam.rosenthal@nokia.com [Tue, 26 Jun 2012 22:51:35 +0000 (22:51 +0000)]
[Qt] Use premultiplied alpha when extracting image data in WebGL
https://bugs.webkit.org/show_bug.cgi?id=89937

Reviewed by Jocelyn Turcotte.

Perform conversion in QImage only if the image format is not ARGB32 or
ARGB32_Premultiplied. Otherwise, allow packPixels to perform the conversion if the formats
don't match, as packPixels already performs pixel-specific operations.

Covered by tests in LayoutTests/fast/canvas/webgl, e.g. webgl-composite-modes.html.

* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3D::getImageData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoIndexedDB: Move method precondition checks to front end objects
jsbell@chromium.org [Tue, 26 Jun 2012 22:04:09 +0000 (22:04 +0000)]
IndexedDB: Move method precondition checks to front end objects
https://bugs.webkit.org/show_bug.cgi?id=89377

Reviewed by Tony Chang.

Now that metadata exists on the front end, most of the pre-condition validation checks
done on IDB method calls from script can be moved to the front end which simplifies the
code significantly in the case of complex methods like IDBObjectStore::put().

Adds an internal "active" flag for transactions, although the behavior is not accurate
to the spec (it should only be true during event callbacks - http://webkit.org/b/89379).
The back-end methods can then be simplifed to just adding async tasks to the transaction,
and the front end methods can take care of all exception cases except for asynchronous
transaction abort which still requires plumbing back to the front end.

No functional changes - no new tests.

* Modules/indexeddb/IDBCursor.cpp:
(WebCore::IDBCursor::update): Migrate from IDBObjectStoreBackendImpl::put.
(WebCore::IDBCursor::advance): Add more explicit transaction-is-active check.
(WebCore::IDBCursor::continueFunction): Ditto.
(WebCore::IDBCursor::deleteFunction): Ditto.
(WebCore::IDBCursor::effectiveObjectStore): Convenience function (source may be store or index).
(WebCore):
* Modules/indexeddb/IDBCursor.h:
(WebCore::IDBCursor::isKeyCursor): Distinguish from IDBCursorWithValue.
(IDBCursor):
* Modules/indexeddb/IDBCursorBackendImpl.cpp:
(WebCore::IDBCursorBackendImpl::update): Remove migrated check.
* Modules/indexeddb/IDBCursorWithValue.h:
(IDBCursorWithValue):
* Modules/indexeddb/IDBDatabase.cpp: Migrate checks.
(WebCore::IDBDatabase::createObjectStore):
(WebCore::IDBDatabase::deleteObjectStore):
* Modules/indexeddb/IDBDatabaseBackendImpl.cpp: Replace checks with assertions.
(WebCore::IDBDatabaseBackendImpl::createObjectStore):
(WebCore::IDBDatabaseBackendImpl::deleteObjectStore):
* Modules/indexeddb/IDBIndex.cpp: Add transaction-is-active checks.
(WebCore::IDBIndex::openCursor):
(WebCore::IDBIndex::count):
(WebCore::IDBIndex::openKeyCursor):
(WebCore::IDBIndex::get):
(WebCore::IDBIndex::getKey):
* Modules/indexeddb/IDBObjectStore.cpp: Migrate cehcks.
(WebCore::IDBObjectStore::get):
(WebCore::IDBObjectStore::add): Delegates to put(PutMode)
(WebCore::IDBObjectStore::put): Delegates to put(PutMode)
(WebCore): Adds put(PutMode) which has the unified checks migrated from
IDBObjectStoreBackendImpl::put.
(WebCore::IDBObjectStore::deleteFunction):
(WebCore::IDBObjectStore::clear):
(WebCore::IDBObjectStore::createIndex):
(WebCore::IDBObjectStore::deleteIndex):
(WebCore::IDBObjectStore::openCursor):
(WebCore::IDBObjectStore::count):
* Modules/indexeddb/IDBObjectStore.h: Adds put(PutMode).
(IDBObjectStore):
* Modules/indexeddb/IDBObjectStoreBackendImpl.cpp:
(WebCore::IDBObjectStoreBackendImpl::getInternal): Fix trace symbol.
(WebCore::IDBObjectStoreBackendImpl::put): Remove migrated checks.
(WebCore::IDBObjectStoreBackendImpl::createIndex): Remove migrated checks.
(WebCore::IDBObjectStoreBackendImpl::deleteIndex): Remove migrated checks.
* Modules/indexeddb/IDBTransaction.cpp: Add active flag tracking.
(WebCore::IDBTransaction::IDBTransaction):
(WebCore::IDBTransaction::abort):
(WebCore::IDBTransaction::onAbort):
(WebCore::IDBTransaction::onComplete):
* Modules/indexeddb/IDBTransaction.h:
(WebCore::IDBTransaction::isActive):
(WebCore::IDBTransaction::isReadOnly): Group IDL/non-IDL methods.
(IDBTransaction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix a test after r121286.
rniwa@webkit.org [Tue, 26 Jun 2012 21:46:34 +0000 (21:46 +0000)]
Fix a test after r121286.

* editing/deleting/merge-into-empty-block-2.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r121285.
commit-queue@webkit.org [Tue, 26 Jun 2012 21:35:55 +0000 (21:35 +0000)]
Unreviewed, rolling out r121285.
http://trac.webkit.org/changeset/121285
https://bugs.webkit.org/show_bug.cgi?id=90014

"We misinterpreted 'size of the initial containing block'"
(Requested by tomz on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-26

Source/WebCore:

* css/CSSCalculationValue.cpp:
(WebCore::CSSCalcValue::computeLengthPx):
(WebCore::CSSCalcPrimitiveValue::toCalcValue):
(WebCore::CSSCalcPrimitiveValue::computeLengthPx):
(WebCore::CSSCalcBinaryOperation::toCalcValue):
(WebCore::CSSCalcBinaryOperation::computeLengthPx):
* css/CSSCalculationValue.h:
(CSSCalcExpressionNode):
(WebCore::CSSCalcValue::toCalcValue):
(CSSCalcValue):
* css/CSSGradientValue.cpp:
(WebCore::CSSGradientValue::addStops):
(WebCore::positionFromValue):
(WebCore::CSSGradientValue::computeEndPoint):
(WebCore::CSSLinearGradientValue::createGradient):
(WebCore::CSSRadialGradientValue::resolveRadius):
(WebCore::CSSRadialGradientValue::createGradient):
* css/CSSGradientValue.h:
(CSSGradientValue):
(CSSRadialGradientValue):
* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::computeLength):
(WebCore::CSSPrimitiveValue::computeLengthDouble):
* css/CSSPrimitiveValue.h:
(CSSPrimitiveValue):
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::convertToLength):
* css/CSSToStyleMap.cpp:
(WebCore::CSSToStyleMap::mapFillSize):
(WebCore::CSSToStyleMap::mapFillXPosition):
(WebCore::CSSToStyleMap::mapFillYPosition):
(WebCore::CSSToStyleMap::mapNinePieceImageQuad):
* css/CSSToStyleMap.h:
(CSSToStyleMap):
* css/MediaQueryEvaluator.cpp:
(WebCore::computeLength):
(WebCore::device_heightMediaFeatureEval):
(WebCore::device_widthMediaFeatureEval):
(WebCore::heightMediaFeatureEval):
(WebCore::widthMediaFeatureEval):
* css/SVGCSSStyleSelector.cpp:
(WebCore::StyleResolver::applySVGProperty):
* css/StyleBuilder.cpp:
(WebCore::ApplyPropertyAuto::applyValue):
(WebCore::ApplyPropertyClip::convertToLength):
(WebCore::ApplyPropertyLength::applyValue):
(WebCore::ApplyPropertyBorderRadius::applyValue):
(WebCore::ApplyPropertyComputeLength::applyValue):
(WebCore::ApplyPropertyFontSize::applyValue):
(WebCore::ApplyPropertyLineHeight::applyValue):
(WebCore::ApplyPropertyPageSize::mmLength):
(WebCore::ApplyPropertyPageSize::inchLength):
(WebCore::ApplyPropertyPageSize::applyValue):
(WebCore::ApplyPropertyVerticalAlign::applyValue):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):
* css/StyleResolver.h:
(StyleResolver):
* css/WebKitCSSMatrix.cpp:
(WebCore::WebKitCSSMatrix::setMatrixValue):

LayoutTests:

* css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vh-border-expected.html: Removed.
* css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vh-border.html: Removed.
* css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vmin-border-expected.html: Removed.
* css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vmin-border.html: Removed.
* css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vw-border-expected.htm: Removed.
* css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vw-border.html: Removed.
* ietestcenter/css3/valuesandunits/units-000.htm:
* platform/chromium/TestExpectations:
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:
* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Expose rendering statistics to WebWidget.
commit-queue@webkit.org [Tue, 26 Jun 2012 21:30:44 +0000 (21:30 +0000)]
[chromium] Expose rendering statistics to WebWidget.
https://bugs.webkit.org/show_bug.cgi?id=88268

Patch by Dave Tu <dtu@chromium.org> on 2012-06-26
Reviewed by James Robinson.

The WebKit side of a basic framework for exposing rendering statistics
to Chromium's --enable-benchmarking extension.

Source/Platform:

* chromium/public/WebLayerTreeView.h:
(WebRenderingStatistics):
(WebKit):
(WebLayerTreeView):

Source/WebCore:

* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(WebCore::CCLayerTreeHost::implFrameNumber):
* platform/graphics/chromium/cc/CCProxy.h:
(CCProxy):
* platform/graphics/chromium/cc/CCSingleThreadProxy.h:
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::implFrameNumber):
(WebCore):
(WebCore::CCThreadProxy::implFrameNumberOnImplThread):
* platform/graphics/chromium/cc/CCThreadProxy.h:
(CCThreadProxy):

Source/WebKit/chromium:

* src/WebLayerTreeView.cpp:
(WebKit::WebLayerTreeView::renderingStatistics):
(WebKit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix platform picker change handler in garden-o-matic
ojan@chromium.org [Tue, 26 Jun 2012 21:21:54 +0000 (21:21 +0000)]
Fix platform picker change handler in garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=90010

Reviewed by Simon Fraser.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
The old code never worked. This is hard to test because change handlers require
a user-initiated action and the code is changing the window's location, which would
navigate the test page.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/onebar.css:
Fix the CSS so it doesn't cause the tabstrip to be disconnected from the tabs on Linux
due to the large margin-bottom.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoConvert editing/deleting/delete-3959464-fix.html, delete-at-paragraph-boundaries...
rniwa@webkit.org [Tue, 26 Jun 2012 21:06:24 +0000 (21:06 +0000)]
Convert editing/deleting/delete-3959464-fix.html, delete-at-paragraph-boundaries-001.html, merge-into-empty-block-1.html and merge-into-empty-block-2.html to dump-as-markup tests
https://bugs.webkit.org/show_bug.cgi?id=90011

Reviewed by Eric Seidel.

* editing/deleting/delete-3959464-fix-expected.txt: Added.
* editing/deleting/delete-3959464-fix.html:
* editing/deleting/delete-at-paragraph-boundaries-001-expected.txt: Added.
* editing/deleting/delete-at-paragraph-boundaries-001.html:
* editing/deleting/merge-into-empty-block-1-expected.txt: Added.
* editing/deleting/merge-into-empty-block-1.html:
* editing/deleting/merge-into-empty-block-2-expected.txt: Added.
* editing/deleting/merge-into-empty-block-2.html:
* platform/chromium-linux/editing/deleting/delete-3959464-fix-expected.png: Removed.
* platform/chromium-linux/editing/deleting/delete-at-paragraph-boundaries-001-expected.png: Removed.
* platform/chromium-linux/editing/deleting/merge-into-empty-block-1-expected.png: Removed.
* platform/chromium-linux/editing/deleting/merge-into-empty-block-2-expected.png: Removed.
* platform/chromium-mac-leopard/editing/deleting/delete-at-paragraph-boundaries-001-expected.png: Removed.
* platform/chromium-mac-leopard/editing/deleting/merge-into-empty-block-1-expected.png: Removed.
* platform/chromium-mac-leopard/editing/deleting/merge-into-empty-block-2-expected.png: Removed.
* platform/chromium-mac-snowleopard/editing/deleting/merge-into-empty-block-1-expected.png: Removed.
* platform/chromium-mac-snowleopard/editing/deleting/merge-into-empty-block-2-expected.png: Removed.
* platform/chromium-mac/editing/deleting/delete-3959464-fix-expected.png: Removed.
* platform/chromium-mac/editing/deleting/delete-at-paragraph-boundaries-001-expected.png: Removed.
* platform/chromium-mac/editing/deleting/merge-into-empty-block-1-expected.png: Removed.
* platform/chromium-mac/editing/deleting/merge-into-empty-block-2-expected.png: Removed.
* platform/chromium-win/editing/deleting/delete-3959464-fix-expected.png: Removed.
* platform/chromium-win/editing/deleting/delete-3959464-fix-expected.txt: Removed.
* platform/chromium-win/editing/deleting/delete-at-paragraph-boundaries-001-expected.png: Removed.
* platform/chromium-win/editing/deleting/delete-at-paragraph-boundaries-001-expected.txt: Removed.
* platform/chromium-win/editing/deleting/merge-into-empty-block-1-expected.png: Removed.
* platform/chromium-win/editing/deleting/merge-into-empty-block-1-expected.txt: Removed.
* platform/chromium-win/editing/deleting/merge-into-empty-block-2-expected.png: Removed.
* platform/chromium-win/editing/deleting/merge-into-empty-block-2-expected.txt: Removed.
* platform/gtk/editing/deleting/delete-3959464-fix-expected.txt: Removed.
* platform/gtk/editing/deleting/delete-at-paragraph-boundaries-001-expected.png: Removed.
* platform/gtk/editing/deleting/delete-at-paragraph-boundaries-001-expected.txt: Removed.
* platform/gtk/editing/deleting/merge-into-empty-block-1-expected.png: Removed.
* platform/gtk/editing/deleting/merge-into-empty-block-1-expected.txt: Removed.
* platform/gtk/editing/deleting/merge-into-empty-block-2-expected.png: Removed.
* platform/gtk/editing/deleting/merge-into-empty-block-2-expected.txt: Removed.
* platform/mac/editing/deleting/delete-3959464-fix-expected.png: Removed.
* platform/mac/editing/deleting/delete-3959464-fix-expected.txt: Removed.
* platform/mac/editing/deleting/delete-at-paragraph-boundaries-001-expected.png: Removed.
* platform/mac/editing/deleting/delete-at-paragraph-boundaries-001-expected.txt: Removed.
* platform/mac/editing/deleting/merge-into-empty-block-1-expected.png: Removed.
* platform/mac/editing/deleting/merge-into-empty-block-1-expected.txt: Removed.
* platform/mac/editing/deleting/merge-into-empty-block-2-expected.png: Removed.
* platform/mac/editing/deleting/merge-into-empty-block-2-expected.txt: Removed.
* platform/qt/editing/deleting/delete-3959464-fix-expected.png: Removed.
* platform/qt/editing/deleting/delete-3959464-fix-expected.txt: Removed.
* platform/qt/editing/deleting/delete-at-paragraph-boundaries-001-expected.png: Removed.
* platform/qt/editing/deleting/delete-at-paragraph-boundaries-001-expected.txt: Removed.
* platform/qt/editing/deleting/merge-into-empty-block-1-expected.png: Removed.
* platform/qt/editing/deleting/merge-into-empty-block-1-expected.txt: Removed.
* platform/qt/editing/deleting/merge-into-empty-block-2-expected.png: Removed.
* platform/qt/editing/deleting/merge-into-empty-block-2-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoietestcenter/css3/valuesandunits/units-000.htm asserts
tomz@codeaurora.org [Tue, 26 Jun 2012 20:23:26 +0000 (20:23 +0000)]
ietestcenter/css3/valuesandunits/units-000.htm asserts
https://bugs.webkit.org/show_bug.cgi?id=86176

Patch by Dave Tharp <dtharp@codeaurora.org> on 2012-06-26
Reviewed by Beth Dakin.

Source/WebCore:

Modified computeLengthDouble() to handle vh, vw, and vmin units. Per the spec
(http://dev.w3.org/csswg/css3-values/#viewport-relative-lengths) viewport -percentage
lengths are "relative to the size of the initial containing block", which I read to be
the size of the parent element. Since parentStyle was not available in computeLengthDouble,
most of the changes for this patch involved "pushing down" the parentStyle pointer through
the network of computeLength methods and dependencies.

Tests: css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vh-border.html
       css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vmin-border.html
       css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vw-border.html

* css/CSSCalculationValue.cpp:
(WebCore::CSSCalcValue::computeLengthPx):
(WebCore::CSSCalcPrimitiveValue::toCalcValue):
(WebCore::CSSCalcPrimitiveValue::computeLengthPx):
(WebCore::CSSCalcBinaryOperation::toCalcValue):
(WebCore::CSSCalcBinaryOperation::computeLengthPx):
* css/CSSCalculationValue.h:
(CSSCalcExpressionNode):
(WebCore::CSSCalcValue::toCalcValue):
(CSSCalcValue):
* css/CSSGradientValue.cpp:
(WebCore::CSSGradientValue::addStops):
(WebCore::positionFromValue):
(WebCore::CSSGradientValue::computeEndPoint):
(WebCore::CSSLinearGradientValue::createGradient):
(WebCore::CSSRadialGradientValue::resolveRadius):
(WebCore::CSSRadialGradientValue::createGradient):
* css/CSSGradientValue.h:
(CSSGradientValue):
(CSSRadialGradientValue):
* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::computeLength):
(WebCore::CSSPrimitiveValue::computeLengthDouble):
* css/CSSPrimitiveValue.h:
(CSSPrimitiveValue):
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::convertToLength):
* css/CSSToStyleMap.cpp:
(WebCore::CSSToStyleMap::parentStyle):
(WebCore):
(WebCore::CSSToStyleMap::mapFillSize):
(WebCore::CSSToStyleMap::mapFillXPosition):
(WebCore::CSSToStyleMap::mapFillYPosition):
(WebCore::CSSToStyleMap::mapNinePieceImageQuad):
* css/CSSToStyleMap.h:
(CSSToStyleMap):
* css/MediaQueryEvaluator.cpp:
(WebCore::computeLength):
(WebCore::device_heightMediaFeatureEval):
(WebCore::device_widthMediaFeatureEval):
(WebCore::heightMediaFeatureEval):
(WebCore::widthMediaFeatureEval):
* css/SVGCSSStyleSelector.cpp:
(WebCore::StyleResolver::applySVGProperty):
* css/StyleBuilder.cpp:
(WebCore::ApplyPropertyAuto::applyValue):
(WebCore::ApplyPropertyClip::convertToLength):
(WebCore::ApplyPropertyLength::applyValue):
(WebCore::ApplyPropertyBorderRadius::applyValue):
(WebCore::ApplyPropertyComputeLength::applyValue):
(WebCore::ApplyPropertyFontSize::applyValue):
(WebCore::ApplyPropertyLineHeight::applyValue):
(WebCore::ApplyPropertyPageSize::mmLength):
(WebCore::ApplyPropertyPageSize::inchLength):
(WebCore::ApplyPropertyPageSize::applyValue):
(WebCore::ApplyPropertyVerticalAlign::applyValue):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):
* css/StyleResolver.h:
(WebCore::StyleResolver::parentNode):
(StyleResolver):
* css/WebKitCSSMatrix.cpp:
(WebCore::WebKitCSSMatrix::setMatrixValue):

LayoutTests:

Adding explicit tests for viewport border length tests. Inspired by IE Test center
units-000 test which highlighted that vw, vh, and vmin were not being handled in computeLengthDouble().
Also, adjusting test_expectations and Skipped for units-000, which no longer Asserts with this
patch implemented.

* css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vh-border-expected.html: Added.
* css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vh-border.html: Added.
* css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vmin-border-expected.html: Added.
* css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vmin-border.html: Added.
* css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vw-border-expected.htm: Added.
* css3/viewport-percentage-lengths/css3-viewport-percentage-lengths-vw-border.html: Added.
* ietestcenter/css3/valuesandunits/units-000.htm:
* platform/chromium/TestExpectations:
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:
* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Add WebLayer API for scrolling
jamesr@google.com [Tue, 26 Jun 2012 20:17:09 +0000 (20:17 +0000)]
[chromium] Add WebLayer API for scrolling
https://bugs.webkit.org/show_bug.cgi?id=89913

Reviewed by Adrienne Walker.

Source/Platform:

Adds WebScrollableLayer type to represent a layer that can be scrolled by the user. Currently WebContentLayers
are scrollable and no other layer types are, although this might change in the future.

* chromium/public/WebContentLayer.h:
(WebKit::WebContentLayer::WebContentLayer):
* chromium/public/WebLayer.h:
(WebLayer):
* chromium/public/WebScrollableLayer.h:
(WebKit):
(WebScrollableLayer):
(WebKit::WebScrollableLayer::WebScrollableLayer):
(WebKit::WebScrollableLayer::~WebScrollableLayer):
(WebKit::WebScrollableLayer::operator=):

Source/WebCore:

Use new WebScrollableLayer type in ScrollingCoordinatorChromium. This file peeks "under the hood" a fair amount
since we don't have WebLayer API for scrollbar layers yet.

* page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:
(WebCore::ScrollingCoordinatorPrivate::setScrollLayer):
(WebCore::ScrollingCoordinatorPrivate::setHorizontalScrollbarLayer):
(WebCore::ScrollingCoordinatorPrivate::setVerticalScrollbarLayer):
(WebCore::ScrollingCoordinatorPrivate::hasScrollLayer):
(WebCore::ScrollingCoordinatorPrivate::scrollLayer):
(ScrollingCoordinatorPrivate):
(WebCore::createScrollbarLayer):
(WebCore::ScrollingCoordinator::setScrollLayer):
(WebCore::ScrollingCoordinator::setNonFastScrollableRegion):
(WebCore::ScrollingCoordinator::setWheelEventHandlerCount):
(WebCore::ScrollingCoordinator::setShouldUpdateScrollLayerPositionOnMainThread):

Source/WebKit/chromium:

Use WebScrollableLayer type in NonCompositedContentHost.

* WebKit.gyp:
* src/NonCompositedContentHost.cpp:
(WebKit::NonCompositedContentHost::setScrollLayer):
(WebKit::reserveScrollbarLayers):
(WebKit::NonCompositedContentHost::setViewport):
(WebKit::NonCompositedContentHost::haveScrollLayer):
(WebKit):
(WebKit::NonCompositedContentHost::scrollLayer):
* src/NonCompositedContentHost.h:
(WebCore):
* src/WebContentLayer.cpp:
(WebKit::WebContentLayer::WebContentLayer):
* src/WebLayer.cpp:
(WebKit::WebLayer::numberOfChildren):
(WebKit):
(WebKit::WebLayer::childAt):
(WebKit::WebLayer::setAlwaysReserveTextures):
* src/WebScrollableLayer.cpp:
(WebKit):
(WebKit::WebScrollableLayer::setScrollPosition):
(WebKit::WebScrollableLayer::setScrollable):
(WebKit::WebScrollableLayer::setHaveWheelEventHandlers):
(WebKit::WebScrollableLayer::setShouldScrollOnMainThread):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r120501.
jamesr@google.com [Tue, 26 Jun 2012 20:09:31 +0000 (20:09 +0000)]
Unreviewed, rolling out r120501.
http://trac.webkit.org/changeset/120501
https://bugs.webkit.org/show_bug.cgi?id=89126

[skia] Fix is too heavy-handed

* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::drawNeedsCopy):
* platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::PlatformContextSkia):
* platform/graphics/skia/PlatformContextSkia.h:
(PlatformContextSkia):
(WebCore::PlatformContextSkia::isDeferred):
(WebCore::PlatformContextSkia::setDeferred):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Add JSC statistics into about:memory
commit-queue@webkit.org [Tue, 26 Jun 2012 19:55:32 +0000 (19:55 +0000)]
[BlackBerry] Add JSC statistics into about:memory
https://bugs.webkit.org/show_bug.cgi?id=89779

Patch by Yong Li <yoli@rim.com> on 2012-06-26
Reviewed by Rob Buis.

Fix non-JIT build on BlackBerry broken by r121196.

* runtime/MemoryStatistics.cpp:
(JSC::globalMemoryStatistics):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Add WebPage interface for Async spell check.
mifenton@rim.com [Tue, 26 Jun 2012 19:52:14 +0000 (19:52 +0000)]
[BlackBerry] Add WebPage interface for Async spell check.
https://bugs.webkit.org/show_bug.cgi?id=89999

Reviewed by Rob Buis.

PR 124517.

Add interface for IMS async spell checking.

Reviewed Internally by Nima Ghanavatian.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::spellCheckingRequestProcessed):
(WebKit):
* Api/WebPage.h:
* Api/WebPageClient.h:
* WebKitSupport/InputHandler.cpp:
(WebKit):
(BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):
* WebKitSupport/InputHandler.h:
(InputHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDFG::operationNewArray is unnecessarily slow, and may use the wrong array
fpizlo@apple.com [Tue, 26 Jun 2012 19:42:05 +0000 (19:42 +0000)]
DFG::operationNewArray is unnecessarily slow, and may use the wrong array
prototype when inlined
https://bugs.webkit.org/show_bug.cgi?id=89821

Source/JavaScriptCore:

Reviewed by Geoffrey Garen.

Fixes all array allocations to use the right structure, and hence the right prototype. Adds
inlining of new Array(...) with a non-zero number of arguments. Optimizes allocations of
empty arrays.

* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleConstantInternalFunction):
* dfg/DFGCCallHelpers.h:
(JSC::DFG::CCallHelpers::setupArgumentsWithExecState):
(CCallHelpers):
* dfg/DFGNodeType.h:
(DFG):
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* runtime/JSArray.h:
(JSC):
(JSC::constructArray):
* runtime/JSGlobalObject.h:
(JSC):
(JSC::constructArray):

LayoutTests:

Rubber stamped by Geoffrey Garen.

* fast/js/dfg-cross-global-object-inline-new-array-expected.txt: Added.
* fast/js/dfg-cross-global-object-inline-new-array-literal-expected.txt: Added.
* fast/js/dfg-cross-global-object-inline-new-array-literal-with-variables-expected.txt: Added.
* fast/js/dfg-cross-global-object-inline-new-array-literal-with-variables.html: Added.
* fast/js/dfg-cross-global-object-inline-new-array-literal.html: Added.
* fast/js/dfg-cross-global-object-inline-new-array-with-elements-expected.txt: Added.
* fast/js/dfg-cross-global-object-inline-new-array-with-elements.html: Added.
* fast/js/dfg-cross-global-object-inline-new-array-with-size-expected.txt: Added.
* fast/js/dfg-cross-global-object-inline-new-array-with-size.html: Added.
* fast/js/dfg-cross-global-object-inline-new-array.html: Added.
* fast/js/script-tests/cross-global-object-inline-global-var.js:
(done):
* fast/js/script-tests/dfg-cross-global-object-inline-new-array-literal-with-variables.js: Added.
(foo):
(done):
(doit):
* fast/js/script-tests/dfg-cross-global-object-inline-new-array-literal.js: Added.
(foo):
(done):
(doit):
* fast/js/script-tests/dfg-cross-global-object-inline-new-array-with-elements.js: Added.
(foo):
(done):
(doit):
* fast/js/script-tests/dfg-cross-global-object-inline-new-array-with-size.js: Added.
(foo):
(done):
(doit):
* fast/js/script-tests/dfg-cross-global-object-inline-new-array.js: Added.
(foo):
(done):
(doit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCrash in FixedTableLayout::layout
jchaffraix@webkit.org [Tue, 26 Jun 2012 19:40:08 +0000 (19:40 +0000)]
Crash in FixedTableLayout::layout
https://bugs.webkit.org/show_bug.cgi?id=88676

Unreviewed typo fix, pointed out by Darin Adler.

* rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::layout):
* rendering/FixedTableLayout.cpp:
(WebCore::FixedTableLayout::layout):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMutationObserver.observe should treat a null or undefined options argument as empty
adamk@chromium.org [Tue, 26 Jun 2012 19:36:50 +0000 (19:36 +0000)]
MutationObserver.observe should treat a null or undefined options argument as empty
https://bugs.webkit.org/show_bug.cgi?id=89992

Reviewed by Ojan Vafai.

Source/WebCore:

The WebIDL spec was recently updated to treat null or undefined
Dictionary arguments the same as the empty dictionary. This patch
updates MutationObserver.observe to follow that spec.

Note that we still throw a SYNTAX_ERR in this case, since it's an
error not to pass one of "attributes", "childList", or "characterData"
as a key in the dictionary.

* dom/WebKitMutationObserver.cpp:
(WebCore::WebKitMutationObserver::observe):

LayoutTests:

* fast/mutation/observe-exceptions-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] The single thread proxy should not automatically tick new animations.
commit-queue@webkit.org [Tue, 26 Jun 2012 19:34:23 +0000 (19:34 +0000)]
[chromium] The single thread proxy should not automatically tick new animations.
https://bugs.webkit.org/show_bug.cgi?id=89996

Patch by Ian Vollick <vollick@chromium.org> on 2012-06-26
Reviewed by James Robinson.

Source/WebCore:

No new tests. No change to existing functionality.

* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::CCSingleThreadProxy):
(WebCore::CCSingleThreadProxy::initializeLayerRenderer):
(WebCore::CCSingleThreadProxy::didAddAnimation):
* platform/graphics/chromium/cc/CCSingleThreadProxy.h:
(WebCore):

Source/WebKit/chromium:

* WebKit.gypi:
* tests/CCSingleThreadProxyTest.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Mark a layout test as timeout
hclam@chromium.org [Tue, 26 Jun 2012 19:21:32 +0000 (19:21 +0000)]
[chromium] Mark a layout test as timeout
https://bugs.webkit.org/show_bug.cgi?id=90003

fast/js/repeat-cached-vm-reentry.html started timing out on Mac debug and Win debug builds
between r121233:121239.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCrash in FixedTableLayout::layout
jchaffraix@webkit.org [Tue, 26 Jun 2012 19:16:08 +0000 (19:16 +0000)]
Crash in FixedTableLayout::layout
https://bugs.webkit.org/show_bug.cgi?id=88676

Reviewed by Abhishek Arya.

Source/WebCore:

Tests: fast/table/auto-table-layout-colgroup-removal-crash.html
       fast/table/fixed-table-layout/colgroup-removal-crash.html
       fast/table/fixed-table-layout/prepend-in-fixed-table.html

The issue comes from RenderTable not properly dirtying its preferred logical
widths. As the table layout codes (both fixed and auto), recomputes their internal
structures at computePreferredLogicalWidth, the internal structure doesn't match
the table sizing and we crash.

This fix adds a work-around in FixedTableLayout::layout (which matches AutoTableLayout).
The long-term fix would be to properly fix the logic but this is a lot safer, especially
since our logic is really not bullet-proof at the moment.

* rendering/FixedTableLayout.cpp:
(WebCore::FixedTableLayout::layout):
Added an internal structure recomputation, if we have drifted from our table's structure.
Also we need to update nEffCols if we call calcWidthArray.

* rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::layout):
Added a comment matching FixedTableLayout. The nEffCols is unneeded but kept for consistency
with FixedTableLayout.

LayoutTests:

* fast/table/auto-table-layout-colgroup-removal-crash-expected.txt: Added.
* fast/table/auto-table-layout-colgroup-removal-crash.html: Added.
* fast/table/fixed-table-layout/colgroup-removal-crash-expected.txt: Added.
* fast/table/fixed-table-layout/colgroup-removal-crash.html: Added.
2 cases where we remove a colgroup after having done layout.

* fast/table/fixed-table-layout/prepend-in-fixed-table-expected.txt: Added.
* fast/table/fixed-table-layout/prepend-in-fixed-table.html: Added.
This is a copy of fast/table/prepend-in-anonymous-table.html modified to work with
fixed table layout. This covers a bug found during testing that is fixed as part of
this broader change.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Layer chromium should need a redraw after getting its first non-empty...
commit-queue@webkit.org [Tue, 26 Jun 2012 18:42:29 +0000 (18:42 +0000)]
[chromium] Layer chromium should need a redraw after getting its first non-empty bounds.
https://bugs.webkit.org/show_bug.cgi?id=89784

Patch by Ian Vollick <vollick@chromium.org> on 2012-06-26
Reviewed by James Robinson.

Previously, we'd only set needs redraw if the old bounds were zero,
and the new bounds were non-zero, but we should actually have
checked that the old bounds were non-empty.

Source/WebCore:

Unit test: LayerChromiumTestWithoutFixture.setBoundsTriggersSetNeedsRedrawAfterGettingNonEmptyBounds

* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::setBounds):

Source/WebKit/chromium:

* tests/LayerChromiumTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Mark a layout test as fail
hclam@chromium.org [Tue, 26 Jun 2012 18:39:31 +0000 (18:39 +0000)]
[chromium] Mark a layout test as fail
https://bugs.webkit.org/show_bug.cgi?id=89998

compositing/webgl/webgl-nonpremultiplied-blend.html started failing after r121267, give it IMAGE failure.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoOn Mac, autocorrection sometimes fails to take place in Safari.
jpu@apple.com [Tue, 26 Jun 2012 18:38:56 +0000 (18:38 +0000)]
On Mac, autocorrection sometimes fails to take place in Safari.
https://bugs.webkit.org/show_bug.cgi?id=89982

Reviewed by Darin Adler.

Existing test was turned off due to intermittent failure, which is caused by autocorrection result depending on user data
that may be altered by previous test runs. Hopefully we can turn the test back on once we have a way to make autocorrection
behave consistently.

Basically we should check the value of shouldCheckForCorrection, not shouldShowCorrectionPanel, to determine if we should
early return in markAndReplaceFor().

* editing/Editor.cpp:
(WebCore::Editor::markAndReplaceFor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDo early-return when author and user styles are disabled.
commit-queue@webkit.org [Tue, 26 Jun 2012 18:34:54 +0000 (18:34 +0000)]
Do early-return when author and user styles are disabled.
https://bugs.webkit.org/show_bug.cgi?id=89947

Patch by Joe Thomas <joethomas@motorola.com> on 2012-06-26
Reviewed by Andreas Kling.

* dom/Document.cpp:
(WebCore::Document::collectActiveStylesheets):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agowebkitpy: Make webkit-patch patches-to-review useful
commit-queue@webkit.org [Tue, 26 Jun 2012 18:27:44 +0000 (18:27 +0000)]
webkitpy: Make webkit-patch patches-to-review useful
https://bugs.webkit.org/show_bug.cgi?id=89470

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-06-26
Reviewed by Eric Seidel.

webkit-patch patches-to-review will now output the list of
bugs with patches pending for review that has the user on CC,
excluding patches with cq-, sorted by the age of the patch.

* Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
(BugzillaQueries.fetch_bugs_from_review_queue):
* Scripts/webkitpy/common/net/bugzilla/bugzilla_mock.py:
(MockBugzillaQueries.fetch_bugs_from_review_queue):
(MockBugzilla.__init__):
(MockBugzilla.authenticate):
* Scripts/webkitpy/tool/commands/queries.py:
(PatchesToReview):
(PatchesToReview.__init__):
(PatchesToReview._print_report):
(PatchesToReview._generate_report):
(PatchesToReview.execute):
* Scripts/webkitpy/tool/commands/queries_unittest.py:
(QueryCommandsTest.test_patches_to_review):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Remove dead compositor-related API from GraphicsContext3DPrivate / Extensi...
commit-queue@webkit.org [Tue, 26 Jun 2012 18:09:22 +0000 (18:09 +0000)]
[chromium] Remove dead compositor-related API from GraphicsContext3DPrivate / Extensions3DChromium
https://bugs.webkit.org/show_bug.cgi?id=89933

Patch by James Robinson <jamesr@chromium.org> on 2012-06-26
Reviewed by Kenneth Russell.

Source/WebCore:

GraphicsContext3DPrivate and Extensions3DChromium had a fair amount of plumbing and boilerplate to support the
compositor's use of GraphicsContext3D. A number of extensions, etc, only make sense for a compositor context.
Since the compositor doesn't use GC3D any more, these are no longer needed.

* platform/chromium/support/Extensions3DChromium.cpp:
* platform/chromium/support/GraphicsContext3DChromium.cpp:
(WebCore::GraphicsContext3D::~GraphicsContext3D):
(WebCore::GraphicsContext3D::create):
* platform/chromium/support/GraphicsContext3DPrivate.cpp:
(WebCore::GraphicsContext3DPrivate::~GraphicsContext3DPrivate):
(WebCore::GraphicsContext3DPrivate::createGraphicsContextFromWebContext):
(WebCore::GrMemoryAllocationChangedCallbackAdapter::GrMemoryAllocationChangedCallbackAdapter):
(WebCore::GraphicsContext3DPrivate::grContext):
* platform/chromium/support/GraphicsContext3DPrivate.h:
(WebCore):
(GraphicsContext3DPrivate):
* platform/graphics/chromium/Extensions3DChromium.h:

Source/WebKit/chromium:

* tests/Canvas2DLayerBridgeTest.cpp:
(Canvas2DLayerBridgeTest::fullLifecycleTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Add the workaround of IOSurface-related corruption during readback on...
commit-queue@webkit.org [Tue, 26 Jun 2012 17:56:46 +0000 (17:56 +0000)]
[chromium] Add the workaround of IOSurface-related corruption during readback on Mac OS X.
https://bugs.webkit.org/show_bug.cgi?id=89797

Patch by Yasuhiro Matsuda <mazda@chromium.org> on 2012-06-26
Reviewed by James Robinson.

No new tests. This patch doesn't change behavior.

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::getFramebufferPixels):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agonrwt: broken for chromium on vista
dpranke@chromium.org [Tue, 26 Jun 2012 17:01:21 +0000 (17:01 +0000)]
nrwt: broken for chromium on vista
https://bugs.webkit.org/show_bug.cgi?id=89988

Reviewed by Tony Chang.

r121194 removed support for 'chromium-win-vista' as a separate
port, but this actually prevented the code from running on vista
at all, which is unduly harsh and broke the websocket tests on
the (non-webkit) chromium bots that are still running on vista.

It's probably good enough to pretend that vista is win7 instead;
some layout tests will still fail but at least things'll run.

* Scripts/webkitpy/layout_tests/port/chromium_win.py:
(ChromiumWinPort.determine_full_port_name):
* Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
(ChromiumWinTest.test_versions):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Native memory snapshots crash in debug mode.
commit-queue@webkit.org [Tue, 26 Jun 2012 16:30:49 +0000 (16:30 +0000)]
Web Inspector: Native memory snapshots crash in debug mode.
https://bugs.webkit.org/show_bug.cgi?id=89977

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-06-26
Reviewed by Yury Semikhatsky.

* bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::maybeDOMWrapper):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Fix incorrect #ifdef WEBKIT_IMPLEMENTATION statements
shawnsingh@chromium.org [Tue, 26 Jun 2012 16:20:07 +0000 (16:20 +0000)]
[chromium] Fix incorrect #ifdef WEBKIT_IMPLEMENTATION statements
https://bugs.webkit.org/show_bug.cgi?id=89931

Reviewed by James Robinson.

WEBKIT_IMPLEMENTATION is defined as either 0 or 1, so the usage of
#ifdef or #if have different behavior. There are some places in
the code that use "#ifdef WEBKIT_IMLPEMENTATION", but they should
actually be "#if WEBKIT_IMPLEMENTATION". This patch fixes those
#ifdef statements.

* public/WebTextRun.h:
(WebTextRun):
* public/linux/WebFontRenderStyle.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agomaster.cfg cleanup: Pass CheckOutSource instance instead of class to BuildStep.addStep
ossy@webkit.org [Tue, 26 Jun 2012 15:00:43 +0000 (15:00 +0000)]
cfg cleanup: Pass CheckOutSource instance instead of class to BuildStep.addStep
https://bugs.webkit.org/show_bug.cgi?id=89215

We need it because it is deprecated and will be dropped in buildbot 0.8.7

Reviewed by Tony Chang.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(CheckOutSource.__init__):
(Factory.__init__):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Baseline missing for 3D transforms tests.
commit-queue@webkit.org [Tue, 26 Jun 2012 14:39:59 +0000 (14:39 +0000)]
[Qt] Baseline missing for 3D transforms tests.
https://bugs.webkit.org/show_bug.cgi?id=89973

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-06-26
Reviewed by Csaba Osztrogonác.

Unskip the transforms/3d/hit-testing, and skip one failing transforms/3d/point-mapping test.
Add missing baselines for all unskipped 3D transforms tests.

* platform/qt/Skipped:
* platform/qt/transforms/3d/hit-testing/backface-hit-test-expected.txt: Added.
* platform/qt/transforms/3d/hit-testing/backface-no-transform-hit-test-expected.txt: Added.
* platform/qt/transforms/3d/point-mapping/3d-point-mapping-2-expected.txt: Added.
* platform/qt/transforms/3d/point-mapping/3d-point-mapping-3-expected.txt: Added.
* platform/qt/transforms/3d/point-mapping/3d-point-mapping-coplanar-expected.txt: Added.
* platform/qt/transforms/3d/point-mapping/3d-point-mapping-deep-expected.txt: Added.
* platform/qt/transforms/3d/point-mapping/3d-point-mapping-expected.txt: Added.
* platform/qt/transforms/3d/point-mapping/3d-point-mapping-overlapping-expected.txt: Added.
* platform/qt/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][Win] Symbols are not exported in QtWebKit5.dll
hausmann@webkit.org [Tue, 26 Jun 2012 14:01:12 +0000 (14:01 +0000)]
[Qt][Win] Symbols are not exported in QtWebKit5.dll
https://bugs.webkit.org/show_bug.cgi?id=88873

Reviewed by Tor Arne Vestbø.

Source/WebKit:

* api.pri: Remove MAKEDLL setting done now in win32/default_post.prf.

Tools:

When linking the target dll make sure to re-export the symbols from
the static libraries marked as export, with the help of a little python
script and a qmake extra compiler.

* Scripts/generate-win32-export-forwards: Added.
* qmake/mkspecs/features/win32/default_post.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Texmap] Bug fix typo about computing bytesPerLine in BitmapTextureGL.
commit-queue@webkit.org [Tue, 26 Jun 2012 13:09:25 +0000 (13:09 +0000)]
[Texmap] Bug fix typo about computing bytesPerLine in BitmapTextureGL.
https://bugs.webkit.org/show_bug.cgi?id=89924

"bytesPerLine == targetRect.width() / 4" is invalid.
This patch amended it into "bytesPerLine == targetRect.width() * 4".
Moreover, changed magic number 4 to bytesPerPixel.

Patch by Huang Dongsung <luxtella@company100.net> on 2012-06-26
Reviewed by Noam Rosenthal.

No new tests. Covered by existing tests.

* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::BitmapTextureGL::updateContents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoShader compiler unprepared to make ESSL output when GLES is used
commit-queue@webkit.org [Tue, 26 Jun 2012 13:07:17 +0000 (13:07 +0000)]
Shader compiler unprepared to make ESSL output when GLES is used
https://bugs.webkit.org/show_bug.cgi?id=87718

Patch by Roland Takacs <takacs.roland@stud.u-szeged.hu> on 2012-06-26
Reviewed by Noam Rosenthal.

Defined a new member that says what type of output code must be generated
(SH_GLSL_OUTPUT, SH_ESSL_OUTPUT). It is set within the constructor.

* platform/graphics/ANGLEWebKitBridge.cpp:
(WebCore::ANGLEWebKitBridge::ANGLEWebKitBridge):
(WebCore::ANGLEWebKitBridge::validateShaderSource):
* platform/graphics/ANGLEWebKitBridge.h:
(ANGLEWebKitBridge):
* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3D::GraphicsContext3D):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix bug where animations failed to start
pdr@google.com [Tue, 26 Jun 2012 12:56:13 +0000 (12:56 +0000)]
Fix bug where animations failed to start
https://bugs.webkit.org/show_bug.cgi?id=89943

Reviewed by Nikolas Zimmermann.

Source/WebCore:

The unpause code previously checked that the animations had not started
before un-setting the pause state. This meant that if an animation was
paused and unpaused before the animations started, it would remain in the
paused state. This patch simply reorders the unpause logic to fix this bug.

Test: svg/custom/animate-initial-pause-unpause.html

* svg/animation/SMILTimeContainer.cpp:
(WebCore::SMILTimeContainer::resume):

LayoutTests:

* svg/custom/animate-initial-pause-unpause-expected.txt: Added.
* svg/custom/animate-initial-pause-unpause.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Gardening of new passing tests
commit-queue@webkit.org [Tue, 26 Jun 2012 12:49:12 +0000 (12:49 +0000)]
[EFL] Gardening of new passing tests
https://bugs.webkit.org/show_bug.cgi?id=89970

Unreviewed gardening.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-06-26

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: popover is not shown for detached DOM nodes, not referenced directly...
yurys@chromium.org [Tue, 26 Jun 2012 12:32:38 +0000 (12:32 +0000)]
Web Inspector: popover is not shown for detached DOM nodes, not referenced directly from JS
https://bugs.webkit.org/show_bug.cgi?id=89955

Reviewed by Vsevolod Vlasov.

Show object popover for all heap snapshot nodes event for those whose
canBeQueried flag is false. We didn't show popover for such objects before
as it could lead to the backend crash. In the meantime the backend shouldn't
fail on such DOM wrappers and report an error if it cannot resolve
inspected object.

* inspector/front-end/HeapSnapshotGridNodes.js:
(WebInspector.HeapSnapshotGenericObjectNode):
(WebInspector.HeapSnapshotGenericObjectNode.prototype.get data):
* inspector/front-end/HeapSnapshotView.js:
(WebInspector.HeapSnapshotView.prototype._getHoverAnchor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Limit session storage quota to 5MB by default
commit-queue@webkit.org [Tue, 26 Jun 2012 12:17:41 +0000 (12:17 +0000)]
[BlackBerry] Limit session storage quota to 5MB by default
https://bugs.webkit.org/show_bug.cgi?id=89941

Patch by Jonathan Dong <jonathan.dong@torchmobile.com.cn> on 2012-06-26
Reviewed by Rob Buis.

Limit session storage quota to 5MB by default for BlackBerry
porting.
Internally reviewed by George Staikos.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::didChangeSettings):
* Api/WebSettings.cpp:
(WebKit):
(BlackBerry::WebKit::WebSettings::standardSettings):
(BlackBerry::WebKit::WebSettings::sessionStorageQuota):
(BlackBerry::WebKit::WebSettings::setSessionStorageQuota):
* Api/WebSettings.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Simplify SharedBuffer::createWithContentsOfFile() implementation
commit-queue@webkit.org [Tue, 26 Jun 2012 12:10:58 +0000 (12:10 +0000)]
[EFL] Simplify SharedBuffer::createWithContentsOfFile() implementation
https://bugs.webkit.org/show_bug.cgi?id=89655

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-06-26
Reviewed by Csaba Osztrogonác.

Simplify the implementation of SharedBuffer::createWithContentsOfFile()
in EFL port.

No new test, no behavior change.

* platform/efl/SharedBufferEfl.cpp:
(WebCore::SharedBuffer::createWithContentsOfFile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] REGRESSION (r121163): fast/frames/iframe-access-screen-of-deleted.html crashes
commit-queue@webkit.org [Tue, 26 Jun 2012 11:27:55 +0000 (11:27 +0000)]
[EFL] REGRESSION (r121163): fast/frames/iframe-access-screen-of-deleted.html crashes
https://bugs.webkit.org/show_bug.cgi?id=89964

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-06-26
Reviewed by Andreas Kling.

Added missing null pointer check.

* platform/efl/PlatformScreenEfl.cpp:
(WebCore::screenDepth):
(WebCore::screenDepthPerComponent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Assert failure in fast/canvas/canvas-createImageData.html for 64bit Debug bot
commit-queue@webkit.org [Tue, 26 Jun 2012 10:36:21 +0000 (10:36 +0000)]
[GTK] Assert failure in fast/canvas/canvas-createImageData.html for 64bit Debug bot
https://bugs.webkit.org/show_bug.cgi?id=89647

Unreviewed, update GTK test expectations.

r121215 has fixed the assertion failure, so the test doesn't crash
anymore.

Patch by Simon Pena <spena@igalia.com> on 2012-06-26

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Add requestMetadata command and metadataReceived event to FileSystem
kinuko@chromium.org [Tue, 26 Jun 2012 10:26:26 +0000 (10:26 +0000)]
Web Inspector: Add requestMetadata command and metadataReceived event to FileSystem
https://bugs.webkit.org/show_bug.cgi?id=87856

Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-06-26
Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: http/tests/inspector/filesystem/get-metadata.html

* inspector/Inspector.json:
* inspector/InspectorFileSystemAgent.cpp:
(WebCore):
(WebCore::InspectorFileSystemAgent::requestFileSystemRoot):
(WebCore::InspectorFileSystemAgent::requestDirectoryContent):
(WebCore::InspectorFileSystemAgent::requestMetadata):
* inspector/InspectorFileSystemAgent.h:
(InspectorFileSystemAgent):
* inspector/front-end/FileSystemModel.js:
(WebInspector.FileSystemModel.prototype._directoryContentReceived):
(WebInspector.FileSystemModel.prototype.requestMetadata):
(WebInspector.FileSystemModel.Entry.prototype.get isDirectory):
(WebInspector.FileSystemModel.Entry.prototype.requestMetadata):
(WebInspector.FileSystemRequestManager):
(WebInspector.FileSystemRequestManager.prototype._directoryContentReceived):
(WebInspector.FileSystemRequestManager.prototype.requestMetadata.requestAccepted):
(WebInspector.FileSystemRequestManager.prototype.requestMetadata):
(WebInspector.FileSystemRequestManager.prototype._metadataReceived):
(WebInspector.FileSystemDispatcher.prototype.directoryContentReceived):
(WebInspector.FileSystemDispatcher.prototype.metadataReceived):

LayoutTests:

* http/tests/inspector/filesystem/filesystem-test.js:
(initialize_FileSystemTest.InspectorTest.writeFile):
(initialize_FileSystemTest.InspectorTest.dumpMetadataRequestResult):
(initialize_FileSystemTest):
(writeFile.didGetFileSystem):
(writeFile):
(writeFile.didGetWriter.writer.onwrite):
(writeFile.didGetWriter):
* http/tests/inspector/filesystem/get-metadata-expected.txt: Added.
* http/tests/inspector/filesystem/get-metadata.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] GraphicsSurface: Fix tile update artifacts on Mac
jocelyn.turcotte@nokia.com [Tue, 26 Jun 2012 10:19:20 +0000 (10:19 +0000)]
[Qt] GraphicsSurface: Fix tile update artifacts on Mac
https://bugs.webkit.org/show_bug.cgi?id=89887

Reviewed by Noam Rosenthal.

* platform/graphics/surfaces/mac/GraphicsSurfaceMac.cpp:
(WebCore::GraphicsSurface::platformCopyToGLTexture):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoGraphicsSurface: Fix IOSurfaceLock failures on Intel video cards.
jocelyn.turcotte@nokia.com [Tue, 26 Jun 2012 10:17:44 +0000 (10:17 +0000)]
GraphicsSurface: Fix IOSurfaceLock failures on Intel video cards.
https://bugs.webkit.org/show_bug.cgi?id=89883

Reviewed by Noam Rosenthal.

Follow the documentation which says: "If locking the buffer requires a readback,
the lock will fail with an error return of kIOReturnCannotLock."
Also make sure that we use the same set of flags when locking and unlocking
for simplicity and to follow this requirement on the kIOSurfaceLockReadOnly flag.

* platform/graphics/surfaces/mac/GraphicsSurfaceMac.cpp:
(WebCore::GraphicsSurface::platformLock):
(WebCore::GraphicsSurface::platformUnlock):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd a note about hostname completion not working well with --cc completion
jocelyn.turcotte@nokia.com [Tue, 26 Jun 2012 10:16:05 +0000 (10:16 +0000)]
Add a note about hostname completion not working well with --cc completion

Reviewed by Simon Hausmann.

Hostname completion tries to resolve anything after an @ sign which is present
in the completed list of contributor emails to CC.

* Scripts/webkit-tools-completion.sh:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r121244.
ossy@webkit.org [Tue, 26 Jun 2012 10:11:28 +0000 (10:11 +0000)]
Unreviewed, rolling out r121244.
http://trac.webkit.org/changeset/121244
https://bugs.webkit.org/show_bug.cgi?id=89966

skip list path is incorrect now. (Requested by Ossy on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-26

* Scripts/webkitpy/layout_tests/port/qt.py:
(QtPort.baseline_search_path):
(QtPort._skipped_file_search_paths):
* Scripts/webkitpy/layout_tests/port/qt_unittest.py:
(QtPortTest.test_baseline_search_path):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix setCurrentTime for paused animations
pdr@google.com [Tue, 26 Jun 2012 10:06:34 +0000 (10:06 +0000)]
Fix setCurrentTime for paused animations
https://bugs.webkit.org/show_bug.cgi?id=81350

Reviewed by Nikolas Zimmermann.

Source/WebCore:

SMILTimeContainer::setElapsed was not resetting the pause time, breaking
setCurrentTime if the animation was paused.

Test: svg/custom/animate-pause-resume.html

* svg/animation/SMILTimeContainer.cpp:
(WebCore::SMILTimeContainer::setElapsed):

LayoutTests:

This test does not use the SVG animation test framework because the framework
works by pausing animations and testing animated values at fixed times
(through calling setCurrentTime). Testing this patch requires that we run
the animation and cannot be tested with the animation test framework.

* svg/custom/animate-pause-resume-expected.txt: Added.
* svg/custom/animate-pause-resume.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Use gesture SwipeDown to exit fullscreen for both video and plugin.
charles.wei@torchmobile.com.cn [Tue, 26 Jun 2012 10:04:40 +0000 (10:04 +0000)]
[BlackBerry] Use gesture SwipeDown to exit fullscreen for both video and plugin.
https://bugs.webkit.org/show_bug.cgi?id=89960

Reviewed by Antonio Gomes.

We used to use gesture swipedown to exit fullscreen for plugin, but not fullscreen
HTML5 video; When a swipe down happens, it applies this event to all the pluginviews
in a page, even though only the one in fullscreen mode will process this.

With this patch, the SwipeDown gesture will only apply to the fullscreen elemement,
which is either a plugin, or an Video element.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::notifySwipeEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][NRWT] Fix baseline and skipped file search path.
commit-queue@webkit.org [Tue, 26 Jun 2012 09:42:06 +0000 (09:42 +0000)]
[Qt][NRWT] Fix baseline and skipped file search path.
https://bugs.webkit.org/show_bug.cgi?id=89882

Patch by János Badics <jbadics@inf.u-szeged.hu> on 2012-06-26
Reviewed by Csaba Osztrogonác.

* Scripts/webkitpy/layout_tests/port/qt.py:
(QtPort.baseline_search_path):
* Scripts/webkitpy/layout_tests/port/qt_unittest.py:
(QtPortTest.test_baseline_search_path):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNew fast/js/dfg-store-unexpected-value-into-argument-and-osr-exit.html fails on 32 bit
fpizlo@apple.com [Tue, 26 Jun 2012 09:22:45 +0000 (09:22 +0000)]
New fast/js/dfg-store-unexpected-value-into-argument-and-osr-exit.html fails on 32 bit
https://bugs.webkit.org/show_bug.cgi?id=89953

Reviewed by Zoltan Herczeg.

DFG 32-bit JIT was confused about the difference between a predicted type and a
proven type. This is easy to get confused about, since a local that is predicted int32
almost always means that the local must be an int32 since speculations are hoisted to
stores to locals. But that is less likely to be the case for arguments, where there is
an additional least-upper-bounding step: any store to an argument with a weird type
may force the argument to be any type.

This patch basically duplicates the functionality in DFGSpeculativeJIT64.cpp for
GetLocal: the decision of whether to load a local as an int32 (or as an array, or as
a boolean) is made based on the AbstractValue::m_type, which is a type proof, rather
than the VariableAccessData::prediction(), which is a predicted type.

* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed typo fix after r121144.
ossy@webkit.org [Tue, 26 Jun 2012 09:21:20 +0000 (09:21 +0000)]
[Qt] Unreviewed typo fix after r121144.

* Target.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121242 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Enable grid layout LayoutTests
tony@chromium.org [Tue, 26 Jun 2012 09:11:58 +0000 (09:11 +0000)]
[Qt] Enable grid layout LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=89909

Reviewed by Csaba Osztrogonác.

Source/WebKit/qt:

These tests pass, we just need to hook up the overridePreference.

* Api/qwebsettings.cpp:
(QWebSettingsPrivate::apply):
(QWebSettings::QWebSettings):
* Api/qwebsettings.h: Add enum value for CSS grid layout

Tools:

These tests pass, we just need to hook up the overridePreference.

* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::WebPage::resetSettings): Reset grid layout and regions between tests.
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::overridePreference): Add WebKitCSSGridLayoutEnabled.

LayoutTests:

* platform/qt/Skipped: Enable fast/css-grid-layout tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: columns in heap snapshot summary view are not resizable
yurys@chromium.org [Tue, 26 Jun 2012 09:04:31 +0000 (09:04 +0000)]
Web Inspector: columns in heap snapshot summary view are not resizable
https://bugs.webkit.org/show_bug.cgi?id=89952

Reviewed by Vsevolod Vlasov.

* inspector/front-end/HeapSnapshotDataGrids.js:
(WebInspector.HeapSnapshotViewportDataGrid.prototype.onResize): overriden method
should call overriden one to make sure column resizers are added to the DataGrid.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r121236.
kkristof@inf.u-szeged.hu [Tue, 26 Jun 2012 08:25:11 +0000 (08:25 +0000)]
Unreviewed, rolling out r121236.
http://trac.webkit.org/changeset/121236
https://bugs.webkit.org/show_bug.cgi?id=89956

It's broke the nrwt on qt and gtk platform (Requested by
kkristof on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-26

* Scripts/webkitpy/layout_tests/port/qt.py:
(QtPort._build_driver):
* Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
(XvfbDriver._start):
(XvfbDriver._start.x_filter):
(XvfbDriver.stop):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed gardening after r120845.
mario@webkit.org [Tue, 26 Jun 2012 07:59:11 +0000 (07:59 +0000)]
Unreviewed gardening after r120845.
Update expectations for test crashing in the GTK 64bit debug bot.

* platform/gtk/TestExpectations: Add test to CRASHING section.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAllow using <input type="color"> UI in ChromeOS.
commit-queue@webkit.org [Tue, 26 Jun 2012 07:59:07 +0000 (07:59 +0000)]
Allow using <input type="color"> UI in ChromeOS.
https://bugs.webkit.org/show_bug.cgi?id=89944

Patch by Jun Mukai <mukai@chromium.org> on 2012-06-26
Reviewed by Kent Tamura.

http://crrev.com/144111 adds the UI of <input type="color"> for
ChromeOS, so now we can set its flag too.

* features.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121237 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[NRWT] XvfbDriver should choose the next free display
kkristof@inf.u-szeged.hu [Tue, 26 Jun 2012 07:55:26 +0000 (07:55 +0000)]
[NRWT] XvfbDriver should choose the next free display
https://bugs.webkit.org/show_bug.cgi?id=88414

Reviewed by Dirk Pranke.

* Scripts/webkitpy/layout_tests/port/qt.py:
(QtPort._driver_class):
* Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
(XvfbDriver.__init__):
(XvfbDriver._start):
(XvfbDriver._start.next_free_id):
(XvfbDriver.stop):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRefactoring: Simplify FormController interface
tkent@chromium.org [Tue, 26 Jun 2012 07:55:18 +0000 (07:55 +0000)]
Refactoring: Simplify FormController interface
https://bugs.webkit.org/show_bug.cgi?id=89951

Reviewed by Kentaro Hara.

- Remove FormController::hasStateForNewFormElements()
  takeStateForFormElement() can check the emptiness, and return an empty
  FormControlState.

- Change the argument of takeStateForFormElement()
  Passing just one HTMLFormControlElementWithState object instead of two
  AtomicStringImpl. This is a preparation to use
  HTMLFormControlElementWithState::form() in FormController.

No new tests. Just a refactoring.

* html/FormController.cpp:
(WebCore::FormController::takeStateForFormElement):
* html/FormController.h:
(FormController):
* html/HTMLFormControlElementWithState.cpp:
(WebCore::HTMLFormControlElementWithState::finishParsingChildren):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWheelEvent should inherit from MouseEvent
dominicc@chromium.org [Tue, 26 Jun 2012 07:41:32 +0000 (07:41 +0000)]
WheelEvent should inherit from MouseEvent
https://bugs.webkit.org/show_bug.cgi?id=76104

Reviewed by Kentaro Hara.

Source/WebCore:

The spec for WheelEvent is
<http://www.w3.org/TR/DOM-Level-3-Events/#webidl-events-WheelEvent>

Tests: fast/events/event-creation.html
       http://samples.msdn.microsoft.com/ietestcenter/dominheritance/showdominheritancetest.htm?Prototype_WheelEvent

* bindings/objc/PublicDOMInterfaces.h: Remove redundant MouseEvent API from WheelEvent
* bindings/scripts/CodeGeneratorObjC.pm: MouseEvents are Events
* dom/MouseEvent.h: Expose no-arg constructor to WheelEvent
* dom/WheelEvent.cpp:
(WebCore::WheelEvent::WheelEvent): Call MouseEvent superconstructor
(WebCore::WheelEvent::isMouseEvent): Existing callers use this just for
moves and clicks, ie the type is exactly MouseEvent.
* dom/WheelEvent.h: Extend MouseEvent
* dom/WheelEvent.idl: "

LayoutTests:

* fast/events/event-creation-expected.txt:
* fast/events/event-creation.html: Also check WheelEvent instanceof MouseEvent as well as UIEvent, Event

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[WK2][GTK] Uninitialized variable in TextCheckerGtk.cpp
commit-queue@webkit.org [Tue, 26 Jun 2012 07:24:03 +0000 (07:24 +0000)]
[WK2][GTK] Uninitialized variable in TextCheckerGtk.cpp
https://bugs.webkit.org/show_bug.cgi?id=89948

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-06-26
Reviewed by Martin Robinson.

Properly initialize didInitializeState in
TextChecker::state().

* UIProcess/gtk/TextCheckerGtk.cpp:
(WebKit::TextChecker::state):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoGet rid of firstItem and nextItem from HTMLCollection
rniwa@webkit.org [Tue, 26 Jun 2012 06:29:58 +0000 (06:29 +0000)]
Get rid of firstItem and nextItem from HTMLCollection
https://bugs.webkit.org/show_bug.cgi?id=89923

Reviewed by Andreas Kling.

Source/WebCore:

Removed HTMLCollection::firstItem and HTMLCollection::nextItem.
Also added hasAnyItem() and hasExactlyOneItem() to HTMLCollection so that named getter on Document
doesn't need to compute the full length before returning a HTMLCollection.

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::getDocumentLinks):
* bindings/js/JSDOMWindowCustom.cpp:
(WebCore::namedItemGetter):
* bindings/js/JSHTMLDocumentCustom.cpp:
(WebCore::JSHTMLDocument::nameGetter):
* bindings/v8/custom/V8DOMWindowCustom.cpp:
(WebCore::V8DOMWindow::namedPropertyGetter):
* bindings/v8/custom/V8HTMLDocumentCustom.cpp:
(WebCore::V8HTMLDocument::GetNamedProperty):
* dom/Document.cpp:
(WebCore::Document::openSearchDescriptionURL):
* html/HTMLCollection.cpp:
(WebCore::shouldIncludeChildren):
(WebCore::HTMLCollection::HTMLCollection):
(WebCore):
(WebCore::HTMLCollection::item):
* html/HTMLCollection.h:
(HTMLCollection):
(WebCore::HTMLCollection::hasAnyItem):
(WebCore::HTMLCollection::hasExactlyOneItem):
* html/HTMLMapElement.cpp:
(WebCore::HTMLMapElement::imageElement):

Source/WebKit/chromium:

Re-implement WebNodeCollection::firstItem() and WebNodeCollection::nextItem() in WebKit code
because we got rid of it from WebCore implementation.

This is an extremely poor API and we shouldn't be exposing it in the future.

* public/WebNodeCollection.h:
(WebKit::WebNodeCollection::WebNodeCollection):
(WebNodeCollection):
* src/WebNodeCollection.cpp:
(WebKit::WebNodeCollection::nextItem):
(WebKit::WebNodeCollection::firstItem):
* src/WebPageSerializerImpl.cpp:
(WebKit::WebPageSerializerImpl::collectTargetFrames):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoJavaScript resources have low priority when SVG is enabled
psolanki@apple.com [Tue, 26 Jun 2012 06:05:25 +0000 (06:05 +0000)]
JavaScript resources have low priority when SVG is enabled
https://bugs.webkit.org/show_bug.cgi?id=89932
<rdar://problem/11741325>

Reviewed by Adele Peterson.

r108785 inadvertently lowered the priority of JavaScript resources. Fix the code so we set
the correct priority for scripts. Also, move the code so that all ifdefs are together at the
bottom to make it a bit easier to read..

* loader/cache/CachedResource.cpp:
(WebCore::defaultPriorityForResourceType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed build fix: Don't do QT += widgets with Qt 4
hausmann@webkit.org [Tue, 26 Jun 2012 05:32:44 +0000 (05:32 +0000)]
Unreviewed build fix: Don't do QT += widgets with Qt 4

Source/WebKit:

* WebKit1.pro: This is already done in WebKit1.pri.

Source/WebKit/qt:

* examples/platformplugin/platformplugin.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd runtime flag to enable/disable CSS variables (in addition to existing compile...
macpherson@chromium.org [Tue, 26 Jun 2012 05:23:57 +0000 (05:23 +0000)]
Add runtime flag to enable/disable CSS variables (in addition to existing compile-time flag).
https://bugs.webkit.org/show_bug.cgi?id=89542

Reviewed by Dimitri Glazkov.

Source/WebCore:

Added fast/css/variables/build-supports-variables.html to test runtime flag in test environment.
Updated all other css variables tests to enable the runtime flag from JS.

* css/CSSParser.cpp:
(WebCore::CSSParserContext::CSSParserContext):
(WebCore::operator==):
(WebCore::CSSParser::cssVariablesEnabled):
(WebCore):
(WebCore::CSSParser::detectDashToken):
(WebCore::CSSParser::lex):
* css/CSSParser.h:
(CSSParser):
* css/CSSParserMode.h:
(CSSParserContext):
* page/Settings.h:
(Settings):
(WebCore::Settings::setCSSVariablesEnabled):
(WebCore::Settings::cssVariablesEnabled):

Source/WebKit/chromium:

* features.gypi:
* public/WebSettings.h:
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setExperimentalCSSVariablesEnabled):
(WebKit):
* src/WebSettingsImpl.h:
(WebSettingsImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Make it possible to build WebKit without QtWidgets
hausmann@webkit.org [Tue, 26 Jun 2012 04:47:14 +0000 (04:47 +0000)]
[Qt] Make it possible to build WebKit without QtWidgets
https://bugs.webkit.org/show_bug.cgi?id=78109

Reviewed by Tor Arne Vestbø.

.:

* Source/QtWebKit.pro: Don't build WK1 tests and examples if WK1 is disabled.
* Source/api.pri: Move WK1 sources away from here and use WEBKIT += webkit1 instead
* WebKit.pro: Add WK1 to SUBDIRS unless no_webkit1 is set.

Source/WebKit:

Moved WebKit1 sources into a separate static library. Only WK1
depends on QtWidgets.

* WebKit1.pri: Added.
* WebKit1.pro: Added.

Source/WebKit2:

* WebKit2.pri: Add missing WK2 specific dependencies.
* qt/MainQt.cpp: Do the QStyle initialization hook only if we are
compiling with QtWidgets support.
(WebKit):
(main):

Tools:

* Tools.pro: Disable various tools that depend on WK1.
* qmake/mkspecs/features/default_post.prf: Add WK1 as supported static lib in WEBKIT
* qmake/mkspecs/features/default_pre.prf: Disable WK1 if QtWidgets is not built.
* qmake/mkspecs/modules/webkit1.prf: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Add WebPluginScrollbar and WebPluginScrollbarClient stub implementations
enne@google.com [Tue, 26 Jun 2012 04:43:44 +0000 (04:43 +0000)]
[chromium] Add WebPluginScrollbar and WebPluginScrollbarClient stub implementations
https://bugs.webkit.org/show_bug.cgi?id=89928

Reviewed by Darin Fisher.

These classes are just typedef'd to be the non-Plugin version. The
next step is to change Chromium to use the Plugin version, then move
most of WebPluginScrollbar to a WebScrollbar in Platform to separate
out the base functionality, while providing the same top level API.

* WebKit.gyp:
* public/WebPluginScrollbar.h: Added.
(WebKit):
* public/WebPluginScrollbarClient.h: Added.
(WebKit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed build fix after r121223.
hausmann@webkit.org [Tue, 26 Jun 2012 04:41:25 +0000 (04:41 +0000)]
Unreviewed build fix after r121223.

Fix the --minimal Qt build, TextureMapperGL now requires WebGL to be enabled.

* Target.pri:
* WebCore.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Fill more data in device motion event
leo.yang@torchmobile.com.cn [Tue, 26 Jun 2012 04:31:48 +0000 (04:31 +0000)]
[BlackBerry] Fill more data in device motion event
https://bugs.webkit.org/show_bug.cgi?id=89857

Reviewed by Antonio Gomes.

Reviewed internally by Robin Cao.

Fill acceleration and rotation rate into DeviceMotionData.

* WebCoreSupport/DeviceMotionClientBlackBerry.cpp:
(DeviceMotionClientBlackBerry::onMotion):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] CCOverdrawMetrics should use the deviceViewportSize to count actual pixels
danakj@chromium.org [Tue, 26 Jun 2012 04:14:54 +0000 (04:14 +0000)]
[chromium] CCOverdrawMetrics should use the deviceViewportSize to count actual pixels
https://bugs.webkit.org/show_bug.cgi?id=89922

Reviewed by Adrienne Walker.

* platform/graphics/chromium/cc/CCOverdrawMetrics.cpp:
(WebCore::CCOverdrawMetrics::recordMetricsInternal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Texmap] Remove platform specific code in BitmapImageGL::updateContents by using
commit-queue@webkit.org [Tue, 26 Jun 2012 03:59:30 +0000 (03:59 +0000)]
[Texmap] Remove platform specific code in BitmapImageGL::updateContents by using
GraphicsContext3D::extractImageData.
https://bugs.webkit.org/show_bug.cgi?id=89867

Patch by Huang Dongsung <luxtella@company100.net> on 2012-06-25
Reviewed by Noam Rosenthal.

No new tests. Covered by existing tests.

* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore):
(WebCore::BitmapTextureGL::didReset):
(WebCore::BitmapTextureGL::updateContents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL][WK2] Include unistd.h in PlatformProcessIdentifier.h.
rakuco@webkit.org [Tue, 26 Jun 2012 03:46:14 +0000 (03:46 +0000)]
[EFL][WK2] Include unistd.h in PlatformProcessIdentifier.h.
https://bugs.webkit.org/show_bug.cgi?id=89804

Reviewed by Hajime Morita.

The pid_t typedef ends up coming from stdlib.h (indirectly via WTF
includes) on Mac and Linux, even though that is not mandated by
POSIX and breaks other platforms (such as FreeBSD). Fix that by
explicitly including unistd.h, which is where the typedef is
supposed to come from.

* Platform/PlatformProcessIdentifier.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[WK2][Qt][EFL] Extract common code from LayerTreeHostQt
commit-queue@webkit.org [Tue, 26 Jun 2012 03:41:27 +0000 (03:41 +0000)]
[WK2][Qt][EFL] Extract common code from LayerTreeHostQt
https://bugs.webkit.org/show_bug.cgi?id=89837

Patch by YoungTaeck Song <youngtaeck.song@samsung.com> on 2012-06-25
Reviewed by Noam Rosenthal.

Extract common code from LayerTreeHostQt to be used by both Qt and Efl.
I renamed LayerTreeHost to LayerTreeCoordinator, and these are moved under WebProcess/WebPage/LayerTreeCoordinator.
I Modified LayerTreeHostProxy to LayerTreeCoordinatorProxy too, Because LayerTreeHostProxy and LayerTreeHost were pair.
Also WebGraphicsLayer moved under that directory.

* CMakeLists.txt:
* DerivedSources.pri:
* GNUmakefile.list.am:
* Platform/CoreIPC/MessageID.h:
* Target.pri:
* UIProcess/API/qt/qquickwebpage.cpp:
(QQuickWebPagePrivate::paint):
(QQuickWebPage::updatePaintNode):
(QQuickWebPagePrivate::updateSize):
* UIProcess/DrawingAreaProxy.cpp:
(WebKit::DrawingAreaProxy::didReceiveLayerTreeCoordinatorProxyMessage):
* UIProcess/DrawingAreaProxy.h:
(WebKit):
(WebKit::DrawingAreaProxy::layerTreeCoordinatorProxy):
(DrawingAreaProxy):
* UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::DrawingAreaProxyImpl):
(WebKit::DrawingAreaProxyImpl::enterAcceleratedCompositingMode):
(WebKit::DrawingAreaProxyImpl::didReceiveLayerTreeCoordinatorProxyMessage):
(WebKit::DrawingAreaProxyImpl::setVisibleContentsRect):
* UIProcess/DrawingAreaProxyImpl.h:
(WebKit):
(DrawingAreaProxyImpl):
* UIProcess/LayerTreeCoordinatorProxy.cpp: Renamed from Source/WebKit2/UIProcess/LayerTreeHostProxy.cpp.
(WebKit):
(WebKit::LayerTreeCoordinatorProxy::LayerTreeCoordinatorProxy):
(WebKit::LayerTreeCoordinatorProxy::~LayerTreeCoordinatorProxy):
(WebKit::LayerTreeCoordinatorProxy::updateViewport):
(WebKit::LayerTreeCoordinatorProxy::dispatchUpdate):
(WebKit::LayerTreeCoordinatorProxy::createTileForLayer):
(WebKit::LayerTreeCoordinatorProxy::updateTileForLayer):
(WebKit::LayerTreeCoordinatorProxy::removeTileForLayer):
(WebKit::LayerTreeCoordinatorProxy::deleteCompositingLayer):
(WebKit::LayerTreeCoordinatorProxy::setRootCompositingLayer):
(WebKit::LayerTreeCoordinatorProxy::setCompositingLayerState):
(WebKit::LayerTreeCoordinatorProxy::setCompositingLayerChildren):
(WebKit::LayerTreeCoordinatorProxy::setCompositingLayerFilters):
(WebKit::LayerTreeCoordinatorProxy::didRenderFrame):
(WebKit::LayerTreeCoordinatorProxy::createDirectlyCompositedImage):
(WebKit::LayerTreeCoordinatorProxy::destroyDirectlyCompositedImage):
(WebKit::LayerTreeCoordinatorProxy::setContentsSize):
(WebKit::LayerTreeCoordinatorProxy::setVisibleContentsRect):
(WebKit::LayerTreeCoordinatorProxy::renderNextFrame):
(WebKit::LayerTreeCoordinatorProxy::didChangeScrollPosition):
(WebKit::LayerTreeCoordinatorProxy::syncCanvas):
(WebKit::LayerTreeCoordinatorProxy::purgeBackingStores):
* UIProcess/LayerTreeCoordinatorProxy.h: Renamed from Source/WebKit2/UIProcess/LayerTreeHostProxy.h.
(WebKit):
(LayerTreeCoordinatorProxy):
(WebKit::LayerTreeCoordinatorProxy::layerTreeRenderer):
* UIProcess/LayerTreeCoordinatorProxy.messages.in: Renamed from Source/WebKit2/UIProcess/LayerTreeHostProxy.messages.in.
* UIProcess/WebLayerTreeRenderer.cpp:
(WebKit::WebLayerTreeRenderer::WebLayerTreeRenderer):
(WebKit::WebLayerTreeRenderer::updateViewport):
(WebKit::WebLayerTreeRenderer::renderNextFrame):
(WebKit::WebLayerTreeRenderer::purgeBackingStores):
(WebKit::WebLayerTreeRenderer::detach):
* UIProcess/WebLayerTreeRenderer.h:
(WebKit):
(WebLayerTreeRenderer):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveMessage):
* WebKit2.pri:
* WebProcess/WebPage/DrawingArea.h:
(DrawingArea):
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::didReceiveLayerTreeCoordinatorMessage):
* WebProcess/WebPage/DrawingAreaImpl.h:
(DrawingAreaImpl):
* WebProcess/WebPage/LayerTreeCoordinator/LayerTreeCoordinator.cpp: Renamed from Source/WebKit2/WebProcess/WebPage/qt/LayerTreeHostQt.cpp.
(WebKit):
(WebKit::LayerTreeCoordinator::create):
(WebKit::LayerTreeCoordinator::~LayerTreeCoordinator):
(WebKit::LayerTreeCoordinator::LayerTreeCoordinator):
(WebKit::LayerTreeCoordinator::setLayerFlushSchedulingEnabled):
(WebKit::LayerTreeCoordinator::scheduleLayerFlush):
(WebKit::LayerTreeCoordinator::cancelPendingLayerFlush):
(WebKit::LayerTreeCoordinator::setShouldNotifyAfterNextScheduledLayerFlush):
(WebKit::LayerTreeCoordinator::setRootCompositingLayer):
(WebKit::LayerTreeCoordinator::invalidate):
(WebKit::LayerTreeCoordinator::setNonCompositedContentsNeedDisplay):
(WebKit::LayerTreeCoordinator::scrollNonCompositedContents):
(WebKit::LayerTreeCoordinator::forceRepaint):
(WebKit::LayerTreeCoordinator::sizeDidChange):
(WebKit::LayerTreeCoordinator::didInstallPageOverlay):
(WebKit::LayerTreeCoordinator::didUninstallPageOverlay):
(WebKit::LayerTreeCoordinator::setPageOverlayNeedsDisplay):
(WebKit::LayerTreeCoordinator::setPageOverlayOpacity):
(WebKit::LayerTreeCoordinator::flushPendingLayerChanges):
(WebKit::LayerTreeCoordinator::syncLayerState):
(WebKit::LayerTreeCoordinator::syncLayerChildren):
(WebKit::LayerTreeCoordinator::syncCanvas):
(WebKit::LayerTreeCoordinator::syncLayerFilters):
(WebKit::LayerTreeCoordinator::attachLayer):
(WebKit::LayerTreeCoordinator::detachLayer):
(WebKit::updateOffsetFromViewportForSelf):
(WebKit::updateOffsetFromViewportForLayer):
(WebKit::LayerTreeCoordinator::syncFixedLayers):
(WebKit::LayerTreeCoordinator::performScheduledLayerFlush):
(WebKit::LayerTreeCoordinator::layerFlushTimerFired):
(WebKit::LayerTreeCoordinator::createPageOverlayLayer):
(WebKit::LayerTreeCoordinator::destroyPageOverlayLayer):
(WebKit::LayerTreeCoordinator::adoptImageBackingStore):
(WebKit::LayerTreeCoordinator::releaseImageBackingStore):
(WebKit::LayerTreeCoordinator::notifyAnimationStarted):
(WebKit::LayerTreeCoordinator::notifySyncRequired):
(WebKit::LayerTreeCoordinator::paintContents):
(WebKit::LayerTreeCoordinator::showDebugBorders):
(WebKit::LayerTreeCoordinator::showRepaintCounter):
(WebKit::LayerTreeHost::supportsAcceleratedCompositing):
(WebKit::LayerTreeCoordinator::createTile):
(WebKit::LayerTreeCoordinator::updateTile):
(WebKit::LayerTreeCoordinator::removeTile):
(WebKit::LayerTreeCoordinator::visibleContentsRect):
(WebKit::LayerTreeCoordinator::setVisibleContentsRect):
(WebKit::LayerTreeCoordinator::renderNextFrame):
(WebKit::LayerTreeCoordinator::layerTreeTileUpdatesAllowed):
(WebKit::LayerTreeCoordinator::purgeBackingStores):
(WebKit::LayerTreeCoordinator::beginContentUpdate):
* WebProcess/WebPage/LayerTreeCoordinator/LayerTreeCoordinator.h: Renamed from Source/WebKit2/WebProcess/WebPage/qt/LayerTreeHostQt.h.
(WebKit):
(LayerTreeCoordinator):
(WebKit::LayerTreeCoordinator::layerTreeContext):
(WebKit::LayerTreeCoordinator::pageOverlayShouldApplyFadeWhenPainting):
(WebKit::LayerTreeCoordinator::pauseRendering):
(WebKit::LayerTreeCoordinator::resumeRendering):
(WebKit::LayerTreeCoordinator::deviceScaleFactorDidChange):
* WebProcess/WebPage/LayerTreeCoordinator/LayerTreeCoordinator.messages.in: Renamed from Source/WebKit2/WebProcess/WebPage/LayerTreeHost.messages.in.
* WebProcess/WebPage/LayerTreeCoordinator/WebGraphicsLayer.cpp: Renamed from Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.cpp.
(WebCore):
(WebCore::layerByIDMap):
(WebCore::WebGraphicsLayer::layerByID):
(WebCore::toWebLayerID):
(WebCore::WebGraphicsLayer::didChangeLayerState):
(WebCore::WebGraphicsLayer::didChangeChildren):
(WebCore::WebGraphicsLayer::didChangeFilters):
(WebCore::WebGraphicsLayer::setShouldUpdateVisibleRect):
(WebCore::WebGraphicsLayer::didChangeGeometry):
(WebCore::WebGraphicsLayer::WebGraphicsLayer):
(WebCore::WebGraphicsLayer::~WebGraphicsLayer):
(WebCore::WebGraphicsLayer::willBeDestroyed):
(WebCore::WebGraphicsLayer::setChildren):
(WebCore::WebGraphicsLayer::addChild):
(WebCore::WebGraphicsLayer::addChildAtIndex):
(WebCore::WebGraphicsLayer::addChildAbove):
(WebCore::WebGraphicsLayer::addChildBelow):
(WebCore::WebGraphicsLayer::replaceChild):
(WebCore::WebGraphicsLayer::removeFromParent):
(WebCore::WebGraphicsLayer::setPosition):
(WebCore::WebGraphicsLayer::setAnchorPoint):
(WebCore::WebGraphicsLayer::setSize):
(WebCore::WebGraphicsLayer::setTransform):
(WebCore::WebGraphicsLayer::setChildrenTransform):
(WebCore::WebGraphicsLayer::setPreserves3D):
(WebCore::WebGraphicsLayer::setMasksToBounds):
(WebCore::WebGraphicsLayer::setDrawsContent):
(WebCore::WebGraphicsLayer::setContentsOpaque):
(WebCore::WebGraphicsLayer::setBackfaceVisibility):
(WebCore::WebGraphicsLayer::setOpacity):
(WebCore::WebGraphicsLayer::setContentsRect):
(WebCore::WebGraphicsLayer::setContentsNeedsDisplay):
(WebCore::WebGraphicsLayer::setContentsToCanvas):
(WebCore::WebGraphicsLayer::setFilters):
(WebCore::WebGraphicsLayer::setContentsToImage):
(WebCore::WebGraphicsLayer::setMaskLayer):
(WebCore::WebGraphicsLayer::setReplicatedByLayer):
(WebCore::WebGraphicsLayer::setNeedsDisplay):
(WebCore::WebGraphicsLayer::setNeedsDisplayInRect):
(WebCore::WebGraphicsLayer::id):
(WebCore::WebGraphicsLayer::syncCompositingState):
(WebCore::toWebGraphicsLayer):
(WebCore::WebGraphicsLayer::syncChildren):
(WebCore::WebGraphicsLayer::syncFilters):
(WebCore::WebGraphicsLayer::syncLayerState):
(WebCore::WebGraphicsLayer::syncCanvas):
(WebCore::WebGraphicsLayer::ensureImageBackingStore):
(WebCore::WebGraphicsLayer::syncCompositingStateForThisLayerOnly):
(WebCore::WebGraphicsLayer::tiledBackingStorePaintBegin):
(WebCore::WebGraphicsLayer::setRootLayer):
(WebCore::WebGraphicsLayer::setVisibleContentRectTrajectoryVector):
(WebCore::WebGraphicsLayer::setContentsScale):
(WebCore::WebGraphicsLayer::effectiveContentsScale):
(WebCore::WebGraphicsLayer::adjustContentsScale):
(WebCore::WebGraphicsLayer::createBackingStore):
(WebCore::WebGraphicsLayer::tiledBackingStorePaint):
(WebCore::WebGraphicsLayer::tiledBackingStorePaintEnd):
(WebCore::WebGraphicsLayer::tiledBackingStoreUpdatesAllowed):
(WebCore::WebGraphicsLayer::tiledBackingStoreContentsRect):
(WebCore::WebGraphicsLayer::shouldUseTiledBackingStore):
(WebCore::WebGraphicsLayer::tiledBackingStoreVisibleRect):
(WebCore::WebGraphicsLayer::tiledBackingStoreBackgroundColor):
(WebCore::WebGraphicsLayer::beginContentUpdate):
(WebCore::WebGraphicsLayer::createTile):
(WebCore::WebGraphicsLayer::updateTile):
(WebCore::WebGraphicsLayer::removeTile):
(WebCore::WebGraphicsLayer::updateContentBuffers):
(WebCore::WebGraphicsLayer::purgeBackingStores):
(WebCore::WebGraphicsLayer::setWebGraphicsLayerClient):
(WebCore::WebGraphicsLayer::adjustVisibleRect):
(WebCore::WebGraphicsLayer::computeTransformedVisibleRect):
(WebCore::createWebGraphicsLayer):
(WebCore::WebGraphicsLayer::initFactory):
(WebCore::WebGraphicsLayer::selfOrAncestorHaveNonAffineTransforms):
* WebProcess/WebPage/LayerTreeCoordinator/WebGraphicsLayer.h: Renamed from Source/WebKit2/WebProcess/WebCoreSupport/WebGraphicsLayer.h.
(WebCore):
(WebKit):
(WebGraphicsLayerClient):
(WebGraphicsLayer):
(WebCore::WebGraphicsLayer::image):
(WebCore::WebGraphicsLayer::fixedToViewport):
(WebCore::WebGraphicsLayer::setFixedToViewport):
(WebCore::WebGraphicsLayer::maskTarget):
(WebCore::WebGraphicsLayer::setMaskTarget):
* WebProcess/WebPage/LayerTreeHost.cpp:
(WebKit::LayerTreeHost::create):
* WebProcess/WebPage/LayerTreeHost.h:
(LayerTreeHost):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::didReceiveMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121221 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Remove uncalled ManagedTexture::framebufferTexture2D
commit-queue@webkit.org [Tue, 26 Jun 2012 03:37:53 +0000 (03:37 +0000)]
[chromium] Remove uncalled ManagedTexture::framebufferTexture2D
https://bugs.webkit.org/show_bug.cgi?id=89930

Patch by James Robinson <jamesr@chromium.org> on 2012-06-25
Reviewed by Adrienne Walker.

Removing dead code.

* platform/graphics/chromium/ManagedTexture.cpp:
* platform/graphics/chromium/ManagedTexture.h:
(ManagedTexture):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121220 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Rolled DEPS.
commit-queue@webkit.org [Tue, 26 Jun 2012 03:28:53 +0000 (03:28 +0000)]
Unreviewed.  Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-25

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121219 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoJSC should try to make profiling deterministic because otherwise reproducing failures is
fpizlo@apple.com [Tue, 26 Jun 2012 02:53:39 +0000 (02:53 +0000)]
JSC should try to make profiling deterministic because otherwise reproducing failures is
nearly impossible
https://bugs.webkit.org/show_bug.cgi?id=89940

Rubber stamped by Gavin Barraclough.

This rolls out the part of http://trac.webkit.org/changeset/121215 that introduced randomness
into the system. Now, instead of randomizing the tier-up threshold, we always set it to an
artificially low (and statically predetermined!) value. This gives most of the benefit of
threshold randomization without actually making the system behave completely differently on
each invocation.

* bytecode/ExecutionCounter.cpp:
(JSC::ExecutionCounter::setThreshold):
* runtime/Options.cpp:
(Options):
(JSC::Options::initializeOptions):
* runtime/Options.h:
(Options):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r121206.
commit-queue@webkit.org [Tue, 26 Jun 2012 02:52:11 +0000 (02:52 +0000)]
Unreviewed, rolling out r121206.
http://trac.webkit.org/changeset/121206
https://bugs.webkit.org/show_bug.cgi?id=89935

[chromium] webkit_unit_tests
WebViewTest.MHTMLWithMissingResourceFinishesLoading crash
(Requested by ukai on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-25

Source/WebCore:

* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::scheduleArchiveLoad):

Source/WebKit/chromium:

* tests/EventListenerTest.cpp:
* tests/FrameTestHelpers.cpp:
(WebKit::FrameTestHelpers::registerMockedURLLoad):
(WebKit::FrameTestHelpers::createWebViewAndLoad):
* tests/FrameTestHelpers.h:
(FrameTestHelpers):
* tests/ListenerLeakTest.cpp:
(WebKit::ListenerLeakTest::RunTest):
* tests/WebFrameTest.cpp:
(WebKit::WebFrameTest::registerMockedHttpURLLoad):
(WebKit::WebFrameTest::registerMockedChromeURLLoad):
* tests/WebViewTest.cpp:
(WebKit::TEST_F):
(WebKit::WebViewTest::testAutoResize):
(WebKit::WebViewTest::testTextInputType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, update chromium test expectations.
ukai@chromium.org [Tue, 26 Jun 2012 02:28:35 +0000 (02:28 +0000)]
Unreviewed, update chromium test expectations.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoValue profiling should use tier-up threshold randomization to get more coverage
fpizlo@apple.com [Tue, 26 Jun 2012 02:14:07 +0000 (02:14 +0000)]
Value profiling should use tier-up threshold randomization to get more coverage
https://bugs.webkit.org/show_bug.cgi?id=89802

Source/JavaScriptCore:

Reviewed by Gavin Barraclough.

This patch causes both LLInt and Baseline JIT code to take the OSR slow path several
times before actually doing OSR. If we take the OSR slow path before the execution
count threshold is reached, then we just call CodeBlock::updateAllPredictions() to
compute the current latest least-upper-bound SpecType of all values seen in each
ValueProfile.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::stronglyVisitStrongReferences):
(JSC::CodeBlock::updateAllPredictionsAndCountLiveness):
(JSC):
(JSC::CodeBlock::updateAllPredictions):
(JSC::CodeBlock::shouldOptimizeNow):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::llintExecuteCounter):
(JSC::CodeBlock::jitExecuteCounter):
(CodeBlock):
(JSC::CodeBlock::updateAllPredictions):
* bytecode/ExecutionCounter.cpp:
(JSC::ExecutionCounter::setThreshold):
(JSC::ExecutionCounter::status):
(JSC):
* bytecode/ExecutionCounter.h:
(JSC::ExecutionCounter::count):
(ExecutionCounter):
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGOperations.cpp:
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* llint/LLIntSlowPaths.cpp:
(JSC::LLInt::jitCompileAndSetHeuristics):
(JSC::LLInt::entryOSR):
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::JSGlobalObject):
(JSC):
* runtime/JSGlobalObject.h:
(JSGlobalObject):
(JSC::JSGlobalObject::weakRandomInteger):
* runtime/Options.cpp:
(Options):
(JSC::Options::initializeOptions):
* runtime/Options.h:
(Options):
* runtime/WeakRandom.h:
(WeakRandom):
(JSC::WeakRandom::seedUnsafe):

LayoutTests:

Reviewed by Gavin Barraclough.

* fast/js/dfg-store-unexpected-value-into-argument-and-osr-exit-expected.txt: Added.
* fast/js/dfg-store-unexpected-value-into-argument-and-osr-exit.html: Added.
* fast/js/script-tests/dfg-store-unexpected-value-into-argument-and-osr-exit.js: Added.
(foo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121215 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Ensure that the compositor code which is aware of flipped status of video...
commit-queue@webkit.org [Tue, 26 Jun 2012 02:02:32 +0000 (02:02 +0000)]
[chromium] Ensure that the compositor code which is aware of flipped status of video-textures
per platform executes on Windows.
https://bugs.webkit.org/show_bug.cgi?id=89914

Patch by Anantanarayanan G Iyengar <ananta@chromium.org> on 2012-06-25
Reviewed by James Robinson.

No new tests. (HW video decode is still only being tested manually for orientation)

* platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore::CCVideoLayerImpl::appendQuads):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Let the embedder override the max page scale factor set by the page
abarth@webkit.org [Tue, 26 Jun 2012 01:59:57 +0000 (01:59 +0000)]
[Chromium] Let the embedder override the max page scale factor set by the page
https://bugs.webkit.org/show_bug.cgi?id=89406

Reviewed by James Robinson.

Chrome on Android has an option to force the web site to allow page
scaling (for accessibility). This patch adds
WebView::setIgnoreViewportTagMaximumScale, which instructs the WebView
to ignore the maximum scale factor supplied by by the page in the
viewport meta tag.

This patch is a bit different from how this is implemented on the
chromium-android branch, but I'll clean up the branch once this patch
lands.

* public/WebView.h:
(WebView):
* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::dispatchViewportPropertiesDidChange):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::setIgnoreViewportTagMaximumScale):
(WebKit):
* src/WebViewImpl.h:
(WebViewImpl):
(WebKit::WebViewImpl::ignoreViewportTagMaximumScale):
* tests/WebFrameTest.cpp:
(WebKit::TEST_F):
(WebKit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r121176.
commit-queue@webkit.org [Tue, 26 Jun 2012 01:57:37 +0000 (01:57 +0000)]
Unreviewed, rolling out r121176.
http://trac.webkit.org/changeset/121176
https://bugs.webkit.org/show_bug.cgi?id=89934

[chromium] browser_tests assert failed:
FATAL:native_theme_win.cc(1541)] Check failed: false. Invalid
part: 16 (Requested by ukai on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-06-25

Source/Platform:

* chromium/public/win/WebThemeEngine.h:
(WebKit::WebThemeEngine::paintProgressBar):

Source/WebCore:

* platform/chromium/PlatformSupport.h:
(PlatformSupport):
* platform/chromium/ScrollbarThemeChromiumWin.cpp:
(WebCore::ScrollbarThemeChromiumWin::buttonSize):

Source/WebKit/chromium:

* src/PlatformSupport.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Shadow] Deleting list distributed to Shadow DOM does not work correctly.
shinyak@chromium.org [Tue, 26 Jun 2012 01:49:11 +0000 (01:49 +0000)]
[Shadow] Deleting list distributed to Shadow DOM does not work correctly.
https://bugs.webkit.org/show_bug.cgi?id=89170

Reviewed by Ryosuke Niwa.

Source/WebCore:

When deleting several elements distributed to Shadow DOM, some renderers might be gone in
processing deletion. To fix them, we should call isContentEditable() instead of rendererIsEditable().

Test: editing/shadow/delete-list-in-shadow.html

* editing/DeleteFromTextNodeCommand.cpp:
(WebCore::DeleteFromTextNodeCommand::doApply):

LayoutTests:

* editing/shadow/delete-list-in-shadow-expected.txt: Added.
* editing/shadow/delete-list-in-shadow.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Fix the css stylesheet for android media controls after recent changes
commit-queue@webkit.org [Tue, 26 Jun 2012 01:34:36 +0000 (01:34 +0000)]
[Chromium] Fix the css stylesheet for android media controls after recent changes
https://bugs.webkit.org/show_bug.cgi?id=89910

Patch by Min Qin <qinmin@chromium.org> on 2012-06-25
Reviewed by Adam Barth.

After the recent changes on upstream chrome video controls, we need to change the css style sheet for chrome on android.
No tests needed, just css changes.

* css/mediaControlsChromiumAndroid.css:
(audio):
(audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):
(::-webkit-media-controls):
(audio::-webkit-media-controls-enclosure, video::-webkit-media-controls-enclosure):
(video::-webkit-media-controls-enclosure):
(audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button):
(audio::-webkit-media-controls-play-button, video::-webkit-media-controls-play-button):
(audio::-webkit-media-controls-time-remaining-display, video::-webkit-media-controls-time-remaining-display):
(audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline):
(video::-webkit-media-controls-fullscreen-button):
(input[type="range"]::-webkit-media-slider-container):
(input[type="range"]::-webkit-media-slider-thumb):
(audio::-webkit-media-controls-fullscreen-button):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Avoid a deep copy of QImage in GraphicsContext3D::getImageData.
commit-queue@webkit.org [Tue, 26 Jun 2012 01:30:19 +0000 (01:30 +0000)]
[Qt] Avoid a deep copy of QImage in GraphicsContext3D::getImageData.
https://bugs.webkit.org/show_bug.cgi?id=89865

Patch by Huang Dongsung <luxtella@company100.net> on 2012-06-25
Reviewed by Noam Rosenthal.

No new tests. Covered by existing tests.

* platform/graphics/qt/GraphicsContext3DQt.cpp:
(WebCore::GraphicsContext3D::getImageData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoReduce memory footprint of BitmapImage Vectors.
commit-queue@webkit.org [Tue, 26 Jun 2012 01:26:17 +0000 (01:26 +0000)]
Reduce memory footprint of BitmapImage Vectors.
https://bugs.webkit.org/show_bug.cgi?id=86563

Patch by Nick Carter <nick@chromium.org> on 2012-06-25
Reviewed by Simon Fraser.

No new tests, affects template params only.

* platform/graphics/BitmapImage.h:
(BitmapImage): use an inline capacity of 1 for the image frame Vector
* platform/image-decoders/ImageDecoder.h:
(ImageDecoder): use an inline capacity of 1 for the image frame Vector

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r121145.
tkent@chromium.org [Tue, 26 Jun 2012 01:20:05 +0000 (01:20 +0000)]
Unreviewed, rolling out r121145.
http://trac.webkit.org/changeset/121145
https://bugs.webkit.org/show_bug.cgi?id=89847

Had an objection for the change.

Source/WebCore:

* html/FormController.cpp:
(WebCore):
(WebCore::FormControlState::serializeTo):
(WebCore::FormControlState::deserialize):
(WebCore::formStateSignature):
(WebCore::FormController::formElementsState):
(WebCore::FormController::setStateForNewFormElements):
* html/FormController.h:
(FormControlState):
* html/shadow/CalendarPickerElement.cpp:
(WebCore::addJavaScriptString):

Source/WTF:

* wtf/text/StringBuilder.h:

LayoutTests:

* fast/forms/state-restore-broken-state-expected.txt:
* fast/forms/state-restore-various-values-expected.txt: Removed.
* fast/forms/state-restore-various-values.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix progress load reporting for MHTML documents.
jcivelli@chromium.org [Tue, 26 Jun 2012 01:12:06 +0000 (01:12 +0000)]
Fix progress load reporting for MHTML documents.

MHTML documents containing references to resources they don't include
never finish loading.
https://bugs.webkit.org/show_bug.cgi?id=71859

Reviewed by Nate Chapin.

Source/WebCore:

* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::scheduleArchiveLoad):

Source/WebKit/chromium:

* tests/EventListenerTest.cpp:
* tests/FrameTestHelpers.cpp:
(FrameTestHelpers):
(WebKit::FrameTestHelpers::registerMockedURLLoad):
(WebKit::FrameTestHelpers::registerMockedURLLoadAsHTML):
(WebKit::FrameTestHelpers::createWebViewAndLoad):
* tests/FrameTestHelpers.h:
(FrameTestHelpers):
* tests/ListenerLeakTest.cpp:
(WebKit::ListenerLeakTest::RunTest):
* tests/WebFrameTest.cpp:
(WebKit::WebFrameTest::registerMockedHttpURLLoad):
(WebKit::WebFrameTest::registerMockedChromeURLLoad):
* tests/WebViewTest.cpp:
(WebKit::TEST_F):
(WebKit::WebViewTest::testAutoResize):
(WebKit::WebViewTest::testTextInputType):
(TestWebViewClient):
(WebKit::TestWebViewClient::TestWebViewClient):
(WebKit::TestWebViewClient::didStartLoading):
(WebKit::TestWebViewClient::didStopLoading):
(WebKit::TestWebViewClient::didChangeLoadProgress):
(WebKit::TestWebViewClient::loadingStarted):
(WebKit::TestWebViewClient::loadingStopped):
(WebKit::TestWebViewClient::loadProgress):
(WebKit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoput vista back for chromium (non-webkit) bots ...
dpranke@chromium.org [Tue, 26 Jun 2012 00:56:41 +0000 (00:56 +0000)]
put vista back for chromium (non-webkit) bots ...
https://bugs.webkit.org/show_bug.cgi?id=89929

Unreviewed, build fix.

Turns out we've only gotten rid of vista on the webkit tests so
far. Put vista back for the other chromium bots ...

* TestResultServer/static-dashboards/flakiness_dashboard.js:
(chromiumPlatform):
* TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
(test):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Use WebGraphicsContext3D in compositor implementation
jamesr@google.com [Tue, 26 Jun 2012 00:55:55 +0000 (00:55 +0000)]
[chromium] Use WebGraphicsContext3D in compositor implementation
https://bugs.webkit.org/show_bug.cgi?id=89700

Reviewed by Adrienne Walker.

Source/Platform:

Puts all callback destructors in protected section and removes obsolete memory callback signature.

* chromium/public/WebGraphicsContext3D.h:
(WebGraphicsContextLostCallback):
(WebGraphicsErrorMessageCallback):
(WebGraphicsSwapBuffersCompleteCallbackCHROMIUM):
(WebGraphicsMemoryAllocationChangedCallbackCHROMIUM):

Source/WebCore:

This converts the compositor implementation from using WebCore::GraphicsContext3D to using the Platform-provided
WebGraphicsContext3D. This removes several unnecessary layers of indirection/wrapping and cuts down the
compositor's implementation dependencies. GraphicsContext3D.h is still widely used to provide GL enum values.
Most of the changes are purely mechanical - changing type names and the like.

Ownership is changed a bit. Instead of multiple components holding references to the compositor's context, the
context is now owned by the CCGraphicsContext, which is now owned directly by CCLayerTreeHostImpl.
CCLayerTreeHostImpl also has ownership of its CCRenderer (LayerRendererChromium in 3D mode) and passes a
non-owning pointer down to the CCRenderer.

Extension checking is a bit different. The compositor does not (and never has) used extensions provided by
WebGL's request/ensure mechanism. It simply checks for the existence of extensions it needs in the GL_EXTENSIONS
string.

FrameBufferSkPictureCanvasLayerTextureUpdater had to be patched as well, since it was grabbing a GrContext off
of the compositor's GraphicsContext3D. This caused many problems. It was inefficient, since it required a full
state flush when switching between ganesh and compositor calls. The gpu memory management was completely broken
since the compositor clobbered ganesh's onMemoryAllocationChanged callback. This moves FBSkPCLTU over to using
the appropriate SharedGraphicsContext3D, like filters.

* platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.cpp:
(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::Texture::updateRect):
(WebCore::FrameBufferSkPictureCanvasLayerTextureUpdater::updateTextureRect):
* platform/graphics/chromium/FrameBufferSkPictureCanvasLayerTextureUpdater.h:
(FrameBufferSkPictureCanvasLayerTextureUpdater):
* platform/graphics/chromium/GeometryBinding.cpp:
(WebCore::GeometryBinding::GeometryBinding):
* platform/graphics/chromium/GeometryBinding.h:
(WebKit):
(GeometryBinding):
(WebCore::GeometryBinding::context):
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::create):
(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::initialize):
(WebCore::LayerRendererChromium::~LayerRendererChromium):
(WebCore::LayerRendererChromium::context):
(WebCore::LayerRendererChromium::debugGLCall):
(WebCore::LayerRendererChromium::setVisible):
(WebCore::LayerRendererChromium::drawStreamVideoQuad):
(WebCore::LayerRendererChromium::drawHeadsUpDisplay):
(WebCore::LayerRendererChromium::swapBuffers):
(WebCore::LayerRendererChromium::onMemoryAllocationChanged):
(WebCore):
(WebCore::LayerRendererChromium::onMemoryAllocationChangedOnImplThread):
(WebCore::LayerRendererChromium::discardFramebuffer):
(WebCore::LayerRendererChromium::ensureFramebuffer):
(WebCore::LayerRendererChromium::onContextLost):
(WebCore::LayerRendererChromium::getFramebufferPixels):
(WebCore::LayerRendererChromium::getFramebufferTexture):
(WebCore::LayerRendererChromium::bindFramebufferToTexture):
(WebCore::LayerRendererChromium::initializeSharedObjects):
(WebCore::LayerRendererChromium::tileCheckerboardProgram):
(WebCore::LayerRendererChromium::solidColorProgram):
(WebCore::LayerRendererChromium::headsUpDisplayProgram):
(WebCore::LayerRendererChromium::renderPassProgram):
(WebCore::LayerRendererChromium::renderPassProgramAA):
(WebCore::LayerRendererChromium::renderPassMaskProgram):
(WebCore::LayerRendererChromium::renderPassMaskProgramAA):
(WebCore::LayerRendererChromium::tileProgram):
(WebCore::LayerRendererChromium::tileProgramOpaque):
(WebCore::LayerRendererChromium::tileProgramAA):
(WebCore::LayerRendererChromium::tileProgramSwizzle):
(WebCore::LayerRendererChromium::tileProgramSwizzleOpaque):
(WebCore::LayerRendererChromium::tileProgramSwizzleAA):
(WebCore::LayerRendererChromium::textureProgram):
(WebCore::LayerRendererChromium::textureProgramFlip):
(WebCore::LayerRendererChromium::textureIOSurfaceProgram):
(WebCore::LayerRendererChromium::videoYUVProgram):
(WebCore::LayerRendererChromium::videoStreamTextureProgram):
(WebCore::LayerRendererChromium::cleanupSharedObjects):
(WebCore::LayerRendererChromium::isContextLost):
* platform/graphics/chromium/LayerRendererChromium.h:
(WebKit):
(WebCore):
(LayerRendererChromium):
(WebCore::LayerRendererChromium::isFramebufferDiscarded):
* platform/graphics/chromium/LayerTextureSubImage.cpp:
(WebCore::LayerTextureSubImage::uploadWithTexSubImage):
(WebCore::LayerTextureSubImage::uploadWithMapTexSubImage):
* platform/graphics/chromium/ManagedTexture.cpp:
(WebCore::ManagedTexture::bindTexture):
(WebCore::ManagedTexture::framebufferTexture2D):
* platform/graphics/chromium/PlatformColor.h:
(WebCore::PlatformColor::bestTextureFormat):
* platform/graphics/chromium/ProgramBinding.cpp:
(WebCore::contextLost):
(WebCore::ProgramBindingBase::init):
(WebCore::ProgramBindingBase::cleanup):
(WebCore::ProgramBindingBase::loadShader):
(WebCore::ProgramBindingBase::createShaderProgram):
* platform/graphics/chromium/ProgramBinding.h:
(WebKit):
(ProgramBindingBase):
(WebCore::ProgramBinding::ProgramBinding):
(WebCore::ProgramBinding::initialize):
* platform/graphics/chromium/ShaderChromium.cpp:
(WebCore::VertexShaderPosTex::init):
(WebCore::VertexShaderPosTexYUVStretch::init):
(WebCore::VertexShaderPos::init):
(WebCore::VertexShaderPosTexTransform::init):
(WebCore::VertexShaderQuad::init):
(WebCore::VertexShaderTile::init):
(WebCore::VertexShaderVideoTransform::init):
(WebCore::FragmentTexAlphaBinding::init):
(WebCore::FragmentTexOpaqueBinding::init):
(WebCore::FragmentShaderOESImageExternal::init):
(WebCore::FragmentShaderRGBATexAlphaAA::init):
(WebCore::FragmentTexClampAlphaAABinding::init):
(WebCore::FragmentShaderRGBATexAlphaMask::init):
(WebCore::FragmentShaderRGBATexAlphaMaskAA::init):
(WebCore::FragmentShaderYUVVideo::init):
(WebCore::FragmentShaderColor::init):
(WebCore::FragmentShaderCheckerboard::init):
* platform/graphics/chromium/ShaderChromium.h:
(WebKit):
(VertexShaderPosTex):
(VertexShaderPosTexYUVStretch):
(VertexShaderPos):
(WebCore::VertexShaderPosTexIdentity::init):
(VertexShaderPosTexTransform):
(VertexShaderQuad):
(VertexShaderTile):
(VertexShaderVideoTransform):
(FragmentTexAlphaBinding):
(FragmentTexOpaqueBinding):
(FragmentShaderOESImageExternal):
(FragmentShaderRGBATexAlphaAA):
(FragmentTexClampAlphaAABinding):
(FragmentShaderRGBATexAlphaMask):
(FragmentShaderRGBATexAlphaMaskAA):
(FragmentShaderYUVVideo):
(FragmentShaderColor):
(FragmentShaderCheckerboard):
* platform/graphics/chromium/TextureCopier.cpp:
(WebCore::AcceleratedTextureCopier::AcceleratedTextureCopier):
(WebCore::AcceleratedTextureCopier::~AcceleratedTextureCopier):
(WebCore::AcceleratedTextureCopier::copyTexture):
* platform/graphics/chromium/TextureCopier.h:
(WebKit):
(WebCore):
(WebCore::AcceleratedTextureCopier::create):
(AcceleratedTextureCopier):
* platform/graphics/chromium/TextureManager.h:
* platform/graphics/chromium/ThrottledTextureUploader.cpp:
(WebCore::ThrottledTextureUploader::Query::Query):
(WebCore::ThrottledTextureUploader::Query::~Query):
(WebCore::ThrottledTextureUploader::Query::begin):
(WebCore::ThrottledTextureUploader::Query::end):
(WebCore::ThrottledTextureUploader::Query::isPending):
(WebCore::ThrottledTextureUploader::Query::wait):
(WebCore::ThrottledTextureUploader::ThrottledTextureUploader):
* platform/graphics/chromium/ThrottledTextureUploader.h:
(WebKit):
(WebCore::ThrottledTextureUploader::create):
(WebCore::ThrottledTextureUploader::Query::create):
(Query):
(ThrottledTextureUploader):
* platform/graphics/chromium/TrackingTextureAllocator.cpp:
(WebCore::TrackingTextureAllocator::TrackingTextureAllocator):
(WebCore::TrackingTextureAllocator::createTexture):
(WebCore::TrackingTextureAllocator::deleteTexture):
(WebCore::TrackingTextureAllocator::deleteAllTextures):
* platform/graphics/chromium/TrackingTextureAllocator.h:
(WebKit):
(WebCore::TrackingTextureAllocator::create):
(TrackingTextureAllocator):
* platform/graphics/chromium/cc/CCGraphicsContext.h:
(CCGraphicsContext):
(WebCore::CCGraphicsContext::create2D):
(WebCore::CCGraphicsContext::create3D):
(WebCore::CCGraphicsContext::context3D):
(WebCore::CCGraphicsContext::CCGraphicsContext):
* platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
(WebCore::CCHeadsUpDisplay::draw):
* platform/graphics/chromium/cc/CCIOSurfaceLayerImpl.cpp:
(WebCore::CCIOSurfaceLayerImpl::~CCIOSurfaceLayerImpl):
(WebCore::CCIOSurfaceLayerImpl::willDraw):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::createContext):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
(CCLayerTreeHostClient):
(WebCore::LayerRendererCapabilities::LayerRendererCapabilities):
(LayerRendererCapabilities):
(WebCore::CCLayerTreeHost::needsSharedContext):
(CCLayerTreeHost):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::initializeLayerRenderer):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(CCLayerTreeHostImpl):
* platform/graphics/chromium/cc/CCSingleThreadProxy.cpp:
(WebCore::CCSingleThreadProxy::initializeContext):
(WebCore::CCSingleThreadProxy::recreateContext):
* platform/graphics/chromium/cc/CCSingleThreadProxy.h:
* platform/graphics/chromium/cc/CCTextureUpdater.cpp:
(WebCore::CCTextureUpdater::update):
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::initializeContext):
(WebCore::CCThreadProxy::recreateContext):
(WebCore::CCThreadProxy::beginFrame):
(WebCore::CCThreadProxy::initializeContextOnImplThread):
(WebCore::CCThreadProxy::recreateContextOnImplThread):
* platform/graphics/chromium/cc/CCThreadProxy.h:
(CCThreadProxy):
* platform/graphics/chromium/cc/CCVideoLayerImpl.cpp:
(WebCore::CCVideoLayerImpl::FramePlane::allocateData):
(WebCore::CCVideoLayerImpl::FramePlane::freeData):
(WebCore::CCVideoLayerImpl::copyPlaneData):

Source/WebKit/chromium:

Updates tests for refactor, mostly by removing unnecessary GraphicsContext3D wrapper around mock contexts.

* WebKit.gypi:
* src/WebLayerTreeView.cpp:
(WebKit::WebLayerTreeView::context):
* src/WebLayerTreeViewImpl.cpp:
* tests/CCLayerTreeHostImplTest.cpp:
* tests/CCLayerTreeHostTest.cpp:
(WTF::CCLayerTreeHostTestAtomicCommit::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestAtomicCommit::drawLayersOnCCThread):
(WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::commitCompleteOnCCThread):
(WTF::CCLayerTreeHostTestAtomicCommitWithPartialUpdate::drawLayersOnCCThread):
* tests/CCSingleThreadProxyTest.cpp:
* tests/CCThreadedTest.cpp:
(WebKitTests::TestHooks::createContext):
* tests/CCThreadedTest.h:
(TestHooks):
* tests/Canvas2DLayerBridgeTest.cpp:
(Canvas2DLayerBridgeTest::fullLifecycleTest):
* tests/CompositorFakeGraphicsContext3D.h: Removed.
* tests/DrawingBufferChromiumTest.cpp: Removed.
* tests/FakeCCLayerTreeHostClient.h:
* tests/FakeGraphicsContext3DTest.cpp:
(TEST):
* tests/GraphicsLayerChromiumTest.cpp:
* tests/LayerRendererChromiumTest.cpp:
(FakeLayerRendererChromium::FakeLayerRendererChromium):
(LayerRendererChromiumTest::LayerRendererChromiumTest):
(LayerRendererChromiumTest):
(TEST_F):
(TEST):
* tests/TextureCopierTest.cpp:
* tests/ThrottledTextureUploaderTest.cpp:
(WebKit::TEST):
* tests/TiledLayerChromiumTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Lion WK2] fast/loader/reload-zero-byte-plugin.html hits assert
andersca@apple.com [Tue, 26 Jun 2012 00:43:47 +0000 (00:43 +0000)]
[Lion WK2] fast/loader/reload-zero-byte-plugin.html hits assert
https://bugs.webkit.org/show_bug.cgi?id=89611
<rdar://problem/11714023>

Reviewed by Sam Weinig.

Source/WebKit2:

Make sure to send the response along to the plug-in in the case where the stream was empty.

* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::finishedLoading):

LayoutTests:

Remove the test from the Skipped list.

* platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoremove chromium vista baselines
dpranke@chromium.org [Tue, 26 Jun 2012 00:31:21 +0000 (00:31 +0000)]
remove chromium vista baselines
https://bugs.webkit.org/show_bug.cgi?id=89927

Unreviewed, expectations change.

Now that we no longer run tests on Vista, no need for the
baselines either.

* platform/chromium-win-vista/canvas/philip/tests/2d.line.cap.round-expected.txt: Removed.
* platform/chromium-win-vista/canvas/philip/tests/2d.strokeRect.zero.5-expected.txt: Removed.
* platform/chromium-win-vista/compositing/geometry/horizontal-scroll-composited-expected.png: Removed.
* platform/chromium-win-vista/compositing/overflow/theme-affects-visual-overflow-expected.txt: Removed.
* platform/chromium-win-vista/compositing/shadows/shadow-drawing-expected.png: Removed.
* platform/chromium-win-vista/css1/font_properties/font-expected.txt: Removed.
* platform/chromium-win-vista/css1/text_properties/line_height-expected.txt: Removed.
* platform/chromium-win-vista/css1/units/percentage_units-expected.png: Removed.
* platform/chromium-win-vista/css2.1/t040103-ident-03-c-expected.png: Removed.
* platform/chromium-win-vista/css2.1/t0803-c5505-imrgn-00-a-ag-expected.txt: Removed.
* platform/chromium-win-vista/css3/selectors3/html/css3-modsel-23-expected.png: Removed.
* platform/chromium-win-vista/css3/selectors3/html/css3-modsel-24-expected.png: Removed.
* platform/chromium-win-vista/css3/selectors3/html/css3-modsel-32-expected.txt: Removed.
* platform/chromium-win-vista/css3/selectors3/html/css3-modsel-68-expected.png: Removed.
* platform/chromium-win-vista/css3/selectors3/html/css3-modsel-69-expected.png: Removed.
* platform/chromium-win-vista/css3/selectors3/xhtml/css3-modsel-23-expected.png: Removed.
* platform/chromium-win-vista/css3/selectors3/xhtml/css3-modsel-24-expected.png: Removed.
* platform/chromium-win-vista/css3/selectors3/xhtml/css3-modsel-69-expected.png: Removed.
* platform/chromium-win-vista/css3/selectors3/xml/css3-modsel-23-expected.png: Removed.
* platform/chromium-win-vista/css3/selectors3/xml/css3-modsel-24-expected.png: Removed.
* platform/chromium-win-vista/css3/selectors3/xml/css3-modsel-68-expected.png: Removed.
* platform/chromium-win-vista/css3/selectors3/xml/css3-modsel-69-expected.png: Removed.
* platform/chromium-win-vista/editing/inserting/4959067-expected.txt: Removed.
* platform/chromium-win-vista/editing/pasteboard/paste-xml-expected.txt: Removed.
* platform/chromium-win-vista/editing/style/style-3681552-fix-002-expected.txt: Removed.
* platform/chromium-win-vista/fast/backgrounds/size/backgroundSize20-expected.png: Removed.
* platform/chromium-win-vista/fast/backgrounds/size/backgroundSize21-expected.png: Removed.
* platform/chromium-win-vista/fast/backgrounds/size/backgroundSize22-expected.png: Removed.
* platform/chromium-win-vista/fast/block/positioning/trailing-space-test-expected.png: Removed.
* platform/chromium-win-vista/fast/box-shadow/single-pixel-shadow-expected.png: Removed.
* platform/chromium-win-vista/fast/canvas/canvas-fillRect-gradient-shadow-expected.txt: Removed.
* platform/chromium-win-vista/fast/canvas/canvas-resize-after-paint-without-layout-expected.png: Removed.
* platform/chromium-win-vista/fast/canvas/webgl/context-lost-expected.txt: Removed.
* platform/chromium-win-vista/fast/compact/001-expected.png: Removed.
* platform/chromium-win-vista/fast/css/box-shadow-and-border-radius-expected.png: Removed.
* platform/chromium-win-vista/fast/css/text-rendering-expected.png: Removed.
* platform/chromium-win-vista/fast/css/text-rendering-expected.txt: Removed.
* platform/chromium-win-vista/fast/css/zoom-body-scroll-expected.txt: Removed.
* platform/chromium-win-vista/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt: Removed.
* platform/chromium-win-vista/fast/dom/HTMLProgressElement/progress-element-expected.txt: Removed.
* platform/chromium-win-vista/fast/forms/select-writing-direction-natural-expected.txt: Removed.
* platform/chromium-win-vista/fast/inline-block/002-expected.png: Removed.
* platform/chromium-win-vista/fast/inline/002-expected.png: Removed.
* platform/chromium-win-vista/fast/js/large-expressions-expected.txt: Removed.
* platform/chromium-win-vista/fast/multicol/client-rects-expected.png: Removed.
* platform/chromium-win-vista/fast/multicol/client-rects-expected.txt: Removed.
* platform/chromium-win-vista/fast/multicol/vertical-rl/nested-columns-expected.png: Removed.
* platform/chromium-win-vista/fast/parser/style-script-head-test-expected.png: Removed.
* platform/chromium-win-vista/fast/repaint/background-misaligned-expected.png: Removed.
* platform/chromium-win-vista/fast/repaint/inline-relative-positioned-expected.txt: Removed.
* platform/chromium-win-vista/fast/replaced/image-tag-expected.png: Removed.
* platform/chromium-win-vista/fast/sub-pixel/selection/selection-gaps-at-fractional-offsets-expected.png: Removed.
* platform/chromium-win-vista/fast/table/tableInsideCaption-expected.png: Removed.
* platform/chromium-win-vista/fast/text/atsui-kerning-and-ligatures-expected.png: Removed.
* platform/chromium-win-vista/fast/text/backslash-to-yen-sign-expected.txt: Removed.
* platform/chromium-win-vista/fast/text/international/bidi-mirror-he-ar-expected.txt: Removed.
* platform/chromium-win-vista/fast/text/international/bidi-neutral-run-expected.png: Removed.
* platform/chromium-win-vista/fast/text/international/danda-space-expected.png: Removed.
* platform/chromium-win-vista/fast/text/international/plane2-expected.txt: Removed.
* platform/chromium-win-vista/fast/text/selection-painted-separately-expected.txt: Removed.
* platform/chromium-win-vista/fast/text/selection-rect-rounding-expected.txt: Removed.
* platform/chromium-win-vista/fast/text/stroking-decorations-expected.png: Removed.
* platform/chromium-win-vista/fast/text/stroking-expected.png: Removed.
* platform/chromium-win-vista/fast/text/unicode-variation-selector-expected.png: Removed.
* platform/chromium-win-vista/fast/text/whitespace/normal-after-nowrap-breaking-expected.png: Removed.
* platform/chromium-win-vista/fast/writing-mode/broken-ideographic-font-expected.txt: Removed.
* platform/chromium-win-vista/fast/writing-mode/english-lr-text-expected.png: Removed.
* platform/chromium-win-vista/http/tests/misc/acid2-expected.txt: Removed.
* platform/chromium-win-vista/http/tests/misc/acid2-pixel-expected.png: Removed.
* platform/chromium-win-vista/platform/chromium/compositing/layout-width-change-expected.png: Removed.
* platform/chromium-win-vista/platform/chromium/virtual/gpu/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.txt: Removed.
* platform/chromium-win-vista/platform/chromium/virtual/gpu/fast/canvas/canvas-resize-after-paint-without-layout-expected.png: Removed.
* platform/chromium-win-vista/svg/W3C-I18N/g-dirLTR-ubNone-expected.txt: Removed.
* platform/chromium-win-vista/svg/W3C-I18N/g-dirLTR-ubOverride-expected.txt: Removed.
* platform/chromium-win-vista/svg/W3C-I18N/g-dirRTL-ubNone-expected.txt: Removed.
* platform/chromium-win-vista/svg/W3C-I18N/g-dirRTL-ubOverride-expected.txt: Removed.
* platform/chromium-win-vista/svg/W3C-I18N/text-dirLTR-ubNone-expected.txt: Removed.
* platform/chromium-win-vista/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png: Removed.
* platform/chromium-win-vista/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt: Removed.
* platform/chromium-win-vista/svg/W3C-I18N/text-dirRTL-ubNone-expected.txt: Removed.
* platform/chromium-win-vista/svg/W3C-I18N/text-dirRTL-ubOverride-expected.txt: Removed.
* platform/chromium-win-vista/svg/W3C-I18N/tspan-dirLTR-ubEmbed-in-rtl-context-expected.txt: Removed.
* platform/chromium-win-vista/svg/W3C-I18N/tspan-dirLTR-ubNone-in-rtl-context-expected.txt: Removed.
* platform/chromium-win-vista/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png: Removed.
* platform/chromium-win-vista/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt: Removed.
* platform/chromium-win-vista/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png: Removed.
* platform/chromium-win-vista/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt: Removed.
* platform/chromium-win-vista/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.png: Removed.
* platform/chromium-win-vista/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-rtl-context-expected.txt: Removed.
* platform/chromium-win-vista/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png: Removed.
* platform/chromium-win-vista/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt: Removed.
* platform/chromium-win-vista/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png: Removed.
* platform/chromium-win-vista/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt: Removed.
* platform/chromium-win-vista/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-rtl-context-expected.txt: Removed.
* platform/chromium-win-vista/svg/W3C-I18N/tspan-direction-rtl-expected.txt: Removed.
* platform/chromium-win-vista/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png: Removed.
* platform/chromium-win-vista/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt: Removed.
* platform/chromium-win-vista/svg/W3C-SVG-1.1/animate-elem-52-t-expected.png: Removed.
* platform/chromium-win-vista/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png: Removed.
* platform/chromium-win-vista/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt: Removed.
* platform/chromium-win-vista/svg/W3C-SVG-1.1/masking-intro-01-f-expected.png: Removed.
* platform/chromium-win-vista/svg/W3C-SVG-1.1/text-intro-05-t-expected.png: Removed.
* platform/chromium-win-vista/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt: Removed.
* platform/chromium-win-vista/svg/as-image/image-respects-pageScaleFactor-expected.png: Removed.
* platform/chromium-win-vista/svg/as-image/image-respects-pageScaleFactor-expected.txt: Removed.
* platform/chromium-win-vista/svg/as-object/svg-embedded-in-html-in-iframe-expected.txt: Removed.
* platform/chromium-win-vista/svg/css/composite-shadow-text-expected.png: Removed.
* platform/chromium-win-vista/svg/css/shadow-changes-expected.png: Removed.
* platform/chromium-win-vista/svg/custom/bug45331-expected.txt: Removed.
* platform/chromium-win-vista/svg/custom/js-late-gradient-and-object-creation-expected.png: Removed.
* platform/chromium-win-vista/svg/custom/js-late-pattern-and-object-creation-expected.png: Removed.
* platform/chromium-win-vista/svg/custom/mouse-move-on-svg-root-expected.png: Removed.
* platform/chromium-win-vista/svg/custom/mouse-move-on-svg-root-expected.txt: Removed.
* platform/chromium-win-vista/svg/custom/object-sizing-width-50p-height-50p-on-target-svg-absolute-expected.txt: Removed.
* platform/chromium-win-vista/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Removed.
* platform/chromium-win-vista/svg/custom/object-sizing-width-50p-on-target-svg-absolute-expected.txt: Removed.
* platform/chromium-win-vista/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-absolute-expected.txt: Removed.
* platform/chromium-win-vista/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Removed.
* platform/chromium-win-vista/svg/custom/pattern-referencing-preserve-aspect-ratio-expected.txt: Removed.
* platform/chromium-win-vista/svg/custom/use-clipped-hit-expected.txt: Removed.
* platform/chromium-win-vista/svg/custom/use-disappears-after-style-update-expected.txt: Removed.
* platform/chromium-win-vista/svg/custom/use-modify-target-symbol-expected.txt: Removed.
* platform/chromium-win-vista/svg/dynamic-updates/SVGImageElement-dom-preserveAspectRatio-attr-expected.png: Removed.
* platform/chromium-win-vista/svg/dynamic-updates/SVGImageElement-dom-width-attr-expected.png: Removed.
* platform/chromium-win-vista/svg/dynamic-updates/SVGImageElement-dom-x-attr-expected.png: Removed.
* platform/chromium-win-vista/svg/dynamic-updates/SVGImageElement-dom-y-attr-expected.png: Removed.
* platform/chromium-win-vista/svg/dynamic-updates/SVGImageElement-svgdom-height-prop-expected.png: Removed.
* platform/chromium-win-vista/svg/dynamic-updates/SVGImageElement-svgdom-preserveAspectRatio-prop-expected.png: Removed.
* platform/chromium-win-vista/svg/dynamic-updates/SVGImageElement-svgdom-width-prop-expected.png: Removed.
* platform/chromium-win-vista/svg/dynamic-updates/SVGImageElement-svgdom-x-prop-expected.png: Removed.
* platform/chromium-win-vista/svg/dynamic-updates/SVGImageElement-svgdom-y-prop-expected.png: Removed.
* platform/chromium-win-vista/svg/filters/big-sized-filter-2-expected.png: Removed.
* platform/chromium-win-vista/svg/filters/feComposite-expected.png: Removed.
* platform/chromium-win-vista/svg/filters/feDisplacementMap-expected.png: Removed.
* platform/chromium-win-vista/svg/filters/feLighting-crash-expected.png: Removed.
* platform/chromium-win-vista/svg/filters/feMerge-expected.png: Removed.
* platform/chromium-win-vista/svg/filters/shadow-on-filter-expected.png: Removed.
* platform/chromium-win-vista/svg/filters/shadow-on-rect-with-filter-expected.png: Removed.
* platform/chromium-win-vista/svg/filters/subRegion-in-userSpace-expected.png: Removed.
* platform/chromium-win-vista/svg/stroke/zero-length-path-linecap-rendering-expected.txt: Removed.
* platform/chromium-win-vista/svg/stroke/zero-length-subpaths-linecap-rendering-expected.txt: Removed.
* platform/chromium-win-vista/svg/text/bidi-text-query-expected.png: Removed.
* platform/chromium-win-vista/svg/text/bidi-text-query-expected.txt: Removed.
* platform/chromium-win-vista/svg/text/bidi-tspans-expected.txt: Removed.
* platform/chromium-win-vista/svg/text/text-intro-05-t-expected.png: Removed.
* platform/chromium-win-vista/svg/text/text-intro-05-t-expected.txt: Removed.
* platform/chromium-win-vista/svg/zoom/page/zoom-foreignObject-expected.png: Removed.
* platform/chromium-win-vista/svg/zoom/page/zoom-hixie-rendering-model-004-expected.png: Removed.
* platform/chromium-win-vista/svg/zoom/page/zoom-mask-with-percentages-expected.png: Removed.
* platform/chromium-win-vista/tables/mozilla/bugs/bug120107-expected.png: Removed.
* platform/chromium-win-vista/tables/mozilla/bugs/bug1271-expected.png: Removed.
* platform/chromium-win-vista/tables/mozilla/bugs/bug12908-2-expected.png: Removed.
* platform/chromium-win-vista/tables/mozilla/bugs/bug13169-expected.png: Removed.
* platform/chromium-win-vista/tables/mozilla/bugs/bug196870-expected.png: Removed.
* platform/chromium-win-vista/tables/mozilla/bugs/bug50695-2-expected.png: Removed.
* platform/chromium-win-vista/tables/mozilla/marvin/tables_align_center-expected.png: Removed.
* platform/chromium-win-vista/tables/mozilla_expected_failures/bugs/bug61042-1-expected.png: Removed.
* platform/chromium-win-vista/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png: Removed.
* platform/chromium-win-vista/transforms/2d/hindi-rotated-expected.png: Removed.
* platform/chromium-win-vista/transforms/2d/hindi-rotated-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121202 268f45cc-cd09-0410-ab3c-d52691b4dbfc