WebKit-https.git
9 years ago[chromium] No modifier flags (shift/ctrl/alt) in drag&drop events on chromium linux
commit-queue@webkit.org [Wed, 16 May 2012 20:04:36 +0000 (20:04 +0000)]
[chromium] No modifier flags (shift/ctrl/alt) in drag&drop events on chromium linux
https://bugs.webkit.org/show_bug.cgi?id=86236

Patch by Varun Jain <varunjain@google.com> on 2012-05-16
Reviewed by Tony Chang.

.:

* ManualTests/chromium/modifiers-during-drag-and-drop.html: Added.

Source/WebCore:

ManualTests: ManualTests/chromium/modifiers-during-drag-and-drop.html

* page/DragController.cpp:
(WebCore::createMouseEvent):
* platform/DragData.cpp:
(WebCore):
(WebCore::DragData::modifierKeyState):
* platform/DragData.h:
(DragData):
* platform/chromium/ChromiumDataObject.cpp:
(WebCore::ChromiumDataObject::ChromiumDataObject):
* platform/chromium/ChromiumDataObject.h:
(WebCore::ChromiumDataObject::modifierKeyState):
(WebCore::ChromiumDataObject::setModifierKeyState):
(ChromiumDataObject):
* platform/chromium/DragDataChromium.cpp:
(WebCore::DragData::modifierKeyState):
(WebCore):

Source/WebKit/chromium:

* public/WebView.h:
(WebView):
* src/WebViewImpl.cpp:
(WebKit::webInputEventKeyStateToPlatformEventKeyState):
(WebKit):
(WebKit::WebViewImpl::dragTargetDragEnter):
(WebKit::WebViewImpl::dragTargetDragOver):
(WebKit::WebViewImpl::dragTargetDrop):
(WebKit::WebViewImpl::dragTargetDragEnterOrOver):
* src/WebViewImpl.h:
(WebViewImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<video> elements with no video tracks report false for webkitSupportsFullscreen.
jer.noble@apple.com [Wed, 16 May 2012 19:55:05 +0000 (19:55 +0000)]
<video> elements with no video tracks report false for webkitSupportsFullscreen.
https://bugs.webkit.org/show_bug.cgi?id=86650

Reviewed by Eric Carlson.

Source/WebCore:

No new tests; updated media/media-fullscreen-inline.html.

With the new Full Screen API, the restriction that only video elements with
video tracks can enter full screen seems arbitrary. Some media types will
occasionally determine they have video tracks long after loadedmetadata, which
breaks websites who check for webkitSupportsFullscreen(). Relax the restriction
on webkitSupportsFullscreen() for ports where the Full Screen API is enabled and
supported so as to no longer require hasVideo().

* html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::supportsFullscreen):

LayoutTests:

Fix media-fullscreen.js to support the new FULLSCREEN_API events, if present.
Fix the media-fullscreen-inline.html test and unskip on Lion.

* media/media-fullscreen-inline-expected.txt:
* media/media-fullscreen-inline.html:
* media/media-fullscreen.js:
(fullscreenchange):
(loadedmetadata):
(addEventListeners):
* platform/mac-lion/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][Mac]REGRESSION?(r89397) It made fast/css/custom-font-xheight.html crash
commit-queue@webkit.org [Wed, 16 May 2012 19:48:12 +0000 (19:48 +0000)]
[Qt][Mac]REGRESSION?(r89397) It made fast/css/custom-font-xheight.html crash
https://bugs.webkit.org/show_bug.cgi?id=63132

Removed test from skipped list, since it now passes on mac.

Patch by Marcelo Lira <marcelo.lira@openbossa.org> on 2012-05-16
Reviewed by Alexis Menard.

* platform/qt-mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[WinCairo] Unreviewed build change after exported symbol
bfulgham@webkit.org [Wed, 16 May 2012 19:40:52 +0000 (19:40 +0000)]
[WinCairo] Unreviewed build change after exported symbol
updates (r114790) and expansion of CG routines in WebPage
PDF output (r114476).

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::drawRectToPDF): Exclude CG use on WinCairo.
(WebKit::WebPage::drawPagesToPDF): Exclude CG use on WinCairo.
* win/WebKit2CFLite.def: Don't claim to export symbols we don't
provide (e.g., full screen API calls).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAvoid reparsing the style attribute when cloning elements.
kling@webkit.org [Wed, 16 May 2012 19:31:40 +0000 (19:31 +0000)]
Avoid reparsing the style attribute when cloning elements.
<http://webkit.org/b/86574>

Reviewed by Antti Koivisto.

Refactor cloning of attributes a bit to dodge the styleAttr reparse previously
caused by ElementAttributeData::setAttributes().

Introduced Element::cloneDataFromElement() which takes care of cloning the
ElementAttributeData as well as "non-attribute properties" (which is currently
specific to HTMLInputElement.)

Also includes some additional dodging of attribute vector traversal to find
old/new 'id' and 'name' attributes.

I'm seeing a ~10% improvement on PerformanceTests/DOM/CloneNodes locally.

* dom/Document.cpp:
(WebCore::Document::importNode):
* dom/Element.cpp:
(WebCore::Element::cloneElementWithoutChildren):
(WebCore::Element::cloneAttributesFromElement):
(WebCore::Element::cloneDataFromElement):
* dom/Element.h:
(WebCore::Element::copyNonAttributePropertiesFromElement):
* dom/ElementAttributeData.cpp:
(WebCore::ElementAttributeData::cloneDataFrom):
* dom/ElementAttributeData.h:
(ElementAttributeData):
* dom/Node.h:
* dom/StyledElement.cpp:
(WebCore::StyledElement::styleAttributeChanged):
(WebCore::StyledElement::parseAttribute):
* dom/StyledElement.h:
* editing/ReplaceNodeWithSpanCommand.cpp:
(WebCore::swapInNodePreservingAttributesAndChildren):
* html/HTMLElement.cpp:
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::copyNonAttributePropertiesFromElement):
* html/HTMLInputElement.h:
* inspector/DOMPatchSupport.cpp:
(WebCore::DOMPatchSupport::innerPatchNode):
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::setNodeName):
* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::expandSymbolElementsInShadowTree):
(WebCore::SVGUseElement::transferUseAttributesToReplacedElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[WinCairo] Unreviewed build change after r115385. Several Cairo
bfulgham@webkit.org [Wed, 16 May 2012 19:25:25 +0000 (19:25 +0000)]
[WinCairo] Unreviewed build change after r115385.  Several Cairo
image routines were modified to use new wrapper classes, but the
relevant WinCairo sources were not updated to match.

* WebCore.vcproj/WebCore.vcproj:
* platform/graphics/win/ImageCairoWin.cpp:
(WebCore::BitmapImage::create):
(WebCore::BitmapImage::drawFrameMatchingSourceSize):
* platform/win/DragImageCairoWin.cpp:
(WebCore::createDragImageFromImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoScrollbar layers should respect accelerated drawing setting
timothy_horton@apple.com [Wed, 16 May 2012 18:45:03 +0000 (18:45 +0000)]
Scrollbar layers should respect accelerated drawing setting
https://bugs.webkit.org/show_bug.cgi?id=86644
<rdar://problem/11462038>

Reviewed by Simon Fraser.

When creating scrollbar layers, pass through the accelerated drawing setting.

No new tests.

* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::updateOverflowControlsLayers):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFrameView::scrollContentsFastPath should use painted area to determine whether to...
timothy_horton@apple.com [Wed, 16 May 2012 18:41:38 +0000 (18:41 +0000)]
FrameView::scrollContentsFastPath should use painted area to determine whether to drop out of the fast path
https://bugs.webkit.org/show_bug.cgi?id=86651
<rdar://problem/11459243>

Reviewed by Simon Fraser.

Previously, we decided to fall out of the fast scrolling path by the number of fixed-position elements
on the page. This was less than ideal if a single fixed position element took up a significant portion
of the page, or if there were many small, cheap-to-paint fixed elements.

Instead, we should use the fast path if less than 50% of the page will be repainted by fixed-position
elements, and otherwise fall back to the slow path.

I've tested a few different thresholds with an internal test; 50% seems to work relatively well,
but the ideal value is hard to determine and likely depends on hardware.

No new tests, performance improvement with few large fixed-position objects or many small ones.

* page/FrameView.cpp:
(WebCore::FrameView::scrollContentsFastPath):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Use ThrottledTextureUploader with threaded compositing.
commit-queue@webkit.org [Wed, 16 May 2012 18:31:53 +0000 (18:31 +0000)]
[Chromium] Use ThrottledTextureUploader with threaded compositing.
https://bugs.webkit.org/show_bug.cgi?id=85848

Patch by David Reveman <reveman@chromium.org> on 2012-05-16
Reviewed by Adrienne Walker.

Switch to ThrottledUploader in CCThreadProxy.

* platform/graphics/chromium/cc/CCThreadProxy.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMake things build with DUMP_HASHTABLE_STATS=1
simon.fraser@apple.com [Wed, 16 May 2012 18:31:12 +0000 (18:31 +0000)]
Make things build with DUMP_HASHTABLE_STATS=1
https://bugs.webkit.org/show_bug.cgi?id=86571

Reviewed by Geoffrey Garen.

DUMP_HASHTABLE_STATS bitrotted after the WTF separation. This patch
makes it build.

Added WTF_EXPORTDATA to the global data, and WTF_EXPORT_PRIVATE to
the static HashTableStats methods. Added a dumpStats() method
that is not yet called anywhere; we can no longer rely on destroying
a global object to dump the stats because global destructors are
disallowed.

* wtf/HashTable.cpp:
(WTF):
(WTF::HashTableStats::recordCollisionAtCount):
(WTF::HashTableStats::dumpStats):
* wtf/HashTable.h:
(HashTableStats):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoChange ascents and descent back to ints for now
eae@chromium.org [Wed, 16 May 2012 18:30:09 +0000 (18:30 +0000)]
Change ascents and descent back to ints for now
https://bugs.webkit.org/show_bug.cgi?id=86518

Reviewed by Eric Seidel.

Change ascents and descent calculation back to integers for now as it
looks like we'll need to support both the 1/60 and 1/1 implementations of
FractionalLayoutUnit for the immediate future to ensure that text is
rendered at the same offset and with the height regardless of the
ENABLE_SUBPIXEL_LAYOUT flag.

This ensures that most websites will look the same at 100% zoom
regardless of the flag and also allows us to the same test expectations
for the vast majority of layout tests.

Eventually we want to move those back to FractionalLayoutUnits as that
will result in more correct rendering.

Source/WebCore:

No new tests, no change in functionality.

* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::computeLogicalBoxHeights):
* rendering/RootInlineBox.cpp:
(WebCore::setAscentAndDescent):
(WebCore::RootInlineBox::ascentAndDescentForBox):
* rendering/RootInlineBox.h:
(RootInlineBox):

LayoutTests:

* platform/chromium-win/fast/block/float/overhanging-tall-block-expected.txt:
* platform/mac/fast/block/float/overhanging-tall-block-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCrash due to first-letter not getting computed on RenderTableCell
kenrb@chromium.org [Wed, 16 May 2012 18:18:43 +0000 (18:18 +0000)]
Crash due to first-letter not getting computed on RenderTableCell
https://bugs.webkit.org/show_bug.cgi?id=86133

Reviewed by Abhishek Arya.

Source/WebCore:

RenderTableCell overrides RenderBlock::layout() but doesn't call
updateFirstLetter() in it. This is normally not a problem because
updateFirstLetter() gets called during preferred logical width
computation, but there exist rare occasions when layout of the table
cell happens without preferred logical widths being dirty, in which
case the first-letter update can be skipped.

This patch adds a call to updateFirstLetter() to
RenderTableCell::layout(). This ensures that the first-letter is up
to date before commencing block layout.

* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::layout)

LayoutTests:

Test to exercise crashing condition in bug 86133.

* fast/css-generated-content/first-letter-table-cell-format-block-crash-expected.txt: Added
* fast/css-generated-content/first-letter-table-cell-format-block-crash.html: Added

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNew baselines required after r117187.
senorblanco@chromium.org [Wed, 16 May 2012 17:53:18 +0000 (17:53 +0000)]
New baselines required after r117187.
https://bugs.webkit.org/show_bug.cgi?id=86486

Unreviewed gardening.

* platform/chromium-linux/svg/custom/pointer-events-image-css-transform-expected.png:
* platform/chromium-linux/svg/custom/pointer-events-image-expected.png:
* platform/chromium-mac-leopard/svg/custom/pointer-events-image-css-transform-expected.png:
* platform/chromium-mac-leopard/svg/custom/pointer-events-image-expected.png:
* platform/chromium-mac-snowleopard/svg/custom/pointer-events-image-css-transform-expected.png:
* platform/chromium-mac-snowleopard/svg/custom/pointer-events-image-expected.png:
* platform/chromium-mac/svg/custom/pointer-events-image-css-transform-expected.png:
* platform/chromium-mac/svg/custom/pointer-events-image-expected.png:
* platform/chromium-win/svg/custom/pointer-events-image-css-transform-expected.png:
* platform/chromium-win/svg/custom/pointer-events-image-expected.png:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAvoid jumpscroll when entering new text in a multi-line editor.
mnaganov@chromium.org [Wed, 16 May 2012 17:45:32 +0000 (17:45 +0000)]
Avoid jumpscroll when entering new text in a multi-line editor.
https://bugs.webkit.org/show_bug.cgi?id=82875

Reviewed by Ryosuke Niwa

Scroll caret to the edge of the viewport in case if a line break or a paragraph
separator is inserted at the end of a multi-line editor.  This avoids
undesirable jumpscroll in cases when there is content under the editor.

Tests: editing/input/scroll-to-edge-if-line-break-at-end-of-document-contenteditable.html
       editing/input/scroll-to-edge-if-line-break-at-end-of-document-textarea.html
       editing/input/scroll-to-edge-if-paragraph-separator-at-end-of-document-contenteditable.html

* editing/Editor.cpp:
(WebCore::Editor::insertLineBreak):
(WebCore::Editor::insertParagraphSeparator):
(WebCore::Editor::revealSelectionAfterEditingOperation):
* editing/Editor.h:
(Editor):

* editing/input/resources/reveal-utilities.js:
(performJumpAtTheEdgeTest):
* editing/input/scroll-to-edge-if-line-break-at-end-of-document-contenteditable-expected.txt: Added.
* editing/input/scroll-to-edge-if-line-break-at-end-of-document-contenteditable.html: Added.
* editing/input/scroll-to-edge-if-line-break-at-end-of-document-textarea-expected.txt: Added.
* editing/input/scroll-to-edge-if-line-break-at-end-of-document-textarea.html: Added.
* editing/input/scroll-to-edge-if-paragraph-separator-at-end-of-document-contenteditable-expected.txt: Added.
* editing/input/scroll-to-edge-if-paragraph-separator-at-end-of-document-contenteditable.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Pressing esc after requesting snippet creation should remove snippet.
vsevik@chromium.org [Wed, 16 May 2012 17:36:23 +0000 (17:36 +0000)]
Web Inspector: Pressing esc after requesting snippet creation should remove snippet.
https://bugs.webkit.org/show_bug.cgi?id=86639

Reviewed by Pavel Feldman.

Added committed parameter to NavigatorView.rename() callback.

* inspector/front-end/NavigatorView.js:
(WebInspector.NavigatorView.prototype.rename.commitHandler):
(WebInspector.NavigatorView.prototype.rename.cancelHandler):
(WebInspector.NavigatorView.prototype.rename.afterEditing):
* inspector/front-end/ScriptsNavigator.js:
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._snippetCreationRequested.callback):
(WebInspector.ScriptsPanel.prototype._snippetCreationRequested):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Add API to get plugins to WebKit2 GTK+
carlosgc@webkit.org [Wed, 16 May 2012 17:29:31 +0000 (17:29 +0000)]
[GTK] Add API to get plugins to WebKit2 GTK+
https://bugs.webkit.org/show_bug.cgi?id=86356

Reviewed by Martin Robinson.

* GNUmakefile.list.am: Add new files to compilation.
* UIProcess/API/gtk/WebKitMimeInfo.cpp: Added.
(_WebKitMimeInfo): Boxed type to represent MIME type information.
(webkitMimeInfoCreate): Ceate a new WebKitMimeInfo.
(webkit_mime_info_ref):
(webkit_mime_info_unref):
(webkit_mime_info_get_mime_type): Return the mime type.
(webkit_mime_info_get_description): Return the mime type
description.
(webkit_mime_info_get_extensions): Return the list of extensions
associated to the mime type.
* UIProcess/API/gtk/WebKitMimeInfo.h: Added.
* UIProcess/API/gtk/WebKitMimeInfoPrivate.h: Added.
* UIProcess/API/gtk/WebKitPlugin.cpp: Added.
(webkitPluginFinalize):
(webkit_plugin_init):
(webkit_plugin_class_init):
(webkitPluginCreate): Create a new WebKitPlugin for the given
PluginModuleInfo.
(webkit_plugin_get_name): Return the plugin name.
(webkit_plugin_get_description): Return the plugin description.
(webkit_plugin_get_path): Return the path where the plugin is
installed.
(webkit_plugin_get_mime_info_list): Return the list of mime types
handled by the plugin.
* UIProcess/API/gtk/WebKitPlugin.h: Added.
* UIProcess/API/gtk/WebKitPluginPrivate.h: Added.
* UIProcess/API/gtk/WebKitWebContext.cpp:
(webkit_web_context_set_additional_plugins_directory): Set an
additional directory to be scanned for plugins.
(GetPluginsAsyncData): Helper struct used to asynchronously get
the list of plugins.
(getPluginsAsyncDataCreate): Create a GetPluginsAsyncData struct.
(getPluginsAsyncDataDestroy): Destroy a GetPluginsAsyncData
struct.
(webkitWebContextGetPluginThread): Thread body to get the list of
plugins installed.
(webkit_web_context_get_plugins): Asynchronously get the list of
plugins installed.
(webkit_web_context_get_plugins_finish): Finish async operation
started by webkit_web_context_get_plugins() returning a list of
WebKitPlugin.
* UIProcess/API/gtk/WebKitWebContext.h:
* UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Add new section for
WebKitPlugin.
* UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbols.
* UIProcess/API/gtk/docs/webkit2gtk.types: Add new types.
* UIProcess/API/gtk/tests/GNUmakefile.am:
* UIProcess/API/gtk/tests/TestWebKitWebContext.cpp:
(testWebContextGetPlugins):
(beforeAll):
* UIProcess/API/gtk/webkit2.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMissing RenderApplet cast check in HTMLAppletElement::renderWidgetForJSBindings.
inferno@chromium.org [Wed, 16 May 2012 17:22:38 +0000 (17:22 +0000)]
Missing RenderApplet cast check in HTMLAppletElement::renderWidgetForJSBindings.
https://bugs.webkit.org/show_bug.cgi?id=86627

Reviewed by Andreas Kling.

Source/WebCore:

Test: java/inline-applet-crash.html

* html/HTMLAppletElement.cpp:
(WebCore::HTMLAppletElement::renderWidgetForJSBindings):

LayoutTests:

* java/inline-applet-crash-expected.txt: Added.
* java/inline-applet-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=86643
beidson@apple.com [Wed, 16 May 2012 16:56:17 +0000 (16:56 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=86643
http/tests/security/contentSecurityPolicy/script-src-redirect.html fails on Mac bots

* platform/mac/Skipped: Add to skipped list while Oliver and Michael are exploring it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: extract CompositeUISourceCodeProvider from DebuggerScriptMapping.
pfeldman@chromium.org [Wed, 16 May 2012 16:38:33 +0000 (16:38 +0000)]
Web Inspector: extract CompositeUISourceCodeProvider from DebuggerScriptMapping.
https://bugs.webkit.org/show_bug.cgi?id=86634

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Extract refactoring.

* inspector/front-end/DebuggerScriptMapping.js:
(WebInspector.DebuggerScriptMapping):
(WebInspector.DebuggerScriptMapping.prototype.uiSourceCodeProviders):
(WebInspector.DebuggerScriptMapping.prototype._parsedScriptSource):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._loadUISourceCodes):
(WebInspector.ScriptsPanel.prototype._toggleFormatSource):
(WebInspector.CompositeUISourceCodeProvider):
(WebInspector.CompositeUISourceCodeProvider.prototype._registerUISourceCodeProvider):
(WebInspector.CompositeUISourceCodeProvider.prototype._handleUISourceCodeAdded):
(WebInspector.CompositeUISourceCodeProvider.prototype._handleUISourceCodeReplaced):
(WebInspector.CompositeUISourceCodeProvider.prototype._handleUISourceCodeRemoved):
(WebInspector.CompositeUISourceCodeProvider.prototype.uiSourceCodes):
* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCodeProvider.prototype.uiSourceCodes):
(WebInspector.UISourceCodeProvider.prototype.addEventListener):
(WebInspector.UISourceCodeProvider.prototype.removeEventListener):

LayoutTests:

* http/tests/inspector/compiler-script-mapping.html:
* http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest):
* inspector/debugger/linkifier.html:
* inspector/debugger/scripts-panel.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=86638
beidson@apple.com [Wed, 16 May 2012 16:30:10 +0000 (16:30 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=86638
Bump the version number on the WKBundlePageLoaderClient

Reviewed by Dan Bernstein.

* WebProcess/InjectedBundle/API/c/WKBundlePage.h: s/1/2/
* Shared/APIClientTraits.cpp: Update client traits for the BundlePageLoaderClient
* Shared/APIClientTraits.h: Update client traits for the BundlePageLoaderClient

* ChangeLog: Change a confusing ChangeLog entry to reflect the actual client that was changed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Double Clicking on "No watch expressions" should add an expression
apavlov@chromium.org [Wed, 16 May 2012 16:22:25 +0000 (16:22 +0000)]
Web Inspector: Double Clicking on "No watch expressions" should add an expression
https://bugs.webkit.org/show_bug.cgi?id=86631

Reviewed by Vsevolod Vlasov.

A double-click listener for the section element adds a new watch expression if the correct element
has been clicked.
Drive-by: do not persist deleted (null) watch expressions.
* inspector/front-end/WatchExpressionsSidebarPane.js:
(WebInspector.WatchExpressionsSection.prototype._sectionDoubleClick):
(WebInspector.WatchExpressionsSection.prototype.updateExpression):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Support script snippets saving.
vsevik@chromium.org [Wed, 16 May 2012 16:11:43 +0000 (16:11 +0000)]
Web Inspector: Support script snippets saving.
https://bugs.webkit.org/show_bug.cgi?id=86632

Reviewed by Pavel Feldman.

Source/WebCore:

Added SnippetJavaScriptSource extending JavaScriptSource and overriding isEditable() and commitWorkingCopy() methods.
ScriptSnippetModel now creates instances of this new class for snippets.
Also maps in ScriptSnippetModel simplified.

* inspector/front-end/JavaScriptSource.js:
(WebInspector.JavaScriptSource.prototype.commitWorkingCopy):
(WebInspector):
* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype.commitEditing):
* inspector/front-end/ScriptSnippetModel.js:
(WebInspector.ScriptSnippetModel):
(WebInspector.ScriptSnippetModel.prototype._addScriptSnippet):
(WebInspector.ScriptSnippetModel.prototype.deleteScriptSnippet):
(WebInspector.ScriptSnippetModel.prototype.renameScriptSnippet):
(WebInspector.ScriptSnippetModel.prototype.setScriptSnippetContent):
(WebInspector.ScriptSnippetModel.prototype._uiSourceCodeList):
(WebInspector.ScriptSnippetModel.prototype._releasedUISourceCodes):
(WebInspector.SnippetJavaScriptSource):
(WebInspector.SnippetJavaScriptSource.prototype.isEditable):
(WebInspector.SnippetJavaScriptSource.prototype.commitWorkingCopy):
(WebInspector.SnippetJavaScriptSource.prototype.get snippetId):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.set _fileRenamed):
(WebInspector.ScriptsPanel.prototype._snippetCreationRequested.callback):
(WebInspector.ScriptsPanel.prototype._snippetCreationRequested):

LayoutTests:

* inspector/debugger/script-snippet-model.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Rounding errors on 32-bit machines causes tests to fail
commit-queue@webkit.org [Wed, 16 May 2012 16:09:41 +0000 (16:09 +0000)]
[EFL] Rounding errors on 32-bit machines causes tests to fail
https://bugs.webkit.org/show_bug.cgi?id=86194

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-16
Reviewed by Martin Robinson.

Pass additional CXXFLAGS to CMake in an attempt to harmonize floating
point values between 32-bit and 64-bit architectures.
Same flags are already used by Qt and GTK ports.

* Scripts/webkitdirs.pm:
(determineArchitecture):
(generateBuildSystemFromCMakeProject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Memory leak in RenderThemeEfl
commit-queue@webkit.org [Wed, 16 May 2012 16:00:54 +0000 (16:00 +0000)]
[EFL] Memory leak in RenderThemeEfl
https://bugs.webkit.org/show_bug.cgi?id=86609

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-16
Reviewed by Martin Robinson.

Fix a memory leak by freeing the cairo surface with
cairo_surface_destroy.

* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::cacheThemePartFlush):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Speedup heap snapshot postprocessing
commit-queue@webkit.org [Wed, 16 May 2012 15:49:36 +0000 (15:49 +0000)]
Web Inspector: Speedup heap snapshot postprocessing
https://bugs.webkit.org/show_bug.cgi?id=86635

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-05-16
Reviewed by Yury Semikhatsky.

* inspector/front-end/HeapSnapshot.js:
(WebInspector.HeapSnapshot.prototype._markQueriableHeapObjects):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, followup for r117273 that fixes the Web Inspector's Computed Style pane...
apavlov@chromium.org [Wed, 16 May 2012 15:48:01 +0000 (15:48 +0000)]
Unreviewed, followup for r117273 that fixes the Web Inspector's Computed Style pane layout.

* inspector/front-end/elementsPanel.css:
(.styles-section.computed-style.expanded .properties > li):
(.styles-section.computed-style.expanded .properties > li .webkit-css-property):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] New failing and flakey tests with newer Qt 5
ossy@webkit.org [Wed, 16 May 2012 15:42:12 +0000 (15:42 +0000)]
[Qt] New failing and flakey tests with newer Qt 5
https://bugs.webkit.org/show_bug.cgi?id=86452

Unreviewed gardening, skip new failing/flakey tests to paint
the bots green. (To be able to catch new and new regressions.)

* platform/qt-5.0-wk1/Skipped:
* platform/qt-5.0-wk2/Skipped:
* platform/qt-5.0/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: [Extensions API] expose evaluateOptions in audit formatters
caseq@chromium.org [Wed, 16 May 2012 15:41:08 +0000 (15:41 +0000)]
Web Inspector: [Extensions API] expose evaluateOptions in audit formatters
https://bugs.webkit.org/show_bug.cgi?id=86617

Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/extensions/extensions-audits-content-script.html

- apply extension-specific audit formatters earlier (in ExtensionAduitCategory, not along with the rest in AuditFormatters);
- use ExtensionServer.evaluate() to handle evaluateOptions instead of PageAgent.evaluate();

* inspector/front-end/AuditFormatters.js: Move node and object formatters to ExtensionAuditCategory.
(WebInspector.partiallyApplyFormatters): Added a method to traverse formatters tree and apply formatters that are passed as input.
* inspector/front-end/ExtensionAuditCategory.js:
(WebInspector.ExtensionAuditCategory): Pass extensionOrigin.
(WebInspector.ExtensionAuditCategoryResults.prototype._addNode): Apply extensions formatters before adding the result.
(WebInspector.ExtensionAuditCategoryResults.prototype._addResult):
(WebInspector.ExtensionAuditCategoryResults.prototype.evaluate): moved from AuditFormatters.
(WebInspector.ExtensionAuditFormatters.object.onEvaluate):
(WebInspector.ExtensionAuditFormatters.object):
(WebInspector.ExtensionAuditFormatters.node.onNodeAvailable):
(WebInspector.ExtensionAuditFormatters.node.onEvaluate):
(WebInspector.ExtensionAuditFormatters.node):
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._onAddAuditCategory): Plumb extensionOrigin through to audit category.

LayoutTests:

* inspector/extensions/extensions-audits-content-script-expected.txt: Added.
* inspector/extensions/extensions-audits-content-script.html: Added.
* platform/gtk/test_expectations.txt:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd missing include that was causing build errors.
commit-queue@webkit.org [Wed, 16 May 2012 15:27:10 +0000 (15:27 +0000)]
Add missing include that was causing build errors.
https://bugs.webkit.org/show_bug.cgi?id=86502

Patch by Genevieve Mak <gmak@rim.com> on 2012-05-16
Reviewed by Rob Buis.
Reviewed Internally by Liam Quinn.

* WebKitSupport/InputHandler.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFixes the build with Qt 5 HEAD
ossy@webkit.org [Wed, 16 May 2012 14:56:52 +0000 (14:56 +0000)]
Fixes the build with Qt 5 HEAD

Patch by Donald Carr <donald.carr@nokia.com> on 2012-05-16
Reviewed by Csaba Osztrogonác.

* WebCore.pri:
* platform/graphics/texmap/TextureMapperGL.cpp:
* plugins/qt/PluginViewQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Web Inspector: DevToolsSanityTest.TestScriptsTabIsPopulatedOnInspectedPage...
yurys@chromium.org [Wed, 16 May 2012 14:52:56 +0000 (14:52 +0000)]
[Chromium] Web Inspector: DevToolsSanityTest.TestScriptsTabIsPopulatedOnInspectedPageRefresh is broken
https://bugs.webkit.org/show_bug.cgi?id=86629

Reviewed by Pavel Feldman.

Listen to DebuggerModel instead of DebuggerPresentationModel which is gone.

* src/js/Tests.js:
(.TestSuite.prototype.testScriptsTabIsPopulatedOnInspectedPageRefresh.waitUntilScriptIsParsed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSVGSVGElement checkIntersection and checkEnclosure Mem corruption
rwlbuis@webkit.org [Wed, 16 May 2012 14:47:05 +0000 (14:47 +0000)]
SVGSVGElement checkIntersection and checkEnclosure Mem corruption
https://bugs.webkit.org/show_bug.cgi?id=67923

Patch by Rob Buis <rbuis@rim.com> on 2012-05-16
Reviewed by Nikolas Zimmermann.

Source/WebCore:

Only call checkIntersection/checkEnclosure when we have a valid renderer.

Test: svg/custom/intersection-list-null.svg

* svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::checkIntersection):
(WebCore::SVGSVGElement::checkEnclosure):

LayoutTests:

Add test to check that checkIntersection/checkEnclosure do not
crash when null is used for the element parameter.

* svg/custom/intersection-list-null-expected.txt: Added.
* svg/custom/intersection-list-null.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Web process hangs while waiting for plugin process connection during layouttests
kbalazs@webkit.org [Wed, 16 May 2012 14:23:43 +0000 (14:23 +0000)]
[Qt] Web process hangs while waiting for plugin process connection during layouttests
https://bugs.webkit.org/show_bug.cgi?id=86620

Reviewed by Csaba Osztrogonác.

Temporary workaround not to fail layout tests.

* Tools.pro: Disable TestNetscapePlugin.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Web Inspector: debugger browser tests are broken
yurys@chromium.org [Wed, 16 May 2012 14:22:30 +0000 (14:22 +0000)]
[Chromium] Web Inspector: debugger browser tests are broken
https://bugs.webkit.org/show_bug.cgi?id=86624

Reviewed by Vsevolod Vlasov.

Use WebInspector.panels.scripts._scriptMapping instead of
WebInspector.panels.scripts._presentationModel as the latter
has been deleted.

* src/js/Tests.js:
(.TestSuite.prototype.nonAnonymousUISourceCodes_):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: Unreviewed, rolling out r110699.
hausmann@webkit.org [Wed, 16 May 2012 14:21:02 +0000 (14:21 +0000)]
Source/WebCore: Unreviewed, rolling out r110699.
http://trac.webkit.org/changeset/110699
https://bugs.webkit.org/show_bug.cgi?id=80982

Not needed anymore and broke modal event loops

* platform/qt/RunLoopQt.cpp:
(WebCore::RunLoop::TimerObject::TimerObject):
(WebCore::RunLoop::TimerObject::performWork):
(RunLoop::TimerObject):

LayoutTests: Unskip fast/animation/request-animation-frame-during-modal.html that was
skipped due to r110699.

* platform/qt-5.0-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Fix uninitialized struct member added by r117258
commit-queue@webkit.org [Wed, 16 May 2012 14:08:05 +0000 (14:08 +0000)]
[EFL] Fix uninitialized struct member added by r117258
https://bugs.webkit.org/show_bug.cgi?id=86611

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-05-16
Reviewed by Gustavo Noronha Silva.

When adding a new member to _Ewk_View_Smart_Class,
EWK_VIEW_SMART_CLASS_VERSION needs to be updated.

* ewk/ewk_view.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed gardening: updating expectations after r117259
ossy@webkit.org [Wed, 16 May 2012 13:58:53 +0000 (13:58 +0000)]
Unreviewed gardening: updating expectations after r117259
https://bugs.webkit.org/show_bug.cgi?id=86463

* platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png: Added.
* platform/qt-5.0-wk2/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt: Added.
* platform/qt-5.0-wk2/svg/custom/altglyph-expected.png: Added.
* platform/qt-5.0-wk2/svg/custom/altglyph-expected.txt: Added.
* platform/qt-5.0-wk2/svg/custom/font-face-simple-expected.png: Added.
* platform/qt-5.0-wk2/svg/custom/font-face-simple-expected.txt: Added.
* platform/qt-5.0-wk2/svg/text/kerning-expected.png: Added.
* platform/qt-5.0-wk2/svg/text/kerning-expected.txt: Added.
* platform/qt-5.0-wk2/svg/text/multichar-glyph-expected.png: Added.
* platform/qt-5.0-wk2/svg/text/multichar-glyph-expected.txt: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.png: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/color-prop-05-t-expected.txt: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.png: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/coords-dom-01-f-expected.txt: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.png: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/coords-dom-02-f-expected.txt: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.png: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/coords-dom-03-f-expected.txt: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.png: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/coords-dom-04-f-expected.txt: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.png: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/filters-felem-01-b-expected.txt: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.png: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.png: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.txt: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.png: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.txt: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.png: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/painting-marker-07-f-expected.txt: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.png: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/paths-dom-02-f-expected.txt: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.png: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/pservers-grad-17-b-expected.txt: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.png: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/pservers-grad-20-b-expected.txt: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.png: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.png: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/struct-use-14-f-expected.txt: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.png: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.txt: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.png: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/svgdom-over-01-f-expected.txt: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.png: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.txt: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.png: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/text-tspan-02-b-expected.txt: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.png: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.png: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-02-f-expected.txt: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.png: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-03-b-expected.txt: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.png: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-04-b-expected.txt: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.png: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-05-b-expected.txt: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.png: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-06-f-expected.txt: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.png: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/types-dom-07-f-expected.txt: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1/animate-elem-06-t-expected.png: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1/filters-light-04-f-expected.png: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1/filters-light-04-f-expected.txt: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1/render-elems-06-t-expected.png: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1/render-elems-06-t-expected.txt: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1/render-elems-07-t-expected.png: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1/render-elems-07-t-expected.txt: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1/render-elems-08-t-expected.png: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1/render-elems-08-t-expected.txt: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1/render-groups-01-b-expected.png: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1/render-groups-03-t-expected.png: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1/text-text-01-b-expected.png: Added.
* platform/qt-5.0/svg/W3C-SVG-1.1/text-text-01-b-expected.txt: Added.
* platform/qt-5.0/svg/batik/text/smallFonts-expected.png: Added.
* platform/qt-5.0/svg/batik/text/smallFonts-expected.txt: Added.
* platform/qt-5.0/svg/batik/text/textAnchor-expected.png: Added.
* platform/qt-5.0/svg/batik/text/textAnchor-expected.txt: Added.
* platform/qt-5.0/svg/batik/text/textEffect-expected.png: Added.
* platform/qt-5.0/svg/batik/text/textEffect-expected.txt: Added.
* platform/qt-5.0/svg/batik/text/textEffect3-expected.png: Added.
* platform/qt-5.0/svg/batik/text/textEffect3-expected.txt: Added.
* platform/qt-5.0/svg/batik/text/textPosition2-expected.png: Added.
* platform/qt-5.0/svg/batik/text/textPosition2-expected.txt:
* platform/qt-5.0/svg/carto.net/window-expected.png: Added.
* platform/qt-5.0/svg/carto.net/window-expected.txt: Added.
* platform/qt-5.0/svg/custom/glyph-selection-arabic-forms-expected.png: Added.
* platform/qt-5.0/svg/custom/glyph-selection-arabic-forms-expected.txt:
* platform/qt-5.0/svg/custom/glyph-selection-bidi-mirror-expected.png: Added.
* platform/qt-5.0/svg/custom/glyph-selection-bidi-mirror-expected.txt:
* platform/qt-5.0/svg/custom/glyph-selection-non-bmp-expected.png: Added.
* platform/qt-5.0/svg/custom/glyph-selection-non-bmp-expected.txt:
* platform/qt-5.0/svg/custom/glyph-transformation-with-hkern-expected.png: Added.
* platform/qt-5.0/svg/custom/glyph-transformation-with-hkern-expected.txt: Added.
* platform/qt-5.0/svg/custom/preserve-aspect-ratio-syntax-expected.png: Added.
* platform/qt-5.0/svg/custom/preserve-aspect-ratio-syntax-expected.txt: Added.
* platform/qt-5.0/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.png:
* platform/qt-5.0/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
* platform/qt-5.0/svg/custom/svg-features-expected.txt: Added.
* platform/qt-5.0/svg/custom/svg-fonts-in-html-expected.png: Added.
* platform/qt-5.0/svg/custom/svg-fonts-in-html-expected.txt: Added.
* platform/qt-5.0/svg/custom/svg-fonts-segmented-expected.png: Added.
* platform/qt-5.0/svg/custom/svg-fonts-segmented-expected.txt: Added.
* platform/qt-5.0/svg/custom/text-linking-expected.png: Added.
* platform/qt-5.0/svg/custom/text-linking-expected.txt: Added.
* platform/qt-5.0/svg/foreignObject/text-tref-02-b-expected.png: Added.
* platform/qt-5.0/svg/foreignObject/text-tref-02-b-expected.txt: Added.
* platform/qt-5.0/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.png: Added.
* platform/qt-5.0/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.txt: Added.
* platform/qt-5.0/svg/text/text-align-01-b-expected.png: Added.
* platform/qt-5.0/svg/text/text-align-01-b-expected.txt: Added.
* platform/qt-5.0/svg/text/text-align-02-b-expected.png: Added.
* platform/qt-5.0/svg/text/text-align-02-b-expected.txt: Added.
* platform/qt-5.0/svg/text/text-align-04-b-expected.png: Added.
* platform/qt-5.0/svg/text/text-align-04-b-expected.txt: Added.
* platform/qt-5.0/svg/text/text-align-06-b-expected.png: Added.
* platform/qt-5.0/svg/text/text-align-06-b-expected.txt: Added.
* platform/qt-5.0/svg/text/text-overflow-ellipsis-svgfont-expected.png: Added.
* platform/qt-5.0/svg/text/text-overflow-ellipsis-svgfont-expected.txt: Added.
* platform/qt-5.0/svg/text/text-text-01-b-expected.png: Added.
* platform/qt-5.0/svg/text/text-text-01-b-expected.txt: Added.
* platform/qt-5.0/svg/text/text-text-04-t-expected.png: Added.
* platform/qt-5.0/svg/text/text-text-04-t-expected.txt: Added.
* platform/qt-5.0/svg/text/text-tselect-01-b-expected.png: Added.
* platform/qt-5.0/svg/text/text-tselect-01-b-expected.txt: Added.
* platform/qt-5.0/svg/text/text-tspan-01-b-expected.png: Added.
* platform/qt-5.0/svg/text/text-tspan-01-b-expected.txt: Added.
* platform/qt-5.0/svg/transforms/text-with-mask-with-svg-transform-expected.png: Added.
* platform/qt-5.0/svg/transforms/text-with-mask-with-svg-transform-expected.txt: Added.
* platform/qt-5.0/svg/transforms/text-with-pattern-inside-transformed-html-expected.png: Added.
* platform/qt-5.0/svg/transforms/text-with-pattern-inside-transformed-html-expected.txt: Added.
* platform/qt-5.0/svg/transforms/text-with-pattern-with-svg-transform-expected.png: Added.
* platform/qt-5.0/svg/transforms/text-with-pattern-with-svg-transform-expected.txt: Added.
* platform/qt-5.0/svg/wicd/test-rightsizing-b-expected.png: Added.
* platform/qt-5.0/svg/wicd/test-rightsizing-b-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: split ScriptMapping into UISourceCodeProvider and SourceMapping.
pfeldman@chromium.org [Wed, 16 May 2012 13:55:04 +0000 (13:55 +0000)]
Web Inspector: split ScriptMapping into UISourceCodeProvider and SourceMapping.
https://bugs.webkit.org/show_bug.cgi?id=86616

Reviewed by Vsevolod Vlasov.

Source/WebCore:

This change simply splits the interface.

* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/compile-front-end.py:
* inspector/front-end/CompilerScriptMapping.js:
(WebInspector.CompilerScriptMapping.prototype.get uiSourceCodes):
(WebInspector.CompilerScriptMapping.prototype.reset):
* inspector/front-end/DebuggerModel.js:
* inspector/front-end/DebuggerResourceBinding.js:
(WebInspector.DebuggerResourceBinding):
(WebInspector.DebuggerResourceBinding.prototype._uiSourceCodeForResource):
* inspector/front-end/DebuggerScriptMapping.js:
(WebInspector.DebuggerScriptMapping):
(WebInspector.DebuggerScriptMapping.prototype.uiSourceCodes):
(WebInspector.DebuggerScriptMapping.prototype._handleUISourceCodeAdded):
(WebInspector.DebuggerScriptMapping.prototype._handleUISourceCodeReplaced):
(WebInspector.DebuggerScriptMapping.prototype._handleUISourceCodeRemoved):
* inspector/front-end/FilteredItemSelectionDialog.js:
(WebInspector.OpenScriptDialog):
(WebInspector.OpenScriptDialog.install):
(WebInspector.OpenScriptDialog._show):
* inspector/front-end/PresentationConsoleMessageHelper.js:
(WebInspector.PresentationConsoleMessageHelper):
(WebInspector.PresentationConsoleMessageHelper.prototype._consoleCleared):
* inspector/front-end/ResourceScriptMapping.js:
(WebInspector.ResourceScriptMapping.prototype.uiSourceCodes):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeAdded):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeReplaced):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeRemoved):
* inspector/front-end/Script.js:
* inspector/front-end/ScriptSnippetModel.js:
(WebInspector.ScriptSnippetModel.prototype._uiSourceCodes):
(WebInspector.SnippetScriptMapping.prototype.uiSourceCodes):
(WebInspector.SnippetScriptMapping.prototype._fireUISourceCodeAdded):
(WebInspector.SnippetScriptMapping.prototype._fireUISourceCodeRemoved):
* inspector/front-end/ScriptsPanel.js:
* inspector/front-end/ScriptsSearchScope.js:
(WebInspector.ScriptsSearchScope):
(WebInspector.ScriptsSearchScope.prototype._sortedUISourceCodes):
* inspector/front-end/SourceMapping.js: Renamed from Source/WebCore/inspector/front-end/ScriptMapping.js.
* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCodeProvider):
(WebInspector.UISourceCodeProvider.prototype.uiSourceCodes):
(WebInspector.UILocation):
(WebInspector.UILocation.prototype.uiLocationToRawLocation):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:

LayoutTests:

* http/tests/inspector/compiler-script-mapping.html:
* inspector/debugger/scripts-panel.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd didFinishProgress BundleUIClient callback
commit-queue@webkit.org [Wed, 16 May 2012 13:47:38 +0000 (13:47 +0000)]
Add didFinishProgress BundleUIClient callback
https://bugs.webkit.org/show_bug.cgi?id=86541

Patch by Dinu Jacob <dinu.jacob@nokia.com> on 2012-05-16
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Added didFinishProgress BundleUIClient callback needed by
WebKitTestRunner. This callback is invoked in postProgressFinishedNotification.

* WebProcess/InjectedBundle/API/c/WKBundlePage.h:
* WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
(WebKit::InjectedBundlePageLoaderClient::didFinishProgress):
(WebKit):
* WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
(InjectedBundlePageLoaderClient):
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::postProgressFinishedNotification):
* WebProcess/qt/QtBuiltinBundlePage.cpp:
(WebKit::QtBuiltinBundlePage::QtBuiltinBundlePage):

Tools:

Added support for dumpProgressFinishedCallback.

* WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::InjectedBundlePage):
(WTR::InjectedBundlePage::didFinishProgress):
(WTR):
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:
(InjectedBundlePage):
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::LayoutTestController):
* WebKitTestRunner/InjectedBundle/LayoutTestController.h:
(WTR::LayoutTestController::dumpProgressFinishedCallback):
(WTR::LayoutTestController::setShouldDumpProgressFinishedCallback):
(WTR::LayoutTestController::shouldDumpProgressFinishedCallback):
(LayoutTestController):

LayoutTests:

Unskip passing test.

* platform/qt-5.0-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed gardening. Fix my typo.
kkristof@inf.u-szeged.hu [Wed, 16 May 2012 13:44:41 +0000 (13:44 +0000)]
[Qt] Unreviewed gardening. Fix my typo.

Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-05-16

* platform/qt/Skipped: After r117262.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Implement snippet creation/renaming in ScriptsNavigator.
vsevik@chromium.org [Wed, 16 May 2012 13:40:58 +0000 (13:40 +0000)]
Web Inspector: Implement snippet creation/renaming in ScriptsNavigator.
https://bugs.webkit.org/show_bug.cgi?id=82622

Reviewed by Pavel Feldman.

Implemented snippet creation and renaming.
Added TitleChanged event to UISourceCode.

* inspector/front-end/NavigatorOverlayController.js:
(WebInspector.NavigatorOverlayController.prototype._containingElementFocused):
(WebInspector.NavigatorOverlayController.prototype.isNavigatorPinned):
(WebInspector.NavigatorOverlayController.prototype.isNavigatorHidden):
* inspector/front-end/NavigatorView.js:
(WebInspector.NavigatorView.prototype._uiSourceCodeTitleChanged):
(WebInspector.NavigatorView.prototype._updateScriptTitle):
(WebInspector.NavigatorView.prototype._addUISourceCodeListeners):
(WebInspector.NavigatorView.prototype._removeUISourceCodeListeners):
(WebInspector.NavigatorView.prototype._fileRenamed):
(WebInspector.NavigatorScriptTreeElement.prototype.onattach):
* inspector/front-end/ScriptSnippetModel.js:
(WebInspector.ScriptSnippetModel.prototype._addScriptSnippet):
* inspector/front-end/ScriptsNavigator.js:
(WebInspector.ScriptsNavigator):
(WebInspector.ScriptsNavigator.prototype._snippetsNavigatorViewForUISourceCode):
(WebInspector.ScriptsNavigator.prototype.addUISourceCode):
(WebInspector.ScriptsNavigator.prototype.isScriptSourceAdded):
(WebInspector.ScriptsNavigator.prototype.revealUISourceCode):
(WebInspector.ScriptsNavigator.prototype.replaceUISourceCode):
(WebInspector.ScriptsNavigator.prototype.rename):
(WebInspector.ScriptsNavigator.prototype._fileRenamed):
(WebInspector.ScriptsNavigator.prototype._snippetCreationRequested):
(WebInspector.SnippetsNavigatorView.prototype._handleCreateSnippet):
(WebInspector.SnippetsNavigatorView.prototype._snippetCreationRequested):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.set _hideDebuggerSidebar):
(WebInspector.ScriptsPanel.prototype.set _fileRenamed):
(WebInspector.ScriptsPanel.prototype._snippetCreationRequested.callback):
(WebInspector.ScriptsPanel.prototype._snippetCreationRequested):
* inspector/front-end/TabbedEditorContainer.js:
(WebInspector.TabbedEditorContainer.prototype._appendFileTab):
(WebInspector.TabbedEditorContainer.prototype._tabClosed):
(WebInspector.TabbedEditorContainer.prototype._uiSourceCodeTitleChanged):
* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode.prototype.urlChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: gradient properties are painful to inspect / author.
apavlov@chromium.org [Wed, 16 May 2012 13:25:53 +0000 (13:25 +0000)]
Web Inspector: gradient properties are painful to inspect / author.
https://bugs.webkit.org/show_bug.cgi?id=86379

Reviewed by Pavel Feldman.

The CSS styles layout has been changed to allow property values to wrap onto subsequent lines
to let the users see the entire value text.

* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertyTreeElement.prototype.updateTitle.): Avoid line breaks between the color swatch and value.
* inspector/front-end/elementsPanel.css:
(.styles-section .properties li.not-parsed-ok img.exclamation-mark):
(.styles-section .properties li):
(.styles-section .properties li .webkit-css-property):
(.styles-section.expanded .properties > li):
(.styles-section .properties > li .webkit-css-property):
(.styles-section .properties > li.child-editing):
(.styles-section .properties > li.child-editing .webkit-css-property):
(.styles-section .properties .enabled-button):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: rename ProfileView.js to CPUProfileView.js
yurys@chromium.org [Wed, 16 May 2012 13:16:57 +0000 (13:16 +0000)]
Web Inspector: rename ProfileView.js to CPUProfileView.js
https://bugs.webkit.org/show_bug.cgi?id=86612

Reviewed by Pavel Feldman.

Renamed ProfileView.js to CPUProfileView.js to match the file content.

* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/compile-front-end.py:
* inspector/front-end/CPUProfileView.js: Renamed from Source/WebCore/inspector/front-end/ProfileView.js.
(WebInspector.CPUProfileView.profileCallback):
(WebInspector.CPUProfileView.prototype.get statusBarItems):
(WebInspector.CPUProfileView.prototype.get profile):
(WebInspector.CPUProfileView.prototype.set profile):
(WebInspector.CPUProfileView.prototype.get bottomUpProfileDataGridTree):
(WebInspector.CPUProfileView.prototype.get topDownProfileDataGridTree):
(WebInspector.CPUProfileView.prototype.get currentTree):
(WebInspector.CPUProfileView.prototype.set currentTree):
(WebInspector.CPUProfileView.prototype.willHide):
(WebInspector.CPUProfileView.prototype.refresh):
(WebInspector.CPUProfileView.prototype.refreshVisibleData):
(WebInspector.CPUProfileView.prototype.refreshShowAsPercents):
(WebInspector.CPUProfileView.prototype.searchCanceled):
(WebInspector.CPUProfileView.prototype.performSearch.matchesQuery):
(WebInspector.CPUProfileView.prototype.performSearch):
(WebInspector.CPUProfileView.prototype.jumpToFirstSearchResult):
(WebInspector.CPUProfileView.prototype.jumpToLastSearchResult):
(WebInspector.CPUProfileView.prototype.jumpToNextSearchResult):
(WebInspector.CPUProfileView.prototype.jumpToPreviousSearchResult):
(WebInspector.CPUProfileView.prototype.showingFirstSearchResult):
(WebInspector.CPUProfileView.prototype.showingLastSearchResult):
(WebInspector.CPUProfileView.prototype._jumpToSearchResult):
(WebInspector.CPUProfileView.prototype._changeView.set else):
(WebInspector.CPUProfileView.prototype._focusClicked):
(WebInspector.CPUProfileView.prototype._excludeClicked):
(WebInspector.CPUProfileView.prototype._resetClicked):
(WebInspector.CPUProfileView.prototype._dataGridNodeSelected):
(WebInspector.CPUProfileView.prototype._dataGridNodeDeselected):
(WebInspector.CPUProfileView.prototype._sortProfile):
(WebInspector.CPUProfileView.prototype._assignParentsInProfile):
(WebInspector.CPUProfileType):
(WebInspector.CPUProfileType.prototype.get buttonTooltip):
(WebInspector.CPUProfileType.prototype.buttonClicked):
(WebInspector.CPUProfileType.prototype.get treeItemTitle):
(WebInspector.CPUProfileType.prototype.get description):
(WebInspector.CPUProfileType.prototype.isRecordingProfile):
(WebInspector.CPUProfileType.prototype.startRecordingProfile):
(WebInspector.CPUProfileType.prototype.stopRecordingProfile):
(WebInspector.CPUProfileType.prototype.setRecordingProfile):
(WebInspector.CPUProfileType.prototype.createSidebarTreeElementForProfile):
(WebInspector.CPUProfileType.prototype.createView):
(WebInspector.CPUProfileType.prototype.createTemporaryProfile):
(WebInspector.CPUProfileType.prototype.createProfile):
* inspector/front-end/HeapSnapshotView.js:
(WebInspector.HeapSnapshotView.prototype.performSearch.matchesByName):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago"border: collapse" + "display: none" rows in the tbody while having thead or tfoot...
commit-queue@webkit.org [Wed, 16 May 2012 12:53:28 +0000 (12:53 +0000)]
"border: collapse" + "display: none" rows in the tbody while having thead or tfoot doesn't render the opposite border
https://bugs.webkit.org/show_bug.cgi?id=67877

Patch by Arpita Bahuguna <arpitabahuguna@gmail.com> on 2012-05-16
Reviewed by Antti Koivisto.

Source/WebCore:

Test: fast/css/table-collapsed-borders.html

* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::computeCollapsedBeforeBorder):
When getting the previous row group's after border, pass SkipEmptySections as the second param
to the RenderTable::sectionAbove() call. Thus if the currSection is the top most section of the
table passing SkipEmptySections to sectionAbove() would return null which should be the expected
behavior.

(WebCore::RenderTableCell::computeCollapsedAfterBorder):
When getting the following row group's before border, pass SkipEmptySections as the second param
to the RenderTable::sectionBelow() call. Thus if the currSection is the bottom most section of the
table passing SkipEmptySections to sectionBelow() would return null which should be the expected
behavior.

LayoutTests:

* fast/css/table-collapsed-borders-expected.html: Added.
* fast/css/table-collapsed-borders.html: Added.
Added new reftest for testing table with collapsed borders.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: follow up to r117267 - fixing typo and removing unnecessary dispatch.
pfeldman@chromium.org [Wed, 16 May 2012 12:48:50 +0000 (12:48 +0000)]
Web Inspector: follow up to r117267 - fixing typo and removing unnecessary dispatch.
https://bugs.webkit.org/show_bug.cgi?id=86613

Reviewed by Vsevolod Vlasov.

* inspector/front-end/ResourceScriptMapping.js:
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeAdded):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeReplaced):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Move edit/save script source logic to JavaScriptSource.
vsevik@chromium.org [Wed, 16 May 2012 12:41:26 +0000 (12:41 +0000)]
Web Inspector: Move edit/save script source logic to JavaScriptSource.
https://bugs.webkit.org/show_bug.cgi?id=86604

Reviewed by Pavel Feldman.

Source/WebCore:

Added working copy notion to UISourceCode.
Moved DebuggerResourceBinding content edit calls to JavaScriptSource.
Added WorkingCopyChanged event to UISourceCode.

* inspector/front-end/CompilerScriptMapping.js:
* inspector/front-end/DebuggerResourceBinding.js:
(WebInspector.DebuggerResourceBinding.prototype.canSetContent):
* inspector/front-end/JavaScriptSource.js:
(WebInspector.JavaScriptSource):
(WebInspector.JavaScriptSource.prototype.breakpointStorageId):
(WebInspector.JavaScriptSource.prototype.isEditable):
(WebInspector.JavaScriptSource.prototype.commitWorkingCopy):
(WebInspector):
* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype.wasShown):
(WebInspector.JavaScriptSourceFrame.prototype.canEditSource):
(WebInspector.JavaScriptSourceFrame.prototype.commitEditing):
(WebInspector.JavaScriptSourceFrame.prototype.afterTextChanged):
(WebInspector.JavaScriptSourceFrame.prototype.beforeTextChanged):
(WebInspector.JavaScriptSourceFrame.prototype._didEditContent):
(WebInspector.JavaScriptSourceFrame.prototype._onMouseDown):
* inspector/front-end/NavigatorView.js:
(WebInspector.NavigatorView.prototype._uiSourceCodeWorkingCopyChanged):
(WebInspector.NavigatorView.prototype._uiSourceCodeContentChanged):
(WebInspector.NavigatorView.prototype._updateScriptTitle):
(WebInspector.NavigatorView.prototype._removeUISourceCode):
(WebInspector.NavigatorView.prototype._addUISourceCodeListeners):
(WebInspector.NavigatorView.prototype._removeUISourceCodeListeners):
(WebInspector.NavigatorView.prototype.reset):
* inspector/front-end/RawSourceCode.js:
(WebInspector.RawSourceCode.prototype._createUISourceCode):
* inspector/front-end/ScriptSnippetModel.js:
(WebInspector.ScriptSnippetModel.prototype._addScriptSnippet):
(WebInspector.ScriptSnippetModel.prototype._createUISourceCodeForScript):
* inspector/front-end/ScriptsPanel.js:
* inspector/front-end/TabbedEditorContainer.js:
(WebInspector.TabbedEditorContainer):
(WebInspector.TabbedEditorContainer.prototype._titleForFile):
(WebInspector.TabbedEditorContainer.prototype._appendFileTab):
(WebInspector.TabbedEditorContainer.prototype._tabClosed):
(WebInspector.TabbedEditorContainer.prototype._updateFileTitle.get if):
(WebInspector.TabbedEditorContainer.prototype._updateFileTitle):
(WebInspector.TabbedEditorContainer.prototype._uiSourceCodeWorkingCopyChanged):
(WebInspector.TabbedEditorContainer.prototype._uiSourceCodeContentChanged):
* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.contentChanged):
(WebInspector.UISourceCode.prototype.isEditable):
(WebInspector.UISourceCode.prototype.workingCopy):
(WebInspector.UISourceCode.prototype.setWorkingCopy):
(WebInspector.UISourceCode.prototype.isDirty):
(WebInspector.UISourceCode.prototype.commitWorkingCopy):

LayoutTests:

* inspector/debugger/breakpoint-manager.html:
* inspector/debugger/scripts-panel.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] A few tests need expected result or rebaselining
commit-queue@webkit.org [Wed, 16 May 2012 12:36:22 +0000 (12:36 +0000)]
[EFL] A few tests need expected result or rebaselining
https://bugs.webkit.org/show_bug.cgi?id=86595

Unreviewed EFL gardening. Add missing EFL text expectation for
media/video-frame-accurate-seek.html.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-16

* platform/efl/media/video-frame-accurate-seek-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: get rid of UISourceCodeListChanged event.
pfeldman@chromium.org [Wed, 16 May 2012 12:22:29 +0000 (12:22 +0000)]
Web Inspector: get rid of UISourceCodeListChanged event.
https://bugs.webkit.org/show_bug.cgi?id=86601

Reviewed by Vsevolod Vlasov.

Source/WebCore:

There was unnecessary conversion between this event and UISourceCodeAdded/Removed/Replaced.

* inspector/front-end/CompilerScriptMapping.js:
(WebInspector.CompilerScriptMapping.prototype.reset):
* inspector/front-end/DebuggerScriptMapping.js:
(WebInspector.DebuggerScriptMapping):
(WebInspector.DebuggerScriptMapping.prototype._handleUISourceCodeAdded):
(WebInspector.DebuggerScriptMapping.prototype._handleUISourceCodeReplaced):
(WebInspector.DebuggerScriptMapping.prototype._handleUISourceCodeRemoved):
* inspector/front-end/NavigatorView.js:
* inspector/front-end/ResourceScriptMapping.js:
(WebInspector.ResourceScriptMapping.prototype.addScript):
(WebInspector.ResourceScriptMapping.prototype._handleUISourceCodeChanged):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeAdded):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeReplaced):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeRemoved):
(WebInspector.ResourceScriptMapping.prototype.reset):
* inspector/front-end/ScriptMapping.js:
* inspector/front-end/ScriptSnippetModel.js:
(WebInspector.ScriptSnippetModel.prototype._addScriptSnippet):
(WebInspector.ScriptSnippetModel.prototype._createUISourceCodeForScript):
(WebInspector.ScriptSnippetModel.prototype._reset):
(WebInspector.SnippetScriptMapping.prototype._fireUISourceCodeAdded):
(WebInspector.SnippetScriptMapping.prototype._fireUISourceCodeRemoved):
* inspector/front-end/ScriptsNavigator.js:
(WebInspector.ScriptsNavigator.prototype.replaceUISourceCode):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._uiSourceCodeReplaced):
* inspector/front-end/TabbedEditorContainer.js:

LayoutTests:

* http/tests/inspector/compiler-script-mapping.html:
* inspector/debugger/scripts-panel.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Layout tests under inspector/profiler are failing on chromium win
yurys@chromium.org [Wed, 16 May 2012 12:07:25 +0000 (12:07 +0000)]
[chromium] Layout tests under inspector/profiler are failing on chromium win
https://bugs.webkit.org/show_bug.cgi?id=86495

Unreviewed. Remove custom expectations for heap profiler tests. They should pass
after r117241.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Remove full-screen-keyboard-disabled.html from test_expectation.txt
commit-queue@webkit.org [Wed, 16 May 2012 12:00:33 +0000 (12:00 +0000)]
[EFL] Remove full-screen-keyboard-disabled.html from test_expectation.txt
https://bugs.webkit.org/show_bug.cgi?id=86596

Unreviewed EFL gardening.

Remove full-screen-keyboard-disabled.html from test_expectation.txt.
This case is not failed since r117205.

Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-05-16

* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] [DRT] Unskip passing tests related to computedStyleIncludingVisitedInfo and...
commit-queue@webkit.org [Wed, 16 May 2012 11:58:01 +0000 (11:58 +0000)]
[EFL] [DRT] Unskip passing tests related to computedStyleIncludingVisitedInfo and display
https://bugs.webkit.org/show_bug.cgi?id=86473

Unreviewed gardening, partially reverts r117073.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-16

* platform/efl/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Add WebKit API to access inner text value of input element
keishi@webkit.org [Wed, 16 May 2012 11:55:20 +0000 (11:55 +0000)]
[chromium] Add WebKit API to access inner text value of input element
https://bugs.webkit.org/show_bug.cgi?id=85353

Reviewed by Kent Tamura.

.:

* Source/autotools/symbols.filter: Added HTMLInputElement::setEditingValue

Source/WebCore:

Test: fast/forms/editing-value.html

We need this to implement the datalist UI for  <input type=email multiple>.
HTMLInputElement.value gives you the sanitized value so the whitespace between values are trimmed.
We need to append the selected suggestion to the end without modifying the rest of the text.

* WebCore.exp.in: Added HTMLInputElement::setEditingValue
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setEditingValue):
(WebCore):
* html/HTMLInputElement.h:
(HTMLInputElement):
* testing/Internals.cpp:
(WebCore::Internals::setEditingValue):
(WebCore):
* testing/Internals.h:
(Internals):
* testing/Internals.idl:

Source/WebKit/chromium:

* public/WebInputElement.h:
(WebInputElement):
* src/WebInputElement.cpp:
(WebKit::WebInputElement::editingValue):
(WebKit):
(WebKit::WebInputElement::setEditingValue):

Source/WebKit2:

* win/WebKit2.def: Added HTMLInputElement::setEditingValue
* win/WebKit2CFLite.def: Added HTMLInputElement::setEditingValue

LayoutTests:

* fast/forms/editing-value-expected.txt: Added.
* fast/forms/editing-value.html: Added. Tests that setting the editing value takes care of the style and placeholder, and that it fires an input event.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Gardening. Skip failing test after 117246.
kkristof@inf.u-szeged.hu [Wed, 16 May 2012 11:47:13 +0000 (11:47 +0000)]
[Qt] Gardening. Skip failing test after 117246.
https://bugs.webkit.org/show_bug.cgi?id=86606

Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-05-16
Reviewed by Csaba Osztrongonác.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Cookies should be checked during parsing to improve performance.
commit-queue@webkit.org [Wed, 16 May 2012 11:43:14 +0000 (11:43 +0000)]
[BlackBerry] Cookies should be checked during parsing to improve performance.
https://bugs.webkit.org/show_bug.cgi?id=85028

Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-05-16
Reviewed by George Staikos.

We shouldn't waste time and memery on invalid cookies. It is better to drop them during parsing.
We shouldn't check the default domain since it is set with host. So we only check domains which are parsed
from response headers.

No new tests. No functionality change.

* platform/blackberry/CookieManager.cpp:
(WebCore::CookieManager::setCookies):
* platform/blackberry/CookieManager.h:
* platform/blackberry/CookieParser.cpp:
(WebCore::CookieParser::parseOneCookie):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed gardening: updating expectations after r117259
pierre.rossi@gmail.com [Wed, 16 May 2012 11:36:30 +0000 (11:36 +0000)]
Unreviewed gardening: updating expectations after r117259
https://bugs.webkit.org/show_bug.cgi?id=86463

* platform/qt/http/tests/misc/SVGFont-delayed-load-expected.txt: Added.
* platform/qt/svg/W3C-SVG-1.1/animate-elem-03-t-expected.png:
* platform/qt/svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt:
* platform/qt/svg/W3C-SVG-1.1/animate-elem-24-t-expected.png:
* platform/qt/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
* platform/qt/svg/W3C-SVG-1.1/animate-elem-36-t-expected.png:
* platform/qt/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt:
* platform/qt/svg/W3C-SVG-1.1/animate-elem-40-t-expected.png:
* platform/qt/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt:
* platform/qt/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png: Added.
* platform/qt/svg/W3C-SVG-1.1/animate-elem-80-t-expected.txt: Added.
* platform/qt/svg/W3C-SVG-1.1/fonts-elem-01-t-expected.png:
* platform/qt/svg/W3C-SVG-1.1/fonts-elem-01-t-expected.txt:
* platform/qt/svg/W3C-SVG-1.1/fonts-elem-02-t-expected.png:
* platform/qt/svg/W3C-SVG-1.1/fonts-elem-02-t-expected.txt:
* platform/qt/svg/W3C-SVG-1.1/fonts-elem-03-b-expected.png:
* platform/qt/svg/W3C-SVG-1.1/fonts-elem-03-b-expected.txt:
* platform/qt/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.png:
* platform/qt/svg/W3C-SVG-1.1/fonts-elem-04-b-expected.txt:
* platform/qt/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.png:
* platform/qt/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt:
* platform/qt/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.png:
* platform/qt/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt:
* platform/qt/svg/W3C-SVG-1.1/fonts-elem-07-b-expected.png:
* platform/qt/svg/W3C-SVG-1.1/fonts-elem-07-b-expected.txt:
* platform/qt/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.png:
* platform/qt/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt:
* platform/qt/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.png:
* platform/qt/svg/W3C-SVG-1.1/fonts-glyph-03-t-expected.txt:
* platform/qt/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.png:
* platform/qt/svg/W3C-SVG-1.1/fonts-kern-01-t-expected.txt:
* platform/qt/svg/W3C-SVG-1.1/masking-mask-01-b-expected.png:
* platform/qt/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
* platform/qt/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.png:
* platform/qt/svg/W3C-SVG-1.1/pservers-grad-08-b-expected.txt:
* platform/qt/svg/W3C-SVG-1.1/struct-cond-03-t-expected.png:
* platform/qt/svg/W3C-SVG-1.1/struct-cond-03-t-expected.txt:
* platform/qt/svg/W3C-SVG-1.1/struct-image-02-b-expected.png:
* platform/qt/svg/W3C-SVG-1.1/struct-image-02-b-expected.txt:
* platform/qt/svg/W3C-SVG-1.1/text-align-08-b-expected.png:
* platform/qt/svg/W3C-SVG-1.1/text-align-08-b-expected.txt:
* platform/qt/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.png:
* platform/qt/svg/W3C-SVG-1.1/text-altglyph-01-b-expected.txt:
* platform/qt/svg/W3C-SVG-1.1/text-fonts-03-t-expected.png:
* platform/qt/svg/W3C-SVG-1.1/text-fonts-03-t-expected.txt:
* platform/qt/svg/W3C-SVG-1.1/text-intro-01-t-expected.png:
* platform/qt/svg/W3C-SVG-1.1/text-intro-01-t-expected.txt:
* platform/qt/svg/W3C-SVG-1.1/text-intro-02-b-expected.png:
* platform/qt/svg/W3C-SVG-1.1/text-intro-02-b-expected.txt:
* platform/qt/svg/W3C-SVG-1.1/text-intro-03-b-expected.png:
* platform/qt/svg/W3C-SVG-1.1/text-intro-03-b-expected.txt:
* platform/qt/svg/W3C-SVG-1.1/text-intro-04-t-expected.png:
* platform/qt/svg/W3C-SVG-1.1/text-intro-04-t-expected.txt:
* platform/qt/svg/W3C-SVG-1.1/text-text-04-t-expected.png:
* platform/qt/svg/W3C-SVG-1.1/text-text-04-t-expected.txt:
* platform/qt/svg/W3C-SVG-1.1/text-text-05-t-expected.png:
* platform/qt/svg/W3C-SVG-1.1/text-text-05-t-expected.txt:
* platform/qt/svg/W3C-SVG-1.1/text-text-06-t-expected.png:
* platform/qt/svg/W3C-SVG-1.1/text-text-06-t-expected.txt:
* platform/qt/svg/custom/acid3-test-77-expected.txt: Added.
* platform/qt/svg/custom/altglyph-expected.png:
* platform/qt/svg/custom/altglyph-expected.txt:
* platform/qt/svg/custom/font-face-simple-expected.png:
* platform/qt/svg/custom/font-face-simple-expected.txt:
* platform/qt/svg/custom/global-constructors-expected.txt: Added.
* platform/qt/svg/custom/glyph-selection-lang-attribute-expected.png:
* platform/qt/svg/custom/glyph-selection-lang-attribute-expected.txt:
* platform/qt/svg/custom/glyph-setting-d-attribute-expected.png:
* platform/qt/svg/custom/glyph-setting-d-attribute-expected.txt: Added.
* platform/qt/svg/custom/insertItemBefore-from-non-list-origin-expected.txt: Added.
* platform/qt/svg/custom/missing-xlink-expected.png: Added.
* platform/qt/svg/custom/missing-xlink-expected.txt: Added.
* platform/qt/svg/custom/path-bad-data-expected.png: Added.
* platform/qt/svg/custom/path-bad-data-expected.txt: Added.
* platform/qt/svg/custom/stroke-width-click-expected.txt: Added.
* platform/qt/svg/custom/svg-fonts-with-no-element-reference-expected.png:
* platform/qt/svg/custom/svg-fonts-with-no-element-reference-expected.txt:
* platform/qt/svg/custom/svg-fonts-without-missing-glyph-expected.png:
* platform/qt/svg/custom/svg-fonts-without-missing-glyph-expected.txt:
* platform/qt/svg/custom/svg-fonts-word-spacing-expected.png: Added.
* platform/qt/svg/custom/svg-fonts-word-spacing-expected.txt: Added.
* platform/qt/svg/custom/visibility-override-filter-expected.png: Copied from LayoutTests/platform/qt/svg/custom/glyph-setting-d-attribute-expected.png.
* platform/qt/svg/custom/visibility-override-filter-expected.txt: Added.
* platform/qt/svg/dom/altGlyph-dom-expected.txt:
* platform/qt/svg/dom/baseVal-animVal-crash-expected.txt: Added.
* platform/qt/svg/dom/font-face-elements-expected.txt: Added.
* platform/qt/svg/text/kerning-expected.png:
* platform/qt/svg/text/kerning-expected.txt:
* platform/qt/svg/text/multichar-glyph-expected.png:
* platform/qt/svg/text/multichar-glyph-expected.txt:
* platform/qt/svg/text/text-altglyph-01-b-expected.png:
* platform/qt/svg/text/text-altglyph-01-b-expected.txt:
* platform/qt/svg/text/text-fonts-01-t-expected.png: Added.
* platform/qt/svg/text/text-fonts-01-t-expected.txt: Added.
* platform/qt/svg/text/text-hkern-expected.png:
* platform/qt/svg/text/text-hkern-expected.txt:
* platform/qt/svg/text/text-hkern-on-vertical-text-expected.png:
* platform/qt/svg/text/text-intro-05-t-expected.png: Added.
* platform/qt/svg/text/text-intro-05-t-expected.txt: Added.
* platform/qt/svg/text/text-text-04-t-expected.png:
* platform/qt/svg/text/text-text-04-t-expected.txt:
* platform/qt/svg/text/text-text-05-t-expected.png:
* platform/qt/svg/text/text-text-05-t-expected.txt:
* platform/qt/svg/text/text-text-06-t-expected.png:
* platform/qt/svg/text/text-text-06-t-expected.txt:
* platform/qt/svg/text/text-tselect-02-f-expected.png: Added.
* platform/qt/svg/text/text-tselect-02-f-expected.txt: Added.
* platform/qt/svg/text/text-vkern-expected.png:
* platform/qt/svg/text/text-vkern-expected.txt:
* platform/qt/svg/text/text-vkern-on-horizontal-text-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Enable SVG Fonts by default
pierre.rossi@gmail.com [Wed, 16 May 2012 11:29:14 +0000 (11:29 +0000)]
[Qt] Enable SVG Fonts by default
https://bugs.webkit.org/show_bug.cgi?id=86463

Reviewed by Nikolas Zimmermann.

Source/WebCore:

Another feature we can get for free after switching to using
the font fast path with QRawFont.
It will get disabled in features.prf if either SVG support is
disabled or if we are not using QRawFont (e.g. for Qt 4).

Covered by a series of tests that were skipped for the
Qt port up until now.

* platform/graphics/qt/FontPlatformData.h:
(WebCore::FontPlatformDataPrivate::FontPlatformDataPrivate):
Initialize the platform data used as fallback in conjunction with SVG
fonts so it will honor size, weight and oblique-ness.
* rendering/svg/SVGTextMetricsBuilder.cpp: Avoid forcing the complex path.
(WebCore::SVGTextMetricsBuilder::advance):
(WebCore::SVGTextMetricsBuilder::advanceSimpleText):
(WebCore::SVGTextMetricsBuilder::initializeMeasurementWithTextRenderer):
* svg/SVGFontElement.cpp:
(WebCore::SVGFontElement::ensureGlyphCache): avoid ambiguity with String(const QString&)

Tools:

* qmake/mkspecs/features/features.pri:

LayoutTests:

* platform/qt-4.8/Skipped: Skipped the relevant tests...
* platform/qt/Skipped: ... and unskipped them here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] EFL's LayoutTestController does not implement setApplicationCacheOriginQuota
commit-queue@webkit.org [Wed, 16 May 2012 11:26:49 +0000 (11:26 +0000)]
[EFL] EFL's LayoutTestController does not implement setApplicationCacheOriginQuota
https://bugs.webkit.org/show_bug.cgi?id=85585

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-16
Reviewed by Gustavo Noronha Silva.

Source/WebKit/efl:

Add new function to Ewk_Security_Origin to set the application cache
quota. Implement reachedApplicationCacheOriginQuota in
ChromeClientEfl. Add function to the Ewk_View to report that the
application cache quota was reached.

* WebCoreSupport/ChromeClientEfl.cpp:
(WebCore::ChromeClientEfl::reachedApplicationCacheOriginQuota):
* ewk/ewk_security_origin.cpp:
(ewk_security_origin_application_cache_quota_set):
* ewk/ewk_security_origin.h:
* ewk/ewk_view.cpp:
(_Ewk_View_Private_Data):
(ewk_view_exceeded_application_cache_quota):
* ewk/ewk_view.h:
* ewk/ewk_view_private.h:

Tools:

Implement setApplicationCacheOriginQuota in EFL's
LayoutTestController.

* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):
* DumpRenderTree/efl/DumpRenderTreeView.cpp:
(onExceededApplicationCacheQuota):
(drtViewAdd):
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::setApplicationCacheOriginQuota):

LayoutTests:

Unskip the test cases that require implementation of
setApplicationCacheOriginQuota in EFL's LayoutTestController.

* platform/efl/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] WebTransformationMatrixTest.verifyDefaultConstructorCreatesIdentityMatrix...
bashi@chromium.org [Wed, 16 May 2012 11:20:21 +0000 (11:20 +0000)]
[Chromium] WebTransformationMatrixTest.verifyDefaultConstructorCreatesIdentityMatrix is failing
https://bugs.webkit.org/show_bug.cgi?id=86589

Reviewed by Kent Tamura.

Source/Platform:

* chromium/public/WebTransformationMatrix.h: Added destructor.
(WebTransformationMatrix):

Source/WebCore:

Need to call m_private.reset(0) before destructing WebTransformationMatrix objects.

No new tests. WebTransformationMatrixTest should pass on debug build.

* platform/chromium/support/WebTransformationMatrix.cpp:
(WebKit::WebTransformationMatrix::~WebTransformationMatrix):
(WebKit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] A few tests need expected result or rebaselining
commit-queue@webkit.org [Wed, 16 May 2012 11:13:06 +0000 (11:13 +0000)]
[EFL] A few tests need expected result or rebaselining
https://bugs.webkit.org/show_bug.cgi?id=86595

Unreviewed EFL gardening. Add expected results for a few tests and
unskip them.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-16

* platform/efl/Skipped:
* platform/efl/fast/forms/input-text-double-click-expected.png: Added.
* platform/efl/fast/forms/input-text-double-click-expected.txt:
* platform/efl/http/tests/misc/slow-loading-mask-expected.png: Added.
* platform/efl/http/tests/misc/slow-loading-mask-expected.txt: Added.
* platform/efl/media/video-frame-accurate-seek-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] EFL's LayoutTestController evaluateScriptInIsolatedWorld implementation
commit-queue@webkit.org [Wed, 16 May 2012 11:03:47 +0000 (11:03 +0000)]
[EFL] EFL's LayoutTestController  evaluateScriptInIsolatedWorld implementation
https://bugs.webkit.org/show_bug.cgi?id=83776

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-16
Reviewed by Tor Arne Vestbø.

Source/WebKit/efl:

Added helper new function implementing JS script evaluation in an isolated world.
Worlds are cached by their id.

* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::evaluateScriptInIsolatedWorld):
* WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

Added missing implementation of LayoutTestController::evaluateScriptInIsolatedWorld().

* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::evaluateScriptInIsolatedWorld):

LayoutTests:

Unskipped corresponding testcases.

* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] Move WebFrameNetworkingContext to WebKit namespace.
commit-queue@webkit.org [Wed, 16 May 2012 10:43:17 +0000 (10:43 +0000)]
[Qt][WK2] Move WebFrameNetworkingContext to WebKit namespace.
https://bugs.webkit.org/show_bug.cgi?id=86590

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-05-16
Reviewed by Simon Hausmann.

* WebProcess/WebCoreSupport/qt/WebFrameNetworkingContext.cpp:
(WebKit::WebFrameNetworkingContext::WebFrameNetworkingContext):
(WebKit::WebFrameNetworkingContext::create):
* WebProcess/WebCoreSupport/qt/WebFrameNetworkingContext.h:
(WebKit):
(WebFrameNetworkingContext):
(WebKit::WebFrameNetworkingContext::originatingObject):
(WebKit::WebFrameNetworkingContext::~WebFrameNetworkingContext):
(WebKit::WebFrameNetworkingContext::networkAccessManager):
(WebKit::WebFrameNetworkingContext::mimeSniffingEnabled):
(WebKit::WebFrameNetworkingContext::thirdPartyCookiePolicyPermission):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] http/tests/misc/iframe-reparenting-id-collision.html can be unskipped
commit-queue@webkit.org [Wed, 16 May 2012 10:34:01 +0000 (10:34 +0000)]
[EFL] http/tests/misc/iframe-reparenting-id-collision.html can be unskipped
https://bugs.webkit.org/show_bug.cgi?id=86588

Unreviewed EFL gardening. Unskip
http/tests/misc/iframe-reparenting-id-collision.html which is passing
now that Bug 64085 is closed.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-16

* platform/efl/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Add myself as a committer.
g.czajkowski@samsung.com [Wed, 16 May 2012 10:27:52 +0000 (10:27 +0000)]
Unreviewed. Add myself as a committer.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSpeech JavaScript API: pass WebSecurityOrigin to embedder
hans@chromium.org [Wed, 16 May 2012 10:24:51 +0000 (10:24 +0000)]
Speech JavaScript API: pass WebSecurityOrigin to embedder
https://bugs.webkit.org/show_bug.cgi?id=86348

Reviewed by Adam Barth.

Pass the WebSecurityOrigin of the SpeecReco object to the embedder when calling
start(). The origin will be used to determine whether speech recognition is
allowed or not.

* public/WebSpeechRecognitionParams.h:
(WebKit::WebSpeechRecognitionParams::WebSpeechRecognitionParams):
(WebKit::WebSpeechRecognitionParams::origin):
(WebSpeechRecognitionParams):
* src/SpeechRecognitionClientProxy.cpp:
(WebKit::SpeechRecognitionClientProxy::start):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed GTK gardening after r117123 and r117225.
zandobersek@gmail.com [Wed, 16 May 2012 10:19:35 +0000 (10:19 +0000)]
Unreviewed GTK gardening after r117123 and r117225.

* platform/gtk/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoShadowRoot.selection should return the seleciton whose range is in a shadow tree.
shinyak@chromium.org [Wed, 16 May 2012 10:08:23 +0000 (10:08 +0000)]
ShadowRoot.selection should return the seleciton whose range is in a shadow tree.
https://bugs.webkit.org/show_bug.cgi?id=82698

Reviewed by Ryosuke Niwa.

Source/WebCore:

The selection object returned from shadowRoot.selection should be able to see
the inner object of the shadowRoot.

In the previous code, the node out of the shadow subtree was returned for
anchorNode, focusNode, baseNode, and extentNode. This patch enables us to get
the corresponding shadow ancestor in the specified TreeScope (m_treeScope).

Tests: editing/shadow/selection-of-orphan-shadowroot.html
       editing/shadow/selection-of-shadowroot.html

* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::selection):
* dom/ShadowRoot.h:
(ShadowRoot):
* dom/TreeScope.cpp:
(WebCore::TreeScope::getSelection): When shadow DOM feature is not enabled, we want to use the same
instance of DOMSelection among Document and ShadowRoot.
* dom/TreeScopeAdjuster.cpp:
(WebCore::TreeScopeAdjuster::TreeScopeAdjuster):
(WebCore::TreeScopeAdjuster::ancestorInThisScope): Since node could be null, I've added a node check code.
* dom/TreeScopeAdjuster.h:
(TreeScopeAdjuster):
(WebCore::TreeScopeAdjuster::treeScope):
* page/DOMSelection.cpp:
(WebCore::DOMSelection::anchorNode):
(WebCore::DOMSelection::anchorOffset):
(WebCore::DOMSelection::focusNode):
(WebCore::DOMSelection::focusOffset):
(WebCore::DOMSelection::baseNode):
(WebCore::DOMSelection::baseOffset):
(WebCore::DOMSelection::extentNode):
(WebCore::DOMSelection::extentOffset):
(WebCore::DOMSelection::shadowAdjustedNode): Gets the corresponding node in the m_treeScope from the Position.
(WebCore):
(WebCore::DOMSelection::shadowAdjustedOffset): Gets the corresponding node offset in the m_treeScope from the Position.
* page/DOMSelection.h:
(WebCore):
(DOMSelection):

LayoutTests:

This patch contains 2 tests:
- Generates a complex HTML tree having a ShadowRoot, an older ShadowRoot, a nested ShadowRoot,
nested ShadowRoot in an older ShadowRoot, etc., and try to drag from a nested shadow root of
older shadow root to a nested shadow root of younger shadow root. Then checks nodes of Shadowroot.selection
are in the same tree scope or null.
- Generates a ShadowDOM which is not inserted into a document, and confirms nodes taken from
the selection are all null.

Also, this patch deprecates old shadowRoot.selection tests, because they test to check
window.getSelection() and shadowRoot.selection is the same. This behavior is changed by this patch.

* editing/shadow/selection-of-orphan-shadowroot-expected.txt: Added.
* editing/shadow/selection-of-orphan-shadowroot.html: Added.
* editing/shadow/selection-of-shadowroot-expected.txt: Added.
* editing/shadow/selection-of-shadowroot.html: Added.
* fast/dom/resources/event-sender-util.js:
(mouseMoveToElem):
(dragFromTo):
* fast/dom/shadow/resources/shadow-dom-util.js: Added.
(getElementByIdConsideringShadowDOM.iter):
(getElementByIdConsideringShadowDOM):
* fast/dom/shadow/selection-in-shadow.html: Removed.
* platform/chromium-mac-snowleopard/fast/dom/shadow/selection-in-shadow-expected.txt: Removed.
* platform/chromium/fast/dom/shadow/selection-in-shadow-expected.txt: Removed.
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[WTR] Visited link tracking is not disabled properly
abecsi@webkit.org [Wed, 16 May 2012 09:58:59 +0000 (09:58 +0000)]
[WTR] Visited link tracking is not disabled properly
https://bugs.webkit.org/show_bug.cgi?id=76699

Reviewed by Jocelyn Turcotte.

Source/WebKit2:

If PLATFORM_STRATEGIES is enabled visited link tracking is done through
VisitedLinkProvider and not through PageGroup.
InjectedBundle sets the shouldTrackVisitedLinks flag on the PageGroup,
thus the shared VisitedLinkTable does get populated with visited links
regardless of the flag.

The WebProcess should only track visited links if tracking is specifically
enabled for a test through WTR's LayoutTestController.

This patch fixes several flacky and failing layout tests on Qt-WK2.

* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::setShouldTrackVisitedLinks): Let the WebProcess
know about visited link tracking.
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::setShouldTrackVisitedLinks):
(WebKit::WebProcess::addVisitedLink):
* WebProcess/WebProcess.h:
(WebProcess):

LayoutTests:

* platform/qt-5.0-wk2/Skipped: Unskip passing tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Unreviewed test expectations update
bashi@chromium.org [Wed, 16 May 2012 09:54:21 +0000 (09:54 +0000)]
[Chromium] Unreviewed test expectations update

Adding further suppressions for flaky tests on cr-linux ews.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] xhr request to non existent file response is 0 and not 404.
commit-queue@webkit.org [Wed, 16 May 2012 09:46:18 +0000 (09:46 +0000)]
[BlackBerry] xhr request to non existent file response is 0 and not 404.
https://bugs.webkit.org/show_bug.cgi?id=86344

Patch by Jason Liu <jason.liu@torchmobile.com.cn> on 2012-05-16
Reviewed by George Staikos.

Source/WebCore:

NetworkJob receives 404 for a XMLHttpRequest which calls open("HEAD", "notExist.html", true).
There are no data received because its method is HEAD.
This case should not be treated as a failure.

Add shouldNotifyClientFailed() to treat XMLHttpRequest as a special case.
XMLHttpRequest will fail when status code is smaller than zero.

If we use "GET" and receive 404 without body, NetworkJob won't go through failing code path, too.
So add http/tests/xmlhttprequest/xmlhttprequest-check-get-readystate-for-404-without-body.html
to check this case.

Test: http/tests/xmlhttprequest/xmlhttprequest-check-head-readystate-for-404.html
      http/tests/xmlhttprequest/xmlhttprequest-check-get-readystate-for-404-without-body.html
* platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::sendResponseIfNeeded):

LayoutTests:

* http/tests/xmlhttprequest/xmlhttprequest-check-head-readystate-for-404.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed gardening, unskip a fixed test
jocelyn.turcotte@nokia.com [Wed, 16 May 2012 09:43:44 +0000 (09:43 +0000)]
[Qt] Unreviewed gardening, unskip a fixed test
https://bugs.webkit.org/show_bug.cgi?id=84434

* platform/qt-5.0-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] fast/loader/stateobjects/replacestate-in-iframe.html can be unskipped
commit-queue@webkit.org [Wed, 16 May 2012 09:34:51 +0000 (09:34 +0000)]
[EFL] fast/loader/stateobjects/replacestate-in-iframe.html can be unskipped
https://bugs.webkit.org/show_bug.cgi?id=86586

Unreviewed EFL gardening. Unskip
fast/loader/stateobjects/replacestate-in-iframe.html since the
infinite loop bug has been fixed in r81232.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-16

* platform/efl/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed gardening.
kkristof@inf.u-szeged.hu [Wed, 16 May 2012 09:32:46 +0000 (09:32 +0000)]
[Qt] Unreviewed gardening.
Modified test fails after r117123.

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-05-16

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoHasCustomWillOrDidRecalcStyleFlag and family should live in a bit.
morrita@google.com [Wed, 16 May 2012 09:32:02 +0000 (09:32 +0000)]
HasCustomWillOrDidRecalcStyleFlag and family should live in a bit.
https://bugs.webkit.org/show_bug.cgi?id=86175

Reviewed by Ryosuke Niwa.

This change unifies following flags into one HasCustomCallbacksFlag.
- HasCustomWillOrDidRecalcStyleFlag
- HasCustomStyleForRendererFlag
- IsFrameOwnerElementFlag

By this change, some callbacks can be called even if there are no override.
So all custom callbacks should just pass these invocations.

No new tests. No behavior change.

* dom/ContainerNodeAlgorithms.h:
(WebCore::ChildFrameDisconnector::collectDescendant):
* dom/Element.cpp:
(WebCore::Element::styleForRenderer):
(WebCore::Element::recalcStyle):
(WebCore::Element::willRecalcStyle):
(WebCore):
(WebCore::Element::didRecalcStyle):
(WebCore::Element::customStyleForRenderer):
* dom/Element.h:
(Element):
* dom/Node.h:
(WebCore::Node::isFrameOwnerElement):
(WebCore::Node::hasCustomCallbacks):
(WebCore::Node::setHasCustomCallbacks):
* dom/Text.cpp:
(WebCore::Text::recalcTextStyle):
(WebCore::Text::willRecalcTextStyle):
(WebCore):
* dom/Text.h:
(Text):
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::HTMLFormControlElement):
* html/HTMLFrameOwnerElement.cpp:
(WebCore::HTMLFrameOwnerElement::disconnectContentFrame):
* html/HTMLFrameOwnerElement.h:
* html/HTMLFrameSetElement.cpp:
(WebCore::HTMLFrameSetElement::HTMLFrameSetElement):
* html/HTMLIFrameElement.cpp:
(WebCore::HTMLIFrameElement::HTMLIFrameElement):
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):
* html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement):
(WebCore::HTMLPlugInImageElement::documentWillSuspendForPageCache):
(WebCore::HTMLPlugInImageElement::documentDidResumeFromPageCache):
(WebCore::HTMLPlugInImageElement::customStyleForRenderer):
* html/HTMLPlugInImageElement.h:
(HTMLPlugInImageElement):
* html/shadow/TextControlInnerElements.cpp:
(WebCore::TextControlInnerElement::TextControlInnerElement):
(WebCore::TextControlInnerElement::customStyleForRenderer):
(WebCore::TextControlInnerTextElement::TextControlInnerTextElement):
(WebCore::TextControlInnerTextElement::customStyleForRenderer):
* html/shadow/TextControlInnerElements.h:
(TextControlInnerElement):
(TextControlInnerTextElement):
* html/shadow/TextFieldDecorationElement.cpp:
(WebCore::TextFieldDecorationElement::TextFieldDecorationElement):
(WebCore::TextFieldDecorationElement::customStyleForRenderer):
* html/shadow/TextFieldDecorationElement.h:
(TextFieldDecorationElement):
* svg/SVGElement.cpp:
(WebCore::SVGElement::SVGElement):
(WebCore::SVGElement::customStyleForRenderer):
* svg/SVGElement.h:
(SVGElement):
* svg/SVGTRefElement.cpp:
(WebCore::SVGShadowText::SVGShadowText):
* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::SVGUseElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117242 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: exception when switching to heap profiler comparison view
yurys@chromium.org [Wed, 16 May 2012 09:26:19 +0000 (09:26 +0000)]
Web Inspector: exception when switching to heap profiler comparison view
https://bugs.webkit.org/show_bug.cgi?id=86224

Reviewed by Pavel Feldman.

Make sure the messages are dispatched in the same order as they are sent in
case a fake worker is used for heap snapshot processing.

* inspector/front-end/HeapSnapshotProxy.js:
(WebInspector.AsyncTaskQueue):
(WebInspector.AsyncTaskQueue.prototype.addTask):
(WebInspector.AsyncTaskQueue.prototype._onTimeout):
(WebInspector.AsyncTaskQueue.prototype._scheduleTimer):
(WebInspector.HeapSnapshotFakeWorker):
(WebInspector.HeapSnapshotFakeWorker.prototype.postMessage):
(WebInspector.HeapSnapshotFakeWorker.prototype._postMessageFromWorker):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL][DRT] Gardening failures after r117123 and r117205
commit-queue@webkit.org [Wed, 16 May 2012 09:19:06 +0000 (09:19 +0000)]
[EFL][DRT] Gardening failures after r117123 and r117205
https://bugs.webkit.org/show_bug.cgi?id=86584

Unreviewed, EFL gardening.

Media expectations updated now that they draw the fullscreen icon.
Moved flaky test to test_expectations, unskipped unexpected pass.

Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-05-16

* platform/efl/media/controls-after-reload-expected.png:
* platform/efl/media/controls-after-reload-expected.txt:
* platform/efl/media/controls-strict-expected.png:
* platform/efl/media/controls-strict-expected.txt:
* platform/efl/media/controls-without-preload-expected.png:
* platform/efl/media/controls-without-preload-expected.txt:
* platform/efl/media/video-controls-rendering-expected.png:
* platform/efl/media/video-controls-rendering-expected.txt:
* platform/efl/media/video-display-toggle-expected.png:
* platform/efl/media/video-display-toggle-expected.txt:
* platform/efl/media/video-zoom-controls-expected.png:
* platform/efl/media/video-zoom-controls-expected.txt:
* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Add new commands for Ewk_Editor_Command.
commit-queue@webkit.org [Wed, 16 May 2012 09:16:58 +0000 (09:16 +0000)]
[EFL] Add new commands for Ewk_Editor_Command.
https://bugs.webkit.org/show_bug.cgi?id=74921

Patch by Michał Pakuła vel Rutka <m.pakula@samsung.com> on 2012-05-16
Reviewed by Hajime Morita.

Add new commands for Ewk_Editor_Command enum and introduce new table to keep
enum and string values in sync.

* ewk/ewk_view.cpp: Added a table with EditorCommand struct elements.
(EditorCommand): Added structure consisting of enum and string value.
(_Ewk_View_Private_Data):
(_ewk_view_editor_command_string_get): Added.
(ewk_view_editor_command_execute):
* ewk/ewk_view.h: Ewk_Editor_Command enum extended.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] PlatformKeyboardEvent: figures, letters and printscreen key handling
commit-queue@webkit.org [Wed, 16 May 2012 09:12:32 +0000 (09:12 +0000)]
[EFL] PlatformKeyboardEvent: figures, letters and printscreen key handling
https://bugs.webkit.org/show_bug.cgi?id=85503

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-16
Reviewed by Gustavo Noronha Silva.

Source/WebCore:

* platform/efl/EflKeyboardUtilities.cpp:
(WebCore::addCharactersToKeyMap): aux function
(WebCore):
(WebCore::createKeyMap): Figures and letters keys are added to the keyMap
(WebCore::addCharactersToWinKeyMap): aux function
(WebCore::createWindowsKeyMap): Capital letters keys are added to the windowsKeyMap. Corrected value for printscreen key.
(WebCore::singleCharacterString): Return empty text for printscreen key.

LayoutTests:

Bug-related testcases are unskipped.

* platform/efl/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117238 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Tests that require DASHBOARD_SUPPORT should be moved to test expectations
commit-queue@webkit.org [Wed, 16 May 2012 09:00:02 +0000 (09:00 +0000)]
[EFL] Tests that require DASHBOARD_SUPPORT should be moved to test expectations
https://bugs.webkit.org/show_bug.cgi?id=86578

Unreviewed EFL gardening. Move tests that require DASHBOARD_SUPPORT
flag to test expectations and skip them since this feature is
Mac-specific.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-16

* platform/efl/Skipped:
* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117237 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Fix heap profiler performance test after r117234.
yurys@chromium.org [Wed, 16 May 2012 08:57:17 +0000 (08:57 +0000)]
Unreviewed. Fix heap profiler performance test after r117234.

* inspector/heap-snapshot.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: rename DebuggerPresentationModel to DebuggerScriptMapping, make it...
pfeldman@chromium.org [Wed, 16 May 2012 08:56:59 +0000 (08:56 +0000)]
Web Inspector: rename DebuggerPresentationModel to DebuggerScriptMapping, make it private to ScriptsPanel.
https://bugs.webkit.org/show_bug.cgi?id=86594

Reviewed by Vsevolod Vlasov.

Source/WebCore:

This change completes the elimination of the presentation model.

* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/compile-front-end.py:
* inspector/front-end/AuditFormatters.js:
(WebInspector.AuditFormatters.resourceLink):
* inspector/front-end/DebuggerResourceBinding.js:
(WebInspector.DebuggerResourceBinding):
(WebInspector.DebuggerResourceBinding.prototype._uiSourceCodeForResource):
* inspector/front-end/DebuggerScriptMapping.js: Renamed from Source/WebCore/inspector/front-end/DebuggerPresentationModel.js.
(WebInspector.DebuggerScriptMapping):
(WebInspector.DebuggerScriptMapping.prototype._handleUISourceCodeListChanged):
* inspector/front-end/FilteredItemSelectionDialog.js:
(WebInspector.OpenScriptDialog):
(WebInspector.OpenScriptDialog.install):
(WebInspector.OpenScriptDialog._show):
* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame):
* inspector/front-end/PresentationConsoleMessageHelper.js:
(WebInspector.PresentationConsoleMessageHelper):
(WebInspector.PresentationConsoleMessageHelper.prototype._consoleCleared):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._loadUISourceCodes):
(WebInspector.ScriptsPanel.prototype._createSourceFrame):
(WebInspector.ScriptsPanel.prototype._toggleFormatSource):
* inspector/front-end/ScriptsSearchScope.js:
(WebInspector.ScriptsSearchScope):
(WebInspector.ScriptsSearchScope.prototype._sortedUISourceCodes):
* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCodeProject):
(WebInspector.UISourceCodeProject.prototype.uiSourceCodes):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:
* inspector/front-end/inspector.js:
(WebInspector._createPanels):

LayoutTests:

* http/tests/inspector/compiler-script-mapping.html:
* http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest):
* inspector/debugger/linkifier.html:
* inspector/debugger/scripts-panel.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: use separate fields for storing HeapSnapshotLoaderProxy and HeapSnapsh...
yurys@chromium.org [Wed, 16 May 2012 08:47:59 +0000 (08:47 +0000)]
Web Inspector: use separate fields for storing HeapSnapshotLoaderProxy and HeapSnapshotProxy
https://bugs.webkit.org/show_bug.cgi?id=86488

Reviewed by Pavel Feldman.

Source/WebCore:

Simplified heap profiler snapshot loading code. Introduced dedicated fields for
snapshot loader proxy and for snapshot proxy.

* inspector/front-end/HeapSnapshotProxy.js:
(WebInspector.HeapSnapshotWorker):
(WebInspector.HeapSnapshotLoaderProxy):
(WebInspector.HeapSnapshotLoaderProxy.prototype.finishLoading.updateStaticData):
(WebInspector.HeapSnapshotLoaderProxy.prototype.finishLoading.callLoadCallbacks):
(WebInspector.HeapSnapshotLoaderProxy.prototype.finishLoading):
(WebInspector.HeapSnapshotLoaderProxy.prototype.get loaded):
(WebInspector.HeapSnapshotLoaderProxy.prototype.startLoading):
(WebInspector.HeapSnapshotLoaderProxy.prototype.pushJSONChunk):
* inspector/front-end/HeapSnapshotView.js:
(WebInspector.HeapSnapshotView.profileCallback):
(WebInspector.HeapSnapshotView):
(WebInspector.HeapSnapshotView.prototype.dispose):
(WebInspector.HeapSnapshotView.prototype.get baseProfileWrapper):
(WebInspector.HeapSnapshotView.prototype.wasShown.profileCallback1):
(WebInspector.HeapSnapshotView.prototype._changeView):
(WebInspector.HeapProfileHeader): split _proxy field into _loaderProxy and _snapshotProxy
(WebInspector.HeapProfileHeader.prototype.snapshotProxy):
(WebInspector.HeapProfileHeader.prototype.load):
(WebInspector.HeapProfileHeader.prototype._setupWorker):
(WebInspector.HeapProfileHeader.prototype.dispose):
(WebInspector.HeapProfileHeader.prototype._saveStatusUpdate):
(WebInspector.HeapProfileHeader.prototype.pushJSONChunk):
(WebInspector.HeapProfileHeader.prototype.finishHeapSnapshot):
(WebInspector.HeapProfileHeader.prototype.canSaveToFile):
(WebInspector.HeapProfileHeader.prototype.loadFromFile.onLoad):
(WebInspector.HeapProfileHeader.prototype.loadFromFile):

LayoutTests:

* inspector/profiler/heap-snapshot-inspect-dom-wrapper.html: instead of sniffing a method
call we can use HeapProfileHeader.load directly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Use CSS columns feature for HelpScreen contents.
caseq@chromium.org [Wed, 16 May 2012 08:38:31 +0000 (08:38 +0000)]
Web Inspector: Use CSS columns feature for HelpScreen contents.
https://bugs.webkit.org/show_bug.cgi?id=86367

Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-05-16
Reviewed by Yury Semikhatsky.

Right-docked inspector should show shortcuts/settings in one column.
Bottom-docked inspector should use horizontal space more effectively
(more than 2 columns in shortcuts/settings).

Please see attached screenshots.

UI adjustments, no new tests.

* inspector/front-end/SettingsScreen.js:
(WebInspector.SettingsScreen): Turned table to div.
(WebInspector.SettingsScreen.prototype._appendSection): Removed.
* inspector/front-end/ShortcutsScreen.js:
(WebInspector.ShortcutsScreen.prototype._buildTable): Removed "balancing" algorithm.
(WebInspector.ShortcutsSection.prototype.renderSection): Turned table to div.
(WebInspector.ShortcutsSection.prototype._renderHeader): Ditto.
* inspector/front-end/helpScreen.css: Use CSS columns feature.
(.help-container): Added columns container.
(.help-block): Added "section".
(.help-line): Added key shortcut line.
(.help-key-cell): Added key shortcut cell.
(.help-cell): Ditto
(.help-section-title): Combined title classes
(.help-content p): Adjusted spacing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed chromium test expectations update
bashi@chromium.org [Wed, 16 May 2012 08:18:58 +0000 (08:18 +0000)]
Unreviewed chromium test expectations update

Removes unnecessary entries and added suppressions
for some flaky tests on cr-linux ews.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdding myself(yosin@chromium.org) to committers list
yosin@chromium.org [Wed, 16 May 2012 07:47:18 +0000 (07:47 +0000)]
Adding myself(yosin@chromium.org) to committers list

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSVG TRef/Use NULL ptr
zimmermann@webkit.org [Wed, 16 May 2012 07:44:01 +0000 (07:44 +0000)]
SVG TRef/Use NULL ptr
https://bugs.webkit.org/show_bug.cgi?id=78700

Add testcase covering a problem fixed in trunk.

* svg/custom/bug78700-expected.txt: Added.
* svg/custom/bug78700.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r117050.
commit-queue@webkit.org [Wed, 16 May 2012 07:36:06 +0000 (07:36 +0000)]
Unreviewed, rolling out r117050.
http://trac.webkit.org/changeset/117050
https://bugs.webkit.org/show_bug.cgi?id=86587

"Some heap profiler tests started timing out" (Requested by
yurys on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-16

* inspector/front-end/HeapSnapshotProxy.js:
(WebInspector.HeapSnapshotFakeWorker):
(WebInspector.HeapSnapshotFakeWorker.prototype.postMessage):
(WebInspector.HeapSnapshotFakeWorker.prototype._postMessageFromWorker):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r117206.
commit-queue@webkit.org [Wed, 16 May 2012 07:22:51 +0000 (07:22 +0000)]
Unreviewed, rolling out r117206.
http://trac.webkit.org/changeset/117206
https://bugs.webkit.org/show_bug.cgi?id=86583

breaks chromium browser_tests (Requested by bashi1 on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-16

* loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::continueAfterContentPolicy):
* loader/archive/mhtml/MHTMLArchive.cpp:
(WebCore::MHTMLArchive::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION(r105057): Infinite loop inside SVGTextLayoutEngine::currentLogicalCharacte...
zimmermann@webkit.org [Wed, 16 May 2012 07:21:07 +0000 (07:21 +0000)]
REGRESSION(r105057): Infinite loop inside SVGTextLayoutEngine::currentLogicalCharacterMetrics
https://bugs.webkit.org/show_bug.cgi?id=83405

Reviewed by Darin Adler.

Source/WebCore:

Dynamically adding tspans carrying position information in the x/y/dx/dy/rotate lists is broken.
To avoid mistakes like this in future, simplify the calling code in RenderSVGInlineText and centralize
the management of all caches (text positioning element cache / metrics map / layout attributes) in
RenderSVGText. This avoids the hack in SVGRootInlineBox::computePerCharacterLayoutInformation() which
called textRoot->rebuildLayoutAttributes(), which was used to fix previous security issues with this code.
Instead correctly handle destruction of RenderSVGInlineText in RenderSVGText, keeping the m_layoutAttributes
synchronized with the current state of the render tree. Fixes highcharts problems.

Tests: svg/text/add-tspan-position-bug.html
       svg/text/highcharts-assertion.html
       svg/text/modify-tspan-position-bug.html

* rendering/svg/RenderSVGBlock.h:
(RenderSVGBlock):
* rendering/svg/RenderSVGInline.cpp:
(WebCore::RenderSVGInline::addChild):
(WebCore::RenderSVGInline::removeChild):
* rendering/svg/RenderSVGInline.h:
(RenderSVGInline):
* rendering/svg/RenderSVGInlineText.cpp:
(WebCore::RenderSVGInlineText::setTextInternal):
(WebCore::RenderSVGInlineText::styleDidChange):
* rendering/svg/RenderSVGInlineText.h:
* rendering/svg/RenderSVGText.cpp:
(WebCore::RenderSVGText::RenderSVGText):
(WebCore::RenderSVGText::~RenderSVGText):
(WebCore::collectLayoutAttributes):
(WebCore::RenderSVGText::subtreeChildWasAdded):
(WebCore::findPreviousAndNextAttributes):
(WebCore::checkLayoutAttributesConsistency):
(WebCore::RenderSVGText::willBeDestroyed):
(WebCore::RenderSVGText::subtreeChildWillBeRemoved):
(WebCore::RenderSVGText::subtreeChildWasRemoved):
(WebCore::RenderSVGText::subtreeStyleDidChange):
(WebCore::RenderSVGText::subtreeTextDidChange):
(WebCore::updateFontInAllDescendants):
(WebCore::RenderSVGText::layout):
(WebCore::RenderSVGText::addChild):
(WebCore::RenderSVGText::removeChild):
* rendering/svg/RenderSVGText.h:
(RenderSVGText):
* rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::layoutChildren):
* rendering/svg/SVGRootInlineBox.cpp:
(WebCore::SVGRootInlineBox::computePerCharacterLayoutInformation):
* rendering/svg/SVGTextLayoutAttributesBuilder.cpp:
(WebCore::SVGTextLayoutAttributesBuilder::buildLayoutAttributesForTextRenderer):
(WebCore::SVGTextLayoutAttributesBuilder::buildLayoutAttributesForWholeTree):
(WebCore::SVGTextLayoutAttributesBuilder::rebuildMetricsForTextRenderer):
(WebCore::SVGTextLayoutAttributesBuilder::buildCharacterDataMap):
* rendering/svg/SVGTextLayoutAttributesBuilder.h:
(SVGTextLayoutAttributesBuilder):
(WebCore::SVGTextLayoutAttributesBuilder::numberOfTextPositioningElements):
* svg/SVGAElement.cpp:
* svg/SVGAElement.h:
(SVGAElement):
* svg/SVGTextContentElement.cpp:
* svg/SVGTextContentElement.h:
(SVGTextContentElement):

LayoutTests:

Add three new testcases covering the problem.

* svg/text/add-tspan-position-bug-expected.html: Added.
* svg/text/add-tspan-position-bug.html: Added.
* svg/text/highcharts-assertion-expected.txt: Added.
* svg/text/highcharts-assertion.html: Added.
* svg/text/modify-tspan-position-bug-expected.html: Added.
* svg/text/modify-tspan-position-bug.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCrash in Document::nodeChildrenWillBeRemoved.
inferno@chromium.org [Wed, 16 May 2012 06:45:05 +0000 (06:45 +0000)]
Crash in Document::nodeChildrenWillBeRemoved.
https://bugs.webkit.org/show_bug.cgi?id=85247

Reviewed by Hajime Morita.

Source/WebCore:

Reverse ordering of commands to ref ptr the children set
first before calling nodeChildrenWillBeRemoved, since it
can fire mutation events.

Test: fast/dom/HTMLObjectElement/beforeload-set-text-crash.xhtml

* dom/ContainerNode.cpp:
(WebCore::willRemoveChildren):

LayoutTests:

* fast/dom/HTMLObjectElement/beforeload-set-text-crash-expected.txt: Added.
* fast/dom/HTMLObjectElement/beforeload-set-text-crash.xhtml: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Enhance an API of BackingStore::drawContents
commit-queue@webkit.org [Wed, 16 May 2012 06:44:50 +0000 (06:44 +0000)]
[BlackBerry] Enhance an API of BackingStore::drawContents
https://bugs.webkit.org/show_bug.cgi?id=86447

Patch by Chris Guan <chris.guan@torchmobile.com.cn> on 2012-05-15
Reviewed by George Staikos.

Enhance the current APIs by adding parameters of id and destination
contentSize, because chrome browser may want different contents from
the same webview at different times.

* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::renderContents):
(BlackBerry::WebKit::BackingStore::drawContents):
* Api/BackingStore.h:
* Api/BackingStore_p.h:
(BackingStorePrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix Qt5/Mac build after r117212 by adding missing NETSCAPE_PLUGIN_API guards
caio.oliveira@openbossa.org [Wed, 16 May 2012 06:24:25 +0000 (06:24 +0000)]
Fix Qt5/Mac build after r117212 by adding missing NETSCAPE_PLUGIN_API guards
https://bugs.webkit.org/show_bug.cgi?id=86577

Reviewed by Andy Estes.

* Shared/Plugins/Netscape/NetscapePluginModuleNone.cpp:
* UIProcess/Plugins/unix/PluginInfoStoreUnix.cpp:
(WebKit::PluginInfoStore::getPluginInfo):
* WebProcess/Plugins/Netscape/NetscapePluginNone.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebKit2 would fail to build on Windows if Netscape plug-ins were disabled.
aestes@apple.com [Wed, 16 May 2012 05:39:23 +0000 (05:39 +0000)]
WebKit2 would fail to build on Windows if Netscape plug-ins were disabled.

* UIProcess/Plugins/win/PluginInfoStoreWin.cpp:
(WebKit::PluginInfoStore::getPluginInfo): Return false if ENABLE_NETSCAPE_PLUGIN_API is false.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117221 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Worker] Web Worker lacks test for posting structured data message.
commit-queue@webkit.org [Wed, 16 May 2012 05:36:35 +0000 (05:36 +0000)]
[Worker] Web Worker lacks test for posting structured data message.
https://bugs.webkit.org/show_bug.cgi?id=86556

Patch by Li Yin <li.yin@intel.com> on 2012-05-15
Reviewed by David Levin.

From http://www.w3.org/TR/2012/CR-workers-20120501/#communicating-with-a-dedicated-worker
Structured data can be sent over the communication channel.

* fast/workers/resources/worker-structure-message.js: Added.
(self.onmessage):
* fast/workers/worker-structure-message-expected.txt: Added.
* fast/workers/worker-structure-message.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117220 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL][DRT] Fix eventSender key providing
commit-queue@webkit.org [Wed, 16 May 2012 05:06:31 +0000 (05:06 +0000)]
[EFL][DRT] Fix eventSender key providing
https://bugs.webkit.org/show_bug.cgi?id=84710

Patch by Kangil Han <kangil.han@samsung.com> on 2012-05-15
Reviewed by Andreas Kling.

Currently eventSender doesn't provide key event correctly.
For example, 'Right' will be visible when 'right arrow' key event is fired.
Given circumstance, nothing has to be shown.
Therefore, this patch fixed incorrectly provided key event.

Tools:

* DumpRenderTree/efl/EventSender.cpp:
(KeyEventInfo::KeyEventInfo):
(KeyEventInfo):
(keyPadNameFromJSValue):
(keyNameFromJSValue):
(createKeyEventInfo):
(sendKeyDown):

LayoutTests:

* platform/efl/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed chromium test expectation update after r117206
bashi@chromium.org [Wed, 16 May 2012 05:02:41 +0000 (05:02 +0000)]
Unreviewed chromium test expectation update after r117206

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoregression(111639): Issue with simultaneous CSS animations
igor.o@sisa.samsung.com [Wed, 16 May 2012 04:49:17 +0000 (04:49 +0000)]
regression(111639): Issue with simultaneous CSS animations
https://bugs.webkit.org/show_bug.cgi?id=85929

Source/WebCore:

Currently, previousTimeToNextService is just saving the previous CompositeAnimation::timeToNextService
for AnimationControllerPrivate::updateAnimationTimerForRenderer, however CompositeAnimation::timeToNextService
is also called and used by updateAnimationTimer. Make sure we save the existing timeToNextService from
both places, updateAnimationTimerForRenderer and updateAnimationTimer.

Reviewed by Dean Jackson.

Test: animations/fill-mode-forwards.html

* page/animation/AnimationController.cpp:
(WebCore::AnimationControllerPrivate::AnimationControllerPrivate):
(WebCore::AnimationControllerPrivate::updateAnimationTimerForRenderer):
(WebCore::AnimationControllerPrivate::updateAnimationTimer):
* page/animation/AnimationControllerPrivate.h:
(AnimationControllerPrivate):

LayoutTests:

Reviewed by Dean Jackson.

* animations/fill-mode-forwards-expected.txt: Added.
* animations/fill-mode-forwards.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFixed a typo.
mitz@apple.com [Wed, 16 May 2012 04:31:16 +0000 (04:31 +0000)]
Fixed a typo.

* Scripts/copy-webkitlibraries-to-product-directory:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117215 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] CCTimer::isActive() is incorrect inside tick callback
commit-queue@webkit.org [Wed, 16 May 2012 04:07:52 +0000 (04:07 +0000)]
[Chromium] CCTimer::isActive() is incorrect inside tick callback
https://bugs.webkit.org/show_bug.cgi?id=86513

Source/WebCore:

This patch implements CCTimer::isActive() by clearing the task pointer
when the timer fires.

Patch by Tien-Ren Chen <trchen@chromium.org> on 2012-05-15
Reviewed by James Robinson.

No new tests. Existing tests updated accordingly.

* platform/graphics/chromium/cc/CCTimer.cpp:
(WebCore::CCTimerTask::performTask):
* rendering/RenderLayerBacking.cpp:

Source/WebKit/chromium:

Update test cases to verify CCTimer::isActive() values.

Patch by Tien-Ren Chen <trchen@chromium.org> on 2012-05-15
Reviewed by James Robinson.

* tests/CCTimerTest.cpp:
(WebKitTests::TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r117204.
commit-queue@webkit.org [Wed, 16 May 2012 04:00:24 +0000 (04:00 +0000)]
Unreviewed, rolling out r117204.
http://trac.webkit.org/changeset/117204
https://bugs.webkit.org/show_bug.cgi?id=86559

causing win compilation failures (Requested by pilgrim_google_
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-15

Source/Platform:

* Platform.gypi:
* chromium/public/Platform.h:
(WebKit):
(Platform):
* chromium/public/WebMessagePortChannel.h: Removed.
* chromium/public/WebMessagePortChannelClient.h: Removed.

Source/WebKit/chromium:

* WebKit.gyp:
* public/WebMessagePortChannel.h:
(WebKit):
(WebMessagePortChannel):
(WebKit::WebMessagePortChannel::~WebMessagePortChannel):
* public/platform/WebKitPlatformSupport.h:
(WebKit):
(WebKitPlatformSupport):
(WebKit::WebKitPlatformSupport::createMessagePortChannel):
* src/PlatformMessagePortChannel.cpp:
(WebCore::PlatformMessagePortChannel::PlatformMessagePortChannel):
* src/PlatformMessagePortChannel.h:
* src/SharedWorkerRepository.cpp:
* src/WebSharedWorkerImpl.cpp:
* src/WebWorkerClientImpl.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoGuard Netscape plug-in code with ENABLE(NETSCAPE_PLUGIN_API)
aestes@apple.com [Wed, 16 May 2012 03:55:58 +0000 (03:55 +0000)]
Guard Netscape plug-in code with ENABLE(NETSCAPE_PLUGIN_API)
https://bugs.webkit.org/show_bug.cgi?id=86496

Reviewed by Sam Weinig.

Ensure that WebKit2 can compile with ENABLE_NETSCAPE_PLUGIN_API disabled.

* Shared/Plugins/Netscape/NetscapePluginModule.cpp:
* Shared/Plugins/Netscape/NetscapePluginModule.h:
* Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
* Shared/Plugins/Netscape/win/NetscapePluginModuleWin.cpp:
* Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:
* UIProcess/Plugins/mac/PluginInfoStoreMac.mm:
(WebKit::PluginInfoStore::getPluginInfo):
* WebProcess/Plugins/Netscape/JSNPMethod.cpp:
* WebProcess/Plugins/Netscape/JSNPMethod.h:
* WebProcess/Plugins/Netscape/JSNPObject.cpp:
* WebProcess/Plugins/Netscape/JSNPObject.h:
* WebProcess/Plugins/Netscape/NPJSObject.cpp:
* WebProcess/Plugins/Netscape/NPJSObject.h:
* WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
* WebProcess/Plugins/Netscape/NPRuntimeObjectMap.h:
* WebProcess/Plugins/Netscape/NPRuntimeUtilities.cpp:
* WebProcess/Plugins/Netscape/NPRuntimeUtilities.h:
* WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
(WebKit::NPN_GetValue):
* WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.h:
* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
* WebProcess/Plugins/Netscape/NetscapePlugin.h:
* WebProcess/Plugins/Netscape/NetscapePluginStream.cpp:
* WebProcess/Plugins/Netscape/NetscapePluginStream.h:
* WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
* WebProcess/Plugins/Netscape/mac/NetscapeSandboxFunctions.h:
* WebProcess/Plugins/Netscape/mac/NetscapeSandboxFunctions.mm:
* WebProcess/Plugins/Netscape/mac/PluginProxyMac.mm:
* WebProcess/Plugins/Netscape/qt/PluginProxyQt.cpp:
* WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
* WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
* WebProcess/Plugins/PluginController.h:
(PluginController):
* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::Stream::didFinishLoading):
(WebKit::PluginView::PluginView):
(WebKit::PluginView::~PluginView):
(WebKit::PluginView::scriptObject):
(WebKit):
* WebProcess/Plugins/PluginView.h:
(PluginView):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::createPlugin):
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::getSitesWithPluginData):
(WebKit::WebProcess::clearPluginSiteData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@117212 268f45cc-cd09-0410-ab3c-d52691b4dbfc