15 years agoWebCore:
bdakin@apple.com [Fri, 9 Nov 2007 19:05:55 +0000 (19:05 +0000)]

        Reviewed by Oliver.

        Fix for <rdar://problem/5586370> CSS Transform - incorrect matrix
        math leads to crazy problems

        Transform matrices accept the first four parameters as CSS lengths.
        CSS lengths get mapped into WebCore::Lengths as percents by
        WebCore::convertToLength(). Percent lengths cannot call value(). It
        does not yield a correct result and it asserts on Debug builds.

        * rendering/RenderStyle.h:
        (WebCore::MatrixTransformOperation::apply): Instead of calling
        value() on the lengths, call calcValue. This fixes the assert and
        the bad rendering.


        Reviewed by Oliver.

        Test for <rdar://problem/5586370> CSS Transform - incorrect matrix
        math leads to crazy problems

        * fast/transforms/identity-matrix.html: Added.
        * platform/mac/fast/transforms/identity-matrix-expected.checksum: Added.
        * platform/mac/fast/transforms/identity-matrix-expected.png: Added.
        * platform/mac/fast/transforms/identity-matrix-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Windows build fix
aroben@apple.com [Fri, 9 Nov 2007 17:56:12 +0000 (17:56 +0000)]
    Windows build fix

        Reviewed by Darin.

        * kjs/value.h:
        (KJS::jsNumber): Add some explicit casts.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoRoll out r27641 since the same bug was already fixed by r27568.
sfalken [Fri, 9 Nov 2007 17:16:39 +0000 (17:16 +0000)]
Roll out r27641 since the same bug was already fixed by r27568.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agouserIdleTime() is stubbed in win/SystemTimeWin.cpp, so don't
hausmann [Fri, 9 Nov 2007 14:33:24 +0000 (14:33 +0000)]
userIdleTime() is stubbed in win/SystemTimeWin.cpp, so don't
define it twice for the Qt/Windows build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoImplemented the webcore actions for changing the text direction.
hausmann [Fri, 9 Nov 2007 13:09:20 +0000 (13:09 +0000)]
Implemented the webcore actions for changing the text direction.

Signed-off-by: Holger
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix ContextMenu allocation in the Qt port.
hausmann [Fri, 9 Nov 2007 13:09:15 +0000 (13:09 +0000)]
Fix ContextMenu allocation in the Qt port.

Store all items and submenus value based in ContextMenu and ContextMenuItem.
That fixes the crashes when the context menu was populated with sub-menus because
of the use of temporary ContextMenu objects like this:

ContextMenu subMenu(...);

subMenuItem.setSubMenu(&subMenu); // temporary pointer, need to _copy_ contents

Signed-off-by: Holger
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoRenamed QWebPage::NumWebActions to QWebPage::WebActionCount (for consistency) and...
hausmann [Fri, 9 Nov 2007 13:09:02 +0000 (13:09 +0000)]
Renamed QWebPage::NumWebActions to QWebPage::WebActionCount (for consistency) and fixed its value.

Signed-off-by: Holger
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-11-09 Peter Kasting <zerodpx@gmail.com>
mrowe@apple.com [Fri, 9 Nov 2007 12:51:03 +0000 (12:51 +0000)]
2007-11-09  Peter Kasting  <zerodpx@gmail.com>

        Reviewed by Mark Rowe.

        Malformed GIFs should not result in memory corruption.

        * platform/image-decoders/gif/GIFImageDecoder.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Initialize WindowFeatures struct before using it.
sfalken [Fri, 9 Nov 2007 09:01:56 +0000 (09:01 +0000)]
    Initialize WindowFeatures struct before using it.

        Reviewed by Oliver.

        * page/ContextMenuController.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam.
kmccullo [Fri, 9 Nov 2007 08:29:20 +0000 (08:29 +0000)]
    Reviewed by Adam.

        - This patch does two main things.
        1) It adds pragma warning guards around WebCore includes in WebKit files
        that were previously overlooked.
        2) It implements almost the entireity of WebScriptDebugger.  Only one
        function remains and that implementation is dependent on finishing the
        implementation of WebScriptScope.

        * WebScriptCallFrame.h:
        * WebScriptDebugServer.h:
        * WebScriptDebugger.cpp:
        * WebScriptDebugger.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam.
kmccullo [Fri, 9 Nov 2007 08:26:05 +0000 (08:26 +0000)]
    Reviewed by Adam.

        - Changed the vcproj file to use Drosera's ForwardingHeaders and not

        * Drosera/ForwardingHeaders/wtf/Assertions.h: Added.
        * Drosera/ForwardingHeaders/wtf/HashTraits.h: Added.
        * Drosera/ForwardingHeaders/wtf/Noncopyable.h: Added.
        * Drosera/ForwardingHeaders/wtf/OwnPtr.h: Added.
        * Drosera/ForwardingHeaders/wtf/RetainPtr.h: Added.
        * Drosera/win/Drosera.cpp:
        * Drosera/win/Drosera.vcproj/Drosera.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-11-08 Timothy Hatcher <timothy@apple.com>
mrowe@apple.com [Fri, 9 Nov 2007 07:06:33 +0000 (07:06 +0000)]
2007-11-08  Timothy Hatcher  <timothy@apple.com>

        Reviewed by Sam Weinig.

        Some Web Inspector CSS editing changes.
        - Only delete the property if all the text is delete or the new user input correctly parses.
          This prevents deleting the existing property if the new text is invalid.
        - Intercept the Escape key and cancel editing, not saving any changes.

        * page/inspector/StylesSidebarPane.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - fix build
darin@apple.com [Fri, 9 Nov 2007 05:57:46 +0000 (05:57 +0000)]
    - fix build

        * kjs/grammar.y:
        * kjs/nodes.h:
        * kjs/property_map.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - roll out accidentally-checked in changes
darin@apple.com [Fri, 9 Nov 2007 05:56:30 +0000 (05:56 +0000)]
    - roll out accidentally-checked in changes

        * kjs/nodes.cpp: Back to previous version.
        * kjs/nodes.h: Ditto.
        * kjs/grammar.y: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - roll out accidentally-checked in changes
darin@apple.com [Fri, 9 Nov 2007 05:55:22 +0000 (05:55 +0000)]
    - roll out accidentally-checked in changes

        * kjs/nodes.cpp: Back to previous version.
        * kjs/nodes.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej.
darin@apple.com [Fri, 9 Nov 2007 05:51:13 +0000 (05:51 +0000)]
    Reviewed by Maciej.

        - http://bugs.webkit.org/show_bug.cgi?id=15912
          fasta spends a lot of time in qsort

        * kjs/property_map.cpp:
        Use insertion sort instead of qsort for small sets of property names.
        We can probably do some even-better speedups of for/in, but this nets
        0.6% overall and 6.7% on fasta.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Maciej.
darin@apple.com [Fri, 9 Nov 2007 05:50:19 +0000 (05:50 +0000)]
    Reviewed by Maciej.

        - http://bugs.webkit.org/show_bug.cgi?id=15906
          getting characters by indexing into a string is very slow

        This fixes one source of the slowness -- the conversion to an unused
        Identifier as we call the get function from the slot -- but doesn't
        fix others, such as the fact that we have to allocate a new UString::Rep
        for every single character.

        Speeds up string-base64 30%, and at least 0.5% overall.
        But does slow down access-fannkuch quite a bit. Might be worth
        revisiting in the future to see what we can do about that (although
        I did look at a profile for a while).

        * kjs/property_slot.h: Add a new marker for "numeric" property slots;
        slots where we don't need to pass the identifier to the get function.
        (KJS::PropertySlot::getValue): Added code to call the numeric get function.
        (KJS::PropertySlot::setCustomNumeric): Added.
        * kjs/string_object.cpp:
        (KJS::StringInstance::indexGetter): Changed to use substr() instead
        of constructing a wholly new UString each time.
        (KJS::stringInstanceNumericPropertyGetter): Added. Like indexGetter, but
        takes advantage of setCustomNumeric to avoid creating an Identifier.
        (KJS::StringInstance::getOwnPropertySlot): Changed to use setCustomNumeric.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Oliver.
darin@apple.com [Fri, 9 Nov 2007 05:48:49 +0000 (05:48 +0000)]
    Reviewed by Oliver.

        - http://bugs.webkit.org/show_bug.cgi?id=15904
          more speed-ups possible by tightening up int version of JSImmediate

        1% improvement of SunSpider

        * kjs/JSImmediate.h: Eliminate the now-unneeded FPBitValues struct template.
        (KJS::JSImmediate::from): Overload for most numeric types; many types can
        do fewer branches and checks.
        (KJS::JSImmediate::getUInt32): Removed unneeded check for undefined.
        (KJS::JSImmediate::getTruncatedInt32): Ditto.
        (KJS::JSImmediate::getTruncatedUInt32): Ditto. There's no difference any more
        between getUInt32 and getTruncatedUInt32, so that's worth a rename and merge later.

        * kjs/grammar.y: Update since fromDouble is now just from.
        * kjs/nodes.h: Ditto.

        * kjs/value.h: (KJS::jsNumber): Overload for most numeric types.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoAdding Bakefiles for JSCore, WebCore, and WebKit, and adding wxWebKit implementation.
kevino@webkit.org [Fri, 9 Nov 2007 05:38:39 +0000 (05:38 +0000)]
Adding Bakefiles for JSCore, WebCore, and WebKit, and adding wxWebKit implementation.

Reviewed by Mark Rowe

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix regression caused by earlier bitwise and optimisation. 1 & undefined != 1.
oliver [Fri, 9 Nov 2007 04:32:55 +0000 (04:32 +0000)]
Fix regression caused by earlier bitwise and optimisation.  1 & undefined != 1.

Reviewed by Maciej.

The implementation of JSImmediate::areBothImmediateNumbers relies on
(JSImmediate::getTag(immediate1) & JSImmediate::getTag(immediate2)) having
a unique result when both immediate values are numbers.

The regression was due to UndefinedType & NumberType returning NumberType (3 & 1).
By swapping the value of NumberType and UndefinedType this ceases to be a problem.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-11-08 Justin Haygood <jhaygood@reaktix.com>
mrowe@apple.com [Fri, 9 Nov 2007 03:13:19 +0000 (03:13 +0000)]
2007-11-08  Justin Haygood  <jhaygood@reaktix.com>

        Reviewed by Mark Rowe.


        Fix builds with HTML 5 Storage support disabled.
        ENABLE(DATABASE) needs to be added in a few places.

        * page/InspectorController.cpp:
        * storage/Database.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoBump versions for submit
sfalken [Fri, 9 Nov 2007 02:03:40 +0000 (02:03 +0000)]
Bump versions for submit

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoVersioning.
mrowe@apple.com [Fri, 9 Nov 2007 01:48:46 +0000 (01:48 +0000)]

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix typo in ChangeLog.
sfalken [Fri, 9 Nov 2007 01:39:16 +0000 (01:39 +0000)]
Fix typo in ChangeLog.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago <rdar://problem/5491463> Wrong dates shown in History menu.
sfalken [Fri, 9 Nov 2007 01:32:49 +0000 (01:32 +0000)]
    <rdar://problem/5491463> Wrong dates shown in History menu.

        Fix off-by-one error in Windows epoch.

        For the Windows DATE type, 1/1/1900 should be 2.0, not 1.0.
        DATE is the number of dates since 12/30/1899.

        Reviewed by Ada.

        * MarshallingHelpers.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-11-08 Alp Toker <alp@atoker.com>
alp@webkit.org [Fri, 9 Nov 2007 01:13:28 +0000 (01:13 +0000)]
2007-11-08  Alp Toker  <alp@atoker.com>

        Reviewed by Mark Rowe.

        [GTK] Text editor does not handle common keystrokes

        Handle more keystrokes in EditorClientGtk. Note that this is a
        temporary measure pending a proper solution using GtkBindingSet (see

        * WebCoreSupport/EditorClientGtk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - fix build
darin@apple.com [Fri, 9 Nov 2007 01:04:54 +0000 (01:04 +0000)]
    - fix build

        * kjs/nodes.h: Add missing parameter name.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-11-08 Eric Seidel <eric@webkit.org>
eseidel [Fri, 9 Nov 2007 00:43:52 +0000 (00:43 +0000)]
2007-11-08 Eric Seidel <eric@webkit.org>

        Reviewed by darin.

        Add ExpressionNode subclass of Node, use it.

        * kjs/grammar.y:
        * kjs/nodes.cpp:
        * kjs/nodes.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoCorrect ChangeLogs to reflect that the speedup was 1% not .5%. Turns out you are...
weinig@apple.com [Fri, 9 Nov 2007 00:09:48 +0000 (00:09 +0000)]
Correct ChangeLogs to reflect that the speedup was 1% not .5%.  Turns out you are not supposed to test in Debug builds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFixed bug title in old check-in.
ggaren@apple.com [Thu, 8 Nov 2007 23:51:44 +0000 (23:51 +0000)]
Fixed bug title in old check-in.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago <rdar://problem/5524082> Allow images to be dragged out directly into other...
sfalken [Thu, 8 Nov 2007 23:49:56 +0000 (23:49 +0000)]
    <rdar://problem/5524082> Allow images to be dragged out directly into other apps

        We weren't including CF_HDROP in our image drops.  This broke drag of
        images out of the browser window directly into other apps (examples
        include notepad, mspaint, msword).

        Reviewed by Oliver, Ada.

        * platform/win/ClipboardWin.cpp:
        (WebCore::createGlobalImageFileContent): Removed unused variable.
        (WebCore::createGlobalHDropContent): Added
        (WebCore::writeFileToDataObject): Write HDROP data if available.
        (WebCore::writeImageToDataObject): Write HDROP for dragged images.
        (WebCore::ClipboardWin::writeURL): Don't write HDROP for dragged URLs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-11-08 Xan Lopez <xan@gnome.org>
alp@webkit.org [Thu, 8 Nov 2007 23:31:16 +0000 (23:31 +0000)]
2007-11-08  Xan Lopez  <xan@gnome.org>

        Reviewed by Alp.

        Use g_object_ref_sink when available

        * platform/gtk/PopupMenuGtk.cpp:
        * platform/gtk/ScrollViewGtk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
mitz@apple.com [Thu, 8 Nov 2007 22:59:42 +0000 (22:59 +0000)]

        Reviewed by Beth Dakin.

        - fix <rdar://problem/5491922> REGRESSION (Safari 2-3): Flash-based "Cash Optimizer" on etrade.com does not draw completely

        Test: fast/dom/length-attribute-mapping.html

        * dom/StyledElement.cpp:
        (WebCore::StyledElement::addCSSLength): Changed the garbage-stripping
        logic to stop after the first "%" or "*" in the string. This allows for
        "100%25" to be mapped to "100%" like it is in Firefox and WinIE.


        Reviewed by Beth Dakin.

        - test for <rdar://problem/5491922> REGRESSION (Safari 2-3): Flash-based "Cash Optimizer" on etrade.com does not draw completely

        * fast/dom/length-attribute-mapping-expected.txt: Added.
        * fast/dom/length-attribute-mapping.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
kmccullo [Thu, 8 Nov 2007 22:26:29 +0000 (22:26 +0000)]

        - Build fix.

        * loader/FrameLoaderClient.h:
        * platform/graphics/svg/SVGImageEmptyClients.h:


        Build Fix.

        * WebCoreSupport/WebFrameLoaderClient.h:
        * WebCoreSupport/WebFrameLoaderClient.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoAdd a fast path for bitwise-and of two immediate numbers for a 0.7% improvement in...
oliver [Thu, 8 Nov 2007 22:23:39 +0000 (22:23 +0000)]
Add a fast path for bitwise-and of two immediate numbers for a 0.7% improvement in SunSpider (4% bitop improvement).

Reviewed by Sam.

This only improves bitwise-and performance, as the additional logic required
for similar code paths on or, xor, and shifting requires additional operations
and branches that negate (and in certain cases, regress) any advantage we might
otherwise receive.

This improves performance on all bitop tests, the cryptography tests, as well as
the string-base64 and string-unpack-code tests.  No significant degradation on
any other tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Stop using KJS inside of MathExtras.h
aroben@apple.com [Thu, 8 Nov 2007 21:49:20 +0000 (21:49 +0000)]
     Stop using KJS inside of MathExtras.h

         Reviewed by Darin.

         * wtf/MathExtras.h: Removed an unused header, and a now-unused
         (wtf_atan2): Use std::numeric_limits intead of KJS.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Sam.
kmccullo [Thu, 8 Nov 2007 21:45:18 +0000 (21:45 +0000)]
    Reviewed by Sam.

        - Use the new IWebFrame [local] function signature and get the shared
        server correctly.

        * Drosera/win/DebuggerClient.cpp:
        * Drosera/win/ServerConnection.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
kmccullo [Thu, 8 Nov 2007 21:43:31 +0000 (21:43 +0000)]

        Reviewed by Sam.

        - windowObjectCleared() is no longer const.  It needs to setup the
        script debugger and cannot be const to do so.

        * loader/FrameLoaderClient.h:
        * platform/graphics/svg/SVGImageEmptyClients.h:


        Reviewed by Sam.

        - windowObjectCleared() is no longer const.  It needs to setup the
        script debugger and cannot be const to do so.

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        * WebCoreSupport/FrameLoaderClientGtk.h:


        Reviewed by Sam.

        - windowObjectCleared() is no longer const.  It needs to setup the
        script debugger and cannot be const to do so.

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        * WebCoreSupport/FrameLoaderClientQt.h:


        Reviewed by Sam.

        - With this change Drosera can now get the source of a website and the
        listings of the sources it gets.  This also lays the foundation for
        letting Drosera show the scope chain of the JavaScript stack.

        * Interfaces/IWebFrame.idl: Changed the signature of the local function,
        globalContext(), because COM was unable to marshal this object with the
        other signature.
        * Interfaces/IWebScriptDebugServer.idl: Of course adding and removing
        a listener cannot be done in a const function.
        * WebChromeClient.h: Added accessor to the WebView for the new added
        kit() function in WebFrame.
        * WebFrame.cpp: Added a script debugger object and the necessary
        functions to attach and communicate with it. Also needed to change the
        local function, globalContext(), because of a COM issue.
        * WebFrame.h: Ditto.
        * WebHTMLRepresentation.cpp: Implemented documentSource so Drosera has
        some source code to display.
        * WebKit.vcproj/WebKit.vcproj: Added the new WebScriptDebugger class.
        * WebScriptCallFrame.cpp: Implemented much of this class' functionality.
        (EnumScopes::EnumScopes): Made an EnumScopes class to create an
        IEnumVARIANT to wrap a ScopeChain for Drosera.
        * WebScriptCallFrame.h: Added member data needed for the above functions
        * WebScriptDebugServer.cpp: Began implementing.
        * WebScriptDebugServer.h: Began implementing.
        * WebScriptDebugger.cpp: Added.
        * WebScriptDebugger.h: Added.
        * WebScriptScope.cpp: Make this class use createInstance which is more
        in line with our guidelines.
        * WebScriptScope.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Hopeful Windows build fix
aroben@apple.com [Thu, 8 Nov 2007 21:27:13 +0000 (21:27 +0000)]
    Hopeful Windows build fix

        * rendering/RenderObject.cpp: Touch this file to make it recompile.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Windows build fix.
weinig@apple.com [Thu, 8 Nov 2007 21:26:49 +0000 (21:26 +0000)]
    Windows build fix.

        * kjs/date_object.cpp:
        (KJS::DateProtoFuncToLocaleString::callAsFunction): Fix unused arg warning.
        (KJS::DateProtoFuncToLocaleDateString::callAsFunction): ditto
        (KJS::DateProtoFuncToLocaleTimeString::callAsFunction): ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-11-08 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Thu, 8 Nov 2007 21:03:13 +0000 (21:03 +0000)]
2007-11-08  Mark Rowe  <mrowe@apple.com>

        Gtk build fix.

        * kjs/lookup.h: Add missing include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoJavaScriptCore:
weinig@apple.com [Thu, 8 Nov 2007 20:31:26 +0000 (20:31 +0000)]

        Reviewed by Darin.

        Convert JavaScript internal function objects to use one class per
        function.  This avoids a switch statement inside what used to be
        the shared function classes and will allow Shark to better analyze
        the code.

        To make this switch, the value property of the HashEntry was changed
        to a union of an intptr_t (which is used to continue handle valueGetters)
        and function pointer which points to a static constructor for the
        individual new function objects.

        SunSpider claims this is a 0.5% speedup.

        * kjs/array_object.cpp:
        * kjs/array_object.h:
        * kjs/create_hash_table:
        * kjs/date_object.cpp:
        * kjs/date_object.h:
        * kjs/lookup.cpp:
        * kjs/lookup.h:
        * kjs/math_object.cpp:
        * kjs/math_object.h:
        * kjs/string_object.cpp:
        * kjs/string_object.h:


        Reviewed by Darin.

        Convert JavaScript internal function objects to use one class per
        function.  This avoids a switch statement inside what used to be
        the shared function classes and will allow Shark to better analyze
        the code.

        To make this switch, the value property of the HashEntry was changed
        to a union of an intptr_t (which is used to continue handle valueGetters)
        and function pointer which points to a static constructor for the
        individual new function objects.

        SunSpider claims this is a 0.5% speedup.

        - On the WebCore side, I updated CodeGeneratorJS.pm to generate the
          new classes and hand updated the remain non-generated (groan) classes.

        * bindings/js/JSDOMWindowCustom.cpp:
        * bindings/js/JSEventTargetNode.cpp:
        * bindings/js/JSEventTargetNode.h:
        * bindings/js/JSHTMLInputElementBase.cpp:
        * bindings/js/JSHTMLInputElementBase.h:
        * bindings/js/JSXMLHttpRequest.cpp:
        * bindings/js/JSXMLHttpRequest.h:
        * bindings/js/JSXSLTProcessor.cpp:
        * bindings/js/JSXSLTProcessor.h:
        * bindings/js/kjs_events.cpp:
        * bindings/js/kjs_events.h:
        * bindings/js/kjs_navigator.cpp:
        * bindings/js/kjs_navigator.h:
        * bindings/js/kjs_window.cpp:
        * bindings/js/kjs_window.h:
        * bindings/scripts/CodeGeneratorJS.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Windows build fix
aroben@apple.com [Thu, 8 Nov 2007 20:22:38 +0000 (20:22 +0000)]
    Windows build fix

        Reviewed by Sam and Ada.

        * wtf/MathExtras.h: Get rid of a circular #include dependency to fix
        the build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Fix a precedence warning on Windows
aroben@apple.com [Thu, 8 Nov 2007 19:58:20 +0000 (19:58 +0000)]
    Fix a precedence warning on Windows

        * kjs/JSImmediate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-11-08 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Thu, 8 Nov 2007 19:49:23 +0000 (19:49 +0000)]
2007-11-08  Mark Rowe  <mrowe@apple.com>

        Build fix for JavaScriptGlue.

        * wtf/MathExtras.h: Include stdlib.h for srand and RAND_MAX.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-11-08 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Thu, 8 Nov 2007 19:45:49 +0000 (19:45 +0000)]
2007-11-08  Mark Rowe  <mrowe@apple.com>

        Build fix.

        * ForwardingHeaders/wtf/MathExtras.h: Copied from WebCore/ForwardingHeaders/wtf/MathExtras.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago - Windows build fix
darin@apple.com [Thu, 8 Nov 2007 19:38:49 +0000 (19:38 +0000)]
    - Windows build fix

        * kjs/JSImmediate.h: Include MathExtras.h rather than math.h since this file uses "signbit".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoReplace the use of floats for immediate values with the use of integers for a 4.5...
oliver [Thu, 8 Nov 2007 18:27:21 +0000 (18:27 +0000)]
Replace the use of floats for immediate values with the use of integers for a 4.5% improvement in SunSpider.

Reviewed by Darin.

Unfortunately this change results in NaN, +Inf, -Inf, and -0 being heap allocated now, but
we should now have faster array access, faster immediate to double conversion, and the
potential to further improve bitwise operators in future.

This also removes the need for unions to avoid strict aliasing problems when extracting
a value from immediates.

* kjs/JSImmediate.h:
* kjs/value.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-11-08 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Thu, 8 Nov 2007 17:18:22 +0000 (17:18 +0000)]
2007-11-08  Mark Rowe  <mrowe@apple.com>

        Fix the Gtk, Qt and Wx builds.

        * platform/gtk/TemporaryLinkStubs.cpp:
        * platform/qt/TemporaryLinkStubs.cpp:
        * platform/wx/TemporaryLinkStubs.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-11-08 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Thu, 8 Nov 2007 16:50:03 +0000 (16:50 +0000)]
2007-11-08  Mark Rowe  <mrowe@apple.com>

        Not reviewed.  Fix two instances of includes using the wrong case in the filename.

        * platform/graphics/mac/MoviePrivateQTKit.mm:
        * platform/wx/MimeTypeRegistryWx.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
darin@apple.com [Thu, 8 Nov 2007 15:42:46 +0000 (15:42 +0000)]

        Reviewed by Adam.

        - fix <rdar://problem/5552943> accesskey does not focus <button> elements

        Test: fast/forms/access-key.html

        * html/HTMLButtonElement.cpp: (WebCore::HTMLButtonElement::accessKeyAction):
        Added a call to focus.


        Reviewed by Adam.

        - test changes for <rdar://problem/5552943> accesskey does not focus <button> elements

        * fast/forms/access-key.html: Check for both focus and click events on all elements, but
        resisted the urge to switch to the American spelling for "focused".

        * fast/forms/access-key-expected.txt: Updated to reflect the bug fix ("1 button focussed"),
        the fact that <input type=button>, <input type=checkbox>, <input type=submit>, and
        <input type=reset> are all both focused and clicked ("2 input type button clicked",
        "3 input type checkbox clicked", "5 input type submit focussed", and
        "6 input type reset focussed"). Unfortunately this now also demonstrates that we don't
        send a click to <input type=text> and Gecko does. And there are still quite a few types
        that are not covered.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
darin@apple.com [Thu, 8 Nov 2007 15:40:40 +0000 (15:40 +0000)]

        Reviewed by Steve.

        - cut down on notImplemented() functions on Windows

        * bridge/AXObjectCache.h: Put #if around the accessibility

        * bridge/win/FrameWin.cpp: (WebCore::Frame::setNeedsReapplyStyles):
        Moved here from TemporaryLinkStubs.

        * dom/Document.cpp: (WebCore::Document::lastModified): Re-implemented
        using the ResourceResponse that's now available from the DocumentLoader.

        * editing/JSEditor.cpp: (execTranspose): Changed to call transpose() on
        the Editor instead of the obsolete one on the Frame.

        * loader/DocumentLoader.h: Removed getResponseModifiedHeader.
        * loader/FrameLoader.h: Removed overrideMediaType.

        * loader/gtk/DocumentLoaderGtk.cpp: Removed.
        * loader/mac/DocumentLoaderMac.mm: Removed.
        * loader/qt/DocumentLoaderQt.cpp: Removed.

        * page/Frame.cpp: Removed transpose.
        * page/Frame.h: Ditto.
        * page/FrameView.h: Removed updateBorder.
        * page/gtk/FrameGtk.cpp: Removed issueTransposeCommand.
        * page/mac/FrameMac.mm: Ditto.
        * page/mac/WebCoreFrameBridge.h: Removed issueTransposeCommand and
        * page/qt/FrameQt.cpp: Removed issueTransposeCommand.

        * platform/gtk/TemporaryLinkStubs.cpp: Removed gAccessibilityEnabled.
        * platform/qt/TemporaryLinkStubs.cpp: Ditto.
        * platform/win/TemporaryLinkStubs.cpp: Removed or moved all but 3 of the stubs.
        * platform/wx/TemporaryLinkStubs.cpp: Removed gAccessibilityEnabled,
        issueTransposeCommand, and overrideMediaType.

        * platform/network/cf/ResourceHandleCFNet.cpp:
        (WebCore::ResourceHandle::loadsBlocked): Moved here from TemporaryLinkStubs.
        (WebCore::ResourceHandle::willLoadFromCache): Ditto.
        * platform/win/GraphicsContextWin.cpp:
        (WebCore::GraphicsContextPlatformPrivate::clip): Ditto.
        * platform/win/ScrollViewWin.cpp: (WebCore::ScrollView::inWindow): Ditto.
        * platform/win/SystemTimeWin.cpp: (WebCore::userIdleTime): Ditto.
        * platform/win/WidgetWin.cpp: (WebCore::Widget::setIsSelected): Ditto.

        * WebCore.pro: Updated for removed files.
        * WebCore.xcodeproj/project.pbxproj: Updated for removed file.


        Reviewed by Steve.

        - removed some unused WebCore bridge methods

        * WebCoreSupport/WebFrameBridge.mm: Removed issueTransposeCommand and overrideMediaType.

        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::overrideMediaType): Changed to call WebView directly instead of
        using the bridge object.


        Reviewed by Steve.

        * Interfaces/IWebUIDelegate.idl: Added the functions needed below.
        * WebChromeClient.cpp:
        (WebChromeClient::setMenubarVisible): Eliminated the notImplemented()
        here by calling through the UI delegate.
        (WebChromeClient::menubarVisible): Ditto.
        (WebChromeClient::runDatabaseSizeLimitPrompt): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-11-08 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Thu, 8 Nov 2007 15:12:14 +0000 (15:12 +0000)]
2007-11-08  Mark Rowe  <mrowe@apple.com>

       Build fix for case-sensitive file systems.  Fix case of file names
       in #include's.

        * html/HTMLMediaElement.cpp:
        * platform/graphics/Movie.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoBuild fix for Qt 4.3.
hausmann [Thu, 8 Nov 2007 14:18:55 +0000 (14:18 +0000)]
Build fix for Qt 4.3.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoRemove some warnings about not implemented methods.
hausmann [Thu, 8 Nov 2007 08:20:46 +0000 (08:20 +0000)]
Remove some warnings about not implemented methods.

* ResourceHandle::loadsBlocked and ResourceHandle::supportsBufferedData are
  specific to the NS API and won't be implemented on Qt.
* ResourceHandle::bufferedData can not be reached as we return false in

Signed-off-by: Lars Knoll <lars@trolltech.com>
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoCleanup checking for the request method.
hausmann [Thu, 8 Nov 2007 08:20:40 +0000 (08:20 +0000)]
Cleanup checking for the request method.

* Check the request method only in QWebNetworkManager::add.
* Currently HEAD, GET, POST are allowed and for everything else
  QWebNetworkManager::add returns false.
* Returning false is compatible with ResourceHandle::start and it
  can be used in ResourceHandle::loadResourceSynchronously to generate
  a ResourceError

Signed-off-by: Lars Knoll <lars@trolltech.com>
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoImplement WebCore::callOnMainThread
hausmann [Thu, 8 Nov 2007 08:20:33 +0000 (08:20 +0000)]
Implement WebCore::callOnMainThread

Implemented using a global QObject, that is moved to the main thread
and then sending a custom event to it.
Picked a number below QEvent::User but above any other documented value.

Signed-off-by: Lars Knoll <lars@trolltech.com>
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix bug in the implementation of synchronous network jobs.
hausmann [Thu, 8 Nov 2007 08:20:27 +0000 (08:20 +0000)]
Fix bug in the implementation of synchronous network jobs.

* George (pmax) reviewed the networking patches and found the following bug (thanks for reviewing)
-    if (jobMode == AsynchronousJob) {
+    if (jobMode == SynchronousJob) {
        add job to synchronous list/hash

* Just applying the above change will lead to crashes because we can finish
  jobs before we started them.

* Avoid these issues by saving all work (starting a job, sending data and
  finishing it) inside one list. JobWork will contain any
  of the above three work types and doWork will just work on this list
  (m_pendingWork). As foreach takes a copy of the list calling started, data
  and finished will not add new work and we gurantee that if we have JobStarted
  it will be in the list before JobData and JobFinished.

* Observation: We might just kill the code to handle sync jobs.

Signed-off-by: Lars Knoll <lars@trolltech.com>
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoAvoid problems with calling QPainter::begin() on an already active paintdevice
hausmann [Thu, 8 Nov 2007 08:20:20 +0000 (08:20 +0000)]
Avoid problems with calling QPainter::begin() on an already active paintdevice

* Partial pick from 6200e04c3e0a77873c3b3f3969b65bc701020326 to avoid getting
  crashes on Qt/Mac 4.4 with QPainter::begin to fail because we already draw.
* If we are in a layout or need one do not paint. This can happen for the PlatformScrollBar
  used by the ScrollView on a layout triggered by QWebPage::paintEvent.

Signed-off-by: Lars Knoll <lars@trolltech.com>
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-11-08 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 8 Nov 2007 08:03:19 +0000 (08:03 +0000)]
2007-11-08  Eric Seidel  <eric@webkit.org>

        No review.

        * ksvg2/svg/SVGPathElement.h: remove old comment

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-11-07 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 8 Nov 2007 07:58:15 +0000 (07:58 +0000)]
2007-11-07  Eric Seidel  <eric@webkit.org>

        Reviewed by Darin and Oliver.

        Add evaluateToNumber parallel evaluation tree to speed up number operations.
        Make ImmediateNumberNode a subclass of NumberNode.
        Share evaluate logic between evaluate and evaluateToNumber using inline functions
        There is still a lot of improvement to be made here.

        SunSpider claims this is a 1.0% speedup overall (nbody 7.9%), base64 slowing 2.0%
        Given the huge win that this prepares us for with simple type inferencing I see the small
        regression in base64 being worth the substantial overall improvement.

        * kjs/grammar.y:
        * kjs/nodes.cpp:
        * kjs/nodes.h:
        * kjs/nodes2string.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Added IWebDocumentText available via QI from WebFrame.
sfalken [Thu, 8 Nov 2007 07:40:08 +0000 (07:40 +0000)]
    Added IWebDocumentText available via QI from WebFrame.

        Reviewed by Sam.

        * WebFrame.cpp:
        (WebFrame::QueryInterface): Added IID_IWebDocumentText.
        (WebFrame::supportsTextEncoding): Stubbed out.
        (WebFrame::selectedString): Implemented.
        (WebFrame::selectAll): Stubbed out.
        (WebFrame::deselectAll): Stubbed out.
        * WebFrame.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Ollie.
antti [Thu, 8 Nov 2007 06:13:20 +0000 (06:13 +0000)]
    Reviewed by Ollie.

        Ensure video renderer has correct size if video has already been loaded
        when it is constructed.

        * rendering/RenderVideo.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Ollie.
antti [Thu, 8 Nov 2007 04:24:50 +0000 (04:24 +0000)]
    Reviewed by Ollie.

        Ensure video is visible when it should be.

        * rendering/RenderVideo.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin Adler.
mitz@apple.com [Thu, 8 Nov 2007 01:54:14 +0000 (01:54 +0000)]
    Reviewed by Darin Adler.

        - fix <rdar://problem/5523503> Safari crashes clicking scroll bar in FaceBook 'Trips'

        Layers and listboxes are two kinds of ScrollBarClient that can be
        removed while the scrollbar is tracking the mouse. The scrollbar is not
        destroyed until later, and meanwhile it can try to call the client,
        which results in a crash.

        * manual-tests/stale-scrollbar-client-crash.html: Added.
        * platform/ScrollBar.h:
        (WebCore::Scrollbar::setClient): Added.
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::destroyScrollbar): Call Scrollbar::setClient().
        * rendering/RenderListBox.cpp:
        (WebCore::RenderListBox::~RenderListBox): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Darin Adler.
mitz@apple.com [Thu, 8 Nov 2007 01:45:11 +0000 (01:45 +0000)]
    Reviewed by Darin Adler.

        - add an option to run-webkit-tests to ignore pixel test failures where
          all pixels differ by no more than a specified threshold

        * DumpRenderTree/mac/ImageDiff.m:
        * Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix <rdar://5569268> Crash when opening any FTP site in second tab/window
aroben [Wed, 7 Nov 2007 23:45:58 +0000 (23:45 +0000)]
Fix <rdar://5569268> Crash when opening any FTP site in second tab/window


        Fix <rdar://5569268> Crash when opening any FTP site in second tab/window

        Reviewed by Sam.

        No test possible.

        * platform/win/SharedBufferWin.cpp:
        (WebCore::SharedBuffer::createWithContentsOfFile): Bail if we get an
        empty path, because _wfopen_s will crash if we pass it a null pointer.


        Fix <rdar://5569268> Crash when opening any FTP site in second tab/window

        Reviewed by Sam.

        * WebView.cpp:
        (WebView::initWithFrame): Set the ftpDirectoryTemplatePath for every
        Page, not just the first one.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-11-07 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Wed, 7 Nov 2007 23:09:12 +0000 (23:09 +0000)]
2007-11-07  Mark Rowe  <mrowe@apple.com>

        Reviewed by Kevin Decker.

        Fix 64-bit Mac build.

        * WebKit.xcodeproj/project.pbxproj: Change paths specified relative to SRCROOT
        to be relative to PROJECT_DIR.  PROJECT_DIR takes into account the projectDirPath
        setting of the project, which in this instance includes the necessary "mac"

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
ddkilzer [Wed, 7 Nov 2007 21:54:57 +0000 (21:54 +0000)]

        WebKit confuses width/height for Media Queries device-aspect-ratio evaluation

        Reviewed by Darin.

        Tests: fast/css/device-aspect-ratio.html

        * css/MediaQueryEvaluator.cpp:
        (WebCore::parseAspectRatio): Renamed method parameters from a/b to h/v.
        (WebCore::device_aspect_ratioMediaFeatureEval): Renamed local variables from
        a/b to h/v.  Switched first two arguments of the call to cmpvalue() to fix
        the bug.


        WebKit confuses width/height for Media Queries device-aspect-ratio evaluation

        Reviewed by Darin.

        Each of the following tests creates a <link> element and dynamically sets its
        media query based on the aspect ratio (width/height) of the current screen.
        When the <link> element is attached to the <head> node, the test expects the
        stylesheet to be loaded for the test to pass.

        * fast/css/device-aspect-ratio-expected.txt: Added.
        * fast/css/device-aspect-ratio.html: Added.

        This test sets the device-aspect-ratio to the current size of the screen.
        NOTE: This test passed before the fix.

        * fast/css/max-device-aspect-ratio-expected.txt: Added.
        * fast/css/max-device-aspect-ratio.html: Added.

        This test sets the max-device-aspect ratio to 100/1 for landscape monitors or
        1/1 for portrait (or square) monitors.
        NOTE: This test failed before the fix.

        * fast/css/min-device-aspect-ratio-expected.txt: Added.
        * fast/css/min-device-aspect-ratio.html: Added.

        This test sets the min-device-aspect ratio to 1/1 for landscape monitors or
        1/100 for portrait (or square) monitors.
        NOTE: This test failed before the fix.

        * fast/css/resources/device-aspect-ratio.css: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoRoll out r27578 as it is not necessary.
mrowe@apple.com [Wed, 7 Nov 2007 21:44:04 +0000 (21:44 +0000)]
Roll out r27578 as it is not necessary.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
mitz@apple.com [Wed, 7 Nov 2007 20:59:00 +0000 (20:59 +0000)]

        Reviewed by Dave Hyatt.

        - fix http://bugs.webkit.org/show_bug.cgi?id=15887
          REGRESSION (r27576): Crash in RenderStyle::affectedByHoverRules clicking link on Digg

        Test: fast/css/display-none-inline-style-change-crash.html

        * dom/Element.cpp:
        (WebCore::Element::recalcStyle): Fixed the crash by null-checking
        the current style and removed other checks that are not strictly


        Reviewed by Dave Hyatt.

        - test for http://bugs.webkit.org/show_bug.cgi?id=15887
          REGRESSION (r27576): Crash in RenderStyle::affectedByHoverRules clicking link on Digg

        * fast/css/display-none-inline-style-change-crash-expected.txt: Added.
        * fast/css/display-none-inline-style-change-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Kevin Decker.
tristan [Wed, 7 Nov 2007 20:11:12 +0000 (20:11 +0000)]
    Reviewed by Kevin Decker.

        Build fix for Leopard.  Cast a size() as int to unsigned for proper

        * bindings/js/JSHTMLDocumentCustom.cpp:
        Casted an int to unsigned for an unsigned to unsigned comparison.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Rubberstamped by Sam
beidson@apple.com [Wed, 7 Nov 2007 19:31:27 +0000 (19:31 +0000)]
    Rubberstamped by Sam

        Remove FrameLoaderClient methods from SVG that were pruned awhile ago

        * platform/graphics/svg/SVGImageEmptyClients.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoWebCore:
mitz@apple.com [Wed, 7 Nov 2007 18:52:09 +0000 (18:52 +0000)]

        Reviewed by Darin Adler.

        - fix a bug where CSS rules with :hover in the ancestor chain stopped
          working after changing the inline style declaration of the ancestor

        Test: fast/css/affected-by-hover-after-style-change.html

        * dom/Element.cpp:
        (WebCore::Element::recalcStyle): If we are not forcing style
        recalculation for all descendants, preserve any "affected by
        {hover|active|drag} bits that we may have acquired from them.
        Also renamed _style to currentStyle.


        Reviewed by Darin Adler.

        - removed a workaround for the bug fixed in the WebCore part of this

        * misc/DatabaseExample.html:


        Reviewed by Darin Adler.

        - test that CSS rules with :hover in the ancestor chain continue to work
          after changing the inline style declaration of the ancestor

        * fast/css/affected-by-hover-after-style-change.html: Added.
        * platform/mac/fast/css/affected-by-hover-after-style-change-expected.checksum: Added.
        * platform/mac/fast/css/affected-by-hover-after-style-change-expected.png: Added.
        * platform/mac/fast/css/affected-by-hover-after-style-change-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Adam.
timothy@apple.com [Wed, 7 Nov 2007 17:56:16 +0000 (17:56 +0000)]
    Reviewed by Adam.

        Bug 11920: Web Inspector should have Firebug-like CSS editing

        * css/CSSComputedStyleDeclaration.h:
          (WebCore::CSSComputedStyleDeclaration::isPropertyImplicit): Return false. I'm not sure why
          this was true, but computed style has no concept of implicit. So false makes more sense
          and makes the code simpler in the inspector. This function was added for the inspector,
          so this isn't a compatibility change.
        * page/inspector/PropertiesSection.js: Add a getter/setter to reset populated status.
        * page/inspector/StylesSidebarPane.js: Some refactoring along with the main support for
          style editing.
        * page/inspector/inspector.css: Style changes for propery editing and focus correctness.
        * page/inspector/inspector.js: Look for a handleKeyEvent function of the focus element before
          trying to call a function based on the element's id. Call focused and blurred on the focused
          element when currentFocusElement is changed. Use the new listItemElement getter instead of
          the private property.
        * page/inspector/treeoutline.js: No longer expand on double click if ondblclick is implemented.
          Shrink the toggle zone to 10px to better match the size of the arrow. Add an onattach call
          to allow generation of the title using the DOM element. Add listItemElement and
          childrenListElement getters.
        * page/inspector/utilities.js: Add new helper prototype methods on CSSStyleDeclaration.
        * page/inspector/DocumentPanel.js: Use the new listItemElement getter instead of the private
          property. Also expand the DOM node on double click now that the TreeOutline dosen't do it.
        * page/inspector/Resource.js: Use the new listItemElement and childrenListElement getters
          instead of the private properties.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-11-07 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Wed, 7 Nov 2007 17:54:36 +0000 (17:54 +0000)]
2007-11-07  Mark Rowe  <mrowe@apple.com>

        Reviewed by Eric.

        Fix up initialization after being mangled in r27572, and remove the
        ternary expression as extraCost will always be zero for the numeric

        * kjs/collector.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago2007-11-07 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Wed, 7 Nov 2007 17:54:12 +0000 (17:54 +0000)]
2007-11-07  Mark Rowe  <mrowe@apple.com>

        Gtk build fix.

        * kjs/regexp_object.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years ago Reviewed by Beth Dakin.
ggaren@apple.com [Wed, 7 Nov 2007 17:32:11 +0000 (17:32 +0000)]
    Reviewed by Beth Dakin.

        Eliminated a bogus (though compiled-out) branch in the collector.

        * kjs/collector.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoJavaScriptCore:
ggaren@apple.com [Wed, 7 Nov 2007 17:18:39 +0000 (17:18 +0000)]

        Reviewed by Darin Adler.

        Fixed part of http://bugs.webkit.org/show_bug.cgi?id=15861
        15% of string-validate-input.js is spent compiling the same regular expression.

        Put RegExpImp properties into a static hashtable to avoid a slew of
        PropertyMap churn when creating a RegExpImp.

        Factored important bits of regular expression implementation out of
        RegExpImp (the JS object) and into RegExp (the PCRE wrapper class),
        making RegExp a ref-counted class. (This will help later.)

        Removed PCRE_POSIX support because I didn't quite know how to test it
        and keep it working with these changes.

        1.1% SunSpider speedup. 5.8% speedup on string-validate-input.js.

        * kjs/regexp.h: A few interface changes:
        1. Renamed "subpatterns()" => "numSubpatterns()"
        2. Made flag enumeration private and replaced it with public getters for
        specific flags.
        3. Made RegExp ref-counted so RegExps can be shared by RegExpImps.
        4. Made RegExp take a string of flags instead of an int, eliminating
        duplicated flag parsing code elsewhere.

        * kjs/regexp_object.cpp:
        (KJS::RegExpProtoFunc::callAsFunction): For RegExp.compile:
        - Fixed a bug where compile(undefined) would throw an exception.
        - Removed some now-redundant code.
        - Used RegExp sharing to eliminate an allocation and a bunch of
        PropertyMap thrash. (Not a big win since compile is a deprecated
        function. I mainly did this to test the plubming.)


        Reviewed by Darin Adler.

        Beefed up the RegExp.compile testcase to cover a mistake in the
        original check-in and a mistake I made while developing my new patch.

        * fast/js/resources/regexp-compile.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoJavaScriptCore.pri expects OBJECTS_DIR to be set, so set it in
hausmann [Wed, 7 Nov 2007 16:36:04 +0000 (16:36 +0000)]
JavaScriptCore.pri expects OBJECTS_DIR to be set, so set it in
testkjs.pro, too, where it's included from.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoCoding style fix.
hausmann [Wed, 7 Nov 2007 16:14:59 +0000 (16:14 +0000)]
Coding style fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFor safety provide a default constructor for WindowFeatures().
hausmann [Wed, 7 Nov 2007 15:52:09 +0000 (15:52 +0000)]
For safety provide a default constructor for WindowFeatures().
ContextMenuController.cpp: createNewWindow as well as QWebPage need to
create a default initialized WindowFeatures object on the fly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix the Qt build.
hausmann [Wed, 7 Nov 2007 15:35:44 +0000 (15:35 +0000)]
Fix the Qt build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoFix "nmake clean" for the Qt/Windows build by replacing tmp/ with a variable that...
hausmann [Wed, 7 Nov 2007 14:45:32 +0000 (14:45 +0000)]
Fix "nmake clean" for the Qt/Windows build by replacing tmp/ with a variable that ends with the correct type of slash/backslash depending on the choice of compiler/make tool.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoMake the setting of letting Javascript access the clipboard configurable through...
hausmann [Wed, 7 Nov 2007 14:32:23 +0000 (14:32 +0000)]
Make the setting of letting Javascript access the clipboard configurable through QWebSettings, turn it off by default and turn it on in DumpRenderTree.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoChanged QWebPageHistory::goToItem to take a value instead of a pointer.
hausmann [Wed, 7 Nov 2007 14:32:16 +0000 (14:32 +0000)]
Changed QWebPageHistory::goToItem to take a value instead of a pointer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoRemoved unimplemented QWebHistoryItem::children() function
hausmann [Wed, 7 Nov 2007 14:32:09 +0000 (14:32 +0000)]
Removed unimplemented QWebHistoryItem::children() function

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoChanged the getter functions in QWebSettings to transparently resolve against the...
hausmann [Wed, 7 Nov 2007 14:32:05 +0000 (14:32 +0000)]
Changed the getter functions in QWebSettings to transparently resolve against the default settings.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoAdded explicit functions for resetting the font sizes and font families.
hausmann [Wed, 7 Nov 2007 14:31:59 +0000 (14:31 +0000)]
Added explicit functions for resetting the font sizes and font families.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoCombined the font sizes accessors/setters under one setter/getter with an enum.
hausmann [Wed, 7 Nov 2007 14:31:54 +0000 (14:31 +0000)]
Combined the font sizes accessors/setters under one setter/getter with an enum.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoRenamed QWebPage::userAgentStringForUrl(url) to QWebPage::userAgentFor(url);
hausmann [Wed, 7 Nov 2007 14:31:49 +0000 (14:31 +0000)]
Renamed QWebPage::userAgentStringForUrl(url) to QWebPage::userAgentFor(url);

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoRenamed QWebPage::webActionTriggered to QWebPage::triggerAction
hausmann [Wed, 7 Nov 2007 14:31:44 +0000 (14:31 +0000)]
Renamed QWebPage::webActionTriggered to QWebPage::triggerAction

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoChanged the virtual QWebPage::setWindowGeometry to be a geometryChangeRequest signal...
hausmann [Wed, 7 Nov 2007 14:31:38 +0000 (14:31 +0000)]
Changed the virtual QWebPage::setWindowGeometry to be a geometryChangeRequest signal instead.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoRenamed QWebPage::webAction() to QWebPage::action()
hausmann [Wed, 7 Nov 2007 14:31:32 +0000 (14:31 +0000)]
Renamed QWebPage::webAction() to QWebPage::action()

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoRemoved a bunch of slots/functions that are now available through the new actions...
hausmann [Wed, 7 Nov 2007 14:31:26 +0000 (14:31 +0000)]
Removed a bunch of slots/functions that are now available through the new actions API.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoAdded some more comments to the API after another round of API review with Lars.
hausmann [Wed, 7 Nov 2007 14:31:22 +0000 (14:31 +0000)]
Added some more comments to the API after another round of API review with Lars.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoMoved QWebFrame::selectedText() to QWebPage::selectedText().
hausmann [Wed, 7 Nov 2007 14:31:16 +0000 (14:31 +0000)]
Moved QWebFrame::selectedText() to QWebPage::selectedText().

The currently selected text is a property of the page as a whole.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoImplemented support for settings propagation.
hausmann [Wed, 7 Nov 2007 14:31:11 +0000 (14:31 +0000)]
Implemented support for settings propagation.

If an individual setting is not set in a page's QWebSettings then it is inherited from the default settings.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoReworked the QWebSettings API.
hausmann [Wed, 7 Nov 2007 14:31:04 +0000 (14:31 +0000)]
Reworked the QWebSettings API.
QWebPage now returns a pointer to its mutable QWebSettings object and the settings of newly created QWebPageObjects are initialized from QWebSettings::defaultSettings().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

15 years agoMade the QWebSettings::webGraphic functions static. The implementation was using...
hausmann [Wed, 7 Nov 2007 14:30:57 +0000 (14:30 +0000)]
Made the QWebSettings::webGraphic functions static. The implementation was using QWebSettings::global() anyway.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27550 268f45cc-cd09-0410-ab3c-d52691b4dbfc