WebKit-https.git
10 years agoREGRESSION(r94274): FormManagerTest.PreviewForm and FillFormNonEmptyField fail on...
rniwa@webkit.org [Tue, 6 Sep 2011 19:00:51 +0000 (19:00 +0000)]
REGRESSION(r94274): FormManagerTest.PreviewForm and FillFormNonEmptyField fail on chromium
https://bugs.webkit.org/show_bug.cgi?id=67453

Reviewed by Kent Tamura.

.:

Add symbols for internals.

* Source/autotools/symbols.filter:

Source/WebCore:

Fixed the bug by updating inner text value in setSuggestedValue.

Also added a suggestedValue and setSuggestedValue on window.internals for testing purposes.

Test: fast/forms/suggested-value.html

* WebCore.exp.in:
* testing/Internals.cpp:
(WebCore::Internals::suggestedValue):
(WebCore::Internals::setSuggestedValue):
* testing/Internals.h:
* testing/Internals.idl:

Source/WebKit/chromium:

Chromium code incorrectly calls Node::isFocusable without updating layout, and was hitting assertions.
Fix the assertion failure (and a potential crash) by updating layout in WebCore::isFocusable.

* src/WebNode.cpp:
(WebKit::WebNode::isFocusable):

Source/WebKit2:

Add symbols for internals.

* win/WebKit2.def:
* win/WebKit2CFLite.def:

LayoutTests:

Added a regression test to ensure HTMLInputElement updates its inner text value when the suggested value is set.

* fast/forms/suggested-value-expected.txt: Added.
* fast/forms/suggested-value.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-09-06 Laszlo Gombos <laszlo.1.gombos@nokia.com>
laszlo.1.gombos@nokia.com [Tue, 6 Sep 2011 18:56:40 +0000 (18:56 +0000)]
2011-09-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Web Inspector: [Extensions API] rename webInspector.resources to webInspector.network
        https://bugs.webkit.org/show_bug.cgi?id=66460

        Unreviewed, renaming tests in WK2 skiplists after r93312.

        * platform/win-wk2/Skipped:
        * platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoload() does not reset the resource selection algorithm
eric.carlson@apple.com [Tue, 6 Sep 2011 18:49:56 +0000 (18:49 +0000)]
load() does not reset the resource selection algorithm
https://bugs.webkit.org/show_bug.cgi?id=64917

Reviewed by Darin Adler.

Source/WebCore:

Test: media/video-source-load.html

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::selectMediaResource): Reset m_nextChildNodeToConsider, update
    comments and rearrange logic to more closely match logic in spec.
(WebCore::HTMLMediaElement::noneSupported): Update comments.

LayoutTests:

* media/video-source-load-expected.txt: Added.
* media/video-source-load.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[GTK] Use soup_session_add_feature_by_type uniformly in WebKit2.
commit-queue@webkit.org [Tue, 6 Sep 2011 18:26:27 +0000 (18:26 +0000)]
[GTK] Use soup_session_add_feature_by_type uniformly in WebKit2.
https://bugs.webkit.org/show_bug.cgi?id=67593

Patch by Wajahat Siddiqui <mdwajahatali.siddiqui@motorola.com> on 2011-09-06
Reviewed by Martin Robinson.

Using soup_session_add_feature_by_type for adding all soup features
instead of adding using GRefPtr.

* WebProcess/gtk/WebProcessMainGtk.cpp:
(WebKit::WebProcessMainGtk):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoStyle not propagated to anonymous boxes and anonymous
inferno@chromium.org [Tue, 6 Sep 2011 18:19:55 +0000 (18:19 +0000)]
Style not propagated to anonymous boxes and anonymous
inline-blocks.
https://bugs.webkit.org/show_bug.cgi?id=67364

Source/WebCore:

Reviewed by James Robinson.

Share propagateStyleToAnonymousChildren with RenderBlock::styleDidChange.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::styleDidChange):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::propagateStyleToAnonymousChildren):
* rendering/RenderObject.h:

LayoutTests:

Add comments explaining what the test does.

Reviewed by James Robinson.

* fast/ruby/ruby-block-style-not-updated-with-before-after-content.html:
* fast/ruby/ruby-block-style-not-updated.html:
* fast/ruby/ruby-inline-style-not-updated-with-before-after-content.html:
* fast/ruby/ruby-inline-style-not-updated.html:
* fast/table/table-before-child-style-update.html:
* fast/table/table-row-before-child-style-update.html:
* fast/table/table-row-style-not-updated-with-after-content.html:
* fast/table/table-row-style-not-updated-with-before-content.html:
* fast/table/table-style-not-updated.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[skia] States of GraphicsContext may never be restored after clipToImageBuffer
commit-queue@webkit.org [Tue, 6 Sep 2011 18:13:20 +0000 (18:13 +0000)]
[skia] States of GraphicsContext may never be restored after clipToImageBuffer
https://bugs.webkit.org/show_bug.cgi?id=67358

Source/WebCore:

beginLayerClippedToImage/applyClipFromImage are mismatched when clipping to
an empty ImageBuffer, which will make states of GraphicsContext incorrect.

Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2011-09-06
Reviewed by James Robinson.

Test: fast/repaint/background-clip-text.html

* platform/graphics/skia/PlatformContextSkia.cpp:
(WebCore::PlatformContextSkia::beginLayerClippedToImage):

LayoutTests:

Patch by Robin Cao <robin.cao@torchmobile.com.cn> on 2011-09-06
Reviewed by James Robinson.

* fast/repaint/background-clip-text-expected.png: Added.
* fast/repaint/background-clip-text-expected.txt: Added.
* fast/repaint/background-clip-text.html: Added.
* platform/qt/Skipped: Missing layoutController.testRepaint().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUse a hierarchial structure for the garden-o-matic results view
abarth@webkit.org [Tue, 6 Sep 2011 18:02:50 +0000 (18:02 +0000)]
Use a hierarchial structure for the garden-o-matic results view
https://bugs.webkit.org/show_bug.cgi?id=67620

Reviewed by Dimitri Glazkov.

This patch re-organizes the results view to use a hierachial structure
for selection.  At the top-level are sections for each test.  Expanding
the test section shows a tab selector for builders.

This structure prepares us for wiring up various actions to this view.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
(.):
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
():
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
(.):
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/styles/results.css:
(.results-view>.toolbar):
(.results-view>.toolbar ul.actions):
(.results-view>.toolbar ul.actions li):
(.results-grid table):
(.results-grid table td, .results-view table th):
(.results-grid table th):
(.results-grid .text-result):
(.results-grid .image-result):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agogarden-o-matic's base.probe generates spam in the JavaScript console
abarth@webkit.org [Tue, 6 Sep 2011 18:00:25 +0000 (18:00 +0000)]
garden-o-matic's base.probe generates spam in the JavaScript console
https://bugs.webkit.org/show_bug.cgi?id=67622

Reviewed by Dimitri Glazkov.

Now that we have CORS set up on the buildbot, we can use XMLHttpRequest
instead of HTMLScriptElement to test whether results exist.  This
reduces the console.log spam and saves bandwidth because we can use a
HEAD request instead of a GET request.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[EFL] Do not allocate memory for extremely large surfaces.
commit-queue@webkit.org [Tue, 6 Sep 2011 17:49:41 +0000 (17:49 +0000)]
[EFL] Do not allocate memory for extremely large surfaces.
https://bugs.webkit.org/show_bug.cgi?id=65192

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2011-09-06
Reviewed by Martin Robinson.

So far, RenderThemeEfl tried to allocate a buffer and a cairo surface
the size of the whole form element passed to it.

In the case of
fast/overflow/overflow-height-float-not-removed-crash.html and others,
this meant extremely large widgets, which crashed the code.

We now only render the widgets if they are smaller than some hardcoded
and sufficiently large values which should work in most cases.

No new tests, as this was uncovered by existing ones.

* platform/efl/RenderThemeEfl.cpp:
(WebCore::RenderThemeEfl::isFormElementTooLargeToDisplay):
(WebCore::RenderThemeEfl::cacheThemePartNew):
(WebCore::RenderThemeEfl::paintThemePart):
* platform/efl/RenderThemeEfl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: implement source map v3 consumer.
podivilov@chromium.org [Tue, 6 Sep 2011 17:36:19 +0000 (17:36 +0000)]
Web Inspector: implement source map v3 consumer.
https://bugs.webkit.org/show_bug.cgi?id=67205

Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/debugger/compiler-source-mapping.html

* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/front-end/CompilerSourceMapping.js: Added.
(WebInspector.CompilerSourceMapping):
(WebInspector.CompilerSourceMapping.prototype.compiledLocationToSourceLocation):
(WebInspector.CompilerSourceMapping.prototype.sourceLocationToCompiledLocation):
(WebInspector.CompilerSourceMapping.prototype.get sources):
(WebInspector.ClosureCompilerSourceMapping):
(WebInspector.ClosureCompilerSourceMapping.prototype.compiledLocationToSourceLocation):
(WebInspector.ClosureCompilerSourceMapping.prototype.sourceLocationToCompiledLocation):
(WebInspector.ClosureCompilerSourceMapping.prototype.get sources):
(WebInspector.ClosureCompilerSourceMapping.prototype._findMapping):
(WebInspector.ClosureCompilerSourceMapping.prototype._parsePayload):
(WebInspector.ClosureCompilerSourceMapping.prototype._isSeparator):
(WebInspector.ClosureCompilerSourceMapping.prototype._decodeVLQ):
(WebInspector.ClosureCompilerSourceMapping.StringCharIterator):
(WebInspector.ClosureCompilerSourceMapping.StringCharIterator.prototype.next):
(WebInspector.ClosureCompilerSourceMapping.StringCharIterator.prototype.peek):
(WebInspector.ClosureCompilerSourceMapping.StringCharIterator.prototype.hasNext):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:

LayoutTests:

* inspector/debugger/compiler-source-mapping-expected.txt: Added.
* inspector/debugger/compiler-source-mapping.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, unskip tests now passing because bug 61523 was fixed.
philn@webkit.org [Tue, 6 Sep 2011 16:41:56 +0000 (16:41 +0000)]
Unreviewed, unskip tests now passing because bug 61523 was fixed.

* platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd windows changes for JSC:RegExp functional tests
msaboff@apple.com [Tue, 6 Sep 2011 16:19:44 +0000 (16:19 +0000)]
Add windows changes for JSC:RegExp functional tests
https://bugs.webkit.org/show_bug.cgi?id=67521

Windows build changes for regular expression functional test.

Rubber-stamped by Gavin Barraclough.

* JavaScriptCore.vcproj/JavaScriptCore.sln:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* JavaScriptCore.vcproj/testRegExp: Added.
* JavaScriptCore.vcproj/testRegExp/testRegExp.vcproj: Added.
* JavaScriptCore.vcproj/testRegExp/testRegExpCommon.vsprops: Added.
* JavaScriptCore.vcproj/testRegExp/testRegExpDebug.vsprops: Added.
* JavaScriptCore.vcproj/testRegExp/testRegExpDebugAll.vsprops: Added.
* JavaScriptCore.vcproj/testRegExp/testRegExpDebugCairoCFLite.vsprops: Added.
* JavaScriptCore.vcproj/testRegExp/testRegExpPostBuild.cmd: Added.
* JavaScriptCore.vcproj/testRegExp/testRegExpPreBuild.cmd: Added.
* JavaScriptCore.vcproj/testRegExp/testRegExpPreLink.cmd: Added.
* JavaScriptCore.vcproj/testRegExp/testRegExpProduction.vsprops: Added.
* JavaScriptCore.vcproj/testRegExp/testRegExpRelease.vsprops: Added.
* JavaScriptCore.vcproj/testRegExp/testRegExpReleaseCairoCFLite.vsprops: Added.
* JavaScriptCore.vcproj/testRegExp/testRegExpReleasePGO.vsprops: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt][Mac] Unreviewed gardening.
ossy@webkit.org [Tue, 6 Sep 2011 16:01:51 +0000 (16:01 +0000)]
[Qt][Mac] Unreviewed gardening.

* platform/qt-mac/Skipped: Skip one more failing test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Unreviewed, update expectation for inspector/elements/elements-panel-style...
apavlov@chromium.org [Tue, 6 Sep 2011 15:53:42 +0000 (15:53 +0000)]
[Chromium] Unreviewed, update expectation for inspector/elements/elements-panel-styles.html,
which no longer looks flaky.
https://bugs.webkit.org/show_bug.cgi?id=63056

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Unreviewed gardening after r94331.
ossy@webkit.org [Tue, 6 Sep 2011 15:37:49 +0000 (15:37 +0000)]
[Qt] Unreviewed gardening after r94331.

* platform/qt/fast/css/focus-ring-multiline-writingmode-vertical-expected.png: Renamed from LayoutTests/platform/qt-linux/fast/css/focus-ring-multiline-writingmode-vertical-expected.png.
* platform/qt/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt: Renamed from LayoutTests/platform/qt-linux/fast/css/focus-ring-multiline-writingmode-vertical-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: re-implement RawSourceCode.
podivilov@chromium.org [Tue, 6 Sep 2011 15:25:28 +0000 (15:25 +0000)]
Web Inspector: re-implement RawSourceCode.
https://bugs.webkit.org/show_bug.cgi?id=67609

Source/WebCore:

RawSourceCode content and source mapping loading logic is too complex, re-implement it using simpler semantics:
1) Initially, RawSourceCode doesn't have any content or mapping because content loading and
formatting operations are asynchronous, it only has scripts metadata. We don't update UI right
after RawSourceCode creation until full RawSourceCode representation is ready (content + mapping).
2) When RawSourceCode representation is ready (e.g. resource is finished, or content is formatted
if in pretty-print mode) we dispatch SourceMappingUpdated event to notify the listeners that
source code should be shown to user and raw locations should be converted to ui locations
(to show breakpoins, messages, call frames etc in UI). At this moment, all source file's content
is ready for loading and source mapping is available.
3) Later, RawSourceCode representation may change again, e.g. if pretty-print mode is toggled, or
blocked resource is finished etc., in that case SourceMappingUpdated is dispatched again to update
source code, links and decorations in UI.

Reviewed by Yury Semikhatsky.

* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.linkifyLocation):
(WebInspector.DebuggerPresentationModel.prototype._addScript):
(WebInspector.DebuggerPresentationModel.prototype._sourceMappingUpdated):
(WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoints):
(WebInspector.DebuggerPresentationModel.prototype._addConsoleMessage.didGetUILocation):
(WebInspector.DebuggerPresentationModel.prototype._addConsoleMessage):
(WebInspector.DebuggerPresentationModel.prototype.messagesForUISourceCode):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._uiSourceCodeReplaced):
(WebInspector.ScriptsPanel.prototype._sourceFrameLoaded):
* inspector/front-end/SourceFile.js:
(WebInspector.RawSourceCode):
(WebInspector.RawSourceCode.prototype.addScript):
(WebInspector.RawSourceCode.prototype.contentEdited):
(WebInspector.RawSourceCode.prototype._resourceFinished):
(WebInspector.RawSourceCode.prototype.requestContent):
(WebInspector.RawSourceCode.prototype.createSourceMappingIfNeeded.sourceMappingUpdated):
(WebInspector.RawSourceCode.prototype.createSourceMappingIfNeeded):
(WebInspector.RawSourceCode.prototype.forceLoadContent):
(WebInspector.RawSourceCode.prototype._updateSourceMapping.didCreateSourceMapping):
(WebInspector.RawSourceCode.prototype._updateSourceMapping):
(WebInspector.RawSourceCode.prototype._createContentProvider):
(WebInspector.RawSourceCode.prototype._createSourceMapping.didRequestContent.didFormatContent):
(WebInspector.RawSourceCode.prototype._createSourceMapping.didRequestContent):
(WebInspector.RawSourceCode.prototype._createSourceMapping):
(WebInspector.RawSourceCode.prototype._saveSourceMapping):
(WebInspector.StaticContentProvider):
(WebInspector.StaticContentProvider.prototype.requestContent):

LayoutTests:

Reviewed by Yury Semikhatsky.

* inspector/debugger/content-providers-expected.txt:
* inspector/debugger/content-providers.html:
* inspector/debugger/scripts-panel.html:
* inspector/debugger/source-frame-count.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt][Mac] Unreviewed gardening.
ossy@webkit.org [Tue, 6 Sep 2011 15:23:43 +0000 (15:23 +0000)]
[Qt][Mac] Unreviewed gardening.

* platform/qt-mac/Skipped: Skip new failing tests to paint the bot green.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-09-06 Laszlo Gombos <laszlo.1.gombos@nokia.com>
laszlo.1.gombos@nokia.com [Tue, 6 Sep 2011 14:30:57 +0000 (14:30 +0000)]
2011-09-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Regression:  On Lion, redirects lose HTTP authentication headers
        https://bugs.webkit.org/show_bug.cgi?id=66354

        Unreviewed, renaming tests in WK2 skiplist after r93247.

        * platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r94564.
ossy@webkit.org [Tue, 6 Sep 2011 14:11:27 +0000 (14:11 +0000)]
Unreviewed, rolling out r94564.
http://trac.webkit.org/changeset/94564
https://bugs.webkit.org/show_bug.cgi?id=67555

It broke many tests

Source/WebCore:

* svg/SVGTRefElement.cpp:
(WebCore::SVGTRefElement::svgAttributeChanged):

LayoutTests:

* svg/custom/tref-clone-crash-expected.txt: Removed.
* svg/custom/tref-clone-crash.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-09-06 Laszlo Gombos <laszlo.1.gombos@nokia.com>
laszlo.1.gombos@nokia.com [Tue, 6 Sep 2011 14:07:08 +0000 (14:07 +0000)]
2011-09-06  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Web Inspector: nuke background events collection (dead feature)
        https://bugs.webkit.org/show_bug.cgi?id=66296

        Reviewed by Yury Semikhatsky.

        * platform/wk2/Skipped: Remove non-existent tests from the Skipped list
        as well.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, removing non-existent test from Qt skiplist.
andreas.kling@nokia.com [Tue, 6 Sep 2011 13:56:39 +0000 (13:56 +0000)]
Unreviewed, removing non-existent test from Qt skiplist.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt][ARM] http/tests/loading/empty-urls.html fails
ossy@webkit.org [Tue, 6 Sep 2011 13:38:18 +0000 (13:38 +0000)]
[Qt][ARM] http/tests/loading/empty-urls.html fails
https://bugs.webkit.org/show_bug.cgi?id=67638

[Qt][ARM]fast/dom/call-a-constructor-as-a-function.html fails
https://bugs.webkit.org/show_bug.cgi?id=67639

* platform/qt-arm/Skipped: Skip failing tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-09-06 Rob Buis <rbuis@rim.com>
rwlbuis@webkit.org [Tue, 6 Sep 2011 12:57:01 +0000 (12:57 +0000)]
2011-09-06  Rob Buis  <rbuis@rim.com>

        use after free in WebCore::SVGTRefElement::updateReferencedText
        https://bugs.webkit.org/show_bug.cgi?id=67555

        Reviewed by Nikolas Zimmermann.

        Do not install event listener if tref is not part of any document.

        Test: svg/custom/tref-clone-crash.html

        * svg/SVGTRefElement.cpp:
        (WebCore::SVGTRefElement::svgAttributeChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt][ARM] Missing WebGLContextEvent window property
ossy@webkit.org [Tue, 6 Sep 2011 12:48:39 +0000 (12:48 +0000)]
[Qt][ARM] Missing WebGLContextEvent window property
https://bugs.webkit.org/show_bug.cgi?id=67637

* platform/qt-arm/fast/dom/Window/window-property-descriptors-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r94560.
yurys@chromium.org [Tue, 6 Sep 2011 11:58:10 +0000 (11:58 +0000)]
Unreviewed, rolling out r94560.
http://trac.webkit.org/changeset/94560
https://bugs.webkit.org/show_bug.cgi?id=67636

It made inspector/debugger/script-formatter.html flakey
(Requested by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-06

Source/WebCore:

* inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager.prototype.set reset):
* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype._addScript.didCreateSourceMapping):
(WebInspector.DebuggerPresentationModel.prototype._addScript):
(WebInspector.DebuggerPresentationModel.prototype._uiSourceCodeReplaced):
(WebInspector.DebuggerPresentationModel.prototype.setFormatSource):
(WebInspector.DebuggerPresentationModel.prototype._addConsoleMessage.didGetUILocation):
(WebInspector.DebuggerPresentationModel.prototype._addConsoleMessage):
(WebInspector.PresenationCallFrame.prototype.select):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._uiSourceCodeReplaced):
(WebInspector.ScriptsPanel.prototype._sourceFrameLoaded):
* inspector/front-end/SourceFile.js:
(WebInspector.RawSourceCode):
(WebInspector.RawSourceCode.prototype.addScript):
(WebInspector.RawSourceCode.prototype.contentEdited):
(WebInspector.RawSourceCode.prototype.requestContent):
(WebInspector.RawSourceCode.prototype.createSourceMappingIfNeeded.didRequestContent):
(WebInspector.RawSourceCode.prototype.createSourceMappingIfNeeded):
(WebInspector.RawSourceCode.prototype._setContentProvider):
(WebInspector.RawSourceCode.prototype.forceLoadContent):
(WebInspector.RawSourceCode.prototype._reload):
(WebInspector.RawSourceCode.prototype._requestContent):
(WebInspector.RawSourceCode.prototype._loadResourceContent):
(WebInspector.RawSourceCode.prototype._loadScriptContent):
(WebInspector.RawSourceCode.prototype._loadAndConcatenateScriptsContent):
(WebInspector.RawSourceCode.prototype._didRequestContent):
(WebInspector.RawSourceCode.prototype._hasPendingResource):
(WebInspector.FormattedContentProvider):
(WebInspector.FormattedContentProvider.prototype.requestContent.didRequestContent.didFormatContent):
(WebInspector.FormattedContentProvider.prototype.requestContent):

LayoutTests:

* inspector/debugger/content-providers-expected.txt:
* inspector/debugger/content-providers.html:
* inspector/debugger/scripts-panel.html:
* inspector/debugger/source-frame-count.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=67480
antti@apple.com [Tue, 6 Sep 2011 11:15:29 +0000 (11:15 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=67480
[Chromium] [REGRESSION] Layout Test svg/batik/text/textStyles.svg is failing

Reviewed by Dimitri Glazkov.

The text node needs willRecalcStyle mechanism too.

* dom/Text.cpp:
(WebCore::Text::recalcTextStyle):
* dom/Text.h:
(WebCore::Text::willRecalcTextStyle):
* svg/SVGTRefElement.cpp:
(WebCore::SVGTRefElement::SVGTRefElement):
(WebCore::SVGShadowText::SVGShadowText):
(WebCore::SVGShadowText::willRecalcTextStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: re-implement RawSourceCode.
podivilov@chromium.org [Tue, 6 Sep 2011 09:34:02 +0000 (09:34 +0000)]
Web Inspector: re-implement RawSourceCode.
https://bugs.webkit.org/show_bug.cgi?id=67609

Source/WebCore:

RawSourceCode content and source mapping loading logic is too complex, re-implement it using simpler semantics:
1) Initially, RawSourceCode doesn't have any content or mapping because content loading and
formatting operations are asynchronous, it only has scripts metadata. We don't update UI right
after RawSourceCode creation until full RawSourceCode representation is ready (content + mapping).
2) When RawSourceCode representation is ready (e.g. resource is finished, or content is formatted
if in pretty-print mode) we dispatch SourceMappingUpdated event to notify the listeners that
source code should be shown to user and raw locations should be converted to ui locations
(to show breakpoins, messages, call frames etc in UI). At this moment, all source file's content
is ready for loading and source mapping is available.
3) Later, RawSourceCode representation may change again, e.g. if pretty-print mode is toggled, or
blocked resource is finished etc., in that case SourceMappingUpdated is dispatched again to update
source code, links and decorations in UI.

Reviewed by Yury Semikhatsky.

* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.linkifyLocation):
(WebInspector.DebuggerPresentationModel.prototype._addScript):
(WebInspector.DebuggerPresentationModel.prototype._sourceMappingUpdated):
(WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoints):
(WebInspector.DebuggerPresentationModel.prototype._addConsoleMessage.didGetUILocation):
(WebInspector.DebuggerPresentationModel.prototype._addConsoleMessage):
(WebInspector.DebuggerPresentationModel.prototype.messagesForUISourceCode):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._uiSourceCodeReplaced):
(WebInspector.ScriptsPanel.prototype._sourceFrameLoaded):
* inspector/front-end/SourceFile.js:
(WebInspector.RawSourceCode):
(WebInspector.RawSourceCode.prototype.addScript):
(WebInspector.RawSourceCode.prototype.contentEdited):
(WebInspector.RawSourceCode.prototype._resourceFinished):
(WebInspector.RawSourceCode.prototype.requestContent):
(WebInspector.RawSourceCode.prototype.createSourceMappingIfNeeded.sourceMappingUpdated):
(WebInspector.RawSourceCode.prototype.createSourceMappingIfNeeded):
(WebInspector.RawSourceCode.prototype.forceLoadContent):
(WebInspector.RawSourceCode.prototype._updateSourceMapping.didCreateSourceMapping):
(WebInspector.RawSourceCode.prototype._updateSourceMapping):
(WebInspector.RawSourceCode.prototype._createContentProvider):
(WebInspector.RawSourceCode.prototype._createSourceMapping.didRequestContent.didFormatContent):
(WebInspector.RawSourceCode.prototype._createSourceMapping.didRequestContent):
(WebInspector.RawSourceCode.prototype._createSourceMapping):
(WebInspector.RawSourceCode.prototype._saveSourceMapping):
(WebInspector.StaticContentProvider):
(WebInspector.StaticContentProvider.prototype.requestContent):

LayoutTests:

Reviewed by Yury Semikhatsky.

* inspector/debugger/content-providers-expected.txt:
* inspector/debugger/content-providers.html:
* inspector/debugger/scripts-panel.html:
* inspector/debugger/source-frame-count.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoJavaScriptCore does not have tiered compilation
fpizlo@apple.com [Tue, 6 Sep 2011 09:23:55 +0000 (09:23 +0000)]
JavaScriptCore does not have tiered compilation
https://bugs.webkit.org/show_bug.cgi?id=67176

Reviewed by Gavin Barraclough.

This adds the ability to have multiple CodeBlocks associated with
a particular role in an Executable.  These are stored in
descending order of compiler tier.  CodeBlocks are optimized when
a counter (m_executeCounter) that is incremented in loops and
epilogues becomes positive.  Optimizing means that all calls to
the old CodeBlock are unlinked.

The DFG can now pull in predictions from ValueProfiles, and
propagate them along the graph.  To support the new phase while
maintaing some level of abstraction, a DFGDriver was introduced
that encapsulates how to run the DFG compiler.

This is turned off by default because it's not yet a performance
win on all benchmarks.  It speeds up crypto and richards by
10% and 6% respectively, but still does not do as good of a job
as it could.  Notably, the DFG backend has not changed, and
is largely oblivious to the new information being made available
to it.

When turned off (the default), this patch is performance neutral.

* CMakeLists.txt:
* GNUmakefile.am:
* GNUmakefile.list.am:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
* JavaScriptCore.vcproj/JavaScriptCore/copy-files.cmd:
* JavaScriptCore.xcodeproj/project.pbxproj:
* assembler/MacroAssemblerX86.h:
(JSC::MacroAssemblerX86::branchAdd32):
* assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::branchAdd32):
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::~CodeBlock):
(JSC::CodeBlock::visitAggregate):
(JSC::CallLinkInfo::unlink):
(JSC::CodeBlock::unlinkCalls):
(JSC::CodeBlock::unlinkIncomingCalls):
(JSC::CodeBlock::clearEvalCache):
(JSC::replaceExistingEntries):
(JSC::CodeBlock::copyDataFromAlternative):
(JSC::ProgramCodeBlock::replacement):
(JSC::EvalCodeBlock::replacement):
(JSC::FunctionCodeBlock::replacement):
(JSC::ProgramCodeBlock::compileOptimized):
(JSC::EvalCodeBlock::compileOptimized):
(JSC::FunctionCodeBlock::compileOptimized):
* bytecode/CodeBlock.h:
(JSC::GlobalCodeBlock::GlobalCodeBlock):
(JSC::ProgramCodeBlock::ProgramCodeBlock):
(JSC::EvalCodeBlock::EvalCodeBlock):
(JSC::FunctionCodeBlock::FunctionCodeBlock):
* bytecode/ValueProfile.h:
(JSC::ValueProfile::dump):
(JSC::ValueProfile::computeStatistics):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
* bytecompiler/BytecodeGenerator.h:
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::addCall):
(JSC::DFG::ByteCodeParser::dynamicallyPredict):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::parse):
* dfg/DFGDriver.cpp: Added.
(JSC::DFG::compile):
(JSC::DFG::tryCompile):
(JSC::DFG::tryCompileFunction):
* dfg/DFGDriver.h: Added.
(JSC::DFG::tryCompile):
(JSC::DFG::tryCompileFunction):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::predictArgumentTypes):
* dfg/DFGGraph.h:
(JSC::DFG::Graph::predict):
(JSC::DFG::Graph::predictGlobalVar):
(JSC::DFG::Graph::isConstant):
(JSC::DFG::Graph::isJSConstant):
(JSC::DFG::Graph::isInt32Constant):
(JSC::DFG::Graph::isDoubleConstant):
(JSC::DFG::Graph::valueOfJSConstant):
(JSC::DFG::Graph::valueOfInt32Constant):
(JSC::DFG::Graph::valueOfDoubleConstant):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::isConstant):
(JSC::DFG::JITCompiler::isJSConstant):
(JSC::DFG::JITCompiler::isInt32Constant):
(JSC::DFG::JITCompiler::isDoubleConstant):
(JSC::DFG::JITCompiler::valueOfJSConstant):
(JSC::DFG::JITCompiler::valueOfInt32Constant):
(JSC::DFG::JITCompiler::valueOfDoubleConstant):
* dfg/DFGNode.h:
(JSC::DFG::isCellPrediction):
(JSC::DFG::isNumberPrediction):
(JSC::DFG::predictionToString):
(JSC::DFG::mergePrediction):
(JSC::DFG::makePrediction):
(JSC::DFG::Node::valueOfJSConstant):
(JSC::DFG::Node::isInt32Constant):
(JSC::DFG::Node::isDoubleConstant):
(JSC::DFG::Node::valueOfInt32Constant):
(JSC::DFG::Node::valueOfDoubleConstant):
(JSC::DFG::Node::predict):
* dfg/DFGPropagation.cpp: Added.
(JSC::DFG::Propagator::Propagator):
(JSC::DFG::Propagator::fixpoint):
(JSC::DFG::Propagator::setPrediction):
(JSC::DFG::Propagator::mergePrediction):
(JSC::DFG::Propagator::propagateNode):
(JSC::DFG::Propagator::propagateForward):
(JSC::DFG::Propagator::propagateBackward):
(JSC::DFG::propagate):
* dfg/DFGPropagation.h: Added.
(JSC::DFG::propagate):
* dfg/DFGRepatch.cpp:
(JSC::DFG::dfgLinkFor):
* heap/HandleHeap.h:
(JSC::HandleHeap::Node::Node):
* jit/JIT.cpp:
(JSC::JIT::emitOptimizationCheck):
(JSC::JIT::emitTimeoutCheck):
(JSC::JIT::privateCompile):
(JSC::JIT::linkFor):
* jit/JIT.h:
(JSC::JIT::emitOptimizationCheck):
* jit/JITCall32_64.cpp:
(JSC::JIT::emit_op_ret):
(JSC::JIT::emit_op_ret_object_or_this):
* jit/JITCode.h:
(JSC::JITCode::JITCode):
(JSC::JITCode::bottomTierJIT):
(JSC::JITCode::topTierJIT):
(JSC::JITCode::nextTierJIT):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_ret):
(JSC::JIT::emit_op_ret_object_or_this):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* jit/JITStubs.h:
* runtime/Executable.cpp:
(JSC::EvalExecutable::compileOptimized):
(JSC::EvalExecutable::compileInternal):
(JSC::ProgramExecutable::compileOptimized):
(JSC::ProgramExecutable::compileInternal):
(JSC::FunctionExecutable::compileOptimizedForCall):
(JSC::FunctionExecutable::compileOptimizedForConstruct):
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):
* runtime/Executable.h:
(JSC::EvalExecutable::compile):
(JSC::ProgramExecutable::compile):
(JSC::FunctionExecutable::compileForCall):
(JSC::FunctionExecutable::compileForConstruct):
(JSC::FunctionExecutable::compileOptimizedFor):
* wtf/Platform.h:
* wtf/SentinelLinkedList.h:
(WTF::BasicRawSentinelNode::BasicRawSentinelNode):
(WTF::BasicRawSentinelNode::setPrev):
(WTF::BasicRawSentinelNode::setNext):
(WTF::BasicRawSentinelNode::prev):
(WTF::BasicRawSentinelNode::next):
(WTF::BasicRawSentinelNode::isOnList):
(WTF::::remove):
(WTF::::SentinelLinkedList):
(WTF::::begin):
(WTF::::end):
(WTF::::push):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoReturn to transform multiplication: motion transform * other transforms
krit@webkit.org [Tue, 6 Sep 2011 08:18:23 +0000 (08:18 +0000)]
Return to transform multiplication: motion transform * other transforms
https://bugs.webkit.org/show_bug.cgi?id=67601

Source/WebCore:

Reviewed by Nikolas Zimmermann.

Right now we take the current transform of a transformable SVG element, post multiply the animation transform
and post multiply the motion transform to the other both:

  transform * animation transform * motion transform

We switched to this behavior with the clean up of AffineTransform.
While the specification of SVG demands us to do so, no other SVG viewer is doing it that way. Now switching back to:

  motion transform * transform * animation transform

This is done by other SVG viewers as well. While their is no consense about how to multiply the different transforms
on the SVG WG, their is a consense that the current specified behavior is unwanted. See
http://lists.w3.org/Archives/Public/www-svg/2011Jan/0055.html for more details.

We pass the following tests of the official W3C SVG test suite again now:

- animate-elem-24-t.svg
- animate-elem-30-t.svg

* svg/SVGStyledTransformableElement.cpp:
(WebCore::SVGStyledTransformableElement::animatedLocalTransform):
* svg/SVGTextElement.cpp:
(WebCore::SVGTextElement::animatedLocalTransform):

LayoutTests:

Reviewed by Nikolas Zimmermann.

Change the expected results of nested transformations to match new behavior
on matrices multiplications.

* svg/animations/animate-path-nested-transforms-expected.txt:
* svg/animations/animate-text-nested-transforms-expected.txt:
* svg/animations/script-tests/animate-path-nested-transforms.js:
(startSample):
(endSample):
* svg/animations/script-tests/animate-text-nested-transforms.js:
(startSample):
(endSample):
* svg/animations/svgtransform-animation-discrete-expected.txt:
* svg/animations/svgtransform-animation-discrete.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt][WK2] http/tests/history/popstate-fires-with-pending-requests.html breaks ~400...
abecsi@webkit.org [Tue, 6 Sep 2011 07:55:11 +0000 (07:55 +0000)]
[Qt][WK2] http/tests/history/popstate-fires-with-pending-requests.html breaks ~400 subsequent tests
https://bugs.webkit.org/show_bug.cgi?id=49321

Rubber-stamped by Csaba Osztrogonác.

* platform/qt-wk2/Skipped:
The issue is not reproducible any more, so the bug can be closed and the test unskipped.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdated expectations on Mac for fast/js/global-constructors.html.
fpizlo@apple.com [Tue, 6 Sep 2011 07:50:00 +0000 (07:50 +0000)]
Updated expectations on Mac for fast/js/global-constructors.html.

Rubber-stampted by Gavin Barraclough.

* platform/mac/fast/js/global-constructors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r94554.
commit-queue@webkit.org [Tue, 6 Sep 2011 07:49:02 +0000 (07:49 +0000)]
Unreviewed, rolling out r94554.
http://trac.webkit.org/changeset/94554
https://bugs.webkit.org/show_bug.cgi?id=67631

This patch did not quite fix the problem (Requested by
benwells on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-06

* PrettyPatch/PrettyPatch.rb:
* PrettyPatch/PrettyPatch_test.rb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoPrettyPatch should handle "delta" patch mechanism in git binary patches
commit-queue@webkit.org [Tue, 6 Sep 2011 07:26:13 +0000 (07:26 +0000)]
PrettyPatch should handle "delta" patch mechanism in git binary patches
https://bugs.webkit.org/show_bug.cgi?id=67628

Git patches are encoded using two mechanisms - "literal" and "delta".
See this email from the git mailing list archive for info
http://marc.info/?l=git&m=114682417113315&w=2

When determining if a binary file patch is an image or not we should accept
both literal and delta patch encodings.

Patch by Ben Wells <benwells@chromium.org> on 2011-09-06
Reviewed by Shinichiro Hamaji.

* PrettyPatch/PrettyPatch.rb:
* PrettyPatch/PrettyPatch_test.rb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, GTK rebaseline after r94545.
philn@webkit.org [Tue, 6 Sep 2011 07:13:28 +0000 (07:13 +0000)]
Unreviewed, GTK rebaseline after r94545.

* platform/gtk/fast/dom/HTMLInputElement/input-image-alt-text-expected.txt:
* platform/gtk/fast/dom/Window/window-properties-expected.txt:
* platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/gtk/fast/dom/prototype-inheritance-2-expected.txt:
* platform/gtk/fast/js/global-constructors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, fullscreen tests rebaseline after r94545.
philn@webkit.org [Tue, 6 Sep 2011 07:05:10 +0000 (07:05 +0000)]
Unreviewed, fullscreen tests rebaseline after r94545.

* fullscreen/full-screen-cancel-expected.txt:
* fullscreen/full-screen-css-expected.txt:
* fullscreen/full-screen-remove-ancestor-expected.txt:
* fullscreen/full-screen-remove-children-expected.txt:
* fullscreen/full-screen-remove-expected.txt:
* fullscreen/full-screen-twice-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Update expecteds after r94545.
reni@webkit.org [Tue, 6 Sep 2011 06:58:07 +0000 (06:58 +0000)]
[Qt] Update expecteds after r94545.

Unreviewed gardening.

* platform/qt/fast/dom/Window/window-properties-expected.png:
* platform/qt/fast/dom/Window/window-properties-expected.txt:
* platform/qt/fast/dom/Window/window-property-descriptors-expected.png:
* platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/qt/fast/dom/prototype-inheritance-2-expected.txt:
* platform/qt/fast/js/global-constructors-expected.png:
* platform/qt/fast/js/global-constructors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. GTK rebaselines for r94541, r94543.
inferno@chromium.org [Tue, 6 Sep 2011 04:52:25 +0000 (04:52 +0000)]
Unreviewed. GTK rebaselines for r94541, r94543.

* platform/gtk/fast/css-generated-content/table-before-after-child-add-expected.txt:
* platform/gtk/fast/css-generated-content/table-cell-before-after-child-add-expected.txt:
* platform/gtk/fast/css-generated-content/table-row-before-after-child-add-expected.txt:
* platform/gtk/fast/css-generated-content/table-table-before-after-child-add-expected.txt:
* platform/gtk/fast/multicol/span/anonymous-split-block-crash-expected.txt:
* platform/gtk/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
* platform/gtk/fast/ruby/ruby-block-style-not-updated-expected.txt: Added.
* platform/gtk/fast/ruby/ruby-block-style-not-updated-with-before-after-content-expected.txt: Added.
* platform/gtk/fast/ruby/ruby-inline-style-not-updated-expected.txt: Added.
* platform/gtk/fast/ruby/ruby-inline-style-not-updated-with-before-after-content-expected.txt: Added.
* platform/gtk/fast/table/table-after-child-in-table-expected.txt:
* platform/gtk/fast/table/table-before-child-in-table-expected.txt:
* platform/gtk/fast/table/table-cell-after-child-in-table-expected.txt:
* platform/gtk/fast/table/table-cell-before-child-in-table-expected.txt:
* platform/gtk/fast/table/table-row-after-child-in-table-expected.txt:
* platform/gtk/fast/table/table-row-before-child-in-table-expected.txt:
* platform/gtk/fast/table/table-row-style-not-updated-expected.txt: Added.
* platform/gtk/fast/table/table-row-style-not-updated-with-after-content-expected.txt: Added.
* platform/gtk/fast/table/table-row-style-not-updated-with-before-content-expected.txt: Added.
* platform/gtk/fast/table/table-style-not-updated-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium] Remove unnecessary expectation, results match the fallback path.
jamesr@google.com [Tue, 6 Sep 2011 03:45:15 +0000 (03:45 +0000)]
[chromium] Remove unnecessary expectation, results match the fallback path.

* platform/chromium-cg-mac/fast/dom/wrapper-classes-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Chromium rebaselines for r94541, r94543.
inferno@chromium.org [Tue, 6 Sep 2011 03:06:29 +0000 (03:06 +0000)]
Unreviewed. Chromium rebaselines for r94541, r94543.

* platform/chromium-cg-mac-leopard/fast/multicol/span/anonymous-split-block-crash-expected.png:
* platform/chromium-cg-mac-leopard/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png:
* platform/chromium-cg-mac/fast/multicol/span/anonymous-split-block-crash-expected.png:
* platform/chromium-cg-mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png:
* platform/chromium-cg-mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt: Removed.
* platform/chromium-linux/fast/multicol/span/anonymous-split-block-crash-expected.png:
* platform/chromium-linux/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png:
* platform/chromium-linux/fast/ruby/ruby-block-style-not-updated-expected.png: Added.
* platform/chromium-linux/fast/ruby/ruby-block-style-not-updated-with-before-after-content-expected.png: Added.
* platform/chromium-linux/fast/ruby/ruby-inline-style-not-updated-expected.png: Added.
* platform/chromium-linux/fast/ruby/ruby-inline-style-not-updated-with-before-after-content-expected.png: Added.
* platform/chromium-linux/fast/table/table-row-style-not-updated-expected.png: Added.
* platform/chromium-linux/fast/table/table-row-style-not-updated-with-after-content-expected.png: Added.
* platform/chromium-linux/fast/table/table-row-style-not-updated-with-before-content-expected.png: Added.
* platform/chromium-linux/fast/table/table-style-not-updated-expected.png: Added.
* platform/chromium-win/fast/css-generated-content/table-before-after-child-add-expected.txt:
* platform/chromium-win/fast/css-generated-content/table-cell-before-after-child-add-expected.txt:
* platform/chromium-win/fast/css-generated-content/table-row-before-after-child-add-expected.txt:
* platform/chromium-win/fast/css-generated-content/table-table-before-after-child-add-expected.txt:
* platform/chromium-win/fast/multicol/span/anonymous-split-block-crash-expected.png:
* platform/chromium-win/fast/multicol/span/anonymous-split-block-crash-expected.txt:
* platform/chromium-win/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png:
* platform/chromium-win/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
* platform/chromium-win/fast/ruby/ruby-block-style-not-updated-expected.png: Added.
* platform/chromium-win/fast/ruby/ruby-block-style-not-updated-with-before-after-content-expected.png: Added.
* platform/chromium-win/fast/ruby/ruby-inline-style-not-updated-expected.png: Added.
* platform/chromium-win/fast/ruby/ruby-inline-style-not-updated-with-before-after-content-expected.png: Added.
* platform/chromium-win/fast/table/table-after-child-in-table-expected.txt:
* platform/chromium-win/fast/table/table-before-child-in-table-expected.txt:
* platform/chromium-win/fast/table/table-cell-after-child-in-table-expected.txt:
* platform/chromium-win/fast/table/table-cell-before-child-in-table-expected.txt:
* platform/chromium-win/fast/table/table-row-after-child-in-table-expected.txt:
* platform/chromium-win/fast/table/table-row-before-child-in-table-expected.txt:
* platform/chromium-win/fast/table/table-row-style-not-updated-expected.png: Added.
* platform/chromium-win/fast/table/table-row-style-not-updated-with-after-content-expected.png: Added.
* platform/chromium-win/fast/table/table-row-style-not-updated-with-before-content-expected.png: Added.
* platform/chromium-win/fast/table/table-style-not-updated-expected.png: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Qt rebaselines for r94543.
inferno@chromium.org [Tue, 6 Sep 2011 02:38:34 +0000 (02:38 +0000)]
Unreviewed. Qt rebaselines for r94543.

* platform/qt/fast/css-generated-content/table-before-after-child-add-expected.txt:
* platform/qt/fast/css-generated-content/table-cell-before-after-child-add-expected.txt:
* platform/qt/fast/css-generated-content/table-row-before-after-child-add-expected.txt:
* platform/qt/fast/css-generated-content/table-table-before-after-child-add-expected.txt:
* platform/qt/fast/ruby/ruby-block-style-not-updated-expected.txt: Added.
* platform/qt/fast/ruby/ruby-block-style-not-updated-with-before-after-content-expected.txt: Added.
* platform/qt/fast/ruby/ruby-inline-style-not-updated-expected.txt: Added.
* platform/qt/fast/ruby/ruby-inline-style-not-updated-with-before-after-content-expected.txt: Added.
* platform/qt/fast/table/table-after-child-in-table-expected.txt:
* platform/qt/fast/table/table-before-child-in-table-expected.txt:
* platform/qt/fast/table/table-cell-after-child-in-table-expected.txt:
* platform/qt/fast/table/table-cell-before-child-in-table-expected.txt:
* platform/qt/fast/table/table-row-after-child-in-table-expected.txt:
* platform/qt/fast/table/table-row-before-child-in-table-expected.txt:
* platform/qt/fast/table/table-row-style-not-updated-expected.txt: Added.
* platform/qt/fast/table/table-row-style-not-updated-with-after-content-expected.txt: Added.
* platform/qt/fast/table/table-row-style-not-updated-with-before-content-expected.txt: Added.
* platform/qt/fast/table/table-style-not-updated-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Rebaselines for r94541.
inferno@chromium.org [Tue, 6 Sep 2011 02:13:09 +0000 (02:13 +0000)]
Unreviewed. Rebaselines for r94541.

* platform/qt/fast/multicol/span/anonymous-split-block-crash-expected.txt:
* platform/qt/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agowindow.HTMLSpanElement does not exist
abarth@webkit.org [Tue, 6 Sep 2011 01:52:46 +0000 (01:52 +0000)]
window.HTMLSpanElement does not exist
https://bugs.webkit.org/show_bug.cgi?id=67571

Reviewed by Sam Weinig.

Source/WebCore:

We have these objects for most other elements and HTMLSpanElement
exists in Firefox and in the HTML5 spec.  This patch adds it.

Test: fast/dom/wrapper-classes.html

* CMakeLists.txt:
* CodeGenerators.pri:
* DerivedSources.cpp:
* DerivedSources.make:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* html/HTMLElementsAllInOne.cpp:
* html/HTMLSpanElement.cpp: Added.
(WebCore::HTMLSpanElement::HTMLSpanElement):
(WebCore::HTMLSpanElement::create):
* html/HTMLSpanElement.h: Added.
* html/HTMLSpanElement.idl: Added.
* html/HTMLTagNames.in:
* page/DOMWindow.idl:

LayoutTests:

Update tests to account for HTMLSpanElement existing.  I also took the
liberty of changing fast/tokenizer/external-script-document-write.html
into a text test and cleaning up the platform-specific results.

* editing/selection/extend-after-mouse-selection-expected.txt:
* fast/dom/gc-6-expected.txt:
* fast/dom/gc-7-expected.txt:
* fast/dom/wrapper-classes-expected.txt:
* fast/dom/wrapper-classes.html:
* fast/events/mouseclick-target-and-positioning-expected.txt:
* fast/js/toString-and-valueOf-override-expected.txt:
* fast/tokenizer/external-script-document-write-expected.txt: Added.
* fast/tokenizer/resources/external-script-document-write.js:
* platform/chromium-linux/fast/tokenizer/external-script-document-write-expected.png: Removed.
* platform/chromium-win/fast/tokenizer/external-script-document-write-expected.png: Removed.
* platform/chromium-win/fast/tokenizer/external-script-document-write-expected.txt: Removed.
* platform/gtk/fast/tokenizer/external-script-document-write-expected.png: Removed.
* platform/gtk/fast/tokenizer/external-script-document-write-expected.txt: Removed.
* platform/mac-leopard/fast/tokenizer/external-script-document-write-expected.png: Removed.
* platform/mac/fast/tokenizer/external-script-document-write-expected.png: Removed.
* platform/mac/fast/tokenizer/external-script-document-write-expected.txt: Removed.
* platform/qt/fast/tokenizer/external-script-document-write-expected.png: Removed.
* platform/qt/fast/tokenizer/external-script-document-write-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoStyle not propagated to anonymous boxes and anonymous
inferno@chromium.org [Tue, 6 Sep 2011 01:45:39 +0000 (01:45 +0000)]
Style not propagated to anonymous boxes and anonymous
inline-blocks.
https://bugs.webkit.org/show_bug.cgi?id=67364

Reviewed by James Robinson.

Source/WebCore:

Tests: fast/ruby/ruby-block-style-not-updated-with-before-after-content.html
       fast/ruby/ruby-block-style-not-updated.html
       fast/ruby/ruby-inline-style-not-updated-with-before-after-content.html
       fast/ruby/ruby-inline-style-not-updated.html
       fast/table/table-row-style-not-updated-with-after-content.html
       fast/table/table-row-style-not-updated-with-before-content.html
       fast/table/table-row-style-not-updated.html
       fast/table/table-style-not-updated.html

* rendering/RenderObject.cpp:
(WebCore::RenderObject::propagateStyleToAnonymousChildren):
* rendering/RenderObject.h:
(WebCore::RenderObject::isBeforeAfterContent):
* rendering/RenderRuby.cpp:
(WebCore::RenderRubyAsInline::styleDidChange):
(WebCore::RenderRubyAsBlock::styleDidChange):
* rendering/RenderRuby.h:
* rendering/RenderTable.cpp:
(WebCore::RenderTable::styleDidChange):
* rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::styleDidChange):
(WebCore::RenderTableRow::addChild):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::styleDidChange):
(WebCore::RenderTableSection::addChild):
* rendering/RenderTableSection.h:

LayoutTests:

None of the different color boxes should overlap. If they overlap, test fails.

* fast/ruby/ruby-block-style-not-updated-expected.png: Added.
* fast/ruby/ruby-block-style-not-updated-expected.txt: Added.
* fast/ruby/ruby-block-style-not-updated-with-before-after-content-expected.png: Added.
* fast/ruby/ruby-block-style-not-updated-with-before-after-content-expected.txt: Added.
* fast/ruby/ruby-block-style-not-updated-with-before-after-content.html: Added.
* fast/ruby/ruby-block-style-not-updated.html: Added.
* fast/ruby/ruby-inline-style-not-updated-expected.png: Added.
* fast/ruby/ruby-inline-style-not-updated-expected.txt: Added.
* fast/ruby/ruby-inline-style-not-updated-with-before-after-content-expected.png: Added.
* fast/ruby/ruby-inline-style-not-updated-with-before-after-content-expected.txt: Added.
* fast/ruby/ruby-inline-style-not-updated-with-before-after-content.html: Added.
* fast/ruby/ruby-inline-style-not-updated.html: Added.
* fast/table/table-row-style-not-updated-expected.png: Added.
* fast/table/table-row-style-not-updated-expected.txt: Added.
* fast/table/table-row-style-not-updated-with-after-content-expected.png: Added.
* fast/table/table-row-style-not-updated-with-after-content-expected.txt: Added.
* fast/table/table-row-style-not-updated-with-after-content.html: Added.
* fast/table/table-row-style-not-updated-with-before-content-expected.png: Added.
* fast/table/table-row-style-not-updated-with-before-content-expected.txt: Added.
* fast/table/table-row-style-not-updated-with-before-content.html: Added.
* fast/table/table-row-style-not-updated.html: Added.
* fast/table/table-style-not-updated-expected.png: Added.
* fast/table/table-style-not-updated-expected.txt: Added.
* fast/table/table-style-not-updated.html: Added.
* platform/mac/fast/css-generated-content/table-before-after-child-add-expected.txt:
* platform/mac/fast/css-generated-content/table-cell-before-after-child-add-expected.txt:
* platform/mac/fast/css-generated-content/table-row-before-after-child-add-expected.txt:
* platform/mac/fast/css-generated-content/table-table-before-after-child-add-expected.txt:
* platform/mac/fast/table/table-after-child-in-table-expected.txt:
* platform/mac/fast/table/table-before-child-in-table-expected.txt:
* platform/mac/fast/table/table-cell-after-child-in-table-expected.txt:
* platform/mac/fast/table/table-cell-before-child-in-table-expected.txt:
* platform/mac/fast/table/table-row-after-child-in-table-expected.txt:
* platform/mac/fast/table/table-row-before-child-in-table-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCrash in RenderObjectChildList::destroyLeftOverChildren()
inferno@chromium.org [Tue, 6 Sep 2011 01:16:57 +0000 (01:16 +0000)]
Crash in RenderObjectChildList::destroyLeftOverChildren()
https://bugs.webkit.org/show_bug.cgi?id=64753

Reviewed by James Robinson.

Source/WebCore:

If any of the ancestors between column span element and containing
column's block is a continuation, then don't attempt to render the
column span by splitting the block into continuations.

Test: fast/multicol/column-span-parent-continuation-crash.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::columnsBlockForSpanningElement):

LayoutTests:

anonymous-split-block-crash rendering was already wrong. The fix prevents
the tree to go bad and hence does not do the column-span rendering. same issue
with clone-anonymous-block-non-inline-child-crash test.

* fast/multicol/column-span-parent-continuation-crash-expected.txt: Added.
* fast/multicol/column-span-parent-continuation-crash.html: Added.
* platform/mac/fast/multicol/span/anonymous-split-block-crash-expected.png:
* platform/mac/fast/multicol/span/anonymous-split-block-crash-expected.txt:
* platform/mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png:
* platform/mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd a tab to garden-o-matic for viewing expected failures
abarth@webkit.org [Mon, 5 Sep 2011 23:18:00 +0000 (23:18 +0000)]
Add a tab to garden-o-matic for viewing expected failures
https://bugs.webkit.org/show_bug.cgi?id=67619

Reviewed by Dimitri Glazkov.

This patch adds a basic tab to garden-o-matic that shows all the tests
failing on the bots, including the expected failures.  This patch
mostly involves refactoring existing classes to allow new subclasses.

This view is useful for when gardeners mark tests as expected to fail
and then rebaseline them later.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/garden-o-matic.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/summary-mock.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/notifications_unittests.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix global variable leak in garden-o-matic
abarth@webkit.org [Mon, 5 Sep 2011 22:58:10 +0000 (22:58 +0000)]
Fix global variable leak in garden-o-matic
https://bugs.webkit.org/show_bug.cgi?id=67617

Reviewed by Dimitri Glazkov.

Caught by running the unit tests with noglobals turned on.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r94537.
commit-queue@webkit.org [Mon, 5 Sep 2011 21:07:50 +0000 (21:07 +0000)]
Unreviewed, rolling out r94537.
http://trac.webkit.org/changeset/94537
https://bugs.webkit.org/show_bug.cgi?id=67618

Does not compile on Chromium Mac (Requested by abarth_ on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-05

* platform/image-encoders/skia/JPEGImageEncoder.cpp:
(WebCore::preMultipliedBGRAtoRGB):
(WebCore::RGBAtoRGB):
(WebCore::encodePixels):
(WebCore::JPEGImageEncoder::encode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[chromium skia] JPEGImageEncoder: hoist contants out of the encoding loop
noel.gordon@gmail.com [Mon, 5 Sep 2011 19:56:03 +0000 (19:56 +0000)]
[chromium skia] JPEGImageEncoder: hoist contants out of the encoding loop
https://bugs.webkit.org/show_bug.cgi?id=67589

Reviewed by Adam Barth.

Change the row converter function signatures to be the same.  Call them via a function
pointer during the encoding loop.  Minor webkit stlye cleanup, remove unused include.

No new tests.  Covered by existing canvas 2d and 3d tests.
canvas/philip/tests/toDataURL.jpeg.alpha.html
fast/canvas/webgl/premultiplyalpha-test.html

* platform/image-encoders/skia/JPEGImageEncoder.cpp:  Remove SkUnPreMultiply.h (not used).
(WebCore::preMultipliedBGRAtoRGB):  Use unsigned char* instead of void* for pixels.
(WebCore::RGBAtoRGB):  pixels & pixelCount to match the preMultipliedBGRAtoRGB() signature.
(WebCore::encodePixels):  Move contants out of the encoding loop: use a function pointer to
call preMultipliedBGRAtoRGB or RGBAtoRGB (now they have identical signatures) during the
image row encoding loop.  Add/use pixelRowStride constant.
(WebCore::JPEGImageEncoder::encode):  webkit style: no need to split lines.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTake pageScaleFactor into account for MouseRelatedEvents.
jknotten@chromium.org [Mon, 5 Sep 2011 16:55:52 +0000 (16:55 +0000)]
Take pageScaleFactor into account for MouseRelatedEvents.
https://bugs.webkit.org/show_bug.cgi?id=67592

Source/WebCore:

Reviewed by Dimitri Glazkov.

Test: fast/events/page-scaled-mouse-click.html

* dom/MouseRelatedEvent.cpp:
(WebCore::MouseRelatedEvent::MouseRelatedEvent):

LayoutTests:

Mouse-related events currently take account of the zoom factor, but they
also need to take account of the page scale factor so that pageX and pageY
event coordinates are properly determined.

Reviewed by Dimitri Glazkov.

* fast/events/page-scaled-mouse-click-expected.txt: Added.
* fast/events/page-scaled-mouse-click.html: Added.
* fast/events/script-tests/page-scaled-mouse-click.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoD'oh! Missed the name of the test in the previous gardening.
kbalazs@webkit.org [Mon, 5 Sep 2011 16:51:29 +0000 (16:51 +0000)]
D'oh! Missed the name of the test in the previous gardening.
Unreviewed regardening.

* platform/qt-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt][WK2] fast/inline/absolute-positioned-inline-in-centred-block.html is flaky
kbalazs@webkit.org [Mon, 5 Sep 2011 16:47:30 +0000 (16:47 +0000)]
[Qt][WK2] fast/inline/absolute-positioned-inline-in-centred-block.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=67607

Unreviewed gardening.

* platform/qt-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Unreviewed gardening - move expectation to the correct place.
kbalazs@webkit.org [Mon, 5 Sep 2011 15:42:44 +0000 (15:42 +0000)]
[Qt] Unreviewed gardening - move expectation to the correct place.

* platform/qt/fast/borders/border-image-repeat-expected.txt: Renamed from LayoutTests/platform/qt/border-image-repeat-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: rename RawSourceCode.reload to contentEdited.
podivilov@chromium.org [Mon, 5 Sep 2011 15:35:05 +0000 (15:35 +0000)]
Web Inspector: rename RawSourceCode.reload to contentEdited.
https://bugs.webkit.org/show_bug.cgi?id=67504

Make RawSourceCode.reload private and remove RawSourceCode.content getter and setter
(RawSourceCode isn't supposed to have any content).

Reviewed by Yury Semikhatsky.

* inspector/front-end/DebuggerPresentationModel.js:
(WebInspector.DebuggerPresentationModel.prototype.setScriptSource.didEditScriptSource):
(WebInspector.DebuggerPresentationModel.prototype.setScriptSource):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype.canSetContent):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype.setContent):
(WebInspector.DebuggerPresentationModelResourceBinding.prototype._setContentWithInitialContent):
* inspector/front-end/SourceFile.js:
(WebInspector.RawSourceCode):
(WebInspector.RawSourceCode.prototype.contentEdited):
(WebInspector.RawSourceCode.prototype.forceLoadContent):
(WebInspector.RawSourceCode.prototype._reload):
(WebInspector.RawSourceCode.prototype._didRequestContent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix the regression of bug 65333 introduced by 60170.
leandrogracia@chromium.org [Mon, 5 Sep 2011 15:01:59 +0000 (15:01 +0000)]
Fix the regression of bug 65333 introduced by 60170.
This caused the speech input bubble to appear in the wrong side for RTL text inputs.
https://bugs.webkit.org/show_bug.cgi?id=67597

Reviewed by Tony Gentilcore.

No new tests. Fixing regression.

* html/shadow/TextControlInnerElements.cpp:
(WebCore::InputFieldSpeechButtonElement::startSpeechInput):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: cleanup scripts-panel.html test.
podivilov@chromium.org [Mon, 5 Sep 2011 14:46:03 +0000 (14:46 +0000)]
Web Inspector: cleanup scripts-panel.html test.
https://bugs.webkit.org/show_bug.cgi?id=67497

ScriptsPanel test should not depend on presentation model internals.

Reviewed by Yury Semikhatsky.

* inspector/debugger/scripts-panel.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWeb Inspector: F5 results in a Web Inspector frontend reload on non-Macs
apavlov@chromium.org [Mon, 5 Sep 2011 14:40:00 +0000 (14:40 +0000)]
Web Inspector: F5 results in a Web Inspector frontend reload on non-Macs
https://bugs.webkit.org/show_bug.cgi?id=67602

Reviewed by Yury Semikhatsky.

* inspector/front-end/inspector.js:
(WebInspector.documentKeyDown):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Unreviewed gardening.
kbalazs@webkit.org [Mon, 5 Sep 2011 14:20:10 +0000 (14:20 +0000)]
[Qt] Unreviewed gardening.

Patch by Zsolt Fehér <feherzs@inf.u-szeged.hu> on 2011-09-05

* platform/qt/border-image-repeat-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r94525.
loislo@chromium.org [Mon, 5 Sep 2011 12:57:50 +0000 (12:57 +0000)]
Unreviewed, rolling out r94525.
http://trac.webkit.org/changeset/94525
https://bugs.webkit.org/show_bug.cgi?id=67599

WinCE compilation failed. (Requested by loislo on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-05

* platform/text/TextBoundaries.cpp:
* platform/text/TextBreakIteratorICU.cpp:
* platform/text/qt/TextBoundariesQt.cpp:
* platform/text/qt/TextBreakIteratorQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-09-05 Balazs Kelemen <kbalazs@webkit.org>
kbalazs@webkit.org [Mon, 5 Sep 2011 12:55:38 +0000 (12:55 +0000)]
2011-09-05  Balazs Kelemen  <kbalazs@webkit.org>

        [Qt] Update expectations.

        Unreviewed gardening.

        * platform/qt/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png: Added.
        * platform/qt/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.txt: Added.
        * platform/qt/fast/css/bug4860-absolute-inline-child-inherits-alignment-expected.png: Added.
        * platform/qt/fast/css/bug4860-absolute-inline-child-inherits-alignment-expected.txt: Added.
        * platform/qt/fast/dom/Window/window-properties-expected.png:
        * platform/qt/fast/dom/Window/window-properties-expected.txt:
        * platform/qt/fast/dom/Window/window-property-descriptors-expected.png:
        * platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
        * platform/qt/fast/inline/absolute-positioned-inline-in-centred-block-expected.png: Added.
        * platform/qt/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Added.
        * platform/qt/fast/js/global-constructors-expected.png:
        * platform/qt/fast/js/global-constructors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Compiling using system ICU uses QTextBreakIterator in some cases.
commit-queue@webkit.org [Mon, 5 Sep 2011 12:08:12 +0000 (12:08 +0000)]
[Qt] Compiling using system ICU uses QTextBreakIterator in some cases.
https://bugs.webkit.org/show_bug.cgi?id=67391

Patch by Alexander Færøy <alexander.faeroy@nokia.com> on 2011-09-05
Reviewed by Kenneth Rohde Christiansen.

* platform/text/TextBoundaries.cpp:
* platform/text/TextBreakIteratorICU.cpp:
* platform/text/qt/TextBoundariesQt.cpp:
* platform/text/qt/TextBreakIteratorQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt][WK2] Add pixel test support
kbalazs@webkit.org [Mon, 5 Sep 2011 10:53:32 +0000 (10:53 +0000)]
[Qt][WK2] Add pixel test support
https://bugs.webkit.org/show_bug.cgi?id=66283

Reviewed by Andreas Kling.

Source/WebKit2:

* Shared/API/c/qt/WKImageQt.cpp: Added.
(WKImageCreateQImage):  C style (private) API to get the contents of the backing
store as an image.
* Shared/API/c/qt/WKImageQt.h: Added.
* Shared/qt/ShareableBitmapQt.cpp:
(WebKit::ShareableBitmap::createImage): Typo. Remove useless ifdef.
* WebKit2API.pri:

Tools:

Implemented pixel result generation by reusing the logic
that we have in DumpRenderTree.
* WebKitTestRunner/qt/TestInvocationQt.cpp:
(WTR::dumpImage):
(WTR::TestInvocation::dumpPixelsAndCompareWithExpected):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Update expected result after r94425
zoltan@webkit.org [Mon, 5 Sep 2011 10:50:51 +0000 (10:50 +0000)]
[Qt] Update expected result after r94425
https://bugs.webkit.org/show_bug.cgi?id=66467

Patch by Kristof Kosztyo <kkristof@inf.u-szeged.hu> on 2011-09-05

* platform/qt/fast/dom/HTMLInputElement/input-image-alt-text-expected.png:
* platform/qt/fast/dom/HTMLInputElement/input-image-alt-text-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r94445 and r94448.
commit-queue@webkit.org [Mon, 5 Sep 2011 10:43:34 +0000 (10:43 +0000)]
Unreviewed, rolling out r94445 and r94448.
http://trac.webkit.org/changeset/94445
http://trac.webkit.org/changeset/94448
https://bugs.webkit.org/show_bug.cgi?id=67595

It broke everything (Requested by ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-09-05

* JavaScriptCore.exp:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:
* heap/Heap.cpp:
(JSC::Heap::collect):
* heap/Heap.h:
* heap/NewSpace.cpp:
(JSC::NewSpace::NewSpace):
* heap/NewSpace.h:
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* runtime/JSObject.cpp:
(JSC::JSObject::allocatePropertyStorage):
* runtime/JSObject.h:
(JSC::JSObject::~JSObject):
(JSC::JSObject::putDirectInternal):
(JSC::JSObject::putDirectWithoutTransition):
(JSC::JSObject::putDirectFunctionWithoutTransition):
(JSC::JSObject::transitionTo):
(JSC::JSObject::visitChildrenDirect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-09-05 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Mon, 5 Sep 2011 10:22:11 +0000 (10:22 +0000)]
2011-09-05  Ilya Tikhonovsky  <loislo@chromium.org>

        Unreviewed update expected image for chromium MAC.
        The test was introduced at r94492.

        * platform/chromium-cg-mac-leopard/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
        * platform/chromium-cg-mac/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed build fix for r94452.
paroga@webkit.org [Mon, 5 Sep 2011 09:41:26 +0000 (09:41 +0000)]
Unreviewed build fix for r94452.

Add config.h as the first header to the cc files as required by the coding style.
Reuse macros from Assertions.h instead of adding addional #ifdefs.

* wtf/dtoa/bignum-dtoa.cc:
* wtf/dtoa/bignum.cc:
* wtf/dtoa/cached-powers.cc:
* wtf/dtoa/diy-fp.cc:
* wtf/dtoa/double-conversion.cc:
* wtf/dtoa/fast-dtoa.cc:
* wtf/dtoa/fixed-dtoa.cc:
* wtf/dtoa/strtod.cc:
* wtf/dtoa/utils.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt][WK2] Fix the build
abecsi@webkit.org [Mon, 5 Sep 2011 08:49:57 +0000 (08:49 +0000)]
[Qt][WK2] Fix the build

Rubber-stamped by Csaba Osztrogonác.

Source/JavaScriptCore:

* wtf/dtoa/double-conversion.cc: Remove dead variable in file added in r94452.
The variable fractional_part is only set but never used.

Source/WebKit2:

* DerivedSources.pro: Add missing PluginProcessConnection.messages.in after r94456.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-09-05 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Mon, 5 Sep 2011 08:36:25 +0000 (08:36 +0000)]
2011-09-05  Ilya Tikhonovsky  <loislo@chromium.org>

        Unreviewed update expected image for chromium Linux.
        The test was introduced at r94492.

        * platform/chromium-linux/fast/inline/absolute-positioned-inline-in-centred-block-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-09-05 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Mon, 5 Sep 2011 07:52:17 +0000 (07:52 +0000)]
2011-09-05  Ilya Tikhonovsky  <loislo@chromium.org>

        Unreviewed rebaseline for chromium: fast/repaint/block-layout-inline-children-float-positioned.html

        * platform/chromium-cg-mac-leopard/fast/repaint/block-layout-inline-children-float-positioned-expected.png:
        * platform/chromium-cg-mac/fast/repaint/block-layout-inline-children-float-positioned-expected.png:
        * platform/chromium-linux/fast/repaint/block-layout-inline-children-float-positioned-expected.txt: Removed.
        * platform/chromium-win/fast/repaint/block-layout-inline-children-float-positioned-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoLogic from HTMLElement::deprecatedCreateContextualFragment moved into
commit-queue@webkit.org [Mon, 5 Sep 2011 07:46:55 +0000 (07:46 +0000)]
Logic from HTMLElement::deprecatedCreateContextualFragment moved into
Range::createContextualFragment function.
https://bugs.webkit.org/show_bug.cgi?id=67056

Patch by Kaustubh Atrawalkar <kaustubh@motorola.com> on 2011-09-05
Reviewed by Ryosuke Niwa.

Code Refactoring for deprecatedCreateContextualFragment.

Source/WebCore:

No new tests. Code Re-factoring.

* dom/Element.cpp:
* dom/Element.h:
* dom/Range.cpp:
(WebCore::insertIntoFragment):
(WebCore::Range::createDocumentFragmentForElement):
(WebCore::Range::createContextualFragment):
* dom/Range.h:
* editing/markup.cpp:
(WebCore::createFragmentFromMarkup):
* html/HTMLElement.cpp:
* html/HTMLElement.h:

Source/WebKit/qt:

* Api/qwebelement.cpp:
(QWebElement::appendInside):
(QWebElement::prependInside):
(QWebElement::prependOutside):
(QWebElement::appendOutside):
(QWebElement::encloseContentsWith):
(QWebElement::encloseWith):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-09-05 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Mon, 5 Sep 2011 07:38:20 +0000 (07:38 +0000)]
2011-09-05  Ilya Tikhonovsky  <loislo@chromium.org>

        Unreviewed rebaseline for fast/inline/absolute-positioned-inline-in-centred-block

        * platform/chromium-cg-mac-leopard/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Added.
        * platform/chromium-cg-mac/fast/inline/absolute-positioned-inline-in-centred-block-expected.png: Added.
        * platform/chromium-cg-mac/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Added.
        * platform/chromium-linux-x86/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Added.
        * platform/chromium-linux/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Added.
        * platform/chromium-win-vista/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Added.
        * platform/chromium-win-xp/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Added.
        * platform/chromium-win/fast/inline/absolute-positioned-inline-in-centred-block-expected.png: Added.
        * platform/chromium-win/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoREGRESSION (r94452): 20 http/tests tests failing on Qt Linux Release
commit-queue@webkit.org [Mon, 5 Sep 2011 06:48:18 +0000 (06:48 +0000)]
REGRESSION (r94452): 20 http/tests tests failing on Qt Linux Release
https://bugs.webkit.org/show_bug.cgi?id=67562

Patch by Mark Hahnenberg <mhahnenberg@apple.com> on 2011-09-04
Reviewed by Darin Adler.

Fixing the build (again which was broken by the dtoa patch.  Needed
to make sure WTF::double_conversion::initialize() is called for Qt
as well as adding a check for WinCE in dtoa/utils.h

* runtime/InitializeThreading.cpp:
(JSC::initializeThreadingOnce):
* wtf/dtoa/cached-powers.cc:
* wtf/dtoa/utils.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed, rolling out r94510.
koz@chromium.org [Mon, 5 Sep 2011 06:43:32 +0000 (06:43 +0000)]
Unreviewed, rolling out r94510.
http://trac.webkit.org/changeset/94510
https://bugs.webkit.org/show_bug.cgi?id=66531

Causes layout test crashes.

Source/WebCore:

* dom/Document.cpp:
(WebCore::Document::webkitWillEnterFullScreenForElement):
(WebCore::Document::webkitDidExitFullScreenForElement):
* dom/NodeRenderingContext.cpp:
(WebCore::wrapWithRenderFullScreen):
(WebCore::NodeRendererFactory::createRendererIfNeeded):
* rendering/RenderFullScreen.cpp:
(RenderFullScreen::createFullScreenStyle):
* rendering/RenderFullScreen.h:

LayoutTests:

* plugins/fullscreen-plugins-dont-reload-expected.txt: Removed.
* plugins/fullscreen-plugins-dont-reload.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Compile fix for r94511.
inferno@chromium.org [Mon, 5 Sep 2011 05:59:03 +0000 (05:59 +0000)]
Unreviewed. Compile fix for r94511.

* dom/Range.cpp:
(WebCore::Range::processContents):
(WebCore::Range::processAncestorsAndTheirSiblings):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCrash in Range::processAncestorsAndTheirSiblings.
inferno@chromium.org [Mon, 5 Sep 2011 05:22:36 +0000 (05:22 +0000)]
Crash in Range::processAncestorsAndTheirSiblings.
https://bugs.webkit.org/show_bug.cgi?id=67556

Reviewed by Ryosuke Niwa.

Source/WebCore:

Create a temporary RefPtr Node vector to keep all the ancestor's
childs so that we don't access removed child nodes.

Test: fast/dom/Range/range-delete-contents-event-fire-crash.html

* dom/Range.cpp:
(WebCore::Range::processContents):
(WebCore::Range::processAncestorsAndTheirSiblings):

LayoutTests:

Tests that we do not crash when removing contents of
a range from the document.

* fast/dom/Range/range-delete-contents-event-fire-crash-expected.txt: Added.
* fast/dom/Range/range-delete-contents-event-fire-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDon't detach elements from the render tree when entering fullscreen mode
commit-queue@webkit.org [Mon, 5 Sep 2011 04:46:22 +0000 (04:46 +0000)]
Don't detach elements from the render tree when entering fullscreen mode
https://bugs.webkit.org/show_bug.cgi?id=66531

Source/WebCore:

This prevents plugin instances from being destroyed and reinstantiated
when entering fullscreen mode.

Patch by Jeremy Apthorp <jeremya@google.com> on 2011-09-04
Reviewed by Darin Fisher.

Test: plugins/fullscreen-plugins-dont-reload.html

* dom/Document.cpp:
(WebCore::Document::webkitWillEnterFullScreenForElement):
(WebCore::Document::webkitDidExitFullScreenForElement):
* dom/NodeRenderingContext.cpp:
(WebCore::NodeRendererFactory::createRendererIfNeeded):
* rendering/RenderFullScreen.cpp:
(createFullScreenStyle):
(RenderFullScreen::wrapRenderer):
(RenderFullScreen::unwrapRenderer):
* rendering/RenderFullScreen.h:

LayoutTests:

Test that the plugin is not reloaded when entering fullscreen.

Patch by Jeremy Apthorp <jeremya@google.com> on 2011-09-04
Reviewed by Darin Fisher.

* plugins/fullscreen-plugins-dont-reload-expected.txt: Added.
* plugins/fullscreen-plugins-dont-reload.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[EFL] Rename ewk_view_(single|tiled).c to ewk_view_(single|tiled).cpp
ryuan.choi@samsung.com [Mon, 5 Sep 2011 04:18:04 +0000 (04:18 +0000)]
[EFL] Rename ewk_view_(single|tiled).c to ewk_view_(single|tiled).cpp
https://bugs.webkit.org/show_bug.cgi?id=66542

Use a C++ compiler for these files, so that they can include the C++-using
ewk_private.h.

Reviewed by Daniel Bates.

* CMakeListsEfl.txt:
* ewk/ewk_view_single.cpp: Renamed from Source/WebKit/efl/ewk/ewk_view_single.c.
(_ewk_view_single_on_del):
(_ewk_view_single_smart_add):
(_ewk_view_single_smart_backing_store_add):
(_ewk_view_single_smart_resize):
(_ewk_view_4b_move_region_up):
(_ewk_view_4b_move_region_down):
(_ewk_view_4b_move_line_left):
(_ewk_view_4b_move_line_right):
(_ewk_view_4b_move_region_left):
(_ewk_view_4b_move_region_right):
(_ewk_view_4b_move_region):
(_ewk_view_single_scroll_process_single):
(_ewk_view_single_smart_scrolls_process):
(_ewk_view_single_smart_repaints_process):
(_ewk_view_single_smart_zoom_weak_set):
(_ewk_view_single_smart_zoom_weak_smooth_scale_set):
(_ewk_view_single_smart_bg_color_set):
(ewk_view_single_smart_set):
(_ewk_view_single_smart_class_new):
(ewk_view_single_add):
* ewk/ewk_view_tiled.cpp: Renamed from Source/WebKit/efl/ewk/ewk_view_tiled.c.
(_ewk_view_tiled_render_cb):
(_ewk_view_tiled_updates_process_pre):
(_ewk_view_tiled_smart_backing_store_add):
(_ewk_view_tiled_contents_size_changed_cb):
(_ewk_view_tiled_smart_add):
(_ewk_view_tiled_smart_scrolls_process):
(_ewk_view_tiled_smart_repaints_process):
(_ewk_view_tiled_smart_contents_resize):
(_ewk_view_tiled_smart_zoom_set):
(_ewk_view_tiled_smart_zoom_weak_set):
(_ewk_view_tiled_smart_zoom_weak_smooth_scale_set):
(_ewk_view_tiled_smart_flush):
(_ewk_view_tiled_smart_pre_render_region):
(_ewk_view_tiled_smart_pre_render_relative_radius):
(_ewk_view_tiled_smart_pre_render_cancel):
(_ewk_view_tiled_smart_disable_render):
(_ewk_view_tiled_smart_enable_render):
(ewk_view_tiled_smart_set):
(_ewk_view_tiled_smart_class_new):
(ewk_view_tiled_add):
(ewk_view_tiled_unused_cache_get):
(ewk_view_tiled_unused_cache_set):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/10071256> Retain retired custom fonts until the next style recalc
mitz@apple.com [Mon, 5 Sep 2011 00:01:40 +0000 (00:01 +0000)]
<rdar://problem/10071256> Retain retired custom fonts until the next style recalc

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/css/font-face-used-after-retired.html

During style recalc, existing renderers may reference their old style, including font data.
Allow them to do so safely by keeping retired custom font data around until after style recalc.

* css/CSSFontFace.cpp:
(WebCore::CSSFontFace::retireCustomFont): Added. Calls through to CSSFontSelector, if the font
face is still part of any segmented font face. Otherwise, deletes the custom font data.
* css/CSSFontFace.h:
* css/CSSFontFaceSource.cpp:
(WebCore::CSSFontFaceSource::pruneTable): Changed to call retireCustomFont() instead of deleting
retired font data.
* css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::retireCustomFont): Added. Calls through to the Document, if this is
still the active font selector for a document. Otherwise, deletes the custom font data.
* css/CSSFontSelector.h:
* css/CSSSegmentedFontFace.cpp:
(WebCore::CSSSegmentedFontFace::pruneTable): Changed to call retireCustomFont() instead of
deleting retired font data.
* dom/Document.cpp:
(WebCore::Document::~Document): Added a call to deleteRetiredCustomFonts(), in case the Document
is destroyed before getting a chance to recalc style after custom fonts have been retired.
(WebCore::Document::recalcStyle): Added a call to deleteRetiredCustomFonts() after style recalc.
(WebCore::Document::deleteRetiredCustomFonts): Added. Deletes all previously-retired custom font
data.
* dom/Document.h:
(WebCore::Document::retireCustomFont): Added.

LayoutTests:

* fast/css/font-face-used-after-retired-expected.txt: Added.
* fast/css/font-face-used-after-retired.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Add mutliple to WebPopupMenuInfo for Android
abarth@webkit.org [Sun, 4 Sep 2011 21:24:22 +0000 (21:24 +0000)]
[Chromium] Add mutliple to WebPopupMenuInfo for Android
https://bugs.webkit.org/show_bug.cgi?id=67576

Reviewed by Darin Fisher.

This flag requests that the embedder allow multiple selection for the
popup menu.  (See also https://bugs.webkit.org/show_bug.cgi?id=67574.)

* public/WebPopupMenuInfo.h:
* src/ExternalPopupMenu.cpp:
(WebKit::ExternalPopupMenu::getPopupMenuInfo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoForgot to check in new results for fast/events/event-creation.html
weinig@apple.com [Sun, 4 Sep 2011 21:19:40 +0000 (21:19 +0000)]
Forgot to check in new results for fast/events/event-creation.html

* fast/events/event-creation-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDocument.createEvent should support all the interfaces of Event we got
weinig@apple.com [Sun, 4 Sep 2011 21:04:14 +0000 (21:04 +0000)]
Document.createEvent should support all the interfaces of Event we got
https://bugs.webkit.org/show_bug.cgi?id=67568

Reviewed by Anders Carlsson.

Source/WebCore:

Updated fast/events/event-creation.html

* dom/BeforeLoadEvent.h:
(WebCore::BeforeLoadEvent::create):
(WebCore::BeforeLoadEvent::BeforeLoadEvent):
Added empty create.

* dom/Document.cpp:
(WebCore::Document::createEvent):
Add missing interfaces.

* dom/HashChangeEvent.h:
(WebCore::HashChangeEvent::create):
(WebCore::HashChangeEvent::HashChangeEvent):
Added empty create.

* page/SpeechInputEvent.cpp:
(WebCore::SpeechInputEvent::create):
(WebCore::SpeechInputEvent::SpeechInputEvent):
(WebCore::SpeechInputEvent::~SpeechInputEvent):
* page/SpeechInputEvent.h:
Added empty create.

LayoutTests:

* fast/events/event-creation.html:
Converted to shouldBe style test, changed prototype check to us instanceof and constructor check,
added enumeration based catchall.

* fast/events/event-instanceof-expected.txt: Removed.
* fast/events/event-instanceof.html: Removed.
* fast/events/script-tests/event-instanceof.js: Removed.
Moved contents to fast/events/event-creation.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Chromium] Add memory threshold values to WebKitPlatformSupport.h
abarth@webkit.org [Sun, 4 Sep 2011 18:10:26 +0000 (18:10 +0000)]
[Chromium] Add memory threshold values to WebKitPlatformSupport.h
https://bugs.webkit.org/show_bug.cgi?id=67575

Reviewed by Darin Fisher.

Source/WebCore:

Grab these memory thresholds from PlatformSupport rather than hard-coding them.

* bindings/v8/V8GCController.cpp:
(WebCore::V8GCController::checkMemoryUsage):
* platform/chromium/PlatformSupport.h:
* platform/qt/PlatformSupport.h:
(WebCore::PlatformSupport::lowMemoryUsageMB):
(WebCore::PlatformSupport::highMemoryUsageMB):
(WebCore::PlatformSupport::highUsageDeltaMB):

Source/WebKit/chromium:

Instead of hard-coding these values, we now grab them from
WebKitPlatformSupport because Android wishes to configure them on a
per-device basis.

One could view grabing these values from PlatformSupport as a bit of a
layering violation (because they feel like policy), but another view is
that the alternative implementation is to query the OS for various
memory parameters.  In either case, getting these values via
PlatformSupport is much easier and consistent with the other memory
related queries in PlatformSupport already.

* public/WebKitPlatformSupport.h:
(WebKit::WebKitPlatformSupport::lowMemoryUsageMB):
(WebKit::WebKitPlatformSupport::highMemoryUsageMB):
(WebKit::WebKitPlatformSupport::highUsageDeltaMB):
* src/PlatformSupport.cpp:
(WebCore::PlatformSupport::lowMemoryUsageMB):
(WebCore::PlatformSupport::highMemoryUsageMB):
(WebCore::PlatformSupport::highUsageDeltaMB):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-09-04 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Sun, 4 Sep 2011 18:04:45 +0000 (18:04 +0000)]
2011-09-04  Ilya Tikhonovsky  <loislo@chromium.org>

        Unreviewed fix for chromium expectations.
        The expectations for http/tests/security/xssAuditor/dom-write-innerHTML.html
        were in conflict. The first was for LINUX the second was for DEBUG. I just added RELEASE flag for LINUX one.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[wx] Unreviewed build fix. Add new / moved files missing from last commit.
kevino@webkit.org [Sun, 4 Sep 2011 17:51:35 +0000 (17:51 +0000)]
[wx] Unreviewed build fix. Add new / moved files missing from last commit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[wx] Enable wxWebKit to run using the wxGC Cairo backend on platforms other than...
kevino@webkit.org [Sun, 4 Sep 2011 16:49:10 +0000 (16:49 +0000)]
[wx] Enable wxWebKit to run using the wxGC Cairo backend on platforms other than GTK.
https://bugs.webkit.org/show_bug.cgi?id=67577

Reviewed by Kevin Ollivier.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoThunkGenerators does not convert positive double zero into integer zero
fpizlo@apple.com [Sun, 4 Sep 2011 05:43:47 +0000 (05:43 +0000)]
ThunkGenerators does not convert positive double zero into integer zero
https://bugs.webkit.org/show_bug.cgi?id=67553

Reviewed by Gavin Barraclough.

This is an 0.5% speed-up on V8 and neutral elsewhere.

* jit/SpecializedThunkJIT.h:
(JSC::SpecializedThunkJIT::returnDouble):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoREGRESSION (r86268): Fix for qt_networkAccessAllowed()
laszlo.1.gombos@nokia.com [Sun, 4 Sep 2011 02:58:46 +0000 (02:58 +0000)]
REGRESSION (r86268): Fix for qt_networkAccessAllowed()
https://bugs.webkit.org/show_bug.cgi?id=67570

Reviewed by Noam Rosenthal.

Source/WebCore:

No new tests as this change only removes dead code.
Support for Qt 4.6 has  been removed a while back.

* WebCore.pri:
* WebCore.pro:
* features.pri:
* platform/network/NetworkStateNotifier.h:
* platform/network/qt/NetworkStateNotifierQt.cpp:

Source/WebKit/qt:

Replace the ENABLE(QT_BEARER) guard with
!defined(QT_NO_BEARERMANAGEMENT) which is true by
default in Qt 4.7 or later versions.

* Api/qwebsettings.cpp:
(qt_networkAccessAllowed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove the corresponding entry from the skipped list.
rniwa@webkit.org [Sat, 3 Sep 2011 23:31:58 +0000 (23:31 +0000)]
Remove the corresponding entry from the skipped list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoREGRESSION(r94274): selection-change-closes-typing.html fails
rniwa@webkit.org [Sat, 3 Sep 2011 23:30:08 +0000 (23:30 +0000)]
REGRESSION(r94274): selection-change-closes-typing.html fails
https://bugs.webkit.org/show_bug.cgi?id=67377

Reviewed by Kent Tamura.

Source/WebCore:

The problem was that when the shadow DOM is updated by setInnerTextValue, WebKit layer detects the selection
change and calls confirmCompositionWithoutDisturbingSelection, which in turn modifies the shadow DOM by
inserting text.

Fixed the bug by not inserting text in confirmCompositionWithoutDisturbingSelection. It turned out that this
function is only used to cancel composition but never to confirming composition and restoring selection.

Test: platform/mac/editing/input/selection-change-closes-typing-2.html

* editing/Editor.cpp:
(WebCore::Editor::confirmCompositionWithoutDisturbingSelection):
(WebCore::Editor::confirmComposition):

LayoutTests:

Add a regression test to ensure the same bug doesn't exist in textarea element.

* platform/mac/editing/input/selection-change-closes-typing-2-expected.txt: Copied from
LayoutTests/platform/mac/editing/input/selection-change-closes-typing-expected.txt.
* platform/mac/editing/input/selection-change-closes-typing-2.html: Copied from
LayoutTests/platform/mac/editing/input/selection-change-closes-typing.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTest that document.all.tags() matches IE behavior with too few arguments
commit-queue@webkit.org [Sat, 3 Sep 2011 22:43:00 +0000 (22:43 +0000)]
Test that document.all.tags() matches IE behavior with too few arguments
https://bugs.webkit.org/show_bug.cgi?id=66535

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2011-09-03
Reviewed by Darin Adler.

* fast/dom/document-all-tags-expected.txt: Added.
* fast/dom/document-all-tags.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd platform-specific results for r94492
robert@webkit.org [Sat, 3 Sep 2011 21:00:17 +0000 (21:00 +0000)]
Add platform-specific results for r94492

Unreviewed.

* platform/chromium-win/fast/repaint/block-layout-inline-children-float-positioned-expected.png:
* platform/gtk/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.txt: Added.
* platform/gtk/fast/css/bug4860-absolute-inline-child-inherits-alignment-expected.txt: Added.
* platform/gtk/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Added.
* platform/gtk/fast/repaint/block-layout-inline-children-float-positioned-expected.txt:
* platform/mac/fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Added.
* platform/mac/fast/repaint/block-layout-inline-children-float-positioned-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[wx] Unreviewed build fix. Add wtf/dtoa directory to build.
kevino@webkit.org [Sat, 3 Sep 2011 20:08:17 +0000 (20:08 +0000)]
[wx] Unreviewed build fix. Add wtf/dtoa directory to build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd missing Event constructors to DOMWindow.idl
weinig@apple.com [Sat, 3 Sep 2011 19:26:54 +0000 (19:26 +0000)]
Add missing Event constructors to DOMWindow.idl
https://bugs.webkit.org/show_bug.cgi?id=67449

Reviewed by Anders Carlsson.

Source/WebCore:

Covered by existing tests.

* page/DOMWindow.idl:

LayoutTests:

* platform/mac/fast/dom/Window/window-properties-expected.txt:
* platform/mac/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/mac/fast/dom/prototype-inheritance-expected.txt:
* platform/mac/fast/js/global-constructors-expected.txt:
Update results for new constructors.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agodiv align="center" rendering problem
robert@webkit.org [Sat, 3 Sep 2011 18:28:57 +0000 (18:28 +0000)]
div align="center" rendering problem
https://bugs.webkit.org/show_bug.cgi?id=4860

Reviewed by David Hyatt.

Source/WebCore:

When an inline element with absolute position was the sole or first child of a render block with
centred alignment, it wasn't obeying its parent's alignment. However it would obey the
alignment if it was preceded by some text. The problem was that the element's render object
was getting skipped as leading white space, so it was not included in a normal line block in
a bidi run. Instead, its position was getting set by RenderBlockLineLayout::setStaticPositions()
which does not pay attention to alignment. Preceding the element with some text allowed the object
to get included in a Bidi run and so get a linebox which would get properly aligned.

The fix is to get RenderBlockLineLayout::setStaticPositions() to obey the alignment specified by
the object's container. This allows WebKit to get the same result on the test as Firefox and IE.
Opera has the same bug as unpatched WebKit.

Tests: fast/css/bug4860-absolute-block-child-does-not-inherit-alignment.html
       - Ensure positioned block elements inherit alignment.
       fast/css/bug4860-absolute-inline-child-inherits-alignment.html
       - Ensure positioned inline elements inherit alignment.
       fast/inline/absolute-positioned-inline-in-centred-block.html
       - Ensure positioned inline element that's the sole or first child of a rendered block
         obeys parents alignment.
       fast/inline/absolute-positioned-block-in-centred-block.html
       - As above, but a positioned block should not inherit alignment.

* rendering/RenderBlock.h:
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::updateLogicalWidthForAlignment):
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine): Move the alignment check to updateLogicalWidthForAlignment.
(WebCore::setStaticPositions): use startAlignedOffsetForLine and use startAlignedOffsetForBlock
(WebCore::RenderBlock::startAlignedOffsetForLine): New function, find the aligned offset using updateLogicalWidthForAlignment

LayoutTests:

* fast/css/bug4860-absolute-block-child-does-not-inherit-alignment-expected.png: Added.
* fast/css/bug4860-absolute-block-child-does-not-inherit-alignment-expected.txt: Added.
* fast/css/bug4860-absolute-block-child-does-not-inherit-alignment.html: Added.
* fast/css/bug4860-absolute-inline-child-inherits-alignment-expected.png: Added.
* fast/css/bug4860-absolute-inline-child-inherits-alignment-expected.txt: Added.
* fast/css/bug4860-absolute-inline-child-inherits-alignment.html: Added.
* fast/inline/absolute-positioned-block-in-centred-block-expected.png: Added.
* fast/inline/absolute-positioned-block-in-centred-block-expected.txt: Added.
* fast/inline/absolute-positioned-block-in-centred-block.html: Added.
* fast/inline/absolute-positioned-inline-in-centred-block-expected.png: Added.
* fast/inline/absolute-positioned-inline-in-centred-block-expected.txt: Added.
* fast/inline/absolute-positioned-inline-in-centred-block.html: Added.
* platform/chromium-linux/fast/repaint/block-layout-inline-children-float-positioned-expected.png:
* platform/chromium-linux/fast/repaint/block-layout-inline-children-float-positioned-expected.txt:
  Both of these two tests were based on the incorrect behaviour of ignoring the alignment specified
  by the container of an element absolute position when there was no text preceding the element.
  The updated results agree with Firefox and IE.
* fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.txt:
* platform/chromium-win/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.png:
  This test expected the wrong alignment of the red block - it should be centred, not aligned to the left.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove two unused functions from Element.
andreas.kling@nokia.com [Sat, 3 Sep 2011 18:18:04 +0000 (18:18 +0000)]
Remove two unused functions from Element.
https://bugs.webkit.org/show_bug.cgi?id=67492

Reviewed by Benjamin Poulain.

Removed openTagStartToString() and setCStringAttribute() as they are
not called from anywhere.

* dom/Element.cpp:
* dom/Element.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago32-bit build fix.
mitz@apple.com [Sat, 3 Sep 2011 17:13:58 +0000 (17:13 +0000)]
32-bit build fix.

* TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
(TestWebKitAPI::Util::toSTD):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Enable support for WebGL OES_standard_derivatives for Qt
commit-queue@webkit.org [Sat, 3 Sep 2011 16:13:57 +0000 (16:13 +0000)]
[Qt] Enable support for WebGL OES_standard_derivatives for Qt
https://bugs.webkit.org/show_bug.cgi?id=67430

Patch by Andrew Wason <rectalogic@rectalogic.com> on 2011-09-03
Reviewed by Noam Rosenthal.

Tested using https://cvs.khronos.org/svn/repos/registry/trunk/public/webgl/sdk/tests/conformance/extensions/oes-standard-derivatives.html

Enable existing support for OES_standard_derivatives for Qt.

* platform/graphics/opengl/Extensions3DOpenGL.cpp:
(WebCore::Extensions3DOpenGL::ensureEnabled):
(WebCore::Extensions3DOpenGL::isEnabled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMove testStringByEvaluatingJavaScriptFromString() from DumpRenderTree to TestWebKitAPI
mitz@apple.com [Sat, 3 Sep 2011 15:57:04 +0000 (15:57 +0000)]
Move testStringByEvaluatingJavaScriptFromString() from DumpRenderTree to TestWebKitAPI
https://bugs.webkit.org/show_bug.cgi?id=67559

Reviewed by Darin Adler.

* DumpRenderTree/mac/DumpRenderTree.mm:
(dumpRenderTree): Moved testStringByEvaluatingJavaScriptFromString() from here and removed
the call to it.
* TestWebKitAPI/PlatformUtilities.h: Declared Util::toSTD(NSString *)
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj: Added StringByEvaluatingJavaScriptFromString.mm.
* TestWebKitAPI/Tests/mac/StringByEvaluatingJavaScriptFromString.mm: Added.
(TestWebKitAPI::TEST): Added. Moved testStringByEvaluatingJavaScriptFromString() to here.
* TestWebKitAPI/mac/PlatformUtilitiesMac.mm:
(TestWebKitAPI::Util::toSTD): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agogarden-o-matic results view should have a better results selector
abarth@webkit.org [Sat, 3 Sep 2011 08:29:32 +0000 (08:29 +0000)]
garden-o-matic results view should have a better results selector
https://bugs.webkit.org/show_bug.cgi?id=67542

Reviewed by Dimitri Glazkov.

This patch adds a basic grid-based results selector to the results
view.  Currently, this grid just shows how the tests fail on the
various bots.  A future patch will let you select which failure to view
and to mark the failures for rebaselining.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
  - Add some more basic functions for manipulating dictionaries.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/controllers.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/ui/results_unittests.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agogarden-o-matic results view should show Actual and Expected results for text failures
abarth@webkit.org [Sat, 3 Sep 2011 08:27:38 +0000 (08:27 +0000)]
garden-o-matic results view should show Actual and Expected results for text failures
https://bugs.webkit.org/show_bug.cgi?id=67536

Reviewed by Eric Seidel.

In the past, we didn't show actual and expected text results (we just
showed the diff) because we didn't have the awesome six-by-two results
grid.  Now that we do, we can move show these results.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base_unittests.js:
  - Fixed some typos that were preventing these unit tests from running.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:
(.):
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results_unittests.js:
  - Report -actual.txt and -expected.txt as possible results URLs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agogarden-o-matic shows "ghost" failures that are already fixed
abarth@webkit.org [Sat, 3 Sep 2011 08:25:33 +0000 (08:25 +0000)]
garden-o-matic shows "ghost" failures that are already fixed
https://bugs.webkit.org/show_bug.cgi?id=67535

Reviewed by Eric Seidel.

About 10% of writes fail to stick on test-results.appspot.com.  This
patch causes us to fetch the full_results.json blob directly from
build.chromium.org rather than relying upon AppEngine.

Unforuntately, we still need to get historical information from
AppEngine.  That will take several patches to fix becuase I need to
change the bots to write the full_results.json file to the
build-specific directory in addition to the zip file.

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/base.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/model.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/results.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@94485 268f45cc-cd09-0410-ab3c-d52691b4dbfc