WebKit-https.git
13 years ago Reviewed by Oliver.
eric@webkit.org [Thu, 21 Feb 2008 03:38:04 +0000 (03:38 +0000)]
    Reviewed by Oliver.

        Remove m_drawingContext and change m_data to m_imageBuffer

        * html/HTMLCanvasElement.cpp:
        (WebCore::HTMLCanvasElement::HTMLCanvasElement):
        (WebCore::HTMLCanvasElement::reset):
        (WebCore::HTMLCanvasElement::paint):
        (WebCore::HTMLCanvasElement::createImageBuffer):
        (WebCore::HTMLCanvasElement::buffer):
        (WebCore::HTMLCanvasElement::createPlatformImage):
        * html/HTMLCanvasElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-02-20 Brent Fulgham <bfulgham@gmail.com>
pewtermoose@webkit.org [Thu, 21 Feb 2008 02:26:00 +0000 (02:26 +0000)]
2008-02-20  Brent Fulgham  <bfulgham@gmail.com>

        Reviewed by Alp.

        - http://bugs.webkit.org/show_bug.cgi?id=17428
          Reenable a Windows-based launcher

        This patch reenables the venerable Spinneret application,
        changing its name to match the other lanch applications.

        * WinLauncher: Added.
        * WinLauncher/WinLauncher.cpp: Added.
        (WinLauncherWebHost::updateAddressBar):
        (WinLauncherWebHost::QueryInterface):
        (WinLauncherWebHost::AddRef):
        (WinLauncherWebHost::Release):
        (resizeSubViews):
        (_tWinMain):
        (MyRegisterClass):
        (InitInstance):
        (WndProc):
        (MyEditProc):
        (About):
        (loadURL):
        * WinLauncher/WinLauncher.h: Added.
        (WinLauncherWebHost::WinLauncherWebHost):
        (WinLauncherWebHost::didStartProvisionalLoadForFrame):
        (WinLauncherWebHost::didReceiveServerRedirectForProvisionalLoadForFrame):
        (WinLauncherWebHost::didFailProvisionalLoadWithError):
        (WinLauncherWebHost::didCommitLoadForFrame):
        (WinLauncherWebHost::didReceiveTitle):
        (WinLauncherWebHost::didReceiveIcon):
        (WinLauncherWebHost::didFinishLoadForFrame):
        (WinLauncherWebHost::didFailLoadWithError):
        (WinLauncherWebHost::didChangeLocationWithinPageForFrame):
        (WinLauncherWebHost::willPerformClientRedirectToURL):
        (WinLauncherWebHost::didCancelClientRedirectForFrame):
        (WinLauncherWebHost::willCloseFrame):
        (WinLauncherWebHost::windowScriptObjectAvailable):
        * WinLauncher/WinLauncher.ico: Added.
        * WinLauncher/WinLauncher.rc: Added.
        * WinLauncher/WinLauncher.vcproj: Added.
        * WinLauncher/resource.h: Added.
        * WinLauncher/small.ico: Added.
        * WinLauncher/stdafx.cpp: Added.
        * WinLauncher/stdafx.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Sam.
andersca@apple.com [Thu, 21 Feb 2008 02:17:30 +0000 (02:17 +0000)]
    Reviewed by Sam.

        Rename AtomicString::domString() to AtomicString::string().

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
        * css/CSSFontSelector.cpp:
        (WebCore::CSSFontSelector::getFontData):
        * dom/Attr.cpp:
        (WebCore::Attr::createTextChild):
        * dom/Comment.cpp:
        (WebCore::Comment::nodeName):
        * dom/Document.cpp:
        (WebCore::Document::recalcStyleSelector):
        (WebCore::Document::setHTMLWindowEventListener):
        (WebCore::Document::formElementsState):
        * dom/StyledElement.cpp:
        (WebCore::StyledElement::parseMappedAttribute):
        * dom/Text.cpp:
        (WebCore::Text::nodeName):
        * editing/SelectionController.cpp:
        (WebCore::SelectionController::debugRenderer):
        * html/HTMLCollection.cpp:
        (WebCore::HTMLCollection::checkForNameMatch):
        * html/HTMLElement.cpp:
        (WebCore::HTMLElement::nodeName):
        (WebCore::HTMLElement::setHTMLEventListener):
        * html/HTMLFormCollection.cpp:
        (WebCore::HTMLFormCollection::getNamedFormItem):
        * html/HTMLImageElement.cpp:
        (WebCore::HTMLImageElement::parseMappedAttribute):
        (WebCore::HTMLImageElement::isURLAttribute):
        * html/HTMLLinkElement.cpp:
        (WebCore::HTMLLinkElement::parseMappedAttribute):
        (WebCore::HTMLLinkElement::tokenizeRelAttribute):
        * html/HTMLObjectElement.cpp:
        (WebCore::HTMLObjectElement::isURLAttribute):
        (WebCore::HTMLObjectElement::containsJavaApplet):
        * html/HTMLParamElement.cpp:
        (WebCore::HTMLParamElement::isURLAttribute):
        * html/HTMLParser.cpp:
        (WebCore::HTMLParser::handleIsindex):
        * html/HTMLScriptElement.cpp:
        (WebCore::HTMLScriptElement::insertedIntoDocument):
        (WebCore::HTMLScriptElement::shouldExecuteAsJavaScript):
        * html/HTMLStyleElement.cpp:
        (WebCore::HTMLStyleElement::parseMappedAttribute):
        * html/HTMLTokenizer.cpp:
        (WebCore::HTMLTokenizer::parseTag):
        * html/HTMLViewSourceDocument.cpp:
        (WebCore::HTMLViewSourceDocument::addViewSourceToken):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::saveDocumentState):
        * page/FrameTree.cpp:
        (WebCore::FrameTree::uniqueChildName):
        * platform/text/AtomicString.h:
        (WebCore::AtomicString::string):
        (WebCore::AtomicString::contains):
        (WebCore::AtomicString::find):
        (WebCore::AtomicString::startsWith):
        (WebCore::AtomicString::endsWith):
        * rendering/RenderPartObject.cpp:
        (WebCore::RenderPartObject::updateWidget):
        * svg/SVGElement.cpp:
        (WebCore::SVGElement::addSVGEventListener):
        * svg/SVGSVGElement.cpp:
        (WebCore::SVGSVGElement::addSVGWindowEventListener):
        * xml/XPathFunctions.cpp:
        (WebCore::XPath::FunLocalName::evaluate):
        (WebCore::XPath::FunNamespaceURI::evaluate):
        (WebCore::XPath::FunName::evaluate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoRemove stray conflict marker
pewtermoose@webkit.org [Thu, 21 Feb 2008 02:12:09 +0000 (02:12 +0000)]
Remove stray conflict marker

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-02-20 Brent Fulgham <bfulgham@gmail.com>2008-02-20 Brent Fulgham <bfulgham...
pewtermoose@webkit.org [Thu, 21 Feb 2008 02:10:56 +0000 (02:10 +0000)]
2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>2008-02-20  Brent Fulgham  <bfulgham@gmail.com>

        Reviewed by Dan.

        http://bugs.webkit.org/show_bug.cgi?id=17336
        Provide implementations for Windows (Cairo) build of WebKit that
        handles font formatting.
        - Split font implementation files to allow maximal code sharing
          between CG and Cairo back-ends.

        * WebCore.vcproj/WebCore.vcproj:
        * platform/graphics/SimpleFontData.h:   Add signatures for private win
          initialization functions.
        * platform/graphics/win/FontCacheWin.cpp:
        (WebCore::FontCache::platformInit):
        (WebCore::FontCache::createFontPlatformData):
        * platform/graphics/win/FontCairoWin.cpp: Removed.  Universal version
          is now part of platform/graphics/cairo.
        * platform/graphics/win/FontCustomPlatformDataCairo.cpp: Added.
        (WebCore::FontCustomPlatformDataCairo::~FontCustomPlatformDataCairo):
        (WebCore::FontCustomPlatformDataCairo::fontPlatformData):
        (WebCore::releaseData):
        (WebCore::createFontCustomPlatformData):
        * platform/graphics/win/FontCustomPlatformDataCairo.h: Added.
        (WebCore::FontCustomPlatformDataCairo::FontCustomPlatformDataCairo):
        * platform/graphics/win/FontPlatformData.h:
        (WebCore::FontPlatformData::FontPlatformData):
        (WebCore::FontPlatformData::fontFace):
        (WebCore::FontPlatformData::scaledFont):
        (WebCore::FontPlatformData::operator==):
        * platform/graphics/win/FontPlatformDataCGWin.cpp: Copied from WebCore/platform/graphics/win/FontPlatformDataWin.cpp.
        (WebCore::FontPlatformData::platformDataInit):
        * platform/graphics/win/FontPlatformDataCairoWin.cpp: Added.
        (WebCore::FontPlatformData::platformDataInit):
        (WebCore::FontPlatformData::FontPlatformData):
        (WebCore::FontPlatformData::setFont):
        * platform/graphics/win/FontPlatformDataWin.cpp:  Moved CG-specific
          code to FontPlatformDataCG.cpp.
        (WebCore::FontPlatformData::FontPlatformData):
        * platform/graphics/win/GlyphPageTreeNodeCGWin.cpp: Copied from WebCore/platform/graphics/win/GlyphPageTreeNodeWin.cpp.
        * platform/graphics/win/GlyphPageTreeNodeCairoWin.cpp: Copied from WebCore/platform/graphics/win/GlyphPageTreeNodeWin.cpp.
        (WebCore::GlyphPage::fill):
        * platform/graphics/win/GlyphPageTreeNodeWin.cpp: Removed.  Replaced
          with CG- and Cairo-specific versions.
        * platform/graphics/win/SimpleFontDataCGWin.cpp:
        (WebCore::SimpleFontData::platformInit):
        (WebCore::SimpleFontData::platformDestroy):
        (WebCore::SimpleFontData::platformWidthForGlyph):
        * platform/graphics/win/SimpleFontDataCairoWin.cpp:
        (WebCore::SimpleFontData::platformInit):
        (WebCore::SimpleFontData::platformDestroy):
        (WebCore::SimpleFontData::platformWidthForGlyph):
        (WebCore::SimpleFontData::setFont):
        * platform/graphics/win/SimpleFontDataWin.cpp:
        (WebCore::SimpleFontData::initGDIFont):
        (WebCore::SimpleFontData::platformCommonDestroy):
        (WebCore::SimpleFontData::widthForGDIGlyph):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Sam.
darin@apple.com [Thu, 21 Feb 2008 02:03:59 +0000 (02:03 +0000)]
    Reviewed by Sam.

        * dom/Node.h: Took out unneeded forward declaration of TextStream.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Sam.
darin@apple.com [Thu, 21 Feb 2008 02:01:12 +0000 (02:01 +0000)]
    Reviewed by Sam.

        * rendering/RenderObject.h: Took out unneeded forward declaration of TextStream.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix for bug 16760, incorrect <object> MIME type handling and fallback
hyatt@apple.com [Thu, 21 Feb 2008 01:59:14 +0000 (01:59 +0000)]
    Fix for bug 16760, incorrect <object> MIME type handling and fallback
        handling.

        Reviewed by darin

        * html/HTMLImageLoader.cpp:
        (WebCore::HTMLImageLoader::notifyFinished):
        If the image had an error, make sure to do <object> fallback.

        * html/HTMLObjectElement.cpp:
        (WebCore::HTMLObjectElement::renderFallbackContent):
        Before doing fallback check if there is a MIME type mismatch between
        an image type and a non-image type.  If so, detach and re-attach after
        storing the correct MIME type.

        * loader/loader.cpp:
        (WebCore::Loader::didReceiveData):
        Consider it an error when a 404 is encountered on a CachedResource load.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Sam.
andersca@apple.com [Thu, 21 Feb 2008 01:41:14 +0000 (01:41 +0000)]
    Reviewed by Sam.

        StringImpl constructors used by AtomicString should start with a refcount of 1.

        * platform/text/AtomicString.cpp:
        (WebCore::AtomicString::add):
        * platform/text/AtomicString.h:
        * platform/text/StringImpl.cpp:
        (WebCore::StringImpl::StringImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago * bindings/js/kjs_navigator.cpp:
darin@apple.com [Thu, 21 Feb 2008 01:06:56 +0000 (01:06 +0000)]
    * bindings/js/kjs_navigator.cpp:
        (WebCore::needsYouTubeQuirk): Tweak comments.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
andersca@apple.com [Wed, 20 Feb 2008 23:54:37 +0000 (23:54 +0000)]
    Reviewed by Darin.

        Change all refcounted classes in page/ to start with a refcount of 1.

        * page/BarInfo.cpp:
        (WebCore::BarInfo::BarInfo):
        * page/BarInfo.h:
        (WebCore::BarInfo::create):
        * page/Console.cpp:
        (WebCore::Console::Console):
        * page/Console.h:
        (WebCore::Console::create):
        * page/DOMSelection.cpp:
        (WebCore::DOMSelection::DOMSelection):
        * page/DOMSelection.h:
        (WebCore::DOMSelection::create):
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::DOMWindow):
        (WebCore::DOMWindow::screen):
        (WebCore::DOMWindow::history):
        (WebCore::DOMWindow::locationbar):
        (WebCore::DOMWindow::menubar):
        (WebCore::DOMWindow::personalbar):
        (WebCore::DOMWindow::scrollbars):
        (WebCore::DOMWindow::statusbar):
        (WebCore::DOMWindow::toolbar):
        (WebCore::DOMWindow::console):
        (WebCore::DOMWindow::getSelection):
        * page/DOMWindow.h:
        (WebCore::DOMWindow::create):
        * page/Frame.cpp:
        (WebCore::Frame::domWindow):
        * page/History.cpp:
        (WebCore::History::History):
        * page/History.h:
        (WebCore::History::create):
        * page/InspectorController.cpp:
        (WebCore::InspectorResource::create):
        (WebCore::InspectorResource::InspectorResource):
        (WebCore::InspectorDatabaseResource::create):
        (WebCore::InspectorDatabaseResource::InspectorDatabaseResource):
        (WebCore::InspectorController::didLoadResourceFromMemoryCache):
        (WebCore::InspectorController::identifierForInitialRequest):
        (WebCore::InspectorController::didOpenDatabase):
        * page/Plugin.h:
        (WebCore::Plugin::create):
        (WebCore::Plugin::Plugin):
        * page/Screen.cpp:
        (WebCore::Screen::Screen):
        * page/Screen.h:
        (WebCore::Screen::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
weinig@apple.com [Wed, 20 Feb 2008 23:04:40 +0000 (23:04 +0000)]
WebCore:

        Reviewed by Darin and Geoff.

        - <rdar://problem/5754378> work around missing video on YouTube front page with a site-specific hack

        * WebCore.base.exp: Updated.

        * bindings/js/kjs_navigator.cpp:
        (WebCore::needsYouTubeQuirk): Added. Return true on Windows only when the quirk is needed.
        (WebCore::Navigator::getValueProperty): For the appVersion property, if needsYouTubeQuirk
        return true, then return the empty string.

        * page/Settings.cpp:
        (WebCore::Settings::Settings): Set m_needsSiteSpecificQuirks to false.
        (WebCore::Settings::setNeedsSiteSpecificQuirks): Added.
        * page/Settings.h: Added m_needsSiteSpecificQuirks.
        (WebCore::Settings::needsSiteSpecificQuirks): Added.

WebKit/mac:

        Reviewed by Darin and Geoff.

        - WebKit part of <rdar://problem/5754378> work around missing video on YouTube front page with a site-specific hack

        * WebView/WebView.mm:
        (-[WebView _preferencesChangedNotification:]): Added a call to Settings::setNeedsSiteSpecificQuirks.
        There are currently no site-specific quirks on Mac, but we will propagate the state
        to WebCore to avoid possible mistakes later.

WebKit/win:

        Reviewed by Darin and Geoff.

        - WebKit part of <rdar://problem/5754378> work around missing video on YouTube front page with a site-specific hack

        * WebView.cpp:
        (WebView::notifyPreferencesChanged): Added a call to Settings::setNeedsSiteSpecificQuirks.
        (WebView::setAllowSiteSpecificHacks): Added a comment about the problem Darin noticed, where
        after you disable the site-specific hacks they persist until you open a new window or tweak
        some other preference.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLand additional doctype piece. toString fix of doctype.
hyatt@apple.com [Wed, 20 Feb 2008 22:57:03 +0000 (22:57 +0000)]
Land additional doctype piece.  toString fix of doctype.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix for bug 12751, doctype nodes aren't part of the Document (Acid3).
hyatt@apple.com [Wed, 20 Feb 2008 22:47:57 +0000 (22:47 +0000)]
    Fix for bug 12751, doctype nodes aren't part of the Document (Acid3).

        Reviewed by Sam Weinig

        Many tests added in fast/doctypes.

        * dom/DOMImplementation.cpp:
        (WebCore::DOMImplementation::createDocument):
        (WebCore::DOMImplementation::createHTMLDocument):
        * dom/Document.cpp:
        (WebCore::Document::Document):
        (WebCore::Document::setDocType):
        (WebCore::Document::attach):
        (WebCore::Document::getImageMap):
        * dom/Document.h:
        (WebCore::Document::doctype):
        (WebCore::Document::):
        (WebCore::Document::determineParseMode):
        (WebCore::Document::setParseMode):
        (WebCore::Document::parseMode):
        (WebCore::Document::inCompatMode):
        (WebCore::Document::inAlmostStrictMode):
        (WebCore::Document::inStrictMode):
        * dom/DocumentType.cpp:
        (WebCore::DocumentType::cloneNode):
        (WebCore::DocumentType::insertedIntoDocument):
        (WebCore::DocumentType::removedFromDocument):
        * dom/DocumentType.h:
        * dom/Node.cpp:
        (WebCore::Node::childAllowed):
        * dom/StyledElement.cpp:
        (WebCore::StyledElement::attributeChanged):
        * dom/XMLTokenizer.cpp:
        (WebCore::XMLTokenizer::internalSubset):
        (WebCore::):
        * editing/markup.cpp:
        (WebCore::appendStartMarkup):
        * html/HTMLAppletElement.cpp:
        (WebCore::HTMLAppletElement::createRenderer):
        * html/HTMLDocument.cpp:
        (WebCore::HTMLDocument::HTMLDocument):
        (WebCore::HTMLDocument::childAllowed):
        (WebCore::HTMLDocument::determineParseMode):
        * html/HTMLDocument.h:
        * html/HTMLMapElement.cpp:
        (WebCore::HTMLMapElement::parseMappedAttribute):
        * html/HTMLParamElement.cpp:
        (WebCore::HTMLParamElement::parseMappedAttribute):
        * html/HTMLParser.cpp:
        (WebCore::HTMLParser::parseDoctypeToken):
        * html/HTMLParser.h:
        * html/HTMLTokenizer.cpp:
        (WebCore::HTMLTokenizer::reset):
        (WebCore::HTMLTokenizer::parseDoctype):
        (WebCore::HTMLTokenizer::parseTag):
        (WebCore::HTMLTokenizer::write):
        (WebCore::HTMLTokenizer::finish):
        (WebCore::HTMLTokenizer::processDoctypeToken):
        * html/HTMLTokenizer.h:
        (WebCore::):
        (WebCore::DoctypeToken::DoctypeToken):
        (WebCore::DoctypeToken::reset):
        (WebCore::DoctypeToken::state):
        (WebCore::DoctypeToken::setState):
        (WebCore::HTMLTokenizer::State::inDoctype):
        (WebCore::HTMLTokenizer::State::setInDoctype):
        (WebCore::HTMLTokenizer::State::needsSpecialWriteHandling):
        (WebCore::HTMLTokenizer::State::):
        * html/HTMLViewSourceDocument.cpp:
        (WebCore::HTMLViewSourceDocument::addViewSourceToken):
        (WebCore::HTMLViewSourceDocument::addViewSourceDoctypeToken):
        * html/HTMLViewSourceDocument.h:
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::write):
        (WebCore::FrameLoader::switchOutLowBandwidthDisplayIfReady):
        * page/Frame.cpp:
        (WebCore::Frame::documentTypeString):
        * page/inspector/utilities.js:
        * xml/XSLTProcessor.cpp:
        (WebCore::XSLTProcessor::createDocumentFromSource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
andersca@apple.com [Wed, 20 Feb 2008 22:28:42 +0000 (22:28 +0000)]
    Reviewed by Darin.

        Change most SVG related classes to start out with a ref count of 1.

        * bindings/js/JSSVGPointListCustom.cpp:
        (WebCore::JSSVGPointList::initialize):
        (WebCore::JSSVGPointList::insertItemBefore):
        (WebCore::JSSVGPointList::replaceItem):
        (WebCore::JSSVGPointList::appendItem):
        * bindings/js/JSSVGTransformListCustom.cpp:
        (WebCore::JSSVGTransformList::initialize):
        (WebCore::JSSVGTransformList::insertItemBefore):
        (WebCore::JSSVGTransformList::replaceItem):
        (WebCore::JSSVGTransformList::appendItem):
        * rendering/SVGCharacterLayoutInfo.h:
        (WebCore::SVGCharOnPath::create):
        (WebCore::SVGCharOnPath::SVGCharOnPath):
        * rendering/SVGRootInlineBox.cpp:
        (WebCore::SVGRootInlineBox::buildLayoutInformationForTextBox):
        * svg/SVGAnimationElement.cpp:
        (WebCore::SVGAnimationElement::parseBeginOrEndValue):
        * svg/SVGClipPathElement.cpp:
        (WebCore::SVGClipPathElement::canvasResource):
        * svg/SVGElementInstance.cpp:
        (WebCore::SVGElementInstance::childNodes):
        * svg/SVGElementInstanceList.cpp:
        (WebCore::SVGElementInstanceList::SVGElementInstanceList):
        * svg/SVGElementInstanceList.h:
        (WebCore::SVGElementInstanceList::create):
        * svg/SVGFitToViewBox.cpp:
        (WebCore::SVGFitToViewBox::SVGFitToViewBox):
        * svg/SVGGradientElement.cpp:
        (WebCore::SVGGradientElement::SVGGradientElement):
        (WebCore::SVGGradientElement::canvasResource):
        * svg/SVGImageElement.cpp:
        (WebCore::SVGImageElement::SVGImageElement):
        * svg/SVGLengthList.h:
        (WebCore::SVGLengthList::create):
        * svg/SVGList.h:
        (WebCore::SVGList::SVGList):
        (WebCore::SVGPODListItem::create):
        (WebCore::SVGPODListItem::copy):
        (WebCore::SVGPODListItem::SVGPODListItem):
        (WebCore::SVGPODList::initialize):
        (WebCore::SVGPODList::insertItemBefore):
        (WebCore::SVGPODList::replaceItem):
        (WebCore::SVGPODList::appendItem):
        (WebCore::SVGPODList::SVGPODList):
        * svg/SVGMarkerElement.cpp:
        (WebCore::SVGMarkerElement::canvasResource):
        * svg/SVGMaskElement.cpp:
        (WebCore::SVGMaskElement::canvasResource):
        * svg/SVGNumberList.h:
        (WebCore::SVGNumberList::create):
        * svg/SVGPathElement.cpp:
        (WebCore::SVGPathElement::createSVGPathSegClosePath):
        (WebCore::SVGPathElement::createSVGPathSegMovetoAbs):
        (WebCore::SVGPathElement::createSVGPathSegMovetoRel):
        (WebCore::SVGPathElement::createSVGPathSegLinetoAbs):
        (WebCore::SVGPathElement::createSVGPathSegLinetoRel):
        (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicAbs):
        (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicRel):
        (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticAbs):
        (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticRel):
        (WebCore::SVGPathElement::createSVGPathSegArcAbs):
        (WebCore::SVGPathElement::createSVGPathSegArcRel):
        (WebCore::SVGPathElement::createSVGPathSegLinetoHorizontalAbs):
        (WebCore::SVGPathElement::createSVGPathSegLinetoHorizontalRel):
        (WebCore::SVGPathElement::createSVGPathSegLinetoVerticalAbs):
        (WebCore::SVGPathElement::createSVGPathSegLinetoVerticalRel):
        (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicSmoothAbs):
        (WebCore::SVGPathElement::createSVGPathSegCurvetoCubicSmoothRel):
        (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticSmoothAbs):
        (WebCore::SVGPathElement::createSVGPathSegCurvetoQuadraticSmoothRel):
        (WebCore::SVGPathElement::pathSegList):
        * svg/SVGPathElement.h:
        * svg/SVGPathSeg.h:
        (WebCore::SVGPathSeg::SVGPathSeg):
        * svg/SVGPathSegArc.h:
        (WebCore::SVGPathSegArcAbs::create):
        (WebCore::SVGPathSegArcRel::create):
        * svg/SVGPathSegClosePath.h:
        (WebCore::SVGPathSegClosePath::create):
        * svg/SVGPathSegCurvetoCubic.h:
        (WebCore::SVGPathSegCurvetoCubicAbs::create):
        (WebCore::SVGPathSegCurvetoCubicRel::create):
        * svg/SVGPathSegCurvetoCubicSmooth.h:
        (WebCore::SVGPathSegCurvetoCubicSmoothAbs::create):
        (WebCore::SVGPathSegCurvetoCubicSmoothRel::create):
        * svg/SVGPathSegCurvetoQuadratic.h:
        (WebCore::SVGPathSegCurvetoQuadraticAbs::create):
        (WebCore::SVGPathSegCurvetoQuadraticRel::create):
        * svg/SVGPathSegCurvetoQuadraticSmooth.h:
        (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::create):
        (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::create):
        * svg/SVGPathSegLineto.h:
        (WebCore::SVGPathSegLinetoAbs::create):
        (WebCore::SVGPathSegLinetoRel::create):
        * svg/SVGPathSegLinetoHorizontal.h:
        (WebCore::SVGPathSegLinetoHorizontalAbs::create):
        (WebCore::SVGPathSegLinetoHorizontalRel::create):
        * svg/SVGPathSegLinetoVertical.h:
        (WebCore::SVGPathSegLinetoVerticalAbs::create):
        (WebCore::SVGPathSegLinetoVerticalRel::create):
        * svg/SVGPathSegList.h:
        (WebCore::SVGPathSegList::create):
        * svg/SVGPathSegMoveto.h:
        (WebCore::SVGPathSegMovetoAbs::create):
        (WebCore::SVGPathSegMovetoRel::create):
        * svg/SVGPatternElement.cpp:
        (WebCore::SVGPatternElement::SVGPatternElement):
        (WebCore::SVGPatternElement::canvasResource):
        * svg/SVGPointList.h:
        (WebCore::SVGPointList::create):
        * svg/SVGPolyElement.cpp:
        (WebCore::SVGPolyElement::points):
        * svg/SVGPreserveAspectRatio.cpp:
        (WebCore::SVGPreserveAspectRatio::SVGPreserveAspectRatio):
        * svg/SVGPreserveAspectRatio.h:
        (WebCore::SVGPreserveAspectRatio::create):
        * svg/SVGRenderingIntent.h:
        (WebCore::SVGRenderingIntent::SVGRenderingIntent):
        * svg/SVGStringList.h:
        (WebCore::SVGStringList::create):
        * svg/SVGStyledTransformableElement.cpp:
        (WebCore::SVGStyledTransformableElement::SVGStyledTransformableElement):
        * svg/SVGTests.cpp:
        (WebCore::SVGTests::requiredFeatures):
        (WebCore::SVGTests::requiredExtensions):
        (WebCore::SVGTests::systemLanguage):
        * svg/SVGTextElement.cpp:
        (WebCore::SVGTextElement::SVGTextElement):
        * svg/SVGTextPositioningElement.cpp:
        (WebCore::SVGTextPositioningElement::SVGTextPositioningElement):
        * svg/SVGTransformList.h:
        (WebCore::SVGTransformList::create):
        * svg/SVGUnitTypes.h:
        (WebCore::SVGUnitTypes::SVGUnitTypes):
        * svg/SVGViewElement.cpp:
        (WebCore::SVGViewElement::viewTarget):
        * svg/SVGViewSpec.cpp:
        (WebCore::SVGViewSpec::SVGViewSpec):
        * svg/graphics/SVGPaintServer.cpp:
        (WebCore::SVGPaintServer::sharedSolidPaintServer):
        * svg/graphics/SVGPaintServer.h:
        * svg/graphics/SVGPaintServerGradient.h:
        (WebCore::SVGPaintServerGradient::SharedStopCache::create):
        (WebCore::SVGPaintServerGradient::SharedStopCache::SharedStopCache):
        * svg/graphics/SVGPaintServerLinearGradient.h:
        (WebCore::SVGPaintServerLinearGradient::create):
        * svg/graphics/SVGPaintServerPattern.h:
        (WebCore::SVGPaintServerPattern::create):
        * svg/graphics/SVGPaintServerRadialGradient.h:
        (WebCore::SVGPaintServerRadialGradient::create):
        * svg/graphics/SVGPaintServerSolid.h:
        (WebCore::SVGPaintServerSolid::create):
        * svg/graphics/SVGResource.cpp:
        (WebCore::SVGResource::SVGResource):
        * svg/graphics/SVGResource.h:
        * svg/graphics/SVGResourceClipper.h:
        (WebCore::SVGResourceClipper::create):
        * svg/graphics/SVGResourceMarker.h:
        (WebCore::SVGResourceMarker::create):
        * svg/graphics/SVGResourceMasker.h:
        (WebCore::SVGResourceMasker::create):
        * svg/graphics/cg/SVGPaintServerGradientCg.cpp:
        (WebCore::SVGPaintServerGradient::updateQuartzGradientStopsCache):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Sam.
darin@apple.com [Wed, 20 Feb 2008 21:36:34 +0000 (21:36 +0000)]
    Reviewed by Sam.

        - make conversion from CSS ParseString to String and AtomicString
          automatic and remove all the explicit calls to do the conversion

        - fix CSS parsing to do fewer allocations, mostly by using the
          equalIgnoringCase function in CSSParser

        * css/CSSGrammar.y: Take out all the explicit atomicString and
        domString calls now that ParseString knows how to convert itself.

        * css/CSSParser.cpp:
        (WebCore::equal): Added.
        (WebCore::equalIgnoringCase): Allow non-lettters.
        (WebCore::ParseString::lower): Used charactersAreAllASCII.
        (WebCore::unitFromString): Use equal.
        (WebCore::CSSParser::parseValue): Removed unneeded call to domString.
        (WebCore::CSSParser::parseContent): Use equalIgnoringCase.
        (WebCore::CSSParser::parseBackgroundImage): Removed unneeded call to domString.
        (WebCore::CSSParser::parseTransitionTimingFunction): Use equalIgnoringCase.
        (WebCore::CSSParser::parseDashboardRegions): More of the same.
        (WebCore::CSSParser::parseCounterContent): Ditto.
        (WebCore::CSSParser::parseShape): Use equalIgnoringCase.
        (WebCore::CSSParser::parseFontFamily): Removed unneeded calls to domString.
        (WebCore::CSSParser::parseFontFaceSrc): More.
        (WebCore::CSSParser::parseFontFaceUnicodeRange): More.
        (WebCore::CSSParser::parseColor): Don't lowercase here -- setNamedColor now
        handles the case folding.
        (WebCore::CSSParser::parseColorFromValue): More.
        (WebCore::CSSParser::parseBorderImage): More.
        (WebCore::CSSParser::parseCounter): More.
        (WebCore::TransformOperationInfo::TransformOperationInfo): More.
        (WebCore::CSSParser::parseTransform): More.
        (WebCore::CSSParser::createCharsetRule): More.
        (WebCore::CSSParser::createImportRule): More.

        * css/CSSParser.h: Removed domString and atomicString functions.
        (WebCore::ParseString::operator String): Added. Allows conversion to String
        without an explicit function call.
        (WebCore::ParseString::operator AtomicString): Ditto.

        * css/MediaQueryExp.cpp:
        (WebCore::MediaQueryExp::MediaQueryExp): Removed a call to domString.
        * css/SVGCSSParser.cpp:
        (WebCore::CSSParser::parseSVGValue): Removed calls to domString.

        * platform/graphics/Color.cpp:
        (WebCore::findNamedColor): Call toASCIILower on each character as we copy
        it into the 8-bit character buffer to make the operation fold case.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix a bug in this SVG test harness. Make sure it uses document.documentElement inste...
hyatt@apple.com [Wed, 20 Feb 2008 21:03:48 +0000 (21:03 +0000)]
Fix a bug in this SVG test harness.  Make sure it uses document.documentElement instead of document.firstChild.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin Adler.
justin.garcia@apple.com [Wed, 20 Feb 2008 17:48:44 +0000 (17:48 +0000)]
    Reviewed by Darin Adler.

        <rdar://problem/5694920> Typing (esp. deleting) is slower due to TOT WebCore changes

        * editing/DeleteSelectionCommand.cpp:
        (WebCore::DeleteSelectionCommand::initializeStartEnd): The common case here
        is where there are no special elements.  Avoid creating VisiblePositions in
        that case.  Additionally, this change postpones the more expensive creation
        of an upstream VisiblePosition until the last possible moment.
        (WebCore::DeleteSelectionCommand::saveTypingStyleState):
        (WebCore::DeleteSelectionCommand::calculateTypingStyleAfterDelete): Add an
        early return for a common case: deleting characters that are all inside the
        same text node. In that case the style at the start of the selection will
        not change during the delete, so there is no need to save/recompute it.
        (WebCore::DeleteSelectionCommand::saveFullySelectedAnchor): Early return
        before VisiblePosition creation if the ends of the selection aren't enclosed
        by an anchor.
        * editing/TypingCommand.cpp:
        (WebCore::TypingCommand::markMisspellingsAfterTyping): Early return if spell
        checking isn't enabled.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Incorporates some improvements made by Dan Bernstein.
ap@webkit.org [Wed, 20 Feb 2008 12:35:15 +0000 (12:35 +0000)]
    Incorporates some improvements made by Dan Bernstein.

        Reviewed by Darin.

        http://bugs.webkit.org/show_bug.cgi?id=17106
        <rdar://problem/5750722> Debug build ASSERTs on page load

        Test: fast/encoding/GBK/close-gbk-converter.html

        * platform/text/TextCodecICU.cpp:
        (WebCore::getGbkEscape): Changed to use a switch instead of a HashMap, as there
        are only four values.
        (WebCore::gbkCallbackEscape): Check the reason why the function is called, and do not attempt
        getting an escape character if it's not UCNV_UNASSIGNED.
        (WebCore::gbkCallbackSubstitute): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Build fix.
ap@webkit.org [Wed, 20 Feb 2008 11:39:40 +0000 (11:39 +0000)]
    Build fix.

        * xml/XMLHttpRequest.cpp:
        (WebCore::isSafeRequestHeader):
        (WebCore::XMLHttpRequest::setRequestHeader):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
ap@webkit.org [Wed, 20 Feb 2008 11:10:30 +0000 (11:10 +0000)]
    Reviewed by Darin.

        <rdar://problem/5749455> Unable to set the Referer header in Dashboard using XMLHttpRequest

        Cannot be tested in DRT.

        * xml/XMLHttpRequest.cpp: (WebCore::canSetRequestHeader): Assume that a request that can load
        local files can also set any headers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Sam.
darin@apple.com [Wed, 20 Feb 2008 02:17:25 +0000 (02:17 +0000)]
    Reviewed by Sam.

        - removed use of DeprecatedString for font family names

        * css/CSSFontSelector.cpp:
        (WebCore::CSSFontSelector::addFontFaceRule): Update for name change.
        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseFontFamily): Update to use new appendSpaceSeparated
        function and String rather than DeprecatedString.
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applyProperty): Updated for name change.
        * css/FontFamilyValue.cpp:
        (WebCore::FontFamilyValue::FontFamilyValue): Replaced code using a regular
        expression with code that does the same thing more efficiently.
        (WebCore::FontFamilyValue::appendSpaceSeparated): Added.
        (WebCore::FontFamilyValue::cssText): Updated for name change.
        * css/FontFamilyValue.h: Changed DeprecatedString to String. Renamed fontName
        to familyName and parsedFontName to m_familyName. Removed unused genericFamilyType
        and m_genericFamilyType. Added appendSpaceSeparated so that m_familyName can
        be private instead of public.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago - fix build when SVG is not enabled
darin@apple.com [Wed, 20 Feb 2008 02:07:18 +0000 (02:07 +0000)]
    - fix build when SVG is not enabled

        * rendering/RenderTreeAsText.cpp: Added include of "TextStream.h".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
andersca@apple.com [Wed, 20 Feb 2008 01:55:42 +0000 (01:55 +0000)]
    Reviewed by Darin.

        Change all classes in xml/ to start out with a ref count of 1.

        * bindings/js/JSCustomXPathNSResolver.h:
        * bindings/js/JSXMLHttpRequest.cpp:
        (WebCore::JSXMLHttpRequest::JSXMLHttpRequest):
        * bindings/js/JSXSLTProcessor.cpp:
        (WebCore::JSXSLTProcessor::JSXSLTProcessor):
        * bindings/objc/DOMCustomXPathNSResolver.h:
        (WebCore::DOMCustomXPathNSResolver::create):
        * bindings/scripts/CodeGeneratorJS.pm:
        * bindings/scripts/CodeGeneratorObjC.pm:
        * dom/Document.cpp:
        (WebCore::Document::applyXSLTransform):
        (WebCore::Document::createExpression):
        (WebCore::Document::createNSResolver):
        (WebCore::Document::evaluate):
        * xml/DOMParser.h:
        (WebCore::DOMParser::create):
        (WebCore::DOMParser::DOMParser):
        * xml/NativeXPathNSResolver.h:
        (WebCore::NativeXPathNSResolver::create):
        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::XMLHttpRequest):
        * xml/XMLHttpRequest.h:
        (WebCore::XMLHttpRequest::create):
        * xml/XMLSerializer.h:
        (WebCore::XMLSerializer::create):
        (WebCore::XMLSerializer::XMLSerializer):
        * xml/XPathEvaluator.cpp:
        (WebCore::XPathEvaluator::createNSResolver):
        * xml/XPathEvaluator.h:
        (WebCore::XPathEvaluator::create):
        (WebCore::XPathEvaluator::XPathEvaluator):
        * xml/XPathExpression.cpp:
        (WebCore::XPathExpression::createExpression):
        (WebCore::XPathExpression::evaluate):
        * xml/XPathExpression.h:
        (WebCore::XPathExpression::create):
        (WebCore::XPathExpression::XPathExpression):
        * xml/XPathNSResolver.h:
        * xml/XPathResult.cpp:
        (WebCore::XPathResult::XPathResult):
        * xml/XPathResult.h:
        (WebCore::XPathResult::create):
        * xml/XPathValue.cpp:
        (WebCore::XPath::Value::modifiableNodeSet):
        * xml/XPathValue.h:
        (WebCore::XPath::ValueData::create):
        (WebCore::XPath::ValueData::ValueData):
        (WebCore::XPath::Value::Value):
        * xml/XSLTProcessor.h:
        (WebCore::XSLTProcessor::create):
        (WebCore::XSLTProcessor::XSLTProcessor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
darin@apple.com [Wed, 20 Feb 2008 01:51:41 +0000 (01:51 +0000)]
WebCore:

        Reviewed by Sam.

        - Trimmed down TextStream and weaned it from DeprecatedString.

        * page/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge renderTreeAsExternalRepresentation]):
        Removed now-unneeded call to getNSString.

        * platform/text/TextStream.cpp: Removed unused functions.
        Use snprintf instead of sprintf, for better security.
        (WebCore::TextStream::release): Added.
        * platform/text/TextStream.h: Removed lots of unneeded stuff.

        * rendering/RenderTreeAsText.cpp:
        (WebCore::externalRepresentation): Changed to use String instead
        of DeprecatedString.
        * rendering/RenderTreeAsText.h: Ditto.

        * rendering/SVGRenderTreeAsText.cpp:
        (WebCore::writeSVGInlineTextBox): Use "\n" instead of endl.
        (WebCore::write): Ditto.
        (WebCore::writeRenderResources): Ditto.

WebKit/win:

        Reviewed by Sam.

        * WebFrame.cpp:
        (WebFrame::renderTreeAsExternalRepresentation): Changed to use String instead
        of DeprecatedString.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin Adler.
justin.garcia@apple.com [Wed, 20 Feb 2008 01:43:50 +0000 (01:43 +0000)]
    Reviewed by Darin Adler.

        <rdar://problem/5694920> Typing (esp. deleting) is slower due to TOT WebCore changes

        This brings performance on the phone back to old levels.  Andre and I are doing
        some formal testing to see exactly where we stand.

        * dom/Position.cpp:
        (WebCore::enclosingBlockIgnoringEditability): Added.  This is enclosingBlock
        without the expensive editability checks. upstream and downstream can avoid
        those because they do their own editability checking.
        (WebCore::Position::upstream):
        (WebCore::Position::downstream):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
harrison@apple.com [Wed, 20 Feb 2008 00:41:46 +0000 (00:41 +0000)]
    Reviewed by Darin.

        <rdar://problem/3663560> AXLink for a "name" (anchor) on same page should include an AXLinkedUIElementAttribute

        * bridge/mac/WebCoreAXObject.mm:
        (-[WebCoreAXObject linkedUIElement]):
        Returns the linked-to AX object (if the specified one is ignored by accessibility, returns the next un-ignored one by traversing the DOM).

        (-[WebCoreAXObject accessibilityAttributeNames]):
        (-[WebCoreAXObject accessibilityAttributeValue:]):
        Support NSAccessibilityLinkedUIElementsAttribute.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Sam.
darin@apple.com [Wed, 20 Feb 2008 00:00:27 +0000 (00:00 +0000)]
    Reviewed by Sam.

        - Removed old debugging aids, Node::dump, RenderObject::dump, and
          RenderObject::information, that used DeprecatedString.

        * dom/CharacterData.cpp: Removed override of Node::dump.
        * dom/CharacterData.h: Ditto.
        * dom/Element.cpp: Ditto.
        * dom/Element.h: Ditto.
        * dom/EventTargetNode.cpp: Ditto.
        * dom/EventTargetNode.h: Ditto.
        * dom/Node.cpp: Removed Node::dump.
        * dom/Node.h: Ditto.

        * rendering/RenderBlock.cpp: Removed override of RenderObject::dump.
        * rendering/RenderBlock.h: Ditto.
        * rendering/RenderFrameSet.cpp: Ditto.
        * rendering/RenderFrameSet.h: Ditto.
        * rendering/RenderObject.cpp: Removed RenderObject::dump and
        RenderObject::information.
        * rendering/RenderObject.h: Ditto.
        * rendering/RenderTable.cpp: Removed override of RenderObject::dump.
        * rendering/RenderTable.h: Ditto.
        * rendering/RenderTableCell.cpp: Ditto.
        * rendering/RenderTableCell.h: Ditto.
        * rendering/RenderTableCol.cpp: Ditto.
        * rendering/RenderTableCol.h: Ditto.
        * rendering/RenderTableSection.cpp: Ditto.
        * rendering/RenderTableSection.h: Ditto.

        * rendering/RenderTreeAsText.h: Removed unneeded include of TextStream.h
        and added forward declarations as appropriate.

        * svg/SVGSVGElement.cpp: Removed unneeded include of TextStream.h.
        * svg/graphics/SVGResourceClipper.cpp: And here.
        * svg/graphics/SVGResourceFilter.cpp: Ditto.
        * svg/graphics/filters/SVGFEBlend.cpp: Ditto.
        * svg/graphics/filters/SVGFEComponentTransfer.cpp: Ditto.
        * svg/graphics/filters/SVGFEComposite.cpp: Ditto.
        * svg/graphics/filters/SVGFEDiffuseLighting.cpp: Ditto.
        * svg/graphics/filters/SVGFEGaussianBlur.cpp: Ditto.
        * svg/graphics/filters/SVGFEImage.cpp: Ditto.
        * svg/graphics/filters/SVGFEMerge.cpp: Ditto.
        * svg/graphics/filters/SVGFEMorphology.cpp: Ditto.
        * svg/graphics/filters/SVGFEOffset.cpp: Ditto.
        * svg/graphics/filters/SVGFESpecularLighting.cpp: Ditto.
        * svg/graphics/filters/SVGFETurbulence.cpp: Ditto.
        * svg/graphics/filters/SVGFilterEffect.cpp: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
bdakin@apple.com [Tue, 19 Feb 2008 23:26:47 +0000 (23:26 +0000)]
WebCore:

        Reviewed by Sam.

        Fix for <rdar://problem/5729674> Seed: Crash in
        RenderButton::setStyle at http://www.dinorpg.com

        Inputs should not honor first-letter.

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::updateFirstLetter):

LayoutTests:

        Reviewed by Sam.

        Test for <rdar://problem/5729674> Seed: Crash in
        RenderButton::setStyle at http://www.dinorpg.com

        * fast/forms/input-first-letter.html: Added.
        * platform/mac/fast/forms/input-first-letter-expected.checksum: Added.
        * platform/mac/fast/forms/input-first-letter-expected.png: Added.
        * platform/mac/fast/forms/input-first-letter-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
andersca@apple.com [Tue, 19 Feb 2008 22:09:48 +0000 (22:09 +0000)]
    Reviewed by Darin.

        Change OpaqueJSClass and RootObject to start with a ref count of 1.

        * API/JSClassRef.cpp:
        (OpaqueJSClass::OpaqueJSClass):
        (OpaqueJSClass::createNoAutomaticPrototype):
        (OpaqueJSClass::create):
        * API/JSClassRef.h:
        * API/JSObjectRef.cpp:
        (JSClassCreate):
        * bindings/runtime_root.cpp:
        (KJS::Bindings::RootObject::create):
        (KJS::Bindings::RootObject::RootObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
mitz@apple.com [Tue, 19 Feb 2008 21:13:19 +0000 (21:13 +0000)]
WebCore:

        Reviewed by Darin Adler.

        - fix <rdar://problem/5637569> CrashTracer: [REGRESSION] 620 crashes in Safari at com.apple.WebCore: WebCore::RenderBox::setStaticY + 15

        Test: fast/text/wbr-styled.html

        Changed RenderWordBreak to inherit from RenderText instead of
        RenderInline.

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::calcInlinePrefWidths):
        * rendering/RenderFlow.h:
        * rendering/RenderText.cpp:
        (WebCore::RenderText::renderName):
        (WebCore::RenderText::isTextFragment):
        (WebCore::RenderText::isWordBreak):
        * rendering/RenderText.h:
        * rendering/RenderWordBreak.cpp:
        (WebCore::RenderWordBreak::RenderWordBreak):
        * rendering/RenderWordBreak.h:
        * rendering/bidi.cpp:
        (WebCore::RenderBlock::findNextLineBreak):

LayoutTests:

        Reviewed by Darin Adler.

        - test for <rdar://problem/5637569> CrashTracer: [REGRESSION] 620 crashes in Safari at com.apple.WebCore: WebCore::RenderBox::setStaticY + 15

        * fast/text/wbr-styled.html: Added.
        * platform/mac-leopard/fast/text/wbr-styled-expected.checksum: Added.
        * platform/mac-leopard/fast/text/wbr-styled-expected.png: Added.
        * platform/mac/fast/css-generated-content/wbr-with-before-content-expected.txt:
        * platform/mac/fast/text/wbr-pre-expected.txt:
        * platform/mac/fast/text/wbr-styled-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix ChangeLog
andersca@apple.com [Tue, 19 Feb 2008 19:42:54 +0000 (19:42 +0000)]
Fix ChangeLog

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
andersca@apple.com [Tue, 19 Feb 2008 19:42:28 +0000 (19:42 +0000)]
WebCore:

        Reviewed by Darin.

        WARNING: NO TEST CASES ADDED OR CHANGED

        * ChangeLog:
        * WebCore.base.exp:
        * loader/mac/LoaderNSURLExtras.h:
        * loader/mac/LoaderNSURLExtras.m:
        Move unused functions to WebKit (where they are used)

        (vectorContainsString):
        Use const references.

        * platform/mac/WebCoreSystemInterface.h:
        * platform/mac/WebCoreSystemInterface.mm:
        Remove wkNSURLProtocolClassForReqest.

WebKit/mac:

        Reviewed by Darin.

        Move back WebKit methods that were unused in WebCore.

        * Misc/WebNSURLExtras.mm:
        (+[NSURL _web_URLWithData:]):
        (+[NSURL _web_URLWithData:relativeToURL:]):
        (-[NSURL _web_originalData]):
        (-[NSURL _web_originalDataAsString]):
        (-[NSURL _web_isEmpty]):
        (-[NSURL _webkit_canonicalize]):
        (-[NSURL _webkit_URLByRemovingComponent:]):
        (-[NSURL _webkit_URLByRemovingFragment]):
        (-[NSURL _webkit_URLByRemovingResourceSpecifier]):
        (-[NSURL _webkit_isFileURL]):
        (-[NSString _webkit_isFileURL]):
        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::setTitle):
        * WebCoreSupport/WebSystemInterface.m:
        (InitWebCoreSystemInterface):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin Adler.
justin.garcia@apple.com [Tue, 19 Feb 2008 19:28:05 +0000 (19:28 +0000)]
    Reviewed by Darin Adler.

        <rdar://problem/5694920> Typing (esp. deleting) is slower due to TOT WebCore

        These changes bring deleting performance back to old levels on the phone
        except for deleting the first space to the right of a word, which we are
        still working on.

        * dom/Position.cpp:
        (WebCore::Position::upstream): Avoid the use of enclosingBlock when determining
        if we have left the original enclosing block or entered a new one, and avoid
        rootEditableElement for determining if we have changed editability.  These
        operations are expensive.
        (WebCore::Position::downstream): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
darin@apple.com [Tue, 19 Feb 2008 19:16:42 +0000 (19:16 +0000)]
JavaScriptCore:

        Rubber stamped by Anders.

        - removed explicit initialization to 1 for RefCounted; that's now the default

        * kjs/regexp.cpp:
        (KJS::RegExp::RegExp): Removed RefCounted initializer.

WebCore:

        Rubber stamped by Anders.

        - removed explicit initialization to 1 for RefCounted; that's now the default

        * loader/ResourceLoader.cpp:
        (WebCore::ResourceLoader::ResourceLoader): Removed RefCounted initializer.
        * platform/network/ResourceHandle.cpp:
        (WebCore::ResourceHandle::ResourceHandle): Ditto.
        * platform/text/StringImpl.cpp:
        (WebCore::StringImpl::StringImpl): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Geoff
beidson@apple.com [Tue, 19 Feb 2008 19:08:38 +0000 (19:08 +0000)]
    Reviewed by Geoff

        Fixed a bug in DRT --threaded mode

        * DumpRenderTree/pthreads/JavaScriptThreadingPthreads.cpp:
        (startJavaScriptThreads): Don't detach the newly created thread.  The later call to stopJavaScriptThreads() tries
          to pthread_join() each thread that had been created, but you can't join a detached thread!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Anders.
darin@apple.com [Tue, 19 Feb 2008 19:06:07 +0000 (19:06 +0000)]
    Reviewed by Anders.

        - next step for http://bugs.webkit.org/show_bug.cgi?id=17257
          start ref counts at 1 instead of 0 for speed

        * wtf/RefCounted.h:
        (WTF::RefCounted::RefCounted): Have refcounts default to 1. This allows us to start
        removing the explicit initialization of RefCounted from classes and eventually we
        can remove the ability to have the initial count of 0 entirely.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
andersca@apple.com [Tue, 19 Feb 2008 18:25:56 +0000 (18:25 +0000)]
    Reviewed by Darin.

        Make ResourceLoader and ResourceHandle start out with a refcount of 1.

        * loader/MainResourceLoader.cpp:
        (WebCore::MainResourceLoader::create):
        * loader/NetscapePlugInStreamLoader.cpp:
        (WebCore::NetscapePlugInStreamLoader::create):
        * loader/ResourceLoader.cpp:
        (WebCore::ResourceLoader::ResourceLoader):
        * loader/SubresourceLoader.cpp:
        (WebCore::SubresourceLoader::create):
        * platform/network/ResourceHandle.cpp:
        (WebCore::ResourceHandle::ResourceHandle):
        (WebCore::ResourceHandle::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-02-19 Alp Toker <alp@atoker.com>
alp@webkit.org [Tue, 19 Feb 2008 13:05:03 +0000 (13:05 +0000)]
2008-02-19  Alp Toker  <alp@atoker.com>

        Reviewed by Mark Rowe.

        http://bugs.webkit.org/show_bug.cgi?id=16863
        [GTK] tab focusing doesn't work

        GDK_MOD2_MASK doesn't always mean meta so we can't use it to identify
        the meta key state.

        Use GDK_META_MASK where available, otherwise do not support the meta
        key. This matches the behaviour of other applications.

        Also add a comment noting that the platform event constructors need to
        be kept in sync (it's not obvious that there are multiple places that
        check the key state).

        * platform/gtk/KeyEventGtk.cpp:
        (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
        * platform/gtk/MouseEventGtk.cpp:
        (WebCore::PlatformMouseEvent::PlatformMouseEvent):
        * platform/gtk/WheelEventGtk.cpp:
        (WebCore::PlatformWheelEvent::PlatformWheelEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Sam Weinig's white rhino tusk stamp
beidson@apple.com [Tue, 19 Feb 2008 07:17:18 +0000 (07:17 +0000)]
    Reviewed by Sam Weinig's white rhino tusk stamp

        SQLiteTransaction::stop() should also reset the transaction-in-progress flag in its parent SQLiteDatabase

        * platform/sql/SQLiteTransaction.cpp:
        (WebCore::SQLiteTransaction::stop):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Sam Weinig's rubberstamp
beidson@apple.com [Tue, 19 Feb 2008 07:15:55 +0000 (07:15 +0000)]
    Reviewed by Sam Weinig's rubberstamp

        SQLiteTransaction::stop() should also reset the transaction-in-progress flag in its parent SQLiteDatabase

        * platform/sql/SQLiteTransaction.cpp:
        (WebCore::SQLiteTransaction::stop):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Make Drosera work on Vista.
sfalken@apple.com [Tue, 19 Feb 2008 07:03:32 +0000 (07:03 +0000)]
    Make Drosera work on Vista.

        Runtime type library registration on Vista requires use of two new call:
        RegisterTypeLibraryForUser and UnRegisterTypeLibraryForUser, which write to
        HKCU.  LoadTypeLib[Ex] registers under HKLM, which fails under vista due to UAC.

        Reviewed by Adam.

        * WebKitDLL.cpp:
        (DllUnregisterServer): Call UnRegisterTypeLibraryForUser if available. Fix version number.
        (DllRegisterServer): Call RegisterTypeLibraryForUser if available.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adam Roben in California.
mitz@apple.com [Tue, 19 Feb 2008 06:24:13 +0000 (06:24 +0000)]
    Reviewed by Adam Roben in California.

        - remove unnecessary and erroneous layoutTestController calls from a test

        * fast/css/font-face-multiple-remote-sources.html:
        * platform/mac/fast/css/font-face-multiple-remote-sources-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
beidson@apple.com [Tue, 19 Feb 2008 05:19:04 +0000 (05:19 +0000)]
WebCore:

        Reviewed by Darin

        Fix for <rdar://5747529> - ObjC Exception can cause JSLock to never be released

        Test: platform/mac/plugins/webScriptObject-exception-deadlock.html

        * bindings/objc/WebScriptObject.mm:
        (-[WebScriptObject valueForKey:]): The line `resultObj = [super valueForKey:key];    // defaults to throwing an exception`
          says it all - it throws an exception.  This method also happens to hold the JSLock.  Problematically, when the exeception
          is thrown and the method exited, the JSLock is never released.  Fix that without otherwise changing behavior by holding the
          JSLock in two individual scopes - Right before the exception and right after.

WebKitTools:

        Changes by Geoff Garen, Reviewed by Darin

        Fix for <rdar://5747529> - ObjC Exception can cause JSLock to never be released

        DRT changes for test: platform/mac/plugins/webScriptObject-exception-deadlock.html

        [WebScriptObject valueForKey:] might throw an exception, and previously might have "leaked" the global JSLock
        This test calls valueForKey, then runs some arbitrary Javascript on a 2ndary thread.  If the lock has leaked,
        this series of method calls will deadlock.  If things are good, it will complete successfully.

        * DumpRenderTree/mac/ObjCController.m:
        (runJavaScriptThread):
        (+[ObjCController isSelectorExcludedFromWebScript:]):
        (+[ObjCController webScriptNameForSelector:]):
        (-[ObjCController testValueForKey]):

LayoutTests:

        Reviewed by Darin

        Fix for <rdar://5747529> - ObjC Exception can cause JSLock to never be released

        * platform/mac-tiger/Skipped: Removed 2 hanging tests that now don't hang
        * platform/mac/plugins/webScriptObject-exception-deadlock-expected.txt: Added.
        * platform/mac/plugins/webScriptObject-exception-deadlock.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoRemove FindSafari's Release configuration.
pewtermoose@webkit.org [Tue, 19 Feb 2008 04:07:10 +0000 (04:07 +0000)]
Remove FindSafari's Release configuration.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
darin@apple.com [Tue, 19 Feb 2008 02:21:07 +0000 (02:21 +0000)]
WebCore:

        Reviewed by Sam.

        - reduce use of DeprecatedString and memory allocations in processing of CSS
        - remove unnecessary double -> float -> double trip in the CSS parser
        - cleaned up names and structure in CSS grammar

        * css/CSSGrammar.y: Remove getPropertyID and getValueID. Both are now in CSSParser.cpp
        instead, and they now work on ParseString and String objects and don't require the caller
        to put the string into a char*. Gave members of the %union more sensible names, removed
        duplicates, and sorted into a logical order. Put the %expect back in, rather than leaving
        it commented out.
        * css/CSSParser.cpp:
        (WebCore::equalIgnoringCase): Added.
        (WebCore::hasPrefix): Added.
        (WebCore::CSSParser::parseTransitionProperty): Changed to call the new cssPropertyID,
        which obviates the need to call lower() and utf8() or to allocate memory at all. Also
        used equalIgnoringCase rather than putting the value into a String just to compare it.
        (WebCore::CSSParser::lex): Replaced convertASCIIToFloat with charactersToDouble. This change
        along with the CSSGrammar.y change, removes the double -> float -> double round trip, and
        affects the result of one layout test.
        (WebCore::cssPropertyID): Added. Gets the property ID from the gperf hash table, but
        without allocating any memory.
        (WebCore::cssValueKeywordID): Ditto.
        * css/CSSParser.h: Removed declaration for deprecatedString function (now used only in
        CSSParser.cpp; soon to be deleted). Added cssPropertyID and cssValueKeywordID functions.

        * css/CSSStyleDeclaration.cpp:
        (WebCore::CSSStyleDeclaration::getPropertyCSSValue): Call cssPropertyID instead of propertyID.
        (WebCore::CSSStyleDeclaration::getPropertyValue): Ditto.
        (WebCore::CSSStyleDeclaration::getPropertyPriority): Ditto.
        (WebCore::CSSStyleDeclaration::getPropertyShorthand): Ditto.
        (WebCore::CSSStyleDeclaration::isPropertyImplicit): Ditto.
        (WebCore::CSSStyleDeclaration::setProperty): Ditto.
        (WebCore::CSSStyleDeclaration::removeProperty): Ditto.
        (WebCore::CSSStyleDeclaration::isPropertyName): Ditto.
        * css/CSSStyleDeclaration.h: Removed unnecessary includes, unnecessary Noncopyable boilerplate,
        and the getPropertyID function declaration along with its associated apology comment.

        * css/makevalues.pl: Generate constants instead of macros for CSS value numbers (but not an
        enumeration, like properties, since you rarely have any reason to handle all values, but
        often have a reason to handle all properties). Renamed the constant for the number of CSS
        value keywords from CSS_VAL_TOTAL to numCSSValueKeywords, and added maxCSSValueKeywordLength.

        * platform/text/String.cpp:
        (WebCore::charactersToDouble): Made this function more efficient by using a stack buffer
        rather than a CString.

LayoutTests:

        Reviewed by Sam.

        - generate new results for the one test that was altered by the
          double -> float -> double trip taken by numeric values in the
          CSS parser

        This test appears under three different names in three different
        parts of our test suite.

        * platform/mac/css1/box_properties/acid_test-expected.checksum: Updated.
        * platform/mac/css1/box_properties/acid_test-expected.png: Ditto.
        * platform/mac/css1/box_properties/acid_test-expected.txt: Ditto.
        * platform/mac/css2.1/t09-c5526c-display-00-e-expected.checksum: Ditto.
        * platform/mac/css2.1/t09-c5526c-display-00-e-expected.png: Ditto.
        * platform/mac/css2.1/t09-c5526c-display-00-e-expected.txt: Ditto.
        * platform/mac/fast/block/basic/011-expected.checksum: Ditto.
        * platform/mac/fast/block/basic/011-expected.png: Ditto.
        * platform/mac/fast/block/basic/011-expected.txt: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
mitz@apple.com [Tue, 19 Feb 2008 02:13:55 +0000 (02:13 +0000)]
WebCore:

        Reviewed by Dave Hyatt.

        - fix <rdar://problem/5736225> crash in svgFontAndFaceElementForFontData on digitalstrom.org/cms

        Test: fast/css/font-face-multiple-remote-sources.html

        * css/CSSFontFace.cpp:
        (WebCore::CSSFontFace::fontLoaded):
        * css/CSSSegmentedFontFace.cpp:
        (WebCore::CSSSegmentedFontFace::fontLoaded):

LayoutTests:

        - test for <rdar://problem/5736225> crash in svgFontAndFaceElementForFontData on digitalstrom.org/cms

        * fast/css/font-face-multiple-remote-sources.html: Added.
        * platform/mac/fast/css/font-face-multiple-remote-sources-expected.checksum: Added.
        * platform/mac/fast/css/font-face-multiple-remote-sources-expected.png: Added.
        * platform/mac/fast/css/font-face-multiple-remote-sources-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Sam.
darin@apple.com [Tue, 19 Feb 2008 01:12:12 +0000 (01:12 +0000)]
    Reviewed by Sam.

        * bindings/js/JSCSSStyleDeclarationCustom.cpp:
        (WebCore::hasCSSPropertyNamePrefix): Added.
        (WebCore::cssPropertyName): Reimplement to not use DeprecatedString. Also made faster
        by using a Vector<UChar> and eliminating all the string operations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Sam.
darin@apple.com [Tue, 19 Feb 2008 00:54:41 +0000 (00:54 +0000)]
    Reviewed by Sam.

        * Misc/WebNSAttributedStringExtras.mm:
        (+[NSAttributedString _web_attributedStringFromRange:]): Eliminate use of
        DeprecatedString.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-02-18 Stephanie Lewis <slewis@apple.com>
slewis@apple.com [Tue, 19 Feb 2008 00:48:54 +0000 (00:48 +0000)]
2008-02-18  Stephanie Lewis  <slewis@apple.com>

        Reviewed by Adam.

Remove workaround for <rdar://problem/5695848>.

        * platform/network/cf/ResourceResponseCFNet.cpp:
        (WebCore::ResourceResponse::doUpdateResourceResponse):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Sam.
darin@apple.com [Tue, 19 Feb 2008 00:48:06 +0000 (00:48 +0000)]
    Reviewed by Sam.

        * Api/qwebnetworkinterface.cpp:
        (QWebNetworkRequestPrivate::init): Removed use of DeprecatedString.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
weinig@apple.com [Tue, 19 Feb 2008 00:25:26 +0000 (00:25 +0000)]
JavaScriptCore:

        Reviewed by Geoff Garen.

        Fix for http://bugs.webkit.org/show_bug.cgi?id=17419
        Remove CompatMode from JavaScriptCore as it is never set to anything other than NativeMode

        * kjs/JSGlobalObject.cpp:
        (KJS::JSGlobalObject::init):
        * kjs/JSGlobalObject.h:
        (KJS::JSGlobalObject::setDebugger):
        * kjs/date_object.cpp:
        (KJS::dateProtoFuncGetYear):

WebCore:

        Reviewed by Geoff Garen.

        Fix for http://bugs.webkit.org/show_bug.cgi?id=17419
        Remove CompatMode from JavaScriptCore as it is never set to anything other than NativeMode

        * bindings/js/kjs_proxy.cpp:
        (WebCore::KJSProxy::initScript):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-02-18 Alp Toker <alp@atoker.com>
alp@webkit.org [Mon, 18 Feb 2008 23:04:37 +0000 (23:04 +0000)]
2008-02-18  Alp Toker  <alp@atoker.com>

        Reviewed by Mark Rowe.

        http://bugs.webkit.org/show_bug.cgi?id=17381
        [CURL] Regression: data URL parsing broken after DeprecatedString removal (Acid2)

        This patch resolves the regression for the GTK+ port.

        * platform/network/curl/ResourceHandleManager.cpp:
        (WebCore::parseDataUrl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-02-18 Alp Toker <alp@atoker.com>
alp@webkit.org [Mon, 18 Feb 2008 23:03:57 +0000 (23:03 +0000)]
2008-02-18  Alp Toker  <alp@atoker.com>

        Reviewed by Mark Rowe.

        http://bugs.webkit.org/show_bug.cgi?id=17312
        [GTK] Webview Transparent Background

        Add support for WebView background transparency.

        * webkit/webkitprivate.h:
        * webkit/webkitwebview.cpp:
        * webkit/webkitwebview.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-02-18 Alp Toker <alp@atoker.com>
alp@webkit.org [Mon, 18 Feb 2008 23:03:29 +0000 (23:03 +0000)]
2008-02-18  Alp Toker  <alp@atoker.com>

        Reviewed by Mark Rowe.

        Implement webkit_web_view_get_focused_frame()

        Equivalent to selectedFrame in the Mac API.

        * webkit/webkitwebview.cpp:
        * webkit/webkitwebview.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Sam.
darin@apple.com [Mon, 18 Feb 2008 21:43:58 +0000 (21:43 +0000)]
    Reviewed by Sam.

        * platform/network/win/ResourceHandleWin.cpp:
        (WebCore::ResourceHandle::onHandleCreated): Use String instead of DeprecatedString.
        (WebCore::ResourceHandle::start): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Sam.
darin@apple.com [Mon, 18 Feb 2008 21:42:33 +0000 (21:42 +0000)]
    Reviewed by Sam.

        * platform/network/win/CookieJarWin.cpp:
        (WebCore::setCookies): Use String instead of DeprecatedString.
        (WebCore::cookies): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Sam.
darin@apple.com [Mon, 18 Feb 2008 21:40:47 +0000 (21:40 +0000)]
    Reviewed by Sam.

        - removed use of DeprecatedString in the Color class

        * platform/graphics/Color.cpp:
        (WebCore::Color::parseHexColor): Streamlined logic a bit with early returns.
        Used toASCIIHexValue a character at a time rather than using toIntStrict
        in base 16 mode.
        (WebCore::findNamedColor): Added. Uses a fixed-size char buffer to look up
        a color using the gperf-generated findColor function. Saves a memory allocation
        vs. the old version that called DeprecatedString::latin1().
        (WebCore::Color::setNamedColor): Changed to use findNamedColor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Sam.
darin@apple.com [Mon, 18 Feb 2008 21:28:21 +0000 (21:28 +0000)]
    Reviewed by Sam.

        * wtf/ASCIICType.h:
        (WTF::toASCIIHexValue): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Sam.
darin@apple.com [Mon, 18 Feb 2008 21:20:32 +0000 (21:20 +0000)]
    Reviewed by Sam.

        * editing/htmlediting.cpp:
        (WebCore::stringWithRebalancedWhitespace): Changed to use String instead of
        DeprecatedString.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Sam.
darin@apple.com [Mon, 18 Feb 2008 21:16:19 +0000 (21:16 +0000)]
    Reviewed by Sam.

        * editing/SelectionController.cpp:
        (WebCore::SelectionController::debugRenderer): Changed to use String instead of
        DeprecatedString.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed and landed by Sam.
weinig@apple.com [Mon, 18 Feb 2008 20:13:06 +0000 (20:13 +0000)]
    Reviewed and landed by Sam.

        Remove DeprecatedStringList.

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * editing/markup.cpp:
        * platform/DeprecatedStringList.cpp: Removed.
        * platform/DeprecatedStringList.h: Removed.
        * platform/mac/DeprecatedStringListMac.mm: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Sam.
darin@apple.com [Mon, 18 Feb 2008 19:49:52 +0000 (19:49 +0000)]
    Reviewed by Sam.

        * css/CSSPrimitiveValueMappings.h: Add default cases to all the switch statements.
        This will ease the way some day if we decide to use an enum instead of int; otherwise
        we'll have a ton of "unhandled enum value" warnings here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-02-18 Alp Toker <alp@atoker.com>
alp@webkit.org [Mon, 18 Feb 2008 19:21:05 +0000 (19:21 +0000)]
2008-02-18  Alp Toker  <alp@atoker.com>

        Build fix for GTK+ < 2.10. Fall back to simple text clipboard copy
        with older GTK+ versions for now.

        * platform/gtk/PasteboardGtk.cpp:
        (WebCore::Pasteboard::writeSelection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Sam.
darin@apple.com [Mon, 18 Feb 2008 18:59:10 +0000 (18:59 +0000)]
    Reviewed by Sam.

        * WebCore.base.exp: Export a couple of WebCore::String functions we plan to use
        in the future in WebKit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Sam.
darin@apple.com [Mon, 18 Feb 2008 18:58:02 +0000 (18:58 +0000)]
    Reviewed by Sam.

        * DerivedSources.make: Added the scripts to the ENABLE_SVG versions of the rules
        for CSSPropertyNames.h and CSSValueKeywords.h. Somehow that got left out, so the
        files would not be regenerated if the scripts were changed (but would if SVG was
        disabled).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Suggested by Darin.
ap@webkit.org [Mon, 18 Feb 2008 18:41:09 +0000 (18:41 +0000)]
    Suggested by Darin.

        * platform/KURL.h: (WebCore::KURL::operator const String&): Added, to avoid unexpected
        conversion via UString (as in bug 17418).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-02-18 Jon Honeycutt <jhoneycutt@apple.com>
jhoneycutt@apple.com [Mon, 18 Feb 2008 18:23:33 +0000 (18:23 +0000)]
2008-02-18  Jon Honeycutt  <jhoneycutt@apple.com>

        Reviewed by Darin.

        <rdar://problem/5744899> Crash in Flash when clicking "Yes" to abort
        slow script Flash 9 dialog at http://www.kidzui.com

        When navigating to a new page, we stop all outstanding PluginStreams.
        Flash hangs in the call to NPP_URLNotify. It eventually displays the
        "slow script" dialog, which relinquishes control to the system. While
        this dialog is running, the request we are in the process of cancelling
        completes, and we re-enter Flash to deliver the data. When the dialog
        is dismissed, the internal state of Flash has changed, and Flash
        crashes with a null dereference.

        To work around this, we can defer loading before entering plug-in code,
        so that even if a plug-in yields to the system, we won't get callbacks
        while we're handling a callback.

        * plugins/PluginStream.cpp:
        (WebCore::PluginStream::startStream): Defers loads while calling into
        plug-in.
        (WebCore::PluginStream::destroyStream): Same.
        (WebCore::PluginStream::deliverData): Same.
        (WebCore::PluginStream::didFail): Protect 'this' from deletion by
        destroyStream. Null out m_loader only after destroyStream returns.
        (WebCore::PluginStream::didFinishLoading): Same.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
ap@webkit.org [Mon, 18 Feb 2008 18:14:41 +0000 (18:14 +0000)]
    Reviewed by Darin.

        http://bugs.webkit.org/show_bug.cgi?id=17418
        REGRESSION: Assertion failure dragging image (JSLock::lockCount() > 0)

        * platform/win/ClipboardWin.cpp:
        (WebCore::ClipboardWin::declareAndWriteDragImage): Explicitly convert from KURL to String,
        as an implicit conversion uses UString and thus needs a JSLock.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Roll out r30360.
weinig@apple.com [Mon, 18 Feb 2008 06:45:13 +0000 (06:45 +0000)]
    Roll out r30360.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::changeLocation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Mac build fix.
weinig@apple.com [Mon, 18 Feb 2008 06:25:04 +0000 (06:25 +0000)]
    Mac build fix.

        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-02-17 Alp Toker <alp@atoker.com>
alp@webkit.org [Mon, 18 Feb 2008 02:32:57 +0000 (02:32 +0000)]
2008-02-17  Alp Toker  <alp@atoker.com>

        Attempt to fix the Wx build (has been broken all weekend).

        Stub out some graphics functions.

        * platform/graphics/wx/GraphicsContextWx.cpp:
        (WebCore::GraphicsContext::beginPath):
        (WebCore::GraphicsContext::addPath):
        * platform/graphics/wx/PathWx.cpp:
        (WebCore::Path::isEmpty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-02-17 Julien Chaffraix <julien.chaffraix@gmail.com>
alp@webkit.org [Mon, 18 Feb 2008 02:02:56 +0000 (02:02 +0000)]
2008-02-17  Julien Chaffraix  <julien.chaffraix@gmail.com>

        Reviewed by Alexey Proskuryakov.

        http://bugs.webkit.org/show_bug.cgi?id=16989
        bug 16989 : Add send() flag checks in XmlHttpRequest

        - Splitted xmlhttprequest-abort-readystate in 2 test cases (xmlhttprequest-abort-readystate-shouldDispatchEvent and xmlhttprequest-abort-readystate-shouldNotDispatchEvent)

        - Added test case for the 2 send() flag checks in XmlHttpRequest::send and XmlHttpRequest::setRequestHeader

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
weinig@apple.com [Mon, 18 Feb 2008 00:22:21 +0000 (00:22 +0000)]
WebCore:

        Reviewed by Dan Bernstein.

        Fix for http://bugs.webkit.org/show_bug.cgi?id=17365
        document.createEvent("MessageEvent") throws NOT_SUPPORTED_ERR

        - Updated fast/events/event-instanceof.html to test document.createEvent("MessageEvent").

        * DerivedSources.make:
        Generate Objective-C binding for DOMProgressEvent which was missing.

        * WebCore.xcodeproj/project.pbxproj:
        Add missing DOMProgressEvent files to the project.

        * bindings/js/JSEventCustom.cpp:
        (WebCore::toJS):
        Clean up and add case for SVGZoomEvent that was missing.

        * bindings/objc/DOMEvents.mm:
        (+[DOMEvent _wrapEvent:WebCore::]):
        Clean up and add cases for ProgressEvent and MessageEvent that were missing.

        * dom/Document.cpp:
        (WebCore::Document::createEvent):
        Add case for MessageEvent.

WebKit/mac:

        Reviewed by Dan Bernstein.

        Fix for http://bugs.webkit.org/show_bug.cgi?id=17365
        document.createEvent("MessageEvent") throws NOT_SUPPORTED_ERR

        * MigrateHeaders.make: Migrate DOMProgressEvent.h and DOMTextPrivate.h which were
        mistakenly not migrated.

LayoutTests:

        Reviewed by Dan Bernstein.

        Update test for http://bugs.webkit.org/show_bug.cgi?id=17365
        document.createEvent("MessageEvent") throws NOT_SUPPORTED_ERR

        * fast/events/event-instanceof-expected.txt:
        * fast/events/resources/event-instanceof.js: Test MessageEvent as well.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-02-17 Adam Treat <treat@kde.org>
alp@webkit.org [Mon, 18 Feb 2008 00:14:43 +0000 (00:14 +0000)]
2008-02-17  Adam Treat  <treat@kde.org>

        Reviewed by Eric Seidel.

        http://bugs.webkit.org/show_bug.cgi?id=17008
        Meta refresh does not work with cache turned off

        Fix for issue noticed on http://adserver.vivox.com/2

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::changeLocation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-02-17 Alp Toker <alp@atoker.com>
alp@webkit.org [Sun, 17 Feb 2008 23:53:27 +0000 (23:53 +0000)]
2008-02-17  Alp Toker  <alp@atoker.com>

        Reviewed by Sam Weinig.

        Fix for change made in r30355. Issue noticed by İsmail Dönmez.

        Verify SSL certs by default, but allow checks to be disabled with an
        environment variable (WEBKIT_IGNORE_SSL_ERRORS) for now.

        * platform/network/curl/ResourceHandleManager.cpp:
        (WebCore::ResourceHandleManager::startJob):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago http://bugs.webkit.org/show_bug.cgi?id=17397
ap@webkit.org [Sun, 17 Feb 2008 20:21:32 +0000 (20:21 +0000)]
    bugs.webkit.org/show_bug.cgi?id=17397
        <rdar://problem/5748245> REGRESSION (r30236-30336): Cannot backspace/enter in forms on Windows

        * WebKit.vcproj/WebKit.vcproj: Add ENABLE_CROSS_DOCUMENT_MESSAGING definitions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Mark Rowe.
mitz@apple.com [Sun, 17 Feb 2008 19:28:26 +0000 (19:28 +0000)]
    Reviewed by Mark Rowe.

        - disable the non-ASCII parts of a test case for the ASCII code path
          because it is failing on the (Tiger) buildbots for an unrelated
          reason.

        * fast/text/fixed-pitch-control-characters.html:
        * platform/mac/fast/text/fixed-pitch-control-characters-expected.checksum:
        * platform/mac/fast/text/fixed-pitch-control-characters-expected.png:
        * platform/mac/fast/text/fixed-pitch-control-characters-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago * wtf/ListHashSet.h: (WTF::swap): Removed stray return statement.
darin@apple.com [Sun, 17 Feb 2008 17:59:10 +0000 (17:59 +0000)]
    * wtf/ListHashSet.h: (WTF::swap): Removed stray return statement.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-02-17 Bin Chen <binary.chen@gmail.com>
alp@webkit.org [Sun, 17 Feb 2008 15:36:49 +0000 (15:36 +0000)]
2008-02-17  Bin Chen  <binary.chen@gmail.com>

        Reviewed by Alp Toker.

        http://bugs.webkit.org/show_bug.cgi?id=17404
        Bug 17404: curl certification problem

        Disable SSL cert verification until we have a way of distributing
        certs and/or reporting SSL errors to the user.

        * platform/network/curl/ResourceHandleManager.cpp:
        (WebCore::ResourceHandleManager::startJob):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-02-17 Alp Toker <alp@atoker.com>
alp@webkit.org [Sun, 17 Feb 2008 15:09:51 +0000 (15:09 +0000)]
2008-02-17  Alp Toker  <alp@atoker.com>

        Reviewed by Mark Rowe.

        DevHelp fails to load local files; URL truncated by one character.

        Fix a file:// URL regression introduced in KURL.cpp r30243.

        * platform/KURL.cpp:
        (WebCore::KURL::KURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-02-17 Jan Michael Alonzo <jmalonzo@unpluggable.com>
mrowe@apple.com [Sun, 17 Feb 2008 12:12:54 +0000 (12:12 +0000)]
2008-02-17  Jan Michael Alonzo  <jmalonzo@unpluggable.com>

        Reviewed by Mark Rowe.

        Fix a crash introduced in changeset #29985 by moving the dereference to after
        the null check.

        * webkit/webkitwebhistoryitem.cpp:
        (_WebKitWebHistoryItemPrivate::webkit_web_history_item_new_with_core_item):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
mitz@apple.com [Sun, 17 Feb 2008 08:50:32 +0000 (08:50 +0000)]
WebCore:

        Reviewed by Darin Adler.

        - fix http://bugs.webkit.org/show_bug.cgi?id=17033
          <rdar://problem/5709315> REGRESSION: Really long <option> causes unnecessary page scroll bars to accommodate content

        Test: fast/forms/control-clip-overflow.html

        * rendering/RenderFlow.cpp:
        (WebCore::RenderFlow::lowestPosition): Account for control clipping.
        (WebCore::RenderFlow::rightmostPosition): Ditto.
        (WebCore::RenderFlow::leftmostPosition): Ditto.

LayoutTests:

        Reviewed by Darin Adler.

        - test for http://bugs.webkit.org/show_bug.cgi?id=17033
          <rdar://problem/5709315> REGRESSION: Really long <option> causes unnecessary page scroll bars to accommodate content

        * fast/forms/control-clip-overflow.html: Added.
        * platform/mac/fast/forms/control-clip-overflow-expected.checksum: Added.
        * platform/mac/fast/forms/control-clip-overflow-expected.png: Added.
        * platform/mac/fast/forms/control-clip-overflow-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoBug 17269: Deobfuscate CanvasRenderingContext2D.cpp
oliver@apple.com [Sun, 17 Feb 2008 05:48:19 +0000 (05:48 +0000)]
Bug 17269: Deobfuscate CanvasRenderingContext2D.cpp

Reviewed by Eric S

Use cross-platform code to determine the dirty rects for
fill and stroke operations

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin Adler.
weinig@apple.com [Sun, 17 Feb 2008 03:43:01 +0000 (03:43 +0000)]
    Reviewed by Darin Adler.

        Take another step in the direction of getting rid of DeprecatedString
        by moving all the to{NumericType} off of it.

        - Create free functions that take a UChar* buffer and length to do
          the string-to-number conversions.  This allows us to avoid two allocations
          if we don't already have a String and is consistent with the design we would
          like going forward.
        - Since the toInt (and family) functions on DeprecatedString were slightly
          different than the ones on String (they didn't allow trailing garbage),
          an extra set of 'Strict' toInt functions were added that have this behavior.

        * platform/graphics/Color.cpp:
        (WebCore::Color::parseHexColor):
        * platform/text/PlatformString.h:
        * platform/text/String.cpp:
        (WebCore::String::percentage):
        (WebCore::String::toIntStrict):
        (WebCore::String::toUIntStrict):
        (WebCore::String::toInt64Strict):
        (WebCore::String::toUInt64Strict):
        (WebCore::String::toUInt):
        (WebCore::String::toDouble):
        (WebCore::isCharacterAllowedInBase):
        (WebCore::toIntegralType):
        (WebCore::lengthOfCharactersAsInteger):
        (WebCore::charactersToIntStrict):
        (WebCore::charactersToUIntStrict):
        (WebCore::charactersToInt64Strict):
        (WebCore::charactersToUInt64Strict):
        (WebCore::charactersToInt):
        (WebCore::charactersToUInt):
        (WebCore::charactersToInt64):
        (WebCore::charactersToUInt64):
        (WebCore::charactersToDouble):
        (WebCore::charactersToFloat):
        * platform/text/StringImpl.cpp:
        (WebCore::parseLength):
        (WebCore::StringImpl::toIntStrict):
        (WebCore::StringImpl::toUIntStrict):
        (WebCore::StringImpl::toInt64Strict):
        (WebCore::StringImpl::toUInt64Strict):
        (WebCore::StringImpl::toInt):
        (WebCore::StringImpl::toUInt):
        (WebCore::StringImpl::toInt64):
        (WebCore::StringImpl::toUInt64):
        (WebCore::StringImpl::toDouble):
        (WebCore::StringImpl::toFloat):
        * platform/text/StringImpl.h:
        * svg/SVGAnimationElement.cpp:
        (WebCore::SVGAnimationElement::parseClockValue):
        * svg/SVGFETurbulenceElement.cpp:
        (WebCore::SVGFETurbulenceElement::parseMappedAttribute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
mitz@apple.com [Sun, 17 Feb 2008 03:08:37 +0000 (03:08 +0000)]
WebCore:

        Reviewed by Sam Weinig.

        - fix fixed-pitch font measurement of control characters that render
          as zero-width space

        Test: fast/text/fixed-pitch-control-characters.html

        * rendering/RenderText.cpp:
        (WebCore::RenderText::widthFromCache):

LayoutTests:

        Reviewed by Sam Weinig.

        - test fixed-pitch font measurement of control characters that render
          as zero-width space

        * fast/text/fixed-pitch-control-characters.html: Added.
        * platform/mac/fast/text/fixed-pitch-control-characters-expected.checksum: Added.
        * platform/mac/fast/text/fixed-pitch-control-characters-expected.png: Added.
        * platform/mac/fast/text/fixed-pitch-control-characters-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agowx build fix.
kevino@webkit.org [Sat, 16 Feb 2008 22:04:47 +0000 (22:04 +0000)]
wx build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago - disable some failing tests; someone can re-enable after fixing the problems...
darin@apple.com [Sat, 16 Feb 2008 17:41:39 +0000 (17:41 +0000)]
    - disable some failing tests; someone can re-enable after fixing the problems causing
          them to fail or generating new expected results

        http://bugs.webkit.org/show_bug.cgi?id=17391

        * fast/frames/iframe-scroll-page-up-down.html: Removed.
        * fast/frames/iframe-scroll-page-up-down.html-disabled: Copied from fast/frames/iframe-scroll-page-up-down.html.

        http://bugs.webkit.org/show_bug.cgi?id=17392

        * svg/batik/text/textBiDi.svg: Removed.
        * svg/batik/text/textBiDi.svg-disabled: Copied from svg/batik/text/textBiDi.svg.

        http://bugs.webkit.org/show_bug.cgi?id=17393

        * svg/custom/use-on-symbol-inside-pattern.svg: Removed.
        * svg/custom/use-on-symbol-inside-pattern.svg-disabled: Copied from svg/custom/use-on-symbol-inside-pattern.svg.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoClean up some old log entries.
darin@apple.com [Sat, 16 Feb 2008 17:35:14 +0000 (17:35 +0000)]
Clean up some old log entries.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-02-16 Jan Michael Alonzo <jmalonzo@unpluggable.com>
alp@webkit.org [Sat, 16 Feb 2008 11:09:38 +0000 (11:09 +0000)]
2008-02-16  Jan Michael Alonzo  <jmalonzo@unpluggable.com>

        Reviewed by Alp Toker.

        Cross document messaging GTK+/autotools build fix.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoBuild fix for Qt and Cairo builds
oliver@apple.com [Sat, 16 Feb 2008 06:44:46 +0000 (06:44 +0000)]
Build fix for Qt and Cairo builds

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoBug 17269: Deobfuscate CanvasRenderingContext2D.cpp
oliver@apple.com [Sat, 16 Feb 2008 06:00:20 +0000 (06:00 +0000)]
Bug 17269: Deobfuscate CanvasRenderingContext2D.cpp
Refactor CanvasRenderingContext2D::drawImage(HTMLCanvasElement) to remove evil ifdefs

Reviewed by Dan B.

Add logic draw(ImageBuffer*) method to GraphicsContext to handle
painting the source canvas content.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Rubber-stamped by Oliver Hunt.
mitz@apple.com [Sat, 16 Feb 2008 05:57:31 +0000 (05:57 +0000)]
    Rubber-stamped by Oliver Hunt.

        - skip a test for a Leopard-only NSHTTPURLResponse bug workaround

        * platform/mac-tiger/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoUsing GetNativeFontInfoDesc() to generate the hash value was leading to duplicate...
kevino@webkit.org [Sat, 16 Feb 2008 03:23:54 +0000 (03:23 +0000)]
Using GetNativeFontInfoDesc() to generate the hash value was leading to duplicate entries in the HashMap. Use the font object's pointer instead.

http://bugs.webkit.org/show_bug.cgi?id=17371

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago When parsing url we get from a CFURLRef, we need to null terminate
adachan@apple.com [Sat, 16 Feb 2008 02:51:34 +0000 (02:51 +0000)]
    When parsing url we get from a CFURLRef, we need to null terminate
        the string for the case when url ends with a '/'.

        Reviewed by Darin.

        * platform/cf/KURLCFNet.cpp:
        (WebCore::KURL::KURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Added 2 skipped tests
beidson@apple.com [Sat, 16 Feb 2008 02:02:30 +0000 (02:02 +0000)]
    Added 2 skipped tests

        * platform/mac-tiger/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
beidson@apple.com [Sat, 16 Feb 2008 00:51:38 +0000 (00:51 +0000)]
WebCore:

        Reviewed by Darin

        Fix for <rdar://problem/5727175> and <rdar://problem/5740495> - Database threads and callback scripts can run after
        a page has closed or loaded a new document

        Deciding to make the Database I/O semantic the same as loaders/XHR when a document is shut down, this patch implements
        a policy of shutting down the databases in a document at the same time.  This includes removing all pending transactions
        in a database, cutting off an queued statements in the current transaction, and preventing further callbacks from being
        made.

        No new layout tests with this patch as the current layout tests were catching this issue in a plethora of ways already
        (crashing, unexpected exceptions and output, etc)

        * dom/Document.cpp:
        (WebCore::Document::~Document): Don't actually stop the database thread here - it better have been stopped already.
          Add an assertion to that effect.
        (WebCore::Document::addOpenDatabase): Add a new database handle to this Document's open database set
        (WebCore::Document::removeOpenDatabase): Remove such a handle
        (WebCore::Document:: stopDatabases): Call "close" on all open Database handles for this document
        * dom/Document.h:

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::stopLoading): In addition to canceling all resource loads and XHRs, stop all database I/O

        * platform/MessageQueue.h:
        (WebCore::MessageQueue::killed):

        * platform/sql/SQLiteTransaction.cpp:
        (WebCore::SQLiteTransaction::stop): Added.  Explicit stop to cut off a transaction so it won't try anymore SQL activity
        * platform/sql/SQLiteTransaction.h:

        * storage/Database.cpp:
        (WebCore::Database::Database):
        (WebCore::Database::~Database):
        (WebCore::Database::markAsDeletedAndClose): Check if the thread has terminated before committing to waiting on the
          thread.
        (WebCore::Database::stop):  Stop this database, including all queued transactions and callbacks
        * storage/Database.h:
        (WebCore::Database::stopped):

        * storage/DatabaseThread.cpp:
        (WebCore::DatabaseThread::terminationRequested):
        * storage/DatabaseThread.h:

        * storage/SQLTransaction.cpp:
        (WebCore::SQLTransaction::executeSQL): Throw an exception if a new executeSQL comes in after a database is closed
        (WebCore::SQLTransaction::checkAndHandleClosedDatabase): Added.  Clears queued statements and clear the next step
          when the database has been closed since the last step/callback was run.  Also stops the current SQLite transaction,
          if any
        (WebCore::SQLTransaction::performNextStep):
        (WebCore::SQLTransaction::performPendingCallback):
        * storage/SQLTransaction.h:

LayoutTests:

        Reviewed by Darin

        Fix for <rdar://problem/5727175> and <rdar://problem/5740495> - Database threads and callback scripts can run after
        a page has closed or loaded a new document

        * storage/close-during-stress-test-expected.txt: Update results - this test contained output from a javascript callback
          that never should have taken place

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
adele@apple.com [Sat, 16 Feb 2008 00:44:56 +0000 (00:44 +0000)]
WebCore:

        Reviewed by Darin.

        Fix for <rdar://problem/5745072> REGRESSION (r29348): Shift + Tab does not change indent level on Google Docs

        The immediate cause of this bug was that we stopped sending keypress events for the tab key when it is used to advance focus.
        We had a special case for forward-tab in designMode, where the default behavior was to insert a tab key (or respect the keypress handler behavior).
        This change makes the shift-tab behavior match the forward-tab behavior.

        If the site had put their event handler (which does the indenting) on the keydown event, then this problem would have been avoided.
        This is something we should look into and maybe advise the site on in the future.  However, it's a low-risk change to just make tab and shift-tab uniform
        in this respect, so I think this is the way to go for right now.

        * page/EventHandler.cpp: (WebCore::EventHandler::defaultTabEventHandler):

LayoutTests:

        Reviewed by Darin.

        Updated test for <rdar://problem/5745072> REGRESSION (r29348): Shift + Tab does not change indent level on Google Docs

        * editing/inserting/typing-tab-designmode-expected.txt:
        * editing/inserting/typing-tab-designmode.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Alice.
andersca@apple.com [Fri, 15 Feb 2008 23:47:12 +0000 (23:47 +0000)]
    Reviewed by Alice.

        <rdar://problem/5738678>
        REGRESSION: "Loading" status remains when uploading file to .Mac iDisk via Safari

        Use the new CFNetwork functions for setting body parts.

        * platform/network/cf/FormDataStreamCFNet.cpp:
        (WebCore::setHTTPBody):
        (WebCore::httpBodyFromRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
ggaren@apple.com [Fri, 15 Feb 2008 23:39:14 +0000 (23:39 +0000)]
WebCore:

        Reviewed by Anders Carlsson.

        Fixed <rdar://problem/5725429> REGRESSION (r27898): Greenfield online
        surveys no longer work due to XMLHttpRequest exceptions

        Reverted some exception throwing code from r12194.

        To comply with the W3C draft spec, we used to throw an exception when
        trying to access responseText and responseXML at the wrong time, but
        that turned out to be a compatibility problem.

        Now, matching Firefox and previous versions of WebKit, we never throw
        an exception when accessing responseText or responseXML.

        See http://www.mail-archive.com/public-webapi@w3.org/msg02756.html.

        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::getResponseText):
        (WebCore::XMLHttpRequest::getResponseXML):

LayoutTests:

        Reviewed by Anders Carlsson.

        Fixed <rdar://problem/5725429> REGRESSION (r27898): Greenfield online
        surveys no longer work due to XMLHttpRequest exceptions

        Updated layout tests to expect an exception not to be thrown.

        * http/tests/xmlhttprequest/xmlhttprequest-responseText-exception.html:
        * http/tests/xmlhttprequest/xmlhttprequest-responseXML-exception.html:
        * http/tests/xmlhttprequest/zero-length-response-expected.txt:
        * http/tests/xmlhttprequest/zero-length-response-sync-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@30328 268f45cc-cd09-0410-ab3c-d52691b4dbfc