abarth@webkit.org [Mon, 23 Nov 2009 19:12:08 +0000 (19:12 +0000)]
2009-11-23 Adam Barth <abarth@webkit.org>
Reviewed by Dimitri Glazkov.
[V8] Don't crash when OOM in creating isolated world
https://bugs.webkit.org/show_bug.cgi?id=31805
We need to add some more null checks to avoid crashing. No new tests
because we don't have a good way to test out-of-memory bugs.
* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::evaluateInIsolatedWorld):
(WebCore::V8Proxy::evaluateInNewContext):
(WebCore::V8Proxy::setInjectedScriptContextDebugId):
* bindings/v8/V8Proxy.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51312
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bweinstein@apple.com [Mon, 23 Nov 2009 19:07:24 +0000 (19:07 +0000)]
Touch WebKit.idl to force a rebuild.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51311
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
krit@webkit.org [Mon, 23 Nov 2009 16:15:24 +0000 (16:15 +0000)]
2009-11-23 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
This is the implementation of the filterRes attribute. It
helps the SVG developer to set the quality of a filter by
giving the width or height of filter.
This patch also sets the filter resolution to lower values
if a intermediate ImageBuffer size is bigger than the given
maximal size.
The maximal size is set to 5000x5000 by default. This is a
subjectiv decission. Everthing greater than this values gets
sensible slower. Values of 10000x10000 crashed on WebKitGtk.
For mobil devices a maximum size of 100x100 or 200x200 seems
to be reasonable.
The important fact on filter resolution is, that the output
size is still the size given by the <filter> element.
Tests: svg/filters/big-sized-filter-2.svg
svg/filters/big-sized-filter.svg
svg/filters/filterRes.svg
* platform/graphics/FloatRect.cpp:
(WebCore::FloatRect::scale): Add the abbility to scale a rect by x and y.
* platform/graphics/FloatRect.h:
(WebCore::FloatRect::scale): Add the abbility to scale a rect by x and y.
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::createPlatformShadow): Use scaledSubRegion for
calculation.
* platform/graphics/filters/FEBlend.cpp:
(WebCore::FEBlend::apply): Use scaledSubRegion for effect intern calculations.
* platform/graphics/filters/FEColorMatrix.cpp:
(WebCore::FEColorMatrix::apply): Use scaledSubRegion for effect intern calculations.
* platform/graphics/filters/FEComponentTransfer.cpp:
(WebCore::FEComponentTransfer::apply): Use scaledSubRegion for effect intern
calculations.
* platform/graphics/filters/FEComposite.cpp:
(WebCore::FEComposite::apply): Use scaledSubRegion for effect intern calculations.
* platform/graphics/filters/FEGaussianBlur.cpp:
(WebCore::FEGaussianBlur::apply): Use scaledSubRegion for effect intern calculations.
* platform/graphics/filters/Filter.h: Add the abbility to change the quality
of a filter output.
(WebCore::Filter::filterResolution):
(WebCore::Filter::setFilterResolution):
(WebCore::Filter::calculateEffectSubRegion): Calculates the correct subRegion
as well as the scaledSubRegion. It also searches for the biggest effect size.
We have to change the filter resolution, if one intermediate ImageBuffer size
doesn't fit in the maximal image size.
* platform/graphics/filters/FilterEffect.cpp:
(WebCore::FilterEffect::calculateDrawingIntRect): Use scaledSubRegion to get
the right part of a previous effect result.
(WebCore::FilterEffect::calculateDrawingRect): Use scaledSubRegion to get
the right part of a previous effect result.
(WebCore::FilterEffect::getEffectContext): Use scaledSubRegion to create
a new intermediate ImageBuffer for the result of the current effect.
* platform/graphics/filters/FilterEffect.h:
(WebCore::FilterEffect::scaledSubRegion): The scaled subRegion of a the
filter effect.
(WebCore::FilterEffect::setScaledSubRegion):
(WebCore::FilterEffect::effectBoundaries): The original values of the
EffectElement for a second subRegion calculation.
(WebCore::FilterEffect::setEffectBoundaries):
* platform/graphics/filters/ImageBufferFilter.cpp:
(WebCore::ImageBufferFilter::ImageBufferFilter): Set the scale factor to one.
* platform/graphics/filters/ImageBufferFilter.h:
(WebCore::ImageBufferFilter::maxImageSize):
(WebCore::ImageBufferFilter::calculateEffectSubRegion):
* platform/graphics/filters/SourceAlpha.cpp:
(WebCore::SourceAlpha::calculateEffectRect): Use scaledSubRegion for effect
intern calculations.
* platform/graphics/filters/SourceGraphic.cpp:
(WebCore::SourceGraphic::calculateEffectRect): Use scaledSubRegion for effect
intern calculations.
* svg/SVGFilterElement.cpp:
(WebCore::SVGFilterElement::parseMappedAttribute): Parse filterRes attribute.
(WebCore::SVGFilterElement::buildFilter): Give SVGResourceFilter the current
filterResolution.
* svg/SVGFilterPrimitiveStandardAttributes.cpp:
(WebCore::SVGFilterPrimitiveStandardAttributes::setStandardAttributes): Save
values to effectBoundaries of the filter effect
* svg/graphics/SVGResourceFilter.cpp:
(WebCore::SVGResourceFilter::SVGResourceFilter):
(WebCore::shouldProcessFilter): Return signal if a neccessary value is zero.
(WebCore::SVGResourceFilter::fitsInMaximumImageSize): Checks if the given size
fits into the maximal image size, modifys scale factors if not and return a
bool: fits.
(WebCore::SVGResourceFilter::prepareFilter): Scale the SourceImage to
filterResolution (given by FilterElement or calculated on to big image sizes).
Set the scale level to SVGFilter.
(WebCore::SVGResourceFilter::applyFilter): Don't apply filters if shouldProcessFilter
is wrong.
* svg/graphics/SVGResourceFilter.h:
(WebCore::SVGResourceFilter::setFilterResolution): FilterResolution of FilterElement.
(WebCore::SVGResourceFilter::setHasFilterResolution): Does FilterElement provides
a FilterResolution?
(WebCore::SVGResourceFilter::scaleX): Current scale factor for horizontal.
(WebCore::SVGResourceFilter::scaleY): Current scale factor for vertical.
* svg/graphics/filters/SVGFEDisplacementMap.cpp:
(WebCore::FEDisplacementMap::apply): Use scaledSubRegion for effect intern calculations.
Kernel values are scaled to current filter resolution too.
* svg/graphics/filters/SVGFEFlood.cpp:
(WebCore::FEFlood::apply): Use scaledSubRegion for effect intern calculations.
* svg/graphics/filters/SVGFEMerge.cpp:
(WebCore::FEMerge::apply): Use scaledSubRegion for effect intern calculations.
Kernel values are scaled to current filter resolution too.
* svg/graphics/filters/SVGFEMorphology.cpp:
(WebCore::FEMorphology::apply): Use scaledSubRegion for effect intern calculations.
Kernel values are scaled to current filter resolution too.
* svg/graphics/filters/SVGFEOffset.cpp:
(WebCore::FEOffset::apply): Use scaledSubRegion for effect intern calculations.
* svg/graphics/filters/SVGFETile.cpp:
(WebCore::FETile::apply): Use scaledSubRegion for effect intern calculations.
* svg/graphics/filters/SVGFilter.cpp:
(WebCore::SVGFilter::calculateEffectSubRegion): Calculate subRegion for LayoutTests,
scaledSubRegion according to the current filterResolution and get the maximal image size.
* svg/graphics/filters/SVGFilter.h:
(WebCore::SVGFilter::effectBoundingBoxMode): Original values of the FilterElement.
(WebCore::SVGFilter::filterRegion): Use virtual for clarification.
(WebCore::SVGFilter::sourceImageRect): Use virtual for clarification.
(WebCore::SVGFilter::maxImageSize): Get the maximal image size.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51310
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kdecker@apple.com [Mon, 23 Nov 2009 16:05:13 +0000 (16:05 +0000)]
Reviewed by Adam Roben.
<rdar://problem/
7401503>
Added a workaround for plug-ins not drawing immediately.
* Plugins/WebBaseNetscapePluginView.mm: Added new constant.
(-[WebBaseNetscapePluginView _clearSubstituteImage]): Added.
(-[WebBaseNetscapePluginView resumeFromHalt]): Call above new method.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51309
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Mon, 23 Nov 2009 15:17:19 +0000 (15:17 +0000)]
2009-11-23 David Boddie <dboddie@trolltech.com>
Reviewed by Simon Hausmann.
Updated the QWebElement documentation with links to examples and
external resources.
Fixed the project file for the webelement snippet and tidied up the
markers used for quoting the code.
* Api/qwebelement.cpp:
* docs/webkitsnippets/webelement/main.cpp:
(findAll):
* docs/webkitsnippets/webelement/webelement.pro:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51308
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Mon, 23 Nov 2009 13:02:13 +0000 (13:02 +0000)]
[Symbian] Fix lastIndexOf() for Symbian
https://bugs.webkit.org/show_bug.cgi?id=31773
Patch by Laszlo Gombos <laszlo.1.gombos@nokia.com> on 2009-11-23
Reviewed by Kenneth Rohde Christiansen.
Symbian soft floating point library has problems with operators
comparing NaN to numbers. Without a workaround lastIndexOf()
function does not work.
Patch developed by David Leong.
* runtime/StringPrototype.cpp:
(JSC::stringProtoFuncLastIndexOf):Add an extra test
to check for NaN for Symbian.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51307
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Mon, 23 Nov 2009 12:58:30 +0000 (12:58 +0000)]
2009-11-23 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Wrong runtime instance objects of wrapped QObjects may be used if
the wrapped object died before the gc removed the instance.
https://bugs.webkit.org/show_bug.cgi?id=31681
Before using a cached instance, verify that its wrapped QObject is
still alive.
* bridge/qt/qt_instance.cpp:
(JSC::Bindings::QtInstance::getQtInstance):
* bridge/qt/qt_instance.h:
(JSC::Bindings::QtInstance::hashKey):
2009-11-23 Simon Hausmann <simon.hausmann@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Wrong runtime instance objects of wrapped QObjects may be used if
the wrapped object died before the gc removed the instance.
https://bugs.webkit.org/show_bug.cgi?id=31681
Added a unit-test to verify that wrapping a QObject with the
same identity as a previously but now dead object works.
* tests/qwebframe/tst_qwebframe.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51306
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
steveblock@google.com [Mon, 23 Nov 2009 11:29:07 +0000 (11:29 +0000)]
Android port lacks implementation of atomicIncrement and atomicDecrement
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51305
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Mon, 23 Nov 2009 06:21:59 +0000 (06:21 +0000)]
2009-11-22 Chris Fleizach <cfleizach@apple.com>
Reviewed by Oliver Hunt.
ARIA: support aria-flowto
https://bugs.webkit.org/show_bug.cgi?id=31762
* platform/mac/accessibility/aria-flowto-expected.txt: Added.
* platform/mac/accessibility/aria-flowto.html: Added.
2009-11-22 Chris Fleizach <cfleizach@apple.com>
Reviewed by Oliver Hunt.
ARIA: support aria-flowto
https://bugs.webkit.org/show_bug.cgi?id=31762
Test: platform/mac/accessibility/aria-flowto.html
* accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::ariaOwnsElements):
(WebCore::AccessibilityObject::supportsARIAFlowTo):
(WebCore::AccessibilityObject::ariaFlowToElements):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::linkedUIElements):
(WebCore::AccessibilityRenderObject::supportsARIAFlowTo):
(WebCore::AccessibilityRenderObject::ariaFlowToElements):
* accessibility/AccessibilityRenderObject.h:
* html/HTMLAttributeNames.in:
2009-11-22 Chris Fleizach <cfleizach@apple.com>
Reviewed by Oliver Hunt.
ARIA: support aria-flowto
https://bugs.webkit.org/show_bug.cgi?id=31762
* DumpRenderTree/AccessibilityUIElement.cpp:
(ariaFlowToElementAtIndexCallback):
(AccessibilityUIElement::getJSClass):
* DumpRenderTree/AccessibilityUIElement.h:
* DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::ariaFlowToElementAtIndex):
* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::ariaFlowToElementAtIndex):
* DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::ariaFlowToElementAtIndex):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51304
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Mon, 23 Nov 2009 04:27:49 +0000 (04:27 +0000)]
Updated WebKitSystemInterface.
Reviewed by Eric Carlson.
* libWebKitSystemInterfaceLeopard.a:
* libWebKitSystemInterfaceSnowLeopard.a:
* libWebKitSystemInterfaceTiger.a:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51303
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
laszlo.1.gombos@nokia.com [Mon, 23 Nov 2009 03:45:25 +0000 (03:45 +0000)]
2009-11-22 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Unreviewed.
[Qt] Sort source lists and remove obsolete comments
from the build system.
* JavaScriptCore.pri:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51302
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Mon, 23 Nov 2009 01:33:53 +0000 (01:33 +0000)]
2009-11-22 Dirk Schulze <krit@webkit.org>
Reviewed by Nikolas Zimmermann.
Tests to the filterRes implementation for SVG Filters
[https://bugs.webkit.org/show_bug.cgi?id=6021]
big-sized-filter: tests if filter quality is scaled down on a too
big SourceImage (SourceGraphic, SourceAlpha)
big-sized-filter-2: tests if the filter quality is scaled down
on a too big filter effect size.
filterRes: Various tests of SVG Filters with different values for
filterRes attributes. Checks
* that kernel values (if present) are scaled with the filterRes
* subRegion calculation is correct for effects with deeper
dependencies.
* platform/mac/svg/filters/big-sized-filter-2-expected.txt: Added.
* platform/mac/svg/filters/big-sized-filter-expected.checksum: Added.
* platform/mac/svg/filters/big-sized-filter-expected.png: Added.
* platform/mac/svg/filters/big-sized-filter-expected.txt: Added.
* platform/mac/svg/filters/filterRes-expected.checksum: Added.
* platform/mac/svg/filters/filterRes-expected.png: Added.
* platform/mac/svg/filters/filterRes-expected.txt: Added.
* svg/filters/big-sized-filter-2.svg: Added.
* svg/filters/big-sized-filter.svg: Added.
* svg/filters/filterRes.svg: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51301
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zimmermann@webkit.org [Mon, 23 Nov 2009 01:29:07 +0000 (01:29 +0000)]
Not reviewed. Build fix for WML enabled builds.
Adopt WebCore API changes.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51300
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tonikitoo@webkit.org [Sun, 22 Nov 2009 23:14:58 +0000 (23:14 +0000)]
[Qt] fast/history/back-forward-reset-after-error-handling.html failing due to WorkQueue not being un-frozen
https://bugs.webkit.org/show_bug.cgi?id=31638
Reviewed by Kenneth Christiansen.
Unfreeze WorkQueue after each test execution.
* DumpRenderTree/qt/DumpRenderTree.cpp:
(WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51299
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Sun, 22 Nov 2009 22:29:10 +0000 (22:29 +0000)]
2009-11-22 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Adam Barth.
[Qt] DumpRenderTree should explicitly ignore any SSL certificate errors
for localhost and 127.0.0.1.
https://bugs.webkit.org/show_bug.cgi?id=31783
Unskip the http/tests/ssl/verify-ssl-enabled.php test, which is passing now.
* platform/qt/Skipped:
2009-11-22 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Adam Barth.
[Qt] DumpRenderTree should explicitly ignore any SSL certificate errors
for localhost and 127.0.0.1.
https://bugs.webkit.org/show_bug.cgi?id=31783
Unskip the http/tests/ssl/verify-ssl-enabled.php test, which is passing now.
* DumpRenderTree/qt/DumpRenderTree.cpp:
(WebCore::NetworkAccessManager::NetworkAccessManager):
(WebCore::NetworkAccessManager::sslErrorsEncountered):
(WebCore::WebPage::WebPage):
* DumpRenderTree/qt/DumpRenderTree.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51298
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Sun, 22 Nov 2009 20:05:47 +0000 (20:05 +0000)]
2009-11-22 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Introduce sidebar background on timeline panel in order
to prevent it from flickering on scroll.
https://bugs.webkit.org/show_bug.cgi?id=31789
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype.setSidebarWidth):
(WebInspector.TimelinePanel.prototype._onScroll):
(WebInspector.TimelinePanel.prototype._scheduleRefresh):
* inspector/front-end/inspector.css:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51297
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Sun, 22 Nov 2009 18:25:03 +0000 (18:25 +0000)]
2009-11-22 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Reimplement TimelinePanel to make it fast:
- Extract grid and overview into separate files
- Make timeline create only divs for visible rows
https://bugs.webkit.org/show_bug.cgi?id=31784
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/front-end/AbstractTimelinePanel.js:
(WebInspector.AbstractTimelinePanel.prototype.createInterface):
(WebInspector.AbstractTimelinePanel.prototype.refresh):
(WebInspector.AbstractTimelinePanel.prototype.set calculator):
* inspector/front-end/TimelineGrid.js: Added.
(WebInspector.TimelineGrid):
(WebInspector.TimelineGrid.prototype.get itemsGraphsElement):
(WebInspector.TimelineGrid.prototype.updateDividers):
(WebInspector.TimelineGrid.prototype.addEventDivider):
(WebInspector.TimelineGrid.prototype.setScrollAndDividerTop):
* inspector/front-end/TimelineOverviewPane.js: Added.
(WebInspector.TimelineOverviewPane):
(WebInspector.TimelineOverviewPane.prototype._onCheckboxClicked):
(WebInspector.TimelineOverviewPane.prototype.update):
(WebInspector.TimelineOverviewPane.prototype.setSidebarWidth):
(WebInspector.TimelineOverviewPane.prototype.updateMainViewWidth):
(WebInspector.TimelineOverviewPane.prototype.reset):
(WebInspector.TimelineOverviewPane.prototype._resizeWindow):
(WebInspector.TimelineOverviewPane.prototype._windowResizeDragging):
(WebInspector.TimelineOverviewPane.prototype._dragWindow):
(WebInspector.TimelineOverviewPane.prototype._windowDragging):
(WebInspector.TimelineOverviewPane.prototype._resizeWindowLeft):
(WebInspector.TimelineOverviewPane.prototype._resizeWindowRight):
(WebInspector.TimelineOverviewPane.prototype._setWindowPosition):
(WebInspector.TimelineOverviewPane.prototype._endWindowDragging):
(WebInspector.TimelineOverviewCalculator):
(WebInspector.TimelineOverviewCalculator.prototype.computeBarGraphPercentages):
(WebInspector.TimelineOverviewCalculator.prototype.reset):
(WebInspector.TimelineOverviewCalculator.prototype.updateBoundaries):
(WebInspector.TimelineOverviewCalculator.prototype.get boundarySpan):
(WebInspector.TimelineOverviewCalculator.prototype.formatValue):
(WebInspector.TimelineCategoryTreeElement):
(WebInspector.TimelineCategoryTreeElement.prototype.onattach):
(WebInspector.TimelineCategoryGraph):
(WebInspector.TimelineCategoryGraph.prototype.get graphElement):
(WebInspector.TimelineCategoryGraph.prototype.addChunk):
(WebInspector.TimelineCategoryGraph.prototype.clearChunks):
(WebInspector.TimelineCategoryGraph.prototype.set dimmed):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype._toggleTimelineButtonClicked):
(WebInspector.TimelinePanel.prototype.addRecordToTimeline):
(WebInspector.TimelinePanel.prototype._formatRecord):
(WebInspector.TimelinePanel.prototype.setSidebarWidth):
(WebInspector.TimelinePanel.prototype.updateMainViewWidth):
(WebInspector.TimelinePanel.prototype.resize):
(WebInspector.TimelinePanel.prototype.reset):
(WebInspector.TimelinePanel.prototype.show):
(WebInspector.TimelinePanel.prototype._onScroll):
(WebInspector.TimelinePanel.prototype._scheduleRefresh):
(WebInspector.TimelinePanel.prototype._refresh):
(WebInspector.TimelinePanel.prototype._refreshRecords):
(WebInspector.TimelinePanel.prototype._adjustScrollPosition):
(WebInspector.TimelineCategory):
(WebInspector.TimelineCalculator):
(WebInspector.TimelineCalculator.prototype.get boundarySpan):
(WebInspector.TimelineRecordListRow):
(WebInspector.TimelineRecordListRow.prototype.update):
(WebInspector.TimelineRecordGraphRow):
(WebInspector.TimelineRecordGraphRow.prototype.update):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.css:
* inspector/front-end/inspector.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51296
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Sun, 22 Nov 2009 17:22:39 +0000 (17:22 +0000)]
2009-11-22 Chris Evans <cevans@chromium.org>
Reviewed by Adam Barth.
Disable access to file:/// directory listings
https://bugs.webkit.org/show_bug.cgi?id=31329
Updates the test to make sure it is disabling universal access for
file:/// URLs (if the API is supported). This is required to do
effective intra-file:/// access tests.
Note that Safari only passes by virtual of supporting no directory
listings at all.
* fast/xmlhttprequest/resources/xmlhttprequest-nonexistent-file-real.html: Added.
* fast/xmlhttprequest/xmlhttprequest-nonexistent-file-expected.txt:
* fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html:
Disable universal access for file:/// URLs (if API available).
Run the real test in an iframe without universal access.
2009-11-22 Chris Evans <cevans@chromium.org>
Reviewed by Adam Barth.
Disable access to file:/// directory listings
https://bugs.webkit.org/show_bug.cgi?id=31329
Deny access to directory listings. This needs doing in WebKit for
WebKit clients that do permit top-level navigation to file:///dir.
This matches Firefox, plus the existing Safari implementation (which
does not support any directory access at all). It will fix the
LayoutTest named below for Chromium.
Test: fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html
* page/SecurityOrigin.cpp: Deny access to directory listings.
(WebCore::SecurityOrigin::SecurityOrigin):
(WebCore::SecurityOrigin::canRequest):
2009-11-22 Chris Evans <cevans@chromium.org>
Reviewed by Adam Barth.
Disable access to file:/// directory listings
https://bugs.webkit.org/show_bug.cgi?id=31329
Implemented setAllowUniversalAccessFromFileURLs to support testing of
file URL security.
* DumpRenderTree/LayoutTestController.cpp:
(setAllowUniversalAccessFromFileURLsCallback):
(LayoutTestController::staticFunctions):
* DumpRenderTree/LayoutTestController.h:
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::setAllowUniversalAccessFromFileURLs):
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::setAllowUniversalAccessFromFileURLs):
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::setAllowUniversalAccessFromFileURLs):
* DumpRenderTree/wx/LayoutTestControllerWx.cpp:
(LayoutTestController::setAllowUniversalAccessFromFileURLs):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51295
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Sun, 22 Nov 2009 17:22:31 +0000 (17:22 +0000)]
2009-11-22 Chris Evans <cevans@chromium.org>
Reviewed by Adam Barth.
Updates the test to make sure it is disabling universal access for
file:/// URLs (if the API is supported). This is required to do
effective intra-file:/// access tests.
Note that Safari only passes by virtual of supporting no directory
listings at all.
* fast/xmlhttprequest/resources/xmlhttprequest-nonexistent-file-real.html: Added.
* fast/xmlhttprequest/xmlhttprequest-nonexistent-file-expected.txt:
* fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html:
Disable universal access for file:/// URLs (if API available).
Run the real test in an iframe without universal access.
2009-11-22 Chris Evans <cevans@chromium.org>
Reviewed by Adam Barth.
Deny access to directory listings. This needs doing in WebKit for
WebKit clients that do permit top-level navigation to file:///dir.
This matches Firefox, plus the existing Safari implementation (which
does not support any directory access at all). It will fix the
LayoutTest named below for Chromium.
Test: fast/xmlhttprequest/xmlhttprequest-nonexistent-file.html
* page/SecurityOrigin.cpp: Deny access to directory listings.
(WebCore::SecurityOrigin::SecurityOrigin):
(WebCore::SecurityOrigin::canRequest):
2009-11-22 Chris Evans <cevans@chromium.org>
Reviewed by Adam Barth.
Implemented setAllowUniversalAccessFromFileURLs to support testing of
file URL security.
* DumpRenderTree/LayoutTestController.cpp:
(setAllowUniversalAccessFromFileURLsCallback):
(LayoutTestController::staticFunctions):
* DumpRenderTree/LayoutTestController.h:
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::setAllowUniversalAccessFromFileURLs):
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::setAllowUniversalAccessFromFileURLs):
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
(LayoutTestController::setAllowUniversalAccessFromFileURLs):
* DumpRenderTree/wx/LayoutTestControllerWx.cpp:
(LayoutTestController::setAllowUniversalAccessFromFileURLs):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51294
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Sun, 22 Nov 2009 15:16:31 +0000 (15:16 +0000)]
2009-11-22 Jakub Wieczorek <faw217@gmail.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Fix the timeout of fast/frames/frame-navigation.html
https://bugs.webkit.org/show_bug.cgi?id=31638
The test is timeouting, because it uses the WorkQueue to load a document in one
of the child frames and once the loading is finished, the DRT does not dump the
tree. This is because it waits for the QWebFrame::loadFinished() signal from
the main frame, while it should connect to QWebPage::loadFinished().
* DumpRenderTree/qt/DumpRenderTree.cpp:
(WebCore::DumpRenderTree::DumpRenderTree):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51293
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Sun, 22 Nov 2009 10:04:14 +0000 (10:04 +0000)]
Fixed a leak in WKDrawMediaUIPart().
Reviewed by Cameron Zwarich.
* libWebKitSystemInterfaceLeopard.a:
* libWebKitSystemInterfaceSnowLeopard.a:
* libWebKitSystemInterfaceTiger.a:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51292
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
joepeck@webkit.org [Sun, 22 Nov 2009 03:39:27 +0000 (03:39 +0000)]
2009-11-20 Joseph Pecoraro <joepeck@webkit.org>
Reviewed by Timothy Hatcher.
Web Inspector: Support Ctrl+P and Ctrl+N, Readline keyboard shortcuts in the Console
https://bugs.webkit.org/show_bug.cgi?id=31400
Handle the following when on a Mac:
Ctrl+P = Previous (like Up arrow)
Ctrl+N = Next (like Down arrow)
No longer rerun autocompletion when just pushing a modifier key
like Control, Alt, Shift, or Meta.
Improved arrow key behavior with Multiline code in the Console, with the following behavior:
Up = Previous Command if on First Line (caret moves to the end of the first line)
otherwise default caret movement in text.
Down = Next Command if on Last Line (caret naturally moves to the end)
otherwise default caret movement in text.
* inspector/front-end/TextPrompt.js:
(WebInspector.TextPrompt.prototype.handleKeyEvent): handle new keyboard shortcuts
(WebInspector.TextPrompt.prototype.isCaretOnFirstLine): check if the caret is on the top line
(WebInspector.TextPrompt.prototype.isCaretOnLastLine): check if the caret is on the bottom line
(WebInspector.TextPrompt.prototype._upKeyPressed):
(WebInspector.TextPrompt.prototype._downKeyPressed):
(WebInspector.TextPrompt.prototype._moveBackInHistory):
(WebInspector.TextPrompt.prototype._moveForwardInHistory):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51291
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Sun, 22 Nov 2009 03:04:33 +0000 (03:04 +0000)]
Adds a tooltip containing the full url of the resource to each element
in the Resources panel so that it is possible to quickly see the query
parameters.
https://bugs.webkit.org/show_bug.cgi?id=19103
Reviewed by Timothy Hatcher.
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourceSidebarTreeElement.prototype.refresh):
Set the tooltip to be the resource's url.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51290
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Sun, 22 Nov 2009 00:18:46 +0000 (00:18 +0000)]
2009-11-21 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
CSSKeyframesRule::findRule() and deleteRule() should accept 'from' and 'to' as well as percentages
https://bugs.webkit.org/show_bug.cgi?id=31588
In WebKitCSSKeyframesRule::findRuleIndex(), map 'from' to 0% an 'to' to 100%
so that findRule() and deleteRule() work with these keywords.
* css/WebKitCSSKeyframesRule.cpp:
(WebCore::WebKitCSSKeyframesRule::findRuleIndex):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51289
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Sat, 21 Nov 2009 23:13:53 +0000 (23:13 +0000)]
2009-11-21 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Eric Seidel.
[Qt][Mac] Turn on multiple JavaScript threads for QtWebkit on Mac
https://bugs.webkit.org/show_bug.cgi?id=31753
* wtf/Platform.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51288
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Sat, 21 Nov 2009 21:34:49 +0000 (21:34 +0000)]
2009-11-21 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
bugzilla-tool --help spews way too much text
https://bugs.webkit.org/show_bug.cgi?id=31771
* Scripts/bugzilla-tool:
- Remove self.cached_scm initialization hack.
* Scripts/modules/buildbot.py:
- Make default_host accessible to callers.
* Scripts/modules/commands/download.py:
- Phrase help for all commands consistently and remove spurious help text punctuation.
* Scripts/modules/commands/queries.py: Ditto.
* Scripts/modules/commands/queues.py: Ditto.
* Scripts/modules/commands/upload.py: Ditto.
* Scripts/modules/multicommandtool.py:
- Add HelpPrintingOptionParser.format_epilog to replace
NonWrappingEpilogIndentedHelpFormatter and allow us to lazily initialize
per-command help (thus removing the need for the cached_scm hack in BugzillaTool).
- Make --help only show a list of commands like "svn help" and "git help" do --
previously --help was listing all commands and options.
- Sort list of commands alphabetically.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51287
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jhoneycutt@apple.com [Sat, 21 Nov 2009 21:32:09 +0000 (21:32 +0000)]
2009-11-21 Jon Honeycutt <jhoneycutt@apple.com>
Windows build fix. Unreviewed.
* Interfaces/IWebSerializedJSValue.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51286
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Sat, 21 Nov 2009 21:26:55 +0000 (21:26 +0000)]
2009-11-21 Daniel Bates <dbates@webkit.org>
Reviewed by Eric Seidel.
https://bugs.webkit.org/show_bug.cgi?id=31647
Changed KeyboardEvent::m_keyEvent from a raw pointer to an OwnPtr.
No functionality was changed. So, no new tests.
* dom/KeyboardEvent.cpp:
(WebCore::KeyboardEvent::~KeyboardEvent):
* dom/KeyboardEvent.h: Changed m_keyEvent to OwnPtr.
(WebCore::KeyboardEvent::keyEvent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51285
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Sat, 21 Nov 2009 21:12:59 +0000 (21:12 +0000)]
2009-11-21 Eric Seidel <eric@webkit.org>
No review. Fixing a typo from the previous patch for bug 31767.
AbstractQueue.run_bugzilla_tool throws an exception
https://bugs.webkit.org/show_bug.cgi?id=31769
* Scripts/modules/commands/queues.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51284
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Sat, 21 Nov 2009 15:50:16 +0000 (15:50 +0000)]
2009-11-21 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
commit-queue fails to run with "permissions error" due to bad bugzilla-tool path
https://bugs.webkit.org/show_bug.cgi?id=31767
What we really want to test is BugzillaTool.path() instead of TrivialTool.path().
Since we don't have a good way to test BugzillaTool pieces, I've
left out a test for now.
* Scripts/bugzilla-tool:
- Add a path() implementation to expose bugzilla-tool's __file__ path to commit-queue.
* Scripts/modules/commands/queues.py:
- Use tool.path() instead of __file__.
* Scripts/modules/multicommandtool.py:
- Add a new path() method to MultiComandTool.
* Scripts/modules/multicommandtool_unittest.py:
- Provide a path() method. Little point in testing this mock implementation.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51283
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Sat, 21 Nov 2009 15:37:56 +0000 (15:37 +0000)]
2009-11-21 Adam Barth <abarth@webkit.org>
Unreviewed "build" fix. Turns out I was testing the wrong copy of
WebKitTools.
* Scripts/modules/commands/download.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51282
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Sat, 21 Nov 2009 15:29:00 +0000 (15:29 +0000)]
2009-11-21 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Convert check-style to use LandingSequence
https://bugs.webkit.org/show_bug.cgi?id=31763
Instead of manipulating the working copy by hand, we should use the
LandingSequence in CheckStyle. This will make this code eaiser to
test.
* Scripts/modules/commands/download.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51281
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jhoneycutt@apple.com [Sat, 21 Nov 2009 04:50:21 +0000 (04:50 +0000)]
DOMElement::tagName() is unimplemented
https://bugs.webkit.org/show_bug.cgi?id=31746
Reviewed by Darin Adler.
* DOMCoreClasses.cpp:
(DOMElement::tagName):
Create a BString from the element's tag name, and release its BSTR
into result.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51280
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jhoneycutt@apple.com [Sat, 21 Nov 2009 04:50:05 +0000 (04:50 +0000)]
DOMNode::childNodes() is unimplemented
https://bugs.webkit.org/show_bug.cgi?id=31745
Reviewed by Darin Adler.
* DOMCoreClasses.cpp:
(DOMNode::childNodes):
Create a DOMNodeList from the node's child nodes.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51279
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Sat, 21 Nov 2009 04:06:06 +0000 (04:06 +0000)]
2009-11-20 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Unit test query commands
https://bugs.webkit.org/show_bug.cgi?id=31755
These tests are pretty rough, but hopefully they'll grow.
* Scripts/modules/commands/queries_unittest.py: Added.
* Scripts/modules/mock_bugzillatool.py: Added.
* Scripts/run-webkit-unittests:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51278
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Sat, 21 Nov 2009 03:53:27 +0000 (03:53 +0000)]
2009-11-20 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Fix a bunch of unit test regressions from our recent bugzilla-toll hacking
https://bugs.webkit.org/show_bug.cgi?id=31758
* Scripts/modules/multicommandtool.py:
- Allow passing of explicit commands to MultiCommandTool.__init__
* Scripts/modules/multicommandtool_unittest.py:
- Use new Command.name naming system.
- Test Command auto-discovery.
* Scripts/modules/workqueue.py:
- bug_id no longer exists, use patch['bug_id'] instead.
* Scripts/modules/workqueue_unittest.py:
- WorkQueues require names now.
- should_proceed_with_work_item must return a patch object.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51277
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
cfleizach@apple.com [Sat, 21 Nov 2009 03:29:38 +0000 (03:29 +0000)]
WAI-ARIA: add support for aria-owns
https://bugs.webkit.org/show_bug.cgi?id=31702
Reviewed by Beth Dakin.
WebCore:
Re-organized how accessibilityAttributeNames are returned so
that it's possible for an element to add an attribute based on
a dynamic value. In this case, we only want to add AXOwn if the
element actually supports aria-owns.
Test: platform/mac/accessibility/aria-owns.html
* accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::supportsARIAOwns):
(WebCore::AccessibilityObject::ariaOwnsElements):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::ariaOwnsElements):
(WebCore::AccessibilityRenderObject::supportsARIAOwns):
* accessibility/AccessibilityRenderObject.h:
* accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper additionalAccessibilityAttributeNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeNames]):
(-[AccessibilityObjectWrapper accessibilityAttributeValue:]):
* html/HTMLAttributeNames.in:
WebKitTools:
* DumpRenderTree/AccessibilityUIElement.cpp:
(ariaOwnsElementAtIndexCallback):
(AccessibilityUIElement::getJSClass):
* DumpRenderTree/AccessibilityUIElement.h:
* DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
(AccessibilityUIElement::ariaOwnsElementAtIndex):
* DumpRenderTree/mac/AccessibilityUIElementMac.mm:
(AccessibilityUIElement::ariaOwnsElementAtIndex):
* DumpRenderTree/win/AccessibilityUIElementWin.cpp:
(AccessibilityUIElement::ariaOwnsElementAtIndex):
LayoutTests:
* platform/mac/accessibility/aria-owns-expected.txt: Added.
* platform/mac/accessibility/aria-owns.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51276
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Sat, 21 Nov 2009 03:14:51 +0000 (03:14 +0000)]
2009-11-20 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Fix exception thrown when running the commit-queue.
* Scripts/modules/statusbot.py: patch is optional.
* Scripts/modules/workqueue.py: WorkQUeue requires a name.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51275
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Sat, 21 Nov 2009 02:54:23 +0000 (02:54 +0000)]
Change WebSerializedJSValue on Windows to have a zero-argument createInstance call. Move the
serialization into a separate serialize() function that can be called after the object has been
created.
Reviewed by Jon Honeycutt.
Fix a typo in serialize() caused when fixing build bustage (put a ! back in).
* Interfaces/IWebSerializedJSValue.idl:
* WebSerializedJSValue.cpp:
(WebSerializedJSValue::WebSerializedJSValue):
(WebSerializedJSValue::createInstance):
(WebSerializedJSValue::serialize):
(WebSerializedJSValue::deserialize):
* WebSerializedJSValue.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51274
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bweinstein@apple.com [Sat, 21 Nov 2009 02:36:38 +0000 (02:36 +0000)]
Another go at the Windows Build Fix - this is a couple steps of it,
so a little more involved than most build fixes.
Reviewed by Dave Hyatt.
* Interfaces/IWebSerializedJSValue.idl:
* Interfaces/JavaScriptCoreAPITypes.idl:
* WebKit.vcproj/Interfaces.vcproj:
* WebSerializedJSValue.cpp:
(WebSerializedJSValue::deserialize):
* WebSerializedJSValue.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51273
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Sat, 21 Nov 2009 02:07:15 +0000 (02:07 +0000)]
Make sure to export WebSerializedJSValue.
Reviewed by Darin Adler.
* WebKit.exp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51272
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bweinstein@apple.com [Sat, 21 Nov 2009 01:54:59 +0000 (01:54 +0000)]
Build fix for Windows - only declare JSContextRef once, instead
of in two different idl files. Create a new file to hold the
definition of JSContextRef.
Reviewed by Dave Hyatt.
* Interfaces/IWebFrameLoadDelegate.idl:
* Interfaces/IWebSerializedJSValue.idl:
* Interfaces/JavaScriptCoreAPITypes.idl: Added.
* Interfaces/WebKit.idl:
* WebKit.vcproj/Interfaces.vcproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51271
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric.carlson@apple.com [Sat, 21 Nov 2009 01:44:04 +0000 (01:44 +0000)]
2009-11-20 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
<rdar://problem/
7414396> Leopard & Tiger: Support closed caption in <video> element
* css/mediaControls.css:
Define closed caption toggle button.
* rendering/RenderMedia.cpp:
(WebCore::RenderMedia::updateControls):
Create closed caption toggle button in display order.
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::shouldRenderMediaControlPart):
Don't require MediaControllerThemeQuickTime theme for captions toggle button.
No need to check if the movie has video, a closed captions track is a video
track.
2009-11-20 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
<rdar://problem/
7414396> Leopard & Tiger: Support closed caption in <video> element
* WebKitSystemInterface.h:
* libWebKitSystemInterfaceLeopard.a:
* libWebKitSystemInterfaceSnowLeopard.a:
* libWebKitSystemInterfaceTiger.a:
2009-11-20 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
<rdar://problem/
7414396> Leopard & Tiger: Support closed caption in <video> element
Remove closed captions test from skipped list.
* platform/mac-leopard/Skipped:
* platform/mac-tiger/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51270
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jianli@chromium.org [Sat, 21 Nov 2009 01:34:22 +0000 (01:34 +0000)]
Not reviewed. Fix chromium build.
* public/WebAccessibilityRole.h:
(WebKit::):
* src/AssertMatchingEnums.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51269
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
joepeck@webkit.org [Sat, 21 Nov 2009 01:18:59 +0000 (01:18 +0000)]
2009-11-20 Joseph Pecoraro <joepeck@webkit.org>
Reviewed by Timothy Hatcher.
Web Inspector: Running code in the Console that ends with a
single line comment no longer produces a parse error.
* inspector/front-end/InjectedScript.js:
(InjectedScript._evaluateOn):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51268
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt@apple.com [Sat, 21 Nov 2009 01:17:18 +0000 (01:17 +0000)]
Add support for WebSerializedJSValue to WebKit. This object wraps the SerializedScriptValue functionality in WebCore
and exposes the ability to do JS value serialization/deserialization to WebKit clients.
Reviewed by Oliver Hunt and Jon Honeycutt.
WebKit:
* WebKit.xcodeproj/project.pbxproj:
WebKit/mac:
* WebView/WebSerializedJSValue.h: Added.
* WebView/WebSerializedJSValue.mm: Added.
(-[WebSerializedJSValue initWithValue:context:]):
(-[WebSerializedJSValue deserialize:]):
(-[WebSerializedJSValue dealloc]):
WebKit/win:
* Interfaces/IWebSerializedJSValue.idl: Added.
* Interfaces/WebKit.idl:
* WebKit.vcproj/WebKit.vcproj:
* WebSerializedJSValue.cpp: Added.
(WebSerializedJSValue::WebSerializedJSValue):
(WebSerializedJSValue::~WebSerializedJSValue):
(WebSerializedJSValue::createInstance):
(WebSerializedJSValue::AddRef):
(WebSerializedJSValue::Release):
(WebSerializedJSValue::QueryInterface):
(WebSerializedJSValue::deserialize):
* WebSerializedJSValue.h: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51267
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Sat, 21 Nov 2009 01:15:40 +0000 (01:15 +0000)]
2009-11-20 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Teach the StatusBot how to support more than just the commit-queue
https://bugs.webkit.org/show_bug.cgi?id=31754
* Scripts/modules/workqueue.py: Another typo.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51266
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Sat, 21 Nov 2009 01:09:28 +0000 (01:09 +0000)]
2009-11-20 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Teach the StatusBot how to support more than just the commit-queue
https://bugs.webkit.org/show_bug.cgi?id=31754
* Scripts/modules/commands/queues.py: Fix silly typo.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51265
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Sat, 21 Nov 2009 01:02:41 +0000 (01:02 +0000)]
2009-11-20 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Teach the StatusBot how to support more than just the commit-queue
https://bugs.webkit.org/show_bug.cgi?id=31754
* CommitQueueStatus/index.yaml:
- Add indices required for the new queries.
* CommitQueueStatus/queue_status.py:
- Add a patch-status page and move update_status to update-status.
- Only display "commit-queue" status records for the commit-queue.
- Add support for a queue_name property on status records.
- Fix _int_from_request to actually work.
* CommitQueueStatus/update_status.html:
- Add support for a queue_name on status records.
- Remove unused list of bug ids.
* Scripts/modules/commands/queues.py
- Make the queues pass the patch instead of the bug_id to StatusBot.
* Scripts/modules/statusbot.py:
- Support passing the queue_name to the status updates.
- Support fetching patch status with patch_status().
* Scripts/modules/workqueue.py:
- Pass the patch to the StatusBot instead of the bug_id.
- Let WorkQueues have a name.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51264
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Sat, 21 Nov 2009 00:15:23 +0000 (00:15 +0000)]
2009-11-20 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Move bugzilla-tool commands into their own file
https://bugs.webkit.org/show_bug.cgi?id=31752
This will let us write unit tests.
* Scripts/bugzilla-tool:
* Scripts/modules/commands/__init__.py: Added.
* Scripts/modules/commands/download.py: Added.
* Scripts/modules/commands/queries.py: Added.
* Scripts/modules/commands/queues.py: Added.
* Scripts/modules/commands/upload.py: Added.
* Scripts/modules/grammar.py: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51263
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Sat, 21 Nov 2009 00:00:21 +0000 (00:00 +0000)]
2009-11-20 Chris Fleizach <cfleizach@apple.com>
Reviewed by Beth Dakin.
WAI-ARIA: add support for 'math' role
https://bugs.webkit.org/show_bug.cgi?id=31706
* platform/mac/accessibility/aria-grouping-roles-expected.txt:
* platform/mac/accessibility/aria-grouping-roles.html:
2009-11-20 Chris Fleizach <cfleizach@apple.com>
Reviewed by Beth Dakin.
WAI-ARIA: add support for 'math' role
https://bugs.webkit.org/show_bug.cgi?id=31706
* accessibility/AccessibilityObject.cpp:
* accessibility/AccessibilityObject.h:
* accessibility/mac/AccessibilityObjectWrapper.mm:
2009-11-20 Chris Fleizach <cfleizach@apple.com>
Reviewed by Beth Dakin.
WAI-ARIA: add support for 'math' role
https://bugs.webkit.org/show_bug.cgi?id=31706
* English.lproj/Localizable.strings:
* StringsNotToBeLocalized.txt:
2009-11-20 Chris Fleizach <cfleizach@apple.com>
Reviewed by Beth Dakin.
WAI-ARIA: add support for 'math' role
https://bugs.webkit.org/show_bug.cgi?id=31706
* WebCoreSupport/WebViewFactory.mm:
(-[WebViewFactory AXARIAContentGroupText:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51262
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Fri, 20 Nov 2009 22:54:24 +0000 (22:54 +0000)]
Fix ChangeLog
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51261
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Fri, 20 Nov 2009 22:52:47 +0000 (22:52 +0000)]
2009-11-20 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Reviewed by Eric Seidel.
BuildQueue should check if the tree is currently buildable
https://bugs.webkit.org/show_bug.cgi?id=31744
* Scripts/bugzilla-tool:
* Scripts/modules/landingsequence.py:
* Scripts/modules/webkitlandingscripts.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51260
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Fri, 20 Nov 2009 22:51:56 +0000 (22:51 +0000)]
2009-11-20 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Move prepare_clean_working_directory into the LandingSequence
https://bugs.webkit.org/show_bug.cgi?id=31743
* Scripts/bugzilla-tool:
* Scripts/modules/landingsequence.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51259
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yael.aharon@nokia.com [Fri, 20 Nov 2009 22:34:04 +0000 (22:34 +0000)]
Unreviewed fix.
Fix file names in the skipped list, for files added in http://trac.webkit.org/changeset/51257.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51258
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yael.aharon@nokia.com [Fri, 20 Nov 2009 21:40:38 +0000 (21:40 +0000)]
NPN_ReloadPlugins does not reload the page even if reloadPages is true.
https://bugs.webkit.org/show_bug.cgi?id=30460
Reviewed by Kenneth Rohde Christiansen.
WebCore:
Replace call to PluginDatabase::installedPlugins()->refresh() with Page::refreshPlugins().
It already refreshes plugins and reloads pages when necessary.
Tests: plugins/reloadplugins-and-pages.html
plugins/reloadplugins-no-pages.html
* plugins/PluginInfoStore.cpp:
(WebCore::refreshPlugins):
WebKitTools:
Added code for calling NPN_ReloadPlugins with reloadPages true and false.
* DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
(pluginInvoke):
LayoutTests:
Added tests for calling NPN_ReloadPlugins with reloadPages being true and false.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51257
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Fri, 20 Nov 2009 21:32:03 +0000 (21:32 +0000)]
<rdar://
7409188> WebKit needs to be able to serialize and deserialize objects.
Reviewed by Dave Hyatt.
Expose WebCore object serialization to WebKit.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51256
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bweinstein@apple.com [Fri, 20 Nov 2009 21:29:12 +0000 (21:29 +0000)]
Fixes <http://webkit.org/b/31741>.
Web Inspector: User Entered Data on the console should show up no matter what filters.
Reviewed by Tim Hatcher.
Always show .console-user-command-result, no matter what the filter say
we should do with the other classes.
* inspector/front-end/inspector.css:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51255
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Fri, 20 Nov 2009 21:29:00 +0000 (21:29 +0000)]
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=25381
Needs test: jQuery animation crashing Safari
Adding a regression test for a bug that doesn't reproduce in ToT.
* fast/dynamic/jQuery-animation-crash-expected.txt: Added.
* fast/dynamic/jQuery-animation-crash.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51254
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Fri, 20 Nov 2009 21:03:12 +0000 (21:03 +0000)]
2009-11-20 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Pass the port information to the child process
https://bugs.webkit.org/show_bug.cgi?id=31736
We need to do this so the child process knows what to build!
* Scripts/bugzilla-tool:
* Scripts/modules/landingsequence.py:
* Scripts/modules/webkitport.py:
* Scripts/modules/webkitport_unittest.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51253
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Fri, 20 Nov 2009 20:26:49 +0000 (20:26 +0000)]
WebSocket tests still don't work on Windows, disabling for futher invesigation.
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51252
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bweinstein@apple.com [Fri, 20 Nov 2009 19:55:45 +0000 (19:55 +0000)]
Fix a closing tag issue in the vcproj and remove tabs.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51251
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bweinstein@apple.com [Fri, 20 Nov 2009 19:51:38 +0000 (19:51 +0000)]
Fixes <http://webkit.org/b/31700>.
Web Inspector: isMac should be in one central location + Cached.
Reviewed by Tim Hatcher.
We should cache the value of isMac, and make the indexOf call in one
single location, because we are calling it from multiple places, and saving
the result can save us time, and make the call sites simpler.
* inspector/front-end/AbstractTimelinePanel.js:
(WebInspector.AbstractTimelinePanel.prototype._updateFilter):
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype._updateFilter):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.handleKeyEvent):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._loaded):
* inspector/front-end/inspector.js:
(WebInspector.documentKeyDown):
(WebInspector.isMac):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51250
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Fri, 20 Nov 2009 19:31:39 +0000 (19:31 +0000)]
2009-11-20 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Support Qt port in build-queue
https://bugs.webkit.org/show_bug.cgi?id=31733
* Scripts/bugzilla-tool:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51249
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 20 Nov 2009 19:22:46 +0000 (19:22 +0000)]
2009-11-20 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Implement a build-queue
https://bugs.webkit.org/show_bug.cgi?id=31725
Currently this just builds the first 10 patches in the review queue.
We'll want to do something smarter soon.
* Scripts/bugzilla-tool:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51248
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Fri, 20 Nov 2009 19:22:07 +0000 (19:22 +0000)]
Enabling WebSocket tests on Windows - let's see if they pass after the recent fixes.
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51247
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
joepeck@webkit.org [Fri, 20 Nov 2009 19:19:05 +0000 (19:19 +0000)]
2009-11-19 Joseph Pecoraro <joepeck@webkit.org>
Removed .DS_Store accidentally added in last (r51245).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51246
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
joepeck@webkit.org [Fri, 20 Nov 2009 19:11:32 +0000 (19:11 +0000)]
2009-11-19 Joseph Pecoraro <joepeck@webkit.org>
Reviewed by Timothy Hatcher.
Web Inspector: Add Console Only Layout Mode
https://bugs.webkit.org/show_bug.cgi?id=30282
Adds a Console Panel, which allows for a Full size Console. This
extends the Drawer to the size of a Panel. This also fixes previous
resize issues with the Drawer.
* inspector/front-end/ConsolePanel.js: added.
(WebInspector.ConsolePanel):
(WebInspector.ConsolePanel.prototype.toolbarItemClass.get toolbarItemLabel):
(WebInspector.ConsolePanel.prototype.show):
(WebInspector.ConsolePanel.prototype.hide):
* inspector/front-end/Drawer.js:
(WebInspector.Drawer):
(WebInspector.Drawer.prototype.set visibleView):
(WebInspector.Drawer.prototype.get savedHeight): access the saved height of the variable console.
(WebInspector.Drawer.prototype.show.animationFinished):
(WebInspector.Drawer.prototype.show):
(WebInspector.Drawer.prototype.hide.animationFinished):
(WebInspector.Drawer.prototype.hide):
(WebInspector.Drawer.prototype.resize): resize appropriately if full/non-full
(WebInspector.Drawer.prototype.enterPanelMode):
(WebInspector.Drawer.prototype.exitPanelMode):
(WebInspector.Drawer.prototype.immediatelyExitPanelMode):
(WebInspector.Drawer.prototype._cancelAnimationIfNeeded):
(WebInspector.Drawer.prototype._animateDrawerHeight.animationFinished):
(WebInspector.Drawer.prototype._animateDrawerHeight):
(WebInspector.Drawer.prototype._animationDuration):
(WebInspector.Drawer.prototype._startStatusBarDragging):
(WebInspector.Drawer.prototype._statusBarDragging):
(WebInspector.Drawer.prototype._endStatusBarDragging):
Miscellaneous changes and cleanup.
* English.lproj/localizedStrings.js: "Console" toolbar title.
* inspector/front-end/ConsoleView.js: removed unnecessary element reordering
* inspector/front-end/Images/consoleIcon.png: added.
* inspector/front-end/inspector.css: added icon.
* inspector/front-end/inspector.html:
* inspector/front-end/inspector.js:
(WebInspector._createPanels): create console panel
(WebInspector.windowResize): resize drawer if necessary
(WebInspector.documentKeyDown): esc should not toggle the console when in panel mode
(WebInspector.animateStyle): start animation interval, returns the interval key
(WebInspector.toggleAttach): resize drawer if necessary
(WebInspector.showConsolePanel): restore the panel when the inspector restarts
(WebInspector.showProfileForURL): style fix
Restore the panel when the inspector restarts.
* inspector/InspectorController.cpp:
(WebCore::InspectorController::setWindowVisible):
(WebCore::InspectorController::specialPanelForJSName):
* inspector/InspectorFrontend.cpp:
(WebCore::InspectorFrontend::showPanel):
Build files.
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/front-end/WebKit.qrc:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51245
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 20 Nov 2009 19:06:02 +0000 (19:06 +0000)]
2009-11-20 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Make commit-queue and style-queue show up in help
https://bugs.webkit.org/show_bug.cgi?id=31724
We need to store their names on their class to make these commands
properly register themselves with MultiCommandTool.
* Scripts/bugzilla-tool:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51244
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 20 Nov 2009 18:57:50 +0000 (18:57 +0000)]
2009-11-20 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Implement bugzilla-tool build-attachment
https://bugs.webkit.org/show_bug.cgi?id=31722
This command builds an attachment from bugzilla. It leaves the built
patch in the working copy.
* Scripts/bugzilla-tool:
* Scripts/modules/landingsequence.py:
* Scripts/modules/webkitlandingscripts.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51243
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bweinstein@apple.com [Fri, 20 Nov 2009 18:40:57 +0000 (18:40 +0000)]
Fixes <http://webkit.org/b/31699>.
Web Inspector: Should Cache Values of InspectorController.platform() and port().
Reviewed by Tim Hatcher.
Refactor the Inspector to cache the value of InspectorController.platform
and InspectorController.port, because those need to call into C++, they are
being called more and more as we add platform specific keyboard shortcuts, and
they shouldn't change in the lifecycle of the Web Inspector.
* inspector/front-end/AbstractTimelinePanel.js:
(WebInspector.AbstractTimelinePanel.prototype._updateFilter):
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView.prototype._updateFilter):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.handleKeyEvent):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._loaded):
* inspector/front-end/inspector.js:
(WebInspector.get platform):
(WebInspector.get port):
(WebInspector.loaded):
(WebInspector.documentKeyDown):
(WebInspector.toolbarDragStart):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51242
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 20 Nov 2009 17:53:27 +0000 (17:53 +0000)]
2009-11-20 Victor Wang <victorw@chromium.org>
Reviewed by Darin Adler.
Add expected pixel result for layout test input-file-re-render
https://bugs.webkit.org/show_bug.cgi?id=31696
* platform/mac/fast/forms/input-file-re-render-expected.checksum: Added.
* platform/mac/fast/forms/input-file-re-render-expected.png: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51241
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
krit@webkit.org [Fri, 20 Nov 2009 17:49:15 +0000 (17:49 +0000)]
2009-11-20 Dirk Schulze <krit@webkit.org>
Unreviewed build fix for filters enabled builds.
* platform/graphics/filters/FEColorMatrix.cpp:
(WebCore::FEColorMatrix::apply):
* platform/graphics/filters/FEComposite.cpp:
(WebCore::FEComposite::apply):
* platform/graphics/filters/SourceGraphic.cpp:
(WebCore::SourceGraphic::apply):
* svg/graphics/SVGResourceFilter.cpp:
(WebCore::SVGResourceFilter::applyFilter):
* svg/graphics/filters/SVGFEMerge.cpp:
(WebCore::FEMerge::apply):
* svg/graphics/filters/SVGFEOffset.cpp:
(WebCore::FEOffset::apply):
* svg/graphics/filters/SVGFETile.cpp:
(WebCore::FETile::apply):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51240
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 20 Nov 2009 17:45:30 +0000 (17:45 +0000)]
2009-11-20 Alejandro G. Castro <alex@igalia.com>
Reviewed by Xan Lopez.
[GTK] DRT release event does not create the state correctly
https://bugs.webkit.org/show_bug.cgi?id=31717
* WebKitTools/DumpRenderTree/gtk/EventSender.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51239
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric.carlson@apple.com [Fri, 20 Nov 2009 17:27:01 +0000 (17:27 +0000)]
2009-11-20 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
<rdar://problem/
7389945> QTKit based media engine should not claim to support
fullscreen on Leopard
* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivate::supportsFullscreen):
Only return true on SnowLeopard for now.
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::shouldRenderMediaControlPart):
No need to special case MediaFullscreenButtonPart as the default implementation
asks the media engine if it supports fullscreen.
2009-11-20 Eric Carlson <eric.carlson@apple.com>
Reviewed by Simon Fraser.
<rdar://problem/
7389945> QTKit based media engine should not claim to support fullscreen on Leopard
Update test results.
* platform/mac/media/audio-controls-rendering-expected.checksum:
* platform/mac/media/audio-controls-rendering-expected.png:
* platform/mac/media/audio-controls-rendering-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51238
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Fri, 20 Nov 2009 14:54:34 +0000 (14:54 +0000)]
2009-11-20 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
MultiCommandTool should find Command objects automatically instead of with a manual list
https://bugs.webkit.org/show_bug.cgi?id=31710
* Scripts/bugzilla-tool:
* Scripts/modules/multicommandtool.py:
- Use some wild python-fu to crawl all the known subclasses of Command.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51237
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Fri, 20 Nov 2009 14:45:35 +0000 (14:45 +0000)]
2009-11-20 Adam Barth <abarth@webkit.org>
Unreviewed "build" fix. Added missing import.
* Scripts/bugzilla-tool:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51236
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Fri, 20 Nov 2009 14:44:03 +0000 (14:44 +0000)]
2009-11-20 Adam Barth <abarth@webkit.org>
Unreviewed "build" fix. I failed to update LandingSequence.test
properly.
* Scripts/modules/landingsequence.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51235
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
girish@forwardbias.in [Fri, 20 Nov 2009 11:18:31 +0000 (11:18 +0000)]
[Qt] Implement support for rendering plugins on Qt/Mac when a page is used
without a QWebView or when inside QGraphicsWebView.
Reviewed by Simon Hausmann.
Patch by Yongjun Zhang <yongjun.zhang@nokia.com> and
Girish Ramakrishnan <girish@forwardbias.in>
Currently, the code provides the cgcontext of the PlatformPluginWidget to
the plugin. This approach does not work when we are printing, or using
QWebFrame::render() to render to a QImage/QPixmap since the plugin ends
up drawing on the QWebView (i.e platformPluginWidget's cgcontext) instead
of the QPaintDevice's context.
To solve all cases and keep the code simple, we render the plugin to an
offscreen pixmap in all cases. This way, the plugin always renders to the
CGContext of the pixmap and we then use QPainter to blit the pixmap into
the QPaintDevice. We also create a fake window and set it's WindowRef in
NPWindow. Only with this WindowRef does Flash paint correctly to the QPixmap.
Now, that's the theory. In practice, ATM, mouse events do not work when using
the fake window. So, setPlatformPluginWidget() is still called when using QWebView
so that there are no regressions after this patch. Once we get mouse events
working, setPlatformPluginWidget will be removed.
https://bugs.webkit.org/show_bug.cgi?id=31183
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51234
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 20 Nov 2009 09:01:02 +0000 (09:01 +0000)]
2009-11-20 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Create LandingSequence as the all-sing, all-dance landing class
https://bugs.webkit.org/show_bug.cgi?id=31709
Client can inherit from this class to carefully control exactly which
steps they wish to have happen in the landing sequence.
* Scripts/bugzilla-tool:
* Scripts/modules/landingsequence.py: Added.
* Scripts/modules/webkitlandingscripts.py: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51233
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 20 Nov 2009 07:01:26 +0000 (07:01 +0000)]
2009-11-19 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Abstract AbstractPatchProcessingCommand from AbstractPatchLandingCommand
https://bugs.webkit.org/show_bug.cgi?id=31707
This is to help when we implement build-attachment.
* Scripts/bugzilla-tool:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51232
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 20 Nov 2009 06:43:40 +0000 (06:43 +0000)]
2009-11-19 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Support Qt port in bugzilla-tool
https://bugs.webkit.org/show_bug.cgi?id=31701
Now we support building with Qt!
* Scripts/bugzilla-tool:
* Scripts/modules/webkitport.py: Added.
* Scripts/modules/webkitport_unittest.py: Added.
* Scripts/run-webkit-unittests:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51231
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 20 Nov 2009 06:20:51 +0000 (06:20 +0000)]
2009-11-19 Zoltan Horvath <zoltan@webkit.org>
Reviewed by Adam Barth.
Remove inserting stderr into patch in bugzilla-tool
https://bugs.webkit.org/show_bug.cgi?id=29914
Modify SCM python module's run_command function to avoid return of stderr
by default, so stderr won't be inserted into the patches.
Modify the related unit test.
* Scripts/modules/scm.py:
* Scripts/modules/scm_unittest.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51230
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
joepeck@webkit.org [Fri, 20 Nov 2009 06:17:30 +0000 (06:17 +0000)]
2009-11-19 Joseph Pecoraro <joepeck@webkit.org>
Reviewed by Timothy Hatcher.
Web Inspector: Resync Resources Backend and Frontend
https://bugs.webkit.org/show_bug.cgi?id=31705
* inspector/front-end/Resource.js: resync enum values with backend
(WebInspector.Resource.prototype._mimeTypeIsConsistentWithType): return false if all else fails, not true in all cases
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51229
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 20 Nov 2009 06:03:15 +0000 (06:03 +0000)]
2009-11-19 Steve Block <steveblock@google.com>
Android port lacks configuration in Platform.h and config.h.
https://bugs.webkit.org/show_bug.cgi?id=31671
* wtf/Platform.h: Modified. Added Android-specific configuration.
2009-11-19 Steve Block <steveblock@google.com>
Reviewed by Darin Fisher.
Android port lacks configuration in Platform.h and config.h.
https://bugs.webkit.org/show_bug.cgi?id=31671
Build change only. No new tests possible.
* config.h: Modified. Added Android-specific configuration.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51228
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rolandsteiner@chromium.org [Fri, 20 Nov 2009 05:44:06 +0000 (05:44 +0000)]
2009-11-20 Roland Steiner <rolandsteiner@chromium.org>
WebCore: Change default stylesheet to reset text indentation for ruby elements by default.
(https://bugs.webkit.org/show_bug.cgi?id=31247)
Reviewed by Darin Adler.
Test: fast/ruby/ruby-text-indent.html
* css/html.css: reset text-indent on <ruby> and <rt> elements
LayoutTests: Test checking that CSS 'text-indent' does not affect ruby rendering by default.
(https://bugs.webkit.org/show_bug.cgi?id=31247)
Reviewed by Darin Adler.
* fast/ruby/ruby-text-indent-expected.txt: Added.
* fast/ruby/ruby-text-indent.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51227
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 20 Nov 2009 02:18:44 +0000 (02:18 +0000)]
2009-11-19 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
bugzilla-tool needs per-command help
https://bugs.webkit.org/show_bug.cgi?id=31697
Added support for "bugzilla-tool help command-name"
and a unit test to make sure it works.
* Scripts/modules/multicommandtool.py:
* Scripts/modules/multicommandtool_unittest.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51226
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bweinstein@apple.com [Fri, 20 Nov 2009 02:12:21 +0000 (02:12 +0000)]
Fixes <http://webkit.org/b/22754>.
Web Inspector: Keyboard shortcut for Element finder.
Reviewed by Darin Adler.
Use Command + Shift + C as a shortcut for Node Search, to
match the Firebug shortcut to do the same thing.
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.handleKeyEvent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51225
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 20 Nov 2009 01:09:49 +0000 (01:09 +0000)]
2009-11-19 Yaar Schnitman <yaar@chromium.org>
Reviewed by Darin Fisher.
Make chromium/webkit/glue/FormFieldValues use the WebKit API
https://bugs.webkit.org/show_bug.cgi?id=31650
* public/WebElement.h:
* public/WebFormElement.h:
* public/WebInputElement.h:
(WebKit::WebInputElement::):
* public/WebNode.h:
* src/AssertMatchingEnums.cpp:
* src/DOMUtilitiesPrivate.cpp:
(WebKit::nameOfInputElement):
* src/DOMUtilitiesPrivate.h:
* src/EditorClientImpl.cpp:
(WebKit::EditorClientImpl::autofill):
(WebKit::EditorClientImpl::doAutofill):
* src/WebFormElement.cpp:
(WebKit::WebFormElement::name):
(WebKit::WebFormElement::method):
(WebKit::WebFormElement::getNamedElements):
(WebKit::WebFormElement::getInputElements):
* src/WebInputElement.cpp:
(WebKit::WebInputElement::isEnabledFormControl):
(WebKit::WebInputElement::inputType):
(WebKit::WebInputElement::formControlType):
(WebKit::WebInputElement::value):
(WebKit::WebInputElement::dispatchFormControlChangeEvent):
(WebKit::WebInputElement::setSelectionRange):
(WebKit::WebInputElement::name):
(WebKit::WebInputElement::nameForAutofill):
* src/WebNode.cpp:
(WebKit::WebNode::frame):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51224
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 20 Nov 2009 00:55:19 +0000 (00:55 +0000)]
2009-11-19 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
Move MultiCommandTool and Command into a separate file and add some basic unit tests
https://bugs.webkit.org/show_bug.cgi?id=31695
* Scripts/bugzilla-tool:
* Scripts/modules/multicommandtool.py: Added.
* Scripts/modules/multicommandtool_unittest.py: Added.
* Scripts/run-webkit-unittests:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51223
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Fri, 20 Nov 2009 00:53:38 +0000 (00:53 +0000)]
Reviewed by Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=31690
Make SocketStreamHandleCFNet work on Windows
* WebCore.vcproj/WebCore.vcproj: Added LoaderRunLoopCF.
* platform/network/ResourceHandle.h: Removed loaderRunLoop().
* platform/network/cf/LoaderRunLoopCF.cpp: Added.
(WebCore::emptyPerform):
(WebCore::runLoaderThread):
(WebCore::loaderRunLoop):
* platform/network/cf/LoaderRunLoopCF.h: Added.
Moved the run loop that we use for CFNetwork from ResourceHandle to its own file, because
it's needed for more than just resource loading.
* platform/network/cf/ResourceHandleCFNet.cpp: Use loaderRunLoop() from its new location.
* platform/network/cf/DNSCFNet.cpp: (WebCore::DNSResolveQueue::resolve): Ditto.
* platform/network/cf/SocketStreamHandle.h: Added static callbacks for forwarding events to
main thread.
* platform/network/cf/SocketStreamHandleCFNet.cpp:
(WebCore::SocketStreamHandle::SocketStreamHandle): Use loaderRunLoop() on Windows instead of
inoperable main run loop.
(WebCore::MainThreadEventCallbackInfo::MainThreadEventCallbackInfo):
(WebCore::SocketStreamHandle::readStreamCallback):
(WebCore::SocketStreamHandle::writeStreamCallback):
(WebCore::SocketStreamHandle::readStreamCallbackMainThread):
(WebCore::SocketStreamHandle::writeStreamCallbackMainThread):
Forward stream events to main thread on Windows.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51222
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 20 Nov 2009 00:47:08 +0000 (00:47 +0000)]
2009-11-19 Avi Drissman <avi@chromium.org>
Reviewed by Darin Adler.
Quick style fix.
https://bugs.webkit.org/show_bug.cgi?id=27777
* platform/graphics/cg/PDFDocumentImage.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51221
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bweinstein@apple.com [Fri, 20 Nov 2009 00:30:34 +0000 (00:30 +0000)]
Update Windows expected pixel results, and remove the RenderTree results, because they are the same as the Mac.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51220
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin@apple.com [Fri, 20 Nov 2009 00:25:38 +0000 (00:25 +0000)]
Build fix. No review needed.
* platform/chromium/ScrollbarThemeChromium.cpp:
(WebCore::ScrollbarThemeChromium::paintTickmarks):
* rendering/RenderMediaControlsChromium.cpp:
(WebCore::paintMediaButton):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51219
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin@apple.com [Fri, 20 Nov 2009 00:02:16 +0000 (00:02 +0000)]
Build fix. No review needed.
* rendering/RenderThemeChromiumSkia.cpp:
(WebCore::RenderThemeChromiumSkia::paintCheckbox):
(WebCore::RenderThemeChromiumSkia::paintRadio):
(WebCore::RenderThemeChromiumSkia::paintSearchFieldCancelButton):
(WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeChromiumSkia::paintSearchFieldResultsButton):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51218
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin@apple.com [Thu, 19 Nov 2009 23:58:41 +0000 (23:58 +0000)]
Build fix. No review needed.
* platform/graphics/qt/StillImageQt.cpp:
(WebCore::StillImage::draw):
* platform/graphics/qt/StillImageQt.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51217
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin@apple.com [Thu, 19 Nov 2009 23:53:33 +0000 (23:53 +0000)]
Build fix. No review needed.
* rendering/RenderThemeWin.cpp:
(WebCore::RenderThemeWin::paintSearchFieldCancelButton):
(WebCore::RenderThemeWin::paintSearchFieldResultsDecoration):
(WebCore::RenderThemeWin::paintSearchFieldResultsButton):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51216
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin@apple.com [Thu, 19 Nov 2009 23:50:18 +0000 (23:50 +0000)]
Build fix. No review needed.
* plugins/PluginView.cpp:
(WebCore::PluginView::paintMissingPluginIcon):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51215
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin@apple.com [Thu, 19 Nov 2009 23:46:49 +0000 (23:46 +0000)]
Build fix. No review needed.
* platform/graphics/win/ImageCGWin.cpp:
(WebCore::BitmapImage::getHBITMAPOfSize):
(WebCore::BitmapImage::drawFrameMatchingSourceSize):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51214
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Thu, 19 Nov 2009 23:38:24 +0000 (23:38 +0000)]
2009-11-19 Eric Seidel <eric@webkit.org>
No review, just adding a FIXME.
Split out command parsing and help printing from BugzillaTool
https://bugs.webkit.org/show_bug.cgi?id=31688
* Scripts/bugzilla-tool: Add an extra comment about current design failures.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@51213
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
git://git.webkit.org / WebKit-https.git / log