WebKit-https.git
11 years ago1. Changes the order in which some functions are called to match
dumi@chromium.org [Tue, 29 Dec 2009 20:51:32 +0000 (20:51 +0000)]
1. Changes the order in which some functions are called to match
the pre-r52536 order. Namely, when a new Database object is
created, DatabaseTracker::addOpenDatabase() is called in the
constructor, before doing anything else related to that database
(like trying to get a file handle to the database
file). Chromium's implementation depends on this ordering.
2. Changes Database::performOpenAndVerify() to close the open
handle to the database file immediately if the database version
does not match the expected one. The current behavior is to add
the Database object to a DatabaseThread collection and let the
database thread close the handle when it's destroyed.

Reviewed by Maciej Stachowiak.

https://bugs.webkit.org/show_bug.cgi?id=33005

All LayoutTests/storage tests pass in clean WebKit and Chromium
clients.

* storage/Database.cpp:
(WebCore::Database::openDatabase): Notify DatabaseTracker and
Document that a Database object is about to be destroyed (when a
database file cannot be opened, or its version doesn't match the
expected one).
(WebCore::Database::Database): Notify DatabaseTracker and Document
that a new Database object was created.
(WebCore::Database::performOpenAndVerify): If a database version
does not match the expected one, immediately close the open file
handle to the database file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-29 Nikolas Zimmermann <nzimmermann@rim.com>
krit@webkit.org [Tue, 29 Dec 2009 20:46:17 +0000 (20:46 +0000)]
2009-12-29  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        Marker code is buggy: referencePoint translation is off
        https://bugs.webkit.org/show_bug.cgi?id=33012

        Rewrite marker code, as it was buggy:
        - Correct refX/refY handling (covered by new marker-referencePoint.svg test)
        - Calculate marker bounds on layout time, instead of paint time, to deliver correct repaint rects
        - Cleanup RenderPath code, which was cluttered by marker stuff (outlay in SVGMarkerLayoutInfo)
        - Fix SVGResource assuming that there is only one resource per resource type per element. Markers
          can have three different resources of the same type (three markers, start/mid/end markers)

        Fixes all svg/custom/marker*.svg tests, that use dynamic updates (propagation failed before).
        Test: svg/custom/marker-referencePoint.svg

        * Android.mk:
        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * rendering/RenderPath.cpp:
        (WebCore::RenderPath::repaintRectInLocalCoordinates):
        (WebCore::RenderPath::setPath):
        (WebCore::RenderPath::paint):
        (WebCore::RenderPath::calculateMarkerBoundsIfNeeded):
        * rendering/RenderPath.h:
        (WebCore::RenderPath::path):
        * rendering/RenderSVGContainer.h:
        * rendering/RenderSVGViewportContainer.cpp:
        (WebCore::RenderSVGViewportContainer::markerContentTransformation):
        * rendering/RenderSVGViewportContainer.h:
        * rendering/SVGMarkerLayoutInfo.cpp: Added.
        (WebCore::SVGMarkerLayoutInfo::SVGMarkerLayoutInfo):
        (WebCore::SVGMarkerLayoutInfo::~SVGMarkerLayoutInfo):
        (WebCore::SVGMarkerLayoutInfo::initialize):
        (WebCore::updateMarkerDataForElement):
        (WebCore::recordMarkerData):
        (WebCore::processStartAndMidMarkers):
        (WebCore::SVGMarkerLayoutInfo::calculateBoundaries):
        (WebCore::SVGMarkerLayoutInfo::drawMarkers):
        * rendering/SVGMarkerLayoutInfo.h: Added.
        (WebCore::MarkerData::):
        (WebCore::MarkerData::MarkerData):
        (WebCore::MarkerLayout::MarkerLayout):
        * svg/SVGMarkerElement.cpp:
        (WebCore::SVGMarkerElement::canvasResource):
        * svg/graphics/SVGResource.cpp:
        (WebCore::resourceSet):
        (WebCore::SVGResource::SVGResource):
        (WebCore::SVGResource::~SVGResource):
        (WebCore::SVGResource::removeClient):
        (WebCore::SVGResource::addClient):
        * svg/graphics/SVGResourceMarker.cpp:
        (WebCore::SVGResourceMarker::SVGResourceMarker):
        (WebCore::SVGResourceMarker::markerBoundaries):
        (WebCore::SVGResourceMarker::markerTransformation):
        (WebCore::SVGResourceMarker::draw):
        (WebCore::SVGResourceMarker::externalRepresentation):
        * svg/graphics/SVGResourceMarker.h:
        (WebCore::SVGResourceMarker::setRenderer):
        (WebCore::SVGResourceMarker::setReferencePoint):
        (WebCore::SVGResourceMarker::referencePoint):

2009-12-29  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        Marker code is buggy: referencePoint translation is off
        https://bugs.webkit.org/show_bug.cgi?id=33012

        Update SVG test baseline, after rewriting marker support.

        * platform/mac/svg/W3C-SVG-1.1/painting-marker-02-f-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/painting-marker-03-f-expected.txt:
        * platform/mac/svg/custom/circular-marker-reference-1-expected.txt:
        * platform/mac/svg/custom/circular-marker-reference-2-expected.txt:
        * platform/mac/svg/custom/circular-marker-reference-3-expected.txt:
        * platform/mac/svg/custom/circular-marker-reference-4-expected.txt:
        * platform/mac/svg/custom/js-late-marker-and-object-creation-expected.txt:
        * platform/mac/svg/custom/js-late-marker-creation-expected.txt:
        * platform/mac/svg/custom/marker-changes-expected.checksum:
        * platform/mac/svg/custom/marker-changes-expected.png:
        * platform/mac/svg/custom/marker-changes-expected.txt:
        * platform/mac/svg/custom/marker-child-changes-expected.checksum:
        * platform/mac/svg/custom/marker-child-changes-expected.png:
        * platform/mac/svg/custom/marker-child-changes-expected.txt:
        * platform/mac/svg/custom/marker-default-width-height-expected.txt:
        * platform/mac/svg/custom/marker-overflow-clip-expected.txt:
        * platform/mac/svg/custom/marker-referencePoint-expected.checksum: Added.
        * platform/mac/svg/custom/marker-referencePoint-expected.png: Added.
        * platform/mac/svg/custom/marker-referencePoint-expected.txt: Added.
        * platform/mac/svg/custom/marker-viewBox-changes-expected.checksum:
        * platform/mac/svg/custom/marker-viewBox-changes-expected.png:
        * platform/mac/svg/custom/marker-viewBox-changes-expected.txt:
        * platform/mac/svg/custom/non-circular-marker-reference-expected.txt:
        * platform/mac/svg/custom/shapes-supporting-markers-expected.txt:
        * svg/custom/marker-referencePoint.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-29 Alexander Pavlov <apavlov@chromium.org>
eric@webkit.org [Tue, 29 Dec 2009 19:55:59 +0000 (19:55 +0000)]
2009-12-29  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Fix UI nits in the Audits panel.
        https://bugs.webkit.org/show_bug.cgi?id=32932

        * inspector/front-end/AuditLauncherView.js:
        (WebInspector.AuditLauncherView.prototype._selectAllClicked):
        (WebInspector.AuditLauncherView.prototype._createCategoryElement):
        (WebInspector.AuditLauncherView.prototype._createLauncherUI.handleSelectAllClick):
        (WebInspector.AuditLauncherView.prototype._createLauncherUI):
        * inspector/front-end/AuditResultView.js:
        (WebInspector.AuditResultView):
        (WebInspector.AuditRuleResultPane):
        * inspector/front-end/audits.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-29 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 29 Dec 2009 19:33:01 +0000 (19:33 +0000)]
2009-12-29  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Add the start of a Bug object for bugzilla.py
        https://bugs.webkit.org/show_bug.cgi?id=32995

        This allowed us to get rid of some duplicated "is_obsolete" checks.

        * Scripts/modules/bugzilla.py:
         - Add a new Bug class, and move patches/unreviewed_patches filtering logic there.
         - Add _fetch_bug_page for possible future mocking.
           (I did not try to test fetch_*_from_bug now due to difficulties with our current validate_reviewer logic.)
         - Rename fetch_bug to fetch_bug_dictionary and add a new fetch_bug which returns a Bug object.
         - Use fetch_bug and attachments(), patches(), etc. instead of custom fetch_*_from_bug methods.
         - Reduce code in fetch_patches_from_pending_commit_list and fetch_patches_from_review_queue
           using list comprehensions. Use a sum(list, []) trick to flatten a list of lists into a single list.
        * Scripts/modules/bugzilla_unittest.py:
         - Remove an unneeded unicode string marker.
        * Scripts/modules/buildsteps.py:
         - define __all__ to include just the BuildSteps
        * Scripts/modules/commands/download.py:
         - import * now that we have an __all__ defined.
        * Scripts/modules/commands/upload.py:
         - Use fetch_bug_dictionary instead of fetch_bug.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-29 Johnny Ding <jnd@chromium.org>
eric@webkit.org [Tue, 29 Dec 2009 19:25:08 +0000 (19:25 +0000)]
2009-12-29  Johnny Ding  <jnd@chromium.org>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=32863
        Make NodeList support call-as-function

        Test: fast/dom/NodeList/nodelist-item-call-as-function.html

        * bindings/scripts/CodeGeneratorV8.pm:
        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::getTemplate):
        * bindings/v8/custom/V8NodeListCustom.cpp:
        (WebCore::V8NodeList::callAsFunctionCallback):
2009-12-29  Johnny Ding  <jnd@chromium.org>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=32863
        Make NodeList support call-as-function.

        * fast/dom/NodeList/nodelist-item-call-as-function-expected.txt: Added.
        * fast/dom/NodeList/nodelist-item-call-as-function.html: Added.
        * fast/dom/NodeList/script-tests: Added.
        * fast/dom/NodeList/script-tests/TEMPLATE.html: Added.
        * fast/dom/NodeList/script-tests/nodelist-item-call-as-function.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-29 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Tue, 29 Dec 2009 18:27:33 +0000 (18:27 +0000)]
2009-12-29  Daniel Bates  <dbates@webkit.org>

        Reviewed by Ariya Hidayat.

        https://bugs.webkit.org/show_bug.cgi?id=32925

        Adds an Open File dialog to make it convenient to open a file
        to view in the browser.

        * QGVLauncher/main.cpp:
        (MainWindow::load): Modified to call loadURL.
        (MainWindow::openFile): Added.
        (MainWindow::loadURL): Added.
        (MainWindow::buildUI): Added menu item Open File.
2009-12-29  Daniel Bates  <dbates@webkit.org>

        Reviewed by Ariya Hidayat.

        https://bugs.webkit.org/show_bug.cgi?id=32925

        Adds an Open File dialog to make it convenient to open a file
        to view in the browser.

        Currently a person must either specify the path to a file as a
        command-line argument or type a file URL. Instead, we should
        have a file dialog to allow a person to open a file without
        memorizing its path.

        * QtLauncher/main.cpp:
        (MainWindow::MainWindow): Changed urlEdit->setText(qurl.toEncoded())
        to urlEdit->setText(qurl.toString()).
        (MainWindow::openFile): Added.
        (MainWindow::changeLocation): Moved code to load URL into method
        MainWindow::loadURL.
        (MainWindow::loadURL): Added.
        (MainWindow::setupUI): Added menu item Open File.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-29 Robert Hogan <robert@roberthogan.net>
eric@webkit.org [Tue, 29 Dec 2009 17:44:32 +0000 (17:44 +0000)]
2009-12-29  Robert Hogan  <robert@roberthogan.net>

        Reviewed by Eric Seidel.

        [Qt] Fix crash on LayoutTests/fast/loader/empty-embed-src-attribute.html

        Related to https://bugs.webkit.org/show_bug.cgi?id=23806

        If an embedded document is loaded within a page and it has an empty
        URL, use a blank URL for the load request.

        https://bugs.webkit.org/show_bug.cgi?id=33017

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::createFrame):
2009-12-29  Robert Hogan  <robert@roberthogan.net>

        Reviewed by Eric Seidel.

        [Qt] Fix crash on LayoutTests/fast/loader/empty-embed-src-attribute.html

        Related to https://bugs.webkit.org/show_bug.cgi?id=23806

        If an embedded document is loaded within a page and it has an empty
        URL, use a blank URL for the load request.

        https://bugs.webkit.org/show_bug.cgi?id=33017

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-29 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 29 Dec 2009 17:18:45 +0000 (17:18 +0000)]
2009-12-29  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        Typed text in table not correctly redrawn on page with compositing layers
        https://bugs.webkit.org/show_bug.cgi?id=32874

        Use the same test in RenderTableCell::computeRectForRepaint() that we use elsewhere
        to decide when to use layoutState, which is to test for layoutStateEnabled()
        and no repaint container.

        Not possible to make a repaint test that exercises the problem, so no test.

        * rendering/RenderTableCell.cpp:
        (WebCore::RenderTableCell::computeRectForRepaint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-29 Alexander Pavlov <apavlov@chromium.org>
eric@webkit.org [Tue, 29 Dec 2009 16:51:14 +0000 (16:51 +0000)]
2009-12-29  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Timothy Hatcher.

        Discard port from cookie domain when matching cookies.

        WebKit cookies do not hold the port information, so we should match only hostnames.
        https://bugs.webkit.org/show_bug.cgi?id=31787

        * inspector/front-end/inspector.js:
        (WebInspector.updateResource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-29 Laszlo Gombos <laszlo.1.gombos@nokia.com>
laszlo.1.gombos@nokia.com [Tue, 29 Dec 2009 15:55:51 +0000 (15:55 +0000)]
2009-12-29  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Rubber-stamped by Simon Hausmann and Holger Freyther.

        [Qt] Remove WebKit/qt/WebKitPart empty directory

        The content of the directory has been removed by r34888.

        * WebKitPart: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-29 Laszlo Gombos <laszlo.1.gombos@nokia.com>
eric@webkit.org [Tue, 29 Dec 2009 15:32:56 +0000 (15:32 +0000)]
2009-12-29  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Fix warnings in MediaPlayerPrivatePhonon.cpp
        https://bugs.webkit.org/show_bug.cgi?id=33019

        No new tests as there is no new functionality.

        * platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
        (WebCore::MediaPlayerPrivate::totalTimeChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-29 Kent Tamura <tkent@chromium.org>
eric@webkit.org [Tue, 29 Dec 2009 14:28:58 +0000 (14:28 +0000)]
2009-12-29  Kent Tamura  <tkent@chromium.org>

        Reviewed by Maciej Stachowiak.

        Implement HTML5 <aside> element.
        https://bugs.webkit.org/show_bug.cgi?id=32943

        <aside> should behave the same as <nav>, <section>, and <article>.

        Test: fast/html/aside-element.html

        * css/html.css: Add aside as a block element.
        * editing/htmlediting.cpp:
        (WebCore::validBlockTag): Add asideTag.
        * html/HTMLElement.cpp:
        (WebCore::HTMLElement::tagPriority): Returns 5 for asideTag.
        (WebCore::blockTagList): Add asideTag.
        * html/HTMLParser.cpp:
        (WebCore::HTMLParser::getNode): Add asideTag.
        * html/HTMLTagNames.in: Add aside.
2009-12-29  Kent Tamura  <tkent@chromium.org>

        Reviewed by Maciej Stachowiak.

        Implement HTML5 <aside> element.
        https://bugs.webkit.org/show_bug.cgi?id=32943

        The new test file tests:
        - <p> closing,
        - Residual style, and
        - FormatBlock.

        * fast/html/aside-element-expected.txt: Added.
        * fast/html/aside-element.html: Added.
        * fast/html/script-tests/aside-element.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-27 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Tue, 29 Dec 2009 13:52:57 +0000 (13:52 +0000)]
2009-12-27  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Alexey Proskuryakov.

        plugins/get-url-with-iframe-target.html fails on SnowLeopard (64-bit)
        https://bugs.webkit.org/show_bug.cgi?id=32982

        This test has been failing on SnowLeopard since it was landed.

        The problem is that we never delivered the notification for
        NPN_GetURLNotify, in the frame-targeting case, for out-of-process
        plugins on Mac.

        I implemented support for this based on how in-process Mac plugins
        do it.

        * Plugins/Hosted/HostedNetscapePluginStream.h:
        * Plugins/Hosted/HostedNetscapePluginStream.mm:
        (WebKit::HostedNetscapePluginStream::reasonForError):
        * Plugins/Hosted/NetscapePluginInstanceProxy.h:
        * Plugins/Hosted/NetscapePluginInstanceProxy.mm:
        (WebKit::NetscapePluginInstanceProxy::PluginRequest::create):
        (WebKit::NetscapePluginInstanceProxy::PluginRequest::PluginRequest):
        (WebKit::NetscapePluginInstanceProxy::destroy):
        (WebKit::NetscapePluginInstanceProxy::performRequest):
        (WebKit::NetscapePluginInstanceProxy::webFrameDidFinishLoadWithReason):
        (WebKit::NetscapePluginInstanceProxy::requestTimerFired):
        (WebKit::NetscapePluginInstanceProxy::loadRequest):
        * Plugins/Hosted/WebHostedNetscapePluginView.h:
        * Plugins/Hosted/WebHostedNetscapePluginView.mm:
        (-[WebHostedNetscapePluginView webFrame:didFinishLoadWithReason:]):
        (-[WebHostedNetscapePluginView webFrame:didFinishLoadWithError:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-29 Laszlo Gombos <laszlo.1.gombos@nokia.com>
eric@webkit.org [Tue, 29 Dec 2009 13:21:55 +0000 (13:21 +0000)]
2009-12-29  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Eric Seidel.

        Use explicit parentheses to silence gcc 4.4 -Wparentheses warnings
        https://bugs.webkit.org/show_bug.cgi?id=33003

        No new tests as there is no new functionality.

        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::breakOutOfEmptyMailBlockquotedParagraph):
        * page/animation/ImplicitAnimation.cpp:
        (WebCore::ImplicitAnimation::sendTransitionEvent):
        * page/animation/KeyframeAnimation.cpp:
        (WebCore::KeyframeAnimation::sendAnimationEvent):
        * rendering/RenderSVGContainer.h:
        (WebCore::toRenderSVGContainer):
        * rendering/style/RenderStyle.cpp:
        (WebCore::RenderStyle::setTextShadow):
        * svg/graphics/SVGPaintServerGradient.cpp:
        (WebCore::SVGPaintServerGradient::setup):
        * svg/graphics/SVGPaintServerPattern.cpp:
        (WebCore::SVGPaintServerPattern::setup):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoMinor style fix - reported by the style bot
kov@webkit.org [Tue, 29 Dec 2009 13:07:33 +0000 (13:07 +0000)]
Minor style fix - reported by the style bot

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-29 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Tue, 29 Dec 2009 13:05:35 +0000 (13:05 +0000)]
2009-12-29  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        [GTK] Failing media/video-seek-past-end-playing.html
        https://bugs.webkit.org/show_bug.cgi?id=33015

        Skip test that fails on and off locally, but always on the release
        bot, until we figure out what is wrong.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago [GTK] Fails fast/dom/prototype-inheritance-2.html after r52559
kov@webkit.org [Tue, 29 Dec 2009 12:58:47 +0000 (12:58 +0000)]
    [GTK] Fails fast/dom/prototype-inheritance-2.html after r52559
        https://bugs.webkit.org/show_bug.cgi?id=33014

        Skipping test that is failing after r52559 until we figure out why
        the constructors are not showing up for us.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoReviewed by Holger Freyther.
kov@webkit.org [Tue, 29 Dec 2009 12:56:14 +0000 (12:56 +0000)]
Reviewed by Holger Freyther.

[GTK] fails fast/harness/use-page-cache.html
https://bugs.webkit.org/show_bug.cgi?id=33013

Make sure settings are forwarded to child WebViews.

* DumpRenderTree/gtk/DumpRenderTree.cpp:
(createWebView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-29 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Tue, 29 Dec 2009 08:30:18 +0000 (08:30 +0000)]
2009-12-29  Daniel Bates  <dbates@webkit.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=32778

        Changes $diffPercentage to be a number to resolve Perl
        warning about comparing a string to a number.

        * Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-29 Jakub Wieczorek <faw217@gmail.com>
eric@webkit.org [Tue, 29 Dec 2009 08:26:32 +0000 (08:26 +0000)]
2009-12-29  Jakub Wieczorek  <faw217@gmail.com>

        Reviewed by Eric Seidel.

        [Qt] DRT: Frame loader callbacks differ from the Mac port
        https://bugs.webkit.org/show_bug.cgi?id=32989

        Remove messages from the callbacks that should not dump them to match
        the expected results for the http/loading tests.

        Unskip some http/loading tests which succeed now.

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::dispatchDidPopStateWithinPage):
        (WebCore::FrameLoaderClientQt::dispatchWillClose):
        (WebCore::FrameLoaderClientQt::dispatchDidReceiveIcon):
        (WebCore::FrameLoaderClientQt::dispatchDidClearWindowObjectInWorld):
2009-12-29  Jakub Wieczorek  <faw217@gmail.com>

        Reviewed by Eric Seidel.

        [Qt] DRT: Frame loader callbacks differ from the Mac port
        https://bugs.webkit.org/show_bug.cgi?id=32989

        Remove messages from the callbacks that should not dump them to match
        the expected results for the http/loading tests.

        Unskip some http/loading tests which succeed now.

        * platform/qt/Skipped:
2009-12-29  Jakub Wieczorek  <faw217@gmail.com>

        Reviewed by Eric Seidel.

        [Qt] DRT: Frame loader callbacks differ from the Mac port
        https://bugs.webkit.org/show_bug.cgi?id=32989

        Remove messages from the callbacks that should not dump them to match
        the expected results for the http/loading tests.

        Unskip some http/loading tests which succeed now.

        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
        (WebCore::DumpRenderTree::dump):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-29 Robert Hogan <robert@roberthogan.net>
eric@webkit.org [Tue, 29 Dec 2009 08:18:35 +0000 (08:18 +0000)]
2009-12-29  Robert Hogan  <robert@roberthogan.net>

        Reviewed by Eric Seidel.

        [Qt] fix fast/dom/Window/window-onFocus.html

        Add support for layouttestcontroller.windowIsKey to Qt DRT and fix issue where
        window.onblur was getting dispatched twice from QtWebKit.

        https://bugs.webkit.org/show_bug.cgi?id=32990

        * Api/qwebpage.cpp:
        (QWebPagePrivate::focusOutEvent):
2009-12-29  Robert Hogan  <robert@roberthogan.net>

        Reviewed by Eric Seidel.

        [Qt] fix fast/dom/Window/window-onFocus.html

        Add support for layouttestcontroller.windowIsKey to Qt DRT and fix issue where
        window.onblur was getting dispatched twice from QtWebKit.

        https://bugs.webkit.org/show_bug.cgi?id=32990

        * platform/qt/Skipped:
2009-12-29  Robert Hogan  <robert@roberthogan.net>

        Reviewed by Eric Seidel.

        [Qt] fix fast/dom/Window/window-onFocus.html

        Add support for layouttestcontroller.windowIsKey to Qt DRT and fix issue where
        window.onblur was getting dispatched twice from QtWebKit.

        https://bugs.webkit.org/show_bug.cgi?id=32990

        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
        (WebCore::DumpRenderTree::DumpRenderTree):
        (WebCore::DumpRenderTree::switchFocus):
        * DumpRenderTree/qt/DumpRenderTreeQt.h:
        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::setWindowIsKey):
        (LayoutTestController::setMainFrameIsFirstResponder):
        * DumpRenderTree/qt/LayoutTestControllerQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-28 Andrei Popescu <andreip@google.com>
eric@webkit.org [Tue, 29 Dec 2009 06:49:58 +0000 (06:49 +0000)]
2009-12-28  Andrei Popescu  <andreip@google.com>

        Reviewed by Dmitry Titov.

        On Android, ResourceHandle instances make use of a pointer to a
        ResourceLoaderAndroid pointer. This needs to be stored in order to later cancel
        the load, if necessary. Since this pointer is an internal implementation
        details of ResourceHandle on Android, it needs to be stored in the
        ResourceHandleInternal class. This patch adds this pointer.
        https://bugs.webkit.org/show_bug.cgi?id=32873

        No new tests needed, this is platform-specific code.

        * platform/network/ResourceHandle.h:
        * platform/network/ResourceHandleInternal.h:
        (WebCore::ResourceHandleInternal::ResourceHandleInternal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-28 Charles Wei <charles.wei@torchmobile.com.cn>
eric@webkit.org [Tue, 29 Dec 2009 06:41:26 +0000 (06:41 +0000)]
2009-12-28  Charles Wei  <charles.wei@torchmobile.com.cn>

        Reviewed by Maciej Stachowiak.

        Remove the macro ENABLE(XHTMLMP) for noscriptAreateErrorCheck in HTMLParser,
        since with XHTMLMP enabled, it's not checking create Errors,  and then contents inside
        <noscript> are always parsed and rendered.
        https://bugs.webkit.org/show_bug.cgi?id=32706

        Tests: fast/parser/noscript-with-javascript-disabled.html
               fast/parser/noscript-with-javascript-enabled.html

        * html/HTMLParser.cpp:
        (WebCore::HTMLParser::getNode):
2009-12-28  Charles Wei  <charles.wei@torchmobile.com.cn>

        Reviewed by Maciej Stachowiak.

        Add test cases for <noscript> with both Javascript enabled and disabled
        https://bugs.webkit.org/show_bug.cgi?id=32706

        * fast/parser/noscript-with-javascript-disabled-expected.txt: Added.
        * fast/parser/noscript-with-javascript-disabled.html: Added.
        * fast/parser/noscript-with-javascript-enabled-expected.txt: Added.
        * fast/parser/noscript-with-javascript-enabled.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-28 Kinuko Yasuda <kinuko@chromium.org>
eric@webkit.org [Tue, 29 Dec 2009 06:33:19 +0000 (06:33 +0000)]
2009-12-28  Kinuko Yasuda  <kinuko@chromium.org>

        Reviewed by Maciej Stachowiak.

        Fixed isKeypadEvent behavior for chromium/Mac to correctly report
        keyLocation as DOM_KEY_LOCATION_NUMPAD for numeric pad key events.
        https://bugs.webkit.org/show_bug.cgi?id=28247

        Test: fast/events/keydown-numpad-keys.html

        * src/mac/WebInputEventFactory.mm:
        (WebKit::isKeypadEvent):
2009-12-28  Kinuko Yasuda  <kinuko@chromium.org>

        Reviewed by Maciej Stachowiak.

        Fixed isKeypadEvent behavior for Mac to correctly report keyLocation
        as DOM_KEY_LOCATION_NUMPAD for numeric pad key events.
        https://bugs.webkit.org/show_bug.cgi?id=28247

        Test: fast/events/keydown-numpad-keys.html

        * platform/mac/KeyEventMac.mm:
        (WebCore::isKeypadEvent):
2009-12-28  Kinuko Yasuda  <kinuko@chromium.org>

        Reviewed by Maciej Stachowiak.

        Added a layout-test that tests if numeric pad arrow key
        events are correctly reported with keyLocation as
        DOM_KEY_LOCATION_NUMPAD.  Currently this test only passes on Mac.
        https://bugs.webkit.org/show_bug.cgi?id=28247

        * fast/events/keydown-numpad-keys-expected.txt: Added.
        * fast/events/keydown-numpad-keys.html: Added.
        * fast/events/script-tests/keydown-numpad-keys.js: Added.
        (recordKeyEvent):
        (testKeyEventWithLocation):

        * platform/gtk/Skipped: fast/events/keydown-numpad-keys.html added.
        * platform/qt/Skipped: fast/events/keydown-numpad-keys.html added.
        * platform/win/Skipped: fast/events/keydown-numpad-keys.html added.
2009-12-28  Kinuko Yasuda  <kinuko@chromium.org>

        Reviewed by Maciej Stachowiak.

        Extended EventSender.keyDown method to take another (3rd) argument
        for indicating the keyLocation to make numeric pad key events testable.
        Expected values for the argument is one of the KeyLocationCode
        specified in DOM Level 3
        (http://www.w3.org/TR/DOM-Level-3-Events/#events-keyboardevents).
        https://bugs.webkit.org/show_bug.cgi?id=28247

        Test: fast/events/keydown-numpad-keys.html

        * DumpRenderTree/mac/EventSendingController.mm:
        (+[EventSendingController isSelectorExcludedFromWebScript:]):
        (+[EventSendingController webScriptNameForSelector:]):
        (-[EventSendingController keyDown:withModifiers:withLocation:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-28 Mike Moretti <webkit9@mordent.com>
eric@webkit.org [Tue, 29 Dec 2009 06:25:16 +0000 (06:25 +0000)]
2009-12-28  Mike Moretti  <webkit9@mordent.com>

        Reviewed by Darin Adler.

        Fix bug 28245 - problem with inserting a span into a long text block causing a crash because of a null string

        Test: fast/dom/insert-span-into-long-text-bug-28245.html

        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::RenderBlock::findNextLineBreak):
2009-12-28  Mike Moretti  <webkit9@mordent.com>

        Reviewed by Darin Adler.

        Fix bug 28245 - problem with inserting a span into a long text block causing a crash because of a null string

        * fast/dom/insert-span-into-long-text-bug-28245-expected.txt: Added.
        * fast/dom/insert-span-into-long-text-bug-28245.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-28 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Mon, 28 Dec 2009 23:46:16 +0000 (23:46 +0000)]
2009-12-28  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Skip test that is failing since it was checked in, and some tests
        that need results.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-28 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Mon, 28 Dec 2009 23:34:40 +0000 (23:34 +0000)]
2009-12-28  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Rubber-stamped by Xan Lopez.

        Follow Apple's decision to disable HTML DataGrid by default.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-28 Ariya Hidayat <ariya.hidayat@gmail.com>
ariya@webkit.org [Mon, 28 Dec 2009 23:32:17 +0000 (23:32 +0000)]
2009-12-28  Ariya Hidayat  <ariya.hidayat@gmail.com>

        Unreviewed, update my email address.

        * Scripts/modules/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-28 Gustavo Noronha Silva <gns@gnome.org>
kov@webkit.org [Mon, 28 Dec 2009 23:15:45 +0000 (23:15 +0000)]
2009-12-28  Gustavo Noronha Silva  <gns@gnome.org>

        Reviewed by Ariya Hidayat.

        Fix warnings when generating files using gperf. The warnings are
        currently harmless, but some changes in the build system may make
        them fatal.

        [GTK] Build time must be reduced
        https://bugs.webkit.org/show_bug.cgi?id=32921

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-28 Shu Chang <Chang.Shu@nokia.com>
eric@webkit.org [Mon, 28 Dec 2009 20:28:47 +0000 (20:28 +0000)]
2009-12-28  Shu Chang  <Chang.Shu@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] Delete ThreadPrivate instance after it is finished.
        https://bugs.webkit.org/show_bug.cgi?id=32614

        * wtf/qt/ThreadingQt.cpp:
        (WTF::ThreadMonitor::instance):
        (WTF::ThreadMonitor::threadFinished):
        (WTF::createThreadInternal):
        (WTF::detachThread):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-28 Laszlo Gombos <laszlo.1.gombos@nokia.com>
eric@webkit.org [Mon, 28 Dec 2009 19:15:18 +0000 (19:15 +0000)]
2009-12-28  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Adam Barth.

        [Qt] Fix build break for Qt 4.4
        https://bugs.webkit.org/show_bug.cgi?id=30327

        No new tests, as there is no new functionality.

        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::clipOut): Use intersected() instead of
        operator &, which was only introduced in Qt version 4.5.

        * platform/qt/ScrollbarThemeQt.cpp:
        (WebCore::ScrollbarThemeQt::paintScrollCorner): Pass ColorSpace
        argument to fillColor() introduced in r50760
2009-12-28  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Adam Barth.

        [Qt] Fix build break for Qt 4.4
        https://bugs.webkit.org/show_bug.cgi?id=30327

        * DumpRenderTree/qt/DumpRenderTreeQt.cpp: Include QLocale
        * DumpRenderTree/qt/LayoutTestControllerQt.cpp: Ditto.
        * QtLauncher/main.cpp:
        (MainWindow::MainWindow): Qt::WA_TranslucentBackground was
        introduced in Qt version 4.5

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-28 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 28 Dec 2009 17:35:14 +0000 (17:35 +0000)]
2009-12-28  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        [bzt] Add an edit-changelog command
        https://bugs.webkit.org/show_bug.cgi?id=32986

        This command makes it easier to edit ChangeLogs.  It's similar to
        prepare-ChangeLog -o, except it works with already existing ChangeLogs.

        * Scripts/modules/commands/upload.py:
        * Scripts/modules/commands/upload_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-28 Adam Barth <abarth@webkit.org>
eric@webkit.org [Mon, 28 Dec 2009 17:06:28 +0000 (17:06 +0000)]
2009-12-28  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        [bzt] Create an ASAD command for uploading a patch
        https://bugs.webkit.org/show_bug.cgi?id=32979

        The create-review command goes through the whole process of preparing a
        code review, including creating a bug, editing the ChangeLogs, and
        uploading the patch.  It is indeed the All Sing, All Dance upload
        command.

        * Scripts/modules/buildsteps.py:
        * Scripts/modules/commands/upload.py:
        * Scripts/modules/commands/upload_unittest.py:
        * Scripts/modules/mock_bugzillatool.py:
        * Scripts/modules/user.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-28 Patrick Gansterer <paroga@paroga.com>
eric@webkit.org [Mon, 28 Dec 2009 16:58:28 +0000 (16:58 +0000)]
2009-12-28  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Maciej Stachowiak.

        Cleanup of #define JS_EXPORT.

        * API/JSBase.h:
2009-12-28  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Maciej Stachowiak.

        Use JS_NO_EXPORT for JSBase.h.

        * wxwk-settings.bkl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-28 Estêvão Samuel Procópio <tevaum@gmail.com>
eric@webkit.org [Mon, 28 Dec 2009 16:48:55 +0000 (16:48 +0000)]
2009-12-28  Estêvão Samuel Procópio  <tevaum@gmail.com>

        Reviewed by Gustavo Noronha Silva.

        Bug 32940: [GTK] Changing the download throttle conditions.
        https://bugs.webkit.org/show_bug.cgi?id=32716

        The WebKitDownload progress notification was taking long to
        update. This fix makes notification happens each 0.7 secs
        or when the progress ups in 1%.

        * WebKit/gtk/webkit/webkitdownload.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-28 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Mon, 28 Dec 2009 13:48:53 +0000 (13:48 +0000)]
2009-12-28  Kent Tamura  <tkent@chromium.org>

        Reviewed by Maciej Stachowiak.

        Implement HTML5 <article> element.
        https://bugs.webkit.org/show_bug.cgi?id=32942

        The new test file tests:
        - <p> closing,
        - Residual style, and
        - FormatBlock.

        * fast/html/article-element-expected.txt: Added.
        * fast/html/article-element.html: Added.
        * fast/html/script-tests/article-element.js: Added.

2009-12-28  Kent Tamura  <tkent@chromium.org>

        Reviewed by Maciej Stachowiak.

        Implement HTML5 <article> element.
        https://bugs.webkit.org/show_bug.cgi?id=32936

        <article> should behave the same as <nav> and <section>.

        Test: fast/html/article-element.html

        * css/html.css: Add article as a block element.
        * editing/htmlediting.cpp:
        (WebCore::validBlockTag): Add articleTag.
        * html/HTMLElement.cpp:
        (WebCore::HTMLElement::tagPriority): Returns 5 for articleTag.
        (WebCore::blockTagList): Add articleTag.
        * html/HTMLParser.cpp:
        (WebCore::HTMLParser::getNode): Add articleTag.
        * html/HTMLTagNames.in: Add article.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-28 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 28 Dec 2009 08:22:16 +0000 (08:22 +0000)]
2009-12-28  Adam Barth  <abarth@webkit.org>

        Unreviewed "build" fix (with test!).

        * Scripts/modules/bugzilla.py:
        * Scripts/modules/bugzilla_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-27 Eric Seidel <eric@webkit.org>
eric@webkit.org [Mon, 28 Dec 2009 07:59:00 +0000 (07:59 +0000)]
2009-12-27  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Add more awesome bug-parsing logic to bugzilla.py in preparation for assign-to-committer command
        https://bugs.webkit.org/show_bug.cgi?id=32980

        * Scripts/modules/bugzilla.py:
         - Add a new _parse_bug_page function and use it in fetch_attachments_from_bug
         - Replace fetch_title_from_bug with a new fetch_bug call instead.
         - Use list comprehensions where possible to reduce code duplication.
        * Scripts/modules/bugzilla_unittest.py:
         - Add a minimal bug parsing test.
         - Share code between bug parsing and attachment parsing tests with _assert_dictionaries_equal
        * Scripts/modules/commands/upload.py:
         - Use fetch_bug(bug_id)["title"] instead of fetch_title_from_bug

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-27 Adam Barth <abarth@webkit.org>
eric@webkit.org [Mon, 28 Dec 2009 07:05:53 +0000 (07:05 +0000)]
2009-12-27  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Status bubble shouldn't be transparent for bots that haven't run yet
        https://bugs.webkit.org/show_bug.cgi?id=32977

        * QueueStatusServer/templates/statusbubble.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-27 Adam Barth <abarth@webkit.org>
eric@webkit.org [Mon, 28 Dec 2009 06:58:03 +0000 (06:58 +0000)]
2009-12-27  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        [QueueStatusServer] Run gc cron job less often
        https://bugs.webkit.org/show_bug.cgi?id=32958

        Now that we've cleaned out the backlog of idle messages, we don't need
        to run the gc job every half hour.  We could also stop logging the idle
        messages, but this seems easier for the time being.

        * QueueStatusServer/cron.yaml:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRubber stamped by Adam Barth.
mjs@apple.com [Mon, 28 Dec 2009 04:58:22 +0000 (04:58 +0000)]
Rubber stamped by Adam Barth.

Put media/audio-delete-while-step-button-clicked.html back in the mac skipped list because
I think it's making other media tests fail sporadically.

* platform/mac-tiger/Skipped:
* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-27 Jakub Wieczorek <faw217@gmail.com>
eric@webkit.org [Mon, 28 Dec 2009 03:39:02 +0000 (03:39 +0000)]
2009-12-27  Jakub Wieczorek  <faw217@gmail.com>

        Reviewed by Eric Seidel.

        [Qt] Support upload progress events in XMLHttpRequest
        https://bugs.webkit.org/show_bug.cgi?id=32969

        Make QNetworkReplyHandler report the upload progress to the client.

        Already covered by tests:
        http/tests/xmlhttprequest/upload-onload-event.html
        http/tests/xmlhttprequest/upload-onloadstart-event.html
        http/tests/xmlhttprequest/upload-progress-events.html
        http/tests/xmlhttprequest/upload-onprogress-event.html

        which have been unskipped.

        * platform/network/qt/QNetworkReplyHandler.cpp:
        (WebCore::QNetworkReplyHandler::uploadProgress):
        (WebCore::QNetworkReplyHandler::start):
        * platform/network/qt/QNetworkReplyHandler.h:
2009-12-27  Jakub Wieczorek  <faw217@gmail.com>

        Reviewed by Eric Seidel.

        [Qt] Support upload progress events in XMLHttpRequest
        https://bugs.webkit.org/show_bug.cgi?id=32969

        Make QNetworkReplyHandler report the upload progress to the client.

        Already covered by tests:
        http/tests/xmlhttprequest/upload-onload-event.html
        http/tests/xmlhttprequest/upload-onloadstart-event.html
        http/tests/xmlhttprequest/upload-progress-events.html
        http/tests/xmlhttprequest/upload-onprogress-event.html

        which have been unskipped.

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRubber stamped by Adam Barth.
mjs@apple.com [Mon, 28 Dec 2009 03:17:44 +0000 (03:17 +0000)]
Rubber stamped by Adam Barth.

Add media/audio-delete-while-step-button-clicked.html back to the Tiger skipped list.

* platform/mac-tiger/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRubber stamped by Adam Barth.
mjs@apple.com [Mon, 28 Dec 2009 02:28:46 +0000 (02:28 +0000)]
Rubber stamped by Adam Barth.

Removed some tests from the skipped list that are not failing on my system.

* platform/mac-snowleopard/Skipped:
* platform/mac/Skipped:
* platform/mac/fast/forms/menulist-style-color-expected.checksum: Added.
* platform/mac/fast/forms/menulist-style-color-expected.png: Added.
* platform/mac/fast/forms/menulist-style-color-expected.txt: Added.
* platform/mac/plugins/qt-qwidget-plugin-expected.checksum: Added.
* platform/mac/plugins/qt-qwidget-plugin-expected.png: Added.
* platform/mac/plugins/qt-qwidget-plugin-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-27 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Mon, 28 Dec 2009 02:01:57 +0000 (02:01 +0000)]
2009-12-27  Daniel Bates  <dbates@webkit.org>

        Reviewed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=32896

        Fixes an issue where bugzilla-tool tries to read the username and password from
        Git regardless of whether Git is installed. In particular, if Git is not
        installed then bugzilla-tool dies (with a trace) when it attempts to query Git
        for the authentication credentials to log into bugs.webkit.org.

        Moreover, modifies Executive.run_command to catch and pass OSError exceptions to
        the specified error handler. For instance, the specified error handler will now
        be called when the command does not exist (i.e. OSError errno 2).

        * Scripts/modules/credentials.py: Added check for Git.
        * Scripts/modules/credentials_unittest.py: Added test method
        test_read_credentials_with_SVN.
        * Scripts/modules/executive.py: Modified method run_command to catch
        OSError exceptions (i.e [Errno 2] No such file or directory) and call
        the specified error handler.
        * Scripts/modules/executive_unittest.py: Added.
        * Scripts/run-webkit-unittests: Added import executive_unittest.py.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRubber stamped by Cameron Zwarich.
mjs@apple.com [Mon, 28 Dec 2009 01:25:32 +0000 (01:25 +0000)]
Rubber stamped by Cameron Zwarich.

Skip fast/images/size-failure.html on SnowLeopard because it
tickles a CG bug that makes it time out.

* platform/mac-snowleopard/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-27 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Sun, 27 Dec 2009 23:48:48 +0000 (23:48 +0000)]
2009-12-27  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Dan Bernstein.

        fast/forms/basic-selects.html is failing on SnowLeopard
        https://bugs.webkit.org/show_bug.cgi?id=32960

        The recently added fast/forms/basic-selects.html is failing on SnowLeopard; the
        result checked in is only valid for Leopard and earlier, because SnowLeopard
        slightly changed the disabled text color.

        Move the pre-SL result to platform/mac-leopard and generate new
        SnowLeopard results in platform/mac.

        * platform/mac-leopard/fast/forms/basic-selects-expected.checksum: Copied from platform/mac/fast/forms/basic-selects-expected.checksum.
        * platform/mac-leopard/fast/forms/basic-selects-expected.png: Copied from platform/mac/fast/forms/basic-selects-expected.png.
        * platform/mac-leopard/fast/forms/basic-selects-expected.txt: Copied from platform/mac/fast/forms/basic-selects-expected.txt.
        * platform/mac/fast/forms/basic-selects-expected.checksum:
        * platform/mac/fast/forms/basic-selects-expected.png:
        * platform/mac/fast/forms/basic-selects-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-27 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Sun, 27 Dec 2009 22:22:31 +0000 (22:22 +0000)]
2009-12-27  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        SVG: Stop rendering of objects with empty mask and filter content
        https://bugs.webkit.org/show_bug.cgi?id=32968

        It's not neccessary to continue rendering of an object and its' childs
        if the mask clips the complete content away.
        The same for filters, if the filter rendering is discontinued or either
        width or height are zero.
        We might also stop rendering if repaintRectInLocalCoordinates is empty.
        But it needs to be fixed first.

        Test: svg/custom/empty-mask.svg

        * rendering/RenderPath.cpp:
        (WebCore::RenderPath::paint):
        * rendering/RenderSVGContainer.cpp:
        (WebCore::RenderSVGContainer::paint):
        * rendering/RenderSVGImage.cpp:
        (WebCore::RenderSVGImage::paint):
        * rendering/RenderSVGRoot.cpp:
        (WebCore::RenderSVGRoot::paint):
        * rendering/SVGRenderSupport.cpp:
        (WebCore::SVGRenderBase::prepareToRenderSVGContent):
        * rendering/SVGRenderSupport.h:
        * rendering/SVGRootInlineBox.cpp:
        (WebCore::SVGRootInlineBox::paint):
        * svg/SVGMaskElement.cpp:
        (WebCore::SVGMaskElement::drawMaskerContent):
        * svg/SVGMaskElement.h:
        * svg/graphics/SVGResourceFilter.cpp:
        (WebCore::SVGResourceFilter::prepareFilter):
        (WebCore::SVGResourceFilter::applyFilter):
        * svg/graphics/SVGResourceFilter.h:
        * svg/graphics/SVGResourceMasker.cpp:
        (WebCore::SVGResourceMasker::SVGResourceMasker):
        (WebCore::SVGResourceMasker::applyMask):
        * svg/graphics/SVGResourceMasker.h:

2009-12-27  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        SVG: Stop rendering of objects with empty mask and filter content
        https://bugs.webkit.org/show_bug.cgi?id=32968

        Check if the content is not drawn, if the mask clips the complete
        content away.
        mask-excessive-malloc needed an update. This patch stops rendering
        if there is no content in mask. But it's intention is to test
        big masking images.

        * platform/mac/svg/custom/empty-mask-expected.checksum: Added.
        * platform/mac/svg/custom/empty-mask-expected.png: Added.
        * platform/mac/svg/custom/empty-mask-expected.txt: Added.
        * platform/mac/svg/custom/mask-excessive-malloc-expected.checksum:
        * platform/mac/svg/custom/mask-excessive-malloc-expected.png:
        * platform/mac/svg/custom/mask-excessive-malloc-expected.txt:
        * svg/custom/empty-mask.svg: Added.
        * svg/custom/mask-excessive-malloc.svg:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-27 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Sun, 27 Dec 2009 19:25:31 +0000 (19:25 +0000)]
2009-12-27  Daniel Bates  <dbates@webkit.org>

        Unreviewed. Added missing file style_unittest.py that wasn't committed
        in change set 52541 (http://trac.webkit.org/changeset/52541) as part of
        the patch for bug #32592.

        * Scripts/modules/style_unittest.py: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-27 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Sun, 27 Dec 2009 19:12:49 +0000 (19:12 +0000)]
2009-12-27  Daniel Bates  <dbates@webkit.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=32964

        [bzt] Updated the unit test based on the change made in bug #32951.

        The change made in bug #32951 added the command-line argument:
        --makeargs="-j8" to the build-webkit command. However, the associated
        unit test was not updated.

        * Scripts/modules/webkitport_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-27 Christian Dywan <christian@twotoasts.de>
christian@webkit.org [Sun, 27 Dec 2009 18:19:38 +0000 (18:19 +0000)]
2009-12-27  Christian Dywan  <christian@twotoasts.de>

        Reviewed by Eric Seidel.

        [GTK] Spell Check Suggestions (Do not work)
        https://bugs.webkit.org/show_bug.cgi?id=30908

        * platform/gtk/ContextMenuItemGtk.cpp:
        (WebCore::ContextMenuItem::ContextMenuItem):
        (WebCore::ContextMenuItem::title):
        (WebCore::ContextMenuItem::setTitle): Implement the 'title' member
        and set the title from the native menu item.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-27 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Sun, 27 Dec 2009 17:08:50 +0000 (17:08 +0000)]
2009-12-27  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        SVG Mask result wrong, if two different objects call the same mask id
        https://bugs.webkit.org/show_bug.cgi?id=32787

        At the moment we create one resource per maskId. Some resources (like mask)
        create ImageBuffers and depends on the properties of the RenderObject,
        thus we can't use it for a second object.
        This patch stores multiple mask resources for one maskId and different
        RenderObject can use the same maskId.
        Clipper, Filter and Patterns also need to store multiple resources later.

        Test: svg/custom/mask-on-multiple-objects.svg

        * rendering/RenderPath.cpp:
        (WebCore::RenderPath::drawMarkersIfNeeded):
        * rendering/RenderSVGContainer.cpp:
        (WebCore::RenderSVGContainer::selfWillPaint):
        * rendering/RenderSVGGradientStop.cpp:
        (WebCore::RenderSVGGradientStop::styleDidChange):
        * rendering/RenderSVGRoot.cpp:
        (WebCore::RenderSVGRoot::selfWillPaint):
        * rendering/SVGRenderSupport.cpp:
        (WebCore::SVGRenderBase::prepareToRenderSVGContent):
        (WebCore::SVGRenderBase::filterBoundingBoxForRenderer):
        * rendering/SVGRenderTreeAsText.cpp:
        (WebCore::writeRenderResources):
        * svg/SVGClipPathElement.cpp:
        (WebCore::SVGClipPathElement::canvasResource):
        * svg/SVGClipPathElement.h:
        * svg/SVGFilterElement.cpp:
        (WebCore::SVGFilterElement::canvasResource):
        * svg/SVGFilterElement.h:
        * svg/SVGGradientElement.cpp:
        (WebCore::SVGGradientElement::canvasResource):
        * svg/SVGGradientElement.h:
        * svg/SVGMarkerElement.cpp:
        (WebCore::SVGMarkerElement::canvasResource):
        * svg/SVGMarkerElement.h:
        * svg/SVGMaskElement.cpp:
        (WebCore::SVGMaskElement::svgAttributeChanged):
        (WebCore::SVGMaskElement::childrenChanged):
        (WebCore::SVGMaskElement::canvasResource):
        * svg/SVGMaskElement.h:
        * svg/SVGPatternElement.cpp:
        (WebCore::SVGPatternElement::canvasResource):
        * svg/SVGPatternElement.h:
        * svg/SVGStyledElement.cpp:
        (WebCore::SVGStyledElement::invalidateResourcesInAncestorChain):
        * svg/SVGStyledElement.h:
        (WebCore::SVGStyledElement::canvasResource):
        * svg/graphics/SVGPaintServer.cpp:
        (WebCore::getPaintServerById):
        (WebCore::SVGPaintServer::fillPaintServer):
        (WebCore::SVGPaintServer::strokePaintServer):
        * svg/graphics/SVGPaintServer.h:
        * svg/graphics/SVGResource.cpp:
        (WebCore::getResourceById):
        * svg/graphics/SVGResource.h:
        * svg/graphics/SVGResourceClipper.cpp:
        (WebCore::getClipperById):
        * svg/graphics/SVGResourceClipper.h:
        * svg/graphics/SVGResourceFilter.cpp:
        (WebCore::getFilterById):
        * svg/graphics/SVGResourceFilter.h:
        * svg/graphics/SVGResourceMarker.cpp:
        (WebCore::getMarkerById):
        * svg/graphics/SVGResourceMarker.h:
        * svg/graphics/SVGResourceMasker.cpp:
        (WebCore::getMaskerById):
        * svg/graphics/SVGResourceMasker.h:

2009-12-27  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        SVG Mask result wrong, if two different objects call the same mask id
        https://bugs.webkit.org/show_bug.cgi?id=32787

        Two rects with different sizes and positions call the same mask id. Both
        rects should be masked to two circles, dependent on the properties of the
        rects.

        * platform/mac/svg/custom/mask-on-multiple-objects-expected.checksum: Added.
        * platform/mac/svg/custom/mask-on-multiple-objects-expected.png: Added.
        * platform/mac/svg/custom/mask-on-multiple-objects-expected.txt: Added.
        * svg/custom/mask-on-multiple-objects.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-27 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Sun, 27 Dec 2009 14:38:34 +0000 (14:38 +0000)]
2009-12-27  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        Cleanup RenderPath code, related to markers. Pass around
        PaintInfo objects instead of GraphicsContext directly, to
        avoid having to recreate a new PaintInfo object in
        SVGResourceMarker::draw().

        No layout test changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRubber-stamped by Simon Hausmann.
ossy@webkit.org [Sun, 27 Dec 2009 13:27:34 +0000 (13:27 +0000)]
Rubber-stamped by Simon Hausmann.

[Qt] DRT sideeffect (authentication)
https://bugs.webkit.org/show_bug.cgi?id=32961

* platform/qt/Skipped: http/tests/xmlhttprequest/failed-auth.html added temorarily (until fix).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRubber-stamped by Simon Hausmann.
ossy@webkit.org [Sun, 27 Dec 2009 13:15:28 +0000 (13:15 +0000)]
Rubber-stamped by Simon Hausmann.

Patch by Robert Hogan <robert@roberthogan.net> on 2009-12-27
Remove successful tests from qt skipped list

https://bugs.webkit.org/show_bug.cgi?id=32948

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRubber-stamped by Simon Hausmann.
ossy@webkit.org [Sun, 27 Dec 2009 09:42:32 +0000 (09:42 +0000)]
Rubber-stamped by Simon Hausmann.

Patch by Robert Hogan <robert@roberthogan.net> on 2009-12-27
Remove duplicate entries from Qt skipped list

https://bugs.webkit.org/show_bug.cgi?id=32947

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-27 Yael Aharon <yael.aharon@nokia.com>
eric@webkit.org [Sun, 27 Dec 2009 09:11:20 +0000 (09:11 +0000)]
2009-12-27  Yael Aharon  <yael.aharon@nokia.com>

        Reviewed by Darin Adler.

        check-webkit-style should not mark moc files inclusion as errors
        https://bugs.webkit.org/show_bug.cgi?id=32669

        Add a new header type for moc files, and skip them when checking the order of header files.

        * Scripts/modules/cpp_style.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-27 Patrick Gansterer <paroga@paroga.com>
eric@webkit.org [Sun, 27 Dec 2009 08:55:43 +0000 (08:55 +0000)]
2009-12-27  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Eric Seidel.

        WinCE buildfix (added missing header)

        * platform/text/wince/TextBreakIteratorWince.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-27 Patrick Gansterer <paroga@paroga.com>
eric@webkit.org [Sun, 27 Dec 2009 08:47:49 +0000 (08:47 +0000)]
2009-12-27  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Eric Seidel.

        Buildfix after r50760 and some style fixes.

        * rendering/RenderThemeWince.cpp:
        (WebCore::RenderThemeWince::paintSearchFieldCancelButton):
        (WebCore::RenderThemeWince::paintSliderTrack):
        (WebCore::RenderThemeWince::paintSliderThumb):
        (WebCore::RenderThemeWince::paintMediaMuteButton):
        (WebCore::RenderThemeWince::paintMediaPlayButton):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-27 Patrick Gansterer <paroga@paroga.com>
eric@webkit.org [Sun, 27 Dec 2009 08:39:57 +0000 (08:39 +0000)]
2009-12-27  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Adam Barth.

        WinCE buildfixes (missing headers and unsupported HWND_MESSAGE)

        * platform/wince/MIMETypeRegistryWince.cpp:
        * platform/wince/SearchPopupMenuWince.cpp:
        * platform/wince/SharedTimerWince.cpp:
        (WebCore::initializeOffScreenTimerWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-27 Patrick Gansterer <paroga@paroga.com>
eric@webkit.org [Sun, 27 Dec 2009 08:32:01 +0000 (08:32 +0000)]
2009-12-27  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Adam Barth.

        WinCE buildfix (HWND_MESSAGE isn't supported there)

        * wtf/win/MainThreadWin.cpp:
        (WTF::initializeMainThreadPlatform):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-27 Patrick Gansterer <paroga@paroga.com>
eric@webkit.org [Sun, 27 Dec 2009 08:24:12 +0000 (08:24 +0000)]
2009-12-27  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Adam Barth.

        Added a file with WinMain function to link agains in WinCE.

        * os-win32/WinMain.cpp: Added.
        (convertToUtf8):
        (WinMain):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-26 Eric Seidel <eric@webkit.org>
eric@webkit.org [Sun, 27 Dec 2009 07:36:32 +0000 (07:36 +0000)]
2009-12-26  Eric Seidel  <eric@webkit.org>

        No review, rolling out r52554.
        http://trac.webkit.org/changeset/52554

        https://bugs.webkit.org/show_bug.cgi?id=32955
        The original change was covered under
        https://bugs.webkit.org/show_bug.cgi?id=32913

        r52554 was itself a rollout of r52536.
        However it caused two layout tests to fail on Leopard:
        storage/open-database-while-transaction-in-progress.html
        svg/W3C-SVG-1.1/filters-conv-01-f.svg (no clue why?)

        So I'm rolling out the rollout in an attempt to get the bots green.
        r52554 did not explain why it was rolled out, so I do not know
        what might fail for Chromium after this change.  I warned the folks
        in #chromium that it was coming.

        * storage/Database.cpp:
        (WebCore::Database::openDatabase):
        (WebCore::Database::Database):
        (WebCore::Database::performOpenAndVerify):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-26 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sun, 27 Dec 2009 06:50:53 +0000 (06:50 +0000)]
2009-12-26  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        [bzt] Make the qt build go fast
        https://bugs.webkit.org/show_bug.cgi?id=32951

        Make use of multiple cores, if available.

        * Scripts/modules/webkitport.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdded Radar URLs
mitz@apple.com [Sun, 27 Dec 2009 01:28:58 +0000 (01:28 +0000)]
Added Radar URLs

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoREGRESSION (r47255): Extra Large Amount of Empty Space
mitz@apple.com [Sun, 27 Dec 2009 01:27:29 +0000 (01:27 +0000)]
REGRESSION (r47255): Extra Large Amount of Empty Space
https://bugs.webkit.org/show_bug.cgi?id=32690

Reviewed by Sam Weinig.

WebCore:

Test: fast/block/float/clear-to-fit.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::getClearDelta): Only clear floats as needed to
fit the child on the line.

LayoutTests:

* fast/block/float/clear-to-fit-expected.checksum: Added.
* fast/block/float/clear-to-fit-expected.png: Added.
* fast/block/float/clear-to-fit-expected.txt: Added.
* fast/block/float/clear-to-fit.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRubber-stamped by Simon Hausmann.
ossy@webkit.org [Sat, 26 Dec 2009 09:40:23 +0000 (09:40 +0000)]
Rubber-stamped by Simon Hausmann.

[Qt] Skipping some flakey tests.
https://bugs.webkit.org/show_bug.cgi?id=32946

* platform/qt/Skipped:
 - http/tests/cookies/simple-cookies-expired.html added.
 - storage/database-lock-after-reload.html added.
 - storage/empty-statement.html added.
 - storage/execute-sql-args.html added.
 - storage/hash-change-with-xhr.html added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-25 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Sat, 26 Dec 2009 05:26:59 +0000 (05:26 +0000)]
2009-12-25  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Adler.

        Implement HTML5 section element.
        https://bugs.webkit.org/show_bug.cgi?id=32936

        <section> should behave the same as <nav>.

        Test: fast/html/section-element.html

        * css/html.css: Add section as a block element.
        * editing/htmlediting.cpp:
        (WebCore::validBlockTag): Add sectionTag.
        * html/HTMLElement.cpp:
        (WebCore::HTMLElement::tagPriority): Returns 5 for sectionTag.
        (WebCore::blockTagList): Add sectionTag.
        * html/HTMLParser.cpp:
        (WebCore::HTMLParser::getNode): Add sectionTag.
        * html/HTMLTagNames.in: Add section.

2009-12-25  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Adler.

        Implement HTML5 section element.
        https://bugs.webkit.org/show_bug.cgi?id=32936

        The new test file tests:
        - <p> closing,
        - Residual style, and
        - FormatBlock.

        * fast/html/script-tests/TEMPLATE.html: Added.
        * fast/html/script-tests/section-element.js: Added.
        * fast/html/section-element-expected.txt: Added.
        * fast/html/section-element.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago* StringsNotToBeLocalized.txt: Updated for recent changes.
darin@apple.com [Sat, 26 Dec 2009 04:34:08 +0000 (04:34 +0000)]
* StringsNotToBeLocalized.txt: Updated for recent changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-25 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Fri, 25 Dec 2009 23:58:20 +0000 (23:58 +0000)]
2009-12-25  Daniel Bates  <dbates@rim.com>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=32682

        Fixes an issue where checkFrameworks always dies with an error under Windows
        since the clause "unless (-x $path)" is always satisfied because files under
        Windows do not have an explict executable bit.

        * Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-25 Daniel Bates <dbates@webkit.org>
dbates@webkit.org [Fri, 25 Dec 2009 23:32:31 +0000 (23:32 +0000)]
2009-12-25  Daniel Bates  <dbates@webkit.org>

        Reviewed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=32938

        Cleans up XSSAuditor.

        Currently, we pass various parameters through to XSSAuditor::findInRequest
        that are used to determine how to decode the HTTP input parameters so that
        we can perform a match against the script source. Instead, we have defined
        a structure XSSAuditor::FindTask that can hold all of these parameters.

        No functionality was changed. So, no new tests.

        * page/XSSAuditor.cpp:
        (WebCore::XSSAuditor::canEvaluate): Modified to use struct
        XSSAuditor::FindTask.
        (WebCore::XSSAuditor::canEvaluateJavaScriptURL): Ditto.
        (WebCore::XSSAuditor::canCreateInlineEventListener): Ditto.
        (WebCore::XSSAuditor::canLoadExternalScriptFromSrc): Ditto.
        (WebCore::XSSAuditor::canLoadObject): Ditto.
        (WebCore::XSSAuditor::canSetBaseElementURL): Ditto.
        (WebCore::XSSAuditor::findInRequest): Ditto.
        * page/XSSAuditor.h:
        (WebCore::XSSAuditor::FindTask::FindTask): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRubber-stamped by Simon Hausmann.
ossy@webkit.org [Fri, 25 Dec 2009 23:11:47 +0000 (23:11 +0000)]
Rubber-stamped by Simon Hausmann.

[Qt] svg/custom/global-constructors.html skipped
temporarily (until fix) because of missing variables.
Platform dependent expected files updated after r52559.

https://bugs.webkit.org/show_bug.cgi?id=32941

* platform/qt/Skipped: svg/custom/global-constructors.html added until fix.
* platform/qt/fast/dom/Window/window-properties-expected.txt: updated.
* platform/qt/fast/dom/prototype-inheritance-expected.txt: updated.
* platform/qt/fast/js/global-constructors-expected.txt: updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-25 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Fri, 25 Dec 2009 21:03:45 +0000 (21:03 +0000)]
2009-12-25  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        DOMWindow is missing lots of SVG* constructor objects
        https://bugs.webkit.org/show_bug.cgi?id=20430

        Expose all implemented SVG 1.1 constructors.

        Test: svg/custom/global-constructors.js

        * bindings/v8/V8Index.cpp: Add missing includes for SVGFontFaceElement & SVGMissingGlyphElement
        * bindings/v8/V8Index.h: Add misisng SVGFontFaceElement & SVGMissingGlyphElement declarations.
        * page/DOMWindow.idl: Add a bunch of new SVG object ctors.
        * svg/SVGAnimatedPathData.idl: Add OmitConstructor flag, as this is a SVG MI class, which is not exposable at the moment.
        * svg/SVGAnimatedPoints.idl: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-25 Alexander Pavlov <apavlov@chromium.org>
pfeldman@chromium.org [Fri, 25 Dec 2009 14:58:54 +0000 (14:58 +0000)]
2009-12-25  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        AuditsPanel for Web Inspector (hidden, no preset audits).

        https://bugs.webkit.org/show_bug.cgi?id=31665

        * English.lproj/localizedStrings.js:
        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * inspector/front-end/AuditLauncherView.js: Added.
        (WebInspector.AuditLauncherView.categorySortFunction):
        (WebInspector.AuditLauncherView):
        (WebInspector.AuditLauncherView.prototype.updateResourceTrackingState):
        (WebInspector.AuditLauncherView.prototype._setAuditRunning):
        (WebInspector.AuditLauncherView.prototype._launchButtonClicked.profilingFinishedCallback):
        (WebInspector.AuditLauncherView.prototype._launchButtonClicked):
        (WebInspector.AuditLauncherView.prototype._selectAllClicked):
        (WebInspector.AuditLauncherView.prototype._categoryClicked):
        (WebInspector.AuditLauncherView.prototype._createCategoryElement):
        (WebInspector.AuditLauncherView.prototype._createLauncherUI):
        (WebInspector.AuditLauncherView.prototype._updateButton):
        (WebInspector.AuditLauncherView.prototype.resize):
        * inspector/front-end/AuditResultView.js: Added.
        (WebInspector.AuditResultView.entrySortFunction):
        (WebInspector.AuditResultView):
        (WebInspector.AuditCategoryResultPane):
        (WebInspector.AuditRuleResultPane):
        (WebInspector.AuditRuleResultPane.prototype._decorateRuleResult):
        (WebInspector.AuditRuleResultChildSection):
        (WebInspector.AuditRuleResultChildSection.prototype.set title):
        (WebInspector.AuditRuleResultChildSection.prototype.expand):
        * inspector/front-end/AuditsPanel.js: Added.
        (WebInspector.AuditsPanel):
        (WebInspector.AuditsPanel.prototype.toolbarItemClass.get toolbarItemLabel):
        (WebInspector.AuditsPanel.prototype.get statusBarItems):
        (WebInspector.AuditsPanel.prototype.get mainResourceLoadTime):
        (WebInspector.AuditsPanel.prototype.set mainResourceLoadTime):
        (WebInspector.AuditsPanel.prototype.get mainResourceDOMContentTime):
        (WebInspector.AuditsPanel.prototype.set mainResourceDOMContentTime):
        (WebInspector.AuditsPanel.prototype.get categoriesById):
        (WebInspector.AuditsPanel.prototype.get visibleView):
        (WebInspector.AuditsPanel.prototype._constructCategories):
        (WebInspector.AuditsPanel.prototype._executeAudit.ruleResultReadyCallback):
        (WebInspector.AuditsPanel.prototype._executeAudit):
        (WebInspector.AuditsPanel.prototype._auditFinishedCallback):
        (WebInspector.AuditsPanel.prototype.initiateAudit.initiateAuditCallback):
        (WebInspector.AuditsPanel.prototype.initiateAudit):
        (WebInspector.AuditsPanel.prototype._reloadResources):
        (WebInspector.AuditsPanel.prototype._didMainResourceLoad):
        (WebInspector.AuditsPanel.prototype.showResults):
        (WebInspector.AuditsPanel.prototype.showLauncherView):
        (WebInspector.AuditsPanel.prototype.showView):
        (WebInspector.AuditsPanel.prototype.show):
        (WebInspector.AuditsPanel.prototype.attach):
        (WebInspector.AuditsPanel.prototype.resize):
        (WebInspector.AuditsPanel.prototype.updateMainViewWidth):
        (WebInspector.AuditsPanel.prototype._updateLauncherViewControls):
        (WebInspector.AuditsPanel.prototype._clearButtonClicked):
        (WebInspector.AuditsPanel.prototype._closeVisibleView):
        (WebInspector.AuditCategory):
        (WebInspector.AuditCategory.prototype.get id):
        (WebInspector.AuditCategory.prototype.get displayName):
        (WebInspector.AuditCategory.prototype.get ruleCount):
        (WebInspector.AuditCategory.prototype.addRule):
        (WebInspector.AuditCategory.prototype.runRules):
        (WebInspector.AuditRule):
        (WebInspector.AuditRule.prototype.get id):
        (WebInspector.AuditRule.prototype.get displayName):
        (WebInspector.AuditRule.prototype.run):
        (WebInspector.AuditRule.prototype.doRun):
        (WebInspector.AuditRule.prototype.getValue):
        (WebInspector.AuditCategoryResult):
        (WebInspector.AuditCategoryResult.prototype.addEntry):
        (WebInspector.AuditRuleResult):
        (WebInspector.AuditRuleResult.prototype.appendChild):
        (WebInspector.AuditRuleResult.prototype.set type):
        (WebInspector.AuditRuleResult.prototype.get type):
        (WebInspector.AuditsSidebarTreeElement):
        (WebInspector.AuditsSidebarTreeElement.prototype.onattach):
        (WebInspector.AuditsSidebarTreeElement.prototype.onselect):
        (WebInspector.AuditsSidebarTreeElement.prototype.get selectable):
        (WebInspector.AuditsSidebarTreeElement.prototype.refresh):
        (WebInspector.AuditResultSidebarTreeElement):
        (WebInspector.AuditResultSidebarTreeElement.prototype.onselect):
        (WebInspector.AuditResultSidebarTreeElement.prototype.get selectable):
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/audits.css: Added.
        * inspector/front-end/inspector.html:
        * inspector/front-end/inspector.js:
        (WebInspector._createPanels):
        (WebInspector.updateResource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoUnreviewed trivial fix.
ossy@webkit.org [Fri, 25 Dec 2009 14:37:07 +0000 (14:37 +0000)]
Unreviewed trivial fix.

LayoutTests/inspector/settings-set-get.html removed
by r52547, it should be removed from skiplist.

* platform/qt/Skipped: inspector/settings-set-get.html removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-25 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Fri, 25 Dec 2009 14:24:07 +0000 (14:24 +0000)]
2009-12-25  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Implement Edit Inner HTML action.

        https://bugs.webkit.org/show_bug.cgi?id=32924

        * English.lproj/localizedStrings.js:
        * bindings/js/JSInjectedScriptHostCustom.cpp:
        (WebCore::JSInjectedScriptHost::pushNodePathToFrontend):
        * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
        (WebCore::V8InjectedScriptHost::pushNodePathToFrontendCallback):
        * inspector/InjectedScriptHost.cpp:
        (WebCore::InjectedScriptHost::pushNodePathToFrontend):
        * inspector/InjectedScriptHost.h:
        * inspector/InjectedScriptHost.idl:
        * inspector/InspectorDOMAgent.h:
        * inspector/front-end/ElementsPanel.js:
        (WebInspector.ElementsPanel.prototype.show):
        (WebInspector.ElementsPanel.prototype._updateModifiedNodesSoon):
        (WebInspector.ElementsPanel.prototype.updateModifiedNodes):
        * inspector/front-end/ElementsTreeOutline.js:
        (WebInspector.ElementsTreeElement.prototype._populateTagContextMenu):
        (WebInspector.ElementsTreeElement.prototype._startEditingAsHTML.commit):
        (WebInspector.ElementsTreeElement.prototype._startEditingAsHTML.dispose):
        (WebInspector.ElementsTreeElement.prototype._startEditingAsHTML):
        ():
        * inspector/front-end/InjectedScript.js:
        (InjectedScript.getNodePropertyValue):
        (InjectedScript.setOuterHTML):
        (InjectedScript.performSearch.addNodesToResults):
        (InjectedScript._inspectObject):
        (InjectedScript._copy):
        (InjectedScript.pushNodeToFrontend):
        * inspector/front-end/InjectedScriptAccess.js:
        * inspector/front-end/InspectorFrontendHostStub.js:
        (.WebInspector.InspectorFrontendHostStub.prototype.hiddenPanels):
        (.WebInspector.InspectorFrontendHostStub.prototype.windowUnloading):
        * inspector/front-end/inspector.css:
        * inspector/front-end/inspector.js:
        (WebInspector.startEditing.keyDownEventListener):
        (WebInspector.startEditing):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWeb Inspector: Console should force long URLs to wrap
mitz@apple.com [Fri, 25 Dec 2009 06:07:13 +0000 (06:07 +0000)]
Web Inspector: Console should force long URLs to wrap
https://bugs.webkit.org/show_bug.cgi?id=32927

Reviewed by Timothy Hatcher.

* inspector/front-end/inspector.css: Added "word-wrap: break-word;" to
the #console-messages rule.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-24 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Fri, 25 Dec 2009 03:25:10 +0000 (03:25 +0000)]
2009-12-24  Shinichiro Hamaji  <hamaji@chromium.org>

        Unreviewed Chromium test fix by reverting r52536.

        Do not a new Database pointer to any structure until its version has been verified
        https://bugs.webkit.org/show_bug.cgi?id=32913

        * storage/Database.cpp:
        (WebCore::Database::openDatabase):
        (WebCore::Database::Database):
        (WebCore::Database::performOpenAndVerify):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-24 Robert Hogan <robert@roberthogan.net>
eric@webkit.org [Fri, 25 Dec 2009 01:15:01 +0000 (01:15 +0000)]
2009-12-24  Robert Hogan  <robert@roberthogan.net>

        Reviewed by Eric Seidel.

        Remove LayoutTests/storage/change-version.html from Qt Skipped list

        LayoutTests/storage/change-version.html now passes.
        Probably related to the fix in https://bugs.webkit.org/show_bug.cgi?id=32437.

        https://bugs.webkit.org/show_bug.cgi?id=32917

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoReviewed by Gustavo Noronha.
girish@forwardbias.in [Thu, 24 Dec 2009 19:41:36 +0000 (19:41 +0000)]
Reviewed by Gustavo Noronha.

Doc : QGraphicsWebView::zoomFactor was introduced in 4.6.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-24 Laszlo Gombos <laszlo.1.gombos@nokia.com>
laszlo.1.gombos@nokia.com [Thu, 24 Dec 2009 17:34:34 +0000 (17:34 +0000)]
2009-12-24  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Unreviewed; revert of r52550.

        The change regressed the following LayoutTests for QtWebKit.

        fast/workers/worker-call.html -> crashed
        fast/workers/worker-close.html -> crashed

        * wtf/qt/ThreadingQt.cpp:
        (WTF::waitForThreadCompletion):
        (WTF::detachThread):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-24 Shu Chang <Chang.Shu@nokia.com>
eric@webkit.org [Thu, 24 Dec 2009 17:03:40 +0000 (17:03 +0000)]
2009-12-24  Shu Chang  <Chang.Shu@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] Fix memory leak by deleting instance of ThreadPrivate
        in function waitForThreadCompletion(), synchronously, or in
        detachThread(), asynchronously.
        https://bugs.webkit.org/show_bug.cgi?id=32614

        * wtf/qt/ThreadingQt.cpp:
        (WTF::waitForThreadCompletion):
        (WTF::detachThread):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRubber-stamped by Simon Hausmann.
zoltan@webkit.org [Thu, 24 Dec 2009 14:12:17 +0000 (14:12 +0000)]
Rubber-stamped by Simon Hausmann.

Patch by Andras Becsi <abecsi@inf.u-szeged.hu> on 2009-12-24
[Qt] Skip failing test until a solution for layoutTestController.notifyDone() is found.
https://bugs.webkit.org/show_bug.cgi?id=31626

* platform/qt/Skipped: inspector/console-clear.html skipped

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Fix for WebKit bug 29968 - Selecting text with text-overflow ellipsis
jberlin@webkit.org [Thu, 24 Dec 2009 13:46:30 +0000 (13:46 +0000)]
    Fix for WebKit bug 29968 - Selecting text with text-overflow ellipsis
        should not show cut off text
        https://bugs.webkit.org/show_bug.cgi?id=29968

        Reviewed by Dan Bernstein.

        Also fixes the issue on both Mac OS X and Windows where the highlight
        would extend only partway into the ellipsis based on the size of the
        characters being truncated.

        Test: editing/selection/select-text-overflow-ellipsis.html

        WebCore:

        * rendering/EllipsisBox.cpp:
        (WebCore::EllipsisBox::paint):
        When the ellipsis have been selected, paints them with the color for
        selected text.
        (WebCore::EllipsisBox::selectionRect):
        Returns the selection rect for the ellipsis text.
        (WebCore::EllipsisBox::paintSelection):
        Paints the selection highlight around the ellipsis text.

        * rendering/EllipsisBox.h:
        (WebCore::EllipsisBox::EllipsisBox):
        Default the selection state of the EllipsisBox to SelectionNone.
        (WebCore::EllipsisBox::setSelectionState):
        Allow the selection state to be explicitly set by the InlineTextBox
        that it is associated with, since the selection state depends on the
        position of the selection within the truncated text.
        (WebCore::EllipsisBox::selectionState):
        Return the cached selection state.

        * rendering/InlineTextBox.cpp:
        (WebCore::InlineTextBox::selectionState):
        If the text is truncated and the selection extends into the truncation
        where there are ellipsis, set the selection state on the EllipsisBox.
        (WebCore::paintTextWithShadows):
        Allow for an upper bound to be specified on the maximum length of the
        text to be painted.
        (WebCore::InlineTextBox::paint):
        Make sure the text that is drawn gets appropriately truncated. This was
        not an issue before on Mac OS X because it wasn't necessary to draw the
        selected text separately (the selected text had the same color as the
        non-selected text).
        (WebCore::InlineTextBox::paintSelection):
        If the text is being truncated, let whatever is being painted in the
        space after the truncated text paint its own highlight.

        * rendering/InlineTextBox.h:
        (WebCore::InlineTextBox::truncation):
        Allow RenderText to access the truncation status.

        * rendering/RenderText.cpp:
        (WebCore::RenderText::selectionRectForRepaint):
        Make sure that any ellipsis box that falls within the selection also
        gets repainted.

        Places the expected results under the mac and win platforms separately
        because they are pixel test results and also the size of the
        RenderBlocks are showing up as slightly different between mac and win.

        LayoutTests:

        * editing/selection/select-text-overflow-ellipsis.html: Added.
        * platform/mac/editing/selection/select-text-overflow-ellipsis-expected.checksum: Added.
        * platform/mac/editing/selection/select-text-overflow-ellipsis-expected.png: Added.
        * platform/mac/editing/selection/select-text-overflow-ellipsis-expected.txt: Added.
        * platform/win/editing/selection/select-text-overflow-ellipsis-expected.checksum: Added.
        * platform/win/editing/selection/select-text-overflow-ellipsis-expected.png: Added.
        * platform/win/editing/selection/select-text-overflow-ellipsis-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-24 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 24 Dec 2009 12:33:39 +0000 (12:33 +0000)]
2009-12-24  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: add Settings.js class that would manage
        frontend settings.

        This change:
        - Splits preferences and settings
        - Pushes settings to the frontend on load
        - Stores settings on each change
        - Stores showInheritedStyles as setting.

        https://bugs.webkit.org/show_bug.cgi?id=32832

        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * inspector/InspectorBackend.cpp:
        (WebCore::InspectorBackend::saveFrontendSettings):
        * inspector/InspectorBackend.h:
        * inspector/InspectorBackend.idl:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::populateScriptObjects):
        * inspector/InspectorController.h:
        * inspector/InspectorFrontend.cpp:
        (WebCore::InspectorFrontend::populateFrontendSettings):
        * inspector/InspectorFrontend.h:
        * inspector/InspectorFrontendHost.cpp:
        * inspector/InspectorFrontendHost.h:
        * inspector/InspectorFrontendHost.idl:
        * inspector/front-end/EventListenersSidebarPane.js:
        (WebInspector.EventListenersSidebarPane.prototype._settingsLoaded):
        (WebInspector.EventListenersSidebarPane.prototype):
        ():
        * inspector/front-end/InspectorBackendStub.js:
        (.WebInspector.InspectorBackendStub):
        (.WebInspector.InspectorBackendStub.prototype.saveFrontendSettings):
        (.WebInspector.InspectorBackendStub.prototype.releaseWrapperObjectGroup):
        * inspector/front-end/InspectorFrontendHostStub.js:
        (.WebInspector.InspectorFrontendHostStub):
        (.WebInspector.InspectorFrontendHostStub.prototype.hiddenPanels):
        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.ResourcesPanel.prototype._createStatusbarButtons):
        (WebInspector.ResourcesPanel.prototype._settingsLoaded):
        (WebInspector.ResourcesPanel.prototype._toggleLargerResources):
        (WebInspector.ResourcesPanel.prototype._setLargerResources):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype._showScriptOrResource):
        (WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu):
        * inspector/front-end/Settings.js: Added.
        (WebInspector.populateFrontendSettings):
        (WebInspector.Settings):
        (WebInspector.Settings.prototype._load):
        (WebInspector.Settings.prototype._installSetting):
        (WebInspector.Settings.prototype._get):
        (WebInspector.Settings.prototype._set):
        * inspector/front-end/StylesSidebarPane.js:
        (WebInspector.StylesSidebarPane.prototype._settingsLoaded):
        (WebInspector.StylesSidebarPane.prototype.update):
        (WebInspector.StylesSidebarPane.prototype._changeSetting):
        (WebInspector.StylesSidebarPane.prototype._changeColorFormat):
        (WebInspector.StylePropertiesSection.showInheritedToggleFunction):
        (WebInspector.StylePropertiesSection):
        * inspector/front-end/WatchExpressionsSidebarPane.js:
        (WebInspector.WatchExpressionsSidebarPane):
        (WebInspector.WatchExpressionsSidebarPane.prototype._settingsLoaded):
        (WebInspector.WatchExpressionsSidebarPane.prototype.refreshExpressions):
        (WebInspector.WatchExpressionsSection):
        (WebInspector.WatchExpressionsSection.prototype.saveExpressions):
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/inspector.html:
        * inspector/front-end/inspector.js:
        (WebInspector.loaded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-24 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 24 Dec 2009 11:12:45 +0000 (11:12 +0000)]
2009-12-24  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: follow up to r52545, adding missing tests.

        * inspector/console-clear-expected.txt: Added.
        * inspector/console-clear.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-23 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 24 Dec 2009 11:05:58 +0000 (11:05 +0000)]
2009-12-23  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: [REGRESSION] console's clear command does not work.

        https://bugs.webkit.org/show_bug.cgi?id=32897

        Test: inspector/console-clear.html

WebCore:
        * inspector/InjectedScriptHost.cpp:
        (WebCore::InjectedScriptHost::clearConsoleMessages):
        * inspector/InjectedScriptHost.h:
        * inspector/InjectedScriptHost.idl:
        * inspector/InspectorBackend.cpp:
        * inspector/InspectorBackend.h:
        * inspector/InspectorBackend.idl:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::clearConsoleMessages):
        (WebCore::InspectorController::didCommitLoad):
        * inspector/InspectorController.h:
        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleView):
        (WebInspector.ConsoleView.prototype.requestClearConsoleMessages):
        (WebInspector.ConsoleView.prototype.clearConsoleMessages):
        (WebInspector.ConsoleView.prototype._clearButtonClicked):
        * inspector/front-end/InjectedScript.js:
        (InjectedScript.clearConsoleMessages):
        (InjectedScript._ensureCommandLineAPIInstalled):
        * inspector/front-end/InjectedScriptAccess.js:
        * inspector/front-end/inspector.js:
        (WebInspector.clearConsoleMessages):
        (WebInspector.reset):
LayoutTests:
        * inspector/console-clear-expected.txt: Added.
        * inspector/console-clear.html: Added.
        * inspector/console-tests.js:
        (dumpConsoleMessages.callback):
        (dumpConsoleMessages):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-23 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 24 Dec 2009 10:38:27 +0000 (10:38 +0000)]
2009-12-23  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Console dumps strings in escaped form.

        https://bugs.webkit.org/show_bug.cgi?id=32488

        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleMessage.prototype._formatIndividualValue):
        * inspector/console-format-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-23 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 24 Dec 2009 07:18:27 +0000 (07:18 +0000)]
2009-12-23  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        bugzilla-tool should accept global options anywhere
        https://bugs.webkit.org/show_bug.cgi?id=26912

        * Scripts/bugzilla-tool:
         - Use the new global_options class property.
         - Add a handle_global_options callback to avoid needing callbacks for each global option.
        * Scripts/modules/multicommandtool.py:
         - Make the code use one combined option parser.
           This allows us to accept global options anywhere and
           individual command options before commands.
         - Add a handle_global_options callback to avoid needing callbacks for each global option.
         - Make the Command hold the option parser, but allow the tool to override it.
         - The default option parser is used for help printing and when Commands are run stand alone,
           but are otherwise not used.
         - Add Command.main to codify the idea that Commands should support being run stand-alone.
         - Change _split_args to _split_command_name_from_args now that args are unified.
        * Scripts/modules/multicommandtool_unittest.py:
         - Test that "tool" and "tool help" show the same help.
         - Test that args are accepted before commands

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Darin Adler.
ap@apple.com [Thu, 24 Dec 2009 05:49:15 +0000 (05:49 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=32905
        With Pinyin Simplified IM, a wrong character is deleted from google.com suggestion

        Test: platform/mac/editing/input/selection-change-closes-typing.html

        * editing/Editor.cpp: (WebCore::Editor::confirmComposition): If this function wasn't allowed
        to change selection, it needs to close the current typing command - otherwise, its idea of
        selection would be used for future typing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-20 Chris Jerdonek <chris.jerdonek@gmail.com>
hamaji@chromium.org [Thu, 24 Dec 2009 05:31:33 +0000 (05:31 +0000)]
2009-12-20  Chris Jerdonek  <chris.jerdonek@gmail.com>

        Reviewed by David Levin.

        Moved some sections of code in preparation to refactor
        check-webkit-style's argument parser to avoid setting
        global variables.

        https://bugs.webkit.org/show_bug.cgi?id=32592

        * Scripts/check-webkit-style:
          - Moved _USAGE string to style.py.
          - Addressed FIXME by eliminating dependencies on cpp_style.py.

        * Scripts/modules/cpp_style.py:
          - Moved default arguments and style categories to style.py.
          - Moved exit_with_usage(), exit_with_categories(), and
            parse_arguments() to style.py.
          - Removed references in _CppStyleState to the global
            variables now in style.py.

        * Scripts/modules/cpp_style_unittest.py:
          - Moved parse_arguments() unit tests to style_unittest.py.

        * Scripts/modules/style.py:
          - Added _USAGE string from check-webkit-style.
          - Added default arguments and style categories from cpp_style.py.
          - Added exit_with_usage(), exit_with_categories(), and
            parse_arguments() from cpp_sstyle.py.

        * Scripts/modules/style_unittest.py: Added.
          - Added parse_arguments() unit tests from cpp_style_unittest.py.

        * Scripts/run-webkit-unittests:
          - Added unit tests from style_unittest.py.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-23 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 24 Dec 2009 02:31:27 +0000 (02:31 +0000)]
2009-12-23  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        commit-queue should mention bug 30084 when rejecting patches until it can be fixed
        https://bugs.webkit.org/show_bug.cgi?id=32911

        * Scripts/modules/bugzilla.py: Make the message even more fancy.
        * Scripts/modules/bugzilla_unittest.py: Test our new fancy message.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-23 Yuta Kitamura <yutak@chromium.org>
eric@webkit.org [Thu, 24 Dec 2009 02:23:38 +0000 (02:23 +0000)]
2009-12-23  Yuta Kitamura  <yutak@chromium.org>

        Reviewed by Eric Seidel.

        PlatformContextSkia::beginLayerClippedToImage() needs to clip outside of the image.

        This method should limit the current painting window to the bounds of the given
        image, but it did not. Due to this bug, unnecessary contents were rendered in
        some (limited) situations.

        [Skia] PlatformContextSkia::beginLayerClippedToImage does not clip outside of the image
        https://bugs.webkit.org/show_bug.cgi?id=32817

        No new tests, because this is a fix of an existing test which is currently failing in
        Chromium.

        * platform/graphics/skia/PlatformContextSkia.cpp:
        (PlatformContextSkia::beginLayerClippedToImage): Add clipRect() call.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-23 Kwang Yul Seo <skyul@company100.net>
eric@webkit.org [Thu, 24 Dec 2009 02:15:44 +0000 (02:15 +0000)]
2009-12-23  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Laszlo Gombos.

        Include stddef.h for ptrdiff_t
        https://bugs.webkit.org/show_bug.cgi?id=32891

        ptrdiff_t is typedef-ed in stddef.h.
        Include stddef.h in jit/ExecutableAllocator.h.

        * jit/ExecutableAllocator.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-23 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Thu, 24 Dec 2009 01:45:01 +0000 (01:45 +0000)]
2009-12-23  Nikolas Zimmermann  <nzimmermann@rim.com>

        Rubber-stamped by Eric Seidel.

        Remove all references to "GenerateConstructor", as this is the default behaviour now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoA new database should be registered with the Document,
dumi@chromium.org [Thu, 24 Dec 2009 01:38:53 +0000 (01:38 +0000)]
A new database should be registered with the Document,
DatabaseTracker and DatabaseThread only after it was successfully
opened and its version was successfully verified.

Reviewed by Eric Seidel.

Fixes a regression introduced by
http://trac.webkit.org/changeset/52530.

LayoutTests/storage/open-database-while-transaction-in-progress.html
should pass again (or rather, it should pass again when run after
open-database-set-empty-version.html).

https://bugs.webkit.org/show_bug.cgi?id=32913

* storage/Database.cpp:
(WebCore::Database::openDatabase):
(WebCore::Database::Database):
(WebCore::Database::performOpenAndVerify):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-23 David Levin <levin@chromium.org>
levin@chromium.org [Thu, 24 Dec 2009 01:15:10 +0000 (01:15 +0000)]
2009-12-23  David Levin  <levin@chromium.org>

        REGRESSION (r52494): Assertion failure in Frame::caretBlinkTimerFired() (selection()->isCaret())
        https://bugs.webkit.org/show_bug.cgi?id=32903

        No review but ok'ed by Darin Adler. Rolling out r52494 due to above regression.

LayoutTests:
        * fast/forms/selection-layout-reentry-strange-case-expected.txt: Removed.
        * fast/forms/selection-layout-reentry-strange-case.html: Removed.
        * platform/mac/accessibility/frame-with-title-expected.txt:

WebCore:
        * editing/SelectionController.cpp:
        (WebCore::SelectionController::SelectionController):
        (WebCore::SelectionController::setSelection):
        * editing/SelectionController.h:
        * page/Frame.cpp:
        (WebCore::Frame::setCaretVisible):
        (WebCore::Frame::selectionLayoutChanged):
        * page/FrameView.cpp:
        (WebCore::FrameView::needsLayout):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-23 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Thu, 24 Dec 2009 00:55:01 +0000 (00:55 +0000)]
2009-12-23  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Eric Seidel.

        Reverse JS GenerateConstructor logic
        https://bugs.webkit.org/show_bug.cgi?id=32910

        Make 'GenerateConstructor' the default setting for all classes, defined in IDL files. The flag is now obsolete and
        can be removed from all IDL files in a follow-up patch. Add new 'OmitConstructor' flag, that allows to restore the
        old default behaviour: do not generate JSFoobarConstructor class.

        No change in functionality, despite the fact that we're generating a lot more constructors now, as they have to
        be exposed through DOMWindow.idl -- this can be done per affected class in follow-up patches. Especially the SVG
        classes have to be exposed, most of them are missing JS constructors so far.

        As side effect HTMLOptionsCollection is now correctly exposing its constructor, thus fixing a test in fast/dom/wrapper-classes.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRubber-stamped by Eric Seidel.
bweinstein@apple.com [Thu, 24 Dec 2009 00:34:22 +0000 (00:34 +0000)]
Rubber-stamped by Eric Seidel.

Added Windows specific results for a test that was committed in r52505.

* platform/win/fast/forms/basic-textareas-quirks-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-12-23 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 23 Dec 2009 23:22:34 +0000 (23:22 +0000)]
2009-12-23  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        "Refused to execute a JavaScript script" error when embedding SWF with
        a URL that is also a query parameter
        https://bugs.webkit.org/show_bug.cgi?id=32908

        Update expected results to show that we don't raise an alarm in this case.

        * http/tests/security/xssAuditor/object-src-inject-expected.txt:
2009-12-23  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        "Refused to execute a JavaScript script" error when embedding SWF with
        a URL that is also a query parameter
        https://bugs.webkit.org/show_bug.cgi?id=32908

        Don't block direct injections into the object src attribute unless
        there's an illegal character (like < or ") in the URL.  This change
        lets some very unusual vulnerabilities through the filter but removes a
        false positive that we've seen several times.

        * page/XSSAuditor.cpp:
        (WebCore::XSSAuditor::canLoadObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@52532 268f45cc-cd09-0410-ab3c-d52691b4dbfc