ojan@chromium.org [Fri, 14 Jan 2011 20:30:45 +0000 (20:30 +0000)]
2011-01-14 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Roben.
fix bugs going back and forth between unified and sidebyside
https://bugs.webkit.org/show_bug.cgi?id=52470
Now that we're appending DOM nodes directly, we only want to
get the first ".text" element in the subtree. In the cases
where there are multiple, their contents are the same.
Also, when making side-by-side expansion lines, we need to
clone the contents so we have a second copy to append to the DOM.
* code-review.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75809
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Fri, 14 Jan 2011 20:27:53 +0000 (20:27 +0000)]
2011-01-14 Pavel Feldman <pfeldman@chromium.org>
Not reviewed. Follow up to r75791: fix missing dispatch.
https://bugs.webkit.org/show_bug.cgi?id=52442
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerDispatcher.prototype.breakpointResolved):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75808
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Fri, 14 Jan 2011 20:01:24 +0000 (20:01 +0000)]
2011-01-14 Simon Fraser <simon.fraser@apple.com>
Reviewed by Adam Roben.
Issues with contentsScale in GraphicsLayerCA
https://bugs.webkit.org/show_bug.cgi?id=52463
Fix various issues with the recent contentsScale changes:
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::GraphicsLayerCA): Initialize m_contentsScale to 1.
(WebCore::GraphicsLayerCA::updateContentsScale): Only do a setNeedsDisplay()
if the layer draws content, otherwise we'll create backing store for empty layers.
(WebCore::GraphicsLayerCA::swapFromOrToTiledLayer): Be sure to set contentsScale
on the new (tiled or untiled) layer.
(WebCore::GraphicsLayerCA::cloneLayer): Clones need contentsScale too.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75807
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
laszlo.1.gombos@nokia.com [Fri, 14 Jan 2011 19:50:47 +0000 (19:50 +0000)]
2011-01-14 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Align import/export directives
https://bugs.webkit.org/show_bug.cgi?id=52208
* API/JSBase.h: Align import/export directives with
WebKit2/Shared/API/c/WKBase.h
2011-01-14 Laszlo Gombos <laszlo.1.gombos@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
Align import/export directives
https://bugs.webkit.org/show_bug.cgi?id=52208
* Shared/API/c/WKBase.h: Align import/export directives with
JavaScriptCore/API/JSBase.h.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75806
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Fri, 14 Jan 2011 19:16:53 +0000 (19:16 +0000)]
2011-01-14 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Fisher.
[Chromium] WebKit API: Add a function for form interactive validation setting
https://bugs.webkit.org/show_bug.cgi?id=52430
* public/WebSettings.h: Add a pure setInteractiveFormValidationEnabled().
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setInteractiveFormValidationEnabled): Implemented.
* src/WebSettingsImpl.h: Add a declaration.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75805
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Fri, 14 Jan 2011 18:54:52 +0000 (18:54 +0000)]
2011-01-14 Simon Fraser <simon.fraser@apple.com>
Let Xcode have it's way with the project file.
* WebCore.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75804
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Fri, 14 Jan 2011 18:53:12 +0000 (18:53 +0000)]
2011-01-14 Simon Fraser <simon.fraser@apple.com>
Reviewed by Anders Carlsson.
Refactor some FrameView::syncCompositingState code
https://bugs.webkit.org/show_bug.cgi?id=52459
Refactor some code in FrameView related to synchronizing
compositing layer state.
* page/FrameView.cpp:
(WebCore::FrameView::syncCompositingStateForThisFrame):
(WebCore::FrameView::syncCompositingStateRecursive):
(WebCore::FrameView::paintContents):
* page/FrameView.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75803
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Fri, 14 Jan 2011 18:38:25 +0000 (18:38 +0000)]
2011-01-14 Tony Chang <tony@chromium.org>
Unreviewed, updating baselines.
[chromium] rebaseline vertical tests on linux
https://bugs.webkit.org/show_bug.cgi?id=52457
After updating fonts.conf, these tests are now passing.
* platform/chromium-linux/fast/blockflow/japanese-lr-text-expected.checksum:
* platform/chromium-linux/fast/blockflow/japanese-lr-text-expected.png:
* platform/chromium-linux/fast/blockflow/japanese-rl-text-expected.checksum:
* platform/chromium-linux/fast/blockflow/japanese-rl-text-expected.png:
* platform/chromium-linux/fast/repaint/japanese-rl-selection-clear-expected.checksum:
* platform/chromium-linux/fast/repaint/japanese-rl-selection-clear-expected.png:
* platform/chromium-linux/fast/repaint/japanese-rl-selection-repaint-expected.checksum:
* platform/chromium-linux/fast/repaint/japanese-rl-selection-repaint-expected.png:
* platform/chromium-linux/svg/batik/text/verticalText-expected.checksum:
* platform/chromium-linux/svg/batik/text/verticalText-expected.png:
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75802
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 14 Jan 2011 18:30:16 +0000 (18:30 +0000)]
2011-01-14 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
Reviewed by Eric Seidel.
[Qt] Fix build problem introduced by http://trac.webkit.org/changeset/75713
https://bugs.webkit.org/show_bug.cgi?id=30179
* plugins/symbian/PluginViewSymbian.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75801
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 14 Jan 2011 18:09:10 +0000 (18:09 +0000)]
2011-01-14 Vincent Scheib <scheib@chromium.org>
Reviewed by David Levin.
Add support to DumpRenderTree to use the GPU rather than software renderer
https://bugs.webkit.org/show_bug.cgi?id=52333
* DumpRenderTree/chromium/DumpRenderTree.cpp:
(main):
* Scripts/webkitpy/layout_tests/port/chromium.py:
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
2011-01-14 Vincent Scheib <scheib@chromium.org>
Reviewed by David Levin.
Add support to DumpRenderTree to use the GPU rather than software renderer
https://bugs.webkit.org/show_bug.cgi?id=52333
* DEPS: Moved forward to take required support from webkit_support.h
* WebKit.gyp: DumpRenderTree depends on Angle on windows
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75800
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Fri, 14 Jan 2011 17:35:48 +0000 (17:35 +0000)]
2011-01-14 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] update fonts.conf to fix 6 linux tests in drt
https://bugs.webkit.org/show_bug.cgi?id=52411
* platform/chromium/test_expectations.txt:
2011-01-14 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] update fonts.conf to fix 6 linux tests in drt
https://bugs.webkit.org/show_bug.cgi?id=52411
* DumpRenderTree/chromium/fonts.conf: Update to match the copy in
chromium's src/webkit/tools/test_shell/resources/fonts.conf
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75799
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Fri, 14 Jan 2011 17:27:45 +0000 (17:27 +0000)]
2011-01-14 Philippe Normand <pnormand@igalia.com>
Reviewed by Martin Robinson.
[GTK] Add volume slider to media player
https://bugs.webkit.org/show_bug.cgi?id=51532
* platform/gtk/Skipped:
* platform/gtk/media/audio-controls-rendering-expected.txt:
* platform/gtk/media/controls-after-reload-expected.txt:
* platform/gtk/media/controls-strict-expected.txt:
* platform/gtk/media/controls-styling-expected.txt:
* platform/gtk/media/video-controls-rendering-expected.txt:
* platform/gtk/media/video-display-toggle-expected.txt:
* platform/gtk/media/video-empty-source-expected.txt:
* platform/gtk/media/video-no-audio-expected.txt:
* platform/gtk/media/video-volume-slider-expected.txt: Added.
2011-01-14 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Add volume slider to media player
https://bugs.webkit.org/show_bug.cgi?id=51532
* css/mediaControlsGtk.css:
(audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):
(audio::-webkit-media-controls-volume-slider-container, video::-webkit-media-controls-volume-slider-container):
(audio::-webkit-media-controls-volume-slider, video::-webkit-media-controls-volume-slider):
* platform/gtk/RenderThemeGtk.cpp:
(WebCore::RenderThemeGtk::adjustMediaSliderThumbSize):
(WebCore::RenderThemeGtk::paintMediaVolumeSliderContainer):
(WebCore::RenderThemeGtk::paintMediaVolumeSliderTrack):
(WebCore::RenderThemeGtk::paintMediaVolumeSliderThumb):
* platform/gtk/RenderThemeGtk.h:
* platform/gtk/RenderThemeGtk2.cpp:
(WebCore::RenderThemeGtk::paintSliderTrack):
(WebCore::RenderThemeGtk::paintSliderThumb):
(WebCore::RenderThemeGtk::adjustSliderThumbSize):
* platform/gtk/RenderThemeGtk3.cpp:
(WebCore::RenderThemeGtk::paintSliderTrack):
(WebCore::RenderThemeGtk::paintSliderThumb):
(WebCore::RenderThemeGtk::adjustSliderThumbSize):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75798
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 14 Jan 2011 17:03:45 +0000 (17:03 +0000)]
2011-01-14 Joone Hur <joone.hur@collabora.co.uk>
Reviewed by David Levin.
[GTK] Convert use of raw pointers to GOwnPtr in FileSystemGtk.cpp
https://bugs.webkit.org/show_bug.cgi?id=52434
No new tests. This code will be tested when an implementation
of beginDragWithFiles is complete.
* platform/gtk/FileSystemGtk.cpp:
(WebCore::filenameToString): Use GOwnPtr instead of gchar pointer.
(WebCore::fileSystemRepresentation): Ditto.
(WebCore::filenameForDisplay): Ditto.
(WebCore::pathGetFileName): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75797
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
msaboff@apple.com [Fri, 14 Jan 2011 16:02:51 +0000 (16:02 +0000)]
2011-01-14 Michael Saboff <msaboff@apple.com>
Reviewed by Oliver Hunt.
Incorrect backtracking for nested alternatives
https://bugs.webkit.org/show_bug.cgi?id=52387
Added tests to verfiy backtracking of alternatives following
parenthesis.
* fast/regex/parentheses-expected.txt:
* fast/regex/script-tests/parentheses.js:
2011-01-14 Michael Saboff <msaboff@apple.com>
Reviewed by Oliver Hunt.
Incorrect backtracking for nested alternatives
https://bugs.webkit.org/show_bug.cgi?id=52387
In the process of propigating a datalabel it wasn't getting connected
to a destination when the destination was an indirect jump. Added
code to recognize a direct backtrack destination that was an indirect
jump and added mechanism to associate DataLabelPtrs with indirect
jump entries.
Removed dead method
BacktrackDestination::linkDataLabelToHereIfExists()
* yarr/YarrJIT.cpp:
(JSC::Yarr::YarrGenerator::IndirectJumpEntry::IndirectJumpEntry):
(JSC::Yarr::YarrGenerator::IndirectJumpEntry::addDataLabel):
(JSC::Yarr::YarrGenerator::GenerationState::addIndirectJumpEntry):
(JSC::Yarr::YarrGenerator::GenerationState::emitIndirectJumpTable):
Changes to link indirect jumps with DataLabelPtr's.
(JSC::Yarr::YarrGenerator::BacktrackDestination::clearSubDataLabelPtr):
(JSC::Yarr::YarrGenerator::TermGenerationState::linkDataLabelToBacktrackIfExists):
Updated to handle immediate linking of indirect jumps to
DataLabelPtr.
(JSC::Yarr::YarrGenerator::generateParenthesesDisjunction): Changed to
reflect updated linkDataLabelToBacktrackIfExists().
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75796
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Fri, 14 Jan 2011 15:58:16 +0000 (15:58 +0000)]
2011-01-14 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: breakpoint text snippet in breakpoints sidebar pane disappears after reload.
https://bugs.webkit.org/show_bug.cgi?id=52215
* inspector/front-end/Breakpoint.js:
(WebInspector.Breakpoint):
(WebInspector.Breakpoint.prototype.populateLabelElement):
* inspector/front-end/Script.js:
(WebInspector.Script.prototype.get linesCount):
(WebInspector.Script.prototype.sourceLine):
(WebInspector.Script.prototype.sourceLine.didRequestSource):
(WebInspector.Script.prototype.set source):
(WebInspector.Script.prototype.requestSource.didGetScriptSource):
(WebInspector.Script.prototype.requestSource):
* inspector/front-end/ScriptView.js:
(WebInspector.ScriptView.prototype.setupSourceFrameIfNeeded.didRequestSource):
(WebInspector.ScriptView.prototype.setupSourceFrameIfNeeded):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._addBreakpoint):
* inspector/front-end/utilities.js:
(String.prototype.findAll):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75795
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Fri, 14 Jan 2011 15:49:20 +0000 (15:49 +0000)]
2011-01-14 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: provide script column offset to frontend.
https://bugs.webkit.org/show_bug.cgi?id=52377
* parser/SourceCode.h:
(JSC::SourceCode::SourceCode):
(JSC::SourceCode::firstColumn):
2011-01-14 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: provide script column offset to frontend.
https://bugs.webkit.org/show_bug.cgi?id=52377
* bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::dispatchDidParseSource):
* bindings/js/ScriptSourceCode.h:
(WebCore::ScriptSourceCode::ScriptSourceCode):
* bindings/v8/DebuggerScript.js:
():
* bindings/v8/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::dispatchDidParseSource):
* inspector/Inspector.idl:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::didParseSource):
* inspector/InspectorDebuggerAgent.h:
* inspector/ScriptDebugListener.h:
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.prototype.parsedScriptSource):
* inspector/front-end/Script.js:
(WebInspector.Script):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75794
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Fri, 14 Jan 2011 15:28:48 +0000 (15:28 +0000)]
2011-01-14 Ilya Tikhonovsky <loislo@chromium.org>
Unreviewed one line fix for console-xhr-logging test.
The problem was introduced at r75788.
* inspector/InspectorBrowserDebuggerAgent.cpp:
(WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75793
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Fri, 14 Jan 2011 14:57:21 +0000 (14:57 +0000)]
2011-01-13 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: extract console related functionality into InspectorConsoleAgent
https://bugs.webkit.org/show_bug.cgi?id=52282
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* inspector/CodeGeneratorInspector.pm:
* inspector/ConsoleMessage.cpp:
(WebCore::ConsoleMessage::~ConsoleMessage):
* inspector/ConsoleMessage.h:
* inspector/Inspector.idl:
* inspector/InspectorConsoleAgent.cpp: Added.
(WebCore::InspectorConsoleAgent::InspectorConsoleAgent):
(WebCore::InspectorConsoleAgent::~InspectorConsoleAgent):
(WebCore::InspectorConsoleAgent::setConsoleMessagesEnabled):
(WebCore::InspectorConsoleAgent::clearConsoleMessages):
(WebCore::InspectorConsoleAgent::reset):
(WebCore::InspectorConsoleAgent::setFrontend):
(WebCore::InspectorConsoleAgent::addMessageToConsole):
(WebCore::InspectorConsoleAgent::startTiming):
(WebCore::InspectorConsoleAgent::stopTiming):
(WebCore::InspectorConsoleAgent::count):
(WebCore::InspectorConsoleAgent::resourceRetrievedByXMLHttpRequest):
(WebCore::InspectorConsoleAgent::didReceiveResponse):
(WebCore::InspectorConsoleAgent::didFailLoading):
(WebCore::InspectorConsoleAgent::addConsoleMessage):
* inspector/InspectorConsoleAgent.h: Added.
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::clearConsoleMessages):
(WebCore::InspectorController::connectFrontend):
(WebCore::InspectorController::disconnectFrontend):
(WebCore::InspectorController::didCommitLoad):
* inspector/InspectorController.h:
(WebCore::InspectorController::consoleAgent):
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didReceiveResourceResponseImpl):
(WebCore::InspectorInstrumentation::didFailLoadingImpl):
(WebCore::InspectorInstrumentation::resourceRetrievedByXMLHttpRequestImpl):
(WebCore::InspectorInstrumentation::addMessageToConsole):
(WebCore::InspectorInstrumentation::count):
(WebCore::InspectorInstrumentation::startTiming):
(WebCore::InspectorInstrumentation::stopTiming):
(WebCore::InspectorInstrumentation::addStartProfilingMessageToConsole):
* inspector/InspectorInstrumentation.h:
* inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::addProfileFinishedMessageToConsole):
(WebCore::InspectorProfilerAgent::addStartProfilingMessageToConsole):
* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleView):
(WebInspector.ConsoleView.prototype.addConsoleMessage):
(WebInspector.ConsoleView.prototype.updateConsoleMessageExpiredCount):
(WebInspector.ConsoleView.prototype.consoleMessagesCleared):
* inspector/front-end/inspector.js:
* page/Console.cpp:
(WebCore::Console::addMessage):
(WebCore::Console::count):
(WebCore::Console::profile):
(WebCore::Console::time):
(WebCore::Console::timeEnd):
(WebCore::Console::group):
(WebCore::Console::groupCollapsed):
(WebCore::Console::groupEnd):
* page/Console.h:
* page/Console.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75792
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Fri, 14 Jan 2011 14:50:43 +0000 (14:50 +0000)]
2011-01-14 Pavel Feldman <pfeldman@chromium.org>
Web Inspector: do not use this as protocol message
dispatcher in models / agents.
https://bugs.webkit.org/show_bug.cgi?id=52442
Models should never for InspectorBackend.registerDomainDispatcher("foo", this).
There should be a clear way to tell whether method is being called
from within front-end or by the backend.
* http/tests/inspector/debugger-test2.js:
(initialize_DebuggerTest.InspectorTest.startDebuggerTest.startTest):
(initialize_DebuggerTest.InspectorTest.startDebuggerTest):
(initialize_DebuggerTest.InspectorTest.completeDebuggerTest.disableDebugger):
(initialize_DebuggerTest.InspectorTest.showScriptSource):
2011-01-14 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: do not use this as protocol message
dispatcher in models / agents.
https://bugs.webkit.org/show_bug.cgi?id=52442
Models should never for InspectorBackend.registerDomainDispatcher("foo", this).
There should be a clear way to tell whether method is being called
from within front-end or by the backend.
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMAgent):
(WebInspector.DOMAgent.prototype.nodeForId):
(WebInspector.DOMAgent.prototype._bindNodes):
(WebInspector.DOMAgent.prototype._removeBreakpoints):
(WebInspector.DOMDispatcher):
(WebInspector.DOMDispatcher.prototype.setDocument):
(WebInspector.DOMDispatcher.prototype.attributesUpdated):
(WebInspector.DOMDispatcher.prototype.characterDataModified):
(WebInspector.DOMDispatcher.prototype.setChildNodes):
(WebInspector.DOMDispatcher.prototype.setDetachedRoot):
(WebInspector.DOMDispatcher.prototype.childNodeCountUpdated):
(WebInspector.DOMDispatcher.prototype.childNodeInserted):
(WebInspector.DOMDispatcher.prototype.childNodeRemoved):
(WebInspector.DOMDispatcher.prototype.didCommitLoad):
(WebInspector.ApplicationCacheDispatcher):
(WebInspector.ApplicationCacheDispatcher.prototype.getApplicationCachesAsync):
(WebInspector.ApplicationCacheDispatcher.prototype.updateApplicationCacheStatus):
(WebInspector.ApplicationCacheDispatcher.prototype.updateNetworkState):
* inspector/front-end/DOMStorage.js:
(WebInspector.DOMStorageDispatcher):
(WebInspector.DOMStorageDispatcher.prototype.addDOMStorage):
(WebInspector.DOMStorageDispatcher.prototype.selectDOMStorage):
(WebInspector.DOMStorageDispatcher.prototype.updateDOMStorage):
* inspector/front-end/Database.js:
(WebInspector.Database.prototype.executeSql):
(WebInspector.DatabaseDispatcher):
(WebInspector.DatabaseDispatcher.prototype.addDatabase):
(WebInspector.DatabaseDispatcher.prototype.selectDatabase):
(WebInspector.DatabaseDispatcher.prototype.sqlTransactionSucceeded):
(WebInspector.DatabaseDispatcher.prototype.sqlTransactionFailed):
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel):
(WebInspector.DebuggerModel.prototype._pausedScript):
(WebInspector.DebuggerModel.prototype._resumedScript):
(WebInspector.DebuggerModel.prototype._parsedScriptSource):
(WebInspector.DebuggerModel.prototype._failedToParseScriptSource):
(WebInspector.DebuggerDispatcher):
(WebInspector.DebuggerDispatcher.prototype.pausedScript):
(WebInspector.DebuggerDispatcher.prototype.resumedScript):
(WebInspector.DebuggerDispatcher.prototype.parsedScriptSource):
(WebInspector.DebuggerDispatcher.prototype.failedToParseScriptSource):
* inspector/front-end/FileSystemView.js:
(WebInspector.FileSystemDispatcher):
(WebInspector.FileSystemDispatcher.prototype.getFileSystemPathsAsync):
(WebInspector.FileSystemDispatcher.prototype.didGetFileSystemPath):
(WebInspector.FileSystemDispatcher.prototype.didGetFileSystemError):
(WebInspector.FileSystemDispatcher.prototype.didGetFileSystemDisabled):
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel):
(WebInspector.ProfilesPanel.prototype._addProfileHeader):
(WebInspector.ProfilesPanel.prototype._removeProfileHeader):
(WebInspector.ProfilesPanel.prototype._addHeapSnapshotChunk):
(WebInspector.ProfilesPanel.prototype._finishHeapSnapshot):
(WebInspector.ProfilesPanel.prototype._setRecordingProfile):
(WebInspector.ProfilerDispatcher):
(WebInspector.ProfilerDispatcher.prototype.profilerWasEnabled):
(WebInspector.ProfilerDispatcher.prototype.profilerWasDisabled):
(WebInspector.ProfilerDispatcher.prototype.resetProfiles):
(WebInspector.ProfilerDispatcher.prototype.addProfileHeader):
(WebInspector.ProfilerDispatcher.prototype.addHeapSnapshotChunk):
(WebInspector.ProfilerDispatcher.prototype.finishHeapSnapshot):
(WebInspector.ProfilerDispatcher.prototype.setRecordingProfile):
(WebInspector.ProfileSidebarTreeElement.prototype.ondelete):
* inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel):
(WebInspector.TimelinePanel.prototype._timelineProfilerWasStarted):
(WebInspector.TimelinePanel.prototype._timelineProfilerWasStopped):
(WebInspector.TimelinePanel.prototype._addRecordToTimeline):
(WebInspector.TimelineDispatcher):
(WebInspector.TimelineDispatcher.prototype.timelineProfilerWasStarted):
(WebInspector.TimelineDispatcher.prototype.timelineProfilerWasStopped):
(WebInspector.TimelineDispatcher.prototype.addRecordToTimeline):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75791
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Fri, 14 Jan 2011 14:25:14 +0000 (14:25 +0000)]
[Qt][V8] Unreviewed buildfix after r75788.
* inspector/InspectorBrowserDebuggerAgent.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75790
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Fri, 14 Jan 2011 13:31:09 +0000 (13:31 +0000)]
2011-01-14 Andrey Kosyakov <caseq@chromium.org>
Unreviewed test fix.
Filter out /favicon.ico from page resources list to avoid test expectations mismatch on GTK.
* http/tests/inspector/extensions-resources-redirect.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75789
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Fri, 14 Jan 2011 12:54:12 +0000 (12:54 +0000)]
2011-01-12 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Extract BrowserDebuggerAgent from InspectorController, InspectorDOMAgent and InspectorDebugger agent.
We have some methods of Debugger which are related to DOM.
Lets extract these methods to BrowserDebugger agent.
http://bugs.webkit.org/show_bug.cgi?id=52294
* CMakeLists.txt:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* inspector/CodeGeneratorInspector.pm:
* inspector/Inspector.idl:
* inspector/InspectorBrowserDebuggerAgent.cpp: Added.
(WebCore::InspectorBrowserDebuggerAgent::InspectorBrowserDebuggerAgent):
(WebCore::InspectorBrowserDebuggerAgent::~InspectorBrowserDebuggerAgent):
(WebCore::InspectorBrowserDebuggerAgent::discardBindings):
(WebCore::InspectorBrowserDebuggerAgent::setEventListenerBreakpoint):
(WebCore::InspectorBrowserDebuggerAgent::removeEventListenerBreakpoint):
(WebCore::InspectorBrowserDebuggerAgent::didInsertDOMNode):
(WebCore::InspectorBrowserDebuggerAgent::didRemoveDOMNode):
(WebCore::InspectorBrowserDebuggerAgent::setDOMBreakpoint):
(WebCore::InspectorBrowserDebuggerAgent::removeDOMBreakpoint):
(WebCore::InspectorBrowserDebuggerAgent::willInsertDOMNode):
(WebCore::InspectorBrowserDebuggerAgent::willRemoveDOMNode):
(WebCore::InspectorBrowserDebuggerAgent::willModifyDOMAttr):
(WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent):
(WebCore::InspectorBrowserDebuggerAgent::hasBreakpoint):
(WebCore::InspectorBrowserDebuggerAgent::updateSubtreeBreakpoints):
(WebCore::InspectorBrowserDebuggerAgent::pauseOnNativeEventIfNeeded):
(WebCore::InspectorBrowserDebuggerAgent::setXHRBreakpoint):
(WebCore::InspectorBrowserDebuggerAgent::removeXHRBreakpoint):
(WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest):
(WebCore::InspectorBrowserDebuggerAgent::clearForPageNavigation):
* inspector/InspectorBrowserDebuggerAgent.h: Added.
(WebCore::InspectorBrowserDebuggerAgent::create):
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::inspectedPageDestroyed):
(WebCore::InspectorController::didCommitLoad):
(WebCore::InspectorController::enableDebuggerFromFrontend):
(WebCore::InspectorController::disableDebugger):
(WebCore::InspectorController::restoreStickyBreakpoints):
(WebCore::InspectorController::restoreStickyBreakpoint):
* inspector/InspectorController.h:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::discardBindings):
(WebCore::InspectorDOMAgent::didInsertDOMNode):
(WebCore::InspectorDOMAgent::didRemoveDOMNode):
* inspector/InspectorDOMAgent.h:
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::willInsertDOMNodeImpl):
(WebCore::InspectorInstrumentation::didInsertDOMNodeImpl):
(WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl):
(WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl):
(WebCore::InspectorInstrumentation::willModifyDOMAttrImpl):
(WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl):
(WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75788
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 14 Jan 2011 12:33:22 +0000 (12:33 +0000)]
2011-01-14 Eric Seidel <eric@webkit.org>
Original patch from Peter Gal <galpater@inf.u-szeged.hu>
Reviewed by Adam Barth.
Fix when running Tools/Scripts/check-webkit-style without arguments.
https://bugs.webkit.org/show_bug.cgi?id=52261#c16
* Scripts/webkitpy/common/checkout/scm.py: Handle None for changed_files argument better in Git.create_patch method.
* Scripts/webkitpy/common/checkout/scm_unittest.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75787
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Fri, 14 Jan 2011 12:25:39 +0000 (12:25 +0000)]
2011-01-14 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: redirected resources not handled properly in Network panel
https://bugs.webkit.org/show_bug.cgi?id=52292
* inspector/Inspector.idl: Do not pass isMainResource to identifierForInitialRequest() (it's useless, as we may hit provisional load)
* inspector/InspectorInstrumentation.cpp: Ditto.
(WebCore::InspectorInstrumentation::identifierForInitialRequestImpl):
* inspector/InspectorResourceAgent.cpp: Ditto.
(WebCore::InspectorResourceAgent::identifierForInitialRequest):
* inspector/InspectorResourceAgent.h: Ditto.
* inspector/InspectorInstrumentation.cpp: Ditto.
(WebCore::InspectorInstrumentation::identifierForInitialRequestImpl): Fix main resource detection.
* inspector/front-end/AuditsPanel.js: WebInspector.networkResources now returns array, not map.
* inspector/front-end/ConsoleView.js: User WebInspector.resourceById() to get resource
(WebInspector.ConsoleMessage.prototype._formatMessage):
* inspector/front-end/ExtensionServer.js: Ditto.
(WebInspector.ExtensionServer.prototype._onRevealAndSelectResource):
(WebInspector.ExtensionServer.prototype._onGetResourceContent):
* inspector/front-end/HAREntry.js: WebInspector.networkResources now returns array, not map
(WebInspector.HARLog.prototype.build):
(WebInspector.HARLog.prototype._convertResource):
* inspector/front-end/NetworkManager.js:
(WebInspector.NetworkManager): Use appendResource, not refreshResource, when adding a new resource.
(WebInspector.NetworkManager.prototype.identifierForInitialRequest):
(WebInspector.NetworkManager.prototype.willSendRequest):
(WebInspector.NetworkManager.prototype.didLoadResourceFromMemoryCache):
(WebInspector.NetworkManager.prototype.setInitialContent):
(WebInspector.NetworkManager.prototype.didCommitLoadForFrame):
(WebInspector.NetworkManager.prototype.didCreateWebSocket):
(WebInspector.NetworkManager.prototype._createResource): always register resource URL with ResourceTreeModel
(WebInspector.NetworkManager.prototype._appendRedirect):
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkPanel):
(WebInspector.NetworkPanel.prototype.get resources):
(WebInspector.NetworkPanel.prototype.resourceById):
(WebInspector.NetworkPanel.prototype.appendResource): Add resource as new iff appendResource was added.
(WebInspector.NetworkPanel.prototype.refreshResource): ditto.
(WebInspector.NetworkPanel.prototype.mainResourceChanged): Clear console upon arrival of new main resource.
* inspector/front-end/ResourceTreeModel.js: Expose unbindResourceURL, bind resources automatically upon creation.
(WebInspector.ResourceTreeModel.prototype._clearResources):
(WebInspector.ResourceTreeModel.prototype.unbindResourceURL):
(WebInspector.ResourceTreeModel.prototype._addFramesRecursively):
(WebInspector.ResourceTreeModel.prototype.createResource):
* inspector/front-end/inspector.js:
(WebInspector.resourceById):
2011-01-14 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: redirected resources not handled properly in Network panel
Added test for redirected resource presence in HAR
Changed test to request entire HAR log, not multiple HAR entries.
https://bugs.webkit.org/show_bug.cgi?id=52292
* http/tests/inspector/extensions-resources-redirect-expected.txt:
* http/tests/inspector/extensions-resources-redirect.html:
* http/tests/inspector/resource-har-conversion.html:
* inspector/extensions-resources.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75786
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Fri, 14 Jan 2011 10:48:01 +0000 (10:48 +0000)]
2011-01-14 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r75783.
http://trac.webkit.org/changeset/75783
https://bugs.webkit.org/show_bug.cgi?id=52439
a bit strange but the same patch have broken mac builds at
linking stage. (Requested by loislo2 on #webkit).
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* inspector/CodeGeneratorInspector.pm:
* inspector/Inspector.idl:
* inspector/InspectorBrowserDebuggerAgent.cpp: Removed.
* inspector/InspectorBrowserDebuggerAgent.h: Removed.
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::inspectedPageDestroyed):
(WebCore::InspectorController::didCommitLoad):
(WebCore::InspectorController::enableDebuggerFromFrontend):
(WebCore::InspectorController::disableDebugger):
(WebCore::InspectorController::restoreStickyBreakpoints):
(WebCore::InspectorController::restoreStickyBreakpoint):
(WebCore::InspectorController::setEventListenerBreakpoint):
(WebCore::InspectorController::removeEventListenerBreakpoint):
(WebCore::InspectorController::hasEventListenerBreakpoint):
(WebCore::InspectorController::setXHRBreakpoint):
(WebCore::InspectorController::removeXHRBreakpoint):
(WebCore::InspectorController::hasXHRBreakpoint):
* inspector/InspectorController.h:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::discardBindings):
(WebCore::InspectorDOMAgent::setDOMBreakpoint):
(WebCore::InspectorDOMAgent::removeDOMBreakpoint):
(WebCore::InspectorDOMAgent::shouldBreakOnNodeInsertion):
(WebCore::InspectorDOMAgent::shouldBreakOnNodeRemoval):
(WebCore::InspectorDOMAgent::shouldBreakOnAttributeModification):
(WebCore::InspectorDOMAgent::descriptionForDOMEvent):
(WebCore::InspectorDOMAgent::didInsertDOMNode):
(WebCore::InspectorDOMAgent::didRemoveDOMNode):
(WebCore::InspectorDOMAgent::hasBreakpoint):
(WebCore::InspectorDOMAgent::updateSubtreeBreakpoints):
* inspector/InspectorDOMAgent.h:
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::willInsertDOMNodeImpl):
(WebCore::InspectorInstrumentation::didInsertDOMNodeImpl):
(WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl):
(WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl):
(WebCore::InspectorInstrumentation::willModifyDOMAttrImpl):
(WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl):
(WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75785
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 14 Jan 2011 10:24:51 +0000 (10:24 +0000)]
2011-01-14 Finnur Thorarinsson <finnur.webkit@gmail.com>
Reviewed by Ojan Vafai.
Address some user-select-none issues better in our Find in page scoping
function.
The scoping function is in part based on Editor::countMatchesForText
(formerly Frame::markAllMatchesForText), but was rewritten with
asychronous search and interruptability in mind. At the time the
function was written, countMatchesForText didn't work well with
user-select-none style but that has now changed. While
investigating http://crbug.com/68494 I noticed WebKit had fixed this
very problem in the countMatchesForText and I believe we should make
the same changes in our platform code. Therefore, this changelist
adopts the same approach by integrating:
https://bugs.webkit.org/show_bug.cgi?id=33508
(r53142: handling user-select-none better) and
https://bugs.webkit.org/show_bug.cgi?id=51623
(r74886: handling match within textfield better).
For more details see those changelists.
This changelist, however, is tracked here:
https://bugs.webkit.org/show_bug.cgi?id=52367
The original changelists did not come with layout tests, but I'm adding
a test on the Chromium side for this.
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::scopeStringMatches):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75784
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Fri, 14 Jan 2011 10:22:07 +0000 (10:22 +0000)]
2011-01-12 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Extract BrowserDebuggerAgent from InspectorController, InspectorDOMAgent and InspectorDebugger agent.
We have some methods of Debugger which are related to DOM.
Lets extract these methods to BrowserDebugger agent.
http://bugs.webkit.org/show_bug.cgi?id=52294
* CMakeLists.txt:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* inspector/CodeGeneratorInspector.pm:
* inspector/Inspector.idl:
* inspector/InspectorBrowserDebuggerAgent.cpp: Added.
(WebCore::InspectorBrowserDebuggerAgent::InspectorBrowserDebuggerAgent):
(WebCore::InspectorBrowserDebuggerAgent::~InspectorBrowserDebuggerAgent):
(WebCore::InspectorBrowserDebuggerAgent::discardBindings):
(WebCore::InspectorBrowserDebuggerAgent::setEventListenerBreakpoint):
(WebCore::InspectorBrowserDebuggerAgent::removeEventListenerBreakpoint):
(WebCore::InspectorBrowserDebuggerAgent::didInsertDOMNode):
(WebCore::InspectorBrowserDebuggerAgent::didRemoveDOMNode):
(WebCore::InspectorBrowserDebuggerAgent::setDOMBreakpoint):
(WebCore::InspectorBrowserDebuggerAgent::removeDOMBreakpoint):
(WebCore::InspectorBrowserDebuggerAgent::willInsertDOMNode):
(WebCore::InspectorBrowserDebuggerAgent::willRemoveDOMNode):
(WebCore::InspectorBrowserDebuggerAgent::willModifyDOMAttr):
(WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent):
(WebCore::InspectorBrowserDebuggerAgent::hasBreakpoint):
(WebCore::InspectorBrowserDebuggerAgent::updateSubtreeBreakpoints):
(WebCore::InspectorBrowserDebuggerAgent::pauseOnNativeEventIfNeeded):
(WebCore::InspectorBrowserDebuggerAgent::setXHRBreakpoint):
(WebCore::InspectorBrowserDebuggerAgent::removeXHRBreakpoint):
(WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest):
(WebCore::InspectorBrowserDebuggerAgent::clearForPageNavigation):
* inspector/InspectorBrowserDebuggerAgent.h: Added.
(WebCore::InspectorBrowserDebuggerAgent::create):
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::inspectedPageDestroyed):
(WebCore::InspectorController::didCommitLoad):
(WebCore::InspectorController::enableDebuggerFromFrontend):
(WebCore::InspectorController::disableDebugger):
(WebCore::InspectorController::restoreStickyBreakpoints):
(WebCore::InspectorController::restoreStickyBreakpoint):
* inspector/InspectorController.h:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::discardBindings):
(WebCore::InspectorDOMAgent::didInsertDOMNode):
(WebCore::InspectorDOMAgent::didRemoveDOMNode):
* inspector/InspectorDOMAgent.h:
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::willInsertDOMNodeImpl):
(WebCore::InspectorInstrumentation::didInsertDOMNodeImpl):
(WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl):
(WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl):
(WebCore::InspectorInstrumentation::willModifyDOMAttrImpl):
(WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl):
(WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75783
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Fri, 14 Jan 2011 10:05:12 +0000 (10:05 +0000)]
2011-01-14 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: gtk build fix (2).
* webkit/webkitwebview.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75782
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jochen@chromium.org [Fri, 14 Jan 2011 10:02:37 +0000 (10:02 +0000)]
2011-01-04 Jochen Eisinger <jochen@chromium.org>
Reviewed by David Levin.
Store the tempdir object in a variable so it doesn't get deleted too early.
https://bugs.webkit.org/show_bug.cgi?id=51875
* Scripts/update-webkit-auxiliary-libs:
* Scripts/update-webkit-support-libs:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75781
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Fri, 14 Jan 2011 09:59:55 +0000 (09:59 +0000)]
2011-01-14 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: gtk build fix.
* webkit/webkitwebinspector.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75780
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 14 Jan 2011 09:52:38 +0000 (09:52 +0000)]
2011-01-14 Eric Seidel <eric@webkit.org>
Unreviewed. Make it work in python 2.5.
webkit-patch suggest-reviewers dies when ChangeLogs are missing
https://bugs.webkit.org/show_bug.cgi?id=49158
* Scripts/webkitpy/common/checkout/api_unittest.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75779
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Fri, 14 Jan 2011 09:47:45 +0000 (09:47 +0000)]
2011-01-14 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: build fix.
* WebCore.vcproj/WebCore.vcproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75778
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Fri, 14 Jan 2011 09:28:52 +0000 (09:28 +0000)]
2011-01-14 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: extract InspectorSettings from InspectorState,
simplify it.
https://bugs.webkit.org/show_bug.cgi?id=52429
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.xcodeproj/project.pbxproj:
* inspector/InspectorClient.h:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::inspectorStartsAttached):
(WebCore::InspectorController::setInspectorStartsAttached):
(WebCore::InspectorController::setInspectorAttachedHeight):
(WebCore::InspectorController::inspectorAttachedHeight):
(WebCore::InspectorController::setMonitoringXHREnabled):
(WebCore::InspectorController::restoreDebugger):
(WebCore::InspectorController::restoreProfiler):
(WebCore::InspectorController::ensureSettingsLoaded):
(WebCore::InspectorController::enableProfiler):
(WebCore::InspectorController::disableProfiler):
(WebCore::InspectorController::enableDebuggerFromFrontend):
(WebCore::InspectorController::disableDebugger):
* inspector/InspectorController.h:
* inspector/InspectorSettings.cpp: Added.
(WebCore::InspectorSettings::InspectorSettings):
(WebCore::InspectorSettings::getBoolean):
(WebCore::InspectorSettings::setBoolean):
(WebCore::InspectorSettings::getLong):
(WebCore::InspectorSettings::setLong):
(WebCore::InspectorSettings::registerBoolean):
(WebCore::InspectorSettings::registerLong):
* inspector/InspectorSettings.h: Added.
* inspector/InspectorState.cpp:
(WebCore::InspectorState::InspectorState):
(WebCore::InspectorState::setValue):
(WebCore::InspectorState::setObject):
(WebCore::InspectorState::registerBoolean):
(WebCore::InspectorState::registerString):
(WebCore::InspectorState::registerLong):
(WebCore::InspectorState::registerObject):
(WebCore::InspectorState::Property::create):
* inspector/InspectorState.h:
(WebCore::InspectorState::setBoolean):
(WebCore::InspectorState::setString):
(WebCore::InspectorState::setLong):
2011-01-14 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: extract InspectorSettings from InspectorState,
simplify it.
https://bugs.webkit.org/show_bug.cgi?id=52429
* WebProcess/WebCoreSupport/WebInspectorClient.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75777
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Fri, 14 Jan 2011 09:21:05 +0000 (09:21 +0000)]
2011-01-14 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r75774.
http://trac.webkit.org/changeset/75774
https://bugs.webkit.org/show_bug.cgi?id=52431
gtk builds were broken (Requested by loislo2 on #webkit).
* CMakeLists.txt:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* inspector/CodeGeneratorInspector.pm:
* inspector/Inspector.idl:
* inspector/InspectorBrowserDebuggerAgent.cpp: Removed.
* inspector/InspectorBrowserDebuggerAgent.h: Removed.
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::inspectedPageDestroyed):
(WebCore::InspectorController::didCommitLoad):
(WebCore::InspectorController::enableDebuggerFromFrontend):
(WebCore::InspectorController::disableDebugger):
(WebCore::InspectorController::restoreStickyBreakpoints):
(WebCore::InspectorController::restoreStickyBreakpoint):
(WebCore::InspectorController::setEventListenerBreakpoint):
(WebCore::InspectorController::removeEventListenerBreakpoint):
(WebCore::InspectorController::hasEventListenerBreakpoint):
(WebCore::InspectorController::setXHRBreakpoint):
(WebCore::InspectorController::removeXHRBreakpoint):
(WebCore::InspectorController::hasXHRBreakpoint):
* inspector/InspectorController.h:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::discardBindings):
(WebCore::InspectorDOMAgent::setDOMBreakpoint):
(WebCore::InspectorDOMAgent::removeDOMBreakpoint):
(WebCore::InspectorDOMAgent::shouldBreakOnNodeInsertion):
(WebCore::InspectorDOMAgent::shouldBreakOnNodeRemoval):
(WebCore::InspectorDOMAgent::shouldBreakOnAttributeModification):
(WebCore::InspectorDOMAgent::descriptionForDOMEvent):
(WebCore::InspectorDOMAgent::didInsertDOMNode):
(WebCore::InspectorDOMAgent::didRemoveDOMNode):
(WebCore::InspectorDOMAgent::hasBreakpoint):
(WebCore::InspectorDOMAgent::updateSubtreeBreakpoints):
* inspector/InspectorDOMAgent.h:
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::willInsertDOMNodeImpl):
(WebCore::InspectorInstrumentation::didInsertDOMNodeImpl):
(WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl):
(WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl):
(WebCore::InspectorInstrumentation::willModifyDOMAttrImpl):
(WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl):
(WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):
2011-01-14 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r75774.
http://trac.webkit.org/changeset/75774
https://bugs.webkit.org/show_bug.cgi?id=52431
gtk builds were broken (Requested by loislo2 on #webkit).
* Scripts/webkitpy/common/checkout/scm.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75776
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Fri, 14 Jan 2011 08:56:14 +0000 (08:56 +0000)]
check-webkit-style: _FunctionState should detect pure functions.
https://bugs.webkit.org/show_bug.cgi?id=52428
Reviewed by Shinichiro Hamaji.
* Scripts/webkitpy/style/checkers/cpp.py: Added detection for if a function declaration
is a pure virtual function.
* Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests for verifying that pure
virtual functions are correctly detected.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75775
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Fri, 14 Jan 2011 08:21:11 +0000 (08:21 +0000)]
2011-01-12 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Extract BrowserDebuggerAgent from InspectorController, InspectorDOMAgent and InspectorDebugger agent.
We have some methods of Debugger which are related to DOM.
Lets extract these methods to BrowserDebugger agent.
http://bugs.webkit.org/show_bug.cgi?id=52294
* CMakeLists.txt:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* inspector/CodeGeneratorInspector.pm:
* inspector/Inspector.idl:
* inspector/InspectorBrowserDebuggerAgent.cpp: Added.
(WebCore::InspectorBrowserDebuggerAgent::InspectorBrowserDebuggerAgent):
(WebCore::InspectorBrowserDebuggerAgent::~InspectorBrowserDebuggerAgent):
(WebCore::InspectorBrowserDebuggerAgent::discardBindings):
(WebCore::InspectorBrowserDebuggerAgent::setEventListenerBreakpoint):
(WebCore::InspectorBrowserDebuggerAgent::removeEventListenerBreakpoint):
(WebCore::InspectorBrowserDebuggerAgent::didInsertDOMNode):
(WebCore::InspectorBrowserDebuggerAgent::didRemoveDOMNode):
(WebCore::InspectorBrowserDebuggerAgent::setDOMBreakpoint):
(WebCore::InspectorBrowserDebuggerAgent::removeDOMBreakpoint):
(WebCore::InspectorBrowserDebuggerAgent::willInsertDOMNode):
(WebCore::InspectorBrowserDebuggerAgent::willRemoveDOMNode):
(WebCore::InspectorBrowserDebuggerAgent::willModifyDOMAttr):
(WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent):
(WebCore::InspectorBrowserDebuggerAgent::hasBreakpoint):
(WebCore::InspectorBrowserDebuggerAgent::updateSubtreeBreakpoints):
(WebCore::InspectorBrowserDebuggerAgent::pauseOnNativeEventIfNeeded):
(WebCore::InspectorBrowserDebuggerAgent::setXHRBreakpoint):
(WebCore::InspectorBrowserDebuggerAgent::removeXHRBreakpoint):
(WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest):
(WebCore::InspectorBrowserDebuggerAgent::clearForPageNavigation):
* inspector/InspectorBrowserDebuggerAgent.h: Added.
(WebCore::InspectorBrowserDebuggerAgent::create):
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::inspectedPageDestroyed):
(WebCore::InspectorController::didCommitLoad):
(WebCore::InspectorController::enableDebuggerFromFrontend):
(WebCore::InspectorController::disableDebugger):
(WebCore::InspectorController::restoreStickyBreakpoints):
(WebCore::InspectorController::restoreStickyBreakpoint):
* inspector/InspectorController.h:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::discardBindings):
(WebCore::InspectorDOMAgent::didInsertDOMNode):
(WebCore::InspectorDOMAgent::didRemoveDOMNode):
* inspector/InspectorDOMAgent.h:
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::willInsertDOMNodeImpl):
(WebCore::InspectorInstrumentation::didInsertDOMNodeImpl):
(WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl):
(WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl):
(WebCore::InspectorInstrumentation::willModifyDOMAttrImpl):
(WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl):
(WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):
2011-01-13 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
Just small fix for problem with check-webkit-style.
It just didn't work for this patch.
Old code can't concatenate a list of strings with None.
* Scripts/webkitpy/common/checkout/scm.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75774
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hayato@chromium.org [Fri, 14 Jan 2011 08:14:45 +0000 (08:14 +0000)]
2011-01-14 Hayato Ito <hayato@chromium.org>
Unreviewed chromium expectations update.
Exclude http/tests/loading/cross-origin-XHR-willLoadRequest.html (added in r75768)
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75773
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
levin@chromium.org [Fri, 14 Jan 2011 06:58:16 +0000 (06:58 +0000)]
2011-01-13 David Levin <levin@chromium.org>
Reviewed by Shinichiro Hamaji.
check-webkit-style: _FunctionState should use Position to know where items are.
https://bugs.webkit.org/show_bug.cgi?id=52424
* Scripts/webkitpy/style/checkers/cpp.py:
(_FunctionState.*): Changed _FunctionState to use Position instead of line numbers.
(detect_functions): Changed to pass Position's to _FunctionState.begin and
did some minor clean-up.
(*): Other changes are simply about converting to use the Position's in_FunctionState
instead of line numbers.
* Scripts/webkitpy/style/checkers/cpp_unittest.py: Changed the test code
to verify the positions stored in _FunctionState.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75772
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hayato@chromium.org [Fri, 14 Jan 2011 06:58:00 +0000 (06:58 +0000)]
2011-01-13 Hayato Ito <hayato@chromium.org>
Unreviewed, build fix.
Fix Skipped lists in r75768.
* platform/gtk/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75771
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Fri, 14 Jan 2011 06:21:51 +0000 (06:21 +0000)]
Implement form validation message UI
https://bugs.webkit.org/show_bug.cgi?id=48980
Reviewed by Dimitri Glazkov.
* Add four internal pseudo selectors:
- -webkit-validation-bubble
- -webkit-validation-bubble-message
- -webkit-validation-bubble-top-outer-arrow
- -webkit-validation-bubble-top-inner-arrow
* Implement ValidationMessage functions
Show the message for <the number of characters> / 20.0 seconds.
No new tests because the feature is disabled by default for now and the
new behavior is strongly timing-dependent.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::canShareStyleWithElement):
Do not share a style with elements with different shadowPseudoId().
* css/html.css: Define appearance for the internal selectors.
(::-webkit-validation-bubble):
(::-webkit-validation-bubble-message):
(::-webkit-validation-bubble-top-outer-arrow):
(::-webkit-validation-bubble-top-inner-arrow):
* dom/Node.cpp:
(WebCore::Node::createRendererIfNeeded):
Allow to add shadow renderers even if canHaveChildren() returns false.
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::detach):
Remove m_validationMessage immediately because we can't use
hideVisibleValidationMessage(), which calls a ValidationMessage function later.
(WebCore::HTMLFormControlElement::updateVisibleValidationMessage):
- Don't create ValidationMessage if the message is empty.
- Remove the check for message equality.
(WebCore::HTMLFormControlElement::hideVisibleValidationMessage):
Don't remove m_validationMessage immediately. We shouldn't make the
element needsLayout() state in this context.
* html/ValidationMessage.cpp:
(WebCore::ValidationMessage::~ValidationMessage):
hideMessage() -> deleteBubbleTree() renaming.
(WebCore::ValidationMessage::setMessage): Implemented.
(WebCore::ValidationMessage::setMessageDOMAndStartTimer):
Added. This updates the validation message and starts the timer to hide it.
(WebCore::ElementWithPseudoId):
Added to help implementations of styled shadow nodes.
(WebCore::ValidationMessage::buildBubbleTree): Added.
(WebCore::ValidationMessage::requestToHideMessage): Added.
(WebCore::ValidationMessage::deleteBubbleTree):
Renamed from hideMessage(), and implemented.
* html/ValidationMessage.h: Add declarations.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75770
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 14 Jan 2011 05:40:18 +0000 (05:40 +0000)]
2011-01-13 Eric Seidel <eric@webkit.org>
Reviewed by David Levin.
webkit-patch suggest-reviewers dies when ChangeLogs are missing
https://bugs.webkit.org/show_bug.cgi?id=49158
This is not the most elegant, but it is a very safe fix to this bug.
One advantage of catching ScriptError like this instead of adding a
new added_or_modified_files or fixing all changed_files callers
to use a more specific change_files variant, is that we catch
all kinds of ScriptErrors which might cause our (non-essential)
suggest-reviewers code to fail out. This should make passing
--suggest-reviewers to webkit-patch upload much more robust
and may even make it possible for us to make it default.
The root of the problem here is that SCM.changed_files includes
deleted ChangeLog paths (from moves, etc) which then when we ask
SVN/Git for the contents of the file at that revision, the command
errors out and Executive.run_command raises a ScriptError.
In the future we might fix this differently by making all current
callers of chagned_files use a more specific method for requesting
what types of changes they're interested in (adds, modifies, deletes, etc.)
* Scripts/webkitpy/common/checkout/api.py:
* Scripts/webkitpy/common/checkout/api_unittest.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75769
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Fri, 14 Jan 2011 05:19:49 +0000 (05:19 +0000)]
<rdar://problem/
8827065> REGRESSION (r71884): Cross-origin XHR fails if willSendRequest changes the URL
https://bugs.webkit.org/show_bug.cgi?id=52419
Reviewed by Alexey Proskuryakov.
Source/WebCore:
Test: http/tests/loading/cross-origin-XHR-willLoadRequest.html
* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::init): Complete r74453 by ensuring that m_request is only set after
willSendRequest(). Otherwise, willSendRequest() ends up calling into
ThreadableDocumentRequest::willSendRequest(), which cancels the request.
Tools:
Allow to further control the behavior of the willSendRequest delegate callback by making it
set a different URL in the new request.
* DumpRenderTree/LayoutTestController.cpp:
(addURLToRedirectCallback): Added.
(LayoutTestController::staticFunctions): Added addURLToRedirect.
(LayoutTestController::addURLToRedirect): Added. Adds the redirection to the map.
(LayoutTestController::redirectionDestinationForURL): Added this getter.
* DumpRenderTree/LayoutTestController.h:
* DumpRenderTree/mac/ResourceLoadDelegate.mm:
(-[ResourceLoadDelegate webView:resource:willSendRequest:redirectResponse:fromDataSource:]): Check
if there is a redirection for the request’s URL, established by addURLToRedirect(), and if so,
change the URL in the new request to the redirect destination.
LayoutTests:
* http/tests/loading/cross-origin-XHR-willLoadRequest-expected.txt: Added.
* http/tests/loading/cross-origin-XHR-willLoadRequest.html: Added.
* platform/gtk/Skipped: Skip the new test.
* platform/qt/Skipped: Ditto.
* platform/win/Skipped: Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75768
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Fri, 14 Jan 2011 04:19:48 +0000 (04:19 +0000)]
Don’t try to compile InjectedScriptSource.js into WebCore.
Reviewed by Mark Rowe.
* WebCore.xcodeproj/project.pbxproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75767
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Fri, 14 Jan 2011 02:52:53 +0000 (02:52 +0000)]
<rdar://problem/
5469576> Use __PTK_FRAMEWORK_JAVASCRIPTCORE_KEY0 if available.
Reviewed by Geoff Garen.
* DerivedSources.make: Create a header file, HeaderDetection.h, that tells
us whether pthread_machdep.h is available.
* wtf/FastMalloc.cpp: If __PTK_FRAMEWORK_JAVASCRIPTCORE_KEY0 is available, then
don't do the pthread_getspecific_function_pointer trick.
(WTF::setThreadHeap): Ditto, but set thread-specific data.
(WTF::TCMalloc_ThreadCache::GetThreadHeap): Ditto, but get rather than set.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75766
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jschuh@chromium.org [Fri, 14 Jan 2011 02:24:00 +0000 (02:24 +0000)]
2011-01-13 Justin Schuh <jschuh@chromium.org>
Unreviewed chromium expectations update.
Several text layout tests failing on linux after r75756
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75765
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Fri, 14 Jan 2011 02:11:48 +0000 (02:11 +0000)]
2011-01-13 Martin Robinson <mrobinson@igalia.com>
Unreviewed, rolling out r75740.
http://trac.webkit.org/changeset/75740
This led to GTK+ redness
* platform/gtk/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75764
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
robert@webkit.org [Fri, 14 Jan 2011 02:07:50 +0000 (02:07 +0000)]
2011-01-13 Robert Hogan <robert@webkit.org>
Reviewed by Andreas Kling.
[Qt] Unskip http/tests/security/originHeader/origin-header-for-empty.html
https://bugs.webkit.org/show_bug.cgi?id=52389
* platform/qt/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75763
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Fri, 14 Jan 2011 01:58:38 +0000 (01:58 +0000)]
2011-01-13 Mihai Parparita <mihaip@chromium.org>
Unreviewed chromium expectations update.
Add Chromium Snow Leopard expectations. These need to go into a new
chromium-mac-snowleopard directory, since these tests do not have
chromium-mac expectations, but currently pass on Leopard.
The differences are due to bug 52335 (which explains why we can't use
the regular mac port Snow Leopard baselines).
* platform/chromium-mac-snowleopard/css1/box_properties/clear-expected.checksum: Added.
* platform/chromium-mac-snowleopard/css1/box_properties/clear-expected.png: Added.
* platform/chromium-mac-snowleopard/css1/box_properties/float-expected.checksum: Added.
* platform/chromium-mac-snowleopard/css1/box_properties/float-expected.png: Added.
* platform/chromium-mac-snowleopard/css1/text_properties/vertical_align-expected.checksum: Added.
* platform/chromium-mac-snowleopard/css1/text_properties/vertical_align-expected.png: Added.
* platform/chromium-mac-snowleopard/css2.1/t0803-c5501-imrgn-t-00-b-ag-expected.checksum: Added.
* platform/chromium-mac-snowleopard/css2.1/t0803-c5501-imrgn-t-00-b-ag-expected.png: Added.
* platform/chromium-mac-snowleopard/css2.1/t0803-c5502-mrgn-r-00-c-ag-expected.checksum: Added.
* platform/chromium-mac-snowleopard/css2.1/t0803-c5502-mrgn-r-00-c-ag-expected.png: Added.
* platform/chromium-mac-snowleopard/css2.1/t0803-c5503-imrgn-b-00-b-a-expected.checksum: Added.
* platform/chromium-mac-snowleopard/css2.1/t0803-c5503-imrgn-b-00-b-a-expected.png: Added.
* platform/chromium-mac-snowleopard/css2.1/t0803-c5504-mrgn-l-00-c-ag-expected.checksum: Added.
* platform/chromium-mac-snowleopard/css2.1/t0803-c5504-mrgn-l-00-c-ag-expected.png: Added.
* platform/chromium-mac-snowleopard/css2.1/t0803-c5505-mrgn-00-b-ag-expected.checksum: Added.
* platform/chromium-mac-snowleopard/css2.1/t0803-c5505-mrgn-00-b-ag-expected.png: Added.
* platform/chromium-mac-snowleopard/css2.1/t0905-c414-flt-01-d-g-expected.checksum: Added.
* platform/chromium-mac-snowleopard/css2.1/t0905-c414-flt-01-d-g-expected.png: Added.
* platform/chromium-mac-snowleopard/css2.1/t100304-c43-rpl-bbx-00-d-g-expected.checksum: Added.
* platform/chromium-mac-snowleopard/css2.1/t100304-c43-rpl-bbx-00-d-g-expected.png: Added.
* platform/chromium-mac-snowleopard/css2.1/t1008-c44-ln-box-00-d-ag-expected.checksum: Added.
* platform/chromium-mac-snowleopard/css2.1/t1008-c44-ln-box-00-d-ag-expected.png: Added.
* platform/chromium-mac-snowleopard/css2.1/t1008-c44-ln-box-02-d-ag-expected.checksum: Added.
* platform/chromium-mac-snowleopard/css2.1/t1008-c44-ln-box-02-d-ag-expected.png: Added.
* platform/chromium-mac-snowleopard/css2.1/t1008-c44-ln-box-03-d-ag-expected.checksum: Added.
* platform/chromium-mac-snowleopard/css2.1/t1008-c44-ln-box-03-d-ag-expected.png: Added.
* platform/chromium-mac-snowleopard/css2.1/t100801-c544-valgn-02-d-agi-expected.checksum: Added.
* platform/chromium-mac-snowleopard/css2.1/t100801-c544-valgn-02-d-agi-expected.png: Added.
* platform/chromium-mac-snowleopard/css2.1/t100801-c544-valgn-03-d-agi-expected.checksum: Added.
* platform/chromium-mac-snowleopard/css2.1/t100801-c544-valgn-03-d-agi-expected.png: Added.
* platform/chromium-mac-snowleopard/css2.1/t100801-c544-valgn-04-d-agi-expected.checksum: Added.
* platform/chromium-mac-snowleopard/css2.1/t100801-c544-valgn-04-d-agi-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/css/resize-corner-tracking-transformed-expected.checksum: Added.
* platform/chromium-mac-snowleopard/fast/css/resize-corner-tracking-transformed-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/forms/searchfield-heights-expected.checksum: Added.
* platform/chromium-mac-snowleopard/fast/forms/searchfield-heights-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/forms/slider-thumb-shared-style-expected.checksum: Added.
* platform/chromium-mac-snowleopard/fast/forms/slider-thumb-shared-style-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/gradients/background-clipped-expected.checksum: Added.
* platform/chromium-mac-snowleopard/fast/gradients/background-clipped-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/replaced/selection-rect-transform-expected.checksum: Added.
* platform/chromium-mac-snowleopard/fast/replaced/selection-rect-transform-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/text/whitespace/tab-character-basics-expected.checksum: Added.
* platform/chromium-mac-snowleopard/fast/text/whitespace/tab-character-basics-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/transforms/diamond-expected.checksum: Added.
* platform/chromium-mac-snowleopard/fast/transforms/diamond-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/transforms/shadows-expected.checksum: Added.
* platform/chromium-mac-snowleopard/fast/transforms/shadows-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/transforms/transformed-caret-expected.checksum: Added.
* platform/chromium-mac-snowleopard/fast/transforms/transformed-caret-expected.png: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75762
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 14 Jan 2011 01:56:51 +0000 (01:56 +0000)]
2011-01-13 Eric Seidel <eric@webkit.org>
Reviewed by Mihai Parparita.
webkit-patch suggest-reviewers fails due to invalid utf8 in ChangeLog files
https://bugs.webkit.org/show_bug.cgi?id=52416
Example: webkit-patch suggest-reviewers -g
ca3890fe74d94d85d6bfa48f9ea497b094d8e717
UnicodeDecodeError: 'utf8' codec can't decode bytes in position 536-538: invalid data
I also added FIXMEs about the changed_files returning deleted files problem
which is causing the other most common exception for suggest-reviewers
(and is probably breaking sheriff-bots blame detection).
* Scripts/webkitpy/common/checkout/api.py:
* Scripts/webkitpy/common/checkout/api_unittest.py:
* Scripts/webkitpy/common/checkout/scm.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75761
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
eric@webkit.org [Fri, 14 Jan 2011 01:51:57 +0000 (01:51 +0000)]
2011-01-13 Eric Seidel <eric@webkit.org>
Reviewed by Adam Barth.
results archives from commit-queue are too large to upload
https://bugs.webkit.org/show_bug.cgi?id=52405
* Scripts/webkitpy/common/system/filesystem.py:
* Scripts/webkitpy/common/system/filesystem_mock.py:
* Scripts/webkitpy/tool/commands/queues.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75760
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jam@chromium.org [Fri, 14 Jan 2011 01:31:35 +0000 (01:31 +0000)]
2011-01-13 John Abd-El-Malek <jam@chromium.org>
Reviewed by Mihai Parparita.
[chromium] Fix minor type in plugin printing
https://bugs.webkit.org/show_bug.cgi?id=52410
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::printBegin):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75759
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mthole@apple.com [Fri, 14 Jan 2011 01:16:42 +0000 (01:16 +0000)]
The pageScaleFactor() should be saved/restored along with the scroll position
https://bugs.webkit.org/show_bug.cgi?id=52406
<rdar://problem/
8714412>
Reviewed by Darin Adler and Brady Eidson.
* history/HistoryItem.cpp:
(WebCore::HistoryItem::HistoryItem): Initialize m_pageScaleFactor.
(WebCore::HistoryItem::pageScaleFactor): Added getter.
(WebCore::HistoryItem::setPageScaleFactor): Added setter.
(WebCore::HistoryItem::encodeBackForwardTreeNode): Encode m_pageScaleFactor.
(WebCore::HistoryItem::decodeBackForwardTree): Decode m_pageScaleFactor.
* history/HistoryItem.h:
* loader/HistoryController.cpp:
(WebCore::HistoryController::saveScrollPositionAndViewStateToItem): Save the page scale factor...
(WebCore::HistoryController::restoreScrollPositionAndViewState): ...and restore it here.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75758
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Fri, 14 Jan 2011 01:15:46 +0000 (01:15 +0000)]
2011-01-13 Mihai Parparita <mihaip@chromium.org>
Unreviewed chromium expectations update.
Categorize remaining scrollbar-related failures. 6 are due to bug 52414
(small remaining difference between mac and chromium-mac scrollbars).
fast/text/international/thai-line-breaks.html just needed a baseline
update (done for both Leopard and Snow Leopard).
* platform/chromium-mac-leopard/fast/text/international/thai-line-breaks-expected.checksum: Added.
* platform/chromium-mac-leopard/fast/text/international/thai-line-breaks-expected.png: Added.
* platform/chromium-mac/fast/text/international/thai-line-breaks-expected.checksum: Added.
* platform/chromium-mac/fast/text/international/thai-line-breaks-expected.png: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75757
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
evan@chromium.org [Fri, 14 Jan 2011 00:48:53 +0000 (00:48 +0000)]
2011-01-13 Evan Martin <evan@chromium.org>
Reviewed by Tony Chang.
[chromium] drop backwards iteration in Linux complex text code
https://bugs.webkit.org/show_bug.cgi?id=52403
ComplexTextController previously supported iterating through the text in
both directions, but this resulted in duplicate code for each path.
Instead, by being more careful about flipping signs where appropriate,
we can refactor the code into one code path.
No tests, just a refactoring; should be covered by existing tests.
* platform/graphics/chromium/ComplexTextControllerLinux.cpp:
(WebCore::ComplexTextController::ComplexTextController):
(WebCore::ComplexTextController::reset):
(WebCore::ComplexTextController::nextScriptRun):
* platform/graphics/chromium/ComplexTextControllerLinux.h:
* platform/graphics/chromium/FontLinux.cpp:
(WebCore::glyphIndexForXPositionInScriptRun):
(WebCore::Font::selectionRectForComplexText):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75756
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Fri, 14 Jan 2011 00:39:52 +0000 (00:39 +0000)]
2011-01-13 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
simplify keyboard handling in code review tool
https://bugs.webkit.org/show_bug.cgi?id=52407
Now that we have DiffBlock containers, the only things that are
focusable are previousComment nodes and DiffBlock containers
that contain add/remove lines.
Also, this means we show the focus border around the entire diff
instead of just the first line.
* code-review.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75754
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Fri, 14 Jan 2011 00:14:46 +0000 (00:14 +0000)]
2011-01-13 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Darin Adler.
Flip input[type=range] to use the new shadow DOM model.
https://bugs.webkit.org/show_bug.cgi?id=52317
This is a straight-up flip, minimal change to the logic, which will be
refactored in a follow-up patch.
Covered by existing tests.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::initForStyleResolve): Changed to use either
host or parent node to find parent.
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::updateType): Added logic for destroying/creating
shadow DOM subtree.
* html/InputType.cpp:
(WebCore::InputType::createShadowSubtree): Added empty decl.
(WebCore::InputType::destroyShadowSubtree): Added a method to destroy
shadow subtree.
* html/InputType.h: Added defs.
* html/RangeInputType.cpp:
(WebCore::RangeInputType::createShadowSubtree): Added a virtual method to create
slider thumb.
* html/RangeInputType.h: Adde def.
* html/shadow/SliderThumbElement.cpp: Added temporary RenderSliderThumb class
to handle cascading appearance.
(WebCore::RenderSliderThumb::RenderSliderThumb): Added.
(WebCore::RenderSliderThumb::layout): Moved here the logic from
RenderSlider::createThumbStyle.
(WebCore::SliderThumbElement::createRenderer): Added virtual method to
create RenderSliderThumb instance.
(WebCore::SliderThumbElement::defaultEventHandler): Changed to use HTMLDivElement
as base class.
(WebCore::SliderThumbElement::detach): Ditto.
* html/shadow/SliderThumbElement.h:
(WebCore::SliderThumbElement::SliderThumbElement): Ditto.
(WebCore::SliderThumbElement::create): Ditto.
(WebCore::toSliderThumbElement): Added a casting helper.
* rendering/MediaControlElements.cpp:
(WebCore::MediaControlInputElement::attach): Added handling of shadow DOM,
since the whole method is hand-rolled.
(WebCore::MediaControlInputElement::updateStyle): Ditto.
* rendering/RenderSlider.cpp:
(WebCore::RenderSlider::~RenderSlider): Removed unneeded code.
(WebCore::RenderSlider::thumbRect): Changed to use sliderThumbElement helper.
(WebCore::RenderSlider::layout): Ditto.
(WebCore::RenderSlider::sliderThumbElement): Added a temporary helper to access
SliderThumbElement.
(WebCore::RenderSlider::mouseEventIsInThumb): Changed to use sliderThumbElement helper.
(WebCore::RenderSlider::mouseEventOffsetToThumb): Ditto.
(WebCore::RenderSlider::setValueForPosition): Ditto.
(WebCore::RenderSlider::positionForOffset): Ditto.
(WebCore::RenderSlider::currentPosition): Ditto.
(WebCore::RenderSlider::trackSize): Ditto.
(WebCore::RenderSlider::forwardEvent): Ditto.
(WebCore::RenderSlider::inDragMode): Ditto.
* rendering/RenderSlider.h: Added def.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75749
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Thu, 13 Jan 2011 23:55:26 +0000 (23:55 +0000)]
2011-01-13 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Rename RGBA32Buffer to ImageFrame
https://bugs.webkit.org/show_bug.cgi?id=52363
Update references to the new name.
* src/WebImageDecoder.cpp:
(WebKit::WebImageDecoder::isFrameCompleteAtIndex):
(WebKit::WebImageDecoder::getFrameAtIndex):
2011-01-13 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Rename RGBA32Buffer to ImageFrame
https://bugs.webkit.org/show_bug.cgi?id=52363
RGBA32Buffer is a terrible misnomer. ImageFrame is vastly
more accurate. More cleanup to come.
* WebCore.pro:
* platform/graphics/ImageSource.cpp:
(WebCore::ImageSource::createFrameAtIndex):
(WebCore::ImageSource::frameDurationAtIndex):
(WebCore::ImageSource::frameIsCompleteAtIndex):
* platform/graphics/qt/ImageDecoderQt.cpp:
(WebCore::ImageDecoderQt::frameBufferAtIndex):
(WebCore::ImageDecoderQt::internalReadImage):
(WebCore::ImageDecoderQt::internalHandleCurrentImage):
* platform/graphics/qt/ImageDecoderQt.h:
* platform/graphics/wince/ImageWinCE.cpp:
(WebCore::ImageFrame::asNewNativeImage):
* platform/image-decoders/ImageDecoder.cpp:
(WebCore::ImageFrame::ImageFrame):
(WebCore::ImageFrame::operator=):
(WebCore::ImageFrame::clear):
(WebCore::ImageFrame::zeroFill):
(WebCore::ImageFrame::copyReferenceToBitmapData):
(WebCore::ImageFrame::copyBitmapData):
(WebCore::ImageFrame::setSize):
(WebCore::ImageFrame::hasAlpha):
(WebCore::ImageFrame::setHasAlpha):
(WebCore::ImageFrame::setColorProfile):
(WebCore::ImageFrame::setStatus):
(WebCore::ImageFrame::width):
(WebCore::ImageFrame::height):
* platform/image-decoders/ImageDecoder.h:
(WebCore::ImageFrame::ImageFrame):
* platform/image-decoders/bmp/BMPImageDecoder.cpp:
(WebCore::BMPImageDecoder::frameBufferAtIndex):
(WebCore::BMPImageDecoder::decode):
* platform/image-decoders/bmp/BMPImageDecoder.h:
* platform/image-decoders/bmp/BMPImageReader.cpp:
(WebCore::BMPImageReader::decodeBMP):
* platform/image-decoders/bmp/BMPImageReader.h:
(WebCore::BMPImageReader::setBuffer):
* platform/image-decoders/cairo/ImageDecoderCairo.cpp:
(WebCore::ImageFrame::asNewNativeImage):
* platform/image-decoders/cg/ImageDecoderCG.cpp:
(WebCore::getPtrAsPixelData):
(WebCore::ImageFrame::copyReferenceToBitmapData):
(WebCore::ImageFrame::copyBitmapData):
(WebCore::ImageFrame::setSize):
(WebCore::ImageFrame::asNewNativeImage):
* platform/image-decoders/gif/GIFImageDecoder.cpp:
(WebCore::GIFImageDecoder::frameBufferAtIndex):
(WebCore::GIFImageDecoder::clearFrameBufferCache):
(WebCore::GIFImageDecoder::haveDecodedRow):
(WebCore::GIFImageDecoder::frameComplete):
(WebCore::GIFImageDecoder::initFrameBuffer):
* platform/image-decoders/gif/GIFImageDecoder.h:
* platform/image-decoders/gif/GIFImageReader.cpp:
(GIFImageReader::read):
* platform/image-decoders/gif/GIFImageReader.h:
(GIFFrameReader::GIFFrameReader):
* platform/image-decoders/haiku/ImageDecoderHaiku.cpp:
(WebCore::ImageFrame::asNewNativeImage):
* platform/image-decoders/ico/ICOImageDecoder.cpp:
(WebCore::ICOImageDecoder::frameBufferAtIndex):
(WebCore::ICOImageDecoder::decode):
* platform/image-decoders/ico/ICOImageDecoder.h:
* platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
(WebCore::JPEGImageDecoder::frameBufferAtIndex):
(WebCore::JPEGImageDecoder::outputScanlines):
(WebCore::JPEGImageDecoder::jpegComplete):
(WebCore::JPEGImageDecoder::decode):
* platform/image-decoders/jpeg/JPEGImageDecoder.h:
* platform/image-decoders/openvg/ImageDecoderOpenVG.cpp:
(WebCore::ImageFrame::asNewNativeImage):
* platform/image-decoders/png/PNGImageDecoder.cpp:
(WebCore::PNGImageDecoder::frameBufferAtIndex):
(WebCore::PNGImageDecoder::rowAvailable):
(WebCore::PNGImageDecoder::pngComplete):
* platform/image-decoders/png/PNGImageDecoder.h:
(WebCore::PNGImageDecoder::isComplete):
* platform/image-decoders/qt/ImageFrameQt.cpp: Copied from Source/WebCore/platform/image-decoders/qt/RGBA32BufferQt.cpp.
(WebCore::ImageFrame::ImageFrame):
(WebCore::ImageFrame::operator=):
(WebCore::ImageFrame::clear):
(WebCore::ImageFrame::zeroFill):
(WebCore::ImageFrame::copyBitmapData):
(WebCore::ImageFrame::setSize):
(WebCore::ImageFrame::asNewNativeImage):
(WebCore::ImageFrame::hasAlpha):
(WebCore::ImageFrame::setHasAlpha):
(WebCore::ImageFrame::setColorProfile):
(WebCore::ImageFrame::setStatus):
(WebCore::ImageFrame::setPixmap):
(WebCore::ImageFrame::width):
(WebCore::ImageFrame::height):
* platform/image-decoders/qt/RGBA32BufferQt.cpp: Removed.
* platform/image-decoders/skia/ImageDecoderSkia.cpp:
(WebCore::ImageFrame::ImageFrame):
(WebCore::ImageFrame::operator=):
(WebCore::ImageFrame::clear):
(WebCore::ImageFrame::zeroFill):
(WebCore::ImageFrame::copyBitmapData):
(WebCore::ImageFrame::setSize):
(WebCore::ImageFrame::asNewNativeImage):
(WebCore::ImageFrame::hasAlpha):
(WebCore::ImageFrame::setHasAlpha):
(WebCore::ImageFrame::setColorProfile):
(WebCore::ImageFrame::setStatus):
(WebCore::ImageFrame::width):
(WebCore::ImageFrame::height):
* platform/image-decoders/webp/WEBPImageDecoder.cpp:
(WebCore::WEBPImageDecoder::frameBufferAtIndex):
(WebCore::WEBPImageDecoder::decode):
* platform/image-decoders/webp/WEBPImageDecoder.h:
* platform/image-decoders/wx/ImageDecoderWx.cpp:
(WebCore::ImageFrame::asNewNativeImage):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75748
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ojan@chromium.org [Thu, 13 Jan 2011 23:52:42 +0000 (23:52 +0000)]
2011-01-13 Ojan Vafai <ojan@chromium.org>
Reviewed by Adam Barth.
add container divs for diff blocks
https://bugs.webkit.org/show_bug.cgi?id=52400
This will help simplify a lot of code in code-review.js
and make side-by-side diffs better (i.e. put removed lines
to the left of corresponding added lines).
Also, allow for running the JS from a local file. Now you can modify code-review.js
to point to a local file and then run:
ruby prettify.rb < foo.diff > foo.html
foo.html will load a dummy code review matching foo.diff.
Before structure:
Line
Line remove
Line add
Line add
Line
After structure:
DiffBlock
DiffBlockPart shared
Line shared
DiffBlock
DiffBlockPart remove
Line remove
DiffBlockPart add
Line add
Line add
DiffBlock
DiffBlockPart shared
Line shared
* PrettyPatch/PrettyPatch.rb:
* code-review.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75747
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Thu, 13 Jan 2011 23:38:32 +0000 (23:38 +0000)]
2011-01-13 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Darin Adler.
Transferring nodes between documents should be aware of the shadow DOM.
https://bugs.webkit.org/show_bug.cgi?id=52399
No visible change in behavior at the moment.
Once https://bugs.webkit.org/show_bug.cgi?id=52317 lands, the following
tests should no longer crash:
* fast/css/pseudo-in-range-invalid-value.html
* fast/css/pseudo-in-range.html
* fast/forms/form-collection-elements.html
* fast/forms/range-keyoperation.html
* dom/Document.cpp:
(WebCore::Document::adoptNode): Changed to use Node::setDocumentRecursively.
* dom/Node.cpp:
(WebCore::Node::setDocumentRecursively): Added new method, taking existing
logic and adding shadow DOM traversal.
(WebCore::Node::traverseNextNode): Style fix.
(WebCore::Node::traverseNextSibling): Ditto.
(WebCore::Node::traversePreviousNode): Ditto.
(WebCore::Node::traversePreviousNodePostOrder): Ditto.
(WebCore::Node::checkReplaceChild): Changed to use setDocumentRecursively.
(WebCore::Node::checkAddChild): Ditto.
* dom/Node.h: Added def.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75746
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jschuh@chromium.org [Thu, 13 Jan 2011 23:28:58 +0000 (23:28 +0000)]
2011-01-13 Justin Schuh <jschuh@chromium.org>
Unreviewed chromium expectations update.
Remove exception for canvas-large-dimensions.html.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75745
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enrica@apple.com [Thu, 13 Jan 2011 23:14:41 +0000 (23:14 +0000)]
Source/WebCore: WebKit2: Add support for drag and drop
https://bugs.webkit.org/show_bug.cgi?id=52343
<rdar://problem/
7660558>
Reviewed by Darin Adler.
This patch contains the changes required to support dropping content
in WebKit on the Mac. The DragData class has been extended to provide
additional context from the application (keyboard state, modal windows, etc.)
as well as information of the drag pasteboard being used.
The support for WebKit as drag source will be added with a separate patch.
* WebCore.exp.in:
* page/DragController.cpp:
(WebCore::DragController::dragIsMove): Added DragData parameter.
(WebCore::DragController::tryDocumentDrag): Modified call to dragIsMove.
(WebCore::DragController::concludeEditDrag): Same as above.
* page/DragController.h: Added parameter to isCopyKeyDown.
* page/mac/DragControllerMac.mm:
The following methods have been modified to use the information stored
in the DragData class.
(WebCore::DragController::isCopyKeyDown):
(WebCore::DragController::dragOperation):
* platform/DragData.h:
(WebCore::DragData::flags):
* platform/DragData.cpp: Added default flags parameter to the constructor.
* platform/mac/DragDataMac.mm:
(WebCore::DragData::DragData): Added constructor that receives the name of the pasteboard to use.
(WebCore::DragData::canSmartReplace):
(WebCore::DragData::containsColor):
(WebCore::DragData::containsFiles):
(WebCore::DragData::asFilenames):
(WebCore::DragData::containsPlainText):
(WebCore::DragData::asPlainText):
(WebCore::DragData::containsCompatibleContent):
(WebCore::DragData::asURL):
(WebCore::DragData::asFragment):
All the following files have been modified to add the DragData
parameter to isCopyKeyDown. I plan to improve this in the future
and make isCopyKeyDown not platform specific.
* page/android/DragControllerAndroid.cpp:
(WebCore::DragController::isCopyKeyDown):
* page/brew/DragControllerBrew.cpp:
(WebCore::DragController::isCopyKeyDown):
* page/chromium/DragControllerChromium.cpp:
(WebCore::DragController::isCopyKeyDown):
* page/efl/DragControllerEfl.cpp:
(WebCore::DragController::isCopyKeyDown):
* page/gtk/DragControllerGtk.cpp:
(WebCore::DragController::isCopyKeyDown):
* page/haiku/DragControllerHaiku.cpp:
(WebCore::DragController::isCopyKeyDown):
* page/mac/DragControllerMac.mm:
(WebCore::DragController::isCopyKeyDown):
(WebCore::DragController::dragOperation):
* page/qt/DragControllerQt.cpp:
(WebCore::DragController::isCopyKeyDown):
* page/win/DragControllerWin.cpp:
(WebCore::DragController::isCopyKeyDown):
* page/wx/DragControllerWx.cpp:
(WebCore::DragController::isCopyKeyDown):
WebKit/mac: WebKit2: Add support for drag and drop
https://bugs.webkit.org/show_bug.cgi?id=52343
<rdar://problem/
7660558>
Reviewed by Darin Adler.
The DragData class has been extended to provide
additional context from the application (keyboard state, modal windows, etc.)
as well as information of the drag pasteboard being used.
These are the changes to align the behavior for WebKit.
* WebView/WebView.mm:
(-[WebView applicationFlags:]): Added.
(-[WebView draggingEntered:]): Added parameter to the DragData constructor.
(-[WebView draggingUpdated:]): Added parameter to the DragData constructor.
(-[WebView draggingExited:]): Added parameter to the DragData constructor.
(-[WebView performDragOperation:]): Added parameter to the DragData constructor.
WebKit2: WebKit2: Add support for drag and drop
https://bugs.webkit.org/show_bug.cgi?id=52343
<rdar://problem/
7660558>
Reviewed by Darin Adler.
This patch contains the changes required to support dropping content
in WebKit on the Mac. The DragData class has been extended to provide
additional context from the application (keyboard state, modal windows, etc.)
as well as information of the drag pasteboard being used.
The support for WebKit as drag source will be added with a separate patch.
* Shared/DragControllerAction.h: Added.
* UIProcess/API/mac/WKView.mm:
Added implemention of the methods required to add suport for a drop target.
To maintain asynchronous communication with the WebProcess, we always return
the previous calculated value for the drag operation.
(-[WKView _registerDraggedTypes]):
(-[WKView initWithFrame:contextRef:pageGroupRef:]):
(-[WKView applicationFlags:]):
(-[WKView draggingEntered:]):
(-[WKView draggingUpdated:]):
(-[WKView draggingExited:]):
(-[WKView prepareForDragOperation:]):
(-[WKView performDragOperation:]):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::performDragControllerAction):
(WebKit::WebPageProxy::didPerformDragControllerAction):
* UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::dragOperation):
(WebKit::WebPageProxy::resetDragOperation):
* UIProcess/WebPageProxy.messages.in:
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/WebCoreSupport/WebDragClient.cpp:
(WebKit::WebDragClient::willPerformDragDestinationAction):
(WebKit::WebDragClient::willPerformDragSourceAction):
(WebKit::WebDragClient::actionMaskForDrag):
(WebKit::WebDragClient::dragSourceActionMaskForPoint):
(WebKit::WebDragClient::startDrag):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::performDragControllerAction):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75743
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ddkilzer@apple.com [Thu, 13 Jan 2011 23:11:38 +0000 (23:11 +0000)]
Add missing MathMLElementFactory.h and MathMLNames.h to Xcode project
Not reviewed.
* WebCore.xcodeproj/project.pbxproj: Add missing headers. Note
that the corresponding source files were originally added to the
project in r48559.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75742
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zmo@google.com [Thu, 13 Jan 2011 23:05:32 +0000 (23:05 +0000)]
2011-01-12 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Use GC3D types in WebGLRenderingContext and related WebGL classes
https://bugs.webkit.org/show_bug.cgi?id=51908
* html/canvas/WebGLActiveInfo.h:
(WebCore::WebGLActiveInfo::create):
(WebCore::WebGLActiveInfo::type):
(WebCore::WebGLActiveInfo::size):
(WebCore::WebGLActiveInfo::WebGLActiveInfo):
* html/canvas/WebGLBuffer.cpp:
(WebCore::WebGLBuffer::associateBufferDataImpl):
(WebCore::WebGLBuffer::associateBufferData):
(WebCore::WebGLBuffer::associateBufferSubDataImpl):
(WebCore::WebGLBuffer::associateBufferSubData):
(WebCore::WebGLBuffer::byteLength):
(WebCore::WebGLBuffer::getCachedMaxIndex):
(WebCore::WebGLBuffer::setCachedMaxIndex):
(WebCore::WebGLBuffer::setTarget):
* html/canvas/WebGLBuffer.h:
(WebCore::WebGLBuffer::getTarget):
* html/canvas/WebGLFramebuffer.cpp:
(WebCore::WebGLFramebuffer::setAttachment):
(WebCore::WebGLFramebuffer::getAttachment):
(WebCore::WebGLFramebuffer::getWidth):
(WebCore::WebGLFramebuffer::getHeight):
(WebCore::WebGLFramebuffer::getColorBufferFormat):
(WebCore::WebGLFramebuffer::initializeRenderbuffers):
* html/canvas/WebGLFramebuffer.h:
* html/canvas/WebGLProgram.cpp:
(WebCore::WebGLProgram::cacheActiveAttribLocations):
(WebCore::WebGLProgram::numActiveAttribLocations):
(WebCore::WebGLProgram::getActiveAttribLocation):
(WebCore::WebGLProgram::isUsingVertexAttrib0):
* html/canvas/WebGLProgram.h:
(WebCore::WebGLProgram::getLinkCount):
* html/canvas/WebGLRenderbuffer.h:
(WebCore::WebGLRenderbuffer::setInternalFormat):
(WebCore::WebGLRenderbuffer::getInternalFormat):
(WebCore::WebGLRenderbuffer::setSize):
(WebCore::WebGLRenderbuffer::getWidth):
(WebCore::WebGLRenderbuffer::getHeight):
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::initializeNewContext):
(WebCore::WebGLRenderingContext::sizeInBytes):
(WebCore::WebGLRenderingContext::activeTexture):
(WebCore::WebGLRenderingContext::bindAttribLocation):
(WebCore::WebGLRenderingContext::bindBuffer):
(WebCore::WebGLRenderingContext::bindFramebuffer):
(WebCore::WebGLRenderingContext::bindRenderbuffer):
(WebCore::WebGLRenderingContext::bindTexture):
(WebCore::WebGLRenderingContext::blendColor):
(WebCore::WebGLRenderingContext::blendEquation):
(WebCore::WebGLRenderingContext::blendEquationSeparate):
(WebCore::WebGLRenderingContext::blendFunc):
(WebCore::WebGLRenderingContext::blendFuncSeparate):
(WebCore::WebGLRenderingContext::bufferData):
(WebCore::WebGLRenderingContext::bufferSubData):
(WebCore::WebGLRenderingContext::checkFramebufferStatus):
(WebCore::WebGLRenderingContext::clear):
(WebCore::WebGLRenderingContext::clearColor):
(WebCore::WebGLRenderingContext::clearDepth):
(WebCore::WebGLRenderingContext::clearStencil):
(WebCore::WebGLRenderingContext::colorMask):
(WebCore::WebGLRenderingContext::copyTexImage2D):
(WebCore::WebGLRenderingContext::copyTexSubImage2D):
(WebCore::WebGLRenderingContext::createShader):
(WebCore::WebGLRenderingContext::cullFace):
(WebCore::WebGLRenderingContext::deleteBuffer):
(WebCore::WebGLRenderingContext::depthFunc):
(WebCore::WebGLRenderingContext::depthMask):
(WebCore::WebGLRenderingContext::depthRange):
(WebCore::WebGLRenderingContext::disable):
(WebCore::WebGLRenderingContext::disableVertexAttribArray):
(WebCore::WebGLRenderingContext::validateElementArraySize):
(WebCore::WebGLRenderingContext::validateIndexArrayConservative):
(WebCore::WebGLRenderingContext::validateIndexArrayPrecise):
(WebCore::WebGLRenderingContext::validateRenderingState):
(WebCore::WebGLRenderingContext::drawArrays):
(WebCore::WebGLRenderingContext::drawElements):
(WebCore::WebGLRenderingContext::enable):
(WebCore::WebGLRenderingContext::enableVertexAttribArray):
(WebCore::WebGLRenderingContext::framebufferRenderbuffer):
(WebCore::WebGLRenderingContext::framebufferTexture2D):
(WebCore::WebGLRenderingContext::frontFace):
(WebCore::WebGLRenderingContext::generateMipmap):
(WebCore::WebGLRenderingContext::getActiveAttrib):
(WebCore::WebGLRenderingContext::getActiveUniform):
(WebCore::WebGLRenderingContext::getAttachedShaders):
(WebCore::WebGLRenderingContext::getAttribLocation):
(WebCore::WebGLRenderingContext::getBufferParameter):
(WebCore::WebGLRenderingContext::getError):
(WebCore::WebGLRenderingContext::getFramebufferAttachmentParameter):
(WebCore::WebGLRenderingContext::getParameter):
(WebCore::WebGLRenderingContext::getProgramParameter):
(WebCore::WebGLRenderingContext::getRenderbufferParameter):
(WebCore::WebGLRenderingContext::getShaderParameter):
(WebCore::WebGLRenderingContext::getTexParameter):
(WebCore::WebGLRenderingContext::getUniform):
(WebCore::WebGLRenderingContext::getUniformLocation):
(WebCore::WebGLRenderingContext::getVertexAttrib):
(WebCore::WebGLRenderingContext::getVertexAttribOffset):
(WebCore::WebGLRenderingContext::hint):
(WebCore::WebGLRenderingContext::isBuffer):
(WebCore::WebGLRenderingContext::isEnabled):
(WebCore::WebGLRenderingContext::isFramebuffer):
(WebCore::WebGLRenderingContext::isProgram):
(WebCore::WebGLRenderingContext::isRenderbuffer):
(WebCore::WebGLRenderingContext::isShader):
(WebCore::WebGLRenderingContext::isTexture):
(WebCore::WebGLRenderingContext::lineWidth):
(WebCore::WebGLRenderingContext::linkProgram):
(WebCore::WebGLRenderingContext::pixelStorei):
(WebCore::WebGLRenderingContext::polygonOffset):
(WebCore::WebGLRenderingContext::readPixels):
(WebCore::WebGLRenderingContext::renderbufferStorage):
(WebCore::WebGLRenderingContext::sampleCoverage):
(WebCore::WebGLRenderingContext::scissor):
(WebCore::WebGLRenderingContext::stencilFunc):
(WebCore::WebGLRenderingContext::stencilFuncSeparate):
(WebCore::WebGLRenderingContext::stencilMask):
(WebCore::WebGLRenderingContext::stencilMaskSeparate):
(WebCore::WebGLRenderingContext::stencilOp):
(WebCore::WebGLRenderingContext::stencilOpSeparate):
(WebCore::WebGLRenderingContext::texImage2DBase):
(WebCore::WebGLRenderingContext::texImage2DImpl):
(WebCore::WebGLRenderingContext::texImage2D):
(WebCore::WebGLRenderingContext::texParameter):
(WebCore::WebGLRenderingContext::texParameterf):
(WebCore::WebGLRenderingContext::texParameteri):
(WebCore::WebGLRenderingContext::texSubImage2DBase):
(WebCore::WebGLRenderingContext::texSubImage2DImpl):
(WebCore::WebGLRenderingContext::texSubImage2D):
(WebCore::WebGLRenderingContext::uniform1f):
(WebCore::WebGLRenderingContext::uniform1fv):
(WebCore::WebGLRenderingContext::uniform1i):
(WebCore::WebGLRenderingContext::uniform1iv):
(WebCore::WebGLRenderingContext::uniform2f):
(WebCore::WebGLRenderingContext::uniform2fv):
(WebCore::WebGLRenderingContext::uniform2i):
(WebCore::WebGLRenderingContext::uniform2iv):
(WebCore::WebGLRenderingContext::uniform3f):
(WebCore::WebGLRenderingContext::uniform3fv):
(WebCore::WebGLRenderingContext::uniform3i):
(WebCore::WebGLRenderingContext::uniform3iv):
(WebCore::WebGLRenderingContext::uniform4f):
(WebCore::WebGLRenderingContext::uniform4fv):
(WebCore::WebGLRenderingContext::uniform4i):
(WebCore::WebGLRenderingContext::uniform4iv):
(WebCore::WebGLRenderingContext::uniformMatrix2fv):
(WebCore::WebGLRenderingContext::uniformMatrix3fv):
(WebCore::WebGLRenderingContext::uniformMatrix4fv):
(WebCore::WebGLRenderingContext::vertexAttrib1f):
(WebCore::WebGLRenderingContext::vertexAttrib1fv):
(WebCore::WebGLRenderingContext::vertexAttrib2f):
(WebCore::WebGLRenderingContext::vertexAttrib2fv):
(WebCore::WebGLRenderingContext::vertexAttrib3f):
(WebCore::WebGLRenderingContext::vertexAttrib3fv):
(WebCore::WebGLRenderingContext::vertexAttrib4f):
(WebCore::WebGLRenderingContext::vertexAttrib4fv):
(WebCore::WebGLRenderingContext::vertexAttribPointer):
(WebCore::WebGLRenderingContext::viewport):
(WebCore::WebGLRenderingContext::getBooleanParameter):
(WebCore::WebGLRenderingContext::getBooleanArrayParameter):
(WebCore::WebGLRenderingContext::getFloatParameter):
(WebCore::WebGLRenderingContext::getIntParameter):
(WebCore::WebGLRenderingContext::getLongParameter):
(WebCore::WebGLRenderingContext::getUnsignedLongParameter):
(WebCore::WebGLRenderingContext::getWebGLFloatArrayParameter):
(WebCore::WebGLRenderingContext::getWebGLIntArrayParameter):
(WebCore::WebGLRenderingContext::isTexInternalFormatColorBufferCombinationValid):
(WebCore::WebGLRenderingContext::getBoundFramebufferColorFormat):
(WebCore::WebGLRenderingContext::validateTextureBinding):
(WebCore::WebGLRenderingContext::validateSize):
(WebCore::WebGLRenderingContext::validateTexFuncFormatAndType):
(WebCore::WebGLRenderingContext::validateTexFuncLevel):
(WebCore::WebGLRenderingContext::validateTexFuncParameters):
(WebCore::WebGLRenderingContext::validateTexFuncData):
(WebCore::WebGLRenderingContext::validateDrawMode):
(WebCore::WebGLRenderingContext::validateStencilFunc):
(WebCore::WebGLRenderingContext::validateFramebufferFuncParameters):
(WebCore::WebGLRenderingContext::validateBlendEquation):
(WebCore::WebGLRenderingContext::validateBlendFuncFactors):
(WebCore::WebGLRenderingContext::validateCapability):
(WebCore::WebGLRenderingContext::validateUniformParameters):
(WebCore::WebGLRenderingContext::validateUniformMatrixParameters):
(WebCore::WebGLRenderingContext::validateBufferDataParameters):
(WebCore::WebGLRenderingContext::vertexAttribfImpl):
(WebCore::WebGLRenderingContext::vertexAttribfvImpl):
(WebCore::WebGLRenderingContext::simulateVertexAttrib0):
* html/canvas/WebGLRenderingContext.h:
(WebCore::WebGLRenderingContext::VertexAttribState::VertexAttribState):
* html/canvas/WebGLShader.cpp:
(WebCore::WebGLShader::create):
(WebCore::WebGLShader::WebGLShader):
* html/canvas/WebGLShader.h:
(WebCore::WebGLShader::getType):
* html/canvas/WebGLTexture.cpp:
(WebCore::WebGLTexture::setTarget):
(WebCore::WebGLTexture::setParameteri):
(WebCore::WebGLTexture::setParameterf):
(WebCore::WebGLTexture::setLevelInfo):
(WebCore::WebGLTexture::generateMipmapLevelInfo):
(WebCore::WebGLTexture::getInternalFormat):
(WebCore::WebGLTexture::getType):
(WebCore::WebGLTexture::getWidth):
(WebCore::WebGLTexture::getHeight):
(WebCore::WebGLTexture::isNPOT):
(WebCore::WebGLTexture::mapTargetToIndex):
(WebCore::WebGLTexture::computeLevelCount):
(WebCore::WebGLTexture::update):
(WebCore::WebGLTexture::getLevelInfo):
* html/canvas/WebGLTexture.h:
(WebCore::WebGLTexture::LevelInfo::setInfo):
* html/canvas/WebGLUniformLocation.cpp:
(WebCore::WebGLUniformLocation::create):
(WebCore::WebGLUniformLocation::WebGLUniformLocation):
(WebCore::WebGLUniformLocation::location):
* html/canvas/WebGLUniformLocation.h:
* platform/graphics/GraphicsContext3D.h: Map GC3Dboolean to bool instead of unsigned char.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75741
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Thu, 13 Jan 2011 23:00:04 +0000 (23:00 +0000)]
2011-01-13 Martin Robinson <mrobinson@igalia.com>
Unskip editing/input/page-up-down-scrolls.html as it's passing locally.
* platform/gtk/Skipped: Unskip test.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75740
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jianli@chromium.org [Thu, 13 Jan 2011 22:55:05 +0000 (22:55 +0000)]
Change createObjectURL and revokeObjectURL to put under webkitURL.
https://bugs.webkit.org/show_bug.cgi?id=52257
Reviewed by Darin Fisher.
Source/WebCore:
Note that we add "webkit" vendor prefix to URL that is introduced in
the latest File API spec.
For the time being, we implement webkitURL as a readonly attribute
instead of a constructor so that we will not expose prototype property,
as required by the spec.
* Android.derived.jscbindings.mk:
* Android.derived.v8bindings.mk:
* Android.mk:
* CMakeLists.txt:
* DerivedSources.cpp:
* DerivedSources.make:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pri:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* html/DOMURL.cpp: Added.
* html/DOMURL.h: Added.
* html/DOMURL.idl: Added.
* inspector/front-end/NetworkPanel.js:
* inspector/front-end/utilities.js:
* page/DOMWindow.cpp:
(WebCore::DOMWindow::webkitURL):
* page/DOMWindow.h:
* page/DOMWindow.idl:
* workers/WorkerContext.cpp:
(WebCore::WorkerContext::webkitURL):
* workers/WorkerContext.h:
* workers/WorkerContext.idl:
LayoutTests:
Change all related test scripts and results to account for this change.
* fast/dom/Window/script-tests/window-property-descriptors.js:
* fast/dom/Window/window-properties-expected.txt:
* fast/dom/Window/window-properties.html:
* fast/dom/script-tests/prototype-inheritance-2.js:
* fast/dom/script-tests/prototype-inheritance.js:
* fast/files/apply-blob-url-to-img.html:
* fast/files/apply-blob-url-to-xhr.html:
* fast/files/create-blob-url-crash.html:
* fast/files/revoke-blob-url.html:
* fast/files/workers/resources/worker-apply-blob-url-to-xhr.js:
(onmessage):
* platform/qt/fast/dom/Window/window-properties-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75739
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 13 Jan 2011 22:49:44 +0000 (22:49 +0000)]
2011-01-13 Emil Eklund <eae@chromium.org>
Reviewed by Dimitri Glazkov.
Setting outerText should convert CR/LF to <br>
https://bugs.webkit.org/show_bug.cgi?id=52268
Add test for setting Element.outerText.
* fast/dom/set-outer-text-expected.txt: Added.
* fast/dom/set-outer-text.html: Added.
* fast/dom/text-node-append-data-remove-crash-expected.txt: Changed
expectation to "didn't crash" from "threw dom exception" as test
assumed the DOMCharacterDataModified event would fire before the node
would be replaced.
* fast/dom/text-node-append-data-remove-crash.html:
2011-01-13 Emil Eklund <eae@chromium.org>
Reviewed by Dimitri Glazkov.
Setting outerText should convert CR/LF to <br>
https://bugs.webkit.org/show_bug.cgi?id=52268
Make set outerText support line breaks (sharing the text to fragment code
with setInnerText) and handle empty text nodes the same way IE does.
Test: fast/dom/set-outer-text.html
* html/HTMLElement.cpp:
(WebCore::HTMLElement::textToFragment): Shared between setInnerText and setOuterText
(WebCore::HTMLElement::setInnerText): Split out text parsing code.
(WebCore::mergeWithNextTextNode): Split out text node merging code.
(WebCore::HTMLElement::setOuterText): Added support for line breaks.
* html/HTMLElement.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75738
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 13 Jan 2011 22:39:04 +0000 (22:39 +0000)]
Skip a crashing test on Windows
See <http://webkit.org/b/52397>.
* platform/win/Skipped: Added
compositing/reflections/load-video-in-reflection.html.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75737
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Thu, 13 Jan 2011 22:35:48 +0000 (22:35 +0000)]
2011-01-13 Martin Robinson <mrobinson@igalia.com>
Skip fast/text/emphasis.html as it shows a 1 pixel difference on the 32-bit Debug bot.
* platform/gtk/Skipped: Skip fast/text/emphasis.html.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75736
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zmo@google.com [Thu, 13 Jan 2011 22:34:43 +0000 (22:34 +0000)]
2011-01-13 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Relax the ESSL valid charset a little bit to include " ' `
https://bugs.webkit.org/show_bug.cgi?id=52396
* html/canvas/WebGLRenderingContext.cpp:
2011-01-13 Zhenyao Mo <zmo@google.com>
Reviewed by Kenneth Russell.
Relax the ESSL valid charset a little bit to include " ' `
https://bugs.webkit.org/show_bug.cgi?id=52396
* fast/canvas/webgl/invalid-passed-params-expected.txt:
* fast/canvas/webgl/invalid-passed-params.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75735
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jam@chromium.org [Thu, 13 Jan 2011 21:52:37 +0000 (21:52 +0000)]
2011-01-13 John Abd-El-Malek <jam@chromium.org>
Reviewed by Tony Chang.
[chromium]: Only swallow ctrl+c for windowless plugins if we know the plugin has a selection
https://bugs.webkit.org/show_bug.cgi?id=52393
* src/WebPluginContainerImpl.cpp:
(WebKit::WebPluginContainerImpl::copy):
(WebKit::WebPluginContainerImpl::handleKeyboardEvent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75734
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
enne@google.com [Thu, 13 Jan 2011 20:51:45 +0000 (20:51 +0000)]
2011-01-13 Adrienne Walker <enne@google.com>
Reviewed by Kenneth Russell.
[chromium] Attempt to fix crash in tiled compositor memcpy
https://bugs.webkit.org/show_bug.cgi?id=52379
* platform/graphics/chromium/LayerTilerChromium.cpp:
(WebCore::LayerTilerChromium::update):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75733
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mdelaney@apple.com [Thu, 13 Jan 2011 20:36:06 +0000 (20:36 +0000)]
2011-01-13 Matthew Delaney <mdelaney@apple.com>
Reviewed by nobody - reinstrumenting a test to save burning trees.
fast/canvas/canvas-large-dimensions.html (introduced in r75648) is failing on all platforms except Snow Leopard
https://bugs.webkit.org/show_bug.cgi?id=52341
* fast/canvas/canvas-large-dimensions-expected.txt: Replaced.
* fast/canvas/canvas-large-dimensions.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75732
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jschuh@chromium.org [Thu, 13 Jan 2011 20:11:50 +0000 (20:11 +0000)]
2011-01-13 Justin Schuh <jschuh@chromium.org>
Unreviewed chromium expectations update.
Exclude destroy-on-setwindow.html (added in r75720).
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75731
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jam@chromium.org [Thu, 13 Jan 2011 20:07:25 +0000 (20:07 +0000)]
2011-01-11 John Abd-El-Malek <jam@chromium.org>
Reviewed by Darin Fisher.
[chromium] Add support to allow printing just a plugin in a frame
https://bugs.webkit.org/show_bug.cgi?id=52134
* public/WebContextMenuData.h:
* public/WebFrame.h:
* src/ContextMenuClientImpl.cpp:
(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
* src/WebFrameImpl.cpp:
(WebKit::ChromePluginPrintContext::ChromePluginPrintContext):
(WebKit::ChromePluginPrintContext::end):
(WebKit::ChromePluginPrintContext::computePageRects):
(WebKit::ChromePluginPrintContext::spoolPage):
(WebKit::WebFrameImpl::printBegin):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75730
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alex@webkit.org [Thu, 13 Jan 2011 19:48:10 +0000 (19:48 +0000)]
2011-01-13 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
[gtk] Zero-sized font does not yet work
https://bugs.webkit.org/show_bug.cgi?id=49793
Unskip font-size-zero.html.
* platform/gtk/Skipped:
2011-01-13 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
[gtk] Zero-sized font does not yet work
https://bugs.webkit.org/show_bug.cgi?id=49793
Set minimum-font-size to 0 for the DRT.
* DumpRenderTree/gtk/DumpRenderTree.cpp:
(resetDefaultsToConsistentValues):
2011-01-13 Alejandro G. Castro <alex@igalia.com>
Reviewed by Martin Robinson.
[gtk] Zero-sized font does not yet work
https://bugs.webkit.org/show_bug.cgi?id=49793
Allow 0 as a minimum-font-size value for the settings.
* webkit/webkitwebsettings.cpp:
(webkit_web_settings_class_init):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75729
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Thu, 13 Jan 2011 19:38:11 +0000 (19:38 +0000)]
Unreviewed, rolling out r75725.
http://trac.webkit.org/changeset/75725
https://bugs.webkit.org/show_bug.cgi?id=52317
Caused crashes in layout tests.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::initForStyleResolve):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::updateType):
* html/InputType.cpp:
* html/InputType.h:
* html/RangeInputType.cpp:
* html/RangeInputType.h:
* html/shadow/SliderThumbElement.cpp:
(WebCore::SliderThumbElement::defaultEventHandler):
(WebCore::SliderThumbElement::detach):
* html/shadow/SliderThumbElement.h:
(WebCore::SliderThumbElement::SliderThumbElement):
(WebCore::SliderThumbElement::create):
* rendering/MediaControlElements.cpp:
(WebCore::MediaControlInputElement::attach):
(WebCore::MediaControlInputElement::updateStyle):
* rendering/RenderSlider.cpp:
(WebCore::RenderSlider::~RenderSlider):
(WebCore::RenderSlider::styleDidChange):
(WebCore::RenderSlider::createThumbStyle):
(WebCore::RenderSlider::thumbRect):
(WebCore::RenderSlider::layout):
(WebCore::RenderSlider::updateFromElement):
(WebCore::RenderSlider::mouseEventIsInThumb):
(WebCore::RenderSlider::mouseEventOffsetToThumb):
(WebCore::RenderSlider::setValueForPosition):
(WebCore::RenderSlider::positionForOffset):
(WebCore::RenderSlider::currentPosition):
(WebCore::RenderSlider::trackSize):
(WebCore::RenderSlider::forwardEvent):
(WebCore::RenderSlider::inDragMode):
* rendering/RenderSlider.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75728
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Thu, 13 Jan 2011 18:56:14 +0000 (18:56 +0000)]
2011-01-13 Tony Chang <tony@chromium.org>
Unreviewed, updating chromium test_expectations.txt
* platform/chromium/test_expectations.txt: Mark a test as slow in debug.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75727
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Thu, 13 Jan 2011 18:37:33 +0000 (18:37 +0000)]
2011-01-13 Csaba Osztrogonác <ossy@webkit.org>
Reviewed by Darin Adler.
Make old-run-webkit-tests more robust on buildbots
https://bugs.webkit.org/show_bug.cgi?id=52364
* BuildSlaveSupport/build.webkit.org-config/master.cfg: Pass --exit-after-n-failures 500 to old-run-webkit-tests script.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75726
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dglazkov@chromium.org [Thu, 13 Jan 2011 18:35:02 +0000 (18:35 +0000)]
2011-01-12 Dimitri Glazkov <dglazkov@chromium.org>
Reviewed by Darin Adler.
Flip input[type=range] to use the new shadow DOM model.
https://bugs.webkit.org/show_bug.cgi?id=52317
This is a straight-up flip, minimal change to the logic, which will be
refactored in a follow-up patch.
Covered by existing tests.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::initForStyleResolve): Changed to use either
host or parent node to find parent.
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::updateType): Added logic for destroying/creating
shadow DOM subtree.
* html/InputType.cpp:
(WebCore::InputType::createShadowSubtree): Added empty decl.
(WebCore::InputType::destroyShadowSubtree): Added a method to destroy
shadow subtree.
* html/InputType.h: Added defs.
* html/RangeInputType.cpp:
(WebCore::RangeInputType::createShadowSubtree): Added a virtual method to create
slider thumb.
* html/RangeInputType.h: Adde def.
* html/shadow/SliderThumbElement.cpp: Added temporary RenderSliderThumb class
to handle cascading appearance.
(WebCore::RenderSliderThumb::RenderSliderThumb): Added.
(WebCore::RenderSliderThumb::layout): Moved here the logic from
RenderSlider::createThumbStyle.
(WebCore::SliderThumbElement::createRenderer): Added virtual method to
create RenderSliderThumb instance.
(WebCore::SliderThumbElement::defaultEventHandler): Changed to use HTMLDivElement
as base class.
(WebCore::SliderThumbElement::detach): Ditto.
* html/shadow/SliderThumbElement.h:
(WebCore::SliderThumbElement::SliderThumbElement): Ditto.
(WebCore::SliderThumbElement::create): Ditto.
(WebCore::toSliderThumbElement): Added a casting helper.
* rendering/MediaControlElements.cpp:
(WebCore::MediaControlInputElement::attach): Added handling of shadow DOM,
since the whole method is hand-rolled.
(WebCore::MediaControlInputElement::updateStyle): Ditto.
* rendering/RenderSlider.cpp:
(WebCore::RenderSlider::~RenderSlider): Removed unneeded code.
(WebCore::RenderSlider::thumbRect): Changed to use sliderThumbElement helper.
(WebCore::RenderSlider::layout): Ditto.
(WebCore::RenderSlider::sliderThumbElement): Added a temporary helper to access
SliderThumbElement.
(WebCore::RenderSlider::mouseEventIsInThumb): Changed to use sliderThumbElement helper.
(WebCore::RenderSlider::mouseEventOffsetToThumb): Ditto.
(WebCore::RenderSlider::setValueForPosition): Ditto.
(WebCore::RenderSlider::positionForOffset): Ditto.
(WebCore::RenderSlider::currentPosition): Ditto.
(WebCore::RenderSlider::trackSize): Ditto.
(WebCore::RenderSlider::forwardEvent): Ditto.
(WebCore::RenderSlider::inDragMode): Ditto.
* rendering/RenderSlider.h: Added def.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75725
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 13 Jan 2011 18:34:25 +0000 (18:34 +0000)]
Check in Windows-XP-specific results for fast/canvas/set-colors.html
See <http://webkit.org/b/52374>.
* platform/win-xp/fast/canvas/set-colors-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75724
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 13 Jan 2011 18:33:54 +0000 (18:33 +0000)]
Disable fast/profiler/throw-exception-from-eval.html
This test fails non-deterministically. See <http://webkit.org/b/49801>.
* fast/profiler/throw-exception-from-eval.html-disabled: Renamed from LayoutTests/fast/profiler/throw-exception-from-eval.html.
* platform/gtk/Skipped:
* platform/mac-leopard/Skipped:
* platform/qt/Skipped:
Un-skipped this test now that it's been disabled by other means.
* platform/win-xp/fast/profiler/throw-exception-from-eval-expected.txt: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75723
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Thu, 13 Jan 2011 18:24:17 +0000 (18:24 +0000)]
Incorrect assertion in DrawingAreaImpl::scroll()
https://bugs.webkit.org/show_bug.cgi?id=52376
Reviewed by John Sullivan.
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::scroll): Changed to take the fast path if the rects have the same area.
This made the assertion valid, but I removed it anyway.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75722
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Thu, 13 Jan 2011 18:22:58 +0000 (18:22 +0000)]
2011-01-13 Csaba Osztrogonác <ossy@webkit.org>
Reviewed by Darin Adler.
Make old-run-webkit-tests more robust on buildbots
https://bugs.webkit.org/show_bug.cgi?id=52364
* Scripts/old-run-webkit-tests: Ensure that testResultsDirectory is empty.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75721
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Thu, 13 Jan 2011 18:21:15 +0000 (18:21 +0000)]
<rdar://problem/
8098442> Crash in Widget::setFrameRect()
https://bugs.webkit.org/show_bug.cgi?id=52375
Reviewed by Simon Fraser.
Source/WebCore:
Test: plugins/destroy-on-setwindow.html
* platform/mac/WidgetMac.mm:
(WebCore::Widget::setFrameRect): Protect the Widget from being deleted as a result of calling
out to the view.
(WebCore::Widget::getOuterView): Coding style fix.
(WebCore::Widget::paint): Protect the Widget from being deleted as a result of calling out to
the views. This is precautionary, since this function does not applear to access member variables
after such calls.
* platform/wx/WidgetWx.cpp:
(WebCore::Widget::setFrameRect): Protect the Widget from being deleted as a result of calling
out to the platform widget.
LayoutTests:
* plugins/destroy-on-setwindow-expected.txt: Added.
* plugins/destroy-on-setwindow.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75720
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Thu, 13 Jan 2011 17:52:11 +0000 (17:52 +0000)]
2011-01-13 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
https://bugs.webkit.org/show_bug.cgi?id=52332
Fix Linux baseline. Mac should now match Safari Mac.
* platform/chromium-linux/plugins/plugin-javascript-access-expected.txt:
* platform/chromium/test_expectations.txt:
2011-01-13 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
https://bugs.webkit.org/show_bug.cgi?id=52332
Forked Info.plist is not longer needed.
* DumpRenderTree/chromium/TestNetscapePlugIn/Info.plist: Removed.
2011-01-13 Tony Chang <tony@chromium.org>
Reviewed by Kent Tamura.
[chromium] fix plugins/plugin-javascript-access.html on Linux and Mac
https://bugs.webkit.org/show_bug.cgi?id=52332
* WebKit.gyp: Remove WebKitTestNetscapePlugIn
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75719
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Thu, 13 Jan 2011 17:25:27 +0000 (17:25 +0000)]
Unreviewed buildfix after r75715.
* WebCore.pri:
* WebCore.pro:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75718
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Thu, 13 Jan 2011 17:23:32 +0000 (17:23 +0000)]
2011-01-13 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: inspector extensions tests should not use
sources as test data. Commenting one out temporarily, filing a bug.
* inspector/extensions-events-expected.txt:
* inspector/extensions-events.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75717
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Thu, 13 Jan 2011 16:57:48 +0000 (16:57 +0000)]
2011-01-13 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: Qt build fix.
* WebCore.pri:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75716
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Thu, 13 Jan 2011 16:42:03 +0000 (16:42 +0000)]
2011-01-12 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: embed injected script into the backend.
https://bugs.webkit.org/show_bug.cgi?id=52312
InjectedScript belongs to the backend of the system and
should be exposed by means of protocol, not InjectedScriptAccess.
This patch makes injected script a part of the backend.
It introduces single manual generation step (xxd -i) that should be
automated by the build scripts for all the platforms.
* CMakeLists.txt:
* DerivedSources.make:
* GNUmakefile.am:
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSInjectedScriptHostCustom.cpp:
(WebCore::InjectedScriptHost::injectedScriptFor):
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::InjectedScriptHost::injectedScriptFor):
* inspector/InjectedScriptHost.cpp:
(WebCore::InjectedScriptHost::injectedScriptSource):
* inspector/InjectedScriptHost.h:
* inspector/Inspector.idl:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::restoreInspectorStateFromCookie):
* inspector/InspectorState.cpp:
(WebCore::InspectorState::InspectorState):
* inspector/InspectorState.h:
* inspector/front-end/InjectedScript.js: Removed.
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:
* inspector/front-end/inspector.js:
(WebInspector.doLoadedDone.propertyNamesCallback):
(WebInspector.doLoadedDone):
* inspector/xxd.pl: Added.
2011-01-12 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: embed injected script into the backend.
https://bugs.webkit.org/show_bug.cgi?id=52312
* WebKit.grd:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75715
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mnaganov@chromium.org [Thu, 13 Jan 2011 15:49:37 +0000 (15:49 +0000)]
2011-01-13 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Timothy Hatcher.
Web Inspector: Cleanup after r75613 -- make all UI-facing strings
to be passed directly to WebInspector.UIString
https://bugs.webkit.org/show_bug.cgi?id=52365
* English.lproj/localizedStrings.js:
* inspector/front-end/ApplicationCacheItemsView.js:
(WebInspector.ApplicationCacheItemsView.prototype._updateCallback):
(WebInspector.ApplicationCacheItemsView.prototype._populateDataGrid):
* inspector/front-end/AuditRules.js:
(WebInspector.AuditRules.GzipRule.prototype.doRun):
(WebInspector.AuditRules.CookieSizeRule.prototype.processCookies):
(WebInspector.AuditRules.StaticCookielessRule.prototype.processCookies):
* inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector.EventListenerBreakpointsSidebarPane):
(WebInspector.EventListenerBreakpointsSidebarPane.prototype._createCategory):
* inspector/front-end/CookieItemsView.js:
(WebInspector.CookieItemsView.prototype._updateWithCookies):
* inspector/front-end/ImageView.js:
(WebInspector.ImageView.prototype._createContentIfNeeded.onImageLoad):
(WebInspector.ImageView.prototype._createContentIfNeeded):
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkTimeCalculator.prototype.formatValue):
(WebInspector.NetworkTransferTimeCalculator.prototype.formatValue):
(WebInspector.NetworkTransferDurationCalculator.prototype.formatValue):
* inspector/front-end/ProfileDataGridTree.js:
(WebInspector.ProfileDataGridNode.prototype.get data.formatMilliseconds):
(WebInspector.ProfileDataGridNode.prototype.get data):
* inspector/front-end/Resource.js:
(WebInspector.Resource.Type.toUIString):
(WebInspector.Resource.Type.toString):
* inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineOverviewCalculator.prototype.formatValue):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel):
(WebInspector.TimelineCalculator.prototype.formatValue):
(WebInspector.TimelinePanel.FormattedRecord.prototype._generateAggregatedInfo):
(WebInspector.TimelinePanel.FormattedRecord.prototype._generatePopupContent):
(WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
* inspector/front-end/utilities.js:
():
* Scripts/check-inspector-strings:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75714
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 13 Jan 2011 15:45:39 +0000 (15:45 +0000)]
2011-01-13 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Need a way to inform the application when a Netscape plugin is created.
https://bugs.webkit.org/show_bug.cgi?id=30179
Added "c" style static method for the application to hook up for
receiving notifications when a plugin is created.
* plugins/symbian/PluginViewSymbian.cpp:
(qtwebkit_setPluginCreatedCallback):
(WebCore::PluginView::platformStart):
2011-01-13 Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Need a way to inform the application when a Netscape plugin is created.
https://bugs.webkit.org/show_bug.cgi?id=30179
Added "c" style static method for the application to hook up for
receiving notifications when a plugin is created.
* symbian/bwins/QtWebKitu.def:
* symbian/eabi/QtWebKitu.def:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75713
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 13 Jan 2011 15:29:24 +0000 (15:29 +0000)]
2011-01-13 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Eric Seidel.
[Qt] Use a black background color for the video element on Qt Mobile
https://bugs.webkit.org/show_bug.cgi?id=52252
Use black as the background color for the video element on Qt Mobile.
* css/themeQtMobile.css:
(video):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75712
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 13 Jan 2011 15:12:08 +0000 (15:12 +0000)]
2011-01-13 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Eric Seidel.
[Qt] Use a big central media play control button for video element
https://bugs.webkit.org/show_bug.cgi?id=52315
When ChromeClient::requiresFullscreenForVideoPlayback() returns true,
all other control buttons for the video element are hidden, except
a big centralized play button.
No new tests because no client implements requiresFullscreenForVideoPlayback yet.
* WebCore.pri:
* css/mediaControlsQtFullscreen.css: Added.
(audio):
(audio::-webkit-media-controls-panel):
(video::-webkit-media-controls-panel):
(video:-webkit-full-page-media::-webkit-media-controls-panel):
(audio::-webkit-media-controls-mute-button):
(video::-webkit-media-controls-mute-button):
(audio::-webkit-media-controls-play-button):
(video::-webkit-media-controls-play-button):
(audio::-webkit-media-controls-timeline-container):
(video::-webkit-media-controls-timeline-container):
(audio::-webkit-media-controls-current-time-display):
(video::-webkit-media-controls-current-time-display):
(audio::-webkit-media-controls-time-remaining-display, video::-webkit-media-controls-time-remaining-display):
(audio::-webkit-media-controls-timeline):
(video::-webkit-media-controls-timeline):
(audio::-webkit-media-controls-volume-slider-container):
(video::-webkit-media-controls-volume-slider-container):
(audio::-webkit-media-controls-volume-slider):
(video::-webkit-media-controls-volume-slider):
(audio::-webkit-media-controls-seek-back-button, video::-webkit-media-controls-seek-back-button):
(audio::-webkit-media-controls-seek-forward-button, video::-webkit-media-controls-seek-forward-button):
(audio::-webkit-media-controls-fullscreen-button):
(video::-webkit-media-controls-fullscreen-button):
(audio::-webkit-media-controls-rewind-button, video::-webkit-media-controls-rewind-button):
(audio::-webkit-media-controls-return-to-realtime-button, video::-webkit-media-controls-return-to-realtime-button):
(audio::-webkit-media-controls-toggle-closed-captions-button, video::-webkit-media-controls-toggle-closed-captions-button):
* platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::extraMediaControlsStyleSheet):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75711
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Thu, 13 Jan 2011 12:07:22 +0000 (12:07 +0000)]
2011-01-13 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Xan Lopez.
[GTK] Paint toggle buttons inconsistent when the object state is indeterminate
https://bugs.webkit.org/show_bug.cgi?id=52361
Check whether the object state is indeterminate to set the flag
GTK_STATE_FLAG_INCONSISTENT before rendering check and radio
buttons.
* platform/gtk/RenderThemeGtk3.cpp:
(WebCore::paintToggle):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75710
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xan@webkit.org [Thu, 13 Jan 2011 11:58:25 +0000 (11:58 +0000)]
2011-01-13 Xan Lopez <xlopez@igalia.com>
Reviewed by Gavin Barraclough.
JIT requires VM overcommit (particularly on x86-64), Linux does not by default support this without swap?
https://bugs.webkit.org/show_bug.cgi?id=42756
The FixedVMPool Allocator does not work well on systems where
allocating very large amounts of memory upfront is not reasonable,
like Linux without overcommit enabled. As a workaround, on Linux,
default to the values used in embedded environments (in the MB
range), and only jump to the GB range if we detect at runtime that
overcommit is enabled. Should fix crashes on Linux/x86_64 with
less than 3 or 4GB of RAM.
* jit/ExecutableAllocatorFixedVMPool.cpp:
(JSC::FixedVMPoolAllocator::free): use new variables for VM pool
size and coalesce limit.
(JSC::ExecutableAllocator::isValid): swap the variables from
embedded to generic values at runtime, on linux, if overcommit is
enabled.
(JSC::ExecutableAllocator::underMemoryPressure): use new variables
for VM pool size and coalesce limit.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75709
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 13 Jan 2011 11:46:53 +0000 (11:46 +0000)]
2011-01-13 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Extend the Platform Plugin to support full screen video handler
https://bugs.webkit.org/show_bug.cgi?id=51249
Make MediaPlayerPrivateQt support a fullscreen player.
No new tests because LayoutTests/media/media-fullscreen-inline.html already exists.
However, this test failed for Qt (QtMediaPlayer) due to durationchange event getting fired twice.
So, still skip it for Qt.
* WebCore.pro:
* platform/graphics/qt/MediaPlayerPrivateQt.cpp:
(WebCore::MediaPlayerPrivateQt::MediaPlayerPrivateQt):
(WebCore::MediaPlayerPrivateQt::removeVideoItem):
(WebCore::MediaPlayerPrivateQt::restoreVideoItem):
* platform/graphics/qt/MediaPlayerPrivateQt.h:
(WebCore::MediaPlayerPrivateQt::supportsFullscreen):
(WebCore::MediaPlayerPrivateQt::mediaPlayer):
2011-01-13 Yi Shen <yi.4.shen@nokia.com>
Reviewed by Simon Hausmann.
[Qt] Extend the Platform Plugin to support full screen video handler
https://bugs.webkit.org/show_bug.cgi?id=51249
Add a new webkit platform plugin interface to support full screen video handler.
* Api/qwebkitplatformplugin.h:
(QWebFullScreenVideoHandler::QWebFullScreenVideoHandler):
(QWebFullScreenVideoHandler::~QWebFullScreenVideoHandler):
* WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::ChromeClientQt):
(WebCore::ChromeClientQt::~ChromeClientQt):
(WebCore::ChromeClientQt::fullScreenVideo):
(WebCore::ChromeClientQt::supportsFullscreenForNode):
(WebCore::ChromeClientQt::requiresFullscreenForVideoPlayback):
(WebCore::ChromeClientQt::enterFullscreenForNode):
(WebCore::ChromeClientQt::exitFullscreenForNode):
* WebCoreSupport/ChromeClientQt.h:
* WebCoreSupport/FullScreenVideoQt.cpp: Added.
(WebCore::FullScreenVideoQt::FullScreenVideoQt):
(WebCore::FullScreenVideoQt::~FullScreenVideoQt):
(WebCore::FullScreenVideoQt::enterFullScreenForNode):
(WebCore::FullScreenVideoQt::exitFullScreenForNode):
(WebCore::FullScreenVideoQt::aboutToClose):
(WebCore::FullScreenVideoQt::mediaPlayer):
(WebCore::FullScreenVideoQt::mediaPlayerForNode):
(WebCore::FullScreenVideoQt::requiresFullScreenForVideoPlayback):
* WebCoreSupport/FullScreenVideoQt.h: Added.
(WebCore::FullScreenVideoQt::isValid):
* WebCoreSupport/QtPlatformPlugin.cpp:
(WebCore::QtPlatformPlugin::createFullScreenVideoHandler):
* WebCoreSupport/QtPlatformPlugin.h:
* examples/platformplugin/WebPlugin.cpp:
(FullScreenVideoWidget::FullScreenVideoWidget):
(FullScreenVideoWidget::event):
(FullScreenVideoWidget::keyPressEvent):
(FullScreenVideoHandler::FullScreenVideoHandler):
(FullScreenVideoHandler::~FullScreenVideoHandler):
(FullScreenVideoHandler::requiresFullScreenForVideoPlayback):
(FullScreenVideoHandler::enterFullScreen):
(FullScreenVideoHandler::exitFullScreen):
(WebPlugin::supportsExtension):
(WebPlugin::createExtension):
* examples/platformplugin/WebPlugin.h:
(FullScreenVideoWidget::~FullScreenVideoWidget):
* examples/platformplugin/platformplugin.pro:
* examples/platformplugin/qwebkitplatformplugin.h:
(QWebFullScreenVideoHandler::QWebFullScreenVideoHandler):
(QWebFullScreenVideoHandler::~QWebFullScreenVideoHandler):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75708
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Thu, 13 Jan 2011 09:50:33 +0000 (09:50 +0000)]
<rdar://problem/
8858548> Disable inheritance of text emphasis marks to ruby text
https://bugs.webkit.org/show_bug.cgi?id=52359
Reviewed by Dave Hyatt.
Source/WebCore:
Test: fast/ruby/text-emphasis.html
* css/html.css:
(rt):
LayoutTests:
* fast/ruby/text-emphasis-expected.txt: Added.
* fast/ruby/text-emphasis.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75707
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hayato@chromium.org [Thu, 13 Jan 2011 08:39:55 +0000 (08:39 +0000)]
2011-01-13 Hayato Ito <hayato@chromium.org>
Unreviewed, chromium test expectations.
Flaky expectations for html5lib/webkit-resumer.html.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75706
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 13 Jan 2011 08:26:53 +0000 (08:26 +0000)]
2011-01-13 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r74881.
http://trac.webkit.org/changeset/74881
https://bugs.webkit.org/show_bug.cgi?id=52357
The EFL builder has been red for days (Requested by abarth on
#webkit).
* Scripts/webkitpy/common/net/buildbot/buildbot.py:
* Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75705
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Thu, 13 Jan 2011 08:25:14 +0000 (08:25 +0000)]
Trivial fix after r75682.
Rubber-stamped by David Levin.
* loader/FrameLoader.cpp: Remove accidentally committed debug code.
(WebCore::FrameLoader::shouldClose):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@75704
268f45cc-cd09-0410-ab3c-
d52691b4dbfc