WebKit-https.git
9 years agoEnable SUBPIXEL_LAYOUT on Mac
simon.fraser@apple.com [Fri, 2 Nov 2012 21:35:02 +0000 (21:35 +0000)]
Enable SUBPIXEL_LAYOUT on Mac
https://bugs.webkit.org/show_bug.cgi?id=101076

Reviewed by Dave Hyatt.

Source/JavaScriptCore:

Define ENABLE_SUBPIXEL_LAYOUT and include it in FEATURE_DEFINES.

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Define ENABLE_SUBPIXEL_LAYOUT and include it in FEATURE_DEFINES.

* Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

Define ENABLE_SUBPIXEL_LAYOUT and include it in FEATURE_DEFINES.

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Define ENABLE_SUBPIXEL_LAYOUT and include it in FEATURE_DEFINES.

* Configurations/FeatureDefines.xcconfig:

LayoutTests:

Update results affected by subpixel layout.

* platform/mac/accessibility/svg-bounds-expected.txt:
* platform/mac/accessibility/svg-remote-element-expected.txt: Copied from LayoutTests/platform/mac/accessibility/svg-bounds-expected.txt.
* platform/mac/animations/keyframes-comma-separated-expected.txt: Added.
* platform/mac/compositing/direct-image-compositing-expected.txt:
* platform/mac/compositing/overflow/theme-affects-visual-overflow-expected.txt:
* platform/mac/compositing/shadows/shadow-drawing-expected.txt:
* platform/mac/compositing/tiling/tile-cache-zoomed-expected.txt: Added.
* platform/mac/compositing/visibility/visibility-image-layers-dynamic-expected.txt: Added.
* platform/mac/css1/basic/inheritance-expected.txt:
* platform/mac/css1/box_properties/acid_test-expected.txt:
* platform/mac/css1/box_properties/clear_float-expected.txt:
* platform/mac/css1/box_properties/float_on_text_elements-expected.txt:
* platform/mac/css1/box_properties/margin-expected.txt:
* platform/mac/css1/box_properties/margin_bottom-expected.txt:
* platform/mac/css1/box_properties/margin_right-expected.txt:
* platform/mac/css1/box_properties/margin_top-expected.txt:
* platform/mac/css1/box_properties/padding-expected.txt:
* platform/mac/css1/box_properties/padding_bottom-expected.txt:
* platform/mac/css1/box_properties/padding_left-expected.txt:
* platform/mac/css1/box_properties/padding_right-expected.txt:
* platform/mac/css1/box_properties/padding_top-expected.txt:
* platform/mac/css1/box_properties/width-expected.txt:
* platform/mac/css1/color_and_background/background_attachment-expected.txt:
* platform/mac/css1/font_properties/font-expected.txt:
* platform/mac/css1/font_properties/font_size-expected.txt:
* platform/mac/css1/font_properties/font_weight-expected.txt:
* platform/mac/css1/formatting_model/floating_elements-expected.txt:
* platform/mac/css1/formatting_model/horizontal_formatting-expected.txt:
* platform/mac/css1/formatting_model/inline_elements-expected.txt:
* platform/mac/css1/formatting_model/replaced_elements-expected.txt:
* platform/mac/css1/formatting_model/vertical_formatting-expected.txt:
* platform/mac/css1/text_properties/text_indent-expected.txt:
* platform/mac/css1/text_properties/vertical_align-expected.txt:
* platform/mac/css1/units/percentage_units-expected.txt:
* platform/mac/css1/units/rounding-expected.txt: Added.
* platform/mac/css2.1/20110323/block-replaced-width-001-expected.txt:
* platform/mac/css2.1/20110323/floating-replaced-height-008-expected.txt:
* platform/mac/css2.1/20110323/inline-block-replaced-height-008-expected.txt:
* platform/mac/css2.1/20110323/inline-replaced-height-008-expected.txt:
* platform/mac/css2.1/t0803-c5501-mrgn-t-00-b-a-expected.txt:
* platform/mac/css2.1/t0803-c5503-mrgn-b-00-b-a-expected.txt:
* platform/mac/css2.1/t080301-c411-vt-mrgn-00-b-expected.txt:
* platform/mac/css2.1/t0804-c5507-padn-r-00-c-ag-expected.txt:
* platform/mac/css2.1/t0804-c5509-padn-l-03-f-g-expected.txt:
* platform/mac/css2.1/t0804-c5510-padn-00-b-ag-expected.txt:
* platform/mac/css2.1/t09-c5526c-display-00-e-expected.txt:
* platform/mac/css2.1/t0905-c414-flt-wrap-00-e-expected.txt:
* platform/mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.txt:
* platform/mac/css2.1/t090501-c414-flt-03-b-g-expected.txt:
* platform/mac/css2.1/t1002-c5523-width-02-b-g-expected.txt:
* platform/mac/css2.1/t100801-c544-valgn-00-a-ag-expected.txt:
* platform/mac/css2.1/t100801-c544-valgn-02-d-agi-expected.txt:
* platform/mac/css2.1/t100801-c544-valgn-03-d-agi-expected.txt:
* platform/mac/css2.1/t100801-c544-valgn-04-d-agi-expected.txt:
* platform/mac/css2.1/t1205-c565-list-pos-00-b-expected.txt:
* platform/mac/css2.1/t1506-c525-font-wt-00-b-expected.txt:
* platform/mac/css2.1/t1508-c527-font-09-b-expected.txt:
* platform/mac/css2.1/t1602-c43-center-00-d-ag-expected.txt:
* platform/mac/css3/flexbox/flexbox-baseline-expected.txt:
* platform/mac/css3/selectors3/html/css3-modsel-23-expected.txt:
* platform/mac/css3/selectors3/html/css3-modsel-24-expected.txt:
* platform/mac/css3/selectors3/html/css3-modsel-25-expected.txt:
* platform/mac/css3/selectors3/html/css3-modsel-68-expected.txt:
* platform/mac/css3/selectors3/html/css3-modsel-69-expected.txt:
* platform/mac/css3/selectors3/html/css3-modsel-70-expected.txt:
* platform/mac/css3/selectors3/xhtml/css3-modsel-23-expected.txt:
* platform/mac/css3/selectors3/xhtml/css3-modsel-24-expected.txt:
* platform/mac/css3/selectors3/xhtml/css3-modsel-25-expected.txt:
* platform/mac/css3/selectors3/xhtml/css3-modsel-68-expected.txt:
* platform/mac/css3/selectors3/xhtml/css3-modsel-69-expected.txt:
* platform/mac/css3/selectors3/xhtml/css3-modsel-70-expected.txt:
* platform/mac/css3/selectors3/xml/css3-modsel-23-expected.txt:
* platform/mac/css3/selectors3/xml/css3-modsel-24-expected.txt:
* platform/mac/css3/selectors3/xml/css3-modsel-25-expected.txt:
* platform/mac/css3/selectors3/xml/css3-modsel-68-expected.txt:
* platform/mac/css3/selectors3/xml/css3-modsel-69-expected.txt:
* platform/mac/css3/selectors3/xml/css3-modsel-70-expected.txt:
* platform/mac/css3/unicode-bidi-isolate-basic-expected.txt:
* platform/mac/editing/inserting/editing-empty-divs-expected.txt:
* platform/mac/editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.txt:
* platform/mac/editing/selection/3690703-2-expected.txt:
* platform/mac/editing/selection/3690703-expected.txt:
* platform/mac/editing/selection/3690719-expected.txt:
* platform/mac/editing/selection/4397952-expected.txt:
* platform/mac/editing/selection/5240265-expected.txt:
* platform/mac/editing/selection/5354455-2-expected.txt:
* platform/mac/editing/selection/caret-ltr-2-expected.txt:
* platform/mac/editing/selection/caret-ltr-2-left-expected.txt:
* platform/mac/editing/selection/caret-ltr-expected.txt:
* platform/mac/editing/selection/caret-ltr-right-expected.txt:
* platform/mac/editing/selection/caret-rtl-2-expected.txt:
* platform/mac/editing/selection/caret-rtl-2-left-expected.txt:
* platform/mac/editing/selection/caret-rtl-expected.txt:
* platform/mac/editing/selection/caret-rtl-right-expected.txt:
* platform/mac/editing/selection/collapse-selection-in-bidi-expected.txt: Added.
* platform/mac/editing/selection/drag-start-event-client-x-y-expected.txt: Added.
* platform/mac/editing/selection/mixed-editability-10-expected.txt: Added.
* platform/mac/editing/selection/select-across-readonly-input-1-expected.txt:
* platform/mac/editing/selection/select-across-readonly-input-2-expected.txt:
* platform/mac/editing/selection/select-across-readonly-input-3-expected.txt:
* platform/mac/editing/selection/select-across-readonly-input-4-expected.txt:
* platform/mac/editing/selection/select-across-readonly-input-5-expected.txt:
* platform/mac/editing/selection/select-text-overflow-ellipsis-expected.txt:
* platform/mac/editing/selection/selection-button-text-expected.txt:
* platform/mac/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.txt:
* platform/mac/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.txt:
* platform/mac/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.txt:
* platform/mac/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.txt:
* platform/mac/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt:
* platform/mac/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt:
* platform/mac/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.txt:
* platform/mac/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.txt:
* platform/mac/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.txt:
* platform/mac/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.txt:
* platform/mac/fast/backgrounds/background-inherit-color-bug-expected.txt:
* platform/mac/fast/backgrounds/background-position-parsing-expected.txt:
* platform/mac/fast/backgrounds/size/contain-and-cover-zoomed-expected.txt: Added.
* platform/mac/fast/block/basic/001-expected.txt:
* platform/mac/fast/block/basic/011-expected.txt:
* platform/mac/fast/block/basic/014-expected.txt:
* platform/mac/fast/block/basic/015-expected.txt:
* platform/mac/fast/block/basic/016-expected.txt:
* platform/mac/fast/block/basic/019-expected.txt:
* platform/mac/fast/block/basic/fieldset-stretch-to-legend-expected.txt:
* platform/mac/fast/block/float/013-expected.txt:
* platform/mac/fast/block/float/025-expected.txt:
* platform/mac/fast/block/float/026-expected.txt:
* platform/mac/fast/block/float/027-expected.txt:
* platform/mac/fast/block/float/028-expected.txt:
* platform/mac/fast/block/float/032-expected.txt:
* platform/mac/fast/block/float/centered-float-avoidance-complexity-expected.txt:
* platform/mac/fast/block/float/float-avoidance-expected.txt:
* platform/mac/fast/block/float/float-in-float-painting-expected.txt:
* platform/mac/fast/block/float/nopaint-after-layer-destruction2-expected.txt:
* platform/mac/fast/block/float/overhanging-tall-block-expected.txt:
* platform/mac/fast/block/float/shrink-to-avoid-float-complexity-expected.txt:
* platform/mac/fast/block/margin-collapse/100-expected.txt:
* platform/mac/fast/block/margin-collapse/103-expected.txt:
* platform/mac/fast/block/positioning/047-expected.txt:
* platform/mac/fast/block/positioning/051-expected.txt:
* platform/mac/fast/block/positioning/inline-block-relposition-expected.txt:
* platform/mac/fast/block/positioning/replaced-inside-fixed-top-bottom-expected.txt: Added.
* platform/mac/fast/borders/bidi-002-expected.txt:
* platform/mac/fast/borders/bidi-009a-expected.txt:
* platform/mac/fast/borders/bidi-012-expected.txt:
* platform/mac/fast/borders/fieldsetBorderRadius-expected.txt: Added.
* platform/mac/fast/borders/rtl-border-01-expected.txt:
* platform/mac/fast/borders/rtl-border-02-expected.txt:
* platform/mac/fast/borders/rtl-border-03-expected.txt:
* platform/mac/fast/box-sizing/box-sizing-expected.txt:
* platform/mac/fast/canvas/webgl/oes-element-index-uint-expected.txt: Added.
* platform/mac/fast/canvas/webgl/tex-image-and-sub-image-2d-with-array-buffer-view-expected.txt: Added.
* platform/mac/fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data-expected.txt: Added.
* platform/mac/fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data-rgb565-expected.txt: Added.
* platform/mac/fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data-rgba4444-expected.txt: Added.
* platform/mac/fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data-rgba5551-expected.txt: Added.
* platform/mac/fast/clip/overflow-border-radius-composited-expected.txt:
* platform/mac/fast/clip/overflow-border-radius-transformed-expected.txt:
* platform/mac/fast/css-generated-content/011-expected.txt:
* platform/mac/fast/css-generated-content/012-expected.txt:
* platform/mac/fast/css-generated-content/013-expected.txt:
* platform/mac/fast/css-generated-content/014-expected.txt:
* platform/mac/fast/css-generated-content/015-expected.txt:
* platform/mac/fast/css-generated-content/inline-display-types-expected.txt:
* platform/mac/fast/css/003-expected.txt:
* platform/mac/fast/css/004-expected.txt:
* platform/mac/fast/css/005-expected.txt:
* platform/mac/fast/css/absolute-child-with-percent-height-inside-relative-parent-expected.txt:
* platform/mac/fast/css/background-shorthand-invalid-url-expected.txt:
* platform/mac/fast/css/bidi-override-in-anonymous-block-expected.txt:
* platform/mac/fast/css/bug4860-absolute-block-child-does-not-inherit-alignment-expected.txt: Added.
* platform/mac/fast/css/continuationCrash-expected.txt:
* platform/mac/fast/css/css1_forward_compatible_parsing-expected.txt:
* platform/mac/fast/css/css2-system-fonts-expected.txt:
* platform/mac/fast/css/empty-pseudo-class-expected.txt:
* platform/mac/fast/css/ex-after-font-variant-expected.txt:
* platform/mac/fast/css/fieldset-display-row-expected.txt:
* platform/mac/fast/css/first-child-pseudo-class-expected.txt:
* platform/mac/fast/css/first-line-text-decoration-expected.txt:
* platform/mac/fast/css/first-line-text-decoration-inherited-from-parent-expected.txt:
* platform/mac/fast/css/first-of-type-pseudo-class-expected.txt:
* platform/mac/fast/css/h1-in-section-elements-expected.txt:
* platform/mac/fast/css/hsl-color-expected.txt:
* platform/mac/fast/css/hsla-color-expected.txt:
* platform/mac/fast/css/inline-properties-important-expected.txt:
* platform/mac/fast/css/invalid-percentage-property-expected.txt:
* platform/mac/fast/css/large-number-round-trip-expected.txt: Added.
* platform/mac/fast/css/last-child-pseudo-class-expected.txt:
* platform/mac/fast/css/last-of-type-pseudo-class-expected.txt:
* platform/mac/fast/css/margin-top-bottom-dynamic-expected.txt:
* platform/mac/fast/css/non-standard-checkbox-size-expected.txt:
* platform/mac/fast/css/only-child-pseudo-class-expected.txt:
* platform/mac/fast/css/only-of-type-pseudo-class-expected.txt:
* platform/mac/fast/css/percentage-non-integer-expected.txt:
* platform/mac/fast/css/preserve-user-specified-zoom-level-on-reload-expected.txt:
* platform/mac/fast/css/rgb-float-expected.txt:
* platform/mac/fast/css/rtl-ordering-expected.txt:
* platform/mac/fast/css/selector-set-attribute-expected.txt:
* platform/mac/fast/css/text-align-expected.txt:
* platform/mac/fast/css/text-overflow-ellipsis-text-align-center-expected.txt:
* platform/mac/fast/css/text-overflow-ellipsis-text-align-justify-expected.txt:
* platform/mac/fast/css/text-overflow-ellipsis-text-align-left-expected.txt:
* platform/mac/fast/css/text-overflow-ellipsis-text-align-right-expected.txt:
* platform/mac/fast/css/transform-default-parameter-expected.txt:
* platform/mac/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.txt:
* platform/mac/fast/css/vertical-text-overflow-ellipsis-text-align-justify-expected.txt:
* platform/mac/fast/css/vertical-text-overflow-ellipsis-text-align-left-expected.txt:
* platform/mac/fast/css/vertical-text-overflow-ellipsis-text-align-right-expected.txt:
* platform/mac/fast/css/word-space-extra-expected.txt:
* platform/mac/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt:
* platform/mac/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.txt:
* platform/mac/fast/dom/HTMLMeterElement/meter-boundary-values-expected.txt:
* platform/mac/fast/dom/HTMLMeterElement/meter-element-expected.txt:
* platform/mac/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.txt:
* platform/mac/fast/dom/HTMLMeterElement/meter-optimums-expected.txt:
* platform/mac/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt:
* platform/mac/fast/dom/HTMLMeterElement/meter-styles-expected.txt:
* platform/mac/fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.txt:
* platform/mac/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.txt:
* platform/mac/fast/dom/HTMLTableElement/cellpadding-attribute-expected.txt: Removed.
* platform/mac/fast/dom/HTMLTableElement/early-acid3-65-excerpt-expected.txt: Removed.
* platform/mac/fast/dom/HTMLTableElement/early-acid3-66-excerpt-expected.txt: Removed.
* platform/mac/fast/dom/HTMLTableElement/insert-row-expected.txt: Removed.
* platform/mac/fast/dom/HTMLTableElement/rows-expected.txt: Removed.
* platform/mac/fast/dom/HTMLTableElement/tBodies-expected.txt: Removed.
* platform/mac/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt:
* platform/mac/fast/dom/Window/webkitConvertPoint-expected.txt: Added.
* platform/mac/fast/dom/clone-node-dynamic-style-expected.txt:
* platform/mac/fast/dynamic/012-expected.txt:
* platform/mac/fast/dynamic/anchor-lock-expected.txt:
* platform/mac/fast/dynamic/subtree-parent-static-y-expected.txt:
* platform/mac/fast/encoding/denormalised-voiced-japanese-chars-expected.txt:
* platform/mac/fast/encoding/utf-16-big-endian-expected.txt:
* platform/mac/fast/encoding/utf-16-little-endian-expected.txt:
* platform/mac/fast/events/clientXY-in-zoom-and-scroll-expected.txt: Added.
* platform/mac/fast/events/document-elementFromPoint-expected.txt: Added.
* platform/mac/fast/events/pointer-events-2-expected.txt:
* platform/mac/fast/flexbox/flex-hang-expected.txt: Added.
* platform/mac/fast/forms/001-expected.txt:
* platform/mac/fast/forms/006-expected.txt:
* platform/mac/fast/forms/007-expected.txt:
* platform/mac/fast/forms/basic-buttons-expected.txt:
* platform/mac/fast/forms/basic-inputs-expected.txt:
* platform/mac/fast/forms/basic-textareas-quirks-expected.txt:
* platform/mac/fast/forms/blankbuttons-expected.txt:
* platform/mac/fast/forms/box-shadow-override-expected.txt:
* platform/mac/fast/forms/button-cannot-be-nested-expected.txt:
* platform/mac/fast/forms/button-default-title-expected.txt:
* platform/mac/fast/forms/button-generated-content-expected.txt:
* platform/mac/fast/forms/button-positioned-expected.txt:
* platform/mac/fast/forms/button-sizes-expected.txt:
* platform/mac/fast/forms/button-style-color-expected.txt:
* platform/mac/fast/forms/button-table-styles-expected.txt:
* platform/mac/fast/forms/button-text-transform-expected.txt:
* platform/mac/fast/forms/button-white-space-expected.txt:
* platform/mac/fast/forms/control-restrict-line-height-expected.txt:
* platform/mac/fast/forms/fieldset-align-expected.txt:
* platform/mac/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.txt:
* platform/mac/fast/forms/fieldset-with-float-expected.txt:
* platform/mac/fast/forms/file/file-input-direction-expected.txt:
* platform/mac/fast/forms/file/file-input-disabled-expected.txt:
* platform/mac/fast/forms/file/input-file-re-render-expected.txt:
* platform/mac/fast/forms/float-before-fieldset-expected.txt:
* platform/mac/fast/forms/form-element-geometry-expected.txt:
* platform/mac/fast/forms/formmove-expected.txt:
* platform/mac/fast/forms/formmove2-expected.txt:
* platform/mac/fast/forms/formmove3-expected.txt:
* platform/mac/fast/forms/indeterminate-expected.txt:
* platform/mac/fast/forms/input-appearance-height-expected.txt:
* platform/mac/fast/forms/input-button-sizes-expected.txt:
* platform/mac/fast/forms/input-value-expected.txt:
* platform/mac/fast/forms/linebox-overflow-in-textarea-padding-expected.txt:
* platform/mac/fast/forms/listbox-hit-test-zoomed-expected.txt:
* platform/mac/fast/forms/menulist-clip-expected.txt:
* platform/mac/fast/forms/minWidthPercent-expected.txt:
* platform/mac/fast/forms/preserveFormDuringResidualStyle-expected.txt:
* platform/mac/fast/forms/range/input-appearance-range-expected.txt:
* platform/mac/fast/forms/range/slider-mouse-events-expected.txt: Added.
* platform/mac/fast/forms/search-vertical-alignment-expected.txt:
* platform/mac/fast/forms/searchfield-heights-expected.txt:
* platform/mac/fast/forms/select-baseline-expected.txt:
* platform/mac/fast/forms/targeted-frame-submission-expected.txt:
* platform/mac/fast/forms/textAreaLineHeight-expected.txt:
* platform/mac/fast/forms/validation-message-appearance-expected.txt:
* platform/mac/fast/frames/onlyCommentInIFrame-expected.txt:
* platform/mac/fast/gradients/crash-on-zero-radius-expected.txt:
* platform/mac/fast/gradients/generated-gradients-expected.txt:
* platform/mac/fast/gradients/radial-centered-expected.txt:
* platform/mac/fast/gradients/simple-gradients-expected.txt:
* platform/mac/fast/hidpi/video-controls-in-hidpi-expected.txt:
* platform/mac/fast/html/details-add-child-1-expected.txt:
* platform/mac/fast/html/details-add-child-2-expected.txt:
* platform/mac/fast/html/details-add-details-child-1-expected.txt:
* platform/mac/fast/html/details-add-details-child-2-expected.txt:
* platform/mac/fast/html/details-add-summary-1-and-click-expected.txt:
* platform/mac/fast/html/details-add-summary-1-expected.txt:
* platform/mac/fast/html/details-add-summary-10-and-click-expected.txt:
* platform/mac/fast/html/details-add-summary-10-expected.txt:
* platform/mac/fast/html/details-add-summary-2-and-click-expected.txt:
* platform/mac/fast/html/details-add-summary-2-expected.txt:
* platform/mac/fast/html/details-add-summary-3-and-click-expected.txt:
* platform/mac/fast/html/details-add-summary-3-expected.txt:
* platform/mac/fast/html/details-add-summary-4-and-click-expected.txt:
* platform/mac/fast/html/details-add-summary-4-expected.txt:
* platform/mac/fast/html/details-add-summary-5-and-click-expected.txt:
* platform/mac/fast/html/details-add-summary-5-expected.txt:
* platform/mac/fast/html/details-add-summary-6-and-click-expected.txt:
* platform/mac/fast/html/details-add-summary-6-expected.txt:
* platform/mac/fast/html/details-add-summary-7-and-click-expected.txt:
* platform/mac/fast/html/details-add-summary-7-expected.txt:
* platform/mac/fast/html/details-add-summary-8-and-click-expected.txt:
* platform/mac/fast/html/details-add-summary-8-expected.txt:
* platform/mac/fast/html/details-add-summary-9-and-click-expected.txt:
* platform/mac/fast/html/details-add-summary-9-expected.txt:
* platform/mac/fast/html/details-add-summary-child-1-expected.txt:
* platform/mac/fast/html/details-add-summary-child-2-expected.txt:
* platform/mac/fast/html/details-marker-style-expected.txt: Added.
* platform/mac/fast/html/details-nested-1-expected.txt:
* platform/mac/fast/html/details-nested-2-expected.txt:
* platform/mac/fast/html/details-no-summary1-expected.txt:
* platform/mac/fast/html/details-no-summary2-expected.txt:
* platform/mac/fast/html/details-no-summary3-expected.txt:
* platform/mac/fast/html/details-no-summary4-expected.txt:
* platform/mac/fast/html/details-open-javascript-expected.txt:
* platform/mac/fast/html/details-open1-expected.txt:
* platform/mac/fast/html/details-open2-expected.txt:
* platform/mac/fast/html/details-open3-expected.txt:
* platform/mac/fast/html/details-open4-expected.txt:
* platform/mac/fast/html/details-open5-expected.txt:
* platform/mac/fast/html/details-open6-expected.txt:
* platform/mac/fast/html/details-position-expected.txt:
* platform/mac/fast/html/details-remove-child-1-expected.txt:
* platform/mac/fast/html/details-remove-child-2-expected.txt:
* platform/mac/fast/html/details-remove-summary-1-and-click-expected.txt:
* platform/mac/fast/html/details-remove-summary-1-expected.txt:
* platform/mac/fast/html/details-remove-summary-2-and-click-expected.txt:
* platform/mac/fast/html/details-remove-summary-2-expected.txt:
* platform/mac/fast/html/details-remove-summary-3-and-click-expected.txt:
* platform/mac/fast/html/details-remove-summary-3-expected.txt:
* platform/mac/fast/html/details-remove-summary-4-and-click-expected.txt:
* platform/mac/fast/html/details-remove-summary-4-expected.txt:
* platform/mac/fast/html/details-remove-summary-5-and-click-expected.txt:
* platform/mac/fast/html/details-remove-summary-5-expected.txt:
* platform/mac/fast/html/details-remove-summary-6-and-click-expected.txt:
* platform/mac/fast/html/details-remove-summary-6-expected.txt:
* platform/mac/fast/html/details-remove-summary-child-1-expected.txt:
* platform/mac/fast/html/details-remove-summary-child-2-expected.txt:
* platform/mac/fast/html/details-replace-summary-child-expected.txt:
* platform/mac/fast/html/details-replace-text-expected.txt:
* platform/mac/fast/html/details-writing-mode-expected.txt:
* platform/mac/fast/images/imagemap-focus-ring-zoom-expected.txt:
* platform/mac/fast/images/zoomed-img-size-expected.txt: Added.
* platform/mac/fast/inline-block/inline-block-vertical-align-expected.txt:
* platform/mac/fast/inline/002-expected.txt:
* platform/mac/fast/inline/continuation-outlines-expected.txt:
* platform/mac/fast/inline/inline-borders-with-bidi-override-expected.txt:
* platform/mac/fast/inline/inline-box-background-expected.txt:
* platform/mac/fast/inline/inline-box-background-long-image-expected.txt:
* platform/mac/fast/inline/inline-box-background-repeat-x-expected.txt:
* platform/mac/fast/inline/inline-box-background-repeat-y-expected.txt:
* platform/mac/fast/inline/outline-continuations-expected.txt:
* platform/mac/fast/inline/positionedLifetime-expected.txt:
* platform/mac/fast/invalid/010-expected.txt:
* platform/mac/fast/invalid/014-expected.txt:
* platform/mac/fast/invalid/junk-data-expected.txt:
* platform/mac/fast/invalid/missing-end-tag-expected.txt:
* platform/mac/fast/invalid/nestedh3s-expected.txt:
* platform/mac/fast/invalid/residual-style-expected.txt:
* platform/mac/fast/layers/video-layer-expected.txt:
* platform/mac/fast/line-grid/line-align-left-edges-expected.txt:
* platform/mac/fast/line-grid/line-grid-contains-value-expected.txt:
* platform/mac/fast/lists/003-expected.txt:
* platform/mac/fast/lists/003-vertical-expected.txt:
* platform/mac/fast/lists/008-expected.txt:
* platform/mac/fast/lists/008-vertical-expected.txt:
* platform/mac/fast/lists/ordered-list-with-no-ol-tag-expected.txt:
* platform/mac/fast/loader/javascript-url-in-embed-expected.txt: Added.
* platform/mac/fast/media/mq-relative-constraints-08-expected.txt:
* platform/mac/fast/multicol/break-properties-expected.txt: Added.
* platform/mac/fast/multicol/client-rects-expected.txt:
* platform/mac/fast/multicol/column-break-with-balancing-expected.txt:
* platform/mac/fast/multicol/float-multicol-expected.txt:
* platform/mac/fast/multicol/float-paginate-complex-expected.txt:
* platform/mac/fast/multicol/layers-in-multicol-expected.txt:
* platform/mac/fast/multicol/nested-columns-expected.txt:
* platform/mac/fast/multicol/overflow-across-columns-expected.txt:
* platform/mac/fast/multicol/overflow-across-columns-percent-height-expected.txt: Copied from LayoutTests/platform/mac/fast/multicol/overflow-across-columns-expected.txt.
* platform/mac/fast/multicol/overflow-unsplittable-expected.txt:
* platform/mac/fast/multicol/scrolling-overflow-expected.txt:
* platform/mac/fast/multicol/span/anonymous-before-child-parent-crash-expected.txt:
* platform/mac/fast/multicol/span/anonymous-split-block-crash-expected.txt:
* platform/mac/fast/multicol/span/anonymous-style-inheritance-expected.txt:
* platform/mac/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
* platform/mac/fast/multicol/span/clone-flexbox-expected.txt: Added.
* platform/mac/fast/multicol/span/clone-summary-expected.txt: Added.
* platform/mac/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt:
* platform/mac/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt:
* platform/mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
* platform/mac/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt:
* platform/mac/fast/multicol/span/span-as-immediate-columns-child-expected.txt:
* platform/mac/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt:
* platform/mac/fast/multicol/span/span-as-nested-columns-child-expected.txt:
* platform/mac/fast/multicol/span/span-margin-collapsing-expected.txt:
* platform/mac/fast/multicol/table-vertical-align-expected.txt:
* platform/mac/fast/multicol/vertical-lr/break-properties-expected.txt: Added.
* platform/mac/fast/multicol/vertical-lr/column-break-with-balancing-expected.txt:
* platform/mac/fast/multicol/vertical-lr/float-multicol-expected.txt:
* platform/mac/fast/multicol/vertical-lr/nested-columns-expected.txt:
* platform/mac/fast/multicol/vertical-rl/break-properties-expected.txt: Added.
* platform/mac/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt:
* platform/mac/fast/multicol/vertical-rl/float-multicol-expected.txt:
* platform/mac/fast/multicol/vertical-rl/nested-columns-expected.txt:
* platform/mac/fast/overflow/007-expected.txt:
* platform/mac/fast/overflow/clip-rects-fixed-ancestor-expected.txt:
* platform/mac/fast/overflow/infiniteRecursionGuard-expected.txt:
* platform/mac/fast/overflow/overflow-rtl-expected.txt:
* platform/mac/fast/overflow/overflow-rtl-vertical-expected.txt:
* platform/mac/fast/overflow/overflow_hidden-expected.txt:
* platform/mac/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt:
* platform/mac/fast/overflow/scrollRevealButton-expected.txt:
* platform/mac/fast/parser/bad-xml-slash-expected.txt:
* platform/mac/fast/parser/entity-comment-in-style-expected.txt:
* platform/mac/fast/parser/style-script-head-test-expected.txt: Added.
* platform/mac/fast/parser/xhtml-alternate-entities-expected.txt:
* platform/mac/fast/reflections/reflection-with-zoom-expected.txt:
* platform/mac/fast/regions/bottom-overflow-out-of-first-region-expected.txt:
* platform/mac/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt:
* platform/mac/fast/regions/overflow-moving-below-floats-in-variable-width-regions-expected.txt:
* platform/mac/fast/regions/overflow-not-moving-below-floats-in-variable-width-regions-expected.txt:
* platform/mac/fast/regions/overflow-size-change-with-stacking-context-rtl-expected.txt:
* platform/mac/fast/regions/top-overflow-out-of-second-region-expected.txt:
* platform/mac/fast/repaint/control-clip-expected.txt:
* platform/mac/fast/repaint/delete-into-nested-block-expected.txt:
* platform/mac/fast/repaint/line-flow-with-floats-1-expected.txt:
* platform/mac/fast/repaint/line-flow-with-floats-10-expected.txt:
* platform/mac/fast/repaint/line-flow-with-floats-2-expected.txt:
* platform/mac/fast/repaint/line-flow-with-floats-3-expected.txt:
* platform/mac/fast/repaint/line-flow-with-floats-4-expected.txt:
* platform/mac/fast/repaint/line-flow-with-floats-5-expected.txt:
* platform/mac/fast/repaint/line-flow-with-floats-6-expected.txt:
* platform/mac/fast/repaint/line-flow-with-floats-7-expected.txt:
* platform/mac/fast/repaint/line-flow-with-floats-8-expected.txt:
* platform/mac/fast/repaint/line-flow-with-floats-9-expected.txt:
* platform/mac/fast/repaint/line-flow-with-floats-in-regions-expected.txt:
* platform/mac/fast/repaint/repaint-during-scroll-with-zoom-expected.txt:
* platform/mac/fast/repaint/table-section-repaint-expected.txt: Removed.
* platform/mac/fast/repaint/transform-absolute-in-positioned-container-expected.txt:
* platform/mac/fast/repaint/transform-translate-expected.txt:
* platform/mac/fast/replaced/replaced-breaking-expected.txt:
* platform/mac/fast/replaced/table-percent-height-expected.txt: Added.
* platform/mac/fast/replaced/table-percent-height-text-controls-expected.txt: Added.
* platform/mac/fast/replaced/width100percent-button-expected.txt:
* platform/mac/fast/replaced/width100percent-checkbox-expected.txt:
* platform/mac/fast/replaced/width100percent-radio-expected.txt:
* platform/mac/fast/ruby/ruby-inline-table-expected.txt:
* platform/mac/fast/selectors/032-expected.txt:
* platform/mac/fast/selectors/166-expected.txt:
* platform/mac/fast/selectors/unqualified-hover-quirks-expected.txt:
* platform/mac/fast/selectors/unqualified-hover-strict-expected.txt:
* platform/mac/fast/spatial-navigation/snav-unit-overflow-and-scroll-in-direction-expected.txt: Added.
* platform/mac/fast/table/009-expected.txt:
* platform/mac/fast/table/014-expected.txt:
* platform/mac/fast/table/040-expected.txt:
* platform/mac/fast/table/040-vertical-expected.txt:
* platform/mac/fast/table/041-expected.txt:
* platform/mac/fast/table/absolute-table-at-bottom-expected.txt:
* platform/mac/fast/table/append-cells2-expected.txt:
* platform/mac/fast/table/border-collapsing/004-expected.txt:
* platform/mac/fast/table/border-collapsing/004-vertical-expected.txt:
* platform/mac/fast/table/frame-and-rules-expected.txt:
* platform/mac/fast/table/mozilla-bug10296-vertical-align-1-expected.txt:
* platform/mac/fast/table/mozilla-bug10296-vertical-align-2-expected.txt:
* platform/mac/fast/table/nested-percent-height-table-expected.txt:
* platform/mac/fast/table/overflowHidden-expected.txt:
* platform/mac/fast/table/percent-heights-expected.txt:
* platform/mac/fast/table/remove-td-display-none-expected.txt:
* platform/mac/fast/table/table-display-types-strict-expected.txt:
* platform/mac/fast/table/table-hspace-align-center-expected.txt:
* platform/mac/fast/text/basic/012-expected.txt:
* platform/mac/fast/text/basic/013-expected.txt:
* platform/mac/fast/text/basic/generic-family-reset-expected.txt:
* platform/mac/fast/text/international/bidi-LDB-2-CSS-expected.txt:
* platform/mac/fast/text/international/bidi-LDB-2-HTML-expected.txt:
* platform/mac/fast/text/international/bidi-LDB-2-formatting-characters-expected.txt:
* platform/mac/fast/text/international/bidi-layout-across-linebreak-expected.txt:
* platform/mac/fast/text/international/hindi-spacing-expected.txt:
* platform/mac/fast/text/international/thai-line-breaks-expected.txt:
* platform/mac/fast/text/international/vertical-text-glyph-test-expected.txt:
* platform/mac/fast/text/line-breaks-expected.txt:
* platform/mac/fast/text/textIteratorNilRenderer-expected.txt:
* platform/mac/fast/text/vertical-rl-rtl-linebreak-expected.txt:
* platform/mac/fast/text/whitespace/024-expected.txt:
* platform/mac/fast/text/whitespace/normal-after-nowrap-breaking-expected.txt:
* platform/mac/fast/text/whitespace/pre-wrap-spaces-after-newline-expected.txt:
* platform/mac/fast/transforms/bounding-rect-zoom-expected.txt:
* platform/mac/fast/transforms/rotated-transform-affects-scrolling-1-expected.txt: Added.
* platform/mac/fast/transforms/rotated-transform-affects-scrolling-2-expected.txt: Added.
* platform/mac/fast/transforms/transforms-with-zoom-expected.txt: Added.
* platform/mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
* platform/mac/fast/writing-mode/broken-ideograph-small-caps-expected.txt:
* platform/mac/fast/writing-mode/broken-ideographic-font-expected.txt:
* platform/mac/fast/writing-mode/fieldsets-expected.txt:
* platform/mac/fast/writing-mode/japanese-ruby-vertical-lr-expected.txt:
* platform/mac/fast/writing-mode/japanese-ruby-vertical-rl-expected.txt:
* platform/mac/fast/writing-mode/vertical-font-fallback-expected.txt:
* platform/mac/fast/xsl/xslt-extra-content-at-end-expected.txt:
* platform/mac/http/tests/cookies/multiple-cookies-expected.txt: Added.
* platform/mac/http/tests/inspector/console-websocket-error-expected.txt:
* platform/mac/http/tests/misc/acid3-expected.txt: Added.
* platform/mac/http/tests/misc/iframe404-expected.txt:
* platform/mac/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt:
* platform/mac/http/tests/navigation/javascriptlink-frames-expected.txt:
* platform/mac/http/tests/security/sandboxed-iframe-origin-add-expected.txt: Added.
* platform/mac/http/tests/webarchive/cross-origin-stylesheet-crash-expected.txt: Added.
* platform/mac/http/tests/webarchive/test-preload-resources-expected.txt: Added.
* platform/mac/ietestcenter/css3/bordersbackgrounds/background-repeat-space-padding-box-expected.txt:
* platform/mac/ietestcenter/css3/bordersbackgrounds/background_repeat_space_border_box-expected.txt:
* platform/mac/ietestcenter/css3/bordersbackgrounds/background_repeat_space_content_box-expected.txt:
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-with-three-values-001-expected.txt:
* platform/mac/ietestcenter/css3/bordersbackgrounds/border-radius-with-two-values-001-expected.txt:
* platform/mac/mathml/presentation/attributes-expected.txt:
* platform/mac/mathml/presentation/fenced-expected.txt:
* platform/mac/mathml/presentation/fenced-mi-expected.txt:
* platform/mac/mathml/presentation/fractions-expected.txt:
* platform/mac/mathml/presentation/fractions-vertical-alignment-expected.txt:
* platform/mac/mathml/presentation/mo-expected.txt:
* platform/mac/mathml/presentation/mo-stretch-expected.txt:
* platform/mac/mathml/presentation/mroot-pref-width-expected.txt:
* platform/mac/mathml/presentation/over-expected.txt:
* platform/mac/mathml/presentation/roots-expected.txt:
* platform/mac/mathml/presentation/row-alignment-expected.txt:
* platform/mac/mathml/presentation/row-expected.txt:
* platform/mac/mathml/presentation/style-expected.txt:
* platform/mac/mathml/presentation/sub-expected.txt:
* platform/mac/mathml/presentation/subsup-expected.txt:
* platform/mac/mathml/presentation/sup-expected.txt:
* platform/mac/mathml/presentation/tables-expected.txt:
* platform/mac/mathml/presentation/tokenElements-expected.txt:
* platform/mac/mathml/presentation/under-expected.txt:
* platform/mac/mathml/presentation/underover-expected.txt:
* platform/mac/mathml/xHeight-expected.txt:
* platform/mac/media/audio-controls-rendering-expected.txt:
* platform/mac/media/controls-after-reload-expected.txt:
* platform/mac/media/controls-strict-expected.txt:
* platform/mac/media/controls-styling-strict-expected.txt:
* platform/mac/media/controls-without-preload-expected.txt:
* platform/mac/media/media-controls-clone-expected.txt:
* platform/mac/media/media-element-play-after-eos-expected.txt: Added.
* platform/mac/media/video-controls-rendering-expected.txt:
* platform/mac/media/video-display-toggle-expected.txt:
* platform/mac/media/video-empty-source-expected.txt:
* platform/mac/media/video-no-audio-expected.txt:
* platform/mac/media/video-playing-and-pause-expected.txt:
* platform/mac/platform/mac/fast/forms/focus-option-control-on-page-expected.txt: Added.
* platform/mac/platform/mac/fast/loader/file-url-mimetypes-2-expected.txt:
* platform/mac/platform/mac/fast/text/x-height-expected.txt: Added.
* platform/mac/plugins/netscape-dom-access-and-reload-expected.txt: Added.
* platform/mac/plugins/npp-set-window-called-during-destruction-expected.txt:
* platform/mac/svg/as-border-image/svg-as-border-image-2-expected.txt:
* platform/mac/svg/as-border-image/svg-as-border-image-expected.txt:
* platform/mac/svg/as-image/img-preserveAspectRatio-support-2-expected.txt:
* platform/mac/svg/as-image/svg-non-integer-scaled-image-expected.txt: Copied from LayoutTests/platform/mac/fast/dom/HTMLMeterElement/meter-element-expected.txt.
* platform/mac/svg/custom/bug45331-expected.txt:
* platform/mac/svg/custom/fractional-rects-expected.txt: Added.
* platform/mac/svg/custom/image-parent-translation-expected.txt:
* platform/mac/svg/custom/inline-svg-in-xhtml-expected.txt:
* platform/mac/svg/custom/js-update-container-expected.txt: Added.
* platform/mac/svg/custom/junk-data-expected.txt:
* platform/mac/svg/custom/missing-xlink-expected.txt:
* platform/mac/svg/custom/object-sizing-expected.txt:
* platform/mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt: Added.
* platform/mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt: Added.
* platform/mac/svg/custom/object-sizing-width-75p-height-50p-on-target-svg-expected.txt: Added.
* platform/mac/svg/custom/path-bad-data-expected.txt:
* platform/mac/svg/custom/rootmost-svg-xy-attrs-expected.txt:
* platform/mac/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
* platform/mac/svg/custom/svg-fonts-in-html-expected.txt:
* platform/mac/svg/custom/svg-fonts-with-no-element-reference-expected.txt: Added.
* platform/mac/svg/custom/svg-fonts-without-missing-glyph-expected.txt:
* platform/mac/svg/custom/use-css-no-effect-on-shadow-tree-expected.txt: Added.
* platform/mac/svg/custom/use-font-face-crash-expected.txt:
* platform/mac/svg/custom/viewBox-hit-expected.txt: Added.
* platform/mac/svg/hixie/error/012-expected.txt:
* platform/mac/svg/text/small-fonts-in-html5-expected.txt:
* platform/mac/svg/transforms/svg-css-transforms-clip-path-expected.txt:
* platform/mac/svg/transforms/svg-css-transforms-expected.txt:
* platform/mac/svg/webarchive/svg-cursor-subresources-expected.txt: Added.
* platform/mac/svg/webarchive/svg-feimage-subresources-expected.txt: Added.
* platform/mac/svg/webarchive/svg-script-subresouces-expected.txt: Added.
* platform/mac/svg/wicd/rightsizing-grid-expected.txt:
* platform/mac/svg/wicd/test-rightsizing-a-expected.txt:
* platform/mac/svg/wicd/test-rightsizing-b-expected.txt:
* platform/mac/svg/wicd/test-scalable-background-image1-expected.txt:
* platform/mac/svg/wicd/test-scalable-background-image2-expected.txt:
* platform/mac/svg/zoom/page/zoom-background-image-tiled-expected.txt:
* platform/mac/svg/zoom/page/zoom-background-images-expected.txt:
* platform/mac/svg/zoom/page/zoom-hixie-mixed-008-expected.txt:
* platform/mac/svg/zoom/page/zoom-hixie-mixed-009-expected.txt:
* platform/mac/svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt:
* platform/mac/svg/zoom/page/zoom-img-preserveAspectRatio-support-1-expected.txt:
* platform/mac/svg/zoom/page/zoom-mask-with-percentages-expected.txt: Added.
* platform/mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
* platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt:
* platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.txt:
* platform/mac/svg/zoom/page/zoom-svg-as-image-expected.txt: Copied from LayoutTests/platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt.
* platform/mac/svg/zoom/page/zoom-svg-as-object-expected.txt: Added.
* platform/mac/svg/zoom/page/zoom-svg-as-relative-image-expected.txt: Copied from LayoutTests/platform/mac/svg/zoom/page/zoom-svg-as-background-with-relative-size-expected.txt.
* platform/mac/svg/zoom/page/zoom-svg-float-border-padding-expected.txt: Added.
* platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-2-expected.txt:
* platform/mac/svg/zoom/page/zoom-svg-through-object-with-absolute-size-expected.txt:
* platform/mac/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Added.
* platform/mac/svg/zoom/page/zoom-svg-through-object-with-huge-size-expected.txt: Added.
* platform/mac/svg/zoom/page/zoom-svg-through-object-with-override-size-expected.txt:
* platform/mac/svg/zoom/page/zoom-svg-through-object-with-percentage-size-expected.txt:
* platform/mac/svg/zoom/text/zoom-hixie-mixed-008-expected.txt:
* platform/mac/svg/zoom/text/zoom-hixie-rendering-model-004-expected.txt:
* platform/mac/svg/zoom/text/zoom-svg-float-border-padding-expected.txt: Added.
* platform/mac/tables/mozilla/bugs/bug10269-2-expected.txt:
* platform/mac/tables/mozilla/bugs/bug10296-1-expected.txt:
* platform/mac/tables/mozilla/bugs/bug1055-1-expected.txt:
* platform/mac/tables/mozilla/bugs/bug106816-expected.txt:
* platform/mac/tables/mozilla/bugs/bug113235-1-expected.txt:
* platform/mac/tables/mozilla/bugs/bug113235-2-expected.txt:
* platform/mac/tables/mozilla/bugs/bug113424-expected.txt:
* platform/mac/tables/mozilla/bugs/bug11384q-expected.txt:
* platform/mac/tables/mozilla/bugs/bug11384s-expected.txt:
* platform/mac/tables/mozilla/bugs/bug1188-expected.txt:
* platform/mac/tables/mozilla/bugs/bug126742-expected.txt:
* platform/mac/tables/mozilla/bugs/bug131020-expected.txt:
* platform/mac/tables/mozilla/bugs/bug13118-expected.txt:
* platform/mac/tables/mozilla/bugs/bug1318-expected.txt:
* platform/mac/tables/mozilla/bugs/bug138725-expected.txt:
* platform/mac/tables/mozilla/bugs/bug139524-2-expected.txt:
* platform/mac/tables/mozilla/bugs/bug159108-expected.txt:
* platform/mac/tables/mozilla/bugs/bug17130-1-expected.txt:
* platform/mac/tables/mozilla/bugs/bug17130-2-expected.txt:
* platform/mac/tables/mozilla/bugs/bug17138-expected.txt:
* platform/mac/tables/mozilla/bugs/bug18359-expected.txt:
* platform/mac/tables/mozilla/bugs/bug19061-1-expected.txt:
* platform/mac/tables/mozilla/bugs/bug19061-2-expected.txt:
* platform/mac/tables/mozilla/bugs/bug24200-expected.txt:
* platform/mac/tables/mozilla/bugs/bug2479-1-expected.txt:
* platform/mac/tables/mozilla/bugs/bug2479-2-expected.txt:
* platform/mac/tables/mozilla/bugs/bug2479-3-expected.txt:
* platform/mac/tables/mozilla/bugs/bug2479-4-expected.txt:
* platform/mac/tables/mozilla/bugs/bug26178-expected.txt:
* platform/mac/tables/mozilla/bugs/bug26553-expected.txt:
* platform/mac/tables/mozilla/bugs/bug2886-2-expected.txt:
* platform/mac/tables/mozilla/bugs/bug28928-expected.txt:
* platform/mac/tables/mozilla/bugs/bug30692-expected.txt:
* platform/mac/tables/mozilla/bugs/bug3309-1-expected.txt:
* platform/mac/tables/mozilla/bugs/bug3309-2-expected.txt:
* platform/mac/tables/mozilla/bugs/bug33137-expected.txt:
* platform/mac/tables/mozilla/bugs/bug33855-expected.txt:
* platform/mac/tables/mozilla/bugs/bug39209-expected.txt:
* platform/mac/tables/mozilla/bugs/bug42187-expected.txt:
* platform/mac/tables/mozilla/bugs/bug4284-expected.txt:
* platform/mac/tables/mozilla/bugs/bug4429-expected.txt:
* platform/mac/tables/mozilla/bugs/bug4527-expected.txt:
* platform/mac/tables/mozilla/bugs/bug46368-1-expected.txt:
* platform/mac/tables/mozilla/bugs/bug46368-2-expected.txt:
* platform/mac/tables/mozilla/bugs/bug46480-1-expected.txt:
* platform/mac/tables/mozilla/bugs/bug46480-2-expected.txt:
* platform/mac/tables/mozilla/bugs/bug51037-expected.txt:
* platform/mac/tables/mozilla/bugs/bug51727-expected.txt:
* platform/mac/tables/mozilla/bugs/bug52505-expected.txt:
* platform/mac/tables/mozilla/bugs/bug52506-expected.txt:
* platform/mac/tables/mozilla/bugs/bug5538-expected.txt:
* platform/mac/tables/mozilla/bugs/bug59354-expected.txt:
* platform/mac/tables/mozilla/bugs/bug60749-expected.txt:
* platform/mac/tables/mozilla/bugs/bug6304-expected.txt:
* platform/mac/tables/mozilla/bugs/bug67915-1-expected.txt:
* platform/mac/tables/mozilla/bugs/bug69187-expected.txt:
* platform/mac/tables/mozilla/bugs/bug7112-1-expected.txt:
* platform/mac/tables/mozilla/bugs/bug7112-2-expected.txt:
* platform/mac/tables/mozilla/bugs/bug73321-expected.txt:
* platform/mac/tables/mozilla/bugs/bug7342-expected.txt:
* platform/mac/tables/mozilla/bugs/bug8032-1-expected.txt:
* platform/mac/tables/mozilla/bugs/bug83786-expected.txt: Added.
* platform/mac/tables/mozilla/bugs/bug8381-expected.txt:
* platform/mac/tables/mozilla/bugs/bug9271-1-expected.txt:
* platform/mac/tables/mozilla/bugs/bug9271-2-expected.txt:
* platform/mac/tables/mozilla/collapsing_borders/bug41262-4-expected.txt:
* platform/mac/tables/mozilla/core/bloomberg-expected.txt:
* platform/mac/tables/mozilla/core/margins-expected.txt:
* platform/mac/tables/mozilla/core/misc-expected.txt:
* platform/mac/tables/mozilla/dom/tableDom-expected.txt:
* platform/mac/tables/mozilla/marvin/backgr_index-expected.txt:
* platform/mac/tables/mozilla/marvin/backgr_layers-opacity-expected.txt:
* platform/mac/tables/mozilla/marvin/backgr_position-table-expected.txt:
* platform/mac/tables/mozilla/marvin/backgr_simple-table-cell-expected.txt:
* platform/mac/tables/mozilla/marvin/backgr_simple-table-column-expected.txt:
* platform/mac/tables/mozilla/marvin/backgr_simple-table-column-group-expected.txt:
* platform/mac/tables/mozilla/marvin/backgr_simple-table-expected.txt:
* platform/mac/tables/mozilla/marvin/backgr_simple-table-row-expected.txt:
* platform/mac/tables/mozilla/marvin/backgr_simple-table-row-group-expected.txt:
* platform/mac/tables/mozilla/other/move_row-expected.txt:
* platform/mac/tables/mozilla/other/test3-expected.txt:
* platform/mac/tables/mozilla/other/test6-expected.txt:
* platform/mac/tables/mozilla/other/wa_table_thtd_rowspan-expected.txt:
* platform/mac/tables/mozilla/other/wa_table_tr_align-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug10140-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug10216-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug104898-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug1055-2-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug1128-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug131020-3-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug1725-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug21518-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug22122-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug3166-13-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug3166-14-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug3166-16-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug3166-17-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug3166-18-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug46268-4-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug61042-1-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug61042-2-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug72393-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug89315-expected.txt:
* platform/mac/tables/mozilla_expected_failures/bugs/bug91057-expected.txt:
* platform/mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt:
* platform/mac/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.txt:
* platform/mac/tables/mozilla_expected_failures/core/captions1-expected.txt:
* platform/mac/tables/mozilla_expected_failures/core/captions2-expected.txt:
* platform/mac/tables/mozilla_expected_failures/core/captions3-expected.txt:
* platform/mac/tables/mozilla_expected_failures/core/standards1-expected.txt:
* platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-cell-expected.txt:
* platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-column-expected.txt:
* platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-column-group-expected.txt:
* platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-expected.txt:
* platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-quirks-expected.txt:
* platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-row-expected.txt:
* platform/mac/tables/mozilla_expected_failures/marvin/backgr_border-table-row-group-expected.txt:
* platform/mac/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.txt:
* platform/mac/tables/mozilla_expected_failures/marvin/backgr_layers-hide-expected.txt:
* platform/mac/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.txt:
* platform/mac/tables/mozilla_expected_failures/marvin/backgr_position-table-cell-expected.txt:
* platform/mac/tables/mozilla_expected_failures/marvin/backgr_position-table-column-expected.txt:
* platform/mac/tables/mozilla_expected_failures/marvin/backgr_position-table-column-group-expected.txt:
* platform/mac/tables/mozilla_expected_failures/marvin/backgr_position-table-row-expected.txt:
* platform/mac/tables/mozilla_expected_failures/marvin/backgr_position-table-row-group-expected.txt:
* platform/mac/tables/mozilla_expected_failures/other/test4-expected.txt:
* platform/mac/transforms/2d/hindi-rotated-expected.txt:
* platform/mac/transforms/2d/zoom-menulist-expected.txt:
* platform/mac/transforms/3d/point-mapping/3d-point-mapping-opacity-expected.txt: Added.
* platform/mac/transforms/svg-vs-css-expected.txt:
* platform/mac/webarchive/adopt-attribute-styled-body-webarchive-expected.txt: Added.
* platform/mac/webarchive/adopt-attribute-styled-node-webarchive-expected.txt: Added.
* platform/mac/webarchive/adopt-inline-styled-node-webarchive-expected.txt: Added.
* platform/mac/webarchive/archive-empty-frame-dom-expected.txt: Added.
* platform/mac/webarchive/archive-empty-frame-source-expected.txt: Added.
* platform/mac/webarchive/archive-with-unencoded-url-expected.txt: Added.
* platform/mac/webarchive/css-page-rule-crash-expected.txt: Added.
* platform/mac/webarchive/doctype-expected.txt: Added.
* platform/mac/webarchive/ignore-noscript-if-scripting-enabled-expected.txt: Added.
* platform/mac/webarchive/test-body-background-expected.txt: Added.
* platform/mac/webarchive/test-css-import-expected.txt: Added.
* platform/mac/webarchive/test-duplicate-resources-expected.txt: Added.
* platform/mac/webarchive/test-frameset-expected.txt: Added.
* platform/mac/webarchive/test-img-src-expected.txt: Added.
* platform/mac/webarchive/test-input-src-expected.txt: Added.
* platform/mac/webarchive/test-link-href-expected.txt: Added.
* platform/mac/webarchive/test-link-rel-icon-beforeload-expected.txt: Added.
* platform/mac/webarchive/test-object-data-expected.txt: Added.
* platform/mac/webarchive/test-script-src-expected.txt: Added.
* platform/mac/webarchive/test-table-background-expected.txt: Added.
* platform/mac/webarchive/test-td-background-expected.txt: Added.
* platform/mac/webarchive/test-xml-stylesheet-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Unreviewed gardening. Some new Mac baselines, and
senorblanco@chromium.org [Fri, 2 Nov 2012 21:32:43 +0000 (21:32 +0000)]
[Chromium] Unreviewed gardening.  Some new Mac baselines, and
add real bugs in place of Bug(senorblanco).

* platform/chromium-mac-lion/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png:
* platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png: Added.
* platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png: Added.
* platform/chromium-mac/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png:
* platform/chromium-mac/platform/chromium/virtual/softwarecompositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png: Added.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Fix compile-time warning of a possible empty-body if statement
commit-queue@webkit.org [Fri, 2 Nov 2012 21:32:01 +0000 (21:32 +0000)]
[BlackBerry] Fix compile-time warning of a possible empty-body if statement
https://bugs.webkit.org/show_bug.cgi?id=101095

Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-11-02
Reviewed by Yong Li.
Internally reviewed by Jeff Rogers.

BBLOG might be compiled out leaving an if statement with an empty
body. This is giving us a warning at the moment. Simply putting braces
around it will fail as well because then we'd have braces around a
single-line if. So, in following with the style observed in other parts
of BackingStore.cpp, break up the log message and add braces.

* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::blitToWindow):
(BlackBerry::WebKit::BackingStorePrivate::fillWindow):
(BlackBerry::WebKit::BackingStorePrivate::clearWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] platform/chromium/accessibility/other-aria-attribute-change-sends-notifica...
tony@chromium.org [Fri, 2 Nov 2012 21:28:37 +0000 (21:28 +0000)]
[chromium] platform/chromium/accessibility/other-aria-attribute-change-sends-notification.html failing
https://bugs.webkit.org/show_bug.cgi?id=100887

Reviewed by Ojan Vafai.

The tests were racing the load time of js-test-post.js and the test completion.
Previously, js-test-post.js would already be in the cache, so it would always load first.
Now that we clear the cache, sometimes js-test-post.js would run after the other test output.
Fix this by setting window.jsTestIsAsync = true and calling finishJSTest() when the test
ends (this delays the js-test-post.js output until finishJSTest() is called).

* platform/chromium/TestExpectations:
* platform/chromium/accessibility/is-ignored-change-sends-notification-expected.txt:
* platform/chromium/accessibility/is-ignored-change-sends-notification.html:
* platform/chromium/accessibility/other-aria-attribute-change-sends-notification-expected.txt:
* platform/chromium/accessibility/other-aria-attribute-change-sends-notification.html:
* platform/chromium/accessibility/text-change-notification-expected.txt:
* platform/chromium/accessibility/text-change-notification.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed baselines for chromium-mac.
vollick@chromium.org [Fri, 2 Nov 2012 21:14:26 +0000 (21:14 +0000)]
Unreviewed baselines for chromium-mac.

* platform/chromium-mac-lion/compositing/repaint/invalidations-on-composited-layers-expected.txt: Added.
* platform/chromium-mac-snowleopard/compositing/repaint/invalidations-on-composited-layers-expected.txt: Added.
* platform/chromium-mac/compositing/repaint/invalidations-on-composited-layers-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed baselines for chromium-mac.
vollick@chromium.org [Fri, 2 Nov 2012 21:12:06 +0000 (21:12 +0000)]
Unreviewed baselines for chromium-mac.

* platform/chromium-mac/platform/chromium/virtual/softwarecompositing/repaint/invalidations-on-composited-layers-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Optimize backspace key handling
commit-queue@webkit.org [Fri, 2 Nov 2012 21:11:44 +0000 (21:11 +0000)]
[BlackBerry] Optimize backspace key handling
https://bugs.webkit.org/show_bug.cgi?id=101083

PR233591
Optimize backspace key handling. Some of these calls are not
required by IMF since the input_service already processes the backspace key
and updates the state before passing us the key.

Internally reviewed by Mike Fenton.

Patch by Nima Ghanavatian <nghanavatian@rim.com> on 2012-11-02
Reviewed by Yong Li.

Blocking calls with a flag that we clear immediately after
processing a backspace keydown.

* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::nodeTextChanged):
(BlackBerry::WebKit::InputHandler::selectionChanged):
(BlackBerry::WebKit::InputHandler::handleKeyboardInput):
* WebKitSupport/InputHandler.h:
(InputHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] ResourceHandle::cancel() in ResourceHandleBlackBerry should setClient...
commit-queue@webkit.org [Fri, 2 Nov 2012 21:07:51 +0000 (21:07 +0000)]
[BlackBerry] ResourceHandle::cancel() in ResourceHandleBlackBerry should setClient to null.
https://bugs.webkit.org/show_bug.cgi?id=101082

Internal PR: 235410.
Patch suggested by George Staikos, prepared by Lyon Chen.
Patch by Lianghui Chen <liachen@rim.com> on 2012-11-02
Reviewed by Yong Li.

ResourceHandle::cancel() should call setClient(0) to close the window
during which it has been cancelled but its client is still there and can
be called.

No new tests as it's a code improvement without obvious bug.

* platform/network/blackberry/ResourceHandleBlackBerry.cpp:
(WebCore::ResourceHandle::cancel):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agowebkitpy: clean up logging in common.system.autoinstall
dpranke@chromium.org [Fri, 2 Nov 2012 20:55:01 +0000 (20:55 +0000)]
webkitpy: clean up logging in common.system.autoinstall
https://bugs.webkit.org/show_bug.cgi?id=101090

Reviewed by Ojan Vafai.

This module logged way too much, much of which was logging that
was either really redundant or useful only during initial development.
This patch deletes a lot of code and tweaks the remaining log messages
to be more useful now.

Also, clean up a bunch of lint errors and warnings.

* Scripts/webkitpy/common/system/autoinstall.py:
(AutoInstaller.__init__):
(AutoInstaller._write_file):
(AutoInstaller._set_up_target_dir):
(AutoInstaller._create_scratch_directory):
(AutoInstaller._url_downloaded_path):
(AutoInstaller._is_downloaded):
(AutoInstaller._record_url_downloaded):
(AutoInstaller._extract_targz):
(AutoInstaller._extract_all):
(AutoInstaller._unzip):
(AutoInstaller._download_to_stream):
(AutoInstaller._download):
(AutoInstaller._install):
(AutoInstaller.install):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed gardening. Mark report-blocked-uri-cross-origin.html as failing.
aboxhall@chromium.org [Fri, 2 Nov 2012 20:53:13 +0000 (20:53 +0000)]
Unreviewed gardening. Mark report-blocked-uri-cross-origin.html as failing.
https://bugs.webkit.org/show_bug.cgi?id=101096

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd a PluginInactive plug-in unavailability reason
andersca@apple.com [Fri, 2 Nov 2012 20:43:27 +0000 (20:43 +0000)]
Add a PluginInactive plug-in unavailability reason
https://bugs.webkit.org/show_bug.cgi?id=101089

Reviewed by Sam Weinig.

Source/WebCore:

This is to be used by Mac WebKit and WebKit2 shortly.

* English.lproj/Localizable.strings:
* platform/LocalizedStrings.cpp:
(WebCore::inactivePluginText):
(WebCore):
* platform/LocalizedStrings.h:
(WebCore):
* platform/blackberry/LocalizedStringsBlackBerry.cpp:
(WebCore::inactivePluginText):
(WebCore):
* platform/efl/LocalizedStringsEfl.cpp:
(WebCore::inactivePluginText):
(WebCore):
* platform/gtk/LocalizedStringsGtk.cpp:
(WebCore::inactivePluginText):
(WebCore):
* platform/qt/LocalizedStringsQt.cpp:
(WebCore::inactivePluginText):
(WebCore):
* rendering/RenderEmbeddedObject.cpp:
(WebCore::unavailablePluginReplacementText):
* rendering/RenderEmbeddedObject.h:

Source/WebKit/chromium:

* src/LocalizedStrings.cpp:
(WebCore::inactivePluginText):
(WebCore):

Source/WebKit2:

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::unavailablePluginButtonClicked):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[CMAKE] Remove QNX specific section
rwlbuis@webkit.org [Fri, 2 Nov 2012 20:27:02 +0000 (20:27 +0000)]
[CMAKE] Remove QNX specific section
https://bugs.webkit.org/show_bug.cgi?id=101063

Reviewed by Daniel Bates.

We do not need the QNX section anymore, so also remove the FEATURE_DEFINES_CSS variable as it
equals FEATURE_DEFINES_WITH_SPACE_SEPARATOR.

* CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agovisitedHashLink() converts 8 bit URLs and attributes to 16 bits.
msaboff@apple.com [Fri, 2 Nov 2012 20:21:56 +0000 (20:21 +0000)]
visitedHashLink() converts 8 bit URLs and attributes to 16 bits.
https://bugs.webkit.org/show_bug.cgi?id=101014

Reviewed by Geoffrey Garen.

Converted most of the static methods to templated based on character type.  Changed visitedHashLink to
check bitness of both the base URL and attribute.  If both are 8 bit, then we process using the LChar
version of the templated methods.  Otherwise we use the 16 bit flavor.

Changes covered by existing tests.

* platform/LinkHash.cpp:
(WebCore::findSlashDotDotSlash):
(WebCore::findSlashSlash):
(WebCore::findSlashDotSlash):
(WebCore::containsColonSlashSlash):
(WebCore::squeezeOutNullCharacters):
(WebCore::cleanSlashDotDotSlashes):
(WebCore::mergeDoubleSlashes):
(WebCore::cleanSlashDotSlashes):
(WebCore::cleanPath):
(WebCore::matchLetter):
(WebCore::needsTrailingSlash):
(WebCore::visitedURLInline):
(WebCore::visitedURL):
(WebCore::visitedLinkHash):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRegExp.prototype.toString Should Produce an 8 bit JSString if possible.
msaboff@apple.com [Fri, 2 Nov 2012 20:20:50 +0000 (20:20 +0000)]
RegExp.prototype.toString Should Produce an 8 bit JSString if possible.
https://bugs.webkit.org/show_bug.cgi?id=101003

Reviewed by Geoffrey Garen.

Took the logic of regExpObjectSource() and created two templated helpers that uses the
source character type when appending to the StringBuilder.

* runtime/RegExpObject.cpp:
(JSC::appendLineTerminatorEscape): Checks line terminate type to come up with escaped version.
(JSC::regExpObjectSourceInternal): Templated version of original.
(JSC::regExpObjectSource): Wrapper function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSupport invalidation tracking for composited layers
vollick@chromium.org [Fri, 2 Nov 2012 19:58:52 +0000 (19:58 +0000)]
Support invalidation tracking for composited layers
https://bugs.webkit.org/show_bug.cgi?id=97801

Reviewed by Simon Fraser.

GraphicsLayers now store invalidated rects and can include them in
the layer tree dump.

Source/WebCore:

Test: compositing/repaint/invalidations-on-composited-layers.html

* WebCore.exp.in:
  Exports FrameView::resetTrackedRepaints()
* page/FrameView.cpp:
(WebCore::FrameView::setTracksRepaints):
  Notifies each compositor that we are starting/stopping repaints.
(WebCore::FrameView::resetTrackedRepaints):
  Moved implementation to the cpp file.
* platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::~GraphicsLayer):
  Clears the repaint rects associated with this layer.
(WebCore::GraphicsLayer::resetTrackedRepaints):
  Clears the repaint rects associated with this layer.
  Note that the repaint rects are stored in a statically allocated
  HashMap to avoid using space on the graphics layers.
(WebCore::GraphicsLayer::addRepaintRect):
  Adds a repaint rect to list associated with this layer in the
  hash map mentioned above.
(WebCore::GraphicsLayer::dumpProperties):
  This has been modified to include the repaint rects in the dump
  if they've been requested.
* platform/graphics/GraphicsLayerClient.h:
(WebCore::GraphicsLayerClient::isTrackingRepaints):
  This is how graphics layers check if repaint tracking is happening.
  Returns false by default.
* platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp:
(WebCore::GraphicsLayerBlackBerry::setContentsNeedsDisplay):
(WebCore::GraphicsLayerBlackBerry::setNeedsDisplay):
(WebCore::GraphicsLayerBlackBerry::setNeedsDisplayInRect):
  These now call GraphicsLayer::addRepaintRect as necessary.
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::setNeedsDisplayInRect):
  Now calls GraphicsLayer::addRepaintRect as necessary.
* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::setContentsNeedsDisplay):
(WebCore::GraphicsLayerChromium::setNeedsDisplay):
(WebCore::GraphicsLayerChromium::setNeedsDisplayInRect):
  These now call GraphicsLayer::addRepaintRect as necessary.
* platform/graphics/clutter/GraphicsLayerClutter.cpp:
(WebCore::GraphicsLayerClutter::setNeedsDisplay):
(WebCore::GraphicsLayerClutter::setNeedsDisplayInRect):
  These now call GraphicsLayer::addRepaintRect as necessary.
* platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::setNeedsDisplay):
(WebCore::GraphicsLayerTextureMapper::setContentsNeedsDisplay):
(WebCore::GraphicsLayerTextureMapper::setNeedsDisplayInRect):
  These now call GraphicsLayer::addRepaintRect as necessary.
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::isTrackingRepaints):
  Required since this is a GraphicsLayerClient.
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::layerTreeAsText):
  Now accepts a flag to include the repaint rects in the layer tree
  dump.
(WebCore::resetTrackedRepaintRectsRecursive):
  Clears the repaint rects on all graphics layers.
(WebCore::RenderLayerCompositor::resetTrackedRepaintRects):
  Clears the repaint rects on all graphics layers.
(WebCore::RenderLayerCompositor::isTrackingRepaints):
  Required since this is a GraphicsLayerClient.
* testing/Internals.cpp:
(WebCore::Internals::layerTreeAsText):
* testing/Internals.h:
* testing/Internals.idl:
  The internals changes plumb the new flag for including the repaint
  rects in the layer tree dump.

Source/WebKit/chromium:

(WebKit::WebWidget::isTrackingRepaints):
  Used by the NonCompositedContentHost to determine if we are tracking
  repaint rects.
(WebKit::WebWidget::isTrackingRepaints):
* src/LinkHighlight.cpp:
(WebKit::LinkHighlight::updateGeometry):
  Now calls GraphicsLayer::addRepaintRect when invalidated.
* src/NonCompositedContentHost.cpp:
(WebKit::NonCompositedContentHost::isTrackingRepaints):
  Required as this is a GraphicsLayerClient.
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::isTrackingRepaints):
  Implementation of WebWidget::isTrackingRepaints.

LayoutTests:

* compositing/repaint/invalidations-on-composited-layers-expected.txt: Added.
* compositing/repaint/invalidations-on-composited-layers.html: Added.
* platform/mac/compositing/repaint/invalidations-on-composited-layers-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[V8] Generalize NodeWrapperMap to be able to handle other sorts of keys
abarth@webkit.org [Fri, 2 Nov 2012 19:22:24 +0000 (19:22 +0000)]
[V8] Generalize NodeWrapperMap to be able to handle other sorts of keys
https://bugs.webkit.org/show_bug.cgi?id=100973

Reviewed by Stephen White.

This is the first step towards using intrusive DOM wrapper maps more
widely in WebCore (see
http://lists.webkit.org/pipermail/webkit-dev/2012-November/022686.html
for more context).

* bindings/v8/DOMDataStore.cpp:
(WebCore::DOMDataStore::DOMDataStore):
* bindings/v8/IntrusiveDOMWrapperMap.h:
(WebCore):
(WebCore::IntrusiveDOMWrapperMap::weakCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoASSERT in RenderLayer::hitTestContents can fire
abarth@webkit.org [Fri, 2 Nov 2012 19:15:30 +0000 (19:15 +0000)]
ASSERT in RenderLayer::hitTestContents can fire
https://bugs.webkit.org/show_bug.cgi?id=99656

Reviewed by Eric Seidel.

Source/WebCore:

The issue is that updateHitTestResult and addNodeToRectBasedTestResult
are using two different nodes. Since they aren't consistent, we violate
assertions about only setting the inner node if we're doing a
rect-based hit test. This patch makes the two consistent.

Test: fast/dom/nodesFromRect/nodesFromRect-continuation-crash.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::nodeForHitTest):
(WebCore):
(WebCore::RenderBlock::nodeAtPoint):
(WebCore::RenderBlock::updateHitTestResult):
* rendering/RenderBlock.h:
(RenderBlock):

LayoutTests:

This test ensures that we don't trigger the assert.

* fast/dom/nodesFromRect/nodesFromRect-continuation-crash-expected.txt: Added.
* fast/dom/nodesFromRect/nodesFromRect-continuation-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPrefer 'Content-Security-Policy' to 'X-WebKit-CSP'.
mkwst@chromium.org [Fri, 2 Nov 2012 19:05:34 +0000 (19:05 +0000)]
Prefer 'Content-Security-Policy' to 'X-WebKit-CSP'.
https://bugs.webkit.org/show_bug.cgi?id=101043

Reviewed by Adam Barth.

The canonical 'Content-Security-Policy' header landed in 133095, but we
missed a few tests while updating to the new hotness. We also should
start using the canonical header for the inspector.

This patch should have no visible change; tests should continue to pass
with the new header, just as they did with the old header.

Source/WebCore:

* inspector/front-end/inspector.html:

LayoutTests:

* http/tests/inspector/stacktraces/csp-injected-content-warning-contains-stacktrace.html:
* http/tests/inspector/stacktraces/csp-inline-warning-contains-stacktrace.html:
* http/tests/inspector/stacktraces/csp-setInterval-warning-contains-stacktrace.html:
* http/tests/inspector/stacktraces/csp-setTimeout-warning-contains-stacktrace.html:
* http/tests/security/contentSecurityPolicy/img-blocked-no-gc-crash.html:
* http/tests/security/isolatedWorld/bypass-main-world-csp.html:
* inspector/console/console-eval-blocked.html:
* inspector/debugger/debugger-pause-on-blocked-event-handler.html:
* inspector/debugger/debugger-pause-on-blocked-script-injection.html:
* inspector/debugger/debugger-pause-on-blocked-script-url.html:
* inspector/debugger/eval-on-pause-blocked.html:
* inspector/elements/resolve-node-blocked.html:
* media/csp-blocks-video.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agowebkit-patch analyze-baselines output is weak
dpranke@chromium.org [Fri, 2 Nov 2012 19:02:30 +0000 (19:02 +0000)]
webkit-patch analyze-baselines output is weak
https://bugs.webkit.org/show_bug.cgi?id=100998

Reviewed by Ojan Vafai.

Currently analyze-baselines prints a list of baselines that have
the same checksum per line, but the format is hard to read;
this patch cleans up the output to print by directory instead
and use the same format I recently added for debugging optimize-baselines,
then refactors the code so that we share and adds tests for
analyze-baselines (which was untested).

Also, I got rid of a couple of unnecessarily-hardcoded port names,
and modified the baseline optimizer to log the current world when
optimize fails.

* Scripts/webkitpy/common/checkout/baselineoptimizer.py:
(BaselineOptimizer.read_results_by_directory):
(BaselineOptimizer.write_by_directory):
(BaselineOptimizer.optimize):
* Scripts/webkitpy/tool/commands/rebaseline.py:
(OptimizeBaselines.execute):
(AnalyzeBaselines.__init__):
(AnalyzeBaselines._write):
(AnalyzeBaselines._analyze_baseline):
(AnalyzeBaselines.execute):
* Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(_FakeOptimizer):
(_FakeOptimizer.read_results_by_directory):
(TestAnalyzeBaselines):
(TestAnalyzeBaselines.setUp):
(TestAnalyzeBaselines.test_default):
(TestAnalyzeBaselines.test_missing_baselines):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed gardening. Marking object-clip-rects-assertion.html as flaky.
aboxhall@chromium.org [Fri, 2 Nov 2012 19:02:28 +0000 (19:02 +0000)]
Unreviewed gardening. Marking object-clip-rects-assertion.html as flaky.
https://bugs.webkit.org/show_bug.cgi?id=86909

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoENABLE(UNDO_MANAGER) is disabled everywhere and is not under active development
abarth@webkit.org [Fri, 2 Nov 2012 19:01:01 +0000 (19:01 +0000)]
ENABLE(UNDO_MANAGER) is disabled everywhere and is not under active development
https://bugs.webkit.org/show_bug.cgi?id=100711

Reviewed by Eric Seidel.

.:

* Source/cmake/WebKitFeatures.cmake:
* Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

No one is actively working on ENABLE(UNDO_MANAGER). There are some
tricky lifetime issues in the UndoManager API that are complicating
ongoing work to improve the interaction between WebCore and the garbage
collector. Rather than leave this code in a broken state, we should
remove it for the time being. We can always restore it from the svn
history when there is an active owner for this code.

* CMakeLists.txt:
* Configurations/FeatureDefines.xcconfig:
* DerivedSources.cpp:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.features.am:
* GNUmakefile.list.am:
* Target.pri:
* UseJSC.cmake:
* UseV8.cmake:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/DOMTransaction.cpp: Removed.
* bindings/js/DOMTransaction.h: Removed.
* bindings/js/JSBindingsAllInOne.cpp:
* bindings/js/JSUndoManagerCustom.cpp: Removed.
* bindings/v8/DOMTransaction.cpp: Removed.
* bindings/v8/DOMTransaction.h: Removed.
* bindings/v8/V8HiddenPropertyName.h:
(WebCore):
* bindings/v8/custom/V8DOMTransactionCustom.cpp: Removed.
* bindings/v8/custom/V8UndoManagerCustom.cpp: Removed.
* css/PropertySetCSSStyleDeclaration.cpp:
(WebCore::PropertySetCSSStyleDeclaration::setCssText):
(WebCore::PropertySetCSSStyleDeclaration::setProperty):
(WebCore::PropertySetCSSStyleDeclaration::removeProperty):
(WebCore::PropertySetCSSStyleDeclaration::setPropertyInternal):
* dom/CharacterData.cpp:
(WebCore::CharacterData::setDataAndUpdate):
* dom/ContainerNode.cpp:
(WebCore::willRemoveChild):
(WebCore::willRemoveChildren):
(WebCore::updateTreeAfterInsertion):
* dom/Document.cpp:
(WebCore::Document::Document):
* dom/Document.h:
(WebCore):
(Document):
* dom/Document.idl:
* dom/Element.cpp:
(WebCore::Element::willModifyAttribute):
* editing/CompositeEditCommand.h:
* editing/DOMTransaction.idl: Removed.
* editing/DOMTransactionStep.cpp: Removed.
* editing/DOMTransactionStep.h: Removed.
* editing/Editor.cpp:
(WebCore::Editor::appliedEditing):
(WebCore::Editor::unappliedEditing):
(WebCore::Editor::reappliedEditing):
(WebCore::Editor::canUndo):
(WebCore::Editor::undo):
(WebCore::Editor::canRedo):
(WebCore::Editor::redo):
* editing/UndoManager.cpp: Removed.
* editing/UndoManager.h: Removed.
* editing/UndoManager.idl: Removed.
* editing/UndoStep.h:
(UndoStep):

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:

Tools:

* Scripts/webkitperl/FeatureList.pm:
* qmake/mkspecs/features/features.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMeasure the usage of the various CSP headers.
mkwst@chromium.org [Fri, 2 Nov 2012 18:54:46 +0000 (18:54 +0000)]
Measure the usage of the various CSP headers.
https://bugs.webkit.org/show_bug.cgi?id=100974

Reviewed by Adam Barth.

Currently, we're collecting metrics regarding usage of the
'X-WebKit-CSP' and 'X-WebKit-CSP-Report-Only' HTTP headers. We've
recently added support for the canonical 'Content-Security-Policy'
and 'Content-Security-Policy-Report-Only' headers. This patch adds
those headers explicitly into the metrics, giving insight into uptake
of the unprefixed header, and into usage of pure reporting vs.
enforcement.

No visible functionality should change; all Content Security Policy
tests should continue to pass.

* page/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::didReceiveHeader):
    Convert the CSP header type into a FeatureObserver::Feature, and
    observe it.
* page/FeatureObserver.h:
    Add three new values to the enum to cover the new header types.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix silly mistake from http://trac.webkit.org/changeset/133315.
ojan@chromium.org [Fri, 2 Nov 2012 18:53:00 +0000 (18:53 +0000)]
Fix silly mistake from trac.webkit.org/changeset/133315.
Forgot to remove the "!".

* css/StyleResolver.cpp:
(WebCore::StyleResolver::canShareStyleWithElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSupport X-XSS-Protection: report=URL header syntax in XSSAuditor.
tsepez@chromium.org [Fri, 2 Nov 2012 18:50:57 +0000 (18:50 +0000)]
Support X-XSS-Protection: report=URL header syntax in XSSAuditor.
https://bugs.webkit.org/show_bug.cgi?id=100892

Reviewed by Adam Barth.

Source/WebCore:

This patch adds a security feature which allows a violation report to be sent back
to a site when the XSSAuditor detects a reflected XSS against it.  It uses the same
reporting mechanism as for CSP violation reports.

Tests: http/tests/security/xssAuditor/malformed-xss-protection-header-5.html
       http/tests/security/xssAuditor/malformed-xss-protection-header-6.html
       http/tests/security/xssAuditor/malformed-xss-protection-header-7.html
       http/tests/security/xssAuditor/malformed-xss-protection-header-8.html
       http/tests/security/xssAuditor/malformed-xss-protection-header-9.html
       http/tests/security/xssAuditor/report-script-tag.html
       http/tests/security/xssAuditor/xss-protection-parsing-03.html
       http/tests/security/xssAuditor/xss-protection-parsing-04.html

* html/parser/XSSAuditor.cpp:
(WebCore::XSSAuditor::XSSAuditor):
(WebCore::XSSAuditor::init):
(WebCore::XSSAuditor::filterToken):
Invoke Ping loader's violation reporting, if requested, when a reflected
XSS is detected.

* html/parser/XSSAuditor.h:
XSSAuditor class need to store the report URL as well as the undigested versions
of the request URL and request body for reporting.

* loader/MixedContentChecker.cpp:
(WebCore):
* loader/MixedContentChecker.h:
(MixedContentChecker):
Make isMixedContent() method public.

* loader/PingLoader.cpp:
(WebCore::PingLoader::sendViolationReport):
* loader/PingLoader.h:
(PingLoader):
* page/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::reportViolation):
Renamed reportContentSecurityPolicyViolation() method to sendViolationReport(),
since this is now used to send more than just CSP violations.

* platform/network/HTTPParsers.cpp:
(WebCore):
(WebCore::skipEquals):
(WebCore::skipValue):
(WebCore::parseXSSProtectionHeader):
* platform/network/HTTPParsers.h:
Parse and return report= directive in X-XSS-Protection header.

LayoutTests:

* http/tests/security/xssAuditor/malformed-xss-protection-header-1-expected.txt:
* http/tests/security/xssAuditor/malformed-xss-protection-header-2-expected.txt:
* http/tests/security/xssAuditor/malformed-xss-protection-header-3-expected.txt:
* http/tests/security/xssAuditor/malformed-xss-protection-header-4-expected.txt:
* http/tests/security/xssAuditor/malformed-xss-protection-header-5-expected.txt: Added.
* http/tests/security/xssAuditor/malformed-xss-protection-header-5.html: Added.
* http/tests/security/xssAuditor/malformed-xss-protection-header-6-expected.txt: Added.
* http/tests/security/xssAuditor/malformed-xss-protection-header-6.html: Added.
* http/tests/security/xssAuditor/malformed-xss-protection-header-7-expected.txt: Added.
* http/tests/security/xssAuditor/malformed-xss-protection-header-7.html: Added.
* http/tests/security/xssAuditor/malformed-xss-protection-header-8-expected.txt: Added.
* http/tests/security/xssAuditor/malformed-xss-protection-header-8.html: Added.
* http/tests/security/xssAuditor/malformed-xss-protection-header-9-expected.txt: Added.
* http/tests/security/xssAuditor/malformed-xss-protection-header-9.html: Added.
* http/tests/security/xssAuditor/report-script-tag-expected.txt: Added.
* http/tests/security/xssAuditor/report-script-tag.html: Added.
* http/tests/security/xssAuditor/resources/echo-intertag.pl:
* http/tests/security/xssAuditor/xss-protection-parsing-03-expected.txt: Added.
* http/tests/security/xssAuditor/xss-protection-parsing-03.html: Added.
* http/tests/security/xssAuditor/xss-protection-parsing-04-expected.txt: Added.
* http/tests/security/xssAuditor/xss-protection-parsing-04.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Mac] REGRESSION (r130411-r130414): fast/images/repaint-subrect-grid.html failing...
vollick@chromium.org [Fri, 2 Nov 2012 18:45:09 +0000 (18:45 +0000)]
[Mac] REGRESSION (r130411-r130414): fast/images/repaint-subrect-grid.html failing on Apple MountainLion Debug WK2 (Tests)
https://bugs.webkit.org/show_bug.cgi?id=98523

Reviewed by Simon Fraser.

The repaint-subrect-grid.html layout test is now text-based and
doesn't use testRunner.displayInvalidatedRegion().

* fast/images/repaint-subrect-grid-expected.txt:
* fast/images/repaint-subrect-grid.html:
* platform/chromium/fast/images/repaint-subrect-grid-expected.png: Removed.
* platform/efl/fast/images/repaint-subrect-grid-expected.png: Removed.
* platform/mac/TestExpectations:
* platform/mac/fast/images/repaint-subrect-grid-expected.txt: Added.
* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r133313.
senorblanco@chromium.org [Fri, 2 Nov 2012 18:43:30 +0000 (18:43 +0000)]
Unreviewed, rolling out r133313.
http://trac.webkit.org/changeset/133313
https://bugs.webkit.org/show_bug.cgi?id=101078

"A lot of tests hit the ASSERTs introduced by this patch"
(Requested by haraken on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-02

* bindings/v8/V8DOMWrapper.h:
(WebCore::V8DOMWrapper::setDOMWrapper):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed gardening. Marking some repaint tests as flaky.
aboxhall@chromium.org [Fri, 2 Nov 2012 18:39:44 +0000 (18:39 +0000)]
Unreviewed gardening. Marking some repaint tests as flaky.
https://bugs.webkit.org/show_bug.cgi?id=84720

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r132913.
ojan@chromium.org [Fri, 2 Nov 2012 18:33:58 +0000 (18:33 +0000)]
Unreviewed, rolling out r132913.
http://trac.webkit.org/changeset/132913
https://bugs.webkit.org/show_bug.cgi?id=91850

Caused performance regressions.
See https://bugs.webkit.org/show_bug.cgi?id=100872 for details.

* bindings/v8/V8PerIsolateData.cpp:
(WebCore::V8PerIsolateData::visitExternalStrings):
* bindings/v8/V8StringResource.cpp:
(StringTraits):
(WebCore::v8StringToWebCoreString):
* bindings/v8/V8ValueCache.cpp:
(WebCore::makeExternalString):
(WebCore::WebCoreStringResource::visitStrings):
* bindings/v8/V8ValueCache.h:
(WebCore::WebCoreStringResource::WebCoreStringResource):
(WebCore::WebCoreStringResource::~WebCoreStringResource):
(WebCore::WebCoreStringResource::data):
(WebCoreStringResource):
(WebCore::WebCoreStringResource::length):
(WebCore::WebCoreStringResource::atomicString):
(WebCore::WebCoreStringResource::toStringResource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[WK2][EFL] Crash when calling WebOpenPanelResultListenerProxy::cancel() after PageCli...
commit-queue@webkit.org [Fri, 2 Nov 2012 18:27:22 +0000 (18:27 +0000)]
[WK2][EFL] Crash when calling WebOpenPanelResultListenerProxy::cancel() after PageClient is destroyed
https://bugs.webkit.org/show_bug.cgi?id=100977

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-11-02
Reviewed by Alexey Proskuryakov.

Call WebPageProxy::close() in EwkViewImpl's destructor to avoid crashes
if other objects keep a reference to the WebPageProxy and try to use
it after the view (and therefore the PageClient) is destroyed.

* UIProcess/API/efl/EwkViewImpl.cpp:
(EwkViewImpl::~EwkViewImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Remove dependency on SoupPasswordManager
commit-queue@webkit.org [Fri, 2 Nov 2012 18:05:42 +0000 (18:05 +0000)]
[GTK] Remove dependency on SoupPasswordManager
https://bugs.webkit.org/show_bug.cgi?id=100775

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-11-02
Reviewed by Carlos Garcia Campos.

.:

Add a libsecret dependency to the build. This is necessary so that we can remove
a dependency on SoupPasswordManager.

* configure.ac: Look for libsecret using the pkg-config configuration macro.

Source/WebCore:

Remember passwords using libsecret instead of SoupPasswordManager. We accomplish this using
a new class, CredentialBackingStore. CredentialBackingStore will soon be the thing that backs
CredentialStoreGtk. The name is based on the name of a similar class from the BlackBerry port.

No new tests. This does not change behavior.

* GNUmakefile.am: Add libsecret flags to the build and the new directory to the include list.
* GNUmakefile.list.am: Add new files to the source list.
* platform/gtk/GRefPtrGtk.cpp: Add support for SecretValue to GRefPtrGtk.
* platform/gtk/GtkAuthenticationDialog.cpp: Replace interaction with SoupPasswordManger with
interaction with the CredentialBackingStore. Remove all conditional SoupPasswordManager guards.
* platform/gtk/GtkAuthenticationDialog.h: Ditto.
* platform/network/gtk/CredentialBackingStore.cpp: Added.
* platform/network/gtk/CredentialBackingStore.h: Added.

Source/WebKit/gtk:

Add a libsecret dependency to the build. This is necessary so that we can remove
a dependency on SoupPasswordManager.

* GNUmakefile.am: Use libsecret libs during WebKit1 library compilation.

Source/WebKit2:

Add a libsecret dependency to the build. This is necessary so that we can remove
a dependency on SoupPasswordManager.

* GNUmakefile.am: Add libsecret CFLAGS to the WebKit2 build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix build warning [-Wswitch]
commit-queue@webkit.org [Fri, 2 Nov 2012 17:57:43 +0000 (17:57 +0000)]
Fix build warning [-Wswitch]
https://bugs.webkit.org/show_bug.cgi?id=101029

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-11-02
Reviewed by Alexey Proskuryakov.

Fix build warning message: enumeration value ‘Viewport’ not handled in switch [-Wswitch]
in Source/WebCore/css/StyleSheetContents.cpp.
Add case statement for 'Viewport' with the CSS_DEVICE_ADAPTATION macro.

* css/StyleSheetContents.cpp:
(WebCore::childRulesHaveFailedOrCanceledSubresources):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMove m_element checks out of canShareStyle into locateSharedStyle
ojan@chromium.org [Fri, 2 Nov 2012 17:54:02 +0000 (17:54 +0000)]
Move m_element checks out of canShareStyle into locateSharedStyle
https://bugs.webkit.org/show_bug.cgi?id=101070

Reviewed by Darin Adler.

Can shareStyleWithElement is called for each sibling as we look for a
shareElement. locateSharedStyle is called once for the element we're
trying to find a style for. Checks that only depend on the latter
element should, thus be in locateSharedStyle.

No new tests. There should be no change in behavior, except possibly
a performance improvement in some cases.

* css/StyleResolver.cpp:
(WebCore::StyleResolver::canShareStyleWithElement):
(WebCore::StyleResolver::locateSharedStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Adding window.external to our port
commit-queue@webkit.org [Fri, 2 Nov 2012 17:46:55 +0000 (17:46 +0000)]
[BlackBerry] Adding window.external to our port
https://bugs.webkit.org/show_bug.cgi?id=100868

Patch by Otto Derek Cheung <otcheung@rim.com> on 2012-11-02
Reviewed by Rob Buis.
PR 158809

Patch up an error where we were dereferencing a null pointer.

* WebCoreSupport/ExternalExtension.cpp:
(addSearchProviderMethod):
(IsSearchProviderInstalledMethod):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[V8] Add ASSERT() to guarantee that we don't store NULL pointers to V8 internal fields
haraken@chromium.org [Fri, 2 Nov 2012 17:42:50 +0000 (17:42 +0000)]
[V8] Add ASSERT() to guarantee that we don't store NULL pointers to V8 internal fields
https://bugs.webkit.org/show_bug.cgi?id=101054

Reviewed by Adam Barth.

I'm investigating a Chromium crash bug:
http://code.google.com/p/chromium/issues/detail?id=155942

I've not yet identified the root cause (because I can't reproduce
the crash), but it looks like we are storing NULL pointers to
V8 internal fields. Just in case, we can add an ASSERT() to
guarantee that NULL pointers are never stored. (Also I'm hoping
that this ASSERT() will give me more debug information.)

No tests. No change in behavior.

* bindings/v8/V8DOMWrapper.h:
(WebCore::V8DOMWrapper::setDOMWrapper):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImrpove scoring in touch adjustment to address bias towards smaller targets.
commit-queue@webkit.org [Fri, 2 Nov 2012 17:19:09 +0000 (17:19 +0000)]
Imrpove scoring in touch adjustment to address bias towards smaller targets.
https://bugs.webkit.org/show_bug.cgi?id=101046

Patch by Kevin Ellis <kevers@chromium.org> on 2012-11-02
Reviewed by Antonio Gomes.

Source/WebCore:

Update the touch overlap score for touch adjustmetn to normalize
with respect to the maximum possible overlap rather than the size
of the target element.  This change enables good overlap scores for
small and large targets alike.  Prior to the patch it was not possible
to get a good overlap score for a sufficiently larget target.

Covered by existing tests, which have been updated to reflect the
intended behavior.

* page/TouchAdjustment.cpp:
(WebCore::TouchAdjustment::hybridDistanceFunction):

LayoutTests:

Add missing mouse handlers to ensure proper handling of nested
elements.  Nested elements with explicit handlers are favored over
ancestor elements.  The change to scoring in touch adjustment,
which removes bias towards small targets, broke two of the layout
tests.  The updated tests more accurately reflect intended
behavior.

* touchadjustment/nested-shadow-node.html:
* touchadjustment/rotated-node.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Repeated errors are rendered incorrectly: link is not floating to...
mkwst@chromium.org [Fri, 2 Nov 2012 17:10:51 +0000 (17:10 +0000)]
Web Inspector: Repeated errors are rendered incorrectly: link is not floating to the right.
https://bugs.webkit.org/show_bug.cgi?id=101032

Reviewed by Yury Semikhatsky.

https://bugs.webkit.org/show_bug.cgi?id=100525 incorrectly added
'-webkit-flex: 1' only to the list generated for errors in the console.
It should have been added to normal warning text as well. This patch
fixes the problem.

* inspector/front-end/inspector.css:
(.repeated-message .outline-disclosure, .repeated-message > .console-message-text):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Timeline: show popup for CPU bars.
commit-queue@webkit.org [Fri, 2 Nov 2012 17:07:21 +0000 (17:07 +0000)]
Web Inspector: Timeline: show popup for CPU bars.
https://bugs.webkit.org/show_bug.cgi?id=100951

Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-11-02
Reviewed by Pavel Feldman.

Each CPU bar can represent a combination of several shorter messages.
We should show information about combined messages - start time,
total duration, CPU time, message count.

* English.lproj/localizedStrings.js: Added "Message Count" string.
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._refreshMainThreadBars):
Supply elements with underlying info.
* inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel.prototype.generateMainThreadBarPopupContent):
Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Network panel grid UI is misaligned after r132888
commit-queue@webkit.org [Fri, 2 Nov 2012 16:58:55 +0000 (16:58 +0000)]
Web Inspector: Network panel grid UI is misaligned after r132888
https://bugs.webkit.org/show_bug.cgi?id=101050

Rollback the change to basic data grid css and move it to the native memory
snapshot datagrid css.

Patch by Alexei Filippov <alph@chromium.org> on 2012-11-02
Reviewed by Alexander Pavlov.

* inspector/front-end/dataGrid.css:
(.data-grid td):
* inspector/front-end/nativeMemoryProfiler.css:
(.native-snapshot-view .data-grid td):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r133303.
kbalazs@webkit.org [Fri, 2 Nov 2012 16:43:31 +0000 (16:43 +0000)]
Unreviewed, rolling out r133303.
http://trac.webkit.org/changeset/133303
https://bugs.webkit.org/show_bug.cgi?id=101068

"Broke qt wk2 build (seems like bots fails to rerun qmake if
needed)" (Requested by kbalazs on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-02

Source/WebCore:

* Target.pri:
* WebCore.pri:
* platform/PlatformStrategies.cpp:
(WebCore):
* platform/qt/QtTestSupport.h: Removed.

Tools:

* DumpRenderTree/qt/DumpRenderTree.pro:
* DumpRenderTree/qt/DumpRenderTreeMain.cpp:
(main):
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::open):
* DumpRenderTree/qt/QtInitializeTestFonts.cpp: Renamed from Source/WebCore/platform/qt/QtTestSupport.cpp.
(WebKit):
(WebKit::initializeTestFonts):
* DumpRenderTree/qt/QtInitializeTestFonts.h: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp.
(WebKit):
* QtTestBrowser/QtTestBrowser.pro:
* QtTestBrowser/qttestbrowser.cpp:
(LauncherApplication::handleUserOptions):
* WebKitTestRunner/InjectedBundle/Target.pri:
* WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
(WTR::activateFonts):
* WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.cpp: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp.
* WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.h: Copied from Tools/WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp.
* WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp:
(WTR::TestRunner::platformInitialize):
* WebKitTestRunner/Target.pri:
* WebKitTestRunner/qt/main.cpp:
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL][WK2] Change the scope of locking in WorkQueueEfl.cpp.
commit-queue@webkit.org [Fri, 2 Nov 2012 16:30:24 +0000 (16:30 +0000)]
[EFL][WK2] Change the scope of locking in WorkQueueEfl.cpp.
https://bugs.webkit.org/show_bug.cgi?id=98978

Patch by Byungwoo Lee <bw80.lee@samsung.com> on 2012-11-02
Reviewed by Kenneth Rohde Christiansen.

Release the m_workItemQueueLock and m_timerWorkItemsLock mutexes
immediately after the protected resource is no longer modified to
prevent a possible source of a deadlock.

And additional mutex locker for the m_writeToPipeDescriptor is added
to ensure thread-safety of the sendMessageToThread() function.

* Platform/WorkQueue.h:
(WorkQueue):
* Platform/efl/WorkQueueEfl.cpp:
(WorkQueue::insertTimerWorkItem):
(WorkQueue::performTimerWork):
(WorkQueue::sendMessageToThread):
(WorkQueue::dispatch):
(WorkQueue::dispatchAfterDelay):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Rolled DEPS.
senorblanco@chromium.org [Fri, 2 Nov 2012 16:16:45 +0000 (16:16 +0000)]
Unreviewed.  Rolled DEPS.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Unreviewed gardening.
senorblanco@chromium.org [Fri, 2 Nov 2012 16:14:50 +0000 (16:14 +0000)]
[Chromium] Unreviewed gardening.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL][WK2] Add API unit tests for Ewk_Object
commit-queue@webkit.org [Fri, 2 Nov 2012 16:09:54 +0000 (16:09 +0000)]
[EFL][WK2] Add API unit tests for Ewk_Object
https://bugs.webkit.org/show_bug.cgi?id=101037

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-11-02
Reviewed by Kenneth Rohde Christiansen.

Added API unit tests for Ewk_Object.

* PlatformEfl.cmake:
* UIProcess/API/efl/tests/test_ewk2_object.cpp: Added.
(TestEwkObject1):
(TestEwkObject1::create):
(TestEwkObject1::~TestEwkObject1):
(TestEwkObject2):
(TestEwkObject2::create):
(TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] setPlatformStrategies always asserts after r132744
kbalazs@webkit.org [Fri, 2 Nov 2012 16:02:08 +0000 (16:02 +0000)]
[Qt][WK2] setPlatformStrategies always asserts after r132744
https://bugs.webkit.org/show_bug.cgi?id=100838

Reviewed by Simon Hausmann.

Source/WebCore:

The problem here is that we use QWebSettings::clearMemoryCaches, a WebKit1 API
from the injected bundle, which calls initializeWebCoreQt and it sets the platform
strategies to the one for WebKit1. We should stop using WebKit1 API's from WebKit2
code. In order to keep the behavior, this patch adds exported helpers to WebCore
that can be used from DumpRenderTree and WebKitTestRunner. This is the same idea
as WebCoreTestSupport but these helpers are specific to Qt. Technically we could
add it to the WebKit1 API for the time being, but my goal was to move in the direction
of removing the WebKit1 dependency from WebKitTestRunner. We only build the file
in non production mode.

Basically covered by all tests.

* Target.pri:
* WebCore.pri: We need to link against fontconfig (only in non-production mode) since
initializeTestFonts uses it.
* platform/PlatformStrategies.cpp:
(WebCore): Zero initialize the global static variable as it is expected by the functions
below. It is a side fix. It seems like it has not been shown on debug WebKit2 bots because
common runtime environments tend to zero initialize statics by default - but I don't think
we should rely on that.
* platform/qt/QtTestSupport.cpp: Added. I choose GPL license because code from qwebsettings.cpp
is also under that.
(WebKit):
(WebKit::QtTestSupport::clearMemoryCaches): This is basically a copy of QWebSettings::clearMemoryCaches
without calling initializeWebCoreQt.
(WebKit::QtTestSupport::initializeTestFonts): I moved this code here as well now that we have to expose
symbols from WebCore anyway. The advantage is that now we don't have to build it twice and we don't need
additional files to forward it from the directory of DumpRenderTree for WebKitTestRunner.
I added a call to FontCace::invalidate in the case when the font set has been changed so that it will do
the job even if we would stop clearing all caches between tests. Also moved the call to
QFontDatabase::removeAllApplicationFonts from callers to here.
* platform/qt/QtTestSupport.h:
(WebKit):
(QtTestSupport):

Tools:

Turned test runners to use the new QtTestSupport.

* DumpRenderTree/qt/DumpRenderTree.pro:
* DumpRenderTree/qt/DumpRenderTreeMain.cpp:
(main):
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::open):
* QtTestBrowser/QtTestBrowser.pro:
* QtTestBrowser/qttestbrowser.cpp:
(LauncherApplication::handleUserOptions):
* WebKitTestRunner/InjectedBundle/Target.pri:
* WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:
(WTR::activateFonts):
* WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.cpp: Removed.
* WebKitTestRunner/InjectedBundle/qt/QtInitializeTestFonts.h: Removed.
* WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
* WebKitTestRunner/InjectedBundle/qt/TestRunnerQt.cpp:
(WTR::TestRunner::platformInitialize): Removed the comment from here
because it was just lying, apparently two times. First, it is not incorrect
to reinitialize our font set and clear font caches, it is what the tests
expect. Second, the use of QRawFont has nothing to do with the font cache.
* WebKitTestRunner/Target.pri:
* WebKitTestRunner/qt/main.cpp:
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Fix build on Windows when Qt is configured with -release
commit-queue@webkit.org [Fri, 2 Nov 2012 15:42:37 +0000 (15:42 +0000)]
[Qt] Fix build on Windows when Qt is configured with -release
https://bugs.webkit.org/show_bug.cgi?id=101041

Patch by Simon Hausmann <simon.hausmann@digia.com> on 2012-11-02
Reviewed by Jocelyn Turcotte.

When Qt is configured with -debug or -release, the release/debug build of for example
QtCore is not available by default. For LLIntExtractor we always need to build debug
_and_ release versions, but we do not actually need any Qt libraries nor qtmain(d).lib.
Therefore we can disable all these features but need to keep $$QT.core.includes in the
INCLUDEPATH for some defines from qglobal.h.

* LLIntOffsetsExtractor.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoOptimize DateTimeFormat::quoteAndAppendLiteral output
tkent@chromium.org [Fri, 2 Nov 2012 15:26:53 +0000 (15:26 +0000)]
Optimize DateTimeFormat::quoteAndAppendLiteral output
https://bugs.webkit.org/show_bug.cgi?id=101040

Reviewed by Kentaro Hara.

Source/WebCore:

In LDML date format pattern, only ASCII alphabet and quote have special
roles. So we don't need to quote the input string if it doesn't contain
them.

No new tests. Updated WebKit/chromium/tests/LocaleWinTest.cpp

* platform/text/DateTimeFormat.cpp:
(WebCore::isASCIIAlphabetOrQuote): A helper to check special characters.
(WebCore::DateTimeFormat::quoteAndAppendLiteral):
Append the input string as is if it has no special character.

Source/WebKit/chromium:

* tests/LocaleWinTest.cpp:
(TEST_F): Update test results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION (r133075): plugins/plugin-javascript-access.html is failing
rakuco@webkit.org [Fri, 2 Nov 2012 15:22:40 +0000 (15:22 +0000)]
REGRESSION (r133075): plugins/plugin-javascript-access.html is failing
https://bugs.webkit.org/show_bug.cgi?id=101045

Patch by Sudarsana Nagineni <sudarsana.nagineni@intel.com> on 2012-11-02
Reviewed by Kenneth Rohde Christiansen.

Encode the plugin filename in ArgumentCoder<PluginInfo> so that
plugin.filename returns the filename instead of name of the plugin.

* Shared/WebCoreArgumentCoders.cpp:
(CoreIPC::::encode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoOutput Android's device status before running tests on the bots
peter@chromium.org [Fri, 2 Nov 2012 15:16:04 +0000 (15:16 +0000)]
Output Android's device status before running tests on the bots
https://bugs.webkit.org/show_bug.cgi?id=100944

Reviewed by Dirk Pranke.

This adds a new step to the build master which will be run prior to the
actual tests-suites on the Chromium Android tester, and soon the Chromium
Android Perf bot. For each attached device, it outputs the build
information, battery level, battery temperature and username.

The Android tester currently is very flaky, and this will help tremendously
in being able to figure out what's wrong with the bot.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(OutputAndroidDeviceStatus):
(TestFactory.__init__):
* BuildSlaveSupport/chromium/output-android-device-status: Added.
(GetAttachedDevices):
(AndroidDeviceStatus):
(AndroidDeviceStatus.__init__):
(AndroidDeviceStatus._run_adb_command):
(AndroidDeviceStatus.device_type):
(AndroidDeviceStatus.device_build):
(AndroidDeviceStatus.device_fingerprint):
(AndroidDeviceStatus.battery_level):
(AndroidDeviceStatus.battery_temperature):
(AndroidDeviceStatus.username):
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: NMI instrument NodeRareData::Map. It uses ~250k on nytimes.com
loislo@chromium.org [Fri, 2 Nov 2012 15:10:32 +0000 (15:10 +0000)]
Web Inspector: NMI instrument NodeRareData::Map. It uses ~250k on nytimes.com
https://bugs.webkit.org/show_bug.cgi?id=101052

Reviewed by Yury Semikhatsky.

I noticed that in many cases cache structures are plain static HashMap, HashSet etc.
MemoryAgent can visit it but instrumentation for these containers report no objectType.
It means that addRootObject method needs to accept objectType property as an argument.
Otherwise I would have had to create a proxy class with proper objectType.

Source/WebCore:

* dom/WebCoreMemoryInstrumentation.cpp:
(WebCore::WebCoreMemoryInstrumentation::reportMemoryUsage):
(WebCore):
* dom/WebCoreMemoryInstrumentation.h:
(WebCoreMemoryInstrumentation):
(WebCore):
* inspector/InspectorMemoryAgent.cpp:
(WebCore::InspectorMemoryAgent::getProcessMemoryDistribution):

Source/WTF:

* wtf/MemoryInstrumentation.h:
(WTF::MemoryInstrumentation::addRootObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL][WK2][AC] Wrong translation of mouse events
yael@webkit.org [Fri, 2 Nov 2012 15:08:11 +0000 (15:08 +0000)]
[EFL][WK2][AC] Wrong translation of mouse events
https://bugs.webkit.org/show_bug.cgi?id=100983

Reviewed by Kenneth Rohde Christiansen.

The transform that we build for mouse events is scaled by the scale factor.
The url bar should not be scaled, so it should be scaled in the oposite
direction to compensate for that.

* UIProcess/API/efl/ewk_view.cpp:
(toWebContentTransform):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] Add missing variable initialization in PageViewportController
abecsi@webkit.org [Fri, 2 Nov 2012 14:42:40 +0000 (14:42 +0000)]
[Qt][WK2] Add missing variable initialization in PageViewportController

Reviewed by Jocelyn Turcotte.

Updating the viewport state depends on uninitialized booleans
which it should not.

* UIProcess/PageViewportController.cpp:
(WebKit::PageViewportController::PageViewportController):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] ASSERT hit for every mouse click
michael.bruning@digia.com [Fri, 2 Nov 2012 14:25:35 +0000 (14:25 +0000)]
[Qt][WK2] ASSERT hit for every mouse click
https://bugs.webkit.org/show_bug.cgi?id=100607

Reviewed by Jocelyn Turcotte.

.:

Added a test with a link that contains an <em> tag surrounding the entire inner text.
The test should be run on an assert enabled build and the assert should not be
triggered when tapping the link.

* ManualTests/tap-gesture-on-em-link-tap-highlight-assert.html: Added.

Source/WebCore:

Changed the logic of absolutePathForRenderer to use the first highlight box as the mid box
by uniting the two in case the mid box is empty. This allows the first box to be merged with
the last box should they intersect, and thereby prevents an ASSERT in addHighlightRect that is
triggered by two intersecting boxes being passed to addHighlightRect as separate ones.

Also, this patch removes some superfluous checks for LayoutRect::isEmpty, which is being checked
in LayoutRect::intersects already.

No new tests, but added manual test: ManualTests/tap-gesture-on-em-link-tap-highlight-assert.html

* page/GestureTapHighlighter.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix test calendar-picker-key-operations.html
keishi@webkit.org [Fri, 2 Nov 2012 14:07:45 +0000 (14:07 +0000)]
Fix test calendar-picker-key-operations.html
https://bugs.webkit.org/show_bug.cgi?id=101020

Reviewed by Kent Tamura.

The test was wrong and failing.

* platform/chromium-win/platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations-expected.txt:
* platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations-expected.txt:
* platform/chromium/fast/forms/calendar-picker/calendar-picker-key-operations.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRegression r130057: Improper preferred width calculation when an inline replaced...
commit-queue@webkit.org [Fri, 2 Nov 2012 13:55:23 +0000 (13:55 +0000)]
Regression r130057: Improper preferred width calculation when an inline replaced object, wrapped in an inline flow, follows some text.
https://bugs.webkit.org/show_bug.cgi?id=99442

Patch by Arpita Bahuguna <arpitabahuguna@gmail.com> on 2012-11-02
Reviewed by Levi Weintraub.

Source/WebCore:

Extra width is displayed after an inline replaced object that follows some
text (not ending in a whitespace) within an inline-block. This is due to
the end width (endMin) of the text object being carried forward (via inlineMin)
and added onto the next line containing the inline replaced object.

This was caused as a regression to, or rather became apparent post the fix
http://trac.webkit.org/changeset/130057 which fixed the block's preferred
width when a renderInline with width contained an inline replaced object.

Test: fast/block/block-with-inline-replaced-child-following-text.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeInlinePreferredLogicalWidths):
Introduced another flag (shouldBreakLineAfterText) which is set when
our current Text line (object) does not end in a whitespace, thereby
implying that there could be more text following, for which the end width
needs to be carried forward onto the next line.

In case the following object instead turns out to be an Inline Replaced
object, we should terminate our previous line and reset this extra width.
This is now being handled by checking for the shouldBreakLineAfterText
flag while processing Inline Replaced objects.

Once set, shouldBreakLineAfterText shall be reset only if we get another
Text object that ends in a whitespace, signifying the termination of
that text line. For all other cases, we persist with this flag through
the block's inline contents.

LayoutTests:

* fast/block/block-with-inline-replaced-child-following-text-expected.txt: Added.
* fast/block/block-with-inline-replaced-child-following-text.html: Added.
Test added for verifying the width of the inline-block when an inline replaced
object follows some text object which does not end in a whitespace.

The correct width of our containing box in this case should be 94px which is
determined by the min-width of our text (using ahem font) which is 64px +
the padding - 30px.

Prior to this fix, the trailing end-width from the text (64px) would be carried
onto the next line containing the inline replaced object. This would then make
that line's width as 64px (end width of text) + 30 px (padding) + 50px (width
of our image object) making it 144px in total. This would then incorrectly
define the width of our containing box.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Console: remove obsolete ctrl-shift-m shortcut
commit-queue@webkit.org [Fri, 2 Nov 2012 13:52:28 +0000 (13:52 +0000)]
Web Inspector: Console: remove obsolete ctrl-shift-m shortcut
https://bugs.webkit.org/show_bug.cgi?id=101036

Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-11-02
Reviewed by Pavel Feldman.

Ctrl-shift-m on console dumps MemoryAgent.getDOMNodeCount
This functionality seems to be obsolete.

* inspector/front-end/ConsoleView.js: Removed shortcut and function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSVG classes cause layering violations in platform Font code
schenney@chromium.org [Fri, 2 Nov 2012 13:33:57 +0000 (13:33 +0000)]
SVG classes cause layering violations in platform Font code
https://bugs.webkit.org/show_bug.cgi?id=98513

Reviewed by Eric Seidel.

Add a contained class to save and restore GlpyhPage state in FontFallbackList.
This allows us to remove the layering violation, and several methods, that
previously existed to support SVGTextRunRenderingContext.

No new tests because no change at all in functionality.

* platform/graphics/FontFallbackList.h:
(FontFallbackList):
(GlyphPagesStateSaver): New state save and restore class
(WebCore::FontFallbackList::GlyphPagesStateSaver::GlyphPagesStateSaver): Save GlyphPage state
(WebCore::FontFallbackList::GlyphPagesStateSaver::~GlyphPagesStateSaver): Restore GlyphPage state
* rendering/svg/SVGTextRunRenderingContext.cpp:
(WebCore::SVGTextRunRenderingContext::glyphDataForCharacter): Shift to usage of the new class.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL][WK2] Use MutexLocker instead of lock()/unlock().
commit-queue@webkit.org [Fri, 2 Nov 2012 13:00:41 +0000 (13:00 +0000)]
[EFL][WK2] Use MutexLocker instead of lock()/unlock().
https://bugs.webkit.org/show_bug.cgi?id=101015

Patch by Byungwoo Lee <bw80.lee@samsung.com> on 2012-11-02
Reviewed by Kenneth Rohde Christiansen.

Instead of lock()/unlock(), use MutexLocker in WorkQueue::performWork()
and WorkQueue::performTimerWork().

The locking scope will be more clear and simple with using MutexLocker.

* Platform/efl/WorkQueueEfl.cpp:
(WorkQueue::performWork):
(WorkQueue::insertTimerWorkItem):
(WorkQueue::performTimerWork):
(WorkQueue::dispatchAfterDelay):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Fix compilation errors
vsevik@chromium.org [Fri, 2 Nov 2012 12:16:22 +0000 (12:16 +0000)]
Web Inspector: Fix compilation errors
https://bugs.webkit.org/show_bug.cgi?id=101027

Reviewed by Yury Semikhatsky.

* inspector/InjectedScriptSource.js:
(.):
* inspector/front-end/NativeMemorySnapshotView.js:
(WebInspector.NativeSnapshotNode.prototype._createSizeCell):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Unreviewed pixel expectations gardening.
rakuco@webkit.org [Fri, 2 Nov 2012 12:09:41 +0000 (12:09 +0000)]
[EFL] Unreviewed pixel expectations gardening.

* platform/efl/TestExpectations: Skip some css3-text-decoration
tests which depend on pending features.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoOnly resolve attribute-derived style once per shared ElementAttributeData.
kling@webkit.org [Fri, 2 Nov 2012 12:09:27 +0000 (12:09 +0000)]
Only resolve attribute-derived style once per shared ElementAttributeData.
<http://webkit.org/b/100990>

Reviewed by Antti Koivisto.

Track the serialization of the "style" attribute, and the dirtiness of the presentation attribute style
on ElementAttributeData instead of in Node flags.

This allows us to avoid duplicate work for ElementAttributeData that are shared between multiple elements,
since the state is no longer per-Element.

I've left the presentation attribute cache in there for now, since it covers two additional cases:

    - Elements with the same attributes in different order.
    - Elements with the same presentation attributes, but with differing non-presentation attributes.

It's likely that we're not gaining much from it anymore, but that's a topic for another patch.

* dom/Node.h:
* dom/ElementAttributeData.h:
(WebCore::ElementAttributeData::presentationAttributeStyle):
(WebCore::ElementAttributeData::setPresentationAttributeStyle):
(WebCore::ElementAttributeData::styleAttributeIsDirty):
(WebCore::ElementAttributeData::setStyleAttributeIsDirty):
(WebCore::ElementAttributeData::presentationAttributeStyleIsDirty):
(WebCore::ElementAttributeData::setPresentationAttributeStyleIsDirty):
(ElementAttributeData):
(WebCore::ElementAttributeData::ElementAttributeData):
* dom/Element.cpp:
(WebCore::Element::getAttribute):
* dom/Element.h:
(WebCore::Element::styleAttributeIsDirty):
(WebCore::Element::updateInvalidAttributes):
* dom/StyledElement.cpp:
(WebCore::StyledElement::updateStyleAttribute):
(WebCore::StyledElement::attributeChanged):
(WebCore::StyledElement::styleAttributeChanged):
(WebCore::StyledElement::inlineStyleChanged):
* dom/StyledElement.h:
(WebCore::StyledElement::invalidateStyleAttribute):

    Move the "attribute style dirty" and "style attribute valid" node flags to ElementAttributeData
    and change them to both use dirty semantics.

* dom/ElementAttributeData.cpp:
(WebCore::ElementAttributeData::cloneDataFrom):

    Share the presentation attribute style between cloned elements initially.

* dom/StyledElement.h:
(WebCore::StyledElement::presentationAttributeStyle):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::sweepMatchedPropertiesCache):
(WebCore::StyleResolver::matchAllRules):
(WebCore::StyleResolver::canShareStyleWithElement):
* dom/ElementAttributeData.cpp:
(WebCore::MutableElementAttributeData::MutableElementAttributeData):
(WebCore::ElementAttributeData::reportMemoryUsage):
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::buildObjectForAttributesStyle):

    Renamed StyledElement::attributeStyle() to presentationAttributeStyle(). The old name was too
    easily confused with "style attribute".

* dom/StyledElement.cpp:
(WebCore::StyledElement::rebuildPresentationAttributeStyle):

    Renamed from updateAttributeStyle().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] WTR: Make sure that eventSender.mouseDown sends a press event for the second...
jocelyn.turcotte@digia.com [Fri, 2 Nov 2012 12:06:21 +0000 (12:06 +0000)]
[Qt] WTR: Make sure that eventSender.mouseDown sends a press event for the second press
https://bugs.webkit.org/show_bug.cgi?id=101033

Reviewed by Simon Hausmann.

eventSender.mouseDown doesn't work properly since r133153 where
MouseButtonDblClick events aren't interpreted as Press events anymore.
The problem is that mouseDown sends a DblClick event instead of a Press,
while the correct way is to send both events.

Since QQuickWebView isn't doing anything with DblClick events anymore,
simply send Press events all the time and let WebCore figure out
where the double clicks are.

* WebKitTestRunner/qt/EventSenderProxyQt.cpp:
(WTR::EventSenderProxy::updateClickCountForButton):
(WTR::EventSenderProxy::mouseDown):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoIntroduce ENABLE_DATE_AND_TIME_INPUT_TYPES, and clarify usage of other related flags
tkent@chromium.org [Fri, 2 Nov 2012 11:27:50 +0000 (11:27 +0000)]
Introduce ENABLE_DATE_AND_TIME_INPUT_TYPES, and clarify usage of other related flags
https://bugs.webkit.org/show_bug.cgi?id=101007

Reviewed by Kentaro Hara.

Source/WebCore:

ChromeClient::openDateTimeChooser and Locale::formatDateTime are
necessary if one of date/time input types is enabled and even if
ENABLE_INPUT_MULTIPLE_FIELDS_UI is disabled. So they should be wrapped
with ENABLE(DATE_AND_TIME_INPUT_TYPES).

The following clases are used only for ChromeClient::openDateTimeChooser.
They should be wrapped with the same flag.
  - class DateTimeChooser
  - class DateTiemChooserClient

The following classes/functions are used for
Locale::formatDateTime. They should be wrapped with the same flag.
  - Locale::dateFormat
  - Locale::monthFormat
  - Locale::timeFormat
  - Locale::shortTimeFormat
  - Locale::monthLabels
  - Locale::shortMonthLabels
  - Locale::standAloneMonthLabels
  - Locale::shortStandAloneMonthLabels
  - class DateTimeFormat

Also, we change the meaning of ENABLE_CALENDAR_PICKER. It meant
 1) <input> supports calendar picker UI, and
 2) WebCore/Resources/pagepopups/ is used for the calendar UI implementation.
Now ENABLE_CALENDAR_PICKER means only 2.

No new tests because of no behavior changes.

* html/BaseDateAndTimeInputType.h: This is necessary only if date/time
input types are enabled because this is a common super class of
date/time InputType classes.
* html/BaseDateAndTimeInputType.cpp: Ditto.
* html/BaseChooserOnlyDateAndTimeInputType.cpp: Ditto.
* html/BaseChooserOnlyDateAndTimeInputType.h: Ditto.

* page/ChromeClient.h: Change the flag for openDateTimeChooser, and add a comment.
* loader/EmptyClients.cpp: Follow the openDateTimeChooser flag change.
* loader/EmptyClients.h: Ditto.
* platform/DateTimeChooser.h:
This is needed only if ChromeClient::openDateTimeChooser is available.
* platform/DateTimeChooserClient.h: Ditto.

* platform/LocalizedStrings.h:
weekFormatInLDML is necessary if ENABLE(INPUT_TYPE_WEEK) regardless of
ENABLE(INPUT_MULTIPLE_FIELDS_UI).

* platform/text/PlatformLocale.h:
Change the condition for Locale::formatDateTime and the code used by
Locale::formatDateTime.
* platform/text/PlatformLocale.cpp:
(WebCore::Locale::formatDateTime):
This is necessary even if !ENABLE(INPUT_MULTIPLE_FIELDS_UI), to produce
localized representations of date/time values.
* platform/text/LocaleICU.cpp:
Change the condition for the code used by Locale::formatDateTime.
* platform/text/LocaleICU.h: Ditto.
* platform/text/LocaleNone.cpp: Ditto.
* platform/text/mac/LocaleMac.h: Ditto.
* platform/text/mac/LocaleMac.mm: Ditto.
* platform/text/win/LocaleWin.cpp: Ditto.
* platform/text/win/LocaleWin.h: Ditto.
* platform/text/DateTimeFormat.cpp: Ditto.
* platform/text/DateTimeFormat.h: Ditto.

* html/BaseMultipleFieldsDateAndTimeInputType.h:
Remove some #if-#endif for a picker indicator element because
ENABLE_CALENDAR_PICKER meaning is changed.
* html/BaseMultipleFieldsDateAndTimeInputType.cpp: Ditto.

* html/shadow/PickerIndicatorElement.cpp: CALENDAR_PICKER ->
INPUT_MULTIPLE_FIELDS_UI because ENABLE_CALENDAR_PICKER meaning is changed.
* html/shadow/PickerIndicatorElement.h: Ditto.
* rendering/RenderDetailsMarker.cpp: Ditto.
* rendering/RenderDetailsMarker.h: Ditto.
* rendering/RenderTheme.h: Ditto.
* rendering/RenderThemeChromiumCommon.cpp: Ditto.
* rendering/RenderThemeChromiumCommon.h: Ditto.
* rendering/RenderThemeChromiumMac.h: Ditto.
* rendering/RenderThemeChromiumSkia.h: Ditto.

Source/WebKit/chromium:

* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::openDateTimeChooser):
Follow the ChromeClient::openDateTimeChooser flag change.
Also, add an empty implemenatation for Android.
* src/ChromeClientImpl.h:
Follow the ChromeClient::openDateTimeChooser flag change.
* src/DateTimeChooserImpl.cpp: Wrapped with
ENABLE(INPUT_MULTIPLE_FIELDS_UI). This class is not used in Android.
* src/DateTimeChooserImpl.h: Ditto.
* src/LocalizedStrings.cpp: Follow the LocalizedString.h change.

Source/WTF:

* wtf/Platform.h:
Add ENABLE_DATE_AND_TIME_INPUT_TYPES.  It's a union of
ENABLE_INPUT_TYPE_{DATE,DATETIME,DATETIMELOCAL,MONTH,TIME,WEEK}.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Revert QCocoaNativeInterface workaround from r131720.
zeno.albisser@digia.com [Fri, 2 Nov 2012 11:22:27 +0000 (11:22 +0000)]
[Qt] Revert QCocoaNativeInterface workaround from r131720.
https://bugs.webkit.org/show_bug.cgi?id=100842

Reviewed by Simon Hausmann.

After updating Qt5 on the buildbots, the workaround
introduced in r131720 is not needed anymore.

* platform/graphics/surfaces/mac/GraphicsSurfaceMac.cpp:
(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd a common base class for date/time input types without inline editing behavior
tkent@chromium.org [Fri, 2 Nov 2012 10:29:46 +0000 (10:29 +0000)]
Add a common base class for date/time input types without inline editing behavior
https://bugs.webkit.org/show_bug.cgi?id=101031

Reviewed by Hajime Morita.

Add BaseChooserOnlyDateAndTimeInputType class, which will support
DateTimeChooserClient, and date/time input types inherit it if
!ENABLE(INPUT_MULTIPLE_FIELDS_UI).

No new tests. This doesn't change any behavior.

* CMakeLists.txt: Add BaseChooserOnlyDateAndTimeInputType.{cpp,h}.
* GNUmakefile.list.am: Ditto.
* Target.pri: Ditto.
* WebCore.gypi: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* html/BaseChooserOnlyDateAndTimeInputType.cpp: Added.
* html/BaseChooserOnlyDateAndTimeInputType.h: Added.

* html/DateInputType.h: Inherit BaseChooserOnlyDateAndTimeInputType if
!ENABLE(INPUT_MULTIPLE_FIELDS_UI).
* html/DateTimeInputType.h: Ditto.
* html/DateTimeLocalInputType.h: Ditto.
* html/MonthInputType.h: Ditto.
* html/TimeInputType.h: Ditto.
* html/WeekInputType.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: [JSC] implement WorkerScriptDebugServer
commit-queue@webkit.org [Fri, 2 Nov 2012 10:24:40 +0000 (10:24 +0000)]
Web Inspector: [JSC] implement WorkerScriptDebugServer
https://bugs.webkit.org/show_bug.cgi?id=99801

Patch by Peter Wang <peter.wang@torchmobile.com.cn> on 2012-11-02
Reviewed by Yury Semikhatsky.

To implement Worker Inspector for JSC.
The virtual function "runEventLoopWhilePaused" is defined, since there are different ways to block
the JS running in worker-context and normal page-context.
The function "isContentScript" now is virtual because the original invoked functions are useless
and cause problem in worker-context.
In function "WebCore::WorkerScriptController::attachDebugger", we invoke "initScriptIfNeeded" to
ensure the JSGloblalObject exist in the case of attaching Debugger before executing the worker
JS code (Pause on start).

No new test case.

* bindings/js/PageScriptDebugServer.cpp:
(WebCore::PageScriptDebugServer::runEventLoopWhilePaused):
(WebCore):
* bindings/js/PageScriptDebugServer.h:
(PageScriptDebugServer):
* bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::isContentScript):
(WebCore::ScriptDebugServer::pauseIfNeeded):
* bindings/js/ScriptDebugServer.h:
(JSC):
(ScriptDebugServer):
* bindings/js/WorkerScriptController.cpp:
(WebCore::WorkerScriptController::attachDebugger):
(WebCore):
(WebCore::WorkerScriptController::detachDebugger):
* bindings/js/WorkerScriptController.h:
(WorkerScriptController):
* bindings/js/WorkerScriptDebugServer.cpp:
(WebCore::WorkerScriptDebugServer::WorkerScriptDebugServer):
(WebCore):
(WebCore::WorkerScriptDebugServer::addListener):
(WebCore::WorkerScriptDebugServer::recompileAllJSFunctions):
(WebCore::WorkerScriptDebugServer::removeListener):
(WebCore::WorkerScriptDebugServer::runEventLoopWhilePaused):
* bindings/js/WorkerScriptDebugServer.h:
(WorkerScriptDebugServer):
(WebCore::WorkerScriptDebugServer::getListenersForGlobalObject):
(WebCore::WorkerScriptDebugServer::isContentScript):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL][WK2] Add HTTP authentication support to MiniBrowser
commit-queue@webkit.org [Fri, 2 Nov 2012 10:24:38 +0000 (10:24 +0000)]
[EFL][WK2] Add HTTP authentication support to MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=100953

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-11-02
Reviewed by Kenneth Rohde Christiansen.

Add HTTP authentication support to MiniBrowser. An authentication
dialog now pops up to ask the user for credentials whenever
a Web site requires authentication.

* MiniBrowser/efl/main.c:
(auth_popup_close):
(on_auth_cancel):
(on_auth_ok):
(on_authentication_request):
(window_create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCompilation warning in Node.cpp when USERSELECT_ALL is disabled
commit-queue@webkit.org [Fri, 2 Nov 2012 09:47:37 +0000 (09:47 +0000)]
Compilation warning in Node.cpp when USERSELECT_ALL is disabled
https://bugs.webkit.org/show_bug.cgi?id=101025

Patch by KyungTae Kim <ktf.kim@samsung.com> on 2012-11-02
Reviewed by Ryosuke Niwa.

The parameter 'treatment' is not used when USERSELECT_ALL is disabled.

* dom/Node.cpp:
(WebCore::Node::rendererIsEditable):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL][WK2] Common ref and unref functions for EFL WK2 objects
commit-queue@webkit.org [Fri, 2 Nov 2012 09:24:28 +0000 (09:24 +0000)]
[EFL][WK2] Common ref and unref functions for EFL WK2 objects
https://bugs.webkit.org/show_bug.cgi?id=100751

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-11-02
Reviewed by Kenneth Rohde Christiansen.

Added common Ewk_Object class with ref/unref API also added several aux functions for safe
Ewk_Object conversion. Used new approach on ewk_back_forward_list_item as example.

* PlatformEfl.cmake:
* UIProcess/API/efl/EWebKit2.h:
* UIProcess/API/efl/ewk_back_forward_list.cpp:
(Ewk_Back_Forward_List::getFromCacheOrCreate):
(Ewk_Back_Forward_List::createEinaList):
* UIProcess/API/efl/ewk_back_forward_list_item.cpp:
(EwkBackForwardListItem::EwkBackForwardListItem):
(EwkBackForwardListItem::url):
(EwkBackForwardListItem::title):
(EwkBackForwardListItem::originalURL):
(ewk_back_forward_list_item_url_get):
(ewk_back_forward_list_item_title_get):
(ewk_back_forward_list_item_original_url_get):
* UIProcess/API/efl/ewk_back_forward_list_item.h:
* UIProcess/API/efl/ewk_back_forward_list_item_private.h:
(EwkBackForwardListItem):
(EwkBackForwardListItem::create):
* UIProcess/API/efl/ewk_back_forward_list_private.h:
* UIProcess/API/efl/ewk_object.cpp: Copied from Source/WebKit2/UIProcess/API/efl/ewk_back_forward_list_item_private.h.
(ewk_object_ref):
(ewk_object_unref):
* UIProcess/API/efl/ewk_object.h: Copied from Source/WebKit2/UIProcess/API/efl/ewk_back_forward_list_item_private.h.
* UIProcess/API/efl/ewk_object_private.h: Added.
(Ewk_Object):
(Ewk_Object::~Ewk_Object):
(ewk_object_is_of_type):
(ewk_object_cast_check):
(ewk_object_cast):
* UIProcess/API/efl/tests/test_ewk2_back_forward_list.cpp:
(freeEinaList):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Middle click closes an editor and pastes selection into current editor...
vsevik@chromium.org [Fri, 2 Nov 2012 09:16:16 +0000 (09:16 +0000)]
Web Inspector: Middle click closes an editor and pastes selection into current editor on Linux
https://bugs.webkit.org/show_bug.cgi?id=100743

Reviewed by Alexander Pavlov.

Editor now consumes all middle mouse button mouse ups except for the ones in the main panel.
TabbedPane now consumes all middle mouse button mouse ups as well.
Navigator view does not pass focus anymore if element was selected with middle mouse button.

* inspector/front-end/DefaultTextEditor.js:
(.preventDefaultOnMouseUp):
(.consumeMouseUp):
* inspector/front-end/NavigatorView.js:
(WebInspector.NavigatorSourceTreeElement.prototype.ondblclick):
* inspector/front-end/TabbedPane.js:
(WebInspector.TabbedPane):
(WebInspector.TabbedPane.prototype.onMouseUp):
(WebInspector.TabbedPane.prototype.onMouseClick):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][Mac][Win] Unreviewed build fix after r133182
ossy@webkit.org [Fri, 2 Nov 2012 09:16:12 +0000 (09:16 +0000)]
[Qt][Mac][Win] Unreviewed build fix after r133182
https://bugs.webkit.org/show_bug.cgi?id=100995

Remove two methods' OVERRIDE and virtual modifiers, because they cannot be found in any base class.
Also relocate their prototypes, because they mix with the overridden ones.

Patch by Nandor Huszka <hnandor@inf.u-szeged.hu> on 2012-11-02

* WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:
(CoordinatedGraphicsLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: NMI instrument ShadowRoot. It gives us ~400k on plus.google.com
loislo@chromium.org [Fri, 2 Nov 2012 09:11:19 +0000 (09:11 +0000)]
Web Inspector: NMI instrument ShadowRoot. It gives us ~400k on plus.google.com
https://bugs.webkit.org/show_bug.cgi?id=100866

Reviewed by Yury Semikhatsky.

Plain vanilla memory instrumentation code for HTMLInputElement which has a ElementShadow.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* dom/DocumentOrderedMap.cpp:
(WebCore::DocumentOrderedMap::reportMemoryUsage):
(WebCore):
* dom/DocumentOrderedMap.h:
(DocumentOrderedMap):
* dom/Element.cpp:
(WebCore::Element::reportMemoryUsage):
(WebCore):
* dom/Element.h:
* dom/ElementRareData.cpp: Added.
(WebCore):
(WebCore::ElementRareData::reportMemoryUsage):
* dom/ElementRareData.h:
(ElementRareData):
* dom/ElementShadow.cpp:
(WebCore::ElementShadow::reportMemoryUsage):
(WebCore):
* dom/ElementShadow.h:
(ElementShadow):
* dom/Node.cpp:
(WebCore::Node::reportMemoryUsage):
* dom/NodeRareData.cpp: Added.
(WebCore):
(WebCore::NodeListsNodeData::reportMemoryUsage):
(WebCore::NodeRareData::reportMemoryUsage):
* dom/NodeRareData.h:
(NodeListsNodeData):
(NodeRareData):
* dom/ShadowRoot.cpp:
(WebCore):
(WebCore::ShadowRoot::reportMemoryUsage):
* dom/ShadowRoot.h:
(ShadowRoot):
* dom/TreeScope.cpp:
(WebCore::TreeScope::reportMemoryUsage):
(WebCore):
* dom/TreeScope.h:
(TreeScope):
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::reportMemoryUsage):
(WebCore):
* html/HTMLFormControlElement.h:
(HTMLFormControlElement):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::reportMemoryUsage):
(WebCore):
* html/HTMLInputElement.h:
(HTMLInputElement):
* html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::reportMemoryUsage):
(WebCore):
* html/HTMLTextFormControlElement.h:
(HTMLTextFormControlElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL][WK2] Add ewk_security_origin and ewk_storage_manager APIs
commit-queue@webkit.org [Fri, 2 Nov 2012 09:05:48 +0000 (09:05 +0000)]
[EFL][WK2] Add ewk_security_origin and ewk_storage_manager APIs
https://bugs.webkit.org/show_bug.cgi?id=92827

Patch by Jihye Kang <jye.kang@samsung.com> on 2012-11-02
Reviewed by Gyuyoung Kim.

Add ewk_security_origin APIs to get security origin.
These APIs will be used to get host, protocol and port of security
origin.
Add ewk_storage_manager to manage web storage and
ewk_storage_manager_origins_get to get origins list of web storage.
Add Unit tests for ewk_storage_manager and ewk_security_origin APIs.

* PlatformEfl.cmake:
* UIProcess/API/efl/EWebKit2.h:
* UIProcess/API/efl/ewk_context.cpp:
(Ewk_Context::storageManager):
(ewk_context_storage_manager_get):
* UIProcess/API/efl/ewk_context.h:
* UIProcess/API/efl/ewk_context_private.h:
(Ewk_Context):
* UIProcess/API/efl/ewk_security_origin.cpp: Added.
(Ewk_Security_Origin::Ewk_Security_Origin):
(Ewk_Security_Origin::host):
(Ewk_Security_Origin::protocol):
(Ewk_Security_Origin::port):
(ewk_security_origin_ref):
(ewk_security_origin_unref):
(ewk_security_origin_host_get):
(ewk_security_origin_protocol_get):
(ewk_security_origin_port_get):
* UIProcess/API/efl/ewk_security_origin.h: Added.
* UIProcess/API/efl/ewk_security_origin_private.h: Added.
(Ewk_Security_Origin):
(Ewk_Security_Origin::create):
* UIProcess/API/efl/ewk_storage_manager.cpp: Added.
(Ewk_Storage_Manager::Ewk_Storage_Manager):
(Ewk_Storage_Manager::getStorageOrigins):
(Ewk_Storage_Manager::createOriginList):
(_Ewk_Storage_Origins_Async_Get_Context):
(_Ewk_Storage_Origins_Async_Get_Context::_Ewk_Storage_Origins_Async_Get_Context):
(getStorageOriginsCallback):
(ewk_storage_manager_origins_get):
* UIProcess/API/efl/ewk_storage_manager.h: Added.
* UIProcess/API/efl/ewk_storage_manager_private.h: Added.
(Ewk_Storage_Manager):
(Ewk_Storage_Manager::create):
* UIProcess/API/efl/tests/test_ewk2_context.cpp:
(TEST_F):
* UIProcess/API/efl/tests/test_ewk2_storage_manager.cpp: Added.
(getStorageOriginsCallback):
(TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Cookie info in Network Resources Cookies tab shows "Invalid Date"
vsevik@chromium.org [Fri, 2 Nov 2012 08:53:00 +0000 (08:53 +0000)]
Web Inspector: Cookie info in Network Resources Cookies tab shows "Invalid Date"
https://bugs.webkit.org/show_bug.cgi?id=97471

Reviewed by Pavel Feldman.

Source/WebCore:

This patch is partly based on patch by Otto Derek Cheung <otcheung@rim.com>.
Refactored CookieParser so that all cookies in front-end were WebInspector.Cookie object.
Cookie table can now show Max-Age as well as Expires attribute of a cookie.
Fixed expiresDate calculation.
Removed getters from CookieParser for better compilation.

* English.lproj/localizedStrings.js:
* inspector/front-end/AuditRules.js:
(WebInspector.AuditRules.CookieRuleBase.prototype.mapResourceCookies):
(WebInspector.AuditRules.CookieSizeRule.prototype._average):
(WebInspector.AuditRules.CookieSizeRule.prototype._max):
(WebInspector.AuditRules.StaticCookielessRule.prototype._collectorCallback):
* inspector/front-end/CookieItemsView.js:
(WebInspector.CookieItemsView.prototype._filterCookiesForDomain):
* inspector/front-end/CookieParser.js:
(WebInspector.CookieParser.prototype.cookies):
(WebInspector.CookieParser.prototype._flushCookie):
(WebInspector.CookieParser.prototype._addCookie):
(WebInspector.Cookie.prototype.httpOnly):
(WebInspector.Cookie.prototype.secure):
(WebInspector.Cookie.prototype.session):
(WebInspector.Cookie.prototype.path):
(WebInspector.Cookie.prototype.domain):
(WebInspector.Cookie.prototype.expires):
(WebInspector.Cookie.prototype.maxAge):
(WebInspector.Cookie.prototype.size):
(WebInspector.Cookie.prototype.setSize):
(WebInspector.Cookie.prototype.expiresDate):
(WebInspector.Cookie.prototype.attributes):
(WebInspector.Cookies.getCookiesAsync):
(WebInspector.Cookies.buildCookiesFromString):
(WebInspector.Cookies.buildCookieProtocolObject):
(WebInspector.Cookies.cookieMatchesResourceURL):
(WebInspector.Cookies.cookieDomainMatchesResourceDomain):
* inspector/front-end/CookiesTable.js:
(WebInspector.CookiesTable):
(WebInspector.CookiesTable.prototype._totalSize):
(WebInspector.CookiesTable.prototype._sortCookies.expiresCompare):
(WebInspector.CookiesTable.prototype._sortCookies):
(WebInspector.CookiesTable.prototype._createGridNode):
* inspector/front-end/HAREntry.js:
(WebInspector.HAREntry.prototype._buildCookie):

LayoutTests:

* http/tests/inspector/resource-main-cookies.php:
* inspector/cookie-parser.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMemory instrumentation: do not call checkCountedObject with wrong pointers
yurys@chromium.org [Fri, 2 Nov 2012 08:06:31 +0000 (08:06 +0000)]
Memory instrumentation: do not call checkCountedObject with wrong pointers
https://bugs.webkit.org/show_bug.cgi?id=100958

Reviewed by Alexander Pavlov.

Source/WebCore:

Removed redundant call to checkCountedObject.

* inspector/MemoryInstrumentationImpl.cpp:
(WebCore::MemoryInstrumentationClientImpl::countObjectSize):

Source/WTF:

Removed calls to checkCountedObject from places where the pointer may contain
an address of a base class which may differ from the actual object pointer. Instead
checkCountedObject is only called right after processing deferred pointer where
we know real address.

* wtf/MemoryInstrumentation.h:
(WTF::MemoryInstrumentation::addObjectImpl):
(WTF::::process):

Tools:

* TestWebKitAPI/Tests/WTF/MemoryInstrumentationTest.cpp: test that if there
if there is class A derived from classes B and C and we have pointer B* to an
object of class A then MemoryInstrumentationClient::checkoutCountedObject won't
be called for B* but only for A*

Also MemoryInstrumentation implementation used in the test was refactored to
allow passing client as a parameter. The client implementation was extracted into
a top-level class MemoryInstrumentationTestClient.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: a small defect in "WorkersSidebarPanel.js"
commit-queue@webkit.org [Fri, 2 Nov 2012 07:54:27 +0000 (07:54 +0000)]
Web Inspector: a small defect in "WorkersSidebarPanel.js"
https://bugs.webkit.org/show_bug.cgi?id=101022

Patch by Peter Wang <peter.wang@torchmobile.com.cn> on 2012-11-02
Reviewed by Yury Semikhatsky.

In "autoattachToWorkersClicked", the "event.target.checked" doesn't alwyas valid, since the
"event.target" might be a label.

The problem just causes an error report, doesn't effect function, so no new test case.

* inspector/front-end/WorkersSidebarPane.js:
(WebInspector.WorkersSidebarPane.prototype._autoattachToWorkersClicked):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCoordinated Graphics: Manage the lifecycle of shareable surfaces precisely.
commit-queue@webkit.org [Fri, 2 Nov 2012 07:22:59 +0000 (07:22 +0000)]
Coordinated Graphics: Manage the lifecycle of shareable surfaces precisely.
https://bugs.webkit.org/show_bug.cgi?id=100797

Patch by Huang Dongsung <luxtella@company100.net> on 2012-11-02
Reviewed by Noam Rosenthal.

Internal Review by Gwang Yoon Hwang and Jae Hyun Park.

This patch makes UpdateAtlas manage the lifecycle of shareable surfaces
containing the updates in the way how CoordinatedTile manages the lifecycle of
tiles. Currently, UI Process creates the shareable surface when receiving an
UpdateTileForLayer message, but there is no exact point to remove the shareable
surface. Now, we introduce new two messages to handle the lifecycle:
CreateUpdateAtlas and RemoveUpdateAtlas.

This patch gives us two benefits.
1. Reduce file and mmap operations. Web Process does not need to duplicate a
file handle every tile update. UI Process does not need to create a
ShareableSurface every UpdateTileForLayer message.
2. Save memory. We can remove a ShareableSurface in UI Process when UpdateAtlas
in Web Process is removed.

* Shared/SurfaceUpdateInfo.cpp:
(WebKit::SurfaceUpdateInfo::encode):
(WebKit::SurfaceUpdateInfo::decode):
* Shared/SurfaceUpdateInfo.h:
(SurfaceUpdateInfo):
* UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.cpp:
(WebKit::LayerTreeCoordinatorProxy::updateTileForLayer):
(WebKit::LayerTreeCoordinatorProxy::createUpdateAtlas):
(WebKit):
(WebKit::LayerTreeCoordinatorProxy::removeUpdateAtlas):
(WebKit::LayerTreeCoordinatorProxy::purgeBackingStores):
* UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.h:
(LayerTreeCoordinatorProxy):
* UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.messages.in:
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::beginContentUpdate):
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:
(CoordinatedGraphicsLayerClient):
(CoordinatedGraphicsLayer):
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedTile.cpp:
(WebKit::CoordinatedTile::updateBackBuffer):
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedTile.h:
(CoordinatedTileClient):
* WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:
(WebKit::LayerTreeCoordinator::createUpdateAtlas):
(WebKit):
(WebKit::LayerTreeCoordinator::removeUpdateAtlas):
(WebKit::LayerTreeCoordinator::beginContentUpdate):
* WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:
(LayerTreeCoordinator):
* WebProcess/WebPage/UpdateAtlas.cpp:
(WebKit::UpdateAtlas::UpdateAtlas):
(WebKit):
(WebKit::UpdateAtlas::~UpdateAtlas):
(WebKit::UpdateAtlas::beginPaintingOnAvailableBuffer):
* WebProcess/WebPage/UpdateAtlas.h:
(UpdateAtlasClient):
(WebKit):
(UpdateAtlas):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL][WK2] Remove redundant internal function
commit-queue@webkit.org [Fri, 2 Nov 2012 07:15:37 +0000 (07:15 +0000)]
[EFL][WK2] Remove redundant internal function
https://bugs.webkit.org/show_bug.cgi?id=100969

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-11-02
Reviewed by Gyuyoung Kim.

Remove ewk_view_text_found() in ewk_view.cpp which is not used anymore.
Now, "text,found" signal is emitted by DECLARE_EWK_VIEW_CALLBACK(TextFound, "text,found", unsigned)
in EwkViewCallback.h

* UIProcess/API/efl/ewk_view.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Shadow] Element should have getter and setter of attribute 'pseudo'
shinyak@chromium.org [Fri, 2 Nov 2012 06:35:27 +0000 (06:35 +0000)]
[Shadow] Element should have getter and setter of attribute 'pseudo'
https://bugs.webkit.org/show_bug.cgi?id=100831

Reviewed by Hajime Morita.

Source/WebCore:

We expose 'pseudo' attribute in Element. When nothing is assigned to 'pseudo', it should return null.

Test: fast/dom/shadow/pseudo-attribute.html

* dom/Element.cpp:
(WebCore::Element::pseudo):
(WebCore):
(WebCore::Element::setPseudo):
* dom/Element.h:
(Element):
* dom/Element.idl:
* html/HTMLAttributeNames.in:

LayoutTests:

* fast/dom/shadow/pseudo-attribute-expected.txt: Added.
* fast/dom/shadow/pseudo-attribute.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL][WK2] Make File Chooser dialog modal in MiniBrowser
commit-queue@webkit.org [Fri, 2 Nov 2012 06:29:05 +0000 (06:29 +0000)]
[EFL][WK2] Make File Chooser dialog modal in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=100962

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-11-01
Reviewed by Gyuyoung Kim.

Make File Chooser dialog modal in MiniBrowser and make
sure it is closed and freed when its parent window is
closed.

* MiniBrowser/efl/main.c:
(close_file_picker):
(on_filepicker_parent_deletion):
(on_file_chooser_request):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL][DRT] Support Geolocation
commit-queue@webkit.org [Fri, 2 Nov 2012 05:54:31 +0000 (05:54 +0000)]
[EFL][DRT] Support Geolocation
https://bugs.webkit.org/show_bug.cgi?id=97427

Source/WebKit:

Patch by Seonae Kim <sunaeluv.kim@samsung.com> on 2012-11-01
Reviewed by Gyuyoung Kim.

Add a mock directory to use GeolocationClientMock in DumpRenderTree.

* PlatformEfl.cmake:

Source/WebKit/efl:

Patch by Seonae Kim <sunaeluv.kim@samsung.com> on 2012-11-01
Reviewed by Gyuyoung Kim.

Implement methods to use GeolocationClientMock in DumpRenderTree.
This client attaches to the page whenever a view is created.

* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::attachClientToPage):
(DumpRenderTreeSupportEfl::resetGeolocationClientMock):
(DumpRenderTreeSupportEfl::setMockGeolocationPermission):
(DumpRenderTreeSupportEfl::setMockGeolocationPosition):
(DumpRenderTreeSupportEfl::setMockGeolocationPositionUnavailableError):
(DumpRenderTreeSupportEfl::numberOfPendingGeolocationPermissionRequests):
* WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

Patch by Seonae Kim <sunaeluv.kim@samsung.com> on 2012-11-01
Reviewed by Gyuyoung Kim.

Implement methods to use GeolocationClientMock in DumpRenderTree.
This client attaches to the page whenever a view is created.

* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::createView):
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):
* DumpRenderTree/efl/TestRunnerEfl.cpp:
(TestRunner::setMockGeolocationPosition):
(TestRunner::setMockGeolocationPositionUnavailableError):
(TestRunner::setGeolocationPermission):
(TestRunner::numberOfPendingGeolocationPermissionRequests):

LayoutTests:

Patch by Seonae Kim <sunaeluv.kim@samsung.com> on 2012-11-01
Reviewed by Gyuyoung Kim.

Change the comment of Geolocation test cases.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoA llint workaround for a toolchain issue.
mark.lam@apple.com [Fri, 2 Nov 2012 04:41:41 +0000 (04:41 +0000)]
A llint workaround for a toolchain issue.
https://bugs.webkit.org/show_bug.cgi?id=101012.

Reviewed by Michael Saboff.

* llint/LowLevelInterpreter.asm:
  - use a local label to workaround the toolchain issue with undeclared
    global labels.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNew image results for compositing tests. Cross-platform image results seem
simon.fraser@apple.com [Fri, 2 Nov 2012 03:09:52 +0000 (03:09 +0000)]
New image results for compositing tests. Cross-platform image results seem
impossible to maintain, so these are all Mac-specific.

* platform/mac/compositing/animation/busy-indicator-expected.png:
* platform/mac/compositing/animation/state-at-end-event-transform-layer-expected.png:
* platform/mac/compositing/color-matching/image-color-matching-expected.png:
* platform/mac/compositing/color-matching/pdf-image-match-expected.png:
* platform/mac/compositing/compositing-visible-descendant-expected.png:
* platform/mac/compositing/direct-image-compositing-expected.png:
* platform/mac/compositing/flat-with-transformed-child-expected.png:
* platform/mac/compositing/framesets/composited-frame-alignment-expected.png:
* platform/mac/compositing/generated-content-expected.png:
* platform/mac/compositing/geometry/abs-position-inside-opacity-expected.png:
* platform/mac/compositing/geometry/clipping-foreground-expected.png:
* platform/mac/compositing/geometry/composited-html-size-expected.png:
* platform/mac/compositing/geometry/fixed-in-composited-expected.png:
* platform/mac/compositing/geometry/fixed-position-composited-page-scale-down-expected.png:
* platform/mac/compositing/geometry/fixed-position-composited-page-scale-expected.png:
* platform/mac/compositing/geometry/fixed-position-expected.png:
* platform/mac/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png:
* platform/mac/compositing/geometry/fixed-position-iframe-composited-page-scale-expected.png:
* platform/mac/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png:
* platform/mac/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png:
* platform/mac/compositing/geometry/foreground-layer-expected.png:
* platform/mac/compositing/geometry/horizontal-scroll-composited-expected.png:
* platform/mac/compositing/geometry/layer-due-to-layer-children-deep-expected.png:
* platform/mac/compositing/geometry/layer-due-to-layer-children-expected.png:
* platform/mac/compositing/geometry/limit-layer-bounds-overflow-repaint-expected.png:
* platform/mac/compositing/geometry/outline-change-expected.png:
* platform/mac/compositing/geometry/partial-layout-update-expected.png:
* platform/mac/compositing/geometry/repaint-foreground-layer-expected.png:
* platform/mac/compositing/geometry/root-layer-update-expected.png:
* platform/mac/compositing/geometry/tall-page-composited-expected.png:
* platform/mac/compositing/geometry/transfrom-origin-on-zero-size-layer-expected.png:
* platform/mac/compositing/geometry/vertical-scroll-composited-expected.png:
* platform/mac/compositing/geometry/video-fixed-scrolling-expected.png:
* platform/mac/compositing/geometry/video-opacity-overlay-expected.png:
* platform/mac/compositing/iframes/composited-iframe-alignment-expected.png:
* platform/mac/compositing/iframes/iframe-copy-on-scroll-expected.png:
* platform/mac/compositing/iframes/iframe-in-composited-layer-expected.png:
* platform/mac/compositing/images/content-image-change-expected.png:
* platform/mac/compositing/images/direct-image-background-color-expected.png:
* platform/mac/compositing/layer-creation/fixed-position-scroll-expected.png:
* platform/mac/compositing/layer-creation/spanOverlapsCanvas-expected.png:
* platform/mac/compositing/layers-inside-overflow-scroll-expected.png:
* platform/mac/compositing/masks/direct-image-mask-expected.png:
* platform/mac/compositing/masks/masked-ancestor-expected.png:
* platform/mac/compositing/masks/multiple-masks-expected.png:
* platform/mac/compositing/masks/simple-composited-mask-expected.png:
* platform/mac/compositing/overflow/ancestor-overflow-expected.png:
* platform/mac/compositing/overflow/fixed-position-ancestor-clip-expected.png:
* platform/mac/compositing/overflow/overflow-compositing-descendant-expected.png:
* platform/mac/compositing/overflow/overflow-positioning-expected.png:
* platform/mac/compositing/overflow/overflow-scaled-descendant-overlapping-expected.png:
* platform/mac/compositing/overflow/overflow-scroll-expected.png:
* platform/mac/compositing/overflow/parent-overflow-expected.png:
* platform/mac/compositing/overflow/scroll-ancestor-update-expected.png:
* platform/mac/compositing/overflow/scrollbar-painting-expected.png:
* platform/mac/compositing/overflow/theme-affects-visual-overflow-expected.png:
* platform/mac/compositing/plugins/composited-plugin-expected.png:
* platform/mac/compositing/reflections/animation-inside-reflection-expected.png:
* platform/mac/compositing/reflections/compositing-change-inside-reflection-expected.png:
* platform/mac/compositing/reflections/deeply-nested-reflections-expected.png:
* platform/mac/compositing/reflections/load-video-in-reflection-expected.png:
* platform/mac/compositing/reflections/masked-reflection-on-composited-expected.png:
* platform/mac/compositing/reflections/nested-reflection-anchor-point-expected.png:
* platform/mac/compositing/reflections/nested-reflection-animated-expected.png:
* platform/mac/compositing/reflections/nested-reflection-expected.png:
* platform/mac/compositing/reflections/nested-reflection-mask-change-expected.png:
* platform/mac/compositing/reflections/nested-reflection-on-overflow-expected.png:
* platform/mac/compositing/reflections/nested-reflection-opacity-expected.png:
* platform/mac/compositing/reflections/nested-reflection-size-change-expected.png:
* platform/mac/compositing/reflections/nested-reflection-transformed-expected.png:
* platform/mac/compositing/reflections/nested-reflection-transformed2-expected.png:
* platform/mac/compositing/reflections/nested-reflection-transition-expected.png:
* platform/mac/compositing/reflections/reflection-in-composited-expected.png:
* platform/mac/compositing/reflections/reflection-on-composited-expected.png:
* platform/mac/compositing/reflections/reflection-opacity-expected.png:
* platform/mac/compositing/reflections/reflection-ordering-expected.png:
* platform/mac/compositing/reflections/reflection-positioning-expected.png:
* platform/mac/compositing/reflections/reflection-positioning2-expected.png:
* platform/mac/compositing/reflections/simple-composited-reflections-expected.png:
* platform/mac/compositing/reflections/transform-inside-reflection-expected.png:
* platform/mac/compositing/repaint/become-overlay-composited-layer-expected.png:
* platform/mac/compositing/repaint/composited-document-element-expected.png:
* platform/mac/compositing/repaint/content-into-overflow-expected.png:
* platform/mac/compositing/repaint/layer-repaint-expected.png:
* platform/mac/compositing/repaint/layer-repaint-rects-expected.png:
* platform/mac/compositing/repaint/opacity-between-absolute-expected.png:
* platform/mac/compositing/repaint/opacity-between-absolute2-expected.png:
* platform/mac/compositing/repaint/overflow-into-content-expected.png:
* platform/mac/compositing/repaint/same-size-invalidation-expected.png:
* platform/mac/compositing/scaling/tiled-layer-recursion-expected.png:
* platform/mac/compositing/self-painting-layers-expected.png:
* platform/mac/compositing/shadows/shadow-drawing-expected.png:
* platform/mac/compositing/sibling-positioning-expected.png:
* platform/mac/compositing/text-on-large-layer-expected.png:
* platform/mac/compositing/transitions/scale-transition-no-start-expected.png:
* platform/mac/compositing/transitions/singular-scale-transition-expected.png:
* platform/mac/compositing/webgl/webgl-background-color-expected.png:
* platform/mac/compositing/webgl/webgl-no-alpha-expected.png:
* platform/mac/compositing/webgl/webgl-reflection-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRebaseline some MathML results, and mark compositing/iframes/overlapped-nested-iframe...
simon.fraser@apple.com [Fri, 2 Nov 2012 03:00:44 +0000 (03:00 +0000)]
Rebaseline some MathML results, and mark compositing/iframes/overlapped-nested-iframes.html
as flakey because it is.

* platform/mac/TestExpectations:
* platform/mac/mathml/presentation/mo-stretch-expected.txt:
* platform/mac/mathml/presentation/row-alignment-expected.png:
* platform/mac/mathml/presentation/row-alignment-expected.txt:
* platform/mac/mathml/presentation/subsup-expected.png:
* platform/mac/mathml/presentation/subsup-expected.txt:
* platform/mac/mathml/presentation/tables-expected.png:
* platform/mac/mathml/presentation/tables-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild fix. http://trac.webkit.org/changeset/133252 broke the Windows build.
roger_fong@apple.com [Fri, 2 Nov 2012 02:53:40 +0000 (02:53 +0000)]
Build fix. trac.webkit.org/changeset/133252 broke the Windows build.
https://bugs.webkit.org/show_bug.cgi?id=101008

Reviewed by fischman@chromium.org.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::clearMediaPlayer):
* html/HTMLMediaElement.h:
(HTMLMediaElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Unreviewed gardening.
senorblanco@chromium.org [Fri, 2 Nov 2012 02:50:19 +0000 (02:50 +0000)]
[Chromium] Unreviewed gardening.

* platform/chromium/TestExpectations:

* platform/chromium-mac-lion/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.png: Added.
* platform/efl-wk1/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.png: Renamed from LayoutTests/platform/efl/svg/dynamic-updates/SVGUseElement-dom-requiredFeatures-expected.png.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove tests no longer needed after r133229.
rniwa@webkit.org [Fri, 2 Nov 2012 02:44:58 +0000 (02:44 +0000)]
Remove tests no longer needed after r133229.

* Scripts/webkitpy/performance_tests/perftest_unittest.py:
(TestPerfTestFactory.test_inspector_test):
* Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(test_collect_tests_with_skipped_list):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed mathml rebaseline.
dbarton@mathscribe.com [Fri, 2 Nov 2012 02:42:12 +0000 (02:42 +0000)]
Unreviewed mathml rebaseline.

* platform/chromium-linux-x86/mathml: Added.
* platform/chromium-linux-x86/mathml/xHeight-expected.png: Added.
* platform/chromium-linux-x86/mathml/xHeight-expected.txt: Added.
* platform/chromium-linux/mathml: Added.
* platform/chromium-linux/mathml/xHeight-expected.png: Added.
* platform/chromium-linux/mathml/xHeight-expected.txt: Added.
* platform/chromium-win-xp/mathml: Added.
* platform/chromium-win-xp/mathml/xHeight-expected.png: Added.
* platform/chromium-win-xp/mathml/xHeight-expected.txt: Added.
* platform/chromium-win/mathml: Added.
* platform/chromium-win/mathml/xHeight-expected.png: Added.
* platform/chromium-win/mathml/xHeight-expected.txt: Added.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r133244.
senorblanco@chromium.org [Fri, 2 Nov 2012 01:59:21 +0000 (01:59 +0000)]
Unreviewed, rolling out r133244.
http://trac.webkit.org/changeset/133244
https://bugs.webkit.org/show_bug.cgi?id=100973

Broke Chromium Mac (clang) builds.

* bindings/v8/DOMDataStore.cpp:
(WebCore::DOMDataStore::DOMDataStore):
* bindings/v8/IntrusiveDOMWrapperMap.h:
(WebCore::DOMNodeWrapperMap::weakCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove GlobalObject constant register that is typically unused
oliver@apple.com [Fri, 2 Nov 2012 01:43:25 +0000 (01:43 +0000)]
Remove GlobalObject constant register that is typically unused
https://bugs.webkit.org/show_bug.cgi?id=101005

Reviewed by Geoffrey Garen.

The GlobalObject constant register is frequently allocated even when it
is not used, it is also getting in the way of some other optimisations.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
* bytecode/CodeBlock.h:
(CodeBlock):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseResolveOperations):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Unreviewed gardening. Mark another flaky test.
senorblanco@chromium.org [Fri, 2 Nov 2012 01:42:16 +0000 (01:42 +0000)]
[Chromium] Unreviewed gardening.  Mark another flaky test.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Simplify the code of returning JSValue in "BlackBerry::WebKit::WebPagePr...
commit-queue@webkit.org [Fri, 2 Nov 2012 01:40:18 +0000 (01:40 +0000)]
[BlackBerry] Simplify the code of returning JSValue in "BlackBerry::WebKit::WebPagePrivate::executeJavaScript"
https://bugs.webkit.org/show_bug.cgi?id=100941

Patch by Peter Wang <peter.wang@torchmobile.com.cn> on 2012-11-01
Reviewed by Yong Li.

Remove the unnecessary steps, just directly deal with returned JSValue.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::executeJavaScript):
(BlackBerry::WebKit::WebPagePrivate::executeJavaScriptInIsolatedWorld):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoHTMLMediaPlayer should free m_player when src is set/changed
fischman@chromium.org [Fri, 2 Nov 2012 01:38:30 +0000 (01:38 +0000)]
HTMLMediaPlayer should free m_player when src is set/changed
https://bugs.webkit.org/show_bug.cgi?id=99647

Reviewed by Eric Carlson.

.:

* ManualTests/media-players-are-dropped-on-error.html: Added.
    Various scenarios are tested to make sure players aren't
    leaked in different ways for each of them.

Source/WebCore:

New ManualTest added; manual since leaking media players doesn't have layoutTestController-visible effects.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::parseAttribute): clearMediaPlayer() when src is set/changed
(WebCore::HTMLMediaElement::userCancelledLoad): use new clearMediaPlayer() helper
(WebCore::HTMLMediaElement::clearMediaPlayer): clear m_player and associated timers/flags
(WebCore):
(WebCore::HTMLMediaElement::createMediaPlayer): whitespace-only change
* html/HTMLMediaElement.h: new method: createMediaPlayer().
(HTMLMediaElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Unreviewed gardening.
senorblanco@chromium.org [Fri, 2 Nov 2012 01:36:33 +0000 (01:36 +0000)]
[Chromium] Unreviewed gardening.

* platform/chromium-win/compositing/geometry/vertical-scroll-composited-expected.png:
* platform/chromium-win/platform/chromium/compositing/huge-layer-rotated-expected.png:
* platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoReformat the annotationStyle initializer to appease update-webkit-localizable-strings.
andersca@apple.com [Fri, 2 Nov 2012 01:23:58 +0000 (01:23 +0000)]
Reformat the annotationStyle initializer to appease update-webkit-localizable-strings.

Rubber-stamped by Dan Bernstein.

* WebProcess/Plugins/PDF/PDFPlugin.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoXSS blocker false positive when page contains <iframe src="">
tsepez@chromium.org [Fri, 2 Nov 2012 01:22:15 +0000 (01:22 +0000)]
XSS blocker false positive when page contains <iframe src="">
https://bugs.webkit.org/show_bug.cgi?id=93416

Reviewed by Adam Barth.

Source/WebCore:

Treat src="" and src="about:blank" as safe resources even if they appear
in the query parameters.

Tests: http/tests/security/xssAuditor/iframe-injection-allowed-2.html
       http/tests/security/xssAuditor/iframe-injection-allowed-3.html
       http/tests/security/xssAuditor/iframe-injection-allowed.html

* html/parser/XSSAuditor.cpp:
(WebCore::XSSAuditor::isLikelySafeResource):

LayoutTests:

* http/tests/security/xssAuditor/iframe-injection-allowed-2-expected.txt: Added.
* http/tests/security/xssAuditor/iframe-injection-allowed-2.html: Added.
* http/tests/security/xssAuditor/iframe-injection-allowed-3-expected.txt: Added.
* http/tests/security/xssAuditor/iframe-injection-allowed-3.html: Added.
* http/tests/security/xssAuditor/iframe-injection-allowed-expected.txt: Added.
* http/tests/security/xssAuditor/iframe-injection-allowed.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix assertion failure in RenderGeometryMap::absoluteRect when frame scale != 1.0
commit-queue@webkit.org [Fri, 2 Nov 2012 01:19:02 +0000 (01:19 +0000)]
Fix assertion failure in RenderGeometryMap::absoluteRect when frame scale != 1.0
https://bugs.webkit.org/show_bug.cgi?id=100912

Patch by Tien-Ren Chen <trchen@chromium.org> on 2012-11-01
Reviewed by Simon Fraser.

Frame scale will add transformation to RenderView, so fixed position doesn't
get propagated up to the viewport by RenderGeometryMap. This is handled
correctly in RenderView::mapLocalToContainer, causing the assertion to fail.
This patch corrects RenderGeometryMap::mapToAbsolute to handle the RenderView
transformation case.

A layout test is added to catch this issue. The test will crash debug build
without this patch.

Source/WebCore:

Test: compositing/geometry/fixed-position-composited-page-scale-scroll.html

* rendering/RenderGeometryMap.cpp:
(WebCore::RenderGeometryMap::mapToAbsolute):

LayoutTests:

* compositing/geometry/fixed-position-composited-page-scale-scroll-expected.txt: Added.
* compositing/geometry/fixed-position-composited-page-scale-scroll.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Add a prompt to enable global location services
commit-queue@webkit.org [Fri, 2 Nov 2012 01:17:27 +0000 (01:17 +0000)]
[BlackBerry] Add a prompt to enable global location services
https://bugs.webkit.org/show_bug.cgi?id=100992

PR 227897

Patch by Otto Derek Cheung <otcheung@rim.com> on 2012-11-01
Reviewed by Rob Buis.

Adding a dialog to let the user know location services isn't enabled.
Currently, the browser app does not check whether the global setting for
location service is enabled. This patch adds a dialog to allow the user
to open the settings app and change that setting. This infobar will only
show once per session. If the user fails to turn on location services after
the first prompt, all geolocation requests will automatically fail.

Also, adapting GeolocationClientBlackBerry to the removal of GeoTracker.
The class now talks directly to the geo handler singleton.

* Api/WebPageClient.h:
* WebCoreSupport/GeolocationClientBlackBerry.cpp:
(GeolocationClientBlackBerry::GeolocationClientBlackBerry):
(GeolocationClientBlackBerry::geolocationDestroyed):
(GeolocationClientBlackBerry::startUpdating):
(GeolocationClientBlackBerry::stopUpdating):
(GeolocationClientBlackBerry::requestPermission):
(GeolocationClientBlackBerry::setEnableHighAccuracy):
* WebCoreSupport/GeolocationClientBlackBerry.h:
(WebCore::GeolocationClientBlackBerry::requiresHighAccuracy):
(GeolocationClientBlackBerry):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Try to find ninja if it's not in the path already
thakis@chromium.org [Fri, 2 Nov 2012 00:59:08 +0000 (00:59 +0000)]
[chromium] Try to find ninja if it's not in the path already
https://bugs.webkit.org/show_bug.cgi?id=100988

Reviewed by Ryosuke Niwa.

Similar to the gclient detection logic in update-webkit-chromium

* Scripts/webkitdirs.pm:
(buildChromiumNinja):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRebaseline tests listed in Mac TestExpectations as needing new baselines, other than...
simon.fraser@apple.com [Fri, 2 Nov 2012 00:41:36 +0000 (00:41 +0000)]
Rebaseline tests listed in Mac TestExpectations as needing new baselines, other than those that
are failing ref tests.

Removed relevant lines from TestExpectations.

Carry along some new image results for the directories which were rebaselined.

Rubber-stamped by Tim Horton

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[V8] Generalize NodeWrapperMap to be able to handle other sorts of keys
abarth@webkit.org [Fri, 2 Nov 2012 00:24:06 +0000 (00:24 +0000)]
[V8] Generalize NodeWrapperMap to be able to handle other sorts of keys
https://bugs.webkit.org/show_bug.cgi?id=100973

Reviewed by Kentaro Hara.

This is the first step towards using intrusive DOM wrapper maps more
widely in WebCore (see
http://lists.webkit.org/pipermail/webkit-dev/2012-November/022686.html
for more context).

* bindings/v8/DOMDataStore.cpp:
(WebCore::DOMDataStore::DOMDataStore):
* bindings/v8/IntrusiveDOMWrapperMap.h:
(WebCore):
(WebCore::IntrusiveDOMWrapperMap::weakCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@133244 268f45cc-cd09-0410-ab3c-d52691b4dbfc