WebKit-https.git
10 years agoReviewed, tweaked, and landed by Anders Carlsson.
andersca@apple.com [Fri, 17 Sep 2010 20:27:44 +0000 (20:27 +0000)]
Reviewed, tweaked, and landed by Anders Carlsson.

Patch by Sam Weinig <sam@webkit.org> on 2010-09-17
Add WKCopyNSURLResponsePeerCertificates.

* WebKitSystemInterface.h:
* libWebKitSystemInterfaceLeopard.a:
* libWebKitSystemInterfaceSnowLeopard.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake WebNumbers immutable matching CF.
weinig@apple.com [Fri, 17 Sep 2010 20:11:26 +0000 (20:11 +0000)]
Make WebNumbers immutable matching CF.

Reviewed by Anders Carlsson.

* Shared/WebNumber.h:
(WebKit::WebNumber::value):
(WebKit::WebNumber::WebNumber):
* UIProcess/API/C/WKNumber.cpp:
(WKUInt64GetValue):
* UIProcess/API/C/WKNumber.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove unimplemented destructor declaration to fix Chromium build.
levin@chromium.org [Fri, 17 Sep 2010 20:04:47 +0000 (20:04 +0000)]
Remove unimplemented destructor declaration to fix Chromium build.
https://bugs.webkit.org/show_bug.cgi?id=45987

Patch by Eric Uhrhane <ericu@chromium.org> on 2010-09-17
Reviewed by David Levin.

* src/AsyncFileWriterChromium.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<http://webkit.org/b/45989> Add WebArchiveInternal.h to Xcode project
ddkilzer@apple.com [Fri, 17 Sep 2010 20:01:10 +0000 (20:01 +0000)]
<webkit.org/b/45989> Add WebArchiveInternal.h to Xcode project

Reviewed by Joseph Pecoraro.

* WebKit.xcodeproj/project.pbxproj: Added missing
WebArchiveInternal.h header file to the project.  It has been
missing since r31281!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd bool wrapper for WebKit2 API
weinig@apple.com [Fri, 17 Sep 2010 19:35:33 +0000 (19:35 +0000)]
Add bool wrapper for WebKit2 API
https://bugs.webkit.org/show_bug.cgi?id=45985

Reviewed by John Sullivan.

* Shared/APIObject.h:
* Shared/WebNumber.h:
* UIProcess/API/C/WKAPICast.h:
* UIProcess/API/C/WKBase.h:
* UIProcess/API/C/WKNumber.cpp:
(WKBooleanGetTypeID):
(WKBooleanCreate):
(WKBooleanGetValue):
(WKBooleanSetValue):
* UIProcess/API/C/WKNumber.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSkip the new test fast/files/create-blob-url-crash.html in unsupported
jianli@chromium.org [Fri, 17 Sep 2010 19:25:08 +0000 (19:25 +0000)]
Skip the new test fast/files/create-blob-url-crash.html in unsupported
platforms.

* platform/gtk/Skipped:
* platform/mac-wk2/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-17 Lucas De Marchi <lucas.demarchi@profusion.mobi>
demarchi@webkit.org [Fri, 17 Sep 2010 19:07:50 +0000 (19:07 +0000)]
2010-09-17  Lucas De Marchi  <lucas.demarchi@profusion.mobi>

        Unreviewed, build fix. Add files missed in r67704.

        * CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-17 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 17 Sep 2010 19:00:03 +0000 (19:00 +0000)]
2010-09-17  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Chris Marrin.

        Remove scroll and clip layers for WKCACFLayerRenderer
        https://bugs.webkit.org/show_bug.cgi?id=45922

        WKCACFLayerRenderer no longer needs its own layers for managing scrolling
        and clipping, because RenderLayerCompositor provides this functionality.

        * platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:
        (WebCore::MediaPlayerPrivateFullscreenWindow::setRootChildLayer): Remove call to setScrollFrame().
        (WebCore::MediaPlayerPrivateFullscreenWindow::wndProc): Ditto.

        * platform/graphics/win/WKCACFLayerRenderer.cpp: Remove references to scroll and clip layers
        (WebCore::WKCACFLayerRenderer::WKCACFLayerRenderer):
        (WebCore::WKCACFLayerRenderer::setRootChildLayer):
        (WebCore::WKCACFLayerRenderer::destroyRenderer):
        (WebCore::WKCACFLayerRenderer::resize):
        * platform/graphics/win/WKCACFLayerRenderer.h:

        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::layerTreeAsText): Dump the layers from the root platform layer.
        (WebCore::RenderLayerCompositor::requiresScrollLayer): On Windows,
        always say yes.

2010-09-17  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Chris Marrin.

        Remove scroll and clip layers for WKCACFLayerRenderer
        https://bugs.webkit.org/show_bug.cgi?id=45922

        WKCACFLayerRenderer no longer needs its own layers for managing scrolling
        and clipping, because RenderLayerCompositor provides this functionality.

        * WebView.cpp:
        (WebView::sizeChanged): Moved code that handles the WM_SIZE message
        into this method. Use it to resize the layer renderer.
        (WebView::WebViewWndProc): Call sizeChanged().
        (WebView::updateRootLayerContents): No need to call setScrollFrame() any more.
        (WebView::layerRendererBecameVisible): Move this from the header (no need to be inline).
        * WebView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agocreateBlobURL with no argument causes crash.
jianli@chromium.org [Fri, 17 Sep 2010 18:59:15 +0000 (18:59 +0000)]
createBlobURL with no argument causes crash.
https://bugs.webkit.org/show_bug.cgi?id=45880

Reviewed by Dmitry Titov.

WebCore:

The fix is to check if the passing blob argument is NULL or not.

Test: fast/files/create-blob-url-crash.html

* dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::createPublicBlobURL):
* page/DOMWindow.idl: Add attribute to convert null string to undefined.

LayoutTests:

* fast/files/create-blob-url-crash-expected.txt: Added.
* fast/files/create-blob-url-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-17 Chris Marrin <cmarrin@apple.com>
cmarrin@apple.com [Fri, 17 Sep 2010 18:35:46 +0000 (18:35 +0000)]
2010-09-17  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Simon Fraser.

        Add WebKitAccelerated2dCanvasEnabled flag to WebKit for Mac
        https://bugs.webkit.org/show_bug.cgi?id=45911

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix the bug number in the ChangeLog.
bweinstein@apple.com [Fri, 17 Sep 2010 18:34:37 +0000 (18:34 +0000)]
Fix the bug number in the ChangeLog.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSkip some userscripts tests that are flaky on Windows (but pass on Mac),
bweinstein@apple.com [Fri, 17 Sep 2010 18:32:40 +0000 (18:32 +0000)]
Skip some userscripts tests that are flaky on Windows (but pass on Mac),
this needs investigation, and is being tracked by <http://webkit.org/b/44199>.

Rubber-stamped by Adam Roben.

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-17 Tony Gentilcore <tonyg@chromium.org>
abarth@webkit.org [Fri, 17 Sep 2010 18:04:20 +0000 (18:04 +0000)]
2010-09-17  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Adam Barth.

        ASSERTION FAILED: m_loadEventDelayCount
        https://bugs.webkit.org/show_bug.cgi?id=45790

        * dom/AsyncScriptRunner.cpp:
        (WebCore::AsyncScriptRunner::timerFired): Protect document before we go running scripts.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-17 Stephen White <senorblanco@chromium.org>
senorblanco@chromium.org [Fri, 17 Sep 2010 18:01:34 +0000 (18:01 +0000)]
2010-09-17  Stephen White  <senorblanco@chromium.org>

        Reviewed by Kenneth Russell.

        [CHROMIUM] GPU-accelerated canvas should work in test_shell.
        https://bugs.webkit.org/show_bug.cgi?id=45968

        In order for the shaders in GPU-accelerated canvas to work in both the
        GraphicsContext3D / GLES2 path as well as chromium's test_shell (which
        passes them to the Mesa backend unmodified), the precision specifiers
        in the fragment shader have to be wrapped in #if GL_ES.

        Soon to be covered by many layout tests.

        * platform/graphics/gpu/SolidFillShader.cpp:
        (WebCore::SolidFillShader::create):
        * platform/graphics/gpu/TexShader.cpp:
        (WebCore::TexShader::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-17 William Siegrist <wsiegrist@apple.com>
wsiegrist@apple.com [Fri, 17 Sep 2010 18:00:08 +0000 (18:00 +0000)]
2010-09-17 William Siegrist <wsiegrist@apple.com>

Replaces branches option with ChangeFilter since branches is now deprecated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-17 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Fri, 17 Sep 2010 17:47:59 +0000 (17:47 +0000)]
2010-09-17  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] [REGRESSION] Listbox rendering is incorrect
        https://bugs.webkit.org/show_bug.cgi?id=45941

        Only apply the shadow tiling optimization to a layer if the GraphicsContext
        has a shadow.

        This is covered by manual-tests/select-element-type-select.html.

        * platform/graphics/cairo/GraphicsContextCairo.cpp:
        (WebCore::drawBorderlessRectShadow): Before applying the tiled shadow optimization
        first check to see if the context has a shadow at all.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-17 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Fri, 17 Sep 2010 17:42:17 +0000 (17:42 +0000)]
2010-09-17  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Oliver Hunt.

        [GTK] FontPlatformDataFreeType should use smart pointers to hold its members
        https://bugs.webkit.org/show_bug.cgi?id=45917

        Added support to PlatformRefPtr for handling HashTableDeletedValue.

        * wtf/PlatformRefPtr.h:
        (WTF::PlatformRefPtr::PlatformRefPtr): Added a constructor that takes HashTableDeletedValue.
        (WTF::PlatformRefPtr::isHashTableDeletedValue): Added.
2010-09-17  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Oliver Hunt.

        [GTK] FontPlatformDataFreeType should use smart pointers to hold its members
        https://bugs.webkit.org/show_bug.cgi?id=45917

        Have FontPlatformDataFreeType use smart pointers to hold its reference-counted
        members. Also move the FcPattern specialization from OwnPtrCairo to PlatformRefPtrCairo
        as this type is reference-counted.

        No new tests as this should not introduce any functionality changes.

        * platform/graphics/cairo/FontCacheFreeType.cpp:
        (WebCore::FontCache::getFontDataForCharacters): Updated to reflect smart pointer changes.
        (WebCore::FontCache::createFontPlatformData): Ditto.
        * platform/graphics/cairo/FontPlatformDataFreeType.cpp:
        (WebCore::FontPlatformData::FontPlatformData): Ditto.
        (WebCore::FontPlatformData::operator=): Ditto.
        (WebCore::FontPlatformData::~FontPlatformData): Ditto.
        (WebCore::FontPlatformData::isFixedPitch): Ditto.
        (WebCore::FontPlatformData::operator==): Ditto.
        * platform/graphics/cairo/FontPlatformDataFreeType.h:
        (WebCore::FontPlatformData::FontPlatformData): Ditto.
        (WebCore::FontPlatformData::scaledFont): Ditto.
        (WebCore::FontPlatformData::hash): Ditto.
        (WebCore::FontPlatformData::isHashTableDeletedValue): Ditto.
        * platform/graphics/cairo/GlyphPageTreeNodeCairo.cpp:
        (WebCore::GlyphPage::fill): Ditto.
        * platform/graphics/cairo/OwnPtrCairo.cpp: Removed FcPattern specialization.
        * platform/graphics/cairo/OwnPtrCairo.h: Ditto.
        * platform/graphics/cairo/PlatformRefPtrCairo.cpp: Added FcPattern and cairo_scaled_font_t specializations.
        (WTF::refPlatformPtr): Ditto.
        (WTF::derefPlatformPtr): Ditto.
        * platform/graphics/cairo/PlatformRefPtrCairo.h: Ditto.
        * platform/graphics/cairo/SimpleFontDataCairo.cpp:
        (WebCore::SimpleFontData::platformInit): Updated to reflect smart pointer changes.
        (WebCore::SimpleFontData::containsCharacters): Ditto.
        (WebCore::SimpleFontData::platformWidthForGlyph): Ditto.
        * platform/graphics/gtk/FontGtk.cpp:
        (WebCore::setPangoAttributes): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoLand new Windows results for fast/forms/file-input-disabled.html
aroben@apple.com [Fri, 17 Sep 2010 17:40:35 +0000 (17:40 +0000)]
Land new Windows results for fast/forms/file-input-disabled.html

This corresponds to the changes made in r64712.

Rubber-stamped by John Sullivan.

* platform/win/fast/forms/file-input-disabled-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-17 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Fri, 17 Sep 2010 17:20:13 +0000 (17:20 +0000)]
2010-09-17  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Oliver Hunt.

        Style bot complains about cairo forward declaration naming
        https://bugs.webkit.org/show_bug.cgi?id=45867

        Exclude Cairo forward declarations from indentifiers with underscores checks.

        * Scripts/webkitpy/style/checkers/cpp.py: Add exclusion for Cairo forward-declarations.
        * Scripts/webkitpy/style/checkers/cpp_unittest.py: Add some tests for this.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-14 Pavel Podivilov <podivilov@chromium.org>
pfeldman@chromium.org [Fri, 17 Sep 2010 17:16:10 +0000 (17:16 +0000)]
2010-09-14  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: show status message below call stack when debugger is paused on DOM breakpoint
        https://bugs.webkit.org/show_bug.cgi?id=45114

        * English.lproj/localizedStrings.js:
        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::performSearch):
        (WebCore::InspectorDOMAgent::shouldBreakOnNodeInsertion):
        (WebCore::InspectorDOMAgent::shouldBreakOnNodeRemoval):
        (WebCore::InspectorDOMAgent::shouldBreakOnAttributeModification):
        (WebCore::InspectorDOMAgent::descriptionForDOMEvent):
        * inspector/InspectorDOMAgent.h:
        * inspector/InspectorDebuggerAgent.cpp:
        (WebCore::InspectorDebuggerAgent::didPause):
        * inspector/front-end/CallStackSidebarPane.js:
        (WebInspector.CallStackSidebarPane):
        (WebInspector.CallStackSidebarPane.prototype.updateStatus.formatters.s):
        (WebInspector.CallStackSidebarPane.prototype.updateStatus.append):
        (WebInspector.CallStackSidebarPane.prototype.updateStatus):
        * inspector/front-end/ElementsPanel.js:
        (WebInspector.ElementsPanel.prototype.linkifyNodeById):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype.debuggerPaused):
        * inspector/front-end/inspector.css:
        (.pane > .body .placard + .info):
        * inspector/front-end/inspector.js:
        (WebInspector.pausedScript):
        (WebInspector.formatLocalized):
2010-09-14  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: show status message below call stack when debugger is paused on DOM breakpoint
        https://bugs.webkit.org/show_bug.cgi?id=45114

        * http/tests/inspector/inspector-test2.js:
        (initialize_InspectorTest.InspectorTest.evaluateInPageWithTimeout):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-16 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Fri, 17 Sep 2010 17:02:56 +0000 (17:02 +0000)]
2010-09-16  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Adam Barth.

        Adding a timeline screenshot for blocking and defer scripts
        https://bugs.webkit.org/show_bug.cgi?id=45933

        * blog-files/timeline-blocking-script.png: Added.
        * blog-files/timeline-defer-script.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-17 Johnny Ding <jnd@chromium.org>
inferno@chromium.org [Fri, 17 Sep 2010 16:36:53 +0000 (16:36 +0000)]
2010-09-17  Johnny Ding  <jnd@chromium.org>

        Reviewed by Adam Barth.

        Stop history reload navigation to bypass WebKit's popup blocker.
        Now history reload can only navigate the page in self frame, no matter
        what target frame is defined in <base> and no new window can be created.
        https://bugs.webkit.org/show_bug.cgi?id=45369

        Test: fast/events/popup-blocked-from-history-reload.html

        * loader/RedirectScheduler.cpp:
        (WebCore::ScheduledNavigation::ScheduledNavigation):
        (WebCore::ScheduledNavigation::wasUserGesture):
        Move the m_wasUserGesture to base class ScheduledNavigation. Then all
        asynchronous navigation situations can restore the correct gesture state
        during the real navigation process.
        (WebCore::ScheduledURLNavigation::ScheduledURLNavigation):
        (WebCore::ScheduledURLNavigation::fire):
        (WebCore::ScheduledURLNavigation::referrer):
        (WebCore::ScheduledHistoryNavigation::ScheduledHistoryNavigation):
        (WebCore::ScheduledHistoryNavigation::fire):
        (WebCore::ScheduledFormSubmission::ScheduledFormSubmission):
        (WebCore::ScheduledFormSubmission::fire):
        (WebCore::RedirectScheduler::scheduleHistoryNavigation):
2010-09-17  Johnny Ding  <jnd@chromium.org>

        Reviewed by Adam Barth.

        Stop history reload navigation to bypass WebKit's popup blocker.
        https://bugs.webkit.org/show_bug.cgi?id=45369

        * fast/events/popup-blocked-from-history-reload-expected.txt: Added.
        * fast/events/popup-blocked-from-history-reload.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-17 Zhenyao Mo <zmo@google.com>
zmo@google.com [Fri, 17 Sep 2010 16:30:52 +0000 (16:30 +0000)]
2010-09-17  Zhenyao Mo  <zmo@google.com>

        Unreviewed.

        Add failing WebGL tests in drt_expectations.txt.

        * platform/chromium/drt_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-16 Vangelis Kokkevis <vangelis@chromium.org>
vangelis@chromium.org [Fri, 17 Sep 2010 16:27:41 +0000 (16:27 +0000)]
2010-09-16  Vangelis Kokkevis  <vangelis@chromium.org>

        Reviewed by James Robinson.

        [chromium] Clip the update region of an ImageLayerChromium to actual size
        of the image bitmap to prevent uninitialized memory access when uploading
        the dirty region to the texture.
        https://bugs.webkit.org/show_bug.cgi?id=45937

        * platform/graphics/chromium/ImageLayerChromium.cpp:
        (WebCore::ImageLayerChromium::updateContents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-17 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Fri, 17 Sep 2010 16:13:52 +0000 (16:13 +0000)]
2010-09-17  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by David Hyatt.

        Remove extraneous RenderObject traversal.
        https://bugs.webkit.org/show_bug.cgi?id=45821

        This code always exits in the first iteration of the loop,
        because in the context of this call, node->renderer()->node() != 0
        is always true.

        No behavior change, covered by existing tests.

        * page/EventHandler.cpp:
        (WebCore::EventHandler::canMouseDownStartSelect): Removed the loop.
        (WebCore::EventHandler::canMouseDragExtendSelect): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-17 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Fri, 17 Sep 2010 16:02:25 +0000 (16:02 +0000)]
2010-09-17  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: FrameLoader::loadedResourceFromMemoryCache reports
        resource as not cached to InspectorController.
        https://bugs.webkit.org/show_bug.cgi?id=45961

        There is one path in control flow that leads to resources being
        reported as not cached. Patch to follow.

        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::markResourceAsCached):
        * inspector/InspectorController.h:
        * inspector/InspectorResource.cpp:
        (WebCore::InspectorResource::markAsCached):
        (WebCore::InspectorResource::updateResponse):
        * inspector/InspectorResource.h:
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::loadedResourceFromMemoryCache):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoLand new Windows results for html5lib/runner.html
aroben@apple.com [Fri, 17 Sep 2010 15:52:52 +0000 (15:52 +0000)]
Land new Windows results for html5lib/runner.html

This corresponds to the changes made in r67233 and r67356.

Rubber-stamped by Anders Carlsson.

* platform/win/html5lib/runner-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd some tests failing due to unimplemented DRT APIs to the Windows Skipped file
aroben@apple.com [Fri, 17 Sep 2010 15:38:03 +0000 (15:38 +0000)]
Add some tests failing due to unimplemented DRT APIs to the Windows Skipped file

* platform/win/Skipped: Added two tests which fail due to
already-known limitations of Windows DRT.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-17 William Siegrist <wsiegrist@apple.com>
wsiegrist@apple.com [Fri, 17 Sep 2010 15:11:49 +0000 (15:11 +0000)]
2010-09-17 William Siegrist <wsiegrist@apple.com>

Remove centering on results directory listing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-17 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Fri, 17 Sep 2010 15:00:19 +0000 (15:00 +0000)]
2010-09-17  Alexander Pavlov  <apavlov@chromium.org>

        Unreviewed, build fix. Add files missed in the previous commit.

        * GNUmakefile.am:
        * css/CSSPropertySourceData.cpp: Added.
        (WebCore::SourceRange::SourceRange):
        (WebCore::SourceRange::operator=):
        (WebCore::CSSPropertySourceData::CSSPropertySourceData):
        (WebCore::CSSPropertySourceData::operator=):
        (WebCore::CSSPropertySourceData::toString):
        (WebCore::CSSPropertySourceData::hash):
        (WebCore::CSSPropertySourceData::init):
        * css/CSSPropertySourceData.h: Added.
        (WebCore::CSSPropertySourceData::~CSSPropertySourceData):
        (WebCore::CSSStyleSourceData::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-15 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Fri, 17 Sep 2010 14:37:27 +0000 (14:37 +0000)]
2010-09-15  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Provide source-based properties for style declarations to CSSParser clients

        This change:
        - Enables InspectorCSSStore to extract CSS stylesheet text for all source-based stylesheets,
          even with the resource tracking turned off.
        - Adds to CSSParser a capability of source-related style declaration data extraction:
          * Start/end source offsets for a declaration, relative to the parent stylesheet start or the "style" attribute value.
          * Start/end source offsets for CSS properties, relative to the declaration start.
          * CSS property data: name, value, priority, WebCore parsability (i.e. if the property is understood by WebCore).
        - Provides the extracted data to the WebInspector frontend via InspectorDOMAgent::getStyleSourceData().
        https://bugs.webkit.org/show_bug.cgi?id=44949

        WebCore:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * css/CSSGrammar.y:
        * css/CSSMutableStyleDeclaration.h:
        (WebCore::CSSMutableStyleDeclaration::node):
        * css/CSSParser.cpp:
        (WebCore::CSSParser::CSSParser):
        (WebCore::CSSParser::parseSheet):
        (WebCore::CSSParser::parseDeclaration):
        (WebCore::CSSParser::createStyleRule):
        (WebCore::CSSParser::markRuleBodyStart):
        (WebCore::CSSParser::markPropertyStart):
        (WebCore::CSSParser::markPropertyEnd):
        * css/CSSParser.h:
        (WebCore::CSSParser::resetPropertyMarks):
        * css/CSSPropertySourceData.cpp: Added.
        (WebCore::SourceRange::SourceRange):
        (WebCore::SourceRange::operator=):
        (WebCore::CSSPropertySourceData::CSSPropertySourceData):
        (WebCore::CSSPropertySourceData::operator=):
        (WebCore::CSSPropertySourceData::toString):
        (WebCore::CSSPropertySourceData::hash):
        (WebCore::CSSPropertySourceData::init):
        * css/CSSPropertySourceData.h: Added.
        (WebCore::CSSPropertySourceData::~CSSPropertySourceData):
        (WebCore::CSSStyleSourceData::create):
        * inspector/Inspector.idl:
        * inspector/InspectorCSSStore.cpp:
        (WebCore::InspectorCSSStore::reset):
        (WebCore::InspectorCSSStore::styleSheetText):
        (WebCore::InspectorCSSStore::resourceStyleSheetText):
        (WebCore::InspectorCSSStore::inlineStyleSheetText):
        (WebCore::InspectorCSSStore::getStyleSourceData):
        (WebCore::InspectorCSSStore::extractRanges):
        (WebCore::InspectorCSSStore::getStyleAttributeRanges):
        (WebCore::InspectorCSSStore::getParentStyleSheet):
        (WebCore::InspectorCSSStore::inlineStyleElement):
        * inspector/InspectorCSSStore.h:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::resourceContentForURL):
        * inspector/InspectorController.h:
        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::getStyleSourceData):
        (WebCore::InspectorDOMAgent::buildObjectForStyle):
        * inspector/InspectorDOMAgent.h:

        LayoutTests:
        * inspector/resources/styles-source-offsets.css:
        (body):
        (/* comment before selector */body.main1/* comment after selector */):
        (body.main2):
        * inspector/styles-source-offsets-expected.txt:
        * inspector/styles-source-offsets.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-17 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Fri, 17 Sep 2010 13:36:59 +0000 (13:36 +0000)]
2010-09-17  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Show node description in inspector highlight
        https://bugs.webkit.org/show_bug.cgi?id=20930

        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::drawNodeHighlight):
        (WebCore::InspectorController::drawElementTitle):
        * inspector/InspectorController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-17 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Fri, 17 Sep 2010 13:06:06 +0000 (13:06 +0000)]
2010-09-17  Alejandro G. Castro  <alex@igalia.com>

        Unreviewed, GTK+ rebaselines.

        * platform/gtk/fast/repaint/multicol-repaint-expected.txt:
        * platform/gtk/svg/css/getComputedStyle-basic-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-17 Satish Sampath <satish@chromium.org>
satish@chromium.org [Fri, 17 Sep 2010 11:09:53 +0000 (11:09 +0000)]
2010-09-17  Satish Sampath  <satish@chromium.org>

        Unreviewed, updated chromium baselines and disabled a failing test.

        * platform/chromium-linux/fast/css/getComputedStyle/computed-style-expected.txt
        * platform/chromium-linux/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt
        * platform/chromium-linux/svg/css/getComputedStyle-basic-expected.txt
        * platform/chromium-mac/fast/css/getComputedStyle/computed-style-expected.txt
        * platform/chromium-mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt
        * platform/chromium-mac/svg/css/getComputedStyle-basic-expected.txt
        * platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt
        * platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt
        * platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt
        * platform/chromium/test_expectations.txt

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebKit should use system wide spell checking preference when application specific...
mitz@apple.com [Fri, 17 Sep 2010 07:20:19 +0000 (07:20 +0000)]
WebKit should use system wide spell checking preference when application specific one isn't set.
https://bugs.webkit.org/show_bug.cgi?id=45789
<rdar://problem/8416041>

Patch by Jia Pu <jpu@apple.com> on 2010-09-17
Reviewed by Dan Bernstein.

* WebView/WebView.mm:
(+[WebView initialize]): Use system wide autocorrection and text substitution preferences
  when the application level preferences are not set.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-16 takano takumi <takano1@asia.apple.com>
tkent@chromium.org [Fri, 17 Sep 2010 06:20:48 +0000 (06:20 +0000)]
2010-09-16  takano takumi  <takano1@asia.apple.com>

        Reviewed by Kent Tamura.

        https://bugs.webkit.org/show_bug.cgi?id=45020
        Support "block-flow" and "writing-mode": interpret properties into RenderStyle

        Fixed a regression in SVG test introduced by my previous change.

        * css/CSSPrimitiveValueMappings.h:
        (WebCore::CSSPrimitiveValue::operator EWritingMode):
        * css/SVGCSSParser.cpp:
        (WebCore::CSSParser::parseSVGValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-16 Sheriff Bot <webkit.review.bot@gmail.com>
dumi@chromium.org [Fri, 17 Sep 2010 05:26:57 +0000 (05:26 +0000)]
2010-09-16  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r67693.
        http://trac.webkit.org/changeset/67693
        https://bugs.webkit.org/show_bug.cgi?id=45946

        "Need to pick up a chromium change first" (Requested by dumi
        on #webkit).

        * public/WebHTTPBody.h:
        * src/WebHTTPBody.cpp:
        (WebKit::WebHTTPBody::elementAt):
        (WebKit::WebHTTPBody::appendFileRange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove WebHTTPBody::appendFileRange(..., const WebFileInfo&).
dumi@chromium.org [Fri, 17 Sep 2010 04:56:00 +0000 (04:56 +0000)]
Remove WebHTTPBody::appendFileRange(..., const WebFileInfo&).

Reviewed by Darin Fisher.

* public/WebHTTPBody.h:
* src/WebHTTPBody.cpp:
(WebKit::WebHTTPBody::elementAt):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-16 Kinuko Yasuda <kinuko@chromium.org>
kinuko@chromium.org [Fri, 17 Sep 2010 04:30:24 +0000 (04:30 +0000)]
2010-09-16  Kinuko Yasuda  <kinuko@chromium.org>

        Reviewed by Ojan Vafai.

        Include detailed test modifiers (e.g. FLAKY) in results.json for failing non-layout tests
        https://bugs.webkit.org/show_bug.cgi?id=45408

        This change also tries to remove duplicated upload_results_json methods
        in run_webkit_tests.py and json_results_generator.py.

        * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
        * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/8395558>
sullivan@apple.com [Fri, 17 Sep 2010 04:05:37 +0000 (04:05 +0000)]
<rdar://problem/8395558>
https://bugs.webkit.org/show_bug.cgi?id=45938
_web_makePluginViewsPerformSelector:: mutates subviews array while iterating it

Reviewed by Darin Adler.

* WebView/WebHTMLView.mm:
(-[WebHTMLView _web_makePluginSubviewsPerformSelector:withObject:]):
Converted from -[NSArray _web_makePluginViewsPerformSelector:withObject:]. The old method
was only ever called on the result of -[WebHTMLView subviews]. By moving that knowledge into
this helper method, it can't be used incorrectly. Now it makes a copy of [WebHTMLView subviews]
before enumerating it, to ensure that the selector can't mutate the array being enumerated.
(-[WebHTMLView viewWillMoveToHostWindow:]):
Updated for _web_makePluginSubviewsPerformSelector:: signature change.
(-[WebHTMLView viewDidMoveToHostWindow]):
Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-16 Kenneth Russell <kbr@google.com>
kbr@google.com [Fri, 17 Sep 2010 01:53:40 +0000 (01:53 +0000)]
2010-09-16  Kenneth Russell  <kbr@google.com>

        Reviewed by James Robinson.

        Add entry points to GraphicsContext3D needed for Chromium compositor port
        https://bugs.webkit.org/show_bug.cgi?id=45939

        Added entry points for two Chromium-specific extensions, and added
        a flag to the GraphicsContext3D constructor, currently unsupported
        by all ports (including Chromium), indicating whether the context
        should render directly to the passed HostWindow or off-screen per
        the current semantics. The switch to use GraphicsContext3D in
        Chromium's compositor will follow in a subsequent patch.

        No new tests; functionality is unchanged. Built and tested
        Chromium and WebKit on Mac OS X.

        * src/GraphicsContext3D.cpp:
        (WebCore::GraphicsContext3D::GraphicsContext3D):
        (WebCore::GraphicsContext3D::create):
        * src/GraphicsContext3DInternal.h:
2010-09-16  Kenneth Russell  <kbr@google.com>

        Reviewed by James Robinson.

        Add entry points to GraphicsContext3D needed for Chromium compositor port
        https://bugs.webkit.org/show_bug.cgi?id=45939

        Added entry points for two Chromium-specific extensions, and added
        a flag to the GraphicsContext3D constructor, currently unsupported
        by all ports (including Chromium), indicating whether the context
        should render directly to the passed HostWindow or off-screen per
        the current semantics. The switch to use GraphicsContext3D in
        Chromium's compositor will follow in a subsequent patch.

        No new tests; functionality is unchanged. Built and tested
        Chromium and WebKit on Mac OS X.

        * platform/graphics/GraphicsContext3D.cpp:
        (WebCore::GraphicsContext3D::supportsMapSubCHROMIUM):
        (WebCore::GraphicsContext3D::mapBufferSubDataCHROMIUM):
        (WebCore::GraphicsContext3D::unmapBufferSubDataCHROMIUM):
        (WebCore::GraphicsContext3D::mapTexSubImage2DCHROMIUM):
        (WebCore::GraphicsContext3D::unmapTexSubImage2DCHROMIUM):
        (WebCore::GraphicsContext3D::supportsCopyTextureToParentTextureCHROMIUM):
        (WebCore::GraphicsContext3D::copyTextureToParentTextureCHROMIUM):
        * platform/graphics/GraphicsContext3D.h:
        * platform/graphics/mac/GraphicsContext3DMac.mm:
        (WebCore::GraphicsContext3D::create):
        (WebCore::GraphicsContext3D::GraphicsContext3D):
        * platform/graphics/qt/GraphicsContext3DQt.cpp:
        (WebCore::GraphicsContext3D::create):
        (WebCore::GraphicsContext3D::GraphicsContext3D):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-16 Antonio Gomes <tonikitoo@webkit.org>
tonikitoo@webkit.org [Fri, 17 Sep 2010 01:34:20 +0000 (01:34 +0000)]
2010-09-16  Antonio Gomes  <tonikitoo@webkit.org>

        Reviewed by Andreas Kling.

        [Qt] When switching views (WebViewGraphicsBased <--> WebViewTraditional), QWebPage signals and QActions have to be re-set.

        Recently r67554 changed the way different views use the WebPage class: it was previously being shared between
        different views, but now for each view switch, a new WebPage class is constructed and set. Signals and QAction's
        were not being set to the new WebPage though. Patch fix that, by re constructing the toolbar, and then re-hooking
        all page specific stuff to the UI.

        * QtTestBrowser/launcherwindow.cpp:
        (LauncherWindow::initializeView):
        * QtTestBrowser/mainwindow.cpp:
        (MainWindow::MainWindow):
        (MainWindow::buildUI):
        (MainWindow::setPage):
        * QtTestBrowser/mainwindow.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-12 Antonio Gomes <tonikitoo@webkit.org>
tonikitoo@webkit.org [Fri, 17 Sep 2010 01:33:44 +0000 (01:33 +0000)]
2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>

        Reviewed by Andreas Kling.

        Make all accesses to m_item (GraphicsWebView) done by WebViewGraphicsBased class happen though graphicsWebView getter method.

        This patch is mostly a preparation for another commit, where the ownership of the m_item/GraphicsWebView
        object will move to the qgraphicsscene instead of the qgraphicsview.

        * QtTestBrowser/webview.cpp:
        (WebViewGraphicsBased::setPage):
        (WebViewGraphicsBased::setResizesToContents):
        (WebViewGraphicsBased::resizeEvent):
        (WebViewGraphicsBased::animatedFlip):
        * QtTestBrowser/webview.h:
        (WebViewGraphicsBased::setItemCacheMode):
        (WebViewGraphicsBased::itemCacheMode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-12 Antonio Gomes <tonikitoo@webkit.org>
tonikitoo@webkit.org [Fri, 17 Sep 2010 01:32:42 +0000 (01:32 +0000)]
2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>

        Reviewed by Andreas Kling.

        Moved setYRotation method body out of the class (WebViewGraphicsBased) definition.

        We usually separate methods whose body are larger the a few lines from the class definition.

        * QtTestBrowser/webview.h:
        (WebViewGraphicsBased::yRotation):
        (WebViewGraphicsBased::setYRotation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-12 Antonio Gomes <tonikitoo@webkit.org>
tonikitoo@webkit.org [Fri, 17 Sep 2010 01:32:12 +0000 (01:32 +0000)]
2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>

        Reviewed by Andreas Kling.

        Make initializeView method of LauncherWindow private.

        No one else needs to be able to call it but LauncherWindow.
        Also moving the declation of isGraphicsBased method down in the same file, in order
        to better group related methods.

        * QtTestBrowser/launcherwindow.h:

* QtTestBrowser/launcherwindow.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-12 Antonio Gomes <tonikitoo@webkit.org>
tonikitoo@webkit.org [Fri, 17 Sep 2010 01:31:51 +0000 (01:31 +0000)]
2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>

        Reviewed by Andreas Kling.

        Make the getter 'page' method of MainWindow const.

        * QtTestBrowser/mainwindow.cpp:
        (MainWindow::page):
        * QtTestBrowser/mainwindow.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-12 Antonio Gomes <tonikitoo@webkit.org>
tonikitoo@webkit.org [Fri, 17 Sep 2010 01:31:34 +0000 (01:31 +0000)]
2010-09-12  Antonio Gomes  <tonikitoo@webkit.org>

        Reviewed by Andreas Kling.

        Remove useless parameter from MainWindow class' constructor.

        The parameter defaults to an empty URL and is not being used by any caller. Apart from that
        and is also not referred in the constructor body and does not make much sense.

        * QtTestBrowser/mainwindow.cpp:
        (MainWindow::MainWindow):
        * QtTestBrowser/mainwindow.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-16 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Fri, 17 Sep 2010 01:18:30 +0000 (01:18 +0000)]
2010-09-16  Oliver Hunt  <oliver@apple.com>

        Reviewed by Geoffrey Garen.

        Crash due to timer triggered GC on one heap while another heap is active
        https://bugs.webkit.org/show_bug.cgi?id=45932
        <rdar://problem/8318446>

        The GC timer may trigger for one heap while another heap is active.  This
        is safe, but requires us to ensure that we have temporarily associated the
        thread's identifierTable with the heap we're collecting on.  Otherwise we
        may end up with the identifier tables in an inconsistent state leading to
        an eventual crash.

        * runtime/Collector.cpp:
        (JSC::Heap::allocate):
        (JSC::Heap::reset):
        (JSC::Heap::collectAllGarbage):
           Add assertions to ensure we have the correct identifierTable active
           while collecting.
        * runtime/GCActivityCallbackCF.cpp:
        (JSC::DefaultGCActivityCallbackPlatformData::trigger):
           Temporarily make the expected IdentifierTable active
        * wtf/WTFThreadData.h:
        (JSC::IdentifierTable::remove):
           Make it possible to see when IdentifierTable::remove has succeeded
        * wtf/text/StringImpl.cpp:
        (WTF::StringImpl::~StringImpl):
           CRASH if an StringImpl is an Identifier but isn't present in the
           active IdentifierTable.  If we get to this state something has
           gone wrong and we should just crash immediately.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-16 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 17 Sep 2010 01:04:46 +0000 (01:04 +0000)]
2010-09-16  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by James Robinson.

        In layerTreeAsText output, avoid printing properties which have their default values
        https://bugs.webkit.org/show_bug.cgi?id=45931

        Don't dump properties that have their default values to simplify output.

        * platform/graphics/GraphicsLayer.cpp:
        (WebCore::GraphicsLayer::dumpProperties):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-16 John Gregg <johnnyg@google.com>
johnnyg@google.com [Fri, 17 Sep 2010 00:55:13 +0000 (00:55 +0000)]
2010-09-16  John Gregg  <johnnyg@google.com>

        Unreviewed, chromium rebaselines.

        [chromium] Rebaseline multicol tests
        https://bugs.webkit.org/show_bug.cgi?id=45936

        * platform/chromium-linux/fast/multicol/border-padding-pagination-expected.checksum: Added.
        * platform/chromium-linux/fast/multicol/border-padding-pagination-expected.txt: Added.
        * platform/chromium-linux/fast/multicol/client-rects-expected.checksum:
        * platform/chromium-linux/fast/multicol/client-rects-expected.png:
        * platform/chromium-linux/fast/multicol/client-rects-expected.txt: Added.
        * platform/chromium-linux/fast/multicol/column-break-with-balancing-expected.checksum: Added.
        * platform/chromium-linux/fast/multicol/column-break-with-balancing-expected.png: Added.
        * platform/chromium-linux/fast/multicol/column-break-with-balancing-expected.txt: Added.
        * platform/chromium-linux/fast/multicol/column-count-with-rules-expected.checksum:
        * platform/chromium-linux/fast/multicol/column-count-with-rules-expected.png:
        * platform/chromium-linux/fast/multicol/column-rules-expected.checksum:
        * platform/chromium-linux/fast/multicol/column-rules-expected.png:
        * platform/chromium-linux/fast/multicol/column-rules-expected.txt: Added.
        * platform/chromium-linux/fast/multicol/float-avoidance-expected.checksum:
        * platform/chromium-linux/fast/multicol/float-avoidance-expected.png:
        * platform/chromium-linux/fast/multicol/float-avoidance-expected.txt: Added.
        * platform/chromium-linux/fast/multicol/float-multicol-expected.checksum:
        * platform/chromium-linux/fast/multicol/float-multicol-expected.png:
        * platform/chromium-linux/fast/multicol/float-multicol-expected.txt: Added.
        * platform/chromium-linux/fast/multicol/float-paginate-complex-expected.checksum: Added.
        * platform/chromium-linux/fast/multicol/float-paginate-complex-expected.png: Added.
        * platform/chromium-linux/fast/multicol/float-paginate-complex-expected.txt: Added.
        * platform/chromium-linux/fast/multicol/float-paginate-expected.txt:
        * platform/chromium-linux/fast/multicol/layers-in-multicol-expected.checksum:
        * platform/chromium-linux/fast/multicol/layers-in-multicol-expected.png:
        * platform/chromium-linux/fast/multicol/layers-in-multicol-expected.txt: Added.
        * platform/chromium-linux/fast/multicol/margin-collapse-expected.checksum: Added.
        * platform/chromium-linux/fast/multicol/margin-collapse-expected.txt: Added.
        * platform/chromium-linux/fast/multicol/max-height-columns-block-expected.checksum: Added.
        * platform/chromium-linux/fast/multicol/max-height-columns-block-expected.png: Added.
        * platform/chromium-linux/fast/multicol/max-height-columns-block-expected.txt: Added.
        * platform/chromium-linux/fast/multicol/nested-columns-expected.checksum:
        * platform/chromium-linux/fast/multicol/nested-columns-expected.png:
        * platform/chromium-linux/fast/multicol/nested-columns-expected.txt: Added.
        * platform/chromium-linux/fast/multicol/paginate-block-replaced-expected.txt:
        * platform/chromium-linux/fast/multicol/positioned-split-expected.checksum: Added.
        * platform/chromium-linux/fast/multicol/positioned-split-expected.png: Added.
        * platform/chromium-linux/fast/multicol/positioned-split-expected.txt: Added.
        * platform/chromium-linux/fast/multicol/shadow-breaking-expected.checksum: Added.
        * platform/chromium-linux/fast/multicol/shadow-breaking-expected.txt: Added.
        * platform/chromium-linux/fast/multicol/single-line-expected.checksum:
        * platform/chromium-linux/fast/multicol/single-line-expected.png:
        * platform/chromium-linux/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.checksum:
        * platform/chromium-linux/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.png:
        * platform/chromium-linux/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt: Added.
        * platform/chromium-linux/fast/multicol/span/span-as-immediate-child-generated-content-expected.checksum:
        * platform/chromium-linux/fast/multicol/span/span-as-immediate-child-generated-content-expected.png:
        * platform/chromium-linux/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt: Added.
        * platform/chromium-linux/fast/multicol/span/span-as-immediate-child-property-removal-expected.checksum:
        * platform/chromium-linux/fast/multicol/span/span-as-immediate-child-property-removal-expected.png:
        * platform/chromium-linux/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt: Added.
        * platform/chromium-linux/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.checksum:
        * platform/chromium-linux/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.png:
        * platform/chromium-linux/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt: Added.
        * platform/chromium-linux/fast/multicol/span/span-as-immediate-columns-child-expected.txt: Added.
        * platform/chromium-linux/fast/multicol/span/span-as-immediate-columns-child-removal-expected.checksum:
        * platform/chromium-linux/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png:
        * platform/chromium-linux/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt: Added.
        * platform/chromium-linux/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.checksum:
        * platform/chromium-linux/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png:
        * platform/chromium-linux/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt: Added.
        * platform/chromium-linux/fast/multicol/span/span-as-nested-columns-child-expected.checksum:
        * platform/chromium-linux/fast/multicol/span/span-as-nested-columns-child-expected.png:
        * platform/chromium-linux/fast/multicol/span/span-as-nested-columns-child-expected.txt: Added.
        * platform/chromium-linux/fast/multicol/table-margin-collapse-expected.checksum: Added.
        * platform/chromium-linux/fast/multicol/table-margin-collapse-expected.png: Added.
        * platform/chromium-linux/fast/multicol/table-margin-collapse-expected.txt: Added.
        * platform/chromium-linux/fast/multicol/table-vertical-align-expected.checksum: Added.
        * platform/chromium-linux/fast/multicol/table-vertical-align-expected.png: Added.
        * platform/chromium-linux/fast/multicol/table-vertical-align-expected.txt: Added.
        * platform/chromium-linux/fast/multicol/unsplittable-inline-block-expected.checksum: Added.
        * platform/chromium-linux/fast/multicol/unsplittable-inline-block-expected.png: Added.
        * platform/chromium-linux/fast/multicol/unsplittable-inline-block-expected.txt: Added.
        * platform/chromium-linux/fast/repaint/multicol-repaint-expected.txt:
        * platform/chromium-mac/fast/multicol/client-rects-expected.checksum:
        * platform/chromium-mac/fast/multicol/client-rects-expected.png: Removed.
        * platform/chromium-mac/fast/multicol/column-break-with-balancing-expected.checksum: Added.
        * platform/chromium-mac/fast/multicol/column-break-with-balancing-expected.png: Added.
        * platform/chromium-mac/fast/multicol/column-rules-expected.checksum: Added.
        * platform/chromium-mac/fast/multicol/column-rules-expected.png: Added.
        * platform/chromium-mac/fast/multicol/float-avoidance-expected.checksum:
        * platform/chromium-mac/fast/multicol/float-multicol-expected.checksum: Added.
        * platform/chromium-mac/fast/multicol/float-multicol-expected.png: Added.
        * platform/chromium-mac/fast/multicol/float-paginate-complex-expected.checksum: Added.
        * platform/chromium-mac/fast/multicol/float-paginate-complex-expected.png: Added.
        * platform/chromium-mac/fast/multicol/float-paginate-expected.checksum: Added.
        * platform/chromium-mac/fast/multicol/float-paginate-expected.png: Added.
        * platform/chromium-mac/fast/multicol/layers-in-multicol-expected.checksum:
        * platform/chromium-mac/fast/multicol/layers-in-multicol-expected.png: Added.
        * platform/chromium-mac/fast/multicol/margin-collapse-expected.checksum: Added.
        * platform/chromium-mac/fast/multicol/max-height-columns-block-expected.checksum: Added.
        * platform/chromium-mac/fast/multicol/nested-columns-expected.checksum: Added.
        * platform/chromium-mac/fast/multicol/paginate-block-replaced-expected.checksum: Added.
        * platform/chromium-mac/fast/multicol/positioned-split-expected.checksum: Added.
        * platform/chromium-mac/fast/multicol/shadow-breaking-expected.checksum: Added.
        * platform/chromium-mac/fast/multicol/single-line-expected.checksum: Added.
        * platform/chromium-mac/fast/multicol/span/span-as-immediate-child-generated-content-expected.checksum:
        * platform/chromium-mac/fast/multicol/span/span-as-immediate-child-generated-content-expected.png:
        * platform/chromium-mac/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt: Added.
        * platform/chromium-mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.checksum:
        * platform/chromium-mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.png:
        * platform/chromium-mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt: Added.
        * platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt: Added.
        * platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-expected.checksum:
        * platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-expected.png: Removed.
        * platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-expected.txt: Added.
        * platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-removal-expected.checksum:
        * platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png: Removed.
        * platform/chromium-mac/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt: Added.
        * platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.checksum:
        * platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png:
        * platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-expected.checksum:
        * platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-expected.png:
        * platform/chromium-mac/fast/multicol/span/span-as-nested-columns-child-expected.txt: Removed.
        * platform/chromium-mac/fast/multicol/table-margin-collapse-expected.checksum: Added.
        * platform/chromium-mac/fast/multicol/table-vertical-align-expected.checksum: Added.
        * platform/chromium-mac/fast/multicol/table-vertical-align-expected.png: Added.
        * platform/chromium-mac/fast/multicol/unsplittable-inline-block-expected.checksum: Added.
        * platform/chromium-mac/fast/repaint/multicol-repaint-expected.checksum:
        * platform/chromium-mac/fast/repaint/multicol-repaint-expected.png:
        * platform/chromium-win/fast/multicol/border-padding-pagination-expected.checksum: Added.
        * platform/chromium-win/fast/multicol/border-padding-pagination-expected.png: Added.
        * platform/chromium-win/fast/multicol/border-padding-pagination-expected.txt: Added.
        * platform/chromium-win/fast/multicol/client-rects-expected.checksum:
        * platform/chromium-win/fast/multicol/client-rects-expected.png:
        * platform/chromium-win/fast/multicol/client-rects-expected.txt:
        * platform/chromium-win/fast/multicol/column-break-with-balancing-expected.checksum: Added.
        * platform/chromium-win/fast/multicol/column-break-with-balancing-expected.png: Added.
        * platform/chromium-win/fast/multicol/column-break-with-balancing-expected.txt: Added.
        * platform/chromium-win/fast/multicol/column-count-with-rules-expected.checksum:
        * platform/chromium-win/fast/multicol/column-count-with-rules-expected.png:
        * platform/chromium-win/fast/multicol/column-rules-expected.checksum:
        * platform/chromium-win/fast/multicol/column-rules-expected.png:
        * platform/chromium-win/fast/multicol/column-rules-expected.txt:
        * platform/chromium-win/fast/multicol/float-avoidance-expected.checksum:
        * platform/chromium-win/fast/multicol/float-avoidance-expected.png:
        * platform/chromium-win/fast/multicol/float-avoidance-expected.txt:
        * platform/chromium-win/fast/multicol/float-multicol-expected.checksum:
        * platform/chromium-win/fast/multicol/float-multicol-expected.png:
        * platform/chromium-win/fast/multicol/float-multicol-expected.txt:
        * platform/chromium-win/fast/multicol/float-paginate-complex-expected.checksum: Added.
        * platform/chromium-win/fast/multicol/float-paginate-complex-expected.png: Added.
        * platform/chromium-win/fast/multicol/float-paginate-complex-expected.txt: Added.
        * platform/chromium-win/fast/multicol/float-paginate-expected.txt:
        * platform/chromium-win/fast/multicol/layers-in-multicol-expected.checksum:
        * platform/chromium-win/fast/multicol/layers-in-multicol-expected.png:
        * platform/chromium-win/fast/multicol/layers-in-multicol-expected.txt:
        * platform/chromium-win/fast/multicol/margin-collapse-expected.checksum: Added.
        * platform/chromium-win/fast/multicol/margin-collapse-expected.png: Added.
        * platform/chromium-win/fast/multicol/margin-collapse-expected.txt: Added.
        * platform/chromium-win/fast/multicol/max-height-columns-block-expected.checksum: Added.
        * platform/chromium-win/fast/multicol/max-height-columns-block-expected.png: Added.
        * platform/chromium-win/fast/multicol/max-height-columns-block-expected.txt: Added.
        * platform/chromium-win/fast/multicol/nested-columns-expected.checksum:
        * platform/chromium-win/fast/multicol/nested-columns-expected.png:
        * platform/chromium-win/fast/multicol/nested-columns-expected.txt:
        * platform/chromium-win/fast/multicol/paginate-block-replaced-expected.txt:
        * platform/chromium-win/fast/multicol/positioned-split-expected.checksum: Added.
        * platform/chromium-win/fast/multicol/positioned-split-expected.png: Added.
        * platform/chromium-win/fast/multicol/positioned-split-expected.txt: Added.
        * platform/chromium-win/fast/multicol/shadow-breaking-expected.checksum: Added.
        * platform/chromium-win/fast/multicol/shadow-breaking-expected.png: Added.
        * platform/chromium-win/fast/multicol/shadow-breaking-expected.txt: Added.
        * platform/chromium-win/fast/multicol/single-line-expected.checksum:
        * platform/chromium-win/fast/multicol/single-line-expected.png:
        * platform/chromium-win/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.checksum:
        * platform/chromium-win/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.png:
        * platform/chromium-win/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt:
        * platform/chromium-win/fast/multicol/span/span-as-immediate-child-generated-content-expected.checksum:
        * platform/chromium-win/fast/multicol/span/span-as-immediate-child-generated-content-expected.png:
        * platform/chromium-win/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt:
        * platform/chromium-win/fast/multicol/span/span-as-immediate-child-property-removal-expected.checksum:
        * platform/chromium-win/fast/multicol/span/span-as-immediate-child-property-removal-expected.png:
        * platform/chromium-win/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
        * platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt:
        * platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-expected.txt:
        * platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-removal-expected.checksum:
        * platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-removal-expected.png:
        * platform/chromium-win/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt:
        * platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.checksum:
        * platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png:
        * platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt:
        * platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-expected.checksum:
        * platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-expected.png:
        * platform/chromium-win/fast/multicol/span/span-as-nested-columns-child-expected.txt:
        * platform/chromium-win/fast/multicol/table-margin-collapse-expected.checksum: Added.
        * platform/chromium-win/fast/multicol/table-margin-collapse-expected.png: Added.
        * platform/chromium-win/fast/multicol/table-margin-collapse-expected.txt: Added.
        * platform/chromium-win/fast/multicol/table-vertical-align-expected.checksum: Added.
        * platform/chromium-win/fast/multicol/table-vertical-align-expected.png: Added.
        * platform/chromium-win/fast/multicol/table-vertical-align-expected.txt: Added.
        * platform/chromium-win/fast/multicol/unsplittable-inline-block-expected.checksum: Added.
        * platform/chromium-win/fast/multicol/unsplittable-inline-block-expected.png: Added.
        * platform/chromium-win/fast/multicol/unsplittable-inline-block-expected.txt: Added.
        * platform/chromium-win/fast/repaint/multicol-repaint-expected.checksum:
        * platform/chromium-win/fast/repaint/multicol-repaint-expected.png:
        * platform/chromium-win/fast/repaint/multicol-repaint-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdate Windows-specific results to getComputedStyle tests after r67667.
bweinstein@apple.com [Fri, 17 Sep 2010 00:35:47 +0000 (00:35 +0000)]
Update Windows-specific results to getComputedStyle tests after r67667.

Rubber-stamped by Jon Honeycutt.

* platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-16 Andreas Kling <andreas.kling@nokia.com>
andreas.kling@nokia.com [Thu, 16 Sep 2010 23:34:50 +0000 (23:34 +0000)]
2010-09-16  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Ariya Hidayat.

        [Qt] GraphicsContext: Remove unused variable

        GraphicsContextPlatformPrivate::redirect wasn't used for anything.

        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContextPlatformPrivate::p):
        (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-16 Tony Chang <tony@chromium.org>
tony@chromium.org [Thu, 16 Sep 2010 23:15:53 +0000 (23:15 +0000)]
2010-09-16  Tony Chang  <tony@chromium.org>

        Reviewed by Ojan Vafai.

        convert fast/events/5056619.html to a dump-as-markup test
        https://bugs.webkit.org/show_bug.cgi?id=45907

        * fast/events/5056619.html:
        * platform/chromium-linux/fast/events/5056619-expected.checksum: Removed.
        * platform/chromium-linux/fast/events/5056619-expected.png: Removed.
        * platform/chromium-win/fast/events/5056619-expected.checksum: Removed.
        * platform/chromium-win/fast/events/5056619-expected.png: Removed.
        * platform/chromium-win/fast/events/5056619-expected.txt: Removed.
        * platform/chromium/test_expectations.txt:
        * platform/mac/fast/events/5056619-expected.checksum: Removed.
        * platform/mac/fast/events/5056619-expected.png: Removed.
        * platform/mac/fast/events/5056619-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-16 Kenneth Russell <kbr@google.com>
kbr@google.com [Thu, 16 Sep 2010 23:03:51 +0000 (23:03 +0000)]
2010-09-16  Kenneth Russell  <kbr@google.com>

        Reviewed by James Robinson.

        [chromium] Add needed entry points to WebGraphicsContext3D for compositor
        https://bugs.webkit.org/show_bug.cgi?id=45921

        * public/WebGraphicsContext3D.h:
        * src/WebGraphicsContext3DDefaultImpl.cpp:
        (WebKit::WebGraphicsContext3DDefaultImpl::initialize):
        (WebKit::WebGraphicsContext3DDefaultImpl::supportsMapSubCHROMIUM):
        (WebKit::WebGraphicsContext3DDefaultImpl::mapBufferSubDataCHROMIUM):
        (WebKit::WebGraphicsContext3DDefaultImpl::unmapBufferSubDataCHROMIUM):
        (WebKit::WebGraphicsContext3DDefaultImpl::mapTexSubImage2DCHROMIUM):
        (WebKit::WebGraphicsContext3DDefaultImpl::unmapTexSubImage2DCHROMIUM):
        (WebKit::WebGraphicsContext3DDefaultImpl::supportsCopyTextureToParentTextureCHROMIUM):
        (WebKit::WebGraphicsContext3DDefaultImpl::copyTextureToParentTextureCHROMIUM):
        * src/WebGraphicsContext3DDefaultImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-15 Tony Chang <tony@chromium.org>
tony@chromium.org [Thu, 16 Sep 2010 22:45:52 +0000 (22:45 +0000)]
2010-09-15  Tony Chang  <tony@chromium.org>

        Reviewed by Kent Tamura.

        [Chromium] Needs DRT queueLoadHTMLString and setDeferMainResourceLoad-implementations
        https://bugs.webkit.org/show_bug.cgi?id=42151

        * platform/chromium/test_expectations.txt:
2010-09-15  Tony Chang  <tony@chromium.org>

        Reviewed by Kent Tamura.

        [Chromium] Needs DRT queueLoadHTMLString and setDeferMainResourceLoad-implementations
        https://bugs.webkit.org/show_bug.cgi?id=42151

        * public/WebDataSource.h:
        * src/WebDataSourceImpl.cpp:
        (WebKit::WebDataSourceImpl::applicationCacheHost):
        (WebKit::WebDataSourceImpl::setDeferMainResourceDataLoad): Added so DRT can set this flag before a load.
        * src/WebDataSourceImpl.h:
2010-09-15  Tony Chang  <tony@chromium.org>

        Reviewed by Kent Tamura.

        [Chromium] Needs DRT queueLoadHTMLString and setDeferMainResourceLoad-implementations
        https://bugs.webkit.org/show_bug.cgi?id=42151

        * DumpRenderTree/chromium/LayoutTestController.cpp:
        (LayoutTestController::LayoutTestController):
        (WorkItemLoadHTMLString::WorkItemLoadHTMLString):
        (WorkItemLoadHTMLString::run):
        (LayoutTestController::queueLoadHTMLString):
        (LayoutTestController::reset):
        (LayoutTestController::setDeferMainResourceDataLoad):
        * DumpRenderTree/chromium/LayoutTestController.h:
        (LayoutTestController::deferMainResourceDataLoad):
        * DumpRenderTree/chromium/WebViewHost.cpp:
        (WebViewHost::didCreateDataSource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-16 Andreas Kling <andreas.kling@nokia.com>
andreas.kling@nokia.com [Thu, 16 Sep 2010 22:35:30 +0000 (22:35 +0000)]
2010-09-16  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Ariya Hidayat.

        [Qt] Remove unnecessary QPainter::clipPath() call in TransparencyLayer()
        https://bugs.webkit.org/show_bug.cgi?id=45923

        QPainter::clipPath() can be very expensive, so use QPainter::hasClipping()
        instead of QPainter::clipPath().isEmpty().

        * platform/graphics/qt/TransparencyLayer.h:
        (WebCore::TransparencyLayer::TransparencyLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=45924
barraclough@apple.com [Thu, 16 Sep 2010 22:30:08 +0000 (22:30 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=45924

Reviewed by Mark Rowe.

Modify the SunSpider harness to allow a path to be passed to the --suite
argument, supress the normal prepend-"tests/" behaviour for suite names
containing a '/'.

Also wrap the code in an anonymous function to move variables out of global
scope (currently the harness cannot handle running tests the overwrite the
variable 'j').

* resources/sunspider-standalone-driver.js:
* sunspider:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix for regression from my previous check-in. Make sure not to move the LayoutRepain...
hyatt@apple.com [Thu, 16 Sep 2010 22:18:33 +0000 (22:18 +0000)]
Fix for regression from my previous check-in.  Make sure not to move the LayoutRepainter line
below the setHeight(0) call.  This meant it snagged the wrong rectangle and we ended up repainting
the world.

Reviewed by Eric Seidel.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlock):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-16 Zhenyao Mo <zmo@google.com>
zmo@google.com [Thu, 16 Sep 2010 21:58:43 +0000 (21:58 +0000)]
2010-09-16  Zhenyao Mo  <zmo@google.com>

        Unreviewed.

        Remove passing WebGL tests from platform/chromium/test_expectations.txt
        https://bugs.webkit.org/show_bug.cgi?id=45905

        Remove passing tests; also, put webgl tests in one place.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix Windows build. Yay for the style review bot telling me to do something that break...
hyatt@apple.com [Thu, 16 Sep 2010 21:53:07 +0000 (21:53 +0000)]
Fix Windows build. Yay for the style review bot telling me to do something that breaks Windows.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67671 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-16 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 16 Sep 2010 21:51:26 +0000 (21:51 +0000)]
2010-09-16  Eric Seidel  <eric@webkit.org>

        Unreviewed.  Just changing the path to the PNG file.

        fast/css/font-face-svg-decoding-error.html can cause later CSS tests to fail
        https://bugs.webkit.org/show_bug.cgi?id=45919

        Fixing the underlying issue in a separate bug.  For now
        give this test its own png so to unblock the commit-queue.

        * fast/css/font-face-svg-decoding-error.html:
        * fast/css/resources/invalidfont.png: Copied from LayoutTests/fast/css-generated-content/resources/greenbox.png.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67670 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-16 Adrienne Walker <enne@google.com>
commit-queue@webkit.org [Thu, 16 Sep 2010 21:44:28 +0000 (21:44 +0000)]
2010-09-16  Adrienne Walker  <enne@google.com>

        Reviewed by Kenneth Russell.

        Add script to synchronize WebKit and Khronos WebGL tests
        https://bugs.webkit.org/show_bug.cgi?id=42336

        * Scripts/update-webgl-conformance-tests: Added.
        * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests.py: Added.
        * Scripts/webkitpy/layout_tests/update_webgl_conformance_tests_unittest.py: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-16 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Thu, 16 Sep 2010 21:39:43 +0000 (21:39 +0000)]
2010-09-16  Martin Robinson  <mrobinson@igalia.com>

        Update baselines for GTK+ and unskip a test which is passing.

        * platform/gtk/Skipped: Update baselines for GTK+.
        * platform/gtk/fast/css/percent-top-relative-container-height-unspecified-expected.txt: Added.
        * platform/gtk/fast/images/gif-large-checkerboard-expected.txt: Added.
        * platform/gtk/fast/multicol/border-padding-pagination-expected.txt: Added.
        * platform/gtk/fast/multicol/client-rects-expected.txt: Added.
        * platform/gtk/fast/multicol/column-break-with-balancing-expected.txt: Added.
        * platform/gtk/fast/multicol/column-rules-expected.txt: Added.
        * platform/gtk/fast/multicol/column-rules-stacking-expected.txt: Added.
        * platform/gtk/fast/multicol/columns-shorthand-parsing-expected.txt: Added.
        * platform/gtk/fast/multicol/float-avoidance-expected.txt: Added.
        * platform/gtk/fast/multicol/float-multicol-expected.txt: Added.
        * platform/gtk/fast/multicol/float-paginate-complex-expected.txt: Added.
        * platform/gtk/fast/multicol/float-paginate-expected.txt: Added.
        * platform/gtk/fast/multicol/layers-in-multicol-expected.txt:
        * platform/gtk/fast/multicol/margin-collapse-expected.txt: Added.
        * platform/gtk/fast/multicol/max-height-columns-block-expected.txt: Added.
        * platform/gtk/fast/multicol/nested-columns-expected.txt:
        * platform/gtk/fast/multicol/paginate-block-replaced-expected.txt: Added.
        * platform/gtk/fast/multicol/positioned-split-expected.txt: Added.
        * platform/gtk/fast/multicol/positioned-with-constrained-height-expected.txt: Added.
        * platform/gtk/fast/multicol/shadow-breaking-expected.txt: Added.
        * platform/gtk/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt:
        * platform/gtk/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
        * platform/gtk/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt:
        * platform/gtk/fast/multicol/span/span-as-immediate-columns-child-expected.txt:
        * platform/gtk/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt:
        * platform/gtk/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt:
        * platform/gtk/fast/multicol/span/span-as-nested-columns-child-expected.txt:
        * platform/gtk/fast/multicol/table-margin-collapse-expected.txt: Added.
        * platform/gtk/fast/multicol/table-vertical-align-expected.txt: Added.
        * platform/gtk/fast/multicol/unsplittable-inline-block-expected.txt: Added.
        * platform/gtk/fast/repaint/block-layout-inline-children-float-positioned-expected.txt: Added.
        * platform/gtk/fast/repaint/block-layout-inline-children-replaced-expected.txt: Added.
        * platform/gtk/scrollbars/custom-scrollbar-with-incomplete-style-expected.txt: Added.
        * platform/gtk/svg/css/composite-shadow-with-opacity-expected.txt: Added.
        * platform/gtk/svg/css/shadow-changes-expected.txt: Added.
        * platform/gtk/svg/custom/getscreenctm-in-scrollable-div-area-expected.txt: Added.
        * platform/gtk/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.txt: Added.
        * platform/gtk/svg/custom/getscreenctm-in-scrollable-svg-area-expected.txt: Added.
        * platform/gtk/svg/custom/mouse-move-on-svg-container-expected.txt: Added.
        * platform/gtk/svg/custom/mouse-move-on-svg-container-standalone-expected.txt: Added.
        * platform/gtk/svg/custom/mouse-move-on-svg-root-expected.txt: Added.
        * platform/gtk/svg/custom/mouse-move-on-svg-root-standalone-expected.txt: Added.
        * platform/gtk/svg/custom/non-scaling-stroke-markers-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/non-scaling-stroke-markers-expected.txt.
        * platform/gtk/svg/custom/use-invalid-pattern-expected.txt: Copied from LayoutTests/platform/mac-snowleopard/svg/custom/use-invalid-pattern-expected.txt.
        * platform/gtk/svg/repaint/filter-repaint-expected.txt: Added.
        * platform/gtk/transitions/svg-text-shadow-transition-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=45020
hyatt@apple.com [Thu, 16 Sep 2010 21:37:06 +0000 (21:37 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=45020
Support "block-flow" and "writing-mode": interpret properties into RenderStyle

Patch by takano takumi <takano1@asia.apple.com> on 2010-09-16
Reviewed by Dave Hyatt.

Added code that interprets "block-flow" property and "writing-mode" property settings
into a RenderStyle object.

WebCore:

Test: fast/text/international/block-flow-parser-test.html

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EBlockFlowDirection):
* css/CSSPropertyNames.in:
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
* css/CSSValueKeywords.in:
* css/SVGCSSValueKeywords.in:
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff):
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::setBitDefaults):
(WebCore::InheritedFlags::blockFlow):
(WebCore::InheritedFlags::setBlockFlow):
(WebCore::InheritedFlags::initialBlockFlow):
* rendering/style/RenderStyleConstants.h:

LayoutTests:

* fast/css/getComputedStyle/computed-style-expected.txt:
* fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* fast/text/international/block-flow-parser-test-expected.txt: Added.
* fast/text/international/block-flow-parser-test.html: Added.
* svg/css/getComputedStyle-basic-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd support for sending synchronous messages from the InjectedBundle to the WKContext
weinig@apple.com [Thu, 16 Sep 2010 21:04:44 +0000 (21:04 +0000)]
Add support for sending synchronous messages from the InjectedBundle to the WKContext
<rdar://problem/8365320>
https://bugs.webkit.org/show_bug.cgi?id=44785

Reviewed by Anders Carlsson.

WebKit2:

* Shared/CoreIPCSupport/WebContextMessageKinds.h:
* UIProcess/API/C/WKContext.h:
* UIProcess/WebContext.cpp:
(WebKit::WebContext::didReceiveSynchronousMessageFromInjectedBundle):
(WebKit::WebContext::didReceiveMessage):
(WebKit::WebContext::didReceiveSyncMessage):
* UIProcess/WebContext.h:
* UIProcess/WebContextInjectedBundleClient.cpp:
(WebKit::WebContextInjectedBundleClient::didReceiveSynchronousMessageFromInjectedBundle):
* UIProcess/WebContextInjectedBundleClient.h:
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didReceiveSyncMessage):
* WebProcess/InjectedBundle/API/c/WKBundle.cpp:
(WKBundlePostSynchronousMessage):
* WebProcess/InjectedBundle/API/c/WKBundle.h:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::postSynchronousMessage):
* WebProcess/InjectedBundle/InjectedBundle.h:

WebKitTools:

* MiniBrowser/mac/AppDelegate.m:
(didReceiveSynchronousMessageFromInjectedBundle):
(-[BrowserAppDelegate init]):
* MiniBrowser/mac/WebBundle/WebBundleMain.m:
(didCreatePage):
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::initialize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67666 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-16 Kenneth Russell <kbr@google.com>
kbr@google.com [Thu, 16 Sep 2010 20:55:11 +0000 (20:55 +0000)]
2010-09-16  Kenneth Russell  <kbr@google.com>

        Reviewed by James Robinson.

        Roll forward Chromium DEPS to r59706
        https://bugs.webkit.org/show_bug.cgi?id=45916

        * DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-16 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Thu, 16 Sep 2010 20:51:09 +0000 (20:51 +0000)]
2010-09-16  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Implement dissolveDragImageToFraction
        https://bugs.webkit.org/show_bug.cgi?id=45826

        * wtf/gobject/GTypedefs.h: Added forward declarations for GtkWindow and GdkEventExpose.
2010-09-16  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Implement dissolveDragImageToFraction
        https://bugs.webkit.org/show_bug.cgi?id=45826

        Convert the drag image from a GdkPixbuf to a Cairo surface. Not only
        might this allow code to be shared between Cairo ports it prevents a
        full data copy when the image is not resized and makes the implementation
        of dissolveDragImageToFraction more straight-forward.

        This feature is covered by manual-tests/drag-image.html.

        * page/gtk/DragControllerGtk.cpp:
        (WebCore::DragController::maxDragImageSize): Make the maximum size of the drag
        image a little smaller.
        * platform/DragImage.h: Changed the drag image type to be a cairo_surface_t*.
        * platform/gtk/DragImageGtk.cpp:
        (WebCore::dragImageSize): Reimplemented to reflect new drag image type.
        (WebCore::deleteDragImage): Ditto.
        (WebCore::scaleDragImage): Ditto.
        (WebCore::dissolveDragImageToFraction): Filled the stub of this function.
        (WebCore::createDragImageFromImage): Reimplemented to reflect new drag image type.
        * platform/gtk/GtkVersioning.h: Added definition for gtk_widget_get_realized for older GTK+s.
2010-09-16  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Implement dissolveDragImageToFraction
        https://bugs.webkit.org/show_bug.cgi?id=45826

        To support full alpha in the drag icon, changed the drag icon to be a
        GtkWindow with an RGBA colormap. Added logic to support painting the drag
        image to this window during the expose event.

        * WebCoreSupport/DragClientGtk.cpp:
        (WebKit::dragIconWindowExposeEventCallback): Added.
        (WebKit::DragClient::DragClient): Initialize the new drag icon window.
        (WebKit::DragClient::~DragClient): Disconnect the expose event signal.
        (WebKit::DragClient::startDrag): Resize the drag icon window the appropriate size and
        if necessary, set its colormap.
        (WebKit::DragClient::dragIconWindowExposeEvent): Added.
        * WebCoreSupport/DragClientGtk.h: Added new member and method declarations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-16 Leonid Ebril <leonid.ebril@nokia.com>
commit-queue@webkit.org [Thu, 16 Sep 2010 20:31:02 +0000 (20:31 +0000)]
2010-09-16  Leonid Ebril  <leonid.ebril@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] QtTestBrowser: Disable creation of a new window for screenshot on Symbian platform.
        https://bugs.webkit.org/show_bug.cgi?id=45885

        Avoid creation of an additional window for screenshot to prevent overlapping with original window.

        * QtTestBrowser/launcherwindow.cpp:
        (LauncherWindow::screenshot):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=38402, paginate columns at layout time rather...
hyatt@apple.com [Thu, 16 Sep 2010 20:20:02 +0000 (20:20 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=38402, paginate columns at layout time rather than at paint time.

Reviewed by Darin Adler.

WebCore:

This patch adds support for column breaking at layout time rather than at paint time.  New variables have been
added to LayoutState and to ColumnInfo to track column information while laying out.

The basic idea behind this patch is to retain the columns' paint-time hackery of transforming one long vertical strip
into multiple columns.  Now, however, layout is aware of the columns and will move objects up and down vertically in order
to ensure they don't intersect a break.

Many new tests added in fast/multicol and new results added for existing fast/multicol tests.

* rendering/ColumnInfo.h:
(WebCore::ColumnInfo::ColumnInfo):
(WebCore::ColumnInfo::columnCount):
(WebCore::ColumnInfo::columnHeight):
(WebCore::ColumnInfo::setColumnCountAndHeight):
(WebCore::ColumnInfo::setColumnHeight):
(WebCore::ColumnInfo::updateMinimumColumnHeight):
(WebCore::ColumnInfo::minimumColumnHeight):
(WebCore::ColumnInfo::forcedBreaks):
(WebCore::ColumnInfo::forcedBreakOffset):
(WebCore::ColumnInfo::maximumDistanceBetweenForcedBreaks):
(WebCore::ColumnInfo::clearForcedBreaks):
(WebCore::ColumnInfo::addForcedBreak):
* rendering/LayoutState.cpp:
(WebCore::LayoutState::LayoutState):
(WebCore::LayoutState::clearPaginationInformation):
(WebCore::LayoutState::pageY):
(WebCore::LayoutState::addForcedColumnBreak):
* rendering/LayoutState.h:
(WebCore::LayoutState::LayoutState):
(WebCore::LayoutState::paginatingColumns):
(WebCore::LayoutState::paginated):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::RenderBlock):
(WebCore::RenderBlock::~RenderBlock):
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::collapseMargins):
(WebCore::RenderBlock::estimateVerticalPosition):
(WebCore::RenderBlock::layoutBlockChild):
(WebCore::RenderBlock::layoutPositionedObjects):
(WebCore::RenderBlock::paintColumnRules):
(WebCore::RenderBlock::paintColumnContents):
(WebCore::RenderBlock::paintChildren):
(WebCore::RenderBlock::insertFloatingObject):
(WebCore::RenderBlock::removeFloatingObjects):
(WebCore::RenderBlock::positionNewFloats):
(WebCore::RenderBlock::positionNewFloatOnLine):
(WebCore::RenderBlock::lowestPosition):
(WebCore::RenderBlock::rightmostPosition):
(WebCore::RenderBlock::leftmostPosition):
(WebCore::RenderBlock::markAllDescendantsWithFloatsForLayout):
(WebCore::RenderBlock::markDescendantBlocksAndLinesForLayout):
(WebCore::RenderBlock::hitTestColumns):
(WebCore::RenderBlock::setDesiredColumnCountAndWidth):
(WebCore::RenderBlock::columnCount):
(WebCore::RenderBlock::columnRectAt):
(WebCore::RenderBlock::layoutColumns):
(WebCore::RenderBlock::adjustPointToColumnContents):
(WebCore::RenderBlock::adjustRectForColumns):
(WebCore::RenderBlock::adjustForColumns):
(WebCore::RenderBlock::setMaxTopMargins):
(WebCore::RenderBlock::setMaxBottomMargins):
(WebCore::RenderBlock::setPaginationStrut):
(WebCore::RenderBlock::setPageY):
(WebCore::RenderBlock::nextPageTop):
(WebCore::inNormalFlow):
(WebCore::RenderBlock::applyBeforeBreak):
(WebCore::RenderBlock::applyAfterBreak):
(WebCore::RenderBlock::adjustForUnsplittableChild):
(WebCore::RenderBlock::adjustLinePositionForPagination):
* rendering/RenderBlock.h:
(WebCore::RenderBlock::paginationStrut):
(WebCore::RenderBlock::pageY):
(WebCore::RenderBlock::maxTopPosMargin):
(WebCore::RenderBlock::maxTopNegMargin):
(WebCore::RenderBlock::maxBottomPosMargin):
(WebCore::RenderBlock::maxBottomNegMargin):
(WebCore::RenderBlock::initMaxMarginValues):
(WebCore::RenderBlock::FloatingObject::FloatingObject):
(WebCore::RenderBlock::FloatingObject::type):
(WebCore::RenderBlock::RenderBlockRareData::RenderBlockRareData):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutInlineChildren):
(WebCore::RenderBlock::determineStartPosition):
(WebCore::RenderBlock::skipLeadingWhitespace):
(WebCore::RenderBlock::findNextLineBreak):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::mapLocalToContainer):
(WebCore::RenderBox::computeRectForRepaint):
(WebCore::RenderBox::markDescendantBlocksAndLinesForLayout):
* rendering/RenderBox.h:
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutBlock):
(WebCore::RenderFlexibleBox::layoutHorizontalBox):
(WebCore::RenderFlexibleBox::layoutVerticalBox):
* rendering/RenderFlexibleBox.h:
* rendering/RenderInline.cpp:
(WebCore::RenderInline::computeRectForRepaint):
(WebCore::RenderInline::mapLocalToContainer):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::updatePagination):
(WebCore::RenderLayer::paintChildLayerIntoColumns):
(WebCore::RenderLayer::hitTestChildLayerColumns):
* rendering/RenderLineBoxList.cpp:
(WebCore::RenderLineBoxList::paint):
* rendering/RenderTable.cpp:
(WebCore::RenderTable::RenderTable):
(WebCore::RenderTable::layout):
* rendering/RenderTable.h:
* rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::layout):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::layoutRows):
* rendering/RenderView.cpp:
(WebCore::RenderView::RenderView):
(WebCore::RenderView::pushLayoutState):
* rendering/RenderView.h:
(WebCore::RenderView::setTruncatedAt):
(WebCore::RenderView::pushLayoutState):
(WebCore::RenderView::popLayoutState):
(WebCore::LayoutStateMaintainer::LayoutStateMaintainer):
(WebCore::LayoutStateMaintainer::push):
* rendering/RootInlineBox.h:
(WebCore::RootInlineBox::RootInlineBox):
(WebCore::RootInlineBox::paginationStrut):
(WebCore::RootInlineBox::setPaginationStrut):

LayoutTests:

Add many new multicol layout tests that demonstrate new pagination features.

* fast/multicol/border-padding-pagination.html: Added.
* fast/multicol/client-rects-expected.checksum:
* fast/multicol/client-rects-expected.png:
* fast/multicol/client-rects-expected.txt:
* fast/multicol/column-break-with-balancing.html: Added.
* fast/multicol/float-paginate-complex.html: Added.
* fast/multicol/float-paginate.html:
* fast/multicol/float-truncation.html:
* fast/multicol/margin-collapse.html: Added.
* fast/multicol/max-height-columns-block.html: Added.
* fast/multicol/positioned-split.html: Added.
* fast/multicol/shadow-breaking.html: Added.
* fast/multicol/single-line-expected.checksum:
* fast/multicol/single-line-expected.png:
* fast/multicol/table-margin-collapse.html: Added.
* fast/multicol/table-vertical-align.html: Added.
* fast/multicol/unsplittable-inline-block.html: Added.
* platform/mac/fast/multicol/border-padding-pagination-expected.checksum: Added.
* platform/mac/fast/multicol/border-padding-pagination-expected.png: Added.
* platform/mac/fast/multicol/border-padding-pagination-expected.txt: Added.
* platform/mac/fast/multicol/column-break-with-balancing-expected.checksum: Added.
* platform/mac/fast/multicol/column-break-with-balancing-expected.png: Added.
* platform/mac/fast/multicol/column-break-with-balancing-expected.txt: Added.
* platform/mac/fast/multicol/column-count-with-rules-expected.checksum: Added.
* platform/mac/fast/multicol/column-count-with-rules-expected.png: Added.
* platform/mac/fast/multicol/column-count-with-rules-expected.txt:
* platform/mac/fast/multicol/column-rules-expected.checksum:
* platform/mac/fast/multicol/column-rules-expected.png:
* platform/mac/fast/multicol/column-rules-expected.txt:
* platform/mac/fast/multicol/column-rules-stacking-expected.checksum:
* platform/mac/fast/multicol/column-rules-stacking-expected.png:
* platform/mac/fast/multicol/columns-shorthand-parsing-expected.checksum:
* platform/mac/fast/multicol/columns-shorthand-parsing-expected.png:
* platform/mac/fast/multicol/float-avoidance-expected.checksum:
* platform/mac/fast/multicol/float-avoidance-expected.png:
* platform/mac/fast/multicol/float-avoidance-expected.txt:
* platform/mac/fast/multicol/float-multicol-expected.checksum:
* platform/mac/fast/multicol/float-multicol-expected.png:
* platform/mac/fast/multicol/float-multicol-expected.txt:
* platform/mac/fast/multicol/float-paginate-complex-expected.checksum: Added.
* platform/mac/fast/multicol/float-paginate-complex-expected.png: Added.
* platform/mac/fast/multicol/float-paginate-complex-expected.txt: Added.
* platform/mac/fast/multicol/float-paginate-expected.txt:
* platform/mac/fast/multicol/layers-in-multicol-expected.checksum:
* platform/mac/fast/multicol/layers-in-multicol-expected.png:
* platform/mac/fast/multicol/layers-in-multicol-expected.txt:
* platform/mac/fast/multicol/margin-collapse-expected.checksum: Added.
* platform/mac/fast/multicol/margin-collapse-expected.png: Added.
* platform/mac/fast/multicol/margin-collapse-expected.txt: Added.
* platform/mac/fast/multicol/max-height-columns-block-expected.checksum: Added.
* platform/mac/fast/multicol/max-height-columns-block-expected.png: Added.
* platform/mac/fast/multicol/max-height-columns-block-expected.txt: Added.
* platform/mac/fast/multicol/nested-columns-expected.checksum:
* platform/mac/fast/multicol/nested-columns-expected.png:
* platform/mac/fast/multicol/nested-columns-expected.txt:
* platform/mac/fast/multicol/paginate-block-replaced-expected.txt:
* platform/mac/fast/multicol/positioned-split-expected.checksum: Added.
* platform/mac/fast/multicol/positioned-split-expected.png: Added.
* platform/mac/fast/multicol/positioned-split-expected.txt: Added.
* platform/mac/fast/multicol/positioned-with-constrained-height-expected.checksum:
* platform/mac/fast/multicol/positioned-with-constrained-height-expected.png:
* platform/mac/fast/multicol/positioned-with-constrained-height-expected.txt:
* platform/mac/fast/multicol/shadow-breaking-expected.checksum: Added.
* platform/mac/fast/multicol/shadow-breaking-expected.png: Added.
* platform/mac/fast/multicol/shadow-breaking-expected.txt: Added.
* platform/mac/fast/multicol/span/span-as-immediate-child-generated-content-expected.checksum:
* platform/mac/fast/multicol/span/span-as-immediate-child-generated-content-expected.png:
* platform/mac/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt:
* platform/mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.checksum:
* platform/mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.png:
* platform/mac/fast/multicol/span/span-as-immediate-child-property-removal-expected.txt:
* platform/mac/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.checksum:
* platform/mac/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.png:
* platform/mac/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt:
* platform/mac/fast/multicol/span/span-as-immediate-columns-child-expected.txt:
* platform/mac/fast/multicol/span/span-as-immediate-columns-child-removal-expected.txt:
* platform/mac/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.checksum:
* platform/mac/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png:
* platform/mac/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt:
* platform/mac/fast/multicol/span/span-as-nested-columns-child-expected.checksum:
* platform/mac/fast/multicol/span/span-as-nested-columns-child-expected.png:
* platform/mac/fast/multicol/span/span-as-nested-columns-child-expected.txt:
* platform/mac/fast/multicol/table-margin-collapse-expected.checksum: Added.
* platform/mac/fast/multicol/table-margin-collapse-expected.png: Added.
* platform/mac/fast/multicol/table-margin-collapse-expected.txt: Added.
* platform/mac/fast/multicol/table-vertical-align-expected.checksum: Added.
* platform/mac/fast/multicol/table-vertical-align-expected.png: Added.
* platform/mac/fast/multicol/table-vertical-align-expected.txt: Added.
* platform/mac/fast/multicol/unsplittable-inline-block-expected.checksum: Added.
* platform/mac/fast/multicol/unsplittable-inline-block-expected.png: Added.
* platform/mac/fast/multicol/unsplittable-inline-block-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-16 Pavel Podivilov <podivilov@chromium.org>
commit-queue@webkit.org [Thu, 16 Sep 2010 20:18:36 +0000 (20:18 +0000)]
2010-09-16  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Dimitri Glazkov.

        Fix debug crash in HTMLFrameOwnerElement caused by content frame being used after destruction.
        https://bugs.webkit.org/show_bug.cgi?id=45737

        Test: fast/frames/frame-limit.html

        * html/HTMLFrameOwnerElement.cpp:
        (WebCore::HTMLFrameOwnerElement::willRemove):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67659 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix clang++ build.
andersca@apple.com [Thu, 16 Sep 2010 20:15:24 +0000 (20:15 +0000)]
Fix clang++ build.

* MiniBrowser/mac/BrowserWindowController.m:
(-[BrowserWindowController zoomIn:]):
(-[BrowserWindowController zoomOut:]):
(-[BrowserWindowController resetZoom:]):
Remove trailing semicolons.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-16 Thomas Zander <t.zander@nokia.com>
commit-queue@webkit.org [Thu, 16 Sep 2010 20:05:51 +0000 (20:05 +0000)]
2010-09-16  Thomas Zander <t.zander@nokia.com>

        Reviewed by Andreas Kling.

        https://bugs.webkit.org/show_bug.cgi?id=45878

        [Qt] Fixed incorrect Symbian scoping.

        The missing install functionality is only true for mmp based systems.

        * WebCore.pro: limit functionality to mmp systems.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix clang build.
andersca@apple.com [Thu, 16 Sep 2010 20:00:47 +0000 (20:00 +0000)]
Fix clang build.

* page/animation/AnimationBase.h:
Fix struct/class mismatch.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix build.
darin@apple.com [Thu, 16 Sep 2010 19:48:14 +0000 (19:48 +0000)]
Fix build.

WebKit/efl:

* ewk/ewk_view.cpp:
(ewk_view_input_method_state_set): Updated for change
in name of isUrlField to isURLField.

WebKit/qt:

* WebCoreSupport/EditorClientQt.cpp:
(WebCore::EditorClientQt::setInputMethodState): Updated for change
in name of isUrlField to isURLField.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-16 Darin Adler <darin@apple.com>
darin@apple.com [Thu, 16 Sep 2010 19:40:49 +0000 (19:40 +0000)]
2010-09-16  Darin Adler  <darin@apple.com>

        Reviewed by Andreas Kling.

        Reduce use of HTMLInputElement::inputType so we can remove it later
        https://bugs.webkit.org/show_bug.cgi?id=45903

        * src/DOMUtilitiesPrivate.cpp:
        (WebKit::elementHasLegalLinkAttribute): Use isImageButton.
        * src/WebPasswordFormUtils.cpp:
        (WebKit::findPasswordFormFields): Use isPasswordField.
        * src/WebSearchableFormData.cpp:
        (WebCore::IsInDefaultState): Use isCheckbox and isRadioButton.
        (WebCore::HasSuitableTextElement): Use isFileUpload and isPasswordField.
2010-09-16  Darin Adler  <darin@apple.com>

        Reviewed by Andreas Kling.

        Reduce use of HTMLInputElement::inputType so we can remove it later
        https://bugs.webkit.org/show_bug.cgi?id=45903

        * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
        (DumpRenderTreeSupportQt::elementDoesAutoCompleteForElementWithId):
        Use isPasswordField.
2010-09-16  Darin Adler  <darin@apple.com>

        Reviewed by Andreas Kling.

        Reduce use of HTMLInputElement::inputType so we can remove it later
        https://bugs.webkit.org/show_bug.cgi?id=45903

        * WebFrame.cpp:
        (WebFrame::elementDoesAutoComplete): Use isPasswordField.
        (WebFrame::elementIsPassword): Use isPasswordField.
2010-09-16  Darin Adler  <darin@apple.com>

        Reviewed by Andreas Kling.

        Reduce use of HTMLInputElement::inputType so we can remove it later
        https://bugs.webkit.org/show_bug.cgi?id=45903

        * WebView/WebHTMLRepresentation.mm:
        (-[WebHTMLRepresentation elementDoesAutoComplete:]): Use isPasswordField.
        (-[WebHTMLRepresentation elementIsPassword:]): Use isPasswordField.
2010-09-16  Darin Adler  <darin@apple.com>

        Reviewed by Andreas Kling.

        Reduce use of HTMLInputElement::inputType so we can remove it later
        https://bugs.webkit.org/show_bug.cgi?id=45903

        * accessibility/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::isFileUploadButton): Use isFileUpload.
        (WebCore::AccessibilityRenderObject::isInputImage): Use isImageButton.
        (WebCore::AccessibilityRenderObject::determineAccessibilityRole): Use
        isCheckbox and isRadioButton.

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::adjustRenderStyle): Use isImageButton.

        * editing/Editor.cpp:
        (WebCore::Editor::setBaseWritingDirection): Use isTextField.

        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::doApply): Use isPasswordField.

        * editing/SelectionController.cpp:
        (WebCore::SelectionController::isInPasswordField): Use isPasswordField.

        * html/HTMLInputElement.h: Added isFileUpload, isImageButton, and isSubmitButton.

        * page/Chrome.cpp:
        (WebCore::Chrome::setToolTip): Use isSubmitButton and isFileUpload.

        * page/DragController.cpp:
        (WebCore::asFileInput): Use isFileUpload.

        * page/EventHandler.cpp:
        (WebCore::isSubmitImage): Use isImageButton.

        * rendering/RenderFileUploadControl.cpp:
        (WebCore::RenderFileUploadControl::updateFromElement): Use isFileUpload.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMac results for recently-added test.
darin@apple.com [Thu, 16 Sep 2010 19:33:37 +0000 (19:33 +0000)]
Mac results for recently-added test.

* platform/mac/fast/images/gif-large-checkerboard-expected.checksum: Added.
* platform/mac/fast/images/gif-large-checkerboard-expected.png: Added.
* platform/mac/fast/images/gif-large-checkerboard-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-16 Pavel Podivilov <podivilov@chromium.org>
commit-queue@webkit.org [Thu, 16 Sep 2010 19:31:47 +0000 (19:31 +0000)]
2010-09-16  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: quick fix for crash in InspectorController::loadBreakpoints caused by empty main resource
        https://bugs.webkit.org/show_bug.cgi?id=45901

        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::breakpointsSettingKey):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-16 Kenneth Russell <kbr@google.com>
kbr@google.com [Thu, 16 Sep 2010 19:31:20 +0000 (19:31 +0000)]
2010-09-16  Kenneth Russell  <kbr@google.com>

        Reviewed by James Robinson.

        [chromium] Expose separate GraphicsContext3DInternal.h
        https://bugs.webkit.org/show_bug.cgi?id=45914

        * WebKit.gyp:
        * src/GraphicsContext3D.cpp:
        * src/GraphicsContext3DInternal.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-16 Kenneth Russell <kbr@google.com>
kbr@google.com [Thu, 16 Sep 2010 19:26:22 +0000 (19:26 +0000)]
2010-09-16  Kenneth Russell  <kbr@google.com>

        Reviewed by James Robinson.

        [chromium] Add WebGraphicsContext3D accessor to WebView
        https://bugs.webkit.org/show_bug.cgi?id=45913

        * public/WebView.h:
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::WebViewImpl):
        (WebKit::WebViewImpl::graphicsContext3D):
        * src/WebViewImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-16 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 16 Sep 2010 19:17:46 +0000 (19:17 +0000)]
2010-09-16  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Prevent responseReceivedTime from being > endTime in case mixture of WebCore and Network stack info is used.
        https://bugs.webkit.org/show_bug.cgi?id=45892

        * inspector/InspectorResource.cpp:
        (WebCore::InspectorResource::endTiming):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-16 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Thu, 16 Sep 2010 19:13:05 +0000 (19:13 +0000)]
2010-09-16  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: move resourceTracking flag under control of BackendSettings.

        Four Inspector API methods about resourceTracking flag were removed.
        Actual state of the flag is transfered as the response of setResourceTracking request.
        Initial state of the flag on the frontend side is obtained from settings.backend.

        https://bugs.webkit.org/show_bug.cgi?id=45887

        WebCore:

        * inspector/Inspector.idl:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::getBackendSettings):
        (WebCore::InspectorController::populateScriptObjects):
        (WebCore::InspectorController::setResourceTracking):
        * inspector/InspectorController.h:
        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.ResourcesPanel.prototype._toggleResourceTracking):
        * inspector/front-end/Settings.js:
        (WebInspector.Settings.initialize.populateBackendSettings):
        (WebInspector.Settings.initialize):
        * inspector/front-end/inspector.js:

        WebKit/chromium:

        * src/WebDevToolsAgentImpl.cpp:
        (WebKit::WebDevToolsAgentImpl::setRuntimeProperty):
        (WebKit::WebDevToolsAgentImpl::setApuAgentEnabled):

        LayoutTests:

        * http/tests/inspector/inspector-test2.js:
        (initialize_InspectorTest.InspectorTest.enableResourceTracking):
        (initialize_InspectorTest.InspectorTest.disableResourceTracking):
        * http/tests/inspector/resource-parameters.html:
        * inspector/audits-panel-functional.html:
        * inspector/report-API-errors-expected.txt:
        * inspector/report-API-errors.html:
        * inspector/styles-source-offsets.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBlobData should be copied for it to be used cross-thread in ThreadableBlobRegistry.
jianli@chromium.org [Thu, 16 Sep 2010 19:09:36 +0000 (19:09 +0000)]
BlobData should be copied for it to be used cross-thread in ThreadableBlobRegistry.
https://bugs.webkit.org/show_bug.cgi?id=45909

Reviewed by David Levin.

WebCore:

* fileapi/ThreadableBlobRegistry.cpp:
(WebCore::BlobRegistryContext::BlobRegistryContext):

LayoutTests:

Also fix a test issue that we do not calculate the right position to move
mouse to on some platform.

* fast/files/apply-blob-url-to-img.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-16 Daniel Cheng <dcheng@chromium.org>
commit-queue@webkit.org [Thu, 16 Sep 2010 19:05:30 +0000 (19:05 +0000)]
2010-09-16  Daniel Cheng  <dcheng@chromium.org>

        Reviewed by Simon Fraser.

        [chromium] Fix incorrect drag node/selection painting.
        https://bugs.webkit.org/show_bug.cgi?id=45573

        Drag selections were being incorrectly clipped when dragging a selection
        near the bottom of a page that was taller than the viewport. To fix
        this, we use paintContents() instead of paint().

        * page/chromium/FrameChromium.cpp:
        (WebCore::Frame::nodeImage):
        (WebCore::Frame::dragImageForSelection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-16 Zhenyao Mo <zmo@google.com>
zmo@google.com [Thu, 16 Sep 2010 18:36:06 +0000 (18:36 +0000)]
2010-09-16  Zhenyao Mo  <zmo@google.com>

        Unreviewed, TAG fix for two webgl tests in Linux/Win.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-16 Patrick Gansterer <paroga@paroga.com>
commit-queue@webkit.org [Thu, 16 Sep 2010 18:19:03 +0000 (18:19 +0000)]
2010-09-16  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Darin Adler.

        [Mac] Always use a valid string when setting WebKitUserStyleSheetLocationPreferenceKey.
        https://bugs.webkit.org/show_bug.cgi?id=41510

        * platform/mac/fast/loader/user-stylesheet-fast-path-expected.txt:
        * platform/mac/fast/loader/user-stylesheet-fast-path.html:
2010-09-16  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Darin Adler.

        Always use a valid string when setting WebKitUserStyleSheetLocationPreferenceKey.
        https://bugs.webkit.org/show_bug.cgi?id=41510

        This prevents usage of nil value, which would cause an uncaught exception.

        * WebView/WebPreferences.mm:
        (-[WebPreferences setUserStyleSheetLocation:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-16 Daniel Cheng <dcheng@chromium.org>
commit-queue@webkit.org [Thu, 16 Sep 2010 18:06:48 +0000 (18:06 +0000)]
2010-09-16  Daniel Cheng  <dcheng@chromium.org>

        Reviewed by Tony Chang.

        Fix incorrect usage of dissolveDragImageToFraction().
        https://bugs.webkit.org/show_bug.cgi?id=45835

        createDragImageForSelection() was ignoring the return value of
        dissolveDragImageToFraction(). This didn't happen to crash on most
        platforms, since most implementations simply modified the image that was
        passed in. However, Chromium Mac's implementation actually creates a new
        image and returns that instead. This caused us to crash when copying the
        image from the renderer to the browser process, since the memory had
        already been freed.

        * manual-tests/selection-drag-crash.html: Added.
        * platform/DragImage.cpp:
        (WebCore::createDragImageForSelection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-16 Zhenyao Mo <zmo@google.com>
zmo@google.com [Thu, 16 Sep 2010 17:59:22 +0000 (17:59 +0000)]
2010-09-16  Zhenyao Mo  <zmo@google.com>

        Unreviewed, test TAG fix.

        * platform/chromium/test_expectations.txt: should be IMAGE+TEXT, not TEXT+IMAGE.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoReverted the previous change because r67628 has been reverted.
mitz@apple.com [Thu, 16 Sep 2010 17:52:13 +0000 (17:52 +0000)]
Reverted the previous change because r67628 has been reverted.

WebKit:

* English.lproj/Localizable.strings:

WebKit/mac:

* WebCoreSupport/WebPlatformStrategies.h:
* WebCoreSupport/WebPlatformStrategies.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebKit: Updated localizable strings.
mitz@apple.com [Thu, 16 Sep 2010 17:39:09 +0000 (17:39 +0000)]
WebKit: Updated localizable strings.

* English.lproj/Localizable.strings:

WebKit/mac: Build fix after r67628. Added context menu item localizable strings for the items
added in r67628, following equivalent menu items in Mac OS X when possible. However,
this set of menu items does not make much sense for Mac OS X, and this should be
addressed separately.

* WebCoreSupport/WebPlatformStrategies.h:
* WebCoreSupport/WebPlatformStrategies.mm:
(WebPlatformStrategies::contextMenuItemTagOpenMediaInNewWindow):
(WebPlatformStrategies::contextMenuItemTagCopyMediaLinkToClipboard):
(WebPlatformStrategies::contextMenuItemTagToggleMediaControls):
(WebPlatformStrategies::contextMenuItemTagToggleMediaLoop):
(WebPlatformStrategies::contextMenuItemTagEnterVideoFullscreen):
(WebPlatformStrategies::contextMenuItemTagMediaPlay):
(WebPlatformStrategies::contextMenuItemTagMediaPause):
(WebPlatformStrategies::contextMenuItemTagMediaMute):
(WebPlatformStrategies::contextMenuItemTagMediaUnMute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-16 Balazs Kelemen <kbalazs@webkit.org>
kbalazs@webkit.org [Thu, 16 Sep 2010 17:37:51 +0000 (17:37 +0000)]
2010-09-16  Balazs Kelemen  <kbalazs@webkit.org>

        Unreviewed trivial typo fix.

        Remove old debug helper code inside |#if 0| from ConnectionQt.cpp

        * Platform/CoreIPC/qt/ConnectionQt.cpp:
        (CoreIPC::Connection::readyReadHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-16 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Thu, 16 Sep 2010 17:33:22 +0000 (17:33 +0000)]
2010-09-16  Martin Robinson  <mrobinson@igalia.com>

        Unskip some tests that are now passing after libxml fixes in r66336.

        * platform/gtk/Skipped: Unskip passing tests.
        * platform/gtk/svg/custom/js-update-stop-linked-gradient-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-16 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Thu, 16 Sep 2010 17:32:33 +0000 (17:32 +0000)]
2010-09-16  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r67628.
        http://trac.webkit.org/changeset/67628
        https://bugs.webkit.org/show_bug.cgi?id=45904

        broke the build (Requested by eric_carlson on #webkit).

        * media/context-menu-actions-expected.txt: Removed.
        * media/context-menu-actions.html: Removed.
        * platform/mac/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:
2010-09-16  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r67628.
        http://trac.webkit.org/changeset/67628
        https://bugs.webkit.org/show_bug.cgi?id=45904

        broke the build (Requested by eric_carlson on #webkit).

        * page/ContextMenuController.cpp:
        (WebCore::ContextMenuController::contextMenuItemSelected):
        * platform/ContextMenu.cpp:
        (WebCore::ContextMenu::populate):
        (WebCore::ContextMenu::checkOrEnableIfNeeded):
        * platform/ContextMenuItem.h:
        * platform/LocalizationStrategy.h:
        * platform/LocalizedStrings.cpp:
        * platform/LocalizedStrings.h:
        * platform/android/LocalizedStringsAndroid.cpp:
        * platform/brew/LocalizedStringsBrew.cpp:
        * platform/efl/LocalizedStringsEfl.cpp:
        * platform/gtk/ContextMenuItemGtk.cpp:
        (WebCore::gtkStockIDFromContextMenuAction):
        * platform/gtk/LocalizedStringsGtk.cpp:
        * platform/haiku/LocalizedStringsHaiku.cpp:
        * platform/wx/LocalizedStringsWx.cpp:
        * rendering/HitTestResult.cpp:
        (WebCore::HitTestResult::absoluteMediaURL):
        * rendering/HitTestResult.h:
2010-09-16  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r67628.
        http://trac.webkit.org/changeset/67628
        https://bugs.webkit.org/show_bug.cgi?id=45904

        broke the build (Requested by eric_carlson on #webkit).

        * DumpRenderTree/gtk/EventSender.cpp:
        (contextClickCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-16 Andreas Kling <andreas.kling@nokia.com>
andreas.kling@nokia.com [Thu, 16 Sep 2010 17:21:02 +0000 (17:21 +0000)]
2010-09-16  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Simon Fraser.

        CSS: Fix crash in getTimingFunctionValue()
        https://bugs.webkit.org/show_bug.cgi?id=45896

        Use a RefPtr to avoid deleting the TimingFunction prematurely.

        This is covered by existing tests, e.g transitions/inherit-other-props.html
        but will only actually crash on picky platforms (or in valgrind.)

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::getTimingFunctionValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-16 Zhenyao Mo <zmo@google.com>
zmo@google.com [Thu, 16 Sep 2010 17:15:10 +0000 (17:15 +0000)]
2010-09-16  Zhenyao Mo  <zmo@google.com>

        Reviewed by Kenneth Russell.

        Turn on WebGL layout tests for Chromium win/linux
        https://bugs.webkit.org/show_bug.cgi?id=45859

        * platform/chromium/test_expectations.txt: Re-enabling WebGL tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-16 John Gregg <johnnyg@google.com>
johnnyg@google.com [Thu, 16 Sep 2010 17:04:13 +0000 (17:04 +0000)]
2010-09-16  John Gregg  <johnnyg@google.com>

        Unreviewed; chromium test expectations.

        editing/selection/context-menu-on-text.html fails on chromium
        https://bugs.webkit.org/show_bug.cgi?id=45898

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoPasteboard doesn't work in WebKit2.
enrica@apple.com [Thu, 16 Sep 2010 16:28:41 +0000 (16:28 +0000)]
Pasteboard doesn't work in WebKit2.
https://bugs.webkit.org/show_bug.cgi?id=42317
<rdar://problem/7660537>

Reviewed by Sam Weinig.

Initial work to support cut, copy, paste and selectAll in WebKit2.
It still does not support RTF and RTFD format for Mac and the selective
enabling of the editing menu entries.

* Shared/CoreIPCSupport/WebPageMessageKinds.h: Added messages to support the
new editing commands.
* UIProcess/API/mac/WKView.mm:
(-[WKView validateUserInterfaceItem:]): Added.
(-[WKView copy:]): Added.
(-[WKView cut:]): Added.
(-[WKView paste:]): Addded.
(-[WKView selectAll:]): Added.
* UIProcess/WebPageProxy.cpp: Added all the proxy methods.
(WebKit::WebPageProxy::selectAll):
(WebKit::WebPageProxy::copy):
(WebKit::WebPageProxy::cut):
(WebKit::WebPageProxy::paste):
* UIProcess/WebPageProxy.h:
* WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::documentFragmentFromAttributedString): Added but not
implemented. This is needed to support RTF and RTFD.
(WebKit::WebEditorClient::setInsertionPasteboard): Added but not implemented.
This is needed only to support Mail on the Mac.
* WebProcess/WebPage/WebPage.cpp: Added all the stub methods.
(WebKit::WebPage::selectAll):
(WebKit::WebPage::copy):
(WebKit::WebPage::cut):
(WebKit::WebPage::paste):
(WebKit::WebPage::didReceiveMessage): Modified to handle the new messages from
the UI process.
* WebProcess/WebPage/WebPage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-16 Balazs Kelemen <kbalazs@webkit.org>
kbalazs@webkit.org [Thu, 16 Sep 2010 16:27:58 +0000 (16:27 +0000)]
2010-09-16  Balazs Kelemen  <kbalazs@webkit.org>

        Unreviewed.

        Adding myself as a comitter.

        * Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-16 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 16 Sep 2010 16:24:50 +0000 (16:24 +0000)]
2010-09-16  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: prevent resource timing popover from having scrollers.
        https://bugs.webkit.org/show_bug.cgi?id=45883

        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.ResourcesPanel.prototype._showPopover):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-15 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 16 Sep 2010 16:21:44 +0000 (16:21 +0000)]
2010-09-15  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Eric Carlson.

        [GTK] enhanced context menu for media elements
        https://bugs.webkit.org/show_bug.cgi?id=45021

        New items in the media Element context menu:
        - play/pause
        - mute/unmute
        - controls display control
        - switch to fullscreen (for video only)
        - loop playback control
        - copy media url to clipboard
        - open in new window

        Test: media/context-menu-actions.html

        * page/ContextMenuController.cpp:
        (WebCore::ContextMenuController::contextMenuItemSelected):
        * platform/ContextMenu.cpp:
        (WebCore::ContextMenu::populate):
        (WebCore::ContextMenu::checkOrEnableIfNeeded):
        * platform/ContextMenuItem.h:
        * platform/LocalizationStrategy.h:
        * platform/LocalizedStrings.cpp:
        (WebCore::contextMenuItemTagOpenMediaInNewWindow):
        (WebCore::contextMenuItemTagCopyMediaLinkToClipboard):
        (WebCore::contextMenuItemTagToggleMediaControls):
        (WebCore::contextMenuItemTagToggleMediaLoop):
        (WebCore::contextMenuItemTagEnterVideoFullscreen):
        (WebCore::contextMenuItemTagMediaPlay):
        (WebCore::contextMenuItemTagMediaPause):
        (WebCore::contextMenuItemTagMediaMute):
        (WebCore::contextMenuItemTagMediaUnMute):
        * platform/LocalizedStrings.h:
        * platform/android/LocalizedStringsAndroid.cpp:
        (WebCore::contextMenuItemTagOpenMediaInNewWindow):
        (WebCore::contextMenuItemTagCopyMediaLinkToClipboard):
        (WebCore::contextMenuItemTagToggleMediaControls):
        (WebCore::contextMenuItemTagToggleMediaLoop):
        (WebCore::contextMenuItemTagEnterVideoFullscreen):
        (WebCore::contextMenuItemTagMediaPlay):
        (WebCore::contextMenuItemTagMediaPause):
        (WebCore::contextMenuItemTagMediaMute):
        (WebCore::contextMenuItemTagMediaUnMute):
        * platform/brew/LocalizedStringsBrew.cpp:
        (WebCore::contextMenuItemTagOpenMediaInNewWindow):
        (WebCore::contextMenuItemTagCopyMediaLinkToClipboard):
        (WebCore::contextMenuItemTagToggleMediaControls):
        (WebCore::contextMenuItemTagToggleMediaLoop):
        (WebCore::contextMenuItemTagEnterVideoFullscreen):
        (WebCore::contextMenuItemTagMediaPlay):
        (WebCore::contextMenuItemTagMediaPause):
        (WebCore::contextMenuItemTagMediaMute):
        (WebCore::contextMenuItemTagMediaUnMute):
        * platform/efl/LocalizedStringsEfl.cpp:
        (WebCore::contextMenuItemTagOpenMediaInNewWindow):
        (WebCore::contextMenuItemTagCopyMediaLinkToClipboard):
        (WebCore::contextMenuItemTagToggleMediaControls):
        (WebCore::contextMenuItemTagToggleMediaLoop):
        (WebCore::contextMenuItemTagEnterVideoFullscreen):
        (WebCore::contextMenuItemTagMediaPlay):
        (WebCore::contextMenuItemTagMediaPause):
        (WebCore::contextMenuItemTagMediaMute):
        (WebCore::contextMenuItemTagMediaUnMute):
        * platform/gtk/ContextMenuItemGtk.cpp:
        (WebCore::gtkStockIDFromContextMenuAction):
        * platform/gtk/LocalizedStringsGtk.cpp:
        (WebCore::contextMenuItemTagOpenMediaInNewWindow):
        (WebCore::contextMenuItemTagCopyMediaLinkToClipboard):
        (WebCore::contextMenuItemTagToggleMediaControls):
        (WebCore::contextMenuItemTagToggleMediaLoop):
        (WebCore::contextMenuItemTagEnterVideoFullscreen):
        (WebCore::contextMenuItemTagMediaPlay):
        (WebCore::contextMenuItemTagMediaPause):
        (WebCore::contextMenuItemTagMediaMute):
        (WebCore::contextMenuItemTagMediaUnMute):
        * platform/haiku/LocalizedStringsHaiku.cpp:
        (WebCore::contextMenuItemTagOpenMediaInNewWindow):
        (WebCore::contextMenuItemTagCopyMediaLinkToClipboard):
        (WebCore::contextMenuItemTagToggleMediaControls):
        (WebCore::contextMenuItemTagToggleMediaLoop):
        (WebCore::contextMenuItemTagEnterVideoFullscreen):
        (WebCore::contextMenuItemTagMediaPlay):
        (WebCore::contextMenuItemTagMediaPause):
        (WebCore::contextMenuItemTagMediaMute):
        (WebCore::contextMenuItemTagMediaUnMute):
        * platform/wx/LocalizedStringsWx.cpp:
        (WebCore::contextMenuItemTagOpenMediaInNewWindow):
        (WebCore::contextMenuItemTagCopyMediaLinkToClipboard):
        (WebCore::contextMenuItemTagToggleMediaControls):
        (WebCore::contextMenuItemTagToggleMediaLoop):
        (WebCore::contextMenuItemTagEnterVideoFullscreen):
        (WebCore::contextMenuItemTagMediaPlay):
        (WebCore::contextMenuItemTagMediaPause):
        (WebCore::contextMenuItemTagMediaMute):
        (WebCore::contextMenuItemTagMediaUnMute):
        * rendering/HitTestResult.cpp:
        (WebCore::HitTestResult::absoluteMediaURL):
        (WebCore::HitTestResult::mediaSupportsFullscreen):
        (WebCore::HitTestResult::mediaElement):
        (WebCore::HitTestResult::toggleMediaControlsDisplay):
        (WebCore::HitTestResult::toggleMediaLoopPlayback):
        (WebCore::HitTestResult::enterFullscreenForVideo):
        (WebCore::HitTestResult::mediaControlsEnabled):
        (WebCore::HitTestResult::mediaLoopEnabled):
        (WebCore::HitTestResult::mediaPlaying):
        (WebCore::HitTestResult::toggleMediaPlayState):
        (WebCore::HitTestResult::mediaHasAudio):
        (WebCore::HitTestResult::mediaMuted):
        (WebCore::HitTestResult::toggleMediaMuteState):
        * rendering/HitTestResult.h:

WebKitTools:

        Reviewed by Eric Carlson.

        [GTK] enhanced context menu for media elements
        https://bugs.webkit.org/show_bug.cgi?id=45021

        EventSender::contextClick() now returns an array of js
        objects. Each object has a title property and a click() method.

        * DumpRenderTree/gtk/EventSender.cpp:
        (getMenuItemTitleCallback):
        (setMenuItemTitleCallback):
        (menuItemClickCallback):
        (getMenuItemClass):
        (contextClickCallback):

LayoutTests:

        Reviewed by Eric Carlson.

        [GTK] enhanced context menu for media elements
        https://bugs.webkit.org/show_bug.cgi?id=45021

        New test checking the actions that can be triggered by activating
        the contex-menu of the media element. Skipped on mac, qt and win
        because of lack of DRT support.

        * media/context-menu-actions-expected.txt: Added.
        * media/context-menu-actions.html: Added.
        * platform/mac/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-09-16 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Thu, 16 Sep 2010 16:12:23 +0000 (16:12 +0000)]
2010-09-16  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Adam Barth.

        Crash in WebCore::FrameLoader::shouldInterruptLoadForXFrameOptions
        https://bugs.webkit.org/show_bug.cgi?id=45833

        * fast/parser/x-frame-options-detached-document-crash-expected.txt: Added.
        * fast/parser/x-frame-options-detached-document-crash.html: Added. Crashes before this patch.
2010-09-16  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Adam Barth.

        Crash in WebCore::FrameLoader::shouldInterruptLoadForXFrameOptions
        https://bugs.webkit.org/show_bug.cgi?id=45833

        Test: fast/parser/x-frame-options-detached-document-crash.html

        * dom/Document.cpp:
        (WebCore::Document::processHttpEquiv): Other branches in this method already test for a null frame. So it seems to make sense to test that here as well.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@67627 268f45cc-cd09-0410-ab3c-d52691b4dbfc