aroben [Tue, 12 Jun 2007 23:58:50 +0000 (23:58 +0000)]
WebKitTools:
Land CygwinDownloader.
Rubberstamped by Hyatt.
* CygwinDownloader/cygwin-downloader.py: Added.
* CygwinDownloader/cygwin-downloader.zip: Added.
* CygwinDownloader/make-zip.sh: Added.
* CygwinDownloader/setup.py: Added.
WebKitSite:
Update the location of cygwin-downloader.zip.
Rubberstamped by Hyatt.
* building/tools.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23466
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Tue, 12 Jun 2007 22:40:23 +0000 (22:40 +0000)]
Fix build bustage.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23465
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Tue, 12 Jun 2007 21:53:37 +0000 (21:53 +0000)]
Add Windows checkout/build instructions to website.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23464
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Tue, 12 Jun 2007 21:51:33 +0000 (21:51 +0000)]
Update scripts and project paths to make the Windows build work.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23463
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben [Tue, 12 Jun 2007 21:50:34 +0000 (21:50 +0000)]
Merge WindowsMerge to trunk
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@23462
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann [Mon, 11 Jun 2007 13:49:56 +0000 (13:49 +0000)]
Added a QWebPage::open overload to allow specifying the http header and post data.
(it's an overload instead of a merged openUrl to avoid including qhttp.h in qwebpage.h,
which would imply that one has to have QT += network in the .pro file for using WebKitQt)
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22096
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann [Mon, 11 Jun 2007 13:49:46 +0000 (13:49 +0000)]
Added the possibility to intercept url requests through QWebPage::navigationRequested.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22095
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann [Mon, 11 Jun 2007 13:49:34 +0000 (13:49 +0000)]
Added a QWebNetworkRequest::init overload that takes a WebCore::ResourceRequest,
to be called from FrameLoaderClientQt in the near future.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22094
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann [Mon, 11 Jun 2007 13:49:24 +0000 (13:49 +0000)]
Moved the postData setup into QWebNetworkRequest::init.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22093
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann [Mon, 11 Jun 2007 13:49:13 +0000 (13:49 +0000)]
Moved HTTP header field propagation to QWebNetworkRequest::init.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22092
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann [Mon, 11 Jun 2007 13:48:58 +0000 (13:48 +0000)]
Started moving the code to separate a WebCore::ResourceRequest into a QUrl, postData
and QHttpRequestHeader into a separate little QWebNetworkRequest struct.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22091
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zack [Mon, 11 Jun 2007 07:30:43 +0000 (07:30 +0000)]
Forgot to export the plugin exporter. Fixing it.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22090
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Mon, 11 Jun 2007 01:02:52 +0000 (01:02 +0000)]
Reviewed by Beth Dakin.
Made confusing work-around to ObjC bindings bug <rdar://problem/
5262101>
less confusing.
Fixed test to actually call queueReload.
* fast/frames/resources/iframe-focus.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22089
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Sun, 10 Jun 2007 22:58:33 +0000 (22:58 +0000)]
2007-06-10 Holger Hans Peter Freyther <zecke@selfish.org>
Reviewed by Maciej.
Disable whole-view editing for the Gdk port in order to improve the browsing experience.
* platform/gdk/EditorClientGdk.cpp:
(WebCore::EditorClientGdk::isEditable): Return false to disable whole-view editing
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22088
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin [Sun, 10 Jun 2007 22:18:31 +0000 (22:18 +0000)]
Reviewed by Adele.
Fix for http://bugs.webkit.org/show_bug.cgi?id=13933 REGRESSION:
fast/history/clicked-link-is-visited is failing
* fast/frames/resources/iframe-focus.html: Cause the page to reload
with layoutTestController.queueReload instead of using JavaScript
to reload. Using JS seems to get DRT's history all messed up (off
by one?!).
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22087
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Sun, 10 Jun 2007 19:41:08 +0000 (19:41 +0000)]
Reviewed by Beth Dakin.
Cleaned up formatting on the check out page.
* building/checkout.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22085
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Sun, 10 Jun 2007 07:14:52 +0000 (07:14 +0000)]
Fix for bug 14037, make sure respondsToSelector does the write thing
when invoked on a WebKit plugin's container view.
Reviewed by Mark Rowe
* Plugins/WebKitPluginContainerView.mm:
(-[WebKitPluginContainerView respondsToSelector:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22084
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Sat, 9 Jun 2007 06:00:26 +0000 (06:00 +0000)]
LayoutTests:
Reviewed by Oliver.
Update test for http://bugs.webkit.org/show_bug.cgi?id=14044
Autogenerate the JS bindings for HTMLCollection.
* tables/mozilla/bugs/bug53690-1-expected.txt: Now throws Undefined Error instead of Null Error
WebCore:
Reviewed by Oliver.
Patch for http://bugs.webkit.org/show_bug.cgi?id=14044
Autogenerate the JS bindings for HTMLCollection
- also moves JSHTMLAllCollection into it's own file.
* DerivedSources.make:
* WebCore.pro:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSHTMLAllCollection.h: Added.
(WebCore::JSHTMLAllCollection::JSHTMLAllCollection):
(WebCore::JSHTMLAllCollection::toBoolean):
(WebCore::JSHTMLAllCollection::masqueradeAsUndefined):
* bindings/js/JSHTMLCollectionCustom.cpp: Added.
(WebCore::getNamedItems):
(WebCore::JSHTMLCollection::callAsFunction):
(WebCore::JSHTMLCollection::implementsCall):
(WebCore::JSHTMLCollection::canGetItemsForName):
(WebCore::JSHTMLCollection::nameGetter):
(WebCore::JSHTMLCollection::item):
(WebCore::JSHTMLCollection::namedItem):
(WebCore::toJS):
* bindings/js/JSHTMLDocumentCustom.cpp:
(WebCore::JSHTMLDocument::nameGetter):
(WebCore::JSHTMLDocument::all):
* bindings/js/JSXMLHttpRequest.cpp:
* bindings/js/kjs_html.cpp:
(WebCore::ImageConstructorImp::ImageConstructorImp):
(WebCore::ImageConstructorImp::construct):
* bindings/js/kjs_html.h:
(WebCore::ImageConstructorImp::implementsConstruct):
* bindings/js/kjs_window.cpp:
(KJS::Window::namedItemGetter):
* bindings/objc/DOMUtility.mm:
(KJS::createDOMWrapper):
* bindings/scripts/CodeGeneratorJS.pm:
* html/HTMLCollection.cpp:
(WebCore::HTMLCollection::tags):
* html/HTMLCollection.h:
(WebCore::HTMLCollection::collectionType):
* html/HTMLCollection.idl:
* html/HTMLOptionsCollection.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22080
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin [Fri, 8 Jun 2007 20:03:37 +0000 (20:03 +0000)]
Reviewed by Brady.
Fix for http://trac.webkit.org/projects/webkit/changeset/21738
This test started failing after Adele's r21738. After investigating
this, it turns out that it just needs updated results. This test
happened to tickle the very bug that Adele fixed.
* http/tests/navigation/relativeanchor-goback-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22076
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Fri, 8 Jun 2007 18:10:26 +0000 (18:10 +0000)]
LayoutTests:
Reviewed by John.
<rdar://problem/
5232159> REGRESSION: Cannot select text in RSS view
* editing/selection/
5232159-expected.checksum: Added.
* editing/selection/
5232159-expected.png: Added.
* editing/selection/
5232159-expected.txt: Added.
* editing/selection/
5232159.html: Added.
WebCore:
Reviewed by John.
<rdar://problem/
5232159> REGRESSION: Cannot select text in RSS view
The selection is updated both on mouse movement and
when the autoscroll timer fires. The autoscroll
code wasn't converting mouse coordinates to layer
coordinates correctly, and was then using those
coordinates to create a bad selection.
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::autoscroll): Use convertToLayerCoordinates.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22075
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sullivan [Fri, 8 Jun 2007 16:38:11 +0000 (16:38 +0000)]
* WebView/WebViewPrivate.h:
Added a FIXME
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22074
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Fri, 8 Jun 2007 15:17:27 +0000 (15:17 +0000)]
Reviewed by Geoff.
Store the root object in a hash set, keyed by the plugin view. This is in preparation for
letting plugins invalidate the root object upon destruction
* page/Frame.cpp:
(WebCore::Frame::createRootObject):
(WebCore::Frame::cleanupScriptObjects):
* page/FramePrivate.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22071
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lars [Fri, 8 Jun 2007 13:01:38 +0000 (13:01 +0000)]
Forgot to checkin this part in my last submit.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22070
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lars [Fri, 8 Jun 2007 12:44:53 +0000 (12:44 +0000)]
Reviewed by Zack.
Add a QWebObjectPluginConnector class. The class will
facility communication between the plugin and WebKit.
Currently it's used to make the plugin network capable.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22069
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zack [Fri, 8 Jun 2007 10:08:11 +0000 (10:08 +0000)]
Fix the Qt build
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22067
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Fri, 8 Jun 2007 07:17:49 +0000 (07:17 +0000)]
WebCore:
Reviewed by Tristan.
<rdar://problem/
5250997> A crash occurs when selecting Undo Typing for a page that has been closed in tab
* WebCore.exp: Added clearUndoRedoOperations.
* page/Page.cpp:
(WebCore::Page::clearUndoRedoOperations): Added.
* page/Page.h:
WebKit:
Reviewed by Tristan.
<rdar://problem/
5250997> A crash occurs when selecting Undo Typing for a page that has been closed in tab
* WebView/WebView.mm:
(-[WebView _clearUndoRedoOperations]): Added.
* WebView/WebViewPrivate.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22065
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Fri, 8 Jun 2007 06:50:59 +0000 (06:50 +0000)]
2007-06-08 Mark Rowe <mrowe@apple.com>
Rubber-stamped by Hyatt.
Switch to using Internet Explorer's conditional comments to target IE-specific styles rather
than doing server-side user agent checks. This resolves an issue some people were seeing where
caching would lead to a page generated for an Internet Explorer user being served to a Safari
user. The visible symptom of this was many of the graphics were missing.
* blog/wp-content/themes/webkit/header.php:
* header.inc:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22064
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver [Fri, 8 Jun 2007 06:38:16 +0000 (06:38 +0000)]
Reviewed by Sam "The Intern" Weinig.
Don't be overzealous with the input checks, firstRectForCharacterRange
can be determined even when there is not an active editable region.
This unbreaks editing/input/range-for-empty-document which was broken
by aforementioned overzealousness.
* WebView/WebHTMLView.mm:
(-[WebHTMLView firstRectForCharacterRange:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22063
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Fri, 8 Jun 2007 05:25:17 +0000 (05:25 +0000)]
Fix crash. Null check layer. Bug 13984.
Reviewed by andersca
* WebCore.xcodeproj/project.pbxproj:
* page/FrameView.cpp:
(WebCore::FrameView::windowClipRectForLayer):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22062
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver [Fri, 8 Jun 2007 03:07:04 +0000 (03:07 +0000)]
WebCore:
Reviewed by Justin.
Remove incorrect assertions.
These assertions were made on the assumption that
TSM would always call with a range that was contained
by an editable region.
TSM may call -[WebHTMLView characterIndexForPoint:] on a mouse
event that is otherwise unrelated to editing, which may
be outside the current editing region, triggering these
assertions.
* page/mac/WebCoreFrameBridge.mm:
(-[WebCoreFrameBridge convertToNSRange:]):
WebKit:
Reviewed by Justin.
Add checks to make sure we don't try to create, use
or return invalid ranges to TSM when it calls us despite
not currently being in an editable region.
* WebView/WebHTMLView.mm:
(isTextInput):
(-[WebHTMLView textStorage]):
(-[WebHTMLView firstRectForCharacterRange:]):
(-[WebHTMLView selectedRange]):
(-[WebHTMLView attributedSubstringFromRange:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22058
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Fri, 8 Jun 2007 00:02:06 +0000 (00:02 +0000)]
LayoutTests:
Reviewed by John.
<rdar://problem/
5237074> REGRESSION: editing/unsupported-content/table-delete-003 is failing (13931)
Corrected the description and added a FIXME:
* editing/unsupported-content/table-delete-003-expected.checksum:
* editing/unsupported-content/table-delete-003-expected.png:
* editing/unsupported-content/table-delete-003-expected.txt:
* editing/unsupported-content/table-delete-003.html:
WebCore:
Reviewed by John.
<rdar://problem/
5237074> REGRESSION: editing/unsupported-content/table-delete-003 is failing (13931)
* editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::initializeStartEnd):
We wouldn't expand the selection to include a special element
at the start of the selection unless the end of the selection
was at the end of a special element. Avoid a special
element at the start as long as it's fully selected. Ditto for
the end.
* editing/htmlediting.cpp:
(WebCore::positionBeforeContainingSpecialElement):
(WebCore::positionAfterContainingSpecialElement):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22057
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Thu, 7 Jun 2007 23:16:37 +0000 (23:16 +0000)]
Reviewed by Geoff.
Get rid of Instance::setRootObject and pass the root object to the instance constructor instead.
* bindings/c/c_instance.cpp:
(KJS::Bindings::CInstance::CInstance):
* bindings/c/c_instance.h:
* bindings/jni/jni_instance.cpp:
(JavaInstance::JavaInstance):
* bindings/jni/jni_instance.h:
* bindings/jni/jni_jsobject.cpp:
(JavaJSObject::convertJObjectToValue):
* bindings/objc/objc_instance.h:
* bindings/objc/objc_instance.mm:
(ObjcInstance::ObjcInstance):
* bindings/runtime.cpp:
(KJS::Bindings::Instance::Instance):
(KJS::Bindings::Instance::createBindingForLanguageInstance):
* bindings/runtime.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22056
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Thu, 7 Jun 2007 22:31:46 +0000 (22:31 +0000)]
Reviewed by Adam.
Don't use a JavaInstance to store the field when all we want to do is to keep the field
from being garbage collected. Instead, use a JObjectWrapper.
* bindings/jni/jni_instance.h:
* bindings/jni/jni_runtime.cpp:
(JavaField::JavaField):
(JavaField::dispatchValueFromInstance):
(JavaField::dispatchSetValueToInstance):
* bindings/jni/jni_runtime.h:
(KJS::Bindings::JavaField::JavaField):
(KJS::Bindings::JavaField::operator=):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22055
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Thu, 7 Jun 2007 20:58:15 +0000 (20:58 +0000)]
LayoutTests:
Reviewed by Anders.
Update test for http://bugs.webkit.org/show_bug.cgi?id=14028
Finish autogenerating the JS bindings for Node
* fast/dom/prototype-chain-expected.txt: DOMNodePrototype is no longer in the prototype chain.
WebCore:
Reviewed by Anders.
Patch for http://bugs.webkit.org/show_bug.cgi?id=14028
Finish autogenerating the JS bindings for Node
* DerivedSources.make:
* WebCore.pro:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSHTMLElementWrapperFactory.cpp:
(WebCore::createJSHTMLWrapper):
* bindings/js/JSHTMLElementWrapperFactory.h:
* bindings/js/JSHTMLOptionElementConstructor.cpp:
* bindings/js/JSNamedNodeMapCustom.cpp:
* bindings/js/JSNodeCustom.cpp:
(WebCore::JSNode::insertBefore):
(WebCore::JSNode::replaceChild):
(WebCore::JSNode::removeChild):
(WebCore::JSNode::appendChild):
(WebCore::JSNode::mark):
(WebCore::toJS):
* bindings/js/JSSVGElementWrapperFactory.cpp:
(WebCore::createJSSVGWrapper):
* bindings/js/JSSVGElementWrapperFactory.h:
* bindings/js/JSXSLTProcessor.cpp:
(KJS::XSLTProcessorPrototypeFunction::callAsFunction):
* bindings/js/kjs_binding.cpp:
(KJS::ScriptInterpreter::getDOMNodeForDocument):
(KJS::ScriptInterpreter::putDOMNodeForDocument):
(KJS::ScriptInterpreter::markDOMNodesForDocument):
(KJS::ScriptInterpreter::updateDOMNodeDocument):
* bindings/js/kjs_binding.h:
* bindings/js/kjs_dom.cpp:
(WebCore::toAttr):
* bindings/js/kjs_dom.h:
* bindings/js/kjs_domnode.h: Removed.
* bindings/objc/DOMUtility.mm:
(KJS::createDOMWrapper):
* bindings/scripts/CodeGeneratorJS.pm:
* dom/Node.h:
(WebCore::Node::parentElement):
* dom/Node.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22048
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
adele [Thu, 7 Jun 2007 18:34:04 +0000 (18:34 +0000)]
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22044
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Thu, 7 Jun 2007 08:07:43 +0000 (08:07 +0000)]
Another Gdk and Qt build fix.
* WebCore.pro:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22043
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Thu, 7 Jun 2007 07:48:30 +0000 (07:48 +0000)]
Gdk and Qt build fix.
* WebCore.pro:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22042
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Thu, 7 Jun 2007 04:28:36 +0000 (04:28 +0000)]
LayoutTests:
Reviewed by Hyatt.
Update tests for http://bugs.webkit.org/show_bug.cgi?id=13973
Autogenerate most of the rest of kjs_dom.h/cpp
* fast/dom/Window/window-properties-expected.txt:
* fast/dom/prototype-chain-expected.txt:
WebCore:
Reviewed by Hyatt.
Patch for http://bugs.webkit.org/show_bug.cgi?id=13973
Autogenerate most of the rest of kjs_dom.h/cpp
- Autogenerate JSNodeList and JSNamedNodeMap.
- Move JSEventTargetNode, JSNamedNodesCollection, and JSDOMExceptionConstructor
into their own files.
- Rename KJS::DOMEventTargeNode to WebCore::JSEventTargetNode to adhere
to convention and allow easier code generation.
- Add JS constructors for JSNodeList and JSNamedNodeMap.
- Moved more toJS methods into the correct (corresponding) header files.
- Cleaned up code in order for changes to work.
* DerivedSources.make:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSDOMExceptionConstructor.cpp: Added.
(WebCore::):
(WebCore::JSDOMExceptionConstructor::JSDOMExceptionConstructor):
(WebCore::JSDOMExceptionConstructor::getOwnPropertySlot):
(WebCore::JSDOMExceptionConstructor::getValueProperty):
(WebCore::getDOMExceptionConstructor):
* bindings/js/JSDOMExceptionConstructor.h: Added.
(WebCore::JSDOMExceptionConstructor::classInfo):
* bindings/js/JSDOMWindowCustom.cpp: Added.
(WebCore::JSDOMWindow::customGetOwnPropertySlot):
* bindings/js/JSDocumentCustom.cpp:
(WebCore::JSDocument::mark):
(WebCore::toJS):
* bindings/js/JSEventTargetNode.cpp: Added.
(WebCore::JSEventTargetNode::JSEventTargetNode):
(WebCore::JSEventTargetNode::getOwnPropertySlot):
(WebCore::JSEventTargetNode::getValueProperty):
(WebCore::JSEventTargetNode::put):
(WebCore::JSEventTargetNode::putValueProperty):
(WebCore::JSEventTargetNode::setListener):
(WebCore::JSEventTargetNode::getListener):
(WebCore::JSEventTargetNode::pushEventHandlerScope):
(WebCore::JSEventTargetNodePrototypeFunction::callAsFunction):
(WebCore::toEventTargetNode):
* bindings/js/JSEventTargetNode.h: Added.
(WebCore::JSEventTargetNode::):
* bindings/js/JSHTMLElementCustom.cpp:
* bindings/js/JSHTMLFormElementCustom.cpp:
(WebCore::JSHTMLFormElement::nameGetter):
* bindings/js/JSHTMLOptionElementConstructor.cpp:
* bindings/js/JSNamedNodeMapCustom.cpp: Added.
(WebCore::JSNamedNodeMap::canGetItemsForName):
(WebCore::JSNamedNodeMap::nameGetter):
* bindings/js/JSNamedNodesCollection.cpp: Added.
(WebCore::):
(WebCore::JSNamedNodesCollection::JSNamedNodesCollection):
(WebCore::JSNamedNodesCollection::lengthGetter):
(WebCore::JSNamedNodesCollection::indexGetter):
(WebCore::JSNamedNodesCollection::getOwnPropertySlot):
* bindings/js/JSNamedNodesCollection.h: Added.
(WebCore::JSNamedNodesCollection::classInfo):
* bindings/js/JSNodeCustom.cpp: Added.
(WebCore::toJS):
* bindings/js/JSNodeListCustom.cpp: Added.
(WebCore::JSNodeList::callAsFunction):
(WebCore::JSNodeList::implementsCall):
(WebCore::JSNodeList::canGetItemsForName):
(WebCore::JSNodeList::nameGetter):
* bindings/js/kjs_dom.cpp:
* bindings/js/kjs_dom.h:
* bindings/js/kjs_domnode.h:
* bindings/js/kjs_events.cpp:
(KJS::JSLazyEventListener::parseCode):
* bindings/js/kjs_html.cpp:
(KJS::JSHTMLCollection::getNamedItems):
* bindings/js/kjs_html.h:
* bindings/js/kjs_window.cpp:
(WebCore::toJS):
* bindings/js/kjs_window.h:
* bindings/objc/DOMInternal.mm:
(-[WebScriptObject _initializeScriptDOMNodeImp]):
* bindings/objc/DOMUtility.mm:
(KJS::createDOMWrapper):
* bindings/scripts/CodeGeneratorJS.pm:
* bridge/mac/WebCoreAXObject.mm:
* dom/Attr.idl:
* dom/CharacterData.idl:
* dom/Document.idl:
* dom/DocumentFragment.idl:
* dom/DocumentType.idl:
* dom/Element.idl:
* dom/NamedNodeMap.idl:
* dom/Node.idl:
* dom/NodeList.idl:
* page/DOMWindow.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22039
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Thu, 7 Jun 2007 03:42:45 +0000 (03:42 +0000)]
LayoutTests:
Reviewed by Oliver.
* editing/pasteboard/
5245519-expected.checksum: Added.
* editing/pasteboard/
5245519-expected.png: Added.
* editing/pasteboard/
5245519-expected.txt: Added.
* editing/pasteboard/
5245519.html: Added.
WebCore:
Reviewed by Oliver.
<rdar://problem/
5245519> CrashTracer: [USER] 457 crashes in Mail at WebCore::CSSComputedStyleDeclaration::copyInheritableProperties()
If the user pastes something into a region that ends up being
invisible, or if the pasted content contains style spans
that are render-less, we'll crash when we try to remove
redundant styles from style spans.
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::copyInheritableProperties):
Add null checks.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22038
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Thu, 7 Jun 2007 03:11:34 +0000 (03:11 +0000)]
LayoutTests:
Reviewed by Harrison.
<rdar://problem/
4889598> Problems with moveDown: and moveUp: in Notes with ToDos
* editing/selection/
4889598-expected.checksum: Added.
* editing/selection/
4889598-expected.png: Added.
* editing/selection/
4889598-expected.txt: Added.
* editing/selection/
4889598.html: Added.
WebCore:
Reviewed by Harrison.
<rdar://problem/
4889598> Problems with moveDown: and moveUp: in Notes with ToDos
The caret would disappear when moving from content above or below
a ToDo if that ToDo doesn't have any content in it with the same
x position as the caret. That's because closestLeafChildForXPos
would return non-editable leaves, and which turn into non-editable
VisiblePositions, which are invisible.
* editing/visible_units.cpp:
(WebCore::previousLinePosition): Ask closestLeafForXPos to only
return editable leaves.
(WebCore::nextLinePosition): Ditto.
* rendering/RootInlineBox.cpp:
(WebCore::isEditableLeaf): Added.
(WebCore::RootInlineBox::closestLeafChildForXPos): If requested,
return the closest editable leaf. Removed an early return if the
position is before the first leaf, it's not really much of an
optimization.
* rendering/RootInlineBox.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22037
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Thu, 7 Jun 2007 02:36:49 +0000 (02:36 +0000)]
Reviewed by Anders.
Fix release build.
* bindings/objc/DOM.mm:
(-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]): Add missing null initialization.
(-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]): Add missing null initialization.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22036
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Thu, 7 Jun 2007 00:54:18 +0000 (00:54 +0000)]
LayoutTests:
Reviewed by Hyatt.
Update results for http://bugs.webkit.org/show_bug.cgi?id=13947
Finish autogenerating the JS DOM traversal code
* fast/dom/Window/window-properties-expected.txt:
WebCore:
Reviewed by Hyatt.
Patch for http://bugs.webkit.org/show_bug.cgi?id=13947
Finish autogenerating the JS DOM traversal code
- Completely generate JSNodeFilter.
- Move JSNodeFilterCondition into its own file
* DerivedSources.make:
* WebCore.pro:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSNodeFilterCondition.cpp: Copied from WebCore/bindings/js/kjs_traversal.cpp.
(WebCore::JSNodeFilterCondition::JSNodeFilterCondition):
(WebCore::JSNodeFilterCondition::mark):
(WebCore::JSNodeFilterCondition::acceptNode):
* bindings/js/JSNodeFilterCondition.h: Copied from WebCore/bindings/js/kjs_traversal.h.
* bindings/js/JSNodeFilterCustom.cpp: Added.
(WebCore::JSNodeFilter::mark):
(WebCore::toNodeFilter):
* bindings/js/kjs_dom.cpp:
* bindings/js/kjs_traversal.cpp: Removed.
* bindings/js/kjs_traversal.h: Removed.
* bindings/js/kjs_window.cpp:
* bindings/objc/DOM.mm:
(-[DOMDocument createNodeIterator:whatToShow:filter:expandEntityReferences:]):
(-[DOMDocument createTreeWalker:whatToShow:filter:expandEntityReferences:]):
* bindings/scripts/CodeGeneratorJS.pm:
* dom/Document.cpp:
(WebCore::Document::createNodeIterator):
(WebCore::Document::createTreeWalker):
* dom/Document.h:
* dom/NodeFilter.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22035
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Wed, 6 Jun 2007 22:37:09 +0000 (22:37 +0000)]
Make sure to hand back a script object for webkit plugins (the container
view forwards to its plugin child).
Reviewed by sullivan
* Plugins/WebKitPluginContainerView.h:
* Plugins/WebKitPluginContainerView.mm:
(-[WebKitPluginContainerView objectForWebScript]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22033
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Wed, 6 Jun 2007 18:42:44 +0000 (18:42 +0000)]
Reviewed by Mark Rowe.
Fixes Bug 13996: http://bugs.webkit.org/show_bug.cgi?id=13996
[Drosera] Items in the file list don't get un-highlighted when
files are selected from the file drop-down
* Drosera/debugger.js: currentFile was getting modified before file in the file
browser got un-highlighted. Changed the order in which the functions execute.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22031
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Wed, 6 Jun 2007 18:14:27 +0000 (18:14 +0000)]
Reviewed by Eric Seidel.
http://bugs.webkit.org/show_bug.cgi?id=14017
Cairo: Unwanted gradient effect for small stretched images
* platform/graphics/cairo/ImageCairo.cpp: Use CAIRO_FILTER_NEAREST to
work around the issue.
(WebCore::BitmapImage::draw):
(WebCore::Image::drawPattern):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22030
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lars [Wed, 6 Jun 2007 14:47:42 +0000 (14:47 +0000)]
Reviewed by Zack
Add an API to create and load plugins.
Don't include moc files by hand anymore, rather let
qmake handle them.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22027
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Wed, 6 Jun 2007 10:55:43 +0000 (10:55 +0000)]
2007-06-06 Mark Rowe <mrowe@apple.com>
Reviewed by Maciej.
http://bugs.webkit.org/show_bug.cgi?id=13988
Bug 13988: Colon in file path crashes WebKit Nightly
The WebKit launcher makes use of two `dyld' variables to coerce Safari into running with
the bundled WebKit framework. Both of these variables are interpreted as containing a
colon-delimited list of paths. There is no escaping mechanism defined, so if we detect
a path with a colon in it we need to bail out to prevent `dyld' from throwing an error
when we execute Safari.
* WebKitLauncher/main.m:
(main):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22026
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Wed, 6 Jun 2007 09:45:49 +0000 (09:45 +0000)]
2007-06-06 Mark Rowe <mrowe@apple.com>
Qt build fix.
* rendering/RenderTextControl.cpp: Fix case of #include filename.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22024
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lars [Wed, 6 Jun 2007 09:01:39 +0000 (09:01 +0000)]
Reviewed by Maciej.
Define WTF_USE_NPOBJECT for Qt. Fix includes
in HTMLPluginElement and add proper forwarding headers
from JavaScriptCore.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22023
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Wed, 6 Jun 2007 08:46:08 +0000 (08:46 +0000)]
Remove bogus assert that is hit depressingly often.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22022
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Wed, 6 Jun 2007 07:05:57 +0000 (07:05 +0000)]
Bulletproof windowClipRect, since it can be called at crazy times.
Part of fix for 13972.
Reviewed by olliej
* bindings/objc/DOM.mm:
(-[DOMElement _windowClipRect]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22020
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Wed, 6 Jun 2007 07:04:17 +0000 (07:04 +0000)]
Fix for bug 13972, quicktime doesn't respect CSS clip and overflow properties.
Make sure that calls to [NSView visibleRect] will do the right thing for both
Netscape plugins and WebKit plugins.
Reviewed by olliej
* Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView visibleRect]):
(-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
(-[WebBaseNetscapePluginView isOpaque]):
* Plugins/WebKitPluginContainerView.h: Added.
* Plugins/WebKitPluginContainerView.mm: Added.
(-[WebKitPluginContainerView initWithFrame:DOMElement:]):
(-[WebKitPluginContainerView dealloc]):
(-[WebKitPluginContainerView visibleRect]):
* Plugins/WebPluginController.mm:
(-[WebPluginController destroyAllPlugins]):
* WebCoreSupport/WebFrameBridge.mm:
(-[WebFrameBridge pluginViewWithPackage:attributeNames:attributeValues:baseURL:DOMElement:loadManually:]):
* WebKit.xcodeproj/project.pbxproj:
* WebView/WebHTMLView.mm:
(-[WebHTMLView addSubview:]):
(-[WebHTMLView willRemoveSubview:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22019
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Wed, 6 Jun 2007 04:17:41 +0000 (04:17 +0000)]
2007-06-05 MorganL <morganl.webkit@yahoo.com>
Reviewed by Dave Hyatt.
Fixes http://bugs.webkit.org/show_bug.cgi?id=14008
* rendering/RenderTextControl.cpp:
(WebCore::RenderTextControl::calcHeight):
(WebCore::RenderTextControl::calcPrefWidths):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22017
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kmccullo [Wed, 6 Jun 2007 02:36:00 +0000 (02:36 +0000)]
Reviewed by.
- Respelling Oliver's name right.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22014
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kmccullo [Wed, 6 Jun 2007 02:32:15 +0000 (02:32 +0000)]
Reviewed by Mark and Olliver.
- http://bugs.webkit.org/show_bug.cgi?id=13352 REGRESSION: Gmail hangs on send message.
- Now we don't hang, but we do so by avoiding certain legitimate characters, the evangelism bug for this is: <rdar://problem/
5252577> gmail does not accept legal characters in the form boundary
* html/HTMLFormElement.cpp:
(WebCore::getUniqueBoundaryString):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@22013
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Tue, 5 Jun 2007 21:01:59 +0000 (21:01 +0000)]
Build fix.
* xml/xmlhttprequest.cpp:
(WebCore::isValidToken):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21982
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Tue, 5 Jun 2007 20:47:19 +0000 (20:47 +0000)]
LayoutTests:
Reviewed by Geoff.
<rdar://problem/
5245555> REGRESSION: HTTP header injection in XMLHttpRequest.setRequestHeader
<rdar://problem/
5246208> HTTP injection in XMLHttpRequest.open method parameter
<rdar://problem/
5246242> HTTP header injection in HXMLHttpRequest.setRequestHeader header parameter
* fast/dom/xmlhttprequest-invalid-values-expected.txt: Added.
* fast/dom/xmlhttprequest-invalid-values.html: Added.
WebCore:
Reviewed by Geoff.
<rdar://problem/
5245555> REGRESSION: HTTP header injection in XMLHttpRequest.setRequestHeader
<rdar://problem/
5246208> HTTP injection in XMLHttpRequest.open method parameter
<rdar://problem/
5246242> HTTP header injection in HXMLHttpRequest.setRequestHeader header parameter
Check method names, header names and header values and throw exceptions if any of them are
invalid. This is what the new XMLHttpRequest spec states that we should do.
* xml/xmlhttprequest.cpp:
(WebCore::isValidToken):
(WebCore::isValidHeaderValue):
(WebCore::XMLHttpRequest::open):
(WebCore::XMLHttpRequest::setRequestHeader):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21981
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Tue, 5 Jun 2007 20:33:54 +0000 (20:33 +0000)]
Reviewed by Geoff.
Optimize JSCSSStyleDeclaration after performance regression in r21854.
- Check static table before name getter in JSCSSStyleDeclaration::getOwnPropertySlot()
- Get rid of a string allocation by keeping string as KJS::Identifier for canGetItemsForName()
functions.
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSCSSStyleDeclarationCustom.cpp:
(WebCore::JSCSSStyleDeclaration::canGetItemsForName):
* bindings/js/JSHTMLAppletElementCustom.cpp:
(WebCore::JSHTMLAppletElement::canGetItemsForName):
* bindings/js/JSHTMLDocumentCustom.cpp:
(WebCore::JSHTMLDocument::canGetItemsForName):
* bindings/js/JSHTMLEmbedElementCustom.cpp:
(WebCore::JSHTMLEmbedElement::canGetItemsForName):
* bindings/js/JSHTMLFormElementCustom.cpp:
(WebCore::JSHTMLFormElement::canGetItemsForName):
* bindings/js/JSHTMLFrameSetElementCustom.cpp:
(WebCore::JSHTMLFrameSetElement::canGetItemsForName):
* bindings/js/JSHTMLObjectElementCustom.cpp:
(WebCore::JSHTMLObjectElement::canGetItemsForName):
* bindings/scripts/CodeGeneratorJS.pm:
* css/CSSStyleDeclaration.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21979
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver [Tue, 5 Jun 2007 00:15:31 +0000 (00:15 +0000)]
Reviewed by Geoff and Justin.
Fix for <rdar://problem/
5246941> Clicking URL field on
Safari causes halt for a minute when using input methods.
and <rdar://problem/
5245964> Safari hangs for several
seconds when trying to select text using mouse
This is a by product of the textStorage hack used to fix
rdar://problem/
5000470 -- TSM calls textStorage repeatedly
when changing focus, on certain mouse events, etc. If there
is no selection/editable region we repeatedly create an
NSAttributedString from the full document. If the document is
sufficiently long this starts consuming an inordinate amount of
time.
This check should really have been present in the original
patch.
* WebKit.xcodeproj/project.pbxproj:
* WebView/WebHTMLView.mm:
(-[WebHTMLView textStorage]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21976
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Tue, 5 Jun 2007 00:10:40 +0000 (00:10 +0000)]
Reviewed, tweaked and landed by Anders.
<rdar://problem/
5247178> REGRESSION: With CSS Edit 2.5, a crash occurs at WebCore::DeprecatedString::DeprecatedString when page fails to be extracted
Null check the provisional document loader. If an application stops the load
inside of the didFailProvisionalLoad delegate method, the provisional document loader will be nulled out.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::checkLoadCompleteForThisFrame):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21975
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Mon, 4 Jun 2007 23:43:38 +0000 (23:43 +0000)]
2007-06-04 Alp Toker <alp.toker@collabora.co.uk>
Reviewed by Anders.
http://bugs.webkit.org/show_bug.cgi?id=13986
Cairo graphics fixes and cleanups
* platform/graphics/ImageBuffer.h:
* platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::ImageBuffer::surface): Provide surface() accessor.
* platform/graphics/cairo/AffineTransformCairo.cpp:
(WebCore::AffineTransform::rotate): Convert from degrees to radians to
fix rotation.
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::drawRect): Add save/restore.
(WebCore::GraphicsContext::rotate): Rename parameter to "radians" to
avoid further confusion.
* platform/graphics/cairo/PathCairo.cpp:
(WebCore::Path::boundingRect): The cairo_fill_extents() parameters do
not describe a point/size but rather the two control points of the
rectangular region.
(WebCore::Path::contains): Remove needless casts.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21974
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Mon, 4 Jun 2007 23:40:53 +0000 (23:40 +0000)]
2007-06-05 Mark Rowe <mrowe@apple.com>
Reviewed by Anders.
* WebKitLauncher/Info.plist: Update CFBundleGetInfoString, and add CFBundleShortVersionString.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21973
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Mon, 4 Jun 2007 21:27:08 +0000 (21:27 +0000)]
Reviewed by Adam Roben.
Fix the buildbot.
* rendering/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::layout):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21969
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Mon, 4 Jun 2007 18:39:10 +0000 (18:39 +0000)]
LayoutTests:
Reviewed by Kimon Tsinteris.
<rdar://problem/
5241148> REGRESSION: ActivEdit can't perform operations on certain selections
Demonstrates bug:
* editing/selection/
5241148-expected.txt: Added.
* editing/selection/
5241148.html: Added.
Updated to reflect new equivalents for positions before/after tables:
* editing/selection/click-before-and-after-table-expected.txt:
* editing/selection/click-before-and-after-table.html:
WebCore:
Reviewed by Kimon Tsinteris.
<rdar://problem/
5241148> REGRESSION: ActivEdit can't perform operations on certain selections
Return valid equivalents from these methods (no [img, 1] for
example). ActivEdit was using positions returned from these
methods to create new DOM Ranges.
* editing/SelectionController.cpp:
(WebCore::SelectionController::baseNode):
(WebCore::SelectionController::baseOffset):
(WebCore::SelectionController::extentNode):
(WebCore::SelectionController::extentOffset):
(WebCore::SelectionController::anchorNode):
(WebCore::SelectionController::anchorOffset):
(WebCore::SelectionController::focusNode):
(WebCore::SelectionController::focusOffset):
* editing/SelectionController.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21968
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis [Mon, 4 Jun 2007 13:41:08 +0000 (13:41 +0000)]
Fix the svg experimental build.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21967
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Mon, 4 Jun 2007 09:41:09 +0000 (09:41 +0000)]
2007-05-04 Mark Rowe <mrowe@apple.com>
Upgrade to WordPress 2.2. I didn't go to the effort of tracking down files
present in the old version which have since been removed, but it's unlikely
they'll ever cause a problem.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21966
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Mon, 4 Jun 2007 08:30:58 +0000 (08:30 +0000)]
2007-05-04 Mark Rowe <mrowe@apple.com>
Add graphics used by existing blog posts into SVN.
* blog/wp-content/rotate.png: Added.
* blog/wp-content/drosera.png: Added.
* blog/wp-content/hitlist.png: Added.
* blog/wp-content/svgtextmini.png: Added.
* blog/wp-content/svgtextmini_01.png: Added.
* blog/wp-content/textfield_screenshot.jpg: Added.
* blog/wp-content/Picture9.png: Added.
* blog/wp-content/svgtext.png: Added.
* blog/wp-content/webInspector.png: Added.
* blog/wp-content/rotate.svg: Added.
* blog/wp-content/chucknorris.png: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21965
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rwlbuis [Mon, 4 Jun 2007 08:04:55 +0000 (08:04 +0000)]
Reviewed by Hyatt.
http://bugs.webkit.org/show_bug.cgi?id=6170
CSS1: Properties for :first-letter aren't recalculated on color change
Mark styles with first-letter as unique.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21964
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca [Sat, 2 Jun 2007 02:37:45 +0000 (02:37 +0000)]
Reviewed by David Harrison.
<rdar://problem/
5236843>
CrashTracer: [USER] 3 crashes in Mail at WebCore::Loader::didReceiveResponse(WebCore::SubresourceLoader*, WebCore::ResourceResponse const&)
This is by no means the best solution for handling user style sheets. I've filed <rdar://problem/
5244734>
for tracking that.
* loader/loader.cpp:
(WebCore::Loader::didReceiveResponse):
If a load starts while the frame is still in the provisional state
(this can be the case when loading the user style sheet), committing the load then causes all
requests to be removed from the m_requestsLoading map. This means that req might be null here.
In that case we just return early.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21952
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Fri, 1 Jun 2007 23:54:33 +0000 (23:54 +0000)]
Reviewed by Adele.
- fix http://bugs.webkit.org/show_bug.cgi?id=13958
REGRESSION: Form select menu in iframe destroys form select menu on page
* page/mac/EventHandlerMac.mm:
(WebCore::EventHandler::sendFakeEventsAfterWidgetTracking): Instead of calling
the event handler methods directly, post the fake event on the application event
queue. This ensures that the fake event is handled only after handling of the
initiating event has ended, and is seen by ancestor frames' event handlers.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21950
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos [Fri, 1 Jun 2007 12:47:35 +0000 (12:47 +0000)]
2007-06-01 George Staikos <staikos@kde.org>
Reviewed by bdash.
Redo the build fix again after it was backed out
* WebCore.pro: add an include guard around CSSGrammar.h
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21938
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Fri, 1 Jun 2007 09:34:57 +0000 (09:34 +0000)]
Roll out r21916 as it did nothing to fix the build.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21935
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ggaren [Fri, 1 Jun 2007 07:25:38 +0000 (07:25 +0000)]
Reviewed by Beth Dakin.
Fixed <rdar://problem/
5238177> Continuing after hitting breakpoint doesn't
execute the next step.
No test because the only code affected is the debugger, and none of the
relevant API is exported.
Reverted an accidental change in 21324 that caused originRootObject for
the window object always to be 0. We could probably just remove the debugger's
dependency on originRootObject, but I wanted to be safe.
* page/mac/FrameMac.mm:
(WebCore::Frame::windowScriptObject):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21933
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hyatt [Fri, 1 Jun 2007 05:57:33 +0000 (05:57 +0000)]
WebCore:
Fix for 11768, Flash plugin does not respect clips set via CSS.
Reviewed by olliej
* bindings/objc/DOM.mm:
(-[DOMElement _windowClipRect]):
* bindings/objc/DOMPrivate.h:
* page/FrameView.cpp:
(WebCore::FrameView::windowClipRect):
(WebCore::FrameView::windowClipRectForLayer):
* platform/ScrollView.h:
(WebCore::ScrollView::contentsToWindow):
(WebCore::ScrollView::windowToContents):
* platform/mac/ScrollViewMac.mm:
(WebCore::ScrollView::contentsToWindow):
(WebCore::ScrollView::windowToContents):
WebKit:
Fix for 11768, Flash plugin does not respect clips set by CSS.
Reviewed by olliej
* Plugins/WebBaseNetscapePluginView.mm:
(-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21932
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Fri, 1 Jun 2007 05:46:58 +0000 (05:46 +0000)]
Reviewed by Adam.
Update test to reflect new correct result.
* fast/dom/Window/atob-btoa-expected.txt:
* fast/dom/Window/atob-btoa.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21931
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Fri, 1 Jun 2007 05:45:08 +0000 (05:45 +0000)]
Reviewed by Adam.
Fix build bot.
* ksvg2/svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::setCurrentScale):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21930
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Fri, 1 Jun 2007 03:19:32 +0000 (03:19 +0000)]
Fix Qt and Gdk builds.
* WebCore.pro: remove bindings/js/JSHTMLAnchorElementCustom.cpp
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21928
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Fri, 1 Jun 2007 03:13:44 +0000 (03:13 +0000)]
LayoutTests:
Reviewed by Geoff.
Tests for http://bugs.webkit.org/show_bug.cgi?id=10782
Classes should not override JSObject::toString(ExecState *)
- Adds a new test to test overriding toString and valueOf for
multiple objects.
- Update tests to reflect the correction of the toString architecture.
* editing/selection/getRangeAt-expected.txt:
* fast/dom/Window/atob-btoa-expected.txt:
* fast/js/toString-and-valueOf-override-expected.txt: Added.
* fast/js/toString-and-valueOf-override.html: Added.
WebCore:
Reviewed by Geoff.
Patch for http://bugs.webkit.org/show_bug.cgi?id=10782
Classes should not override JSObject::toString(ExecState *)
Remove all overrides of JSObject::toString and JSObject::toPrimitive
which is a bad practice. Instead, if an object, like the
HTMLAnchorElement, needs to override to toString, it should add
a function to the JS object which will be called when needed. This
also allows developers to override toString and valueOf from within JS.
Test: fast/js/toString-and-valueOf-override.html
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSHTMLAnchorElementCustom.cpp: Removed.
* bindings/js/kjs_binding.cpp:
* bindings/js/kjs_binding.h:
* bindings/js/kjs_dom.cpp:
* bindings/js/kjs_dom.h:
* bindings/js/kjs_domnode.h:
* bindings/js/kjs_window.cpp:
(KJS::History::):
(KJS::LocationFunc::callAsFunction):
(KJS::SelectionFunc::callAsFunction):
* bindings/js/kjs_window.h:
* bindings/scripts/CodeGeneratorJS.pm:
* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::toString):
* html/HTMLAnchorElement.h:
* html/HTMLAnchorElement.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21927
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Fri, 1 Jun 2007 01:52:31 +0000 (01:52 +0000)]
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=11272
Implement currentScale(), setCurrentScale() and currentTranslate() in SVGSVGElement
Allow zooming and panning, thereby implementing the above methods.
* ksvg2/svg/SVGDocument.cpp:
(WebCore::SVGDocument::zoomEnabled):
(WebCore::SVGDocument::startPan):
(WebCore::SVGDocument::updatePan):
* ksvg2/svg/SVGDocument.h:
* ksvg2/svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::currentScale):
(WebCore::SVGSVGElement::setCurrentScale):
(WebCore::SVGSVGElement::currentTranslate):
(WebCore::SVGSVGElement::setCurrentTranslate):
* ksvg2/svg/SVGSVGElement.h:
* page/EventHandler.cpp:
(WebCore::EventHandler::EventHandler):
(WebCore::EventHandler::handleMousePressEvent):
(WebCore::EventHandler::handleMouseMoveEvent):
(WebCore::EventHandler::handleMouseReleaseEvent):
* page/EventHandler.h:
* page/Frame.cpp:
(WebCore::Frame::setZoomFactor):
* rendering/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::layout):
(WebCore::RenderSVGContainer::paint):
(WebCore::RenderSVGContainer::absoluteTransform):
* rendering/RenderSVGContainer.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21925
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Fri, 1 Jun 2007 01:35:51 +0000 (01:35 +0000)]
LayoutTests:
Reviewed by Niko.
Test for fix: http://bugs.webkit.org/show_bug.cgi?id=12570
* svg/custom/prevent-default-expected.checksum: Added.
* svg/custom/prevent-default-expected.png: Added.
* svg/custom/prevent-default-expected.txt: Added.
* svg/custom/prevent-default.svg: Added.
WebCore:
Reviewed by Niko.
Links are activated based on mouse down events instead of click events
http://bugs.webkit.org/show_bug.cgi?id=12570
Test: svg/custom/prevent-default.svg
* html/HTMLAnchorElement.cpp: use MiddleButton and RightButton instead of 1 and 2
(WebCore::HTMLAnchorElement::defaultEventHandler):
* ksvg2/svg/SVGAElement.cpp:
(WebCore::SVGAElement::defaultEventHandler): make it function more like the HTML side
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21924
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Fri, 1 Jun 2007 00:21:21 +0000 (00:21 +0000)]
Reviewed by Hyatt.
- fix layout test editing/style/table-selection.html
* editing/style/table-selection-expected.txt: Updated selection delegate output.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21923
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs [Fri, 1 Jun 2007 00:19:05 +0000 (00:19 +0000)]
LayoutTests:
Reviewed by Hyatt.
- fix layout test editing/style/table-selection.html
* editing/style/table-selection-expected.txt: Updated selection delegate output.
WebCore:
Reviewed by Hyatt.
- fix layout test editing/style/table-selection.html
This was broken by the change to keep whitespace text nodes in tables. They safely didn't render,
but the font delta style change command would wrap them in spans, creating extra anonymous table
cells.
* editing/ApplyStyleCommand.cpp:
(WebCore::ApplyStyleCommand::applyRelativeFontStyleChange): Don't wrap in a span if the text node
is not rendered.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21922
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Thu, 31 May 2007 23:50:37 +0000 (23:50 +0000)]
top level:
Reviewed by Eric Seidel.
http://bugs.webkit.org/show_bug.cgi?id=13941
Rename WebCore/platform/network/gdk to WebCore/platform/network/curl
* WebKit.pri:
WebCore:
Reviewed by Eric Seidel.
http://bugs.webkit.org/show_bug.cgi?id=13941
Rename WebCore/platform/network/gdk to WebCore/platform/network/curl
* WebCore.pro:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21921
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Thu, 31 May 2007 20:33:37 +0000 (20:33 +0000)]
Reviewed by Niko.
Patch for http://bugs.webkit.org/show_bug.cgi?id=13945
GraphicsContextCairo enhancements necessary for SVG support
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::concatCTM):
(WebCore::GraphicsContext::beginPath):
(WebCore::GraphicsContext::addPath):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21919
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pyeh [Thu, 31 May 2007 19:49:35 +0000 (19:49 +0000)]
<rdar://problem/
5221920> AXLink is returning a CFString instead of a CFURL for AXURL
* bridge/mac/WebCoreAXObject.mm:
(-[WebCoreAXObject accessibilityAttributeValue:]):
Convert the url string to an NSURL before returning as the AXURLAttribute
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21917
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
staikos [Thu, 31 May 2007 19:44:19 +0000 (19:44 +0000)]
2007-05-31 George Staikos <staikos@kde.org>
Reviewed by Nikolas.
Compile again - Qt build.
* WebCore.pro: header guard added to CSSGrammar.h
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21916
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Thu, 31 May 2007 05:21:11 +0000 (05:21 +0000)]
LayoutTests:
Reviewed by Oliver.
Update results for http://bugs.webkit.org/show_bug.cgi?id=13943
Autogenerate the JS bindings for the CSSStyleSheet
* fast/dom/Window/window-properties-expected.txt:
WebCore:
Reviewed by Oliver.
Patch for http://bugs.webkit.org/show_bug.cgi?id=13943
Autogenerate the JS bindings for the CSSStyleSheet
* DerivedSources.make:
* WebCore.pro:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSStyleSheetCustom.cpp:
(WebCore::toJS):
* bindings/js/kjs_css.cpp:
* bindings/js/kjs_css.h:
* bindings/scripts/CodeGeneratorJS.pm:
* css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::addRule):
(WebCore::CSSStyleSheet::cssRules):
* css/CSSStyleSheet.h:
(WebCore::CSSStyleSheet::rules):
(WebCore::CSSStyleSheet::removeRule):
* css/CSSStyleSheet.idl:
* page/DOMWindow.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21911
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Thu, 31 May 2007 05:05:11 +0000 (05:05 +0000)]
Reviewed by Oliver.
Patch for http://bugs.webkit.org/show_bug.cgi?id=13937
Autogenerate the JS bindings for the CSSValue
* WebCore.pro:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSCSSValueCustom.cpp: Added.
(WebCore::toJS):
* bindings/js/kjs_css.cpp:
* bindings/js/kjs_css.h:
* bindings/objc/DOMUtility.mm:
(KJS::createDOMWrapper):
* bindings/scripts/CodeGeneratorJS.pm:
* css/CSSValue.h:
(WebCore::CSSValue::setCssText):
* css/CSSValue.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21910
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Thu, 31 May 2007 03:36:08 +0000 (03:36 +0000)]
LayoutTests:
Reviewed by Oliver the Hun.
Update results for http://bugs.webkit.org/show_bug.cgi?id=13944
Generate and add missing JS constructors
* fast/dom/Window/window-properties-expected.txt:
WebCore:
Reviewed by Oliver the Hun.
Patch for http://bugs.webkit.org/show_bug.cgi?id=13944
Generate and add missing JS constructors
* css/CSSRuleList.idl:
* css/CSSValueList.idl:
* css/Counter.idl:
* page/DOMWindow.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21909
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Thu, 31 May 2007 00:39:14 +0000 (00:39 +0000)]
Reviewed by Darin.
http://bugs.webkit.org/show_bug.cgi?id=13915
REGRESSION(r21687): editing/inserting/paragraph-separator-* failing pixel test (misspelling markers)
After r21687, SimplifiedBackwardsTextIterator was no longer
emitting a '\n' as it left the first block of a range ending
at [block, 0]. So, foo<div>^<br></div> looked like foo^ to
spell checking (foo wasn't marked as misspelled).
After r21687, SBTI stopped emitting '\n's in the above case
because 1) we stopped incorrectly emitting '\n's for nodes as
we entered them and 2) we were and still are incorrectly calling
code that should only be called when entering nodes as we leave
them and 3) we don't call exitNode(), which is responsible
for emitting the '\n' in the above testcase, when we should.
Before and after r21687, we'd call exitNode() for a node as
we traversed in reverse pre-order from its first descendant
out to its sibling or one of its ancestors' siblings. We
weren't calling it a) after we'd enter a node that could
have children but had none and b) when leaving a container
that contained the end of the range used to create the iterator.
* editing/TextIterator.cpp:
(WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator):
(WebCore::SimplifiedBackwardsTextIterator::advance): Call exitNode() as we
leave a childless container node and a node where the range ended.
* editing/TextIterator.h: Track the end of the range used to create
the SimplifiedBackwardsTextIterator.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21908
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Thu, 31 May 2007 00:23:03 +0000 (00:23 +0000)]
Update ChangeLogs with correct Bugzilla URLs.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21907
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Thu, 31 May 2007 00:16:27 +0000 (00:16 +0000)]
JavaScriptCore:
Reviewed by Brady.
Enable logging in the Gdk port.
http://bugs.webkit.org/show_bug.cgi?id=13029
* wtf/Assertions.cpp:
* wtf/Assertions.h: Add WTFLogVerbose which also logs
the file, line number and function.
WebCore:
Reviewed by Brady.
Enable logging in the Gdk port.
http://bugs.webkit.org/show_bug.cgi?id=13029
* WebCore.pro:
* platform/NotImplemented.h: Changed to use WTFLogVerbose.
* platform/gdk/LoggingGdk.cpp: Added.
(WebCore::InitializeLoggingChannelsIfNecessary):
WebKitTools:
Reviewed by Brady.
Enable logging in the Gdk port.
http://bugs.webkit.org/show_bug.cgi?id=13029
* GdkLauncher/main.cpp:
(main):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21906
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdakin [Wed, 30 May 2007 23:03:51 +0000 (23:03 +0000)]
Reviewed by Hyatt.
Fix for <rdar://problem/
5198882> CrashTracer: [USER] 7 crashes in
Safari at com.apple.WebCore: WebCore::RenderBlock::layoutBlock +
2360
The problem is that we are re-entering layout when we should not.
http://trac.webkit.org/projects/webkit/changeset/21778 actually
fixed this crash, but we have been inspired to add the same guard
in two other possibly-dangerous places.
* page/FrameView.cpp:
(WebCore::FrameView::layout): Add the guard in two more places.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21905
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
justing [Wed, 30 May 2007 22:06:51 +0000 (22:06 +0000)]
Reviewed by Oliver.
<rdar://problem/
5096134> VO gets stuck on Howto.apple.com
http://bugs.webkit.org/show_bug.cgi?id=8622
VisiblePositions aren't canonicalized in some cases
No new test cases added: can't write automated tests
for VO.
* editing/IndentOutdentCommand.cpp:
(WebCore::IndentOutdentCommand::outdentParagraph):
VisiblePositions must be recomputed after nodes that
may have effected their canonicalization are removed.
* editing/VisiblePosition.cpp:
(WebCore::canonicalizeCandidate): Added.
(WebCore::VisiblePosition::canonicalPosition): Canonicalize
the candidates returned by next/previousCandidate before
returning them.
* editing/VisiblePosition.h:
(WebCore::operator==): Remove the workaround for 8622.
* editing/visible_units.cpp:
(WebCore::startOfParagraph): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21904
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Wed, 30 May 2007 21:08:16 +0000 (21:08 +0000)]
LayoutTests:
Reviewed by Dr. Harrison.
Patch for http://bugs.webkit.org/show_bug.cgi?id=13868
REGRESSION: crash on accessing a new iframe's contentWindow property
* fast/dom/frame-contentWindow-crash-expected.txt: Added.
* fast/dom/frame-contentWindow-crash.html: Added.
* fast/dom/iframe-contentWindow-crash-expected.txt: Added.
* fast/dom/iframe-contentWindow-crash.html: Added.
WebCore:
Reviewed by Dr. Harrison.
Patch for http://bugs.webkit.org/show_bug.cgi?id=13868
REGRESSION: crash on accessing a new iframe's contentWindow property
Adds a null check in for the contentWindow property for HTMLIFrameElement
and HTMLFrameElement.
* bindings/scripts/CodeGeneratorJS.pm:
* html/HTMLFrameElement.idl:
* html/HTMLIFrameElement.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21902
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bdash [Wed, 30 May 2007 19:16:19 +0000 (19:16 +0000)]
2007-05-30 Mitz Pettel <mitz@webkit.org>
Reviewed by Darin.
- fix http://bugs.webkit.org/show_bug.cgi?id=13775
REGRESSION: Popup button text should use "natural" directionality to match the items in the popup menu
Test: fast/forms/select-writing-direction-natural.html
* platform/PopupMenu.h: Added the static method itemWritingDirectionIsNatural
which says whether items in the popup ignore the CSS text-align and direction
properties and instead are left-aligned and use natural writing direction.
* platform/gdk/PopupMenuGdk.cpp:
(WebCore::PopupMenu::itemWritingDirectionIsNatural):
* platform/mac/PopupMenuMac.mm:
(WebCore::PopupMenu::itemWritingDirectionIsNatural):
* platform/qt/PopupMenuQt.cpp:
(WebCore::PopupMenu::itemWritingDirectionIsNatural):
* platform/win/TemporaryLinkStubs.cpp:
(WebCore::PopupMenu::itemWritingDirectionIsNatural):
* platform/wx/TemporaryLinkStubs.cpp:
(PopupMenu::itemWritingDirectionIsNatural):
* rendering/RenderMenuList.cpp:
(WebCore::textDirectionForParagraph): Added this helper function that uses
the Unicode Bidi Algorithm rules P2 and P3 to determine the writing direction
of text.
(WebCore::RenderMenuList::adjustInnerStyle): Made the alignment and direction
adjustment conditional on the popup implementation.
(WebCore::RenderMenuList::setText): Added call to adjustInnerStyle() since
the style depends on the text when natural writing direction is used.
2007-05-30 Mitz Pettel <mitz@webkit.org>
Reviewed by Darin.
- test for http://bugs.webkit.org/show_bug.cgi?id=13775
REGRESSION: Popup button text should use "natural" directionality to match the items in the popup menu
* fast/forms/select-writing-direction-natural-expected.checksum: Added.
* fast/forms/select-writing-direction-natural-expected.png: Added.
* fast/forms/select-writing-direction-natural-expected.txt: Added.
* fast/forms/select-writing-direction-natural.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21900
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Wed, 30 May 2007 18:57:10 +0000 (18:57 +0000)]
Add radar to ChangeLog.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21899
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Wed, 30 May 2007 18:45:50 +0000 (18:45 +0000)]
Reviewed by Hyatt.
- http://bugs.webkit.org/show_bug.cgi?id=13932
REGRESSION: fast/dynamic/containing-block-change is failing
* fast/dynamic/containing-block-change.html: Removed whitespace that
got turned into text nodes, thereby making lastNode be not what the script
expected it to be.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21898
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
thatcher [Wed, 30 May 2007 18:11:05 +0000 (18:11 +0000)]
Reviewed by Darin.
<rdar://problem/
5200795> REGRESSION (r21057): lineBoxRects doesn't match actual text when wrapping occurs
Use box->end() instead of box->len().
* rendering/RenderText.cpp:
(WebCore::RenderText::addLineBoxRects):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21897
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig [Wed, 30 May 2007 17:43:55 +0000 (17:43 +0000)]
LayoutTests:
Reviewed by Darin.
- Update results for http://bugs.webkit.org/show_bug.cgi?id=13919
Autogenerate the JS bindings for the CSSRule and its subclasses
* fast/dom/Window/window-properties-expected.txt: adds new constructors
* fast/dom/wrapper-classes-expected.txt: CSSStyleRule now passes!!
WebCore:
Reviewed by Darin.
Patch for http://bugs.webkit.org/show_bug.cgi?id=13919
Autogenerate the JS bindings for the CSSRule and its subclasses
- subclasses generated are CSSCharsetRule, CSSFontFaceRule, CSSImportRule
CSSMediaRule, CSSPageRule and CSSStyleRule.
* DerivedSources.make:
* WebCore.pro:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSCSSRuleCustom.cpp: Added.
(WebCore::toJS):
* bindings/js/kjs_css.cpp:
* bindings/js/kjs_css.h:
* bindings/objc/DOMUtility.mm:
(KJS::createDOMWrapper):
* bindings/scripts/CodeGeneratorJS.pm:
* css/CSSCharsetRule.h:
(WebCore::CSSCharsetRule::setEncoding):
* css/CSSCharsetRule.idl:
* css/CSSFontFaceRule.idl:
* css/CSSImportRule.idl:
* css/CSSMediaRule.idl:
* css/CSSPageRule.cpp:
(WebCore::CSSPageRule::setSelectorText):
* css/CSSPageRule.h:
* css/CSSPageRule.idl:
* css/CSSRule.cpp:
(WebCore::CSSRule::setCssText):
* css/CSSRule.h:
* css/CSSRule.idl:
* css/CSSStyleRule.cpp:
(WebCore::CSSStyleRule::setSelectorText):
* css/CSSStyleRule.h:
* css/CSSStyleRule.idl:
* page/DOMWindow.idl: add new constructors.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@21896
268f45cc-cd09-0410-ab3c-
d52691b4dbfc