WebKit-https.git
10 years ago2011-06-29 Levi Weintraub <leviw@chromium.org>
leviw@chromium.org [Wed, 29 Jun 2011 21:33:11 +0000 (21:33 +0000)]
2011-06-29  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Eric Seidel.

        Switch paint to new layout types
        https://bugs.webkit.org/show_bug.cgi?id=63645

        Switch vanilla paint function over to the new layout unit abstraction.

        No new tests, no functionality changes.

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::paint):
        * rendering/RenderBlock.h:
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::paint):
        * rendering/RenderBox.h:
        * rendering/RenderDetailsMarker.cpp:
        (WebCore::RenderDetailsMarker::paint):
        * rendering/RenderDetailsMarker.h:
        * rendering/RenderEmbeddedObject.cpp:
        (WebCore::RenderEmbeddedObject::paint):
        * rendering/RenderEmbeddedObject.h:
        * rendering/RenderFrameSet.cpp:
        (WebCore::RenderFrameSet::paint):
        * rendering/RenderFrameSet.h:
        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::paint):
        * rendering/RenderImage.h:
        * rendering/RenderInline.cpp:
        (WebCore::RenderInline::paint):
        * rendering/RenderInline.h:
        * rendering/RenderLineBoxList.h:
        * rendering/RenderListItem.cpp:
        (WebCore::RenderListItem::paint):
        * rendering/RenderListItem.h:
        * rendering/RenderListMarker.cpp:
        (WebCore::RenderListMarker::paint):
        * rendering/RenderListMarker.h:
        * rendering/RenderObject.h:
        * rendering/RenderReplaced.cpp:
        (WebCore::RenderReplaced::paint):
        * rendering/RenderReplaced.h:
        * rendering/RenderReplica.cpp:
        (WebCore::RenderReplica::paint):
        * rendering/RenderReplica.h:
        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::paint):
        * rendering/RenderTable.h:
        * rendering/RenderTableCell.cpp:
        (WebCore::RenderTableCell::paint):
        * rendering/RenderTableCell.h:
        * rendering/RenderTableRow.cpp:
        (WebCore::RenderTableRow::paint):
        * rendering/RenderTableRow.h:
        * rendering/RenderTableSection.cpp:
        (WebCore::RenderTableSection::paint):
        * rendering/RenderTableSection.h:
        * rendering/RenderTextControlSingleLine.cpp:
        (WebCore::RenderTextControlSingleLine::paint):
        * rendering/RenderTextControlSingleLine.h:
        * rendering/RenderTheme.h:
        * rendering/RenderView.cpp:
        (WebCore::RenderView::paint):
        * rendering/RenderView.h:
        * rendering/RenderWidget.cpp:
        (WebCore::RenderWidget::paint):
        * rendering/RenderWidget.h:
        * rendering/mathml/RenderMathMLBlock.h:
        * rendering/mathml/RenderMathMLFraction.h:
        * rendering/mathml/RenderMathMLRoot.h:
        * rendering/mathml/RenderMathMLSquareRoot.h:
        * rendering/svg/RenderSVGContainer.h:
        * rendering/svg/RenderSVGForeignObject.h:
        * rendering/svg/RenderSVGHiddenContainer.h:
        * rendering/svg/RenderSVGImage.h:
        * rendering/svg/RenderSVGPath.h:
        * rendering/svg/RenderSVGRoot.cpp:
        (WebCore::RenderSVGRoot::paint):
        * rendering/svg/RenderSVGRoot.h:
        * rendering/svg/RenderSVGText.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed build correction.
bfulgham@webkit.org [Wed, 29 Jun 2011 21:29:58 +0000 (21:29 +0000)]
Unreviewed build correction.

* DumpRenderTree/win/ImageDiffWinCairoCommon.vsprops:
Link against zlib1.dll, not the static zlib.lib.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebGL test failing on SL bots: fast/canvas/webgl/data-view-test.html
jianli@chromium.org [Wed, 29 Jun 2011 21:28:55 +0000 (21:28 +0000)]
WebGL test failing on SL bots: fast/canvas/webgl/data-view-test.html
https://bugs.webkit.org/show_bug.cgi?id=63151

Reviewed by Kenneth Russell.

Source/WebCore:

The fix is to change to throw TypeError in custom JS/V8 bindings.

* bindings/js/JSDataViewCustom.cpp:
(WebCore::getDataViewMember):
(WebCore::setDataViewMember):
* bindings/v8/custom/V8DataViewCustom.cpp:
(WebCore::V8DataView::constructorCallback):
(WebCore::V8DataView::getInt8Callback):

LayoutTests:

Updated the expected result and removed the rebaselined files that are not needed.

* fast/canvas/webgl/data-view-test-expected.txt:
* platform/chromium-mac/fast/canvas/webgl/data-view-test-expected.txt: Removed.
* platform/chromium-win/fast/canvas/webgl/data-view-test-expected.txt: Removed.
* platform/mac/fast/canvas/webgl/data-view-test-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-06-29 Luke Macpherson <macpherson@chromium.org>
macpherson@chromium.org [Wed, 29 Jun 2011 21:25:59 +0000 (21:25 +0000)]
2011-06-29  Luke Macpherson   <macpherson@chromium.org>

        Reviewed by Darin Adler.

        Convert uses of computeLengthIntForLength() to computeLength<Length>()
        https://bugs.webkit.org/show_bug.cgi?id=63641

        No new tests / refactoring only.

        * css/CSSStyleSelector.cpp:
        (WebCore::convertToLength):
        (WebCore::CSSStyleSelector::applyProperty):
        (WebCore::CSSStyleSelector::applyPageSizeProperty):
        (WebCore::CSSStyleSelector::mmLength):
        (WebCore::CSSStyleSelector::inchLength):
        (WebCore::CSSStyleSelector::mapFillSize):
        (WebCore::CSSStyleSelector::mapFillXPosition):
        (WebCore::CSSStyleSelector::mapFillYPosition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-06-29 Jeff Timanus <twiz@chromium.org>
commit-queue@webkit.org [Wed, 29 Jun 2011 21:25:12 +0000 (21:25 +0000)]
2011-06-29  Jeff Timanus  <twiz@chromium.org>

        Reviewed by Stephen White.

        [Chromium] Remove flakiness marker from fast/canvas/canvas-longlived-context.html
        https://bugs.webkit.org/show_bug.cgi?id=63649

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-06-29 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 29 Jun 2011 21:22:52 +0000 (21:22 +0000)]
2011-06-29  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Remove duplicate methods in filesystem.py
        https://bugs.webkit.org/show_bug.cgi?id=63658

        Looks like there was a bad merge at some point.

        I also removed a bunch of redundant docstrings.

        * Scripts/webkitpy/common/system/filesystem.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90043 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-06-29 Chris Rogers <crogers@google.com>
crogers@google.com [Wed, 29 Jun 2011 21:20:08 +0000 (21:20 +0000)]
2011-06-29  Chris Rogers  <crogers@google.com>

        Reviewed by Kenneth Russell.

        Simplify AudioBufferSourceNode rendering
        https://bugs.webkit.org/show_bug.cgi?id=63586

        No new tests since this doesn't change API.

        * webaudio/AudioBufferSourceNode.cpp:
        (WebCore::AudioBufferSourceNode::AudioBufferSourceNode):
        (WebCore::AudioBufferSourceNode::process):
        (WebCore::AudioBufferSourceNode::renderFromBuffer):
        (WebCore::AudioBufferSourceNode::reset):
        (WebCore::AudioBufferSourceNode::setBuffer):
        (WebCore::AudioBufferSourceNode::noteOn):
        (WebCore::AudioBufferSourceNode::noteGrainOn):
        (WebCore::AudioBufferSourceNode::totalPitchRate):
        * webaudio/AudioBufferSourceNode.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-06-29 Martin Robinson <mrobinson@igalia.com>
commit-queue@webkit.org [Wed, 29 Jun 2011 21:03:13 +0000 (21:03 +0000)]
2011-06-29  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [Freetype] Many tests report ERROR: Failed to get glyph page zero.
        https://bugs.webkit.org/show_bug.cgi?id=63498

        Instead of conditionally instantiating the m_scaledFont member of FontPlatformData,
        always instantiate it. For times when the size is 0 and the instantiation would lead
        to a Cairo error, we use size 1 and just make operations which would fail conditional
        on the m_size > 0.

        No new tests. This change is covered by existing tests. We should
        observe no errors on the bots after landing.

        * platform/graphics/cairo/FontCairo.cpp:
        (WebCore::Font::drawGlyphs): Instead of looking at whether or not there is
        a scaled font to determine whether to draw, just look at the size.
        * platform/graphics/freetype/FontPlatformData.h: Remove the m_font member.
        * platform/graphics/freetype/FontPlatformDataFreeType.cpp: Always instantiate
        a scaled font member and remove references to m_font. If we are instantiating
        a scaled font for a 0 size font, instantiate a size 1 font, so that we can
        still use Cairo to query font properties.
        * platform/graphics/freetype/GlyphPageTreeNodeFreeType.cpp:
        (WebCore::GlyphPage::fill): We can assume there is always a scaled font now.
        * platform/graphics/freetype/SimpleFontDataFreeType.cpp:
        (WebCore::SimpleFontData::platformInit): Ditto.
        (WebCore::SimpleFontData::createScaledFontData): Ditto.
        (WebCore::SimpleFontData::containsCharacters): Ditto.
        (WebCore::SimpleFontData::platformWidthForGlyph): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-06-29 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 29 Jun 2011 20:55:24 +0000 (20:55 +0000)]
2011-06-29  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Pass --no-new-test-results to NRWT on build.webkit.org
        https://bugs.webkit.org/show_bug.cgi?id=63653

        This is in preparation for https://bugs.webkit.org/show_bug.cgi?id=38063.

        * BuildSlaveSupport/build.webkit.org-config/master.cfg:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-06-29 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Wed, 29 Jun 2011 20:52:35 +0000 (20:52 +0000)]
2011-06-29  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Darin Adler.

        Media element loads blocked by a resource load delegate do not generate an error event
        https://bugs.webkit.org/show_bug.cgi?id=63558

        Tests: media/media-blocked-by-beforeload.html
               media/media-blocked-by-willsendrequest.html

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::selectMediaResource): Call mediaLoadingFailed instead of noneSupported
            so all failures follow the same code path.
        (WebCore::HTMLMediaElement::loadResource): Call mediaLoadingFailed when there is no frame, when
            the loader delegate rejects the url, or when MediaPlayer doesn't find a media engine that
            supports the type.
        (WebCore::HTMLMediaElement::selectNextSourceChild): Fix incorrect logging.
        (WebCore::HTMLMediaElement::mediaLoadingFailed): Change name of parameter from "state" to
            "error" to make its purpose obvious.

        * platform/graphics/MediaPlayer.cpp:
        (WebCore::MediaPlayer::load): Return a bool indicating whether or not the url was given to
            a media engine.
        (WebCore::MediaPlayer::loadWithNextMediaEngine): Add some logging.
        * platform/graphics/MediaPlayer.h:

2011-06-29  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Darin Adler.

        Media element loads blocked by a resource load delegate do not generate an error event
        https://bugs.webkit.org/show_bug.cgi?id=63558

        * media/media-blocked-by-beforeload-expected.txt: Added.
        * media/media-blocked-by-beforeload.html: Added.
        * media/media-blocked-by-willsendrequest-expected.txt: Added.
        * media/media-blocked-by-willsendrequest.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-06-29 Darin Adler <darin@apple.com>
darin@apple.com [Wed, 29 Jun 2011 20:46:33 +0000 (20:46 +0000)]
2011-06-29  Darin Adler  <darin@apple.com>

        Reviewed by Anders Carlsson.

        [WebKit2] Crash loading page that adds/removes frame in DOMContentLoaded/loaded
        https://bugs.webkit.org/show_bug.cgi?id=63483

        * fast/loader/create-frame-in-DOMContentLoaded-expected.txt: Added.
        * fast/loader/create-frame-in-DOMContentLoaded.html: Added.
2011-06-29  Darin Adler  <darin@apple.com>

        Reviewed by Anders Carlsson.

        [WebKit2] Crash loading page that adds/removes frame in DOMContentLoaded/loaded
        https://bugs.webkit.org/show_bug.cgi?id=63483

        Test: fast/loader/create-frame-in-DOMContentLoaded.html

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::init): Added an assertion.
        (WebCore::FrameLoader::finishedLoadingDocument): Removed a non-helpful #if
        statement. The rule that we do not call the client when creating the initial
        empty document was nominally specific to Windows and Chromium but is needed
        for all platforms.
2011-06-29  Darin Adler  <darin@apple.com>

        Reviewed by Anders Carlsson.

        [WebKit2] Crash loading page that adds/removes frame in DOMContentLoaded/loaded
        https://bugs.webkit.org/show_bug.cgi?id=63483

        * WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
        (WebKit::WebFrameLoaderClient::createFrame): Added a check for null when creating
        a frame. Also added a check that was in the WebKit1 code, but not here. Strangely,
        the comment from the second check was still here, but not the code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-06-29 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Wed, 29 Jun 2011 19:47:04 +0000 (19:47 +0000)]
2011-06-29  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Adam Barth.

        [GTK] overlapping drag&drop tests fail on NRWT
        https://bugs.webkit.org/show_bug.cgi?id=57640

        Make a GTK test driver that spawns one Xvfb instance per
        thread. This avoids bad interactions in DnD tests between threads.

        * Scripts/webkitpy/layout_tests/port/gtk.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90036 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-06-29 Filip Pizlo <fpizlo@apple.com>
commit-queue@webkit.org [Wed, 29 Jun 2011 19:46:28 +0000 (19:46 +0000)]
2011-06-29  Filip Pizlo  <fpizlo@apple.com>

        Reviewed by Gavin Barraclough.

        DFG JIT does not perform get_by_id self list caching.
        https://bugs.webkit.org/show_bug.cgi?id=63605

        * bytecode/StructureStubInfo.h:
        * dfg/DFGJITCompiler.cpp:
        (JSC::DFG::JITCompiler::compileFunction):
        * dfg/DFGOperations.cpp:
        * dfg/DFGOperations.h:
        * dfg/DFGRepatch.cpp:
        (JSC::DFG::tryCacheGetByID):
        (JSC::DFG::tryBuildGetByIDList):
        (JSC::DFG::dfgBuildGetByIDList):
        * dfg/DFGRepatch.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-06-29 Nat Duca <nduca@chromium.org>
nduca@chromium.org [Wed, 29 Jun 2011 19:20:27 +0000 (19:20 +0000)]
2011-06-29  Nat Duca  <nduca@chromium.org>

        [chromium] Unreviewed, mark fast/canvas/webgl/context-lost-restored failing
        https://bugs.webkit.org/show_bug.cgi?id=63643

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-06-29 Alexis Menard <alexis.menard@openbossa.org>
alexis.menard@openbossa.org [Wed, 29 Jun 2011 19:18:02 +0000 (19:18 +0000)]
2011-06-29  Alexis Menard  <alexis.menard@openbossa.org>

        Reviewed by Benjamin Poulain.

        [Qt] Add Qt dependencies in QtWebKit's main pro file.
        https://bugs.webkit.org/show_bug.cgi?id=63639

        syncqt, the script which generates the headers inside Qt parses
        the main pro file of QtWebKit to check the Qt dependencies. It used
        to be WebCore.pro but after the build reorganization QtWebKit.pro is
        the new main pro file so we need to add the network dependency just like
        we did in WebCore.pro.

        * QtWebKit.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-06-29 Nat Duca <nduca@chromium.org>
nduca@chromium.org [Wed, 29 Jun 2011 19:07:19 +0000 (19:07 +0000)]
2011-06-29  Nat Duca  <nduca@chromium.org>

        [chromium] Unreviewed, mark index-validation-with-resized-buffer as failing.
        https://bugs.webkit.org/show_bug.cgi?id=63638

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90032 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-06-29 Wyatt Carss <wcarss@chromium.org>
commit-queue@webkit.org [Wed, 29 Jun 2011 18:58:43 +0000 (18:58 +0000)]
2011-06-29  Wyatt Carss  <wcarss@chromium.org>

        Reviewed by Ryosuke Niwa.

        convert editing/deleting/paragraph-in-preserveNewline.html to dumpAsText
        https://bugs.webkit.org/show_bug.cgi?id=63362

        Converted editing/deleting/paragraph-in-preserveNewline.html to dump-as-markup,
        added doctype, added new baseline, and removed old baselines.

        * editing/deleting/paragraph-in-preserveNewline.html:
        * editing/deleting/paragraph-in-preserveNewline-expected.html: Added.
        * platform/chromium-linux/editing/deleting/paragraph-in-preserveNewline-expected.png: Removed.
        * platform/chromium-win/editing/deleting/paragraph-in-preserveNewline-expected.png: Removed.
        * platform/chromium-win/editing/deleting/paragraph-in-preserveNewline-expected.txt: Removed.
        * platform/gtk/editing/deleting/paragraph-in-preserveNewline-expected.png: Removed.
        * platform/mac-leopard/editing/deleting/paragraph-in-preserveNewline-expected.png: Removed.
        * platform/mac/editing/deleting/paragraph-in-preserveNewline-expected.png: Removed.
        * platform/mac/editing/deleting/paragraph-in-preserveNewline-expected.txt: Removed.
        * platform/qt/editing/deleting/paragraph-in-preserveNewline-expected.png: Removed.
        * platform/qt/editing/deleting/paragraph-in-preserveNewline-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90031 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-06-29 Emil A Eklund <eae@chromium.org>
eae@chromium.org [Wed, 29 Jun 2011 18:58:23 +0000 (18:58 +0000)]
2011-06-29  Emil A Eklund  <eae@chromium.org>

        Reviewed by Darin Adler.

        Switch hitTestColumns/Contents/Floats to to new layout types
        https://bugs.webkit.org/show_bug.cgi?id=63589

        Switch location and size methods for RenderBox over to the new layout unit abstraction.

        No new tests, no functionality changes.

        * rendering/ColumnInfo.h:
        (WebCore::ColumnInfo::desiredColumnWidth):
        (WebCore::ColumnInfo::setDesiredColumnWidth):
        (WebCore::ColumnInfo::columnHeight):
        (WebCore::ColumnInfo::setColumnCountAndHeight):
        (WebCore::ColumnInfo::setColumnHeight):
        (WebCore::ColumnInfo::updateMinimumColumnHeight):
        (WebCore::ColumnInfo::minimumColumnHeight):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::addOverflowFromChildren):
        (WebCore::RenderBlock::paintColumnRules):
        (WebCore::RenderBlock::paintColumnContents):
        (WebCore::RenderBlock::hitTestFloats):
        (WebCore::RenderBlock::hitTestColumns):
        (WebCore::RenderBlock::hitTestContents):
        (WebCore::RenderBlock::columnRectAt):
        * rendering/RenderBlock.h:
        (WebCore::RenderBlock::xPositionForFloatIncludingMargin):
        (WebCore::RenderBlock::yPositionForFloatIncludingMargin):
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::hitTestContents):
        * rendering/RenderLayer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-06-29 Adrienne Walker <enne@google.com>
enne@google.com [Wed, 29 Jun 2011 18:30:07 +0000 (18:30 +0000)]
2011-06-29  Adrienne Walker  <enne@google.com>

        Reviewed by James Robinson.

        [chromium] Divide by zero in TilingData
        https://bugs.webkit.org/show_bug.cgi?id=63305

        Add safety checks for empty layers.

        * platform/graphics/chromium/LayerTilerChromium.cpp:
        (WebCore::LayerTilerChromium::prepareToUpdate):
        (WebCore::LayerTilerChromium::reset):
        (WebCore::LayerTilerChromium::updateRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90029 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-06-29 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Wed, 29 Jun 2011 18:21:37 +0000 (18:21 +0000)]
2011-06-29  Nate Chapin  <japhet@chromium.org>

        Unreviewed, more chromium test updates.

        * platform/chromium-linux/svg/foreignObject/text-tref-02-b-expected.png:
        * platform/chromium-win/svg/foreignObject/text-tref-02-b-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90028 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-06-29 Leandro Pereira <leandro@profusion.mobi>
commit-queue@webkit.org [Wed, 29 Jun 2011 17:57:00 +0000 (17:57 +0000)]
2011-06-29  Leandro Pereira  <leandro@profusion.mobi>

        Reviewed by Darin Adler.

        Add note about cases where enums are preferred over bools on function parameters.
        https://bugs.webkit.org/show_bug.cgi?id=63564

        This matches the outcome of this webkit-dev thread:
        https://lists.webkit.org/pipermail/webkit-dev/2010-December/015192.html

        * coding/coding-style.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90027 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-06-29 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Wed, 29 Jun 2011 17:46:56 +0000 (17:46 +0000)]
2011-06-29  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Adam Barth.

        Extract setShadowRoot function, harden it in preparation to be exposed to script.
        https://bugs.webkit.org/show_bug.cgi?id=63596

        Refactoring, covered by existing tests.

        * dom/Element.cpp:
        (WebCore::validateShadowRoot): Added.
        (WebCore::Element::setShadowRoot): Extracted from ensureShadowRoot.
        (WebCore::Element::ensureShadowRoot): Changed to use setShadowRoot.
        * dom/Element.h: Added decl.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-06-29 James Hawkins <jhawkins@chromium.org>
jhawkins@chromium.org [Wed, 29 Jun 2011 17:44:35 +0000 (17:44 +0000)]
2011-06-29  James Hawkins  <jhawkins@chromium.org>

        Reviewed by Pavel Feldman.

        [Chromium] Fix a crash on when executeCommand(copy) is called on a null node.
        https://bugs.webkit.org/show_bug.cgi?id=63626

        * src/WebFrameImpl.cpp:
        (WebKit::pluginContainerFromNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90025 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-06-29 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Wed, 29 Jun 2011 17:42:55 +0000 (17:42 +0000)]
2011-06-29  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r89888.
        http://trac.webkit.org/changeset/89888
        https://bugs.webkit.org/show_bug.cgi?id=63609

         "Seems to be causing merging issues on the dashboard, e.g.
        http://test-
        results.appspot.com/dashboards/flakiness_dashboard.html#group=%40ToT%20-%20chromium.org&tests=fast%2Fcanvas"
        (Requested by aboxhall on #webkit).

        * Scripts/webkitpy/layout_tests/layout_package/json_layout_results_generator.py:
        * Scripts/webkitpy/layout_tests/layout_package/json_results_generator.py:
        * Scripts/webkitpy/layout_tests/layout_package/json_results_generator_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-06-29 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Wed, 29 Jun 2011 17:34:37 +0000 (17:34 +0000)]
2011-06-29  Nate Chapin  <japhet@chromium.org>

        Unreviewed, chromium test updates.

        * platform/chromium-mac-leopard/svg/foreignObject: Added.
        * platform/chromium-mac-leopard/svg/foreignObject/text-tref-02-b-expected.png: Added.
        * platform/chromium-mac-leopard/svg/foreignObject/text-tref-02-b-expected.txt: Added.
        * platform/chromium-mac/svg/foreignObject/text-tref-02-b-expected.png:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-06-29 Vsevolod Vlasov <vsevik@chromium.org>
commit-queue@webkit.org [Wed, 29 Jun 2011 16:22:53 +0000 (16:22 +0000)]
2011-06-29  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: REGRESSION Resource revision fails to request content if it was not yet loaded for resource.
        https://bugs.webkit.org/show_bug.cgi?id=63631

        * http/tests/inspector/network/network-request-revision-content-expected.txt: Added.
        * http/tests/inspector/network/network-request-revision-content.html: Added.
        * http/tests/inspector/network/resources/script.js: Added.
2011-06-29  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: REGRESSION Resource revision fails to request content if it was not yet loaded for resource.
        https://bugs.webkit.org/show_bug.cgi?id=63631

        Test: http/tests/inspector/network/network-request-revision-content.html

        * inspector/front-end/Resource.js:
        (WebInspector.ResourceRevision.prototype.requestContent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90022 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-06-29 Balazs Kelemen <kbalazs@webkit.org>
kbalazs@webkit.org [Wed, 29 Jun 2011 16:15:48 +0000 (16:15 +0000)]
2011-06-29  Balazs Kelemen  <kbalazs@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt][WK2] plugins/document-open.html need new result for wk2
        https://bugs.webkit.org/show_bug.cgi?id=63633

        * platform/qt-wk2/Skipped:
        * platform/qt-wk2/plugins/document-open-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90021 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-06-29 Igor Oliveira <igor.oliveira@openbossa.org>
commit-queue@webkit.org [Wed, 29 Jun 2011 15:56:52 +0000 (15:56 +0000)]
2011-06-29  Igor Oliveira  <igor.oliveira@openbossa.org>

        Reviewed by Andreas Kling.

        [Qt] GraphicsContext::clipToImageBuffer does not support scale transformation
        https://bugs.webkit.org/show_bug.cgi?id=63555

        Scale alphaMask if GraphicsContext is scaled

        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::pushTransparencyLayerInternal):
        * platform/graphics/qt/ImageBufferQt.cpp:
        (WebCore::ImageBuffer::clip):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90020 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-06-29 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Wed, 29 Jun 2011 14:38:06 +0000 (14:38 +0000)]
2011-06-29  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: backend needs to provide system-unique object ids, so these remain unique across navigation
        https://bugs.webkit.org/show_bug.cgi?id=62894

        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::setAgentProcessIdentifier):
        * inspector/InspectorController.h:
        * inspector/InspectorPageAgent.cpp:
        (WebCore::InspectorPageAgent::setAgentIdentifier):
        (WebCore::InspectorPageAgent::createIdentifier):
        (WebCore::InspectorPageAgent::frameForId):
        (WebCore::InspectorPageAgent::frameId):
        (WebCore::InspectorPageAgent::frameDestroyed):
        * inspector/InspectorPageAgent.h:

2011-06-29  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: backend needs to provide system-unique object ids, so these remain unique across navigation
        https://bugs.webkit.org/show_bug.cgi?id=62894

        * public/WebDevToolsAgent.h:
        * src/WebDevToolsAgentImpl.cpp:
        (WebKit::WebDevToolsAgentImpl::setAgentProcessIdentifier):
        * src/WebDevToolsAgentImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90017 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Martin Robinson.
philn@webkit.org [Wed, 29 Jun 2011 14:18:40 +0000 (14:18 +0000)]
    Reviewed by Martin Robinson.

        [webkitpy] Executive.running_pids() sometimes doesn't correctly process "ps" output
        https://bugs.webkit.org/show_bug.cgi?id=63624

        * Scripts/webkitpy/common/system/executive.py: In some cases the
        ps output lines can contain one or more leading white-spaces, so
        strip it before splitting the pid and command name.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90016 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-06-29 Michal Pakula vel Rutka <m.pakula@samsung.com>
commit-queue@webkit.org [Wed, 29 Jun 2011 14:12:54 +0000 (14:12 +0000)]
2011-06-29  Michal Pakula vel Rutka  <m.pakula@samsung.com>

        Reviewed by Kenneth Rohde Christiansen.

        [EFL] Add ewk_frame_text_selection_type_get function
        https://bugs.webkit.org/show_bug.cgi?id=63462

        Add a method to obtain current WebCore::VisibleSelection text
        selection type.

        * ewk/ewk_frame.cpp:
        (ewk_frame_text_selection_type_get):
        * ewk/ewk_frame.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90015 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-06-29 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Wed, 29 Jun 2011 13:58:09 +0000 (13:58 +0000)]
2011-06-29  Pavel Feldman  <pfeldman@google.com>

        Reviewed by Yury Semikhatsky.

        Web Inspector: create status bar buttons programmatically. Add "Inspect" button to all panels.
        https://bugs.webkit.org/show_bug.cgi?id=63450

        Buttons should be created in code, not in HTML. Also making Inspect Element
        action available on all panels (as an experiment).

        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleView.prototype.show):
        (WebInspector.ConsoleView.prototype.hide):
        * inspector/front-end/ElementsPanel.js:
        (WebInspector.ElementsPanel):
        (WebInspector.ElementsPanel.prototype.get statusBarItems):
        (WebInspector.ElementsPanel.prototype.updateFocusedNode):
        (WebInspector.ElementsPanel.prototype._setSearchingForNode):
        (WebInspector.ElementsPanel.prototype.toggleSearchingForNode):
        * inspector/front-end/inspector.css:
        (button.dock-status-bar-item.status-bar-item .glyph):
        (button.dock-status-bar-item.status-bar-item.toggled-on .glyph):
        (.console-status-bar-item .glyph):
        * inspector/front-end/inspector.html:
        * inspector/front-end/inspector.js:
        (WebInspector._createGlobalStatusBarItems):
        (WebInspector.set attached):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90014 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-06-29 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Wed, 29 Jun 2011 13:47:00 +0000 (13:47 +0000)]
2011-06-29  Pavel Feldman  <pfeldman@google.com>

        Reviewed by Yury Semikhatsky.

        Web Inspector: tab crash after deleting trailing quote when editing attribute
        https://bugs.webkit.org/show_bug.cgi?id=63544

        * inspector/elements/set-attribute-expected.txt:
        * inspector/elements/set-attribute.html:
2011-06-29  Pavel Feldman  <pfeldman@google.com>

        Reviewed by Yury Semikhatsky.

        Web Inspector: tab crash after deleting trailing quote when editing attribute
        https://bugs.webkit.org/show_bug.cgi?id=63544

        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::setAttributesText):
        * inspector/front-end/ElementsTreeOutline.js:
        (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted.moveToNextAttributeIfNeeded):
        (WebInspector.ElementsTreeElement.prototype._attributeEditingCommitted):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90013 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Unreviewed, remove erroneous test name from GTK Skipped list.
philn@webkit.org [Wed, 29 Jun 2011 13:42:54 +0000 (13:42 +0000)]
    Unreviewed, remove erroneous test name from GTK Skipped list.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-06-29 Vsevolod Vlasov <vsevik@chromium.org>
commit-queue@webkit.org [Wed, 29 Jun 2011 13:13:28 +0000 (13:13 +0000)]
2011-06-29  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: REGRESSION Inspector failing to load resource content after navigation. Safari.
        https://bugs.webkit.org/show_bug.cgi?id=63480

        * inspector/front-end/NetworkManager.js:
        (WebInspector.NetworkDispatcher):
        (WebInspector.NetworkDispatcher.prototype.resourceLoadedFromMemoryCache):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-06-29 Mike West <mkwst@chromium.org>
pfeldman@chromium.org [Wed, 29 Jun 2011 12:43:45 +0000 (12:43 +0000)]
2011-06-29  Mike West  <mkwst@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Missing fields in HAR
        https://bugs.webkit.org/show_bug.cgi?id=58127

        Setting correct expectations for the following fields newly added to
        the HAR implementation:

        - entry.request.httpVersion
        - entry.request.headersSize
        - entry.request.bodySize
        - entry.response.httpVersion
        - entry.response.headersSize
        - entry.response.bodySize
        - entry.response.content.compression

        * http/tests/inspector/network/network-size.html:
        * http/tests/inspector/resource-har-conversion-expected.txt:
        * http/tests/inspector/resource-har-conversion.html:
        * http/tests/inspector/resource-har-headers-expected.txt: Added.
        * http/tests/inspector/resource-har-headers.html: Added.
        * http/tests/inspector/resource-parameters-expected.txt:
        * http/tests/inspector/resources-test.js:
2011-06-29  Mike West  <mkwst@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Missing fields in HAR
        https://bugs.webkit.org/show_bug.cgi?id=58127

        Specifically, this patch adds:
        - entry.request.httpVersion
        - entry.request.headersSize
        - entry.request.bodySize
        - entry.response.httpVersion
        - entry.response.headersSize
        - entry.response.bodySize
        - entry.response.content.compression

        Tests: http/tests/inspector/resource-har-conversion.html
               http/tests/inspector/resource-har-headers.html
               http/tests/inspector/resource-parameters.html
               http/tests/inspector/network/network-size.html

        * inspector/front-end/HAREntry.js:
        (WebInspector.HAREntry.prototype.build):
        (WebInspector.HAREntry.prototype._buildRequest):
        (WebInspector.HAREntry.prototype._buildResponse):
        (WebInspector.HAREntry.prototype._buildContent):
        (WebInspector.HAREntry.prototype._buildCookie):
        (WebInspector.HAREntry.prototype._interval):
        (WebInspector.HAREntry.prototype.get requestBodySize):
        (WebInspector.HAREntry.prototype.get responseBodySize):
        (WebInspector.HAREntry.prototype.get responseCompression):
        (WebInspector.HARLog.prototype.build):
        * inspector/front-end/Resource.js:
        (WebInspector.Resource.prototype.set requestHeaders):
        (WebInspector.Resource.prototype.get requestHeadersText):
        (WebInspector.Resource.prototype.set requestHeadersText):
        (WebInspector.Resource.prototype.get requestHeadersSize):
        (WebInspector.Resource.prototype.get requestHttpVersion):
        (WebInspector.Resource.prototype.set responseHeaders):
        (WebInspector.Resource.prototype.get responseHeadersText):
        (WebInspector.Resource.prototype.set responseHeadersText):
        (WebInspector.Resource.prototype.get responseHeadersSize):
        (WebInspector.Resource.prototype.get responseHttpVersion):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Unreviewed, skip 2 acid tests on GTK due to bug 54119. They were
philn@webkit.org [Wed, 29 Jun 2011 11:44:04 +0000 (11:44 +0000)]
    Unreviewed, skip 2 acid tests on GTK due to bug 54119. They were
        failing only in 32-Bits Release though.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt][Mac] Qt specific results committed in r90007, but fail on Qt-Mac platform
ossy@webkit.org [Wed, 29 Jun 2011 11:05:05 +0000 (11:05 +0000)]
[Qt][Mac] Qt specific results committed in r90007, but fail on Qt-Mac platform

* platform/qt-mac/Skipped: Skip failing tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90008 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Add platform specific expected results for new passing tests.
ossy@webkit.org [Wed, 29 Jun 2011 10:44:30 +0000 (10:44 +0000)]
[Qt] Add platform specific expected results for new passing tests.

* platform/qt/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.png: Added.
* platform/qt/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.txt: Added.
* platform/qt/svg/custom/text-tref-03-b-change-href-dom-expected.png: Added.
* platform/qt/svg/custom/text-tref-03-b-change-href-dom-expected.txt: Added.
* platform/qt/svg/custom/text-tref-03-b-change-href-expected.png: Added.
* platform/qt/svg/custom/text-tref-03-b-change-href-expected.txt: Added.
* platform/qt/svg/custom/text-tref-03-b-referenced-element-removal-expected.png: Added.
* platform/qt/svg/custom/text-tref-03-b-referenced-element-removal-expected.txt: Added.
* platform/qt/svg/custom/text-tref-03-b-tref-removal-expected.png: Added.
* platform/qt/svg/custom/text-tref-03-b-tref-removal-expected.txt: Added.
* platform/qt/svg/foreignObject/text-tref-02-b-expected.png:
* platform/qt/svg/foreignObject/text-tref-02-b-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-06-29 Noel Gordon <noel.gordon@gmail.com>
commit-queue@webkit.org [Wed, 29 Jun 2011 10:24:32 +0000 (10:24 +0000)]
2011-06-29  Noel Gordon  <noel.gordon@gmail.com>

        Reviewed by Kent Tamura.

        [Chromium] [DRT] ImageDiff should compile in VS2010
        https://bugs.webkit.org/show_bug.cgi?id=63614

        * DumpRenderTree/chromium/ImageDiff.cpp: Include <iterator> for back_inserter.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Unreviewed, GTK rebaseline of 2 more tests.
philn@webkit.org [Wed, 29 Jun 2011 09:58:06 +0000 (09:58 +0000)]
    Unreviewed, GTK rebaseline of 2 more tests.

        * inspector/console/console-trace-in-eval-expected.txt:
        * platform/gtk/svg/foreignObject/text-tref-02-b-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-06-29 Hayato Ito <hayato@chromium.org>
hayato@chromium.org [Wed, 29 Jun 2011 09:39:58 +0000 (09:39 +0000)]
2011-06-29  Hayato Ito  <hayato@chromium.org>

        Reviewed by Hajime Morita.

        Make a shadow host transfer a focus to the first focusable element in the shadow root when its focus() is called.
        https://bugs.webkit.org/show_bug.cgi?id=62358.

        This patch doesn't take an effect on the following elements to keep a compatibility.
        - <input>, <textarea>, <video> and <audio> elements
        We'll address these elements separately after re-targeting focus events
        (bug 61421) is implemented.

        A shadow root's <content> is not considered in this patch.
        That should be addressed in another patch. See bug 63522.

        * fast/dom/shadow/shadow-host-transfer-focus-expected.txt: Added.
        * fast/dom/shadow/shadow-host-transfer-focus.html: Added.
2011-06-29  Hayato Ito  <hayato@chromium.org>

        Reviewed by Hajime Morita.

        Make a shadow host transfer a focus to the first focusable element in the shadow root when its focus() is called.
        https://bugs.webkit.org/show_bug.cgi?id=62358.

        This patch doesn't take an effect on the following elements to keep a compatibility.
        - <input>, <textarea>, <video> and <audio> elements
        We'll address these elements separately after re-targeting focus events
        (bug 61421) is implemented.

        A shadow root's <content> is not considered in this patch.
        That should be addressed in another patch. See bug 63522.

        Test: fast/dom/shadow/shadow-host-transfer-focus.html

        * dom/Element.cpp:
        (WebCore::Element::focus):
        * page/FocusController.cpp:
        (WebCore::shadowRoot):
        (WebCore::isTreeScopeOwner):
        (WebCore::FocusController::transferFocusToElementInShadowRoot):
        (WebCore::hasCustomFocusLogic):
        (WebCore::FocusController::findFocusableNodeDecendingDownIntoFrameDocumentOrShadowRoot):
        (WebCore::FocusController::advanceFocusInDocumentOrder):
        (WebCore::ownerOfTreeScope):
        (WebCore::FocusController::findFocusableNodeAcrossTreeScope):
        * page/FocusController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-06-29 Ryan Sleevi <rsleevi@chromium.org>
commit-queue@webkit.org [Wed, 29 Jun 2011 09:32:21 +0000 (09:32 +0000)]
2011-06-29  Ryan Sleevi  <rsleevi@chromium.org>

        Reviewed by Dirk Schulze.

        SVGRadialGradientElement::selfHasRelativeLengths() doesn't consider if cx() is relative
        https://bugs.webkit.org/show_bug.cgi?id=61600

        Correct the logic for checking for relative lengths in a SVGRadialGradientElement to consider cx() in addition to cy()

        No new tests, as there is no way to currently test this. With the bug present, a side-effect is causing the
        expected/correct image to be rendered. This is because the cached SVG resource is getting invalided through a
        different path, forcing a repaint. The repaint takes into consideration the proper dimensions, hiding the bug.

        * svg/SVGRadialGradientElement.cpp:
        (WebCore::SVGRadialGradientElement::selfHasRelativeLengths):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-06-29 Roland Steiner <rolandsteiner@chromium.org>
rolandsteiner@chromium.org [Wed, 29 Jun 2011 09:29:14 +0000 (09:29 +0000)]
2011-06-29  Roland Steiner  <rolandsteiner@chromium.org>

        Unreviewed: last last ruby expectations for WebKit2 Win.

        * platform/win-wk2/fast/ruby/generated-after-counter-doesnt-crash-expected.txt: Added.
        * platform/win-wk2/fast/ruby/generated-before-and-after-counter-doesnt-crash-expected.txt: Added.
        * platform/win-wk2/fast/ruby/generated-before-counter-doesnt-crash-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Unreviewed, skip
philn@webkit.org [Wed, 29 Jun 2011 09:22:18 +0000 (09:22 +0000)]
    Unreviewed, skip
        http/tests/history/cross-origin-replace-history-object-child.html
        on GTK, due to bug 61937.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Unreviewed, GTK rebaseline of 3 svg/custom/linking tests.
philn@webkit.org [Wed, 29 Jun 2011 09:18:18 +0000 (09:18 +0000)]
    Unreviewed, GTK rebaseline of 3 svg/custom/linking tests.

        * platform/gtk/svg/custom/linking-a-03-b-all-expected.txt:
        * platform/gtk/svg/custom/linking-a-03-b-transform-expected.txt:
        * platform/gtk/svg/custom/linking-a-03-b-viewBox-transform-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Unreviewed, GTK rebaseline of
philn@webkit.org [Wed, 29 Jun 2011 08:59:32 +0000 (08:59 +0000)]
    Unreviewed, GTK rebaseline of
        fast/html/details-open-javascript.html

        * platform/gtk/fast/html/details-open-javascript-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Unreviewed, skip crashing tests on GTK because of
philn@webkit.org [Wed, 29 Jun 2011 08:30:34 +0000 (08:30 +0000)]
    Unreviewed, skip crashing tests on GTK because of
        https://bugs.webkit.org/show_bug.cgi?id=63611

        * platform/gtk/Skipped: skip 5 editing tests

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-06-29 Roland Steiner <rolandsteiner@chromium.org>
rolandsteiner@chromium.org [Wed, 29 Jun 2011 07:57:36 +0000 (07:57 +0000)]
2011-06-29  Roland Steiner  <rolandsteiner@chromium.org>

        Unreviewed: update the (hopefully) last ruby expectation stragglers in WebKit2

        * platform/win-wk2/fast/ruby/after-block-doesnt-crash-expected.txt:
        * platform/win-wk2/fast/ruby/after-table-doesnt-crash-expected.txt:
        * platform/win-wk2/fast/ruby/before-block-doesnt-crash-expected.txt:
        * platform/win-wk2/fast/ruby/before-table-doesnt-crash-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-06-29 Roland Steiner <rolandsteiner@chromium.org>
rolandsteiner@chromium.org [Wed, 29 Jun 2011 07:21:05 +0000 (07:21 +0000)]
2011-06-29  Roland Steiner  <rolandsteiner@chromium.org>

        Unreviewed: more juggling with ruby expectation files, trying to
        find my way out of the expectations dependency jungle...

        * platform/chromium-mac/fast/ruby/after-block-doesnt-crash-expected.txt: Added.
        * platform/chromium-mac/fast/ruby/after-table-doesnt-crash-expected.txt: Added.
        * platform/chromium-mac/fast/ruby/before-block-doesnt-crash-expected.txt: Added.
        * platform/chromium-mac/fast/ruby/before-table-doesnt-crash-expected.txt: Added.
        * platform/chromium-mac/fast/ruby/generated-after-counter-doesnt-crash-expected.txt: Added.
        * platform/chromium-mac/fast/ruby/generated-before-and-after-counter-doesnt-crash-expected.txt: Added.
        * platform/chromium-mac/fast/ruby/generated-before-counter-doesnt-crash-expected.txt: Added.
        * platform/chromium-win/fast/ruby/after-block-doesnt-crash-expected.txt: Added.
        * platform/chromium-win/fast/ruby/after-table-doesnt-crash-expected.txt: Added.
        * platform/chromium-win/fast/ruby/before-block-doesnt-crash-expected.txt: Added.
        * platform/chromium-win/fast/ruby/before-table-doesnt-crash-expected.txt: Added.
        * platform/chromium-win/fast/ruby/generated-after-counter-doesnt-crash-expected.txt: Added.
        * platform/chromium-win/fast/ruby/generated-before-and-after-counter-doesnt-crash-expected.txt: Added.
        * platform/chromium-win/fast/ruby/generated-before-counter-doesnt-crash-expected.txt: Added.
        * platform/win/fast/ruby/generated-after-counter-doesnt-crash-expected.txt: Added.
        * platform/win/fast/ruby/generated-before-and-after-counter-doesnt-crash-expected.txt: Added.
        * platform/win/fast/ruby/generated-before-counter-doesnt-crash-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-06-29 Darin Adler <darin@apple.com>
darin@apple.com [Wed, 29 Jun 2011 07:11:50 +0000 (07:11 +0000)]
2011-06-29  Darin Adler  <darin@apple.com>

        Reviewed by Adam Barth.

        Consolidate the fast/loader and fast/loading directories
        https://bugs.webkit.org/show_bug.cgi?id=63587

        * fast/loader/resources/subframe-that-removes-itself.html: Copied from LayoutTests/fast/loading/resources/subframe-that-removes-itself.html.
        * fast/loader/subframe-removes-itself-expected.txt: Copied from LayoutTests/fast/loading/subframe-removes-itself-expected.txt.
        * fast/loader/subframe-removes-itself.html: Copied from LayoutTests/fast/loading/subframe-removes-itself.html.
        * fast/loading/resources/subframe-that-removes-itself.html: Removed.
        * fast/loading/subframe-removes-itself-expected.txt: Removed.
        * fast/loading/subframe-removes-itself.html: Removed.

        * platform/gtk/Skipped: Updated for new location of test.
        * platform/mac-wk2/Skipped: Ditto.
        * platform/qt-wk2/Skipped: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-06-28 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Wed, 29 Jun 2011 06:54:22 +0000 (06:54 +0000)]
2011-06-28  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        SVGAnimatedType should support SVGBoolean animation
        https://bugs.webkit.org/show_bug.cgi?id=63529

        Follow up of "SVGAnimation should use direct unit animation for SVGLength": https://bugs.webkit.org/show_bug.cgi?id=61368
        This patch continues the conversion to the new concept of SVGAnimatorFactory with SVGBoolean.

        The new animator does not affect any behavior, since it was animated with SVGAnimatedString before. The new animator is still needed
        to support animVal and baseVal later.

        Test: svg/animations/svgboolean-animation-1.html

        * CMakeLists.txt: Add new file to build system.
        * GNUmakefile.list.am: Ditto.
        * WebCore.gypi: Ditto.
        * WebCore.pro: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * svg/SVGAllInOne.cpp: Ditto.
        * svg/SVGAnimateElement.cpp: Make use of AnimatedBoolean.
        (WebCore::SVGAnimateElement::determineAnimatedAttributeType):
        (WebCore::SVGAnimateElement::calculateAnimatedValue):
        (WebCore::SVGAnimateElement::calculateFromAndToValues):
        (WebCore::SVGAnimateElement::calculateFromAndByValues):
        (WebCore::SVGAnimateElement::resetToBaseValue):
        (WebCore::SVGAnimateElement::applyResultsToTarget):
        (WebCore::SVGAnimateElement::calculateDistance):
        * svg/SVGAnimatedBoolean.cpp: Added. New animator for SVGBoolean.
        (WebCore::SVGAnimatedBooleanAnimator::SVGAnimatedBooleanAnimator):
        (WebCore::SVGAnimatedBooleanAnimator::constructFromString):
        (WebCore::SVGAnimatedBooleanAnimator::calculateFromAndToValues):
        (WebCore::SVGAnimatedBooleanAnimator::calculateFromAndByValues):
        (WebCore::SVGAnimatedBooleanAnimator::calculateAnimatedValue):
        (WebCore::SVGAnimatedBooleanAnimator::calculateDistance):
        * svg/SVGAnimatedBoolean.h:
        (WebCore::SVGAnimatedBooleanAnimator::~SVGAnimatedBooleanAnimator):
        * svg/SVGAnimatedType.cpp: Use bool for SVGBoolean.
        (WebCore::SVGAnimatedType::~SVGAnimatedType):
        (WebCore::SVGAnimatedType::createBoolean):
        (WebCore::SVGAnimatedType::boolean):
        (WebCore::SVGAnimatedType::valueAsString):
        (WebCore::SVGAnimatedType::setValueAsString):
        * svg/SVGAnimatedType.h:
        * svg/SVGAnimatorFactory.h: New crate function for SVGAnimatedSVGBooleanAnimator.
        (WebCore::SVGAnimatorFactory::create):
2011-06-28  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        SVGAnimatedType should support SVGBoolean animation
        https://bugs.webkit.org/show_bug.cgi?id=63529

        Test animation of SVGBoolean. Add the test to the skip list of wk2.
        Convert animate-number-calcMode-discrete-keyTimes to common style, no change
        on the test itself.

        * platform/mac-wk2/Skipped:
        * svg/animations/animate-number-calcMode-discrete-keyTimes-expected.txt:
        * svg/animations/animate-number-calcMode-discrete-keyTimes.html:
        * svg/animations/script-tests/svgboolean-animation-1.js: Added.
        (sample1):
        (sample2):
        (sample3):
        (executeTest):
        * svg/animations/svgboolean-animation-1-expected.txt: Added.
        * svg/animations/svgboolean-animation-1.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-06-28 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Wed, 29 Jun 2011 06:46:56 +0000 (06:46 +0000)]
2011-06-28  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Adam Barth.

        Make applyAuthorSheets settable on ShadowRoot.
        https://bugs.webkit.org/show_bug.cgi?id=63599

        Refactoring and adding not-yet used function, tests to follow when API lands.

        * dom/ShadowRoot.cpp:
        (WebCore::ShadowRoot::ShadowRoot): Added initializer.
        (WebCore::ShadowRoot::applyAuthorSheets): Made to use member variable.
        (WebCore::ShadowRoot::setApplyAuthorSheets): Added.
        * dom/ShadowRoot.h: Tweaked, added decls.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-06-28 Ilya Sherman <isherman@chromium.org>
isherman@chromium.org [Wed, 29 Jun 2011 06:35:41 +0000 (06:35 +0000)]
2011-06-28  Ilya Sherman  <isherman@chromium.org>

        Reviewed by Adam Barth.

        form.autocomplete="off" does not work
        https://bugs.webkit.org/show_bug.cgi?id=35823

        * fast/forms/autocomplete-expected.txt: Added.
        * fast/forms/autocomplete.html: Added.
2011-06-28  Ilya Sherman  <isherman@chromium.org>

        Reviewed by Adam Barth.

        form.autocomplete="off" does not work
        Rename the autoComplete() method for HTMLFormElement, HTMLFormControlElementWithState, and HTMLInputElement to shouldAutocomplete()
        Add the autocomplete attribute to HTMLFormElement.idl and HTMLInputElement.idl
        https://bugs.webkit.org/show_bug.cgi?id=35823

        Test: fast/forms/autocomplete.html

        * html/HTMLFormControlElement.cpp:
        (WebCore::HTMLFormControlElementWithState::shouldAutocomplete): Renamed from ::autoComplete()
        (WebCore::HTMLFormControlElementWithState::shouldSaveAndRestoreFormControlState): Update callsite.
        * html/HTMLFormControlElement.h:
        * html/HTMLFormElement.cpp:
        (WebCore::HTMLFormElement::~HTMLFormElement): Update callsite.
        (WebCore::HTMLFormElement::parseMappedAttribute): Update callsite.
        (WebCore::HTMLFormElement::documentDidBecomeActive): Update callsite.
        (WebCore::HTMLFormElement::willMoveToNewOwnerDocument): Update callsite.
        (WebCore::HTMLFormElement::didMoveToNewOwnerDocument): Update callsite.
        (WebCore::HTMLFormElement::shouldAutocomplete): Renamed from ::autoComplete()
        * html/HTMLFormElement.h:
        * html/HTMLFormElement.idl: Bind the autocomplete attribute to a JavaScript property.
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::shouldAutocomplete): Renamed from ::autoComplete()
        * html/HTMLInputElement.h:
        * html/HTMLInputElement.idl: Bind the autocomplete attribute to a JavaScript property.
        * WebCore.exp.in: Updated autoComplete() -> shouldAutocomplete()
2011-06-28  Ilya Sherman  <isherman@chromium.org>

        Reviewed by Adam Barth.

        form.autocomplete="off" does not work
        https://bugs.webkit.org/show_bug.cgi?id=35823

        * src/EditorClientImpl.cpp:
        (WebKit::EditorClientImpl::autofill): Update callsite.
        * src/WebFormElement.cpp:
        (WebKit::WebFormElement::autoComplete): Update callsite.
        * src/WebInputElement.cpp:
        (WebKit::WebInputElement::autoComplete): Update callsite.
        * src/WebPasswordFormUtils.cpp:
        (WebKit::findPasswordFormFields): Update callsite.
2011-06-28  Ilya Sherman  <isherman@chromium.org>

        Reviewed by Adam Barth.

        form.autocomplete="off" does not work
        https://bugs.webkit.org/show_bug.cgi?id=35823

        * WebView/WebHTMLRepresentation.mm:
        (-[WebHTMLRepresentation elementDoesAutoComplete:]): Update callsite.
2011-06-28  Ilya Sherman  <isherman@chromium.org>

        Reviewed by Adam Barth.

        form.autocomplete="off" does not work
        https://bugs.webkit.org/show_bug.cgi?id=35823

        * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
        (DumpRenderTreeSupportQt::elementDoesAutoCompleteForElementWithId): Update callsite.
2011-06-28  Ilya Sherman  <isherman@chromium.org>

        Reviewed by Adam Barth.

        form.autocomplete="off" does not work
        https://bugs.webkit.org/show_bug.cgi?id=35823

        * WebFrame.cpp:
        (WebFrame::elementDoesAutoComplete): Updated callsite.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-06-28 Roland Steiner <rolandsteiner@chromium.org>
rolandsteiner@chromium.org [Wed, 29 Jun 2011 06:06:14 +0000 (06:06 +0000)]
2011-06-28  Roland Steiner  <rolandsteiner@chromium.org>

        Unreviewed: change URLs in ruby layout tests to lower case in order
        to avoid having to have separate Chromium expectations.

        * fast/ruby/after-block-doesnt-crash-expected.txt:
        * fast/ruby/after-block-doesnt-crash.html:
        * fast/ruby/after-table-doesnt-crash-expected.txt:
        * fast/ruby/after-table-doesnt-crash.html:
        * fast/ruby/before-block-doesnt-crash-expected.txt:
        * fast/ruby/before-block-doesnt-crash.html:
        * fast/ruby/before-table-doesnt-crash-expected.txt:
        * fast/ruby/before-table-doesnt-crash.html:
        * fast/ruby/generated-after-counter-doesnt-crash-expected.txt:
        * fast/ruby/generated-after-counter-doesnt-crash.html:
        * fast/ruby/generated-before-and-after-counter-doesnt-crash-expected.txt:
        * fast/ruby/generated-before-and-after-counter-doesnt-crash.html:
        * fast/ruby/generated-before-counter-doesnt-crash-expected.txt:
        * fast/ruby/generated-before-counter-doesnt-crash.html:
        * platform/chromium-mac/fast/ruby/after-block-doesnt-crash-expected.txt: Removed.
        * platform/chromium-mac/fast/ruby/after-table-doesnt-crash-expected.txt: Removed.
        * platform/chromium-mac/fast/ruby/before-block-doesnt-crash-expected.txt: Removed.
        * platform/chromium-mac/fast/ruby/before-table-doesnt-crash-expected.txt: Removed.
        * platform/chromium-win/fast/ruby/after-block-doesnt-crash-expected.txt: Removed.
        * platform/chromium-win/fast/ruby/after-table-doesnt-crash-expected.txt: Removed.
        * platform/chromium-win/fast/ruby/before-block-doesnt-crash-expected.txt: Removed.
        * platform/chromium-win/fast/ruby/before-table-doesnt-crash-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-06-28 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Wed, 29 Jun 2011 06:05:16 +0000 (06:05 +0000)]
2011-06-28  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Kent Tamura.

        Store shadowPseudoId in ElementRareData.
        https://bugs.webkit.org/show_bug.cgi?id=63604

        No new tests, because the code isn't yet used.

        * css/CSSSelector.cpp:
        (WebCore::CSSSelector::isUnknownPseudoType): Added convenience helper.
        * css/CSSSelector.h: Added decl.
        * dom/Element.cpp:
        (WebCore::Element::shadowPseudoId): Changed to use ElementRareData.
        (WebCore::Element::setShadowPseudoId): Ditto.
        * dom/Element.h: Added decls.
        * dom/ElementRareData.h: Added a member to keep shadowPseudoId.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-06-28 Kenichi Ishibashi <bashi@chromium.org>
bashi@chromium.org [Wed, 29 Jun 2011 06:01:53 +0000 (06:01 +0000)]
2011-06-28  Kenichi Ishibashi  <bashi@chromium.org>

        Reviewed by Tony Chang.

        [Chromium] Remove dependencies on harfbuzz from FontPlatformDataLinux and FontLinux
        https://bugs.webkit.org/show_bug.cgi?id=62530

        - Moved codes of FontLinux which depend on harfbuzz APIs to ComplexTextController.  Removed Some methods of ComplexTextController(advances() and logClusters()) since they are no longer needed.
        - Moved RefCountedHarfbuzzFace from FontPlatformDataLinux to HarfbuzzSkia and renamed it to HarfbuzzFace.

        No new tests because there is no behavior change (The existing tests should cover the changes).

        * platform/graphics/chromium/ComplexTextControllerLinux.cpp:
        (WebCore::ComplexTextController::ComplexTextController): Added arguments so eliminating setter invocations.
        (WebCore::ComplexTextController::setupForRTL): Added.
        (WebCore::ComplexTextController::setupFontForScriptRun): Adopt the change of HarfbuzzFace class.
        (WebCore::ComplexTextController::setGlyphPositions): Use m_item.log_clusters instead of removed method.
        (WebCore::ComplexTextController::glyphIndexForXPositionInScriptRun): Added.
        (WebCore::ComplexTextController::offsetForPosition): Ditto.
        (WebCore::ComplexTextController::selectionRect): Ditto.
        * platform/graphics/chromium/ComplexTextControllerLinux.h:
        (WebCore::ComplexTextController::width):
        * platform/graphics/chromium/FontLinux.cpp: Removed truncateFixedPointToInteger().
        (WebCore::Font::drawComplexText): Removed setter invocations of ComplexTextController.
        (WebCore::Font::floatWidthForComplexText): Ditto.
        (WebCore::Font::offsetForPositionForComplexText): Moved harfbuzz dependent code to ComplexTextController.
        (WebCore::Font::selectionRectForComplexText): Ditto.
        * platform/graphics/chromium/FontPlatformDataLinux.cpp:
        (WebCore::FontPlatformData::harfbuzzFace): Wrapped up HB_FaceRec in HarfbuzzFace class.
        * platform/graphics/chromium/FontPlatformDataLinux.h: Moved RefCountedHarfbuzzFace class and renamed to HarfbuzzFace.
        * platform/graphics/chromium/HarfbuzzSkia.cpp:
        (WebCore::allocHarfbuzzFont): Moved from ComplexTextControllerLinux.cpp.
        (WebCore::HarfbuzzFace::HarfbuzzFace): Added.
        (WebCore::HarfbuzzFace::~HarfbuzzFace): Added.
        * platform/graphics/chromium/HarfbuzzSkia.h:
        (WebCore::HarfbuzzFace::create): Added.
        (WebCore::HarfbuzzFace::face): Added.
        * platform/graphics/skia/GlyphPageTreeNodeSkia.cpp:
        (WebCore::substituteWithVerticalGlyphs): Adopt  the change of HarfbuzzFace class.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-06-28 Roland Steiner <rolandsteiner@chromium.org>
rolandsteiner@chromium.org [Wed, 29 Jun 2011 04:34:38 +0000 (04:34 +0000)]
2011-06-28  Roland Steiner  <rolandsteiner@chromium.org>

        Reviewed by Eric Seidel.

        Bug 55930 - (CVE-2011-1440) Incorrect handling of 'display:' property within nested <ruby> tags
        https://bugs.webkit.org/show_bug.cgi?id=55930

        Test that a generated block child + counter within a <ruby> doesn't crash.
        (Test as provided by original reporter).

        * fast/ruby/generated-after-counter-doesnt-crash-expected.txt: Added.
        * fast/ruby/generated-after-counter-doesnt-crash.html: Added.
        * fast/ruby/generated-before-and-after-counter-doesnt-crash-expected.txt: Added.
        * fast/ruby/generated-before-and-after-counter-doesnt-crash.html: Added.
        * fast/ruby/generated-before-counter-doesnt-crash-expected.txt: Added.
        * fast/ruby/generated-before-counter-doesnt-crash.html: Added.
2011-06-28  Roland Steiner  <rolandsteiner@chromium.org>

        Reviewed by Eric Seidel.

        Bug 55930 - (CVE-2011-1440) Incorrect handling of 'display:' property within nested <ruby> tags
        https://bugs.webkit.org/show_bug.cgi?id=55930

        Don't set style type BEFORE/AFTER on anonymous wrapper block.
        Rather, check style type on generated wrapped child.

        Tests: fast/ruby/generated-after-counter-doesnt-crash.html
               fast/ruby/generated-before-and-after-counter-doesnt-crash.html
               fast/ruby/generated-before-counter-doesnt-crash.html

        * rendering/RenderRuby.cpp:
        (WebCore::isAnonymousRubyInlineBlock):
        (WebCore::isRubyBeforeBlock):
        (WebCore::isRubyAfterBlock):
        (WebCore::rubyBeforeBlock):
        (WebCore::rubyAfterBlock):
        (WebCore::createAnonymousRubyInlineBlock):
        (WebCore::RenderRubyAsInline::addChild):
        (WebCore::RenderRubyAsBlock::addChild):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDFG JIT lacks array.length caching.
barraclough@apple.com [Wed, 29 Jun 2011 03:18:58 +0000 (03:18 +0000)]
DFG JIT lacks array.length caching.
https://bugs.webkit.org/show_bug.cgi?id=63505

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-06-28
Reviewed by Gavin Barraclough.

* bytecode/StructureStubInfo.h:
* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::cachedGetById):
(JSC::DFG::JITCodeGenerator::cachedPutById):
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::tryAllocate):
(JSC::DFG::JITCodeGenerator::selectScratchGPR):
(JSC::DFG::JITCodeGenerator::silentSpillAllRegisters):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileFunction):
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::addPropertyAccess):
(JSC::DFG::JITCompiler::PropertyAccessRecord::PropertyAccessRecord):
* dfg/DFGRegisterBank.h:
(JSC::DFG::RegisterBank::tryAllocate):
* dfg/DFGRepatch.cpp:
(JSC::DFG::tryCacheGetByID):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-06-28 Pierre Rossi <pierre.rossi@gmail.com>
commit-queue@webkit.org [Wed, 29 Jun 2011 02:41:47 +0000 (02:41 +0000)]
2011-06-28  Pierre Rossi  <pierre.rossi@gmail.com>

        Reviewed by Eric Seidel.

        Warnings in JSC's JIT on 32 bit
        https://bugs.webkit.org/show_bug.cgi?id=63259

        Fairly straightforward, just use ASSERT_JIT_OFFSET_UNUSED when it applies.

        * jit/JITPropertyAccess32_64.cpp:
        (JSC::JIT::emit_op_method_check):
        (JSC::JIT::compileGetByIdHotPath):
        (JSC::JIT::emit_op_put_by_id):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-06-28 Emil A Eklund <eae@chromium.org>
eae@chromium.org [Wed, 29 Jun 2011 01:28:51 +0000 (01:28 +0000)]
2011-06-28  Emil A Eklund  <eae@chromium.org>

        Reviewed by Eric Seidel.

        Switch RenderLayer position/size to to new layout types
        https://bugs.webkit.org/show_bug.cgi?id=63578

        Switch location and size methods for RenderLayer over to the new layout unit abstraction.

        No new tests, no functionality changes.

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::resize):
        (WebCore::RenderLayer::visibleHeight):
        (WebCore::RenderLayer::visibleWidth):
        (WebCore::RenderLayer::offsetFromResizeCorner):
        * rendering/RenderLayer.h:
        (WebCore::RenderLayer::location):
        (WebCore::RenderLayer::setLocation):
        (WebCore::RenderLayer::size):
        (WebCore::RenderLayer::setSize):
        (WebCore::RenderLayer::rect):
        (WebCore::RenderLayer::renderBoxLocation):
        (WebCore::RenderLayer::renderBoxX):
        (WebCore::RenderLayer::renderBoxY):
        * rendering/RenderListBox.cpp:
        (WebCore::RenderListBox::visibleHeight):
        (WebCore::RenderListBox::visibleWidth):
        * rendering/RenderListBox.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-06-28 Levi Weintraub <leviw@chromium.org>
leviw@chromium.org [Wed, 29 Jun 2011 01:06:00 +0000 (01:06 +0000)]
2011-06-28  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Eric Seidel.

        Switch paintObject and paintReplaced to new layout types
        https://bugs.webkit.org/show_bug.cgi?id=63585

        Switching paintObject and paintReplaced to layout type abstractions from more integral types.

        No new tests as this is just moving to an abstraction.

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::paintObject):
        * rendering/RenderBlock.h:
        * rendering/RenderBox.h:
        (WebCore::RenderBox::paintObject):
        * rendering/RenderEmbeddedObject.cpp:
        (WebCore::RenderEmbeddedObject::paintReplaced):
        * rendering/RenderEmbeddedObject.h:
        * rendering/RenderFileUploadControl.cpp:
        (WebCore::RenderFileUploadControl::paintObject):
        * rendering/RenderFileUploadControl.h:
        * rendering/RenderHTMLCanvas.cpp:
        (WebCore::RenderHTMLCanvas::paintReplaced):
        * rendering/RenderHTMLCanvas.h:
        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::paintReplaced):
        * rendering/RenderImage.h:
        * rendering/RenderListBox.cpp:
        (WebCore::RenderListBox::paintObject):
        * rendering/RenderListBox.h:
        * rendering/RenderReplaced.h:
        (WebCore::RenderReplaced::paintReplaced):
        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::paintObject):
        * rendering/RenderTable.h:
        * rendering/RenderTableSection.cpp:
        (WebCore::RenderTableSection::paintObject):
        * rendering/RenderTableSection.h:
        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::paintObject):
        * rendering/RenderTextControl.h:
        * rendering/RenderVideo.cpp:
        (WebCore::RenderVideo::paintReplaced):
        * rendering/RenderVideo.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-06-28 Adam Langley <agl@chromium.org>
agl@chromium.org [Wed, 29 Jun 2011 01:03:18 +0000 (01:03 +0000)]
2011-06-28  Adam Langley  <agl@chromium.org>

        Reviewed by Adam Barth.

        Skip cache validation on back with HTTPS.
        https://bugs.webkit.org/show_bug.cgi?id=63537

        * http/tests/cache/history-only-cached-subresource-loads-max-age-https-expected.txt: Added.
        * http/tests/cache/history-only-cached-subresource-loads-max-age-https.html: Added.
        * http/tests/cache/resources/max-age-resource-forward.html: Added.
        * http/tests/cache/resources/max-age-resource-next.html: Added.
        * http/tests/cache/resources/max-age-resource.html: Added.
        * http/tests/cache/resources/random-max-age.cgi: Added.
2011-06-28  Adam Langley  <agl@chromium.org>

        Reviewed by Adam Barth.

        Skip cache validation on back with HTTPS.
        https://bugs.webkit.org/show_bug.cgi?id=63537

        For back navigations over HTTP, WebKit sets a flag to use cached data
        irrespective of whether it has expired. However, this isn't currently
        done for HTTPS.

        The logic in question was added in
        https://bugs.webkit.org/show_bug.cgi?id=33993 and appears to have been
        precautionary. However, both Firefox and IE will use this back
        navigation trick for HTTPS as well and so we should probably behave
        likewise.

        Test: http/tests/cache/history-only-cached-subresource-loads-max-age-https.html

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::addExtraFieldsToRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-06-28 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Wed, 29 Jun 2011 00:58:45 +0000 (00:58 +0000)]
2011-06-28  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Adam Barth.

        Remove errant isShadowBoundary on ShadowRoot.
        https://bugs.webkit.org/show_bug.cgi?id=63588

        Removing dead code, no tests for that.

        * dom/ShadowRoot.h: Removed a function that's no longer used.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-06-28 Zeng Huiqing <huiqing.zeng@intel.com>
commit-queue@webkit.org [Wed, 29 Jun 2011 00:57:24 +0000 (00:57 +0000)]
2011-06-28  Zeng Huiqing  <huiqing.zeng@intel.com>

        Reviewed by Kenneth Russell.

        [chromium]Optimize GraphicsLayerChromium::setChildren()
        https://bugs.webkit.org/show_bug.cgi?id=62837

        No new tests.

        * platform/graphics/chromium/GraphicsLayerChromium.cpp:
        (WebCore::GraphicsLayerChromium::GraphicsLayerChromium):
        (WebCore::GraphicsLayerChromium::setChildren):
        (WebCore::GraphicsLayerChromium::addChild):
        * platform/graphics/chromium/GraphicsLayerChromium.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-06-28 Levi Weintraub <leviw@chromium.org>
leviw@chromium.org [Wed, 29 Jun 2011 00:53:04 +0000 (00:53 +0000)]
2011-06-28  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Eric Seidel.

        Switch paintBoxShadow and paintBoxDecorations to new layout types
        https://bugs.webkit.org/show_bug.cgi?id=63577

        Switching paintBoxShadow and paintBoxDecorations to layout type abstraction
        from more integral types.

        No new tests as this is just moving to an abstraction.

        * rendering/InlineFlowBox.cpp:
        (WebCore::InlineFlowBox::paintBoxShadow):
        (WebCore::InlineFlowBox::paintBoxDecorations):
        * rendering/InlineFlowBox.h:
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::paintBoxDecorations):
        * rendering/RenderBox.h:
        * rendering/RenderBoxModelObject.cpp:
        (WebCore::RenderBoxModelObject::paintBoxShadow):
        * rendering/RenderBoxModelObject.h:
        * rendering/RenderFieldset.cpp:
        (WebCore::RenderFieldset::paintBoxDecorations):
        * rendering/RenderFieldset.h:
        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::paintBoxDecorations):
        * rendering/RenderTable.h:
        * rendering/RenderTableCell.cpp:
        (WebCore::RenderTableCell::paintBoxDecorations):
        * rendering/RenderTableCell.h:
        * rendering/RenderView.cpp:
        (WebCore::RenderView::paintBoxDecorations):
        * rendering/RenderView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-06-28 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Wed, 29 Jun 2011 00:49:05 +0000 (00:49 +0000)]
2011-06-28  Ryosuke Niwa  <rniwa@webkit.org>

        Rolled DEPS.

        * DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-06-28 Emil A Eklund <eae@chromium.org>
eae@chromium.org [Tue, 28 Jun 2011 23:56:01 +0000 (23:56 +0000)]
2011-06-28  Emil A Eklund  <eae@chromium.org>

        Reviewed by Eric Seidel.

        Switch RenderBox position/size to to new layout types
        https://bugs.webkit.org/show_bug.cgi?id=63571

        Switch location and size methods for RenderBox over to the new layout unit abstraction.

        No new tests, no functionality changes.

        * rendering/RenderBox.cpp:
        * rendering/RenderBox.h:
        * rendering/RenderBoxModelObject.cpp:
        * rendering/RenderBoxModelObject.h:
        * rendering/RenderInline.cpp:
        * rendering/RenderInline.h:
        * rendering/RenderVideo.cpp:
        * rendering/RenderVideo.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed build correction. Link to correct library for
bfulgham@webkit.org [Tue, 28 Jun 2011 23:52:14 +0000 (23:52 +0000)]
Unreviewed build correction.  Link to correct library for
the zlib1.dll.

* win/tools/vsprops/WinCairo.vsprops: Don't link to the static
zlib.lib when building for WinCairo.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-06-28 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Tue, 28 Jun 2011 23:39:05 +0000 (23:39 +0000)]
2011-06-28  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r89968.
        http://trac.webkit.org/changeset/89968
        https://bugs.webkit.org/show_bug.cgi?id=63581

        Broke chromium windows compile (Requested by jamesr on
        #webkit).

        * wtf/Platform.h:
2011-06-28  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r89968.
        http://trac.webkit.org/changeset/89968
        https://bugs.webkit.org/show_bug.cgi?id=63581

        Broke chromium windows compile (Requested by jamesr on
        #webkit).

        * WebCore.gyp/WebCore.gyp:
        * loader/cache/CachedFont.cpp:
        * platform/chromium/DragImageRef.h:
        * platform/graphics/FloatPoint.h:
        * platform/graphics/FloatRect.h:
        * platform/graphics/FloatSize.h:
        * platform/graphics/FontPlatformData.h:
        (WebCore::FontPlatformData::hash):
        * platform/graphics/GlyphBuffer.h:
        (WebCore::GlyphBuffer::advanceAt):
        (WebCore::GlyphBuffer::add):
        (WebCore::GlyphBuffer::expandLastAdvance):
        * platform/graphics/IntPoint.h:
        * platform/graphics/IntRect.h:
        * platform/graphics/IntSize.h:
        * platform/graphics/SimpleFontData.h:
        * platform/graphics/cg/FloatPointCG.cpp:
        * platform/graphics/cg/FloatRectCG.cpp:
        * platform/graphics/cg/FloatSizeCG.cpp:
        * platform/graphics/cg/IntPointCG.cpp:
        * platform/graphics/cg/IntRectCG.cpp:
        * platform/graphics/cg/IntSizeCG.cpp:
        * platform/graphics/mac/FontCustomPlatformData.cpp:
        (WebCore::FontCustomPlatformData::~FontCustomPlatformData):
        (WebCore::createFontCustomPlatformData):
        * platform/graphics/mac/FontCustomPlatformData.h:
        (WebCore::FontCustomPlatformData::FontCustomPlatformData):
2011-06-28  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r89968.
        http://trac.webkit.org/changeset/89968
        https://bugs.webkit.org/show_bug.cgi?id=63581

        Broke chromium windows compile (Requested by jamesr on
        #webkit).

        * WebKit.gyp:
        * features.gypi:
        * public/WebCommon.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-06-28 Levi Weintraub <leviw@chromium.org>
leviw@chromium.org [Tue, 28 Jun 2011 23:36:28 +0000 (23:36 +0000)]
2011-06-28  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Eric Seidel.

        Switch PaintMask* to new layout types
        https://bugs.webkit.org/show_bug.cgi?id=63576

        Switching paintMask* to layout type abstraction from more integral types.

        No new tests as this is just moving to an abstraction.

        * rendering/InlineFlowBox.cpp:
        (WebCore::InlineFlowBox::paintMask):
        * rendering/InlineFlowBox.h:
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::paintMask):
        (WebCore::RenderBox::paintMaskImages):
        * rendering/RenderBox.h:
        * rendering/RenderFieldset.cpp:
        (WebCore::RenderFieldset::paintMask):
        * rendering/RenderFieldset.h:
        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::paintMask):
        * rendering/RenderTable.h:
        * rendering/RenderTableCell.cpp:
        (WebCore::RenderTableCell::paintMask):
        * rendering/RenderTableCell.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-06-28 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Tue, 28 Jun 2011 23:26:54 +0000 (23:26 +0000)]
2011-06-28  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        Fix sampling build
        https://bugs.webkit.org/show_bug.cgi?id=63579

        Gets opcode sampling building again, doesn't seem to work alas

        * bytecode/SamplingTool.cpp:
        (JSC::SamplingTool::notifyOfScope):
        * bytecode/SamplingTool.h:
        (JSC::SamplingTool::SamplingTool):
        * interpreter/Interpreter.cpp:
        (JSC::Interpreter::enableSampler):
        * runtime/Executable.h:
        (JSC::ScriptExecutable::ScriptExecutable):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89973 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-06-27 Diego Gonzalez <diegohcg@webkit.org>
diegohcg@webkit.org [Tue, 28 Jun 2011 23:11:30 +0000 (23:11 +0000)]
2011-06-27  Diego Gonzalez  <diegohcg@webkit.org>

    Reviewed by Kenneth Rohde Christiansen.

    [Qt] DRT support for setInteractiveFormValidationEnabled
    https://bugs.webkit.org/show_bug.cgi?id=63496

    Unskipped:
        fast/forms/interactive-validation-prevented.html
        fast/forms/interactive-validation-attach-assertion.html
        fast/forms/interactive-validation-assertion-by-validate-twice.html
        fast/forms/interactive-validation-select-crash.html
        fast/forms/interactive-validation-crash-by-style-override.html

    Source/WebKit/qt:

    * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
    (DumpRenderTreeSupportQt::setInteractiveFormValidationEnabled):
    * WebCoreSupport/DumpRenderTreeSupportQt.h:

    Tools:

    * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
    (WebCore::DumpRenderTree::DumpRenderTree):

    LayoutTests:

    * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-06-28 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 28 Jun 2011 23:06:20 +0000 (23:06 +0000)]
2011-06-28  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Make new-run-webkit-tests -2 actually use WebKitTestRunner
        https://bugs.webkit.org/show_bug.cgi?id=63572

        new-run-webkit-tests -2 works with this change.  However a zillion
        tests fail since it can't find the right skipped lists for wk2.
        The Skipped-list fixing is covered in bug 63501.

        * Scripts/webkitpy/layout_tests/port/gtk.py:
        * Scripts/webkitpy/layout_tests/port/qt.py:
        * Scripts/webkitpy/layout_tests/port/webkit.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-06-28 Levi Weintraub <leviw@chromium.org>
leviw@chromium.org [Tue, 28 Jun 2011 22:41:36 +0000 (22:41 +0000)]
2011-06-28  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Eric Seidel.

        Switch paintFillLayer* to new layout types
        https://bugs.webkit.org/show_bug.cgi?id=63570

        Switching painFillLayer* to layout type abstraction from more integral types.

        No new tests as this is just moving to an abstraction.

        * rendering/InlineFlowBox.cpp:
        (WebCore::InlineFlowBox::paintFillLayers):
        (WebCore::InlineFlowBox::paintFillLayer):
        * rendering/InlineFlowBox.h:
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::paintFillLayers):
        (WebCore::RenderBox::paintFillLayer):
        * rendering/RenderBox.h:
        * rendering/RenderBoxModelObject.cpp:
        (WebCore::RenderBoxModelObject::paintFillLayerExtended):
        * rendering/RenderBoxModelObject.h:
        * rendering/RenderObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89970 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-06-28 Luke Macpherson <macpherson@chromium.org>
macpherson@chromium.org [Tue, 28 Jun 2011 22:33:06 +0000 (22:33 +0000)]
2011-06-28  Luke Macpherson   <macpherson@chromium.org>

        Reviewed by Eric Seidel.

        Use appropriate macro for CSSPropertyWebkitAppearance in CSSStyleSelector::applyProperty()
        https://bugs.webkit.org/show_bug.cgi?id=63197

        No new tests / no functionality changed.

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):
        Use HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE macro and delete duplicate code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-06-28 Cary Clark <caryclark@google.com>
commit-queue@webkit.org [Tue, 28 Jun 2011 22:27:15 +0000 (22:27 +0000)]
2011-06-28  Cary Clark  <caryclark@google.com>

        Reviewed by James Robinson.

        Use Skia if Skia on Mac Chrome is enabled
        https://bugs.webkit.org/show_bug.cgi?id=62999

        * wtf/Platform.h:
        Add switch to use Skia if, externally,
        Skia has been enabled by a gyp define.
2011-06-28  Cary Clark  <caryclark@google.com>

        Reviewed by James Robinson.

        Use Skia if Skia on Mac Chrome is enabled
        https://bugs.webkit.org/show_bug.cgi?id=62999

        No new tests. This does not affect existing
        functionality.

        * WebCore.gyp/WebCore.gyp:
        Include Skia and related files and exclude CG
        and related files when building Chromium for Skia
        on the Mac.

        * loader/cache/CachedFont.cpp:
        Rename CHROME to CHROMIUM.

        * platform/chromium/DragImageRef.h:
        * platform/graphics/FloatPoint.h:
        * platform/graphics/FloatRect.h:
        * platform/graphics/FloatSize.h:
        * platform/graphics/FontPlatformData.h:
        (WebCore::FontPlatformData::hash):
        * platform/graphics/GlyphBuffer.h:
        (WebCore::GlyphBuffer::advanceAt):
        (WebCore::GlyphBuffer::add):
        (WebCore::GlyphBuffer::expandLastAdvance):
        * platform/graphics/IntPoint.h:
        * platform/graphics/IntRect.h:
        * platform/graphics/IntSize.h:
        * platform/graphics/SimpleFontData.h:
        * platform/graphics/cg/FloatPointCG.cpp:
        * platform/graphics/cg/FloatRectCG.cpp:
        * platform/graphics/cg/FloatSizeCG.cpp:
        * platform/graphics/cg/IntPointCG.cpp:
        * platform/graphics/cg/IntRectCG.cpp:
        * platform/graphics/cg/IntSizeCG.cpp:
        * platform/graphics/mac/FontCustomPlatformData.cpp:
        (WebCore::FontCustomPlatformData::~FontCustomPlatformData):
        (WebCore::createFontCustomPlatformData):
        * platform/graphics/mac/FontCustomPlatformData.h:
        (WebCore::FontCustomPlatformData::FontCustomPlatformData):
        Ditto.
2011-06-28  Cary Clark  <caryclark@google.com>

        Reviewed by James Robinson.

        Use Skia if Skia on Mac Chrome is enabled
        https://bugs.webkit.org/show_bug.cgi?id=62999

        * WebKit.gyp:
        If building for Skia, exclude CG files.
        If not, exclude Skia files.

        * features.gypi:
        Enable Skia on Chromium Mac if so instructed by the gyp define.
        Allow Skia to be hardware accelerated on the Mac.

        * public/WebCommon.h:
        If Skia is defined on the Mac, define it in the WebXXX
        interfaces as well.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-06-28 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Tue, 28 Jun 2011 22:15:06 +0000 (22:15 +0000)]
2011-06-28  Nate Chapin  <japhet@chromium.org>

        Unreviewed, chromium test update for r89951.

        * platform/chromium-linux/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.png: Added.
        * platform/chromium-linux/svg/custom/text-tref-03-b-change-href-dom-expected.png: Added.
        * platform/chromium-linux/svg/custom/text-tref-03-b-change-href-expected.png: Added.
        * platform/chromium-linux/svg/custom/text-tref-03-b-referenced-element-removal-expected.png: Added.
        * platform/chromium-linux/svg/custom/text-tref-03-b-tref-removal-expected.png: Added.
        * platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.png: Added.
        * platform/chromium-win/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.png: Added.
        * platform/chromium-win/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.txt: Added.
        * platform/chromium-win/svg/custom/text-tref-03-b-change-href-dom-expected.png: Added.
        * platform/chromium-win/svg/custom/text-tref-03-b-change-href-dom-expected.txt: Added.
        * platform/chromium-win/svg/custom/text-tref-03-b-change-href-expected.png: Added.
        * platform/chromium-win/svg/custom/text-tref-03-b-change-href-expected.txt: Added.
        * platform/chromium-win/svg/custom/text-tref-03-b-referenced-element-removal-expected.png: Added.
        * platform/chromium-win/svg/custom/text-tref-03-b-referenced-element-removal-expected.txt: Added.
        * platform/chromium-win/svg/custom/text-tref-03-b-tref-removal-expected.png: Added.
        * platform/chromium-win/svg/custom/text-tref-03-b-tref-removal-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-06-28 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Tue, 28 Jun 2011 22:09:58 +0000 (22:09 +0000)]
2011-06-28  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Adam Roben.

        Add more machines to Chromium Mac Release and Chromium Mac Release (Tests)
        https://bugs.webkit.org/show_bug.cgi?id=63500

        Added google-mac-3 and google-mac-4.

        * BuildSlaveSupport/build.webkit.org-config/config.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-06-28 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 28 Jun 2011 22:06:09 +0000 (22:06 +0000)]
2011-06-28  Eric Seidel  <eric@webkit.org>

        Reviewed by Dirk Pranke.

        Remove webkitpy's tiger support now that WebKit no longer supports tiger
        https://bugs.webkit.org/show_bug.cgi?id=63568

        I don't think our support actually fully worked anyway.  Regardless
        tiger is dead now (thankfully)!

        I also unwrapped some short lines and added a couple FIXMEs while
        touring the code.

        No new tests, only removing old ones which tested our Tiger support.

        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/builders.py:
        * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
        * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
        * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
        * Scripts/webkitpy/layout_tests/port/mac.py:
        * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
        * Scripts/webkitpy/tool/commands/rebaseline.py:
        * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-06-28 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Tue, 28 Jun 2011 21:51:36 +0000 (21:51 +0000)]
2011-06-28  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        ASSERT when launching debug builds with interpreter and jit enabled
        https://bugs.webkit.org/show_bug.cgi?id=63566

        Add appropriate guards to the various Executable's memory reporting
        logic.

        * runtime/Executable.cpp:
        (JSC::EvalExecutable::compileInternal):
        (JSC::ProgramExecutable::compileInternal):
        (JSC::FunctionExecutable::compileForCallInternal):
        (JSC::FunctionExecutable::compileForConstructInternal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-06-28 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 28 Jun 2011 21:51:19 +0000 (21:51 +0000)]
2011-06-28  Eric Seidel  <eric@webkit.org>

        Unreviewed, just fixing a typo.

        Fix misspellings of "thead" to "thread".

        * Scripts/webkitpy/common/checkout/scm/git.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-06-28 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 28 Jun 2011 21:44:17 +0000 (21:44 +0000)]
2011-06-28  Eric Seidel  <eric@webkit.org>

        Reviewed by Tony Chang.

        new-run-webkit-tests needs a --webkit-test-runner option
        https://bugs.webkit.org/show_bug.cgi?id=63439

        This was accidentally fixed in bug 63501 as well.
        The root problem here was that the webkit unit tests were not using
        enough mocks.  I've fixed them here to use more mocks
        which should unbreak windows.

        * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=63563
barraclough@apple.com [Tue, 28 Jun 2011 21:33:38 +0000 (21:33 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=63563
DFG JIT - add support for double arith to speculative path

Reviewed by Oliver Hunt.

Add integer support for div & mod, add double support for div, mod,
add, sub & mul, dynamically selecting based on operand types.

* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::FPRTemporary::FPRTemporary):
* dfg/DFGJITCodeGenerator.h:
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::assembler):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculateDoubleOperand::SpeculateDoubleOperand):
(JSC::DFG::SpeculateDoubleOperand::~SpeculateDoubleOperand):
(JSC::DFG::SpeculateDoubleOperand::index):
(JSC::DFG::SpeculateDoubleOperand::fpr):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix interpreter build.
oliver@apple.com [Tue, 28 Jun 2011 21:18:31 +0000 (21:18 +0000)]
Fix interpreter build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-06-28 Alexis Menard <alexis.menard@openbossa.org>
alexis.menard@openbossa.org [Tue, 28 Jun 2011 21:13:25 +0000 (21:13 +0000)]
2011-06-28  Alexis Menard  <alexis.menard@openbossa.org>

        Reviewed by Andreas Kling.

        [Qt] Use <QtX/x.h> style of headers for Qt tests which rely on it.
        https://bugs.webkit.org/show_bug.cgi?id=63562

        Some Qt auto-tests rely on <QtX/x.h> types of includes.

        * Api/qwebkitplatformplugin.h:
        * symbian/platformplugin/qwebkitplatformplugin.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=63561
barraclough@apple.com [Tue, 28 Jun 2011 21:06:49 +0000 (21:06 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=63561
DFG JIT - don't always assume integer in relational compare

Reviewed by Oliver Hunt.

If neither operand is known integer, or either is in double representation,
then at least use a function call (don't bail off the speculative path).

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compilePeepHoleCall):
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::isDataFormatDouble):
(JSC::DFG::SpeculativeJIT::compareIsInteger):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake constant array optimisation less strict about what constitutes a constant
barraclough@apple.com [Tue, 28 Jun 2011 20:47:58 +0000 (20:47 +0000)]
Make constant array optimisation less strict about what constitutes a constant
https://bugs.webkit.org/show_bug.cgi?id=63554

Patch by Oliver Hunt <oliver@apple.com> on 2011-06-28
Reviewed by Gavin Barraclough.

Now allow string constants in array literals to actually be considered constant,
and so avoid codegen in array literals with strings in them.

* bytecode/CodeBlock.h:
(JSC::CodeBlock::addConstantBuffer):
(JSC::CodeBlock::constantBuffer):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::addConstantBuffer):
(JSC::BytecodeGenerator::addStringConstant):
(JSC::BytecodeGenerator::emitNewArray):
* bytecompiler/BytecodeGenerator.h:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-06-28 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Tue, 28 Jun 2011 20:34:25 +0000 (20:34 +0000)]
2011-06-28  Nate Chapin  <japhet@chromium.org>

        Unreviewed, chromium test update for r89946.

        * platform/chromium/fast/regex: Added.
        * platform/chromium/fast/regex/constructor-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-06-28 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Tue, 28 Jun 2011 20:21:37 +0000 (20:21 +0000)]
2011-06-28  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        Make constant array optimisation less strict about what constitutes a constant
        https://bugs.webkit.org/show_bug.cgi?id=63554

        Now allow string constants in array literals to actually be considered constant,
        and so avoid codegen in array literals with strings in them.

        * bytecode/CodeBlock.h:
        (JSC::CodeBlock::addConstantBuffer):
        (JSC::CodeBlock::constantBuffer):
        * bytecompiler/BytecodeGenerator.cpp:
        (JSC::BytecodeGenerator::addConstantBuffer):
        (JSC::BytecodeGenerator::addStringConstant):
        (JSC::BytecodeGenerator::emitNewArray):
        * bytecompiler/BytecodeGenerator.h:
        * interpreter/Interpreter.cpp:
        (JSC::Interpreter::privateExecute):
        * jit/JITStubs.cpp:
        (JSC::DEFINE_STUB_FUNCTION):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-06-28 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Tue, 28 Jun 2011 20:09:55 +0000 (20:09 +0000)]
2011-06-28  Ryosuke Niwa  <rniwa@webkit.org>

        Rolled DEPS.

        * DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-06-28 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Tue, 28 Jun 2011 20:07:31 +0000 (20:07 +0000)]
2011-06-28  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        Stop instantiating Position with PositionIsOffsetInAnchor in various files
        https://bugs.webkit.org/show_bug.cgi?id=63384

        Refactoring.

        Removed many if conditions that compared the anchor type to Position::PositionIsOffsetInAnchor
        because there were also checking that containerNode is a text node.

        Also added Position::containerText() to avoid manually casting containerNode().

        * dom/Position.cpp:
        (WebCore::Position::Position): Added an assertion to ensure BeforeChildren/AfterChildren
        anchor type won't be used for a node whose contents is ignored by editing.
        (WebCore::Position::containerText): Added.
        * dom/Position.h:
        * editing/ApplyBlockElementCommand.cpp:
        (WebCore::isNewLineAtPosition): Removed a redundant comparison of anchor type.
        (WebCore::ApplyBlockElementCommand::rangeForParagraphSplittingTextNodesIfNeeded): Since containerNode
        is always a text node when renderStyleOfEnclosingTextNode returns a render style, use new Position
        constructor that takes Text* and offset.
        (WebCore::ApplyBlockElementCommand::endOfNextParagrahSplittingTextNodesIfNeeded): Removed redundant
        comparison of anchor type and use new Position constructor that takes Text* and offset.
        * editing/ApplyStyleCommand.cpp:
        (WebCore::ApplyStyleCommand::splitTextAtStart): Replaced an assertion that compared anchor type by
        an assertion that the container node is a text node; use new constructor.
        (WebCore::ApplyStyleCommand::splitTextAtEnd): Ditto; also added early exits in the case script
        modified DOM.
        (WebCore::ApplyStyleCommand::splitTextElementAtStart): Ditto.
        (WebCore::ApplyStyleCommand::splitTextElementAtEnd): Ditto.
        (WebCore::ApplyStyleCommand::joinChildTextNodes): Use new constructor.
        * editing/CompositeEditCommand.cpp:
        (WebCore::Editor::replaceSelectedTextInNode): Calls containerText instead of manually casting containerNode.
        * editing/Editor.cpp:
        (WebCore::Editor::canDeleteRange): Call Range::startPosition instead of manually instantiating Position
        by calling startContainer and startOffset.
        * editing/FrameSelection.cpp:
        (WebCore::FrameSelection::setSelectedRange): Ditto.
        * editing/InsertTextCommand.cpp:
        (WebCore::InsertTextCommand::input): Calls containerText instead of manually casting containerNode.
        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::doApply): Calls containerText instead of manually casting containerNode.
        * editing/VisiblePosition.cpp:
        (WebCore::VisiblePosition::characterAfter): Removed a redundant anchor type comparison.
        (WebCore::startVisiblePosition): Call Range::startPosition instead of startContainer and startOffset.
        (WebCore::endVisiblePosition): Call Range::endPosition instead of endContainer and endOffset.
        * editing/htmlediting.cpp:
        (WebCore::firstInSpecialElement): Call containerNode() to address <rdar://problem/5027702>.
        (WebCore::lastInSpecialElement): Ditto; use new constructor.
        * editing/visible_units.cpp:
        (WebCore::endPositionForLine): Use new constructor.
        (WebCore::startOfParagraph): Ditto.
        (WebCore::endOfParagraph): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-06-28 Rob Buis <rbuis@rim.com>
rwlbuis@webkit.org [Tue, 28 Jun 2011 20:04:05 +0000 (20:04 +0000)]
2011-06-28  Rob Buis  <rbuis@rim.com>

        Reviewed by Nikolas Zimmermann.

        SVG1.1SE test text-tref-03-b.svg fails
        https://bugs.webkit.org/show_bug.cgi?id=63390

        Support tref on forward referenced content by listening to DOMSubtreeModified events. This also
        allows updating after modifications in the referenced content subtree.

        Tests: svg/W3C-SVG-1.1-SE/text-tref-03-b.svg
               svg/custom/text-tref-03-b-change-href-dom.svg
               svg/custom/text-tref-03-b-change-href.svg
               svg/custom/text-tref-03-b-dynamic.svg
               svg/custom/text-tref-03-b-dynamic2.svg
               svg/custom/text-tref-03-b-referenced-element-removal.svg
               svg/custom/text-tref-03-b-tref-removal.svg

        * svg/SVGTRefElement.cpp:
        (WebCore::SubtreeModificationEventListener::create):
        (WebCore::SubtreeModificationEventListener::cast):
        (WebCore::SubtreeModificationEventListener::removeFromTarget):
        (WebCore::SubtreeModificationEventListener::SubtreeModificationEventListener):
        (WebCore::SubtreeModificationEventListener::operator==):
        (WebCore::SubtreeModificationEventListener::handleEvent):
        (WebCore::SVGTRefElement::updateReferencedText):
        (WebCore::SVGTRefElement::parseMappedAttribute):
        (WebCore::SVGTRefElement::svgAttributeChanged):
        (WebCore::SVGTRefElement::buildPendingResource):
        (WebCore::SVGTRefElement::removedFromDocument):
        * svg/SVGTRefElement.h:
2011-06-28  Rob Buis  <rbuis@rim.com>

        Reviewed by Nikolas Zimmermann.

        SVG1.1SE test text-tref-03-b.svg fails
        https://bugs.webkit.org/show_bug.cgi?id=63390

        - text-tref-03-b.svg, the w3c SVG1.1 testcase mentioned in the bug.
        - text-tref-03-b-dynamic.svg, tests dynamically adding the tref.
        - text-tref-03-b-dynamic2.svg, tests dynamically adding the referenced content.
        - text-tref-03-b-tref-removal.svg, tests removal of tref.
        - text-tref-03-b-referenced-element-removal.svg, tests removal of referenced content.
        - text-tref-03-b-change-href.svg, tests changing href attribute dynamically through setAttribute.
        - text-tref-03-b-change-href-dom.svg, tests changing href attribute dynamically through href animated property.
        - foreignObject/text-tref-02-b.svg has improved result, but is still not perfect.

        * platform/mac/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.png: Added.
        * platform/mac/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.txt: Added.
        * platform/mac/svg/custom/text-tref-03-b-change-href-dom-expected.png: Added.
        * platform/mac/svg/custom/text-tref-03-b-change-href-dom-expected.txt: Added.
        * platform/mac/svg/custom/text-tref-03-b-change-href-expected.png: Added.
        * platform/mac/svg/custom/text-tref-03-b-change-href-expected.txt: Added.
        * platform/mac/svg/custom/text-tref-03-b-referenced-element-removal-expected.png: Added.
        * platform/mac/svg/custom/text-tref-03-b-referenced-element-removal-expected.txt: Added.
        * platform/mac/svg/custom/text-tref-03-b-tref-removal-expected.png: Added.
        * platform/mac/svg/custom/text-tref-03-b-tref-removal-expected.txt: Added.
        * platform/mac/svg/foreignObject/text-tref-02-b-expected.png:
        * platform/mac/svg/foreignObject/text-tref-02-b-expected.txt:
        * svg/W3C-SVG-1.1-SE/text-tref-03-b.svg: Added.
        * svg/custom/text-tref-03-b-change-href-dom.svg: Added.
        * svg/custom/text-tref-03-b-change-href.svg: Added.
        * svg/custom/text-tref-03-b-dynamic-expected.txt: Added.
        * svg/custom/text-tref-03-b-dynamic.svg: Added.
        * svg/custom/text-tref-03-b-dynamic2-expected.txt: Added.
        * svg/custom/text-tref-03-b-dynamic2.svg: Added.
        * svg/custom/text-tref-03-b-referenced-element-removal.svg: Added.
        * svg/custom/text-tref-03-b-tref-removal.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-06-28 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Tue, 28 Jun 2011 19:37:07 +0000 (19:37 +0000)]
2011-06-28  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Anders Carlsson.

        Split the string creation into a local (while creating text runs)
        so that it is not destroyed prematurely.
        https://bugs.webkit.org/show_bug.cgi?id=63543

        Run fast/forms/text-control-intrinsic-widths.html under valgrind/ASAN.
        * rendering/RenderFileUploadControl.cpp:
        (WebCore::RenderFileUploadControl::computePreferredLogicalWidths):
        this one is just done for caution, in case, we don't do the same
        mistake when adding legacy rounding hacks option.
        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::getAvgCharWidth):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-06-28 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 28 Jun 2011 19:33:27 +0000 (19:33 +0000)]
2011-06-28  Eric Seidel  <eric@webkit.org>

        Reviewed by Tony Chang.

        new-run-webkit-tests should not run mthml tests when MHTML support is disabled
        https://bugs.webkit.org/show_bug.cgi?id=63549

        This way mhtml tests won't show up as "missing" results on all non-chromium platforms.
        I happen to go looking for what code was deciding that .mht was a supported
        extension, found test_files.py and then removed some redundant doc-strings and
        if branching.

        * Scripts/webkitpy/layout_tests/port/test_files.py:
        * Scripts/webkitpy/layout_tests/port/webkit.py:
        * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-06-28 Greg Simon <gregsimon@chromium.org>
commit-queue@webkit.org [Tue, 28 Jun 2011 19:19:33 +0000 (19:19 +0000)]
2011-06-28  Greg Simon  <gregsimon@chromium.org>

        Reviewed by Dimitri Glazkov.

        Update migration LayoutTest to include indexes and successful migration.
        https://bugs.webkit.org/show_bug.cgi?id=62780

        * storage/indexeddb/migrate-basics-expected.txt:
        * storage/indexeddb/migrate-basics.html:
2011-06-28  Greg Simon  <gregsimon@chromium.org>

        Reviewed by Dimitri Glazkov.

        Migrate SQLite backing store to LevelDB backing store for Indexeddb.
        https://bugs.webkit.org/show_bug.cgi?id=62780

        * storage/IDBFactoryBackendImpl.cpp:
        (WebCore::computeFileIdentifier):
        (WebCore::computeUniqueIdentifier):
        (WebCore::IDBFactoryBackendImpl::open):
        (WebCore::migrateObjectStores):
        (WebCore::IDBFactoryBackendImpl::migrateFromSQLiteToLevelDB):
        * storage/IDBLevelDBBackingStore.cpp:
        (WebCore::IDBLevelDBBackingStore::backingStoreExists):
        * storage/IDBLevelDBBackingStore.h:
        * storage/IDBObjectStoreBackendImpl.cpp:
        (WebCore::IDBObjectStoreBackendImpl::populateIndex):
        * storage/IDBObjectStoreBackendImpl.h:
        * storage/IDBSQLiteBackingStore.cpp:
        (WebCore::IDBSQLiteBackingStore::backingStoreExists):
        * storage/IDBSQLiteBackingStore.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-06-28 Chang Shu <cshu@webkit.org>
commit-queue@webkit.org [Tue, 28 Jun 2011 19:01:29 +0000 (19:01 +0000)]
2011-06-28  Chang Shu  <cshu@webkit.org>

        Reviewed by Andreas Kling.

        [Qt][WK2] Random crashes in fast/frames/ tests
        https://bugs.webkit.org/show_bug.cgi?id=63459

        Investigation on the crashes has revealed that sometimes, a frame could
        have been destroyed before it is removed from the hierachy in Qt WebKit2 UI process.
        The root cause lies in the fact that the order of the two contiguous asynchronous
        messages may not be respected on the receiving side. And it is Qt's implementation,
        which uses QTimer::startTimer(0), that causes the reverse order. This patch replaces
        the timer approach with QMetaObject::invokeMethod approach and no crash happens afterwards.

        * Platform/qt/WorkQueueQt.cpp:
        (WorkQueue::scheduleWork):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=55040
barraclough@apple.com [Tue, 28 Jun 2011 18:35:37 +0000 (18:35 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=55040
RegExp constructor returns the argument regexp instead of a new object

Reviewed by Oliver Hunt.

Per 15.10.3.1, our current behaviour is correct if called as a function,
but incorrect when called as a constructor.

Source/JavaScriptCore:

* runtime/RegExpConstructor.cpp:
(JSC::constructRegExp):
(JSC::constructWithRegExpConstructor):
* runtime/RegExpConstructor.h:

LayoutTests:

* fast/regex/constructor-expected.txt: Added.
* fast/regex/constructor.html: Added.
* fast/regex/script-tests/constructor.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-06-28 Levi Weintraub <leviw@chromium.org>
leviw@chromium.org [Tue, 28 Jun 2011 18:31:19 +0000 (18:31 +0000)]
2011-06-28  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Darin Adler.

        Create intermediate classes as a path towards getting off of pixel offsets
        https://bugs.webkit.org/show_bug.cgi?id=61896

        Creating three intermediate typedefs to aid in moving layout and hit testing from integers
        to floats. We'll transition the render tree over to these intermediate types and add
        infrastructure to support the new types behind USE(FLOAT_LAYOUT_OFFSETS). This allows the ultimate
        changeover to be easier.

        Switching LayoutState over to this abstraction to verify it works correctly.

        No new tests since this is creating a new abstraction, not changing current behavior.

        * GNUmakefile.list.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * rendering/LayoutState.cpp:
        (WebCore::LayoutState::LayoutState):
        (WebCore::LayoutState::pageLogicalOffset):
        (WebCore::LayoutState::addForcedColumnBreak):
        * rendering/LayoutState.h:
        * rendering/LayoutTypes.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-06-28 Roland Steiner <rolandsteiner@chromium.org>
rolandsteiner@chromium.org [Tue, 28 Jun 2011 18:29:17 +0000 (18:29 +0000)]
2011-06-28  Roland Steiner  <rolandsteiner@chromium.org>

        Reviewed by Tony Chang.

        Fix filesystem_unittest.FileSystemTest test_read_and_write_file()
        https://bugs.webkit.org/show_bug.cgi?id=63514

        - change write_text_file to write_binary_file
        - check that text_path and binary_path are actually existant files
        - change cleanup block from 'except' to 'finally'

        * Scripts/webkitpy/common/system/filesystem_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89944 268f45cc-cd09-0410-ab3c-d52691b4dbfc