WebKit-https.git
16 years agoSubmitted by: eseidel
eseidel [Fri, 29 Jul 2005 22:05:18 +0000 (22:05 +0000)]
Submitted by: eseidel
Reviewed by: vicki
        * DrawTest/DrawTest.xcodeproj/project.pbxproj:
        Build fix.  Removed bad path.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago - Oops. Last checkin omitted the actual test for:
ggaren [Fri, 29 Jul 2005 22:04:30 +0000 (22:04 +0000)]
    - Oops. Last checkin omitted the actual test for:
        <rdar://problem/3461547> can't use document.writeln() on windows opened via window.open("about:blank") in same function

        * manual-tests/write-after-open.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoSubmitted by: eseidel
eseidel [Fri, 29 Jul 2005 21:43:51 +0000 (21:43 +0000)]
Submitted by: eseidel
        * kdom/xpath/impl/parser/xpath.ypp:
        Turned off "verbose errors" which was generating a warning
        during compile (Bison 1.28 bug).  This is unused code in kdom
        xpath support, thus I didn't ask for review.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago - fixed:
ggaren [Fri, 29 Jul 2005 21:22:14 +0000 (21:22 +0000)]
    - fixed:
        <rdar://problem/3461547> can't use document.writeln() on windows opened via window.open("about:blank") in same function
        <rdar://problem/3725977> A_WINDOW.document.write() content overwritten when first parameter to window.open is provided
        <rdar://problem/4101498> SAP: window.write in same call chain as window.open fails to write if URL parameter is provided
        <rdar://problem/4179028> document.write in same function as window.open fails to write new content (4056)
        http://bugzilla.opendarwin.org/show_bug.cgi?id=4056 document.write in same function as window.open fails to write new content

        Reviewed by darin.

        Test cases added:
        * manual-tests/resources/write-after-open-popup.html: Added.

        * khtml/khtml_part.cpp:
        (KHTMLPart::didExplicitOpen): now cancels any pending redirection

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoWebCore:
sullivan [Fri, 29 Jul 2005 21:16:56 +0000 (21:16 +0000)]
WebCore:

        Reviewed by Dave Hyatt.

        Test cases added: none, this only affects Safari forms autofill

        - WebCore part of <rdar://problem/4187404> Redo form SPI so that it doesn't rely on NSViews

        * khtml/html/html_formimpl.cpp:
        added a FIXME about a bug I ran into while doing this autofill stuff

        * kwq/DOMHTML.mm:
        (viewForElement):
        Moved this function here (was in WebCoreBridge), and simplified it a little. This will go
        away when we have non-NSView ways of implementing all the methods below.
        (-[DOMHTMLInputElement _displayedValue]):
        moved here from Safari
        (-[DOMHTMLInputElement _setDisplayedValue:]):
        ditto
        (-[DOMHTMLInputElement _rectOnScreen]):
        ditto
        (-[DOMHTMLInputElement _replaceCharactersInRange:withString:selectingFromIndex:]):
        ditto
        (-[DOMHTMLInputElement _selectedRange]):
        ditto
        (-[DOMHTMLInputElement _setBackgroundColor:]):
        ditto
        (-[DOMHTMLSelectElement _activateItemAtIndex:]):
        ditto
        (-[DOMHTMLSelectElement _optionLabels]):
        ditto

        * kwq/DOMPrivate.h:
        moved DOMHTMLInputElement and DOMHTMLSelectElement categories here from Safari

        * kwq/WebCoreBridge.h:
        * kwq/WebCoreBridge.mm:
        removed viewForElement:, which had been added as a temporary measure while I did this conversion.

WebKit:

        Reviewed by Dave Hyatt.

        - WebKit part of <rdar://problem/4187404> Redo form SPI so that it doesn't rely on NSViews

        Much of 4187404 was addressed in earlier checkins. This checkin completes the task.

        * WebView.subproj/WebHTMLRepresentation.h:
        * WebView.subproj/WebHTMLRepresentation.m:
        removed viewForElement:, which was the only remaining NSView-related SPI that Safari autofill was
        still using. I added viewForElement a week ago as a transitional measure, so removing it won't
        affect any other clients.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Chris Blumenberg.
sullivan [Fri, 29 Jul 2005 21:01:37 +0000 (21:01 +0000)]
    Reviewed by Chris Blumenberg.

        * WebView.subproj/WebFrameView.m:
        (-[WebFrameView _firstResponderIsFormControl]):
        renamed from _firstResponderIsControl for clarity. Explicitly rejects WebHTMLView, since
        it's now a control.
        (-[WebFrameView keyDown:]):
        updated for renamed method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoBug #: 4155
eseidel [Fri, 29 Jul 2005 20:22:51 +0000 (20:22 +0000)]
Bug #: 4155
Submitted by: eseidel
Reviewed by: sullivan
        * WebCore+SVG/DrawCanvasItem.h: Added.
        * WebCore+SVG/DrawCanvasItem.mm: Added.
        * WebCore+SVG/DrawCanvasItemPrivate.h: Added.
        * WebCore+SVG/DrawDocument.h: Added.
        * WebCore+SVG/DrawDocument.mm: Added.
        * WebCore+SVG/DrawDocumentPrivate.h: Added.
        * WebCore+SVG/DrawView.h: Added.
        * WebCore+SVG/DrawView.mm: Added.
        * WebCore+SVG/DrawViewPrivate.h: Added.
        * WebCore+SVG/NSSVGImageRep.h: Added.
        * WebCore+SVG/NSSVGImageRep.m: Added.
        Temporary SPI to make it possible to write Obj-C test applications.
        http://bugzilla.opendarwin.org/show_bug.cgi?id=4155

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by harrison
justing [Fri, 29 Jul 2005 19:44:45 +0000 (19:44 +0000)]
    Reviewed by harrison

        Backing out my recent change as it causes a layout test failure in Deployment mode

        * khtml/editing/delete_selection_command.cpp:
        (khtml::DeleteSelectionCommand::saveTypingStyleState):
        (khtml::DeleteSelectionCommand::calculateTypingStyleAfterDelete):
        (khtml::DeleteSelectionCommand::clearTransientState):
        * khtml/editing/delete_selection_command.h:
        * layout-tests/editing/deleting/delete-4038408-fix-expected.txt: Removed.
        * layout-tests/editing/deleting/delete-4038408-fix.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoBug #: 4157
eseidel [Fri, 29 Jul 2005 19:20:23 +0000 (19:20 +0000)]
Bug #: 4157
Submitted by: eseidel
Reviewed by: sullivan
        * DrawTest/AppDelegate.h: Added.
        * DrawTest/AppDelegate.m: Added.
        * DrawTest/DrawTest.xcodeproj/project.pbxproj: Added.
        * DrawTest/DrawTestDocument.h: Added.
        * DrawTest/DrawTestDocument.m: Added.
        * DrawTest/DrawTestInspectorController.h: Added.
        * DrawTest/DrawTestInspectorController.m: Added.
        * DrawTest/DrawTestToolbarController.h: Added.
        * DrawTest/DrawTestToolbarController.m: Added.
        * DrawTest/DrawTestView.h: Added.
        * DrawTest/DrawTestView.m: Added.
        * DrawTest/DrawTest_Prefix.pch: Added.
        * DrawTest/English.lproj/DrawTestDocument.nib/classes.nib: Added.
        * DrawTest/English.lproj/DrawTestDocument.nib/info.nib: Added.
        * DrawTest/English.lproj/DrawTestDocument.nib/keyedobjects.nib: Added.
        * DrawTest/English.lproj/InfoPlist.strings: Added.
        * DrawTest/English.lproj/Inspector.nib/classes.nib: Added.
        * DrawTest/English.lproj/Inspector.nib/info.nib: Added.
        * DrawTest/English.lproj/Inspector.nib/keyedobjects.nib: Added.
        * DrawTest/English.lproj/MainMenu.nib/classes.nib: Added.
        * DrawTest/English.lproj/MainMenu.nib/info.nib: Added.
        * DrawTest/English.lproj/MainMenu.nib/keyedobjects.nib: Added.
        * DrawTest/English.lproj/TestViewer.nib/classes.nib: Added.
        * DrawTest/English.lproj/TestViewer.nib/info.nib: Added.
        * DrawTest/English.lproj/TestViewer.nib/keyedobjects.nib: Added.
        * DrawTest/Info.plist: Added.
        * DrawTest/SVGTest.h: Added.
        * DrawTest/SVGTest.m: Added.
        * DrawTest/ScalingImageView.h: Added.
        * DrawTest/ScalingImageView.m: Added.
        * DrawTest/TestController.h: Added.
        * DrawTest/TestController.m: Added.
        * DrawTest/TestViewerSplitView.h: Added.
        * DrawTest/TestViewerSplitView.m: Added.
        * DrawTest/main.m: Added.
        Adding simple cocoa app for testing SVG rendering, interaction.
        http://bugzilla.opendarwin.org/show_bug.cgi?id=4157

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoBug #: 3936
eseidel [Fri, 29 Jul 2005 06:21:12 +0000 (06:21 +0000)]
Bug #: 3936
Submitted by: Ben La Monica
Reviewed by: darin, eseidel
        * kdom/css/impl/kdomparsercss.y: commented out %destructor %verbose
        * kdom/xpath/impl/parser/xpath.ypp: added missing definitions
        Fixes kdom to build with bison 1.28
        http://bugzilla.opendarwin.org/show_bug.cgi?id=3936

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoBug #: 4154
eseidel [Fri, 29 Jul 2005 06:11:14 +0000 (06:11 +0000)]
Bug #: 4154
Submitted by: eseidel
Reviewed by: mjs
        * WebCore.xcodeproj/project.pbxproj: Added SVG files back.
        * kdom/css/CSSCharsetRule.cpp:
        * kdom/css/CSSFontFaceRule.cpp:
        * kdom/css/CSSImportRule.cpp:
        * kdom/css/CSSMediaRule.cpp:
        * kdom/css/CSSPageRule.cpp:
        * kdom/css/CSSPrimitiveValue.cpp:
        * kdom/css/CSSRule.cpp:
        * kdom/css/CSSRuleList.cpp:
        * kdom/css/CSSStyleDeclaration.cpp:
        * kdom/css/CSSStyleRule.cpp:
        * kdom/css/CSSStyleSheet.cpp:
        * kdom/css/CSSValue.cpp:
        * kdom/css/CSSValueList.cpp:
        * kdom/css/Counter.cpp:
        * kdom/css/DocumentStyle.cpp:
        * kdom/css/MediaList.cpp:
        * kdom/css/RGBColor.cpp:
        * kdom/css/Rect.cpp:
        * kdom/css/StyleSheet.cpp:
        * kdom/css/StyleSheetList.cpp:
        * kdom/ecma/DOMLookup.h: Hacked around mjs's latest JSC change.
        Fixed #include statements to build under Xcode 2.1.
        http://bugzilla.opendarwin.org/show_bug.cgi?id=4154

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoBug #: 4156
eseidel [Fri, 29 Jul 2005 05:26:07 +0000 (05:26 +0000)]
Bug #: 4156
Submitted by: eseidel
Reviewed by: ggaren
        * svg2png/svg2png.m: Added.
        * svg2png/svg2png.xcodeproj/project.pbxproj: Added.
        * svg2png/svg2png_Prefix.pch: Added.
        Added a simple test tool which dumps a PNG from an SVG using
        WebCore+SVG's SVG rendering support.
        http://bugzilla.opendarwin.org/show_bug.cgi?id=4156

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoManual message.
hyatt [Fri, 29 Jul 2005 02:45:10 +0000 (02:45 +0000)]
Manual message.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoManual message, having commit issues.
hyatt [Fri, 29 Jul 2005 02:42:31 +0000 (02:42 +0000)]
Manual message, having commit issues.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoTest?
hyatt [Fri, 29 Jul 2005 02:40:41 +0000 (02:40 +0000)]
Test?

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9939 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Implement support for the :checked, :enabled and :disabled pseudo-classes.
hyatt [Thu, 28 Jul 2005 23:27:14 +0000 (23:27 +0000)]
Implement support for the :checked, :enabled and :disabled pseudo-classes.

        Reviewed by john

        * khtml/css/css_base.cpp:
        (CSSSelector::extractPseudoType):
        * khtml/css/css_base.h:
        (DOM::CSSSelector::):
        * khtml/css/cssstyleselector.cpp:
        (khtml::CSSStyleSelector::checkOneSelector):
        * khtml/html/html_formimpl.h:
        (DOM::HTMLGenericFormElementImpl::isControl):
        (DOM::HTMLGenericFormElementImpl::isEnabled):
        (DOM::HTMLInputElementImpl::isChecked):
        * khtml/rendering/render_theme.cpp:
        (khtml::RenderTheme::isChecked):
        (khtml::RenderTheme::isEnabled):
        * khtml/xml/dom_nodeimpl.h:
        (DOM::NodeImpl::isControl):
        (DOM::NodeImpl::isEnabled):
        (DOM::NodeImpl::isChecked):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9938 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago This is a fix for <rdar://problem/4190684>. Hyatt and I
bdakin [Thu, 28 Jul 2005 22:52:50 +0000 (22:52 +0000)]
This is a fix for <rdar://problem/4190684>. Hyatt and I
(okay, mostly Hyatt) wrote this for Cayenne so that they
can change the value of a style of a rule and have everything
update dynamically without causing a crash.

Reviewed by Hyatt

        Test cases added: (NONE)

        * khtml/css/css_valueimpl.cpp:
        (DOM::CSSMutableStyleDeclarationImpl::setChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Moved non-AppKit related code from RenderThemeMac to RenderTheme so potentially...
cblu [Thu, 28 Jul 2005 21:28:00 +0000 (21:28 +0000)]
Moved non-AppKit related code from RenderThemeMac to RenderTheme so potentially other RenderTheme subclasses can inherit more behavior.

        Reviewed by hyatt.

        * khtml/rendering/render_theme.cpp:
        (khtml::RenderTheme::baselinePosition):
        (khtml::RenderTheme::isControlContainer):
        (khtml::RenderTheme::sizeForFont):
        (khtml::RenderTheme::setSizeFromFont):
        (khtml::RenderTheme::setCheckboxSize):
        (khtml::RenderTheme::adjustCheckboxStyle):
        * khtml/rendering/render_theme.h:
        * khtml/rendering/render_theme_mac.h:
        * khtml/rendering/render_theme_mac.mm:
        (khtml::RenderThemeMac::sizeForFont):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9936 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Make sure :focus is not matched when the window is not key.
hyatt [Thu, 28 Jul 2005 20:47:29 +0000 (20:47 +0000)]
Make sure :focus is not matched when the window is not key.
This involved adding a check to the style selector and also
removing the hack from the painter that turned off outline:auto
drawing when the window wasn't key.

Added support for control tinting when the window resigns/becomes
key.

        Reviewed by john

        * khtml/css/cssstyleselector.cpp:
        (khtml::CSSStyleSelector::checkOneSelector):
        * khtml/khtml_part.h:
        (KHTMLPart::displaysWithFocusAttributes):
        * khtml/rendering/render_theme.cpp:
        (khtml::RenderTheme::paint):
        (khtml::RenderTheme::isChecked):
        (khtml::RenderTheme::isEnabled):
        (khtml::RenderTheme::isFocused):
        (khtml::RenderTheme::isPressed):
        * khtml/rendering/render_theme.h:
        (khtml::RenderTheme::controlSupportsTints):
        * khtml/rendering/render_theme_mac.h:
        * khtml/rendering/render_theme_mac.mm:
        (khtml::RenderThemeMac::controlSupportsTints):
        * kwq/KWQKHTMLPart.mm:
        (KWQKHTMLPart::setDisplaysWithFocusAttributes):
        * kwq/KWQPainter.h:
        (QPainter::updatingControlTints):
        (QPainter::setUpdatingControlTints):
        * kwq/KWQPainter.mm:
        (QPainter::QPainter):
        (QPainter::initFocusRing):
        (QPainter::addFocusRingRect):
        (QPainter::drawFocusRing):
        * kwq/WebCoreBridge.mm:
        (-[WebCoreBridge drawRect:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9935 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Beth Dakin.
sullivan [Thu, 28 Jul 2005 20:30:37 +0000 (20:30 +0000)]
    Reviewed by Beth Dakin.

        - removed method -[WebHTMLRepresentation elementForView:], which was SPI used only for
        Safari autofill. Tip of tree Safari no longer includes any calls to this method. Also,
        Tiger Safari never gets around to actually calling it due to the other recent form-SPI-related
        changes, so removing this method doesn't break Tiger Safari running on tip of tree WebKit
        (though autofill continues to not work in that configuration).

        * WebView.subproj/WebHTMLRepresentation.h:
        * WebView.subproj/WebHTMLRepresentation.m:
        (-[WebHTMLRepresentation elementForView:]): removed

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9934 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by ken
justing [Thu, 28 Jul 2005 05:15:45 +0000 (05:15 +0000)]
    Reviewed by ken

        Fix for <rdar://problems/4038408&4154187&4125381&4125087>
            Mail: Editing at the bottom of a quoted block makes the text blue in certain cases

        Test cases added:
        * layout-tests/editing/deleting/delete-4038408-fix-expected.txt: Added.
        * layout-tests/editing/deleting/delete-4038408-fix.html: Added.

        * khtml/editing/delete_selection_command.cpp:
        (khtml::DeleteSelectionCommand::saveTypingStyleState):
        (khtml::DeleteSelectionCommand::calculateTypingStyleAfterDelete):
        (khtml::DeleteSelectionCommand::clearTransientState):
        * khtml/editing/delete_selection_command.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoJavaScriptCore:
ggaren [Wed, 27 Jul 2005 23:44:59 +0000 (23:44 +0000)]
JavaScriptCore:

        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4147
        Array.toString() and toLocaleString() improvements from KDE KJS
        (rolled in KDE changes)

        Test cases added:

        * layout-tests/fast/js/toString-overrides-expected.txt: Added.
        * layout-tests/fast/js/toString-overrides.html: Added.

        * kjs/array_object.cpp:
        (ArrayProtoFuncImp::call):

WebCore:

        - added test case for http://bugzilla.opendarwin.org/show_bug.cgi?id=4147
        Array.toString() and toLocaleString() improvements from KDE KJS

        Test cases added:

        * layout-tests/fast/js/toString-overrides-expected.txt: Added.
        * layout-tests/fast/js/toString-overrides.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Fix submitted by: Andrew Wellington <proton@wiretapped.net>
bdakin [Wed, 27 Jul 2005 23:41:41 +0000 (23:41 +0000)]
Fix submitted by: Andrew Wellington <proton@wiretapped.net>
        Reviewed by Beth Dakin.

This is a fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=3406 and
<rdar://problem/3204011>. It does not solve all of the problems with
text-transform: capitalize, but it does fix some of the more notable
problems regarding apostrophes (like on amazon.com), and does not cause
any regressions (i.e., some things about text-transform are still wrong and some
of those things are wrong in different ways than they were wrong before, but
the patch does not seem to cause anything that was right to be newly
wrong.

        Test cases added: another text-transform test, see below

        * khtml/xml/dom_stringimpl.cpp: Here is the fix.
        (DOM::DOMStringImpl::capitalize):
        * layout-tests/css1/text_properties/text-transCapitalize-expected.txt: Added. New test case.
        * layout-tests/css1/text_properties/text-transCapitalize.html: Added. New test case.
        * layout-tests/css1/text_properties/text_transform-expected.txt: New expected results...
here are some instances where things were wrong before but are
wrong in new ways now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Changes by Michael Kahl, reviewed by me.
mjs [Wed, 27 Jul 2005 23:10:48 +0000 (23:10 +0000)]
    Changes by Michael Kahl, reviewed by me.

- fixed <rdar://problem/4194278> Need better debugging support in JavaScriptCore

        * JavaScriptCore.xcodeproj/project.pbxproj:
        * kjs/debugger.cpp:
        (KJS::AttachedInterpreter::AttachedInterpreter):
        (KJS::AttachedInterpreter::~AttachedInterpreter):
        (Debugger::~Debugger):
        (Debugger::attach):
        (Debugger::detach):
        (Debugger::sourceParsed):
        * kjs/debugger.h:
        * kjs/function.cpp:
        (KJS::FunctionImp::call):
        (KJS::GlobalFuncImp::call):
        * kjs/function_object.cpp:
        (FunctionObjectImp::construct):
        * kjs/grammar.y:
        * kjs/internal.cpp:
        (Parser::parse):
        (InterpreterImp::evaluate):
        * kjs/internal.h:
        (KJS::InterpreterImp::setDebugger):
        * kjs/interpreter.cpp:
        * kjs/interpreter.h:
        (KJS::Interpreter::imp):
        * kjs/nodes.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Patch by Trey Matteson <trey@usa.net>
sullivan [Wed, 27 Jul 2005 22:35:53 +0000 (22:35 +0000)]
Patch by Trey Matteson <trey@usa.net>
        Reviewed by me.

        Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4169
          scaling PDF view up leaves later HTML view scaled too

        An additional step of separating scaling of HTML and PDF.  If we do a zoom and there
        are no docViews that track the common scaling factor, then don't change it.  Thus in
        the common PDF case where it is the only doc view, scaling the PDF does not affect
        HTML pages loaded in the same window.

        * WebView.subproj/WebView.m:
        (-[WebView canMakeTextSmaller]):  Pass 0 for new scaling factor, since we just querying.
        (-[WebView canMakeTextLarger]):  Ditto.
        (-[WebView makeTextSmaller:]):  Pass new scaling factor.
        (-[WebView makeTextLarger:]):  Ditto.
        (-[WebView canMakeTextStandardSize]):  Pass 0 for new scaling factor.
        (-[WebView makeTextStandardSize:]):  Pass new scaling factor.
        (-[WebView _performTextSizingSelector:withObject:onTrackingDocs:selForNonTrackingDocs:newScaleFactor:]):
          The meat of the change is that this Swiss Army Knife also takes a new scaling
          factor, which it will set as the common scaling factor if it finds any doc views that
          are able to be scaled which track the common scaling factor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Patch by Trey Matteson <trey@usa.net>
sullivan [Wed, 27 Jul 2005 21:36:42 +0000 (21:36 +0000)]
Patch by Trey Matteson <trey@usa.net>
        Reviewed by me.

        Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4015
          PDF views should remember viewing mode, scroll position across back/forward
          Note this doesn't work within frames because of a PDFKit bug - see 4164
        Fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=4091
          PDF views should keep a separate scaling factor from shared text scaling factor

        Basic idea #1 is that we now have a general mechanism for a WebDocView to save/restore some UI
        state to the WebHistoryItem.
        Basic idea #2 is that _WebDocumentTextSizing is expanded to allow for the case of a WebDocView
        keeping its own notion of a scaling factor.  WebPDFView's -_tracksCommonSizeFactor has justification.

        * History.subproj/WebHistoryItem.m:
        (-[WebHistoryItem setViewState:]):  New methods to hold PList of arbitrary WebView state
        (-[WebHistoryItem viewState]):
        * History.subproj/WebHistoryItemPrivate.h:
        * WebKit.xcodeproj/project.pbxproj:  Add Quartz to framework path so we can import PDFKit files
        * WebView.subproj/WebDocumentInternal.h:  New methods added to _WebDocumentTextSizing.
          Also the _ prefix is sufficient instead of _web_WebDocumentTextSizing.
          Added _WebDocumentViewState protocol.
        * WebView.subproj/WebFrame.m:
        (-[WebFrame _createItemTreeWithTargetFrame:clippedAtTarget:]):  Rename of save/restore methods.
        (-[WebFrame _detachFromParent]):  Ditto
        (-[WebFrame _transitionToCommitted:]):  Ditto
        (-[WebFrame _checkLoadCompleteForThisFrame]):  Ditto
        (-[WebFrame _loadItem:withLoadType:]):  Ditto
        (-[WebFrame _recursiveGoToItem:fromItem:withLoadType:]):  Ditto
        (-[WebFrame _saveViewStateToItem:]):  Call doc view to retrieve view state.
        (-[WebFrame _restoreViewState]):  Call doc view to set view state.
        (-[WebFrame _scrollToTop]):  Nuked dead code.
        (-[WebFrame _textSizeMultiplierChanged]):  This work now appears in WebView.
        (-[WebFrame _saveDocumentAndScrollState]):  Same rename, one code cleanup.
        (-[WebFrame _accumulateDocumentViews:]): Add our docview to the array, call kids.
        (-[WebFrame _documentViews]):  New helper to return all docviews.
        (-[WebFrame _didFirstLayout]):  Same name change.
        * WebView.subproj/WebFrameInternal.h:
        * WebView.subproj/WebFramePrivate.h:
        * WebView.subproj/WebHTMLView.m:  Removed redundant category decl.
        (-[WebHTMLView _makeTextSmaller:]):  Implement new protocol.
        (-[WebHTMLView _makeTextLarger:]):
        (-[WebHTMLView _makeTextStandardSize:]):
        (-[WebHTMLView _tracksCommonSizeFactor]):
        * WebView.subproj/WebPDFRepresentation.m:  Tweak #imports.
        * WebView.subproj/WebPDFView.h:
        * WebView.subproj/WebPDFView.m:
        (-[WebPDFView _menuItemsFromPDFKitForEvent:]):  No longer intercept context menu text sizing items.
        (-[WebPDFView setDataSource:]):  No longer track the WebView's scaling factor.
        (-[WebPDFView scrollPoint]):  Dig through PDFKit view tree to get real scroll position
        (-[WebPDFView setScrollPoint:]):  Ditto
        (-[WebPDFView viewState]):  Return bundle of viewing params
        (-[WebPDFView setViewState:]):  Restore bundle of viewing params
        (-[WebPDFView _makeTextSmaller:]):  Implement new text sizing protocol
        (-[WebPDFView _makeTextLarger:]):
        (-[WebPDFView _makeTextStandardSize:]):
        (-[WebPDFView _tracksCommonSizeFactor]):
        (-[WebPDFView _canMakeTextSmaller]):
        (-[WebPDFView _canMakeTextLarger]):
        (-[WebPDFView _canMakeTextStandardSize]):
        * WebView.subproj/WebTextView.m:
        (-[WebTextView _makeTextSmaller:]):  Implement new text sizing protocol
        (-[WebTextView _makeTextLarger:]):
        (-[WebTextView _makeTextStandardSize:]):
        (-[WebTextView _tracksCommonSizeFactor]):
        * WebView.subproj/WebView.m:
        (-[WebView setTextSizeMultiplier:]):  Calling docViews is now more complicates than just posting
           a notification to the frame.
        (-[WebView _performTextSizingSelector:withObject:onTrackingDocs:selForNonTrackingDocs:]):  Workhorse
           that sends the text sizing method to the right doc views.
        (-[WebView canMakeTextSmaller]):  Call workhorse.
        (-[WebView canMakeTextLarger]):  Ditto
        (-[WebView makeTextSmaller:]):  Ditto
        (-[WebView makeTextLarger:]):  Ditto
        (-[WebView canMakeTextStandardSize]):  Ditto
        (-[WebView makeTextStandardSize:]):  Ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoJavaScriptCore:
ggaren [Wed, 27 Jul 2005 19:54:18 +0000 (19:54 +0000)]
JavaScriptCore:

        - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=3381
        Date.prototype.setDate() incorrect for values >=128

        - Test cases added:

        * layout-tests/fast/js/date-big-setdate-expected.txt: Added.
        * layout-tests/fast/js/date-big-setdate.html: Added.

        Reviewed by darin.

        * kjs/date_object.cpp:
        (DateProtoFuncImp::call):

WebCore:

        Test cases added:

        * layout-tests/fast/js/date-big-setdate-expected.txt: Added.
        * layout-tests/fast/js/date-big-setdate.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Remove the "enforce a square size" rule for checkboxes. WinIE
hyatt [Wed, 27 Jul 2005 18:55:40 +0000 (18:55 +0000)]
Remove the "enforce a square size" rule for checkboxes. WinIE
doesn't do this, and I'm not sure where I came up with it.

Fix a bug in isFocusable that was causing disabled form
controls with no corresponding widget to still get focus!
(This bug affected my new checkbox but also <input type=image>
and the HTML4 button!)

        Reviewed by ggaren

        * khtml/html/html_formimpl.cpp:
        * khtml/rendering/render_theme_mac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoJavaScriptCore:
ggaren [Wed, 27 Jul 2005 18:22:18 +0000 (18:22 +0000)]
JavaScriptCore:

        -rolled in patch by Carsten Guenther <cguenther@gmail.com>
        for http://bugzilla.opendarwin.org/show_bug.cgi?id=3759
        Date object enhancements

        Test cases added:

        * layout-tests/fast/js/date-preserve-milliseconds-expected.txt: Added.
        * layout-tests/fast/js/date-preserve-milliseconds.html: Added.

        Reviewed by darin.

        * kjs/date_object.cpp:
        (timeFromArgs):
        (DateProtoFuncImp::call):
        (DateObjectImp::construct):
        (DateObjectFuncImp::call):
        (KJS::makeTime):
        * kjs/date_object.h:
        * tests/mozilla/expected.html:

WebCore:

        -added testcase for http://bugzilla.opendarwin.org/show_bug.cgi?id=3759
        Date object enhancements

        Reviewed by darin.

        Test cases added:

        * layout-tests/fast/js/date-preserve-milliseconds-expected.txt: Added.
        * layout-tests/fast/js/date-preserve-milliseconds.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Patch by Trey Matteson <trey@usa.net>
justing [Wed, 27 Jul 2005 02:01:03 +0000 (02:01 +0000)]
    Patch by Trey Matteson <trey@usa.net>

        Reviewed by John Sullivan.

        Fixed <http://bugzilla.opendarwin.org/show_bug.cgi?id=4072>
        Pressing back in browser misses out a page

        * WebView.subproj/WebFrame.m:
        (-[WebFrame _transitionToCommitted:]):  When reloading the same page or refreshing the
        page, update the URL in the b/f item with the URL that we wind up at.  Due to cookies,
        it might be different than the result we just got when we loaded the same page.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Patch by Trey Matteson <trey@usa.net>
justing [Wed, 27 Jul 2005 01:53:16 +0000 (01:53 +0000)]
    Patch by Trey Matteson <trey@usa.net>

        Reviewed by hyatt.

        Fixed <rdar://problem/4083496> some elements draw selection when printing
        Also listed as <http://bugzilla.opendarwin.org/show_bug.cgi?id=3992>

        Simply added tests to prevent selection drawing when printing.

        * khtml/rendering/render_block.cpp:
        (khtml::RenderBlock::paintObject):
        * khtml/rendering/render_canvasimage.cpp:
        (RenderCanvasImage::paint):
        * khtml/rendering/render_image.cpp:
        (RenderImage::paint):
        * khtml/rendering/render_replaced.cpp:
        (RenderWidget::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by darin
justing [Wed, 27 Jul 2005 01:34:28 +0000 (01:34 +0000)]
    Reviewed by darin

        Added forward declarations to fix new gcc4 errors

        * khtml/ecma/kjs_window.h:
        * khtml/xml/dom_elementimpl.h:
        * kwq/KWQMapImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Added a forward declaration to fix gcc4 build error
justing [Wed, 27 Jul 2005 01:28:32 +0000 (01:28 +0000)]
    Added a forward declaration to fix gcc4 build error

        * kjs/function.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoHave to commit with my own checkin message, since commit-log-editor dies on this...
hyatt [Wed, 27 Jul 2005 01:12:29 +0000 (01:12 +0000)]
Have to commit with my own checkin message, since commit-log-editor dies on this patch for some odd reason.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoBug #: 4133
eseidel [Tue, 26 Jul 2005 23:12:11 +0000 (23:12 +0000)]
Bug #: 4133
Submitted by: eseidel
Reviewed by: darin
        * WebCore.xcodeproj/project.pbxproj: Removed unused C++ DOM
        * khtml/dom/css_rule.cpp: Removed.
        * khtml/dom/css_stylesheet.cpp: Removed.
        * khtml/dom/css_value.cpp: Removed.
        * khtml/dom/dom2_range.cpp: Removed.
        * khtml/dom/dom2_views.cpp: Removed.
        * khtml/dom/dom2_views.h: Removed.
        * khtml/dom/dom_core.h: Removed.
        * khtml/dom/dom_doc.cpp: Removed.
        * khtml/dom/dom_doc.h: Removed.
        * khtml/dom/dom_element.cpp: Removed.
        * khtml/dom/dom_element.h: Removed.
        * khtml/dom/dom_html.h: Removed.
        * khtml/dom/dom_node.cpp: Removed.
        * khtml/dom/dom_text.cpp: Removed.
        * khtml/dom/dom_text.h: Removed.
        * khtml/dom/dom_xml.cpp: Removed.
        * khtml/dom/dom_xml.h: Removed.
        * khtml/dom/html_base.cpp: Removed.
        * khtml/dom/html_base.h: Removed.
        * khtml/dom/html_block.cpp: Removed.
        * khtml/dom/html_block.h: Removed.
        * khtml/dom/html_document.cpp: Removed.
        * khtml/dom/html_document.h: Removed.
        * khtml/dom/html_element.cpp: Removed.
        * khtml/dom/html_element.h: Removed.
        * khtml/dom/html_form.cpp: Removed.
        * khtml/dom/html_form.h: Removed.
        * khtml/dom/html_head.cpp: Removed.
        * khtml/dom/html_head.h: Removed.
        * khtml/dom/html_image.cpp: Removed.
        * khtml/dom/html_image.h: Removed.
        * khtml/dom/html_inline.cpp: Removed.
        * khtml/dom/html_inline.h: Removed.
        * khtml/dom/html_list.cpp: Removed.
        * khtml/dom/html_list.h: Removed.
        * khtml/dom/html_misc.cpp: Removed.
        * khtml/dom/html_misc.h: Removed.
        * khtml/dom/html_object.cpp: Removed.
        * khtml/dom/html_object.h: Removed.
        * khtml/dom/html_table.cpp: Removed.
        * khtml/dom/html_table.h: Removed.
        This removes unused C++ DOM files from both the project and
        the repository.  There are a few left (css_, dom_) which will
        need to be cleaned over time.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Make WebHTMLView inherit from NSControl instead of NSView.
hyatt [Tue, 26 Jul 2005 20:29:06 +0000 (20:29 +0000)]
Make WebHTMLView inherit from NSControl instead of NSView.
This change is necessary because the theme renderer for
WebCore that draws controls with the Aqua appearance does so
using NSCells.  NSCells must be hosted within a control view
in order to paint properly.

The method updateCell must be overridden because it wants to
repaint the whole control when the windows resigns/becomes
key, and this would result in behavior that we don't want
(the repainting of the whole view).  We already have hooks
in WebHTMLView for the window resigning/becoming key so
we will do our proper control updating there instead (in a
future patch).

        Reviewed by john

        * WebView.subproj/WebHTMLView.h:
        * WebView.subproj/WebHTMLView.m:
        (-[WebHTMLView updateCell:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoWebCore:
sullivan [Tue, 26 Jul 2005 17:37:25 +0000 (17:37 +0000)]
WebCore:

        Reviewed by Chris Blumenberg.

        Test cases added: none, only affects Safari autofill

        - more work to wean form-related SPI from NSView. All that's left (but this is a big "all")
        is viewForElement: and elementForView:

        * kwq/WebCoreBridge.h:
        Rename control:textView:doCommandBySelector: to textField:doCommandBySelector:, and changed
        to take DOMHTMLInputElement* rather than NSControl* and NSTextView*

        * kwq/KWQTextField.mm:
        (-[KWQTextFieldController control:textView:doCommandBySelector:]):
        call renamed bridge method, passing DOMElement* instead of NSView*

WebKit:

        Reviewed by Chris Blumenberg.

        - more work to wean form-related SPI from NSView. All that's left (but this is a big "all")
        is viewForElement: and elementForView:

        * WebCoreSupport.subproj/WebBridge.m:
        (-[WebBridge textField:doCommandBySelector:]):
        changed signature to pass along DOMElement* rather than NSView*

        * WebView.subproj/WebFormDelegate.h:
        * WebView.subproj/WebFormDelegate.m:
        (-[WebFormDelegate textField:doCommandBySelector:inFrame:]):
        ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoFor every makefile that we set Xcode's default for PBXProductDirectory, also set...
cblu [Tue, 26 Jul 2005 17:28:58 +0000 (17:28 +0000)]
For every makefile that we set Xcode's default for PBXProductDirectory, also set PBXIntermediatesDirectory. This allows multiple CVS trees to live on one system without confusing each other.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoWebCore:
sullivan [Tue, 26 Jul 2005 16:34:17 +0000 (16:34 +0000)]
WebCore:

        Reviewed by Darin Adler.

        Test cases added: none, only affects Safari autofill

        - big hunk of weaning form-related SPI from NSView; autofill continues to
        work (but only on tip of tree Safari)

        * kwq/KWQTextArea.mm:
        (-[KWQTextArea textDidChange:]):
        call renamed bridge method, passing DOMElement* instead of NSView*

        * kwq/KWQTextField.mm:
        (-[KWQTextFieldController controlTextDidBeginEditing:]):
        call renamed bridge method, passing DOMElement* instead of NSView*
        (-[KWQTextFieldController controlTextDidEndEditing:]):
        ditto
        (-[KWQTextFieldController controlTextDidChange:]):
        ditto
        (-[KWQTextFieldController control:textShouldBeginEditing:]):
        don't call through to bridge form-delegate-related method; I deleted it because it was
        not being used
        (-[KWQTextFieldController control:textShouldEndEditing:]):
        ditto
        (-[KWQTextFieldController textView:shouldHandleEvent:]):
        call renamed bridge method, passing DOMElement* instead of NSView*

        * kwq/WebCoreBridge.h:
        Remove textShouldBeginEditing and textShouldEndEditing methods since they weren't being used.
        Rename other methods and made them take DOMElement* instead of NSView*

WebKit:

        Reviewed by Darin Adler.

        - big hunk of weaning form-related SPI from NSView; autofill continues to
        work (but only on tip of tree Safari)

        * WebCoreSupport.subproj/WebBridge.m:
        (-[WebBridge textFieldDidBeginEditing:]):
        changed name from controlTextXXX:, now takes a DOMHTMLInputElement*
        (-[WebBridge textFieldDidEndEditing:]):
        ditto
        (-[WebBridge textDidChangeInTextField:]):
        ditto
        (-[WebBridge textDidChangeInTextArea:]):
        changed name from textDidChange:, now takes a DOMHTMLTextAreaElement*
        (-[WebBridge control:textShouldBeginEditing:]):
        removed this method as it wasn't being used by autofill, and did nothing in WebKit
        (-[WebBridge control:textShouldEndEditing:]):
        ditto
        (-[WebBridge textField:shouldHandleEvent:]):
        changed name from control:textView:shouldHandleEvent:, now takes a DOMHTMLInputElement*.
        The textView parameter wasn't being used, so I eliminated it.

        * WebView.subproj/WebFormDelegate.h:
        * WebView.subproj/WebFormDelegate.m:
        (-[WebFormDelegate textFieldDidBeginEditing:inFrame:]):
        (-[WebFormDelegate textFieldDidEndEditing:inFrame:]):
        (-[WebFormDelegate control:textShouldBeginEditing:inFrame:]):
        (-[WebFormDelegate control:textShouldEndEditing:inFrame:]):
        (-[WebFormDelegate textDidChangeInTextField:inFrame:]):
        (-[WebFormDelegate textDidChangeInTextArea:inFrame:]):
        (-[WebFormDelegate textField:shouldHandleEvent:inFrame:]):
        These all changed in the same way as the WebBridge methods

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoWebCore:
mjs [Tue, 26 Jul 2005 08:54:15 +0000 (08:54 +0000)]
WebCore:

        - imported much of the w3c DOM test suite:

DOM Level 1 Core (html version)
DOM Level 2 Core (html version)
DOM Level 2 Events (html version)
DOM Level 2 HTML (html version)

For now I left out the XHTML versions.

        Test cases added: (NONE)

        * layout-tests/dom/html/level1/core/*
* layout-tests/dom/html/level2/core/*
        * layout-tests/dom/html/level2/events/*
        * layout-tests/dom/html/level2/html/*

WebKitTools:

        Reviewed by Darin.

- new script to review the DOM layout test results and see where we stand
on actual success and failure

        * Scripts/check-dom-results: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoWebCore:
mjs [Tue, 26 Jul 2005 08:36:06 +0000 (08:36 +0000)]
WebCore:

        - imported much of the w3c DOM test suite:

DOM Level 1 Core (html version)
DOM Level 2 Core (html version)
DOM Level 2 Events (html version)
DOM Level 2 HTML (html version)

For now I left out the XHTML versions.

        Test cases added: (NONE)

        * layout-tests/dom/html/level1/core/*
* layout-tests/dom/html/level2/core/*
        * layout-tests/dom/html/level2/events/*
        * layout-tests/dom/html/level2/html/*

WebKitTools:

        Reviewed by Darin.

- new script to review the DOM layout test results and see where we stand
on actual success and failure

        * Scripts/check-dom-results: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago * Scripts/webkitdirs.pm: Check in missing line of code.
darin [Tue, 26 Jul 2005 04:39:50 +0000 (04:39 +0000)]
    * Scripts/webkitdirs.pm: Check in missing line of code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago - fixed problem that was causing JavaScriptCore test to fail
darin [Tue, 26 Jul 2005 03:58:00 +0000 (03:58 +0000)]
    - fixed problem that was causing JavaScriptCore test to fail
          (except for people who had set DYLD_FRAMEWORK_PATH)

        * Scripts/run-javascriptcore-tests: Add code to set DYLD_FRAMEWORK_PATH.
        Add code to parse configuration parameter so you can pass --deployment if you like.
        * Scripts/run-webkit-tests: Add code to parse configuration parameter.

        * Scripts/update-javascriptcore-test-results: Add license header.

        * Scripts/webkitdirs.pm: Change code that reads configuration option to remove it
        from @ARGV. This lets us use this option in commands that take other options and
        pass them along to a subsequent tool.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago - fixed mistake in my last checkin -- the expected results included
ggaren [Tue, 26 Jul 2005 00:14:13 +0000 (00:14 +0000)]
    - fixed mistake in my last checkin -- the expected results included
        results from a patch that hasn't landed yet.

        * tests/mozilla/expected.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Darin.
vicki [Tue, 26 Jul 2005 00:11:33 +0000 (00:11 +0000)]
    Reviewed by Darin.

- fixed <rdar://problem/3470523> Safari's user agent should be changed to say Intel rather
than PPC on Intel machines

        * WebView.subproj/WebView.m: add conditional #defines for "PPC" and "Intel"
        (-[WebView userAgentForURL:]): use this variable when constructing the user agent string

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago - fix mistake in last change that leads to assertion failure in the Developme...
mjs [Mon, 25 Jul 2005 23:35:36 +0000 (23:35 +0000)]
    - fix mistake in last change that leads to assertion failure in the Development build

        * kjs/lookup.h:
        (KJS::lookupGetOwnValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Beth Dakin.
vicki [Mon, 25 Jul 2005 23:13:35 +0000 (23:13 +0000)]
    Reviewed by Beth Dakin.

- fixed <rdar://problem/4011544> selecting an item from a <select> menu with
the mouse doesn't place the focus on the menu

Test cases added:
        * manual-tests/focus-select-when-clicked.html: Added.

        * kwq/KWQComboBox.mm:
        (-[KWQPopUpButton needsPanelToBecomeKey]): override this NSView method to return YES

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoJavaScriptCore:
mjs [Mon, 25 Jul 2005 22:17:20 +0000 (22:17 +0000)]
JavaScriptCore:

        Reviewed by Darin.

- http://bugzilla.opendarwin.org/show_bug.cgi?id=4124
(change JavaScript property access to avoid double lookup)

- 10% speedup on JavaScript iBench
- 5% speedup on 24fun BenchJS benchmark

Changed all get methods to getOwnProperty - they are no longer
responsible for prototype lookup, and determine if the property
was found as a side efect.

get() is now a nonvirtual ObjectImp method which calls the virtual
getOwnProperty and walks the prototype chain. A few selected
methods were inlined.

Changed ResolveNode::evaluate plus some other places to use
getProperty which does get() and hasProperty() in one lookup.

Also miscellaneous code cleanup.

* bindings/objc/objc_runtime.h:
        * bindings/objc/objc_runtime.mm:
        (ObjcFallbackObjectImp::ObjcFallbackObjectImp):
        (ObjcFallbackObjectImp::getOwnProperty):
        * bindings/runtime_array.cpp:
        (RuntimeArrayImp::RuntimeArrayImp):
        (RuntimeArrayImp::getOwnProperty):
        * bindings/runtime_array.h:
        * bindings/runtime_method.cpp:
        (RuntimeMethodImp::getOwnProperty):
        * bindings/runtime_method.h:
        * bindings/runtime_object.cpp:
        (RuntimeObjectImp::getOwnProperty):
        * bindings/runtime_object.h:
        * kjs/array_instance.h:
        * kjs/array_object.cpp:
        (ArrayInstanceImp::getOwnProperty):
        (ArrayPrototypeImp::getOwnProperty):
        (ArrayProtoFuncImp::call):
        * kjs/array_object.h:
        * kjs/date_object.cpp:
        (DatePrototypeImp::getOwnProperty):
        * kjs/date_object.h:
        * kjs/function.cpp:
        (KJS::FunctionImp::getOwnProperty):
        (KJS::ArgumentsImp::getOwnProperty):
        (KJS::ActivationImp::getOwnProperty):
        * kjs/function.h:
        * kjs/lookup.h:
        (KJS::lookupGetOwnProperty):
        (KJS::lookupGetOwnFunction):
        (KJS::lookupGetOwnValue):
        * kjs/math_object.cpp:
        (MathObjectImp::getOwnProperty):
        (MathObjectImp::getValueProperty):
        * kjs/math_object.h:
        * kjs/nodes.cpp:
        (ResolveNode::evaluate):
        * kjs/number_object.cpp:
        (NumberObjectImp::getOwnProperty):
        * kjs/number_object.h:
        * kjs/object.cpp:
        (KJS::ObjectImp::get):
        (KJS::ObjectImp::getOwnProperty):
        (KJS::ObjectImp::getProperty):
        * kjs/object.h:
        (KJS::ObjectImp::getProperty):
        (KJS::ObjectImp::getOwnProperty):
        * kjs/object_object.cpp:
        (ObjectProtoFuncImp::call):
        * kjs/regexp_object.cpp:
        (RegExpObjectImp::getOwnProperty):
        * kjs/regexp_object.h:
        * kjs/string_object.cpp:
        (StringInstanceImp::getOwnProperty):
        (StringPrototypeImp::getOwnProperty):
        * kjs/string_object.h:

WebCore:

        Reviewed by Darin.

- http://bugzilla.opendarwin.org/show_bug.cgi?id=4124
(change JavaScript property access to avoid double lookup)

- 10% speedup on JavaScript iBench
- 5% speedup on 24fun BenchJS benchmark

Changed all get methods to getOwnProperty - they are no longer responsible for
prototype lookup, and determine if the property was found as a side efect.

Also miscellaneous code cleanup.

        * khtml/ecma/kjs_css.cpp:
        (KJS::DOMCSSStyleDeclaration::getOwnProperty):
        (KJS::DOMStyleSheet::getOwnProperty):
        (KJS::DOMStyleSheetList::getOwnProperty):
        (KJS::DOMMediaList::getOwnProperty):
        (KJS::DOMCSSStyleSheet::getOwnProperty):
        (KJS::DOMCSSRuleList::getOwnProperty):
        (KJS::DOMCSSRule::getOwnProperty):
        (KJS::DOMCSSRule::getValueProperty):
        (KJS::CSSRuleConstructor::getOwnProperty):
        (KJS::DOMCSSValue::getOwnProperty):
        (KJS::CSSValueConstructor::getOwnProperty):
        (KJS::DOMCSSPrimitiveValue::getOwnProperty):
        (KJS::CSSPrimitiveValueConstructor::getOwnProperty):
        (KJS::DOMCSSValueList::getOwnProperty):
        (KJS::DOMRGBColor::getOwnProperty):
        (KJS::DOMRect::getOwnProperty):
        (KJS::DOMCounter::getOwnProperty):
        * khtml/ecma/kjs_css.h:
        * khtml/ecma/kjs_dom.cpp:
        (KJS::DOMNode::getOwnProperty):
        (KJS::DOMNodeList::getOwnProperty):
        (KJS::DOMAttr::getOwnProperty):
        (KJS::DOMDocument::getOwnProperty):
        (KJS::DOMElement::getOwnProperty):
        (KJS::DOMDocumentType::getOwnProperty):
        (KJS::DOMNamedNodeMap::getOwnProperty):
        (KJS::DOMProcessingInstruction::getOwnProperty):
        (KJS::DOMNotation::getOwnProperty):
        (KJS::DOMEntity::getOwnProperty):
        (KJS::NodeConstructor::getOwnProperty):
        (KJS::DOMExceptionConstructor::getOwnProperty):
        (KJS::DOMNamedNodesCollection::getOwnProperty):
        (KJS::DOMCharacterData::getOwnProperty):
        * khtml/ecma/kjs_dom.h:
        * khtml/ecma/kjs_events.cpp:
        (KJS::EventConstructor::getOwnProperty):
        (KJS::DOMEvent::getOwnProperty):
        (KJS::EventExceptionConstructor::getOwnProperty):
        (KJS::DOMUIEvent::getOwnProperty):
        (KJS::DOMMouseEvent::getOwnProperty):
        (KJS::DOMKeyboardEvent::getOwnProperty):
        (KJS::MutationEventConstructor::getOwnProperty):
        (KJS::DOMMutationEvent::getOwnProperty):
        (KJS::DOMWheelEvent::getOwnProperty):
        (KJS::Clipboard::getOwnProperty):
        * khtml/ecma/kjs_events.h:
        * khtml/ecma/kjs_html.cpp:
        (KJS::HTMLDocument::getOwnProperty):
        (KJS::KJS::HTMLElement::getOwnProperty):
        (KJS::KJS::HTMLCollection::getOwnProperty):
        (KJS::KJS::HTMLSelectCollection::getOwnProperty):
        (KJS::Image::getOwnProperty):
        (KJS::Context2D::getOwnProperty):
        (KJS::Gradient::getOwnProperty):
        (KJS::ImagePattern::getOwnProperty):
        * khtml/ecma/kjs_html.h:
        * khtml/ecma/kjs_navigator.cpp:
        (KJS::Plugin::Plugin):
        (KJS::Navigator::getOwnProperty):
        (KJS::Plugins::getOwnProperty):
        (KJS::MimeTypes::getOwnProperty):
        (KJS::Plugin::getOwnProperty):
        (KJS::MimeType::getOwnProperty):
        * khtml/ecma/kjs_navigator.h:
        * khtml/ecma/kjs_range.cpp:
        (KJS::DOMRange::getOwnProperty):
        (KJS::RangeConstructor::getOwnProperty):
        * khtml/ecma/kjs_range.h:
        * khtml/ecma/kjs_traversal.cpp:
        (KJS::DOMNodeIterator::getOwnProperty):
        (KJS::NodeFilterConstructor::getOwnProperty):
        (KJS::DOMTreeWalker::getOwnProperty):
        * khtml/ecma/kjs_traversal.h:
        * khtml/ecma/kjs_views.cpp:
        (KJS::DOMAbstractView::getOwnProperty):
        * khtml/ecma/kjs_views.h:
        * khtml/ecma/kjs_window.cpp:
        (KJS::Screen::getOwnProperty):
        (KJS::Window::~Window):
        (KJS::Window::getOwnProperty):
        (KJS::Window::put):
        (KJS::FrameArray::getOwnProperty):
        (KJS::Location::Location):
        (KJS::Location::getOwnProperty):
        (KJS::Location::put):
        (KJS::Selection::Selection):
        (KJS::Selection::getOwnProperty):
        (KJS::BarInfo::getOwnProperty):
        (KJS::History::getOwnProperty):
        * khtml/ecma/kjs_window.h:
        * khtml/ecma/xmlhttprequest.cpp:
        (KJS::XMLHttpRequest::getOwnProperty):
        * khtml/ecma/xmlhttprequest.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Geoff Garen.
darin [Mon, 25 Jul 2005 21:55:06 +0000 (21:55 +0000)]
    Reviewed by Geoff Garen.

        - Fixed run-safari and gdb-safari to use the Safari application in the build results
          directory, if any, falling back to the one in the Applications directory otherwise.
          Does no harm for open source contributors who don't build Safari, and helps out the
          Safari team, since we do build Safari.

        * Scripts/webkitdirs.pm: Added safariPath function that uses WEBKIT_SAFARI environment
        variable, and if that's not present, looks in either the build results directory or
        /Applications; factors code that was in both scripts before into a shared function.
        Also removed some Xcode 2.0 support which is no longer relevant since our projects are
        now in Xcode 2.1 format and incompatible with older versions of Xcode.

        * Scripts/gdb-safari: Use safariPath.
        * Scripts/run-safari: Use safariPath.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by hyatt
justing [Mon, 25 Jul 2005 21:50:27 +0000 (21:50 +0000)]
    Reviewed by hyatt

        Backing out a change that made the caret invisible in Mail in certain situations.

        * khtml/rendering/render_block.cpp:
        (khtml::RenderBlock::paintObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago - fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=3971
ggaren [Mon, 25 Jul 2005 20:38:32 +0000 (20:38 +0000)]
    - fixed bugzilla.opendarwin.org/show_bug.cgi?id=3971
        JS test suite depends on JS 1.2 behavior

        Reviewed by darin.

        * tests/mozilla/js1_2/Array/tostring_1.js: now tests only for JS 1.5 behavior
        * tests/mozilla/js1_2/Array/tostring_2.js: ditto
        * tests/mozilla/expected.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Added a manual test for a recent change to WebKit
justing [Mon, 25 Jul 2005 16:59:02 +0000 (16:59 +0000)]
    Added a manual test for a recent change to WebKit

        Test cases added:
        * manual-tests/deleteToEndOfLine.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by mjs
justing [Mon, 25 Jul 2005 00:35:32 +0000 (00:35 +0000)]
    Reviewed by mjs

        - Fixes <rdar://problem/4120535> deleteToEndOfLine: does not delete thew newline when at the end of a line
            Fix to match NSTextView.  Delete the next character if deleteToEndOfLine fails

        * WebView.subproj/WebHTMLView.m:
        (-[WebHTMLView deleteToEndOfLine:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Patch by Trey Matteson <trey@apple.com>
justing [Sun, 24 Jul 2005 22:58:23 +0000 (22:58 +0000)]
    Patch by Trey Matteson <trey@apple.com>

        Reviewed by john

        Fixes <http://bugzilla.opendarwin.org/show_bug.cgi?id=3953> back-forward items have wrong titles after sub-frame navigations

        This was caused by a mistaken data structure, where WebDataSource tried to keep a list of
        b/f items it was responsible for.  The problem arose in the case of frames, where a subframe
        was loaded with new content.  When this happens a fresh tree of b/f items is created,
        but the reference in the DataSource still pointed to the old item.

        Since the WebFrame does a lot of work to track the current b/f item, the easiest thing is to
        get rid of the DataSource's reference, and have it ask the WebFrame to set the title on the
        right b/f item.

        * WebView.subproj/WebDataSource.m:
        (-[WebDataSourcePrivate dealloc]):
        (-[WebDataSource _setTitle:]):
        * WebView.subproj/WebDataSourcePrivate.h:
        * WebView.subproj/WebFrame.m:
        (-[WebFrame _createItem:]):
        (-[WebFrame _transitionToCommitted:]):
        (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]):
        (-[WebFrame _setTitle:]):
        * WebView.subproj/WebFramePrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Patch by Anders Carlsson <andersca@mac.com>
justing [Sun, 24 Jul 2005 22:44:55 +0000 (22:44 +0000)]
    Patch by Anders Carlsson <andersca@mac.com>

        Reviewed by hyatt

        - <http://bugzilla.opendarwin.org/show_bug.cgi?id=3615> canvas transform matrix does not apply to patterns
        Fill and stroke patterns are created in the respective fill and stroke functions using the current CTM.

        * khtml/ecma/kjs_html.cpp:
        (KJS::KJS::Context2DFunction::call):
        (KJS::Context2D::updateFillImagePattern):
        (KJS::Context2D::updateStrokeImagePattern):
        (KJS::Context2D::putValueProperty):
        (KJS::Context2D::Context2D):
        (KJS::_rh):
        (KJS::ImagePattern::createPattern):
        * khtml/ecma/kjs_html.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by kevin.
justing [Sun, 24 Jul 2005 22:01:02 +0000 (22:01 +0000)]
    Reviewed by kevin.

        Fixes make clean problem introduced in xcode2.1 transition

        * Makefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by kevin
justing [Sun, 24 Jul 2005 21:58:10 +0000 (21:58 +0000)]
    Reviewed by kevin

        Fixed make clean problem

        * Makefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Patch by <opendarwin.org@mitzpettel.com>
justing [Sun, 24 Jul 2005 21:36:26 +0000 (21:36 +0000)]
    Patch by <opendarwin.org@mitzpettel.com>

        Reviewed by darin and hyatt

        Fixes <http://bugzilla.opendarwin.org/show_bug.cgi?id=3862>
        The fix for <http://bugzilla.opendarwin.org/show_bug.cgi?id=3545> enclosed each run of visually ordered
        hebrew with LRO and PDF control characters, but adjusted the run's to and from to include those characters,
        so that they would be rendered if the font includes a glyph for bidi control characters.

        Also adding a manual test

        * WebCoreSupport.subproj/WebTextRenderer.m:
        (reverseCharactersInRun):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Adding a manual test for <http://bugzilla.opendarwin.org/show_bug.cgi?id...
justing [Sun, 24 Jul 2005 21:35:34 +0000 (21:35 +0000)]
    Adding a manual test for <bugzilla.opendarwin.org/show_bug.cgi?id=3862>

        Test cases added:
        * manual-tests/bidi-visible-control-characters.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Adding a manual test for <http://bugzilla.opendarwin.org/show_bug.cgi?id...
justing [Sat, 23 Jul 2005 20:49:36 +0000 (20:49 +0000)]
    Adding a manual test for <bugzilla.opendarwin.org/show_bug.cgi?id=3862>, since
        our layout test font doesn't include glyphs for bidi control characters

        Test cases added:
        * manual-tests/bidi-visible-control-characters.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Patch by <opendarwin.org@mitzpettel.com>
justing [Sat, 23 Jul 2005 20:45:31 +0000 (20:45 +0000)]
    Patch by <opendarwin.org@mitzpettel.com>

        Reviewed by darin and hyatt

        Fixes <http://bugzilla.opendarwin.org/show_bug.cgi?id=3862>
        The fix for <http://bugzilla.opendarwin.org/show_bug.cgi?id=3545> enclosed each run of visually ordered
        hebrew with LRO and PDF control characters, but adjusted the run's to and from to include those characters,
        so that they would be rendered if the font includes a glyph for bidi control characters.

        Also adding a manual test (our default layout test font does not include bidi control characters)

        * WebCoreSupport.subproj/WebTextRenderer.m:
        (reverseCharactersInRun):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by darin.
ggaren [Sat, 23 Jul 2005 00:50:36 +0000 (00:50 +0000)]
    Reviewed by darin.

        * kjs/date_object.cpp: DatePrototypeImp now identifies itself as a
        child class of DateInstanceImp -- this enables calls to Date.ValueOf().

        fixes: ecma/Date/15.9.5.js (once we enable the date tests).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoJavaScriptCore:
ggaren [Sat, 23 Jul 2005 00:34:52 +0000 (00:34 +0000)]
JavaScriptCore:

        Reviewed by darin.

        * tests/mozilla/jsDriver.pl: now takes the path to testkjs as a command-line argument
        * tests/mozilla/run-mozilla-tests: Removed.

WebKitTools:

        Moved Tools/Scripts/run-mozilla-tests to WebKitTools/Scripts/run-javascriptcore-tests.
        run-javascriptcore-tests now passes its command-line arguments to jsDriver.pl

        Moved Tools/Scripts/update-mozilla-js-test-results to
        WebKitTools/Scripts/update-javascriptcore-test-results.

        Reviewed by darin.

        * Scripts/run-javascriptcore-tests: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Justin Garcia.
sullivan [Fri, 22 Jul 2005 21:52:11 +0000 (21:52 +0000)]
    Reviewed by Justin Garcia.

        Mail (running on tip of tree WebKit) was running into an assertion I recently added.
        The assertion is actually correct, catching an old bug in this code.

        * WebView.subproj/WebView.m:
        (-[WebView selectedFrame]):
        if the first responder is a WebFrameView, then we've found the WebFrameView we're
        looking for, and we shouldn't look at its superviews.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Put back in the <script src="foo"/> self-closing tag quirk in HTML. Unfortunately
hyatt [Fri, 22 Jul 2005 21:34:11 +0000 (21:34 +0000)]
Put back in the <script src="foo"/> self-closing tag quirk in HTML.  Unfortunately
Dashboard widgets are dependent on this quirk.

        Reviewed by mjs

        * khtml/html/htmltokenizer.cpp:
        (khtml::HTMLTokenizer::parseTag):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoWebCore:
sullivan [Fri, 22 Jul 2005 18:09:25 +0000 (18:09 +0000)]
WebCore:

        Reviewed by Chris Blumenberg.

        Test cases added: none, this only affects Safari autocomplete; it doesn't affect any
        web pages.

        - some changes in the direction of weaning all the form-related SPI from NSView

        * kwq/DOMExtensions.h:
        added -[DOMHTMLInputElement isTextField]
        * kwq/DOMHTML.mm:
        (-[DOMHTMLInputElement isTextField]):
        new method that returns YES if this element is one of the types that's represented
        by a text field (as opposed to a button, slider, etc.). I could have put this method
        in Safari, but it seems useful for other WebKit clients.

        * kwq/WebCoreBridge.h:
        * kwq/WebCoreBridge.mm:
        (-[WebCoreBridge viewForElement:]):
        added viewForElement: as a stopgap measure. This allowed me to convert controlsInForm:
        to return DOMElements rather than NSViews, while keeping autocomplete working in
        Safari tip of tree. When I finish the SPI conversion I'll delete this method. Note that
        from this point on, autocomplete will not work in Tiger Safari with tip of tree WebKit
        (it will always fail to find anything to autocomplete)
        (-[WebCoreBridge controlsInForm:]):
        now returns an array of DOMElement* rather than an array of NSView*

WebKit:

        Reviewed by Chris Blumenberg.

        - some changes in the direction of weaning all the form-related SPI from NSView

        * PublicHeaderChangesFromTiger.txt:
        noted that the WebCore change to add -[DOMHTMLInputElement isTextField] to
        DOMExtensions.h is a public header change.

        * WebView.subproj/WebHTMLRepresentation.h:
        * WebView.subproj/WebHTMLRepresentation.m:
        (-[WebHTMLRepresentation viewForElement:]):
        added viewForElement: as a stopgap measure. This allowed me to convert controlsInForm:
        to return DOMElements rather than NSViews, while keeping autocomplete working in
        Safari tip of tree. When I finish the SPI conversion I'll delete this method. Note that
        from this point on, autocomplete will not work in Tiger Safari with tip of tree WebKit
        (it will always fail to find anything to autocomplete)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Darin.
adele [Fri, 22 Jul 2005 01:57:01 +0000 (01:57 +0000)]
    Reviewed by Darin.

        Changing temporary #ifndef to #if

        * WebCoreSupport.subproj/WebImageData.m:
        (-[WebImageData _checkSolidColor:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Darin.
ggaren [Fri, 22 Jul 2005 01:23:02 +0000 (01:23 +0000)]
    Reviewed by Darin.

        * Scripts/build-dumprendertree: changed XCode 2.0 project file reference to 2.1

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Chris Blumenberg.
adele [Fri, 22 Jul 2005 00:02:23 +0000 (00:02 +0000)]
    Reviewed by Chris Blumenberg.

        - fixed <rdar://problem/4132797> don't register thin PPC WebKit plug-ins
        Merged fix for:
        <rdar://problem/4127100> [WebKit] 8B1016: After installing Acrobat Reader, can no longer see pdf's in Safari

        * Plugins.subproj/WebBasePluginPackage.h: Added isNativeLibraryData method.
        * Plugins.subproj/WebBasePluginPackage.m: (-[WebBasePluginPackage isNativeLibraryData:]): Added isNativeLibraryData method.
        * Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage initWithPath:]):
          calls isNativeLibraryData to determine whether or not to register the plug-in.
        * Plugins.subproj/WebPluginPackage.m: (-[WebPluginPackage initWithPath:]): ditto.
        * WebCoreSupport.subproj/WebImageData.m: (-[WebImageData _checkSolidColor:]): added comment for #ifdef.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoRemoving old XCode project files.
ggaren [Thu, 21 Jul 2005 22:48:22 +0000 (22:48 +0000)]
Removing old XCode project files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Removing old XCode project files.
ggaren [Thu, 21 Jul 2005 22:47:03 +0000 (22:47 +0000)]
    Removing old XCode project files.

        Reviewed by NOBODY (OOPS!).

        * DumpRenderTree/DumpRenderTree.xcode/.cvsignore: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by NOBODY (OOPS!).
ggaren [Thu, 21 Jul 2005 20:38:11 +0000 (20:38 +0000)]
    Reviewed by NOBODY (OOPS!).

        * DumpRenderTree/DumpRenderTree.xcode/project.pbxproj: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoWebCore:
ggaren [Thu, 21 Jul 2005 20:33:56 +0000 (20:33 +0000)]
WebCore:

        Reviewed by NOBODY (OOPS!).

        Test cases added: (NONE)

        * WebCore.pbproj/project.pbxproj: Removed.

WebKit:

        Reviewed by NOBODY (OOPS!).

        * WebKit.pbproj/project.pbxproj: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoJavaScriptCore:
ggaren [Thu, 21 Jul 2005 20:28:25 +0000 (20:28 +0000)]
JavaScriptCore:

        Reviewed by NOBODY (OOPS!).

        * JavaScriptCore.xcodeproj/.cvsignore: Added.

WebCore:

        Reviewed by NOBODY (OOPS!).

        Test cases added: (NONE)

        * WebCore.xcodeproj/.cvsignore: Added.

WebKit:

        Reviewed by NOBODY (OOPS!).

        * WebKit.xcodeproj/.cvsignore: Added.

WebKitTools:

        Reviewed by NOBODY (OOPS!).

        * DumpRenderTree/DumpRenderTree.xcodeproj/.cvsignore: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoWebCore:
ggaren [Thu, 21 Jul 2005 20:24:37 +0000 (20:24 +0000)]
WebCore:

        Reviewed by NOBODY (OOPS!).

        Test cases added: (NONE)

        * WebCore.xcodeproj/project.pbxproj: Added.

WebKit:

        Reviewed by NOBODY (OOPS!).

        * WebKit.xcodeproj/project.pbxproj: Added.

WebKitTools:

        Reviewed by NOBODY (OOPS!).

        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago*** empty log message ***
ggaren [Thu, 21 Jul 2005 19:46:42 +0000 (19:46 +0000)]
*** empty log message ***

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoJavaScriptCore:
ggaren [Thu, 21 Jul 2005 19:44:18 +0000 (19:44 +0000)]
JavaScriptCore:

        Reviewed by NOBODY (OOPS!).

        * JavaScriptCore.pbproj/project.pbxproj: Removed.
        * JavaScriptCore.xcodeproj/ggaren.pbxuser: Added.
        * JavaScriptCore.xcodeproj/ggaren.perspective: Added.
        * JavaScriptCore.xcodeproj/project.pbxproj: Added.
        * Makefile.am:

WebCore:

        Reviewed by NOBODY (OOPS!).

        Test cases added: (NONE)

        * Makefile.am:

WebKit:

        Reviewed by NOBODY (OOPS!).

        * Makefile.am:

WebKitTools:

        Reviewed by NOBODY (OOPS!).

        * Scripts/build-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Hyatt.
bdakin [Thu, 21 Jul 2005 16:33:33 +0000 (16:33 +0000)]
    Reviewed by Hyatt.

-fix for <rdar://problem/4169069> Also fixes the behavior of generated content
when it is specified within a list element.

        Test cases added: (NONE)

        * khtml/rendering/render_block.cpp:
        (khtml::RenderBlock::setStyle): Added loop to skip over list elements hen updating
generatedcontent.
        (khtml::RenderBlock::updateFirstLetter): Added clause so that the function updates the
first letter instead of just creating it.
        * khtml/rendering/render_inline.cpp:
        (RenderInline::setStyle): Added loop to skip over list elements when updating generated
content.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Geoff.
mjs [Thu, 21 Jul 2005 04:10:54 +0000 (04:10 +0000)]
    Reviewed by Geoff.

- fix handling of special properties of the HTML document object. Now we
completely match IE.

        Test cases added:
* layout-tests/fast/dom/HTMLDocument/document-special-properties.html:
Added; new exhaustive test case.
        * layout-tests/fast/dom/HTMLDocument/document-special-properties-expected.txt: Added.

        * khtml/ecma/kjs_html.cpp:
        (KJS::HTMLDocument::hasOwnProperty): Check for named and doc extra named
items.
        (KJS::HTMLDocument::get): Return the appropriate element, window or collection
by name; give such named items precedence over built-in and custom properties.
        * khtml/ecma/kjs_window.cpp:
        (KJS::Window::get): Replace quirky &* idiom with call to get().
        * khtml/html/html_baseimpl.cpp:
        (HTMLIFrameElementImpl::parseMappedAttribute): Track by name as a doc
extra named item.
        (HTMLIFrameElementImpl::insertedIntoDocument): ditto
        (HTMLIFrameElementImpl::removedFromDocument): ditto
        * khtml/html/html_baseimpl.h:
        * khtml/html/html_documentimpl.cpp:
        (DOM::addItemToMap): Factored out from addNamedItem
        (DOM::removeItemFromMap): Factored out from removeNamedItem
        (DOM::HTMLDocumentImpl::addNamedItem): refactored
        (DOM::HTMLDocumentImpl::removeNamedItem): refactored
        (DOM::HTMLDocumentImpl::addDocExtraNamedItem): new method - maintains
a hashtable of the "extra" named items for a document, which are
iframes by name and applets and embeds by id.
        (DOM::HTMLDocumentImpl::removeDocExtraNamedItem): ditto
        (DOM::HTMLDocumentImpl::hasDocExtraNamedItem): ditto
        * khtml/html/html_documentimpl.h:
        * khtml/html/html_miscimpl.cpp:
        (DOM::HTMLCollectionImpl::traverseNextItem): Remove support for
DOC_NAMEABLE_ITEMS collection - no longer needed.
        (DOM::HTMLNameCollectionImpl::traverseNextItem): Add support for
DOCUMENT_NAMED_ITEMS, implementing the correct document rule.
        * khtml/html/html_miscimpl.h:
        (DOM::HTMLCollectionImpl::):
        * khtml/html/html_objectimpl.cpp:
        (DOM::HTMLAppletElementImpl::parseMappedAttribute): Track by id
as doc extra named item
        (DOM::HTMLAppletElementImpl::insertedIntoDocument): ditto
        (DOM::HTMLAppletElementImpl::removedFromDocument): ditto
        (DOM::HTMLObjectElementImpl::parseMappedAttribute): ditto
        (DOM::HTMLObjectElementImpl::insertedIntoDocument): ditto
        (DOM::HTMLObjectElementImpl::removedFromDocument): ditto
        * khtml/html/html_objectimpl.h:
        * khtml/xml/dom_docimpl.cpp:
        (DocumentImpl::nameableItems): removed - no longer used
        (DocumentImpl::documentNamedItems): added
        * khtml/xml/dom_docimpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoWebCore:
sullivan [Wed, 20 Jul 2005 22:55:07 +0000 (22:55 +0000)]
WebCore:

        Reviewed by Vicki Murley.

        - removed some form-related methods that weren't being used anywhere, in preparation
        for weaning WebKit's WebFormDelegate protocol from NSView.

        Test cases added: none, no behavior change

        * kwq/KWQTextField.mm:
        * kwq/WebCoreBridge.h:
        removed these methods:
        -control:didFailToFormatString:errorDescription:
        -control:didFailToValidatePartialString:errorDescription:
        -control:isValidObject:

WebKit:

        Reviewed by Vicki Murley.

        - removed some form-related methods that weren't being used anywhere, in preparation
        for weaning WebKit's WebFormDelegate protocol from NSView.

        * WebCoreSupport.subproj/WebBridge.m:
        * WebView.subproj/WebFormDelegate.h:
        * WebView.subproj/WebFormDelegate.m:
        removed these methods:
        -control:didFailToFormatString:errorDescription:
        -control:didFailToValidatePartialString:errorDescription:
        -control:isValidObject:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Merged fix for:
adele [Wed, 20 Jul 2005 20:36:38 +0000 (20:36 +0000)]
      Merged fix for:
          <rdar://problem/4125127> [WebKit] horizontal rulers don't render on Safari on web.apple.com

          * WebCoreSupport.subproj/WebImageData.m:
          (-[WebImageData _checkSolidColor:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Merged fix for :
adele [Wed, 20 Jul 2005 20:04:13 +0000 (20:04 +0000)]
    Merged fix for :
        <rdar://problem/4118278> mail divide by zero navigating messages

        * WebCoreSupport.subproj/WebTextRenderer.m:
        (-[WebTextRenderer _extendGlyphToWidthMapToInclude:font:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Rolling fix for <rdar://problem/4046602> back in.
adele [Wed, 20 Jul 2005 19:55:12 +0000 (19:55 +0000)]
    Rolling fix for <rdar://problem/4046602> back in.

    2005-03-11  David Harrison  <harrison@apple.com>

        Reviewed by Darin.

        <rdar://problem/4046602> WebCore invokes undefined behavior when the spell checker isn't running

        * kwq/KWQKHTMLPart.mm:
        (KWQKHTMLPart::advanceToNextMisspelling):
        (KWQKHTMLPart::markMisspellings):
        Nil check checker.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoFixed reviewer name from previous checkin.
sullivan [Wed, 20 Jul 2005 18:34:19 +0000 (18:34 +0000)]
Fixed reviewer name from previous checkin.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Adele Amchan.
sullivan [Wed, 20 Jul 2005 18:30:15 +0000 (18:30 +0000)]
    Reviewed by Adele Amchan.

        - added -[WebView selectedFrame] to SPI (pending public API), needed for 4180958

        * WebView.subproj/WebView.m:
        (-[WebView selectedFrame]):
        new method, extracted from _selectedOrMainFrame
        (-[WebView _selectedOrMainFrame]):
        now calls extracted method

        * WebView.subproj/WebViewPrivate.h:
        add -selectedFrame to PendingPublic category

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Darin.
adele [Wed, 20 Jul 2005 18:17:31 +0000 (18:17 +0000)]
    Reviewed by Darin.

        - fixed <rdar://problem/4181058> 8C45: Safari repro crash with document.write (DOM::NodeImpl::dispatchEvent)

        Test cases added:
        * manual-tests/textfield-onblur.html: Added.

        * kwq/KWQTextField.mm: (-[KWQTextFieldController setHasFocus:]): added nil check for widget, since it can get deleted during an event.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoJavaScriptCore:
mjs [Wed, 20 Jul 2005 07:29:46 +0000 (07:29 +0000)]
JavaScriptCore:

        Patch from Trey Matteson <trey@usa.net>, reviewed by me.

- fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=3956
some of WebKit builds with symbols, some doesn't

        * JavaScriptCore.pbproj/project.pbxproj: Generate symbols even for
Deployment.

WebCore:

        Patch from Trey Matteson <trey@usa.net>, reviewed by me.

- fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=3956
some of WebKit builds with symbols, some doesn't

        * WebCore.pbproj/project.pbxproj: Generate symbols even for
Deployment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Kevin.
mjs [Wed, 20 Jul 2005 04:04:53 +0000 (04:04 +0000)]
    Reviewed by Kevin.

- fixed some mistakes in my previous checkin

        * khtml/html/html_objectimpl.cpp:
        (DOM::HTMLAppletElementImpl::parseMappedAttribute): Take name attribute out
of the "do nothing" case (duh).
        * layout-tests/fast/dom/Window/window-special-properties-expected.txt: Update
for change to the text at the top.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Darin.
mjs [Wed, 20 Jul 2005 02:35:33 +0000 (02:35 +0000)]
    Reviewed by Darin.

- fix handling of special properties of the Window object. now we
almost completely match Win IE.

        Test cases added:
        * layout-tests/fast/dom/Window/window-special-properties-expected.txt: Added.
        * layout-tests/fast/dom/Window/window-special-properties.html: Added.

        * khtml/ecma/kjs_html.cpp:
        (KJS::HTMLDocument::hasOwnProperty):
        (KJS::HTMLDocument::tryGet):
        * khtml/ecma/kjs_window.cpp:
        (KJS::Window::get):
        (KJS::Window::hasOwnProperty):
        * khtml/html/html_documentimpl.cpp:
        (DOM::HTMLDocumentImpl::addNamedItem):
        (DOM::HTMLDocumentImpl::removeNamedItem):
        (DOM::HTMLDocumentImpl::hasNamedItem):
        * khtml/html/html_documentimpl.h:
        * khtml/html/html_formimpl.cpp:
        (DOM::HTMLFormElementImpl::attach):
        (DOM::HTMLFormElementImpl::insertedIntoDocument):
        (DOM::HTMLFormElementImpl::removedFromDocument):
        (DOM::HTMLFormElementImpl::parseMappedAttribute):
        * khtml/html/html_formimpl.h:
        * khtml/html/html_imageimpl.cpp:
        (HTMLImageElementImpl::parseMappedAttribute):
        (HTMLImageElementImpl::attach):
        (HTMLImageElementImpl::insertedIntoDocument):
        (HTMLImageElementImpl::removedFromDocument):
        * khtml/html/html_imageimpl.h:
        * khtml/html/html_miscimpl.cpp:
        (DOM::HTMLCollectionImpl::HTMLCollectionImpl):
        (DOM::HTMLCollectionImpl::traverseNextItem):
        (DOM::HTMLCollectionImpl::namedItem):
        (DOM::HTMLNameCollectionImpl::HTMLNameCollectionImpl):
        (DOM::HTMLNameCollectionImpl::traverseNextItem):
        (DOM::HTMLFormCollectionImpl::getNamedFormItem):
        (DOM::HTMLFormCollectionImpl::nextNamedItem):
        * khtml/html/html_miscimpl.h:
        (DOM::HTMLCollectionImpl::):
        * khtml/html/html_objectimpl.cpp:
        (DOM::HTMLAppletElementImpl::parseMappedAttribute):
        (DOM::HTMLAppletElementImpl::insertedIntoDocument):
        (DOM::HTMLAppletElementImpl::removedFromDocument):
        (DOM::HTMLEmbedElementImpl::parseMappedAttribute):
        (DOM::HTMLEmbedElementImpl::attach):
        (DOM::HTMLEmbedElementImpl::insertedIntoDocument):
        (DOM::HTMLEmbedElementImpl::removedFromDocument):
        (DOM::HTMLObjectElementImpl::parseMappedAttribute):
        (DOM::HTMLObjectElementImpl::detach):
        (DOM::HTMLObjectElementImpl::insertedIntoDocument):
        (DOM::HTMLObjectElementImpl::removedFromDocument):
        * khtml/html/html_objectimpl.h:
        * khtml/xml/dom_docimpl.cpp:
        (DocumentImpl::windowNamedItems):
        * khtml/xml/dom_docimpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago -fixed http://bugzilla.opendarwin.org/show_bug.cgi?id=3991
ggaren [Wed, 20 Jul 2005 02:23:57 +0000 (02:23 +0000)]
    -fixed bugzilla.opendarwin.org/show_bug.cgi?id=3991
        JSC doesn't implement Array.prototype.toLocaleString()

        -test failure: ecma_3/Array/15.4.4.3-1.js

        Reviewed by mjs.

        * kjs/array_object.cpp:
        (ArrayProtoFuncImp::call): now searches for toString and
        toLocaleString overrides in the array's elements

        * tests/mozilla/expected.html: failures are under 100! woohoo!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago -rolled in patch by Anders Carlsson <andersca@mac.com> for
ggaren [Wed, 20 Jul 2005 02:04:43 +0000 (02:04 +0000)]
    -rolled in patch by Anders Carlsson <andersca@mac.com> for
        http://bugzilla.opendarwin.org/show_bug.cgi?id=3751
        REGRESSION: affects Blogger, GMail & Wikipedia: empty textarea's which should have content

        Reviewed by mjs.

        * khtml/html/html_formimpl.cpp:
        (DOM::HTMLTextAreaElementImpl::defaultValue):
        (DOM::HTMLTextAreaElementImpl::attach):
        * khtml/html/html_formimpl.h:

        Test cases added:
        * manual-tests/textarea-after-stylesheet-link.html: Added.
        Test is manual because the result doesn't show up in DumpRenderTree

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Added a virtual deconstructor to fix gcc4 build warning
justing [Wed, 20 Jul 2005 01:17:28 +0000 (01:17 +0000)]
    Added a virtual deconstructor to fix gcc4 build warning

        * khtml/rendering/render_theme.h:
        (khtml::RenderTheme::~RenderTheme):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Darin Adler.
sullivan [Wed, 20 Jul 2005 00:50:23 +0000 (00:50 +0000)]
    Reviewed by Darin Adler.

        - cleaned up code related to dealing with the "selected frame"; fixes radar bugs 4118830 and 4118820

        * WebView.subproj/WebTextView.m:
        (-[WebTextView resignFirstResponder]):
        call deselectAll here instead of replicating its guts, just for clarity

        * WebView.subproj/WebViewInternal.h:
        eliminated category WebInternal; all of these methods were used only inside WebView.m, so I moved
        them into the existing category WebFileInternal that was declared and implemented in WebView.m

        * WebView.subproj/WebView.m:
        (-[WebView searchFor:direction:caseSensitive:wrap:]):
        updated for name changes. Also, uses new _deselectFrame: to clear the selection if the found
        text is in a different frame.
        (-[WebView pasteboardTypesForSelection]):
        (-[WebView writeSelectionWithPasteboardTypes:toPasteboard:]):
        (-[WebView setSelectedDOMRange:affinity:]):
        (-[WebView selectedDOMRange]):
        (-[WebView selectionAffinity]):
        (-[WebView setTypingStyle:]):
        (-[WebView typingStyle]):
        (-[WebView styleDeclarationWithText:]):
        (-[WebView replaceSelectionWithNode:]):
        (-[WebView replaceSelectionWithText:]):
        (-[WebView replaceSelectionWithMarkupString:]):
        (-[WebView replaceSelectionWithArchive:]):
        (-[WebView deleteSelection]):
        (-[WebView applyStyle:]):
        updated for name changes only

        (-[WebView _frameIsSelected:]):
        new method, returns YES if given frame has a non-zero-length selection
        (-[WebView _deselectFrame:]):
        new method, clears selection from given frame
        (-[WebView _findSelectedFrameStartingFromFrame:]):
        new method, recursive helper used by _findSelectedFrame
        (-[WebView _findSelectedFrame]):
        new method, finds first frame that returns YES for _frameIsSelected, or nil
        (-[WebView _debugCollectSelectedFramesIntoArray:startingFromFrame:]):
        new method, recursive helper used by _debugCheckForMultipleSelectedFrames
        (-[WebView _debugCheckForMultipleSelectedFrames]):
        new method for debugging, fires an assertion if there's more than one selected frame.
        (-[WebView _selectedOrMainFrame]):
        renamed from _frameForCurrentSelection, which was a misleading name since the returned
        frame does not necessarily have a selection (or even focus). Now checks for a selected
        but non-focused frame if the first responder is not in any frame. Also, moved in file
        from WebInternal category to WebFileInternal category.
        (-[WebView _bridgeForSelectedOrMainFrame]):
        renamed from _bridgeForCurrentSelection, which was a misleading name for the same
        reasons as _frameForCurrentSelection. Also, moved in file from WebInternal category to
        WebFileInternal category.
        (-[WebView _isLoading]):
        (-[WebView _frameViewAtWindowPoint:]):
        (-[WebView _bridgeAtPoint:]):
        just moved in file from WebInternal category to WebFileInternal category

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Adding support for the "checkbox" appearance value. This is not yet implemented...
hyatt [Wed, 20 Jul 2005 00:45:49 +0000 (00:45 +0000)]
Adding support for the "checkbox" appearance value.  This is not yet implemented, but the
methods are now stubbed out and will get called.

Reviewed by mjs

        * WebCore.pbproj/project.pbxproj:
        * khtml/css/cssstyleselector.cpp:
        (khtml::CSSStyleSelector::adjustRenderStyle):
        (khtml::CSSStyleSelector::applyProperty):
        * khtml/css/html4.css:
        * khtml/html/html_formimpl.cpp:
        (DOM::HTMLInputElementImpl::createRenderer):
        * khtml/rendering/render_box.cpp:
        (RenderBox::paintBoxDecorations):
        * khtml/rendering/render_theme.cpp: Added.
        (khtml::RenderTheme::adjustStyle):
        (khtml::RenderTheme::paint):
        * khtml/rendering/render_theme.h: Added.
        * khtml/rendering/render_theme_mac.h: Added.
        * khtml/rendering/render_theme_mac.mm: Added.
        (khtml::theme):
        (khtml::RenderThemeMac::adjustCheckboxStyle):
        (khtml::RenderThemeMac::paintCheckbox):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Fix performance regressions from attribute QName landing.
hyatt [Tue, 19 Jul 2005 23:44:07 +0000 (23:44 +0000)]
Fix performance regressions from attribute QName landing.

        Reviewed by mjs

        * khtml/html/htmltokenizer.cpp:
        (khtml::Token::addAttribute):
        (khtml::HTMLTokenizer::write):

Make sure attributes have a faster constructor that can avoid the copy of QualifiedNames.

Make sure to grab the part from the document outside the loop, so that it is not fetched
over and over again for every character in the source.

        * khtml/rendering/render_block.cpp:
        (khtml::RenderBlock::paintObject):

Only call paintCaret if the block is actually editable.

        * khtml/xml/dom_atomicstring.h:
        (DOM::operator!=):
        * khtml/xml/dom_elementimpl.h:
        (DOM::AttributeImpl::AttributeImpl):
        (DOM::AttributeImpl::~AttributeImpl):
        (DOM::MappedAttributeImpl::MappedAttributeImpl):

Add != comparison operator with a char* to speed up the / check for attribute invalidity.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Maciej.
vicki [Tue, 19 Jul 2005 22:41:48 +0000 (22:41 +0000)]
    Reviewed by Maciej.

        Test cases added:
        * manual-tests/scrollIntoView-horizontal.html: Added.
        * manual-tests/scrollIntoView-vertical.html: Added.

        * khtml/xml/dom_elementimpl.h:
        * khtml/xml/dom_elementimpl.cpp:
        (ElementImpl::scrollIntoView): Added.
        * khtml/ecma/kjs_dom.h:
        (KJS::DOMNode::):
        (KJS::DOMElement::):
        * khtml/ecma/kjs_dom.cpp:
        (KJS::DOMElementProtoFunc::tryCall): glue for new scrollIntoView function

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago - rolled in patch by opendarwin.org@mitzpettel.com for
ggaren [Tue, 19 Jul 2005 21:18:25 +0000 (21:18 +0000)]
    - rolled in patch by opendarwin.org@mitzpettel.com for
        http://bugzilla.opendarwin.org/show_bug.cgi?id=3838
        Text runs unnecessarily split at EN L boundaries

        Reviewed by hyatt.

        * khtml/rendering/bidi.cpp:
        (khtml::RenderBlock::bidiReorderLine):

        Lots of new test case results because previous results had inappropriately
        split text runs.

        * layout-tests/css1/basic/containment-expected.txt:
        * layout-tests/css1/box_properties/border-expected.txt:
        * layout-tests/css1/box_properties/border_bottom-expected.txt:
        * layout-tests/css1/box_properties/border_bottom_inline-expected.txt:
        * layout-tests/css1/box_properties/border_bottom_width-expected.txt:
        * layout-tests/css1/box_properties/border_bottom_width_inline-expected.txt:
        * layout-tests/css1/box_properties/border_inline-expected.txt:
        * layout-tests/css1/box_properties/border_left-expected.txt:
        * layout-tests/css1/box_properties/border_left_inline-expected.txt:
        * layout-tests/css1/box_properties/border_left_width-expected.txt:
        * layout-tests/css1/box_properties/border_left_width_inline-expected.txt:
        * layout-tests/css1/box_properties/border_right-expected.txt:
        * layout-tests/css1/box_properties/border_right_inline-expected.txt:
        * layout-tests/css1/box_properties/border_right_width-expected.txt:
        * layout-tests/css1/box_properties/border_right_width_inline-expected.txt:
        * layout-tests/css1/box_properties/border_top-expected.txt:
        * layout-tests/css1/box_properties/border_top_inline-expected.txt:
        * layout-tests/css1/box_properties/border_top_width-expected.txt:
        * layout-tests/css1/box_properties/border_top_width_inline-expected.txt:
        * layout-tests/css1/box_properties/border_width-expected.txt:
        * layout-tests/css1/box_properties/border_width_inline-expected.txt:
        * layout-tests/css1/box_properties/clear_float-expected.txt:
        * layout-tests/css1/box_properties/float_elements_in_series-expected.txt:
        * layout-tests/css1/box_properties/float_margin-expected.txt:
        * layout-tests/css1/box_properties/float_on_text_elements-expected.txt:
        * layout-tests/css1/box_properties/height-expected.txt:
        * layout-tests/css1/box_properties/margin-expected.txt:
        * layout-tests/css1/box_properties/margin_bottom-expected.txt:
        * layout-tests/css1/box_properties/margin_bottom_inline-expected.txt:
        * layout-tests/css1/box_properties/margin_inline-expected.txt:
        * layout-tests/css1/box_properties/margin_left-expected.txt:
        * layout-tests/css1/box_properties/margin_left_inline-expected.txt:
        * layout-tests/css1/box_properties/margin_right-expected.txt:
        * layout-tests/css1/box_properties/margin_right_inline-expected.txt:
        * layout-tests/css1/box_properties/margin_top-expected.txt:
        * layout-tests/css1/box_properties/margin_top_inline-expected.txt:
        * layout-tests/css1/box_properties/padding-expected.txt:
        * layout-tests/css1/box_properties/padding_bottom-expected.txt:
        * layout-tests/css1/box_properties/padding_bottom_inline-expected.txt:
        * layout-tests/css1/box_properties/padding_inline-expected.txt:
        * layout-tests/css1/box_properties/padding_left-expected.txt:
        * layout-tests/css1/box_properties/padding_left_inline-expected.txt:
        * layout-tests/css1/box_properties/padding_right-expected.txt:
        * layout-tests/css1/box_properties/padding_right_inline-expected.txt:
        * layout-tests/css1/box_properties/padding_top-expected.txt:
        * layout-tests/css1/box_properties/padding_top_inline-expected.txt:
        * layout-tests/css1/box_properties/width-expected.txt:
        * layout-tests/css1/classification/display-expected.txt:
        * layout-tests/css1/color_and_background/background_position-expected.txt:
        * layout-tests/css1/conformance/forward_compatible_parsing-expected.txt:
        * layout-tests/css1/font_properties/font-expected.txt:
        * layout-tests/css1/font_properties/font_size-expected.txt:
        * layout-tests/css1/formatting_model/canvas-expected.txt:
        * layout-tests/css1/formatting_model/floating_elements-expected.txt:
        * layout-tests/css1/formatting_model/height_of_lines-expected.txt:
        * layout-tests/css1/formatting_model/inline_elements-expected.txt:
        * layout-tests/css1/formatting_model/replaced_elements-expected.txt:
        * layout-tests/css1/formatting_model/vertical_formatting-expected.txt:
        * layout-tests/css1/pseudo/anchor-expected.txt:
        * layout-tests/css1/text_properties/letter_spacing-expected.txt:
        * layout-tests/css1/text_properties/line_height-expected.txt:
        * layout-tests/css1/text_properties/text_indent-expected.txt:
        * layout-tests/css1/text_properties/vertical_align-expected.txt:
        * layout-tests/css1/text_properties/word_spacing-expected.txt:
        * layout-tests/css1/units/length_units-expected.txt:
        * layout-tests/editing/style/relative-font-size-change-001-expected.txt:
        * layout-tests/editing/style/relative-font-size-change-002-expected.txt:
        * layout-tests/editing/style/relative-font-size-change-003-expected.txt:
        * layout-tests/editing/style/relative-font-size-change-004-expected.txt:
        * layout-tests/editing/style/smoosh-styles-003-expected.txt:
        * layout-tests/fast/block/basic/018-expected.txt:
        * layout-tests/fast/block/float/002-expected.txt:
        * layout-tests/fast/block/float/021-expected.txt:
        * layout-tests/fast/block/float/023-expected.txt:
        * layout-tests/fast/block/float/024-expected.txt:
        * layout-tests/fast/block/float/029-expected.txt:
        * layout-tests/fast/block/float/030-expected.txt:
        * layout-tests/fast/block/margin-collapse/043-expected.txt:
        * layout-tests/fast/block/margin-collapse/101-expected.txt:
        * layout-tests/fast/block/positioning/060-expected.txt:
        * layout-tests/fast/block/positioning/auto/001-expected.txt:
        * layout-tests/fast/block/positioning/auto/002-expected.txt:
        * layout-tests/fast/block/positioning/auto/003-expected.txt:
        * layout-tests/fast/block/positioning/auto/004-expected.txt:
        * layout-tests/fast/block/positioning/auto/005-expected.txt:
        * layout-tests/fast/block/positioning/auto/006-expected.txt:
        * layout-tests/fast/clip/001-expected.txt:
        * layout-tests/fast/clip/002-expected.txt:
        * layout-tests/fast/clip/003-expected.txt:
        * layout-tests/fast/clip/004-expected.txt:
        * layout-tests/fast/clip/005-expected.txt:
        * layout-tests/fast/clip/006-expected.txt:
        * layout-tests/fast/clip/007-expected.txt:
        * layout-tests/fast/clip/008-expected.txt:
        * layout-tests/fast/clip/009-expected.txt:
        * layout-tests/fast/clip/010-expected.txt:
        * layout-tests/fast/clip/011-expected.txt:
        * layout-tests/fast/clip/012-expected.txt:
        * layout-tests/fast/clip/013-expected.txt:
        * layout-tests/fast/clip/014-expected.txt:
        * layout-tests/fast/clip/015-expected.txt:
        * layout-tests/fast/clip/016-expected.txt:
        * layout-tests/fast/css-generated-content/012-expected.txt:
        * layout-tests/fast/css/008-expected.txt:
        * layout-tests/fast/css/MarqueeLayoutTest-expected.txt:
        * layout-tests/fast/css/apple-prefix-expected.txt:
        * layout-tests/fast/dom/quadraticCurveTo-expected.txt:
        * layout-tests/fast/dynamic/noninlinebadness-expected.txt:
        * layout-tests/fast/encoding/utf-16-big-endian-expected.txt:
        * layout-tests/fast/encoding/utf-16-little-endian-expected.txt:
        * layout-tests/fast/flexbox/001-expected.txt:
        * layout-tests/fast/flexbox/004-expected.txt:
        * layout-tests/fast/flexbox/007-expected.txt:
        * layout-tests/fast/flexbox/008-expected.txt:
        * layout-tests/fast/flexbox/009-expected.txt:
        * layout-tests/fast/flexbox/010-expected.txt:
        * layout-tests/fast/flexbox/012-expected.txt:
        * layout-tests/fast/flexbox/013-expected.txt:
        * layout-tests/fast/flexbox/014-expected.txt:
        * layout-tests/fast/flexbox/015-expected.txt:
        * layout-tests/fast/flexbox/018-expected.txt:
        * layout-tests/fast/flexbox/019-expected.txt:
        * layout-tests/fast/flexbox/020-expected.txt:
        * layout-tests/fast/flexbox/021-expected.txt:
        * layout-tests/fast/flexbox/022-expected.txt:
        * layout-tests/fast/flexbox/023-expected.txt:
        * layout-tests/fast/flexbox/024-expected.txt:
        * layout-tests/fast/invalid/012-expected.txt:
        * layout-tests/fast/invalid/016-expected.txt:
        * layout-tests/fast/invalid/nestedh3s-expected.txt:
        * layout-tests/fast/lists/003-expected.txt:
        * layout-tests/fast/replaced/004-expected.txt:
        * layout-tests/fast/selectors/166-expected.txt:
        * layout-tests/fast/table/032-expected.txt:
        * layout-tests/fast/table/border-collapsing/004-expected.txt:
        * layout-tests/fast/text/basic/003-expected.txt:
        * layout-tests/fast/text/basic/004-expected.txt:
        * layout-tests/fast/text/basic/005-expected.txt:
        * layout-tests/fast/text/basic/009-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago - fixed the build
darin [Tue, 19 Jul 2005 21:16:49 +0000 (21:16 +0000)]
    - fixed the build

        * kjs/lookup.h: (KJS::lookupPut): Remove bogus const; was preventing WebCore from
        compiling (not sure why this didn't affect my other build machine).

        - one other tiny tweak (so sue me)

        * bindings/runtime_root.cpp: Remove unneeded declaration.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years agoJavaScriptCore:
darin [Tue, 19 Jul 2005 19:52:49 +0000 (19:52 +0000)]
JavaScriptCore:

        Reviewed by Geoff Garen.

        - eliminated try wrappers for get/put/call since we don't use C++ exceptions any more

        * kjs/lookup.h: Changed tryCall in IMPLEMENT_PROTOFUNC here to call. It doesn't make
        sense for this macro to use the name tryCall anyway, since that's specific to how
        WebCore used this, so this is good anyway. On the other hand, it might be a problem
        for KDOM or KSVG, in which case we'll need another macro for them, since JavaScriptCore
        should presumably not have the C++ exception support.

WebCore:

        Reviewed by Geoff Garen.

        Test cases added: None. Structural change only.

        - eliminated try wrappers for get/put/call since we don't use C++ exceptions any more

        * khtml/ecma/kjs_binding.cpp: Removed DOMObject::get, DOMObject::set, DOMFunction::get,
        and DOMFunction::call.
        * khtml/ecma/kjs_binding.h: Removed get, set, tryGet, trySet, call, tryCall from DOMObject
        and DOMFunction. Removed DOMObjectLookupGet, DOMObjectLookupGetValue, and DOMObjectLookupPut.
        We can just do things the normal way now.

        The rest of the changes are just renames and removal of a couple stray tryCall wrappers.

            tryGet -> get
            tryPut -> put
            tryCall -> call
            putValue -> putValueProperty
            DOMObjectLookupGet -> lookupGet
            DOMObjectLookupGetValue -> lookupGetValue
            DOMObjectLookupPut -> lookupPut

        * khtml/ecma/domparser.cpp:
        (KJS::DOMParserProtoFunc::call):
        * khtml/ecma/kjs_css.cpp:
        (KJS::DOMCSSStyleDeclaration::get):
        (KJS::DOMCSSStyleDeclaration::put):
        (KJS::DOMCSSStyleDeclarationProtoFunc::call):
        (KJS::DOMStyleSheet::get):
        (KJS::DOMStyleSheet::put):
        (KJS::DOMStyleSheetList::get):
        (KJS::DOMStyleSheetListFunc::call):
        (KJS::DOMMediaList::get):
        (KJS::DOMMediaList::put):
        (KJS::KJS::DOMMediaListProtoFunc::call):
        (KJS::DOMCSSStyleSheet::get):
        (KJS::DOMCSSStyleSheetProtoFunc::call):
        (KJS::DOMCSSRuleList::get):
        (KJS::DOMCSSRuleListFunc::call):
        (KJS::DOMCSSRule::get):
        (KJS::DOMCSSRule::put):
        (KJS::DOMCSSRule::putValueProperty):
        (KJS::DOMCSSRuleFunc::call):
        (KJS::CSSRuleConstructor::get):
        (KJS::DOMCSSValue::get):
        (KJS::DOMCSSValue::put):
        (KJS::CSSValueConstructor::get):
        (KJS::DOMCSSPrimitiveValue::get):
        (KJS::DOMCSSPrimitiveValueProtoFunc::call):
        (KJS::CSSPrimitiveValueConstructor::get):
        (KJS::DOMCSSValueList::get):
        (KJS::DOMCSSValueListFunc::call):
        (KJS::DOMRGBColor::get):
        (KJS::DOMRect::get):
        (KJS::DOMCounter::get):
        * khtml/ecma/kjs_css.h:
        * khtml/ecma/kjs_dom.cpp:
        (KJS::DOMNode::get):
        (KJS::DOMNode::put):
        (KJS::DOMNode::putValueProperty):
        (KJS::DOMNodeProtoFunc::call):
        (KJS::DOMNodeList::get):
        (KJS::DOMNodeList::call):
        (KJS::DOMNodeListFunc::call):
        (KJS::DOMAttr::get):
        (KJS::DOMAttr::put):
        (KJS::DOMAttr::putValueProperty):
        (KJS::DOMDocument::get):
        (KJS::DOMDocument::put):
        (KJS::DOMDocument::putValueProperty):
        (KJS::DOMDocumentProtoFunc::call):
        (KJS::DOMElement::get):
        (KJS::DOMElementProtoFunc::call):
        (KJS::DOMDOMImplementationProtoFunc::call):
        (KJS::DOMDocumentType::get):
        (KJS::DOMNamedNodeMap::get):
        (KJS::DOMNamedNodeMapProtoFunc::call):
        (KJS::DOMProcessingInstruction::get):
        (KJS::DOMProcessingInstruction::put):
        (KJS::DOMNotation::get):
        (KJS::DOMEntity::get):
        (KJS::NodeConstructor::get):
        (KJS::DOMExceptionConstructor::get):
        (KJS::DOMNamedNodesCollection::get):
        (KJS::DOMCharacterData::get):
        (KJS::DOMCharacterData::put):
        (KJS::DOMCharacterDataProtoFunc::call):
        (KJS::DOMText::get):
        (KJS::DOMTextProtoFunc::call):
        * khtml/ecma/kjs_dom.h:
        * khtml/ecma/kjs_events.cpp:
        (KJS::EventConstructor::get):
        (KJS::DOMEvent::get):
        (KJS::DOMEvent::put):
        (KJS::DOMEvent::putValueProperty):
        (KJS::DOMEventProtoFunc::call):
        (KJS::EventExceptionConstructor::get):
        (KJS::DOMUIEvent::get):
        (KJS::DOMUIEventProtoFunc::call):
        (KJS::DOMMouseEvent::get):
        (KJS::DOMMouseEventProtoFunc::call):
        (KJS::DOMKeyboardEvent::get):
        (KJS::DOMKeyboardEventProtoFunc::call):
        (KJS::MutationEventConstructor::get):
        (KJS::DOMMutationEvent::get):
        (KJS::DOMMutationEventProtoFunc::call):
        (KJS::DOMWheelEvent::get):
        (KJS::DOMWheelEventProtoFunc::call):
        (KJS::Clipboard::get):
        (KJS::Clipboard::put):
        (KJS::Clipboard::putValueProperty):
        (KJS::ClipboardProtoFunc::call):
        * khtml/ecma/kjs_events.h:
        * khtml/ecma/kjs_html.cpp:
        (KJS::KJS::HTMLDocFunction::call):
        (KJS::HTMLDocument::get):
        (KJS::KJS::HTMLDocument::put):
        (KJS::KJS::HTMLDocument::putValueProperty):
        (KJS::KJS::HTMLElement::get):
        (KJS::KJS::HTMLElementFunction::call):
        (KJS::KJS::HTMLElement::put):
        (KJS::HTMLElement::putValueProperty):
        (KJS::KJS::HTMLCollection::get):
        (KJS::KJS::HTMLCollection::call):
        (KJS::KJS::HTMLCollectionProtoFunc::call):
        (KJS::KJS::HTMLSelectCollection::get):
        (KJS::KJS::HTMLSelectCollection::put):
        (KJS::Image::get):
        (KJS::Image::put):
        (KJS::Image::putValueProperty):
        (KJS::KJS::Context2DFunction::call):
        (KJS::Context2D::get):
        (KJS::Context2D::put):
        (KJS::Context2D::putValueProperty):
        (KJS::GradientFunction::call):
        (KJS::Gradient::get):
        (KJS::Gradient::put):
        (KJS::Gradient::putValueProperty):
        (KJS::ImagePattern::get):
        (KJS::ImagePattern::put):
        (KJS::ImagePattern::putValueProperty):
        * khtml/ecma/kjs_html.h:
        * khtml/ecma/kjs_navigator.cpp:
        (KJS::PluginsFunc::call):
        (KJS::NavigatorFunc::call):
        * khtml/ecma/kjs_range.cpp:
        (KJS::DOMRange::get):
        (KJS::DOMRangeProtoFunc::call):
        (KJS::RangeConstructor::get):
        * khtml/ecma/kjs_range.h:
        * khtml/ecma/kjs_traversal.cpp:
        (KJS::DOMNodeIterator::get):
        (KJS::DOMNodeIteratorProtoFunc::call):
        (KJS::NodeFilterConstructor::get):
        (KJS::DOMNodeFilterProtoFunc::call):
        (KJS::DOMTreeWalker::get):
        (KJS::DOMTreeWalker::put):
        (KJS::DOMTreeWalkerProtoFunc::call):
        * khtml/ecma/kjs_traversal.h:
        * khtml/ecma/kjs_views.cpp:
        (KJS::DOMAbstractView::get):
        (KJS::DOMAbstractViewFunc::call):
        * khtml/ecma/kjs_views.h:
        * khtml/ecma/kjs_window.cpp:
        (KJS::WindowFunc::call):
        (KJS::LocationFunc::call):
        (KJS::SelectionFunc::call):
        (KJS::HistoryFunc::call):
        (KJS::KonquerorFunc::call):
        * khtml/ecma/xmlhttprequest.cpp:
        (KJS::XMLHttpRequest::get):
        (KJS::XMLHttpRequest::put):
        (KJS::XMLHttpRequest::putValueProperty):
        (KJS::XMLHttpRequestProtoFunc::call):
        * khtml/ecma/xmlhttprequest.h:
        * khtml/ecma/xmlserializer.cpp:
        (KJS::XMLSerializerProtoFunc::call):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

16 years ago Reviewed by Geoff Garen.
darin [Tue, 19 Jul 2005 19:48:45 +0000 (19:48 +0000)]
    Reviewed by Geoff Garen.

        - improve handling of plug-ins when the WebView or a superview is hidden with -[NSView setHidden]

        * Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView saveAndSetPortStateForUpdate:]):
        Add "hidden" to the list of reasons to clip out all plug-in drawing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@9832 268f45cc-cd09-0410-ab3c-d52691b4dbfc