WebKit-https.git
4 years ago[WebIDL] Replace JSCryptoKeyCustom and JSCryptoAlgorithmBuilder with generated code
commit-queue@webkit.org [Sat, 12 Aug 2017 00:07:00 +0000 (00:07 +0000)]
[WebIDL] Replace JSCryptoKeyCustom and JSCryptoAlgorithmBuilder with generated code
https://bugs.webkit.org/show_bug.cgi?id=175457

Patch by Sam Weinig <sam@webkit.org> on 2017-08-11
Reviewed by Chris Dumez.

* CMakeLists.txt:
* DerivedSources.make:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSCryptoAlgorithmBuilder.cpp: Removed.
* bindings/js/JSCryptoAlgorithmBuilder.h: Removed.
* bindings/js/JSCryptoKeyCustom.cpp: Removed.

    Remove JSCryptoAlgorithmBuilder and JSCryptoKeyCustom, add KeyAlgorithm
    IDLs and headers.

* crypto/CryptoKey.cpp:
* crypto/CryptoKey.h:
* crypto/CryptoKey.idl:

    Replace custom algorithm attribute with a union of the supported key algorithms.

* crypto/keys/CryptoAesKeyAlgorithm.h: Added.
* crypto/keys/CryptoAesKeyAlgorithm.idl: Added.
* crypto/keys/CryptoEcKeyAlgorithm.h: Added.
* crypto/keys/CryptoEcKeyAlgorithm.idl: Added.
* crypto/keys/CryptoHmacKeyAlgorithm.h: Added.
* crypto/keys/CryptoHmacKeyAlgorithm.idl: Added.
* crypto/keys/CryptoKeyAlgorithm.h: Added.
* crypto/keys/CryptoKeyAlgorithm.idl: Added.
* crypto/keys/CryptoRsaHashedKeyAlgorithm.h: Added.
* crypto/keys/CryptoRsaHashedKeyAlgorithm.idl: Added.
* crypto/keys/CryptoRsaKeyAlgorithm.h: Added.
* crypto/keys/CryptoRsaKeyAlgorithm.idl: Added.

    Add IDLs and headers fo the supported key algorithms.

* crypto/keys/CryptoKeyAES.h:
* crypto/keys/CryptoKeyEC.h:
* crypto/keys/CryptoKeyHMAC.h:
* crypto/keys/CryptoKeyRSA.h:
* crypto/keys/CryptoKeyRaw.h:

    Give each of the existing KeyAlgorithm subclasses a dictionary() function
    that returns the populated corresponding spec'd dictionary.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoJSLexicalEnvironment needs to be in the JSValue gigacage
fpizlo@apple.com [Fri, 11 Aug 2017 23:18:18 +0000 (23:18 +0000)]
JSLexicalEnvironment needs to be in the JSValue gigacage
https://bugs.webkit.org/show_bug.cgi?id=174922

Reviewed by Michael Saboff.

We can sorta random access the JSLexicalEnvironment. So, we put it in the JSValue gigacage and make
the only random accesses use pointer caging.

We don't need to do anything to normal lexical environment accesses.

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileGetByValOnScopedArguments):
* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileGetByVal):
* runtime/JSEnvironmentRecord.h:
(JSC::JSEnvironmentRecord::subspaceFor):
(JSC::JSEnvironmentRecord::variables):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUpdate TestExpectations for failing media/video-controls tests.
ryanhaddad@apple.com [Fri, 11 Aug 2017 23:12:52 +0000 (23:12 +0000)]
Update TestExpectations for failing media/video-controls tests.
https://bugs.webkit.org/show_bug.cgi?id=173978

Unreviewed test gardening.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoSome RenderSVGResource cleanup
simon.fraser@apple.com [Fri, 11 Aug 2017 22:43:01 +0000 (22:43 +0000)]
Some RenderSVGResource cleanup
https://bugs.webkit.org/show_bug.cgi?id=175494

Reviewed by Zalan Bujtas.

Use more initializers. Remove spurious use of bitfields that didn't save any space at all.
0 -> nullptr.

No behavior change.

* rendering/svg/RenderSVGResourceContainer.cpp:
(WebCore::RenderSVGResourceContainer::RenderSVGResourceContainer):
* rendering/svg/RenderSVGResourceContainer.h:
* rendering/svg/RenderSVGResourceGradient.cpp:
(WebCore::RenderSVGResourceGradient::RenderSVGResourceGradient):
(WebCore::RenderSVGResourceGradient::applyResource):
* rendering/svg/RenderSVGResourceGradient.h:
* rendering/svg/RenderSVGResourcePattern.cpp:
(WebCore::RenderSVGResourcePattern::RenderSVGResourcePattern):
* rendering/svg/RenderSVGResourcePattern.h:
* rendering/svg/RenderSVGShape.cpp:
(WebCore::RenderSVGShape::fillShape):
(WebCore::RenderSVGShape::strokeShape):
* rendering/svg/SVGRenderingContext.cpp:
(WebCore::SVGRenderingContext::~SVGRenderingContext):
(WebCore::SVGRenderingContext::prepareToRenderSVGContent):
* rendering/svg/SVGRenderingContext.h:
(WebCore::SVGRenderingContext::SVGRenderingContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoFix the build with modern Clang's -Wexpansion-to-defined
timothy_horton@apple.com [Fri, 11 Aug 2017 22:35:30 +0000 (22:35 +0000)]
Fix the build with modern Clang's -Wexpansion-to-defined
https://bugs.webkit.org/show_bug.cgi?id=175467
<rdar://problem/33667497>

Reviewed by Simon Fraser.

Source/WebCore:

* crypto/mac/SerializedCryptoKeyWrapMac.mm:

Source/WTF:

* wtf/FeatureDefines.h:
* wtf/Platform.h:
Avoid object-like macros that expand to include defined(), because this
behaves inconsistently between different compilers (though in ways
that don't matter for these particular defines, which aren't used on MSVC),
and Clang has added a warning for it.

Move ENABLE_WEBASSEMBLY to Platform.h since it depends on things that
are defined there and can't be evaluated at time-of-use because of the
aforementioned new rules. Previously, there was a cycle between
ENABLE_WEBASSEMBLY and ENABLE_B3_JIT -- break that so that it just
goes FTL_JIT->B3_JIT->WASM instead.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWeb Inspector: Clicking on suggestion hint should apply it, not dismiss
nvasilyev@apple.com [Fri, 11 Aug 2017 22:33:28 +0000 (22:33 +0000)]
Web Inspector: Clicking on suggestion hint should apply it, not dismiss
https://bugs.webkit.org/show_bug.cgi?id=175409

Reviewed by Matt Baker.

Make clicking on the suggestion hint apply the completion, and place the text caret after it.

* UserInterface/Controllers/CodeMirrorCompletionController.js:
(WI.CodeMirrorCompletionController.prototype._createCompletionHintMarker):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWeb Inspector: Styles: Update the filter icon to match Xcode
nvasilyev@apple.com [Fri, 11 Aug 2017 21:08:58 +0000 (21:08 +0000)]
Web Inspector: Styles: Update the filter icon to match Xcode
https://bugs.webkit.org/show_bug.cgi?id=175458
<rdar://problem/33838660>

Reviewed by Matt Baker.

* UserInterface/Images/FilterFieldGlyph.svg:
Half-pixel transform is necessary for a cleaner rasterisation.

* UserInterface/Views/FilterBar.css:
(.filter-bar > input[type="search"]::-webkit-search-decoration):
(.sidebar > .panel.dom-node-details .details-section.dom-node-event-listeners > .header > .filter):
::-webkit-search-decoration is a flexbox item. Remove `vertical-align: bottom`,
since it didn't do anything for it.

* UserInterface/Views/DOMNodeDetailsSidebarPanel.css:
* UserInterface/Views/FilterBar.js:
(WI.FilterBar):
* UserInterface/Views/CSSStyleDetailsSidebarPanel.js:
(WI.CSSStyleDetailsSidebarPanel.prototype.initialLayout):
* UserInterface/Views/DebuggerSidebarPanel.js:
* UserInterface/Views/LogContentView.js:
(WI.LogContentView):
* UserInterface/Views/NetworkSidebarPanel.js:
(WI.NetworkSidebarPanel):
* UserInterface/Views/RecordingNavigationSidebarPanel.js:
(WI.RecordingNavigationSidebarPanel):
* UserInterface/Views/ResourceSidebarPanel.js:
(WI.ResourceSidebarPanel):
* UserInterface/Views/SearchSidebarPanel.js:
(WI.SearchSidebarPanel):
* UserInterface/Views/StorageSidebarPanel.js:
(WI.StorageSidebarPanel):
* UserInterface/Views/TimelineRecordingContentView.js:
(WI.TimelineRecordingContentView):
* Localizations/en.lproj/localizedStrings.js:
Replace placeholder text for all filter fields with "Filter".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoCrash under ServiceWorkerJob::failedWithException.
beidson@apple.com [Fri, 11 Aug 2017 20:37:51 +0000 (20:37 +0000)]
Crash under ServiceWorkerJob::failedWithException.
https://bugs.webkit.org/show_bug.cgi?id=175488

Reviewed by Tim Horton.

Covered by existing tests.

* workers/ServiceWorkerJob.cpp:
(WebCore::ServiceWorkerJob::failedWithException): jobDidFinish might cause the Job to be deleted, so make it last.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoDirectArguments should be in the JSValue gigacage
fpizlo@apple.com [Fri, 11 Aug 2017 20:08:33 +0000 (20:08 +0000)]
DirectArguments should be in the JSValue gigacage
https://bugs.webkit.org/show_bug.cgi?id=174920

Reviewed by Michael Saboff.

This puts DirectArguments in a new subspace for cells that want to be in the JSValue gigacage. All
indexed accesses to DirectArguments now do caging. get_from_arguments/put_to_arguments are exempted
because they always operate on a DirectArguments that is pointed to directly from the stack, they are
required to use fixed offsets, and you can only store JSValues.

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileGetByValOnDirectArguments):
* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileGetByVal):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emitDirectArgumentsGetByVal):
* runtime/DirectArguments.h:
(JSC::DirectArguments::subspaceFor):
(JSC::DirectArguments::storage):
* runtime/VM.cpp:
(JSC::VM::VM):
* runtime/VM.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoCreate mock ITP data in testing to prevent grandfathering
jbedard@apple.com [Fri, 11 Aug 2017 20:04:06 +0000 (20:04 +0000)]
Create mock ITP data in testing to prevent grandfathering
https://bugs.webkit.org/show_bug.cgi?id=174720

Unreviewed follow-up fix for r220604.

* WebKitTestRunner/cocoa/TestControllerCocoa.mm:
(WTR::TestController::cocoaPlatformInitialize): Release resourceLogPlist.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoCreate mock ITP data in testing to prevent grandfathering
jbedard@apple.com [Fri, 11 Aug 2017 17:30:46 +0000 (17:30 +0000)]
Create mock ITP data in testing to prevent grandfathering
https://bugs.webkit.org/show_bug.cgi?id=174720
<rdar://problem/33457779>

Reviewed by Brent Fulgham.

We don't need to be triggering grandfathering when each test runner starts. On Mac,
this may launch plugins which can cause layout tests to fail later if the test
runner does not shut-down before the plugins unload.

* WebKitTestRunner/TestController.h: Add declaration of cocoaPlatformInitialize.
* WebKitTestRunner/cocoa/TestControllerCocoa.mm:
(WTR::TestController::cocoaPlatformInitialize): Write the minimum data required to
prevent grandfathering from being triggered.
* WebKitTestRunner/ios/TestControllerIOS.mm:
(WTR::TestController::platformInitialize): Call cocoaPlatformInitialize.
* WebKitTestRunner/mac/TestControllerMac.mm:
(WTR::TestController::platformInitialize): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed, add a FIXME.
fpizlo@apple.com [Fri, 11 Aug 2017 17:26:59 +0000 (17:26 +0000)]
Unreviewed, add a FIXME.

* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::caged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWTF::Function does not allow for reference / non-default constructible return types
weinig@apple.com [Fri, 11 Aug 2017 16:56:37 +0000 (16:56 +0000)]
WTF::Function does not allow for reference / non-default constructible return types
https://bugs.webkit.org/show_bug.cgi?id=175244
Source/JavaScriptCore:

Reviewed by Chris Dumez.

* runtime/ArrayBuffer.cpp:
(JSC::ArrayBufferContents::transferTo):
Call reset(), rather than clear() to avoid the call to destroy() in clear(). The
destroy call needed to be a no-op anyway, since the data is being moved.

Source/WebCore:

Reviewed by Chris Dumez.

* bindings/js/JSCustomElementInterface.h:
(WebCore::JSCustomElementInterface::invokeCallback):
Update the default value for the addArguments parameter to be an empty lambda, rather than
default initialization, which leads to a null WTF::Function. This allows us to remove support
for calling null WTF::Function. No change in behavior.

Source/WebKit:

Reviewed by Chris Dumez.

* UIProcess/WebResourceLoadStatisticsStore.h:
Update the default value for the updateCookiePartitioningForDomainsHandler parameter to be an
empty lambda, rather than default initialization, which leads to a null WTF::Function. This allows
us to remove support for calling null WTF::Function. No change in behavior.

Source/WTF:

Reviewed by Chris Dumez.

When Function, then NoncopyableFunction, was templatized to allow non-void return values
in r201493, it maintained the behavior of being callable even if the Function was null.
To accomplish this, when null, the default construction of the return parameter was used.
This means Function can't be used with return types that are not default constructible,
such as reference types and Ref.

This behavior of returning something when null is surprising, as this is not how normal
functions behave, and not very useful. Instead, we now assert that the function is not
null when being called.

* wtf/Function.h:
(WTF::Function operator(...)):
Instead of allowing a null callable wrapper by returning the default construction of
the return type, assert that the wrapper is there when calling a Function.

Tools:

<rdar://problem/33801582>

Reviewed by Chris Dumez.

* TestWebKitAPI/Tests/WTF/Function.cpp:
(TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoGardening: fix CLoop build.
mark.lam@apple.com [Fri, 11 Aug 2017 16:54:45 +0000 (16:54 +0000)]
Gardening: fix CLoop build.
https://bugs.webkit.org/show_bug.cgi?id=175446
<rdar://problem/33836545>

Not reviewed.

* assembler/MacroAssemblerPrinter.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoDFG should do caging
fpizlo@apple.com [Fri, 11 Aug 2017 16:47:14 +0000 (16:47 +0000)]
DFG should do caging
https://bugs.webkit.org/show_bug.cgi?id=174918

Reviewed by Saam Barati.

Adds the appropriate cage() calls to the DFG, including a cageTypedArrayStorage() helper that does
the conditional caging with a watchpoint.

This might be a 1% SunSpider slow-down, but it's not clear.

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::cageTypedArrayStorage):
(JSC::DFG::SpeculativeJIT::compileGetIndexedPropertyStorage):
(JSC::DFG::SpeculativeJIT::compileGetTypedArrayByteOffset):
(JSC::DFG::SpeculativeJIT::compileCreateRest):
(JSC::DFG::SpeculativeJIT::compileSpread):
(JSC::DFG::SpeculativeJIT::compileNewArrayWithSpread):
(JSC::DFG::SpeculativeJIT::compileArraySlice):
(JSC::DFG::SpeculativeJIT::compileGetButterfly):
* dfg/DFGSpeculativeJIT.h:
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[CMake] Fix broken use of REQUIRED with find modules
annulen@yandex.ru [Fri, 11 Aug 2017 16:39:14 +0000 (16:39 +0000)]
[CMake] Fix broken use of REQUIRED with find modules
https://bugs.webkit.org/show_bug.cgi?id=175427

Reviewed by Michael Catanzaro.

Module name passed to find_package_handle_standard_args() must exactly
match file name of CMake find module including letter case, e.g. "WebP"
must be used in FindWebP.cmake file. Otherwise find_package() arguments
(REQUIRED, QUIET, version) are not processed correctly.

To continue using old XXX_FOUND variables without case changes porting
to new find_package_handle_standard_args syntax which has FOUND_VAR
parameter. Unfortunately, variable name GTK_UNIX_PRINT_FOUND is not
allowed by find_package_handle_standard_args when package name is
GTKUnixPrint, so it's replaced to GTKUnixPrint_FOUND (default).

* Source/cmake/FindGTKUnixPrint.cmake:
* Source/cmake/FindGeoClue2.cmake:
* Source/cmake/FindHyphen.cmake:
* Source/cmake/FindLibEpoxy.cmake:
* Source/cmake/FindLibGBM.cmake:
* Source/cmake/FindLibsecret.cmake:
* Source/cmake/FindLibtasn1.cmake:
* Source/cmake/FindLibxkbcommon.cmake:
* Source/cmake/FindOpenGL.cmake:
* Source/cmake/FindOpenGLES2.cmake:
* Source/cmake/FindOpenWebRTC.cmake:
* Source/cmake/FindWPEBackend-mesa.cmake:
* Source/cmake/FindWPEBackend.cmake:
* Source/cmake/FindWayland.cmake:
* Source/cmake/FindWebP.cmake:
* Source/cmake/OptionsGTK.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRemove RenderQuote collection from RenderView
antti@apple.com [Fri, 11 Aug 2017 16:22:44 +0000 (16:22 +0000)]
Remove RenderQuote collection from RenderView
https://bugs.webkit.org/show_bug.cgi?id=175479

Reviewed by Andreas Kling.

We can do it well enough without maintaining this pointer structure.

Global updating doesn't work well with future direction for first-letter and similar anyway.
We need to update quote immediately when updating its style.

* rendering/RenderQuote.cpp:
(WebCore::RenderQuote::insertedIntoTree):
(WebCore::RenderQuote::willBeRemovedFromTree):

    Just tell the view that there are renderers to update.

(WebCore::RenderQuote::styleDidChange):
(WebCore::RenderQuote::isOpen const):
(WebCore::RenderQuote::updateRenderer):
(WebCore::RenderQuote::updateRenderers): Deleted.

    Update single renderer only. RenderTreeUpdater provides the previous renderer to compute the depth.

* rendering/RenderQuote.h:
* rendering/RenderView.cpp:
(WebCore::RenderView::registerQuote): Deleted.
(WebCore::RenderView::unregisterQuote): Deleted.
(WebCore::RenderView::updateSpecialRenderers): Deleted.

    Remove the quote list.

* rendering/RenderView.h:
* style/RenderTreeUpdater.cpp:
(WebCore::RenderTreeUpdater::commit):

    Ensure that all quotes are updated.

(WebCore::RenderTreeUpdater::updateBeforeOrAfterPseudoElement):
(WebCore::RenderTreeUpdater::updateQuotesUpTo):

    Traverse render tree to find quotes to update starting from the previous updated quote.

* style/RenderTreeUpdater.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed, build fix for x86 GTK port
utatane.tea@gmail.com [Fri, 11 Aug 2017 15:44:38 +0000 (15:44 +0000)]
Unreviewed, build fix for x86 GTK port
https://bugs.webkit.org/show_bug.cgi?id=175446

Use pushfl/popfl instead of pushfd/popfd.

* assembler/MacroAssemblerX86Common.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[CMake] Many warning about missing “override” keywords in ANGLE with Clang
aperez@igalia.com [Fri, 11 Aug 2017 15:44:00 +0000 (15:44 +0000)]
[CMake] Many warning about missing “override” keywords in ANGLE with Clang
https://bugs.webkit.org/show_bug.cgi?id=175475

Reviewed by Michael Catanzaro.

* CMakeLists.txt: Add "-Wno-inconsistent-missing-override" to the
compiler flags using for building the ANGLE sources.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[GTK][WPE] Overriden virtual function not marked “override” in ImageBufferDataCairo.h
aperez@igalia.com [Fri, 11 Aug 2017 13:46:59 +0000 (13:46 +0000)]
[GTK][WPE] Overriden virtual function not marked “override” in ImageBufferDataCairo.h
https://bugs.webkit.org/show_bug.cgi?id=175476

Reviewed by Carlos Garcia Campos.

* platform/graphics/cairo/ImageBufferDataCairo.h: Add missing "override" qualifier.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[WPE] Build failure with Clang 4.0.1: no matching conversion for functional-style...
aperez@igalia.com [Fri, 11 Aug 2017 13:25:57 +0000 (13:25 +0000)]
[WPE] Build failure with Clang 4.0.1: no matching conversion for functional-style cast from 'pointer' (aka 'unsigned short *') to 'WTF::String'
https://bugs.webkit.org/show_bug.cgi?id=175477

Reviewed by Žan Doberšek.

* Shared/wpe/WebEventFactory.cpp:
(WebKit::singleCharacterStringForKeyEvent): Cast to UChar* to make
compiler choose the correct WTF::String constructor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoFix build warning in WebDriverService.h
clopez@igalia.com [Fri, 11 Aug 2017 12:28:21 +0000 (12:28 +0000)]
Fix build warning in WebDriverService.h
https://bugs.webkit.org/show_bug.cgi?id=166682

Unreviewed build fix.

* WebDriverService.h: Fixes the warning: class 'Capabilities' was previously declared as a struct [-Wmismatched-tags]

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[Soup] Cannot access HTTPS sites using a HTTP proxy that requires authentication
carlosgc@webkit.org [Fri, 11 Aug 2017 10:06:12 +0000 (10:06 +0000)]
[Soup] Cannot access HTTPS sites using a HTTP proxy that requires authentication
https://bugs.webkit.org/show_bug.cgi?id=175378

Reviewed by Sergio Villar Senin.

Source/WebCore:

Bring back part of the code removed in r206732, to keep a reference to the SoupMessage in the
AuthenticationChallenge since it can be different to the resource message.

* platform/network/soup/AuthenticationChallenge.h:
(WebCore::AuthenticationChallenge::AuthenticationChallenge): Deleted.
(WebCore::AuthenticationChallenge::authenticationClient const): Deleted.
(WebCore::AuthenticationChallenge::soupAuth const): Deleted.
(WebCore::AuthenticationChallenge::setProposedCredential): Deleted.
* platform/network/soup/AuthenticationChallengeSoup.cpp:
(WebCore::AuthenticationChallenge::AuthenticationChallenge):
(WebCore::AuthenticationChallenge::platformCompare):

Source/WebKit:

In case of HTTPS resource with a proxy, libsoup uses a tunnel internally, that uses its own SoupMessage during
the proxy authentication. We were ignoring authentication requests for other messages.

* NetworkProcess/soup/NetworkDataTaskSoup.cpp:
(WebKit::NetworkDataTaskSoup::authenticateCallback): Only return early if the message does't match and it's not
HTTPS resource over a proxy.
(WebKit::NetworkDataTaskSoup::authenticate): Use the soup message from the authentication challenge.
(WebKit::NetworkDataTaskSoup::continueAuthenticate): Ditto.

Tools:

Add two test cases to check proxy authentication.

* TestWebKitAPI/Tests/WebKitGLib/TestAuthentication.cpp:
(Tunnel::Tunnel):
(Tunnel::~Tunnel):
(Tunnel::connect):
(Tunnel::connected):
(serverCallback):
(ProxyAuthenticationTest::ProxyAuthenticationTest):
(ProxyAuthenticationTest::~ProxyAuthenticationTest):
(ProxyAuthenticationTest::proxyServerPortAsString):
(testWebViewAuthenticationProxy):
(testWebViewAuthenticationProxyHTTPS):
(beforeAll):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[GStreamer][GTK][WPE] Unify GStreamer JHBuild moduleset for both GTK+ and WPE
calvaris@igalia.com [Fri, 11 Aug 2017 08:15:40 +0000 (08:15 +0000)]
[GStreamer][GTK][WPE] Unify GStreamer JHBuild moduleset for both GTK+ and WPE
https://bugs.webkit.org/show_bug.cgi?id=175428

Both ports share the GStreamer code as multimedia backend and till
not so long they were using different versions. Now they do use
the same versions and it does not make any sense anymore (and
neither had sense before) to have differences in the modulesets.

In this patch I created a GStreamer moduleset and referenced it
from both GTK+'s and WPE's. GStreamer patches were also moved there.

Reviewed by Žan Doberšek.

* gstreamer/jhbuild.modules: Added.
* gstreamer/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch.
* gstreamer/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch.
* gstreamer/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch.
* gstreamer/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Renamed from Tools/gtk/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch.
* gstreamer/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Renamed from Tools/gtk/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch.
* gstreamer/patches/openh264-configure.patch: Renamed from Tools/gtk/patches/openh264-configure.patch.
* gtk/jhbuild.modules:
* wpe/jhbuild.modules:
* wpe/patches/gst-plugins-good-0003-rtpbin-receive-bundle-support.patch: Removed.
* wpe/patches/gst-plugins-good-0005-souphttpsrc-cookie-jar-and-context-query-support.patch: Removed.
* wpe/patches/gst-plugins-good-0006-qtdemux-add-context-for-a-preferred-protection.patch: Removed.
* wpe/patches/gst-plugins-good-0008-qtdemux-also-push-buffers-without-encryption-info-in.patch: Removed.
* wpe/patches/gstreamer-0001-protection-added-function-to-filter-system-ids.patch: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[Soup] Do not spawn the network process to setup cookie persistent storage
carlosgc@webkit.org [Fri, 11 Aug 2017 06:02:33 +0000 (06:02 +0000)]
[Soup] Do not spawn the network process to setup cookie persistent storage
https://bugs.webkit.org/show_bug.cgi?id=175424

Reviewed by Sergio Villar Senin.

The persistent storage configuration is saved and passed to network process as creation parameters, so we don't
need to spawn the network process to configure it, when it's created eventually it will use the configuration.

* UIProcess/soup/WebCookieManagerProxySoup.cpp:
(WebKit::WebCookieManagerProxy::setCookiePersistentStorage): Use sendToNetworkingProcess() instead of
endToNetworkingProcessRelaunchingIfNecessary().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[GTK][WPE] Assertion failure in TimerBase inside WebCore::IconRecord::setImageData
carlosgc@webkit.org [Fri, 11 Aug 2017 06:01:15 +0000 (06:01 +0000)]
[GTK][WPE] Assertion failure in TimerBase inside WebCore::IconRecord::setImageData
https://bugs.webkit.org/show_bug.cgi?id=173866
<rdar://problem/33122050>

Reviewed by Michael Catanzaro.

IconDatabase creates and destroys IconRecord objects in both database and main thread. If the IconRecord has a
valid icon, its Image could be created in one thread and destroyed in another, something that is not expected to
happen, because Image has a Timer member. Since we have all the data and we are decoding it right after creating
the Image, we don't really need to keep the Image object around, we could simply take a reference of the encoded
data and the decoded native image to be returned by synchronousIconForPageURL().

* UIProcess/API/glib/IconDatabase.cpp:
(WebKit::IconDatabase::IconRecord::image): Return NativeImagePtr now.
(WebKit::IconDatabase::IconRecord::setImageData): Create a BitmapImage to decode it and keep a reference to the
encoded data and decoded native image.
(WebKit::IconDatabase::IconRecord::snapshot const): Use m_imageData to get the encoded data.
(WebKit::IconDatabase::synchronousIconForPageURL): Return the native image and whether the icon is known or not.
(WebKit::IconDatabase::IconRecord::loadImageFromResource): Deleted.
* UIProcess/API/glib/IconDatabase.h:
* UIProcess/API/glib/WebKitFaviconDatabase.cpp:
(getIconSurfaceSynchronously): Use new API.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoMake the MASM_PROBE mechanism mandatory for DFG and FTL builds.
mark.lam@apple.com [Fri, 11 Aug 2017 05:31:32 +0000 (05:31 +0000)]
Make the MASM_PROBE mechanism mandatory for DFG and FTL builds.
https://bugs.webkit.org/show_bug.cgi?id=175446
<rdar://problem/33836545>

Reviewed by Saam Barati.

Source/JavaScriptCore:

* assembler/AbstractMacroAssembler.h:
* assembler/MacroAssembler.cpp:
(JSC::MacroAssembler::probe):
* assembler/MacroAssembler.h:
* assembler/MacroAssemblerARM.cpp:
(JSC::MacroAssembler::probe):
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::trustedImm32FromPtr):
* assembler/MacroAssemblerARM64.cpp:
(JSC::MacroAssembler::probe):
* assembler/MacroAssemblerARMv7.cpp:
(JSC::MacroAssembler::probe):
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::trustedImm32FromPtr):
* assembler/MacroAssemblerPrinter.cpp:
* assembler/MacroAssemblerPrinter.h:
* assembler/MacroAssemblerX86Common.cpp:
* assembler/testmasm.cpp:
(JSC::isSpecialGPR):
(JSC::testProbeModifiesProgramCounter):
(JSC::run):
* b3/B3LowerToAir.cpp:
(JSC::B3::Air::LowerToAir::print):
* b3/air/AirPrintSpecial.cpp:
* b3/air/AirPrintSpecial.h:

Source/WTF:

This is needed in order to support https://bugs.webkit.org/show_bug.cgi?id=174645.
One consequence of this is that the DFG will now be disabled for the MIPS and
Windows ports. See:
    https://bugs.webkit.org/show_bug.cgi?id=175447
    https://bugs.webkit.org/show_bug.cgi?id=175449

Also, we should only ENABLE_SIGNAL_BASED_VM_TRAPS if the DFG is enabled.  It was
never meaningful to use SIGNAL_BASED_VM_TRAPS with the baseline JIT anyway.  This
is a mis-configuration error that is now fixed.

* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRestored svn:ignore values that went missing when the project got renamed.
mitz@apple.com [Fri, 11 Aug 2017 04:47:06 +0000 (04:47 +0000)]
Restored svn:ignore values that went missing when the project got renamed.

Source/WebKit:

* WebKit.xcodeproj: Added property svn:ignore.

Source/WebKitLegacy:

* WebKitLegacy.xcodeproj: Added property svn:ignore.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoFixed building for macOS 10.12 with the macOS 10.13 SDK.
mitz@apple.com [Fri, 11 Aug 2017 04:22:59 +0000 (04:22 +0000)]
Fixed building for macOS 10.12 with the macOS 10.13 SDK.

Suppressed the unguarded-availability-new warning around uses of AVSampleBufferAudioRenderer
and AVSampleBufferRenderSynchronizer. Even though the 10.13 SDK declares them as available
starting in that release, they have been available as SPI earlier.

* platform/graphics/avfoundation/objc/CDMSessionMediaSourceAVFObjC.h:
* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.h:
* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::setHasAvailableAudioSample):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::addAudioRenderer):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::removeAudioRenderer):
* platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.h:
* platform/graphics/avfoundation/objc/SourceBufferPrivateAVFObjC.mm:
(-[WebAVSampleBufferErrorListener beginObservingRenderer:]):
(-[WebAVSampleBufferErrorListener stopObservingRenderer:]):
(-[WebAVSampleBufferErrorListener observeValueForKeyPath:ofObject:change:context:]):
(WebCore::SourceBufferPrivateAVFObjC::trackDidChangeEnabled):
(WebCore::SourceBufferPrivateAVFObjC::rendererDidReceiveError):
(WebCore::SourceBufferPrivateAVFObjC::flush):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWeb Inspector: Add three.js in preparation for layer visualization.
commit-queue@webkit.org [Fri, 11 Aug 2017 03:06:56 +0000 (03:06 +0000)]
Web Inspector: Add three.js in preparation for layer visualization.
https://bugs.webkit.org/show_bug.cgi?id=174798

Patch by Ross Kirsling <ross.kirsling@sony.com> on 2017-08-10
Reviewed by Brian Burg.

* UserInterface/External/three.js/LICENSE: Added.
* UserInterface/External/three.js/OrbitControls.js: Added.
* UserInterface/External/three.js/three.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRename the source files for the WTF persistent coders.
beidson@apple.com [Fri, 11 Aug 2017 02:59:06 +0000 (02:59 +0000)]
Rename the source files for the WTF persistent coders.
https://bugs.webkit.org/show_bug.cgi?id=175441

Reviewed by Tim Horton.

Source/WebCore:

* platform/network/NetworkLoadMetrics.h:

Source/WebKit:

* NetworkProcess/cache/NetworkCacheCoders.h:
* NetworkProcess/cache/NetworkCacheKey.cpp:
* NetworkProcess/cache/NetworkCacheKey.h:
* UIProcess/API/APIContentRuleListStore.cpp:

Source/WTF:

* WTF.xcodeproj/project.pbxproj:
* wtf/CMakeLists.txt:

* wtf/persistence/PersistentCoder.h: Renamed from Source/WTF/wtf/persistence/Coder.h.
* wtf/persistence/PersistentCoders.cpp: Renamed from Source/WTF/wtf/persistence/Coders.cpp.
* wtf/persistence/PersistentCoders.h: Renamed from Source/WTF/wtf/persistence/Coders.h.
* wtf/persistence/PersistentDecoder.cpp: Renamed from Source/WTF/wtf/persistence/Decoder.cpp.
* wtf/persistence/PersistentDecoder.h: Renamed from Source/WTF/wtf/persistence/Decoder.h.
* wtf/persistence/PersistentEncoder.cpp: Renamed from Source/WTF/wtf/persistence/Encoder.cpp.
* wtf/persistence/PersistentEncoder.h: Renamed from Source/WTF/wtf/persistence/Encoder.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed, adding Ross Kirsling to contributors.json\n\n* Scripts/webkitpy/common...
don.olmstead@sony.com [Fri, 11 Aug 2017 02:17:10 +0000 (02:17 +0000)]
Unreviewed, adding Ross Kirsling to contributors.json\n\n* Scripts/webkitpy/common/config/contributors.json:\n

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoResource Load Statistics: Increase grandfathering time to 7 days
wilander@apple.com [Fri, 11 Aug 2017 01:47:03 +0000 (01:47 +0000)]
Resource Load Statistics: Increase grandfathering time to 7 days
https://bugs.webkit.org/show_bug.cgi?id=175414
<rdar://problem/33818046>

Reviewed by Brent Fulgham.

* UIProcess/WebResourceLoadStatisticsStore.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoLayout test accessibility/press-target-uses-text-descendant-node.html is flaky.
n_wang@apple.com [Fri, 11 Aug 2017 01:41:56 +0000 (01:41 +0000)]
Layout test accessibility/press-target-uses-text-descendant-node.html is flaky.
https://bugs.webkit.org/show_bug.cgi?id=175272
<rdar://problem/33756962>

Since accessibilityPress is async, we shouldn't rely on the timeout.

Reviewed by Chris Fleizach.

* accessibility/press-target-uses-text-descendant-node.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoMake ThreadGlobalData RefCounted for web thread
utatane.tea@gmail.com [Fri, 11 Aug 2017 00:41:53 +0000 (00:41 +0000)]
Make ThreadGlobalData RefCounted for web thread
https://bugs.webkit.org/show_bug.cgi?id=175439

Reviewed by Mark Lam.

When the web thread is enabled, we share ThreadGlobalData between the web thread and the main thread.
The problem happens when the main thread is dying. It could start deallocating TLS and the web
thread may see the destructed ThreadGlobalData.

Even though, the current implementation is safe because the main thread do not perform TLS deallocation
in the Darwin environment. But this is not true in Windows. And we should not rely on this condition
that depends on the platforms.

In this patch, we make ThreadGlobalData ThreadSafeRefCounted. This type verbosely describes that
ThreadGlobalData could be shared between threads when the web thread enabled. And make the life time
management simple instead of relying on the platform dependent TLS implementation.

* platform/ThreadGlobalData.cpp:
(WebCore::ThreadGlobalData::setWebCoreThreadData):
(WebCore::threadGlobalData):
* platform/ThreadGlobalData.h:
(WebCore::ThreadGlobalData::cachedResourceRequestInitiators): Deleted.
(WebCore::ThreadGlobalData::eventNames): Deleted.
(WebCore::ThreadGlobalData::threadTimers): Deleted.
(WebCore::ThreadGlobalData::qualifiedNameCache): Deleted.
(WebCore::ThreadGlobalData::cachedConverterICU): Deleted.
(WebCore::ThreadGlobalData::cachedConverterTEC): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoResource Load Statistics: Add significant figures to telemetry calls
wilander@apple.com [Fri, 11 Aug 2017 00:41:09 +0000 (00:41 +0000)]
Resource Load Statistics: Add significant figures to telemetry calls
https://bugs.webkit.org/show_bug.cgi?id=175442
<rdar://problem/33834834>

Reviewed by Brent Fulgham.

With this change, logged values are allowed to have 3 significant figures
as opposed to today's 0 which is wrong.

* UIProcess/WebResourceLoadStatisticsTelemetry.cpp:
(WebKit::submitTopList):
(WebKit::WebResourceLoadStatisticsTelemetry::calculateAndSubmit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed, attempt to fix build failure with VC2017
utatane.tea@gmail.com [Fri, 11 Aug 2017 00:36:24 +0000 (00:36 +0000)]
Unreviewed, attempt to fix build failure with VC2017

Source/WTF:

* wtf/PriorityQueue.h:

Tools:

* TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:
(TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[JSC] Use @toNumber in builtins
utatane.tea@gmail.com [Fri, 11 Aug 2017 00:36:23 +0000 (00:36 +0000)]
[JSC] Use @toNumber in builtins
https://bugs.webkit.org/show_bug.cgi?id=172692

Reviewed by Sam Weinig.

Use @toNumber bytecode intrinsic. It emits op_to_number, which efficiently converts
a given argument to a number.

* Modules/streams/ReadableByteStreamInternals.js:
(privateInitializeReadableByteStreamController):
(readableByteStreamControllerRespond):
* Modules/streams/StreamInternals.js:
(validateAndNormalizeQueuingStrategy):
(enqueueValueWithSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed, suppress warnings on GCC
utatane.tea@gmail.com [Fri, 11 Aug 2017 00:29:03 +0000 (00:29 +0000)]
Unreviewed, suppress warnings on GCC

* TestWebKitAPI/Tests/WTF/CheckedArithmeticOperations.cpp:
(TestWebKitAPI::CheckedArithmeticTester::run):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[Xcode] With Xcode 9 developer beta, everything rebuilds when switching between comma...
mitz@apple.com [Thu, 10 Aug 2017 23:57:47 +0000 (23:57 +0000)]
[Xcode] With Xcode 9 developer beta, everything rebuilds when switching between command-line and IDE
https://bugs.webkit.org/show_bug.cgi?id=173223

Reviewed by Tim Horton.

The rebuilds were happening due to a difference in the compiler options that the IDE and
xcodebuild were specifying. Only the IDE was passing the -index-store-path option. To make
xcodebuild pass that option, too, set INDEX_ENABLE_DATA_STORE to YES and
INDEX_DATA_STORE_DIR to the Index Datastore path specified in Xcode Locations preferences >
Advanced when a Custom Absolute path is selected.

* Scripts/webkitdirs.pm:
(determineBaseProductDir):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRun more WTF tests
utatane.tea@gmail.com [Thu, 10 Aug 2017 23:42:14 +0000 (23:42 +0000)]
Run more WTF tests
https://bugs.webkit.org/show_bug.cgi?id=174970

Reviewed by Michael Catanzaro.

Source/WTF:

CHAR_BIT is not defined.

* wtf/LEBDecoder.h:

Tools:

Some of WTF tests are not executed in non Apple ports while they are generic ones.
This patch adds these tests to non-Apple port TestWebKitAPI.
Currently, we do not add Signals.cpp since it depends on signal functionality.

* TestWebKitAPI/CMakeLists.txt:
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WTF/PriorityQueue.cpp:
(isHigherPriority):
(TEST):
* TestWebKitAPI/Tests/WTF/Signals.cpp: Copied from Tools/TestWebKitAPI/Tests/WTF/ThreadMessages.cpp.
(TEST):
* TestWebKitAPI/Tests/WTF/ThreadMessages.cpp:
(TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoApply the UNLIKELY macro to some unlikely things.
mark.lam@apple.com [Thu, 10 Aug 2017 23:00:06 +0000 (23:00 +0000)]
Apply the UNLIKELY macro to some unlikely things.
https://bugs.webkit.org/show_bug.cgi?id=175440
<rdar://problem/33834767>

Reviewed by Yusuke Suzuki.

Source/JavaScriptCore:

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::~CodeBlock):
(JSC::CodeBlock::jettison):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleVarargsCall):
(JSC::DFG::ByteCodeParser::handleGetById):
(JSC::DFG::ByteCodeParser::handlePutById):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::parseCodeBlock):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::JITCompiler):
(JSC::DFG::JITCompiler::linkOSRExits):
(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::disassemble):
* dfg/DFGJITFinalizer.cpp:
(JSC::DFG::JITFinalizer::finalizeCommon):
* dfg/DFGOSRExit.cpp:
(JSC::DFG::OSRExit::compileOSRExit):
* dfg/DFGPlan.cpp:
(JSC::DFG::Plan::Plan):
* ftl/FTLJITFinalizer.cpp:
(JSC::FTL::JITFinalizer::finalizeCommon):
* ftl/FTLLink.cpp:
(JSC::FTL::link):
* ftl/FTLOSRExitCompiler.cpp:
(JSC::FTL::compileStub):
* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
(JSC::JIT::compileWithoutLinking):
(JSC::JIT::link):
* runtime/ScriptExecutable.cpp:
(JSC::ScriptExecutable::installCode):
* runtime/VM.cpp:
(JSC::VM::VM):

Source/WebKit:

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::getBytecodeProfile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed test gardening for High Sierra.
ryanhaddad@apple.com [Thu, 10 Aug 2017 22:57:33 +0000 (22:57 +0000)]
Unreviewed test gardening for High Sierra.

* platform/mac-highsierra/css1/basic/inheritance-expected.txt: Added.
* platform/mac-highsierra/css2.1/t0602-c13-inh-underlin-00-e-expected.txt: Added.
* platform/mac-highsierra/css2.1/t0805-c5522-brdr-02-e-expected.txt: Added.
* platform/mac-highsierra/css3/selectors3/html/css3-modsel-18-expected.txt: Added.
* platform/mac-highsierra/css3/selectors3/xhtml/css3-modsel-18-expected.txt: Added.
* platform/mac-highsierra/css3/selectors3/xml/css3-modsel-18-expected.txt: Added.
* platform/mac-highsierra/fast/block/basic/001-expected.txt: Added.
* platform/mac-highsierra/fast/css-generated-content/initial-letter-basic-expected.txt: Added.
* platform/mac-highsierra/fast/css-generated-content/initial-letter-border-padding-expected.txt: Added.
* platform/mac-highsierra/fast/css-generated-content/initial-letter-raised-expected.txt: Added.
* platform/mac-highsierra/fast/css-generated-content/initial-letter-sunken-expected.txt: Added.
* platform/mac-highsierra/fast/css/css3-nth-child-expected.txt: Added.
* platform/mac-highsierra/fast/css/text-overflow-input-expected.txt: Added.
* platform/mac-highsierra/fast/dom/34176-expected.txt: Added.
* platform/mac-highsierra/fast/dom/clone-node-dynamic-style-expected.txt: Added.
* platform/mac-highsierra/fast/forms/basic-inputs-expected.txt: Added.
* platform/mac-highsierra/fast/forms/input-value-expected.txt: Added.
* platform/mac-highsierra/fast/forms/plaintext-mode-2-expected.txt: Added.
* platform/mac-highsierra/fast/invalid/003-expected.txt: Added.
* platform/mac-highsierra/fast/invalid/004-expected.txt: Added.
* platform/mac-highsierra/fast/invalid/nestedh3s-expected.txt: Added.
* platform/mac-highsierra/fast/selectors/018-expected.txt: Added.
* platform/mac-highsierra/fast/table/frame-and-rules-expected.txt: Added.
* platform/mac-highsierra/fast/text/atsui-multiple-renderers-expected.txt: Added.
* platform/mac-highsierra/fast/text/bidi-embedding-pop-and-push-same-expected.txt: Added.
* platform/mac-highsierra/fast/text/font-weights-expected.txt: Added.
* platform/mac-highsierra/fast/text/font-weights-zh-expected.txt: Added.
* platform/mac-highsierra/fast/text/indic-expected.txt: Added.
* platform/mac-highsierra/fast/text/international/complex-character-based-fallback-expected.txt:
* platform/mac-highsierra/svg/W3C-SVG-1.1/animate-elem-46-t-expected.txt: Added.
* platform/mac-highsierra/svg/W3C-SVG-1.1/struct-use-01-t-expected.txt: Added.
* platform/mac-highsierra/svg/batik/text/textStyles-expected.txt: Added.
* platform/mac-highsierra/tables/mozilla/other/wa_table_thtd_rowspan-expected.txt: Added.
* platform/mac-highsierra/tables/mozilla/other/wa_table_tr_align-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoTurn on support for Beacon API by default in STP
cdumez@apple.com [Thu, 10 Aug 2017 22:42:29 +0000 (22:42 +0000)]
Turn on support for Beacon API by default in STP
https://bugs.webkit.org/show_bug.cgi?id=175445
<rdar://problem/33836379>

Reviewed by Youenn Fablet.

* Shared/WebPreferencesDefinitions.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoAX: crash at WebCore::AccessibilityObject::supportsARIALiveRegion() const + 24
n_wang@apple.com [Thu, 10 Aug 2017 22:15:49 +0000 (22:15 +0000)]
AX: crash at WebCore::AccessibilityObject::supportsARIALiveRegion() const + 24
https://bugs.webkit.org/show_bug.cgi?id=175340
<rdar://problem/33782159>

Reviewed by Chris Fleizach.

Source/WebCore:

The issue here is that we manualy set the parent object of the AccessibilitySVGRoot object
and there are chances that the parent doesn't detach it properly during the parent's destroying
process. Accessing the stale parent object will lead to a crash.
Fixed this by making the parent object a weak pointer so we don't access an invalid memory.

Test: accessibility/add-children-pseudo-element.html

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::AccessibilityRenderObject):
* accessibility/AccessibilityRenderObject.h:
(WebCore::AccessibilityRenderObject::createWeakPtr):
* accessibility/AccessibilitySVGRoot.cpp:
(WebCore::AccessibilitySVGRoot::AccessibilitySVGRoot):
(WebCore::AccessibilitySVGRoot::setParent):
(WebCore::AccessibilitySVGRoot::parentObject const):
* accessibility/AccessibilitySVGRoot.h:

LayoutTests:

* accessibility/add-children-pseudo-element-expected.txt: Added.
* accessibility/add-children-pseudo-element.html: Added.
* accessibility/resources/svg-circle.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoFix iOS simulator build after change "[WTF] Move TextStream into WTF"
ryanhaddad@apple.com [Thu, 10 Aug 2017 22:08:34 +0000 (22:08 +0000)]
Fix iOS simulator build after change "[WTF] Move TextStream into WTF"
https://bugs.webkit.org/show_bug.cgi?id=175211

Patch by Ross Kirsling <ross.kirsling@sony.com> on 2017-08-10
Reviewed by Myles C. Maxfield.

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _scrollByContentOffset:]):
(-[WKWebView _navigationGestureDidBegin]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[Beacon] Do connect-src CSP check on redirects as well
cdumez@apple.com [Thu, 10 Aug 2017 21:51:15 +0000 (21:51 +0000)]
[Beacon] Do connect-src CSP check on redirects as well
https://bugs.webkit.org/show_bug.cgi?id=175410
<rdar://problem/33815470>

Reviewed by Youenn Fablet.

Source/WebCore:

Pass ContentSecurityPolicy object to createPingHandle so that we can send
enough data to the NetworkProcess so do CSP checks for Ping loads such
as Beacon. For the IPC, we serialize the ContentSecurityPolicy's response
headers. Those headers are now cached in ContentSecurityPolicy for
performance reasons. CSP headers are rarely updated in practice but
sendBeacon() may get called repeatedly for a given document.

Tests: http/wpt/beacon/connect-src-beacon-redirect-allowed.sub.html
       http/wpt/beacon/connect-src-beacon-redirect-blocked.sub.html

* loader/LoaderStrategy.h:
* loader/PingLoader.cpp:
(WebCore::PingLoader::loadImage):
(WebCore::PingLoader::sendPing):
(WebCore::PingLoader::sendViolationReport):
(WebCore::PingLoader::startPingLoad):
* loader/PingLoader.h:
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::load):
* page/csp/ContentSecurityPolicy.cpp:
(WebCore::ContentSecurityPolicy::responseHeaders const):
(WebCore::ContentSecurityPolicy::didReceiveHeader):
* page/csp/ContentSecurityPolicy.h:
* page/csp/ContentSecurityPolicyResponseHeaders.h:
(WebCore::ContentSecurityPolicyResponseHeaders::encode const):
(WebCore::ContentSecurityPolicyResponseHeaders::decode):

Source/WebKit:

Pass CSP Response headers to the NetworkProcess via NetworkResourceLoadParameters
when doing a PingLoad. This allows PingLoad to do CSP checks (in particular
connect-src ones) in case the ping load gets redirected. Those checks need to be
done on the NetworkProcess side at this point because there is no guarantee the
WebContent process is still around.

To do the CSP checks, PingLoad lazily reconstructs a ContentSecurityPolicy object
from the CSP response headers.

* NetworkProcess/NetworkResourceLoadParameters.cpp:
(WebKit::NetworkResourceLoadParameters::encode const):
(WebKit::NetworkResourceLoadParameters::decode):
* NetworkProcess/NetworkResourceLoadParameters.h:
* NetworkProcess/PingLoad.cpp:
(WebKit::PingLoad::willPerformHTTPRedirection):
(WebKit::PingLoad::contentSecurityPolicy):
* NetworkProcess/PingLoad.h:
* WebProcess/Network/WebLoaderStrategy.cpp:
(WebKit::WebLoaderStrategy::createPingHandle):
* WebProcess/Network/WebLoaderStrategy.h:

Source/WebKitLegacy:

Update createPingHandle() to take in ContentSecurityPolicy
object in but no behavior change for WK1.

* WebCoreSupport/WebResourceLoadScheduler.cpp:
(WebResourceLoadScheduler::createPingHandle):
* WebCoreSupport/WebResourceLoadScheduler.h:

LayoutTests:

Add layout test coverage.

* http/wpt/beacon/connect-src-beacon-redirect-allowed.sub-expected.txt: Added.
* http/wpt/beacon/connect-src-beacon-redirect-allowed.sub.html: Added.
* http/wpt/beacon/connect-src-beacon-redirect-blocked.sub-expected.txt: Added.
* http/wpt/beacon/connect-src-beacon-redirect-blocked.sub.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[WTF] ThreadSpecific should not introduce additional indirection
utatane.tea@gmail.com [Thu, 10 Aug 2017 21:19:51 +0000 (21:19 +0000)]
[WTF] ThreadSpecific should not introduce additional indirection
https://bugs.webkit.org/show_bug.cgi?id=175187

Reviewed by Mark Lam.

Source/JavaScriptCore:

* runtime/Identifier.cpp:

Source/WebCore:

We drop ThreadSpecific::replace feature which is only used by
Web thread. Instead, we use ThreadSpecific<std::unique_ptr<T>> here.

While this std::unique_ptr<T> shares one instance between main thread
and web thread, this is the same to the current implementation. It is
safe because the web thread never finishes.

And for non-web thread implementation, we just use ThreadSpecific<T>,
since it is the most efficient.

* platform/ThreadGlobalData.cpp:
(WebCore::ThreadGlobalData::ThreadGlobalData):
(WebCore::ThreadGlobalData::setWebCoreThreadData):
(WebCore::threadGlobalData):
We also drop StringImpl::empty() call since it is not necessary now:
StringImpl::empty data is statically initialized by using constexpr.

* platform/ThreadGlobalData.h:
We make it FAST_ALLOCATED since it is previously allocated by fast malloc
in ThreadSpecific.

Source/WTF:

ThreadSpecific sets Data* to the TLS. And Data holds T*, which
is fast allocated actual data. But ideally, we should store T
instance directly in Data instead of introducing an additional
indirection.

This patch adds storage in Data in order to embed the instance of T. The constructor
for Data will invoke the constructor for T on the embedded storage. We also drop
ThreadSpecific::replace which is only used by the web thread to set its thread specific
ThreadGlobalData to the one shared from the main thread. The existing implementation
relies on the main thread and the web thread never exiting in order for the shared
ThreadGlobalData to stay alive. We can achieve the same semantics by using a
ThreadSpecific<std::unique_ptr<T>> to hold the ThreadGlobalData instance instead.

* wtf/ThreadSpecific.h:
(WTF::ThreadSpecific::Data::construct):
(WTF::ThreadSpecific::Data::Data):
We make it fast allocated since we previously allocated ThreadSpecific T data by fastMalloc.

(WTF::ThreadSpecific::Data::~Data):
(WTF::ThreadSpecific::Data::storagePointer const):
(WTF::canBeGCThread>::get):
We also drop RELEASE_ASSERT from ::get(). We already inserted this assert to setAndConstruct(),
so when creating the member to this TLS, we execute this release assert. So it is
not necessary to execute this assertion every time we get data from this TLS.

(WTF::canBeGCThread>::set):
(WTF::canBeGCThread>::destroy):
(WTF::canBeGCThread>::setAndConstruct):
(WTF::T):
(WTF::canBeGCThread>::replace): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRemove obsolete link from webkit-queues status page
commit-queue@webkit.org [Thu, 10 Aug 2017 20:49:01 +0000 (20:49 +0000)]
Remove obsolete link from webkit-queues status page
https://bugs.webkit.org/show_bug.cgi?id=175337

Patch by obinna obike <oobike@apple.com> on 2017-08-10
Reviewed by Aakash Jain.

* QueueStatusServer/templates/recentstatus.html:
Removed the link to the ews-watcher server.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoMark webgl/webgl-box-shadow.html and webgl/webgl-border.html as failing for ios-device.
jbedard@apple.com [Thu, 10 Aug 2017 20:47:16 +0000 (20:47 +0000)]
Mark webgl/webgl-box-shadow.html and webgl/webgl-border.html as failing for ios-device.
https://bugs.webkit.org/show_bug.cgi?id=175437

Unreviewed test gardening.

* platform/ios-device/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWKPreferences should conform to NSCopying
bburg@apple.com [Thu, 10 Aug 2017 20:34:40 +0000 (20:34 +0000)]
WKPreferences should conform to NSCopying
https://bugs.webkit.org/show_bug.cgi?id=175303
<rdar://problem/33764939>

Reviewed by Dan Bernstein.

Source/WebKit:

* UIProcess/API/Cocoa/WKPreferencesPrivate.h:
Add conformance in the private header, as there is not consensus that this
needs to be API.

* UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences copyWithZone:]):
Copy the wrapped WebPreferences instance and return its wrapper.

Tools:

Add unit test to make sure a WKPreference and its copy are
not aliased to each other or affect each other's properties.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKit2Cocoa/Copying.mm: Added.
(TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoFix a silly typo in Compiler.h
timothy_horton@apple.com [Thu, 10 Aug 2017 19:39:28 +0000 (19:39 +0000)]
Fix a silly typo in Compiler.h

* wtf/Compiler.h:
Heature, indeed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoREGRESSION(r220515) [GTK][CMake] Build with ENABLE_GEOLOCATION fails on Debian Jessie
mcatanzaro@igalia.com [Thu, 10 Aug 2017 19:31:53 +0000 (19:31 +0000)]
REGRESSION(r220515) [GTK][CMake] Build with ENABLE_GEOLOCATION fails on Debian Jessie
https://bugs.webkit.org/show_bug.cgi?id=175426

Reviewed by Carlos Alberto Lopez Perez.

.:

* Source/cmake/FindGeoClue2.cmake:

Source/WebCore:

Also stop using GEOCLUE_LIBRARIES and GEOCLUE_INCLUDE_DIRS, since they are empty. Apparently
we have not actually been using the client library at all this whole time, only the D-Bus
interface.

* PlatformGTK.cmake:

Source/WebKit:

* PlatformGTK.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoAdd ServiceWorkerJob.
beidson@apple.com [Thu, 10 Aug 2017 19:28:26 +0000 (19:28 +0000)]
Add ServiceWorkerJob.
https://bugs.webkit.org/show_bug.cgi?id=175241

Reviewed by Tim Horton.

Source/WebCore:

Test: http/tests/workers/service/basic-register.html

This patch does a few things:
- Adds the spec concept of a ServiceWorkerJob (in the WebProcess, at least)
- Adds a ServiceWorkerProvider interface for WebKit to implement
- Actually creates a job for service worker registration and "schedules" it,
  though it always immediately errors out the promise.

Actually queuing jobs and executing asynchronously is coming up soon.

* CMakeLists.txt:
* WebCore.xcodeproj/project.pbxproj:

* dom/Document.cpp:
(WebCore::Document::sessionID const):
* dom/Document.h:

* workers/ServiceWorkerContainer.cpp:
(WebCore::ServiceWorkerContainer::~ServiceWorkerContainer):
(WebCore::ServiceWorkerContainer::addRegistration):
(WebCore::ServiceWorkerContainer::scheduleJob):
(WebCore::ServiceWorkerContainer::jobDidFinish):
* workers/ServiceWorkerContainer.h:

* workers/ServiceWorkerJob.cpp: Added.
(WebCore::ServiceWorkerJob::ServiceWorkerJob):
(WebCore::ServiceWorkerJob::~ServiceWorkerJob):
(WebCore::ServiceWorkerJob::failedWithException):
* workers/ServiceWorkerJob.h: Copied from Source/WebCore/workers/ServiceWorkerContainer.h.
(WebCore::ServiceWorkerJob::createRegisterJob):
(WebCore::ServiceWorkerJob::identifier const):

* workers/ServiceWorkerJobClient.h: Added.
(WebCore::ServiceWorkerJobClient::~ServiceWorkerJobClient):

* workers/ServiceWorkerProvider.cpp: Added.
(WebCore::ServiceWorkerProvider::singleton):
(WebCore::ServiceWorkerProvider::setSharedProvider):
* workers/ServiceWorkerProvider.h: Added.
* workers/ServiceWorkerRegistrationOptions.h: Copied from Source/WebCore/workers/ServiceWorkerContainer.h.
* workers/ServiceWorkerRegistrationParameters.cpp: Added.
* workers/ServiceWorkerRegistrationParameters.h: Added.

Source/WebKit:

* CMakeLists.txt:
* WebKit.xcodeproj/project.pbxproj:

* WebProcess/Storage/WebServiceWorkerProvider.cpp: Added.
(WebKit::WebServiceWorkerProvider::singleton):
(WebKit::WebServiceWorkerProvider::WebServiceWorkerProvider):
(WebKit::WebServiceWorkerProvider::scheduleJob):
* WebProcess/Storage/WebServiceWorkerProvider.h: Added.

* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):

LayoutTests:

Verifies that the "serviceWorker.register()" job we currently schedule fails as expected.

* http/tests/workers/service/basic-register-expected.txt: Added.
* http/tests/workers/service/basic-register.html: Added.
* http/tests/workers/service/resources/basic-register.js: Added.
* http/tests/workers/service/resources/empty-worker.js: Added.
* platform/mac-wk1/TestExpectations:
* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRemove some unused lambda captures so that WebKit builds with -Wunused-lambda-capture
timothy_horton@apple.com [Thu, 10 Aug 2017 19:05:51 +0000 (19:05 +0000)]
Remove some unused lambda captures so that WebKit builds with -Wunused-lambda-capture
https://bugs.webkit.org/show_bug.cgi?id=175436
<rdar://problem/33667497>

Reviewed by Simon Fraser.

Source/JavaScriptCore:

* interpreter/Interpreter.cpp:
(JSC::Interpreter::Interpreter):

Source/WebCore:

* platform/audio/cocoa/MediaSessionManagerCocoa.cpp:
(PlatformMediaSessionManager::updateSessionState):
* platform/graphics/cocoa/WebCoreDecompressionSession.mm:
(WebCore::WebCoreDecompressionSession::handleDecompressionOutput):

Source/WebKit:

* UIProcess/UserMediaPermissionRequestManagerProxy.cpp:
(WebKit::UserMediaPermissionRequestManagerProxy::requestUserMediaPermissionForFrame):
* UIProcess/WebsiteData/WebsiteDataStore.cpp:
(WebKit::WebsiteDataStore::topPrivatelyControlledDomainsWithWebsiteData):

Tools:

* TestWebKitAPI/Tests/WebCore/FileMonitor.cpp:
(TestWebKitAPI::TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoFix duplicated code from r220534.
lforschler@apple.com [Thu, 10 Aug 2017 18:57:22 +0000 (18:57 +0000)]
Fix duplicated code from r220534.

Unreviewed cleanup.

* Scripts/bisect-builds:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[WebCrypto] Enable SerializedCryptoKeyWrapTest in iOS
jiewen_tan@apple.com [Thu, 10 Aug 2017 18:47:56 +0000 (18:47 +0000)]
[WebCrypto] Enable SerializedCryptoKeyWrapTest in iOS
https://bugs.webkit.org/show_bug.cgi?id=175344
<rdar://problem/28507240>

Reviewed by Alexey Proskuryakov.

Add entitlements to TestWebKitAPI project for iOS. Then add Keychain Access entitlement to the project.
Finally enable the existing tests for iOS.

* TestWebKitAPI/Configurations/TestWebKitAPI-iOS.entitlements: Added.
* TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebCore/cocoa/SerializedCryptoKeyWrap.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed, rolling out r220463.
commit-queue@webkit.org [Thu, 10 Aug 2017 18:27:01 +0000 (18:27 +0000)]
Unreviewed, rolling out r220463.
https://bugs.webkit.org/show_bug.cgi?id=175435

unaccepted fix (Requested by n_wang on #webkit).

Reverted changeset:

"AX: crash at
WebCore::AccessibilityObject::supportsARIALiveRegion() const +
24"
https://bugs.webkit.org/show_bug.cgi?id=175340
http://trac.webkit.org/changeset/220463

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWrite a tool to bisect WebKit builds
lforschler@apple.com [Thu, 10 Aug 2017 18:22:01 +0000 (18:22 +0000)]
Write a tool to bisect WebKit builds
https://bugs.webkit.org/show_bug.cgi?id=174596

Reviewed by Dean Johnson and Kocsen Chung.

* Scripts/bisect-builds: Added.
(bisect_builds): main bisection algorithm
(download_archive):download an archive from S3 using existing tools
(extract_archive):extract an archive using existing tools
(find_le):Find rightmost value less than or equal to x
(find_ge):Find leftmost item greater than or equal to x
(get_api_url):generate url for the rest api/database
(get_indices_from_revisions):convert revisions to list indexes for bisection
(get_sorted_revisions):retrieve sorted revision list
(get_s3_location_for_revision):calculate the S3 archive storage location
(parse_args):parse command line arguments
(pick_next_build):compute the next build to bisect
(prompt_did_reproduce):prompt user for direction for bisection
(set_webkit_output_dir):set the folder for bisected builds to avoid overwriting engineering build output
(test_archive):Platform specific logic to test downloaded archive
(minified_platforms):return a list of minified platforms in the database
(unminified_platforms):return a list of full platforms in the database
(is_supported_platform):check if platform is supported
(validate_options):validate command line options
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRemove bisect-builds script.
lforschler@apple.com [Thu, 10 Aug 2017 18:17:07 +0000 (18:17 +0000)]
Remove bisect-builds script.
https://bugs.webkit.org/show_bug.cgi?id=175433

Reviewed by Aakash Jain.

* Scripts/bisect-builds: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRemove ENABLE_GAMEPAD_DEPRECATED
mcatanzaro@igalia.com [Thu, 10 Aug 2017 17:04:46 +0000 (17:04 +0000)]
Remove ENABLE_GAMEPAD_DEPRECATED
https://bugs.webkit.org/show_bug.cgi?id=175361

Reviewed by Carlos Garcia Campos.

.:

* Source/cmake/FindGUdev.cmake: Removed.
* Source/cmake/OptionsGTK.cmake:
* Source/cmake/OptionsMac.cmake:
* Source/cmake/WebKitFeatures.cmake:

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

* CMakeLists.txt:
* Configurations/FeatureDefines.xcconfig:
* PlatformGTK.cmake:
* PlatformWPE.cmake:
* platform/Linux.cmake: Removed.
* platform/gamepad/deprecated/Gamepads.h: Removed.
* platform/gamepad/glib/GamepadsGlib.cpp: Removed.
* platform/gamepad/linux/GamepadDeviceLinux.cpp: Removed.
* platform/gamepad/linux/GamepadDeviceLinux.h: Removed.

Source/WebCore/PAL:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit:

* Configurations/FeatureDefines.xcconfig:

Source/WebKitLegacy/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WTF:

* wtf/FeatureDefines.h:

Tools:

* TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoAddressing post-review comments after r219173.
mmaxfield@apple.com [Thu, 10 Aug 2017 16:59:28 +0000 (16:59 +0000)]
Addressing post-review comments after r219173.
https://bugs.webkit.org/show_bug.cgi?id=174149

Unreviewed.

* css/CSSFontStyleValue.h:
* editing/EditingStyle.cpp:
(WebCore::identifierForStyleProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUpdate TestExpectations for imported/w3c/web-platform-tests/IndexedDB/interleaved...
ryanhaddad@apple.com [Thu, 10 Aug 2017 16:53:08 +0000 (16:53 +0000)]
Update TestExpectations for imported/w3c/web-platform-tests/IndexedDB/interleaved-cursors.html.
https://bugs.webkit.org/show_bug.cgi?id=170698

Unreviewed test gardening.

* TestExpectations: Skip test on debug because it times out on every run.
* platform/ios/TestExpectations: Mark as flaky on Release.
* platform/mac/TestExpectations: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoREGRESSION(r220515) [GTK][CMake] Build with ENABLE_GEOLOCATION fails on Debian Jessie
clopez@igalia.com [Thu, 10 Aug 2017 16:33:31 +0000 (16:33 +0000)]
REGRESSION(r220515) [GTK][CMake] Build with ENABLE_GEOLOCATION fails on Debian Jessie
https://bugs.webkit.org/show_bug.cgi?id=175426

Reviewed by Carlos Garcia Campos.

.:

Fix the pkg-config file name.
We really require geoclue-2.0 and not libgeoclue-2.0.

* Source/cmake/FindGeoClue2.cmake:

Tools:

* gtk/install-dependencies: libgeoclue-dev packages not really needed on Debian/Ubuntu.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoTry to fix windows build.
antti@apple.com [Thu, 10 Aug 2017 15:44:39 +0000 (15:44 +0000)]
Try to fix windows build.

* style/StyleUpdate.h:
(WebCore::Style::TextUpdate::TextUpdate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[GTK] Don't use --whole-archive linking flags for the WebKit2 target libraries
zandobersek@gmail.com [Thu, 10 Aug 2017 12:25:07 +0000 (12:25 +0000)]
[GTK] Don't use --whole-archive linking flags for the WebKit2 target libraries
https://bugs.webkit.org/show_bug.cgi?id=175416

Reviewed by Carlos Garcia Campos.

* PlatformGTK.cmake: Drop the ADD_WHOLE_ARCHIVE_TO_LIBRARIES instruction
for the WebKit2 target. This unnecessarily bundles complete archive
files both into the main .so library as well as single executables that
are linked against the WebKit2 target.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoAdd Ms2ger as contributor.
commit-queue@webkit.org [Thu, 10 Aug 2017 12:01:56 +0000 (12:01 +0000)]
Add Ms2ger as contributor.
https://bugs.webkit.org/show_bug.cgi?id=175325

Patch by Ms2ger <Ms2ger@igalia.com> on 2017-08-10
Reviewed by Carlos Alberto Lopez Perez.

* Scripts/webkitpy/common/config/contributors.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[GTK] Crashes in WebCore::PasteboardHelper::fillSelectionData when source file of...
carlosgc@webkit.org [Thu, 10 Aug 2017 11:02:33 +0000 (11:02 +0000)]
[GTK] Crashes in WebCore::PasteboardHelper::fillSelectionData when source file of drag is unavailable
https://bugs.webkit.org/show_bug.cgi?id=174161

Reviewed by Xabier Rodriguez-Calvar.

In r219385 we changed the early return in fillSelectionData() to check the selection data length instead of the
data pointer. However, the gtk_selection_data_get_length() can return -1, so we need to check also if the value
less than 0. The case of setting an empty string could be valid depending on the target type, so it's better to
return early only when data lenght is less than 0 and handle the 0 length case in each target.

* platform/gtk/PasteboardHelper.cpp:
(WebCore::PasteboardHelper::fillSelectionData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed GTK+ gardening. Update expectations of several tests failing at r220516.
magomez@igalia.com [Thu, 10 Aug 2017 10:44:57 +0000 (10:44 +0000)]
Unreviewed GTK+ gardening. Update expectations of several tests failing at r220516.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoText renderer updates should be done by RenderTreeUpdater
antti@apple.com [Thu, 10 Aug 2017 10:20:53 +0000 (10:20 +0000)]
Text renderer updates should be done by RenderTreeUpdater
https://bugs.webkit.org/show_bug.cgi?id=175417

Reviewed by Andreas Kling.

All render tree mutations should be done by RenderTreeUpdater. Currently
Text::updateRendererAfterContentChange calls RenderText::setTextWithOffset directly.

* dom/Document.cpp:
(WebCore::Document::updateTextRenderer):

    Add range argument.

* dom/Document.h:
* dom/Text.cpp:
(WebCore::Text::updateRendererAfterContentChange):

    Remove call to setTextWithOffset and pass the range to updateTextRenderer

* style/RenderTreeUpdater.cpp:
(WebCore::RenderTreeUpdater::updateRenderTree):
(WebCore::RenderTreeUpdater::updateTextRenderer):

    Call setTextWithOffset here.

* style/RenderTreeUpdater.h:
* style/StyleTreeResolver.cpp:
(WebCore::Style::TreeResolver::resolveComposedTree):
* style/StyleUpdate.cpp:
(WebCore::Style::Update::textUpdate const):
(WebCore::Style::Update::addText):

    Add TextUpdate struct similar to ElementUpdate to pass the range to the RenderTreeUpdater.

* style/StyleUpdate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed GTK+ build fix for ENABLE_GLES2=ON.
zandobersek@gmail.com [Thu, 10 Aug 2017 08:37:36 +0000 (08:37 +0000)]
Unreviewed GTK+ build fix for ENABLE_GLES2=ON.

* platform/graphics/texmap/TextureMapperGLHeaders.h:
Define various GL constants that are not provided in GLES2 headers
but are only leveraged in OpenGL calls if at runtime the underlying
OpenGL is GLES2-capable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[TexMap] Remove GraphicsContext3D usage from BitmapTexturePool
zandobersek@gmail.com [Thu, 10 Aug 2017 07:39:39 +0000 (07:39 +0000)]
[TexMap] Remove GraphicsContext3D usage from BitmapTexturePool
https://bugs.webkit.org/show_bug.cgi?id=175319

Reviewed by Carlos Garcia Campos.

Drop the GraphicsContext3D reference in BitmapTexturePool now
that the BitmapTextureGL doesn't require it anymore.

No new tests -- no change in behavior.

* platform/graphics/texmap/BitmapTexturePool.cpp:
(WebCore::BitmapTexturePool::BitmapTexturePool):
* platform/graphics/texmap/BitmapTexturePool.h:
* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::TextureMapperGL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[TexMap] Drop GraphicsContext3D usage from BitmapTextureGL
zandobersek@gmail.com [Thu, 10 Aug 2017 07:20:16 +0000 (07:20 +0000)]
[TexMap] Drop GraphicsContext3D usage from BitmapTextureGL
https://bugs.webkit.org/show_bug.cgi?id=175317

Reviewed by Carlos Garcia Campos.

Have BitmapTextureGL use direct OpenGL API entrypoints and constants
instead of leveraging the GraphicsContext3D class. Any GraphicsContext3D
object passed to BitmapTextureGL would assume rendering to the GL context
that's current on that thread, translating method invocations to the
OpenGL API. We can do this by ourselves and benefit by avoiding allocating
GraphicsContext3D resources like the ANGLE compiler that are by most useful
for WebGL.

BitmapTextureGL::create() call sites are adjusted to stop passing a
GraphicsContext3D reference. BitmapTextureGL::bindAsSurface() doesn't need
a replacement for the passed-in GraphicsContext3D object since that object
originated from the TextureMapperGL instance, whose GraphicsContext3D is by
default of the render-to-current-context nature. Other changes are direct
translations of GraphicsContext3D methods to OpenGL API calls, or of
GraphicsContext3D values to OpenGL API constants.

No new tests -- no change in behavior.

* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::pushTextureToCompositor):
* platform/graphics/texmap/BitmapTextureGL.cpp:
Also remove an unnecessary GraphicsContext.h header inclusion.
(WebCore::BitmapTextureGL::BitmapTextureGL):
(WebCore::BitmapTextureGL::didReset):
(WebCore::BitmapTextureGL::updateContentsNoSwizzle):
(WebCore::BitmapTextureGL::updateContents):
(WebCore::BitmapTextureGL::initializeStencil):
(WebCore::BitmapTextureGL::initializeDepthBuffer):
(WebCore::BitmapTextureGL::clearIfNeeded):
(WebCore::BitmapTextureGL::createFboIfNeeded):
(WebCore::BitmapTextureGL::bindAsSurface):
(WebCore::BitmapTextureGL::~BitmapTextureGL):
(WebCore::BitmapTextureGL::copyFromExternalTexture):
* platform/graphics/texmap/BitmapTextureGL.h:
(WebCore::BitmapTextureGL::create):
(WebCore::BitmapTextureGL::textureTarget const):
(WebCore::BitmapTextureGL::internalFormat const):
* platform/graphics/texmap/BitmapTexturePool.cpp:
(WebCore::BitmapTexturePool::createTexture):
* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::bindSurface):
(WebCore::TextureMapperGL::createTexture):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoFix run-benchmark after r220483.
dewei_zhu@apple.com [Thu, 10 Aug 2017 06:01:56 +0000 (06:01 +0000)]
Fix run-benchmark after r220483.
https://bugs.webkit.org/show_bug.cgi?id=175415
<rdar://problem/33803003>

Reviewed by Ryosuke Niwa.

Update run-benchmark script to adapt new Timeout implementation introduced in r220483.

* Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py:
(WebServerBenchmarkRunner._run_one_test):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[GTK] Remove support for geoclue1
mcatanzaro@igalia.com [Thu, 10 Aug 2017 05:58:26 +0000 (05:58 +0000)]
[GTK] Remove support for geoclue1
https://bugs.webkit.org/show_bug.cgi?id=164205

Reviewed by Carlos Garcia Campos.

.:

* Source/cmake/FindGeoClue.cmake: Removed.
* Source/cmake/OptionsGTK.cmake:

Source/WebCore:

* PlatformGTK.cmake:
* platform/geoclue/GeolocationProviderGeoclue.h:
* platform/geoclue/GeolocationProviderGeoclue1.cpp: Removed.
* platform/geoclue/GeolocationProviderGeoclue2.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoDisable Beacon API on WK1 DRT and WK2 when not using NETWORK_SESSION
cdumez@apple.com [Thu, 10 Aug 2017 04:19:34 +0000 (04:19 +0000)]
Disable Beacon API on WK1 DRT and WK2 when not using NETWORK_SESSION
https://bugs.webkit.org/show_bug.cgi?id=175401

Reviewed by Brady Eidson.

Source/WebKit:

* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetBeaconAPIEnabled):
(WKPreferencesGetBeaconAPIEnabled):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences):
* config.h:

Source/WebKitLegacy/mac:

* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences beaconAPIEnabled]): Deleted.
(-[WebPreferences setBeaconAPIEnabled:]): Deleted.
* WebView/WebPreferencesPrivate.h:
* WebView/WebView.mm:
(-[WebView _preferencesChanged:]):

Tools:

* DumpRenderTree/mac/DumpRenderTree.mm:
(enableExperimentalFeatures):

LayoutTests:

* platform/mac-elcapitan-wk2/fast/dom/navigator-detached-no-crash-expected.txt: Copied from LayoutTests/platform/mac-wk1/fast/dom/navigator-detached-no-crash-expected.txt.
* platform/mac-elcapitan-wk2/imported/w3c/web-platform-tests/url/failure-expected.txt: Added.
* platform/mac-wk1/TestExpectations:
* platform/mac-wk1/fast/dom/navigator-detached-no-crash-expected.txt:
* platform/mac-wk1/imported/w3c/web-platform-tests/url/failure-expected.txt: Added.
* platform/mac-wk2/TestExpectations:
* platform/win/TestExpectations:
* platform/win/fast/dom/navigator-detached-no-crash-expected.txt: Copied from LayoutTests/platform/mac-wk1/fast/dom/navigator-detached-no-crash-expected.txt.
* platform/win/imported/w3c/web-platform-tests/url/failure-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[PAL] Move spi/cocoa and spi/cg directories into PAL
commit-queue@webkit.org [Thu, 10 Aug 2017 04:13:08 +0000 (04:13 +0000)]
[PAL] Move spi/cocoa and spi/cg directories into PAL
https://bugs.webkit.org/show_bug.cgi?id=175175

Patch by Yoshiaki Jitsukawa <Yoshiaki.Jitsukawa@sony.com> on 2017-08-09
Reviewed by Myles C. Maxfield.

Source/WebCore:

* Modules/applepay/cocoa/PaymentCocoa.mm:
* Modules/applepay/cocoa/PaymentContactCocoa.mm:
* Modules/applepay/cocoa/PaymentMerchantSessionCocoa.mm:
* Modules/applepay/cocoa/PaymentMethodCocoa.mm:
* PlatformAppleWin.cmake:
* WebCore.xcodeproj/project.pbxproj:
* editing/cocoa/EditorCocoa.mm:
* editing/cocoa/HTMLConverter.mm:
* editing/ios/EditorIOS.mm:
* page/cocoa/ResourceUsageThreadCocoa.mm:
* page/mac/TextIndicatorWindow.mm:
* platform/cocoa/ContentFilterUnblockHandlerCocoa.mm:
* platform/cocoa/DataDetectorsCoreSoftLink.h:
* platform/cocoa/MIMETypeRegistryCocoa.mm:
* platform/cocoa/NetworkExtensionContentFilter.mm:
* platform/cocoa/ParentalControlsContentFilter.mm:
* platform/cocoa/SleepDisablerCocoa.cpp:
* platform/graphics/Font.cpp:
* platform/graphics/Font.h:
* platform/graphics/avfoundation/objc/AVAssetTrackUtilities.mm:
* platform/graphics/avfoundation/objc/MediaPlaybackTargetPickerMac.mm:
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
* platform/graphics/avfoundation/objc/VideoFullscreenLayerManager.mm:
* platform/graphics/ca/cocoa/PlatformCAAnimationCocoa.mm:
* platform/graphics/ca/cocoa/PlatformCAFiltersCocoa.mm:
* platform/graphics/ca/cocoa/PlatformCALayerCocoa.mm:
* platform/graphics/cg/ColorCG.cpp:
* platform/graphics/cg/GraphicsContextCG.cpp:
* platform/graphics/cg/ImageBufferCG.cpp:
* platform/graphics/cg/ImageBufferDataCG.cpp:
* platform/graphics/cg/ImageDecoderCG.cpp:
* platform/graphics/cg/NativeImageCG.cpp:
* platform/graphics/cocoa/FontCacheCoreText.cpp:
* platform/graphics/cocoa/FontCascadeCocoa.mm:
* platform/graphics/cocoa/FontCocoa.mm:
* platform/graphics/cocoa/FontDescriptionCocoa.cpp:
* platform/graphics/cocoa/FontPlatformDataCocoa.mm:
* platform/graphics/cocoa/IOSurface.mm:
* platform/graphics/cocoa/TextTrackRepresentationCocoa.mm:
* platform/graphics/cocoa/WebActionDisablingCALayerDelegate.h:
* platform/graphics/ios/FontAntialiasingStateSaver.h:
* platform/graphics/ios/FontCacheIOS.mm:
* platform/graphics/mac/ComplexTextControllerCoreText.mm:
* platform/graphics/mac/FontCacheMac.mm:
* platform/graphics/mac/GlyphPageMac.cpp:
* platform/graphics/win/FontCacheWin.cpp:
* platform/ios/LegacyTileCache.mm:
* platform/ios/LegacyTileGrid.mm:
* platform/ios/LegacyTileGridTile.mm:
* platform/ios/PlaybackSessionInterfaceAVKit.mm:
* platform/ios/QuickLook.mm:
* platform/ios/VideoFullscreenInterfaceAVKit.mm:
* platform/ios/WebAVPlayerController.h:
* platform/ios/WebAVPlayerController.mm:
* platform/ios/WebVideoFullscreenControllerAVKit.mm:
* platform/ios/wak/WKGraphics.mm:
* platform/mac/DragImageMac.mm:
* platform/mac/PlatformScreenMac.mm:
* platform/mac/PlaybackSessionInterfaceMac.mm:
* platform/mac/ThemeMac.mm:
* platform/mac/VideoFullscreenInterfaceMac.mm:
* platform/mac/WebPlaybackControlsManager.h:
* platform/mac/WebVideoFullscreenHUDWindowController.mm:
* platform/network/cocoa/CookieStorageObserver.mm:
* platform/network/cocoa/NetworkLoadMetrics.mm:
* platform/network/mac/AuthenticationMac.mm:
* platform/network/mac/ResourceHandleMac.mm:
* platform/spi/ios/DataDetectorsUISPI.h:
* platform/spi/mac/DataDetectorsSPI.h:
* platform/spi/mac/NSViewSPI.h:
* rendering/RenderThemeCocoa.mm:
* rendering/RenderThemeIOS.mm:
* rendering/RenderThemeMac.mm:

Source/WebCore/PAL:

* PAL.xcodeproj/project.pbxproj:
* pal/PlatformAppleWin.cmake:
* pal/spi/cg/CoreGraphicsSPI.h: Renamed from Source/WebCore/platform/spi/cg/CoreGraphicsSPI.h.
(CGFloatMin):
* pal/spi/cg/ImageIOSPI.h: Renamed from Source/WebCore/platform/spi/cg/ImageIOSPI.h.
* pal/spi/cocoa/AVKitSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/AVKitSPI.h.
(-[AVTouchBarPlaybackControlsControlling NS_ENUM]):
* pal/spi/cocoa/CFNSURLConnectionSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/CFNSURLConnectionSPI.h.
* pal/spi/cocoa/CoreTextSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/CoreTextSPI.h.
* pal/spi/cocoa/DataDetectorsCoreSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/DataDetectorsCoreSPI.h.
* pal/spi/cocoa/IOPMLibSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/IOPMLibSPI.h.
* pal/spi/cocoa/IOPSLibSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/IOPSLibSPI.h.
* pal/spi/cocoa/IOReturnSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/IOReturnSPI.h.
* pal/spi/cocoa/IOSurfaceSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/IOSurfaceSPI.h.
* pal/spi/cocoa/IOTypesSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/IOTypesSPI.h.
* pal/spi/cocoa/LinkPresentationSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/LinkPresentationSPI.h.
* pal/spi/cocoa/MachVMSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/MachVMSPI.h.
* pal/spi/cocoa/NEFilterSourceSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/NEFilterSourceSPI.h.
* pal/spi/cocoa/NSAttributedStringSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/NSAttributedStringSPI.h.
* pal/spi/cocoa/NSButtonCellSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/NSButtonCellSPI.h.
* pal/spi/cocoa/NSCalendarDateSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/NSCalendarDateSPI.h.
* pal/spi/cocoa/NSColorSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/NSColorSPI.h.
* pal/spi/cocoa/NSExtensionSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/NSExtensionSPI.h.
* pal/spi/cocoa/NSFileManagerSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/NSFileManagerSPI.h.
* pal/spi/cocoa/NSStringSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/NSStringSPI.h.
* pal/spi/cocoa/NSTouchBarSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/NSTouchBarSPI.h.
* pal/spi/cocoa/NSURLConnectionSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/NSURLConnectionSPI.h.
* pal/spi/cocoa/NSURLDownloadSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/NSURLDownloadSPI.h.
* pal/spi/cocoa/NSURLFileTypeMappingsSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/NSURLFileTypeMappingsSPI.h.
* pal/spi/cocoa/PassKitSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/PassKitSPI.h.
(NS_ERROR_ENUM):
* pal/spi/cocoa/QuartzCoreSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/QuartzCoreSPI.h.
* pal/spi/cocoa/ServersSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/ServersSPI.h.
* pal/spi/cocoa/WebFilterEvaluatorSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/WebFilterEvaluatorSPI.h.
* pal/spi/cocoa/pthreadSPI.h: Renamed from Source/WebCore/platform/spi/cocoa/pthreadSPI.h.

Source/WebKit:

* NetworkProcess/CustomProtocols/Cocoa/LegacyCustomProtocolManagerCocoa.mm:
* NetworkProcess/Downloads/mac/DownloadMac.mm:
* Platform/cocoa/SharedMemoryCocoa.cpp:
* Platform/mac/LayerHostingContext.mm:
* Shared/Cocoa/DataDetectionResult.mm:
* Shared/Cocoa/WebCoreArgumentCodersCocoa.mm:
* Shared/cf/CookieStorageUtilsCF.mm:
* Shared/ios/InteractionInformationAtPosition.mm:
* Shared/mac/HangDetectionDisablerMac.mm:
* Shared/mac/RemoteLayerBackingStore.mm:
* Shared/mac/RemoteLayerTreePropertyApplier.mm:
* UIProcess/API/Cocoa/WKWebView.mm:
* UIProcess/API/mac/WKView.mm:
* UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.h:
* UIProcess/ApplePay/cocoa/WebPaymentCoordinatorProxyCocoa.mm:
* UIProcess/ApplePay/mac/WebPaymentCoordinatorProxyMac.mm:
* UIProcess/Cocoa/VideoFullscreenManagerProxy.mm:
* UIProcess/Cocoa/WebViewImpl.h:
* UIProcess/Cocoa/WebViewImpl.mm:
* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
* UIProcess/ios/ViewGestureControllerIOS.mm:
* UIProcess/ios/WKContentView.mm:
* UIProcess/ios/WKContentViewInteraction.mm:
* UIProcess/ios/WKPDFPageNumberIndicator.mm:
* UIProcess/ios/WKScrollView.mm:
* UIProcess/mac/RemoteLayerTreeHost.mm:
* UIProcess/mac/ServicesController.mm:
* UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:
* UIProcess/mac/ViewGestureControllerMac.mm:
* UIProcess/mac/ViewSnapshotStore.mm:
* UIProcess/mac/WKViewLayoutStrategy.mm:
* WebProcess/Plugins/PDF/PDFPlugin.mm:
* WebProcess/WebPage/WebPage.cpp:
* WebProcess/WebPage/mac/PlatformCAAnimationRemote.mm:
* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
* WebProcess/cocoa/WebProcessCocoa.mm:

Source/WebKitLegacy/ios:

* Misc/WebNSStringExtrasIOS.m:
* WebCoreSupport/WebFixedPositionContent.mm:

Source/WebKitLegacy/mac:

* History/WebHistory.mm:
* Misc/WebDownload.mm:
* Misc/WebKitNSStringExtras.mm:
* Plugins/Hosted/NetscapePluginHostManager.mm:
* Plugins/WebPluginDatabase.mm:
* WebCoreSupport/WebFrameLoaderClient.mm:
* WebInspector/WebNodeHighlight.mm:
* WebView/WebHTMLView.mm:
* WebView/WebIndicateLayer.mm:
* WebView/WebView.mm:
* WebView/WebViewData.h:

Tools:

* DumpRenderTree/ios/PixelDumpSupportIOS.mm:
* DumpRenderTree/mac/DumpRenderTree.mm:
* TestWebKitAPI/Tests/WebKit2Cocoa/NSFileManagerExtras.mm:
* WebKitTestRunner/ios/PlatformWebViewIOS.mm:

* Scripts/webkitpy/style/checker.py:
* Scripts/webkitpy/style/checker_unittest.py:
(GlobalVariablesTest.test_path_rules_specifier):

Add path rules specifiers for PassKitSPI.h and DataDetectorsCoreSPI.h

* Scripts/webkitpy/style/checkers/cpp.py:
(check_braces):
* Scripts/webkitpy/style/checkers/cpp_unittest.py:
(WebKitStyleTest.test_braces.CF_OPTIONS):
(WebKitStyleTest.test_braces):

Prevent CF_OPTIONS() from being handled as funtion definition.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoResource Load Statistics: Increase grandfathering time to 3 days
wilander@apple.com [Thu, 10 Aug 2017 03:21:04 +0000 (03:21 +0000)]
Resource Load Statistics: Increase grandfathering time to 3 days
https://bugs.webkit.org/show_bug.cgi?id=175414
<rdar://problem/33818046>

Reviewed by Brent Fulgham.

* UIProcess/WebResourceLoadStatisticsStore.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoInvalidate PlaybackSessionManager in same fashion as VideoFullscreenManager.
commit-queue@webkit.org [Thu, 10 Aug 2017 02:11:47 +0000 (02:11 +0000)]
Invalidate PlaybackSessionManager in same fashion as VideoFullscreenManager.
https://bugs.webkit.org/show_bug.cgi?id=175399
rdar://problem/33663344

Patch by Jeremy Jones <jeremyj@apple.com> on 2017-08-09
Reviewed by Eric Carlson.

Invalidate PlaybackSessionManager when WebPage is destructed.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::~WebPage):
* WebProcess/cocoa/PlaybackSessionManager.h:
* WebProcess/cocoa/PlaybackSessionManager.mm:
(WebKit::PlaybackSessionManager::~PlaybackSessionManager):
(WebKit::PlaybackSessionManager::invalidate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[WTF] Move TextStream into WTF
don.olmstead@sony.com [Thu, 10 Aug 2017 01:15:14 +0000 (01:15 +0000)]
[WTF] Move TextStream into WTF
https://bugs.webkit.org/show_bug.cgi?id=175211

Reviewed by Myles C. Maxfield.

Source/WebCore:

No new tests. No change in behavior.

* CMakeLists.txt:
* WebCore.xcodeproj/project.pbxproj:
* dom/ComposedTreeIterator.cpp:
* dom/Position.cpp:
* dom/Position.h:
* dom/Range.cpp:
(WebCore::operator<<):
* dom/Range.h:
* dom/ViewportArguments.cpp:
* dom/ViewportArguments.h:
* editing/VisiblePosition.cpp:
* editing/VisiblePosition.h:
* editing/VisibleSelection.cpp:
* editing/VisibleSelection.h:
* html/HTMLVideoElement.cpp:
* html/canvas/CanvasRenderingContext2D.cpp:
* page/FrameView.cpp:
* page/ViewportConfiguration.cpp:
* page/ViewportConfiguration.h:
* page/WheelEventDeltaFilter.cpp:
* page/animation/CSSPropertyAnimation.cpp:
* page/scrolling/AsyncScrollingCoordinator.cpp:
* page/scrolling/ScrollingConstraints.cpp:
* page/scrolling/ScrollingConstraints.h:
* page/scrolling/ScrollingCoordinator.cpp:
* page/scrolling/ScrollingCoordinator.h:
* page/scrolling/ScrollingStateFixedNode.cpp:
* page/scrolling/ScrollingStateFixedNode.h:
* page/scrolling/ScrollingStateFrameScrollingNode.cpp:
* page/scrolling/ScrollingStateFrameScrollingNode.h:
* page/scrolling/ScrollingStateNode.cpp:
* page/scrolling/ScrollingStateNode.h:
* page/scrolling/ScrollingStateOverflowScrollingNode.cpp:
* page/scrolling/ScrollingStateOverflowScrollingNode.h:
* page/scrolling/ScrollingStateScrollingNode.cpp:
* page/scrolling/ScrollingStateScrollingNode.h:
* page/scrolling/ScrollingStateStickyNode.cpp:
* page/scrolling/ScrollingStateStickyNode.h:
* page/scrolling/ScrollingTree.cpp:
* page/scrolling/ScrollingTreeFrameScrollingNode.cpp:
* page/scrolling/ScrollingTreeFrameScrollingNode.h:
* page/scrolling/ScrollingTreeNode.cpp:
* page/scrolling/ScrollingTreeNode.h:
* page/scrolling/ScrollingTreeScrollingNode.cpp:
* page/scrolling/ScrollingTreeScrollingNode.h:
* page/scrolling/mac/ScrollingTreeFixedNode.h:
* page/scrolling/mac/ScrollingTreeFixedNode.mm:
* page/scrolling/mac/ScrollingTreeFrameScrollingNodeMac.mm:
* page/scrolling/mac/ScrollingTreeStickyNode.h:
* page/scrolling/mac/ScrollingTreeStickyNode.mm:
* platform/CalculationValue.cpp:
* platform/CalculationValue.h:
* platform/LayoutUnit.cpp:
* platform/LayoutUnit.h:
* platform/Length.cpp:
* platform/Length.h:
* platform/LengthBox.cpp:
* platform/LengthBox.h:
* platform/LengthPoint.cpp:
* platform/LengthPoint.h:
* platform/LengthSize.cpp:
* platform/LengthSize.h:
* platform/LogMacros.h:
* platform/ScrollView.cpp:
* platform/ScrollableArea.cpp:
* platform/animation/TimingFunction.cpp:
* platform/animation/TimingFunction.h:
* platform/graphics/BitmapImage.cpp:
* platform/graphics/BitmapImage.h:
* platform/graphics/Color.cpp:
* platform/graphics/Color.h:
* platform/graphics/CrossfadeGeneratedImage.cpp:
* platform/graphics/CrossfadeGeneratedImage.h:
* platform/graphics/FloatPoint.cpp:
* platform/graphics/FloatPoint.h:
* platform/graphics/FloatPoint3D.cpp:
* platform/graphics/FloatPoint3D.h:
* platform/graphics/FloatRect.cpp:
* platform/graphics/FloatRect.h:
* platform/graphics/FloatRoundedRect.cpp:
* platform/graphics/FloatRoundedRect.h:
* platform/graphics/FloatSize.cpp:
* platform/graphics/FloatSize.h:
* platform/graphics/FontTaggedSettings.cpp:
* platform/graphics/FontTaggedSettings.h:
* platform/graphics/GradientImage.cpp:
(WebCore::GradientImage::dump const):
* platform/graphics/GradientImage.h:
* platform/graphics/GraphicsContext.cpp:
* platform/graphics/GraphicsContext.h:
* platform/graphics/GraphicsLayer.cpp:
* platform/graphics/GraphicsLayer.h:
(WebCore::GraphicsLayer::dumpAdditionalProperties const):
* platform/graphics/GraphicsTypes.cpp:
* platform/graphics/GraphicsTypes.h:
* platform/graphics/Image.cpp:
* platform/graphics/Image.h:
* platform/graphics/ImageSource.h:
* platform/graphics/IntPoint.cpp:
* platform/graphics/IntPoint.h:
* platform/graphics/IntRect.cpp:
* platform/graphics/IntRect.h:
* platform/graphics/IntSize.cpp:
* platform/graphics/IntSize.h:
* platform/graphics/LayoutPoint.cpp:
* platform/graphics/LayoutPoint.h:
* platform/graphics/LayoutRect.cpp:
* platform/graphics/LayoutRect.h:
* platform/graphics/LayoutSize.cpp:
* platform/graphics/LayoutSize.h:
* platform/graphics/NamedImageGeneratedImage.cpp:
* platform/graphics/NamedImageGeneratedImage.h:
* platform/graphics/Path.cpp:
* platform/graphics/Path.h:
* platform/graphics/ca/GraphicsLayerCA.cpp:
* platform/graphics/ca/GraphicsLayerCA.h:
* platform/graphics/ca/PlatformCAAnimation.cpp:
* platform/graphics/ca/PlatformCAAnimation.h:
* platform/graphics/ca/PlatformCALayer.cpp:
* platform/graphics/ca/PlatformCALayer.h:
* platform/graphics/ca/TileController.cpp:
* platform/graphics/ca/TileGrid.cpp:
* platform/graphics/cg/GraphicsContextCG.cpp:
* platform/graphics/cg/PDFDocumentImage.cpp:
* platform/graphics/cg/PDFDocumentImage.h:
* platform/graphics/cocoa/IOSurface.h:
* platform/graphics/cocoa/IOSurface.mm:
* platform/graphics/displaylists/DisplayList.cpp:
(WebCore::DisplayList::DisplayList::description const):
* platform/graphics/displaylists/DisplayList.h:
* platform/graphics/displaylists/DisplayListItems.cpp:
* platform/graphics/displaylists/DisplayListItems.h:
* platform/graphics/displaylists/DisplayListRecorder.cpp:
* platform/graphics/displaylists/DisplayListReplayer.cpp:
* platform/graphics/filters/DistantLightSource.cpp:
* platform/graphics/filters/DistantLightSource.h:
* platform/graphics/filters/FEBlend.cpp:
* platform/graphics/filters/FEBlend.h:
* platform/graphics/filters/FEColorMatrix.cpp:
* platform/graphics/filters/FEColorMatrix.h:
* platform/graphics/filters/FEComponentTransfer.cpp:
* platform/graphics/filters/FEComponentTransfer.h:
* platform/graphics/filters/FEComposite.cpp:
* platform/graphics/filters/FEComposite.h:
* platform/graphics/filters/FEConvolveMatrix.cpp:
* platform/graphics/filters/FEConvolveMatrix.h:
* platform/graphics/filters/FEDiffuseLighting.cpp:
* platform/graphics/filters/FEDiffuseLighting.h:
* platform/graphics/filters/FEDisplacementMap.cpp:
* platform/graphics/filters/FEDisplacementMap.h:
* platform/graphics/filters/FEDropShadow.cpp:
* platform/graphics/filters/FEDropShadow.h:
* platform/graphics/filters/FEFlood.cpp:
* platform/graphics/filters/FEFlood.h:
* platform/graphics/filters/FEGaussianBlur.cpp:
* platform/graphics/filters/FEGaussianBlur.h:
* platform/graphics/filters/FEMerge.cpp:
* platform/graphics/filters/FEMerge.h:
* platform/graphics/filters/FEMorphology.cpp:
* platform/graphics/filters/FEMorphology.h:
* platform/graphics/filters/FEOffset.cpp:
* platform/graphics/filters/FEOffset.h:
* platform/graphics/filters/FESpecularLighting.cpp:
* platform/graphics/filters/FESpecularLighting.h:
* platform/graphics/filters/FETile.cpp:
* platform/graphics/filters/FETile.h:
* platform/graphics/filters/FETurbulence.cpp:
* platform/graphics/filters/FETurbulence.h:
* platform/graphics/filters/FilterEffect.cpp:
* platform/graphics/filters/FilterEffect.h:
* platform/graphics/filters/FilterOperation.cpp:
* platform/graphics/filters/FilterOperation.h:
* platform/graphics/filters/FilterOperations.cpp:
* platform/graphics/filters/FilterOperations.h:
* platform/graphics/filters/LightSource.h:
* platform/graphics/filters/PointLightSource.cpp:
* platform/graphics/filters/PointLightSource.h:
* platform/graphics/filters/SourceAlpha.cpp:
* platform/graphics/filters/SourceAlpha.h:
* platform/graphics/filters/SourceGraphic.cpp:
* platform/graphics/filters/SourceGraphic.h:
* platform/graphics/filters/SpotLightSource.cpp:
* platform/graphics/filters/SpotLightSource.h:
* platform/graphics/transforms/AffineTransform.cpp:
* platform/graphics/transforms/AffineTransform.h:
* platform/graphics/transforms/IdentityTransformOperation.h:
* platform/graphics/transforms/Matrix3DTransformOperation.cpp:
* platform/graphics/transforms/Matrix3DTransformOperation.h:
* platform/graphics/transforms/MatrixTransformOperation.cpp:
* platform/graphics/transforms/MatrixTransformOperation.h:
* platform/graphics/transforms/PerspectiveTransformOperation.cpp:
* platform/graphics/transforms/PerspectiveTransformOperation.h:
* platform/graphics/transforms/RotateTransformOperation.cpp:
* platform/graphics/transforms/RotateTransformOperation.h:
* platform/graphics/transforms/ScaleTransformOperation.cpp:
* platform/graphics/transforms/ScaleTransformOperation.h:
* platform/graphics/transforms/SkewTransformOperation.cpp:
* platform/graphics/transforms/SkewTransformOperation.h:
* platform/graphics/transforms/TransformOperation.cpp:
* platform/graphics/transforms/TransformOperation.h:
* platform/graphics/transforms/TransformOperations.cpp:
* platform/graphics/transforms/TransformOperations.h:
* platform/graphics/transforms/TransformationMatrix.cpp:
* platform/graphics/transforms/TransformationMatrix.h:
* platform/graphics/transforms/TranslateTransformOperation.cpp:
* platform/graphics/transforms/TranslateTransformOperation.h:
* platform/ios/SelectionRect.cpp:
(WebCore::operator<<):
* platform/ios/SelectionRect.h:
* platform/mac/ScrollAnimatorMac.mm:
* platform/text/TextAllInOne.cpp:
* rendering/InlineBox.cpp:
* rendering/InlineBox.h:
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::outputLineTreeAndMark const):
* rendering/InlineFlowBox.h:
* rendering/InlineTextBox.cpp:
* rendering/InlineTextBox.h:
* rendering/RenderBlockFlow.cpp:
(WebCore::RenderBlockFlow::outputLineTreeAndMark const):
* rendering/RenderBlockFlow.h:
* rendering/RenderLayer.cpp:
* rendering/RenderLayerCompositor.cpp:
* rendering/RenderObject.cpp:
* rendering/RenderObject.h:
* rendering/RenderTreeAsText.cpp:
* rendering/RenderTreeAsText.h:
* rendering/ScrollAlignment.cpp:
* rendering/ScrollAlignment.h:
* rendering/SimpleLineLayoutCoverage.cpp:
* rendering/SimpleLineLayoutFunctions.cpp:
* rendering/SimpleLineLayoutFunctions.h:
* rendering/style/FillLayer.cpp:
* rendering/style/FillLayer.h:
* rendering/style/NinePieceImage.cpp:
* rendering/style/NinePieceImage.h:
* rendering/style/RenderStyleConstants.cpp:
* rendering/style/RenderStyleConstants.h:
* rendering/svg/SVGRenderTreeAsText.cpp:
(WebCore::operator<<):
* rendering/svg/SVGRenderTreeAsText.h:
(WebCore::operator<<):
* svg/SVGLengthValue.cpp:
* svg/SVGLengthValue.h:
* svg/graphics/SVGImage.cpp:
* svg/graphics/SVGImage.h:
* svg/graphics/filters/SVGFEImage.cpp:
* svg/graphics/filters/SVGFEImage.h:

Source/WebKit:

* Shared/Scrolling/RemoteScrollingCoordinatorTransaction.cpp:
* Shared/VisibleContentRectUpdateInfo.cpp:
* Shared/VisibleContentRectUpdateInfo.h:
* Shared/mac/RemoteLayerTreeTransaction.mm:
* UIProcess/API/Cocoa/WKWebView.mm:
* UIProcess/ios/WKContentView.mm:
* UIProcess/ios/WKContentViewInteraction.h:
* UIProcess/ios/WKContentViewInteraction.mm:
(WebKit::operator<<):
* UIProcess/ios/WebPageProxyIOS.mm:
* WebProcess/WebPage/ios/WebPageIOS.mm:
* WebProcess/WebPage/mac/PlatformCAAnimationRemote.h:
* WebProcess/WebPage/mac/PlatformCAAnimationRemote.mm:

Source/WTF:

* WTF.xcodeproj/project.pbxproj:
* wtf/CMakeLists.txt:
* wtf/text/TextStream.cpp: Renamed from Source/WebCore/platform/text/TextStream.cpp.
(WTF::TextStream::writeIndent):
* wtf/text/TextStream.h: Renamed from Source/WebCore/platform/text/TextStream.h.
(WTF::TextStream::FormatNumberRespectingIntegers::FormatNumberRespectingIntegers):

Tools:

* TestWebKitAPI/Tests/WebCore/CalculationValue.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agofont-fallback-font-family.html is failing on perf bots
mmaxfield@apple.com [Thu, 10 Aug 2017 01:12:07 +0000 (01:12 +0000)]
font-fallback-font-family.html is failing on perf bots
https://bugs.webkit.org/show_bug.cgi?id=174989

Unreviewed.

* Layout/resources/font-fallback-font-family.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoPart 3 of: Rename DatabaseProcess to StorageProcess
aestes@apple.com [Thu, 10 Aug 2017 01:07:09 +0000 (01:07 +0000)]
Part 3 of: Rename DatabaseProcess to StorageProcess
https://bugs.webkit.org/show_bug.cgi?id=175034

Reviewed by Brady Eidson.

Source/WebKit:

We tried renaming com.apple.WebKit.Databases to com.apple.WebKit.Storage in r219986, but
this prevented trunk WebKit from running on iOS 11 devices. This is because launchd keeps a
codesigned cache of XPC services, and refuses to launch services that aren't in the cache.

It's not possibe for us to rebuild the cache with the new service name (only Apple's
production build system can do this), and disabling the cache or opting WebKit's XPC
services out of the cache might have a negative impact on our performance testing.

For now we'll retain the name "com.apple.WebKit.Databases" on iOS 11 devices to work around
this issue. If we find a way to allow the new service to run without impacting performance,
we can revert this change.

We will rename the service to "com.apple.WebKit.Storage" on macOS and iOS Simulator, and in
a follow-up patch we'll use the new service name on post-iOS 11 device builds.

* Configurations/BaseTarget.xcconfig: Defined WK_STORAGE_SERVICE_PRODUCT_NAME to be
com.apple.WebKit.Databases by default, and overrode it to com.apple.WebKit.Storage on macOS
and iOS Simulator.
* Configurations/StorageService.xcconfig: Changed PRODUCT_NAME to $(WK_STORAGE_SERVICE_PRODUCT_NAME).
* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::serviceName): Changed to return "com.apple.WebKit.Storage" on macOS and
iOS Simulator platforms.
* WebKit.xcodeproj/project.pbxproj: Updated the "Copy XPC services for engineering builds"
build phase to use WK_STORAGE_SERVICE_PRODUCT_NAME.

Tools:

* WebKitTestRunner/TestController.cpp:
(WTR::TestController::databaseProcessName): Updated to return
"com.apple.WebKit.Storage.Development" on macOS and iOS Simulator.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[JSC] Create JSSet constructor that accepts it's size as parameter
ticaiolima@gmail.com [Thu, 10 Aug 2017 00:42:24 +0000 (00:42 +0000)]
[JSC] Create JSSet constructor that accepts it's size as parameter
https://bugs.webkit.org/show_bug.cgi?id=173297

Reviewed by Saam Barati.

This patch is adding a new constructor to JSSet that gives its
expected initial size. It is important to avoid re-hashing and mutiple
allocations when we know the final size of JSSet, such as in
CodeBlock::setConstantIdentifierSetRegisters.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::setConstantIdentifierSetRegisters):
* runtime/HashMapImpl.h:
(JSC::HashMapImpl::HashMapImpl):
* runtime/JSSet.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed, rolling out r220466, r220477, and r220487.
ryanhaddad@apple.com [Thu, 10 Aug 2017 00:35:58 +0000 (00:35 +0000)]
Unreviewed, rolling out r220466, r220477, and r220487.
https://bugs.webkit.org/show_bug.cgi?id=175411

This change broke existing API tests and follow up fixes did
not resolve all the issues. (Requested by ryanhaddad on
#webkit).

Reverted changesets:

https://bugs.webkit.org/show_bug.cgi?id=175244
http://trac.webkit.org/changeset/220466

"WTF::Function does not allow for reference / non-default
constructible return types"
https://bugs.webkit.org/show_bug.cgi?id=175244
http://trac.webkit.org/changeset/220477

https://bugs.webkit.org/show_bug.cgi?id=175244
http://trac.webkit.org/changeset/220487

Patch by Commit Queue <commit-queue@webkit.org> on 2017-08-09

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[CMake] Remove unused find modules
mcatanzaro@igalia.com [Wed, 9 Aug 2017 23:32:14 +0000 (23:32 +0000)]
[CMake] Remove unused find modules
https://bugs.webkit.org/show_bug.cgi?id=175363

Reviewed by Carlos Alberto Lopez Perez.

* Source/cmake/FindCFLite.cmake: Removed.
* Source/cmake/FindClang.cmake: Removed.
* Source/cmake/FindDBus.cmake: Removed.
* Source/cmake/FindDirectX.cmake: Removed.
* Source/cmake/FindEspeak.cmake: Removed.
* Source/cmake/FindQuickTimeSDK.cmake: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[Beacon][NetworkSession] Support CORS-preflighting on redirects
cdumez@apple.com [Wed, 9 Aug 2017 23:23:58 +0000 (23:23 +0000)]
[Beacon][NetworkSession] Support CORS-preflighting on redirects
https://bugs.webkit.org/show_bug.cgi?id=175386
<rdar://problem/33801370>

Reviewed by Youenn Fablet.

Source/WebCore:

Export a couple of WebCore symbols so I can use them in WebKit2.

Tests: http/wpt/beacon/cors/cors-preflight-redirect-failure.html
       http/wpt/beacon/cors/cors-preflight-redirect-from-crossorigin-to-sameorigin.html
       http/wpt/beacon/cors/cors-preflight-redirect-success.html

* loader/CrossOriginAccessControl.h:
* page/SecurityOrigin.h:

Source/WebKit:

Add support to Beacon for doing CORS-preflighting upon redirect to a different
domain.

* NetworkProcess/NetworkCORSPreflightChecker.h:
* NetworkProcess/PingLoad.cpp:
(WebKit::PingLoad::PingLoad):
(WebKit::PingLoad::~PingLoad):
(WebKit::PingLoad::loadRequest):
(WebKit::PingLoad::securityOrigin const):
(WebKit::PingLoad::willPerformHTTPRedirection):
(WebKit::PingLoad::didReceiveResponseNetworkSession):
(WebKit::PingLoad::needsCORSPreflight const):
(WebKit::PingLoad::doCORSPreflight):
* NetworkProcess/PingLoad.h:

LayoutTests:

Add layout test coverage.

* http/wpt/beacon/cors/cors-preflight-redirect-failure-expected.txt: Added.
* http/wpt/beacon/cors/cors-preflight-redirect-failure.html: Added.
* http/wpt/beacon/cors/cors-preflight-redirect-from-crossorigin-to-sameorigin-expected.txt: Added.
* http/wpt/beacon/cors/cors-preflight-redirect-from-crossorigin-to-sameorigin.html: Added.
* http/wpt/beacon/cors/cors-preflight-redirect-success-expected.txt: Added.
* http/wpt/beacon/cors/cors-preflight-redirect-success.html: Added.
* http/wpt/beacon/resources/beacon-preflight.py:
(main):
* http/wpt/beacon/resources/redirect.py: Added.
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUse MPAVRoutingController instead of deprecated versions.
commit-queue@webkit.org [Wed, 9 Aug 2017 23:18:13 +0000 (23:18 +0000)]
Use MPAVRoutingController instead of deprecated versions.
https://bugs.webkit.org/show_bug.cgi?id=175063
Source/WebCore:

Patch by Jeremy Jones <jeremyj@apple.com> on 2017-08-09
Reviewed by Tim Horton.

No new tests because no behavior change. This uses a different platform class to present
an interface.

Remove deprecated MPAudioVideoRoutingPopoverController and MPAVRoutingSheet
Add MPMediaControlsViewController.

* platform/spi/ios/MediaPlayerSPI.h:

Source/WebKit:

rdar://problem/33301230

Patch by Jeremy Jones <jeremyj@apple.com> on 2017-08-09
Reviewed by Tim Horton.

Remove dependence on deprecated classes MPAVRoutingSheet and MPAudioVideoRoutingPopoverController.

* UIProcess/ios/forms/WKAirPlayRoutePicker.h:
* UIProcess/ios/forms/WKAirPlayRoutePicker.mm:
(-[WKAirPlayRoutePicker dealloc]):
(-[WKAirPlayRoutePicker show:fromRect:]):
(-[WKAirPlayRoutePicker popoverControllerDidDismissPopover:]): Deleted.
(-[WKAirPlayRoutePicker _presentAirPlayPopoverAnimated:fromRect:]): Deleted.
(-[WKAirPlayRoutePicker _windowWillRotate:]): Deleted.
(-[WKAirPlayRoutePicker _windowDidRotate:]): Deleted.
(-[WKAirPlayRoutePicker _dismissAirPlayRoutePickerIPad]): Deleted.
(-[WKAirPlayRoutePicker showAirPlayPickerIPad:fromRect:]): Deleted.
(-[WKAirPlayRoutePicker showAirPlayPickerIPhone:]): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed, deflake http/wpt/beacon/keepalive-after-navigation.html
cdumez@apple.com [Wed, 9 Aug 2017 23:03:10 +0000 (23:03 +0000)]
Unreviewed, deflake http/wpt/beacon/keepalive-after-navigation.html

Temporarily restore previous timeout on this test to address flakiness on the
bots until I can rewrite it.

* http/wpt/beacon/keepalive-after-navigation.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoImport beacon/headers/header-content-type.html from upstream WPT
cdumez@apple.com [Wed, 9 Aug 2017 23:01:05 +0000 (23:01 +0000)]
Import beacon/headers/header-content-type.html from upstream WPT
https://bugs.webkit.org/show_bug.cgi?id=175395

Reviewed by Sam Weinig.

LayoutTests/imported/w3c:

* web-platform-tests/beacon/headers/header-content-type-expected.txt:
* web-platform-tests/beacon/headers/header-content-type.html:

LayoutTests:

Drop local test that has been upstreamed to WPT.

* http/wpt/beacon/headers/header-content-type-same-origin-expected.txt: Removed.
* http/wpt/beacon/headers/header-content-type-same-origin.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed build fix.
msaboff@apple.com [Wed, 9 Aug 2017 22:59:32 +0000 (22:59 +0000)]
Unreviewed build fix.

Added missing files.

* RexBench/Octane2/benchmark.js: Added.
(Octane2RegExpBenchmark):
(Octane2RegExpBenchmark.prototype.setup.):
(Octane2RegExpBenchmark.prototype.setup.Math.random):
(Octane2RegExpBenchmark.prototype.setup):
(Octane2RegExpBenchmark.prototype.runOnce):
(Octane2RegExpBenchmark.prototype.tearDown):
* RexBench/SunSpider/benchmark.js: Added.
(RegexDNABenchmark):
(RegexDNABenchmark.prototype.runOnce):
(RegexDNABenchmark.prototype.validate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoMark font-display as in development
mmaxfield@apple.com [Wed, 9 Aug 2017 22:42:59 +0000 (22:42 +0000)]
Mark font-display as in development
https://bugs.webkit.org/show_bug.cgi?id=175387

Unreviewed.

* features.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUpdate for https://bugs.webkit.org/show_bug.cgi?id=175244.
weinig@apple.com [Wed, 9 Aug 2017 22:40:53 +0000 (22:40 +0000)]
Update for https://bugs.webkit.org/show_bug.cgi?id=175244.

Remove one addition of null Function test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoLayoutTest accessibility/presentation-role-iframe.html is a flaky failure
n_wang@apple.com [Wed, 9 Aug 2017 22:36:04 +0000 (22:36 +0000)]
LayoutTest accessibility/presentation-role-iframe.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=175194

Reviewed by Chris Fleizach.

In the test we have no way to control which iframe will be loaded first.
Output the logs at the end of the test so that they are in order.

* accessibility/presentation-role-iframe.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRex Bench doesn't work from the command line
msaboff@apple.com [Wed, 9 Aug 2017 22:33:27 +0000 (22:33 +0000)]
Rex Bench doesn't work from the command line
https://bugs.webkit.org/show_bug.cgi?id=175349

Reviewed by Saam Barati.

Fixed cli.js to have the same set of benchmarks and .js files as the web
page driver.

Refactored the way benchmarks are run using a new Benchmark base class.  That
class will run the benchmark as well.  Eliminated the various runBenchmark()
functions that were used for individual tests.  This refactoring was threaded
into the web page driver as well.  Changed the iteration counts on many of the
individual benchmarks.  Also changed the inner loop count for the flight
planner test.

Eliminated Octane2/base.js as it isn't needed to run Octane2/RegExp with the
new test harness.  Eliminated other dead code in Octane2/regexp.js.

* RexBench/Basic/benchmark.js:
(BasicBenchmark):
(BasicBenchmark.prototype.runIteration): Deleted.
(runBenchmark): Deleted.
* RexBench/FlightPlanner/benchmark.js:
(FlightPlannerBenchmark):
(FlightPlannerBenchmark.prototype.runOnce):
(this.performance.performance.now.currentTime): Deleted.
(else.this.preciseTime.currentTime): Deleted.
(else.currentTime): Deleted.
(FlightPlannerBenchmark.prototype.runIteration): Deleted.
(FlightPlannerBenchmark.prototype.checkResults): Deleted.
(runBenchmark): Deleted.
* RexBench/Octane2/base.js: Removed.
* RexBench/Octane2/regexp.js:
* RexBench/basic_benchmark.js:
* RexBench/benchmark.js: Added.
(this.performance.performance.now.currentTime):
(else.this.preciseTime.currentTime):
(else.currentTime):
(Benchmark):
(Benchmark.prototype.runIterations):
(Benchmark.prototype.setup):
(Benchmark.prototype.runOnce):
(Benchmark.prototype.validate):
(Benchmark.prototype.tearDown):
* RexBench/cli.js:
* RexBench/flightplan_benchmark.js:
* RexBench/flightplan_unicode_benchmark.js:
* RexBench/octane2_benchmark.js:
* RexBench/stats.js:
(Stats.prototype.toString.return.span.0.span.span):
* RexBench/sunspider_benchmark.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed, rolling out r219334.
commit-queue@webkit.org [Wed, 9 Aug 2017 22:08:35 +0000 (22:08 +0000)]
Unreviewed, rolling out r219334.
https://bugs.webkit.org/show_bug.cgi?id=175398

Caused bug 175023 (Requested by ap on #webkit).

Reverted changeset:

"[SVG] Leak in SVGAnimatedListPropertyTearOff"
https://bugs.webkit.org/show_bug.cgi?id=172545
http://trac.webkit.org/changeset/219334

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoAllow nested timeouts in webkitpy
jbedard@apple.com [Wed, 9 Aug 2017 21:58:18 +0000 (21:58 +0000)]
Allow nested timeouts in webkitpy
https://bugs.webkit.org/show_bug.cgi?id=175390
<rdar://problem/33803003>

Reviewed by David Kilzer.

We need to be able to nest timeouts in webkitpy. In particular, we have a few cases where functions
which use timeouts also call the executive. For on-device testing, we need to have timeouts inside
the executive to detect and recover from any issues connecting with devices.

* Scripts/webkitpy/benchmark_runner/utils.py:
(TimeoutError): Deleted.
(timeout): Deleted.
* Scripts/webkitpy/common/timeout_context.py: Added.
(Timeout): A timeout context designed to be nested.
(Timeout.TimeoutData): The data required to construct an alarm for a given timeout.
(Timeout.TimeoutData.__init__):
(Timeout.default_handler): Timeout handler used if none is specified.
(Timeout.current): Access data about the most urgent timeout.
(Timeout.__init__): Construct a Timeout object with seconds and an optional handler.
(Timeout._bind_timeout_data_to_alarm): Given data about a timeout, initialize an alarm for that timeout.
(Timeout.__enter__): Un-bind all alarms. Add data for this timeout to the ordered list and bind the most
urgent timeout data.
(Timeout.__exit__): Un-bind all alarms. Remove data for this timeout from the ordered list and bind the
most urgent timeout data, if such data exists.
* Scripts/webkitpy/common/timeout_context_unittest.py: Added.
(TimeoutContextTests):
(TimeoutContextTests.test_current_timeout): Test that accessing the nearest timeout works as expected.
(TimeoutContextTests.test_invalid_timeout): Test a timeout of 0.
(TimeoutContextTests.test_timeout_data): Confirm that timeouts are constructed correctly.
(TimeoutContextTests.test_nested_inner_precedence): Check that a more urgent inner timeout takes precedence
over a less urgent outer timeout.
(TimeoutContextTests.test_nested_outer_precedence): Check that a more urgent outer timeout takes precedence
over a less urgent inner timeout.
(TimeoutContextTests.test_no_timeout): Test a block of code without a timeout.
(TimeoutContextTests.test_basic_timeout): Test a block of code expected to timeout.
(TimeoutContextTests.test_exception_constructor_timeout): Test a timeout where the handler is an exception.
(TimeoutContextTests.test_nested_inner_timeout): Confirm that a more urgent inner timeout is triggered.
(TimeoutContextTests.test_nested_outer_timeout): Confirm that a more urgent outer timeout is triggered.
* Scripts/webkitpy/port/simulator_process.py:
(SimulatorProcess._start): Use Timeout class.
* Scripts/webkitpy/xcode/simulated_device.py:
(SimulatedDevice.launch_app._log_debug_error): Use Timeout class.
(SimulatedDevice.launch_app): Ditto.
(SimulatedDevice.launch_app._install_timeout): Deleted.
* Scripts/webkitpy/xcode/simulator.py:
(Simulator.wait_until_device_is_booted):Use Timeout class.
(Simulator.wait_until_device_is_in_state): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoEarly error on ANY operator before new.target
caitp@igalia.com [Wed, 9 Aug 2017 21:34:20 +0000 (21:34 +0000)]
Early error on ANY operator before new.target
https://bugs.webkit.org/show_bug.cgi?id=157970

Reviewed by Saam Barati.

Instead of throwing if any unary operator precedes new.target, only
throw if the unary operator updates the reference.

The following become legal in JSC:

```
!new.target
~new.target
typeof new.target
delete new.target
void new.target
```

All of which are legal in v8 and SpiderMonkey in strict and sloppy mode

JSTests:

* stress/new-target-syntax-errors.js:
* stress/new-target.js:

Source/JavaScriptCore:

* parser/Parser.cpp:
(JSC::Parser<LexerType>::parseUnaryExpression):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[Repaint from Layout Removal] Move layer repaint rects into a map
hyatt@apple.com [Wed, 9 Aug 2017 21:03:03 +0000 (21:03 +0000)]
[Repaint from Layout Removal] Move layer repaint rects into a map
https://bugs.webkit.org/show_bug.cgi?id=175393

Reviewed by Zalan Bujtas.

Move the two repaint rects held by RenderLayer into a RenderLayerModelObject -> RepaintLayoutRects hash map.
RepaintLayoutRects is a new struct that holds both rects.

Eventually more objects than just self painting layers will be caching repaint rects, so this takes a first
step towards having a common cache for these repaint rects. In addition this change saves memory, since
layers that aren't self-painting no longer have empty repaint rects taking up space in RenderLayer.

* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlockFlow::layoutRunsAndFloats):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::updateLayerPositions):
(WebCore::RenderLayer::repaintRectIncludingNonCompositingDescendants):
(WebCore::RenderLayer::computeRepaintRects):
(WebCore::RenderLayer::clearRepaintRects):
(WebCore::RenderLayer::updateLayerPositionsAfterScroll):
(WebCore::RenderLayer::scrollTo):
* rendering/RenderLayer.h:
* rendering/RenderLayerModelObject.cpp:
(WebCore::RepaintLayoutRects::RepaintLayoutRects):
(WebCore::RenderLayerModelObject::willBeDestroyed):
(WebCore::RenderLayerModelObject::destroyLayer):
(WebCore::RenderLayerModelObject::styleDidChange):
(WebCore::RenderLayerModelObject::hasRepaintLayoutRects):
(WebCore::RenderLayerModelObject::setRepaintLayoutRects):
(WebCore::RenderLayerModelObject::clearRepaintLayoutRects):
(WebCore::RenderLayerModelObject::repaintLayoutRects):
(WebCore::RenderLayerModelObject::computeRepaintLayoutRects):
* rendering/RenderLayerModelObject.h:
(WebCore::RepaintLayoutRects::RepaintLayoutRects):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUpdate reviewer
weinig@apple.com [Wed, 9 Aug 2017 21:02:23 +0000 (21:02 +0000)]
Update reviewer

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWTF::Function does not allow for reference / non-default constructible return types
commit-queue@webkit.org [Wed, 9 Aug 2017 20:57:51 +0000 (20:57 +0000)]
WTF::Function does not allow for reference / non-default constructible return types
https://bugs.webkit.org/show_bug.cgi?id=175244

Patch by Sam Weinig <sam@webkit.org> on 2017-08-09
Reviewed by Sam Weinig.

Source/JavaScriptCore:

* runtime/ArrayBuffer.cpp:
(JSC::ArrayBufferContents::transferTo):
Call reset(), rather than clear() to avoid the call to destroy() in clear(). The
destroy call needed to be a no-op anyway, since the data is being moved.

Source/WebCore:

* bindings/js/JSCustomElementInterface.h:
(WebCore::JSCustomElementInterface::invokeCallback):
Update the default value for the addArguments parameter to be an empty lambda, rather than
default initialization, which leads to a null WTF::Function. This allows us to remove support
for calling null WTF::Function. No change in behavior.

Source/WebKit:

* UIProcess/WebResourceLoadStatisticsStore.h:
Update the default value for the updateCookiePartitioningForDomainsHandler parameter to be an
empty lambda, rather than default initialization, which leads to a null WTF::Function. This allows
us to remove support for calling null WTF::Function. No change in behavior.

Source/WTF:

When Function, then NoncopyableFunction, was templatized to allow non-void return values
in r201493, it maintained the behavior of being callable even if the Function was null.
To accomplish this, when null, the default construction of the return parameter was used.
This means Function can't be used with return types that are not default constructible,
such as reference types and Ref.

This behavior of returning something when null is surprising, as this is not how normal
functions behave, and not very useful. Instead, we now assert that the function is not
null when being called.

* wtf/Function.h:
(WTF::Function operator(...)):
Instead of allowing a null callable wrapper by returning the default construction of
the return type, assert that the wrapper is there when calling a Function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@220477 268f45cc-cd09-0410-ab3c-d52691b4dbfc