WebKit-https.git
8 years agoVersioning.
lforschler@apple.com [Fri, 16 Nov 2012 02:45:07 +0000 (02:45 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agocustom CSS cursors ignore hotspot values embedded in CUR files
commit-queue@webkit.org [Fri, 16 Nov 2012 02:28:00 +0000 (02:28 +0000)]
custom CSS cursors ignore hotspot values embedded in CUR files
https://bugs.webkit.org/show_bug.cgi?id=100059

Patch by Rick Byers <rbyers@chromium.org> on 2012-11-15
Reviewed by Kenneth Russell.

Source/WebCore:

Add reading the hotspot values to the ICOImageDecoder (for CUR files only),
and plumb it through so that the existing calls to ImageSource::getHotSpot
actually return the hot spot value when there is one.

Tests: fast/events/mouse-cursor.html, fast/events/mouse-cursor-multiframecur.html

* platform/graphics/ImageSource.cpp:
(WebCore::ImageSource::getHotSpot):
* platform/graphics/chromium/DeferredImageDecoder.cpp:
(WebCore::DeferredImageDecoder::hotSpot):
(WebCore::DeferredImageDecoder::hotSpotAtIndex):
* platform/graphics/chromium/DeferredImageDecoder.h:
(DeferredImageDecoder):
* platform/image-decoders/ImageDecoder.h:
(WebCore::ImageDecoder::hotSpot):
(WebCore::ImageDecoder::hotSpotAtIndex):
(ImageDecoder):
* platform/image-decoders/ico/ICOImageDecoder.cpp:
(WebCore::ICOImageDecoder::hotSpot):
(WebCore::ICOImageDecoder::hotSpotAtIndex):
(WebCore::ICOImageDecoder::processDirectory):
(WebCore::ICOImageDecoder::readDirectoryEntry):
* platform/image-decoders/ico/ICOImageDecoder.h:
(ICOImageDecoder):
(IconDirectoryEntry):

LayoutTests:

Add mouse cursor test cases that use CUR files that have embedded hotspot values.

* fast/events/mouse-cursor-expected.txt:
* fast/events/mouse-cursor-multiframecur-expected.txt: Added.
* fast/events/mouse-cursor-multiframecur.html: Copied from LayoutTests/fast/events/mouse-cursor.html.
* fast/events/mouse-cursor.html:
* fast/events/resources/greenbox-3frames.cur: Added.
* fast/events/resources/greenbox-hotspot35-4.cur: Added.
* fast/events/resources/greenbox-hotspot5-4.cur: Added.
* platform/mac/TestExpectations: Skip the multi-frame case on mac because it causes a hang

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCoordinated Graphics: Refactor code related to directly composited images.
commit-queue@webkit.org [Fri, 16 Nov 2012 02:24:31 +0000 (02:24 +0000)]
Coordinated Graphics: Refactor code related to directly composited images.
https://bugs.webkit.org/show_bug.cgi?id=101023

Patch by Huang Dongsung <luxtella@company100.net> on 2012-11-15
Reviewed by Noam Rosenthal.

Internal Review by Gwang Yoon Hwang and Jae Hyun Park.

Currently, LayerTreeCoordinator manages composited images using
ShareableBitmap. This patch introduces CoordinatedImageBacking which
plays a role in managing composited images. CoordinatedImageBacking makes us
gather code related to a directly composited image into a single class.

We create only one CoordinatedImageBacking per image. For example, in the leaves
demo, we create only 3 textures of leaves.

* CMakeLists.txt:
* Shared/WebLayerTreeInfo.h:
(WebKit::WebLayerInfo::WebLayerInfo):
(WebLayerInfo):
* Target.pri:
* UIProcess/CoordinatedGraphics/CoordinatedBackingStore.cpp:
(WebKit::CoordinatedBackingStoreTile::swapBuffers):
* UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.cpp:
(WebKit::LayerTreeCoordinatorProxy::createImageBacking):
(WebKit::LayerTreeCoordinatorProxy::updateImageBacking):
(WebKit):
(WebKit::LayerTreeCoordinatorProxy::removeImageBacking):
* UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.h:
(LayerTreeCoordinatorProxy):
* UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.messages.in:
* UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp:
(WebKit::LayerTreeRenderer::setLayerState):
(WebKit::LayerTreeRenderer::createImageBacking):
(WebKit::LayerTreeRenderer::updateImageBacking):
(WebKit::LayerTreeRenderer::removeImageBacking):
(WebKit):
(WebKit::LayerTreeRenderer::assignImageBackingToLayer):
(WebKit::LayerTreeRenderer::removeReleasedImageBackingsIfNeeded):
(WebKit::LayerTreeRenderer::flushLayerChanges):
(WebKit::LayerTreeRenderer::purgeGLResources):
* UIProcess/CoordinatedGraphics/LayerTreeRenderer.h:
(LayerTreeRenderer):
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::setContentsToImage):
(WebCore::CoordinatedGraphicsLayer::syncImageBacking):
(WebCore::CoordinatedGraphicsLayer::releaseImageBackingIfNeeded):
(WebCore::CoordinatedGraphicsLayer::beginContentUpdate):
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:
(CoordinatedGraphicsLayerClient):
(CoordinatedGraphicsLayer):
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedImageBacking.cpp: Added.
(WebKit):
(WebKit::CoordinatedImageBacking::getCoordinatedImageBackingID):
(WebKit::CoordinatedImageBacking::create):
(WebKit::CoordinatedImageBacking::CoordinatedImageBacking):
(WebKit::CoordinatedImageBacking::~CoordinatedImageBacking):
(WebKit::CoordinatedImageBacking::addLayerClient):
(WebKit::CoordinatedImageBacking::removeLayerClient):
(WebKit::CoordinatedImageBacking::markDirty):
(WebKit::CoordinatedImageBacking::update):
(WebKit::CoordinatedImageBacking::releaseSurfaceIfNeeded):
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedImageBacking.h: Added.
(WebCore):
(WebKit):
(CoordinatedImageBacking):
(Coordinator):
(WebKit::CoordinatedImageBacking::id):
* WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:
(WebKit::LayerTreeCoordinator::flushPendingLayerChanges):
(WebKit::LayerTreeCoordinator::createImageBackingIfNeeded):
(WebKit::LayerTreeCoordinator::createImageBacking):
(WebKit::LayerTreeCoordinator::updateImageBacking):
(WebKit::LayerTreeCoordinator::removeImageBacking):
(WebKit::LayerTreeCoordinator::flushPendingImageBackingChanges):
(WebKit::LayerTreeCoordinator::purgeBackingStores):
* WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.h:
(LayerTreeCoordinator):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake OpenTypeVerticalData be ref-counted
bashi@chromium.org [Fri, 16 Nov 2012 01:55:00 +0000 (01:55 +0000)]
Make OpenTypeVerticalData be ref-counted
https://bugs.webkit.org/show_bug.cgi?id=101971

Reviewed by Tony Chang.

FontCache::purgeInactiveFontData() uses mark & sweep algorithm to remove unused
OpenTypeVerticalData objects. It marks only OpenTypeVerticalData which can be reached
via SimpleFontData in gFontDataCache. However, OpenTypeVerticalData can be referred by
SimpleFontData which resides in CSSFontFaceSource::m_fontDataTable so the algorithm can
delete active OpenTypeVerticalData. To avoid deleting active OpenTypeVerticalData, make
it be ref-counted.

No new tests. No changes in behavior. Checked manually that the use-after-free was fixed.

* platform/graphics/FontCache.cpp:
(WebCore): Use RefPtr instead of OwnPtr for FontVerticalDataCache.
(WebCore::FontCache::getVerticalData): Return PassRefPtr<OpenTypeVerticalData>.
(WebCore::FontCache::purgeInactiveFontData): Follow the change of OwnPtr -> RefPtr.
* platform/graphics/FontCache.h:
* platform/graphics/SimpleFontData.cpp:
(WebCore::SimpleFontData::SimpleFontData):
* platform/graphics/SimpleFontData.h:
Use RefPtr instead of raw const pointer for OpenTypeVerticalData.
(WebCore::SimpleFontData::verticalData):
* platform/graphics/chromium/FontPlatformDataChromiumWin.cpp:
(WebCore::FontPlatformData::verticalData): Return PassRefPtr<OpenTypeVerticalData>.
* platform/graphics/chromium/FontPlatformDataChromiumWin.h:
(FontPlatformData):
* platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.cpp:
(WebCore::FontPlatformData::verticalData): Ditto.
* platform/graphics/harfbuzz/FontPlatformDataHarfBuzz.h:
(WebCore):
(FontPlatformData):
* platform/graphics/opentype/OpenTypeVerticalData.h:
(WebCore::OpenTypeVerticalData::create): Added.
(OpenTypeVerticalData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUse complex path for the reference text in fast/text/international/combining-marks...
bashi@chromium.org [Fri, 16 Nov 2012 01:39:29 +0000 (01:39 +0000)]
Use complex path for the reference text in fast/text/international/combining-marks-position.html
https://bugs.webkit.org/show_bug.cgi?id=101009

Reviewed by Kent Tamura.

Arial has a kerning pair for U+043A U+0430 so the width of the text can be
different between simple path and complex path. Use text-rendering: optimizeLegibility
to force using complex text for reference text.

* fast/text/international/combining-marks-position.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Skipped media/video-src-blob.html on Windows.
roger_fong@apple.com [Fri, 16 Nov 2012 01:32:37 +0000 (01:32 +0000)]
Unreviewed. Skipped media/video-src-blob.html on Windows.
Blob not enabled on Windows.

* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCoordinated Graphics: A Minor optimization of calculating transforms in CoordinagedGr...
commit-queue@webkit.org [Fri, 16 Nov 2012 01:22:03 +0000 (01:22 +0000)]
Coordinated Graphics: A Minor optimization of calculating transforms in CoordinagedGraphicsLayer.
https://bugs.webkit.org/show_bug.cgi?id=102309

We calculate an inverse transform each tiledBackingStoreVisibleRect() call by
a TiledBackingStore and every tiles.
This patch caches the inverse transform to reuse it.

Patch by Huang Dongsung <luxtella@company100.net> on 2012-11-15
Reviewed by Noam Rosenthal.

* WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::tiledBackingStoreVisibleRect):
(WebCore::CoordinatedGraphicsLayer::computeTransformedVisibleRect):
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:
(CoordinatedGraphicsLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoOptimize the multiply-add in Biquad.cpp::process
commit-queue@webkit.org [Fri, 16 Nov 2012 01:19:50 +0000 (01:19 +0000)]
Optimize the multiply-add in Biquad.cpp::process
https://bugs.webkit.org/show_bug.cgi?id=75528

Patch by Xingnan Wang <xingnan.wang@intel.com> on 2012-11-15
Reviewed by Brent Fulgham.

Pipeline the multiply-add with SSE2 intrinsics.
Get ~45% performance improvement for the function.

* platform/audio/Biquad.cpp:
(WebCore::Biquad::process):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIndexedDB: setVersion batch 8
dgrogan@chromium.org [Fri, 16 Nov 2012 01:14:12 +0000 (01:14 +0000)]
IndexedDB: setVersion batch 8
https://bugs.webkit.org/show_bug.cgi?id=102434

Reviewed by Tony Chang.

2 lines were added to intversion-bad-parameters to capture the tests
that were in the now-deleted setVersion-{null,undefined}.

* storage/indexeddb/intversion-bad-parameters-expected.txt:
* storage/indexeddb/key-generator-expected.txt:
* storage/indexeddb/open-during-transaction-expected.txt:
* storage/indexeddb/readonly-properties-expected.txt:
* storage/indexeddb/resources/intversion-bad-parameters.js:
(deleteSuccess):
* storage/indexeddb/resources/key-generator.js:
  Again awkward to call indexedDBTest all over the place. The prefix
  line's gotta go, and we could also pull a resetDatabase method out of
  indexedDBTest that would just do a delete and open.

(runTests.nextTest.prepareDatabase):
(runTests.nextTest.onSuccess.finishTest):
(runTests.nextTest.onSuccess):
(runTests.nextTest):
(testAcrossConnections.prepareDatabase):
* storage/indexeddb/resources/open-during-transaction.js:
(prepareDatabase.event.target.transaction.oncomplete):
(prepareDatabase):
(tryOpens):
* storage/indexeddb/resources/readonly-properties.js:
(prepareDatabase):
* storage/indexeddb/resources/setVersion-null.js: Removed.
* storage/indexeddb/resources/setVersion-undefined.js: Removed.
* storage/indexeddb/resources/transaction-after-close.js:
(prepareDatabase):
(firstTransactionComplete):
(onFinalPutSuccess):
* storage/indexeddb/resources/versionchangerequest-activedomobject.js:
(testSetVersion):
(upgradeNeededCallback):
(successCallback):
* storage/indexeddb/setVersion-null-expected.txt: Removed.
* storage/indexeddb/setVersion-null.html: Removed.
* storage/indexeddb/setVersion-undefined-expected.txt: Removed.
* storage/indexeddb/setVersion-undefined.html: Removed.
* storage/indexeddb/transaction-after-close-expected.txt:
* storage/indexeddb/versionchangerequest-activedomobject-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd tests for explicit serialization values
alecflett@chromium.org [Fri, 16 Nov 2012 01:07:26 +0000 (01:07 +0000)]
Add tests for explicit serialization values
https://bugs.webkit.org/show_bug.cgi?id=96818

Reviewed by Adam Barth.

Source/WebCore:

Expose direct access to the serialization/deserialization mechanisms
of SerializedScriptValue to DumpRenderTree.

* testing/Internals.cpp:
(WebCore::Internals::serializeObject):
(WebCore):
(WebCore::Internals::deserializeBuffer):
* testing/Internals.h:
(WebCore):
* testing/Internals.idl:

Source/WebKit2:

Add exports for SerializedScriptValue changes.

* win/WebKit2.def:
* win/WebKit2CFLite.def:

LayoutTests:

Make sure SerializedScriptValues are backward compatible with future changes.

* platform/chromium/fast/storage/serialized-script-value.html: Added.
* platform/chromium/fast/storage/serialized-script-value.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Split WebCore/platform into a separate library
kov@webkit.org [Fri, 16 Nov 2012 01:05:18 +0000 (01:05 +0000)]
[GTK] Split WebCore/platform into a separate library
https://bugs.webkit.org/show_bug.cgi?id=94435

Reviewed by Martin Robinson.

More people have been reporting problems when linking WebCore because
the command line limit is being exceeded. Splitting WebCore a bit more
is in order.

.:

* GNUmakefile.am: add variable that will hold the list of source files
for libWebCorePlatform .

Source/WebCore:

* GNUmakefile.am: add new libWebCorePlatform convenience library.
* GNUmakefile.list.am: move list of platform/* files to its own variable.

Source/WebKit/gtk:

* GNUmakefile.am: link libWebCorePlatform into libwebkitgtk

Source/WebKit2:

* GNUmakefile.am: link libWebCorePlatform into libwebkit2gtk

Tools:

* GNUmakefile.am: link libWebCorePlatform into DRT

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Add missing text test expectations for Mac and Windows ports.
roger_fong@apple.com [Fri, 16 Nov 2012 00:56:12 +0000 (00:56 +0000)]
Unreviewed. Add missing text test expectations for Mac and Windows ports.

* platform/mac/css3/filters/effect-reference-ordering-hw-expected.txt: Added.
* platform/mac/fast/css/text-overflow-input-expected.txt: Added.
* platform/mac/fast/forms/input-readonly-dimmed-expected.txt: Added.
* platform/mac/fast/forms/input-text-scroll-left-on-blur-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove unused macro HANDLE_INHERIT_AND_INITIAL_WITH_VALUE in StyleResolver.cpp
macpherson@chromium.org [Fri, 16 Nov 2012 00:49:03 +0000 (00:49 +0000)]
Remove unused macro HANDLE_INHERIT_AND_INITIAL_WITH_VALUE in StyleResolver.cpp
https://bugs.webkit.org/show_bug.cgi?id=102036

Reviewed by Darin Adler.

Remove HANDLE_INHERIT_AND_INITIAL_WITH_VALUE macro, as it is not used anywhere.

No tests added because code is unused, and compile is enough to verify that conculsively.

* css/StyleResolver.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Updated chromium test expectations to clean up some passed
jianli@chromium.org [Fri, 16 Nov 2012 00:47:01 +0000 (00:47 +0000)]
Unreviewed. Updated chromium test expectations to clean up some passed
tests.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate DOMException name: SyntaxError
arv@chromium.org [Fri, 16 Nov 2012 00:42:00 +0000 (00:42 +0000)]
Update DOMException name: SyntaxError
https://bugs.webkit.org/show_bug.cgi?id=102279

Reviewed by Kentaro Hara.

Source/WebCore:

Patch 12 of 25 to update DOMException name to match the spec and Firefox.

Updated existing tests.

* dom/DOMCoreException.cpp:

LayoutTests:

Updated tests and expectations.

* fast/canvas/canvas-gradient-addStop-error-expected.txt:
* fast/canvas/canvas-pattern-behaviour-expected.txt:
* fast/canvas/gradient-addColorStop-with-invalid-color-expected.txt:
* fast/canvas/script-tests/gradient-addColorStop-with-invalid-color.js:
* fast/css/css3-nth-tokens-script-expected.txt:
* fast/css/css3-nth-tokens-script.html:
* fast/dom/HTMLElement/insertAdjacentHTML-errors-expected.txt:
* fast/dom/HTMLElement/script-tests/insertAdjacentHTML-errors.js:
* fast/dom/HTMLElement/set-invalid-value-expected.txt:
* fast/dom/HTMLElement/set-invalid-value.html:
* fast/dom/SelectorAPI/dumpNodeList-almost-strict-expected.txt:
* fast/dom/SelectorAPI/dumpNodeList-expected.txt:
* fast/dom/Window/custom-constructors-expected.txt:
* fast/dom/Window/invalid-protocol-expected.txt:
* fast/dom/css-mediarule-functions-expected.txt:
* fast/dom/css-mediarule-functions.html:
* fast/dom/dataset-expected.txt:
* fast/dom/dataset-xhtml-expected.txt:
* fast/dom/element-attribute-js-null-expected.txt:
* fast/dom/register-protocol-handler.html:
* fast/dom/script-tests/dataset-xhtml.js:
* fast/dom/script-tests/dataset.js:
* fast/dom/xhtml-fragment-parsing-exceptions-expected.txt:
* fast/dynamic/insertAdjacentHTML-expected.txt:
* fast/eventsource/eventsource-constructor-expected.txt:
* fast/innerHTML/innerHTML-changing-document-properties-expected.txt:
* fast/mutation/observe-exceptions-expected.txt:
* fast/workers/worker-constructor-expected.txt:
* http/tests/security/postMessage/invalid-origin-throws-exception-expected.txt:
* http/tests/security/postMessage/target-origin-expected.txt:
* http/tests/websocket/tests/hybi/bad-sub-protocol-empty-expected.txt:
* http/tests/websocket/tests/hybi/bad-sub-protocol-non-ascii-expected.txt:
* http/tests/websocket/tests/hybi/close-expected.txt:
* http/tests/websocket/tests/hybi/close-reason-too-long-expected.txt:
* http/tests/websocket/tests/hybi/close-reason-too-long.html:
* http/tests/websocket/tests/hybi/close.html:
* http/tests/websocket/tests/hybi/invalid-subprotocol-characters-expected.txt:
* http/tests/websocket/tests/hybi/invalid-subprotocol-characters.html:
* http/tests/websocket/tests/hybi/invalid-subprotocols-expected.txt:
* http/tests/websocket/tests/hybi/invalid-subprotocols.html:
* http/tests/websocket/tests/hybi/url-parsing-expected.txt:
* http/tests/xmlhttprequest/inject-header-expected.txt:
* http/tests/xmlhttprequest/xmlhttprequest-open-empty-method-expected.txt:
* http/tests/xmlhttprequest/xmlhttprequest-setrequestheader-no-name-expected.txt:
* platform/chromium-linux/fast/media/mq-js-media-except-02-expected.png:
* platform/chromium-linux/fast/media/mq-js-media-except-03-expected.png:
* platform/chromium-mac/fast/dom/SelectorAPI/dumpNodeList-almost-strict-expected.txt:
* platform/chromium-mac/fast/dom/SelectorAPI/dumpNodeList-expected.txt:
* platform/chromium-win/fast/dom/SelectorAPI/dumpNodeList-almost-strict-expected.txt:
* platform/chromium-win/fast/dom/SelectorAPI/dumpNodeList-expected.txt:
* platform/chromium-win/fast/media/mq-js-media-except-02-expected.txt:
* platform/chromium-win/fast/media/mq-js-media-except-03-expected.txt:
* platform/chromium-win/fast/workers/worker-constructor-expected.txt:
* platform/chromium-win/websocket/tests/bad-sub-protocol-non-ascii-expected.txt:
* platform/chromium-win/websocket/tests/url-parsing-expected.txt:
* platform/chromium/canvas/philip/tests/2d.missingargs-expected.txt:
* platform/chromium/fast/dom/register-protocol-handler-expected.txt:
* platform/chromium/fast/media/mq-js-media-except-02-expected.txt:
* platform/chromium/fast/media/mq-js-media-except-03-expected.txt:
* platform/chromium/fast/workers/worker-constructor-expected.txt:
* platform/chromium/http/tests/websocket/tests/hixie76/url-parsing-expected.txt:
* platform/chromium/http/tests/websocket/tests/hybi/bad-sub-protocol-control-chars-expected.txt:
* platform/chromium/http/tests/websocket/tests/hybi/url-parsing-expected.txt:
* platform/efl/fast/media/mq-js-media-except-02-expected.txt:
* platform/efl/fast/media/mq-js-media-except-03-expected.txt:
* platform/gtk/fast/media/mq-js-media-except-02-expected.txt:
* platform/gtk/fast/media/mq-js-media-except-03-expected.txt:
* platform/mac/canvas/philip/tests/2d.missingargs-expected.txt:
* platform/mac/fast/media/mq-js-media-except-02-expected.txt:
* platform/mac/fast/media/mq-js-media-except-03-expected.txt:
* platform/qt-5.0-wk2/http/tests/websocket/tests/hybi/bad-sub-protocol-non-ascii-expected.txt:
* platform/qt/fast/media/mq-js-media-except-02-expected.txt:
* platform/qt/fast/media/mq-js-media-except-03-expected.txt:
* platform/qt/http/tests/websocket/tests/hixie76/bad-sub-protocol-non-ascii-expected.txt:
* platform/qt/http/tests/websocket/tests/hybi/bad-sub-protocol-non-ascii-expected.txt:
* svg/dom/SVGAngle-expected.txt:
* transforms/cssmatrix-2d-interface-expected.txt:
* transforms/cssmatrix-3d-interface-expected.txt:
* webintents/web-intents-api-expected.txt:
* webintents/web-intents-api.html:
* webintents/web-intents-obj-constructor-expected.txt:
* webintents/web-intents-obj-constructor.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCallData.h should have correct indentation.
fpizlo@apple.com [Fri, 16 Nov 2012 00:40:05 +0000 (00:40 +0000)]
CallData.h should have correct indentation.

Rubber stamped by Mark Hahneberg.

* runtime/CallData.h:
(JSC):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoClean up some TestExpectations for tests that pass now.
jamesr@google.com [Fri, 16 Nov 2012 00:39:27 +0000 (00:39 +0000)]
Clean up some TestExpectations for tests that pass now.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove methodCallDummy since it is not used anymore.
fpizlo@apple.com [Fri, 16 Nov 2012 00:37:58 +0000 (00:37 +0000)]
Remove methodCallDummy since it is not used anymore.

Rubber stamped by Mark Hahnenberg.

* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
(JSC):
(JSC::JSGlobalObject::visitChildren):
* runtime/JSGlobalObject.h:
(JSGlobalObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Win] key event's location does not work on Windows platform.
bfulgham@webkit.org [Fri, 16 Nov 2012 00:30:14 +0000 (00:30 +0000)]
[Win] key event's location does not work on Windows platform.
https://bugs.webkit.org/show_bug.cgi?id=89742

Patch by Takashi Sakamoto <tasak@google.com> on 2012-11-15
Reviewed by Brent Fulgham.

As WM_KEYDOWN, WM_KEYUP, WM_SYSKEYDOWN, and WM_SYSKEYUP doesn't
directly provide a virtual keycode which distinguish between left-hand
and right-hand keys. To obtain a virtual keycode, we have to look at
lparam, i.e. scancode and extended key bit. So if the given virtual
keycode is control, shift, or menu, use MapVirtualKey with scancode and
extended key bit and recreate a virtual keycode which distinguishes
between left-hand and right-hand.

No new tests, because left-hand keys, right-hand keys layout tests
have been already added.

* platform/win/KeyEventWin.cpp:
(WebCore::windowsKeycodeWithLocation):
Use wparam and lparam to recreate a virtual keycode which distinguishes
between left-hand and right-hand if the given wparam (=virtual keycode)
is control, shift, or menu.
(WebCore):
(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
Use the newly added function to obtain windows virtual keycode.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIndexedDB setVersion-removal batch 7
dgrogan@chromium.org [Fri, 16 Nov 2012 00:29:23 +0000 (00:29 +0000)]
IndexedDB setVersion-removal batch 7
https://bugs.webkit.org/show_bug.cgi?id=102415

Reviewed by Tony Chang.

* storage/indexeddb/mozilla/object-store-remove-values-expected.txt:
* storage/indexeddb/mozilla/readyState-expected.txt:
* storage/indexeddb/mozilla/resources/object-store-remove-values.js:
* storage/indexeddb/mozilla/resources/readyState.js:
  Moved one check into shared.js, a few others around, and the check
  for setVersion's request.readyState==pending is deleted.

* storage/indexeddb/mozilla/resources/versionchange-abort.js:
  First test I've converted that makes the initial open fail, but
  request.onsuccess is unhooked to not cause the whole test to fail.

(prepareDatabase):
(postAbort):
* storage/indexeddb/mozilla/versionchange-abort-expected.txt:
* storage/indexeddb/objectstore-basics-expected.txt:
* storage/indexeddb/objectstore-basics-workers-expected.txt:
* storage/indexeddb/odd-strings-expected.txt:
* storage/indexeddb/readonly-expected.txt:
* storage/indexeddb/resources/objectstore-basics.js:
* storage/indexeddb/resources/odd-strings.js:
* storage/indexeddb/resources/readonly.js:
  Moved the checks at the beginning to the end of the test, but
  everything was preserved.

* storage/indexeddb/resources/shared.js:
  Moved a check from readyState to here as the readyState layout test
  doesn't have access to the open request before any events are fired.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Don't assert when notifyAuthReceived is called with a different auth...
commit-queue@webkit.org [Fri, 16 Nov 2012 00:23:28 +0000 (00:23 +0000)]
[BlackBerry] Don't assert when notifyAuthReceived is called with a different auth type
https://bugs.webkit.org/show_bug.cgi?id=102436

Patch by Joe Mason <jmason@rim.com> on 2012-11-15
Reviewed by Rob Buis.

The server type could change if we contact a site taking HTTP auth, through an HTTP proxy
taking auth of its own. First we get a 407 from the proxy, and then when get past the
proxy, we get a 401 from the end site - so notifyAuthReceived gets called again with auth
type Proxy instead of HTTP.

The correct thing to do when that happens is skip the "update the auth type in the
credentials" step, since these are actually new credentials and not just credentials being
reused for a different auth type on the same server.

PR 241637

* platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::notifyAuthReceived):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIgnore autocomplete=off for chrome generated passwords.
commit-queue@webkit.org [Fri, 16 Nov 2012 00:23:13 +0000 (00:23 +0000)]
Ignore autocomplete=off for chrome generated passwords.
https://bugs.webkit.org/show_bug.cgi?id=102426

Patch by Yue Zhang <zysxqn@google.com> on 2012-11-15
Reviewed by Adam Barth.

Record the autocomplete attribute in the web password form data,
so that we can handle autocomplete in chromium code. The
motivation/background is: we should ignore autocomplete=off field
for password forms with chrome generated passwords (has passed
security review). By handling autocomplete in chromium code we can
distinguish password forms with chrome generated passwords and
those normal password forms. Note that we haven't turned off
checking autocomplete=off in the Webkit code for now so there is
no behavior change after this CL, and we will turn off after we
make the chromium side change to be safe.

* public/WebPasswordFormData.h:
(WebPasswordFormData):
* src/WebPasswordFormData.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agompath elements do not clear resource lists before destruction
schenney@chromium.org [Fri, 16 Nov 2012 00:22:02 +0000 (00:22 +0000)]
mpath elements do not clear resource lists before destruction
https://bugs.webkit.org/show_bug.cgi?id=101505

Reviewed by Abhishek Arya.

Source/WebCore:

The destructor for SVGMPathElement should clear its resources before
deletion, so as not to leave hanging pointers in resource lists.

Test: svg/animations/mpath-remove-from-dependents-on-delete-crash.html

* svg/SVGMPathElement.cpp:
(WebCore::SVGMPathElement::~SVGMPathElement): Add destructor that calls clearResourceReferences.
(WebCore):
* svg/SVGMPathElement.h:
(SVGMPathElement): Add destructor.

LayoutTests:

Test that causes a mpath element to be deleted before the path that it
references.

* svg/animations/mpath-remove-from-dependents-on-delete-crash-expected.html: Added.
* svg/animations/mpath-remove-from-dependents-on-delete-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Stop using the WebCompositorSupport methods for changing settings
danakj@chromium.org [Fri, 16 Nov 2012 00:17:56 +0000 (00:17 +0000)]
[chromium] Stop using the WebCompositorSupport methods for changing settings
https://bugs.webkit.org/show_bug.cgi?id=101968

Reviewed by James Robinson.

* DumpRenderTree/chromium/TestShell.cpp:
* DumpRenderTree/chromium/TestShell.h:
(TestShell::setPerTilePaintingEnabled):
(TestShell::setAcceleratedAnimationEnabled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove CodeGenerator::StripModule
haraken@chromium.org [Fri, 16 Nov 2012 00:16:35 +0000 (00:16 +0000)]
Remove CodeGenerator::StripModule
https://bugs.webkit.org/show_bug.cgi?id=102338

Reviewed by Adam Barth.

Now WebKit IDL files have no modules. (The Web IDL spec has no modules.)
We can remove CodeGenerator::StripModule.
This might break some internal builds if the internal builds are still
using modules. Ping haraken@ you observe it.

No tests. No change in behavior.

* bindings/scripts/CodeGenerator.pm:
(ForAllParents):
(AttributeNameForGetterAndSetter):
(IsStrictSubtype):
* bindings/scripts/CodeGeneratorCPP.pm:
(GetClassName):
(GetImplClassName):
(GetParentImplClassName):
(GetParent):
(ConversionNeeded):
(GetCPPTypeGetter):
(AddForwardDeclarationsForType):
(AddIncludesForType):
(GenerateImplementation):
* bindings/scripts/CodeGeneratorGObject.pm:
(GetParentClassName):
(GetParentGObjType):
(GetClassName):
* bindings/scripts/CodeGeneratorJS.pm:
(GetParentClassName):
(AddIncludesForTypeInImpl):
(AddIncludesForTypeInHeader):
(GenerateParametersCheckExpression):
(GenerateImplementation):
(GenerateParametersCheck):
(GetNativeTypeFromSignature):
(JSValueToNative):
(NativeToJSValue):
* bindings/scripts/CodeGeneratorObjC.pm:
(GetClassName):
(GetImplClassName):
(GetParentImplClassName):
(GetParentAndProtocols):
(GetPropertyAttributes):
(ConversionNeeded):
(GetObjCTypeGetter):
(AddForwardDeclarationsForType):
(AddIncludesForType):
(GenerateImplementation):
* bindings/scripts/CodeGeneratorV8.pm:
(AddIncludesForType):
(GenerateHeader):
(IsSubType):
(GenerateSingleBatchedAttribute):
(GenerateImplementation):
(BaseInterfaceName):
(GetTypeFromSignature):
(IsWrapperType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. CSS3_TEXT is not enabled on Windows.
roger_fong@apple.com [Fri, 16 Nov 2012 00:16:28 +0000 (00:16 +0000)]
Unreviewed. CSS3_TEXT is not enabled on Windows.
Skipping tests:
fast/css3-text/css3-text-align-last/getComputedStyle/getComputedStyle-text-align-last-inherited.html
fast/css3-text/css3-text-align-last/getComputedStyle/getComputedStyle-text-align-last.html
fast/css3-text/css3-text-decoration/getComputedStyle/getComputedStyle-text-decoration-line.html

* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Test expectations - we're passing!
schenney@chromium.org [Fri, 16 Nov 2012 00:13:34 +0000 (00:13 +0000)]
[Chromium] Test expectations - we're passing!

Unreviewed expectations for canvas-shadow.html

* platform/chromium-linux-x86/platform/chromium/virtual/gpu/fast/canvas/canvas-shadow-expected.txt: Added.
* platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/canvas-shadow-expected.txt: Added.
* platform/chromium-win-xp/platform/chromium/virtual/gpu/fast/canvas/canvas-shadow-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake assumptions about m_parentStyle consistent within StyleResolver::applyProperty()
macpherson@chromium.org [Fri, 16 Nov 2012 00:13:29 +0000 (00:13 +0000)]
Make assumptions about m_parentStyle consistent within StyleResolver::applyProperty()
https://bugs.webkit.org/show_bug.cgi?id=101696

Reviewed by Tony Chang.

Most of the code in StyleResolver::applyProperty assumes that isInherit implies that m_parentStyle is available.
This patch ASSERTs that this assumption is correct, and removes the few existing checks to maintain consistency.

No new tests / covered by all existing CSS tests.

* css/StyleResolver.cpp:
(WebCore::StyleResolver::applyProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[V8] Remove redundant $interfaceName from function parameters
haraken@chromium.org [Fri, 16 Nov 2012 00:12:17 +0000 (00:12 +0000)]
[V8] Remove redundant $interfaceName from function parameters
https://bugs.webkit.org/show_bug.cgi?id=102334

Reviewed by Adam Barth.

'sub func { my $dataNode = shift; my $interfaceName = shift; }'
is redundant. We can get $interfaceName by $dataNode->name.

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateOpaqueRootForGC):
(GenerateHeader):
(GenerateConstructorGetter):
(GenerateNormalAttrGetter):
(GenerateReplaceableAttrSetter):
(GenerateNormalAttrSetter):
(GenerateOverloadedFunctionCallback):
(GenerateFunctionCallback):
(GenerateOverloadedConstructorCallback):
(GenerateSingleConstructorCallback):
(GenerateConstructorCallback):
(GenerateEventConstructorCallback):
(GenerateTypedArrayConstructorCallback):
(GenerateNamedConstructorCallback):
(GenerateBatchedAttributeData):
(GenerateImplementation):
(GenerateToV8Converters):
(GetNativeTypeForConversions):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIndexedDB: remove setVersion from intversion-long-queue
dgrogan@chromium.org [Fri, 16 Nov 2012 00:10:21 +0000 (00:10 +0000)]
IndexedDB: remove setVersion from intversion-long-queue
https://bugs.webkit.org/show_bug.cgi?id=102322

Reviewed by Tony Chang.

This test probably doesn't provide as much value as it used to but
tests like this, where there's a long sequence of interdependent
events, have caught stuff for us in the past. There are endless
variants that will all exercise our code differently.

* storage/indexeddb/intversion-long-queue-expected.txt:
* storage/indexeddb/resources/intversion-long-queue.js:
(prepareDatabase):
(connection1Success):
(connection1VersionChangeCallback):
(connection2Blocked):
(deleteDatabaseBlockedCallback):
(deleteDatabaseSuccessCallback):
(connection2UpgradeNeeded):
(connection2Success):
(connection2TransactionComplete):
(connection2VersionChangeEvent):
(connection3UpgradeNeeded):
(connection3Success):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoEnsure that scrollbar layers show debug borders
simon.fraser@apple.com [Thu, 15 Nov 2012 23:46:07 +0000 (23:46 +0000)]
Ensure that scrollbar layers show debug borders
https://bugs.webkit.org/show_bug.cgi?id=102429

Reviewed by Anders Carlsson.

After r133517, scrollbar layers no longer showed debug borders, which
was very confusing. Fix this by explicitly calling setShowDebugBorder()
on the scrollbar-related layers owned by RenderLayerCompositor
and RenderLayerBacking.

* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateDebugIndicators):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::cacheAcceleratedCompositingFlags):
(WebCore::RenderLayerCompositor::updateOverflowControlsLayers):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoASSERTION FAILED: fastAttributeLookupAllowed(name) for 7 layout tests
akling@apple.com [Thu, 15 Nov 2012 23:43:15 +0000 (23:43 +0000)]
ASSERTION FAILED: fastAttributeLookupAllowed(name) for 7 layout tests
<http://webkit.org/b/102423>

Reviewed by Anders Carlsson.

Use Element::getAttributeItem() to find out if the element has a given attribute
instead of fastHasAttribute() since that causes assertions for the "style" attribute.

* html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::mergeAttributesFromTokenIntoElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. More subpixel layout test rebaselines for Windows.
roger_fong@apple.com [Thu, 15 Nov 2012 23:33:29 +0000 (23:33 +0000)]
Unreviewed. More subpixel layout test rebaselines for Windows.

* platform/win/fast/multicol/vertical-rl/float-multicol-expected.txt: Added.
* platform/win/fast/multicol/vertical-rl/nested-columns-expected.txt: Added.
* platform/win/scrollbars/custom-scrollbar-with-incomplete-style-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate DOMException name: DOMStringSizeError
arv@chromium.org [Thu, 15 Nov 2012 23:26:16 +0000 (23:26 +0000)]
Update DOMException name: DOMStringSizeError
https://bugs.webkit.org/show_bug.cgi?id=102089

Reviewed by Ojan Vafai.

Patch 2 of 25 to update DOMException name to match the spec and Firefox.

DOMSTRING_SIZE_ERR is historical and not used in any spec or in our code.

* dom/DOMCoreException.cpp:
* dom/ExceptionCode.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed gardening.
arv@chromium.org [Thu, 15 Nov 2012 23:24:00 +0000 (23:24 +0000)]
Unreviewed gardening.

Rebaselining pixel tests after r102427

* platform/chromium-mac-lion/svg/custom/baseval-animval-equality-expected.png:
* platform/chromium-mac-lion/svg/custom/baseval-animval-equality-expected.txt: Copied from LayoutTests/platform/gtk/svg/custom/baseval-animval-equality-expected.txt.
* platform/chromium-mac-lion/svg/dom/SVGLengthList-basics-expected.png:
* platform/chromium-mac-snowleopard/svg/custom/baseval-animval-equality-expected.png:
* platform/chromium-mac-snowleopard/svg/custom/baseval-animval-equality-expected.txt: Copied from LayoutTests/platform/gtk/svg/custom/baseval-animval-equality-expected.txt.
* platform/chromium-mac-snowleopard/svg/dom/SVGLengthList-basics-expected.png:
* platform/chromium-mac/svg/dom/SVGLengthList-basics-expected.png:
* platform/chromium-win-xp/svg/custom/baseval-animval-equality-expected.png: Added.
* platform/chromium-win-xp/svg/dom/SVGLengthList-basics-expected.png: Added.
* platform/efl-wk1/svg/dom/SVGLengthList-basics-expected.png: Renamed from LayoutTests/platform/efl/svg/dom/SVGLengthList-basics-expected.png.
* platform/gtk/svg/custom/baseval-animval-equality-expected.txt:
* platform/mac-lion/svg/custom/baseval-animval-equality-expected.txt: Copied from LayoutTests/platform/gtk/svg/custom/baseval-animval-equality-expected.txt.
* platform/mac-wk2/svg/custom/baseval-animval-equality-expected.txt: Copied from LayoutTests/platform/gtk/svg/custom/baseval-animval-equality-expected.txt.
* platform/qt/svg/custom/baseval-animval-equality-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIndexedDB: Indexing tests are flaky-crashing
jsbell@chromium.org [Thu, 15 Nov 2012 23:17:32 +0000 (23:17 +0000)]
IndexedDB: Indexing tests are flaky-crashing
https://bugs.webkit.org/show_bug.cgi?id=102283

Reviewed by Tony Chang.

Source/WebCore:

Processing the final task can cause IDBTransactionBackendImpl references to be released
by all holders. Prior to looping over the tasks (or, in an even earlier implementation,
swapping queues) control would fall off the end of the function. The loop termination
check introduced in http://wkrev.com/134529 requires that |this| be kept alive until
the method completes.

Test: storage/indexeddb/transaction-crash-in-tasks.html

* Modules/indexeddb/IDBTransactionBackendImpl.cpp:
(WebCore::IDBTransactionBackendImpl::abort): Rename self => protect.
(WebCore::IDBTransactionBackendImpl::commit): Rename self => protect.
(WebCore::IDBTransactionBackendImpl::taskTimerFired): New self-ref.

LayoutTests:

Reduced repro case, although the behavior is still flaky.

* storage/indexeddb/transaction-crash-in-tasks-expected.txt: Added.
* storage/indexeddb/transaction-crash-in-tasks.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Create default directory so that cq can apply patch
commit-queue@webkit.org [Thu, 15 Nov 2012 23:01:37 +0000 (23:01 +0000)]
[chromium] Create default directory so that cq can apply patch
https://bugs.webkit.org/show_bug.cgi?id=102421

Patch by Scott Violet <sky@chromium.org> on 2012-11-15
Reviewed by Tony Chang.

Done in hopes of patch that copies files to this directory working.

Source/Platform:

* chromium/public/default: Added.

Source/WebKit/chromium:

* public/platform/default: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. HiDPI is not enabled on Windows (as indicated by test result). Adding...
roger_fong@apple.com [Thu, 15 Nov 2012 22:56:28 +0000 (22:56 +0000)]
Unreviewed. HiDPI is not enabled on Windows (as indicated by test result). Adding failing expected result.

* platform/win/fast/canvas/canvas-resize-reset-pixelRatio-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. WebGL not supported on Windows. Skipping fast/images/webgl-teximage2d...
roger_fong@apple.com [Thu, 15 Nov 2012 22:42:42 +0000 (22:42 +0000)]
Unreviewed. WebGL not supported on Windows. Skipping fast/images/webgl-teximage2d.html.

* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Remove unused debug border setters from the WebLayer API
danakj@chromium.org [Thu, 15 Nov 2012 22:07:37 +0000 (22:07 +0000)]
[chromium] Remove unused debug border setters from the WebLayer API
https://bugs.webkit.org/show_bug.cgi?id=102274

Reviewed by James Robinson.

* chromium/public/WebLayer.h:
(WebLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Update chromium test expectations.
jianli@chromium.org [Thu, 15 Nov 2012 22:07:00 +0000 (22:07 +0000)]
Unreviewed. Update chromium test expectations.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMutationObserver wrapper should not be collected while still observing
commit-queue@webkit.org [Thu, 15 Nov 2012 21:48:03 +0000 (21:48 +0000)]
MutationObserver wrapper should not be collected while still observing
https://bugs.webkit.org/show_bug.cgi?id=102328

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-11-15
Reviewed by Adam Barth.

Source/WebCore:

Make MutationObserver an ActiveDOMObject so that the wrapper is not
collected while it is still observing the DOM. This is needed because
the wrapper is passed into the callback and expandos on the wrapper
should be preserved.

Test: fast/mutation/observer-wrapper-dropoff.html

* bindings/js/JSMutationObserverCustom.cpp:
(WebCore::JSMutationObserverConstructor::constructJSMutationObserver):
* bindings/v8/custom/V8MutationObserverCustom.cpp:
(WebCore::V8MutationObserver::constructorCallback):
* dom/MutationObserver.cpp:
(WebCore::MutationObserver::create):
(WebCore::MutationObserver::MutationObserver):
(WebCore::MutationObserver::observationStarted):
(WebCore::MutationObserver::observationEnded):
* dom/MutationObserver.h:
(WebCore):
* dom/MutationObserver.idl:

LayoutTests:

Test that a MutationObserver wrapper is not collected while the observer
is still observing since the wrapper must be passed into the callback
later.

* fast/mutation/observer-wrapper-dropoff-expected.txt: Added.
* fast/mutation/observer-wrapper-dropoff.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoGenerate Settings from a .in file
tony@chromium.org [Thu, 15 Nov 2012 21:41:07 +0000 (21:41 +0000)]
Generate Settings from a .in file
https://bugs.webkit.org/show_bug.cgi?id=100393

Reviewed by Adam Barth.

.:

Generate SettingsMacros.h for cmake.

* Source/cmake/WebKitMacros.cmake:

Source/WebCore:

Generate most settings from an .in file to reduce human mistakes and
to make it easier to add/remove new settings.

I only moved settings that are easy to move at this point.  There are many more that
have some minor naming inconsistencies that we can also move to Settings.in, but I'll
do that in a follow up patch.

This doesn't generate SettingInternals.* yet-- we can do that in a follow up patch.

No new tests, this is a refactor.

* CMakeLists.txt:
* DerivedSources.make: Run make_settings.pl.
* DerivedSources.pri: Run make_settings.pl.
* GNUmakefile.am: Run make_settings.pl.
* GNUmakefile.list.am:
* WebCore.exp.in: Remove functions that are now inline in the header.
* WebCore.gyp/WebCore.gyp: Run action_makenames.py, which will run make_settings.pl.
* WebCore.gyp/scripts/action_makenames.py:
(main): Allow make_settings.pl.
* WebCore.order: Remove functions that are now inline in the header.
* html/ValidationMessage.cpp:
(WebCore::ValidationMessage::setMessageDOMAndStartTimer): Fix a typo in "magnification".
* page/Settings.cpp:
(WebCore::Settings::Settings): Replace generated settings with SETTINGS_INITIALIZER_LIST.
* page/Settings.h:
(Settings): Replace generated settings with SETTINGS_GETTERS_AND_SETTERS and SETTINGS_MEMBER_VARIABLES.
* page/Settings.in: Added.
* page/make_settings.pl: Added.
(defaultItemFactory):
(generateCode):
(generateHeader): Use a similar model as make_names.pl.
(printConditionalMacros):
(printGettersAndSetters):
(printMemberVariables):
(printGetterAndSetter):
(printInitializerList):
(printInitializer):

Tools:

Add the generated WebCore files to the include dir.

* TestWebKitAPI/CMakeLists.txt:
* WebKitTestRunner/CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIndexedDB: setVersion test conversion batch 6
dgrogan@chromium.org [Thu, 15 Nov 2012 21:34:44 +0000 (21:34 +0000)]
IndexedDB: setVersion test conversion batch 6
https://bugs.webkit.org/show_bug.cgi?id=102318

Reviewed by Tony Chang.

Salvaged the useful parts of intversion-and-setversion as
intversion-upgrades.

* storage/indexeddb/intversion-and-setversion-expected.txt: Removed.
* storage/indexeddb/intversion-upgrades-expected.txt: Added.
* storage/indexeddb/intversion-upgrades.html: Renamed from LayoutTests/storage/indexeddb/intversion-and-setversion.html.
* storage/indexeddb/resources/intversion-and-setversion.js: Removed.
* storage/indexeddb/resources/intversion-upgrades.js: Added.
(test):
(deleteSuccess):
(initialUpgradeNeeded):
(openSuccess):
(connection1VersionChangeCallback):
(connection2BlockedCallback):
(connection2UpgradeNeeded):
(transactionCompleted):
(connection2Success):
(connection3Success):
(errorWhenTryingLowVersion):
(connection4UpgradeNeeded):
(connection4Success):
(connection5Success):
* storage/indexeddb/resources/shared.js:
(unexpectedVersionChangeCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake old-run-webkit-tests handle setting the results directory properly.
roger_fong@apple.com [Thu, 15 Nov 2012 21:25:54 +0000 (21:25 +0000)]
Make old-run-webkit-tests handle setting the results directory properly.
https://bugs.webkit.org/show_bug.cgi?id=102273
<rdar://problem/11571607>

Reviewed by Timothy Horton.

A call to chdirWebkit in old-run-webkit-tests set the current working directory to the OpenSource folder.
Thus setting --results-directory to OpenSource/layout-test-results would create OpenSource/layout-test-results inside the main OpenSource folder.
This caused many other problems including failure to upload test results and failed future test runs.
The solution is to save the current working directory before calling chdirWebKit and then reconstructing the full path to the results directory
using the saved directory when setting $testResultsDirectory.

* Scripts/old-run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Refactoring to move logic of creating lazy decoded SkBitmap into DeferredI...
hclam@chromium.org [Thu, 15 Nov 2012 20:57:32 +0000 (20:57 +0000)]
[chromium] Refactoring to move logic of creating lazy decoded SkBitmap into DeferredImageDecoder
https://bugs.webkit.org/show_bug.cgi?id=102019

Reviewed by Stephen White.

Goal of this change is to keep ImageDecodingStore clean and only do
image caching. Logic of creating lazily decoded SkBitmaps is moved into
DeferredImageDecoder.

In particular these two methods are moved:
- ImageDecodingStore::createLazyDecodedSkBitmap
- ImageDecodingStore::resizeLazyDecodedSkBitmap

No new tests. There is no new code (really). It is just moved from
ImageDecodingStore to DeferredImageDecoder.

No change in behavior. Code is tested with:
Unit tests: webkit_unit_tests
Layout test: platform/chromium/virtual/deferred

* platform/graphics/chromium/DeferredImageDecoder.cpp:
(WebCore::DeferredImageDecoder::isLazyDecoded):
(WebCore):
(WebCore::DeferredImageDecoder::resizeLazyDecodedSkBitmap):
(WebCore::DeferredImageDecoder::frameBufferAtIndex):
(WebCore::DeferredImageDecoder::setData):
(WebCore::DeferredImageDecoder::createLazyDecodedSkBitmap):
* platform/graphics/chromium/DeferredImageDecoder.h:
(WebCore):
(DeferredImageDecoder):
* platform/graphics/chromium/ImageDecodingStore.cpp:
* platform/graphics/chromium/ImageDecodingStore.h:
(ImageDecodingStore):
* platform/graphics/chromium/ImageFrameGenerator.cpp:
(WebCore::ImageFrameGenerator::ImageFrameGenerator):
* platform/graphics/chromium/ImageFrameGenerator.h:
(WebCore::ImageFrameGenerator::create):
(ImageFrameGenerator):
* platform/graphics/skia/NativeImageSkia.cpp:
(WebCore::NativeImageSkia::resizedBitmap):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoConsolidate four accelerated compositing WKView methods into a single method
andersca@apple.com [Thu, 15 Nov 2012 20:55:54 +0000 (20:55 +0000)]
Consolidate four accelerated compositing WKView methods into a single method
https://bugs.webkit.org/show_bug.cgi?id=102419

Reviewed by Andreas Kling.

Add a single -[WKView _setAcceleratedCompositingModeRootLayer:] method and have
the existing PageClientImpl member functions call it. Also, add a new
PageClient member function, setAcceleratedCompositingRootLayer.

* UIProcess/API/mac/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::enterAcceleratedCompositingMode):
(WebKit::PageClientImpl::exitAcceleratedCompositingMode):
(WebKit::PageClientImpl::updateAcceleratedCompositingMode):
(WebKit::PageClientImpl::setAcceleratedCompositingRootLayer):
* UIProcess/API/mac/WKView.mm:
(-[WKView _processDidCrash]):
(-[WKView _setAcceleratedCompositingModeRootLayer:]):
* UIProcess/API/mac/WKViewInternal.h:
* UIProcess/PageClient.h:
* UIProcess/WebPageProxy.h:
* UIProcess/mac/RemoteLayerTreeHost.mm:
(WebKit::RemoteLayerTreeHost::commit):
* UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::setAcceleratedCompositingRootLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIndexedDB test conversions batch 5
dgrogan@chromium.org [Thu, 15 Nov 2012 20:54:44 +0000 (20:54 +0000)]
IndexedDB test conversions batch 5
https://bugs.webkit.org/show_bug.cgi?id=102308

Reviewed by Tony Chang.

* storage/indexeddb/mozilla/cursor-update-updates-indexes-expected.txt:
* storage/indexeddb/mozilla/event-source-expected.txt:
* storage/indexeddb/mozilla/global-data-expected.txt:
* storage/indexeddb/mozilla/key-requirements-put-null-key-expected.txt:
* storage/indexeddb/mozilla/odd-result-order-expected.txt:
* storage/indexeddb/mozilla/remove-objectstore-expected.txt:
* storage/indexeddb/mozilla/resources/cursor-update-updates-indexes.js:
  Calls indexedDBTest a bunch of times, which seems awkward, but is
  really convenient.

* storage/indexeddb/mozilla/resources/event-source.js:
  Now that setVersion is gone, it appears that no request should have
  a database as a source so the dropped test is ok.

* storage/indexeddb/mozilla/resources/global-data.js:
(prepareDatabase):
(open2Success):
* storage/indexeddb/mozilla/resources/key-requirements-put-null-key.js:
(prepareDatabase):
* storage/indexeddb/mozilla/resources/odd-result-order.js:
  The tests had to be run in slightly different order but they are all
  preserved.

(prepareDatabase):
(openSuccess):
(deleteSuccess):
* storage/indexeddb/mozilla/resources/remove-objectstore.js:
(prepareDatabase):
(checkObjectStore):
(inSetVersion2.request.onsuccess):
(inSetVersion2):
(setVersion3):
(inSetVersion3):
(deleteThirdObjectStore):
* storage/indexeddb/objectstore-removeobjectstore-expected.txt:
* storage/indexeddb/resources/objectstore-removeobjectstore.js:
(getValue):
(checkResult):
(addIndex):
(deleteObjectStore):
(createObjectStoreAgain):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Build fix for Windows after r134767.
roger_fong@apple.com [Thu, 15 Nov 2012 20:54:27 +0000 (20:54 +0000)]
Unreviewed. Build fix for Windows after r134767.

Update vsprops and vcproj files to reflect changes to file locations in r134767.

* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcproj/WebCoreCommon.vsprops:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoTrack subframe count to avoid traversing the tree when there's no subframes
commit-queue@webkit.org [Thu, 15 Nov 2012 20:38:34 +0000 (20:38 +0000)]
Track subframe count to avoid traversing the tree when there's no subframes
https://bugs.webkit.org/show_bug.cgi?id=101821

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-11-15
Reviewed by Ojan Vafai.

Bug 101619 showed a 9-14% improvement from not walking the children during
removeChild looking for frames when there's known to be no frames. The fix
in that bug only avoids this walk when the whole document has no frames, this
patch extends it to skip traversing subtrees that have no iframes by hooking
the frame assignment to walk up the tree and keep track of the count of frames
in the subtree on contentFrame assignment and then decrement it on disconnect.

No new tests, this is just a perf refactor.

* dom/ContainerNode.cpp:
(WebCore::willRemoveChildren):
* dom/ContainerNodeAlgorithms.cpp:
(WebCore::ChildFrameDisconnector::collectFrameOwners):
* dom/ContainerNodeAlgorithms.h:
(WebCore::ChildFrameDisconnector::ChildFrameDisconnector):
(ChildFrameDisconnector):
(WebCore::ChildFrameDisconnector::collectFrameOwners):
  Renamed from collectDescendant() to better reflect what it really does.
(WebCore::ChildFrameDisconnector::disconnectCollectedFrameOwners):
  Renamed from disconnect() to better reflect what it really does.
(WebCore::ChildFrameDisconnector::disconnect):
  New method that does the collection of frame owners on either the root
  or only it's descendants.
* dom/Node.cpp:
(WebCore::Node::connectedSubframeCount):
(WebCore::Node::incrementConnectedSubframeCount):
(WebCore::Node::decrementConnectedSubframeCount):
* dom/Node.h:
* dom/NodeRareData.h:
(WebCore::NodeRareData::NodeRareData):
(WebCore::NodeRareData::connectedSubframeCount):
(WebCore::NodeRareData::incrementConnectedSubframeCount):
(WebCore::NodeRareData::decrementConnectedSubframeCount):
* html/HTMLFrameOwnerElement.cpp:
(WebCore::HTMLFrameOwnerElement::setContentFrame):
(WebCore::HTMLFrameOwnerElement::disconnectContentFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] WebGL texImage2D fails with deferred image decoding
hclam@chromium.org [Thu, 15 Nov 2012 20:35:40 +0000 (20:35 +0000)]
[chromium] WebGL texImage2D fails with deferred image decoding
https://bugs.webkit.org/show_bug.cgi?id=102310

Reviewed by Kenneth Russell.

Source/WebCore:

Skia's implementation of GraphicsContext3D::getImageData() uses ImageSource
to decode an image. When deferred image decoding is enabled this class
generates an ImageFrame marked as incomplete, which WebGL rejects. This results
in failing of texImage2D.

This change uses ImageDecoder directly instead of ImageSource. This skips
the code path of deferred image decoding. This behavior is correct because
GraphicsContext3D wants to decode the image differently with alpha not
premultiplied and color profile applied optionally.

Added a test to prove this change fixed the bug.

Test: fast/images/webgl-teximage2d.html

* platform/graphics/skia/GraphicsContext3DSkia.cpp:
(WebCore::GraphicsContext3D::getImageData):

LayoutTests:

Added a test to exercise texImage2D with an Image object.

* fast/images/webgl-teximage2d-expected.txt: Added.
* fast/images/webgl-teximage2d.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoTest rebaselines after SK_IGNORE_FAST_BLURRECT has been removed
schenney@chromium.org [Thu, 15 Nov 2012 20:34:33 +0000 (20:34 +0000)]
Test rebaselines after SK_IGNORE_FAST_BLURRECT has been removed

Unreviewed test expectations update.

* fast/box-shadow/single-pixel-shadow-expected.png: Added.
* platform/chromium-linux-x86/fast/box-shadow: Removed.
* platform/chromium-linux-x86/fast/box-shadow/single-pixel-shadow-expected.png: Removed.
* platform/chromium-linux-x86/fast/repaint/transform-replaced-shadows-expected.png: Added.
* platform/chromium-linux-x86/svg/filters/shadow-on-rect-with-filter-expected.png:
* platform/chromium-linux/fast/box-shadow/single-pixel-shadow-expected.png: Removed.
* platform/chromium-linux/fast/repaint/shadow-multiple-horizontal-expected.png:
* platform/chromium-linux/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
* platform/chromium-linux/fast/repaint/shadow-multiple-strict-vertical-expected.png:
* platform/chromium-linux/fast/repaint/transform-replaced-shadows-expected.png: Added.
* platform/chromium-mac-lion/compositing/shadows/shadow-drawing-expected.png:
* platform/chromium-mac-lion/fast/box-shadow/basic-shadows-expected.png:
* platform/chromium-mac-lion/fast/box-shadow/box-shadow-transformed-expected.png:
* platform/chromium-mac-lion/fast/canvas/canvas-incremental-repaint-expected.png:
* platform/chromium-mac-lion/fast/repaint/box-shadow-h-expected.png:
* platform/chromium-mac-lion/fast/repaint/box-shadow-v-expected.png:
* platform/chromium-mac-lion/fast/repaint/shadow-multiple-horizontal-expected.png: Added.
* platform/chromium-mac-lion/fast/repaint/shadow-multiple-strict-horizontal-expected.png: Added.
* platform/chromium-mac-lion/fast/repaint/shadow-multiple-strict-vertical-expected.png: Added.
* platform/chromium-mac-lion/fast/repaint/shadow-multiple-vertical-expected.png:
* platform/chromium-mac-lion/fast/repaint/transform-replaced-shadows-expected.png: Added.
* platform/chromium-mac-lion/fast/transforms/shadows-expected.png:
* platform/chromium-mac-lion/platform/chromium/virtual/softwarecompositing/shadows/shadow-drawing-expected.png:
* platform/chromium-mac-lion/svg/css/group-with-shadow-expected.png:
* platform/chromium-mac-lion/svg/filters/shadow-on-rect-with-filter-expected.png: Added.
* platform/chromium-mac-snowleopard/compositing/shadows/shadow-drawing-expected.png:
* platform/chromium-mac-snowleopard/fast/box-shadow/basic-shadows-expected.png:
* platform/chromium-mac-snowleopard/fast/box-shadow/box-shadow-transformed-expected.png:
* platform/chromium-mac-snowleopard/fast/box-shadow/single-pixel-shadow-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/repaint/box-shadow-h-expected.png:
* platform/chromium-mac-snowleopard/fast/repaint/box-shadow-v-expected.png:
* platform/chromium-mac-snowleopard/fast/repaint/shadow-multiple-horizontal-expected.png:
* platform/chromium-mac-snowleopard/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
* platform/chromium-mac-snowleopard/fast/repaint/shadow-multiple-strict-vertical-expected.png:
* platform/chromium-mac-snowleopard/fast/repaint/shadow-multiple-vertical-expected.png:
* platform/chromium-mac-snowleopard/fast/repaint/transform-replaced-shadows-expected.png: Added.
* platform/chromium-mac-snowleopard/platform/chromium/virtual/softwarecompositing/shadows/shadow-drawing-expected.png:
* platform/chromium-mac-snowleopard/svg/filters/shadow-on-rect-with-filter-expected.png:
* platform/chromium-mac/compositing/shadows/shadow-drawing-expected.png:
* platform/chromium-mac/fast/box-shadow/basic-shadows-expected.png:
* platform/chromium-mac/fast/box-shadow/box-shadow-clipped-slices-expected.png:
* platform/chromium-mac/fast/box-shadow/box-shadow-radius-expected.png:
* platform/chromium-mac/fast/box-shadow/box-shadow-transformed-expected.png:
* platform/chromium-mac/fast/box-shadow/scaled-box-shadow-expected.png:
* platform/chromium-mac/fast/box-shadow/single-pixel-shadow-expected.png:
* platform/chromium-mac/fast/canvas/canvas-incremental-repaint-expected.png:
* platform/chromium-mac/fast/canvas/canvas-shadow-expected.txt: Removed.
* platform/chromium-mac/fast/repaint/box-shadow-h-expected.png:
* platform/chromium-mac/fast/repaint/box-shadow-v-expected.png:
* platform/chromium-mac/fast/repaint/shadow-multiple-horizontal-expected.png: Added.
* platform/chromium-mac/fast/repaint/shadow-multiple-strict-horizontal-expected.png: Added.
* platform/chromium-mac/fast/repaint/shadow-multiple-strict-vertical-expected.png: Added.
* platform/chromium-mac/fast/repaint/shadow-multiple-vertical-expected.png:
* platform/chromium-mac/fast/repaint/transform-replaced-shadows-expected.png: Added.
* platform/chromium-mac/fast/transforms/shadows-expected.png:
* platform/chromium-mac/platform/chromium/virtual/softwarecompositing/shadows/shadow-drawing-expected.png:
* platform/chromium-mac/svg/css/group-with-shadow-expected.png:
* platform/chromium-mac/svg/filters/shadow-on-rect-with-filter-expected.png:
* platform/chromium-win-xp/compositing/shadows/shadow-drawing-expected.png:
* platform/chromium-win-xp/fast/box-shadow: Removed.
* platform/chromium-win-xp/fast/box-shadow/single-pixel-shadow-expected.png: Removed.
* platform/chromium-win-xp/fast/repaint/box-shadow-h-expected.png: Added.
* platform/chromium-win-xp/fast/repaint/box-shadow-v-expected.png: Added.
* platform/chromium-win-xp/fast/repaint/shadow-multiple-horizontal-expected.png: Added.
* platform/chromium-win-xp/fast/repaint/shadow-multiple-strict-horizontal-expected.png: Added.
* platform/chromium-win-xp/fast/repaint/shadow-multiple-strict-vertical-expected.png: Added.
* platform/chromium-win-xp/fast/repaint/shadow-multiple-vertical-expected.png: Added.
* platform/chromium-win-xp/fast/repaint/transform-replaced-shadows-expected.png: Added.
* platform/chromium-win-xp/fast/transforms/shadows-expected.png: Added.
* platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/shadows: Added.
* platform/chromium-win-xp/platform/chromium/virtual/softwarecompositing/shadows/shadow-drawing-expected.png: Added.
* platform/chromium-win-xp/svg/css/group-with-shadow-expected.png:
* platform/chromium-win-xp/svg/filters/shadow-on-rect-with-filter-expected.png:
* platform/chromium-win/compositing/shadows/shadow-drawing-expected.png:
* platform/chromium-win/fast/box-shadow/basic-shadows-expected.png:
* platform/chromium-win/fast/box-shadow/box-shadow-clipped-slices-expected.png:
* platform/chromium-win/fast/box-shadow/box-shadow-transformed-expected.png:
* platform/chromium-win/fast/box-shadow/single-pixel-shadow-expected.png:
* platform/chromium-win/fast/canvas/canvas-incremental-repaint-expected.png:
* platform/chromium-win/fast/canvas/canvas-shadow-expected.txt: Added.
* platform/chromium-win/fast/repaint/shadow-multiple-horizontal-expected.png:
* platform/chromium-win/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
* platform/chromium-win/fast/repaint/shadow-multiple-strict-vertical-expected.png:
* platform/chromium-win/fast/repaint/transform-replaced-shadows-expected.png:
* platform/chromium/TestExpectations:
* platform/chromium/fast/repaint/shadow-multiple-horizontal-expected.png: Removed.
* platform/chromium/fast/repaint/shadow-multiple-strict-horizontal-expected.png: Removed.
* platform/chromium/fast/repaint/shadow-multiple-strict-vertical-expected.png: Removed.
* platform/efl-wk1/compositing/shadows: Added.
* platform/efl-wk1/compositing/shadows/shadow-drawing-expected.png: Added.
* platform/efl-wk1/fast/box-shadow: Added.
* platform/efl-wk1/fast/box-shadow/basic-shadows-expected.png: Added.
* platform/efl-wk1/fast/box-shadow/box-shadow-clipped-slices-expected.png: Added.
* platform/efl-wk1/fast/box-shadow/box-shadow-transformed-expected.png: Added.
* platform/efl-wk1/fast/box-shadow/scaled-box-shadow-expected.png: Added.
* platform/efl-wk1/fast/canvas: Added.
* platform/efl-wk1/fast/canvas/canvas-incremental-repaint-expected.png: Added.
* platform/efl-wk1/fast/repaint/shadow-multiple-horizontal-expected.png: Added.
* platform/efl-wk1/fast/repaint/shadow-multiple-strict-horizontal-expected.png: Added.
* platform/efl-wk1/fast/repaint/shadow-multiple-strict-vertical-expected.png: Added.
* platform/efl-wk1/fast/repaint/shadow-multiple-vertical-expected.png: Added.
* platform/efl-wk1/fast/transforms: Added.
* platform/efl-wk1/fast/transforms/shadows-expected.png: Added.
* platform/efl-wk1/svg/css: Added.
* platform/efl-wk1/svg/css/group-with-shadow-expected.png: Added.
* platform/efl/compositing/shadows/shadow-drawing-expected.png: Removed.
* platform/efl/fast/box-shadow/basic-shadows-expected.png: Removed.
* platform/efl/fast/box-shadow/box-shadow-clipped-slices-expected.png: Removed.
* platform/efl/fast/box-shadow/box-shadow-transformed-expected.png: Removed.
* platform/efl/fast/box-shadow/scaled-box-shadow-expected.png: Removed.
* platform/efl/fast/box-shadow/single-pixel-shadow-expected.png: Removed.
* platform/efl/fast/canvas/canvas-incremental-repaint-expected.png: Removed.
* platform/efl/fast/repaint/shadow-multiple-horizontal-expected.png: Removed.
* platform/efl/fast/repaint/shadow-multiple-strict-horizontal-expected.png: Removed.
* platform/efl/fast/repaint/shadow-multiple-strict-vertical-expected.png: Removed.
* platform/efl/fast/repaint/shadow-multiple-vertical-expected.png: Removed.
* platform/efl/fast/transforms/shadows-expected.png: Removed.
* platform/efl/svg/css/group-with-shadow-expected.png: Removed.
* platform/gtk/fast/box-shadow/single-pixel-shadow-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFurther unreviewed build fix. Add explicit static_casts to avoid implicit precision...
jer.noble@apple.com [Thu, 15 Nov 2012 20:29:44 +0000 (20:29 +0000)]
Further unreviewed build fix. Add explicit static_casts to avoid implicit precision warnings.

* platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm:
(WebCore::WebCoreAVFResourceLoader::fulfillRequestWithResource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoStructure should be able to easily tell if the prototype chain might intercept a...
fpizlo@apple.com [Thu, 15 Nov 2012 20:20:02 +0000 (20:20 +0000)]
Structure should be able to easily tell if the prototype chain might intercept a store
https://bugs.webkit.org/show_bug.cgi?id=102326

Reviewed by Geoffrey Garen.

This improves our ability to reason about the correctness of the more optimized
prototype chain walk in JSObject::put(), while also making it straight forward to
check if the prototype chain will do strange things to a property store by just
looking at the structure.

* runtime/JSObject.cpp:
(JSC::JSObject::put):
* runtime/Structure.cpp:
(JSC::Structure::prototypeChainMayInterceptStoreTo):
(JSC):
* runtime/Structure.h:
(Structure):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed build fix. Avoid implicit precision and unused parameter warnings.
jer.noble@apple.com [Thu, 15 Nov 2012 20:04:21 +0000 (20:04 +0000)]
Unreviewed build fix. Avoid implicit precision and unused parameter warnings.

* platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm:
(WebCore::WebCoreAVFResourceLoader::responseReceived):
(WebCore::WebCoreAVFResourceLoader::fulfillRequestWithResource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[V8] We shouldn't call deprecated V8 APIs
abarth@webkit.org [Thu, 15 Nov 2012 20:01:20 +0000 (20:01 +0000)]
[V8] We shouldn't call deprecated V8 APIs
https://bugs.webkit.org/show_bug.cgi?id=102407

Reviewed by Eric Seidel.

This patch was written by Sven Panne on the V8 team. He would prefer
that we not call deprecated V8 APIs. This patch updates these call
sites to more modern idioms.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateConstructorGetter):
(GenerateImplementation):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::TestObjConstructorGetter):
* bindings/v8/PageScriptDebugServer.cpp:
(WebCore::PageScriptDebugServer::addListener):
* bindings/v8/ScriptController.cpp:
(WebCore::ScriptController::setContextDebugId):
(WebCore::ScriptController::contextDebugId):
* bindings/v8/ScriptProfiler.cpp:
(WebCore::ScriptProfiler::objectByHeapObjectId):
    - This code doesn't seem to do anything anymore.
* bindings/v8/V8DOMConfiguration.h:
(WebCore::V8DOMConfiguration::configureAttribute):
* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::setInjectedScriptContextDebugId):
* bindings/v8/V8DOMWrapper.cpp:
(WebCore::V8DOMWrapper::maybeDOMWrapper):
(WebCore::V8DOMWrapper::isWrapperOfType):
* bindings/v8/V8EventListenerList.h:
(WebCore::V8EventListenerList::doFindWrapper):
(WebCore::V8EventListenerList::findOrCreateWrapper):
* bindings/v8/WorkerContextExecutionProxy.cpp:
(WebCore::WorkerContextExecutionProxy::initializeIfNeeded):
* bindings/v8/WrapperTypeInfo.h:
(WebCore::WrapperTypeInfo::unwrap):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r134800 and r134805.
commit-queue@webkit.org [Thu, 15 Nov 2012 19:59:56 +0000 (19:59 +0000)]
Unreviewed, rolling out r134800 and r134805.
http://trac.webkit.org/changeset/134800
http://trac.webkit.org/changeset/134805
https://bugs.webkit.org/show_bug.cgi?id=102417

This patch broke chromium port (Requested by jianli on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-15

Source/Platform:

* chromium/public/WebRTCPeerConnectionHandlerClient.h:
(WebRTCPeerConnectionHandlerClient):

Source/WebCore:

* Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::RTCPeerConnection):
(WebCore::RTCPeerConnection::createOffer):
(WebCore::RTCPeerConnection::createAnswer):
(WebCore::RTCPeerConnection::setLocalDescription):
(WebCore::RTCPeerConnection::localDescription):
(WebCore::RTCPeerConnection::setRemoteDescription):
(WebCore::RTCPeerConnection::remoteDescription):
(WebCore::RTCPeerConnection::updateIce):
(WebCore::RTCPeerConnection::addIceCandidate):
(WebCore::RTCPeerConnection::readyState):
(WebCore::RTCPeerConnection::iceState):
(WebCore::RTCPeerConnection::addStream):
(WebCore::RTCPeerConnection::close):
(WebCore::RTCPeerConnection::stop):
(WebCore::RTCPeerConnection::changeReadyState):
(WebCore::RTCPeerConnection::scheduledEventTimerFired):
* Modules/mediastream/RTCPeerConnection.h:
(RTCPeerConnection):
* Modules/mediastream/RTCPeerConnection.idl:
* dom/EventNames.h:
(WebCore):
* platform/mediastream/RTCDataChannelDescriptor.cpp:
(WebCore::RTCDataChannelDescriptor::RTCDataChannelDescriptor):
(WebCore::RTCDataChannelDescriptor::readyStateChanged):
* platform/mediastream/RTCPeerConnectionHandlerClient.h:
(RTCPeerConnectionHandlerClient):
* platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.cpp:
* platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.h:
(RTCPeerConnectionHandlerChromium):

Source/WebKit/chromium:

* src/AssertMatchingEnums.cpp:

Tools:

* DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
(MockWebRTCPeerConnectionHandler::openDataChannel):

LayoutTests:

* fast/mediastream/RTCPeerConnection-datachannel-expected.txt:
* fast/mediastream/RTCPeerConnection-datachannel.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Do not mark an event (mouse wheel, scroll update) as handled if nothing...
commit-queue@webkit.org [Thu, 15 Nov 2012 19:57:07 +0000 (19:57 +0000)]
[chromium] Do not mark an event (mouse wheel, scroll update) as handled if nothing was scrolled.
https://bugs.webkit.org/show_bug.cgi?id=102246

Patch by Sadrul Habib Chowdhury <sadrul@chromium.org> on 2012-11-15
Reviewed by James Robinson.

* src/WebCompositorInputHandlerImpl.cpp:
(WebKit::WebCompositorInputHandlerImpl::handleInputEventInternal):
* tests/WebCompositorInputHandlerImplTest.cpp:
(MockWebInputHandlerClient):
(WebKit::TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Animate changes to viewport due to input focus changes.
commit-queue@webkit.org [Thu, 15 Nov 2012 19:55:12 +0000 (19:55 +0000)]
[BlackBerry] Animate changes to viewport due to input focus changes.
https://bugs.webkit.org/show_bug.cgi?id=102410

Patch by Andrew Lo <anlo@rim.com> on 2012-11-15
Reviewed by Rob Buis.

When changing scroll position or zoom level for input field focus,
animate the change.
Internal PR 231937

Internally reviewed by Mike Fenton.

* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove Node::aboutToUnload and be more explicit about what it was for
commit-queue@webkit.org [Thu, 15 Nov 2012 19:39:50 +0000 (19:39 +0000)]
Remove Node::aboutToUnload and be more explicit about what it was for
https://bugs.webkit.org/show_bug.cgi?id=102357

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-11-15
Reviewed by Ryosuke Niwa.

Node::aboutToUnload was confusingly named because it was only called on
the focused node, and it really only existed to support notifying the
embedder that inputs should stop being editable on unload. Instead add
a new method to HTMLInputElement that ends editing and call that
explicitly in the FrameLoader so it's clear what this is about.

No new tests, this is just a refactoring.

* dom/Node.h:
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::endEditing):
    New method that handles finishing editing.
* html/HTMLInputElement.h:
(HTMLInputElement):
* html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::handleBlurEvent):
    Use the new method to reduce code duplication.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::stopLoading):
    Be explicit about what this check was for.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] MediaStream API: Add missing WebRTCPeerConnectionHandlerClient::didAddRemo...
tommyw@google.com [Thu, 15 Nov 2012 19:22:49 +0000 (19:22 +0000)]
[chromium] MediaStream API: Add missing WebRTCPeerConnectionHandlerClient::didAddRemoteDataChannel
https://bugs.webkit.org/show_bug.cgi?id=102386

Reviewed by Adam Barth.

Source/Platform:

* chromium/public/WebRTCPeerConnectionHandlerClient.h:
(WebRTCPeerConnectionHandlerClient):

Source/WebCore:

Existing tests expanded to cover patch.

* platform/mediastream/RTCDataChannelDescriptor.cpp:
(WebCore::RTCDataChannelDescriptor::RTCDataChannelDescriptor):
(WebCore::RTCDataChannelDescriptor::readyStateChanged):
* platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.cpp:
(WebCore::RTCPeerConnectionHandlerChromium::didAddRemoteDataChannel):
(WebCore):
* platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.h:
(WebKit):
(RTCPeerConnectionHandlerChromium):

Tools:

Adding mock data channel functionality.

* DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
(MockWebRTCPeerConnectionHandler::openDataChannel):

LayoutTests:

* fast/mediastream/RTCPeerConnection-datachannel.html:
* fast/mediastream/RTCPeerConnection-datachannel-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoNo tests for changing mouse cursors
commit-queue@webkit.org [Thu, 15 Nov 2012 19:15:17 +0000 (19:15 +0000)]
No tests for changing mouse cursors
https://bugs.webkit.org/show_bug.cgi?id=100550

Patch by Rick Byers <rbyers@chromium.org> on 2012-11-15
Reviewed by Brent Fulgham.

.:

Add necessary exports for Internals::getCurrentCursorInfo

* Source/autotools/symbols.filter:

Source/WebCore:

Add infrastructure to keep track of the last set mouse cursor,
and then to query it from DumpRenderTree.  Also adds ASSERTs to help ensure
we can reliably detect when an uninitialized Cursor object is used (such as
the one that can be returned from OptionalCursor in the NoCursorChange scenario).

Test: fast/events/mouse-cursor.html

* WebCore.exp.in: Add Cursor copy ctor export
* page/EventHandler.cpp:
(WebCore::OptionalCursor::cursor):
(WebCore::EventHandler::handleMouseMoveEvent): Keep track of last set mouse cursor
* page/EventHandler.h:
(WebCore::EventHandler::currentMouseCursor): New getter for last set mouse cursor
* platform/Cursor.h:
(WebCore::Cursor::Cursor): Mark uninitialized cursor types as invalid.
(WebCore::Cursor::type): Assert cursor type is valid.
* testing/Internals.cpp:
(WebCore::cursorTypeToString): Helper to convert cursor type to enum
(WebCore):
(WebCore::Internals::getCurrentCursorInfo): New function to return a string describing the last set mouse cursor
* testing/Internals.h: Declare getCurrentCursorInfo
* testing/Internals.idl: Declare getCurrentCursorInfo

Source/WebKit2:

Add necessary exports for Internals::getCurrentCursorInfo

* win/WebKit2.def:
* win/WebKit2CFLite.def:

LayoutTests:

Add a simple test covering the basic scenarios of changing a mouse
cursor with CSS.  This includes most of the cases currently covered
by ManualTests/*cursor*.

* fast/events/mouse-cursor-expected.txt: Added.
* fast/events/mouse-cursor.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSupport loading of blob URLs in AVFoundation.
jer.noble@apple.com [Thu, 15 Nov 2012 19:08:54 +0000 (19:08 +0000)]
Support loading of blob URLs in AVFoundation.
https://bugs.webkit.org/show_bug.cgi?id=102182

Reviewed by Eric Carlson.

Source/WebCore:

Add support for BLOB (and other non-natively supported schemed) URLs through the AVAssetResourceLoader API.

Test: media/video-src-blob.html

* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::shouldWaitForLoadingOfResource): Only go down the encrypted
    media path if the key scheme is skp://.
(WebCore::MediaPlayerPrivateAVFoundationObjC::didCancelLoadingRequest): Added.  Cancel resource loading if
    the media engine requests it.
(WebCore::MediaPlayerPrivateAVFoundationObjC::addKey): Use the new, non-deprecated API.

Use the dispatch_main_queue() as the AVAssetResourceLoadDelegate queue now that <rdar://problem/12362461> is fixed.
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVAssetForURL):
(-[WebCoreAVFLoaderDelegate resourceLoader:shouldWaitForLoadingOfRequestedResource:]):
(-[WebCoreAVFLoaderDelegate resourceLoader:didCancelLoadingRequest:]):

Add a new helper class to manage loading the CachedRawResource and feed the incoming
data to the AVAssetResourceLoader.
* platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.h: Added.
* platform/graphics/avfoundation/objc/WebCoreAVFResourceLoader.mm: Added.
(WebCore::WebCoreAVFResourceLoader::create): Simple factory.
(WebCore::WebCoreAVFResourceLoader::WebCoreAVFResourceLoader): Simple constructor.
(WebCore::WebCoreAVFResourceLoader::~WebCoreAVFResourceLoader): Simple destructor.
(WebCore::WebCoreAVFResourceLoader::startLoading): Tell the cachedResourceLoader to schedule loading.
(WebCore::WebCoreAVFResourceLoader::stopLoading): Remove this as a client of the resource.
(WebCore::WebCoreAVFResourceLoader::responseReceived): Fill in the contentInformation field of the
    AVAssetResourceLoadingRequest.
(WebCore::WebCoreAVFResourceLoader::dataReceived): Call fulfillRequestWithResource.
(WebCore::WebCoreAVFResourceLoader::notifyFinished): Tell the AVAssetResourceLoadingRequest that loading
    has completed.
(WebCore::WebCoreAVFResourceLoader::fulfillRequestWithResource): Fill in (if possible) the dataRequest
    field of the AVAssetResourceLoadingRequest.

Add a MediaPlayerClient method allowing MediaPlayerPrivate subclasses to access the HTMLMediaElement's
document's cachedResourceLoader.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaPlayerCachedResourceLoader):
* html/HTMLMediaElement.h:
* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::cachedResourceLoader):
* platform/graphics/MediaPlayer.h:
(WebCore::MediaPlayerClient::mediaPlayerCachedResourceLoader):

Add a convenience method to convert from MIME type -> UTI.
* platform/network/mac/UTIUtilities.h:
* platform/network/mac/UTIUtilities.mm:
(WebCore::UTIFromMIMEType):

Add new files to project.
* WebCore.xcodeproj/project.pbxproj:

LayoutTests:

Add a new test which verifies blob url support in video elements.

* media/video-src-blob-expected.txt: Added.
* media/video-src-blob.html: Added.
* platform/mac/TestExpectations: Add expected failure results for OSX releases where
    custom media loading is not supported.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove initiallyFitToViewport attribute
kenneth@webkit.org [Thu, 15 Nov 2012 19:06:03 +0000 (19:06 +0000)]
Remove initiallyFitToViewport attribute
https://bugs.webkit.org/show_bug.cgi?id=102392

Reviewed by Noam Rosenthal.

Remove the initiallyFitToViewport which shouldn't have been
added in the first place. We now reset userScalable to auto (-1)
in case it was not explicitly set by the web author.

Same behavior, covered by existing tests.

Source/WebCore:

* dom/ViewportArguments.cpp:
(WebCore::ViewportArguments::resolve):
* dom/ViewportArguments.h:
(ViewportAttributes):

Source/WebKit2:

* UIProcess/PageViewportController.cpp:
(WebKit::PageViewportController::PageViewportController):
(WebKit::PageViewportController::pageTransitionViewportReady):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::sendViewportAttributesChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMediaStream API: Update RTCPeerConnection states to match the latest editors draft
tommyw@google.com [Thu, 15 Nov 2012 19:01:40 +0000 (19:01 +0000)]
MediaStream API: Update RTCPeerConnection states to match the latest editors draft
https://bugs.webkit.org/show_bug.cgi?id=102382

Reviewed by Adam Barth.

Source/Platform:

Adding a callback for the new RTCPeerConnection::iceGatheringState.

* chromium/public/WebRTCPeerConnectionHandlerClient.h:
(WebKit::WebRTCPeerConnectionHandlerClient::didChangeICEGatheringState):

Source/WebCore:

Updating readyState & iceState, and adding iceGatheringState.
Also safeguarding the event timer callback.

Patch covered by existing tests.

* Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::RTCPeerConnection):
(WebCore::RTCPeerConnection::createOffer):
(WebCore::RTCPeerConnection::createAnswer):
(WebCore::RTCPeerConnection::setLocalDescription):
(WebCore::RTCPeerConnection::localDescription):
(WebCore::RTCPeerConnection::setRemoteDescription):
(WebCore::RTCPeerConnection::remoteDescription):
(WebCore::RTCPeerConnection::updateIce):
(WebCore::RTCPeerConnection::addIceCandidate):
(WebCore::RTCPeerConnection::readyState):
(WebCore::RTCPeerConnection::iceGatheringState):
(WebCore):
(WebCore::RTCPeerConnection::iceState):
(WebCore::RTCPeerConnection::addStream):
(WebCore::RTCPeerConnection::close):
(WebCore::RTCPeerConnection::didChangeIceGatheringState):
(WebCore::RTCPeerConnection::stop):
(WebCore::RTCPeerConnection::changeReadyState):
(WebCore::RTCPeerConnection::scheduledEventTimerFired):
* Modules/mediastream/RTCPeerConnection.h:
(RTCPeerConnection):
* Modules/mediastream/RTCPeerConnection.idl:
* dom/EventNames.h:
(WebCore):
* platform/mediastream/RTCPeerConnectionHandlerClient.h:
(RTCPeerConnectionHandlerClient):
* platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.cpp:
(WebCore::RTCPeerConnectionHandlerChromium::didChangeICEGatheringState):
(WebCore):
* platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.h:
(RTCPeerConnectionHandlerChromium):

Source/WebKit/chromium:

Updating readyState & iceState, and adding iceGatheringState.

* src/AssertMatchingEnums.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r134649 and r134665.
commit-queue@webkit.org [Thu, 15 Nov 2012 19:00:12 +0000 (19:00 +0000)]
Unreviewed, rolling out r134649 and r134665.
http://trac.webkit.org/changeset/134649
http://trac.webkit.org/changeset/134665
https://bugs.webkit.org/show_bug.cgi?id=102413

Broke a ton of downstream chromium tests (Requested by japhet
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-15

Source/WebCore:

* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::DocumentLoader):
(WebCore::DocumentLoader::~DocumentLoader):
(WebCore::DocumentLoader::finishedLoading):
(WebCore::DocumentLoader::clearMainResourceLoader):
(WebCore::DocumentLoader::isLoadingInAPISense):
(WebCore::DocumentLoader::documentURL):
(WebCore::DocumentLoader::isLoadingMainResource):
(WebCore::DocumentLoader::startLoadingMainResource):
* loader/DocumentLoader.h:
(DocumentLoader):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::FrameLoader):
(WebCore::FrameLoader::init):
* loader/FrameLoaderStateMachine.cpp:
(WebCore::FrameLoaderStateMachine::FrameLoaderStateMachine):
* loader/FrameLoaderStateMachine.h:
* loader/MainResourceLoader.cpp:
(WebCore::shouldLoadAsEmptyDocument):
(WebCore):
(WebCore::MainResourceLoader::continueAfterContentPolicy):
(WebCore::MainResourceLoader::didReceiveResponse):
(WebCore::MainResourceLoader::didFinishLoading):
(WebCore::MainResourceLoader::handleEmptyLoad):
(WebCore::MainResourceLoader::loadNow):
(WebCore::MainResourceLoader::load):
* loader/MainResourceLoader.h:
(MainResourceLoader):

Tools:

* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::updateForCommittedLoad):

LayoutTests:

* http/tests/inspector/network/network-iframe-load-and-delete.html:
* http/tests/loading/redirect-methods-expected.txt:
* http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-expected.txt:
* http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-in-body-expected.txt:
* http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-deny-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCorrect syntax of old-style IDL files
haraken@chromium.org [Thu, 15 Nov 2012 18:56:17 +0000 (18:56 +0000)]
Correct syntax of old-style IDL files
https://bugs.webkit.org/show_bug.cgi?id=102335

Reviewed by Adam Barth.

Recently tasak@ corrected an IDL syntax of almost all IDL files.
We should correct the rest of them.

No tests. No change in behavior.

* html/canvas/OESElementIndexUint.idl:
* page/PerformanceMark.idl:
* page/PerformanceMeasure.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWindows Fibers can corrupt the cached StackBounds
mhahnenberg@apple.com [Thu, 15 Nov 2012 18:53:20 +0000 (18:53 +0000)]
Windows Fibers can corrupt the cached StackBounds
https://bugs.webkit.org/show_bug.cgi?id=102411

Reviewed by Geoffrey Garen.

Windows has support for something called fibers, which are like lightweight versions of
threads. Multiple fibers can run within the context of a single thread and they have access
to the same thread local storage but have different stacks. If we create a new JSGlobalContext
on one fiber, then switch to another fiber and create a JSGlobalContext there, we will call
initializeThreading() once for each new JSGlobalContext created. However, since these fibers
are technically running inside the same thread, they will clobber each other's wtfThreadData(),
which is stored using thread local storage. This can lead to corruption of the WTFThreadData
structure for the fibers other than the last one to create a new JSGlobalContext, including
the StackBounds data structure which is used during conservative scanning, among other things.
This can lead to crashes during garbage collection on Windows if fibers are used.

A quick fix would be to always get a fresh StackBounds data structure when asking for it
instead of using the cached version from the thread local storage. There is a larger problem
in that these fibers can corrupt other WebKit data that uses thread local storage. We'll leave
those theoretical fixes for future theoretical bugs.

* wtf/WTFThreadData.h:
(WTF::WTFThreadData::stack): We now refresh the m_stackBounds field whenever somebody asks for
the StackBounds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUse correct unscaled document size when calculating scale limits
commit-queue@webkit.org [Thu, 15 Nov 2012 18:41:52 +0000 (18:41 +0000)]
Use correct unscaled document size when calculating scale limits
https://bugs.webkit.org/show_bug.cgi?id=102028

Patch by Tien-Ren Chen <trchen@chromium.org> on 2012-11-15
Reviewed by Adam Barth.

Fixes bug http://crbug.com/160581
Using contentsSize / pageScaleFactor as unscaled contents size results
in rounding errors. This can cause scale factor to oscillate indefinitely.

* src/WebViewImpl.cpp:
(WebKit::unscaledContentsSize):
(WebKit):
(WebKit::WebViewImpl::computePageScaleFactorLimits):
* tests/WebFrameTest.cpp:
* tests/data/scale_oscillate.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Don't restore zoom and scroll when leaving an input field.
mifenton@rim.com [Thu, 15 Nov 2012 18:40:35 +0000 (18:40 +0000)]
[BlackBerry] Don't restore zoom and scroll when leaving an input field.
https://bugs.webkit.org/show_bug.cgi?id=102376

Reviewed by Yong Li.

Restoring the zoom causes undesirable behavior when switching between fields.

Reviewed Internally by Andrew Lo.

* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::InputHandler):
(BlackBerry::WebKit::InputHandler::ensureFocusTextElementVisible):
* WebKitSupport/InputHandler.h:
(InputHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebCore: Remove isHTMLInputElement since it's unused and toInputElement exists
commit-queue@webkit.org [Thu, 15 Nov 2012 18:33:31 +0000 (18:33 +0000)]
Source/WebCore: Remove isHTMLInputElement since it's unused and toInputElement exists
https://bugs.webkit.org/show_bug.cgi?id=102358

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-11-15
Reviewed by Ojan Vafai.

Remove isHTMLInputElement as no one uses it. Everyone just uses
Node::toInputElement and checks for a 0 return value instead.

toInputElement is also more reliable as there's no requirement that
subclasses of HTMLInputElement have the tag name of inputTag so using
this method in a check could potentially miss future subclasses with
different tag names, though none exist right now.

No new tests, this just deletes dead code.

* html/HTMLInputElement.h:

Source/WebKit/chromium: [chromium] Move allowWebGL query to WebFrameClient
https://bugs.webkit.org/show_bug.cgi?id=102319

Patch by Kenneth Russell <kbr@google.com> on 2012-11-15
Reviewed by Adam Barth.

Moved allowWebGL query to WebFrameClient to avoid polluting
content/ API.

* public/WebFrameClient.h:
(WebFrameClient):
(WebKit::WebFrameClient::allowWebGL):
* public/WebPermissionClient.h:
* src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::allowWebGL):

LayoutTests: Unreviewed: Skipping http/tests/security/sandboxed-iframe-form-top.html
https://bugs.webkit.org/show_bug.cgi?id=102391

This test is leaking state into the following test. Skipping it here,
and will look for a fix in 85522 (oooooold!).

Patch by Mike West <mkwst@chromium.org> on 2012-11-15

* platform/mac/TestExpectations:
    Skip sandboxed-iframe-form-top.html
* platform/max/http/tests/security/sandboxed-iframe-origin-add-expected.txt:
    We're no longer leaking into this test; remove the platform specific
    results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[CMake] Do not regenerate LLIntAssembly.h on every incremental build
commit-queue@webkit.org [Thu, 15 Nov 2012 18:18:42 +0000 (18:18 +0000)]
[CMake] Do not regenerate LLIntAssembly.h on every incremental build
https://bugs.webkit.org/show_bug.cgi?id=102248

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-11-15
Reviewed by Kenneth Rohde Christiansen.

Update LLIntAssembly.h's mtime after running asm.rb to make the build
system dependency tracking consistent.

* CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate DOMException name: NotSupportedError
arv@chromium.org [Thu, 15 Nov 2012 18:17:26 +0000 (18:17 +0000)]
Update DOMException name: NotSupportedError
https://bugs.webkit.org/show_bug.cgi?id=102139

Reviewed by Ojan Vafai.

Source/WebCore:

Patch 9 of 25 to update DOMException name to match the spec and Firefox.

Updated existing tests.

* dom/DOMCoreException.cpp:

LayoutTests:

Updated tests and expectations.

* editing/pasteboard/data-transfer-items-expected.txt:
* fast/canvas/canvas-2d-imageData-create-nonfinite-expected.txt:
* fast/canvas/canvas-createImageData-expected.txt:
* fast/canvas/canvas-getImageData-invalid-expected.txt:
* fast/canvas/canvas-putImageData-expected.txt:
* fast/canvas/canvas-putImageData.js:
* fast/canvas/linearGradient-infinite-values-expected.txt:
* fast/canvas/radialGradient-infinite-values-expected.txt:
* fast/canvas/resources/canvas-2d-imageData-create-nonfinite.js:
* fast/canvas/script-tests/canvas-createImageData.js:
* fast/canvas/script-tests/canvas-getImageData-invalid.js:
* fast/canvas/script-tests/linearGradient-infinite-values.js:
* fast/canvas/script-tests/radialGradient-infinite-values.js:
* fast/dom/HTMLMeterElement/script-tests/set-meter-properties.js:
* fast/dom/HTMLMeterElement/set-meter-properties-expected.txt:
* fast/dom/HTMLProgressElement/script-tests/set-progress-properties.js:
* fast/dom/HTMLProgressElement/set-progress-properties-expected.txt:
* fast/dom/Node/initial-values-expected.txt:
* fast/dom/importNode-null-expected.txt:
* fast/dynamic/insertAdjacentText-expected.txt:
* fast/forms/date/input-valueasnumber-date-expected.txt:
* fast/forms/date/input-valueasnumber-date.html:
* fast/forms/datetime/input-valueasnumber-datetime-expected.txt:
* fast/forms/datetime/input-valueasnumber-datetime.html:
* fast/forms/datetimelocal/input-valueasnumber-datetimelocal-expected.txt:
* fast/forms/datetimelocal/input-valueasnumber-datetimelocal.html:
* fast/forms/month/input-valueasnumber-month-expected.txt:
* fast/forms/month/input-valueasnumber-month.html:
* fast/forms/number/number-valueasnumber-expected.txt:
* fast/forms/number/number-valueasnumber.html:
* fast/forms/range/input-valueasnumber-range-expected.txt:
* fast/forms/range/input-valueasnumber-range.html:
* fast/forms/time/time-valueasnumber-expected.txt:
* fast/forms/time/time-valueasnumber.html:
* fast/forms/week/input-valueasnumber-week-expected.txt:
* fast/forms/week/input-valueasnumber-week.html:
* fast/mediastream/RTCPeerConnection-expected.txt:
* fast/mediastream/argument-types-expected.txt:
* fast/mediastream/getusermedia-expected.txt:
* fast/mediastream/script-tests/argument-types.js:
* http/tests/media/media-source/video-media-source-add-and-remove-buffers-expected.txt:
* platform/chromium/canvas/philip/tests/2d.missingargs-expected.txt:
* platform/chromium/dom/xhtml/level3/core/documentsetxmlversion03-expected.txt:
* platform/chromium/fast/dynamic/insertAdjacentElement-expected.txt:
* platform/efl/fast/dynamic/insertAdjacentElement-expected.txt:
* platform/gtk/fast/dynamic/insertAdjacentElement-expected.txt:
* platform/mac/canvas/philip/tests/2d.missingargs-expected.txt:
* platform/mac/fast/dynamic/insertAdjacentElement-expected.txt:
* platform/qt/fast/dynamic/insertAdjacentElement-expected.txt:
* svg/dom/SVGAngle-expected.txt:
* svg/dom/SVGLength-expected.txt:
* svg/dom/SVGLength-px-expected.txt:
* svg/dom/SVGPreserveAspectRatio-expected.txt:
* transforms/cssmatrix-2d-interface-expected.txt:
* transforms/cssmatrix-3d-interface-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix an erroneous comment about the operators required by binarySearch
mjs@apple.com [Thu, 15 Nov 2012 18:15:39 +0000 (18:15 +0000)]
Fix an erroneous comment about the operators required by binarySearch
https://bugs.webkit.org/show_bug.cgi?id=102406

Reviewed by Anders Carlsson.

* wtf/StdLibExtras.h: binarySearch needs '==' and '<', not '--', '<' and '>'.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove isHTMLInputElement since it's unused and toInputElement exists
commit-queue@webkit.org [Thu, 15 Nov 2012 18:13:54 +0000 (18:13 +0000)]
Remove isHTMLInputElement since it's unused and toInputElement exists
https://bugs.webkit.org/show_bug.cgi?id=102358

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-11-15
Reviewed by Ojan Vafai.

Remove isHTMLInputElement as no one uses it. Everyone just uses
Node::toInputElement and checks for a 0 return value instead.

toInputElement is also more reliable as there's no requirement that
subclasses of HTMLInputElement have the tag name of inputTag so using
this method in a check could potentially miss future subclasses with
different tag names, though none exist right now.

No new tests, this just deletes dead code.

* html/HTMLInputElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed: Skipping http/tests/security/sandboxed-iframe-form-top.html
mkwst@chromium.org [Thu, 15 Nov 2012 18:13:15 +0000 (18:13 +0000)]
Unreviewed: Skipping http/tests/security/sandboxed-iframe-form-top.html
https://bugs.webkit.org/show_bug.cgi?id=102391

This test is leaking state into the following test. Skipping it here,
and will look for a fix in 85522 (oooooold!).

* platform/mac/TestExpectations:
    Skip sandboxed-iframe-form-top.html
* platform/max/http/tests/security/sandboxed-iframe-origin-add-expected.txt:
    We're no longer leaking into this test; remove the platform specific
    results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Fix suspend/resume assertion in setCompositor().
jpetsovits@rim.com [Thu, 15 Nov 2012 17:57:42 +0000 (17:57 +0000)]
[BlackBerry] Fix suspend/resume assertion in setCompositor().
https://bugs.webkit.org/show_bug.cgi?id=102397
RIM PR 244701

Reviewed by Adam Treat.

If a compositor is used but no surface pool is ever
allocated (which is a perfectly valid use case), initial
suspension of the backingstore is skipped because of an
early return. This will cause an assertion to be triggered
and a bug. Fix this by suspending it before the return.

With Adam Treat's recent change to split suspension of
screen and backingstore into two different functions,
this can now be reduced to a mere screen (blitting)
suspension. That was the original intention of this code.

* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::createSurfaces):
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::setCompositor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Rolled DEPS.
commit-queue@webkit.org [Thu, 15 Nov 2012 17:37:23 +0000 (17:37 +0000)]
Unreviewed.  Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-11-15

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate my e-mail address.
akling@apple.com [Thu, 15 Nov 2012 17:16:56 +0000 (17:16 +0000)]
Update my e-mail address.

Rubber-stamped by Anders Koivisto.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate DOMException name: NoModificationAllowedError
arv@chromium.org [Thu, 15 Nov 2012 17:08:49 +0000 (17:08 +0000)]
Update DOMException name: NoModificationAllowedError
https://bugs.webkit.org/show_bug.cgi?id=102134

Reviewed by Ojan Vafai.

Source/WebCore:

Patch 7 of 25 to update DOMException name to match the spec and Firefox.

Updated existing tests.

* dom/DOMCoreException.cpp:

LayoutTests:

Updated tests and expectations.

* dom/xhtml/level1/core/hc_nodevalue03-expected.txt:
* fast/dom/EntityReference/readonly-exceptions-expected.txt:
* fast/dom/HTMLElement/insertAdjacentHTML-errors-expected.txt:
* fast/dom/HTMLElement/script-tests/insertAdjacentHTML-errors.js:
* fast/dom/computed-style-set-property-expected.txt:
* fast/dom/insertAdjacentHTML-DocumentFragment-crash-expected.txt:
* fast/dom/outerText-no-element-expected.txt:
* fast/dom/setPrimitiveValue-exceptions-expected.txt:
* fast/dom/setPrimitiveValue-expected.txt:
* fast/dynamic/outerHTML-no-element-expected.txt:
* fast/frames/out-of-document-iframe-has-child-frame-expected.txt:
* platform/chromium-mac/fast/dom/setPrimitiveValue-exceptions-expected.txt:
* platform/chromium-win/fast/dom/setPrimitiveValue-exceptions-expected.txt:
* platform/chromium-win/svg/custom/baseval-animval-equality-expected.txt:
* platform/chromium/fast/dom/insertAdjacentHTML-DocumentFragment-crash-expected.txt:
* platform/chromium/fast/frames/out-of-document-iframe-has-child-frame-expected.txt:
* platform/chromium/svg/custom/baseval-animval-equality-expected.txt:
* platform/gtk/svg/custom/baseval-animval-equality-expected.txt:
* platform/mac/svg/custom/baseval-animval-equality-expected.txt:
* platform/qt/svg/custom/baseval-animval-equality-expected.txt:
* platform/qt/svg/dom/altGlyph-dom-expected.txt:
* svg/animations/animate-gradient-transform-expected.txt:
* svg/dom/SVGColor-expected.txt:
* svg/dom/SVGLengthList-basics-expected.txt:
* svg/dom/SVGNumberList-basics-expected.txt:
* svg/dom/SVGPaint-expected.txt:
* svg/dom/SVGTransformList-basics-expected.txt:
* svg/dom/SVGViewSpec-defaults-expected.txt:
* svg/dom/altGlyph-dom-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove unnecesary dependencies INPUT_TYPE_COLOR
commit-queue@webkit.org [Thu, 15 Nov 2012 17:06:49 +0000 (17:06 +0000)]
Remove unnecesary dependencies INPUT_TYPE_COLOR
https://bugs.webkit.org/show_bug.cgi?id=102379

Patch by Miguel Garcia <miguelg@chromium.org> on 2012-11-15
Reviewed by Darin Adler.

Platforms should be able to enable INPUT_TYPE_COLOR without enabling
CALENDAR_PICKER and DATALIST_ELEMENT. Before this patch however there would be
compile errors in such configuration.

No new tests since this is not adding any extra functionality.

* WebCore.gyp/WebCore.gyp:
* html/ColorInputType.cpp:
(WebCore::ColorInputType::shouldShowSuggestions):
* make-file-arrays.py:
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate computed line position algorithm
eric.carlson@apple.com [Thu, 15 Nov 2012 17:05:29 +0000 (17:05 +0000)]
Update computed line position algorithm
https://bugs.webkit.org/show_bug.cgi?id=93779

Reviewed by Philippe Normand.

Compute the position of a text track relative to rendered tracks. This is needed to position
cues correctly when there is more than one text track.

Source/WebCore:

Test: media/track/track-cue-container-rendering-position.html

* html/track/TextTrack.cpp:
(WebCore::TextTrack::invalidateTrackIndex): Invalidate both cached track indices.
(WebCore::TextTrack::trackIndexRelativeToRenderedTracks): Return the index of the track relative
    to other rendered tracks.
* html/track/TextTrack.h:

* html/track/TextTrackCue.cpp:
(WebCore::TextTrackCue::calculateComputedLinePosition): Use trackIndexRelativeToRenderedTracks()
    instead of trackIndex() so cues are positioned correctly.

* html/track/TextTrackList.cpp:
(TextTrackList::getTrackIndex): Change return type from unsigned to int.
(TextTrackList::getTrackIndexRelativeToRenderedTracks): New.
* html/track/TextTrackList.h:

LayoutTests:

* media/track/track-cue-container-rendering-position-expected.txt: Added.
* media/track/track-cue-container-rendering-position.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Leave surface resizing to the client.
jpetsovits@rim.com [Thu, 15 Nov 2012 17:02:27 +0000 (17:02 +0000)]
[BlackBerry] Leave surface resizing to the client.
https://bugs.webkit.org/show_bug.cgi?id=102280
RIM PR 235034
RIM PR 160619

Reviewed by Adam Treat.

Now that we always blit on the user interface thread and
use the client's userInterfaceViewportAccessor() to determine
the destination rectangle for blitting, changing the viewport
size does not affect the window or target surface directly.
The only way that blitted output is affected is through
layout, scroll position or scale changes. None of these
require us to synchronize with the UI thread to resize its
target surface.

This commit simplifies setViewportSize() and removes a
blocking message dispatch by simply offloading all surface
resizing responsibilities to the client. This is safer,
cleaner and easier.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::WebPagePrivate):
(BlackBerry::WebKit::WebPage::setScreenOrientation):
(BlackBerry::WebKit::WebPagePrivate::setViewportSize):
* Api/WebPage.h:
* Api/WebPageClient.h:
* Api/WebPage_p.h:
(WebPagePrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Bump Harfbuzz to allow fixing bug 101009 on EFL
dominik.rottsches@intel.com [Thu, 15 Nov 2012 16:59:27 +0000 (16:59 +0000)]
[EFL] Bump Harfbuzz to allow fixing bug 101009 on EFL
https://bugs.webkit.org/show_bug.cgi?id=101323

Reviewed by Martin Robinson.

Source/WebCore:

Removing ifdef since we bumped Harfbuzz dependency. This is the
real fix replacing the previous workaround of having a Chromium
specific ifdef here, since Chromium uses a newer HarfBuzz version
already.

No new tests, covered by css3/flexbox/inline-flex-crash.html
which will not crash anymore even with the ifdef removed.

* platform/graphics/harfbuzz/ng/HarfBuzzShaper.cpp:
(WebCore::HarfBuzzShaper::shapeHarfBuzzRuns):

Tools:

Bumping Harfbuzz to newer version so that we can remove the
ifdef round the fix for bug 101009 for EFL, too.
We're using the zip snapshot since jhbuild can fallback to the previously
downloaded blob in case of network failures which leads to better
buildbot robustness. This zip snapshot currently needs to be locally
patched to fix ICU detection on systems that don't have icu pkg-config files.
The patch is suggested for merging into HarfBuzz. We can remove it locally
once it's accepted into HarfBuzz upstream.

* efl/patches/harfbuzz-icu-detection-fix.patch: Applied after retrieving source to fix harfbuzz detection on systems that don't have pkg-config files for it.
* efl/jhbuild.modules: Bumping harfbuzz version.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Mac] Implement WTR --no-timeout-at-all option
ap@apple.com [Thu, 15 Nov 2012 16:50:57 +0000 (16:50 +0000)]
[Mac] Implement WTR --no-timeout-at-all option
https://bugs.webkit.org/show_bug.cgi?id=102251

Reviewed by Eric Carlson.

* WebKitTestRunner/mac/TestControllerMac.mm: (WTR::TestController::platformRunUntil):
Just do it, and convert to Objective C on the way for simplicity.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION(r134408): Heap-use-after-free in WebCore::HTMLConstructionSite::mergeAttri...
kling@webkit.org [Thu, 15 Nov 2012 16:35:30 +0000 (16:35 +0000)]
REGRESSION(r134408): Heap-use-after-free in WebCore::HTMLConstructionSite::mergeAttributesFromTokenIntoElement().
<http://webkit.org/b/102304>

Reviewed by Anders Carlsson.

Source/WebCore:

Test: fast/dom/cloneNode-below-body-attribute-merging.html

* html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::mergeAttributesFromTokenIntoElement):

    Use Element::fastHasAttribute() to determine if a given attribute is already present on the element
    we're merging attributes into.

* dom/ElementAttributeData.h:
(ElementAttributeData):

    Remove a now-unnecessary friend declaration.

LayoutTests:

* fast/dom/cloneNode-below-body-attribute-merging-expected.txt: Added.
* fast/dom/cloneNode-below-body-attribute-merging.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Move SK_DISABLE_FAST_AA_STROKE_RECT to skia_webkit.gyp
schenney@chromium.org [Thu, 15 Nov 2012 16:11:02 +0000 (16:11 +0000)]
[Chromium] Move SK_DISABLE_FAST_AA_STROKE_RECT to skia_webkit.gyp

Unreviewed non-funtional, behavior-neutral change

* skia_webkit.gyp: Add SK_DISABLE_FAST_AA_STROKE_RECT=1 so that it can be removed from Chromium's skia.gyp

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCleanup test expectations after rebaseline r134668
junov@google.com [Thu, 15 Nov 2012 15:48:56 +0000 (15:48 +0000)]
Cleanup test expectations after rebaseline r134668
https://bugs.webkit.org/show_bug.cgi?id=101974

Unreviewed

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Gardening.
rakuco@webkit.org [Thu, 15 Nov 2012 15:46:01 +0000 (15:46 +0000)]
[EFL] Gardening.

Move some expectations from efl-wk1/ to efl/ since they should
work for both ports (and were originally there).

Skip an additional HiDPI test.

* platform/efl-wk1/fast/borders: Removed.
* platform/efl-wk1/fast/borders/border-radius-wide-border-01-expected.png: Removed.
* platform/efl-wk1/fast/borders/borderRadiusInset01-expected.png: Removed.
* platform/efl-wk1/fast/css: Removed.
* platform/efl-wk1/fast/css/text-overflow-ellipsis-bidi-expected.png: Removed.
* platform/efl-wk1/fast/css/text-overflow-ellipsis-expected.png: Removed.
* platform/efl-wk1/fast/css/text-overflow-ellipsis-strict-expected.png: Removed.
* platform/efl-wk1/fast/css/text-overflow-ellipsis-text-align-center-expected.png: Removed.
* platform/efl-wk1/fast/css/text-overflow-input-expected.png: Removed.
* platform/efl-wk1/fast/css/text-overflow-input-expected.txt: Removed.
* platform/efl-wk1/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.png: Removed.
* platform/efl-wk1/fast/forms/menulist-clip-expected.png: Removed.
* platform/efl-wk1/fast/forms/menulist-option-wrap-expected.png: Removed.
* platform/efl-wk1/fast/forms/select-empty-option-height-expected.png: Removed.
* platform/efl-wk1/fast/media: Removed.
* platform/efl-wk1/fast/media/mq-js-media-except-01-expected.png: Removed.
* platform/efl-wk1/fast/media/mq-js-media-except-01-expected.txt: Removed.
* platform/efl-wk1/fast/repaint/control-clip-expected.png: Removed.
* platform/efl-wk1/svg/dom: Removed.
* platform/efl-wk1/svg/dom/SVGLengthList-appendItem-expected.png: Removed.
* platform/efl-wk1/svg/dom/SVGLengthList-basics-expected.png: Removed.
* platform/efl-wk1/svg/dom/SVGLengthList-getItem-expected.png: Removed.
* platform/efl-wk1/svg/dom/SVGLengthList-initialize-expected.png: Removed.
* platform/efl-wk1/svg/dom/SVGLengthList-insertItemBefore-expected.png: Removed.
* platform/efl-wk1/svg/dom/SVGLengthList-removeItem-expected.png: Removed.
* platform/efl-wk1/svg/dom/SVGLengthList-replaceItem-expected.png: Removed.
* platform/efl-wk1/svg/dom/SVGNumberList-basics-expected.png: Removed.
* platform/efl-wk1/svg/dom/SVGTransformList-basics-expected.png: Removed.
* platform/efl/TestExpectations:
* platform/efl/fast/borders/border-radius-wide-border-01-expected.png: Copied from LayoutTests/platform/efl-wk1/fast/borders/border-radius-wide-border-01-expected.png.
* platform/efl/fast/borders/border-radius-wide-border-05-expected.png: Added.
* platform/efl/fast/borders/borderRadiusInset01-expected.png: Copied from LayoutTests/platform/efl-wk1/fast/borders/borderRadiusInset01-expected.png.
* platform/efl/fast/css/text-overflow-ellipsis-bidi-expected.png: Copied from LayoutTests/platform/efl-wk1/fast/css/text-overflow-ellipsis-bidi-expected.png.
* platform/efl/fast/css/text-overflow-ellipsis-expected.png: Copied from LayoutTests/platform/efl-wk1/fast/css/text-overflow-ellipsis-expected.png.
* platform/efl/fast/css/text-overflow-ellipsis-strict-expected.png: Copied from LayoutTests/platform/efl-wk1/fast/css/text-overflow-ellipsis-strict-expected.png.
* platform/efl/fast/css/text-overflow-ellipsis-text-align-center-expected.png: Copied from LayoutTests/platform/efl-wk1/fast/css/text-overflow-ellipsis-text-align-center-expected.png.
* platform/efl/fast/css/text-overflow-input-expected.png: Copied from LayoutTests/platform/efl-wk1/fast/css/text-overflow-input-expected.png.
* platform/efl/fast/css/text-overflow-input-expected.txt: Copied from LayoutTests/platform/efl-wk1/fast/css/text-overflow-input-expected.txt.
* platform/efl/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.png: Copied from LayoutTests/platform/efl-wk1/fast/css/vertical-text-overflow-ellipsis-text-align-center-expected.png.
* platform/efl/fast/forms/menulist-clip-expected.png: Copied from LayoutTests/platform/efl-wk1/fast/forms/menulist-clip-expected.png.
* platform/efl/fast/forms/menulist-option-wrap-expected.png: Copied from LayoutTests/platform/efl-wk1/fast/forms/menulist-option-wrap-expected.png.
* platform/efl/fast/forms/select-empty-option-height-expected.png: Copied from LayoutTests/platform/efl-wk1/fast/forms/select-empty-option-height-expected.png.
* platform/efl/fast/forms/zoomed-controls-expected.png: Added.
* platform/efl/fast/media/mq-js-media-except-01-expected.png: Copied from LayoutTests/platform/efl-wk1/fast/media/mq-js-media-except-01-expected.png.
* platform/efl/fast/media/mq-js-media-except-01-expected.txt: Copied from LayoutTests/platform/efl-wk1/fast/media/mq-js-media-except-01-expected.txt.
* platform/efl/fast/repaint/control-clip-expected.png: Copied from LayoutTests/platform/efl-wk1/fast/repaint/control-clip-expected.png.
* platform/efl/svg/dom/SVGLengthList-appendItem-expected.png: Copied from LayoutTests/platform/efl-wk1/svg/dom/SVGLengthList-appendItem-expected.png.
* platform/efl/svg/dom/SVGLengthList-basics-expected.png: Copied from LayoutTests/platform/efl-wk1/svg/dom/SVGLengthList-basics-expected.png.
* platform/efl/svg/dom/SVGLengthList-getItem-expected.png: Copied from LayoutTests/platform/efl-wk1/svg/dom/SVGLengthList-getItem-expected.png.
* platform/efl/svg/dom/SVGLengthList-initialize-expected.png: Copied from LayoutTests/platform/efl-wk1/svg/dom/SVGLengthList-initialize-expected.png.
* platform/efl/svg/dom/SVGLengthList-insertItemBefore-expected.png: Copied from LayoutTests/platform/efl-wk1/svg/dom/SVGLengthList-insertItemBefore-expected.png.
* platform/efl/svg/dom/SVGLengthList-removeItem-expected.png: Copied from LayoutTests/platform/efl-wk1/svg/dom/SVGLengthList-removeItem-expected.png.
* platform/efl/svg/dom/SVGLengthList-replaceItem-expected.png: Copied from LayoutTests/platform/efl-wk1/svg/dom/SVGLengthList-replaceItem-expected.png.
* platform/efl/svg/dom/SVGNumberList-basics-expected.png: Copied from LayoutTests/platform/efl-wk1/svg/dom/SVGNumberList-basics-expected.png.
* platform/efl/svg/dom/SVGTransformList-basics-expected.png: Copied from LayoutTests/platform/efl-wk1/svg/dom/SVGTransformList-basics-expected.png.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoPrevent creation of detached frames in ShadowRoot
commit-queue@webkit.org [Thu, 15 Nov 2012 15:42:48 +0000 (15:42 +0000)]
Prevent creation of detached frames in ShadowRoot
https://bugs.webkit.org/show_bug.cgi?id=102333

Patch by Elliott Sprehn <esprehn@chromium.org> on 2012-11-15
Reviewed by Dimitri Glazkov.

Source/WebCore:

Similar to Bug 94717 you can create a loaded iframe in a detached
subtree using ShadowRoot. To fix this we just need to make
SubframeLoadingDisabler traverse through shadow boundaries.

Test: fast/frames/detached-shadow-frame.html

* html/HTMLFrameOwnerElement.h:
(WebCore::SubframeLoadingDisabler::canLoadFrame):

LayoutTests:

Test that you cannot create a detached frame using a ShadowRoot
and iframe unload handlers.

* fast/frames/detached-shadow-frame-expected.txt: Added.
* fast/frames/detached-shadow-frame.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoChanging pseudoClass (:visited) should cause distribution.
shinyak@chromium.org [Thu, 15 Nov 2012 15:28:52 +0000 (15:28 +0000)]
Changing pseudoClass (:visited) should cause distribution.
https://bugs.webkit.org/show_bug.cgi?id=101700

Reviewed by Dimitri Glazkov.

Source/WebCore:

When href attribute of an anchor or area element is changed, we have to invalidate distribution.

Since we would like to check a few pseudoClasses at once, we make the argument of
SelectRuleFeatureSet::hasSelectorFor int.

Tests: fast/dom/shadow/pseudoclass-update-visited-anchor.html
       fast/dom/shadow/pseudoclass-update-visited-area.html

* dom/ElementShadow.cpp:
(WebCore::invalidateParentDistributionIfNecessary):
* dom/ElementShadow.h:
(WebCore):
* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::parseAttribute):
* html/shadow/SelectRuleFeatureSet.h:
(WebCore::SelectRuleFeatureSet::hasSelectorFor):

LayoutTests:

* fast/dom/shadow/pseudoclass-update-visited-anchor-expected.html: Added.
* fast/dom/shadow/pseudoclass-update-visited-anchor.html: Added.
* fast/dom/shadow/pseudoclass-update-visited-area-expected.html: Added.
* fast/dom/shadow/pseudoclass-update-visited-area.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed build fix attempt after r134765.
zandobersek@gmail.com [Thu, 15 Nov 2012 15:28:10 +0000 (15:28 +0000)]
Unreviewed build fix attempt after r134765.

* webkit/webkitviewportattributes.cpp:
(webkitViewportAttributesRecompute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCoordinated Graphics: support the "freeze animations" API
kbalazs@webkit.org [Thu, 15 Nov 2012 15:27:15 +0000 (15:27 +0000)]
Coordinated Graphics: support the "freeze animations" API
https://bugs.webkit.org/show_bug.cgi?id=100703

Reviewed by Noam Rosenthal.

Source/WebCore:

Make animations resumable in Coordinated Graphics.
Pausing was already implemented.

Tested with animations and transitions tests. No tests to be
unskipped because these tests has been working without this API
as well (although this is the preferred way).

* platform/graphics/GraphicsLayerAnimation.cpp:
(WebCore::GraphicsLayerAnimation::apply):
(WebCore::GraphicsLayerAnimation::computeTotalRunningTime):
Do not consider the time while we was suspended as part of
the total running time.
(WebCore):
(WebCore::GraphicsLayerAnimation::resume):
(WebCore::GraphicsLayerAnimations::suspend):
(WebCore::GraphicsLayerAnimations::resume):
* platform/graphics/GraphicsLayerAnimation.h:
(GraphicsLayerAnimation):
(GraphicsLayerAnimations):

Source/WebKit2:

Implement suspendAnimations and resumeAnimations in CoordinatedGraphicsLayer.

* WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::suspendAnimations):
(WebCore):
(WebCore::CoordinatedGraphicsLayer::resumeAnimations):
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:
(CoordinatedGraphicsLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Disable SK_IGNORE_FAST_BLURRECT
schenney@chromium.org [Thu, 15 Nov 2012 15:06:47 +0000 (15:06 +0000)]
[Chromium] Disable SK_IGNORE_FAST_BLURRECT

Source/WebKit/chromium:

Unreviewed test update.

This flag is enabled purely to simplify rebaselining. I am now
removing it and doing the rebaslining.

* skia_webkit.gyp: Remove the line for SK_IGNORE_FAST_BLURRECT

LayoutTests:

Unreviewed test expectations update

* platform/chromium-linux/compositing/shadows/shadow-drawing-expected.png:
* platform/chromium-linux/fast/box-shadow/basic-shadows-expected.png:
* platform/chromium-linux/fast/box-shadow/box-shadow-clipped-slices-expected.png:
* platform/chromium-linux/fast/box-shadow/box-shadow-transformed-expected.png:
* platform/chromium-linux/fast/box-shadow/single-pixel-shadow-expected.png:
* platform/chromium-linux/fast/canvas/canvas-incremental-repaint-expected.png:
* platform/chromium-linux/fast/repaint/box-shadow-h-expected.png:
* platform/chromium-linux/fast/repaint/box-shadow-v-expected.png:
* platform/chromium-linux/fast/repaint/shadow-multiple-vertical-expected.png:
* platform/chromium-linux/fast/transforms/shadows-expected.png:
* platform/chromium-linux/svg/css/group-with-shadow-expected.png:
* platform/chromium-linux/svg/filters/shadow-on-rect-with-filter-expected.png:
* platform/chromium-win/fast/box-shadow/box-shadow-radius-expected.png:
* platform/chromium-win/fast/box-shadow/scaled-box-shadow-expected.png:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRebaseline after r134736
schenney@chromium.org [Thu, 15 Nov 2012 14:18:41 +0000 (14:18 +0000)]
Rebaseline after r134736

Unreviewed expectations update.

Very minor changes, not entirely clear why but not a problem at all.
Probably due to animation cauising an initial valeue to differ
slightly.

* platform/chromium-linux/compositing/checkerboard-expected.png:
* platform/chromium-mac/compositing/checkerboard-expected.png:
* platform/chromium-win/compositing/checkerboard-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Update pixel test expectation for datalist tests
commit-queue@webkit.org [Thu, 15 Nov 2012 14:13:23 +0000 (14:13 +0000)]
[EFL] Update pixel test expectation for datalist tests
https://bugs.webkit.org/show_bug.cgi?id=102365

Unreviewed EFL gardening.

Patch by KwangYong Choi <ky0.choi@samsung.com> on 2012-11-15

* platform/efl/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png:
* platform/efl/fast/forms/datalist/input-appearance-range-with-padding-with-datalist-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION(r134495): It made svg/custom/use-instanceRoot-event-listeners.xhtml fail...
ossy@webkit.org [Thu, 15 Nov 2012 13:59:24 +0000 (13:59 +0000)]
REGRESSION(r134495): It made svg/custom/use-instanceRoot-event-listeners.xhtml fail and fast/events/attribute-listener-deletion-crash.html timeout
https://bugs.webkit.org/show_bug.cgi?id=102183

Unreviewed gardening, unskip now passing tests after r134666.

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRelocate the ARM NEON SVG filter optimizations
rgabor@webkit.org [Thu, 15 Nov 2012 13:42:28 +0000 (13:42 +0000)]
Relocate the ARM NEON SVG filter optimizations
https://bugs.webkit.org/show_bug.cgi?id=102214

Reviewed by Zoltan Herczeg.

Relocate the ARM filter optimizations into platform/graphics/cpu/arm
to keep them together with the others.
From now all graphics optimization for ARM NEON should go here.

* CMakeLists.txt:
* GNUmakefile.am:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* WebCore.pri:
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/cpu/arm/filters/FEBlendNEON.h: Renamed from Source/WebCore/platform/graphics/filters/arm/FEBlendNEON.h.
(WebCore):
(FEBlendUtilitiesNEON):
(WebCore::FEBlendUtilitiesNEON::div255):
(WebCore::FEBlendUtilitiesNEON::normal):
(WebCore::FEBlendUtilitiesNEON::multiply):
(WebCore::FEBlendUtilitiesNEON::screen):
(WebCore::FEBlendUtilitiesNEON::darken):
(WebCore::FEBlendUtilitiesNEON::lighten):
(WebCore::FEBlend::platformApplyNEON):
* platform/graphics/cpu/arm/filters/FECompositeArithmeticNEON.h: Renamed from Source/WebCore/platform/graphics/filters/arm/FECompositeArithmeticNEON.h.
(WebCore):
(WebCore::FEComposite::computeArithmeticPixelsNeon):
(WebCore::FEComposite::platformArithmeticNeon):
* platform/graphics/cpu/arm/filters/FEGaussianBlurNEON.h: Renamed from Source/WebCore/platform/graphics/filters/arm/FEGaussianBlurNEON.h.
(WebCore):
(WebCore::boxBlurNEON):
* platform/graphics/cpu/arm/filters/FELightingNEON.cpp: Renamed from Source/WebCore/platform/graphics/filters/arm/FELightingNEON.cpp.
(WebCore):
(WebCore::feLightingConstantsForNeon):
(WebCore::FELighting::platformApplyNeonWorker):
(WebCore::FELighting::getPowerCoefficients):
* platform/graphics/cpu/arm/filters/FELightingNEON.h: Renamed from Source/WebCore/platform/graphics/filters/arm/FELightingNEON.h.
(WebCore):
(FELightingFloatArgumentsForNeon):
(FELightingPaintingDataForNeon):
(WebCore::FELighting::platformApplyNeon):
* platform/graphics/cpu/arm/filters/NEONHelpers.h: Renamed from Source/WebCore/platform/graphics/filters/arm/NEONHelpers.h.
(WebCore):
(WebCore::loadRGBA8AsFloat):
(WebCore::storeFloatAsRGBA8):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWe should trigger a console warning when we encounter invalid sandbox flags.
mkwst@chromium.org [Thu, 15 Nov 2012 13:04:54 +0000 (13:04 +0000)]
We should trigger a console warning when we encounter invalid sandbox flags.
https://bugs.webkit.org/show_bug.cgi?id=101956

Reviewed by Adam Barth.

Source/WebCore:

A developer who writes '<iframe sandbox="allowScripts">' probably has
something in mind other than what the browser interprets. In these
situations, we should log a console warning that notes 'allowScripts'
is an invalid sandbox flag ('allow-scripts' is probably what she
meant).

This patch does the simplest thing possible: it throws a warning that
lists the invalid flags encountered for sandbox attributes on iframes,
and for sandbox Content Security Policy directives.

Tests: http/tests/security/contentSecurityPolicy/sandbox-invalid-header.html
       http/tests/security/sandboxed-iframe-invalid.html

* dom/SecurityContext.cpp:
(WebCore::SecurityContext::parseSandboxPolicy):
* dom/SecurityContext.h:
(SecurityContext):
    Accept a new out parameter, invalidTokensErrorMessage. If invalid
    tokens are encountered, build an error message string, and pass it
    back to the caller through this parameter.
* html/HTMLIFrameElement.cpp:
(WebCore::HTMLIFrameElement::parseAttribute):
* page/ContentSecurityPolicy.cpp:
(WebCore::CSPDirectiveList::applySandboxPolicy):
    When applying a sandbox policy, pass a string into
    SecurityContext::parseSandboxPolicy to grab any errors that might
    be encountered, and log a warning in that event.
(WebCore::ContentSecurityPolicy::reportInvalidSandboxFlags):
(WebCore):
* page/ContentSecurityPolicy.h:
    Adding a new method to report invalid sandbox flags.

LayoutTests:

* http/tests/security/contentSecurityPolicy/sandbox-invalid-header-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/sandbox-invalid-header.html: Added.
* http/tests/security/sandboxed-iframe-invalid-expected.txt: Added.
* http/tests/security/sandboxed-iframe-invalid.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRename member vars in ViewportArgument to match css-device-adapt
kenneth@webkit.org [Thu, 15 Nov 2012 13:00:33 +0000 (13:00 +0000)]
Rename member vars in ViewportArgument to match css-device-adapt
https://bugs.webkit.org/show_bug.cgi?id=102355

Reviewed by Gyuyoung Kim.

Source/WebCore:

No behavior change, thus no new tests.

* dom/ViewportArguments.cpp:
(WebCore::ViewportArguments::resolve):
(WebCore::setViewportFeature):
* dom/ViewportArguments.h:
(WebCore::ViewportArguments::ViewportArguments):
(ViewportArguments):
(WebCore::ViewportArguments::operator==):

Source/WebKit/efl:

* ewk/ewk_view.cpp:
(_ewk_view_priv_new): Update to reflect name change.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@134765 268f45cc-cd09-0410-ab3c-d52691b4dbfc