WebKit-https.git
12 years ago2008-08-27 Mike Hommey <glandium@debian.org>
zecke@webkit.org [Thu, 28 Aug 2008 01:20:19 +0000 (01:20 +0000)]
2008-08-27  Mike Hommey <glandium@debian.org>

        Reviewed by Holger.

        * GNUmakefile.am:
        * symbols.filter: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebKit/mac:
weinig@apple.com [Thu, 28 Aug 2008 00:50:13 +0000 (00:50 +0000)]
WebKit/mac:

2008-08-27  Robert Kroeger  <rjkroege@liqui.org>

        Tweaked by Sam Weinig.

        Reviewed by Eric Seidel.

        Fix https://bugs.webkit.org/show_bug.cgi?id=6595
        <rdar://problem/4432150>
        Right-click does not fire mouseup event

        Adds a rightMouseUp handler to the WebHTMLView.

        The added method generates mouseup events for button 2.  The result
        is that webkit will deliver mousedown and mouseup events for button
        2 in a fashion identical to FireFox and will retain event ordering
        identical to Internet Explorer.

        Test: fast/events/mouseup-from-button2.html

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView rightMouseUp:]):

LayoutTests:

2008-08-27  Robert Kroeger  <rjkroege@liqui.org>

        Reviewed by Eric Seidel.

        Test for https://bugs.webkit.org/show_bug.cgi?id=6595

        * fast/events/mouseup-from-button2-expected.txt: Added.
        * fast/events/mouseup-from-button2.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by eseidel.
eric@webkit.org [Thu, 28 Aug 2008 00:26:15 +0000 (00:26 +0000)]
    Reviewed by eseidel.

        Fix canvas drawImage to support composite operations.
        Composite had no effect on canvas elements like these:
        http://philip.html5.org/tests/canvas/suite/tests/index.2d.composite.canvas.html

        [CAIRO] Canvas composite don't work on canvas-elements.
        https://bugs.webkit.org/show_bug.cgi?id=20548

        * html/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::drawImage): pass the current composite operator to the drawImage call

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Eric Seidel.
eric@webkit.org [Thu, 28 Aug 2008 00:04:59 +0000 (00:04 +0000)]
    Reviewed by Eric Seidel.

        Fix the data content of an image with a base64.

        * platform/network/curl/ResourceHandleManager.cpp:
        (WebCore::parseDataUrl): Remove the String and use only the data
        Vector because the data.latin1().data() convert the data content and
        the image test ( https://bugs.webkit.org/attachment.cgi?id=21726 ) is
        not drawn correctly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-27 Antti Koivisto <antti@apple.com>
antti@apple.com [Wed, 27 Aug 2008 23:59:50 +0000 (23:59 +0000)]
2008-08-27  Antti Koivisto  <antti@apple.com>

        Reviewed by Eric Seidel.

        Crash after OK in dialog box and reloading page in secure mode
        https://bugs.webkit.org/show_bug.cgi?id=20493

        The new run loop spawned by a modal dialog causes a timer in the loader to run
        synchronously inside didFinishLoading() deleting "this" object.

        Defer all WebCore timers when a modal dialog is up. They are not
        safe to execute.

        * page/Chrome.cpp:
        (WebCore::PageGroupLoadDeferrer::PageGroupLoadDeferrer):
        (WebCore::PageGroupLoadDeferrer::~PageGroupLoadDeferrer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-27 Chris Marrin <cmarrin@apple.com>
simon.fraser@apple.com [Wed, 27 Aug 2008 23:16:36 +0000 (23:16 +0000)]
2008-08-27  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Dave Hyatt

        Memory leaks when animating transforms
        https://bugs.webkit.org/show_bug.cgi?id=20532

        * rendering/style/RenderStyle.cpp:
        (WebCore::ScaleTransformOperation::blend):
        (WebCore::RotateTransformOperation::blend):
        (WebCore::SkewTransformOperation::blend):
        (WebCore::TranslateTransformOperation::blend):
        (WebCore::MatrixTransformOperation::blend):
        * rendering/style/RenderStyle.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Fixed build.
adachan@apple.com [Wed, 27 Aug 2008 22:54:04 +0000 (22:54 +0000)]
    Fixed build.

        * WebFrame.cpp:
        (WebFrame::pluginWillHandleLoadError):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd support for support for -webkit-appearance: default-button on the Mac platform.
timothy@apple.com [Wed, 27 Aug 2008 22:03:24 +0000 (22:03 +0000)]
Add support for support for -webkit-appearance: default-button on the Mac platform.

WebCore:

2008-08-27  Timothy Hatcher  <timothy@apple.com>

        Add support for support for -webkit-appearance: default-button on the Mac platform.

        <rdar://problem/6173530>

        Reviewed by Dave Hyatt.

        * WebCore.base.exp: Export new symbols.
        * platform/mac/WebCoreSystemInterface.h: Add wkAdvanceDefaultButtonPulseAnimation.
        * platform/mac/WebCoreSystemInterface.mm: Ditto.
        * rendering/RenderButton.cpp:
        (WebCore::RenderButton::RenderButton): Remove #if PLATFORM(WIN).
        (WebCore::RenderButton::setStyle): Ditto.
        * rendering/RenderButton.h: Ditto.
        * rendering/RenderThemeMac.mm:
        (WebCore::RenderThemeMac::adjustRepaintRect): Add a case for DefaultButtonAppearance.
        (WebCore::RenderThemeMac::setButtonCellState): Set the key equivalent to the return
        key if the button is default, otherwise reset the key equivalent.
        (WebCore::RenderThemeMac::paintButton): If the button is default call setDefaultButtonCell:
        on the window, then wkAdvanceDefaultButtonPulseAnimation before painting. Restore
        the window's previous default button cell when finished.

WebKit/mac:

2008-08-27  Timothy Hatcher  <timothy@apple.com>

        Add support for support for -webkit-appearance: default-button on the Mac platform.

        <rdar://problem/6173530>

        Reviewed by Dave Hyatt.

        * WebCoreSupport/WebSystemInterface.m:
        (InitWebCoreSystemInterface): Init AdvanceDefaultButtonPulseAnimation.
        * WebView/WebPreferenceKeysPrivate.h: Added WebKitApplicationChromeModeEnabledPreferenceKey.
        * WebView/WebPreferences.mm:
        (+[WebPreferences initialize]): Set WebKitApplicationChromeModeEnabledPreferenceKey to NO.
        (-[WebPreferences applicationChromeModeEnabled]): Added.
        (-[WebPreferences setApplicationChromeModeEnabledEnabled:]): Added.
        * WebView/WebPreferencesPrivate.h:
        * WebView/WebView.mm:
        (-[WebView _preferencesChangedNotification:]): Call Settings::setApplicationChromeMode
        with the value of -[WebPreferences applicationChromeModeEnabled].

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-26 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Wed, 27 Aug 2008 21:18:15 +0000 (21:18 +0000)]
2008-08-26  David Hyatt  <hyatt@apple.com>

        First cut at making form controls on OS X respect full page zoom.  There are lots of bugs.

        Reviewed by weinig

        Added fast/forms/zoomed-controls.html

        * css/CSSStyleSelector.cpp:
        (WebCore::addIntrinsicMargins):
        * rendering/RenderSlider.cpp:
        (WebCore::RenderSlider::calcPrefWidths):
        * rendering/RenderThemeMac.h:
        * rendering/RenderThemeMac.mm:
        (WebCore::RenderThemeMac::adjustRepaintRect):
        (WebCore::RenderThemeMac::inflateRect):
        (WebCore::RenderThemeMac::baselinePosition):
        (WebCore::RenderThemeMac::setControlSize):
        (WebCore::RenderThemeMac::sizeForFont):
        (WebCore::RenderThemeMac::sizeForSystemFont):
        (WebCore::RenderThemeMac::setFontFromControlSize):
        (WebCore::RenderThemeMac::paintCheckbox):
        (WebCore::RenderThemeMac::setCheckboxCellState):
        (WebCore::RenderThemeMac::paintRadio):
        (WebCore::RenderThemeMac::setRadioCellState):
        (WebCore::RenderThemeMac::setButtonPaddingFromControlSize):
        (WebCore::RenderThemeMac::adjustButtonStyle):
        (WebCore::RenderThemeMac::setButtonCellState):
        (WebCore::RenderThemeMac::paintButton):
        (WebCore::RenderThemeMac::paintMenuList):
        (WebCore::RenderThemeMac::paintMenuListButton):
        (WebCore::RenderThemeMac::popupInternalPaddingLeft):
        (WebCore::RenderThemeMac::popupInternalPaddingRight):
        (WebCore::RenderThemeMac::popupInternalPaddingTop):
        (WebCore::RenderThemeMac::popupInternalPaddingBottom):
        (WebCore::RenderThemeMac::setPopupButtonCellState):
        (WebCore::RenderThemeMac::paintSliderTrack):
        (WebCore::RenderThemeMac::paintSliderThumb):
        (WebCore::RenderThemeMac::adjustSliderThumbSize):
        (WebCore::RenderThemeMac::paintSearchField):
        (WebCore::RenderThemeMac::adjustSearchFieldStyle):
        (WebCore::RenderThemeMac::paintSearchFieldCancelButton):
        (WebCore::RenderThemeMac::paintSearchFieldResultsButton):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Adds the WKAdvanceDefaultButtonPulseAnimation function.
timothy@apple.com [Wed, 27 Aug 2008 20:29:45 +0000 (20:29 +0000)]
    Adds the WKAdvanceDefaultButtonPulseAnimation function.

        <rdar://problem/6173530> Add Mac support for -webkit-appearance: default-button

        Reviewed by Adele Peterson.

        * WebKitSystemInterface.h: Added WKAdvanceDefaultButtonPulseAnimation.
        * libWebKitSystemInterfaceLeopard.a: Updated.
        * libWebKitSystemInterfaceTiger.a: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
beidson@apple.com [Wed, 27 Aug 2008 19:59:55 +0000 (19:59 +0000)]
WebCore:

2008-08-27  Brady Eidson  <beidson@apple.com>

        Reviewed by Anders

        <rdar://problem/6134133> - Crash when loading large movie as a standalone document

        We hand off these loads to Quicktime which manages and spools the data itself, but we also continued
        to load and buffer the data for the movie in WebCore.  With large media files, this results in blowing
        away the virtual address space and a crash.

        * loader/EmptyClients.h:
        (WebCore::EmptyFrameLoaderClient::pluginWillHandleLoadError):
        * loader/FrameLoaderClient.h:  Added client method to get platform specific error for
          "plugin will handle load"

        * loader/MediaDocument.cpp:
        (WebCore::MediaTokenizer::createDocumentStructure): Tell the MainResourceLoader to not buffer data,
          and cancel the WebCore-managed load
        (WebCore::MediaTokenizer::writeRawData):
        (WebCore::MediaTokenizer::finish):

WebKit/gtk:

2008-08-27  Brady Eidson  <beidson@apple.com>

        Reviewed by Anders

        <rdar://problem/6134133> - Crash when loading large movie as a standalone document

        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        (WebKit::FrameLoaderClient::pluginWillHandleLoadError): Stubbed for now
        * WebCoreSupport/FrameLoaderClientGtk.h:

WebKit/mac:

2008-08-27  Brady Eidson  <beidson@apple.com>

        Reviewed by Anders

        <rdar://problem/6134133> - Crash when loading large movie as a standalone document

        * WebCoreSupport/WebFrameLoaderClient.h:
        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::pluginWillHandleLoadError):

WebKit/qt:

2008-08-27  Brady Eidson  <beidson@apple.com>

        Reviewed by Anders

        <rdar://problem/6134133> - Crash when loading large movie as a standalone document

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::pluginWillHandleLoadError): Stubbed for now
        * WebCoreSupport/FrameLoaderClientQt.h:

WebKit/win:

2008-08-27  Brady Eidson  <beidson@apple.com>

        Reviewed by Anders

        <rdar://problem/6134133> - Crash when loading large movie as a standalone document

        * WebFrame.cpp:
        (WebFrame::pluginWillHandleLoadError):
        * WebFrame.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-26 Alice Liu <alice.liu@apple.com>
alice.liu@apple.com [Wed, 27 Aug 2008 19:47:43 +0000 (19:47 +0000)]
2008-08-26  Alice Liu  <alice.liu@apple.com>

        Implement COMPropertyBag::GetPropertyInfo
        and a variant setter for type int

        Reviewed by Anders Carlsson.

        * COMPropertyBag.h:
        (::GetPropertyInfo):
        * COMVariantSetter.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-26 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Wed, 27 Aug 2008 18:19:55 +0000 (18:19 +0000)]
2008-08-26  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Eric Seidel

        Linear timing functions should have control points 0, 0, 1, 1.
        https://bugs.webkit.org/show_bug.cgi?id=20535

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::mapAnimationTimingFunction):
        * rendering/style/RenderStyle.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Windows build fix
aroben@apple.com [Wed, 27 Aug 2008 14:52:17 +0000 (14:52 +0000)]
    Windows build fix

        * WebCore.vcproj/WebCore.vcproj: Fix file extension.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-26 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 27 Aug 2008 00:14:51 +0000 (00:14 +0000)]
2008-08-26  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        Test for https://bugs.webkit.org/show_bug.cgi?id=20456

        * http/tests/security/object-literals-expected.txt: Added.
        * http/tests/security/object-literals.html: Added.
        * http/tests/security/resources/object-literals-cross-origin.html: Added.
        * http/tests/security/resources/object-literals-same-origin.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoJavaScriptCore:
kmccullough@apple.com [Tue, 26 Aug 2008 23:47:17 +0000 (23:47 +0000)]
JavaScriptCore:

2008-08-26  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Geoff and Cameron.

        <rdar://problem/6174603> Hitting assertion in Register::codeBlock when
        loading facebook (20516).

        - This was a result of my line numbers change.  After a host function is
        called the stack does not get reset correctly.
        - Oddly this also appears to be a slight speedup on SunSpider.

        * VM/Machine.cpp:
        (KJS::Machine::privateExecute):

LayoutTests:

2008-08-26  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Geoff and Cameron.

        <rdar://problem/6174603> Hitting assertion in Register::codeBlock when
        loading facebook (20516).

        - This was a result of my line numbers change.  After a host function is
        called the stack does not get reset correctly.
        - Oddly this also appears to be a slight speedup on SunSpider.

        * fast/js/resources/stack-unwinding.js: Added.
        * fast/js/stack-unwinding-expected.txt: Added.
        * fast/js/stack-unwinding.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago<rdar://problem/6069462> REGRESSION: webkit is returning flash objects as AXUnknown
cfleizach@apple.com [Tue, 26 Aug 2008 22:56:03 +0000 (22:56 +0000)]
<rdar://problem/6069462> REGRESSION: webkit is returning flash objects as AXUnknown

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35939 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago<rdar://problem/5817770> can't bring up contextual menu for embedded objects
cfleizach@apple.com [Tue, 26 Aug 2008 22:43:22 +0000 (22:43 +0000)]
<rdar://problem/5817770> can't bring up contextual menu for embedded objects

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35938 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago<rdar://problem/6176924> CrashTracer: [USER] 4 crashes in Safari at com.apple.WebCore...
cfleizach@apple.com [Tue, 26 Aug 2008 22:29:14 +0000 (22:29 +0000)]
<rdar://problem/6176924> CrashTracer: [USER] 4 crashes in Safari at com.apple.WebCore: WebCore::RenderTableSection::numColumns

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-26 Sam Weinig <sam@webkit.org>
weinig@apple.com [Tue, 26 Aug 2008 21:21:26 +0000 (21:21 +0000)]
2008-08-26  Sam Weinig  <sam@webkit.org>

        Reviewed by Beth Dakin.

        Fix typo.

        * dom/DOMCoreException.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35936 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
weinig@apple.com [Tue, 26 Aug 2008 19:56:54 +0000 (19:56 +0000)]
WebCore:

2008-08-26  Sam Weinig  <sam@webkit.org>

        Reviewed by Oliver Hunt.

        Fix https://bugs.webkit.org/show_bug.cgi?id=20479
        <rdar://problem/6167660>
        Take image redirects into account when tainting the canvas.

        Test: http/tests/security/canvas-remote-read-redirect-to-remote-image.html

        * html/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::drawImage):
        (WebCore::CanvasRenderingContext2D::drawImageFromRect):

LayoutTests:

2008-08-26  Sam Weinig  <sam@webkit.org>

        Reviewed by Oliver Hunt.

        Test for  https://bugs.webkit.org/show_bug.cgi?id=20479

        * http/tests/security/canvas-remote-read-redirect-to-remote-image-expected.txt: Added.
        * http/tests/security/canvas-remote-read-redirect-to-remote-image.html: Added.
        * http/tests/security/canvas-remote-read-svg-image-expected.txt:
        * http/tests/security/canvas-remote-read-svg-image.html: Fix incorrect log message.
        * http/tests/security/resources/redir.php: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35935 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-26 Sam Weinig <sam@webkit.org>
weinig@apple.com [Tue, 26 Aug 2008 19:51:28 +0000 (19:51 +0000)]
2008-08-26  Sam Weinig  <sam@webkit.org>

        Reviewed by Darin Adler.

        Change canvas tainting logic to ask the image if it contains
        any resources outside of its own origin. Since there is no
        way to determine if SVG images contain any resources outside its
        origin, we always assume it does.

        * html/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::drawImage):
        (WebCore::CanvasRenderingContext2D::drawImageFromRect):
        * platform/graphics/BitmapImage.h:
        (WebCore::BitmapImage::hasSingleSecurityOrigin):
        * platform/graphics/GeneratedImage.h:
        (WebCore::GeneratedImage::hasSingleSecurityOrigin):
        * platform/graphics/Image.h:
        (WebCore::Image::hasSingleSecurityOrigin):
        * platform/graphics/cg/PDFDocumentImage.h:
        (WebCore::PDFDocumentImage::hasSingleSecurityOrigin):
        * svg/graphics/SVGImage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35934 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-26 Maxime Britto <britto@apple.com>
britto@apple.com [Tue, 26 Aug 2008 17:51:03 +0000 (17:51 +0000)]
2008-08-26  Maxime Britto  <britto@apple.com>

        Reviewed by Adele.

        <rdar://6159244> Pan-scrolling does not work on particular sites (starmagazine.com, nytimes.com)
        This patch fixes the issues and modify the behavior of the panscroll by allowing it to jump to a parent layer when it reaches the end of its scrollable area.
        This is matching the behavior of the mouse wheel when trying to scroll in a smaller layer of the page (div, textarea, ...) and when we reach the edge and keep scrolling then the whole page scrolls.

        * page/EventHandler.cpp:
        (WebCore::EventHandler::updateAutoscrollRenderer): if we switch to the parent layer to do the scroll we want to change the renderer for the panning
        * page/EventHandler.h:
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::panScrollFromPoint): now calls the scrollByRecursively method when it has computed the xDelta and yDelta
        (WebCore::RenderLayer::scrollByRecursively): try to scroll the current layer by the xDelta and yDelta provided, if it can't it ask its parent layer to do so.
        * rendering/RenderLayer.h:
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::canBeProgramaticallyScrolled): a RenderObject must have a RenderLayer to be programatically scrolled
        (WebCore::RenderObject::autoscroll): No need to check for the layer anymore since we verify it's present in the upmentionned method
        (WebCore::RenderObject::panScroll): No need to check for the layer anymore too.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Disable a truncation warning that is disabled/doesn't exist on Mac
aroben@apple.com [Tue, 26 Aug 2008 16:07:16 +0000 (16:07 +0000)]
    Disable a truncation warning that is disabled/doesn't exist on Mac

        This warning was firing when initializing floats from double literals.
        I haven't yet found any other situation that would cause this warning
        to arise.

        Reviewed by Sam Weinig.

        * win/tools/vsprops/common.vsprops: Turn off warning C4305.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
jchaffraix@webkit.org [Tue, 26 Aug 2008 10:27:33 +0000 (10:27 +0000)]
WebCore:

2008-08-25  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Darin.

        Bug 20247: setAttributeNode() does not work when attribute name has a capital letter in it
        https://bugs.webkit.org/show_bug.cgi?id=20247

        <rdar://problem/6118218>

        Add a boolean parameter to getAttributeItem to choose between case sensitive and case insensitive
        check. This keeps the behaviour for setAttribute / hasAttribute (case sensitive) and getAttribute
        (case insensitive for HTML elements).

        Test: fast/dom/Element/getAttribute-check-case-sensitivity.html

        * dom/Element.cpp:
        (WebCore::Element::getAttribute):
        * dom/NamedAttrMap.cpp:
        (WebCore::NamedAttrMap::getNamedItem):
        (WebCore::NamedAttrMap::getAttributeItem):
        * dom/NamedAttrMap.h:

LayoutTests:

2008-08-25  Julien Chaffraix  <jchaffraix@webkit.org>

        Reviewed by Darin.

        Test case for Bug 20247: setAttributeNode() does not work when attribute name
        has a capital letter in it
        https://bugs.webkit.org/show_bug.cgi?id=20247

        <rdar://problem/6118218>

        Most of this test case was done by Eric Roman <minatoar@gmail.com>, the rest by ap and was
        tweaked by me.

        * fast/dom/Element/getAttribute-check-case-sensitivity-expected.txt: Added.
        * fast/dom/Element/getAttribute-check-case-sensitivity.html: Added.
        * fast/dom/Element/resources/getAttribute-check-case-sensitivity.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Geoff and Tim.
ap@webkit.org [Tue, 26 Aug 2008 07:05:33 +0000 (07:05 +0000)]
    Reviewed by Geoff and Tim.

        Export new API methods.

        * JavaScriptCore.exp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoModernize the bug reporting guidelines and make them a little less Mac-specific.
mrowe@apple.com [Tue, 26 Aug 2008 07:00:48 +0000 (07:00 +0000)]
Modernize the bug reporting guidelines and make them a little less Mac-specific.

Reviewed by Dan Bernstein.

* quality/bugwriting.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
weinig@apple.com [Tue, 26 Aug 2008 04:19:07 +0000 (04:19 +0000)]
WebCore:

2008-08-25  Sam Weinig  <sam@webkit.org>

        Reviewed by Oliver Hunt.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=20514
        <rdar://problem/6174096>
        Treat SVG images as dirty when drawing to a canvas.

        Test: http/tests/security/canvas-remote-read-svg-image.html

        * html/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::drawImage):
        (WebCore::CanvasRenderingContext2D::drawImageFromRect):
        * platform/graphics/Image.h:
        (WebCore::Image::isSVGImage):
        * svg/graphics/SVGImage.h:
        (WebCore::SVGImage::isSVGImage):

LayoutTests:

2008-08-25  Sam Weinig  <sam@webkit.org>

        Reviewed by Oliver Hunt.

        Test for https://bugs.webkit.org/show_bug.cgi?id=20514

        * http/tests/security/canvas-remote-read-svg-image-expected.txt: Added.
        * http/tests/security/canvas-remote-read-svg-image.html: Added.
        * http/tests/security/resources/image-wrapper.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-25 Sam Weinig <sam@webkit.org>
weinig@apple.com [Tue, 26 Aug 2008 01:52:51 +0000 (01:52 +0000)]
2008-08-25  Sam Weinig  <sam@webkit.org>

        Reviewed by Mark Rowe.

        Fix https://bugs.webkit.org/show_bug.cgi?id=20377
        Leak in XMLHttpRequest.

        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::makeCrossSiteAccessRequestWithPreflight):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Build fix. Copy correct version of ICU.
sfalken@apple.com [Tue, 26 Aug 2008 00:59:02 +0000 (00:59 +0000)]
    Build fix. Copy correct version of ICU.

        * DumpRenderTree/win/DumpRenderTree.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-25 Brady Eidson <beidson@apple.com>
beidson@apple.com [Mon, 25 Aug 2008 21:48:56 +0000 (21:48 +0000)]
2008-08-25  Brady Eidson  <beidson@apple.com>

        Reviewed by Anders

        Speculative fix for <rdar://problem/6173217>

        Moves the "clearArchivedResources()" call to exactly where it used to be in the old version of WebArchive code.
        Also, adds a null check for m_documentLoader since DocumentLoader::stopLoading() can end up clearing it, rendering
        the first null check invalid.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::stopAllLoaders):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-25 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Mon, 25 Aug 2008 21:28:40 +0000 (21:28 +0000)]
2008-08-25  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Tim.

        <rdar://problem/6157711> Heavy/Tree view selector is not grayed out if
        there is no profile, can cause crash

        * page/inspector/ProfilesPanel.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-25 Dean Jackson <dino@apple.com>
dino@apple.com [Mon, 25 Aug 2008 21:06:21 +0000 (21:06 +0000)]
2008-08-25  Dean Jackson  <dino@apple.com>

        Reviewed by Dave Hyatt

        Make sure 'inherit' is handled by transition property.
        https://bugs.webkit.org/show_bug.cgi?id=20513

        Test: transitions/inherit.html
        Test: transitions/inherit-other-props.html

        * css/CSSStyleSelector.cpp:
          fix macro to check existence of list before getting size

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-25 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 25 Aug 2008 20:56:21 +0000 (20:56 +0000)]
2008-08-25  Anders Carlsson  <andersca@apple.com>

        Reviewed by Mark.

        <rdar://problem/6149787> crash @ com.apple.JavaScriptCore: WTF::callOnMainThread + 37.

        Initialize threading in the call to WebCoreObjCFinalizeOnMainThread. We currently assume
        (safely) that any class that needs finalization on the main thread will also need to be deallocated
        on the main thread, and calling initializeThreading from WebCoreObjCFinalizeOnMainThread instead of
        calling it from WebCoreObjCScheduleDeallocateOnMainThread seems safer.

        * platform/mac/WebCoreObjCExtras.c:
        (WebCoreObjCFinalizeOnMainThread):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-25 Antti Koivisto <antti@apple.com>
antti@apple.com [Mon, 25 Aug 2008 20:41:11 +0000 (20:41 +0000)]
2008-08-25  Antti Koivisto  <antti@apple.com>

        Reviewed by Dan Bernstein.

        Rename CachedResource::referenced() to CachedResource::hasClients() to
        match previous ref() -> addClient() rename.

        * loader/Cache.cpp:
        (WebCore::Cache::pruneLiveResources):
        (WebCore::Cache::pruneDeadResources):
        (WebCore::Cache::remove):
        (WebCore::Cache::getStatistics):
        (WebCore::Cache::dumpLRULists):
        * loader/CachedResource.cpp:
        (WebCore::CachedResource::addClient):
        (WebCore::CachedResource::removeClient):
        (WebCore::CachedResource::setDecodedSize):
        (WebCore::CachedResource::setEncodedSize):
        * loader/CachedResource.h:
        (WebCore::CachedResource::hasClients):
        (WebCore::CachedResource::canDelete):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Fix an assertion when showing the Web Inspector
aroben@apple.com [Mon, 25 Aug 2008 19:53:57 +0000 (19:53 +0000)]
    Fix an assertion when showing the Web Inspector

        Reviewed by Kevin McCullough.

        * WebCoreSupport/WebInspectorClient.cpp:
        (WebInspectorClient::attachWindow):
        (WebInspectorClient::detachWindow):
        Recent code changes have caused these functions to get called even
        when the window is already attached/detached, respectively. Handle
        this case gracefully instead of asserting something that is no longer
        true.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Add a missing Inspector localized string for "other".
timothy@apple.com [Mon, 25 Aug 2008 18:33:05 +0000 (18:33 +0000)]
    Add a missing Inspector localized string for "other".

        https://bugs.webkit.org/show_bug.cgi?id=20509

        Reviewed by Tim Hatcher.

        * English.lproj/localizedStrings.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoJavaScriptCore:
kmccullough@apple.com [Mon, 25 Aug 2008 18:18:01 +0000 (18:18 +0000)]
JavaScriptCore:

2008-08-25  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Geoff, Tim and Mark.

        <rdar://problem/6150623> JSProfiler: It would be nice if the profiles
        in the console said what file and line number they came from
        - Lay the foundation for getting line numbers and other data from the
        JavaScript engine.  With the cleanup in kjs/ExecState this is actually
        a slight performance improvement.

        * JavaScriptCore.exp: Export retrieveLastCaller() for WebCore.
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * VM/Machine.cpp: Now Host and JS functions set a call frame on the
        exec state, so this and the profiler code were pulled out of the
        branches.
        (KJS::Machine::privateExecute):
        (KJS::Machine::retrieveLastCaller): This get's the lineNumber, sourceID
        and sourceURL for the previously called function.
        * VM/Machine.h:
        * kjs/ExecState.cpp: Remove references to JSFunction since it's not used
        anywhere.
        * kjs/ExecState.h:

WebCore:

2008-08-22  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Geoff, Mark and Tim.

        <rdar://problem/6150623> JSProfiler: It would be nice if the profiles
        in the console said what file and line number they came from
        - Lay the foundation for getting line numbers and other data from the
        JavaScript engine.

        * ForwardingHeaders/VM: Added.
        * ForwardingHeaders/VM/Machine.h: Added.
        * page/Console.cpp: Gather the line number and file information when
        profileEnd has been called, but don't use it until didFinishProfiling is
        called.  We won't need to wait once we remove the profiler "zombie" mode
        which this patch helps pave the foundation for.
        (WebCore::Console::Console):
        (WebCore::Console::profileEnd):
        (WebCore::Console::finishedProfiling):
        * page/Console.h:
        * page/InspectorController.cpp: Modify calls to
        addProfileMessageToConsole to satisfy the new arguments it takes.
        (WebCore::InspectorController::finishedProfiling):
        (WebCore::InspectorController::addProfile):
        (WebCore::InspectorController::addProfileMessageToConsole):
        (WebCore::InspectorController::finishedProfiling):
        * page/InspectorController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin.
ap@webkit.org [Mon, 25 Aug 2008 12:40:20 +0000 (12:40 +0000)]
    Reviewed by Darin.

        Ensure that JSGlobalContextRelease() performs garbage collection, even if there are other
        contexts in the current context's group.

        This is only really necessary when the last reference is released, but there is no way to
        determine that, and no harm in collecting slightly more often.

        * API/JSContextRef.cpp: (JSGlobalContextRelease): Explicitly collect the heap if it is not
        being destroyed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-25 Holger Hans Peter Freyther <zecke@selfish.org>
hausmann@webkit.org [Mon, 25 Aug 2008 10:08:41 +0000 (10:08 +0000)]
2008-08-25  Holger Hans Peter Freyther  <zecke@selfish.org>

        Reviewed by Simon.

        [run-webkit-tests] Use QtLauncher to show the results of the tests
        konqueror might not be installed, xdg-open might not be installed but the
        QtLauncher should be present.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-25 Holger Hans Peter Freyther <zecke@selfish.org>
hausmann@webkit.org [Mon, 25 Aug 2008 10:06:53 +0000 (10:06 +0000)]
2008-08-25  Holger Hans Peter Freyther  <zecke@selfish.org>

        Reviewed by Simon.

        [inspector] Update the WebKit.qrc Qt resources file
        Catchup with the changes in the directory.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago[inspector] Emit signals from attachWindow and detachWindow in the Qt platform
hausmann@webkit.org [Mon, 25 Aug 2008 10:06:39 +0000 (10:06 +0000)]
[inspector] Emit signals from attachWindow and detachWindow in the Qt platform
    Allow the user of the API to honor the attachWindow and detachWindow
    requests and attach the QWebPage/QWebView wherever it is wanted. This needs
    some more API in QWebPage to be properly exposed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago008-08-25 Dirk Schulze <vbs85@gmx.de>
hausmann@webkit.org [Mon, 25 Aug 2008 07:10:22 +0000 (07:10 +0000)]
008-08-25  Dirk Schulze  <vbs85@gmx.de>

        Reviewed by Simon.

        Transformed the radian to degree, to get rotate()
        in canvas work as expected.

        [Qt] Canvas.rotate() doesn't work
        https://bugs.webkit.org/show_bug.cgi?id=20496

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-24 Steve Falkenburg <sfalken@apple.com>
sfalken@apple.com [Mon, 25 Aug 2008 05:43:33 +0000 (05:43 +0000)]
2008-08-24  Steve Falkenburg  <sfalken@apple.com>

        Add a "last chance" WM_TIMER to the Windows shared timer.

        The last chance timer fires every 5 seconds to run any lost WM_TIMER based timers.
        Failure to fire a timer is fatal to the cross-platform Timer code, since it won't re-schedule
        timers if a timer with an earlier expiration is already pending. This results in no timers
        firing from that point on.

        We lose WM_TIMER messages occasionally (in the neighborhood of 1 per hour) probably due to a
        buggy window message hook.

        This timer will start when the first WM_TIMER is scheduled, and will
        fire every 5 seconds thereafter, causing any lost timers to be fired.

        Found this via one of its symptoms: leaking WebFrames. The fix prevents timers from stalling
        and prevents the WebFrame leak.

        Reviewed by Darin Adler, Geoff Garen.

        * platform/win/SharedTimerWin.cpp:
        (WebCore::):
        (WebCore::TimerWindowWndProc):
        (WebCore::setSharedTimerFireTime):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-24 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Mon, 25 Aug 2008 04:08:01 +0000 (04:08 +0000)]
2008-08-24  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Oliver Hunt.

        Bug 20093: JSC shell does not clear exceptions after it executes toString on an expression
        <https://bugs.webkit.org/show_bug.cgi?id=20093>

        Clear exceptions after evaluating any code in the JSC shell. We do not
        report exceptions that are caused by calling toString on the final
        valued, but at least we avoid incorrect behaviour.

        Also, print any exceptions that occurred while evaluating code at the
        interactive prompt, not just while evaluating code from a file.

        * kjs/Shell.cpp:
        (runWithScripts):
        (runInteractive):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
mitz@apple.com [Mon, 25 Aug 2008 03:22:44 +0000 (03:22 +0000)]
WebCore:

        Reviewed by Darin Adler.

        - fix <rdar://problem/6065547> REGRESSION (r34879): "Subject" in unread emails in Yahoo mail is not shown in bold

        Test: fast/css/font-property-priority.html

        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseValue): Changed to pass the 'important' flag
        to the font-property-parsing functions.
        (WebCore::CSSParser::parseFontStyle): Added an 'important' argument and
        changed to use it rather than the m_important member.
        (WebCore::CSSParser::parseFontVariant): Ditto.
        (WebCore::CSSParser::parseFontWeight): Ditto.
        * css/CSSParser.h:

LayoutTests:

        Reviewed by Darin Adler.

        - test for <rdar://problem/6065547> REGRESSION (r34879): "Subject" in unread emails in Yahoo mail is not shown in bold

        * fast/css/font-property-priority-expected.txt: Added.
        * fast/css/font-property-priority.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-24 Beth Dakin <bdakin@apple.com>
bdakin@apple.com [Mon, 25 Aug 2008 01:27:53 +0000 (01:27 +0000)]
2008-08-24  Beth Dakin  <bdakin@apple.com>

        Reviewed by John Sullivan.

        Provide the excludeFromTextSearch SPI on Windows as well.

        * Interfaces/IWebFrame.idl:
        * WebFrame.cpp:
        (WebFrame::setExcludeFromTextSearch):
        * WebFrame.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Fixes a bug where the Inspector's UI would not animate or
timothy@apple.com [Sun, 24 Aug 2008 22:28:44 +0000 (22:28 +0000)]
    Fixes a bug where the Inspector's UI would not animate or
        fully function because JavaScript timeouts, intervals and
        CSS animation timers where not firing while paused at a
        a breakpoint in the inspected page.

        https://bugs.webkit.org/show_bug.cgi?id=20042

        Reviewed by Darin Adler.

        Test: manual-tests/inspector/forzen-ui-while-paused.html

        * page/JavaScriptDebugServer.cpp:
        (WebCore::JavaScriptDebugServer::pauseIfNeeded):
        Add a call to TimerBase::fireTimersInNestedEventLoop before
        spinning the EventLoop.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-24 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Sun, 24 Aug 2008 21:30:40 +0000 (21:30 +0000)]
2008-08-24  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Oliver.

        Remove an unnecessary RefPtr to a RegisterID.

        * kjs/nodes.cpp:
        (KJS::DeleteBracketNode::emitCode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Sam Weinig.
rwlbuis@webkit.org [Sun, 24 Aug 2008 18:07:32 +0000 (18:07 +0000)]
    Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=20324
        A change in SVG Glyph wont show up

        Invalidate the glyph cache when the d attribute is set.

        Test: svg/custom/glyph-setting-d-attribute.svg

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-24 Jon Honeycutt <jhoneycutt@apple.com>
jhoneycutt@apple.com [Sun, 24 Aug 2008 12:59:03 +0000 (12:59 +0000)]
2008-08-24  Jon Honeycutt  <jhoneycutt@apple.com>

        Cannot get the focused accessible object from the root object.

        AccessibleBase::get_AccFocus() checks whether the focused object is a
        child of the current object, but
        http://msdn.microsoft.com/en-us/library/ms696150(VS.85).aspx states that
        the result is the object itself, if it has focus, or a child object of
        the active window, not a child of the object.

        Reviewed by Sam Weinig.

        * AccessibleBase.cpp:
        (AccessibleBase::get_accFocus): Don't check whether the focused object
        is our child.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-24 Jon Honeycutt <jhoneycutt@apple.com>
jhoneycutt@apple.com [Sun, 24 Aug 2008 12:56:21 +0000 (12:56 +0000)]
2008-08-24  Jon Honeycutt  <jhoneycutt@apple.com>

        Initial support for accessibility layout tests on Windows.
        https://bugs.webkit.org/show_bug.cgi?id=20497

        Reviewed by Sam Weinig.

        * DumpRenderTree/AccessibilityController.h: Fix typos.
        * DumpRenderTree/AccessibilityUIElement.cpp: Change #import to #include.
        * DumpRenderTree/AccessibilityUIElement.h: Define _WINSOCKAPI_ to
        prevent oleacc.h, which includes windows.h, from including winsock.h.
        Fixed typos.
        * DumpRenderTree/win/AccessibilityControllerWin.cpp: Added.
        (AccessibilityController::AccessibilityController):
        (AccessibilityController::~AccessibilityController):
        (AccessibilityController::focusedElement): Get the root element, and
        request its focused object.
        (AccessibilityController::rootElement): Query Windows for the
        accessible client object for the WebView's window.
        * DumpRenderTree/win/AccessibilityUIElementWin.cpp: Added.
        (AccessibilityUIElement::AccessibilityUIElement):
        (AccessibilityUIElement::~AccessibilityUIElement):
        (AccessibilityUIElement::getLinkedUIElements): Not implemented.
        (AccessibilityUIElement::getChildren): Get the child count, and append
        each child.
        (AccessibilityUIElement::getChildAtIndex): Get the child at the given
        index offset by 1. In MSAA, child 0 is the object itself.
        (AccessibilityUIElement::allAttributes): Not implemented.
        (AccessibilityUIElement::attributesOfLinkedUIElements): Same.
        (AccessibilityUIElement::attributesOfChildren): Same.
        (AccessibilityUIElement::parameterizedAttributeNames): Same.
        (self): Return a VARIANT representing the "self" object. This is used
        when calling methods that require a child variant.
        (AccessibilityUIElement::role): Get the MSAA role, a long value, and
        convert it into a string with GetRoleText().
        (AccessibilityUIElement::title): Get the element's title, and convert
        it to a JS String.
        (AccessibilityUIElement::description): Same, for description.
        (AccessibilityUIElement::width):
        (AccessibilityUIElement::height):
        (AccessibilityUIElement::intValue): Get the object's value as a string,
        and convert the string to a double.
        (AccessibilityUIElement::minValue): Not implemented.
        (AccessibilityUIElement::maxValue): Same.
        (AccessibilityUIElement::insertionPointLineNumber): Same.
        (AccessibilityUIElement::attributesOfColumnHeaders): Same.
        (AccessibilityUIElement::attributesOfRowHeaders): Same.
        (AccessibilityUIElement::attributesOfColumns): Same.
        (AccessibilityUIElement::attributesOfRows): Same.
        (AccessibilityUIElement::attributesOfVisibleCells): Same.
        (AccessibilityUIElement::attributesOfHeader): Same.
        (AccessibilityUIElement::indexInTable): Same.
        (AccessibilityUIElement::rowIndexRange): Same.
        (AccessibilityUIElement::columnIndexRange): Same.
        (AccessibilityUIElement::lineForIndex): Same.
        (AccessibilityUIElement::boundsForRange): Same.
        (AccessibilityUIElement::cellForColumnAndRow): Same.
        * DumpRenderTree/win/DumpRenderTree.vcproj: Add accessibility files to
        project.  Link to oleacc.lib, the MSAA library.
        * DumpRenderTree/win/FrameLoadDelegate.cpp:
        (FrameLoadDelegate::FrameLoadDelegate): Initialize the accessibility
        controller.
        (FrameLoadDelegate::didClearWindowObject): Create a new window object
        for the accessibility controller.
        * DumpRenderTree/win/FrameLoadDelegate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Sam Weinig.
mitz@apple.com [Sun, 24 Aug 2008 09:18:39 +0000 (09:18 +0000)]
    Reviewed by Sam Weinig.

        - fix https://bugs.webkit.org/show_bug.cgi?id=13864
          <rdar://problem/5451470> REGRESSION: Uninitialized value in RenderBlock::calcInlinePrefWidths()

        * rendering/RenderText.cpp:
        (WebCore::RenderText::trimmedPrefWidths): Moved the assignment to
        beginWS and endWS before the early return to ensure that they are
        initialized in that case.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUse the correct version number for when JSGlobalContextCreate was introduced.
mrowe@apple.com [Sun, 24 Aug 2008 08:35:21 +0000 (08:35 +0000)]
Use the correct version number for when JSGlobalContextCreate was introduced.

Reviewed by Oliver Hunt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-23 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Sat, 23 Aug 2008 08:16:54 +0000 (08:16 +0000)]
2008-08-23  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Rubber-stamped by Mark Rowe.

        Remove modelines.

        JavaScriptCore:

        * API/APICast.h:
        * API/JSBase.cpp:
        * API/JSCallbackConstructor.cpp:
        * API/JSCallbackConstructor.h:
        * API/JSCallbackFunction.cpp:
        * API/JSCallbackFunction.h:
        * API/JSCallbackObject.cpp:
        * API/JSCallbackObject.h:
        * API/JSCallbackObjectFunctions.h:
        * API/JSClassRef.cpp:
        * API/JSContextRef.cpp:
        * API/JSObjectRef.cpp:
        * API/JSProfilerPrivate.cpp:
        * API/JSStringRef.cpp:
        * API/JSStringRefBSTR.cpp:
        * API/JSStringRefCF.cpp:
        * API/JSValueRef.cpp:
        * API/tests/JSNode.c:
        * API/tests/JSNode.h:
        * API/tests/JSNodeList.c:
        * API/tests/JSNodeList.h:
        * API/tests/Node.c:
        * API/tests/Node.h:
        * API/tests/NodeList.c:
        * API/tests/NodeList.h:
        * API/tests/minidom.c:
        * API/tests/minidom.js:
        * API/tests/testapi.c:
        * API/tests/testapi.js:
        * JavaScriptCore.pro:
        * kjs/FunctionConstructor.h:
        * kjs/FunctionPrototype.h:
        * kjs/JSArray.h:
        * kjs/JSString.h:
        * kjs/JSWrapperObject.cpp:
        * kjs/NumberConstructor.h:
        * kjs/NumberObject.h:
        * kjs/NumberPrototype.h:
        * kjs/lexer.h:
        * kjs/lookup.h:
        * wtf/Assertions.cpp:
        * wtf/Assertions.h:
        * wtf/HashCountedSet.h:
        * wtf/HashFunctions.h:
        * wtf/HashIterators.h:
        * wtf/HashMap.h:
        * wtf/HashSet.h:
        * wtf/HashTable.h:
        * wtf/HashTraits.h:
        * wtf/ListHashSet.h:
        * wtf/ListRefPtr.h:
        * wtf/Noncopyable.h:
        * wtf/OwnArrayPtr.h:
        * wtf/OwnPtr.h:
        * wtf/PassRefPtr.h:
        * wtf/Platform.h:
        * wtf/RefPtr.h:
        * wtf/RefPtrHashMap.h:
        * wtf/RetainPtr.h:
        * wtf/UnusedParam.h:
        * wtf/Vector.h:
        * wtf/VectorTraits.h:
        * wtf/unicode/Unicode.h:
        * wtf/unicode/icu/UnicodeIcu.h:

        WebCore:

        * WebCore.pro:
        * bridge/testbindings.cpp:
        * dom/DocPtr.h:
        * loader/SubstituteData.h:
        * page/Chrome.cpp:
        * page/Chrome.h:
        * page/ChromeClient.h:
        * page/Frame.h:
        * page/FrameLoadRequest.h:
        * page/FrameTree.cpp:
        * page/FrameTree.h:
        * page/Page.h:
        * page/mac/ChromeMac.mm:
        * platform/network/HTTPHeaderMap.h:
        * platform/network/ResourceErrorBase.cpp:
        * platform/network/ResourceErrorBase.h:
        * platform/network/ResourceHandleInternal.h:
        * platform/network/ResourceRequestBase.cpp:
        * platform/network/ResourceRequestBase.h:
        * platform/network/ResourceResponseBase.cpp:
        * platform/network/ResourceResponseBase.h:
        * platform/network/cf/ResourceError.h:
        * platform/network/cf/ResourceRequest.h:
        * platform/network/cf/ResourceRequestCFNet.h:
        * platform/network/cf/ResourceResponse.h:
        * platform/network/cf/ResourceResponseCFNet.h:
        * platform/network/curl/ResourceError.h:
        * platform/network/curl/ResourceRequest.h:
        * platform/network/curl/ResourceResponse.h:
        * platform/network/mac/ResourceError.h:
        * platform/network/mac/ResourceErrorMac.mm:
        * platform/network/mac/ResourceRequest.h:
        * platform/network/mac/ResourceRequestMac.mm:
        * platform/network/mac/ResourceResponse.h:
        * platform/network/mac/ResourceResponseMac.mm:
        * platform/network/qt/ResourceError.h:
        * platform/network/qt/ResourceRequest.h:
        * platform/network/qt/ResourceResponse.h:
        * platform/network/soup/CookieJarSoup.cpp:
        * platform/network/soup/ResourceError.h:
        * platform/network/soup/ResourceRequest.h:
        * platform/network/soup/ResourceResponse.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
mitz@apple.com [Sat, 23 Aug 2008 07:16:41 +0000 (07:16 +0000)]
WebCore:

        Reviewed by Dave Hyatt.

        - fix <rdar://problem/6065143> Reflowed image in first line of table doesn't affect baseline

        Test: fast/table/vertical-align-baseline.html

        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::getBaselineOfFirstLineBox): Added. Returns the
        baseline of the first table row, if there is one, -1 otherwise.
        * rendering/RenderTable.h:
        * rendering/RenderTableCell.cpp:
        (WebCore::RenderTableCell::baselinePosition): Changed to follow the
        CSS2.1 definition of the baseline of a table cell.
        * rendering/RenderTableSection.cpp:
        (WebCore::RenderTableSection::getBaselineOfFirstLineBox): Added. Returns
        the baseline of the first row in the section.
        * rendering/RenderTableSection.h:

LayoutTests:

        Reviewed by Dave Hyatt.

        - test and updated results for <rdar://problem/6065143> Reflowed image in first line of table doesn't affect baseline

        * fast/table/vertical-align-baseline.html: Added.
        * platform/mac/fast/table/form-with-table-style-expected.checksum:
        * platform/mac/fast/table/form-with-table-style-expected.png:
        * platform/mac/fast/table/form-with-table-style-expected.txt:
        * platform/mac/fast/table/vertical-align-baseline-expected.checksum: Added.
        * platform/mac/fast/table/vertical-align-baseline-expected.png: Added.
        * platform/mac/fast/table/vertical-align-baseline-expected.txt: Added.
        * platform/mac/tables/mozilla/bugs/bug3037-1-expected.txt:
        * platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.checksum:
        * platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png:
        * platform/mac/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-22 Cameron Zwarich <cwzwarich@uwaterloo.ca>
cwzwarich@webkit.org [Sat, 23 Aug 2008 03:17:17 +0000 (03:17 +0000)]
2008-08-22  Cameron Zwarich  <cwzwarich@uwaterloo.ca>

        Reviewed by Oliver.

        Some cleanup to match our coding style.

        * VM/CodeGenerator.h:
        * VM/Machine.cpp:
        (KJS::Machine::privateExecute):
        * kjs/ExecState.cpp:
        * kjs/ExecState.h:
        * kjs/completion.h:
        * kjs/identifier.cpp:
        (KJS::Identifier::equal):
        (KJS::CStringTranslator::hash):
        (KJS::CStringTranslator::equal):
        (KJS::CStringTranslator::translate):
        (KJS::UCharBufferTranslator::equal):
        (KJS::UCharBufferTranslator::translate):
        (KJS::Identifier::remove):
        * kjs/operations.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-18 Jon Honeycutt <jhoneycutt@apple.com>
jhoneycutt@apple.com [Fri, 22 Aug 2008 23:44:32 +0000 (23:44 +0000)]
2008-08-18  Jon Honeycutt  <jhoneycutt@apple.com>

        Add SPI to make a Windows WebView transparent.

        Reviewed by Dan Bernstein.

        * Interfaces/IWebViewPrivate.idl:
        * WebCoreSupport/WebFrameLoaderClient.cpp:
        (WebFrameLoaderClient::transitionToCommittedForNewPage): Call
        updateBackground() when a new frame is attached, matching the Mac.
        * WebFrame.cpp:
        (WebFrame::updateBackground): Propagate WebView transparency to ourself
        and our child frames.
        * WebFrame.h:
        * WebView.cpp:
        (WebView::WebView):
        (WebView::paintIntoBackingStore): Pass m_transparent when creating a
        GraphicsContext, so the context will be created with an alpha channel.
        (WebView::setTransparent):
        (WebView::transparent):
        * WebView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-12 Jon Honeycutt <jhoneycutt@apple.com>
jhoneycutt@apple.com [Fri, 22 Aug 2008 23:44:14 +0000 (23:44 +0000)]
2008-08-12  Jon Honeycutt  <jhoneycutt@apple.com>

        Add SPI to get a handle to the WebView's backing store bitmap.

        Reviewed by Dan Bernstein.

        * Interfaces/IWebViewPrivate.idl:
        * WebView.cpp:
        (WebView::backingStore):
        * WebView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Rolls out r35834 because it caused a regression in the Inspector's
timothy@apple.com [Fri, 22 Aug 2008 20:35:20 +0000 (20:35 +0000)]
    Rolls out r35834 because it caused a regression in the Inspector's
        Console where some expressions always threw a syntax error.

        https://bugs.webkit.org/show_bug.cgi?id=20487

        * page/inspector/Console.js:
        (Console.prototype._evalInInspectedWindow): Removes parenthesis
        around the expression.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-22 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 22 Aug 2008 19:39:36 +0000 (19:39 +0000)]
2008-08-22  Anders Carlsson  <andersca@apple.com>

        Fix build for real this time.

        * UserObjectImp.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-22 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 22 Aug 2008 19:14:11 +0000 (19:14 +0000)]
2008-08-22  Anders Carlsson  <andersca@apple.com>

        Fix build.

        * UserObjectImp.cpp:
        (UserObjectImp::toPrimitive):
        * UserObjectImp.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoMakes getStyleProperty return a value for the overflow property when overflow-x and...
timothy@apple.com [Fri, 22 Aug 2008 18:39:52 +0000 (18:39 +0000)]
Makes getStyleProperty return a value for the overflow property when overflow-x and overflow-y are equal.

WebCore:

2008-08-22  Timothy Hatcher  <timothy@apple.com>

        Makes getStyleProperty return a value for the overflow property
        when overflow-x and overflow-y are equal.

        https://bugs.webkit.org/show_bug.cgi?id=20485

        Reviewed by Dan Bernstein.

        Test: fast/css/overflow-property.html

        * css/CSSMutableStyleDeclaration.cpp:
        (WebCore::CSSMutableStyleDeclaration::getPropertyValue):

LayoutTests:

2008-08-22  Timothy Hatcher  <timothy@apple.com>

        Test for the tests the parsing and retrieval of the overflow,
        overflow-x and overflow-y properties

        https://bugs.webkit.org/show_bug.cgi?id=20485

        Reviewed by Dan Bernstein.

        * fast/css/overflow-property-expected.txt: Added.
        * fast/css/overflow-property.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Fixes a bug where while editing in the Inspector the
timothy@apple.com [Fri, 22 Aug 2008 18:39:42 +0000 (18:39 +0000)]
    Fixes a bug where while editing in the Inspector the
        sidebar scroll position would jump to the top.

        https://bugs.webkit.org/show_bug.cgi?id=20484

        Reviewed by Darin Adler.

        * page/inspector/treeoutline.js:
        (TreeOutline._removeChildren): Remove the offsetTop call that
        was forcing a layout, since layout causes scroll positions
        to be clamped to the new scrollHeight/Width. Layout will happen
        normally when needed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin Adler
simon.fraser@apple.com [Fri, 22 Aug 2008 17:38:53 +0000 (17:38 +0000)]
    Reviewed by Darin Adler

        css3/transform-computed-style-001.html is better tested
        by fast/css/getComputedStyle-transform.html, so removed.
        https://bugs.webkit.org/show_bug.cgi?id=20477

        * css3/transform-computed-style-001-expected.txt: Removed.
        * css3/transform-computed-style-001.fhtml: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agowx build fix. Add AccessibilityTable sources.
kevino@webkit.org [Fri, 22 Aug 2008 16:25:52 +0000 (16:25 +0000)]
wx build fix. Add AccessibilityTable sources.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
mitz@apple.com [Fri, 22 Aug 2008 06:29:33 +0000 (06:29 +0000)]
WebCore:

        Reviewed by Jon Honeycutt and Alexey Proskuryakov.

        - fix <rdar://problem/6162701> WebKit should correct Geeza Pro's font metrics

        Test: platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment.html

        * platform/graphics/mac/SimpleFontDataMac.mm:
        (WebCore::SimpleFontData::platformInit): Add 8% to Geeza Pro's reported
        ascent and 100% to its reported descent.

LayoutTests:

        Reviewed by Jon Honeycutt and Alexey Proskuryakov.

        - test for <rdar://problem/6162701> WebKit should correct Geeza Pro's font metrics

        * platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.checksum: Added.
        * platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.png: Added.
        * platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment-expected.txt: Added.
        * platform/mac/fast/text/international/Geeza-Pro-vertical-metrics-adjustment.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-21 Jonas Klink <klinktech@gmail.com>
mrowe@apple.com [Fri, 22 Aug 2008 02:20:13 +0000 (02:20 +0000)]
2008-08-21 Jonas Klink <klinktech@gmail.com>

        Reviewed by Jon Honeycutt.

        Fix https://bugs.webkit.org/show_bug.cgi?id=20231
        Bug 20231: accNavigate: no screen element found in the specified direction should return S_FALSE

        Per <http://msdn.microsoft.com/en-us/library/ms696145(VS.85).aspx>, we should return S_FALSE
        from accNavigate if no screen element is found in the specified direction.

        * AccessibleBase.cpp:
        (AccessibleBase::accNavigate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-21 Jonas Klink <klinktech@gmail.com>
mrowe@apple.com [Fri, 22 Aug 2008 02:20:08 +0000 (02:20 +0000)]
2008-08-21 Jonas Klink <klinktech@gmail.com>

        Reviewed by Jon Honeycutt.

        Fix http://bugs.webkit.org/show_bug.cgi?id=20230
        Bug 20230: get_accState should be testing state on childObj

        Also initializes output parameter action to 0 in get_accDefaultAction.

        * AccessibleBase.cpp:
        (AccessibleBase::get_accState):
        (AccessibleBase::get_accDefaultAction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix bug number in ChangeLog.
mrowe@apple.com [Fri, 22 Aug 2008 02:10:15 +0000 (02:10 +0000)]
Fix bug number in ChangeLog.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-21 Kalle Vahlman <kalle.vahlman@movial.com>
mrowe@apple.com [Fri, 22 Aug 2008 02:07:54 +0000 (02:07 +0000)]
2008-08-21  Kalle Vahlman  <kalle.vahlman@movial.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=19171
        [GTK] Crash on some pages due to a plugin

        Fix handling of badly formatted and empty plugin mime descriptions

        * plugins/gtk/PluginPackageGtk.cpp:
        (WebCore::PluginPackage::fetchInfo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-21 Kevin Watters <kevinwatters@gmail.com>
mrowe@apple.com [Fri, 22 Aug 2008 02:07:48 +0000 (02:07 +0000)]
2008-08-21  Kevin Watters  <kevinwatters@gmail.com>

        Reviewed by Darin Adler.

        Follow other ports (and IE) in ImageSourceWx.cpp never to return an
        animated GIF frame duration of less than 50ms.

        * platform/graphics/wx/ImageSourceWx.cpp:
        (WebCore::ImageSource::frameDurationAtIndex):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-21 Maxime Britto <britto@apple.com>
britto@apple.com [Fri, 22 Aug 2008 00:39:39 +0000 (00:39 +0000)]
2008-08-21  Maxime Britto  <britto@apple.com>

        Reviewed by Kevin McCullough.

        Test: fast/events/autoscroll-nonscrollable-iframe-in-scrollable-div.html
        https://bugs.webkit.org/show_bug.cgi?id=20451

        rdar://problem/6166435 Inspector doesn't auto scroll when selecting text (20451)
        When we climb up the rendering tree looking for a scrollable renderer, we need to be able to jump outside of an iframe.
        This way we can see if what is embedding the iframe can be scrolled even if the iframe content can't.

        * page/EventHandler.cpp:
        (WebCore::EventHandler::handleMouseDraggedEvent): when we reach the document node and it can't be scrolled we set the next parent as the document's owner element if it exists.

        (WebCore::EventHandler::handleMousePressEvent): ditto

2008-08-21  Maxime Britto  <britto@apple.com>

        Reviewed by Kevin McCullough.

        rdar://problem/6166435 Inspector doesn't auto scroll when selecting text (20451)
        https://bugs.webkit.org/show_bug.cgi?id=20451

        This test can be run automatically or manually as well.

        * fast/events/autoscroll-nonscrollable-iframe-in-scrollable-div-expected.txt: Added.
        * fast/events/autoscroll-nonscrollable-iframe-in-scrollable-div.html: Added.
        * fast/events/resources/big-page-with-overflow-hidden.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Small optimization for when the dividers in the Inspector's
timothy@apple.com [Thu, 21 Aug 2008 23:54:01 +0000 (23:54 +0000)]
    Small optimization for when the dividers in the Inspector's
        Resources panel are updated.

        Reviewed by Tim Hatcher.

        * page/inspector/ResourcesPanel.js:
        (WebInsector.ResourcesPanel.prototype._updateGraphDividersIfNeeded):
        Combind a for loop and clone the divider element.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoReviewed by Mark Rowe
simon.fraser@apple.com [Thu, 21 Aug 2008 23:44:56 +0000 (23:44 +0000)]
Reviewed by Mark Rowe

Make build-launcher-app work when run from a git repository.
https://bugs.webkit.org/show_bug.cgi?id=20478

* BuildSlaveSupport/build-launcher-app:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-21 Chris Marrin <cmarrin@apple.com>
dino@apple.com [Thu, 21 Aug 2008 23:35:23 +0000 (23:35 +0000)]
2008-08-21  Chris Marrin  <cmarrin@apple.com>

        Allow 0 (without units) for Time eg. duration
        Fix for https://bugs.webkit.org/show_bug.cgi?id=20467

        Reviewed by Dave Hyatt.

        Test: css1/units/zero-duration-without-units.html

        * css/CSSParser.cpp:
        (WebCore::CSSParser::validUnit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Make deleting all text while editing a DOM attribute in
timothy@apple.com [Thu, 21 Aug 2008 20:13:12 +0000 (20:13 +0000)]
    Make deleting all text while editing a DOM attribute in
        the Inspector delete the attribute. This also fixes
        an exception that would happen before.

        https://bugs.webkit.org/show_bug.cgi?id=20472

        Reviewed by Kevin McCullough.

        * page/inspector/ElementsPanel.js:
        (WebInspector.DOMNodeTreeElement.prototype._attributeEditingCommitted):
        Don't check for hasAttributes on the parseElement, continuing
        through the function will correctly remove the attribute.
        If the parseElement is null, call _editingCancelled not
        editingCancelled, this fixes an exception.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Update the Inspector's Metrics pane when editing in
timothy@apple.com [Thu, 21 Aug 2008 20:12:59 +0000 (20:12 +0000)]
    Update the Inspector's Metrics pane when editing in
        the Styles pane. This makes sure the metrics shown
        always match what the Styles pane shows.

        https://bugs.webkit.org/show_bug.cgi?id=20470

        Reviewed by Kevin McCullough.

        * page/inspector/ElementsPanel.js:
        (WebInspector.ElementsPanel): Add event listeners for
        the "style edited" and "style property toggled" events,
        so the Metrics pane is updated.
        (WebInspector.ElementsPanel.prototype._stylesPaneEdited):
        Update the Metrics pane.
        * page/inspector/StylesSidebarPane.js:
        (WebInspector.StylePropertyTreeElement.prototype.toggleEnabled):
        Dispatch the "style property toggled" event.
        (WebInspector.StylePropertyTreeElement.prototype.editingCancelled):
        Dispatch the "style edited" event when the CSS text is restored.
        (WebInspector.StylePropertyTreeElement.prototype.applyStyleText):
        Dispatch the "style edited" event.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Make the Inspector's Metrics sidebar pane editable.
timothy@apple.com [Thu, 21 Aug 2008 20:12:47 +0000 (20:12 +0000)]
    Make the Inspector's Metrics sidebar pane editable.

        https://bugs.webkit.org/show_bug.cgi?id=17218
        rdar://problem/5732818

        Reviewed by Kevin McCullough.

        * page/inspector/ElementsPanel.js:
        (WebInspector.ElementsPanel): Add an event listener for
        the "metrics edited" event, so the Styles pane is updated.
        * page/inspector/MetricsSidebarPane.js:
        (WebInspector.MetricsSidebarPane.prototype.update): Remember the node
        so future updates work. Add a double click event listener for the
        metric values to start editing.
        (WebInspector.MetricsSidebarPane.prototype.startEditing):
        Call WebInspector.startEditing with some context.
        (WebInspector.MetricsSidebarPane.prototype.editingCancelled):
        (WebInspector.MetricsSidebarPane.prototype.editingCommitted):
        Set the user input on the elements inline style. Fire the
        "metrics edited" event.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Fix a race condition in Windows timer code.
sfalken@apple.com [Thu, 21 Aug 2008 18:42:44 +0000 (18:42 +0000)]
    Fix a race condition in Windows timer code.
        Timer function could end up being called with a 0 timer, leading to a Windows exception.

        Don't post a timer message if one is already pending.

        Reviewed by Ada Chan.

        * platform/win/SharedTimerWin.cpp:
        (WebCore::TimerWindowWndProc):
        (WebCore::clearTimer):
        (WebCore::queueTimerProc):
        (WebCore::setSharedTimerFireTime):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago After trying to add the expression, try again with quotes for
timothy@apple.com [Thu, 21 Aug 2008 16:36:06 +0000 (16:36 +0000)]
    After trying to add the expression, try again with quotes for
        easier edition.

        https://bugs.webkit.org/show_bug.cgi?id=20466

        Reviewed by Tim Hatcher.

        * page/inspector/ObjectPropertiesSection.js: Added an
        evaluateExpression function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Perform Inspector searches on search event to clear results when
timothy@apple.com [Thu, 21 Aug 2008 16:33:17 +0000 (16:33 +0000)]
    Perform Inspector searches on search event to clear results when
        clicking the cross to empty it. Delete the lastQuery when the field
        is emptied in order to perform the search if exactly the same query
        is entered next.

        https://bugs.webkit.org/show_bug.cgi?id=20462

        Reviewed by Tim Hatcher.

        * page/inspector/inspector.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-21 Marco Barisione <marco.barisione@collabora.co.uk>
jmalonzo@webkit.org [Thu, 21 Aug 2008 11:22:51 +0000 (11:22 +0000)]
2008-08-21  Marco Barisione  <marco.barisione@collabora.co.uk>

        Reviewed by Mark Rowe.

        http://bugs.webkit.org/show_bug.cgi?id=19656
        [SOUP] The gio code should call didFail() instead of
        didFinishLoading() in case of error

        In case of error call didFail() instead of didReceiveResponse() and
        didFinishLoading().

        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::networkErrorForFile):
        (WebCore::readCallback):
        (WebCore::openCallback):
        (WebCore::queryInfoCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix build failure.
mrowe@apple.com [Thu, 21 Aug 2008 06:52:42 +0000 (06:52 +0000)]
Fix build failure.

Reviewed by Jon Honeycutt.

* bridge/c/c_instance.cpp:
(KJS::Bindings::CInstance::getPropertyNames): Declare count as uint32_t rather than unsigned
as that is what NPEnumerationFunctionPtr is declared as accepting.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd Anthony Ricaud's blog.
timothy@apple.com [Thu, 21 Aug 2008 05:03:21 +0000 (05:03 +0000)]
Add Anthony Ricaud's blog.

        Reviewed by Tim Hatcher.

        * config.ini: Add Anthony Ricaud's blog.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoBuild fix.
mrowe@apple.com [Thu, 21 Aug 2008 04:01:51 +0000 (04:01 +0000)]
Build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
mitz@apple.com [Thu, 21 Aug 2008 00:33:29 +0000 (00:33 +0000)]
WebCore:

        Rubber-stamped by John Sullivan.

        - rename shouldUpdateWhileHidden to shouldUpdateWhileOffscreen and
          rename related methods and variables accordingly.

        * WebCore.base.exp:
        * page/FrameView.cpp:
        (WebCore::FrameViewPrivate::FrameViewPrivate):
        (WebCore::FrameView::shouldUpdateWhileOffscreen):
        (WebCore::FrameView::setShouldUpdateWhileOffscreen):
        * page/FrameView.h:
        * platform/ScrollView.h:
        * platform/mac/ScrollViewMac.mm:
        (WebCore::ScrollView::updateContents):

WebKit/mac:

        Rubber-stamped by John Sullivan.

        - rename shouldUpdateWhileHidden to shouldUpdateWhileOffscreen,
          rename related methods and variables accordingly, and make
          -setShouldUpdateWhileOffscreen: and -shouldUpdateWhileOffscreen
          WebView API.

        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::transitionToCommittedForNewPage):
        * WebView/WebFrame.mm:
        (-[WebFrame _updateBackgroundAndUpdatesWhileOffscreen]):
        * WebView/WebFrameInternal.h:
        * WebView/WebHTMLView.mm:
        (-[WebHTMLView windowWillOrderOnScreen:]):
        * WebView/WebView.h:
        * WebView/WebView.mm:
        (-[WebViewPrivate init]):
        (-[WebView setBackgroundColor:]):
        (-[WebView setDrawsBackground:]):
        (-[WebView setShouldUpdateWhileOffscreen:]):
        (-[WebView shouldUpdateWhileOffscreen]):
        * WebView/WebViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-20 Brady Eidson <beidson@apple.com>
beidson@apple.com [Thu, 21 Aug 2008 00:13:12 +0000 (00:13 +0000)]
2008-08-20  Brady Eidson  <beidson@apple.com>

        Reviewed by Mitzpettel

        <rdar://problem/6163636> - Many images broken in Mail

        This can be traced back to the preload scanner.  With that change, CachedResources are created a lot
        sooner than before and confuse the WebArchive machinery.

        When referencing WebArchive subresources directly through the WebKit API it is appropriate to ignore
        such CachedResources since they are placeholders and have not been submitted to the ResourceLoadDelegate
        machinery and nothing is known about where the data will eventually come from.

        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::subresource):  Ignore a CachedResource if its preloadResult is
          CachedResource::PreloadReferenced.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoSwitch to non-deprecated NSFileManager APIs.
mrowe@apple.com [Wed, 20 Aug 2008 23:20:55 +0000 (23:20 +0000)]
Switch to non-deprecated NSFileManager APIs.

In order to minimize #if's the new NSFileManager APIs have been implemented for
Tiger and call sites updated to use the new methods.

Reviewed by Darin Adler.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Dave Hyatt
simon.fraser@apple.com [Wed, 20 Aug 2008 23:04:43 +0000 (23:04 +0000)]
    Reviewed by Dave Hyatt

        getComputedStyle() for webkitTransform should return a transform
        that does not have the transform origin baked into it.
        https://bugs.webkit.org/show_bug.cgi?id=20464

        * fast/css/getComputedStyle-transform-expected.txt: Added.
        * fast/css/getComputedStyle-transform.html: Added.

        (Missed these test files on last commit)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-20 Holger Hans Peter Freyther <zecke@selfish.org>
zecke@webkit.org [Wed, 20 Aug 2008 22:50:39 +0000 (22:50 +0000)]
2008-08-20  Holger Hans Peter Freyther  <zecke@selfish.org>

        Unreviewed compile fix

        Catch up with the JSValue::type elimination.

        * bridge/qt/qt_instance.cpp:
        (KJS::Bindings::QtRuntimeObjectImp::construct):
        (KJS::Bindings::QtInstance::defaultValue):
        * bridge/qt/qt_runtime.cpp:
        (KJS::Bindings::QtRuntimeConnectionMethod::call):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-20 Chris Teague <chris.teague@gmail.com>
mrowe@apple.com [Wed, 20 Aug 2008 22:15:53 +0000 (22:15 +0000)]
2008-08-20  Chris Teague  <chris.teague@gmail.com>

        Reviewed by Mark Rowe.

        Fix https://bugs.webkit.org/show_bug.cgi?id=20449
        Bug 20449: Build fails if LOW_BANDWIDTH_DISPLAY is defined

        * ChangeLog:
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::switchOutLowBandwidthDisplayIfReady):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Dave Hyatt
simon.fraser@apple.com [Wed, 20 Aug 2008 21:57:22 +0000 (21:57 +0000)]
    Reviewed by Dave Hyatt

        getComputedStyle() for webkitTransform should return a transform
        that does not have the transform origin baked into it.
        https://bugs.webkit.org/show_bug.cgi?id=20464

        Test: fast/css/getComputedStyle-transform.html

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::computedTransform):
        * rendering/style/RenderStyle.cpp:
        (WebCore::RenderStyle::applyTransform):
        * rendering/style/RenderStyle.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
andersca@apple.com [Wed, 20 Aug 2008 21:04:12 +0000 (21:04 +0000)]
WebCore:

2008-08-20  Josh Aas  <joshmoz@gmail.com>

        Reviewed and landed by Anders.

        <rdar://problem/6163636>
        rename NPCocoaEvent's "event" struct to "data" (20446)

        * bridge/npapi.h:
        (_NPCocoaEvent::):

WebKit/mac:

2008-08-20  Josh Aas  <joshmoz@gmail.com>

        Reviewed and landed by Anders.

        <rdar://problem/6163636>
        rename NPCocoaEvent's "event" struct to "data" (20446)

        * Plugins/WebNetscapePluginEventHandlerCocoa.mm:
        (WebNetscapePluginEventHandlerCocoa::drawRect):
        (WebNetscapePluginEventHandlerCocoa::sendMouseEvent):
        (WebNetscapePluginEventHandlerCocoa::flagsChanged):
        (WebNetscapePluginEventHandlerCocoa::sendKeyEvent):
        (WebNetscapePluginEventHandlerCocoa::windowFocusChanged):
        (WebNetscapePluginEventHandlerCocoa::focusChanged):

WebKitExamplePlugins:

2008-08-20  Josh Aas  <joshmoz@gmail.com>

        Reviewed and landed by Anders.

        <rdar://problem/6163636>
        rename NPCocoaEvent's "event" struct to "data" (20446)

        * NetscapeCocoaPlugin/main.m:
        (handleMouseEvent):
        (handleKeyboardEvent):
        (NPP_HandleEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
bdakin@apple.com [Wed, 20 Aug 2008 20:46:28 +0000 (20:46 +0000)]
WebCore:

2008-08-20  Beth Dakin  <bdakin@apple.com>

        Reviewed by Darin.

        Fix for <rdar://problem/6145626>
        This patch fixes a number of remaining problems getting
        disconnected frames to work correctly with markAllMatchesForText()
        and findString(). Details inline.

        This was a static helper function in Frame, but this patch requires
        the same functionality in Editor, so I just added it as a function
        on Node.
        * dom/Node.cpp:
        (WebCore::Node::isInShadowTree):
        * dom/Node.h:

        * editing/Editor.cpp:
        (WebCore::Editor::insideVisibleArea): Returns false if
        excludeFromTextSearch() is true.

        In a normal (non-disconnected) frame, findString returns a range of
        the document node if the text is not found in the frame. I changed
        firstVisibleRange and lastVisibleRange to match that behavior when
        the text is not found
        (WebCore::Editor::firstVisibleRange):
        (WebCore::Editor::lastVisibleRange):

        Here are the bulk of the changes in the patch. A lot of text was
        not being found in disconnected frames because I failed to account
        for all of the possible problems associated with shadow trees. That
        is fixed here.
        (WebCore::Editor::nextVisibleRange):
        * editing/Editor.h:

        excludeFromTextSearch() is new. It allows a WebKit client to mark a
        frame as not-text-searchable through SPI.
        * WebCore.base.exp:
        * page/Frame.cpp:
        (WebCore::Frame::excludeFromTextSearch):
        (WebCore::Frame::setExcludeFromTextSearch):
        (WebCore::FramePrivate::FramePrivate):
        * page/Frame.h:
        * page/FramePrivate.h:

        (WebCore::Frame::findString):
        (WebCore::Frame::markAllMatchesForText):  I kept running into an
        assertion failure in paining code because of the forced paint on
        empty visible rects.

WebKit/mac:

2008-08-20  Beth Dakin  <bdakin@apple.com>

        Reviewed by Darin.

        Fix for <rdar://problem/6145626>
        Allows a WebKit client to mark a frame as not-text-searchable
        through SPI.

        * WebView/WebFrame.mm:
        (-[WebFrame _setExcludeFromTextSearch:]):
        * WebView/WebFramePrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Adds a positon box to the Inspector's Metrics sidebar
timothy@apple.com [Wed, 20 Aug 2008 19:10:54 +0000 (19:10 +0000)]
    Adds a positon box to the Inspector's Metrics sidebar
        pane. When an element is not statically positioned, there
        is now a position box that show top, right, bottom and
        left computed values.

        Reviewed by Kevin McCullough.

        * English.lproj/localizedStrings.js: Updated the strings.
        * page/inspector/MetricsSidebarPane.js:
        (WebInspector.MetricsSidebarPane.prototype.update):
        Renamed the boxPartValue function to createBoxPartElement
        and made it create the entire element. Made it understand
        how to get position style properties. Don't use the figure dash
        when 0px is used for positions, since the 0 is meaningful there.
        Instead use the figure dash when a position is auto.
        * page/inspector/inspector.css: Added a new rule for position.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-20 Maxime Britto <britto@apple.com>
britto@apple.com [Wed, 20 Aug 2008 19:01:24 +0000 (19:01 +0000)]
2008-08-20  Maxime Britto  <britto@apple.com>

        Reviewed by Ada Chan.

        rdar://5259746
        Mouse events are sent to page while resizing window (affects Gmail)
        In the WebView, if the MouseEvent is located in the resize corner, we send it back to the UIDelegate and early return.

        * Interfaces/IWebUIDelegatePrivate.idl: Add a new method to the UIDelegate to send the resize message
        * WebView.cpp:
        (WebView::handleMouseEvent): If the mouse event is in the resize corner and our UIDelegate supports the message it sends the new message and early returns

2008-08-20  Maxime Britto  <britto@apple.com>

        Reviewed by Ada Chan.

         rdar://5259746
        Mouse events are sent to page while resizing window (affects Gmail)

        * DumpRenderTree/win/UIDelegate.h:
        (UIDelegate::webViewSendResizeMessage): Add the new interface method, not implemented.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoQt build fix
cfleizach@apple.com [Wed, 20 Aug 2008 18:34:56 +0000 (18:34 +0000)]
Qt build fix

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Anders Carlsson.
mitz@apple.com [Wed, 20 Aug 2008 18:28:07 +0000 (18:28 +0000)]
    Reviewed by Anders Carlsson.

        - avoid using a deprecated NSScroller method on Leopard

        * platform/mac/PlatformScrollBarMac.mm:
        (WebCore::PlatformScrollbar::updateThumbPosition):
        (WebCore::PlatformScrollbar::updateThumbProportion):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-08-20 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Wed, 20 Aug 2008 11:40:31 +0000 (11:40 +0000)]
2008-08-20  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Oliver Hunt.

        Gtk build fix

        * GNUmakefile.am:
        * page/AccessibilityTable.cpp: Change nil to 0
        (WebCore::AccessibilityTable::cellForColumnAndRow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35855 268f45cc-cd09-0410-ab3c-d52691b4dbfc