WebKit-https.git
13 years agoReviewed by Sam.
zimmermann@webkit.org [Thu, 17 Jul 2008 00:41:38 +0000 (00:41 +0000)]
Reviewed by Sam.

Fixes: https://bugs.webkit.org/show_bug.cgi?id=20052
Export the tag & attribute names as string literals for SVGNames/XLinkNames and one property in HTMLNames.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoRubber stamped by Eric.
zimmermann@webkit.org [Thu, 17 Jul 2008 00:22:41 +0000 (00:22 +0000)]
Rubber stamped by Eric.
Update pixel test results for two tests that have been changed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoReviewed by Eric.
zimmermann@webkit.org [Wed, 16 Jul 2008 23:34:53 +0000 (23:34 +0000)]
Reviewed by Eric.

Fixes: https://bugs.webkit.org/show_bug.cgi?id=10745 (SVGLength object needs some weight loss)
Don't store a context pointer in SVGLength, saving memory.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
ggaren@apple.com [Wed, 16 Jul 2008 22:47:32 +0000 (22:47 +0000)]
JavaScriptCore:

2008-07-16  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        First step toward putting doubles in registers: Turned Register into a
        proper abstraction layer. It is no longer possible to cast a Register
        to a JSValue*, or a Register& to a JSValue*&, or to access the union
        inside a Register directly.

        SunSpider reports no change.

        In support of this change, I had to make the following mechanical changes
        in a lot of places:

        1. Clients now use explicit accessors to read data out of Registers, and
        implicit copy constructors to write data into registers.

        So, assignment that used to look like

            x.u.jsValue = y;

        now looks like

            x = y;

        And access that used to look like

            x = y.u.jsValue;

        now looks like

            x = y.jsValue();

        2. I made generic flow control specific in opcodes that made their flow
        control generic by treating a Register& as a JSValue*&. This had the
        added benefit of removing some exception checking branches from immediate
        number code.

        3. I beefed up PropertySlot to support storing a Register* in a property
        slot. For now, only JSVariableObject's symbolTableGet and symbolTablePut
        use this functionality, but I expect more clients to use it in the future.

        4. I changed ArgList to be a buffer of Registers, not JSValue*'s, and I
        changed ArgList iterator clients to iterate Registers, not JSValue*'s.

WebCore:

2008-07-16  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        Support for JavaScriptCore's first step toward putting doubles in
        registers: Treat ArgList iterators as Register*'s, not JSValue*'s.

        * bindings/js/ScheduledAction.cpp:
        (WebCore::ScheduledAction::ScheduledAction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fixed build.
adachan@apple.com [Wed, 16 Jul 2008 21:41:14 +0000 (21:41 +0000)]
    Fixed build.

        * kjs/JSGlobalObject.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoReviewed by Anders Carlsson.
zimmermann@webkit.org [Wed, 16 Jul 2008 21:24:12 +0000 (21:24 +0000)]
Reviewed by Anders Carlsson.
Add missing layout test results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-16 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Wed, 16 Jul 2008 20:37:35 +0000 (20:37 +0000)]
2008-07-16  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Sam and Geoff.

        <rdar://problem/5958840> Navigating to another page while profiler is
        attached results in slow JavaScript for all time.

        - The UNLIKELY keeps this from being a sunspider performance regression.

        * kjs/JSGlobalObject.cpp:
        (KJS::JSGlobalObject::~JSGlobalObject): Stop the profiler associated
        with this exec state.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-16 Sam Weinig <sam@webkit.org>
weinig@apple.com [Wed, 16 Jul 2008 20:19:56 +0000 (20:19 +0000)]
2008-07-16  Sam Weinig  <sam@webkit.org>

        Reviewed by Steve Falkenburg.

        Replace adopting UString constructor in favor of explicit
        static adopt method.

        * API/JSStringRefCF.cpp:
        (JSStringCreateWithCFString):
        * kjs/StringConstructor.cpp:
        (KJS::stringFromCharCode):
        * kjs/StringPrototype.cpp:
        (KJS::stringProtoFuncToLowerCase):
        (KJS::stringProtoFuncToUpperCase):
        (KJS::stringProtoFuncToLocaleLowerCase):
        (KJS::stringProtoFuncToLocaleUpperCase):
        * kjs/ustring.cpp:
        (KJS::UString::adopt):
        * kjs/ustring.h:
        (KJS::UString::UString):
        (KJS::UString::~UString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-16 Ariya Hidayat <ariya.hidayat@trolltech.com>
hausmann@webkit.org [Wed, 16 Jul 2008 10:14:03 +0000 (10:14 +0000)]
2008-07-16  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Reviewed by Simon.

        http://trolltech.com/developer/task-tracker/index_html?method=entry&id=216179
        Fix potential crash (on Qt for Windows port) when performing JavaScript date
        conversion.

        * kjs/DateMath.cpp:
        (KJS::getLocalTime): For the Qt port, prefer to use Windows code, i.e.
        localtime_s() instead of localtime() since the latter might crash (on Windows)
        given a non-sensible, e.g. NaN, argument.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix a typo in ChangeLog.
ap@webkit.org [Wed, 16 Jul 2008 08:24:35 +0000 (08:24 +0000)]
Fix a typo in ChangeLog.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Anders and Geoff.
ap@webkit.org [Wed, 16 Jul 2008 08:20:23 +0000 (08:20 +0000)]
    Reviewed by Anders and Geoff.

        https://bugs.webkit.org/show_bug.cgi?id=20023
        Failed assertion in PropertyNameArray.cpp

        This is already tested by testapi.

        * API/JSObjectRef.cpp: (JSPropertyNameAccumulatorAddName): Add the string to identifier
        table to appeaase PropertyNameArray.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Geoff.
ap@webkit.org [Wed, 16 Jul 2008 08:07:11 +0000 (08:07 +0000)]
    Reviewed by Geoff.

        Dereference identifiers when deleting a hash table (fixes leaks with private JSGlobalData
        objects).

        * kjs/JSGlobalData.cpp: (KJS::JSGlobalData::~JSGlobalData):
        * kjs/lookup.cpp: (KJS::HashTable::deleteTable):
        * kjs/lookup.h:
        * kjs/lexer.cpp: (KJS::Lexer::~Lexer)
        HashTable cannot have a destructor, because check-for-global-initializers complains about
        having a global constructor then.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Geoff.
ap@webkit.org [Wed, 16 Jul 2008 07:58:38 +0000 (07:58 +0000)]
    Reviewed by Geoff.

        Check pthread_key_create return value.

        This check was helpful when debugging a crash in run-webkit-tests --threaded that happened
        because JSGlobalData objects were not deleted, and we were running out of pthread keys soon.
        It also looks useful for production builds.

        * wtf/ThreadSpecific.h: (WTF::::ThreadSpecific):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35194 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebKitTools:
weinig@apple.com [Wed, 16 Jul 2008 04:53:29 +0000 (04:53 +0000)]
WebKitTools:

2008-07-15  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        Refactor accessibility testing code.

        We now have:
        - AccessibilityController
          Controller which has access to the WebView and can provide the focused element, root element
          and in the future, elementAtPoint.

        - AccessibilityUIElement
          Object which provides access to the data provided by the Accessibility APIs.

        * DumpRenderTree/AccessibilityController.cpp:
        (getFocusedElementCallback):
        (getRootElementCallback):
        (AccessibilityController::getJSClass):
        * DumpRenderTree/AccessibilityController.h:
        * DumpRenderTree/AccessibilityUIElement.cpp: Added.
        (allAttributesCallback):
        (attributesOfLinkedUIElementsCallback):
        (attributesOfChildrenCallback):
        (getRoleCallback):
        (getTitleCallback):
        (getDescriptionCallback):
        (getWidthCallback):
        (getHeightCallback):
        (getIntValueCallback):
        (getMinValueCallback):
        (getMaxValueCallback):
        (finalize):
        (AccessibilityUIElement::makeJSAccessibilityUIElement):
        (AccessibilityUIElement::getJSClass):
        * DumpRenderTree/AccessibilityUIElement.h: Added.
        (AccessibilityUIElement::platformUIElement):
        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
        * DumpRenderTree/mac/AccessibilityControllerMac.mm:
        (AccessibilityController::AccessibilityController):
        (AccessibilityController::~AccessibilityController):
        (AccessibilityController::focusedElement):
        (AccessibilityController::rootElement):
        * DumpRenderTree/mac/AccessibilityUIElementMac.mm: Added.
        (AccessibilityUIElement::AccessibilityUIElement):
        (descriptionOfValue):
        (attributesOfElement):
        (nsStringToJSStringRef):
        (concatenateAttributeAndValue):
        (AccessibilityUIElement::getLinkedUIElements):
        (AccessibilityUIElement::getChildren):
        (AccessibilityUIElement::attributesOfLinkedUIElements):
        (AccessibilityUIElement::attributesOfChildren):
        (AccessibilityUIElement::allAttributes):
        (AccessibilityUIElement::role):
        (AccessibilityUIElement::title):
        (AccessibilityUIElement::description):
        (AccessibilityUIElement::width):
        (AccessibilityUIElement::height):
        (AccessibilityUIElement::intValue):
        (AccessibilityUIElement::minValue):
        (AccessibilityUIElement::maxValue):

LayoutTests:

2008-07-15  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        Update for refactored accessibility testing code.

        * accessibility/aria-describedby-on-input.html:
        * accessibility/aria-labelledby-on-input.html:
        * accessibility/aria-range-value.html:
        * accessibility/aria-range.html:
        * accessibility/aria-roles.html:
        * accessibility/aria-slider.html:
        * accessibility/aria-spinbutton.html:
        * accessibility/document-attributes.html:
        * accessibility/image-map1.html:
        * accessibility/image-map2.html:
        * accessibility/internal-link-anchors.html:
        * accessibility/radio-button-checkbox-size.html:
        * accessibility/radio-button-group-members.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35193 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoVersioning.
mrowe@apple.com [Wed, 16 Jul 2008 04:11:34 +0000 (04:11 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35192 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-15 Maxime Britto <britto@apple.com>
britto@apple.com [Wed, 16 Jul 2008 03:17:38 +0000 (03:17 +0000)]
2008-07-15  Maxime Britto  <britto@apple.com>

        Reviewed by Eric.

        https://bugs.webkit.org/show_bug.cgi?id=17589
        <rdar://problem/5770893>
        Retrieve the wheel sensitivity setting from windows system settings for the horizontal and the vertical scrolling.
        Allows the page scrolling with the wheel (if activated in windows settings) on both horizontal and vertical ways
        For the other platforms, nothing is changed but if someone want to activate this feature
        he/she has to retrieve the settings and fill out the m_lineScrollSensitivity and/or m_charScrollSensitivity in his/her PlatformWheelEvent constructor.

        * ChangeLog:
        * page/EventHandler.cpp:
        (WebCore::scrollAndAcceptEvent): static inline function to avoid copy/paste in the member functions
        (WebCore::EventHandler::handleWheelEvent): Call to the above mentionned static inline function with the right parameters
        * platform/PlatformWheelEvent.h:
        (WebCore::PlatformWheelEvent::deltaX): Now returns the delta multiplied by the user settings for the number of lines to scroll
        (WebCore::PlatformWheelEvent::deltaY): Now returns the delta multiplied by the user settings for the number of chars to scroll
        (WebCore::PlatformWheelEvent::isPageXScrollModeEnabled):
        (WebCore::PlatformWheelEvent::isPageYScrollModeEnabled):
        * platform/gtk/WheelEventGtk.cpp: Add the values to avoid build break but the factors are initialized to 1 not to change the previous behavior
        (WebCore::PlatformWheelEvent::PlatformWheelEvent):
        * platform/mac/WheelEventMac.mm: Add the values to avoid build break but the factors are initialized to 1 not to change the previous behavior
        (WebCore::PlatformWheelEvent::PlatformWheelEvent):
        * platform/qt/WheelEventQt.cpp: Add the values to avoid build break but the factors are initialized to 1 not to change the previous behavior
        (WebCore::PlatformWheelEvent::PlatformWheelEvent):
        * platform/win/ScrollViewWin.cpp: Added the page scroll (horiz/vertical) and reduced the number of pixels to scroll per line to keep the standard behavior with the factor
        (WebCore::adjustDeltaForPageScrollMode): static inline function to avoid copy/paste in the member functions
        (WebCore::ScrollView::updateScrollbars):
        (WebCore::ScrollView::wheelEvent):
        * platform/win/WheelEventWin.cpp: Retrieves the new values by using the win32 API.
        (WebCore::PlatformWheelEvent::PlatformWheelEvent):
        * platform/wx/MouseWheelEventWx.cpp: Add the values to avoid build break but the factors are initialized to 1 not to change the previous behavior
        (WebCore::PlatformWheelEvent::PlatformWheelEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35190 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agowx build fix - adding AccessibilityImageMapLink.cpp to the wx build.
kevino@webkit.org [Wed, 16 Jul 2008 03:09:28 +0000 (03:09 +0000)]
wx build fix - adding AccessibilityImageMapLink.cpp to the wx build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35189 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
kmccullough@apple.com [Tue, 15 Jul 2008 23:46:36 +0000 (23:46 +0000)]
WebCore:

2008-07-15  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Dan.

        <rdar://problem/5620273> REGRESSION: Apparent caching between form
        submits twice (on Maconomy) (18401)

        Frames did not set the createdByParser flag even when they were.

        * html/HTMLElementFactory.cpp:
        (WebCore::frameConstructor):
        (WebCore::iframeConstructor):

LayoutTests:

2008-07-15  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Dan.

        <rdar://problem/5620273> REGRESSION: Apparent caching between form
        submits twice (on Maconomy) (18401)

        * fast/forms/form-and-frame-interaction-retains-values-expected.txt: Added.
        * fast/forms/form-and-frame-interaction-retains-values.html: Added.
        * fast/forms/resources/form-and-frame-interaction-retains-values-main.html: Added.
        * fast/forms/resources/form-and-frame-interaction-retains-values-submit.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35188 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Rubber-stamped by Sam Weinig.
mitz@apple.com [Tue, 15 Jul 2008 23:20:49 +0000 (23:20 +0000)]
    Rubber-stamped by Sam Weinig.

        - update results for the addition of the compareDocumentPosition-related constants

        * fast/dom/domListEnumeration-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
mitz@apple.com [Tue, 15 Jul 2008 22:53:29 +0000 (22:53 +0000)]
WebCore:

        Reviewed by Dave Hyatt.

        - fix https://bugs.webkit.org/show_bug.cgi?id=19525
          <rdar://problem/5961768> -webkit-box-reflect in hyperlink causes webkit to crash

        Test: fast/reflections/inline-crash.html

        * rendering/RenderInline.cpp:
        (WebCore::RenderInline::setStyle): Added setHasReflection(false).
        Inline flows never have reflections.

LayoutTests:

        Reviewed by Dave Hyatt.

        - test for https://bugs.webkit.org/show_bug.cgi?id=19525
          <rdar://problem/5961768> -webkit-box-reflect in hyperlink causes webkit to crash

        * fast/reflections/inline-crash.html: Added.
        * platform/mac/fast/reflections/inline-crash-expected.checksum: Added.
        * platform/mac/fast/reflections/inline-crash-expected.png: Added.
        * platform/mac/fast/reflections/inline-crash-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-14 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Tue, 15 Jul 2008 21:24:57 +0000 (21:24 +0000)]
2008-07-14  David Hyatt  <hyatt@apple.com>

        Allow <style> and <link> pretty much anywhere.  They will still be moved to the <head> if
        no <body> exists yet though.

        Reviewed by Sam

        Added fast/css/style-parsed-outside-of-head.html

        * html/HTMLElement.cpp:
        (WebCore::inlineTagList):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
kmccullough@apple.com [Tue, 15 Jul 2008 17:48:00 +0000 (17:48 +0000)]
JavaScriptCore:

2008-07-15  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Geoff.

        Rename pageGroupIdentifier to profileGroup to keep mention of a
        pageGroup out of JavaScriptCore.

        * kjs/JSGlobalObject.cpp:
        (KJS::JSGlobalObject::init):
        * kjs/JSGlobalObject.h:
        (KJS::JSGlobalObject::setProfileGroup):
        (KJS::JSGlobalObject::profileGroup):
        * profiler/ProfileGenerator.cpp:
        (KJS::ProfileGenerator::create):
        (KJS::ProfileGenerator::ProfileGenerator):
        * profiler/ProfileGenerator.h:
        (KJS::ProfileGenerator::profileGroup):
        * profiler/Profiler.cpp:
        (KJS::Profiler::startProfiling):
        (KJS::dispatchFunctionToProfiles):
        (KJS::Profiler::willExecute):
        (KJS::Profiler::didExecute):

WebCore:

2008-07-15  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Geoff.

        Rename pageGroupIdentifier to profileGroup to keep mention of a
        pageGroup out of JavaScriptCore.

        * bindings/js/JSQuarantinedObjectWrapper.cpp:
        (WebCore::JSQuarantinedObjectWrapper::allowsUnwrappedAccessFrom):
        * bindings/js/ScriptController.cpp:
        (WebCore::ScriptController::clear):
        (WebCore::ScriptController::initScript):
        * history/CachedPage.cpp:
        (WebCore::CachedPage::restore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35184 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-15 Adele Peterson <adele@apple.com>
adele@apple.com [Tue, 15 Jul 2008 17:06:04 +0000 (17:06 +0000)]
2008-07-15  Adele Peterson  <adele@apple.com>

        Updating results for my fix to <rdar://problem/5784890>.

        * http/tests/misc/xhtml-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35183 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd WebKit[Set]ShouldUseFontSmoothing functions
aroben@apple.com [Tue, 15 Jul 2008 16:49:23 +0000 (16:49 +0000)]
Add WebKit[Set]ShouldUseFontSmoothing functions

WebCore:

        WebCore part of adding WebKit[Set]ShouldUseFontSmoothing functions

        <rdar://6059127>

        Reviewed by John Sullivan.

        * platform/graphics/win/FontCGWin.cpp:
        (WebCore::Font::drawGlyphs): Pass the result of
        WebCoreShouldUseFontSmoothing() into wkSetFontSmoothingStyle.
        * platform/win/WebCoreTextRenderer.cpp:
        (WebCore::WebCoreSetShouldUseFontSmoothing):
        (WebCore::WebCoreShouldUseFontSmoothing):
        Added.
        * platform/win/WebCoreTextRenderer.h:

WebKit/win:

        Add WebKit[Set]ShouldUseFontSmoothing functions

        <rdar://6059127>

        Reviewed by John Sullivan.

        * WebKit.vcproj/WebKit.def:
        * WebKit.vcproj/WebKit_debug.def:
        Export the new functions.
        * WebKitGraphics.cpp:
        (WebKitSetShouldUseFontSmoothing):
        (WebKitShouldUseFontSmoothing):
        Call through to the relevant WebCore functions.
        * WebKitGraphics.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35182 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Rubber-stamped by Anders Carlsson.
mitz@apple.com [Tue, 15 Jul 2008 16:32:34 +0000 (16:32 +0000)]
    Rubber-stamped by Anders Carlsson.

        - updated results for https://bugs.webkit.org/show_bug.cgi?id=18088
          <rdar://problem/6036232> white-space:nowrap; float:left; causing the misalignment issue

        * platform/mac/tables/mozilla/bugs/bug26553-expected.checksum:
        * platform/mac/tables/mozilla/bugs/bug26553-expected.png:
        * platform/mac/tables/mozilla/bugs/bug26553-expected.txt:
        * platform/mac/tables/mozilla/bugs/bug57828-2-expected.checksum:
        * platform/mac/tables/mozilla/bugs/bug57828-2-expected.png:
        * platform/mac/tables/mozilla/bugs/bug57828-2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35181 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Windows build fix
aroben@apple.com [Tue, 15 Jul 2008 15:34:32 +0000 (15:34 +0000)]
    Windows build fix

        * WebCore.vcproj/WebCore.vcproj: Add AccessibilityImageMapLink.{cpp,h}
        to the project.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35180 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-15 Holger Hans Peter Freyther <zecke@selfish.org>
zecke@webkit.org [Tue, 15 Jul 2008 08:14:19 +0000 (08:14 +0000)]
2008-07-15  Holger Hans Peter Freyther  <zecke@selfish.org>

        Build fix for the Gtk+ and Qt platform.

        * GNUmakefile.am: Add AccessibilityImageMapLink.cpp to the build
        * WebCore.pro: Add AccessibilityImageMapLink.cpp to the build

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35179 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago - Tiger build fix
mitz@apple.com [Tue, 15 Jul 2008 06:16:17 +0000 (06:16 +0000)]
    - Tiger build fix

        * platform/mac/WidgetMac.mm:
        (WebCore::Widget::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix https://bugs.webkit.org/show_bug.cgi?id=20037
mrowe@apple.com [Tue, 15 Jul 2008 02:17:56 +0000 (02:17 +0000)]
Fix https://bugs.webkit.org/show_bug.cgi?id=20037
Bug 20037: GCC 4.2 build broken due to strict aliasing violation.

Reviewed by Sam Weinig.

* kjs/ustring.cpp:
(KJS::UString::Rep::computeHash): Add a version of computeHash that takes a char* and explicit length.
* kjs/ustring.h:
* profiler/CallIdentifier.h:
(WTF::): Use new version of computeHash that takes a char* and explicit length to avoid unsafe aliasing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35177 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
mitz@apple.com [Tue, 15 Jul 2008 00:16:25 +0000 (00:16 +0000)]
WebCore:

        Reviewed by John Sullivan.

        - WebCore part of fixing <rdar://problem/6071850> Subviews not drawn correctly when using -cacheDisplayInRect:toBitmapImageRep:

        * platform/mac/WidgetMac.mm:
        (WebCore::Widget::paint): Changed to account for the case of drawing
        into a bitmap context that is not a window's backing store. In that
        case, -displayRectIgnoringOpacity:inContext: is used to redirect the
        drawing to the correct context, after setting up the right transform
        on it. For subframes, additional code ensures that the scroll view will
        not paint the background behind a transparent frame.

WebKit/mac:

        Reviewed by John Sullivan.

        - WebKit part of fixing <rdar://problem/6071850> Subviews not drawn correctly when using -cacheDisplayInRect:toBitmapImageRep:

        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView saveAndSetNewPortStateForUpdate:]): Changed
        to account for the case of being drawn into a bitmap context that is not
        a window's backing store. In that case, there are no valid "rects being
        drawn" to clip to.
        * WebView/WebHTMLView.mm:
        (-[WebHTMLView _recursive:displayRectIgnoringOpacity:inContext:topView:]):
        Added an override of this NSView method which is used in for
        -cacheDisplayInRect:toBitmapImageRep:. Like two existing NSView drawing
        machinery overrides, it sets subviews aside before invoking the
        superclass implementation. On Tiger, it also updates the layout.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35176 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Don't include autoversion.h in WebKitDLL.cpp.
sfalken@apple.com [Mon, 14 Jul 2008 23:15:35 +0000 (23:15 +0000)]
    Don't include autoversion.h in WebKitDLL.cpp.
        autoversion.h changes for every build, so we don't want to include it unless necessary.

        Rubber stamped by Ada Chan.

        * WebKitDLL.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35175 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago<rdar://problem/6038106> AXChildren returned for this web area is null
cfleizach@apple.com [Mon, 14 Jul 2008 22:43:05 +0000 (22:43 +0000)]
<rdar://problem/6038106> AXChildren returned for this web area is null

The accessibility of image maps needed to be brought inline with the new AX architecture

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35174 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-14 Sam Weinig <sam@webkit.org>
weinig@apple.com [Mon, 14 Jul 2008 22:31:00 +0000 (22:31 +0000)]
2008-07-14  Sam Weinig  <sam@webkit.org>

        Rubber-stamped by David Hyatt.

        Remove unused ExceptionCode parameter from compareDocumentPosition.

        * dom/Document.cpp:
        (WebCore::Document::addStyleSheetCandidateNode):
        * dom/Node.cpp:
        (WebCore::Node::compareDocumentPosition):
        * dom/Node.h:
        * dom/Node.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35173 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-14 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Mon, 14 Jul 2008 22:10:10 +0000 (22:10 +0000)]
2008-07-14  David Hyatt  <hyatt@apple.com>

        Fix for bugzilla bug 5476, link and style elements should be allowed outside the <head>.

        Reviewed by Sam

        Added fast/css/style-outside-head.html
        Added fast/css/link-outside-head.html

        * dom/Document.cpp:
        (WebCore::Document::addStyleSheetCandidateNode):
        (WebCore::Document::removeStyleSheetCandidateNode):
        (WebCore::Document::recalcStyleSelector):
        * dom/Document.h:
        * dom/Node.cpp:
        (WebCore::Node::compareDocumentPosition):
        * dom/ProcessingInstruction.cpp:
        (WebCore::ProcessingInstruction::checkStyleSheet):
        (WebCore::ProcessingInstruction::insertedIntoDocument):
        (WebCore::ProcessingInstruction::removedFromDocument):
        (WebCore::ProcessingInstruction::finishParsingChildren):
        * dom/ProcessingInstruction.h:
        (WebCore::ProcessingInstruction::setCreatedByParser):
        * dom/StyleElement.cpp:
        (WebCore::StyleElement::removedFromDocument):
        * dom/XMLTokenizer.cpp:
        (WebCore::XMLTokenizer::startElementNs):
        (WebCore::XMLTokenizer::processingInstruction):
        (WebCore::):
        * html/HTMLElementFactory.cpp:
        (WebCore::linkConstructor):
        * html/HTMLLinkElement.cpp:
        (WebCore::HTMLLinkElement::HTMLLinkElement):
        (WebCore::HTMLLinkElement::insertedIntoDocument):
        (WebCore::HTMLLinkElement::removedFromDocument):
        (WebCore::HTMLLinkElement::finishParsingChildren):
        * html/HTMLLinkElement.h:
        (WebCore::HTMLLinkElement::setCreatedByParser):
        * html/HTMLStyleElement.cpp:
        (WebCore::HTMLStyleElement::insertedIntoDocument):
        (WebCore::HTMLStyleElement::removedFromDocument):
        * svg/SVGStyleElement.cpp:
        (WebCore::SVGStyleElement::insertedIntoDocument):
        (WebCore::SVGStyleElement::removedFromDocument):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35172 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-14 Steve Falkenburg <sfalken@apple.com>
sfalken@apple.com [Mon, 14 Jul 2008 22:08:08 +0000 (22:08 +0000)]
2008-07-14  Steve Falkenburg  <sfalken@apple.com>

        Build fix.

        * DumpRenderTree/win/DumpRenderTree.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Attempted Windows build fix
aroben@apple.com [Mon, 14 Jul 2008 21:48:10 +0000 (21:48 +0000)]
    Attempted Windows build fix

        * DumpRenderTree/win/TestNetscapePlugin/TestNetscapePlugin.vcproj: Add
        CoreFoundation/OSXCompatibilityHeaders[/GNUCompatibility] to the
        include path.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35170 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-14 Sam Weinig <sam@webkit.org>
weinig@apple.com [Mon, 14 Jul 2008 21:21:14 +0000 (21:21 +0000)]
2008-07-14  Sam Weinig  <sam@webkit.org>

        Reviewed by Mark Rowe.

        Sort interface extended attributes to appease *the* Mark Rowe.

        * page/DOMWindow.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35169 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
andersca@apple.com [Mon, 14 Jul 2008 21:16:57 +0000 (21:16 +0000)]
WebCore:

2008-07-14  Anders Carlsson  <andersca@apple.com>

        Reviewed by Geoff.

        <rdar://problem/6073974>
        https://bugs.webkit.org/show_bug.cgi?id=18106
        The "onscroll" event bubbles, which is inconsistent with Firefox and IE

        Don't bubble the scroll event.

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::scrollToOffset):
        * rendering/RenderListBox.cpp:
        (WebCore::RenderListBox::valueChanged):

LayoutTests:

2008-07-14  Anders Carlsson  <andersca@apple.com>

        Reviewed by Geoff.

        <rdar://problem/6073974>
        https://bugs.webkit.org/show_bug.cgi?id=18106
        The "onscroll" event bubbles, which is inconsistent with Firefox and IE

        Add test.

        * fast/events/scroll-event-does-not-bubble-expected.txt: Added.
        * fast/events/scroll-event-does-not-bubble.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35168 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-14 Adele Peterson <adele@apple.com>
adele@apple.com [Mon, 14 Jul 2008 20:58:39 +0000 (20:58 +0000)]
2008-07-14  Adele Peterson  <adele@apple.com>

        Reviewed by Geoff.

        Fix for <rdar://problem/5784890> REGRESSION (Safari 3): Can't edit SpeedStream 4100 DSL modem settings

        The web server on this particular piece of hardware doesn't handle "text/xml" in the
        Accept header if the headers are sent in a certain order.  Safari 2 used to send "*/*" in
        the Accept header.  Firefox 2 sent "text/xml" but in an acceptable order for the web
        server.  And Firefox 3 doesn't send "text/xml" at all in the Accept header since it
        is being deprecated in favor of "application/xml".  We decided that the best solution is
        to match Firefox 3 and stop sending "text/xml" in the Accept header.

        No test.  There appears to be no way to get the raw headers in the original order in perl/php.

        * loader/FrameLoader.cpp: (WebCore::FrameLoader::addExtraFieldsToRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35167 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
weinig@apple.com [Mon, 14 Jul 2008 20:56:53 +0000 (20:56 +0000)]
WebCore:

2008-07-14  Sam Weinig  <sam@webkit.org>

        Reviewed by Adele Peterson.

        Fix for <rdar://problem/5769819>

        Test: http/tests/security/cross-frame-access-object-prototype.html

        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::getPropertyAttributes): Perform security check.
        (WebCore::JSDOMWindow::defineGetter): Ditto.
        (WebCore::JSDOMWindow::defineSetter): Ditto.
        (WebCore::JSDOMWindow::lookupGetter): Ditto.
        (WebCore::JSDOMWindow::lookupSetter): Ditto.
        * bindings/scripts/CodeGeneratorJS.pm: Add support for custom versions
        of all the core JSObject functionality.
        * page/DOMWindow.idl: Override remaining core JSObject functionality,
        to inject security checks.

LayoutTests:

2008-07-14  Sam Weinig  <sam@webkit.org>

        Reviewed by Adele Peterson.

        Test for <rdar://problem/5769819>

        * http/tests/security/cross-frame-access-object-prototype-expected.txt: Added.
        * http/tests/security/cross-frame-access-object-prototype.html: Added.
        * http/tests/security/resources/cross-frame-iframe-for-object-prototype-test.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35166 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-14 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Mon, 14 Jul 2008 20:37:42 +0000 (20:37 +0000)]
2008-07-14  David Hyatt  <hyatt@apple.com>

        Fix a crashing bug in ListHashSet's -- operator.  Make sure that end() can be -- by special-casing the null
        position.

        Reviewed by Maciej

        * wtf/ListHashSet.h:
        (WTF::ListHashSetConstIterator::operator--):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35165 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-14 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Mon, 14 Jul 2008 20:04:50 +0000 (20:04 +0000)]
2008-07-14  David Hyatt  <hyatt@apple.com>

        Buidl fix.  Make sure the second insertBefore method returns a value.

        * wtf/ListHashSet.h:
        (WTF::::insertBefore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35164 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWindows build fixes
aroben@apple.com [Mon, 14 Jul 2008 19:21:52 +0000 (19:21 +0000)]
Windows build fixes

JavaScriptCore:

        Windows build fix

        * JavaScriptCore.vcproj/jsc/jsc.vcproj: Added include/pthreads to the
        include path.

WebCore:

        Windows build fixes

        * WebCore.vcproj/WebCore.vcproj: Add include/pthreads to the include
        path.
        * bindings/scripts/CodeGeneratorCOM.pm: Touched this to force COM
        bindings to regenerate.
        * loader/FTPDirectoryDocument.cpp:
        * loader/FTPDirectoryParser.cpp:
        Fixed some duplicate macro definitions now that we're including
        pthread.h again.

WebKit/win:

        Windows build fix

        * WebJavaScriptCollector.cpp:
        (WebJavaScriptCollector::objectCount): Updated to match
        -[WebCoreStatistics javaScriptsObjectCount].

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35163 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Kevin McCullough.
ap@webkit.org [Mon, 14 Jul 2008 18:23:48 +0000 (18:23 +0000)]
    Reviewed by Kevin McCullough.

        Make JSGlobalData refcounted in preparation to adding a way to create contexts that share
        global data.

        * JavaScriptCore.exp:
        * kjs/JSGlobalData.cpp:
        (KJS::JSGlobalData::create):
        * kjs/JSGlobalData.h:
        Made contructor private, and added a static create() method. Made the class inherit from
        RefCounted.

        * kjs/JSGlobalObject.h:
        (KJS::JSGlobalObject::globalData):
        JSGlobalData is now owned by JSGlobalObject (except for the shared one, and the common
        WebCore one, which are never deleted).

        * kjs/Shell.cpp: (main): Create JSGlobalData with create() method.

WebCore:
        * bindings/js/JSDOMWindowBase.cpp:
        (WebCore::JSDOMWindowBase::commonJSGlobalData): Create JSGlobalData with create() method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35162 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-14 Simon Hausmann <hausmann@webkit.org>
hausmann@webkit.org [Mon, 14 Jul 2008 14:13:50 +0000 (14:13 +0000)]
2008-07-14  Simon Hausmann  <hausmann@webkit.org>

        Reviewed by Holger.

        Make listDirectory() in the Qt port work with empty namefilters.
        Don't include . and .. to avoid scanning the parent directory.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35161 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-14 Simon Hausmann <hausmann@webkit.org>
hausmann@webkit.org [Mon, 14 Jul 2008 12:12:50 +0000 (12:12 +0000)]
2008-07-14  Simon Hausmann  <hausmann@webkit.org>

        Fix the single-threaded build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Geoff Garen.
ap@webkit.org [Mon, 14 Jul 2008 11:28:57 +0000 (11:28 +0000)]
    Reviewed by Geoff Garen.

        Eliminate per-thread JavaScript global data instance support and make arbitrary
        global data/global object combinations possible.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35159 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-14 Ariya Hidayat <ariya.hidayat@trolltech.com>
hausmann@webkit.org [Mon, 14 Jul 2008 10:20:35 +0000 (10:20 +0000)]
2008-07-14  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Reviewed by Simon.

        MinGW build fixes

        * plugins/win/PluginDatabaseWin.cpp:
        * plugins/win/PluginViewWin.cpp:
        (WebCore::PluginView::handleKeyboardEvent):
        (WebCore::PluginView::handleMouseEvent):
        * svg/SynchronizableTypeWrapper.h:
        (WebCore::::SynchronizableTypeWrapper):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-13 Sam Weinig <sam@webkit.org>
weinig@apple.com [Mon, 14 Jul 2008 05:23:53 +0000 (05:23 +0000)]
2008-07-13  Sam Weinig  <sam@webkit.org>

        Reviewed by Oliver Hunt and Dan Bernstein.

        Fix for <rdar://problem/5888127>
        https://bugs.webkit.org/show_bug.cgi?id=18699

        - Match Firefox in restricting the size of custom cursor to images to
          128x128 px.
        - Restrict custom cursor hotspots to values within the bounds of the
          cursor image.

        * manual-tests/cursor-max-size.html: Added.
        * page/EventHandler.cpp:
        (WebCore::EventHandler::selectCursor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Windows build fix: Add wtf/RefCountedLeakCounter to the project.
adachan@apple.com [Mon, 14 Jul 2008 02:46:30 +0000 (02:46 +0000)]
    Windows build fix: Add wtf/RefCountedLeakCounter to the project.

        * JavaScriptCore.vcproj/WTF/WTF.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agowx build fix.
kevino@webkit.org [Sun, 13 Jul 2008 22:50:14 +0000 (22:50 +0000)]
wx build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35155 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoRemove conflict markers.
mitz@apple.com [Sun, 13 Jul 2008 01:18:26 +0000 (01:18 +0000)]
Remove conflict markers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35154 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-12 Sam Weinig <sam@webkit.org>
weinig@apple.com [Sat, 12 Jul 2008 23:42:06 +0000 (23:42 +0000)]
2008-07-12  Sam Weinig  <sam@webkit.org>

        Rubber-stamped by Oliver Hunt.

        Update version of Selectors API test from http://ejohn.org/apps/selectortest/
        and fix the spelling of the authors name.

        * fast/dom/SelectorAPI/resig-SelectorsAPI-test-expected.txt: Copied from fast/dom/SelectorAPI/ressig-SelectorsAPI-test-expected.txt.
        * fast/dom/SelectorAPI/resig-SelectorsAPI-test.xhtml: Copied from fast/dom/SelectorAPI/ressig-SelectorsAPI-test.xhtml.
        * fast/dom/SelectorAPI/ressig-SelectorsAPI-test-expected.txt: Removed.
        * fast/dom/SelectorAPI/ressig-SelectorsAPI-test.xhtml: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35153 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
mitz@apple.com [Sat, 12 Jul 2008 23:32:14 +0000 (23:32 +0000)]
WebCore:

        Reviewed by Oliver Hunt.

        - fix https://bugs.webkit.org/show_bug.cgi?id=18088
          <rdar://problem/6036232> white-space:nowrap; float:left; causing the misalignment issue

        Test: fast/block/basic/min-pref-width-nowrap-floats.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::calcInlinePrefWidths): Fixed a case where a
        float's width was added to the minimum preferred widths instead of just
        acting as a lower bound on the minimum preferred width (since the float
        can always be pushed down to be the only thing on the line).

LayoutTests:

        Reviewed by Oliver Hunt.

        - test for https://bugs.webkit.org/show_bug.cgi?id=18088
          <rdar://problem/6036232> white-space:nowrap; float:left; causing the misalignment issue

        * fast/block/basic/min-pref-width-nowrap-floats.html: Added.
        * platform/mac/fast/block/basic/min-pref-width-nowrap-floats-expected.checksum: Added.
        * platform/mac/fast/block/basic/min-pref-width-nowrap-floats-expected.png: Added.
        * platform/mac/fast/block/basic/min-pref-width-nowrap-floats-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35152 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Bug 13067: Manually adding #hash to URL reloads entire page instead of jumpin...
ddkilzer@apple.com [Sat, 12 Jul 2008 21:33:52 +0000 (21:33 +0000)]
    Bug 13067: Manually adding #hash to URL reloads entire page instead of jumping to #hash location in cached page

        <https://bugs.webkit.org/show_bug.cgi?id=13067>

        Reviewed by Darin.

        Test: WebCore/manual-tests/hash-ref.html

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::load(const KURL& newURL, const String& referrer,
             FrameLoadType newLoadType, const String& frameName, Event* event,
             PassRefPtr<FormState> formState)): Extracted logic into
        shouldScrollToAnchor() for determining when to scroll to an anchor.

        (WebCore::FrameLoader::load(DocumentLoader* loader, FrameLoadType type,
             PassRefPtr<FormState> formState)): Added check for
        shouldScrollToAnchor() to catch cases when the user manually added a
        hash ref to the URL in the address bar.  This is the bug fix.

        (WebCore::FrameLoader::shouldReload): Simplified early return logic.
        We only need to check if the destinationURL has a hash ref, not the
        currentURL, per the comment in the method.

        (WebCore::FrameLoader::shouldScrollToAnchor): Added.  Logic extracted
        from the FrameLoader::load(const KURL& newURL, ...) method.  Fixed order
        of arguments to shouldReload() since they were backwards, although the
        previous logic in the method made this irrelevant.

        (WebCore::FrameLoader::loadItem): Removed call to shouldReload().  Since
        we're navigating to a HistoryItem, it doesn't make sense to ask whether
        we need to reload the page or not.  Additionally, the logic at the end
        of shouldReload() is also checked in urlsMatchItem(), so there's no need
        to call the method.  This fixed the fast/css/target-fragment-match.html
        test from continuously reloading after the other changes.

        * loader/FrameLoader.h:
        (WebCore::FrameLoader::shouldScrollToAnchor): Added.

        * manual-tests/hash-ref.html: Added.
        * manual-tests/resources/hash-ref-test.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35151 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-12 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Sat, 12 Jul 2008 08:09:40 +0000 (08:09 +0000)]
2008-07-12  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Gtk, Qt and Wx build fix: Add wtf/RefCountedLeakCounter in the
        build scripts

        * GNUmakefile.am:
        * JavaScriptCore.pri:
        * JavaScriptCoreSources.bkl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35150 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoUpdate layout test results for new compareDocumentPosition method
hyatt@apple.com [Sat, 12 Jul 2008 07:49:18 +0000 (07:49 +0000)]
Update layout test results for new compareDocumentPosition method

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35149 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-11 Stephanie Lewis <slewis@apple.com>
slewis@apple.com [Sat, 12 Jul 2008 05:51:33 +0000 (05:51 +0000)]
2008-07-11  Stephanie Lewis  <slewis@apple.com>

        Reviewed by Darin Adler and Oliver Hunt.

JavaScriptCore:
        Refactor RefCounting Leak counting code into a common class.

        In order to export the symbols I needed to put the debug defines inside the function names

        Before we had a separate channel for each Logging each Leak type.  Since the leak channels were only used in one location, and only at quit for simplicity I combined them all into one leak channel.

        * JavaScriptCore.exp:
        * JavaScriptCore.xcodeproj/project.pbxproj: add new class
        * kjs/nodes.cpp: remove old leak counting code
        * wtf/RefCountedLeakCounter.cpp: Added. create a common leak counting class
        * wtf/RefCountedLeakCounter.h: Added.

WebCore:
        No Functionality Changed.  Change all the leak counting code to use the new WTF leak counter class.

        * bindings/js/JSCustomSQLTransactionCallback.cpp:
        (WebCore::JSCustomSQLTransactionCallback::JSCustomSQLTransactionCallback):
        (WebCore::JSCustomSQLTransactionCallback::~JSCustomSQLTransactionCallback):
        * bindings/js/JSEventListener.cpp:
        (WebCore::JSEventListener::JSEventListener):
        (WebCore::JSEventListener::~JSEventListener):
        * dom/Node.cpp:
        (WebCore::Node::Node):
        (WebCore::Node::~Node):
        * dom/Range.cpp:
        (WebCore::Range::Range):
        (WebCore::Range::~Range):
        * history/CachedPage.cpp:
        (WebCore::CachedPage::CachedPage):
        (WebCore::CachedPage::~CachedPage):
        * loader/SubresourceLoader.cpp:
        (WebCore::SubresourceLoader::SubresourceLoader):
        (WebCore::SubresourceLoader::~SubresourceLoader):
        * page/Frame.cpp:
        (WebCore::Frame::Frame):
        (WebCore::Frame::~Frame):
        * page/Page.cpp:
        (WebCore::Page::Page):
        (WebCore::Page::~Page):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::RenderObject):
        (WebCore::RenderObject::~RenderObject):
        * rendering/bidi.cpp:
        (WebCore::throw):
        (WebCore::BidiRun::operator delete):

WebKit

        Move WebPreferences.m to objc++ so it can include the new WTF leak counting class.

        * WebKit.xcodeproj/project.pbxproj:

        Disable WTF leak messages when using fast teardown.  Use full document teardown while running in debug.

        * WebView/WebPreferences.m: Removed.
        * WebView/WebPreferences.mm: Copied from http:/svn.webkit.org/repository/webkit/trunk/WebKit/mac/WebView/WebPreferences.m.
        (+[WebPreferences initialize]): if running in Default enable full  document teardown
        (-[WebPreferences editableLinkBehavior]):
        (-[WebPreferences setFullDocumentTeardownEnabled:]):
        * WebView/WebView.mm:
        (-[WebView _close]): disable leak messages if using fast teardown

WebKitTools:
        Make sure we read WebCore Leak messages.  Force full document teardown for DumpRenderTree.

        Up timeout limit, some slower machines were timing out before crashtracer finished writing out to disk and quitting DRT.

        * DumpRenderTree/mac/DumpRenderTree.mm:
        (setDefaultsToConsistentValuesForTesting):
        (resetWebViewToConsistentStateBeforeTesting):
        * Scripts/run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoClean up some funny whitespace from my previous Node.h checkin
hyatt@apple.com [Sat, 12 Jul 2008 02:52:41 +0000 (02:52 +0000)]
Clean up some funny whitespace from my previous Node.h checkin

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35147 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
weinig@apple.com [Sat, 12 Jul 2008 02:50:57 +0000 (02:50 +0000)]
WebCore:

2008-07-11  Sam Weinig  <sam@webkit.org>

        Reviewed by Mark Rowe.

        Update getSubStringLength and selectSubString methods exception throwing conditions
        based on SVG working group errata.

        Test: svg/custom/selectSubString.html

        * svg/SVGTextContentElement.cpp:
        (WebCore::SVGTextContentElement::getSubStringLength):
        (WebCore::SVGTextContentElement::selectSubString):

LayoutTests:

2008-07-11  Sam Weinig  <sam@webkit.org>

        Reviewed by Mark Rowe.

        Update getSubStringLength and selectSubString methods exception throwing conditions
        based on SVG working group errata.

        * svg/custom/acid3-test-77-expected.txt:
        * svg/custom/acid3-test-77.html:
        * svg/custom/getSubStringLength-expected.txt:
        * svg/custom/resources/getSubStringLength.js:
        * svg/custom/resources/selectSubString.js: Added.
        * svg/custom/selectSubString-expected.txt: Added.
        * svg/custom/selectSubString.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35146 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
weinig@apple.com [Sat, 12 Jul 2008 02:28:59 +0000 (02:28 +0000)]
WebCore:

2008-07-11  Sam Weinig  <sam@webkit.org>

        Reviewed by Mark Rowe.

        We can only use the Id fast path for querySelector and querySelectorAll
        if the selector is purely an Id selector.

        Test: fast/dom/SelectorAPI/id-fastpath.html

        * dom/Node.cpp:
        (WebCore::Node::querySelector):
        * dom/SelectorNodeList.cpp:
        (WebCore::createSelectorNodeList):

LayoutTests:

2008-07-11  Sam Weinig  <sam@webkit.org>

        Reviewed by Mark Rowe.

        We can only use the Id fast path for querySelector and querySelectorAll
        if the selector is purely an Id selector.

        * fast/dom/SelectorAPI/id-fastpath-expected.txt: Added.
        * fast/dom/SelectorAPI/id-fastpath.html: Added.
        * fast/dom/SelectorAPI/resources/id-fastpath.js: Added.
        * fast/dom/SelectorAPI/ressig-SelectorsAPI-test-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35145 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-11 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Sat, 12 Jul 2008 02:24:25 +0000 (02:24 +0000)]
2008-07-11  David Hyatt  <hyatt@apple.com>

        Add an insertBefore method to ListHashSet to allow for insertions in the middle of the list (rather than just
        at the end).

        Reviewed by Anders

        * wtf/ListHashSet.h:
        (WTF::::insertBefore):
        (WTF::::insertNodeBefore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-11 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Sat, 12 Jul 2008 02:13:27 +0000 (02:13 +0000)]
2008-07-11  David Hyatt  <hyatt@apple.com>

        Implement the DOM level 3 compareDocumentPosition method on Node.

        Reviewed by Darin

        * dom/Node.cpp:
        (WebCore::Node::compareDocumentPosition):
        * dom/Node.h:
        * dom/Node.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35143 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-11 Sam Weinig <sam@webkit.org>
weinig@apple.com [Sat, 12 Jul 2008 00:29:24 +0000 (00:29 +0000)]
2008-07-11  Sam Weinig  <sam@webkit.org>

        Rubber-stamped by Darin Adler.

        Move call function to CallData.cpp and construct to ConstructData.cpp.

        * GNUmakefile.am:
        * JavaScriptCore.pri:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * JavaScriptCoreSources.bkl:
        * kjs/AllInOneFile.cpp:
        * kjs/CallData.cpp: Copied from kjs/JSValue.cpp.
        * kjs/ConstructData.cpp: Copied from kjs/JSValue.cpp.
        * kjs/JSValue.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35142 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-11 Brady Eidson <beidson@apple.com>
beidson@apple.com [Fri, 11 Jul 2008 22:51:41 +0000 (22:51 +0000)]
2008-07-11  Brady Eidson  <beidson@apple.com>

        Rubberstamped by Sam

        Removed unneeded export

        * WebCore.base.exp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35141 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-11 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Fri, 11 Jul 2008 22:42:54 +0000 (22:42 +0000)]
2008-07-11  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Geoff.

        <rdar://problem/6067178> REGRESSION: Start profile button in profiler
        now profiles inspector rather than actual page (19833)
        - The JSQuarantinedObjectWrapper should use the wrapped exec state
        so that calls to it execute in its quarantined world.

        * bindings/js/JSQuarantinedObjectWrapper.cpp:
        (WebCore::JSQuarantinedObjectWrapper::construct):
        (WebCore::JSQuarantinedObjectWrapper::call):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-11 Simon Fraser <simon.fraser@apple.com>
dino@apple.com [Fri, 11 Jul 2008 22:40:56 +0000 (22:40 +0000)]
2008-07-11  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dave Hyatt

        StyleRareNonInheritedData needs to initialize and compare
        m_maskBoxImage.
        <https://bugs.webkit.org/show_bug.cgi?id=20005>

        * rendering/style/RenderStyle.cpp:
        (WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
        (WebCore::StyleRareNonInheritedData::operator==):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35139 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-11 Simon Fraser <simon.fraser@apple.com>
dino@apple.com [Fri, 11 Jul 2008 22:34:42 +0000 (22:34 +0000)]
2008-07-11  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dave Hyatt

        Bug 18885: RenderLayer::enclosingPositionedAncestor() should
        look for transforms, since transforms create containing
        blocks.
        <https://bugs.webkit.org/show_bug.cgi?id=18885>

        Test: fast/transforms/transform-positioned-ancestor.html

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::stackingContext):
        (WebCore::RenderLayer::enclosingPositionedAncestor):
        (WebCore::RenderLayer::enclosingTransformedAncestor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-11 Jacob Refstrup <jacob.refstrup@hp.com>
jmalonzo@webkit.org [Fri, 11 Jul 2008 22:30:11 +0000 (22:30 +0000)]
2008-07-11  Jacob Refstrup  <jacob.refstrup@hp.com>

        Reviewed by Darin Adler

        http://bugs.webkit.org/show_bug.cgi?id=19978
        GTK port always ends up with # at the end of resource URLs (and hence can't load files)

        - Optimized KURL::removeRef() and used it rather than setRef("")
          which after r35040 does the wrong thing.

        * platform/KURL.cpp:
        (WebCore::KURL::removeRef):
        * platform/network/curl/ResourceHandleManager.cpp:
        (WebCore::ResourceHandleManager::initializeHandle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-08 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Fri, 11 Jul 2008 22:07:02 +0000 (22:07 +0000)]
2008-07-08  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Christian Dywan.

        Replace 'const' with G_CONST_RETURN macro to make it flexible to
        disable constness

        * webkit/webkitnetworkrequest.cpp:
        * webkit/webkitnetworkrequest.h:
        * webkit/webkitwebframe.cpp:
        * webkit/webkitwebframe.h:
        * webkit/webkitwebhistoryitem.cpp:
        * webkit/webkitwebhistoryitem.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35136 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Anders.
eric@webkit.org [Fri, 11 Jul 2008 21:46:02 +0000 (21:46 +0000)]
    Reviewed by Anders.

        Skip the printing tests since they fail between machines.
        https://bugs.webkit.org/show_bug.cgi?id=20011

        * platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-11 Sam Weinig <sam@webkit.org>
weinig@apple.com [Fri, 11 Jul 2008 21:19:50 +0000 (21:19 +0000)]
2008-07-11  Sam Weinig  <sam@webkit.org>

        Rubber-stamped by Oliver Hunt.

        Import Selectors API test from http://ejohn.org/apps/selectortest/.

        * fast/dom/SelectorAPI/ressig-SelectorsAPI-test-expected.txt: Added.
        * fast/dom/SelectorAPI/ressig-SelectorsAPI-test.xhtml: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by cpst.
eric@webkit.org [Fri, 11 Jul 2008 21:17:23 +0000 (21:17 +0000)]
    Reviewed by cpst.

        Update results to match the buildbot (even though this now fails on my machine)
        I think the failure for me is possibly leopard vs. tiger or git vs. svn.

        * webarchive/test-xml-stylesheet-expected.webarchive:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35133 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoBuild fix.
sfalken@apple.com [Fri, 11 Jul 2008 18:35:33 +0000 (18:35 +0000)]
Build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago008-07-11 Simon Hausmann <hausmann@webkit.org>
hausmann@webkit.org [Fri, 11 Jul 2008 17:02:41 +0000 (17:02 +0000)]
008-07-11  Simon Hausmann  <hausmann@webkit.org>

        Fix the Qt/Windows build, include windows.h for HWND directly
        instead of implicit inclusion through Timer.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35129 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin Adler.
mitz@apple.com [Fri, 11 Jul 2008 16:54:13 +0000 (16:54 +0000)]
    Reviewed by Darin Adler.

        - fix popularity tracking for cached resources, which regressed in r23923

        * loader/Cache.cpp:
        (WebCore::Cache::requestResource): Changed to increase the access count
        whenever this function returns a CachedResource and the cache is
        enabled, instead of only when creating a new CachedResources. The
        incorrect behavior resulted in all resources in the cache having an
        access count of exactly 1 at all times.
        (WebCore::Cache::requestUserCSSStyleSheet): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-11 Ariya Hidayat <ariya.hidayat@trolltech.com>
hausmann@webkit.org [Fri, 11 Jul 2008 15:43:27 +0000 (15:43 +0000)]
2008-07-11  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Reviewed by Simon.

        Enable Netscape plugins for the Qt/Windows build.

        This required various smaller fixes across a wider set of
        files described below.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35127 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-11 Simon Hausmann <hausmann@webkit.org>
hausmann@webkit.org [Fri, 11 Jul 2008 12:08:22 +0000 (12:08 +0000)]
2008-07-11  Simon Hausmann  <hausmann@webkit.org>

        Rubber-stamped by Holger.

        Enable Database and Icondatabase functionality for the Qt/Windows
        build when building inside Qt, as we can use the builtin copy of
        sqlite then.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoUpdated test results for
dino@apple.com [Fri, 11 Jul 2008 11:51:10 +0000 (11:51 +0000)]
Updated test results for
https://bugs.webkit.org/show_bug.cgi?id=19864

* css3/transform-computed-style-001-expected.txt:
* fast/css/computed-style-expected.txt:
* fast/css/computed-style-without-renderer-expected.txt:
* svg/css/getComputedStyle-basic-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35125 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-11 Ariya Hidayat <ariya.hidayat@trolltech.com>
hausmann@webkit.org [Fri, 11 Jul 2008 11:28:16 +0000 (11:28 +0000)]
2008-07-11  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Reviewed by Adam Roben.

        Fix compile with MinGW since it does not like friend static function.

        * plugins/PluginView.h:
        * plugins/win/PluginViewWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-11 Ariya Hidayat <ariya.hidayat@trolltech.com>
hausmann@webkit.org [Fri, 11 Jul 2008 10:33:32 +0000 (10:33 +0000)]
2008-07-11  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Reviewed by Simon.

        Fix Qt/Win32 build.

        * platform/graphics/qt/GraphicsContextQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
weinig@apple.com [Fri, 11 Jul 2008 07:34:45 +0000 (07:34 +0000)]
WebCore:

2008-07-10  Sam Weinig  <sam@webkit.org>

        Reviewed by Oliver Hunt.

        Add support for NSResolver to resolve namespaces for querySelector
        and querySelectorAll.

        - Namespace resolution is done after parsing by iterating over all the
          parts of the CSSSelector.

        Tests: fast/dom/SelectorAPI/NSResolver-basic.xhtml
               fast/dom/SelectorAPI/NSResolver-exceptions.xhtml

        * GNUmakefile.am: Updated with new files.
        * WebCore.pro: Ditto.
        * WebCore.vcproj/WebCore.vcproj: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * WebCoreSources.bkl: Ditto.

        * bindings/js/JSDOMBinding.cpp:
        (WebCore::execStateFromNode):
        * bindings/js/JSDOMBinding.h:
        Move execStateFromNode here from NodeFilter.

        * bindings/js/JSDocumentCustom.cpp:
        (WebCore::JSDocument::querySelector): Don't throw a NOT_SUPPORTED_ERR for NSResolver
        and instead create one if the argument is not undefined or null.
        (WebCore::JSDocument::querySelectorAll): Ditto.
        * bindings/js/JSDocumentFragmentCustom.cpp:
        (WebCore::JSDocumentFragment::querySelector): Ditto.
        (WebCore::JSDocumentFragment::querySelectorAll): Ditto.
        * bindings/js/JSElementCustom.cpp:
        (WebCore::JSElement::querySelector): Ditto.
        (WebCore::JSElement::querySelectorAll): Ditto.

        * bindings/js/JSNSResolver.cpp: Added.
        (WebCore::JSNSResolver::JSNSResolver):
        (WebCore::JSNSResolver::mark):
        (WebCore::JSNSResolver::lookupNamespaceURI): Try and get the function
        from the passed in argument, either the value itself, or the result of
        getting the lookupNamespaceURI property, and call it.
        (WebCore::toNSResolver):
        * bindings/js/JSNSResolver.h: Added.
        (WebCore::JSNSResolver::create):

        * dom/Document.idl: Update with NSResolver parameter.
        * dom/DocumentFragment.idl: Ditto.
        * dom/Element.idl: Ditto.

        * dom/NSResolver.h: Added.
        (WebCore::NSResolver::~NSResolver):
        (WebCore::NSResolver::mark):
        Abstract base class.

        * dom/NSResolver.idl: Added.

        * dom/Node.cpp:
        (WebCore::forEachTagSelector):
        (WebCore::forEachSelector):
        Functions to iterate over all parts of the selector.

        (WebCore::SelectorNeedsNamespaceResolutionFunctor::operator()):
        Functor to be passed to forEachSelector to determine if a selector
        needs namespace resolution, for the case when no NSResolver is passed
        and we need to determine whether to throw a NAMESPACE_ERR.

        (WebCore::ResolveNamespaceFunctor::ResolveNamespaceFunctor):
        (WebCore::ResolveNamespaceFunctor::operator()):
        Functor to resolve namespaces for the selector.

        (WebCore::selectorNeedsNamespaceResolution):
        (WebCore::resolveNamespacesForSelector):
        (WebCore::Node::querySelector): Resolve namepspaces, including the defaultNamespace
        if a NSResolver is passed in.
        (WebCore::Node::querySelectorAll): Ditto.
        * dom/Node.h:

        * dom/NodeFilter.cpp:
        * dom/NodeFilter.h:
        * dom/NodeIterator.h:
        (WebCore::NodeIterator::nextNode):
        (WebCore::NodeIterator::previousNode):
        * dom/TreeWalker.h:
        (WebCore::TreeWalker::parentNode):
        (WebCore::TreeWalker::firstChild):
        (WebCore::TreeWalker::lastChild):
        (WebCore::TreeWalker::previousSibling):
        (WebCore::TreeWalker::nextSibling):
        (WebCore::TreeWalker::previousNode):
        (WebCore::TreeWalker::nextNode):
        Use the version of execStateFromNode in JSDOMBinding.

LayoutTests:

2008-07-10  Sam Weinig  <sam@webkit.org>

        Reviewed by Oliver Hunt.

        Add support for NSResolver to resolve namespaces for querySelector
        and querySelectorAll.

        * fast/dom/SelectorAPI/NSResolver-basic-expected.txt: Added.
        * fast/dom/SelectorAPI/NSResolver-basic.xhtml: Added.
        * fast/dom/SelectorAPI/NSResolver-exceptions-expected.txt: Added.
        * fast/dom/SelectorAPI/NSResolver-exceptions.xhtml: Added.
        * fast/dom/SelectorAPI/not-supported-NSResolver-expected.txt: Removed.
        * fast/dom/SelectorAPI/not-supported-NSResolver.html: Removed.
        * fast/dom/SelectorAPI/resources/NSResolver-exceptions.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoDefine WEBKIT_VERSION_MIN_REQUIRED=WEBKIT_VERSION_LATEST when building WebKit to...
mrowe@apple.com [Fri, 11 Jul 2008 06:10:34 +0000 (06:10 +0000)]
Define WEBKIT_VERSION_MIN_REQUIRED=WEBKIT_VERSION_LATEST when building WebKit to ensure that no symbols end up with the weak_import attribute.

Reviewed by Sam Weinig.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix the Tiger build by omitting annotations from methods declared in categories when...
mrowe@apple.com [Fri, 11 Jul 2008 06:10:30 +0000 (06:10 +0000)]
Fix the Tiger build by omitting annotations from methods declared in categories when using old versions of GCC.

Reviewed by Sam Weinig.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoBuild fix.
sfalken@apple.com [Fri, 11 Jul 2008 05:02:44 +0000 (05:02 +0000)]
Build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoReviewed by hyatt.
dino@apple.com [Fri, 11 Jul 2008 04:54:03 +0000 (04:54 +0000)]
Reviewed by hyatt.

Calculate computed style for -webkit-transform property
https://bugs.webkit.org/show_bug.cgi?id=19864

Test: css3/transform-computed-style-001.html

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::computedTransform):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
    handles -webkit-transform property now
* manual-tests/computed-transform-value.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adam Roben.
mitz@apple.com [Fri, 11 Jul 2008 00:46:45 +0000 (00:46 +0000)]
    Reviewed by Adam Roben.

        - fix a parse error in inspector.js

        * page/inspector/inspector.js: Added missing brace.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Build fix
aroben@apple.com [Fri, 11 Jul 2008 00:43:36 +0000 (00:43 +0000)]
    Build fix

        * WebCore.vcproj/QTMovieWin.vcproj: Add
        OSXCompatibilityHeaders[/GNUCompatibility] to the include path.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago<rdar://problem/6067408> AX: internal anchors broken
cfleizach@apple.com [Fri, 11 Jul 2008 00:28:03 +0000 (00:28 +0000)]
<rdar://problem/6067408> AX: internal anchors broken

Fixes a broken accessibility test

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoBuild fix.
mrowe@apple.com [Fri, 11 Jul 2008 00:01:50 +0000 (00:01 +0000)]
Build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-10 Sam Weinig <sam@webkit.org>
weinig@apple.com [Thu, 10 Jul 2008 23:47:26 +0000 (23:47 +0000)]
2008-07-10  Sam Weinig  <sam@webkit.org>

        Reviewed by Mark Rowe.

        Remove no-op debug method.

        * css/CSSSelector.cpp:
        * css/CSSSelector.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
weinig@apple.com [Thu, 10 Jul 2008 23:21:15 +0000 (23:21 +0000)]
WebCore:

2008-07-10  Sam Weinig  <sam@webkit.org>

        Reviewed by Dave Hyatt and Darin Adler.

        Add support for calling querySelector and querySelectorAll on DocumentFragments

        - Fixes bug where nodes not in the document tree would not match based on ID due
          to over optimization.

        Test: fast/dom/SelectorAPI/detached-element.html

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * bindings/js/JSDocumentFragmentCustom.cpp: Added.
        (WebCore::JSDocumentFragment::querySelector): Add custom code matching JSElement
        and JSDocument that checks for a 2nd arguments and throws an exception indicating
        we do not currently support the optional NSResolver part of the Selectors API spec.
        (WebCore::JSDocumentFragment::querySelectorAll): Ditto.
        * dom/DocumentFragment.idl: Add querySelector and querySelectorAll declarations.

        * dom/Node.cpp:
        (WebCore::Node::querySelector): Make the CSS parser parse the selector
        according to the strictness of the document so that mixed case ID selectors
        match in quirks mode.  Also, don't use the fast ID path if the root is not
        in the DOM tree, as it won't work.
        (WebCore::Node::querySelectorAll): Ditto.
        * dom/SelectorNodeList.cpp:
        (WebCore::createSelectorNodeList): Don't use the fast ID path if the root is not
        in the DOM tree, as it won't work.

LayoutTests:

2008-07-10  Sam Weinig  <sam@webkit.org>

        Reviewed by Dave Hyatt and Darin Adler,

        Add support for calling querySelector and querySelectorAll on DocumentFragments

        - Add test for nodes not in the document tree.

        * fast/dom/SelectorAPI/detached-element-expected.txt: Added.
        * fast/dom/SelectorAPI/detached-element.html: Added.
        * fast/dom/SelectorAPI/dumpNodeList-expected.txt:
        * fast/dom/SelectorAPI/dumpNodeList.html:
        * fast/dom/SelectorAPI/not-supported-NSResolver-expected.txt:
        * fast/dom/SelectorAPI/not-supported-NSResolver.html:
        * fast/dom/SelectorAPI/resources/detached-element.js: Added.
        * fast/dom/Window/window-properties-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-10 Anthony Ricaud <rik24d@gmail.com>
pewtermoose@webkit.org [Thu, 10 Jul 2008 23:06:33 +0000 (23:06 +0000)]
2008-07-10  Anthony Ricaud  <rik24d@gmail.com>

        Bug 19389: querySelectorAll exception while searching invalid CSS selector
        <https://bugs.webkit.org/show_bug.cgi?id=19389>

        Reviewed by Tim Hatcher.

        * page/inspector/inspector.js: Added a try/catch block.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35107 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-10 Brent Fulgham <bfulgham@gmail.com>
pewtermoose@webkit.org [Thu, 10 Jul 2008 23:02:37 +0000 (23:02 +0000)]
2008-07-10  Brent Fulgham  <bfulgham@gmail.com>

        Correct a build regression due to an uninitialized variable.

        <https://bugs.webkit.org/show_bug.cgi?id=19976>

        Reviewed by Darin.

        * platform/graphics/cairo/FontCairo.cpp:
        (WebCore::Font::drawGlyphs):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix Bug 19580: REGRESSION (r34432): PGO-only crash in HTMLCollection::resetCo...
aroben@apple.com [Thu, 10 Jul 2008 22:59:21 +0000 (22:59 +0000)]
    Fix Bug 19580: REGRESSION (r34432): PGO-only crash in HTMLCollection::resetCollectionInfo (codegen issue?)

        <https://bugs.webkit.org/show_bug.cgi?id=19580>
        <rdar://6029794>

        Reviewed by Cameron Zwarich.

        * WebCore.vcproj/WebCore.vcproj: Disable LTCG for HTMLFormElement.cpp,
        which was causing some bad codegen in HTMLFormElement::elements.
        * html/HTMLFormElement.cpp: Touched this file to force it to rebuild.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2008-07-10 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 10 Jul 2008 22:53:57 +0000 (22:53 +0000)]
2008-07-10  Anders Carlsson  <andersca@apple.com>

        Reviewed by Jon.

        <rdar://problem/6067135>
        WebKit should respond true to a query for NPNVSupportsWindowless.

        Handle NPNVSupportsWindowless and return true.

        * bridge/npapi.h:
        * plugins/win/PluginViewWin.cpp:
        (WebCore::PluginView::getValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Build fix.
sfalken@apple.com [Thu, 10 Jul 2008 22:38:37 +0000 (22:38 +0000)]
    Build fix.

        * DumpRenderTree/win/DumpRenderTree.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
kmccullough@apple.com [Thu, 10 Jul 2008 20:50:04 +0000 (20:50 +0000)]
JavaScriptCore:

2008-07-10  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Darin.

        -Minor cleanup. Renamed callTree() to head() and no longer use m_head
        directly but instead keep it private and access via a method().

        * profiler/HeavyProfile.cpp:
        (KJS::HeavyProfile::HeavyProfile):
        (KJS::HeavyProfile::generateHeavyStructure):
        (KJS::HeavyProfile::addNode):
        * profiler/Profile.h:
        (KJS::Profile::head):
        * profiler/ProfileGenerator.cpp:
        (KJS::ProfileGenerator::ProfileGenerator):

WebCore:

2008-07-10  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Darin.

        -Minor cleanup. Renamed callTree() to head() and no longer use m_head
        directly but instead keep it private and access via a method().

        * page/JavaScriptProfile.cpp:
        (WebCore::getHeadCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWhen a mask image changes, ensure that elements
dino@apple.com [Thu, 10 Jul 2008 19:31:43 +0000 (19:31 +0000)]
When a mask image changes, ensure that elements
that use that mask image are repainted correctly.

<https://bugs.webkit.org/show_bug.cgi?id=19954>

Reviewed by Dave Hyatt

* manual-tests/canvas-mask-redraw.html
  Manual testcase
* rendering/RenderBox.cpp:
  (WebCore::RenderBox::imageChanged):
  (WebCore::RenderBox::repaintLayerRectsForImage):
* rendering/RenderBox.h:
  Loop through background layers and mask layers, and
  if this image is used in a layer, compute a repaint
  rect and repaint.
* rendering/RenderImage.cpp:
  (WebCore::RenderImage::imageChanged):
  If this image has a mask, call the base class method.
* rendering/RenderObject.cpp:
  Remove a bogus 'return'.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoTransforms create a containing block, so
dino@apple.com [Thu, 10 Jul 2008 19:05:10 +0000 (19:05 +0000)]
Transforms create a containing block, so
RenderLayer::shouldBeOverflowOnly() needs to look for transforms.
<https://bugs.webkit.org/show_bug.cgi?id=18886>

Reviewed by Dave Hyatt

Test: fast/transforms/transform-overflow.html

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::shouldBeOverflowOnly):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35100 268f45cc-cd09-0410-ab3c-d52691b4dbfc