WebKit-https.git
18 years agoMore layout tests here.
darin [Thu, 31 Jul 2003 00:21:00 +0000 (00:21 +0000)]
More layout tests here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoMoving layout tests in here.
darin [Thu, 31 Jul 2003 00:18:03 +0000 (00:18 +0000)]
Moving layout tests in here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Dave.
darin [Wed, 30 Jul 2003 23:54:41 +0000 (23:54 +0000)]
    Reviewed by Dave.

        - fixed problem where some JavaScriptCore symbols had no namespace or prefix

        * kjs/grammar.y: Added a define for yylloc to make it use the kjs prefix.
        This is the same thing done for the rest of the symbols automatically by yacc,
        but for some reason it's not done for yyloc. Also make automatic() function static.
        * kjs/grammar.cpp: Regenerated.
        * kjs/lexer.cpp: Use kjsyylloc instead of yyloc.

        * pcre/pcre.h: Add defines to prepend kjs prefixes for all the PCRE functions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago * Makefile.am: Include the subdirectory with the PCRE code in it.
darin [Wed, 30 Jul 2003 22:34:00 +0000 (22:34 +0000)]
    * Makefile.am: Include the subdirectory with the PCRE code in it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Add support for setting the text-shadow's color. This uses a new CG API,
hyatt [Wed, 30 Jul 2003 22:19:36 +0000 (22:19 +0000)]
Add support for setting the text-shadow's color.  This uses a new CG API,
so updating to a fairly recent Panther is required.

        Reviewed by rjw

        * khtml/css/cssparser.cpp:
        (CSSParser::parseShadow):
* kwq/KWQPainter.mm:
        (QPainter::setShadow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoTweaked for signature change to KWQRegExp::match, to fix build
sullivan [Wed, 30 Jul 2003 22:09:48 +0000 (22:09 +0000)]
Tweaked for signature change to KWQRegExp::match, to fix build

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoTests:
sullivan [Wed, 30 Jul 2003 21:03:32 +0000 (21:03 +0000)]
Tests:

        * qt/qregexp-test.cpp:
        (main):
fixed broken build by removing final parameter to match()

WebCore:

- fixed 3346460 -- images > area (2048x2048) are compressed vertically
when displayed as src of img tag

        Reviewed by Darin

        * khtml/rendering/render_image.cpp:
        (RenderImage::layout):
Just comment out the code that imposes a maximum image size (incorrectly);
maybe KDE folks want to make this work, but we don't need to try to
prevent large images.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoBackout hack for IB. IB will deal with the issue internally.
rjw [Wed, 30 Jul 2003 21:02:38 +0000 (21:02 +0000)]
Backout hack for IB.  IB will deal with the issue internally.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoFixed signature for QRegExp::match in .exp file to fix build
sullivan [Wed, 30 Jul 2003 20:49:32 +0000 (20:49 +0000)]
Fixed signature for QRegExp::match in .exp file to fix build

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fixed 3356518. Added private method called by IB to ensure
rjw [Wed, 30 Jul 2003 20:48:55 +0000 (20:48 +0000)]
Fixed 3356518.  Added private method called by IB to ensure
that autoresizeSubviews flag is turned on correctly.

        Reviewed by mjs.

        * WebView.subproj/WebViewPrivate.m:
        (-[WebView _finishedMakingConnections]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoJavaScriptCore:
sullivan [Wed, 30 Jul 2003 19:04:07 +0000 (19:04 +0000)]
JavaScriptCore:

- JavaScriptCore part of fix for 3284525 -- AutoFill fills in
only e-mail address field of New Account form on Apple Store Japan

        Reviewed by Darin

        * JavaScriptCore.pbproj/project.pbxproj:
Mark pcre.h as a Private header

WebCore:

- WebCore part of fix for 3284525 -- AutoFill fills in
only e-mail address field of New Account form on Apple Store Japan

There were two problems: the regex library being used by
KWQRegExp.mm didn't handle unicode at all, and the way we
were using word boundaries in our regular expressions didn't
work with Japanese.

        Reviewed by Darin

        * kwq/KWQKHTMLPart.mm:
        (regExpForLabels):
Redid the way word boundaries are used; the old way didn't
work with PCRE, and also didn't work with Japanese.

        * kwq/KWQRegExp.h:
removed treatStartAsStartOfInput parameter to match() that Trey had added;
it was being used incorrectly and was not necessary.

        * kwq/KWQRegExp.mm:
        (compareStringOffsets), (createSortedOffsetsArray),
        (convertCharacterOffsetsToUTF8ByteOffsets),
        (convertUTF8ByteOffsetsToCharacterOffsets):
Code copied from JavaScriptCore/regexp.cpp to convert between
byte and character offsets. Darin preferred that I copy these
methods rather than make them public in JavaScriptCore/regexp.h.
        (QRegExp::KWQRegExpPrivate::compile):
converted from regex.h style to pcre.h style
        (QRegExp::KWQRegExpPrivate::~KWQRegExpPrivate):
ditto
        (QRegExp::match):
ditto
        (QRegExp::search):
removed parameter to match()
        (QRegExp::searchRev):
ditto

        * kwq/KWQString.mm:
        (QString::replace):
removed parameter to match()

WebBrowser:

- WebBrowser part of fix for 3284525 -- AutoFill fills in
only e-mail address field of New Account form on Apple Store Japan

        Reviewed by Darin

        * FormCompletionController.m:
        (-[FormToABBinder _indexMapping:]):
Replace ASSERT with ERROR when label tables have duplicates.
The Japanese localized file that I was using to test with had
such duplicates, and was crashing on me.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fixed 3349598. Deal gracefully with <li> items that
rjw [Wed, 30 Jul 2003 18:48:49 +0000 (18:48 +0000)]
Fixed 3349598.  Deal gracefully with <li> items that
are not in a <ol> or <ul>, instead of crashing!

        Reviewed by Ken.

        * kwq/KWQKHTMLPart.mm:
        (listParent):
        (KWQKHTMLPart::attributedString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Use the new KURL getNSURL() method to create an NSURL.
rjw [Wed, 30 Jul 2003 01:36:42 +0000 (01:36 +0000)]
Use the new KURL getNSURL() method to create an NSURL.

        Reviewed by darin.

        * kwq/KWQKHTMLPart.mm:
        (KWQKHTMLPart::attributedString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Dave.
darin [Wed, 30 Jul 2003 00:39:43 +0000 (00:39 +0000)]
    Reviewed by Dave.

        - fixed 3311756 -- REGRESSION (76-77): radio buttons in different forms act as the same set
by rolling out old fix for 3158411 -- radio button groups are supposed to be per-form
        The real bug at flyglobespan.com is what's fixed below.

        * khtml/html/html_formimpl.h:
        * khtml/html/html_formimpl.cpp:
        (HTMLFormElementImpl::radioClicked):
        (HTMLInputElementImpl::~HTMLInputElementImpl):
        (HTMLInputElementImpl::setType):
        (HTMLInputElementImpl::parseAttribute):
        (HTMLInputElementImpl::attach):
        (HTMLInputElementImpl::reset):
        (HTMLInputElementImpl::setChecked):
        (HTMLInputElementImpl::isEditable):
        * khtml/xml/dom_docimpl.cpp:
        * khtml/xml/dom_docimpl.h:

        - fixed 3158411 -- re-opened form is one form in other browsers, multiple forms in Safari
        (flyglobespan.com)

        * khtml/html/htmlparser.cpp: (KHTMLParser::getElement): Don't open a form if we encounter
        a form element inside another form.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoWebCore:
sullivan [Tue, 29 Jul 2003 18:00:41 +0000 (18:00 +0000)]
WebCore:

- fixed 3346707 -- AutoFill does not fill in email address on
Apple Store new account page

        Reviewed by Darin

        * kwq/KWQRegExp.h:
        * kwq/KWQRegExp.mm:
        (QRegExp::searchRev):
This method (that Trey had added) used a placeholder 2nd parameter
that was always -1 and should have been ignored. But it was
being passed into QRegExp::match as the starting index, which
happened to work in many cases, but not if the byte of memory
before the string happened to be a null character. Fixed by
eliminating the placeholder parameter entirely.

WebBrowser:

- fixed 3345689 -- Safari-89: timeout alert sheet sometimes
shows for the wrong tab

        Reviewed by Darin

        * BrowserWindowController.m:
        (-[BrowserWindowController closeTab:]):
We were removing the old tab, then switching to the next tab.
But removing the old tab causes NSTabView to switch to the
previous tab, so there was an instant where the previous tab
was switched in and thus felt compelled to put up its pending
sheet. Fixed by switching to new tab before removing old one,
which should also be a slight speed improvement, since we bypass
going to the wrong tab momentarily.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fixed 3323866. Provide SPI to IB to enable scoping of preferences
rjw [Tue, 29 Jul 2003 01:23:26 +0000 (01:23 +0000)]
Fixed 3323866.  Provide SPI to IB to enable scoping of preferences
values on a document-by-document basis.

        Reviewed by Maciej.

        * WebView.subproj/WebPreferences.m:
        (-[WebPreferencesPrivate dealloc]):
        (-[WebPreferences initWithIdentifier:]):
        (-[WebPreferences initWithCoder:]):
        (+[WebPreferences _userDefaultsKeysForIB]):
        (+[WebPreferences _setIBCreatorID:]):
        (+[WebPreferences _IBCreatorID]):
        (-[WebPreferences _concatenateKeyWithIBCreatorID:]):
        * WebView.subproj/WebPreferencesPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Maciej.
darin [Tue, 29 Jul 2003 00:55:59 +0000 (00:55 +0000)]
    Reviewed by Maciej.

        - fixed 3344647 -- reachedTerminalState assertion in WebBaseResourceHandleDelegate.m

        * WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient cancelWithError:]):
        Use [super cancelWithError:] rather than [self receivedError:]. I checked carefully to
        see that this code now does everything the old code did (and a bit more).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Richard.
mjs [Tue, 29 Jul 2003 00:10:07 +0000 (00:10 +0000)]
    Reviewed by Richard.

- fixed 3240814 - LEAK: 120 byte leak in JavaScript parser in Sherlock Movies channel

        * kjs/internal.cpp:
        (Parser::parse): ref() and deref() the program node, to make sure to clean up properly,
before deleting it.
        (InterpreterImp::checkSyntax): Likewise.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Richard.
mjs [Mon, 28 Jul 2003 21:58:28 +0000 (21:58 +0000)]
    Reviewed by Richard.

- fixed 3343050 - nil-deref in saveInterpreterBuiltins running Sherlock via MallocDebug in Panther7B20
- fixed 3343942 - Safari crashes when clicking on link w/ JavaScript turned off

        * kwq/KWQKHTMLPart.mm:
        (KWQKHTMLPart::saveInterpreterBuiltins): Don't attempt to save
when JavaScript is off.
        (KWQKHTMLPart::restoreInterpreterBuiltins): Don't attempt to restore
when JavaScript is off.
        (KWQKHTMLPart::saveWindowProperties): Remove ERROR, since that
case is normal when JS is off.
        (KWQKHTMLPart::saveLocationProperties): Remove ERROR, since that
case is normal when JS is off.
        (KWQKHTMLPart::restoreWindowProperties): Remove ERROR, since that
case is normal when JS is off.
        (KWQKHTMLPart::restoreLocationProperties): Remove ERROR, since that
case is normal when JS is off.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fixed 3341859.
rjw [Mon, 28 Jul 2003 21:24:48 +0000 (21:24 +0000)]
Fixed 3341859.
     Check that the WebHTMLView is initialized in viewWillMoveToWindow: and
viewDidMoveToWindow.  Don't do anything if we aren't initialized.  This
happens when decoding a WebView.  When WebViews are decoded their subviews
     are created by initWithCoder: and so won't be normally initialized.  The
stub views are discarded by WebView.

        Reviewed by John.

        * WebView.subproj/WebHTMLView.m:
        (-[WebHTMLView viewWillMoveToWindow:]):
        (-[WebHTMLView viewDidMoveToWindow]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by John.
darin [Mon, 28 Jul 2003 20:58:55 +0000 (20:58 +0000)]
    Reviewed by John.

        - fixed 3279864 -- remove class_poseAs calls from WebKit

        * WebView.subproj/WebHTMLView.m: (-[WebHTMLView initWithFrame:]):
        Call _setDrawsOwnDescendants, if we have a new enough AppKit.
        * WebView.subproj/WebHTMLViewPrivate.m: (+[WebHTMLView load]):
        Don't pose as NSView, if we have a new enough AppKit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fix build bustage on my buggy panther compiler.
hyatt [Mon, 28 Jul 2003 20:39:24 +0000 (20:39 +0000)]
Fix build bustage on my buggy panther compiler.

        Reviewed by darin

        * kwq/KWQLineEdit.mm:
        (QLineEdit::~QLineEdit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by John
kocienda [Mon, 28 Jul 2003 20:37:55 +0000 (20:37 +0000)]
    Reviewed by John

        Fix for this bug:

        <rdar://problem/3336933>: REGRESSION (Panther): Mozilla build downloaded
        with wrong extension, bad file size (gzip)

Use new delegate methods that allow for the correct reporting
of progress in cases where Foundation-level content decoding
has been performed on data received

        * WebCoreSupport.subproj/WebSubresourceClient.m:
        (-[WebSubresourceClient connection:didReceiveData:lengthReceived:]):
        * WebView.subproj/WebBaseResourceHandleDelegate.m:
        (-[WebBaseResourceHandleDelegate connection:didReceiveData:]):
        (-[WebBaseResourceHandleDelegate connection:didReceiveData:lengthReceived:]):
        * WebView.subproj/WebMainResourceClient.m:
        (-[WebMainResourceClient connection:didReceiveData:lengthReceived:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fix for 3343250, XML didn't know how to make implicit tbodies when starting new...
hyatt [Mon, 28 Jul 2003 20:32:48 +0000 (20:32 +0000)]
Fix for 3343250, XML didn't know how to make implicit tbodies when starting new elements,
nor did it know to skip implicit elements when popping its element stack.

        Reviewed by darin

        * khtml/xml/xml_tokenizer.cpp:
        (XMLHandler::startElement):
        (XMLHandler::endElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Richard.
darin [Mon, 28 Jul 2003 20:16:18 +0000 (20:16 +0000)]
    Reviewed by Richard.

        - fixed leak of WebDataRequestParameters objects

        * WebView.subproj/WebDataProtocol.m:
        (-[NSMutableURLRequest _webDataRequestParametersForWriting]):
        Release the WebDataRequestParameters object after putting it in the dictionary.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago - fixed 3236815 -- bitmap TIFFs at > 72 dpi are scaled incorrectly
sullivan [Mon, 28 Jul 2003 17:14:00 +0000 (17:14 +0000)]
- fixed 3236815 -- bitmap TIFFs at > 72 dpi are scaled incorrectly
in Safari when viewed standalone (uspto.gov)

        Reviewed by Darin

        * WebCoreSupport.subproj/WebImageRenderer.m:
        (-[WebImageRenderer _adjustSizeToPixelDimensions]):
call setScalesWhenResized:YES

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fixed 3344519. Prevent infinite recursion attempting font substitution.
rjw [Fri, 25 Jul 2003 22:04:01 +0000 (22:04 +0000)]
Fixed 3344519.  Prevent infinite recursion attempting font substitution.

        Reviewed by Darin.

        * WebCoreSupport.subproj/WebTextRenderer.m:
        (-[WebTextRenderer _floatWidthForRun:style:applyRounding:attemptFontSubstitution:widths:fonts:glyphs:startGlyph:endGlyph:numGlyphs:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by John.
mjs [Fri, 25 Jul 2003 21:22:56 +0000 (21:22 +0000)]
    Reviewed by John.

- fixed 3280582 - REGRESSION (74-85): authentication sheet doesn't state that previous login was incorrect

        * Panels.subproj/WebAuthenticationPanel.m:
        (-[WebAuthenticationPanel setUpForChallenge:]): Use chall, the
parameter, not challenge, the not-yet-set ivar so we get the right
failure count &c.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Rename box and inline-box to -khtml-box and -khtml-inline-box.
hyatt [Fri, 25 Jul 2003 20:47:53 +0000 (20:47 +0000)]
Rename box and inline-box to -khtml-box and -khtml-inline-box.

        Reviewed by john

        * khtml/css/cssparser.cpp:
        (CSSParser::parseValue):
        * khtml/css/cssvalues.c:
        (hash_val):
        (findValue):
        * khtml/css/cssvalues.h:
        * khtml/css/cssvalues.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4713 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fix for 3343529, inline blocks crashing Safari. There were lots of problems with
hyatt [Fri, 25 Jul 2003 20:22:34 +0000 (20:22 +0000)]
Fix for 3343529, inline blocks crashing Safari.  There were lots of problems with
inlne-blocks.  This code gets basic inline-blocks working properly (with no crashes).

Several functions have been patched to take an isRootLineBox parameter.  This is used
to tell whether you're supposed to examine the root line box for a block or the block
itself.  In the case of baselinePosition and lineHeight, it indicates whether the caller
wants to measure the outside or inside of the box.

The outside of an inline-block is like a replaced element (e.g., an image), but the
inside is like a block, e.g., you want measurements for
the line height and baseline position of a root line box for that block.

Similarly, createInlineBox has been patched in order to know whether you're making a
root inline box *inside* the inline-block or an inline box that *encompasses* the
inline-block element (like you'd do for an image).

A number of places had isInline() calls and needed to be patched to also check
isInlineBlockOrInlineTable().  How to treat the inline-block again basically depends
on whether the caller is looking at the outside of the block (in which case you're like
an inline replaced element) or the inside of the block (in which case you're just like
a block).

        Reviewed by darin

        * ChangeLog:
        * khtml/rendering/bidi.cpp:
        * khtml/rendering/render_block.cpp:
        * khtml/rendering/render_block.h:
        * khtml/rendering/render_box.cpp:
        (RenderBox::calcWidth):
        (RenderBox::calcHeight):
        * khtml/rendering/render_flow.cpp:
        (RenderFlow::createInlineBox):
        * khtml/rendering/render_flow.h:
        * khtml/rendering/render_form.cpp:
        (RenderFormElement::baselinePosition):
        (RenderButton::baselinePosition):
        (RenderSubmitButton::baselinePosition):
        (RenderSelect::baselinePosition):
        * khtml/rendering/render_form.h:
        * khtml/rendering/render_line.cpp:
        (InlineFlowBox::verticallyAlignBoxes):
        (InlineFlowBox::computeLogicalBoxHeights):
        * khtml/rendering/render_list.cpp:
        (RenderListMarker::lineHeight):
        (RenderListMarker::baselinePosition):
        * khtml/rendering/render_list.h:
        * khtml/rendering/render_object.cpp:
        (RenderObject::sizesToMaxWidth):
        (RenderObject::getVerticalPosition):
        (RenderObject::lineHeight):
        (RenderObject::baselinePosition):
        (RenderObject::createInlineBox):
        * khtml/rendering/render_object.h:
        * khtml/rendering/render_replaced.cpp:
        (RenderReplaced::lineHeight):
        (RenderReplaced::baselinePosition):
        * khtml/rendering/render_replaced.h:
        * khtml/rendering/render_table.cpp:
        * khtml/rendering/render_table.h:
        * khtml/rendering/render_text.cpp:
        (RenderText::lineHeight):
        (RenderText::baselinePosition):
        (RenderText::createInlineBox):
        * khtml/rendering/render_text.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Use 11 point bold, instead of 12 point bold, to draw dragged link
rjw [Fri, 25 Jul 2003 19:54:57 +0000 (19:54 +0000)]
Use 11 point bold, instead of 12 point bold, to draw dragged link
labels.  This matches the text drawn in the bookmarks bar.

        Reviewed by John.

        * WebView.subproj/WebHTMLViewPrivate.m:
        (-[WebHTMLView _dragImageForLinkElement:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fix for 3343527, crash when attempting to access rules in the CSS OM.
hyatt [Fri, 25 Jul 2003 10:27:37 +0000 (10:27 +0000)]
Fix for 3343527, crash when attempting to access rules in the CSS OM.
Our KWQListImpl doesn't null check accesses, so anything out
of bounds would cause a crash.

        Reviewed by mjs

        * kwq/KWQListImpl.mm:
        (KWQListImpl::at):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Dave.
mjs [Fri, 25 Jul 2003 10:10:51 +0000 (10:10 +0000)]
    Reviewed by Dave.

 - fixed 3332460 - nil-deref in khtml::RenderWidget::eventFilter with onchange handler

        * khtml/rendering/render_form.cpp:
        (RenderTextArea::handleFocusOut): Check if we still have an
element. It could have gone away while handling an event that
replaced some or all of the document, and if we're gonna be
destroyed soon then there's no point doing this work anyway.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Dave.
mjs [Fri, 25 Jul 2003 09:11:17 +0000 (09:11 +0000)]
    Reviewed by Dave.

- fixed 3332460 - nil-deref in khtml::RenderWidget::eventFilter with onchange handler

        * khtml/rendering/render_replaced.cpp:
        (RenderWidget::eventFilter): We want to ref element() across this call, but it could get
unset, so store it in a local variable.
        * kwq/KWQLineEdit.h:
        * kwq/KWQLineEdit.mm:
        (QLineEdit::~QLineEdit): invalidate our KWQTextField.
        * kwq/KWQTextField.h:
        * kwq/KWQTextField.mm:
        (-[KWQTextField invalidate]): Set widget to NULL.
        (-[KWQTextField action:]): Do nothing if widget is NULL.
        (-[KWQTextField controlTextDidBeginEditing:]): Likewise.
        (-[KWQTextField controlTextDidEndEditing:]): Likewise.
        (-[KWQTextField controlTextDidChange:]): Likewise.
        (-[KWQTextField control:textShouldBeginEditing:]): Likewise.
        (-[KWQTextField control:textShouldEndEditing:]): Likewise.
        (-[KWQTextField control:didFailToFormatString:errorDescription:]): Likewise.
        (-[KWQTextField control:didFailToValidatePartialString:errorDescription:]): Likewise.
        (-[KWQTextField control:isValidObject:]): Likewise.
        (-[KWQTextField control:textView:doCommandBySelector:]): Likewise.
        (-[KWQTextField stringValue]): Likewise.
        (-[KWQTextField setStringValue:]): Likewise.
        (-[KWQTextField setFont:]): Likewise.
        (-[KWQTextField nextKeyView]): Likewise.
        (-[KWQTextField previousKeyView]): Likewise.
        (-[KWQTextField nextValidKeyView]): Likewise.
        (-[KWQTextField previousValidKeyView]): Likewise.
        (-[KWQTextField fieldEditorDidMouseDown:]): Likewise.
        (-[KWQTextField textView:shouldHandleEvent:]): Likewise.
        (-[KWQTextField textView:didHandleEvent:]): Likewise.
        (-[KWQTextField setHasFocus:]): Likewise.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fixed 3279910. Change the way we draw dragged link to use
rjw [Fri, 25 Jul 2003 01:21:52 +0000 (01:21 +0000)]
Fixed 3279910.  Change the way we draw dragged link to use
WebKit's measurement and drawing.  Also made the look match
the bookmarks bar text.

        Reviewed by Maciej.

        * Misc.subproj/WebKitNSStringExtras.h:
        * Misc.subproj/WebKitNSStringExtras.m:
        (-[NSString _web_drawDoubledAtPoint:withTopColor:bottomColor:font:]):
        * WebView.subproj/WebHTMLViewPrivate.h:
        * WebView.subproj/WebHTMLViewPrivate.m:
        (-[WebHTMLView _dragImageForLinkElement:]):
        (-[WebHTMLView _handleMouseDragged:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago - fixed 3332622 -- Safari Abbreviates Attribute Names in EMBED tags
sullivan [Thu, 24 Jul 2003 22:43:50 +0000 (22:43 +0000)]
- fixed 3332622 -- Safari Abbreviates Attribute Names in EMBED tags

        Reviewed by Richard

        * khtml/html/htmltokenizer.h:
bumped fixed max length of attributes from 14 to 1024.
Theoretically they could be any arbitrary length, but it's
more risk than it's worth to rewrite the code that uses the
fixed-size buffer that is based on this value.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Removed unnecessary log.
rjw [Thu, 24 Jul 2003 22:27:58 +0000 (22:27 +0000)]
Removed unnecessary log.

        Reviewed by John.

        * WebCoreSupport.subproj/WebImageRendererFactory.m:
        (-[WebImageRendererFactory imageRendererWithData:MIMEType:]):

Add another check to use ATSU for Limbu (Unicode 4.0) script.
Also made shouldUseATSU inline.

        * WebCoreSupport.subproj/WebTextRenderer.m:
        (shouldUseATSU):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Change all uses of "konq-" in CSS to "khtml-".
hyatt [Thu, 24 Jul 2003 22:07:45 +0000 (22:07 +0000)]
Change all uses of "konq-" in CSS to "khtml-".

Also rename the CSS3 properties that have either buggy or
incomplete implementations to "-khtml-property" for forward
compatibility (so that people don't have to worry about a buggy
Safari if/when they use the official property names).

        Reviewed by john

        * khtml/css/cssparser.cpp:
        (CSSParser::parseRule):
        (CSSParser::parseValue):
        (CSSParser::parseDeclaration):
        (CSSParser::parseFontFamily):
        (CSSParser::parseShadow):
        * khtml/css/cssproperties.c:
        (hash_prop):
        (findProp):
        * khtml/css/cssproperties.h:
        * khtml/css/cssproperties.in:
        * khtml/css/cssstyleselector.cpp:
        * khtml/css/cssvalues.c:
        (hash_val):
        (findValue):
        * khtml/css/cssvalues.h:
        * khtml/css/cssvalues.in:
        * khtml/css/html4.css:
        * khtml/css/parser.cpp:
        * khtml/css/parser.h:
        * khtml/css/parser.y:
        * khtml/css/quirks.css:
        * khtml/css/tokenizer.cpp:
        * khtml/css/tokenizer.flex:
        * khtml/html/html_blockimpl.cpp:
        (HTMLDivElementImpl::parseAttribute):
        (HTMLParagraphElementImpl::parseAttribute):
        * khtml/html/html_elementimpl.cpp:
        (HTMLElementImpl::addHTMLAlignment):
        * khtml/html/html_inlineimpl.cpp:
        (HTMLFontElementImpl::parseAttribute):
        * khtml/html/html_tableimpl.cpp:
        (HTMLTablePartElementImpl::parseAttribute):
        (HTMLTableCellElementImpl::parseAttribute):
        * khtml/rendering/bidi.cpp:
        * khtml/rendering/render_block.cpp:
        * khtml/rendering/render_box.cpp:
        (RenderBox::calcHorizontalMargins):
        * khtml/rendering/render_flexbox.cpp:
        * khtml/rendering/render_style.h:
        * khtml/rendering/render_table.cpp:
        (RenderTableCell::setStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoSafari-91u
sheridan [Thu, 24 Jul 2003 19:49:13 +0000 (19:49 +0000)]
Safari-91u

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoSafari-90 stamp
sheridan [Thu, 24 Jul 2003 19:39:16 +0000 (19:39 +0000)]
Safari-90 stamp

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Build breakage fix:
mjs [Thu, 24 Jul 2003 03:38:57 +0000 (03:38 +0000)]
Build breakage fix:

Fix WebKit to build with the latest Foundation.

        * Misc.subproj/WebNSURLExtras.h:
        * Misc.subproj/WebNSURLExtras.m:
        (-[NSURL _webkit_isJavaScriptURL]):
        (-[NSURL _webkit_scriptIfJavaScriptURL]):
        (-[NSURL _webkit_isFTPDirectoryURL]):
        (-[NSString _webkit_isFTPDirectoryURL]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fix opacity to respect clipping.
hyatt [Thu, 24 Jul 2003 01:51:17 +0000 (01:51 +0000)]
Fix opacity to respect clipping.

        Reviewed by rjw

        * khtml/rendering/render_layer.cpp:
        (RenderLayer::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fixed 3311725: Added support for key/value binding.
rjw [Thu, 24 Jul 2003 01:38:55 +0000 (01:38 +0000)]
Fixed 3311725:  Added support for key/value binding.
(As a side effect also made icon loading work!  In 1.0
it doesn't work unless a secret preference value is set.)

        Reviewed by Ken.

        * Misc.subproj/WebIconDatabase.m:
        (-[WebIconDatabase _createFileDatabase]):
        * WebView.subproj/WebDataSourcePrivate.m:
        (-[WebDataSource _startLoading:]):
        (-[WebDataSource _setTitle:]):
        (-[WebDataSource _updateIconDatabaseWithURL:]):
        * WebView.subproj/WebFramePrivate.m:
        (-[WebFrame _transitionToCommitted:]):
        (-[WebFrame _isLoadComplete]):
        * WebView.subproj/WebView.m:
        (-[WebView setMainFrameURL:]):
        (-[WebView mainFrameURL]):
        (-[WebView isLoading]):
        (-[WebView mainFrameTitle]):
        (-[WebView mainFrameIcon]):
        * WebView.subproj/WebViewPrivate.h:
        * WebView.subproj/WebViewPrivate.m:
        (-[WebView _progressStarted]):
        (-[WebView _progressCompleted]):
        (-[WebView _incrementProgressForConnection:data:]):
        (-[WebView _completeProgressForConnection:]):
        (-[WebView _declaredKeys]):
        (-[WebView setObservationInfo:]):
        (-[WebView observationInfo]):
        (-[WebView _willChangeBackForwardKeys]):
        (-[WebView _didChangeBackForwardKeys]):
        (-[WebView _didStartProvisionalLoadForFrame:]):
        (-[WebView _didCommitLoadForFrame:]):
        (-[WebView _didFinishLoadForFrame:]):
        (-[WebView _didFailLoadWithError:forFrame:]):
        (-[WebView _didFailProvisionalLoadWithError:forFrame:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoi Fixed 3341119: Crash when content contains nil (0x0) characters.
rjw [Thu, 24 Jul 2003 00:32:14 +0000 (00:32 +0000)]
i Fixed 3341119:  Crash when content contains nil (0x0) characters.

        Reviewed by Ken.

        * WebCoreSupport.subproj/WebTextRenderer.m:
        (-[WebTextRenderer _CG_drawRun:style:atPoint:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoWebCore:
darin [Thu, 24 Jul 2003 00:23:31 +0000 (00:23 +0000)]
WebCore:

        Reviewed by John.

        - fixed 2/3 of 3279864 -- remove class_poseAs calls from WebKit (will also remove init routine)

        * kwq/KWQTextArea.h: Add drawing state variable so we can tell the difference
        between calls to draw the insertion point inside and calls to draw outside the
        redraw machinery.
        * kwq/KWQTextArea.mm:
        (-[KWQTextArea displayRectIgnoringOpacity:]): Added. Set drawing flag while in here.
        This is the method used by KWQWidget to draw.
        (-[KWQTextArea textView:shouldDrawInsertionPointInRect:color:turnedOn:]): Added.
        Calls setNeedsDisplay (the NSView version, not the NSTextView override) instead
        of immediately drawing when asked to draw outside the normal redraw machinery.
        (-[KWQTextAreaTextView keyDown:]): Call interceptKeyEvent before handling each
        key down event.
        * kwq/KWQTextField.h: Add drawing state variable so we can tell the difference
        between calls to draw the insertion point inside and calls to draw outside the
        redraw machinery.
        * kwq/KWQTextField.mm:
        (-[KWQTextField displayRectIgnoringOpacity:]): Added. Set drawing flag while in here.
        This is the method used by KWQWidget to draw.
        (-[KWQTextField textView:shouldDrawInsertionPointInRect:color:turnedOn:]): Added.
        Calls setNeedsDisplay (the NSView version, not the NSTextView override) instead
        of immediately drawing when asked to draw outside the normal redraw machinery.
        (-[KWQTextField textView:shouldHandleEvent:]): Call interceptKeyEvent before
        handling each key down event.
        (-[KWQTextField textView:didHandleEvent:]): Call fieldEditorDidMouseDown: after
        handling each mouse down event.

        * kwq/KWQWidget.mm: (QWidget::paint): Add comment about dependency on
        displayRectIgnoringOpacity: use in KWQTextArea and KWQTextField.

        * kwq/WebCoreFirstResponderChanges.h: Added a comment about obsolescence.

        - Xcode wanted to change this, because it now knows JavaScriptCore is a framework

        * WebCore.pbproj/project.pbxproj: Munged by Xcode.

WebKit:

        Reviewed by John.

        - fixed 2/3 of 3279864 -- remove class_poseAs calls from WebKit (will also remove init routine)

        * WebView.subproj/WebHTMLViewPrivate.m: (+[WebHTMLView load]):
        Only pose as NSTextView and NSWindow if we have an older AppKit.
        If we have a new enough AppKit, the code in WebCore now takes care of things.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fix for 3340885, invalid colors were being mapped to transparentColor,
hyatt [Wed, 23 Jul 2003 22:56:37 +0000 (22:56 +0000)]
Fix for 3340885, invalid colors were being mapped to transparentColor,
thus causing invisible text!

        Reviewed by kocienda

        * khtml/css/cssparser.cpp:
        (CSSParser::parseColorFromValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoWebCore:
rjw [Wed, 23 Jul 2003 22:48:49 +0000 (22:48 +0000)]
WebCore:
Fixed for 3259840.  Use ATSU for scripts we don't handle internally,
i.e.:  Syriac, Thaana, Devanagari, Bengali, Gurmukhi, Gujarati, Oriya, Tamil, Telugu, Kannada, Malayalam, Sinhala, Thai, Lao, Tibetan, Myanmar, Hangul Jamo, Khmer, Mongolian

Also fixed issues with our rendering of Arabic.

Changed the internal API to take WebCoreTextRun and WebCoreTextStyle
parameters instead of scads on individual parameters.  Much cleaner.

        Reviewed by Maciej.

        * WebCore-combined.exp:
        * WebCore.exp:
        * kwq/KWQFontMetrics.mm:
        (QFontMetrics::width):
        (QFontMetrics::floatWidth):
        (QFontMetrics::floatCharacterWidths):
        * kwq/KWQPainter.mm:
        (QPainter::drawText):
        * kwq/WebCoreTextRenderer.h:
        * kwq/WebCoreTextRendererFactory.m:
        (WebCoreMakeTextRun):
        (WebCoreMakeEmptyTextStyle):

WebKit:
Fixed for 3259840.  Use ATSU for scripts we don't handle internally,
i.e.:  Syriac, Thaana, Devanagari, Bengali, Gurmukhi, Gujarati, Oriya, Tamil, Telugu, Kannada, Malayalam, Sinhala, Thai, Lao, Tibetan, Myanmar, Hangul Jamo, Khmer, Mongolian

Also fixed issues with our rendering of Arabic.

Changed the internal API to take WebCoreTextRun and WebCoreTextStyle
parameters instead of scads on individual parameters.  Much cleaner.

        Reviewed by Maciej.

        * Misc.subproj/WebKitNSStringExtras.m:
        (-[NSString _web_widthWithFont:]):
        * Misc.subproj/WebStringTruncator.m:
        (stringWidth):
        * WebCoreSupport.subproj/WebTextRenderer.h:
        * WebCoreSupport.subproj/WebTextRenderer.m:
        (shouldUseATSU):
        (-[WebTextRenderer _setupFont:]):
        (-[WebTextRenderer dealloc]):
        (-[WebTextRenderer widthForCharacters:length:]):
        (-[WebTextRenderer drawRun:style:atPoint:]):
        (-[WebTextRenderer _CG_drawRun:style:atPoint:]):
        (-[WebTextRenderer floatWidthForCharacters:stringLength:characterPosition:]):
        (-[WebTextRenderer floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:]):
        (-[WebTextRenderer floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:applyRounding:attemptFontSubstitution:widths:letterSpacing:wordSpacing:smallCaps:fontFamilies:]):
        (-[WebTextRenderer floatWidthForRun:style:applyRounding:attemptFontSubstitution:widths:]):
        (-[WebTextRenderer _floatWidthForRun:style:applyRounding:attemptFontSubstitution:widths:fonts:glyphs:startGlyph:endGlyph:numGlyphs:]):
        (-[WebTextRenderer _CG_floatWidthForRun:style:applyRounding:attemptFontSubstitution:widths:fonts:glyphs:startGlyph:endGlyph:numGlyphs:]):
        (-[WebTextRenderer extendCharacterToGlyphMapToInclude:]):
        (-[WebTextRenderer _initializeATSUStyle]):
        (-[WebTextRenderer _createATSUTextLayoutForRun:]):
        (-[WebTextRenderer _trapezoidForRun:style:atPoint:]):
        (-[WebTextRenderer _ATSU_floatWidthForRun:style:]):
        (-[WebTextRenderer _ATSU_drawRun:style:atPoint:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Clean up the mess left by a couple of previous checkins. I had
hyatt [Wed, 23 Jul 2003 22:36:07 +0000 (22:36 +0000)]
Clean up the mess left by a couple of previous checkins.  I had
patched computeLength and computeLengthFloat to take a CSSStyleSelector,
but then I came up with a simpler solution that didn't require that
the selector be passed in as an argument.  I forgot, however, to revert
the functions back to their original forms.  This patch does that.

        Reviewed by john

        * khtml/css/css_valueimpl.cpp:
        (CSSPrimitiveValueImpl::computeLength):
        (CSSPrimitiveValueImpl::computeLengthFloat):
        * khtml/css/css_valueimpl.h:
        * khtml/css/cssstyleselector.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoWebKit:
kocienda [Wed, 23 Jul 2003 20:04:23 +0000 (20:04 +0000)]
WebKit:

        Reviewed by Darin

Removed dependency on Foundation NSURL_NSURLExtras file.
Copied the required methods from that file to WebNSURLExtras,
temporarily renaming the methods that are now in both
places to have a _webkit_ prefix. The names will be changed
back once every one is living on a Foundation version that
no longer contains these methods.

The files below were changed in one of three ways:
1. Rename _web_URLWithString: to _web_URLWithDataAsString:
2. Tweak headers to depend on WebNSURLExtras instead of NSURL_NSURLExtras.
3. At call sites, tweak names of methods that moved to WebKit (_web_ -> _webkit_).

        * History.subproj/WebHistory.m:
        * History.subproj/WebHistoryItem.m:
        (-[WebHistoryItem URL]):
        * History.subproj/WebHistoryPrivate.m:
        * History.subproj/WebURLsWithTitles.m:
        (+[WebURLsWithTitles URLsFromPasteboard:]):
        * Misc.subproj/WebIconDatabase.m:
        (-[WebIconDatabase _iconForFileURL:withSize:]):
        * Misc.subproj/WebIconLoader.m:
        * Misc.subproj/WebNSPasteboardExtras.m:
        (-[NSPasteboard _web_bestURL]):
        * Misc.subproj/WebNSURLExtras.h:
        * Misc.subproj/WebNSURLExtras.m:
        (ReleaseIfNotNULL):
        (+[NSURL _web_URLWithDataAsString:]):
        (+[NSURL _web_URLWithDataAsString:relativeToURL:]):
        (+[NSURL _web_URLWithData:]):
        (+[NSURL _web_URLWithData:relativeToURL:]):
        (-[NSURL _web_originalData]):
        (-[NSURL _web_displayableString]):
        (-[NSURL _web_URLStringLength]):
        (-[NSURL _webkit_canonicalize]):
        (-[NSURL _webkit_URLByRemovingFragment]):
        (-[NSURL _webkit_isJavaScriptURL]):
        (-[NSURL _webkit_scriptIfJavaScriptURL]):
        (-[NSURL _webkit_isFTPDirectoryURL]):
        (-[NSURL _webkit_shouldLoadAsEmptyDocument]):
        (isHexDigit):
        (hexDigitValue):
        (-[NSString _webkit_isJavaScriptURL]):
        (-[NSString _webkit_stringByReplacingValidPercentEscapes]):
        (-[NSString _webkit_scriptIfJavaScriptURL]):
        * Misc.subproj/WebNSViewExtras.m:
        * Panels.subproj/WebAuthenticationPanel.m:
        * Plugins.subproj/WebBaseNetscapePluginView.m:
        (-[WebBaseNetscapePluginView requestWithURLCString:]):
        (-[WebBaseNetscapePluginView loadPluginRequest:]):
        (-[WebBaseNetscapePluginView _postURLNotify:target:len:buf:file:notifyData:allowHeaders:]):
        * Plugins.subproj/WebNullPluginView.m:
        * WebCoreSupport.subproj/WebBridge.m:
        (-[WebBridge requestedURLString]):
        * WebCoreSupport.subproj/WebCookieAdapter.m:
        (-[WebCookieAdapter cookiesForURL:]):
        (-[WebCookieAdapter setCookies:forURL:policyBaseURL:]):
        * WebKit.pbproj/project.pbxproj:
        * WebView.subproj/WebDataSourcePrivate.m:
        (-[WebDataSource _setTitle:]):
        (-[WebDataSource _loadIcon]):
        * WebView.subproj/WebFrame.m:
        * WebView.subproj/WebFramePrivate.m:
        (-[WebFrame _transitionToCommitted:]):
        (-[WebFrame _shouldReloadForCurrent:andDestination:]):
        (-[WebFrame _URLsMatchItem:]):
        * WebView.subproj/WebFrameView.m:
        * WebView.subproj/WebHTMLViewPrivate.m:
        (-[WebHTMLView _elementAtPoint:]):
        * WebView.subproj/WebMainResourceClient.m:
        (-[WebMainResourceClient continueAfterContentPolicy:response:]):
        (-[WebMainResourceClient loadWithRequest:]):
        (-[WebMainResourceClient setDefersCallbacks:]):

WebBrowser:

        Reviewed by Darin

        Removed dependency on Foundation NSURL_NSURLExtras file.
        Copied the required methods from that file to WebNSURLExtras
in WebKit. WebBrowser code now depends on that file instead.
        In order to avoid method name collisions, the WebNSURLExtras
some methods have been temporarily renamed to have a _webkit_
prefix. The names will be changed back once every one is
living on a Foundation version that no longer contains these methods.

        The files below were changed in one of three ways:
        1. Rename _web_URLWithString: to _web_URLWithDataAsString:
        2. Tweak headers to depend on WebNSURLExtras instead of NSURL_NSURLExtras.
        3. At call sites, tweak names of methods that moved to WebKit (_web_ -> _webkit_).

        * AppController.m:
        (-[AppController handleURLEvent:withReplyEvent:]):
        * BookmarkSource.m:
        * BookmarksViewController.m:
        * BrowserDocument.m:
        (-[BrowserDocument initWithContentsOfURL:ofType:]):
        (-[BrowserDocument goToScriptSpecifiedURL]):
        (-[BrowserDocument goHome:]):
        * BrowserDocumentController.m:
        (-[BrowserDocumentController openDocumentWithContentsOfURL:display:]):
        (-[BrowserDocumentController URLFromShortcutFile:]):
        (-[BrowserDocumentController openDocument:]):
        (-[BrowserDocumentController goToURL:windowPolicy:]):
        * BrowserNSNetServiceExtras.m:
        (-[NSNetService URL]):
        * BrowserNSStringExtras.m:
        (-[NSString possibleURLsForUserTypedString]):
        (-[NSString bestURLForUserTypedString]):
        * BrowserWebBookmarkExtras.m:
        (-[WebBookmark _goToWithWindowPolicy:]):
        (-[WebBookmark URLsForGoToAllWithTitles:]):
        * BrowserWebController.m:
        (-[BrowserWebView mouseoverTextForElement:modifierFlags:]):
        (-[BrowserWebView webView:unableToImplementPolicyWithError:frame:]):
        (-[BrowserWebView webView:decidePolicyForMIMEType:request:frame:decisionListener:]):
        (-[BrowserWebView locationFieldURL]):
        (-[BrowserWebView goToRequest:withTabLabel:allowJavaScript:waitInQueue:]):
        (-[BrowserWebView goToURL:withFallbackURLs:]):
        * BrowserWindowController.m:
        (-[BrowserWindowController goToToolbarLocationWithWindowPolicy:]):
        (-[BrowserWindowController replaceTabURLs:usingTabLabelsFromBookmarks:]):
        (-[BrowserWindowController goToBookmarks]):
        * ContextMenuHandler.m:
        (-[BrowserWebView goToAddress:]):
        * Debug/DebugUtilities.m:
        (-[WebHistory populateHistoryWithTestData:]):
        * DownloadProgressEntry.m:
        * FrameProgressEntry.m:
        (-[FrameProgressEntry URL]):
        * GlobalHistory.m:
        (-[GlobalHistory updateDisplayTitleForHistoryItem:]):
        * GoogleSearchChannel.m:
        (-[GoogleSearchChannel URLWithSearchCriteria:]):
        * LoadProgressMonitor.m:
        (-[LoadProgressMonitor launchApplicationSheetEnded:returnCode:contextInfo:]):
        (-[LoadProgressMonitor pluginErrorSheetEnded:returnCode:contextInfo:]):
        * LocationChangeError.m:
        (-[LocationChangeHandler specializedMessageForError:dataSource:]):
        * LocationChangeHandler.m:
        (-[LocationChangeHandler webView:locationChangeDone:forDataSource:]):
        * LocationFieldEditor.m:
        (-[LocationFieldEditor paste:]):
        * Preferences.subproj/AdvancedPreferences.m:
        (-[AdvancedPreferences setStyleSheetPathPreference:]):
        * RendezvousController.m:
        (-[RendezvousController init]):
        * ResourceProgressEntry.m:
        (-[ResourceProgressEntry open]):
        (-[ResourceProgressEntry download]):
        * Test/PageLoadTestRunner.m:
        (-[PageLoadTestRunner setSingleTestURL:]):
        (-[PageLoadTestRunner loadTestSuiteFile:]):
        (-[PageLoadTestRunner pageLoadStarted:]):
        * TitleBarButton.m:
        (-[TitleBarButton showPathRepresentingPopUpMenuForEvent:URL:]):
        * URLCompletionController.m:
        * WebBookmarkLeaf.m:
        (-[WebBookmarkLeaf setURLString:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Temporary hack to ensure that the layout tests will not all
hyatt [Wed, 23 Jul 2003 18:07:50 +0000 (18:07 +0000)]
Temporary hack to ensure that the layout tests will not all
be failures if/when the layout tests regression gets fixed.
Will remove once we can run the tests.

        Reviewed by ken

        * khtml/rendering/render_block.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Allow HTML and BODY to be any display type. This patch primarily eliminates the
hyatt [Wed, 23 Jul 2003 06:35:21 +0000 (06:35 +0000)]
Allow HTML and BODY to be any display type.  This patch primarily eliminates the
RenderBody class and makes the code that deals with background propagation smart
enough to locate the correct renderers for the HTML and BODY elements (by crossing
back into the DOM tree).

        Reviewed by darin

        * ForwardingHeaders/rendering/render_body.h: Removed.
        * WebCore.pbproj/project.pbxproj:
        * khtml/html/html_baseimpl.cpp:
        (HTMLBodyElementImpl::insertedIntoDocument):
        * khtml/html/html_baseimpl.h:
        * khtml/rendering/render_body.cpp: Removed.
        * khtml/rendering/render_body.h: Removed.
        * khtml/rendering/render_box.cpp:
        (RenderBox::setStyle):
        (RenderBox::paintRootBoxDecorations):
        (RenderBox::paintBoxDecorations):
        (RenderBox::repaint):
        * khtml/rendering/render_inline.cpp:
        (RenderInline::paintObject):
        * khtml/rendering/render_inline.h:
        * khtml/rendering/render_object.cpp:
        (RenderObject::isBody):
        * khtml/rendering/render_object.h:
        * khtml/xml/dom_elementimpl.cpp:
        (ElementImpl::createRenderer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoWebCore:
darin [Wed, 23 Jul 2003 06:02:25 +0000 (06:02 +0000)]
WebCore:

        Reviewed by Maciej.

        - fixed 3108604 -- add Shift JIS X0213 and HK-SCS to the Text Encoding menu

        * kwq/mac-encodings.txt: Added "Shift_JIS_X0213-2000". Changed all non-HKSCS
        Big5 encodings to use the DOS variant of Big5 as requested by Peter Edberg,
        but left Big5-HKSCS alone.
        * kwq/KWQCharsets.mm: Added kCFStringEncodingBig5_DOSVariant constant.
        * kwq/KWQCharsetData.c: Regenerated.

        - fixed 3100151 -- subframes without explicit charset settings should inherit from parent, not use default

        * khtml/khtml_part.cpp: (KHTMLPart::write): Get the default encoding from the parent
        part, if there is one.

WebBrowser:

        Reviewed by Maciej.

        - fixed 3108604 -- add Shift JIS X0213 and HK-SCS to the Text Encoding menu

        Since Shift JIS X0213 does not yet have an IANA name, had to change the code
        to get the name another way. This led me to change the menu items to work by having
        the character set name in the representedObject instead of the CFString character set
        code in the tag.

        * BrowserWindowController.m:
        (-[BrowserWindowController validateMenuItem:]): Set the state of a changeTextEncoding:
        menu item based on the represented object, not the tag.
        (-[BrowserWindowController changeTextEncoding:]): Pass the represented object into
        setCustomTextEncodingName: rather than calling CFStringConvertEncodingToIANACharSetName.
        * Preferences.subproj/AppearancePreferences.m:
        (-[AppearancePreferences updateDefaultCharacterSetPopup]):
        (-[AppearancePreferences takeDefaultCharacterSetFrom:]):
        * TextEncodingMenu.m: Added both kCFStringEncodingShiftJIS_X0213_00 and
        kCFStringEncodingBig5_HKSCS_1999 to the menu.
        (-[NSMenu addItemToMenuForEncoding:withTarget:action:]): Get the name using
        CFStringConvertEncodingToIANACharSetName, with hardcoded fallbacks for
        kCFStringEncodingGB_2312_80 and kCFStringEncodingShiftJIS_X0213_00, which do not have
        their IANA names in the table. Put the name in the represented object instead of putting
        the encoding constant in the tag. No need for the separatorItemWithNonConflictingTag method
        any more, since a character set name of nil does not ever get used (unlike a tag of 0,
        which was used for US-ASCII).
        (-[NSMenu addStandardTextEncodingMenuItemsWithTarget:action:preferredEncoding:]):
        Use the represented object check to detect the end of a group rather than checking the
        tag. No need for the separatorItemWithNonConflictingTag method (as above).

        * English.lproj/StringsNotToBeLocalized.txt: Updated for this change and other recent changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago * English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.
darin [Wed, 23 Jul 2003 04:41:32 +0000 (04:41 +0000)]
    * English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by John.
mjs [Tue, 22 Jul 2003 20:48:48 +0000 (20:48 +0000)]
    Reviewed by John.

Remove -seg_addr_table_filename to fix build.

        * JavaScriptCore.pbproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fix for 3293898, list bullets in ordered lists with an inside list
hyatt [Tue, 22 Jul 2003 18:24:02 +0000 (18:24 +0000)]
Fix for 3293898, list bullets in ordered lists with an inside list
position were rendering as though they had a width of 0.  This was
a bug in KWQFontMetrics, which needed to handle the case where a
length of -1 was passed in to the width method (in which case
you should use the length of the whole string).

        Reviewed by john

        * kwq/KWQFontMetrics.mm:
        (QFontMetrics::width):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fix for mozilla.org front page. This patch re-architects
hyatt [Tue, 22 Jul 2003 16:40:20 +0000 (16:40 +0000)]
Fix for mozilla.org front page.  This patch re-architects
align="left" and align="right" (for rtl and ltr directionality
respectively).  The attributes are mapped to custom text-align
values, konq-left and konq-right, just as was done with the
center/middle attributes for alignment.

A number of "hack" style rules have been dropped from html4.css
and replaced with this C++ code that now works in the general
case for any children of align="left/right" divs and tds.

In addition, absmiddle support has been added for <td>s.

For RTL blocks, there is also a regression fix (this was probably
the #1 culprit for mangled placement of blocks in Hebrew Web
pages).  The old code was doing byzantine math that happened to
work out.  When I tried to simplify it before 1.0, I missed a spot
and basically broke margin handling on RTL blocks completely.

        Reviewed by mjs

        * khtml/css/cssparser.cpp:
        (CSSParser::parseValue):
        * khtml/css/cssvalues.c:
        (hash_val):
        (findValue):
        * khtml/css/cssvalues.h:
        * khtml/css/cssvalues.in:
        * khtml/css/html4.css:
        * khtml/html/html_blockimpl.cpp:
        (HTMLDivElementImpl::parseAttribute):
        (HTMLParagraphElementImpl::parseAttribute):
        * khtml/html/html_tableimpl.cpp:
        (HTMLTablePartElementImpl::parseAttribute):
        * khtml/rendering/bidi.cpp:
        * khtml/rendering/render_block.cpp:
        * khtml/rendering/render_box.cpp:
        (RenderBox::calcHorizontalMargins):
        * khtml/rendering/render_style.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fix for 3333557, crash on www.dremedia.com. markDescendants in RenderBlock
hyatt [Mon, 21 Jul 2003 22:53:31 +0000 (22:53 +0000)]
Fix for 3333557, crash on dremedia.com.  markDescendants in RenderBlock
was not passing in its argument in the recursive step, so the float wasn't
getting properly cleared out of everyone's lists.

        Reviewed by darin

        * khtml/rendering/render_block.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fix for 3182596, percentage height tables with cells that specify
hyatt [Mon, 21 Jul 2003 21:19:25 +0000 (21:19 +0000)]
Fix for 3182596, percentage height tables with cells that specify
tiny percentage heights used that height even if it was smaller
than the cell's minimum required height.

        Reviewed by darin

        * khtml/rendering/render_table.cpp:
        (RenderTableSection::layoutRows):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Dave.
darin [Mon, 21 Jul 2003 20:41:50 +0000 (20:41 +0000)]
    Reviewed by Dave.

        - fixed 3316867 -- tabbing to textarea below visible part of page doesn't scroll down

        * kwq/KWQTextArea.mm: (-[KWQTextAreaTextView becomeFirstResponder]): Added call to
        _KWQ_scrollFrameToVisible to match the one in KWQTextField.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fix removeAttributeNode. This is David Faure's patch.
hyatt [Mon, 21 Jul 2003 20:29:33 +0000 (20:29 +0000)]
Fix removeAttributeNode.  This is David Faure's patch.

        Reviewed by me

        * khtml/xml/dom_elementimpl.cpp:
        (NamedAttrMapImpl::removeAttribute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Checking in David Faure's patch that fixes getElementsByTagName(*).
hyatt [Mon, 21 Jul 2003 20:21:37 +0000 (20:21 +0000)]
Checking in David Faure's patch that fixes getElementsByTagName(*).

        Reviewed by me

        * khtml/xml/dom_nodeimpl.cpp:
        (NodeBaseImpl::getElementsByTagNameNS):
        (TagNodeListImpl::nodeMatches):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by me.
kocienda [Mon, 21 Jul 2003 14:31:45 +0000 (14:31 +0000)]
    Reviewed by me.

Fixed build breaker.

Removed glyphCountFromFont function. It was used only in an
ERROR function, which does not compile in on deployment
builds, causing a "defined, but not used warning".

As this function is only a one-liner call into ATS, I
replaced the usage in the ERROR call with a call to the
ATS function directly.

        * WebCoreSupport.subproj/WebTextRenderer.m:
        (-[WebTextRenderer initWithFont:usingPrinterFont:])

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Enable domain() and setDomain() to work for all documents (XML
hyatt [Mon, 21 Jul 2003 01:36:50 +0000 (01:36 +0000)]
Enable domain() and setDomain() to work for all documents (XML
as well as HTML).

Implement onload for frames.

        Reviewed by mjs

        * khtml/ecma/kjs_window.cpp:
        (Window::isSafeScript):
        (WindowFunc::tryCall):
        * khtml/html/html_baseimpl.cpp:
        (HTMLFrameElementImpl::parseAttribute):
        (HTMLIFrameElementImpl::parseAttribute):
        * khtml/html/html_documentimpl.cpp:
        * khtml/html/html_documentimpl.h:
        * khtml/khtml_part.cpp:
        (KHTMLPart::checkEmitLoadEvent):
        * khtml/xml/dom_docimpl.cpp:
        (DocumentImpl::domain):
        (DocumentImpl::setDomain):
        * khtml/xml/dom_docimpl.h:
        * khtml/xml/dom_nodeimpl.cpp:
        (NodeImpl::dispatchWindowEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fixed 3283594. "Times RO" appears to have a corrupt regular variant. Added
rjw [Sat, 19 Jul 2003 02:06:46 +0000 (02:06 +0000)]
Fixed 3283594.  "Times RO" appears to have a corrupt regular variant.  Added
additional bullet proofing to catch corrupt fonts.  Also added a special case
hack to map "Times RO" to "Time New Roman" if the variant doesn't have valid
glyphs.

Fixed 3319846.  The page mentioned in this bug required > 10 substitute fonts for
the same base font.  This triggered some buggy code that hasn't been exercise before.
Specifically the code that resizes the substitute fonts array was incorrect.

        Reviewed by mjs.

        * Misc.subproj/WebAssertions.h:  Added FATAL_ALWAYS macro that logs and CRASHES
even in deployment builds.

        * WebCoreSupport.subproj/WebTextRenderer.m:
        (mapForSubstituteFont):
        (widthFromMap):
        (FillStyleWithAttributes):
        (-[WebTextRenderer convertCharacters:length:toGlyphs:skipControlCharacters:]):
        (-[WebTextRenderer convertUnicodeCharacters:length:toGlyphs:]):
        (-[WebTextRenderer _computeWidthForSpace]):
        (-[WebTextRenderer _setupFont:]):
        (pathFromFont):
        (glyphCountFromFont):
        (-[WebTextRenderer initWithFont:usingPrinterFont:]):
        (-[WebTextRenderer extendUnicodeCharacterToGlyphMapToInclude:]):
        (-[WebTextRenderer extendCharacterToGlyphMapToInclude:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fix for 3334082, XML documents can access HTML/XML docs in other
hyatt [Fri, 18 Jul 2003 19:22:59 +0000 (19:22 +0000)]
Fix for 3334082, XML documents can access HTML/XML docs in other
domains.  The basic bug is that we made a change right before
1.0 to allow a parent document to access a child frame's document
if the child frame had no document.  What we didn't notice was
that the ptr was obtained from the part by asking for an HTML
document.  For XML documents that failed the cast, we got back
null as well, which means that for non-HTML XML documents we
always return true from isSafeScript.

This patch makes sure our addition uses the raw xmlDoc pointer,
so that there are no mistakes, and it restores the code that
denies access when you aren't an HTML document.

(It is a separate bug that we just disallow cross-frame
communication in XML documents right now that I'll file as
a follow-up to this one.)

        Reviewed by darin, rjw, mjs

        * khtml/ecma/kjs_window.cpp:
        (Window::isSafeScript):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4671 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by John.
darin [Thu, 17 Jul 2003 23:41:12 +0000 (23:41 +0000)]
    Reviewed by John.

        - fixed 3250608 -- REGRESSION (74-85): reproducible Safari crash in blinkCaretTimerAction

        * WebView.subproj/WebHTMLViewPrivate.m:
        (-[WebNSTextView drawInsertionPointInRect:color:turnedOn:]):
        Use NSView's setNeedsDisplayInRect: instead of the one in NSTextView.
        This avoids the layout that the NSTextView version of the call might do.
        By definition, we don't need layout to draw the insertion point, because we did
        the layout to find where the insertion point should display. If we do the layout
        we can end up recursing into the insertion point drawing code, which wreaks major
        havoc. Still no idea why this happened less in version 74.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fix for 3300362, crash on myuhc.com. The residual style code
hyatt [Thu, 17 Jul 2003 19:49:39 +0000 (19:49 +0000)]
Fix for 3300362, crash on myuhc.com.  The residual style code
was messing up and inserting nodes in the wrong place (and also
updating the current member variable when it wasn't supposed to).

Fix for 3331793, nil deref because (astoundingly) someone was
using text-shadow and exposed a bug with the color handling
of the shadow.

        Reviewed by darin

        * khtml/html/htmlparser.cpp:
* khtml/html/htmlparser.h
        (KHTMLParser::reopenResidualStyleTags):
        (KHTMLParser::popBlock):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by John.
mjs [Thu, 17 Jul 2003 18:55:17 +0000 (18:55 +0000)]
    Reviewed by John.

- fixed 3283076 - crash when doing 2nd query on the eBay channel (Sherlock) -- JavaScript locking issue?

I added a bit of minimal extra locking to WebCore to make sure
multithreaded apps that use WebKit on the main thread but do
JavaScript on other threads as well continue to work nicely.

        * khtml/ecma/kjs_proxy.cpp:
        (KJSProxyImpl::initScript): Lock interpreter around possible allocations or collections.
        * khtml/ecma/kjs_window.cpp:
        (Window::clear): Lock interpreter around possible allocations or collections.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4666 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by John.
mjs [Thu, 17 Jul 2003 18:54:39 +0000 (18:54 +0000)]
    Reviewed by John.

- fixed 3330344 - Please change allowable client to "JavaScriptGlue" from "JSGlue"

        * JavaScriptCore.pbproj/project.pbxproj: Changed allowable client
to "JavaScriptGlue"

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoWebCore:
kocienda [Thu, 17 Jul 2003 17:49:06 +0000 (17:49 +0000)]
WebCore:

        Reviewed by John

        * kwq/KWQKHTMLPart.mm:
        (KWQKHTMLPart::createPart): Now uses NSURL instead of NSString
        (KWQKHTMLPart::redirectionTimerStartedOrStopped): Ditto
        (KWQKHTMLPart::userAgent): Ditto
        * kwq/KWQKHTMLPartBrowserExtension.mm:
        (KHTMLPartBrowserExtension::setIconURL): Ditto
        (KHTMLPartBrowserExtension::setTypedIconURL): Ditto
        * kwq/KWQKJavaAppletWidget.mm:
        (KJavaAppletWidget::showApplet): Ditto
        * kwq/KWQLoader.mm:
        (KWQServeRequest): Ditto
        (KWQCheckCacheObjectStatus): Ditto
        * kwq/WebCoreBridge.h: Changed quite a number of methods to use NSURL
instead of NSString
        * kwq/WebCoreBridge.mm:
        (-[WebCoreBridge didNotOpenURL:]): Now uses NSURL instead of NSString
        (-[WebCoreBridge scrollToAnchorWithURL:]): Ditto
        (-[WebCoreBridge URL]): Ditto

WebKit:

        Reviewed by John

        * WebCoreSupport.subproj/WebBridge.m:
        (-[WebBridge startLoadingResource:withURL:]): Now uses NSURL instead of NSString
        (-[WebBridge objectLoadedFromCacheWithURL:response:size:]): Ditto
        (-[WebBridge reportClientRedirectToURL:delay:fireDate:lockHistory:isJavaScriptFormAction:]):
Ditto
        (-[WebBridge setIconURL:]): Ditto
        (-[WebBridge setIconURL:withType:]): Ditto
        (-[WebBridge createChildFrameNamed:withURL:renderPart:allowsScrolling:marginWidth:marginHeight:]): Ditto
        (-[WebBridge userAgentForURL:]): Ditto
        (-[WebBridge requestedURL]): Now returns string using _web_absoluteString
        * WebView.subproj/WebDataSourcePrivate.m:
        (-[WebDataSource _receivedError:complete:]): Now uses NSURL instead of NSString
        * WebView.subproj/WebFramePrivate.m:
        (-[WebFrame _opened]): Ditto
        (-[WebFrame _continueFragmentScrollAfterNavigationPolicy:formState:]): Ditto
        (-[WebFrame _loadURL:referrer:loadType:target:triggeringEvent:form:formValues:]): Ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by me
kocienda [Thu, 17 Jul 2003 15:51:56 +0000 (15:51 +0000)]
    Reviewed by me

        * Misc.subproj/WebNSURLExtras.m:
        (-[NSURL _web_URLStringLength]): Fix premature use of new CFURL API.
New code is ifdef'ed out for now until everyone has revved.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4663 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoWebCore:
kocienda [Thu, 17 Jul 2003 14:56:10 +0000 (14:56 +0000)]
WebCore:

        Reviewed by Darin

        * kwq/KWQKHTMLPart.h: _submittedFormURL is now a KURL, not a QString
        * kwq/KWQKHTMLPart.mm:
        (KWQKHTMLPart::openURL): Now uses NSURL in API instead of NSString
        (KWQKHTMLPart::openURLRequest): Ditto
        (KWQKHTMLPart::didNotOpenURL): Ditto
        (KWQKHTMLPart::submitForm): Ditto. Plus update _submittedFormURL usages.
        (KWQKHTMLPart::urlSelected): Ditto
        (KWQKHTMLPart::setView): Ditto
        * kwq/KWQKHTMLPartBrowserExtension.mm:
        (KHTMLPartBrowserExtension::createNewWindow): Now uses NSURL in API instead of NSString
        * kwq/KWQKURL.h: Added constructor that takes an NSURL
        * kwq/KWQKURL.mm:
        (KURL::KURL): Ditto.
        * kwq/WebCoreBridge.h: Updated bridge APIs to use NSURL instead of NSString
in several places.
        * kwq/WebCoreBridge.mm:
        (-[WebCoreBridge openURL:reload:contentType:refresh:lastModified:pageCache:]): Ditto

WebKit:

        Reviewed by Darin

        * WebCoreSupport.subproj/WebBridge.m:
        (-[WebBridge createWindowWithURL:frameName:]): Now uses NSURL in API instead of NSString
        (-[WebBridge loadURL:referrer:reload:target:triggeringEvent:form:formValues:]): Ditto
        (-[WebBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): Ditto
        * WebKit.pbproj/project.pbxproj: Added WebNSURLExtras file
        * WebView.subproj/WebDataSourcePrivate.m:
        (-[WebDataSource _commitIfReady:]): Now uses NSURL in API instead of NSString

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by John.
darin [Wed, 16 Jul 2003 20:30:22 +0000 (20:30 +0000)]
    Reviewed by John.

        - cure problem where we keep competing to check in config.h with/without HAVE_FOUNDATION_SOURCSE

        * Makefile.am: Remove the HAVE_FOUNDATION_SOURCES line.
        * config.h: Check in without that line.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by kocienda.
vicki [Wed, 16 Jul 2003 18:46:32 +0000 (18:46 +0000)]
    Reviewed by kocienda.

        * kwq/KWQKHTMLPart.mm:
        (KWQKHTMLPart::attributedString): set linkStartLocation to zero to fix deployment build

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Richard
kocienda [Wed, 16 Jul 2003 16:54:00 +0000 (16:54 +0000)]
    Reviewed by Richard

        * kwq/KWQKURL.h:
        * kwq/KWQKURL.mm:
        (StringHasCaseInsensitivePrefix): Helper method for the new functions below
        (StringByAddingPercentEscapes): Ditto
        (URLStringByAddingPercentEscapes): Ditto
        (KURL::getNSURL): Added convenience function to get an NSURL from a KURL
        (KURL::getNSData): Added convenience function to get an NSData from a KURL

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4659 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years agoWebKit:
rjw [Tue, 15 Jul 2003 22:54:37 +0000 (22:54 +0000)]
WebKit:
Fixed 3315952:  Add support for <IMG> in attributed string conversion.

Added RTFD pasteboard type.

        Reviewed by John.

        * WebView.subproj/WebHTMLViewPrivate.m:
        (+[WebHTMLView _pasteboardTypes]):
        (-[WebHTMLView _writeSelectionToPasteboard:]):

WebCore:
Fixed 3315951:  Add support for <OL>, <UL> in attributed string conversion.
Fixed 3315952:  Add support for <IMG> in attributed string conversion.
Fixed 3315953:  Added support for <A> in attributed string conversion.

        Reviewed by John (and earlier by Darin).

        * khtml/rendering/render_list.h:
        * kwq/KWQKHTMLPart.mm:
        (fileWrapperForElement):
        (listParent):
        (inList):
        (KWQKHTMLPart::attributedString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fix a problem where ems used for non-font values like width
hyatt [Tue, 15 Jul 2003 22:32:42 +0000 (22:32 +0000)]
Fix a problem where ems used for non-font values like width
and line-height would not zoom. (r=darin)

The rest is r=rjw.

An implementation of the CSS2 text-shadow property.

It uses a CoreGraphics API for drawing shadows
(via a custom API on QPainter) to paint the shadows.

        At the moment there are two limitations in CG's API.  The first
        is that the shadow color cannot be set.  This will be fixed for
        Panther, and the code passes the color through in preparation
        for this fix.

The second limitation is that CG only supports one shadow effect
and not multiple shadow effects.  The parsing code on the CSS
        side is set up to go ahead and parse all of the shadow effects,
        but the code that makes use of shadows will simply look at the
        first one for now.  CG will not support multiple shadow effects
        in the Panther time frame, so it will be a while before this
        is revisited.

This patch also fixes a slew of bugs with colors in KHTML.  When
we took the CSS parser and all of its associated code from Lars,
that code was using QRgb values that assumed RGBA (like the current
Qt toolkit uses).  The code even made use of an "invalid color"
that wasn't really invalid (kind of like the z-index hack we refused
to take, i.e., unlikely but not invalid).

Our KWQColor implementation has been rewritten in this patch to
work the way the current Qt toolkit expects.  That is, the top
eight bits actually do contain an alpha channel, and you can obtain
the alpha component using the qAlpha method and build a quadruple
using the qRgba method.

This patch adds support for rgba quadruples to CSS, so you can now
say, e.g.,color: rgba(255,0,0,0.5); in CSS.

        * khtml/css/css_valueimpl.cpp:
        (ShadowValueImpl::~ShadowValueImpl):
        * khtml/css/css_valueimpl.h:
        * khtml/css/cssparser.cpp:
        (CSSParser::parseValue):
        (parseColor):
        (CSSParser::parseColor):
        (CSSParser::parseColorFromValue):
        (CSSParser::parseShadow):
        * khtml/css/cssparser.h:
        * khtml/css/cssstyleselector.cpp:
        * khtml/misc/helper.h:
        * khtml/rendering/render_line.cpp:
        (InlineFlowBox::paintDecorations):
        * khtml/rendering/render_style.cpp:
        (StyleVisualData::StyleVisualData):
        (opacity):
        (flexibleBox):
        (StyleCSS3NonInheritedData::operator==):
        (textShadow):
        (StyleCSS3InheritedData):
        (StyleCSS3InheritedData::operator==):
        (StyleCSS3InheritedData::shadowDataEquivalent):
        (RenderStyle::RenderStyle):
        (RenderStyle::inheritFrom):
        (RenderStyle::operator==):
        (RenderStyle::inheritedNotEqual):
        (RenderStyle::diff):
        (ContentData::clearContent):
        (RenderStyle::setTextShadow):
        (ShadowData::operator==):
        * khtml/rendering/render_style.h:
        * khtml/rendering/render_text.cpp:
        (RenderText::paintObject):
        * khtml/xml/dom_nodeimpl.cpp:
        (NodeImpl::diff):
        * kwq/KWQColor.h:
        * kwq/KWQColor.mm:
        (qRgb):
        (qRgba):
        (qAlpha):
        (QColor::QColor):
        (QColor::setNamedColor):
        (QColor::getNSColor):
        * kwq/KWQNamespace.h:
        * kwq/KWQPainter.h:
        * kwq/KWQPainter.mm:
        (QPainter::drawRect):
        (QPainter::drawLine):
        (QPainter::_fillRect):
        (QPainter::fillRect):
        (QPainter::setShadow):
        (QPainter::clearShadow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Maciej.
darin [Tue, 15 Jul 2003 04:18:49 +0000 (04:18 +0000)]
    Reviewed by Maciej.

        - fixed 3244447 -- add KOI8-U charset support
        - fixed 3327152 -- unicodeFFFE and unicodeFEFF are handled backwards by WebCore
        - fixed 3327157 -- x-mac-ukrainian should be mapped to MacCyrillic
        - fixed 3327160 -- shift-jis, shift_jis, x-sjis should be mapped to the DOS variant of Shift JIS
        - fixed 3327162 -- most Simplified Chinese encoding choices should be mapped to the DOS variant of EUC-CN
        - fixed 3327166 -- use DOS variant of EUC_KR

        * kwq/KWQCharsets.mm: Added some defines so we could use encodings that don't
        have any kCFStringEncoding constant in a header file.
        * kwq/mac-encodings.txt: Change table entries in accordance with the above bug reports.
        * kwq/KWQCharsetData.c: Regenerated.

        - other changes, inspired by investigation of various bugs

        * kwq/KWQButton.mm: (-[KWQButton sendConsumedMouseUpIfNeeded]): Make robust against cases where
        sending the consumed mouse up event destroys the QButton.

        * khtml/html/htmlparser.cpp:
        (KHTMLParser::reopenResidualStyleTags): Rearrange code slightly for clarity, added comment.
        (KHTMLParser::freeBlock): Removed unnecessary line of code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Maciej.
darin [Tue, 15 Jul 2003 04:17:53 +0000 (04:17 +0000)]
    Reviewed by Maciej.

        - make some improvements to handling of the timer, inspired by some bug reports

        * WebView.subproj/WebFramePrivate.m:
        (-[WebFramePrivate dealloc]): Instead of releasing the timer, assert it is nil.
        (-[WebFrame _detachFromParent]): Invalidate and release the timer after finishing
        dealing with self, in case the reference from the timer is the last one.
        (-[WebFrame _timedLayout:]): Release the timer after doing all the other work,
        in case the reference from the timer is the last one.
        (-[WebFrame _setState:]): Release the timer after doing all the other work,
        in case the reference from the timer is the last one.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Rolled out workaround to bug 3298153 -- get "screen font while printing"
darin [Mon, 14 Jul 2003 20:37:40 +0000 (20:37 +0000)]
    Rolled out workaround to bug 3298153 -- get "screen font while printing"
        error, bad stuff happens after that (Sherlock, Safari). It turns out the
        real fix was on the WebCore side. Now that we have that fix we don't need
        these extra calls to printerFont, which is a relatively slow call that
        may need to look up a font by name each time it's called.

        * WebCoreSupport.subproj/WebTextRenderer.m: (_drawGlyphs):
        Remove code to look up the printer font.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Rolled in fix from Safari-89-branch
mjs [Mon, 14 Jul 2003 20:10:36 +0000 (20:10 +0000)]
Rolled in fix from Safari-89-branch

    2003-07-12  Maciej Stachowiak  <mjs@apple.com>

Try to fix OS build by making the Frameworks link in both SYMROOT
and DSTROOT, and at both build time and install time.

        * WebKit.pbproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Roll this change out. It was a bad change that I only made
hyatt [Mon, 14 Jul 2003 19:17:51 +0000 (19:17 +0000)]
Roll this change out.  It was a bad change that I only made
because I was using the opacity APIs wrong.

        Reviewed by (nobody, just a straight backout of a previous checkin)

        * WebCoreSupport.subproj/WebImageRenderer.m:
        (-[WebImageRenderer drawClippedToValidInRect:fromRect:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fix for 3294626, no scrollbar on ESPN. Fix lowestPosition to
hyatt [Mon, 14 Jul 2003 19:02:43 +0000 (19:02 +0000)]
Fix for 3294626, no scrollbar on ESPN.  Fix lowestPosition to
always crawl into all children.

        Reviewed by darin

        * khtml/rendering/render_flow.cpp:
        (RenderFlow::lowestPosition):
        (RenderFlow::rightmostPosition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Maciej.
darin [Sun, 13 Jul 2003 21:41:19 +0000 (21:41 +0000)]
    Reviewed by Maciej.

        - fixed 3132021 -- certain Japanese characters are misrendered because of incorrect partial-character handling

        We didn't have code to handle kTECPartialCharErr.

        * kwq/KWQTextCodec.mm:
        (KWQTextDecoder::createTECConverter): Added. Broken out from convertUsingTEC.
        (KWQTextDecoder::appendOmittingBOMs): Added. Broken out from convertUsingTEC.
        (KWQTextDecoder::convertOneChunkUsingTEC): Added. Broken out from convertUsingTEC.
        This also has much of the partially-decoded character handling.
        (KWQTextDecoder::convertUsingTEC): Simplified by breaking into functions, and added
        handling to use the same buffer we use for the other decoders to hold partially-decoded
        characters.
        (KWQTextDecoder::convert): Add a partial-character handling test mode where the decoder
        is passed only a single byte at a time; controlled by an #if.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Maciej.
darin [Sun, 13 Jul 2003 21:40:45 +0000 (21:40 +0000)]
    Reviewed by Maciej.

        - do some improvements Maciej suggested while reviewing the array index change

        * kjs/array_object.cpp:
        (getArrayIndex): Return a flag to say whether the index was value separately, to avoid
        in-band signalling.
        (ArrayInstanceImp::get): Update for new getArrayIndex parameters.
        (ArrayInstanceImp::put): Ditto.
        (ArrayInstanceImp::hasProperty): Ditto.
        (ArrayInstanceImp::setLength): Ditto.

        * kjs/ustring.cpp: (UString::toStrictUInt32): Check for overflow in a way that avoids doing
        a divide every time through the loop. But note that it adds an extra branch to the loop.
        I wonder which is worse.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago * WebKit.pbproj/project.pbxproj: Add command to prevent build from failing...
darin [Sun, 13 Jul 2003 21:40:27 +0000 (21:40 +0000)]
    * WebKit.pbproj/project.pbxproj: Add command to prevent build from failing if symlink
        creation fails.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fixed symbolic link path as Matt Reda suggested.
darin [Sun, 13 Jul 2003 21:31:15 +0000 (21:31 +0000)]
    Fixed symbolic link path as Matt Reda suggested.

        * WebKit.pbproj/project.pbxproj: Changed paths in both of Maciej's new build phases
        to use Versions/Current instead of Versions/A.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fixed DSTROOT path as Eric Weiss suggested.
darin [Sun, 13 Jul 2003 16:29:55 +0000 (16:29 +0000)]
    Fixed DSTROOT path as Eric Weiss suggested.

        * WebKit.pbproj/project.pbxproj: Changed paths in both of Maciej's new build phases.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Try to fix OS build by making the Frameworks link in both SYMROOT
mjs [Sun, 13 Jul 2003 06:23:49 +0000 (06:23 +0000)]
Try to fix OS build by making the Frameworks link in both SYMROOT
and DSTROOT, and at both build time and install time.

        * WebKit.pbproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fix for 3187101, before/after content not dynamic. This patch
hyatt [Sun, 13 Jul 2003 00:10:21 +0000 (00:10 +0000)]
Fix for 3187101, before/after content not dynamic.  This patch
compares the ContentData of the old style and the new style and
if they are different, it blows away and recreates the render
objects for the generated content.  Otherwise it will dynamically
update the styles of the generated content render objects (which
should fix the printer/screen bug for rjw).

Note that createObject had an extra call to setStyle, which was
causing most objects to set the same style context on themselves
twice.  This was exposed as I was fixing the above problem.

        Reviewed by darin

        * ChangeLog:
        * khtml/rendering/render_container.cpp:
        (RenderContainer::updatePseudoChild):
        * khtml/rendering/render_object.cpp:
        (RenderObject::createObject):
        * khtml/rendering/render_style.cpp:
        (RenderStyle::contentDataEquivalent):
        * khtml/rendering/render_style.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fixed broken build.
darin [Sat, 12 Jul 2003 18:53:16 +0000 (18:53 +0000)]
    Fixed broken build.

        * kjs/identifier.h: Add toULong back. It's still used in WebCore (and maybe in JavaScriptGlue,
        for all I know).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Dave.
darin [Sat, 12 Jul 2003 16:01:36 +0000 (16:01 +0000)]
    Reviewed by Dave.

        - fixed 3272777 -- array object indices treated as integers by Safari, but as strings in other web browsers

        JavaScriptCore did not implement the proper rule for what an array index is.

        * kjs/array_object.cpp:
        (getArrayIndex): Added. Implements the rule from the specification, which also provides a handy
        "not an array index" value of 2^32-1.
        (ArrayInstanceImp::get): Use getArrayIndex.
        (ArrayInstanceImp::put): Ditto.
        (ArrayInstanceImp::hasProperty): Ditto.
        (ArrayInstanceImp::setLength): Ditto.

        * kjs/identifier.h: Removed now-unused toULong, and added toStrictUInt32, in both cases forwarding
        functions that forward to UString.

        * kjs/ustring.h: Added toStringUInt32.
        * kjs/ustring.cpp: (UString::toStrictUInt32): Added. Converts a string to a 32-bit unsigned integer,
        and rejects any string that does not exactly match the way the integer would be formatted on output.
        This is the rule documented in the ECMA language standard.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Fix pseudostyles to inherit from the element's style that they are
hyatt [Sat, 12 Jul 2003 00:36:55 +0000 (00:36 +0000)]
Fix pseudostyles to inherit from the element's style that they are
specified for.  This is incorrect both for ::first-line and
::first-letter, but it is at least right for ::before and ::after.

Fix iframes and objects and embeds so that they will render borders
when borders are specified (as well as background images).

Patch iframes so that they correctly let the parent document's
background show through when the Web page inside the iframe has
no specified background.  Also patched iframes to understand not
to blit in this case and to not blit when opacity has been specified
on the iframe.

        Reviewed by darin

        * khtml/css/cssstyleselector.cpp:
        * khtml/khtmlview.h:
        * khtml/rendering/render_box.cpp:
        (RenderBox::paintRootBoxDecorations):
        * khtml/rendering/render_canvas.cpp:
        * khtml/rendering/render_form.cpp:
        (RenderFormElement::setStyle):
        * khtml/rendering/render_replaced.cpp:
        (RenderReplaced::calcMinMaxWidth):
        (RenderWidget::setStyle):
        (RenderWidget::paintObject):
        * kwq/KWQKHTMLPart.mm:
        (KWQKHTMLPart::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Ken.
darin [Fri, 11 Jul 2003 22:38:03 +0000 (22:38 +0000)]
    Reviewed by Ken.

        - roll in change from KHTML to remove user and password from referrer

        * khtml/khtml_part.cpp: (KHTMLPart::begin): Call setUser(""), setPass(""),
        and setRef(""), then also set the referrer to "" if the protocol does not
        start with http.

        * kwq/WebCoreBridge.mm: (-[WebCoreBridge referrer]): Remove check to exclude
        file URL referrers because KHTMLPart now excludes all non-http referrers.

        * kwq/KWQKURL.h: Add setUser and setPass functions. Also sort by order within
        the URL so it's clear no methods are omitted.
        * kwq/KWQKURL.mm:
        (KURL::setUser): Added. Adds or removes the username, adding or removing
        delimiters as needed. For now only the remove part is compiled in.
        (KURL::setPass): Added. Adds or removes a password, adding or removing
        delimiters as needed. For now only the remove part is compiled in.

        * kwq/KWQString.h: Add QSTRING_NULL macro to allow us to work around the fact
        that there is no global QString::null object in KWQ without having to do a
        relatively ineffecient conversion from a non-constant char * of 0 each time.
        We can use this anywhere QString::null appears and perhaps get some small code
        savings or performance boost.

        - small cleanup

        * kwq/KWQTextCodec.mm: (QTextCodec::fromUnicode): Remove unneeded checks that
        repeat optimizations I already put in QString.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Dave.
darin [Fri, 11 Jul 2003 18:41:16 +0000 (18:41 +0000)]
    Reviewed by Dave.

        - added a function Dave needs for various work he's doing that goes
          from a document to the corresponding element in the parent document

        * khtml/xml/dom_docimpl.h: Add ownerElement member function.
        * khtml/xml/dom_docimpl.cpp: (DocumentImpl::ownerElement):
        Added. Gets to the parent part and finds the right element.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago An initial implementation of the CSS opacity property. Seems
hyatt [Fri, 11 Jul 2003 17:55:42 +0000 (17:55 +0000)]
An initial implementation of the CSS opacity property.  Seems
to work perfectly except for native widgetry (NSViews).  Images,
text, borders, and underlines are all properly blended.

        Reviewed by rjw

        * config.h:
        * khtml/css/cssparser.cpp:
        (CSSParser::parseValue):
        * khtml/css/cssproperties.c:
        (hash_prop):
        (findProp):
        * khtml/css/cssproperties.h:
        * khtml/css/cssproperties.in:
        * khtml/css/cssstyleselector.cpp:
        * khtml/rendering/render_block.h:
        * khtml/rendering/render_box.cpp:
        (RenderBox::setStyle):
        (RenderBox::adjustZIndex):
        * khtml/rendering/render_box.h:
        * khtml/rendering/render_inline.h:
        * khtml/rendering/render_layer.cpp:
        (RenderLayer::transparentAncestor):
        (RenderLayer::isTransparent):
        (commonTransparentAncestor):
        (RenderLayer::updateTransparentState):
        (RenderLayer::beginTransparencyLayers):
        (RenderLayer::endTransparencyLayers):
        (RenderLayer::paint):
        * khtml/rendering/render_layer.h:
        * khtml/rendering/render_object.h:
        * khtml/rendering/render_style.cpp:
        (StyleVisualData::StyleVisualData):
        (RenderStyle::diff):
        * khtml/rendering/render_style.h:
        * kwq/KWQPainter.h:
        * kwq/KWQPainter.mm:
        (QPainter::beginTransparencyLayer):
        (QPainter::endTransparencyLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Make sure image compositing obeys the current global alpha that
hyatt [Fri, 11 Jul 2003 17:54:32 +0000 (17:54 +0000)]
Make sure image compositing obeys the current global alpha that
is in effect, e.g., if someone has set an opacity within the
current layer.

It's worth noting that I'm not even sure *why* this patch works,
but it does, even with nested opacity layers.

        Reviewed by darin

        * WebCoreSupport.subproj/WebImageRenderer.m:
        (-[WebImageRenderer drawClippedToValidInRect:fromRect:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Chris.
darin [Fri, 11 Jul 2003 16:24:37 +0000 (16:24 +0000)]
    Reviewed by Chris.

        - fixed 3305391 -- repro crash in QPixmap::QPixmap after click in SVG using Adobe SVG plugin

        * kwq/WebCoreBridge.mm: (-[WebCoreBridge elementAtPoint:]): Remove code that tried to determine
        if something is an image by looking at the node type. Instead look at the object in the render
        tree and ask it if it's an image. Also use logic that exactly matches what RenderImage uses.

        * kwq/KWQDOMNode.h: Remove unused isImage function.
        * kwq/KWQDOMNode.cpp: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

18 years ago Reviewed by Ken.
darin [Fri, 11 Jul 2003 15:24:44 +0000 (15:24 +0000)]
    Reviewed by Ken.

        - fixed 3300220 -- repro crash in closeURL when choosing from popup menus on www.drivewire.com

        * khtml/xml/dom_nodeimpl.cpp:
        (NodeImpl::dispatchGenericEvent): Removed unused local variable. Since we update all documents,
        there was no longer any need to keep that pointer around, but we still had this obsolete code.
        This had nothing to do with the bug, just a related cleanup.
        (NodeImpl::dispatchWindowEvent): Add check for nil. We ref the document pointer, but we don't
        ref the document itself. So we do need to check for the case where the document went away.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

19 years ago Reviewed by Maciej.
darin [Fri, 11 Jul 2003 08:01:45 +0000 (08:01 +0000)]
    Reviewed by Maciej.

        - fixed 3217731 -- after going back to a page, forms are submitted with the wrong encoding (back/forward cache)

        * kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::openURLFromPageCache): Put decoder from document into the part.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@4622 268f45cc-cd09-0410-ab3c-d52691b4dbfc