WebKit-https.git
10 years agoVersioning.
lforschler@apple.com [Fri, 22 Apr 2011 00:45:27 +0000 (00:45 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-21 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Fri, 22 Apr 2011 00:43:59 +0000 (00:43 +0000)]
2011-04-21  Ryosuke Niwa  <rniwa@webkit.org>

        Windows build fix.

        * WebCoreSupport/WebEditorClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/9033535>
ike@apple.com [Fri, 22 Apr 2011 00:42:26 +0000 (00:42 +0000)]
<rdar://problem/9033535>

Reviewed by Maciej Stachowiak.

Mute sandbox violations when attempting to read a temporary
CFNetwork keychain.

* WebProcess/com.apple.WebProcess.sb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-21 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 22 Apr 2011 00:34:13 +0000 (00:34 +0000)]
2011-04-21  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        webkit-patch upload should assign the bug to you
        https://bugs.webkit.org/show_bug.cgi?id=33699

        This patch only re-assigns the bug if it is currently unassigned.  We
        can be more aggressive in the future if people want us to be more
        agressive.

        * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
        * Scripts/webkitpy/tool/commands/upload_unittest.py:
        * Scripts/webkitpy/tool/mocktool.py:
        * Scripts/webkitpy/tool/steps/postdiff.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-21 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Fri, 22 Apr 2011 00:33:21 +0000 (00:33 +0000)]
2011-04-21  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Sam Weinig.

        Add Frame* to the argument lists of canCopyCut and canPaste
        https://bugs.webkit.org/show_bug.cgi?id=59153

        * src/EditorClientImpl.cpp:
        (WebKit::EditorClientImpl::canCopyCut):
        (WebKit::EditorClientImpl::canPaste):
        * src/EditorClientImpl.h:
2011-04-21  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Sam Weinig.

        Add Frame* to the argument lists of canCopyCut and canPaste
        https://bugs.webkit.org/show_bug.cgi?id=59153

        * WebCoreSupport/EditorClientQt.cpp:
        (WebCore::EditorClientQt::canCopyCut):
        (WebCore::EditorClientQt::canPaste):
        * WebCoreSupport/EditorClientQt.h:
2011-04-21  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Sam Weinig.

        Add Frame* to the argument lists of canCopyCut and canPaste
        https://bugs.webkit.org/show_bug.cgi?id=59153

        * WebCoreSupport/EditorClientGtk.cpp:
        (WebKit::EditorClient::canCopyCut):
        (WebKit::EditorClient::canPaste):
        * WebCoreSupport/EditorClientGtk.h:
2011-04-21  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Sam Weinig.

        Add Frame* to the argument lists of canCopyCut and canPaste
        https://bugs.webkit.org/show_bug.cgi?id=59153

        * WebCoreSupport/WebEditorClient.cpp:
        (WebEditorClient::canCopyCut):
        (WebEditorClient::canPaste):
        * WebCoreSupport/WebEditorClient.h:
2011-04-21  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Sam Weinig.

        Add Frame* to the argument lists of canCopyCut and canPaste
        https://bugs.webkit.org/show_bug.cgi?id=59153

        * WebKitSupport/EditorClientWx.cpp:
        (WebCore::EditorClientWx::canCopyCut):
        (WebCore::EditorClientWx::canPaste):
        * WebKitSupport/EditorClientWx.h:
2011-04-21  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Sam Weinig.

        Add Frame* to the argument lists of canCopyCut and canPaste
        https://bugs.webkit.org/show_bug.cgi?id=59153

        * WebCoreSupport/WebEditorClient.h:
        * WebCoreSupport/WebEditorClient.mm:
        (WebEditorClient::canCopyCut):
        (WebEditorClient::canPaste):
2011-04-21  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Sam Weinig.

        Add Frame* to the argument lists of canCopyCut and canPaste
        https://bugs.webkit.org/show_bug.cgi?id=59153

        * WebCoreSupport/EditorClientHaiku.cpp:
        (WebCore::EditorClientHaiku::canCopyCut):
        (WebCore::EditorClientHaiku::canPaste):
        * WebCoreSupport/EditorClientHaiku.h:
2011-04-21  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Sam Weinig.

        Add Frame* to the argument lists of canCopyCut and canPaste
        https://bugs.webkit.org/show_bug.cgi?id=59153

        * WebCoreSupport/EditorClientEfl.cpp:
        (WebCore::EditorClientEfl::canCopyCut):
        (WebCore::EditorClientEfl::canPaste):
        * WebCoreSupport/EditorClientEfl.h:
2011-04-21  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Sam Weinig.

        Add Frame* to the argument lists of canCopyCut and canPaste
        https://bugs.webkit.org/show_bug.cgi?id=59153

        canCopyCut and canPaste now takes Frame* for which supportedCopyCut and supportedPaste are called.
        This allows editor client to grant copy/cut and paste permissions per origin.

        * editing/EditorCommand.cpp:
        (WebCore::supportedCopyCut):
        (WebCore::supportedPaste):
        * loader/EmptyClients.h:
        (WebCore::EmptyEditorClient::canCopyCut):
        (WebCore::EmptyEditorClient::canPaste):
        * page/EditorClient.h:
2011-04-21  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Sam Weinig.

        Add Frame* to the argument lists of canCopyCut and canPaste
        https://bugs.webkit.org/show_bug.cgi?id=59153

        * WebProcess/WebCoreSupport/WebEditorClient.cpp:
        (WebKit::WebEditorClient::canCopyCut):
        (WebKit::WebEditorClient::canPaste):
        * WebProcess/WebCoreSupport/WebEditorClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-21 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Fri, 22 Apr 2011 00:22:23 +0000 (00:22 +0000)]
2011-04-21  Dirk Pranke  <dpranke@chromium.org>

        Unreviwed, expecations change. Pick up chromium-win baselines
        for r84522.

        * platform/chromium-win/svg/dynamic-updates/SVGFEDropShadowElement-dom-dx-attr-expected.png: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGFEDropShadowElement-dom-dy-attr-expected.png: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGFEDropShadowElement-dom-in-attr-expected.png: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-color-attr-expected.png: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-opacity-attr-expected.png: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGFEDropShadowElement-dom-stdDeviation-attr-expected.png: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dx-prop-expected.png: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dy-prop-expected.png: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-in-prop-expected.png: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-color-prop-expected.png: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-opacity-prop-expected.png: Added.
        * platform/chromium-win/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-stdDeviation-prop-expected.png: Added.
        * platform/chromium-win/svg/filters/feDropShadow-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-21 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Fri, 22 Apr 2011 00:17:34 +0000 (00:17 +0000)]
2011-04-21  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, expectations change.

        Suppress failures possibly caused by bug 59158 on chromium win/linux:
        fast/canvas/canvas-stroke{Path,Rect}-alpha-shadow.html = TEXT

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/8774116>
ike@apple.com [Fri, 22 Apr 2011 00:10:02 +0000 (00:10 +0000)]
<rdar://problem/8774116>

Reviewed by Maciej Stachowiak.

The WebProcess sandbox should only allow access to the
parts of the Darwin cache directory needed by the Security
framework.

* WebProcess/com.apple.WebProcess.sb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/9311053>
ike@apple.com [Fri, 22 Apr 2011 00:06:10 +0000 (00:06 +0000)]
<rdar://problem/9311053>

Reviewed by Maciej Stachowiak.

The WebProcess sandbox should not allow opening arbitrary
IOKit user clients. Restrict to a whitelist required for normal
WebProcess operation, including sound and accelerated graphics.

* WebProcess/com.apple.WebProcess.sb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/9311037>
ike@apple.com [Fri, 22 Apr 2011 00:03:02 +0000 (00:03 +0000)]
<rdar://problem/9311037>

Reviewed by Maciej Stachowiak.

The WebProcess sandbox should not allow modification of the
CoreAudio component cache.

* WebProcess/com.apple.WebProcess.sb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agofix
ojan@chromium.org [Thu, 21 Apr 2011 23:58:40 +0000 (23:58 +0000)]
fix

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/9263428>
ike@apple.com [Thu, 21 Apr 2011 23:58:06 +0000 (23:58 +0000)]
<rdar://problem/9263428>

Reviewed by Maciej Stachowiak.

The WebProcess sandbox should only allow outbound networking
to remote destinations and local kernel controls.

* WebProcess/com.apple.WebProcess.sb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWhoops, change lost during merge
oliver@apple.com [Thu, 21 Apr 2011 23:54:26 +0000 (23:54 +0000)]
Whoops, change lost during merge

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-21 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Thu, 21 Apr 2011 23:49:13 +0000 (23:49 +0000)]
2011-04-21  Dirk Pranke  <dpranke@chromium.org>

        Update baselines to accomodate the change in r84506. I wonder
        how much having platform/mac in the search path hurts
        chromium-win/-linux.

        * platform/chromium-win/canvas/philip/tests/toDataURL.jpeg.alpha-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-21 Matthew Delaney <mdelaney@apple.com>
mdelaney@apple.com [Thu, 21 Apr 2011 23:44:44 +0000 (23:44 +0000)]
2011-04-21  Matthew Delaney  <mdelaney@apple.com>

        Reviewed by Simon Fraser.

        Move canvas test set-colors.html expected results out of platform/mac-leopard and into platform/mac
        This test expected result pertains to all of mac, not just leopard.
        https://bugs.webkit.org/show_bug.cgi?id=59139

        * platform/mac-leopard/fast/canvas/set-colors-expected.txt: Removed.
        * platform/mac/fast/canvas/set-colors-expected.txt: Copied from LayoutTests/platform/mac-leopard/fast/canvas/set-colors-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-21 Tony Chang <tony@chromium.org>
tony@chromium.org [Thu, 21 Apr 2011 23:36:11 +0000 (23:36 +0000)]
2011-04-21  Tony Chang  <tony@chromium.org>

        Embed checksums in more png files.  Not sure how these were missed earlier.

        * animations/missing-values-first-keyframe-expected.png:
        * animations/missing-values-last-keyframe-expected.png:
        * animations/opacity-transform-animation-expected.png:
        * animations/suspend-transform-animation-expected.png:
        * compositing/backface-visibility-expected.png:
        * compositing/checkerboard-expected.png:
        * compositing/geometry/ancestor-overflow-change-expected.png:
        * compositing/geometry/tall-page-composited-expected.png:
        * compositing/iframes/composited-iframe-scroll-expected.png:
        * compositing/iframes/iframe-content-flipping-expected.png:
        * compositing/iframes/nested-iframe-scrolling-expected.png:
        * compositing/images/direct-pdf-image-expected.png:
        * compositing/images/direct-svg-image-expected.png:
        * compositing/overflow/zero-size-overflow-expected.png:
        * compositing/reflections/backface-hidden-reflection-expected.png:
        * compositing/reflections/remove-add-reflection-expected.png:
        * compositing/tiling/constrained-layer-size-expected.png:
        * compositing/z-order/negative-z-index-expected.png:
        * transforms/3d/general/cssmatrix-3d-zoom-expected.png:
        * transforms/3d/general/matrix-with-zoom-3d-expected.png:
        * transitions/suspend-transform-transition-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-21 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Thu, 21 Apr 2011 23:29:35 +0000 (23:29 +0000)]
2011-04-21  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by NOBODY (OOPS!).

        Unreviewed, expectations change - update chromium SVG baselines
        after r84522.

        * platform/chromium/fast/dom/prototype-inheritance-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-21 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Thu, 21 Apr 2011 23:24:50 +0000 (23:24 +0000)]
2011-04-21  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r82052.
        http://trac.webkit.org/changeset/82052
        https://bugs.webkit.org/show_bug.cgi?id=59135

        New full screen api should be opt-in, not opt-out. (Requested
        by jernoble on #webkit).

        * WebView/WebPreferences.mm:
        (+[WebPreferences initialize]):
2011-04-21  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r82052.
        http://trac.webkit.org/changeset/82052
        https://bugs.webkit.org/show_bug.cgi?id=59135

        New full screen api should be opt-in, not opt-out. (Requested
        by jernoble on #webkit).

        * Shared/WebPreferencesStore.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-21 Adam Barth <abarth@webkit.org>
ojan@chromium.org [Thu, 21 Apr 2011 23:24:13 +0000 (23:24 +0000)]
2011-04-21  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        ValidateChangeLogs doesn't work on SVN
        https://bugs.webkit.org/show_bug.cgi?id=59115

        svn-create-patch lies about the diff in the working copy by moving
        ChangeLog entries to the top of the diff.  That's fine on most cases,
        but causes problems for ValidateChangeLogs, which is trying validate
        the where the ChangeLog entry appears.

        I haven't added a test for this change because I couldn't figure out
        how to write one.  The issue is more of an integration issue, which
        we're not really set up to test in our unit testing framework.  If this
        patch had worked around the output from svn-create-patch, then I could
        have tested that we behave correctly on sample svn-create-patch output,
        but, in this case, I've removed the dependency on svn-create-patch.  I
        could test that we behave correctly on "svn diff" output, but we
        already have those tests.

        * Scripts/webkitpy/tool/commands/download_unittest.py:
        * Scripts/webkitpy/tool/mocktool.py:
        * Scripts/webkitpy/tool/steps/validatechangelogs.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-21 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Thu, 21 Apr 2011 23:22:22 +0000 (23:22 +0000)]
2011-04-21  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, expectations change - update chromium SVG baselines
        after r84522.

        * platform/chromium-linux/svg/dynamic-updates/SVGFEDropShadowElement-dom-dx-attr-expected.png: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGFEDropShadowElement-dom-dy-attr-expected.png: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGFEDropShadowElement-dom-in-attr-expected.png: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-color-attr-expected.png: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-opacity-attr-expected.png: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGFEDropShadowElement-dom-stdDeviation-attr-expected.png: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dx-prop-expected.png: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dy-prop-expected.png: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-in-prop-expected.png: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-color-prop-expected.png: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-opacity-prop-expected.png: Added.
        * platform/chromium-linux/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-stdDeviation-prop-expected.png: Added.
        * platform/chromium-linux/svg/filters/feDropShadow-expected.png: Added.
        * platform/chromium-mac/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-color-attr-expected.png: Added.
        * platform/chromium-mac/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-opacity-attr-expected.png: Added.
        * platform/chromium-mac/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-color-prop-expected.png: Added.
        * platform/chromium-mac/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-opacity-prop-expected.png: Added.
        * platform/chromium-mac/svg/filters/feDropShadow-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFixed a failure seen in fast/dom/prototype-inheritance-2.html due to
ggaren@apple.com [Thu, 21 Apr 2011 23:20:34 +0000 (23:20 +0000)]
Fixed a failure seen in fast/dom/prototype-inheritance-2.html due to
wrong global object use.

Reviewed by Sam Weinig.

Source/WebCore:

* bindings/js/JSHTMLDocumentCustom.cpp:
(WebCore::JSHTMLDocument::nameGetter):
(WebCore::JSHTMLDocument::all):
* bindings/js/JSHTMLFormElementCustom.cpp:
(WebCore::JSHTMLFormElement::nameGetter): Use the right global object.

LayoutTests:

* fast/dom/prototype-inheritance-2-expected.txt: Expect success!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-21 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Thu, 21 Apr 2011 23:10:08 +0000 (23:10 +0000)]
2011-04-21  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, expectations change - flaky tests.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-21 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Thu, 21 Apr 2011 23:08:15 +0000 (23:08 +0000)]
2011-04-21  Oliver Hunt  <oliver@apple.com>

        Reviewed by Geoffrey Garen.

        Start moving to a general visitor pattern for GC traversal
        https://bugs.webkit.org/show_bug.cgi?id=59141

        This is just a rename:
            markChildren -> visitChildren
            markAggregate -> visitAggregate
            markStack -> visitor
            MarkStack -> typedef'd to SlotVisitor

        * API/JSCallbackObject.h:
        (JSC::JSCallbackObjectData::visitChildren):
        (JSC::JSCallbackObjectData::JSPrivatePropertyMap::visitChildren):
        (JSC::JSCallbackObject::visitChildren):
        * JavaScriptCore.exp:
        * bytecode/CodeBlock.cpp:
        (JSC::CodeBlock::visitStructures):
        (JSC::EvalCodeCache::visitAggregate):
        (JSC::CodeBlock::visitAggregate):
        * bytecode/CodeBlock.h:
        * bytecode/EvalCodeCache.h:
        * bytecode/Instruction.h:
        (JSC::PolymorphicAccessStructureList::visitAggregate):
        * bytecode/StructureStubInfo.cpp:
        (JSC::StructureStubInfo::visitAggregate):
        * bytecode/StructureStubInfo.h:
        * debugger/DebuggerActivation.cpp:
        (JSC::DebuggerActivation::visitChildren):
        * debugger/DebuggerActivation.h:
        * heap/HandleHeap.cpp:
        (JSC::WeakHandleOwner::isReachableFromOpaqueRoots):
        (JSC::HandleHeap::markStrongHandles):
        (JSC::HandleHeap::markWeakHandles):
        * heap/HandleHeap.h:
        * heap/HandleStack.cpp:
        (JSC::HandleStack::mark):
        * heap/HandleStack.h:
        * heap/Heap.cpp:
        (JSC::Heap::markProtectedObjects):
        (JSC::Heap::markTempSortVectors):
        (JSC::Heap::markRoots):
        * heap/Heap.h:
        * heap/MarkStack.cpp:
        (JSC::MarkStack::visitChildren):
        (JSC::MarkStack::drain):
        * heap/MarkStack.h:
        (JSC::HeapRootVisitor::HeapRootVisitor):
        (JSC::HeapRootVisitor::mark):
        (JSC::HeapRootVisitor::visitor):
        * heap/MarkedSpace.h:
        * runtime/ArgList.cpp:
        (JSC::MarkedArgumentBuffer::markLists):
        * runtime/ArgList.h:
        * runtime/Arguments.cpp:
        (JSC::Arguments::visitChildren):
        * runtime/Arguments.h:
        * runtime/Executable.cpp:
        (JSC::EvalExecutable::visitChildren):
        (JSC::ProgramExecutable::visitChildren):
        (JSC::FunctionExecutable::visitChildren):
        * runtime/Executable.h:
        * runtime/GetterSetter.cpp:
        (JSC::GetterSetter::visitChildren):
        * runtime/GetterSetter.h:
        (JSC::GetterSetter::createStructure):
        * runtime/JSAPIValueWrapper.h:
        (JSC::JSAPIValueWrapper::createStructure):
        * runtime/JSActivation.cpp:
        (JSC::JSActivation::visitChildren):
        * runtime/JSActivation.h:
        * runtime/JSArray.cpp:
        (JSC::JSArray::visitChildren):
        * runtime/JSArray.h:
        (JSC::JSArray::visitDirect):
        * runtime/JSCell.h:
        (JSC::JSCell::JSCell::visitChildren):
        * runtime/JSFunction.cpp:
        (JSC::JSFunction::visitChildren):
        * runtime/JSFunction.h:
        * runtime/JSGlobalObject.cpp:
        (JSC::visitIfNeeded):
        (JSC::JSGlobalObject::visitChildren):
        * runtime/JSGlobalObject.h:
        * runtime/JSONObject.cpp:
        * runtime/JSObject.cpp:
        (JSC::JSObject::visitChildren):
        * runtime/JSObject.h:
        (JSC::JSObject::visitDirect):
        * runtime/JSPropertyNameIterator.cpp:
        (JSC::JSPropertyNameIterator::visitChildren):
        * runtime/JSPropertyNameIterator.h:
        (JSC::JSPropertyNameIterator::createStructure):
        * runtime/JSStaticScopeObject.cpp:
        (JSC::JSStaticScopeObject::visitChildren):
        * runtime/JSStaticScopeObject.h:
        * runtime/JSTypeInfo.h:
        (JSC::TypeInfo::TypeInfo):
        (JSC::TypeInfo::overridesVisitChildren):
        * runtime/JSWrapperObject.cpp:
        (JSC::JSWrapperObject::visitChildren):
        * runtime/JSWrapperObject.h:
        * runtime/JSZombie.h:
        (JSC::JSZombie::visitChildren):
        * runtime/NativeErrorConstructor.cpp:
        (JSC::NativeErrorConstructor::visitChildren):
        * runtime/NativeErrorConstructor.h:
        * runtime/RegExpObject.cpp:
        (JSC::RegExpObject::visitChildren):
        * runtime/RegExpObject.h:
        * runtime/ScopeChain.cpp:
        (JSC::ScopeChainNode::visitChildren):
        * runtime/ScopeChain.h:
        * runtime/SmallStrings.cpp:
        (JSC::SmallStrings::visitChildren):
        * runtime/SmallStrings.h:
        * runtime/Structure.cpp:
        (JSC::Structure::Structure):
        (JSC::Structure::visitChildren):
        * runtime/Structure.h:
        * runtime/StructureChain.cpp:
        (JSC::StructureChain::visitChildren):
        * runtime/StructureChain.h:
        (JSC::StructureChain::createStructure):
2011-04-21  Oliver Hunt  <oliver@apple.com>

        Reviewed by Geoffrey Garen.

        Start moving to a general visitor pattern for GC traversal
        https://bugs.webkit.org/show_bug.cgi?id=59141

        This is just a rename:
            markChildren -> visitChildren
            markAggregate -> visitAggregate
            markStack -> visitor
            MarkStack -> typedef'd to SlotVisitor

        * UserObjectImp.cpp:
        (UserObjectImp::visitChildren):
2011-04-21  Oliver Hunt  <oliver@apple.com>

        Reviewed by Geoffrey Garen.

        Start moving to a general visitor pattern for GC traversal
        https://bugs.webkit.org/show_bug.cgi?id=59141

        This is just a rename:
            markChildren -> visitChildren
            markAggregate -> visitAggregate
            markStack -> visitor
            MarkStack -> typedef'd to SlotVisitor

        * bindings/js/JSAttrCustom.cpp:
        (WebCore::JSAttr::visitChildren):
        * bindings/js/JSAudioConstructor.cpp:
        (WebCore::constructAudio):
        * bindings/js/JSCSSRuleCustom.cpp:
        (WebCore::JSCSSRule::visitChildren):
        * bindings/js/JSCSSStyleDeclarationCustom.cpp:
        (WebCore::JSCSSStyleDeclaration::visitChildren):
        * bindings/js/JSDOMBinding.cpp:
        (WebCore::visitActiveObjectsForContext):
        (WebCore::markDOMObjectWrapper):
        * bindings/js/JSDOMBinding.h:
        * bindings/js/JSDOMGlobalObject.cpp:
        (WebCore::JSDOMGlobalObject::visitChildren):
        * bindings/js/JSDOMGlobalObject.h:
        * bindings/js/JSDOMImplementationCustom.cpp:
        (WebCore::JSDOMImplementation::visitChildren):
        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::visitChildren):
        * bindings/js/JSDOMWindowShell.cpp:
        (WebCore::JSDOMWindowShell::visitChildren):
        * bindings/js/JSDOMWindowShell.h:
        * bindings/js/JSDocumentCustom.cpp:
        (WebCore::JSDocument::visitChildren):
        * bindings/js/JSElementCustom.cpp:
        (WebCore::JSElement::visitChildren):
        * bindings/js/JSEventListener.cpp:
        (WebCore::JSEventListener::markJSFunction):
        * bindings/js/JSEventListener.h:
        * bindings/js/JSHTMLCanvasElementCustom.cpp:
        (WebCore::JSHTMLCanvasElement::visitChildren):
        * bindings/js/JSHTMLLinkElementCustom.cpp:
        (WebCore::JSHTMLLinkElement::visitChildren):
        * bindings/js/JSHTMLStyleElementCustom.cpp:
        (WebCore::JSHTMLStyleElement::visitChildren):
        * bindings/js/JSImageConstructor.cpp:
        (WebCore::constructImage):
        * bindings/js/JSJavaScriptAudioNodeCustom.cpp:
        (WebCore::JSJavaScriptAudioNode::visitChildren):
        * bindings/js/JSMessageChannelCustom.cpp:
        (WebCore::JSMessageChannel::visitChildren):
        * bindings/js/JSMessagePortCustom.cpp:
        (WebCore::JSMessagePort::visitChildren):
        * bindings/js/JSNamedNodeMapCustom.cpp:
        (WebCore::JSNamedNodeMapOwner::isReachableFromOpaqueRoots):
        (WebCore::JSNamedNodeMap::visitChildren):
        * bindings/js/JSNavigatorCustom.cpp:
        (WebCore::JSNavigator::visitChildren):
        * bindings/js/JSNodeCustom.cpp:
        (WebCore::isObservable):
        (WebCore::isReachableFromDOM):
        (WebCore::JSNodeOwner::isReachableFromOpaqueRoots):
        (WebCore::JSNode::visitChildren):
        * bindings/js/JSNodeCustom.h:
        * bindings/js/JSNodeFilterCondition.cpp:
        (WebCore::JSNodeFilterCondition::WeakOwner::isReachableFromOpaqueRoots):
        * bindings/js/JSNodeFilterCondition.h:
        * bindings/js/JSNodeFilterCustom.cpp:
        (WebCore::JSNodeFilter::visitChildren):
        * bindings/js/JSNodeIteratorCustom.cpp:
        (WebCore::JSNodeIterator::visitChildren):
        * bindings/js/JSNodeListCustom.cpp:
        (WebCore::JSNodeListOwner::isReachableFromOpaqueRoots):
        * bindings/js/JSProcessingInstructionCustom.cpp:
        (WebCore::JSProcessingInstruction::visitChildren):
        * bindings/js/JSSVGElementInstanceCustom.cpp:
        (WebCore::JSSVGElementInstance::visitChildren):
        * bindings/js/JSSharedWorkerCustom.cpp:
        (WebCore::JSSharedWorker::visitChildren):
        * bindings/js/JSStyleSheetCustom.cpp:
        (WebCore::JSStyleSheet::visitChildren):
        * bindings/js/JSTreeWalkerCustom.cpp:
        (WebCore::JSTreeWalker::visitChildren):
        * bindings/js/JSWebGLRenderingContextCustom.cpp:
        (WebCore::JSWebGLRenderingContext::visitChildren):
        * bindings/js/JSWebKitAnimationListCustom.cpp:
        (WebCore::JSWebKitAnimationList::visitChildren):
        * bindings/js/JSWorkerContextCustom.cpp:
        (WebCore::JSWorkerContext::visitChildren):
        * bindings/js/JSXMLHttpRequestCustom.cpp:
        (WebCore::JSXMLHttpRequest::visitChildren):
        * bindings/js/JSXMLHttpRequestUploadCustom.cpp:
        (WebCore::JSXMLHttpRequestUpload::visitChildren):
        * bindings/scripts/CodeGeneratorJS.pm:
        * bridge/qt/qt_instance.cpp:
        (JSC::Bindings::QtRuntimeObject::visitChildren):
        (JSC::Bindings::QtInstance::markAggregate):
        * bridge/qt/qt_instance.h:
        * bridge/qt/qt_pixmapruntime.cpp:
        * bridge/qt/qt_runtime.cpp:
        (JSC::Bindings::QtRuntimeMetaMethod::visitChildren):
        * bridge/qt/qt_runtime.h:
        * dom/EventListener.h:
        (WebCore::EventListener::visitJSFunction):
        * dom/EventTarget.h:
        (WebCore::EventTarget::visitJSEventListeners):
        * dom/Node.h:
        * dom/NodeFilterCondition.h:
        (WebCore::NodeFilterCondition::visitAggregate):
        * page/DOMWindow.h:
        * workers/WorkerContext.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-21 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 21 Apr 2011 23:07:57 +0000 (23:07 +0000)]
2011-04-21  Adam Barth  <abarth@webkit.org>

        Update test results to show that we're using ogv.  I would have
        preferred to make this test independent of which video codec we have,
        but I didn't see a way to do that.

        * platform/chromium/http/tests/security/contentSecurityPolicy/media-src-blocked-expected.txt: Added.
        * platform/chromium/media/csp-blocks-video-expected.txt: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-21 Tony Chang <tony@chromium.org>
tony@chromium.org [Thu, 21 Apr 2011 22:52:08 +0000 (22:52 +0000)]
2011-04-21  Tony Chang  <tony@chromium.org>

        Unreviewed, deleting .checksum files in platform/chromium*

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=59048
bdakin@apple.com [Thu, 21 Apr 2011 22:49:53 +0000 (22:49 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=59048
Need to track whether overlay scrollbar is currently visible and in lower-
righthand corner
-and corresponding-
<rdar://problem/9211232>

Reviewed by Dan Bernstein.

Source/WebCore:

Whenever we start a new ScrollbarPartAnimation, check if the scrollbar is vertical
and showing (alpha of 1), and if so, call setVisibleScrollerThumbRect with the
knob rect, otherwise with an empty rect. ScrollAnimatorMac has a local rect to
track this value so that it can avoid sending messages across the ChromeClient to
the UIProcess if the rect has not changed.
* platform/mac/ScrollAnimatorMac.h:
* platform/mac/ScrollAnimatorMac.mm:
(-[ScrollbarPainterDelegate setUpAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):
(WebCore::ScrollAnimatorMac::ScrollAnimatorMac):
(WebCore::ScrollAnimatorMac::setVisibleScrollerThumbRect):

Plumbing for the chrome client.
* page/ChromeClient.h:
(WebCore::ChromeClient::notifyScrollerThumbIsVisibleInRect):
* page/FrameView.cpp:
(WebCore::FrameView::setVisibleScrollerThumbRect):
* page/FrameView.h:
* platform/ScrollableArea.h:
(WebCore::ScrollableArea::setVisibleScrollerThumbRect):

New WebCoreSystemInterface function to get the knob rect.
* WebCore.exp.in:
* platform/mac/WebCoreSystemInterface.h:
* platform/mac/WebCoreSystemInterface.mm:

Source/WebKit/mac:

A new WebSystemInterface is needed for this.
* WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):

Source/WebKit2:

WebPageProxy now stores an IntRect of the scroller thumb set by WebCore through
the client.

_windowResizeMouseLocationIsInVisibleScrollerThumb tests if the parameter point is
inside the cached scroller thumb rect.
* UIProcess/API/mac/WKView.mm:
(-[WKView _windowResizeMouseLocationIsInVisibleScrollerThumb:]):

Client work to cache the rect.
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::WebPageProxy):
(WebKit::WebPageProxy::close):
(WebKit::WebPageProxy::processDidCrash):
(WebKit::WebPageProxy::notifyScrollerThumbIsVisibleInRect):
* UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::visibleScrollerThumbRect):
* UIProcess/WebPageProxy.messages.in:
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::notifyScrollerThumbIsVisibleInRect):
* WebProcess/WebCoreSupport/WebChromeClient.h:

New WebSystemInterface is needed by WebCore for this.
* WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-21 Sheriff Bot <webkit.review.bot@gmail.com>
adamk@chromium.org [Thu, 21 Apr 2011 22:13:46 +0000 (22:13 +0000)]
2011-04-21  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r84548.
        http://trac.webkit.org/changeset/84548
        https://bugs.webkit.org/show_bug.cgi?id=59144

        Broke chromium-win build (Requested by aklein on #webkit).

        * wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-21 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 21 Apr 2011 22:00:54 +0000 (22:00 +0000)]
2011-04-21  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        ValidateChangeLogs doesn't work on SVN
        https://bugs.webkit.org/show_bug.cgi?id=59115

        svn-create-patch lies about the diff in the working copy by moving
        ChangeLog entries to the top of the diff.  That's fine on most cases,
        but causes problems for ValidateChangeLogs, which is trying validate
        the where the ChangeLog entry appears.

        I haven't added a test for this change because I couldn't figure out
        how to write one.  The issue is more of an integration issue, which
        we're not really set up to test in our unit testing framework.  If this
        patch had worked around the output from svn-create-patch, then I could
        have tested that we behave correctly on sample svn-create-patch output,
        but, in this case, I've removed the dependency on svn-create-patch.  I
        could test that we behave correctly on "svn diff" output, but we
        already have those tests.

        * Scripts/webkitpy/tool/commands/download_unittest.py:
        * Scripts/webkitpy/tool/mocktool.py:
        * Scripts/webkitpy/tool/steps/validatechangelogs.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-21 Adam Klein <adamk@chromium.org>
adamk@chromium.org [Thu, 21 Apr 2011 21:39:46 +0000 (21:39 +0000)]
2011-04-21  Adam Klein  <adamk@chromium.org>

        Reviewed by David Levin.

        [fileapi] Worker File API calls that create Blobs fail in debug builds due to random number generator thread assertion
        https://bugs.webkit.org/show_bug.cgi?id=55728

        Enable WTF_MULTIPLE_THREADS for Chromium.

        * wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-21 Tony Chang <tony@chromium.org>
tony@chromium.org [Thu, 21 Apr 2011 21:28:05 +0000 (21:28 +0000)]
2011-04-21  Tony Chang  <tony@chromium.org>

        Unreviewed, embedding checksums in png files not in LayoutTests/platform.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-21 Nat Duca <nduca@chromium.org>
commit-queue@webkit.org [Thu, 21 Apr 2011 21:22:27 +0000 (21:22 +0000)]
2011-04-21  Nat Duca  <nduca@chromium.org>

        Reviewed by James Robinson.

        [chromium] Fix artefacts in compositor HUD when resizing
        https://bugs.webkit.org/show_bug.cgi?id=58969

        HUD was using the tiler program and not setting the texture
        transform. The HUD would thus draw with a texture transform based
        on the last tile drawn, leading sometimes to distortion.

        * platform/graphics/chromium/LayerRendererChromium.cpp:
        (WebCore::LayerRendererChromium::initializeSharedObjects):
        (WebCore::LayerRendererChromium::cleanupSharedObjects):
        * platform/graphics/chromium/LayerRendererChromium.h:
        (WebCore::LayerRendererChromium::headsUpDisplayProgram):
        * platform/graphics/chromium/cc/CCHeadsUpDisplay.cpp:
        (WebCore::CCHeadsUpDisplay::draw):
        * platform/graphics/chromium/cc/CCHeadsUpDisplay.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-21 Mike Reed <reed@google.com>
commit-queue@webkit.org [Thu, 21 Apr 2011 21:09:16 +0000 (21:09 +0000)]
2011-04-21  Mike Reed  <reed@google.com>

        Reviewed by Kenneth Russell.

        only return false if we actually in a skia-gpu accelerated canvas for isNativeFontRenderingAllowed
        https://bugs.webkit.org/show_bug.cgi?id=59024

        No new tests. The bug (and fix) depend on enabling SKIA_GPU. When that is enabled, the bug
        shows all text w/o lcd rendering. This is a regression from a recent CL when we switch to
        calling skia::SupportsPlatformPaint. This CL fixes that.
        There should be no change for the default builds when SKIA_GPU is not enabled.

        * platform/graphics/skia/PlatformContextSkia.cpp:
        (WebCore::PlatformContextSkia::isNativeFontRenderingAllowed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-21 Tony Chang <tony@chromium.org>
tony@chromium.org [Thu, 21 Apr 2011 21:08:49 +0000 (21:08 +0000)]
2011-04-21  Tony Chang  <tony@chromium.org>

        Reviewed by Ojan Vafai.

        old-run-webkit-tests/new-run-webkit-tests shouldn't read or write .checksum files
        https://bugs.webkit.org/show_bug.cgi?id=58402

        * Scripts/old-run-webkit-tests: Don't read or write .checksum files.
        * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py: Don't write .checksum files.
        * Scripts/webkitpy/layout_tests/port/base.py: Don't read .checksum files.
        * Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
        * Scripts/webkitpy/layout_tests/port/test.py: Update passing pngs to include a checksum.
        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-21 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Thu, 21 Apr 2011 20:44:41 +0000 (20:44 +0000)]
2011-04-21  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Tony Chang.

        only expand visible rows
        https://bugs.webkit.org/show_bug.cgi?id=59130

        For the chromium port, where there are many expected failures,
        expanding all of them is quite slow. Only expand the visible ones.
        This makes the default case. Also, make the expanding async to
        avoid totally killing the process.

        * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
        * Scripts/webkitpy/layout_tests/layout_package/json_results_test.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-21 Adrienne Walker <enne@google.com>
enne@google.com [Thu, 21 Apr 2011 20:19:36 +0000 (20:19 +0000)]
2011-04-21  Adrienne Walker  <enne@google.com>

        Reviewed by James Robinson.

        [chromium] Don't upload partially drawn tiles in the compositor
        https://bugs.webkit.org/show_bug.cgi?id=59112

        Use the same set of tiles for painting as is used for updating.
        Before, a larger set of tiles were being uploaded, causing some to
        only be partially undirtied because they were not fully painted.
        As tiles are clear their dirty rect after being unpainted, this caused
        artifacts to appear when scrolling.

        Unfortunately, no layout test can test this behavior yet because
        scrolling invalidations are done differently in test shell.

        * platform/graphics/chromium/ImageLayerChromium.cpp:
        (WebCore::ImageLayerChromium::updateCompositorResources):
        * platform/graphics/chromium/LayerTilerChromium.cpp:
        (WebCore::LayerTilerChromium::update):
        (WebCore::LayerTilerChromium::uploadCanvas):
        (WebCore::LayerTilerChromium::updateFromPixels):
        * platform/graphics/chromium/LayerTilerChromium.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-21 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Thu, 21 Apr 2011 19:49:52 +0000 (19:49 +0000)]
2011-04-21  Dirk Schulze  <krit@webkit.org>

        Uneviewed rebaseline of win.

        SVG feDropShadow implementation of SVG Filters 1.2
        https://bugs.webkit.org/show_bug.cgi?id=52513

        * platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
        * platform/win/fast/dom/prototype-inheritance-2-expected.txt:
        * platform/win/fast/dom/prototype-inheritance-expected.txt:
        * platform/win/fast/js/global-constructors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-21 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Thu, 21 Apr 2011 19:35:55 +0000 (19:35 +0000)]
2011-04-21  Martin Robinson  <mrobinson@igalia.com>

        [GTK] DRT: implement eventSender.scalePageBy
        https://bugs.webkit.org/show_bug.cgi?id=59082

        Rolling out r84507 since it broke many GTK+ tests.

        * platform/gtk/Skipped:
        * platform/gtk/fast/repaint/scale-page-shrink-expected.checksum: Removed.
        * platform/gtk/fast/repaint/scale-page-shrink-expected.png: Removed.
        * platform/gtk/fast/repaint/scale-page-shrink-expected.txt: Removed.
2011-04-21  Martin Robinson  <mrobinson@igalia.com>

        [GTK] DRT: implement eventSender.scalePageBy
        https://bugs.webkit.org/show_bug.cgi?id=59082

        Rolling out r84507 since it broke many GTK+ tests.

        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
        * WebCoreSupport/DumpRenderTreeSupportGtk.h:
2011-04-21  Martin Robinson  <mrobinson@igalia.com>

        [GTK] DRT: implement eventSender.scalePageBy
        https://bugs.webkit.org/show_bug.cgi?id=59082

        Rolling out r84507 since it broke many GTK+ tests.

        * DumpRenderTree/gtk/EventSender.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-21 Andreas Kling <andreas.kling@nokia.com>
andreas.kling@nokia.com [Thu, 21 Apr 2011 19:31:03 +0000 (19:31 +0000)]
2011-04-21  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt][WK2] Emit QWKPage::urlChanged() when navigating within the same document.
        https://bugs.webkit.org/show_bug.cgi?id=59044

        Hook up the didSameDocumentNavigationForFrame callback to QWKPage::urlChanged().

        * UIProcess/API/qt/ClientImpl.cpp:
        (qt_wk_didSameDocumentNavigationForFrame):
        * UIProcess/API/qt/ClientImpl.h:
        * UIProcess/API/qt/qwkpage.cpp:
        (QWKPage::QWKPage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-21 Ben Taylor <bentaylor.solx86@gmail.com>
commit-queue@webkit.org [Thu, 21 Apr 2011 19:27:29 +0000 (19:27 +0000)]
2011-04-21  Ben Taylor  <bentaylor.solx86@gmail.com>

        Reviewed by Alexey Proskuryakov.

        https://bugs.webkit.org/show_bug.cgi?id=58725

        Fix a compile issue on Solaris 10 with Sun Studio 12,
        ternary operators (?:) must have the same types

        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::popArchiveForSubframe):
        * loader/archive/ArchiveFactory.cpp:
        (WebCore::ArchiveFactory::create):
        * loader/icon/IconDatabase.cpp:
        (WebCore::IconDatabase::setIconDataForIconURL):
        * page/animation/AnimationBase.cpp:
        (WebCore::blendFunc):
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::updateScrollCornerStyle):
        (WebCore::RenderLayer::updateResizerStyle):
        * rendering/RenderScrollbar.cpp:
        (WebCore::RenderScrollbar::updateScrollbarPart):
        * rendering/RenderTextFragment.cpp:
        (WebCore::RenderTextFragment::RenderTextFragment):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-21 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Thu, 21 Apr 2011 19:22:44 +0000 (19:22 +0000)]
2011-04-21  Dirk Schulze  <krit@webkit.org>

        Unreviewed rebaseline.

        SVG feDropShadow implementation of SVG Filters 1.2
        https://bugs.webkit.org/show_bug.cgi?id=52513

        * fast/dom/Window/window-properties-expected.txt:
        * fast/dom/Window/window-property-descriptors-expected.txt:
        * fast/dom/prototype-inheritance-2-expected.txt:
        * fast/dom/prototype-inheritance-expected.txt:
        * fast/js/global-constructors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Unreviewed. Update expected files after r84522.
ossy@webkit.org [Thu, 21 Apr 2011 19:15:30 +0000 (19:15 +0000)]
[Qt] Unreviewed. Update expected files after r84522.

* platform/qt/fast/dom/Window/window-properties-expected.txt:
* platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/qt/fast/dom/prototype-inheritance-expected.txt:
* platform/qt/fast/js/global-constructors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-21 Mike Reed <reed@google.com>
commit-queue@webkit.org [Thu, 21 Apr 2011 19:09:37 +0000 (19:09 +0000)]
2011-04-21  Mike Reed  <reed@google.com>

        Reviewed by Kenneth Russell.

        [chromium, win] Multiple failures of shadow rendering layout tests
        https://bugs.webkit.org/show_bug.cgi?id=58772

        No new tests. This CL fixes a regression in the following tests
        fast/multicol/shadow-breaking.html
        fast/repaint/shadow-multiple-horizontal.html
        fast/repaint/shadow-multiple-strict-horizontal.html
        fast/repaint/shadow-multiple-strict-vertical.html
        fast/repaint/shadow-multiple-vertical.html
        fast/text/shadow-translucent-fill.html
        fast/transforms/shadows.html
        svg/css/group-with-shadow.svg
        svg/css/shadow-changes.svg
        svg/css/text-shadow-multiple.xhtml
        transitions/svg-text-shadow-transition.html
        svg/css/composite-shadow-text.svg

        * platform/graphics/skia/GraphicsContextSkia.cpp:
        (WebCore::GraphicsContext::setPlatformShadow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-21 Sam Weinig <sam@webkit.org>
weinig@apple.com [Thu, 21 Apr 2011 19:08:53 +0000 (19:08 +0000)]
2011-04-21  Sam Weinig  <sam@webkit.org>

        Reviewed by Simon Fraser.

        Add way to garbage collect between each test when running layout tests
        https://bugs.webkit.org/show_bug.cgi?id=59126

        * DumpRenderTree/mac/DumpRenderTree.mm:
        (initializeGlobalsFromCommandLineOptions):
        (runTest):
        * Scripts/old-run-webkit-tests:
        * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
        (WTR::InjectedBundle::didReceiveMessage):
        * WebKitTestRunner/TestController.cpp:
        (WTR::TestController::TestController):
        (WTR::TestController::initialize):
        (WTR::TestController::resetStateToConsistentValues):
        * WebKitTestRunner/TestController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-21 Roland Steiner <rolandsteiner@chromium.org>
rolandsteiner@chromium.org [Thu, 21 Apr 2011 19:01:56 +0000 (19:01 +0000)]
2011-04-21  Roland Steiner  <rolandsteiner@chromium.org>

        Unreviewed: skip tests on Windows.

        fast/dom/shadow/layout-tests-can-access-shadow.html is failing on Windows
        https://bugs.webkit.org/show_bug.cgi?id=59081

        Skip all tests in fast/dom/shadow on Windows.
        (shadowRoot accessor is not implemented on Windows yet)

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-21 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Thu, 21 Apr 2011 18:56:16 +0000 (18:56 +0000)]
2011-04-21  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, expectations change.

        Roll in downstream failures as of Chromium r82532.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTry to fix the Qt build.
ggaren@apple.com [Thu, 21 Apr 2011 18:46:41 +0000 (18:46 +0000)]
Try to fix the Qt build.

* UseJSC.cmake:
* WebCore.pro: Use correct file name.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-21 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Thu, 21 Apr 2011 18:45:07 +0000 (18:45 +0000)]
2011-04-21  Dirk Schulze  <krit@webkit.org>

        Unreviewed Qt build fix.

        SVG feDropShadow implementation of SVG Filters 1.2
        https://bugs.webkit.org/show_bug.cgi?id=52513

        * CodeGenerators.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-21 Adrienne Walker <enne@google.com>
enne@google.com [Thu, 21 Apr 2011 18:39:17 +0000 (18:39 +0000)]
2011-04-21  Adrienne Walker  <enne@google.com>

        Reviewed by James Robinson.

        [chromium] Clamp dirty regions on content layers to layer bounds
        https://bugs.webkit.org/show_bug.cgi?id=58933

        This prevents garbage being rendered when layers are resized and a
        previous invalidation (now off-layer) is no longer valid.

        * platform/graphics/chromium/ContentLayerChromium.cpp:
        (WebCore::ContentLayerChromium::paintContentsIfDirty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-21 Roland Steiner <rolandsteiner@chromium.org>
rolandsteiner@chromium.org [Thu, 21 Apr 2011 18:32:15 +0000 (18:32 +0000)]
2011-04-21  Roland Steiner  <rolandsteiner@chromium.org>

        Reviewed by Kent Tamura.

        Bug 59012 - Shadows should be imported along with their host nodes
        https://bugs.webkit.org/show_bug.cgi?id=59012

        Verify that the shadow of a bound element is imported along with the element.

        * fast/dom/shadow/import-shadowroot-expected.txt: Added.
        * fast/dom/shadow/import-shadowroot.html: Added.
2011-04-21  Roland Steiner  <rolandsteiner@chromium.org>

        Reviewed by Kent Tamura.

        Bug 59012 - Shadows should be imported along with their host nodes
        https://bugs.webkit.org/show_bug.cgi?id=59012

        Copy the shadow tree of an element (even on a shallow copy!).

        Test: fast/dom/shadow/import-shadowroot.html

        * dom/Element.cpp:
        (WebCore::Element::copyNonAttributeProperties):
        * dom/Element.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-20 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Thu, 21 Apr 2011 18:29:12 +0000 (18:29 +0000)]
2011-04-20  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        Removed a use of markDOMObjectWrapper: CSS Object Model
        https://bugs.webkit.org/show_bug.cgi?id=59057

        This is 24 hours of my life I will never get back. Thank you, W3C.

        * GNUmakefile.list.am:
        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj: Build!

        * bindings/js/JSCSSFontFaceRuleCustom.cpp:
        * bindings/js/JSCSSImportRuleCustom.cpp:
        * bindings/js/JSCSSMediaRuleCustom.cpp:
        * bindings/js/JSCSSPageRuleCustom.cpp:
        * bindings/js/JSCSSRuleCustom.cpp:
        (WebCore::JSCSSRuleOwner::isReachableFromOpaqueRoots):
        (WebCore::JSCSSRuleOwner::finalize):
        (WebCore::wrapperOwner):
        (WebCore::wrapperContext):
        (WebCore::JSCSSRule::markChildren):
        * bindings/js/JSCSSRuleListCustom.cpp:
        (WebCore::JSCSSRuleListOwner::isReachableFromOpaqueRoots):
        (WebCore::JSCSSRuleListOwner::finalize):
        (WebCore::wrapperOwner):
        (WebCore::wrapperContext):
        (WebCore::toJS):
        * bindings/js/JSCSSStyleDeclarationCustom.cpp:
        (WebCore::JSCSSStyleDeclarationOwner::isReachableFromOpaqueRoots):
        (WebCore::JSCSSStyleDeclarationOwner::finalize):
        (WebCore::wrapperOwner):
        (WebCore::wrapperContext):
        (WebCore::JSCSSStyleDeclaration::markChildren): Removed custom mark functions,
        and replaced with use of the opaque roots system. This has the nice benefit
        of allowing us to eagerly recycle far more CSS wrappers and their associated
        DOM wrappers.

        (WebCore::JSCSSStyleDeclaration::getPropertyCSSValue): Made this function
        custom because it must maintain the sorrowful invariant that primitive
        values can be mapped back to objects that are reachable through the DOM.
        We maintain this invariant through an external hash table because
        making all primitive values bigger would be a too-large memory use
        penalty. Luckily, nobody uses this feature, so the cost of the hash table
        is no big deal.

        (WebCore::toJS): We need a custom toJS so we can specify our own WeakHandleOwner.

        * bindings/js/JSCSSStyleRuleCustom.cpp: Removed custom mark, as above.

        * bindings/js/JSCSSValueCustom.cpp:
        (WebCore::cssValueRoots):
        (WebCore::JSCSSValueOwner::isReachableFromOpaqueRoots):
        (WebCore::JSCSSValueOwner::finalize):
        (WebCore::wrapperOwner):
        (WebCore::wrapperContext): Use the opaque roots system. Piggy-back on
        the external hash table filled by JSCSSStyleDeclaration::getPropertyCSSValue.

        * bindings/js/JSDocumentCustom.cpp:
        (WebCore::JSDocument::markChildren): No need to mark our stylesheet list,
        since all style-related objects can use our opaque root to determine
        liveness.

        * bindings/js/JSMediaListCustom.cpp: Added.
        (WebCore::JSMediaListOwner::isReachableFromOpaqueRoots):
        (WebCore::JSMediaListOwner::finalize):
        (WebCore::wrapperOwner):
        (WebCore::wrapperContext):
        (WebCore::toJS): Use the opaque roots system.

        * bindings/js/JSNodeCustom.h:
        (WebCore::root): Added helpers for computing style-related roots.

        * bindings/js/JSStyleSheetCustom.cpp:
        (WebCore::JSStyleSheetOwner::isReachableFromOpaqueRoots):
        (WebCore::JSStyleSheetOwner::finalize):
        (WebCore::wrapperOwner):
        (WebCore::wrapperContext):
        (WebCore::JSStyleSheet::markChildren): Use the opaque roots system instead
        of direct marking.

        * bindings/js/JSStyleSheetListCustom.cpp:
        (WebCore::JSStyleSheetListOwner::isReachableFromOpaqueRoots):
        (WebCore::JSStyleSheetListOwner::finalize):
        (WebCore::wrapperOwner):
        (WebCore::wrapperContext):
        (WebCore::toJS): Ditto.

        * bindings/js/JSWebKitCSSKeyframeRuleCustom.cpp:
        * bindings/js/JSWebKitCSSKeyframesRuleCustom.cpp:
        * css/CSSFontFaceRule.idl:
        * css/CSSImportRule.idl: No more custom mark, since we use the opaque
        roots system instead.

        * css/CSSMediaRule.cpp:
        (WebCore::CSSMediaRule::CSSMediaRule): Fixed a bug where a media rule
        would incorrectly have no parent, since this got in the way of correctly
        computing the media rule's root.

        * css/CSSMediaRule.idl:
        * css/CSSPageRule.idl:
        * css/CSSRuleList.idl:
        * css/CSSStyleDeclaration.idl:
        * css/CSSStyleRule.idl:
        * css/MediaList.idl: Match behavior changes above.

        * css/StyleBase.cpp:
        (WebCore::StyleBase::node): Helper function for computing roots of the
        style system. This object model is pretty weird and not very well factored,
        but I'm pretty sure this covers all the relevant cases.

        * css/StyleBase.h:
        * css/StyleSheetList.idl:
        * css/WebKitCSSKeyframeRule.idl:
        * css/WebKitCSSKeyframesRule.idl: Updated to match the behavior changes above.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Maciej Stachowiak.
ap@apple.com [Thu, 21 Apr 2011 18:29:00 +0000 (18:29 +0000)]
    Reviewed by Maciej Stachowiak.

        WebKit2: Unconfirmed inline input session persists after reload
        https://bugs.webkit.org/show_bug.cgi?id=59054
        <rdar://problem/9291086>

        Makes the inline input get properly confirmed or discarded when changing selection,
        navigating to another page, focusing another view in the window, or after a web process
        crash.

        * Shared/EditorState.h: (WebKit::EditorState::EditorState):
        * WebProcess/WebPage/WebPage.cpp: (WebKit::WebPage::editorState):
        Added a variable that Editor sets while processing input method calls. We don't want
        selection changes caused by -setMarkedText: discard the composition!

        * UIProcess/PageClient.h:
        * UIProcess/API/mac/PageClientImpl.h:
        * UIProcess/API/mac/PageClientImpl.mm:
        (WebKit::PageClientImpl::updateTextInputState):
        (WebKit::PageClientImpl::resetTextInputState):
        Extended updateSecureInputState() to potentially confirm the current inline input session.
        Added resetTextInputState, which is to be called when we get out of the current web page.

        * UIProcess/API/mac/WKView.mm:
        (-[WKView resignFirstResponder]): Just call _resetTextInputState instead of dealing with
        input state here.
        (-[WKView _updateSecureInputState]): Use _isFocused to make the code simpler.
        (-[WKView _updateTextInputStateIncludingSecureInputState:]): Confirm the current inline
        input session if selection changed for any other reason but an input method changing the
        composition. We will want to do other work here, like dismissing a dictionary pop-up,
        updating a font panel etc.
        (-[WKView _resetTextInputState]): Added. We don't want secure text input persist after
        navigations, crashes an such, and we also don't want input methods to remember inline input
        state. Relying on selection changed notifications is fragile and insufficient.

        * UIProcess/API/mac/WKViewInternal.h: Added internal functions to keep the build unbroken.

        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::didCommitLoadForFrame): This is the best chance we have to reset input
        state for a new page. This doesn't work well for cached page loads, but WK1 is quite broken
        in that case, too.
        (WebKit::WebPageProxy::editorStateChanged): Moved some logic up to the client, since the
        function now does much more than before.

        * UIProcess/WebPageProxy.h:
        * UIProcess/mac/WebPageProxyMac.mm: (WebKit::WebPageProxy::confirmCompositionWithoutDisturbingSelection):
        * WebProcess/WebPage/WebPage.h:
        * WebProcess/WebPage/WebPage.messages.in:
        * WebProcess/WebPage/mac/WebPageMac.mm: (WebKit::WebPage::confirmCompositionWithoutDisturbingSelection):
        Added confirmCompositionWithoutDisturbingSelection(). When we confirm the composition due
        to selection change, we obvisouly don't want the selection to move back.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-21 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Thu, 21 Apr 2011 18:28:55 +0000 (18:28 +0000)]
2011-04-21  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Mihai Parparita.

        fix another innocuous JS error in expand/collapseAllExpectations
        https://bugs.webkit.org/show_bug.cgi?id=59122

        * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
        * Scripts/webkitpy/layout_tests/layout_package/json_results_test.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-21 Sam Weinig <sam@webkit.org>
weinig@apple.com [Thu, 21 Apr 2011 18:19:42 +0000 (18:19 +0000)]
2011-04-21  Sam Weinig  <sam@webkit.org>

        Reviewed by Simon Fraser.

        Remove warnings from DrawingAreaImpl and related classes
        https://bugs.webkit.org/show_bug.cgi?id=59120

        DrawingAreaImpl is mature enough for others to adopt. Remove warnings.

        * UIProcess/BackingStore.cpp:
        * UIProcess/DrawingAreaProxyImpl.cpp:
        * WebProcess/WebPage/DrawingAreaImpl.cpp:
        * WebProcess/WebPage/LayerTreeHost.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-21 Sam Weinig <sam@webkit.org>
weinig@apple.com [Thu, 21 Apr 2011 17:57:36 +0000 (17:57 +0000)]
2011-04-21  Sam Weinig  <sam@webkit.org>

        Reviewed by Simon Fraser.

        Deploy GraphicsContextStateSaver in WebKit2
        https://bugs.webkit.org/show_bug.cgi?id=59116

        * UIProcess/FindIndicator.cpp:
        (WebKit::FindIndicator::draw):
        * WebProcess/Plugins/PluginView.cpp:
        (WebKit::PluginView::paint):
        * WebProcess/WebPage/FindController.cpp:
        (WebKit::FindController::drawRect):
        * WebProcess/WebPage/PageOverlay.cpp:
        (WebKit::PageOverlay::drawRect):
        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::drawRect):
        (WebKit::WebPage::drawPageOverlay):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-21 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Thu, 21 Apr 2011 17:56:28 +0000 (17:56 +0000)]
2011-04-21  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        SVG feDropShadow implementation of SVG Filters 1.2
        https://bugs.webkit.org/show_bug.cgi?id=52513

        Added dynamic update tests for FEDropShadow as well as a basic pixel test.

        * platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-dom-dx-attr-expected.checksum: Added.
        * platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-dom-dx-attr-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-dom-dy-attr-expected.checksum: Added.
        * platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-dom-dy-attr-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-dom-in-attr-expected.checksum: Added.
        * platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-dom-in-attr-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-color-attr-expected.checksum: Added.
        * platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-color-attr-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-opacity-attr-expected.checksum: Added.
        * platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-opacity-attr-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-dom-stdDeviation-attr-expected.checksum: Added.
        * platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-dom-stdDeviation-attr-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dx-prop-expected.checksum: Added.
        * platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dx-prop-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dy-prop-expected.checksum: Added.
        * platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dy-prop-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-in-prop-expected.checksum: Added.
        * platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-in-prop-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-color-prop-expected.checksum: Added.
        * platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-color-prop-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-opacity-prop-expected.checksum: Added.
        * platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-opacity-prop-expected.png: Added.
        * platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-stdDeviation-prop-expected.checksum: Added.
        * platform/mac/svg/dynamic-updates/SVGFEDropShadowElement-svgdom-stdDeviation-prop-expected.png: Added.
        * platform/mac/svg/filters/feDropShadow-expected.checksum: Added.
        * platform/mac/svg/filters/feDropShadow-expected.png: Added.
        * platform/mac/svg/filters/feDropShadow-expected.txt: Added.
        * svg/dynamic-updates/SVGFEDropShadowElement-dom-dx-attr-expected.txt: Added.
        * svg/dynamic-updates/SVGFEDropShadowElement-dom-dx-attr.html: Added.
        * svg/dynamic-updates/SVGFEDropShadowElement-dom-dy-attr-expected.txt: Added.
        * svg/dynamic-updates/SVGFEDropShadowElement-dom-dy-attr.html: Added.
        * svg/dynamic-updates/SVGFEDropShadowElement-dom-in-attr-expected.txt: Added.
        * svg/dynamic-updates/SVGFEDropShadowElement-dom-in-attr.html: Added.
        * svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-color-attr-expected.txt: Added.
        * svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-color-attr.html: Added.
        * svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-opacity-attr-expected.txt: Added.
        * svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-opacity-attr.html: Added.
        * svg/dynamic-updates/SVGFEDropShadowElement-dom-stdDeviation-attr-expected.txt: Added.
        * svg/dynamic-updates/SVGFEDropShadowElement-dom-stdDeviation-attr.html: Added.
        * svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dx-prop-expected.txt: Added.
        * svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dx-prop.html: Added.
        * svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dy-prop-expected.txt: Added.
        * svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dy-prop.html: Added.
        * svg/dynamic-updates/SVGFEDropShadowElement-svgdom-in-prop-expected.txt: Added.
        * svg/dynamic-updates/SVGFEDropShadowElement-svgdom-in-prop.html: Added.
        * svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-color-prop-expected.txt: Added.
        * svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-color-prop.html: Added.
        * svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-opacity-prop-expected.txt: Added.
        * svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-opacity-prop.html: Added.
        * svg/dynamic-updates/SVGFEDropShadowElement-svgdom-stdDeviation-prop-expected.txt: Added.
        * svg/dynamic-updates/SVGFEDropShadowElement-svgdom-stdDeviation-prop.html: Added.
        * svg/dynamic-updates/SVGFETurbulenceElement-svgdom-numOctaves-prop.html:
        * svg/dynamic-updates/SVGFETurbulenceElement-svgdom-seed-prop.html:
        * svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop.html:
        * svg/dynamic-updates/SVGFETurbulenceElement-svgdom-type-prop.html:
        * svg/dynamic-updates/script-tests/SVGFEDropShadowElement-dom-dx-attr.js: Added.
        (executeTest):
        * svg/dynamic-updates/script-tests/SVGFEDropShadowElement-dom-dy-attr.js: Added.
        (executeTest):
        * svg/dynamic-updates/script-tests/SVGFEDropShadowElement-dom-in-attr.js: Added.
        (executeTest):
        * svg/dynamic-updates/script-tests/SVGFEDropShadowElement-dom-shadow-color-attr.js: Added.
        (executeTest):
        * svg/dynamic-updates/script-tests/SVGFEDropShadowElement-dom-shadow-opacity-attr.js: Added.
        (executeTest):
        * svg/dynamic-updates/script-tests/SVGFEDropShadowElement-dom-stdDeviation-attr.js: Added.
        (executeTest):
        * svg/dynamic-updates/script-tests/SVGFEDropShadowElement-svgdom-dx-prop.js: Added.
        (executeTest):
        * svg/dynamic-updates/script-tests/SVGFEDropShadowElement-svgdom-dy-prop.js: Added.
        (executeTest):
        * svg/dynamic-updates/script-tests/SVGFEDropShadowElement-svgdom-in-prop.js: Added.
        (executeTest):
        * svg/dynamic-updates/script-tests/SVGFEDropShadowElement-svgdom-shadow-color-prop.js: Added.
        (executeTest):
        * svg/dynamic-updates/script-tests/SVGFEDropShadowElement-svgdom-shadow-opacity-prop.js: Added.
        (executeTest):
        * svg/dynamic-updates/script-tests/SVGFEDropShadowElement-svgdom-stdDeviation-prop.js: Added.
        (executeTest):
        * svg/filters/feDropShadow.svg: Added.
2011-04-21  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        SVG feDropShadow implementation of SVG Filters 1.2
        https://bugs.webkit.org/show_bug.cgi?id=52513

        * MigrateHeaders.make:
2011-04-21  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        SVG feDropShadow implementation of SVG Filters 1.2
        https://bugs.webkit.org/show_bug.cgi?id=52513

        This is the implementation of feDropShadow, a shorthand filter and a combination of feGaussianBlur,
        feOffset, feFlood and feComposite to create a drop shadow of an input effect.
        Creating this new filter effect makes it possible to optimize the often used workflow. ShadowBlur, with its
        fast blurring algorithm, is used to blur the shadow and composite operators are responsible for combining the
        source with different colored shadows.
        Shadow color and opacity can be set with the properties flood-color and flood-opacity.

        Tests: svg/dynamic-updates/SVGFEDropShadowElement-dom-dx-attr.html
               svg/dynamic-updates/SVGFEDropShadowElement-dom-dy-attr.html
               svg/dynamic-updates/SVGFEDropShadowElement-dom-in-attr.html
               svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-color-attr.html
               svg/dynamic-updates/SVGFEDropShadowElement-dom-shadow-opacity-attr.html
               svg/dynamic-updates/SVGFEDropShadowElement-dom-stdDeviation-attr.html
               svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dx-prop.html
               svg/dynamic-updates/SVGFEDropShadowElement-svgdom-dy-prop.html
               svg/dynamic-updates/SVGFEDropShadowElement-svgdom-in-prop.html
               svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-color-prop.html
               svg/dynamic-updates/SVGFEDropShadowElement-svgdom-shadow-opacity-prop.html
               svg/dynamic-updates/SVGFEDropShadowElement-svgdom-stdDeviation-prop.html
               svg/filters/feDropShadow.svg

        * Android.mk:
        * CMakeLists.txt:
        * DerivedSources.cpp:
        * DerivedSources.make:
        * GNUmakefile.list.am:
        * WebCore.exp.in:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/objc/DOM.mm:
        (WebCore::createElementClassMap):
        * bindings/objc/DOMSVG.h:
        * page/DOMWindow.idl:
        * platform/graphics/ShadowBlur.cpp: Added missing copyright after r84410.
        * platform/graphics/ShadowBlur.h: Made blurLayerImage public.
        * platform/graphics/filters/FEDropShadow.cpp: Added.
        (WebCore::FEDropShadow::FEDropShadow):
        (WebCore::FEDropShadow::create):
        (WebCore::FEDropShadow::determineAbsolutePaintRect):
        (WebCore::FEDropShadow::apply):
        (WebCore::FEDropShadow::dump):
        (WebCore::FEDropShadow::externalRepresentation):
        * platform/graphics/filters/FEDropShadow.h: Added.
        (WebCore::FEDropShadow::stdDeviationX):
        (WebCore::FEDropShadow::setStdDeviationX):
        (WebCore::FEDropShadow::stdDeviationY):
        (WebCore::FEDropShadow::setStdDeviationY):
        (WebCore::FEDropShadow::dx):
        (WebCore::FEDropShadow::setDx):
        (WebCore::FEDropShadow::dy):
        (WebCore::FEDropShadow::setDy):
        (WebCore::FEDropShadow::shadowColor):
        (WebCore::FEDropShadow::setShadowColor):
        (WebCore::FEDropShadow::shadowOpacity):
        (WebCore::FEDropShadow::setShadowOpacity):
        * platform/graphics/filters/FEGaussianBlur.cpp:
        (WebCore::FEGaussianBlur::calculateKernelSize): Make kernel calculations accessible for feDropShadow.
        * platform/graphics/filters/FEGaussianBlur.h:
        * svg/SVGAllInOne.cpp:
        * svg/SVGFEDropShadowElement.cpp: Added.
        (WebCore::SVGFEDropShadowElement::SVGFEDropShadowElement):
        (WebCore::SVGFEDropShadowElement::create):
        (WebCore::SVGFEDropShadowElement::stdDeviationXIdentifier):
        (WebCore::SVGFEDropShadowElement::stdDeviationYIdentifier):
        (WebCore::SVGFEDropShadowElement::setStdDeviation):
        (WebCore::SVGFEDropShadowElement::parseMappedAttribute):
        (WebCore::SVGFEDropShadowElement::svgAttributeChanged):
        (WebCore::SVGFEDropShadowElement::synchronizeProperty):
        (WebCore::SVGFEDropShadowElement::build):
        * svg/SVGFEDropShadowElement.h: Added.
        * svg/SVGFEDropShadowElement.idl: Added.
        * svg/svgtags.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-21 MORITA Hajime <morrita@google.com>
morrita@google.com [Thu, 21 Apr 2011 17:47:47 +0000 (17:47 +0000)]
2011-04-21  MORITA Hajime  <morrita@google.com>

        Unreviewed expectations update following r84511.

        * platform/gtk/fast/html/details-open2-expected.txt:
        * platform/qt/fast/html/details-open2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-20 Roland Steiner <rolandsteiner@chromium.org>
rolandsteiner@chromium.org [Thu, 21 Apr 2011 17:44:14 +0000 (17:44 +0000)]
2011-04-20  Roland Steiner  <rolandsteiner@chromium.org>

        Reviewed by Dimitri Glazkov.

        Bug 58704 - Decide on node type for ShadowRoot
        https://bugs.webkit.org/show_bug.cgi?id=58704

        Test node types of shadow host, shadow root and first shadow child.

        * fast/dom/shadow/nodetype-expected.txt: Added.
        * fast/dom/shadow/nodetype.html: Added.
2011-04-21  Roland Steiner  <rolandsteiner@chromium.org>

        Reviewed by Dimitri Glazkov.

        Bug 58704 - Decide on node type for ShadowRoot
        https://bugs.webkit.org/show_bug.cgi?id=58704

        Add a new node type SHADOW_ROOT_NODE.
        Adapt all calling sites of nodeType().

        Test: fast/dom/shadow/nodetype.html

        * bindings/js/JSNodeCustom.cpp:
        (WebCore::createWrapperInline):
        * bindings/objc/DOM.mm:
        (kitClass):
        * bindings/v8/custom/V8NodeCustom.cpp:
        (WebCore::toV8Slow):
        * dom/Document.cpp:
        (WebCore::Document::importNode):
        (WebCore::Document::childTypeAllowed):
        (WebCore::Document::canReplaceChild):
        * dom/Node.cpp:
        (WebCore::Node::dumpStatistics):
        (WebCore::Node::isDefaultNamespace):
        (WebCore::Node::lookupPrefix):
        (WebCore::Node::lookupNamespaceURI):
        (WebCore::appendTextContent):
        (WebCore::Node::setTextContent):
        * dom/Node.h:
        * dom/Range.cpp:
        (WebCore::lengthOfContentsInNode):
        (WebCore::Range::processContentsBetweenOffsets):
        (WebCore::Range::insertNode):
        (WebCore::Range::checkNodeWOffset):
        (WebCore::Range::checkNodeBA):
        (WebCore::Range::selectNode):
        (WebCore::Range::selectNodeContents):
        (WebCore::Range::surroundContents):
        * dom/ShadowRoot.cpp:
        (WebCore::ShadowRoot::nodeType):
        * dom/Traversal.cpp:
        (WebCore::Traversal::acceptNode):
        * editing/MarkupAccumulator.cpp:
        (WebCore::MarkupAccumulator::appendStartMarkup):
        * html/parser/HTMLElementStack.cpp:
        (WebCore::HTMLNames::isRootNode):
        (WebCore::HTMLElementStack::pushRootNode):
        * html/parser/HTMLElementStack.h:
        (WebCore::isInHTMLNamespace):
        * xml/XPathUtil.cpp:
        (WebCore::XPath::isValidContextNode):
2011-04-21  Roland Steiner  <rolandsteiner@chromium.org>

        Reviewed by Dimitri Glazkov.

        Bug 58704 - Decide on node type for ShadowRoot
        https://bugs.webkit.org/show_bug.cgi?id=58704

        Add a new enum entry to WebNode::NodeType for shadow roots.
        Adapt calling sites for new SHADOW_ROOT_NODE node type.

        * public/WebNode.h:
        * src/WebPageSerializerImpl.cpp:
        (WebKit::WebPageSerializerImpl::buildContentForNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebKit2: Need a way to get a snapshot of the visible contents of a page from the...
jberlin@webkit.org [Thu, 21 Apr 2011 17:43:39 +0000 (17:43 +0000)]
WebKit2: Need a way to get a snapshot of the visible contents of a page from the UI Process.
https://bugs.webkit.org/show_bug.cgi?id=59035

Reviewed by Sam Weinig.

Added a sync call from the UI Process to the Web Process with comments saying that it should
be removed as soon as possible.

* UIProcess/API/C/WKPage.cpp:
(WKPageVisibleContentsSnapshot):
* UIProcess/API/C/WKPagePrivate.h:

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::createSnapshotOfVisibleContent):
* UIProcess/WebPageProxy.h:

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::createSnapshotOfVisibleContent):
Ask the FrameView for the visibleContentRect, and call scaledSnapshotInDocumentCoordinates
with a scale factor of 1 (which preserves the current scaling of the page - e.g. if the
page is already zoomed then the snapshot will reflect the zoomed content).
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-20 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Thu, 21 Apr 2011 17:43:24 +0000 (17:43 +0000)]
2011-04-20  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Tony Chang.

        put unexpected passes into their own table
        https://bugs.webkit.org/show_bug.cgi?id=59016

        * Scripts/webkitpy/layout_tests/layout_package/json_results.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-20 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 21 Apr 2011 17:37:47 +0000 (17:37 +0000)]
2011-04-20  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Kent Tamura.

        REGRESSION (r75543): Styles bleed into new shadow DOM (like slider and video)
        https://bugs.webkit.org/show_bug.cgi?id=52917

        * fast/css/shadow-dom-scope-expected.txt: Added.
        * fast/css/shadow-dom-scope.html: Added.
2011-04-20  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Kent Tamura.

        REGRESSION (r75543): Styles bleed into new shadow DOM (like slider and video)
        https://bugs.webkit.org/show_bug.cgi?id=52917

        In order to determine whether a rule should apply inside of a shadow DOM subtree,
        we collect three pieces of information:

        1) Are we parsing UA sheets?
        2) Does the current tree scope allows applying author sheets?
        3) Does the rule explicitly reach into shadow DOM (using pseudo-elements, for example)?

        If the answer to all of these is no, we ignore the rule.

        Test: fast/css/shadow-dom-scope.html

        * css/CSSStyleSelector.cpp:
        (WebCore::MatchingUARulesScope::MatchingUARulesScope): Added a scope helper to
            track whether we are currently matching UA rules.
        (WebCore::CSSStyleSelector::matchRulesForList): Added the check for three
            conditions mentioned above.
        (WebCore::CSSStyleSelector::SelectorChecker::SelectorChecker): Added
            initializer for the flag, which helps us determine whether the rule
            explicitly reaches into shadow DOM.
        (WebCore::CSSStyleSelector::matchUARules): Started using the scope helper.
        (WebCore::CSSStyleSelector::checkSelector): Added initializing of the
            flag.
        (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Added setting
            of the flag when we encounter unknown pseudo-elements.
        * css/CSSStyleSelector.h: Adjusted decls.
        * dom/ShadowRoot.cpp:
        (WebCore::ShadowRoot::applyAuthorSheets): Added.
        * dom/ShadowRoot.h: Adjusted decls.
        * dom/TreeScope.cpp:
        (WebCore::TreeScope::applyAuthorSheets): Added.
        * dom/TreeScope.h: Adjusted decls.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-21 Levi Weintraub <leviw@chromium.org>
leviw@chromium.org [Thu, 21 Apr 2011 17:24:19 +0000 (17:24 +0000)]
2011-04-21  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Simon Fraser.

        position fixed element does not render properly when dynamically updated via javascript
        https://bugs.webkit.org/show_bug.cgi?id=54297

        Disabling the LayoutState fast-path for fixed-position content.

        Tests: fast/repaint/fixed-contents-changed-after-scroll.html
               fast/repaint/transformed-contents-changed-after-scroll.html

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::computeRectForRepaint):
2011-04-21  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Simon Fraser.

        position fixed element does not render properly when dynamically updated via javascript
        https://bugs.webkit.org/show_bug.cgi?id=54297

        Disabling the LayoutState fast-path for fixed-position content.

        * fast/repaint/fixed-contents-changed-after-scroll.html: Added.
        * fast/repaint/transformed-contents-changed-after-scroll.html: Added.
        * platform/mac/fast/repaint/fixed-contents-changed-after-scroll-expected.checksum: Added.
        * platform/mac/fast/repaint/fixed-contents-changed-after-scroll-expected.png: Added.
        * platform/mac/fast/repaint/fixed-contents-changed-after-scroll-expected.txt: Added.
        * platform/mac/fast/repaint/transformed-contents-changed-after-scroll-expected.checksum: Added.
        * platform/mac/fast/repaint/transformed-contents-changed-after-scroll-expected.png: Added.
        * platform/mac/fast/repaint/transformed-contents-changed-after-scroll-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-20 Michael Saboff <msaboff@apple.com>
msaboff@apple.com [Thu, 21 Apr 2011 17:23:16 +0000 (17:23 +0000)]
2011-04-20  Michael Saboff  <msaboff@apple.com>

        Reviewed by Geoff Garen.

        JSString::resolveRope inefficient for common 2 fiber case
        https://bugs.webkit.org/show_bug.cgi?id=58994

        Split JSString::resolveRope into three routines.
        resolveRope allocates the new buffer and handles the 1 or 2
        fiber case with single level fibers.
        resolveRopeSlowCase handles the general case.
        outOfMemory handles the rare out of memory exception case.

        * runtime/JSString.cpp:
        (JSC::JSString::resolveRope):
        (JSC::JSString::resolveRopeSlowCase):
        (JSC::JSString::outOfMemory):
        * runtime/JSString.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-20 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Thu, 21 Apr 2011 17:16:33 +0000 (17:16 +0000)]
2011-04-20  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Tony Chang.

        initial set of tests for new results.html file
        https://bugs.webkit.org/show_bug.cgi?id=59031

        Also, fix the bugs (mostly innocuous JS errors) the tests found.

        * Scripts/webkitpy/layout_tests/layout_package/json_results.html:
        * Scripts/webkitpy/layout_tests/layout_package/json_results_test.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-21 Tony Chang <tony@chromium.org>
tony@chromium.org [Thu, 21 Apr 2011 17:12:44 +0000 (17:12 +0000)]
2011-04-21  Tony Chang  <tony@chromium.org>

        Unreviewed.  Fixed the last set of tests that are missing pngs.
        Created new png baselines on my Leopard machine.

        * platform/chromium-mac-leopard/fast/blockflow/english-bt-text-expected.checksum: Removed.
        * platform/chromium-mac-leopard/fast/blockflow/english-bt-text-expected.png: Added.
        * platform/chromium-mac-leopard/fast/borders/svg-as-border-image-expected.checksum: Removed.
        * platform/chromium-mac-leopard/fast/borders/svg-as-border-image-expected.png: Added.
        * platform/chromium-mac-leopard/fast/css/background-shorthand-invalid-url-expected.checksum: Removed.
        * platform/chromium-mac-leopard/fast/css/background-shorthand-invalid-url-expected.png: Added.
        * platform/chromium-mac-leopard/fast/css/value-list-out-of-bounds-crash-expected.checksum: Removed.
        * platform/chromium-mac-leopard/fast/css/value-list-out-of-bounds-crash-expected.png: Added.
        * platform/chromium-mac-leopard/svg/custom/group-opacity-expected.checksum: Removed.
        * platform/chromium-mac-leopard/svg/custom/group-opacity-expected.png: Added.
        * platform/chromium-mac-leopard/svg/custom/image-with-transform-clip-filter-expected.checksum: Removed.
        * platform/chromium-mac-leopard/svg/custom/image-with-transform-clip-filter-expected.png: Added.
        * platform/chromium-mac/editing/selection/extend-by-word-002-expected.checksum: Removed. Matches platform/mac.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-20 MORITA Hajime <morrita@google.com>
mdelaney@apple.com [Thu, 21 Apr 2011 16:57:02 +0000 (16:57 +0000)]
2011-04-20  MORITA Hajime  <morrita@google.com>

        Reviewed by Dimitri Glazkov.

        Content of <summary> should be forwarded through the shadow DOM
        https://bugs.webkit.org/show_bug.cgi?id=58914

        - Added test cases for dynamic DOM change.
        - Updated expectations details-open2.html because generated RenderTree slightly changed.

        * fast/html/details-add-summary-child-1.html: Added.
        * fast/html/details-add-summary-child-2.html: Added.
        * fast/html/details-remove-summary-child-1.html: Added.
        * fast/html/details-remove-summary-child-2.html: Added.
        * platform/chromium/test_expectations.txt:
        * platform/mac/fast/html/details-add-summary-child-1-expected.checksum: Added.
        * platform/mac/fast/html/details-add-summary-child-1-expected.png: Added.
        * platform/mac/fast/html/details-add-summary-child-1-expected.txt: Added.
        * platform/mac/fast/html/details-add-summary-child-2-expected.checksum: Added.
        * platform/mac/fast/html/details-add-summary-child-2-expected.png: Added.
        * platform/mac/fast/html/details-add-summary-child-2-expected.txt: Added.
        * platform/mac/fast/html/details-open2-expected.txt:
        * platform/mac/fast/html/details-remove-summary-child-1-expected.checksum: Added.
        * platform/mac/fast/html/details-remove-summary-child-1-expected.png: Added.
        * platform/mac/fast/html/details-remove-summary-child-1-expected.txt: Added.
        * platform/mac/fast/html/details-remove-summary-child-2-expected.checksum: Added.
        * platform/mac/fast/html/details-remove-summary-child-2-expected.png: Added.
        * platform/mac/fast/html/details-remove-summary-child-2-expected.txt: Added.
2011-04-20  Matthew Delaney  <mdelaney@apple.com>

        Reviewed by Maciej Stachowiak.

        arc() should add a circle to the path when start and end angles are far enough apart
        https://bugs.webkit.org/show_bug.cgi?id=58934

        Test: fast/canvas/canvas_arc_largeangles.html

        * html/canvas/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::arc):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-20 MORITA Hajime <morrita@google.com>
morrita@google.com [Thu, 21 Apr 2011 16:51:55 +0000 (16:51 +0000)]
2011-04-20  MORITA Hajime  <morrita@google.com>

        Reviewed by Dimitri Glazkov.

        Content of <summary> should be forwarded through the shadow DOM
        https://bugs.webkit.org/show_bug.cgi?id=58914

        - Added test cases for dynamic DOM change.
        - Updated expectations details-open2.html because generated RenderTree slightly changed.

        * fast/html/details-add-summary-child-1.html: Added.
        * fast/html/details-add-summary-child-2.html: Added.
        * fast/html/details-remove-summary-child-1.html: Added.
        * fast/html/details-remove-summary-child-2.html: Added.
        * platform/chromium/test_expectations.txt:
        * platform/mac/fast/html/details-add-summary-child-1-expected.checksum: Added.
        * platform/mac/fast/html/details-add-summary-child-1-expected.png: Added.
        * platform/mac/fast/html/details-add-summary-child-1-expected.txt: Added.
        * platform/mac/fast/html/details-add-summary-child-2-expected.checksum: Added.
        * platform/mac/fast/html/details-add-summary-child-2-expected.png: Added.
        * platform/mac/fast/html/details-add-summary-child-2-expected.txt: Added.
        * platform/mac/fast/html/details-open2-expected.txt:
        * platform/mac/fast/html/details-remove-summary-child-1-expected.checksum: Added.
        * platform/mac/fast/html/details-remove-summary-child-1-expected.png: Added.
        * platform/mac/fast/html/details-remove-summary-child-1-expected.txt: Added.
        * platform/mac/fast/html/details-remove-summary-child-2-expected.checksum: Added.
        * platform/mac/fast/html/details-remove-summary-child-2-expected.png: Added.
        * platform/mac/fast/html/details-remove-summary-child-2-expected.txt: Added.
2011-04-20  MORITA Hajime  <morrita@google.com>

        Reviewed by Dimitri Glazkov.

        Content of <summary> should be forwarded through the shadow DOM
        https://bugs.webkit.org/show_bug.cgi?id=58914

        - Introduced ShadowContentElement which hosts forwarded children of <summary>
        - Encapsulated Node::parentNodeForRenderingAndStyle() and shouldCreateRendererFor()
          into NodeVisualParentLookupResult class.
        - The parent lookup is also aware of node forwarding. If the visual parent node has
          a shadow root, the node is possibly forwarded to ShadowContentElement
        - ShadowContentElement lookup is implemented inside ShadowRoot.

        Tests: fast/html/details-add-summary-child-1.html
               fast/html/details-add-summary-child-2.html
               fast/html/details-remove-summary-child-1.html
               fast/html/details-remove-summary-child-2.html

        * GNUmakefile.list.am:
        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * dom/Element.cpp:
        (WebCore::Element::childrenChanged):
        * dom/Node.cpp:
        (WebCore::NodeRenderParentDetector::NodeRenderParentDetector):
        (WebCore::NodeRenderParentDetector::parentNodeForRenderingAndStyle):
        (WebCore::NodeRenderParentDetector::findVisualParent):
        (WebCore::NodeRenderParentDetector::shouldCreateRenderer):
        (WebCore::Node::parentNodeForRenderingAndStyle):
        (WebCore::Node::createRendererAndStyle):
        * dom/ShadowRoot.cpp:
        (WebCore::ShadowRoot::contentContainerFor):
        (WebCore::ShadowRoot::hostChildrenChanged):
        (WebCore::ShadowRoot::firstContentElement):
        * dom/ShadowRoot.h:
        * html/HTMLSummaryElement.cpp:
        (WebCore::HTMLSummaryElement::createShadowSubtree):
        * html/HTMLSummaryElement.h:
        * html/shadow/ShadowContentElement.h: Copied from Source/WebCore/dom/ShadowRoot.h.
        (WebCore::ShadowContentElement::ShadowContentElement):
        (WebCore::ShadowContentElement::isShadowBoundary):
        (WebCore::ShadowContentElement::createRenderer):
        (WebCore::ShadowContentElement::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago011-04-21 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Thu, 21 Apr 2011 16:40:56 +0000 (16:40 +0000)]
011-04-21  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: fix calls to WebInspector.ObjectPropertiesSection constructor
        https://bugs.webkit.org/show_bug.cgi?id=59105

        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleView.prototype._formatobject):
        * inspector/front-end/ExtensionPanel.js:
        (WebInspector.ExtensionSidebarPane.prototype._setObject):
        * inspector/front-end/ResourceJSONView.js:
        (WebInspector.ResourceJSONView.parseJSON.WebInspector.ResourceJSONView.prototype._initialize):
        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype._showPopup.showObjectPopup):
        (WebInspector.SourceFrame.prototype._showPopup):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-20 Matthew Delaney <mdelaney@apple.com>
mdelaney@apple.com [Thu, 21 Apr 2011 16:38:01 +0000 (16:38 +0000)]
2011-04-20  Matthew Delaney  <mdelaney@apple.com>

        Reviewed by Adam Roben.

        Move toDataURL.jpeg.alpha expected result out of /mac-snowleopard and into /mac
        https://bugs.webkit.org/show_bug.cgi?id=59038

        * platform/mac-snowleopard/canvas/philip/tests/toDataURL.jpeg.alpha-expected.txt: Removed.
        * platform/mac/canvas/philip/tests/toDataURL.jpeg.alpha-expected.txt: Copied from LayoutTests/platform/mac-snowleopard/canvas/philip/tests/toDataURL.jpeg.alpha-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-21 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 21 Apr 2011 16:32:16 +0000 (16:32 +0000)]
2011-04-21  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] missing LayoutTestController::callShouldCloseOnWebView()
        https://bugs.webkit.org/show_bug.cgi?id=59086

        * platform/gtk/Skipped: Unskip fast/events/onbeforeunload-focused-iframe.html

        callShouldCloseOnWebView() implementation.

        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
        (LayoutTestController::callShouldCloseOnWebView):

        DRT::shouldClose(), used by the LayoutController.

        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
        (DumpRenderTreeSupportGtk::shouldClose):
        * WebCoreSupport/DumpRenderTreeSupportGtk.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-21 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 21 Apr 2011 16:24:21 +0000 (16:24 +0000)]
2011-04-21  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] DRT: implement eventSender.scalePageBy
        https://bugs.webkit.org/show_bug.cgi?id=59082

        Unskipped tests that should pass now that
        eventSender.scalePageBy() is supported in GTK.

        * platform/gtk/Skipped:
        * platform/gtk/fast/repaint/scale-page-shrink-expected.checksum: Added.
        * platform/gtk/fast/repaint/scale-page-shrink-expected.png: Added.
        * platform/gtk/fast/repaint/scale-page-shrink-expected.txt: Added.

        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
        (DumpRenderTreeSupportGtk::scalePageBy):
        * WebCoreSupport/DumpRenderTreeSupportGtk.h:

        * DumpRenderTree/gtk/EventSender.cpp:
        (scalePageByCallback): scalePageBy() support.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-21 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 21 Apr 2011 16:18:27 +0000 (16:18 +0000)]
2011-04-21  Adam Barth  <abarth@webkit.org>

        Update results to show failure.

        * http/tests/security/contentSecurityPolicy/frame-src-blocked-expected.txt:
2011-04-21  Adam Barth  <abarth@webkit.org>

        Remove support for CSP's frame-src.  This approach causes too many
        extra console messages to be logged.  I'm leaving in the test (which
        now shows failure).

        * html/HTMLFrameElementBase.cpp:
        (WebCore::HTMLFrameElementBase::isURLAllowed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-21 Eunsol Park <eunsol47.park@samsung.com>
commit-queue@webkit.org [Thu, 21 Apr 2011 15:58:11 +0000 (15:58 +0000)]
2011-04-21  Eunsol Park  <eunsol47.park@samsung.com>

        Reviewed by Antonio Gomes.

        [EFL] Scroll doesn't work on tiled backing store.
        https://bugs.webkit.org/show_bug.cgi?id=55021

        It was added from Changeset 72242, but it worked wrong in EFL port.
        The visible rect should not be returned as content rect for scrolling in EFL tiled backing store,
        because it works differently from QT.

        * platform/ScrollView.cpp:
        (WebCore::ScrollView::visibleContentRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-21 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 21 Apr 2011 15:55:57 +0000 (15:55 +0000)]
2011-04-21  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Eric Seidel.

        Create RIAA class for GraphicsContext::save() and restore()
        https://bugs.webkit.org/show_bug.cgi?id=58807

        Use GraphicsContextStateSaver in a lot more places.

        * html/canvas/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::drawImage):
        (WebCore::CanvasRenderingContext2D::drawTextInternal):
        * platform/ScrollView.cpp:
        (WebCore::ScrollView::wheelEvent):
        * platform/graphics/GeneratedImage.cpp:
        (WebCore::GeneratedImage::draw):
        * platform/graphics/GraphicsContext.h:
        (WebCore::GraphicsContextStateSaver::save):
        (WebCore::GraphicsContextStateSaver::restore):
        * platform/graphics/ShadowBlur.cpp:
        (WebCore::ShadowBlur::drawShadowBuffer):
        (WebCore::ShadowBlur::drawRectShadowWithoutTiling):
        (WebCore::ShadowBlur::drawInsetShadowWithoutTiling):
        (WebCore::ShadowBlur::drawInsetShadowWithTiling):
        (WebCore::ShadowBlur::drawRectShadowWithTiling):
        (WebCore::ShadowBlur::drawLayerPieces):
        * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
        (WebCore::MediaPlayerPrivateAVFoundationObjC::paint):
        * platform/graphics/cg/ImageCG.cpp:
        (WebCore::BitmapImage::draw):
        (WebCore::Image::drawPattern):
        * platform/graphics/cg/PDFDocumentImage.cpp:
        (WebCore::PDFDocumentImage::draw):
        * platform/graphics/filters/FEComposite.cpp:
        (WebCore::FEComposite::apply):
        * platform/graphics/filters/SourceAlpha.cpp:
        (WebCore::SourceAlpha::apply):
        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        (WebCore::MediaPlayerPrivateQTKit::paint):
        * platform/mac/ScrollbarThemeMac.mm:
        (WebCore::ScrollbarThemeMac::paint):
        * platform/mac/ThemeMac.mm:
        (WebCore::paintCheckbox):
        (WebCore::paintRadio):
        (WebCore::paintStepper):
        * rendering/EllipsisBox.cpp:
        (WebCore::EllipsisBox::paintSelection):
        * rendering/InlineFlowBox.cpp:
        (WebCore::InlineFlowBox::paintFillLayer):
        (WebCore::InlineFlowBox::paintBoxDecorations):
        (WebCore::InlineFlowBox::paintMask):
        * rendering/InlineTextBox.cpp:
        (WebCore::InlineTextBox::paint):
        (WebCore::InlineTextBox::paintSelection):
        (WebCore::InlineTextBox::paintCompositionBackground):
        (WebCore::InlineTextBox::paintDecoration):
        (WebCore::InlineTextBox::paintTextMatchMarker):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::paintColumnContents):
        (WebCore::RenderBlock::paintSelection):
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::paintBoxDecorationsWithSize):
        * rendering/RenderBoxModelObject.cpp:
        (WebCore::RenderBoxModelObject::paintFillLayerExtended):
        (WebCore::RenderBoxModelObject::paintBorder):
        * rendering/RenderEmbeddedObject.cpp:
        (WebCore::RenderEmbeddedObject::paintReplaced):
        * rendering/RenderFieldset.cpp:
        (WebCore::RenderFieldset::paintBoxDecorations):
        * rendering/RenderFileUploadControl.cpp:
        (WebCore::RenderFileUploadControl::paintObject):
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::paintResizer):
        (WebCore::RenderLayer::paintLayer):
        (WebCore::RenderLayer::paintChildLayerIntoColumns):
        * rendering/RenderListMarker.cpp:
        (WebCore::RenderListMarker::paint):
        * rendering/RenderMediaControls.cpp:
        (WebCore::RenderMediaControls::paintMediaControlsPart):
        * rendering/RenderTableCell.cpp:
        (WebCore::RenderTableCell::paintBackgroundsBehindCell):
        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::paintPlaceholder):
        * rendering/RenderThemeMac.mm:
        (WebCore::RenderThemeMac::paintMenuList):
        (WebCore::RenderThemeMac::paintMeter):
        (WebCore::RenderThemeMac::paintProgressBar):
        (WebCore::RenderThemeMac::paintMenuListButtonGradients):
        (WebCore::RenderThemeMac::paintMenuListButton):
        (WebCore::RenderThemeMac::paintSliderTrack):
        (WebCore::RenderThemeMac::paintSliderThumb):
        (WebCore::RenderThemeMac::paintSearchField):
        (WebCore::RenderThemeMac::paintSearchFieldCancelButton):
        (WebCore::RenderThemeMac::paintSearchFieldResultsButton):
        (WebCore::RenderThemeMac::paintMediaSliderTrack):
        (WebCore::RenderThemeMac::paintMediaCurrentTime):
        (WebCore::RenderThemeMac::paintMediaTimeRemaining):
        * rendering/mathml/RenderMathMLBlock.cpp:
        (WebCore::RenderMathMLBlock::paint):
        * rendering/mathml/RenderMathMLFraction.cpp:
        (WebCore::RenderMathMLFraction::paint):
        * rendering/mathml/RenderMathMLRoot.cpp:
        (WebCore::RenderMathMLRoot::paint):
        * rendering/mathml/RenderMathMLSquareRoot.cpp:
        (WebCore::RenderMathMLSquareRoot::paint):
        * rendering/svg/RenderSVGContainer.cpp:
        (WebCore::RenderSVGContainer::paint):
        * rendering/svg/RenderSVGForeignObject.cpp:
        (WebCore::RenderSVGForeignObject::paint):
        * rendering/svg/RenderSVGImage.cpp:
        (WebCore::RenderSVGImage::paint):
        * rendering/svg/RenderSVGPath.cpp:
        (WebCore::RenderSVGPath::fillAndStrokePath):
        (WebCore::RenderSVGPath::paint):
        * rendering/svg/RenderSVGResourceClipper.cpp:
        (WebCore::RenderSVGResourceClipper::applyClippingToContext):
        * rendering/svg/RenderSVGResourceMarker.cpp:
        (WebCore::RenderSVGResourceMarker::draw):
        * rendering/svg/RenderSVGText.cpp:
        (WebCore::RenderSVGText::paint):
        * rendering/svg/SVGInlineFlowBox.cpp:
        (WebCore::SVGInlineFlowBox::paint):
        * rendering/svg/SVGInlineTextBox.cpp:
        (WebCore::SVGInlineTextBox::paintSelectionBackground):
        (WebCore::SVGInlineTextBox::paint):
        (WebCore::SVGInlineTextBox::paintDecorationWithStyle):
        * rendering/svg/SVGRootInlineBox.cpp:
        (WebCore::SVGRootInlineBox::paint):
        * svg/SVGFont.cpp:
        (WebCore::Font::drawTextUsingSVGFont):
        * svg/graphics/SVGImage.cpp:
        (WebCore::SVGImage::draw):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-21 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Thu, 21 Apr 2011 15:39:23 +0000 (15:39 +0000)]
2011-04-21  Tony Gentilcore  <tonyg@chromium.org>

        [chromium] inspector/console/console-log-before-inspector-open.html times out on mac
        https://bugs.webkit.org/show_bug.cgi?id=59106

        Seems to have started timing out in 84470-84471 which were expectations
        updates.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-21 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 21 Apr 2011 15:38:37 +0000 (15:38 +0000)]
2011-04-21  Adam Barth  <abarth@webkit.org>

        Reviewed by Tony Gentilcore.

        Make test robust to PHP magic quotes
        https://bugs.webkit.org/show_bug.cgi?id=59104

        * http/tests/security/contentSecurityPolicy/report-uri-expected.txt:
        * http/tests/security/contentSecurityPolicy/report-uri-from-child-frame-expected.txt:
        * http/tests/security/contentSecurityPolicy/resources/save-report.php:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-21 Yi Shen <yi.4.shen@nokia.com>
yi.4.shen@nokia.com [Thu, 21 Apr 2011 15:21:52 +0000 (15:21 +0000)]
2011-04-21  Yi Shen  <yi.4.shen@nokia.com>

        Reviewed by Antonio Gomes.

        [Qt] Fix the style issue for Api/qwebkitplatformplugin.h
        https://bugs.webkit.org/show_bug.cgi?id=59097

        Fix the style issues for Api/qwebkitplatformplugin.h found by the webkit-check-style.

        * Api/qwebkitplatformplugin.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-21 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Thu, 21 Apr 2011 15:07:33 +0000 (15:07 +0000)]
2011-04-21  Tony Gentilcore  <tonyg@chromium.org>

        [chromium] Temporarily skip new contentSecurityPolicy tests
        https://bugs.webkit.org/show_bug.cgi?id=59103

        Tests introduced by http://trac.webkit.org/changeset/84478

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-20 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Thu, 21 Apr 2011 14:59:35 +0000 (14:59 +0000)]
2011-04-20  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [Extensions API] console API is not exposed to code evaluated by sidebar.setExpression()
        https://bugs.webkit.org/show_bug.cgi?id=59006

        * inspector/front-end/ExtensionPanel.js:
        (WebInspector.ExtensionSidebarPane.prototype.setExpression):

2011-04-20  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Pavel Feldman.

        Expose console API to the code evaluated by sidebar.setExpression()

        Web Inspector: [Extensions API] console API is not exposed to code evaluated by sidebar.setExpression()
        https://bugs.webkit.org/show_bug.cgi?id=59006

        * inspector/extensions/extensions-expected.txt:
        * inspector/extensions/extensions.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-21 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Thu, 21 Apr 2011 14:22:42 +0000 (14:22 +0000)]
2011-04-21  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        Split SVGGlyphIdentifier class out of SVGGlyphElement.h
        https://bugs.webkit.org/show_bug.cgi?id=59101

        Move SVGGlyphIdentifier class out of SVGGlyphElement.h, place it in platform/graphics/SVGGlyph.h
        and rename the contained struct to SVGGlyph. It will be used in follow-up patches that will integrate SVGGlyph & GlyphPage.

        Several utility functions are moved from SVGFont.cpp to SVGGlyph.cpp, as that's the place where they really belong to.
        Renamed nameLength to unicodeStringLength in the SVGGlyph struct for clarity.

        * Android.mk: Add SVGGlyph.cpp/h to build.
        * CMakeLists.txt: Ditto.
        * GNUmakefile.list.am: Ditto.
        * WebCore.gypi: Ditto.
        * WebCore.pro: Ditto.
        * WebCore.vcproj/WebCore.vcproj: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * platform/graphics/SVGGlyph.cpp: Copied from svg/SVGFont.cpp. Removed everything except the methods listed below, that belong here.
        (WebCore::processArabicFormDetection):
        (WebCore::charactersWithArabicForm):
        (WebCore::isCompatibleArabicForm):
        (WebCore::isCompatibleGlyph):
        * platform/graphics/SVGGlyph.h: Copied from svg/SVGGlyphElement.h. Renamed SVGGlyphIdentifier to SVGGlyph.
        (WebCore::SVGGlyph::SVGGlyph):
        (WebCore::SVGGlyph::operator==):
        * platform/graphics/SimpleFontData.cpp: Adapt for SVGGlyphIdentifier -> SVGGlyph and nameLength -> unicodeStringLength rename.
        (WebCore::SimpleFontData::SimpleFontData):
        * svg/SVGFont.cpp: Ditto. Remove helper functions that are now living in SVGGlyph.cpp
        (WebCore::SVGTextRunWalker::walk):
        (WebCore::floatWidthUsingSVGFontCallback):
        (WebCore::drawTextUsingSVGFontCallback):
        (WebCore::drawTextMissingGlyphCallback):
        (WebCore::Font::drawTextUsingSVGFont):
        * svg/SVGFontElement.cpp: Ditto.
        (WebCore::SVGFontElement::getGlyphIdentifiersForString):
        * svg/SVGFontElement.h: Ditto.
        * svg/SVGGlyphElement.cpp: Ditto.
        (WebCore::parseArabicForm):
        (WebCore::parseOrientation):
        (WebCore::SVGGlyphElement::inheritUnspecifiedAttributes):
        (WebCore::parseSVGGlyphAttribute):
        (WebCore::SVGGlyphElement::buildGenericGlyphIdentifier):
        (WebCore::SVGGlyphElement::buildGlyphIdentifier):
        * svg/SVGGlyphElement.h: Ditto.
        * svg/SVGGlyphMap.h: Ditto.
        (WebCore::SVGGlyphMap::add):
        (WebCore::SVGGlyphMap::compareGlyphPriority):
        (WebCore::SVGGlyphMap::get):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-21 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Thu, 21 Apr 2011 14:10:18 +0000 (14:10 +0000)]
2011-04-21  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Dan Bernstein.

        Live streams won't play with AVFoundation backend
        https://bugs.webkit.org/show_bug.cgi?id=58961
        rdar://problem/9284748

        Tested manually because we don't have any live streams to test in DRT.

        * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
        (WebCore::MediaPlayerPrivateAVFoundation::seek): Do nothing when asked to seek to the
            current time.
        (WebCore::MediaPlayerPrivateAVFoundation::updateStates): If the readyState is HaveEnoughData,
            don't revert when the new state is "ready to play" or "buffer full".
        (WebCore::MediaPlayerPrivateAVFoundation::movieLoadType): Use new convenience function isLiveStream.
        * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
        (WebCore::MediaPlayerPrivateAVFoundation::isLiveStream): New.

        * platform/graphics/avfoundation/MediaPlayerPrivateAVFoundationObjC.mm:
        (WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Don't use AVAsset's
            tracksWithMediaCharacteristic because it doesn't give us what we need with live
            streams.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-21 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Thu, 21 Apr 2011 14:08:55 +0000 (14:08 +0000)]
2011-04-21  Tony Gentilcore  <tonyg@chromium.org>

        [chromium] Correct expecations for editing/selection/designmode-no-caret.html
        https://bugs.webkit.org/show_bug.cgi?id=59088

        Straighten out bad override in designmode-no-caret.html

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-21 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Thu, 21 Apr 2011 13:51:08 +0000 (13:51 +0000)]
2011-04-21  Pavel Feldman  <pfeldman@google.com>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Cookies section in empty on page re-launch.
        https://bugs.webkit.org/show_bug.cgi?id=59095

        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.ResourcesPanel.prototype._reset):
        (WebInspector.ResourcesPanel.prototype._frameNavigated):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-21 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Thu, 21 Apr 2011 13:49:22 +0000 (13:49 +0000)]
2011-04-21  Pavel Feldman  <pfeldman@google.com>

        Reviewed by Yury Semikhatsky.

        Web Inspector: rename De-obfuscate to Pretty print.
        https://bugs.webkit.org/show_bug.cgi?id=59093

        * English.lproj/localizedStrings.js:
        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype._populateTextAreaContextMenu):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-21 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Thu, 21 Apr 2011 13:48:14 +0000 (13:48 +0000)]
2011-04-21  Pavel Feldman  <pfeldman@google.com>

        Reviewed by Yury Semikhatsky.

        Web Inspector: following Image URL link in the network panel does nothing.
        https://bugs.webkit.org/show_bug.cgi?id=59092

        * inspector/front-end/ImageView.js:
        (WebInspector.ImageView.prototype._createContentIfNeeded.onImageLoad):
        (WebInspector.ImageView.prototype._createContentIfNeeded):
        * inspector/front-end/inspector.js:
        (WebInspector.linkifyURLAsNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-21 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Thu, 21 Apr 2011 13:46:56 +0000 (13:46 +0000)]
2011-04-21  Pavel Feldman  <pfeldman@google.com>

        Reviewed by Yury Semikhatsky.

        Web Inspector: implement Go To Line for network panel.
        https://bugs.webkit.org/show_bug.cgi?id=59090

        * inspector/front-end/GoToLineDialog.js:
        (WebInspector.GoToLineDialog.prototype._highlightSelectedLine):
        * inspector/front-end/NetworkItemView.js:
        (WebInspector.NetworkItemView.prototype._tabSelected):
        (WebInspector.NetworkItemView.prototype._installHighlightSupport):
        * inspector/front-end/NetworkPanel.js:
        (WebInspector.NetworkPanel):
        * inspector/front-end/TabbedPane.js:
        (WebInspector.TabbedPane.prototype.appendTab):
        (WebInspector.TabbedPane.prototype.selectTab):
        * inspector/front-end/TextViewer.js:
        (WebInspector.TextViewer.prototype.highlightLine):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSkip some newly-failing tests on Windows
aroben@apple.com [Thu, 21 Apr 2011 13:45:28 +0000 (13:45 +0000)]
Skip some newly-failing tests on Windows

<http://webkit.org/b/59098> and <http://webkit.org/b/59099> track the failures.

* platform/win/Skipped: Added fast/transforms/selection-bounds-in-transformed-view.html and
http/tests/security/contentSecurityPolicy/frame-src-blocked.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-21 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Thu, 21 Apr 2011 13:34:36 +0000 (13:34 +0000)]
2011-04-21  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        Split GlyphPage from GlyphPageTreeNode.h into its own header
        https://bugs.webkit.org/show_bug.cgi?id=59096

        * GNUmakefile.list.am: Add GlyphPage.h to build.
        * WebCore.gypi: Ditto.
        * WebCore.vcproj/WebCore.vcproj: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * platform/graphics/GlyphPage.h: Copied from platform/graphics/GlyphPageTreeNode.h. Removed GlyphPageTreeNode class, leaving only GlyphPage.
        * platform/graphics/GlyphPageTreeNode.h: Removed GlyphPage class.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-21 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Thu, 21 Apr 2011 13:07:46 +0000 (13:07 +0000)]
2011-04-21  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        Centralize typedef unsigned short Glyph in Glyph.h
        https://bugs.webkit.org/show_bug.cgi?id=59087

        * GNUmakefile.list.am: Add Glyph.h to build.
        * WebCore.gypi: Ditto.
        * WebCore.vcproj/WebCore.vcproj: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * platform/graphics/Glyph.h: Added.
        * platform/graphics/GlyphBuffer.h: Include Glyph.h instead of duplicating the Glyph typedef.
        * platform/graphics/GlyphMetricsMap.h: Ditto.
        * platform/graphics/GlyphPageTreeNode.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-21 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Thu, 21 Apr 2011 12:45:27 +0000 (12:45 +0000)]
2011-04-21  Tony Gentilcore  <tonyg@chromium.org>

        BitmapImage::destroyMetadataAndNotify should clear m_checkedForSolidColor
        https://bugs.webkit.org/show_bug.cgi?id=58926

        Remove chromium's crashing expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-21 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Thu, 21 Apr 2011 12:33:16 +0000 (12:33 +0000)]
2011-04-21  Tony Gentilcore  <tonyg@chromium.org>

        [chromium] Correct expecations for editing/selection/designmode-no-caret.html
        https://bugs.webkit.org/show_bug.cgi?id=59088

        http://trac.webkit.org/changeset/84470 seemed to have caused a conflict. This
        has always been failing on Win Debug.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt][WK2] Unreviewed.
ossy@webkit.org [Thu, 21 Apr 2011 12:28:09 +0000 (12:28 +0000)]
[Qt][WK2] Unreviewed.

REGRESSION (WK2): Animated GIF stops when navigating forward, back
https://bugs.webkit.org/show_bug.cgi?id=59042

* platform/qt-wk2/Skipped: Add fast/images/animated-gif-restored-from-bfcache.html,
because WebKit2 since it doesn't implement layoutTestController.overridePreference().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-21 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Thu, 21 Apr 2011 12:24:51 +0000 (12:24 +0000)]
2011-04-21  Pavel Feldman  <pfeldman@google.com>

        Reviewed by Yury Semikhatsky.

        Web Inspector: toolbar background is blank on Mac Chromium port.
        https://bugs.webkit.org/show_bug.cgi?id=59089

        * inspector/front-end/inspector.css:
        (body.detached.platform-mac-snowleopard:not(.remote) #toolbar):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-21 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 21 Apr 2011 12:05:16 +0000 (12:05 +0000)]
2011-04-21  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: add support for Go To Line in Resources panel.
        https://bugs.webkit.org/show_bug.cgi?id=59077

        * inspector/front-end/CallStackSidebarPane.js:
        (WebInspector.CallStackSidebarPane.prototype.registerShortcuts):
        * inspector/front-end/GoToLineDialog.js:
        (WebInspector.GoToLineDialog.show):
        (WebInspector.GoToLineDialog.createShortcut):
        (WebInspector.GoToLineDialog.prototype._onKeyDown):
        * inspector/front-end/NetworkPanel.js:
        (WebInspector.NetworkPanel.prototype.handleShortcut):
        * inspector/front-end/Panel.js:
        (WebInspector.Panel):
        (WebInspector.Panel.prototype._restoreScrollPositions):
        (WebInspector.Panel.prototype.handleShortcut):
        (WebInspector.Panel.prototype.registerShortcuts):
        (WebInspector.Panel.prototype._showGoToLineDialog):
        * inspector/front-end/ProfilesPanel.js:
        (WebInspector.ProfilesPanel.prototype.handleShortcut):
        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.ResourcesPanel):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype._registerShortcuts):
        (WebInspector.ScriptsPanel.prototype.jumpToPreviousSearchResult):
        * inspector/front-end/inspector.js:
        (WebInspector._registerShortcuts):
        (WebInspector.documentKeyDown):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-21 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Thu, 21 Apr 2011 11:43:42 +0000 (11:43 +0000)]
2011-04-21  Pavel Feldman  <pfeldman@google.com>

        Reviewed by Yury Semikhatsky.

        Web Inspector: persist local resource history between inspector / browser launches.
        https://bugs.webkit.org/show_bug.cgi?id=58993

        * inspector/front-end/Resource.js:
        (WebInspector.Resource.prototype._restoreRevisions):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-21 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 21 Apr 2011 10:51:33 +0000 (10:51 +0000)]
2011-04-21  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, GTK baselines for test added in r84398.

        * platform/gtk/fast/borders/bidi-012-expected.checksum: Added.
        * platform/gtk/fast/borders/bidi-012-expected.png: Added.
        * platform/gtk/fast/borders/bidi-012-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-20 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Thu, 21 Apr 2011 09:53:57 +0000 (09:53 +0000)]
2011-04-20  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Metrics pane editing and visual feedback improvements
        https://bugs.webkit.org/show_bug.cgi?id=58992

        Added visual feedback when hovering over the box model components of the Metrics pane
        and handling of the [Page]Up/Down keys when editing the box model values.

        * inspector/DOMNodeHighlighter.cpp:
        (WebCore::DOMNodeHighlighter::DrawNodeHighlight):
        * inspector/DOMNodeHighlighter.h:
        * inspector/Inspector.json:
        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::mouseDidMoveOverElement):
        (WebCore::InspectorDOMAgent::highlight):
        (WebCore::InspectorDOMAgent::highlightDOMNode):
        (WebCore::InspectorDOMAgent::highlightFrame):
        (WebCore::InspectorDOMAgent::drawNodeHighlight):
        * inspector/InspectorDOMAgent.h:
        * inspector/front-end/CSSStyleModel.js:
        (WebInspector.CSSProperty.prototype.setText.callback):
        (WebInspector.CSSProperty.prototype.setText):
        (WebInspector.CSSProperty.prototype.setValue):
        (WebInspector.CSSProperty.prototype.setDisabled.callback):
        (WebInspector.CSSProperty.prototype.setDisabled):
        * inspector/front-end/ElementsPanel.js:
        (WebInspector.ElementsPanel.prototype.startEditingStyle):
        (WebInspector.ElementsPanel.prototype.endEditingStyle):
        (WebInspector.ElementsPanel.prototype._attributesUpdated):
        * inspector/front-end/MetricsSidebarPane.js:
        (WebInspector.MetricsSidebarPane):
        (WebInspector.MetricsSidebarPane.prototype._highlightDOMNode):
        (WebInspector.MetricsSidebarPane.prototype._highlightDOMNode.getBoxRectangleElement):
        (WebInspector.MetricsSidebarPane.prototype._update.createBoxPartElement):
        (WebInspector.MetricsSidebarPane.prototype._update):
        (WebInspector.MetricsSidebarPane.prototype.startEditing):
        (WebInspector.MetricsSidebarPane.prototype._handleKeyDown):
        (WebInspector.MetricsSidebarPane.prototype.editingEnded):
        (WebInspector.MetricsSidebarPane.prototype.editingCancelled):
        (WebInspector.MetricsSidebarPane.prototype._applyUserInput.callback):
        (WebInspector.MetricsSidebarPane.prototype._applyUserInput):
        (WebInspector.MetricsSidebarPane.prototype.editingCommitted):
        * inspector/front-end/StylesSidebarPane.js:
        (WebInspector.StylesSidebarPane.alteredFloatNumber):
        (WebInspector.StylesSidebarPane.alteredHexNumber):
        (WebInspector.StylePropertyTreeElement.prototype):
        (WebInspector.StylePropertyTreeElement.prototype.element.userInput.previousContent.context.moveDirection):
        * inspector/front-end/inspector.css:
        (.metrics .hovered > .label):
        (.metrics .position):
        (.metrics .margin):
        (.metrics .margin.hovered):
        (.metrics .border):
        (.metrics .border.hovered):
        (.metrics .padding):
        (.metrics .padding.hovered):
        (.metrics .content):
        (.metrics .content.hovered):
        * inspector/front-end/inspector.js:
        (WebInspector.highlightDOMNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-21 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 21 Apr 2011 09:39:06 +0000 (09:39 +0000)]
2011-04-21  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, GTK baselines for
        http/tests/security/contentSecurityPolicy tests that don't escape
        the quote character.

        * platform/gtk/http/tests/security/contentSecurityPolicy/report-uri-expected.txt: Added.
        * platform/gtk/http/tests/security/contentSecurityPolicy/report-uri-from-child-frame-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Missing eventSender.scalePageBy() implementation
ossy@webkit.org [Thu, 21 Apr 2011 08:50:30 +0000 (08:50 +0000)]
[Qt] Missing eventSender.scalePageBy() implementation

* platform/qt/Skipped: Add fast/transforms/selection-bounds-in-transformed-view.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-21 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 21 Apr 2011 08:34:52 +0000 (08:34 +0000)]
2011-04-21  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        CSP report-uri is missing
        https://bugs.webkit.org/show_bug.cgi?id=58639

        Test that report-uri sends a report.  Testing approach stolen from the
        ping tests.

        * http/tests/security/contentSecurityPolicy/report-uri-expected.txt: Added.
        * http/tests/security/contentSecurityPolicy/report-uri.html: Added.
        * http/tests/security/contentSecurityPolicy/resources/echo-report.php: Added.
        * http/tests/security/contentSecurityPolicy/resources/go-to-echo-report.js: Added.
        * http/tests/security/contentSecurityPolicy/resources/save-report.php: Added.
2011-04-21  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        CSP report-uri is missing
        https://bugs.webkit.org/show_bug.cgi?id=58639

        Our implementation of report-uri differs from what's currently in the
        spec.  I sent the working group an email explaining why.  Generally,
        we're using normal form encoding instead of JSON and we're sending less
        information to a wider set of URLs.  Specifically, we send the current
        document's URL as well as the directive that was violated.  The spec
        (currently) tells us to send the raw HTTP headers and the URL that
        caused the violation, but both of these pieces of data could contain
        information that's sensitive, so we omit them for now.

        Test: http/tests/security/contentSecurityPolicy/report-uri.html

        * loader/PingLoader.cpp:
        (WebCore::PingLoader::reportContentSecurityPolicyViolation):
        * loader/PingLoader.h:
        * page/ContentSecurityPolicy.cpp:
        (WebCore::CSPDirective::CSPDirective):
        (WebCore::CSPDirective::text):
        (WebCore::ContentSecurityPolicy::reportViolation):
        (WebCore::ContentSecurityPolicy::allowJavaScriptURLs):
        (WebCore::ContentSecurityPolicy::allowInlineEventHandlers):
        (WebCore::ContentSecurityPolicy::allowInlineScript):
        (WebCore::ContentSecurityPolicy::allowEval):
        (WebCore::ContentSecurityPolicy::allowScriptFromSource):
        (WebCore::ContentSecurityPolicy::allowObjectFromSource):
        (WebCore::ContentSecurityPolicy::allowChildFrameFromSource):
        (WebCore::ContentSecurityPolicy::allowImageFromSource):
        (WebCore::ContentSecurityPolicy::allowStyleFromSource):
        (WebCore::ContentSecurityPolicy::allowFontFromSource):
        (WebCore::ContentSecurityPolicy::allowMediaFromSource):
        (WebCore::ContentSecurityPolicy::parseReportURI):
        (WebCore::ContentSecurityPolicy::addDirective):
        * page/ContentSecurityPolicy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-04-21 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 21 Apr 2011 08:07:53 +0000 (08:07 +0000)]
2011-04-21  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, skip
        fast/transforms/selection-bounds-in-transformed-view.html on GTK as it
        depends on eventSender.scalePageBy().

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84477 268f45cc-cd09-0410-ab3c-d52691b4dbfc